December 2012 - Wine-Devel - list.winehq.org

wine-1.5.20 reversion compared to 1.5.19 and previous; MinGW/gcc 4.7.0 segfaults under wineconsole
by Alan W. Irwin Jan. 2, 2013

Jan. 2, 2013

The subject line pretty much says it all. Running MinGW/gcc under wineconsole for any simple test programme should demonstrate the issue for wine-1.5.20 which is not present in wine-1.5.19 and a fairly large selection of 1.5.x and MinGW versions I have tried over the last year or so. I would be happy to supply more details if there is any difficulty replicating this reversion. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

3 7

Re: xbox 360 emulation with logitech cordless and dinput joy disable
by Stefan Dösinger Jan. 1, 2013

Jan. 1, 2013

Hi, The patch needs a few improvements before it can be accepted into Wine. I can't comment on the dinput / xinput specifics of the patch, so this is a non- exhaustive list of general suggestions. Concerning the big picture, this patch needs a few discussions about xinput.dll design. There have been some discussions about that in the past, and I hope that some dinput devs can help out. Am Dienstag, 12. Juni 2012, 23:48:53 schrieb Giovanni Ongaro: > From: root <root(a)joe.(none)> Please configure git correctly, see http://wiki.winehq.org/GitWine section 3.3. Also consider using a non-root user, but that's your personal setup, so not really my business. > + if (getenv("LINIXFORCENOJOY") != NULL) return FALSE; /*JoeFix disable joystick*/ The problem with dinput vs xinput conflicts should probably be solved in a different manner. That aside, such configurations are usually done via registry keys. Also comments like /* I changed this here */ are useless, the git history stores this information anyway. > + <...> //JoeFix DEAD ZONE This is a C++ comment and not allowed in Wine. See http://wiki.winehq.org/SubmittingPatches > + fdJoy=open("/dev/input/js0",O_RDONLY | O_NONBLOCK); Xinput.dll should not open joystick devices directy, and definitely not a hardcoded one. I don't know if there's consensus about how xinput should be implemented, but basing it on top of dinput might be a start. A good start would be to write a few tests to test how Windows announces(or doesn't announce) Xbox gamepads and other gamepads/joysticks to games. My understanding is that xinput.dll only works for Xbox gamepads. Do those show up in dinput on Windows? > +#define DEAD_ZONE 4096 > ... > + if (e.number == 4) { > + if (e.value == 1) { > + FIXME("TRIGGER LEFT PRESSED\n"); > + pState->Gamepad.bLeftTrigger=32767; > + } > + else { > + pState->Gamepad.bLeftTrigger=0; > + } > ... > +#define JOYMAX 30000 > +#define JOYMIN -30000 The hardcoded numbers look questionable. The 4 and 1 are probably specific to the joystick, the 32767 might have a symbolic name like XINPUT_MAX or something. A part of this seems to be needed due to the attempt to emulate an xbox gamepad with a different device. Personally I'm not opposed to doing that, and you might need some device specific tricks to pull this off. However, this needs a more structured approach than hardcoding the values needed for one specific Logitech device in the code. Best regards, Stefan

3 2

Re: [PATCH] dsound: rework ugly mixer logic
by Andrew Eikum Jan. 1, 2013

Jan. 1, 2013

On Sat, Dec 29, 2012 at 01:24:03AM +0100, Maarten Lankhorst wrote: > + if(!maxq){ > + /* nothing to do! */ > + LeaveCriticalSection(&device->mixlock); > + return; > } This was removed in 8ba4090fc304993. It breaks starting the device in some situations (write primary mode iirc). > + if (native) { > + void *buffer = NULL; > + > + hr = IAudioRenderClient_GetBuffer(device->render, maxq / block, (void*)&buffer); > + if(FAILED(hr)){ > + WARN("GetBuffer failed: %08x\n", hr); > + LeaveCriticalSection(&device->mixlock); > + return; > + } I think this (mixing directly to RenderClient and skipping WaveQueue) could be split into a separate patch. > hres = IAudioClient_Initialize(device->client, > AUDCLNT_SHAREMODE_SHARED, AUDCLNT_STREAMFLAGS_NOPERSIST | > - AUDCLNT_STREAMFLAGS_EVENTCALLBACK, prebuf_rt, 0, device->pwfx, NULL); > + AUDCLNT_STREAMFLAGS_EVENTCALLBACK, 800000, 0, device->pwfx, NULL); ... > + frames = (UINT64)device->pwfx->nSamplesPerSec * 800000 / 10000000; Could you #define the 800000? Anyway, I gave it a test on ALSA+Pulse and didn't find any issues. I'll test the other backends when you resubmit. Andrew

2 3

Mail problems for wine-patches
by Detlef Riekenberg Dec. 31, 2012

Dec. 31, 2012

I send several patches the last days with git and with the webmail interface from web.de, but nothing arrived at the wine-patches archive or the patches queue page. I also unsubscribed and subscribed again to the wine-patches list. Any ideas? Has wine-patches a whitelist? -- By by ... Detlef

2 1

Re: atl100: Fixed NULL catmap handling in AtlRegisterClassCategoriesHelper
by Marvin Dec. 31, 2012

Dec. 31, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23671 Your paranoid android. === WXPPROSP3 (32 bit atl) === Timeout === W2K3R2SESP2 (32 bit atl) === Timeout

1 0

Re: atl100: Fixed NULL catmap handling in AtlRegisterClassCategoriesHelper
by Marvin Dec. 31, 2012

Dec. 31, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23671 Your paranoid android. === WXPPROSP3 (32 bit atl) === Timeout === W2K3R2SESP2 (32 bit atl) === Timeout

1 0

Help Splitting Patches
by Adam Martinson Dec. 31, 2012

Dec. 31, 2012

Looking for some help splitting patch 3, not sure how I can cut it down any more without breaking stuff. I'm guessing patch 9 will need splitting too, same problem. ~Adam

2 1

[AppDB] Cannot submit rejected Test results after change
by Joerg Schiermeier Dec. 30, 2012

Dec. 30, 2012

¡Hola! In AppDB I got a problem, exactly with one of my maintained applications: some days ago someone filed a test about the mail program 'The Bat!'. This test has this URL: <http://appdb.winehq.org/objectManager.php?sClass=version&iId=23662&iTesting…> So AppDB sent me an email about this test and I went to its web interface. There I rejected this test result because of some incorrect version numberings. Than I got some days later a mail about a new submitted test. I logged into AppDB again to my control panel but I didn't saw this new submitted test there. So I had and have no change to commit this test results. If you follow the link above you will see: the test results are still there. So my conclusion: 1.) Someone, maybe you will have to commit this test. 2.) Something went wrong with the AppDB. Thanks for your attention and your help! -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: d3dx9: Implement D3DXSHEvalConeLight [try 4]
by Marvin Dec. 30, 2012

Dec. 30, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23666 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W2K3R2SESP2 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === WVISTAADM (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W2K8SE (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PRO (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PROX64 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === TEST64_W7SP1 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PROX64 (64 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556351 === TEST64_W7SP1 (64 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556351

1 0

Re: [PATCH 2/2] kernel32: conditional variable support
by Nikolay Sivov Dec. 29, 2012

Dec. 29, 2012

On 12/29/2012 23:04, Marcus Meissner wrote: > From: Marcus Meissner <marcus(a)jet.(none)> > > Modeled pretty much after the implementation described > in glibc/nptl/DESIGN-condvar.txt with its futex usage > sofar replaced by regular Win32 Semaphores. > > An additional futex implementation is possible. > > I *think* I have the semantics correct, there is 1 small > place where it might have unnecessary CPU usage though. > > Ciao, Marcus > +/********************************************************************** > + * InitializeConditionVariable (KERNEL32.@) > + */ > +VOID WINAPI InitializeConditionVariable(PCONDITION_VARIABLE variable) > +{ > + struct _condition_var_intern *var; > + variable->Ptr = HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,sizeof(struct _condition_var_intern)); > + var = variable->Ptr; > + if (!var) return; > + InitializeCriticalSection (&var->crit); > + var->crit.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": ConditionVariable.cs"); > +} I don't think it allocates anything at all, what makes me believe that is that stuff like CONDITION_VARIABLE_INIT exists. After googling a bit for it I see that gallium from mesa has some platform dependent stuff in code that uses this API like that: --- +#define pipe_static_condvar(cond) \ + /*static*/ pipe_condvar cond = CONDITION_VARIABLE_INIT --- So this structure has nothing more than a single pointer value, value 0 of it means it's initialized. I think you could just add some tests to see if it's really reset to 0 from initial value. Also regarding tests I don't think randomizing timeouts is a good idea cause it adds some unpredictable behaviour and it's not really clear if we could rely on such tests results.

2 2