February 2012 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Wine automated testing update
by Jeremy White Aug. 6, 2012

Aug. 6, 2012

Hi Folks, At the last Wine conference, I volunteered to find a home for the WineTestBot that Ge's brother has been hosting, and to take over the Buildbot that Dan and Austin have been so diligently maintaining. This is an update on that project, mostly to help keep my procrastinating self moving it along. First, we have a lovely set of hardware; 4 servers, in a dedicated rack, with a dedicated static ip to the outside world. One server is the gateway, 2 are dedicated Linux test systems (with nice fast processor + gpus), and one is a beefy system capable of running many VMs. The plan was to move the existing VMWare based WineTestBot to this hardware and simply get the existing system up and running on the new hardware. Here we hit our first snag; the VMWare folks are not willing to provide a permanent license for VMWare to us. So, we've shifted gears, and are exploring whether something like qemu + kvm would be a sufficient alternate. I've done a little of this work, and Maarten is hopefully going to help me try converting the existing VMs to see if we can save any hassle by doing a conversion. In parallel, I learned a great deal about buildbot and the buildbot system that Dan has built. There are two especially valuable and useful functions provided by this buildbot: the first is essentially a patch watcher; a process that catches simple mistakes (e.g. build errors on different architectures, and so on). The second is more powerful and is encapsulated by the 'dotests.sh' shell script. The dotests.sh script does a good job of basically running make test and noticing any test failures outside of 'the usual ones'. There is an infrastructure for Buildbot is a good tool, and I invested a lot of energy into it (as have Dan and Austin). However, Alexandre has persuaded me that we should first explore integrating the dotest.sh functionality into the existing WineTestBot, as that would allow us to have a very simple clean web page, and would also allow us to integrate most cleanly with Alexandre's back end tools. Of course, WineTestBot is Perl code, and my Perl fu is low. So I have recently asked Francois to help with that effort as well. So the basic plan is as follows: 1. Test qemu/kvm with a few Windows versions to see if it'll work. 2. If so, modify WineTestBot to use qemu instead of vmware. (This is 'easy' because the WineTestBot code nicely isolates the VM functions, but 'hard', because VMWare provides some APIs that may have to be replicated). 3. Migrate WineTestBot to the new hardware stack 4. Write new code to run 'dotests.sh' as part of WineTestBot Cheers, Jeremy

9 11

Rethinking WineConf
by Jeremy White July 26, 2012

July 26, 2012

Hi All, This past Wine conference, while great fun as always, was not as well attended as Wine conferences in the past. So I would like to stir up trouble by suggesting we rethink WineConf. For those that have not attended, the Wine conference has been a mostly annual affair since 2002. It is open to all, but is advertised as being aimed at Wine developers. About 35 people attend each year. It's been in Minnesota about every 3rd year, and is otherwise 'normally' somewhere in Europe. I see the primary goal as creating human bonds between otherwise anonymous people (aka going to the pub). It's a bonus if it also spurs resolution to tricky issues, or motivates people to get more done. So I'd like to ask folks to brain storm with me. How could Wineconf be different? If you've never been, what would encourage you to come? If you've been to a technical conference recently that you thought was well done, what did they do well? Anything we could emulate? Any other ideas, or suggestions? Cheers, Jeremy

17 25

Spelling errors in en_US translation
by Julian Rüger March 26, 2012

March 26, 2012

Hi Francois, (and everybody else ;) are there any plans to create an ignore-list for these: http://fgouget.free.fr/wine-po/en_US.spell.html to be able to distinguish real typos from false positives? Most reported errors are false positives (like "codec" or "checksum") but there are real errors, or at least instances of uncommon spelling (like "customising", which is British English afaik, or "Cancelled") which should be fixed (after 1.4), imho. Best regards, Julian

2 3

wineapploader in wine64
by Michael Ost March 11, 2012

March 11, 2012

Hi, Any explanation for why the wineapploader script doesn't use 'wine64' instead of 'wine' in a 64bit Linux with 64bit wine? That's the script that is used to build /usr/bin/wineboot and /usr/bin/regedit, for instance. In Fedora 15 with wine 1.3.24, the upshot is that the 'wineboot' command doesn't work. /usr/lib/wine/wineboot.exe.so is not installed; only /usr/lib64/wineboot.exe.so is. Since the /usr/bin/wineboot is running 'wine' instead of 'wine64' it is looking for the 32bit /usr/lib/wine/wineboot.exe.so. It can't be found since it isn't installed so the loader gives up. > $ wineboot > wine: cannot find L"C:\\windows\\system32\\wineboot.exe" If it used wine64 instead, it would work. There must be a reason that wine64 is starting 32bit apps, but I haven't been able to glean anything from the web. Thanks for any info, -- Michael Ost

4 6

Web based translation tool
by Miroslav Suchý March 11, 2012

March 11, 2012

Hi, I just read: http://www.winehq.org/news/2012022001 and then http://wiki.winehq.org/Translating especially: > The Wine project would be very interested in making its PO files available on web-based community translations systems such as Pootle or Launchpad. Our hope is that this would make translating Wine even easier and engage new translators. > > The reason why it has not happened yet is that all Wine contributions, including for translations, must be attributable to a specific author and that these tools don't make that possible yet. For more details see the wine-devel discussion here and here. Any contributions that would solve this issue would be very welcome. which refer: http://www.winehq.org/pipermail/wine-devel/2012-January/093908.html I would like to point you to: https://www.transifex.net/ which can do the tracking. Latest version is probably not what you want, because it just add at the top of the file: # Translators: # Martin Minar <skulliq(a)gmail.com>, 2011. # Milan Kerslager <kerslage(a)linux.cz>, 2002, 2007. # Miloslav Trmac <mitr(a)volny.cz>, 2002. # Miroslav Suchý <msuchy(a)redhat.com>, 2011. msgid "" msgstr "" "Project-Id-Version: Spacewalk\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2011-12-21 13:07+0100\n" "PO-Revision-Date: 2011-12-14 09:21+0000\n" "Last-Translator: Miroslav Suchý <msuchy(a)redhat.com>\n" "Language-Team: Czech (http://www.transifex.net/projects/p/fedora/team/cs/)\n So you had overview of contributors, but you could not tell which one contributor done which string. But version 0.7 (IIRC) sent each contribution immediately to git. Under login (and email) of that contributor. That contributor was "Author" and commiter was some transifex user. So this way you allow git commit access to those contributors directly to git, but since it goes via that web interface, they could commit only to /po/ directory and even only to language, for which they had been granted. You can download it here: http://trac.transifex.org/files/ and setup your own instance. If is sufficient for you only tracking name of contributors, you can use that hosted solution at: https://www.transifex.net/ -- Miroslav Suchy Red Hat Satellite Engineering

4 5

Re: Hungarian translation patch 2
by Francois Gouget March 1, 2012

March 1, 2012

Thanks. That first patch made quite a big difference already. Hungarian is now in the 90% range :-) I noticed some issues though: -#, fuzzy msgid "&Modify/Remove" msgstr "&Módosítás/Eltávolítás..." You should remove the ellipsis here. msgctxt "Saturation" msgid "&Sat:" -msgstr "" +msgstr "&Telítettség:" msgctxt "Luminance" msgid "&Lum:" -msgstr "" +msgstr "&Fényerő" These two may be too long, hence why they are truncated in English. You can check in winecfg. Go to Desktop Integration, pick an Item, click on Color and click on Define Custom Colors. They should also have a trailing colon. msgctxt "All key" msgid "A" -msgstr "" +msgstr "A" Given that 'All' is translated into 'Mind', this should most likely be an 'M'. -#, fuzzy msgid "Certificate &status:" -msgstr "Tanusítvány beszerzés" +msgstr "Tanusítvány &állapot" -#, fuzzy msgid "&Friendly name:" msgstr "Keresztnév" More missing colons... Also the second one looks like it's supposed to have a keyboard shortcut. msgid "Connection is active.\n" -msgstr "Kapcsolat aktív" +msgstr "Kapcsolat aktív\n" This one should probably have a trailing full stop. You'll find more issues like this on the Wine PO site. http://fgouget.free.fr/wine-po/ Specifically: http://fgouget.free.fr/wine-po/hu-errors.html -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ La terre est une bêta...

2 4

Re: [PATCH] winepulse: Add pulse driver, v8
by Joerg-Cyril.Hoehle＠t-systems.com March 1, 2012

March 1, 2012

Hi, Chris is right about the format. The shared mode mixer ought to return FLOAT(32), and it always appears to return the extensible format as a consequence. For weird reasons, wineoss may return integer formats, but that's certainly going to cause some unexpecting app to crash. >+ assert(oldpad >= This->pad); Wasn't there a discussion some time ago that asserts are bad? Better back out, return INVALIDATED or some such, but don't crash the app just because there's a problem with sound. (I agree that winmm&mmdevapi ought to contain self/consistency tests). It would be nice if you could attach some WINETEST_DEBUG=2 render.log 2>&1 to bugzilla somewhere. There is stuff that do not cause a failure yet diverges from native. +static void pulse_wr_callback(pa_stream *s, size_t bytes, void *userdata) + if (This->event) + SetEvent(This->event); This should be the last thing in the callback. It may well cause your thread to be kicked out by the scheduler. + if (filled_one && This->event) + SetEvent(This->event); Don't the capture tests prove that events get in even when the buffer is full? (please cross-check) >- Align buffer size to a multiple of period size How can you pass the tests with that? It's wrong with both capture (annoyingly IMHO) and playback. I don't have more time now (and know nothing about the pa_* API). Is pa_mainloop_run the thread that dispatches the pulse_xyz_callbacks? I wouldn't mind a winepulse driver in 1.4.0 Regards, Jörg

2 3

bugzilla: show the component, not "comp" and not the assignee
by Joerg-Cyril.Hoehle＠t-systems.com March 1, 2012

March 1, 2012

Hi, Somehow I discovered that bugzilla can display the component in a search result list. Now I'm using that instead of the useless "assignee" field. Here's part of the URL I'm using: &columnlist=bug_severity%2Cop_sys%2Ccomponent%2Cbug_status%2Cshort_desc& Unfortunately, the column named "Comp" only holds 8 characters, causing ugly names like: directx- : you don't know which one out of ten directx-YZ winmm&mc : one missing letter looks rather stupid It would be nice if some bugzilla admin would enlarge that column BTW, I recently suggested replacing the mostly useless "assignee" column in the default search result list by the component. No answer. What do you think? Thank you, Jörg Höhle

2 1

Debugging WINE 1.3.24 with GDB
by louis＠museresearch.com Feb. 29, 2012

Feb. 29, 2012

Hi All, I've been attempting to debug a WINElib application on Fedora 15 (WINE 1.3.24) and not having much success. Winedbg works, but using gdb I'm not able to see symbols or multiple threads. In Fedora 8, running GDB on wine-pthreads (and not wine!) used to work under 1.1.7. However, under 1.3.24 there's no wine-pthreads. I've also tried attaching to various threads after the program was running with little success. I'm also not having any success using "winedbg --gdb"-- the same thing happens there as if I'd run it using just gdb (strange). The big picture is that I'd like to get an IDE such as QtCreator or KDevelop to work debugging a WINE application. Any way that is possible would be a good solution for me; it doesn't necessarily have to be through GDB if there's another way. Thanks for your help in advance! -Louis

1 0

Re: po: Spanish translation update for cmd.rc (almost complete)
by Eduardo García Feb. 29, 2012

Feb. 29, 2012

Sorry, attached the wrong patch, this one is the correct one. With regards. Eduardo. El 02/29/12 21:00, Eduardo García escribió: > This one was fun to do as I fouund a couple of "my hovercraft is full > of eels" phrases. > > With regards. > > Eduardo. > > > > >

1 0

Re: po: Spanish translation update for cmd.rc (almost complete)
by Eduardo García Feb. 29, 2012

Feb. 29, 2012

Sorry, attached the wrong patch, this one is the correct. With regards. Eduardo. El 02/29/12 21:00, Eduardo García escribió: > This one was fun to do as I fouund a couple of "my hovercraft is full > of eels" phrases. > > > > > > >

1 0

Re: Fix references to the LGPL
by Alexandre Julliard Feb. 29, 2012

Feb. 29, 2012

Francois Gouget <fgouget(a)free.fr> writes: > So the problem is that start.rc (it's always about start) > contains slightly incorrect references to the LGPL in its license > message (no less): I would say we should get rid of that license message. No other Wine command-line app does this, and we have the license in the about box already for graphical apps. This would also avoid the need for a different usage message in cmd. -- Alexandre Julliard julliard(a)winehq.org

1 0

Major mmdevapi and winmm audio bugs
by Joerg-Cyril.Hoehle＠t-systems.com Feb. 29, 2012

Feb. 29, 2012

Hi, instead of Wine Weekly News (WWN, any taker?) you get monthly audio news. The surprising thing is: it looks like most audio bugs remaining in bugzilla are from the pre-mmdevapi era and have not been updated since mid-2011. - Using devices other than "default" (dmix or pulse): #29294 no sound with ALSA loopback -- are they duplicates of each other #28781 loopback to Jack -- or is one about DSound only? We have are several issues about crackling sound: - One definitely is caused by CreateTimerQueue which is not regular enough or does not deliver 10ms, but 12ms callbacks. This is in #28723 which includes a work-around in comment #130 That may affect the Solaris machine on test.winehq.org too. - One is caused by a mmdevapi design error: the audio buffer we use is simply too small, and Linux can't bear a regular 10ms rate. Things got worse since the introduction of the Completely Fair Scheduler. It can't even guarantee a regular 50ms one. There's a need for a much larger buffer. That's why wine < 1.3.25 is giving steadier sound. #29531 may be caused by this. - Mac OS X 10.5.8 crackles constantly with dlls/mmdevapi/tests/render I'd like somebody with 10.6 or .7 to perform the interactive test. rm -f render.ok; WINETEST_INTERACTIVE=1 make render.ok - Lastly, there's PulseAudio #28856 among others I don't understand why I couldn't find bugs in PA's bugzilla, so I wrote some: - https://bugs.freedesktop.org/show_bug.cgi?id=46296 About the need to restart the PA server from time to time - https://bugs.freedesktop.org/show_bug.cgi?id=46297 PA's huge buffering causes issues with winmm - https://bugs.freedesktop.org/show_bug.cgi?id=46412 How to obtain PA's typical 44100 rate? Feel free to contribute if you know apps outside Wine with similar issues. Surprisingly, users have reported improvements in the latest wine-1.4rcX even when nothing changed, but also mentioned updates on the PA and alsa_plugins side. Perhaps that improved the situation. I was pleased to see Wine's testsuite help find bugs in Pulse: http://lists.freedesktop.org/archives/pulseaudio-discuss/2012-February/0128… There are issues not always associated with a bug entry: - #29472 comment #12 DSound GetDevicePosition is not how it should be - Check OSS4 with and without vmix #28056 #28790 - winmm handling huge latency (such as PA's) & when to send notifications - Issues with microphone capture? - DSound mixing and buffer sizes & padding vs. GetPosition - Deal with intermittent errors from ALSA etc. in mmdevapi, winmm and dsound - Device enumeration and PA preventing access to the underlying device Is this known to cause no sound in an app (or only in our wave tests?) - various missing trailing sound with DSound #21209 - #29369 strange issue involving PA and perhaps messaging - misc. losing sound: #28319 #25164 #28770 - lead-out needed with dmix - Use lock-less design to reduce contention, cf. #29531, comment #7 - multi-channel, 5:1 etc. in mmdevapi and DSound - Bugs in the quartz or winegstreamer area that I don't have on my radar Of course there are more bugs than this. Regards, Jörg Höhle

6 11

Re: gdiplus: Create a GDI brush only when needed.
by Vincent Povirk Feb. 29, 2012

Feb. 29, 2012

This won't work. We create gdi32 brushes for hatch brushes based on temporary bitmaps that won't exist at the time brush_fill_path is called. On Wed, Feb 15, 2012 at 2:44 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > This patch fixes the problem reported in the bug 29894. > --- > dlls/gdiplus/brush.c | 19 ------------------- > dlls/gdiplus/gdiplus_private.h | 1 - > dlls/gdiplus/graphics.c | 13 ++++++++++++- > 3 files changed, 12 insertions(+), 21 deletions(-) > > diff --git a/dlls/gdiplus/brush.c b/dlls/gdiplus/brush.c > index d1af903..e0c400e 100644 > --- a/dlls/gdiplus/brush.c > +++ b/dlls/gdiplus/brush.c > @@ -55,7 +55,6 @@ GpStatus WINGDIPAPI GdipCloneBrush(GpBrush *brush, GpBrush **clone) > > memcpy(*clone, brush, sizeof(GpSolidFill)); > > - (*clone)->gdibrush = CreateBrushIndirect(&(*clone)->lb); > fill->bmp = ARGB2BMP(fill->color); > break; > } > @@ -123,8 +122,6 @@ GpStatus WINGDIPAPI GdipCloneBrush(GpBrush *brush, GpBrush **clone) > > memcpy(dest, src, sizeof(GpLineGradient)); > > - dest->brush.gdibrush = CreateSolidBrush(dest->brush.lb.lbColor); > - > count = dest->blendcount; > dest->blendfac = GdipAlloc(count * sizeof(REAL)); > dest->blendpos = GdipAlloc(count * sizeof(REAL)); > @@ -142,7 +139,6 @@ GpStatus WINGDIPAPI GdipCloneBrush(GpBrush *brush, GpBrush **clone) > GdipFree(dest->blendpos); > GdipFree(dest->pblendcolor); > GdipFree(dest->pblendpos); > - DeleteObject(dest->brush.gdibrush); > GdipFree(dest); > return OutOfMemory; > } > @@ -295,7 +291,6 @@ GpStatus WINGDIPAPI GdipCreateHatchBrush(HatchStyle hatchstyle, ARGB forecol, AR > (*brush)->brush.lb.lbStyle = BS_PATTERN; > (*brush)->brush.lb.lbColor = 0; > (*brush)->brush.lb.lbHatch = (ULONG_PTR)hbmp; > - (*brush)->brush.gdibrush = CreateBrushIndirect(&(*brush)->brush.lb); > > DeleteObject(hbmp); > } > @@ -307,7 +302,6 @@ GpStatus WINGDIPAPI GdipCreateHatchBrush(HatchStyle hatchstyle, ARGB forecol, AR > (*brush)->brush.lb.lbStyle = BS_SOLID; > (*brush)->brush.lb.lbColor = fgcol; > (*brush)->brush.lb.lbHatch = 0; > - (*brush)->brush.gdibrush = CreateBrushIndirect(&(*brush)->brush.lb); > } > > if (stat == Ok) > @@ -351,7 +345,6 @@ GpStatus WINGDIPAPI GdipCreateLineBrush(GDIPCONST GpPointF* startpoint, > (*line)->brush.lb.lbStyle = BS_SOLID; > (*line)->brush.lb.lbColor = col; > (*line)->brush.lb.lbHatch = 0; > - (*line)->brush.gdibrush = CreateSolidBrush(col); > (*line)->brush.bt = BrushTypeLinearGradient; > > (*line)->startpoint.X = startpoint->X; > @@ -387,7 +380,6 @@ GpStatus WINGDIPAPI GdipCreateLineBrush(GDIPCONST GpPointF* startpoint, > { > GdipFree((*line)->blendfac); > GdipFree((*line)->blendpos); > - DeleteObject((*line)->brush.gdibrush); > GdipFree(*line); > *line = NULL; > return OutOfMemory; > @@ -624,7 +616,6 @@ GpStatus WINGDIPAPI GdipCreatePathGradient(GDIPCONST GpPointF* points, > (*grad)->brush.lb.lbColor = col; > (*grad)->brush.lb.lbHatch = 0; > > - (*grad)->brush.gdibrush = CreateSolidBrush(col); > (*grad)->brush.bt = BrushTypePathGradient; > (*grad)->centercolor = 0xffffffff; > (*grad)->wrap = wrap; > @@ -719,7 +710,6 @@ GpStatus WINGDIPAPI GdipCreatePathGradientFromPath(GDIPCONST GpPath* path, > (*grad)->brush.lb.lbColor = col; > (*grad)->brush.lb.lbHatch = 0; > > - (*grad)->brush.gdibrush = CreateSolidBrush(col); > (*grad)->brush.bt = BrushTypePathGradient; > (*grad)->centercolor = 0xffffffff; > (*grad)->wrap = WrapModeClamp; > @@ -753,7 +743,6 @@ GpStatus WINGDIPAPI GdipCreateSolidFill(ARGB color, GpSolidFill **sf) > (*sf)->brush.lb.lbColor = col; > (*sf)->brush.lb.lbHatch = 0; > > - (*sf)->brush.gdibrush = CreateSolidBrush(col); > (*sf)->brush.bt = BrushTypeSolidColor; > (*sf)->color = color; > (*sf)->bmp = ARGB2BMP(color); > @@ -898,7 +887,6 @@ GpStatus WINGDIPAPI GdipCreateTextureIA(GpImage *image, > (*texture)->brush.lb.lbColor = 0; > (*texture)->brush.lb.lbHatch = (ULONG_PTR)hbm; > > - (*texture)->brush.gdibrush = CreateBrushIndirect(&(*texture)->brush.lb); > (*texture)->brush.bt = BrushTypeTextureFill; > (*texture)->image = new_image; > > @@ -1036,7 +1024,6 @@ GpStatus WINGDIPAPI GdipDeleteBrush(GpBrush *brush) > break; > } > > - DeleteObject(brush->gdibrush); > GdipFree(brush); > > return Ok; > @@ -1578,9 +1565,6 @@ GpStatus WINGDIPAPI GdipSetPathGradientCenterColor(GpPathGradient *grad, > grad->centercolor = argb; > grad->brush.lb.lbColor = ARGB2COLORREF(argb); > > - DeleteObject(grad->brush.gdibrush); > - grad->brush.gdibrush = CreateSolidBrush(grad->brush.lb.lbColor); > - > return Ok; > } > > @@ -1775,9 +1759,6 @@ GpStatus WINGDIPAPI GdipSetSolidFillColor(GpSolidFill *sf, ARGB argb) > sf->color = argb; > sf->brush.lb.lbColor = ARGB2COLORREF(argb); > > - DeleteObject(sf->brush.gdibrush); > - sf->brush.gdibrush = CreateSolidBrush(sf->brush.lb.lbColor); > - > return Ok; > } > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 9afe15b..b597511 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -170,7 +170,6 @@ struct GpGraphics{ > }; > > struct GpBrush{ > - HBRUSH gdibrush; > GpBrushType bt; > LOGBRUSH lb; > }; > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 65a3815..35aa504 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -723,10 +723,21 @@ static void brush_fill_path(GpGraphics *graphics, GpBrush* brush) > /* else fall through */ > } > default: > - SelectObject(graphics->hdc, brush->gdibrush); > + { > + HBRUSH gdibrush, old_brush; > + > + if (brush->lb.lbStyle == BS_SOLID) > + gdibrush = CreateSolidBrush(brush->lb.lbColor); > + else > + gdibrush = CreateBrushIndirect(&brush->lb); > + > + old_brush = SelectObject(graphics->hdc, gdibrush); > FillPath(graphics->hdc); > + SelectObject(graphics->hdc, old_brush); > + DeleteObject(gdibrush); > break; > } > + } > } > > static INT brush_can_fill_pixels(GpBrush *brush) > -- > 1.7.8.4 > > >

2 3

Re: [PATCH] wined3d: Do not use double-buffered dynamic buffers (try 2)
by Henri Verbeet Feb. 29, 2012

Feb. 29, 2012

On 29 February 2012 11:12, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > try 2: Invalidate the index buffer state as well, as the buffer might be > an index buffer. > > Otherwise unmodified reesend after the discussion from yesterday. This > is for bugs 29079, 29897(suspected) and 30019. > I guess I didn't explicitly say it yesterday, but I think this should be deferred and fixed properly after 1.4. While in principle dropping VBOs might be ok as a temporary fix for the release, the vertex / index buffer code is pretty fragile in general, and I can't guarantee that this won't introduce more regressions than it fixes.

2 2

Re: [PATCH] winepulse: Add pulse driver, v8
by Chris Robinson Feb. 29, 2012

Feb. 29, 2012

On Tuesday, February 28, 2012 5:32:13 PM Maarten Lankhorst wrote: > + * This is basically the same as the pa_threaded_mainloop implementation, > + * but that cannot be used because it uses pthread_create directly > + * > + * pa_threaded_mainloop_(un)lock -> pthread_mutex_(un)lock > + * pa_threaded_mainloop_signal -> pthread_cond_signal > + * pa_threaded_mainloop_wait -> pthread_cond_wait I'm curious why you're using pthreads. Doesn't WinAPI have anything comparable to pthread_cond_wait? > +static void pulse_probe_settings(void) { ... > + ret = pa_stream_connect_playback(stream, NULL, &attr, > + PA_STREAM_START_CORKED|PA_STREAM_FIX_RATE|PA_STREAM_FIX_FORMAT|PA_S > TREAM_FIX_CHANNELS|PA_STREAM_EARLY_REQUESTS, NULL, NULL); Is it necessary to fix the format? MSDN says that the audio service always works with floating-point, and GetMixFormat always specified floating-point in my dealings with it. I don't think it should blindly return whatever PulseAudio does, unless it can be shown that Windows doesn't always give floating-point. > +static WAVEFORMATEX *clone_format(const WAVEFORMATEX *fmt) > +{ > + WAVEFORMATEX *ret; > + size_t size; > + > + if (fmt->wFormatTag == WAVE_FORMAT_EXTENSIBLE) > + size = sizeof(WAVEFORMATEXTENSIBLE); > + else > + size = sizeof(WAVEFORMATEX); > + > + ret = HeapAlloc(GetProcessHeap(), 0, size); This should probably use CoTaskMemAlloc, as it's used for IsFormatSupported. I'm also curious if IsFormatSupported should always return a WAVE_FORMAT_EXTENSIBLE object. > +static enum pa_channel_position pulse_map[] = { This should probably be const. > + if (fmt->wFormatTag == WAVE_FORMAT_IEEE_FLOAT) > + This->ss.format = PA_SAMPLE_FLOAT32LE; ... > + if (IsEqualGUID(&wfe->SubFormat, &KSDATAFORMAT_SUBTYPE_IEEE_FLOAT)) > + This->ss.format = PA_SAMPLE_FLOAT32LE; You likely should check that the format specifies 32 bits, and not 64 or something different like that. This isn't an all-inclusive lookover, just some things that caught my eye. Also, does this driver fail to load if it can't connect to a pulse server?

3 2

RFT: Use Greek semicolons for comdlg32's printer status enumeration?
by Francois Gouget Feb. 29, 2012

Feb. 29, 2012

Request For Translators<g> So what I've gathered from Wikipedia is that the Greek language does not use semicolons as a separator for enumerations: http://en.wikipedia.org/wiki/Semicolon#Greek_and_Church_Slavonic | In Greek and Church Slavonic, a semicolon indicates a question, | similar to a Latin question mark.[2] To indicate a long pause or | separate sections, each with commas (the semicolon's purpose in | English), Greek uses an ano teleia ( · ). Wine uses semicolons as a separator in one place, for comdlg32's printer status enumeration. It's a list of status indicators separated by semicolons and looks like this: Error; Paper jam; or Initialising; Default Printer; I/O Active; So I would expect the Greek translation to use ano teleia characters as the separator but instead it uses plain semicolons: msgid "Paused; " msgstr "Σταματημένος; " msgid "Error; " msgstr "Σφάλμα; " msgid "Busy; " msgstr "Απασχολημένος; " So I'm hoping some Greek-speaking Wine hacker or user can enlighten me on the following points: * Did I understand Wikipedia wrong? Do both English semicolons and question marks translate to a semicolon in Greek? * Is this a special case that justifies not following the standard rule? If so why? * Does the attached patch replacing semicolons with ano teleia characters make sense? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

2 3

Remove an obsolete string chunk fom the Swedish translation?
by Francois Gouget Feb. 29, 2012

Feb. 29, 2012

This translation seems to have an extra example which is not present in the English string. Would it be ok to remove it? msgid "" "MOVE relocates a file or directory to a new point within the file system.\n" "\n" "If the item being moved is a directory then all the files and " "subdirectories\n" "below the item are moved as well.\n" "\n" "MOVE fails if the old and new locations are on different DOS drive letters.\n" msgstr "" "MOVE flyttar en fil eller mapp till ett nytt ställe inom filsystemet.\n" "\n" "Om du flyttar på en mapp, så flyttas allting under mappen med.\n" "\n" "MOVE misslyckas om den gamla och det den nya stället är på olika\n" "DOS-enhetsbokstäver. Till exempel från C: till D:.\n" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

1 0

Re: doc: Update Italian README
by Frédéric Delanoy Feb. 29, 2012

Feb. 29, 2012

2012/2/28 Luca Bennati <lucak3(a)gmail.com>: > I tried converting README.it to UTF8, instead of the current Extended ASCII, > which works really bad on my system. > However, it does not seems like Git caught this change: could this be done > manually? I applied the patch manually and it seems the conversion went fine. Maybe there were some accentuated letters already. (hint: 'iconv' can be useful for those kind of conversions, or a save with your favorite editor) BTW, -6. ESEGUIRE I PROGRAMMI +6. RUNNING PROGRAMS seems wrong... Frédéric

2 1

Re: [PATCH] README: updated Linux and FreeBSD kernels
by Francois Gouget Feb. 29, 2012

Feb. 29, 2012

On Wed, 22 Feb 2012, Marcus Meissner wrote: > --- > README | 13 ++++++------- > 1 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/README b/README > index baa6ab3..0cbb047 100644 > --- a/README > +++ b/README > @@ -29,7 +29,7 @@ especially the wealth of information found at http://www.winehq.org. > To compile and run Wine, you must have one of the following: > > Linux version 2.0.36 or above > - FreeBSD 6.3 or later > + FreeBSD 8.0 or later [...] > FreeBSD info: > - Wine will generally not work properly on versions before FreeBSD > - 6.3 or 7.0, and FreeBSD 6.3 has additional patches available. See > - http://wiki.freebsd.org/Wine for more information. > + Wine will generally not work properly on versions before FreeBSD 8.0. > + See http://wiki.freebsd.org/Wine for more information. Is there a reason why Wine won't work right on FreeBSD 7.0? Winetest seems mostly ok. http://test.winehq.org/data/f43f37d3613db57c732196f88e1225191cd62c30/index_… -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ It really galls me that most of the computer power in the world is wasted on screen savers. Chris Caldwell from the GIMPS project http://www.mersenne.org/prime.htm

2 1

Re: [PATCH] winepulse: Add pulse driver, v8
by Dmitry Timoshkov Feb. 28, 2012

Feb. 28, 2012

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > >From 8aa5903b1ee75a6c538d7e1d99560bcb39a47ed2 Mon Sep 17 00:00:00 2001 > From: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> > Date: Thu, 28 Apr 2011 09:45:18 +0200 > Subject: [PATCH 10/10] winepulse: Add pulse driver, v8 You forgot to fix the date, 1 Apr would be more appropriate I'd guess. -- Dmitry.

2 1

Re: [PATCH 1/4] ddraw: Make D3DVBCAPS_WRITEONLY vertex buffers dynamic
by Henri Verbeet Feb. 28, 2012

Feb. 28, 2012

On 28 February 2012 12:19, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This is for bug 30019. > > Out ddraw.dll forwards DDLOCK_DISCARDCONTENTS and DDLOCK_NOOVERWRITE to > wined3d, but wined3d ignores those flags because we never set > WINED3DUSAGE_DYNAMIC. D3d7 docs refer to D3DVBCAPS_WRITEONLY as the flag > to set when creating a buffer, so translate it to DYNAMIC | WRITEONLY. > > An argument could be made that we should set the DYNAMIC flag on all > d3d7 buffers, but until I see a game that needs it I prefer to keep > non-D3DVBCAPS_WRITEONLY buffers regular buffers. I don't see why WRITEONLY should imply DYNAMIC. Setting it for all ddraw buffers may make sense, but even then I'd like to hear a somewhat more convincing argument that now is the right time to change this.

2 3

Re: [PATCH 2/4] wined3d: Do not use double-buffered dynamic buffers
by Henri Verbeet Feb. 28, 2012

Feb. 28, 2012

On 28 February 2012 12:19, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This is for bug 30019. > > They are a lot slower than using no VBO at all in at least some, if not all > games. The reason for the slowdown is the memcpy call, not the buffer > map. I don't find this all that convincing either. My impression is that the reason we have these kinds of problems is mostly that the buffer conversion code is broken. I don't think there are legitimate cases where not creating a VBO should improve performance.

2 3

Re: A small cs.po file update
by Francois Gouget Feb. 28, 2012

Feb. 28, 2012

On Mon, 27 Feb 2012, David wrote: > Hello. > > There is attached a small cs.po update. Gzipped. Generated using > winepo. More is coming. I am planning to update it all. Last will be > translation of certificates/encryption strings. Thanks for the translation update. Unfortunately the tool you used to edit the PO file converted all the line ends from LF to CR+LF. The resulting diff was not so small as it contained the whole file twice. I have cleaned it up and rediffed it for this time (and I'll try to modify winepo to detect this). Some notes about the patch: -#, fuzzy msgid "&Modify..." msgstr "Z&měnit" msgid "&Install" -msgstr "&Instalovat" +msgstr "Na&instalovat..." The ellipses don't match here. Ellipses are very important because, for instance, they make all the difference between a 'Print' button that will send the page to the default printer right away, and a 'Print...' button that will first display a dialog that will let you choose the destination printer or cancel before anything happens. These look like th eonly two issues so things are looking pretty good. msgid "" "Is '%1' a filename or directory\n" "on the target?\n" "(F - File, D - Directory)\n" msgstr "" "Je '%1' název souboru nebo adresáře\n" "v cíli?\n" "(F - Soubor, D - Adresář)\n" It would probably be more intuitive for users if you change the 'shortcut keys': "(S - Soubor, A - Adresář)\n" And then modify the two other corresponding translations: msgctxt "File key" msgid "F" msgstr "S" msgctxt "Directory key" msgid "D" msgstr "A" -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A black hole is just God dividing by zero.

1 0

Re: po: zh_TW translation updates
by Francois Gouget Feb. 28, 2012

Feb. 28, 2012

On Mon, 27 Feb 2012, Hin-Tak Leung wrote: [...] > - some of the changes are over-eager: i.e. it "improves" on windows > and tried to be more user-friendly, but not exactly how windows does > it. > > I think there should be a notes on the translation FAQ: one is not > looking to be "better than" windows, but bug-for-bug-compatible. > Therefore translation is preferably what regional/localized windows > (whatever version) does. > > 20% of the world's population is Chinese, I am sure it is easy enough > to do a few screenshots of localized windows (be in traditional or > simplied) and show how those behave. > > There is a definitive answer (or "definition answers") to most of > these translation strings: what localized windows (some version) does. > It is not up to individual or group opinions, really. I mean, public > libraries, etc have windows in the far east, there is no excuse to be > wrong, or on the opposite extreme, "try to improve on windows", even > if one does not want to get one's hand dirty and own a windows box. The dialog labels and error messages are an area where we don't need to and don't want to be word for word identical to Windows. We should definitely follow the Windows User Experience Interaction Guidelines: http://msdn.microsoft.com/en-us/library/aa511258.aspx The Windows GUI is certainly be a valuable resource to determine which terms the users are going to be familiar with (e.g. will they more readily understand 'directory' or 'folder'). That said Wine runs on Linux and Mac OS X so Wine's users will likely be somewhat accustomed to the terms used by these platforms too. But in any case blindly copying all the strings from the Windows GUI would be a very bad idea. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ $live{free} || die "";

2 2

Translators wanted!
by Francois Gouget Feb. 28, 2012

Feb. 28, 2012

I feel that we should put out a call for translators to the wider community. In preparation for that I updated the Wiki's Translating page and added a winepo script to help translators who don't want to check out the whole Wine source: http://wiki.winehq.org/Translating Here's the proposed news message for the website: > Translators wanted! > > Wine is looking for translators for the 1.4 release! > > Wine's translation <a href="http://fgouget.free.fr/wine-po/">status > page</a> shows only 12 complete translations. We'd like to do better > for 1.4. > > Luckily, starting with 1.4 Wine uses PO files, thus making > translations easier than ever before. So check out how to <a > href="http://wiki.winehq.org/Translating">get started</a> and help us > make Wine usable in your country. And here is the proposed wine-users message: > Wine 1.4 is making good progress. Unfortunately we still have a lot of > translations that are quite incomplete and have no active translators, > thus making Wine unusable in many countries. You track progress on > this page: > > http://fgouget.free.fr/wine-po/ > > As you can see we currently have 12 pretty complete translations and 5 > others that are advanced too. But that still leaves 25 languages > without much, not counting those that are not in the list. This page > also lists some suspected issues that would make easy targets for a > translator short on time. > > The good news is that Wine now uses standard PO files for localization > which makes translation easier than ever before. You even get to > choose between working straight on Wine's source or just editing the > one PO file for your language. So check out the instructions below and > make Wine usable for users in your country! > > http://wiki.winehq.org/Translating Of course if you can help translating Wine, you can also consider this your call to action<g>. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ I haven't lost my mind, it's backed up on tape around here somewhere...

12 29

Re: po: zh_TW translation updates
by Franklin Weng Feb. 28, 2012

Feb. 28, 2012

Hi, I rechecked the translation with old zh_TW.po file. I used Kompare and picked the better one for each entry. I hope that the new patch file is okay and acceptable. I'll post the new patch again later. BTW, the Chinese name (used in Taiwan) of Free Software Foundation is "自由軟體基金會", that's correct. Thanks, Franklin 2012/2/27 Hin-Tak Leung <hintak_leung(a)yahoo.co.uk>: > --- On Mon, 27/2/12, Francois Gouget <fgouget(a)free.fr> wrote: > >> Patches are posted to wine-patches(a)winehq.org: >> http://www.winehq.org/pipermail/wine-patches/2012-February/111804.html > > A quick look at it (it is a few hundred k) - says a few of the problems I saw and suspected: > > - some of the changes are not improvements/corrections but just opinionated changes > > - some changes are wrong (i.e. the older version is more correct/natural and the change makes it worse, not better). > > - some of the changes are over-eager: i.e. it "improves" on windows and tried to be more user-friendly, but not exactly how windows does it. > > I think there should be a notes on the translation FAQ: one is not looking to be "better than" windows, but bug-for-bug-compatible. Therefore translation is preferably what regional/localized windows (whatever version) does. > > 20% of the world's population is Chinese, I am sure it is easy enough to do a few screenshots of localized windows (be in traditional or simplied) and show how those behave. > > There is a definitive answer (or "definition answers") to most of these translation strings: what localized windows (some version) does. It is not up to individual or group opinions, really. I mean, public libraries, etc have windows in the far east, there is no excuse to be wrong, or on the opposite extreme, "try to improve on windows", even if one does not want to get one's hand dirty and own a windows box. > > > >

1 0

Re: msvcrt/file.c: file mode T (temporary file) (try 3)
by Frédéric Delanoy Feb. 28, 2012

Feb. 28, 2012

On Mon, Feb 27, 2012 at 11:23, Robert van Herk <mijnspamboxje(a)hotmail.com> wrote: >> So what actually prevents you from properly implementing this? Especially >> that Wine already supports temporary files. Search for MSVCRT__O_TEMPORARY >> >> Vitaliy. > > I wrote a new version that maps > 'D' -> MSVCRT__O_TEMPORARY, and > 'T' -> MSVCRT__O_SHORT_LIVED | MSVCRT__O_TEMPORARY > > I deliberately included MSVCRT__O_TEMPORARY in 'T': on Windows, when a file > is opened in 'T' mode, a subsequent call to GetFileAttributes(tempfile) show > that the FILE_ATTRIBUTE_TEMPORARY flag is set, so this seemed like to most > sensible thing to do. > > I updated the conformance test such that it checks that the file is actually > deleted after fclose. > > Kind regards, > Robert van Herk You may already be aware of this, but you can request a testbot account to check your patches before submission to wine-patches. See http://testbot.winehq.org/ Frédéric

1 0

Re: Testbot and changes to multiple tests
by Joerg-Cyril.Hoehle＠t-systems.com Feb. 27, 2012

Feb. 27, 2012

Stefan Dösinger wrote: >When I manually submit a patch to the Wine testbot, it refuses to test it if >the patch changes multiple tests. I know that and live with it as follows: - I usually keep changes to separate tests as distinct commits in my git, so I can send them separately to testbot. I merge them just prior to submission to wine-patches. - Alternatively, I edit the patch file in an editor and change it so that only one test file is modified, then edit again, saving the second test. >Why are they refused when I submit them via the testbot web interface? Perhaps to keep the web interface clean? (e.g. page 3 where it's asking you for the command line arguments) Regards, Jörg Höhle

1 0

Re: po: zh_TW translation updates
by Francois Gouget Feb. 27, 2012

Feb. 27, 2012

It's great seeing lots of progress being made on the Taiwanese translation. There are a few changes that look a bit strange to me though: msgid "Theme files (*.msstyles; *.theme)" -msgstr "�Ѿ��}�n�� (*.msstyles��*.theme)" +msgstr "�Ѿ��}�n�� (*.msstyles; *.theme)" msgid "TypeLib files (*.tlb; *.olb; *.dll; *.ocx; *.exe)" -msgstr "TypeLib �n�� (*.tlb��*.olb��*.dll��*.ocx��*.exe)" +msgstr "TypeLib �n�� (*.tlb;*.olb;*.dll;*.ocx;*.exe)" So half width semicolons seem to be preferred to full width ones which is fine to me. But in the first patch it's followed by a space, like in English, and not in the second one which seems inconsistent. msgid "Wine Programs (*.exe; *.exe.so)" -msgstr "Wine ��ʽ (*.exe��*.exe.so)" +msgstr "Wine ��ʽ (*.exe,*.exe.so)" Here the semicolon was replaced by a comma (and no space), which is probably wrong. msgid "Programs (*.exe)" -msgstr "��ʽ (*.exe)" +msgstr "��ʽ(*.exe) " The previous changes all preserved the space before the opening parenthesis. If I add the fact that this introduces a space after the closing parenthesis I'd guess this was unintentional. msgid "Printer files (*.prn)" -msgstr "��ӡ�n�� (*.prn)" +msgstr "��ӡ�n�� (*.PRN)" All other strings of this type use lower case for the extension so I'm not sure about this change. +#, fuzzy msgid "The device door is open.\n" -msgstr "" +msgstr "ӡ��C�w�Ǵ��_��; ��\n" +#, fuzzy msgid "Connection unavailable.\n" -msgstr "" +msgstr "��; ��\n" The combination of the semicolon and full width full stop seems wrong. I suspect the fuzzy translations were from the printer common dialog English strings that ended in a semicolon which escaped removal. msgid "" "This program is free software; you can redistribute it and/or modify it " "under the terms of the GNU Lesser General Public License as published by the " "Free Software Foundation; either version 2.1 of the License, or (at your " "option) any later version." msgstr "" "�@��ʽ��ܛ�w�o��\n" "��ܛ�w�� GNU LGPL 2.1\n" "��°��S�ɗl��޸ĺ��\n" "ɢ��@��ʽ��" This string is not supposed to be explicitly wrapped. Is the wrapping made necessary for Taiwanese because of a Wine bug? msgid "Finished searching the document." -msgstr "�n��ь��Y��" +msgstr "�n��ҽY��." msgid "Failed to load the RichEdit library." -msgstr "RichEdit �d��ʧ��" +msgstr "RichEdit �b�dʧ��." Everywhere else full width full stops are used so this change looks strange to me. msgid "Overwrite %1? (Yes|No|All)\n" -msgstr "" +msgstr "�Ƿ��w %1�� ǣ��ȫ��ǣ�\n" Note that in English the 'Yes' implies one should use the 'Y' key, etc. So this set of strings is tied to the following translations: msgctxt "Yes key" msgid "Y" msgstr "" msgctxt "No key" msgid "N" msgstr "" msgctxt "All key" msgid "A" msgstr "" So depending on the keyboard layout it may be necessary to do something like '��(Y)��(N)��ȫ��(A)��' There's another translation which works the same way, look for "(F - File, D - Directory)" -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

4 5

Re: msvcrt/file.c: file mode T (temporary file) (try 3)
by Marvin Feb. 27, 2012

Feb. 27, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17117 Your paranoid android. === WNT4WSSP6 (32 bit file) === file.c:464: Test failed: File was opened in 'T' mode, but wasn't deleted when closed. === W2KPROSP4 (32 bit file) === file.c:464: Test failed: File was opened in 'T' mode, but wasn't deleted when closed. === WXPPROSP3 (32 bit file) === file.c:464: Test failed: File was opened in 'T' mode, but wasn't deleted when closed. === W2K3R2SESP2 (32 bit file) === file.c:464: Test failed: File was opened in 'T' mode, but wasn't deleted when closed. === WVISTAADM (32 bit file) === file.c:464: Test failed: File was opened in 'T' mode, but wasn't deleted when closed. === W2K8SE (32 bit file) === file.c:464: Test failed: File was opened in 'T' mode, but wasn't deleted when closed. === W7PRO (32 bit file) === file.c:464: Test failed: File was opened in 'T' mode, but wasn't deleted when closed. === W7PROX64 (32 bit file) === file.c:464: Test failed: File was opened in 'T' mode, but wasn't deleted when closed. === TEST64_W7SP1 (32 bit file) === file.c:464: Test failed: File was opened in 'T' mode, but wasn't deleted when closed. === W7PROX64 (64 bit file) === file.c:464: Test failed: File was opened in 'T' mode, but wasn't deleted when closed. === TEST64_W7SP1 (64 bit file) === file.c:464: Test failed: File was opened in 'T' mode, but wasn't deleted when closed.

1 0

Re: ntdll: Fix the file mapping view leak in the case of module loading failure. Take 2.
by Alexandre Julliard Feb. 27, 2012

Feb. 27, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -1548,6 +1549,11 @@ static NTSTATUS load_native_dll( LPCWSTR load_path, LPCWSTR name, HANDLE file, > *pwm = wm; > status = STATUS_SUCCESS; > done: > + if (status) > + { > + if (wm) free_modref( wm ); > + else if (module) NtUnmapViewOfSection( NtCurrentProcess(), module ); > + } I don't see any evidence that you are addressing the issues that caused us to not do that in the first place. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: dsound: Small fixes to IDirectSoundCaptureBuffer
by Andrew Eikum Feb. 27, 2012

Feb. 27, 2012

This patch looks sane and fixes the tests on my machine, but causes no changes to dsound capture behavior in Audacity. I don't have much of an opinion on if it should go in for 1.4. On Tue, Feb 21, 2012 at 05:33:35PM +0100, Maarten Lankhorst wrote: > --- > I suspect a lot more AUDCLNT_E_* calls will have to be mapped > correctly, but at least this is enough to pass the dsound:capture > tests again on wine. > > dlls/dsound/capture.c | 8 +++++--- > dlls/dsound/tests/capture.c | 24 +++++++++++++++--------- > 2 files changed, 20 insertions(+), 12 deletions(-) > > diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c > index 90cddb7..7ceddfc 100644 > --- a/dlls/dsound/capture.c > +++ b/dlls/dsound/capture.c > @@ -456,13 +456,14 @@ static HRESULT WINAPI IDirectSoundCaptureBufferImpl_Start(IDirectSoundCaptureBuf > > EnterCriticalSection(&(This->device->lock)); > > - This->flags = dwFlags; > - TRACE("old This->device->state=%s\n",captureStateString[This->device->state]); > if (This->device->state == STATE_STOPPED) > This->device->state = STATE_STARTING; > else if (This->device->state == STATE_STOPPING) > This->device->state = STATE_CAPTURING; > + else > + goto out; > TRACE("new This->device->state=%s\n",captureStateString[This->device->state]); > + This->flags = dwFlags; > > if (This->device->buffer) > FillMemory(This->device->buffer, This->device->buflen, (This->device->pwfx->wBitsPerSample == 8) ? 128 : 0); > @@ -474,6 +475,7 @@ static HRESULT WINAPI IDirectSoundCaptureBufferImpl_Start(IDirectSoundCaptureBuf > return hres; > } > > +out: > LeaveCriticalSection(&This->device->lock); > > TRACE("returning DS_OK\n"); > @@ -705,7 +707,7 @@ static HRESULT IDirectSoundCaptureBufferImpl_Create( > HeapFree(GetProcessHeap(), 0, This->pdscbd); > This->device->capture_buffer = 0; > HeapFree( GetProcessHeap(), 0, This ); > - return err; > + return err == AUDCLNT_E_UNSUPPORTED_FORMAT ? DSERR_BADFORMAT : err; > } > > err = IAudioClient_GetService(device->client, &IID_IAudioCaptureClient, > diff --git a/dlls/dsound/tests/capture.c b/dlls/dsound/tests/capture.c > index 96fb417..2040f3f 100644 > --- a/dlls/dsound/tests/capture.c > +++ b/dlls/dsound/tests/capture.c > @@ -393,15 +393,18 @@ static void test_capture_buffer(LPDIRECTSOUNDCAPTURE dsco, > ok(ref==0,"IDirectSoundNotify_Release(): has %d references, should have " > "0\n",ref); > > - if (record) { > - rc=IDirectSoundCaptureBuffer_Start(dscbo,DSCBSTART_LOOPING); > - ok(rc==DS_OK,"IDirectSoundCaptureBuffer_Start() failed: %08x\n", rc); > + rc=IDirectSoundCaptureBuffer_Start(dscbo,DSCBSTART_LOOPING); > + ok(rc==DS_OK,"IDirectSoundCaptureBuffer_Start() failed: %08x\n", rc); > + > + rc=IDirectSoundCaptureBuffer_Start(dscbo,0); > + ok(rc==DS_OK,"IDirectSoundCaptureBuffer_Start() failed: %08x\n", rc); > > - rc=IDirectSoundCaptureBuffer_GetStatus(dscbo,&status); > - ok(rc==DS_OK,"IDirectSoundCaptureBuffer_GetStatus() failed: %08x\n", rc); > - ok(status==(DSCBSTATUS_CAPTURING|DSCBSTATUS_LOOPING), > - "GetStatus: bad status: %x\n",status); > + rc=IDirectSoundCaptureBuffer_GetStatus(dscbo,&status); > + ok(rc==DS_OK,"IDirectSoundCaptureBuffer_GetStatus() failed: %08x\n", rc); > + ok(status==(DSCBSTATUS_CAPTURING|DSCBSTATUS_LOOPING), > + "GetStatus: bad status: %x\n",status); > > + if (record) { > /* wait for the notifications */ > for (i = 0; i < (NOTIFICATIONS * 2); i++) { > rc=WaitForMultipleObjects(NOTIFICATIONS,state.event,FALSE,3000); > @@ -416,9 +419,12 @@ static void test_capture_buffer(LPDIRECTSOUNDCAPTURE dsco, > break; > } > > - rc=IDirectSoundCaptureBuffer_Stop(dscbo); > - ok(rc==DS_OK,"IDirectSoundCaptureBuffer_Stop() failed: %08x\n", rc); > } > + rc=IDirectSoundCaptureBuffer_Stop(dscbo); > + ok(rc==DS_OK,"IDirectSoundCaptureBuffer_Stop() failed: %08x\n", rc); > + > + rc=IDirectSoundCaptureBuffer_Stop(dscbo); > + ok(rc==DS_OK,"IDirectSoundCaptureBuffer_Stop() failed: %08x\n", rc); > } > > static BOOL WINAPI dscenum_callback(LPGUID lpGuid, LPCSTR lpcstrDescription, > -- > 1.7.7.6 > > > > >

1 0

Re: ntdll: Fix the file mapping view leak in the case of module loading failure.
by Alexandre Julliard Feb. 27, 2012

Feb. 27, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -1548,6 +1548,8 @@ static NTSTATUS load_native_dll( LPCWSTR load_path, LPCWSTR name, HANDLE file, > *pwm = wm; > status = STATUS_SUCCESS; > done: > + if (status && module) > + NtUnmapViewOfSection( NtCurrentProcess(), module ); It doesn't make sense to free the module as long as we don't free the associated modref. -- Alexandre Julliard julliard(a)winehq.org

1 0

Testbot and changes to multiple tests
by Stefan Dösinger Feb. 27, 2012

Feb. 27, 2012

Hi, When I manually submit a patch to the Wine testbot, it refuses to test it if the patch changes multiple tests. As a workaround I usually test a precompiled .exe and submit it once for each modified test[1]. In the case of the ddraw patch I sent today this missed test failures in 64 bit ddraw[2]. Apparently patches changing multiple tests work just fine when submitted via wine-patches. Why are they refused when I submit them via the testbot web interface? Cheers, Stefan 1: https://testbot.winehq.org/JobDetails.pl?Key=17113 2: https://testbot.winehq.org/JobDetails.pl?Key=17115

1 0

Re: [PATCH 2/2] ddraw/tests: Add pitch alignment tests (try 2)
by Stefan Dösinger Feb. 27, 2012

Feb. 27, 2012

Please ignore this patch for now, it looks like 64 bit ddraw.dll behaves differently. It probably doesn't matter for real games, since they're all 32 bit, but I'll have to investigate this closer. Am Montag, 27. Februar 2012, 12:11:16 schrieb Stefan Dösinger: > This patch is a side product of my attempts to debug bug 21238. It > confirms that the 8 byte aligned pitches are correct for all pools. > > try 2: Don't fail and crash if video memory surfaces are not available > --- > dlls/ddraw/tests/ddraw1.c | 77 ++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw2.c | 81 > ++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw4.c | > 82 +++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw7.c > | 82 +++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 322 > insertions(+), 0 deletions(-) > > diff --git a/dlls/ddraw/tests/ddraw1.c b/dlls/ddraw/tests/ddraw1.c > index 5d0d6da..8fa813b 100644 > --- a/dlls/ddraw/tests/ddraw1.c > +++ b/dlls/ddraw/tests/ddraw1.c > @@ -1121,6 +1121,82 @@ static void test_zenable(void) > DestroyWindow(window); > } > > +static void test_pitch_alignment(void) > +{ > + IDirectDraw *ddraw; > + IDirectDrawSurface *surface; > + HRESULT hr; > + static const struct > + { > + DWORD caps; > + UINT align; > + LONG pitch; > + const char *name; > + } > + pools[] = > + { > + { > + DDSCAPS_OFFSCREENPLAIN | DDSCAPS_VIDEOMEMORY, > + 8, 0, "D3DPOOL_DEFAULT" > + }, > + { > + DDSCAPS_OFFSCREENPLAIN | DDSCAPS_SYSTEMMEMORY, > + 8, 16, "D3DPOOL_SYSTEMMEM" > + }, > + }; > + unsigned int i; > + DDSURFACEDESC ddsd; > + > + if (!(ddraw = create_ddraw())) > + { > + skip("Failed to create a ddraw object, skipping test.\n"); > + return; > + } > + > + hr = IDirectDraw_SetCooperativeLevel(ddraw, NULL, DDSCL_NORMAL); > + ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr); > + > + for (i = 0; i < (sizeof(pools) / sizeof(*pools)); i++) > + { > + memset(&ddsd, 0, sizeof(ddsd)); > + ddsd.dwSize = sizeof(ddsd); > + ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT | > DDSD_PIXELFORMAT; + ddsd.dwWidth = 5; > + ddsd.dwHeight = 5; > + ddsd.ddpfPixelFormat.dwSize = sizeof(ddsd.ddpfPixelFormat); > + ddsd.ddpfPixelFormat.dwFlags = DDPF_RGB; > + U1(ddsd.ddpfPixelFormat).dwRGBBitCount = 16; > + U2(ddsd.ddpfPixelFormat).dwRBitMask = 0xF800; > + U3(ddsd.ddpfPixelFormat).dwGBitMask = 0x07E0; > + U4(ddsd.ddpfPixelFormat).dwBBitMask = 0x001F; > + ddsd.ddsCaps.dwCaps = pools[i].caps; > + > + hr = IDirectDraw_CreateSurface(ddraw, &ddsd, &surface, NULL); > + ok(SUCCEEDED(hr) || hr == DDERR_UNSUPPORTEDFORMAT || hr == > DDERR_NODIRECTDRAWHW, + "%s: Failed to create surface, hr > %#x.\n", pools[i].name, hr); + if (!surface) > + { > + skip("%s: Failed to create surface, skipping pitch alignment > test\n", pools[i].name); + continue; > + } > + > + memset(&ddsd, 0, sizeof(ddsd)); > + ddsd.dwSize = sizeof(ddsd); > + hr = IDirectDrawSurface_GetSurfaceDesc(surface, &ddsd); > + ok(SUCCEEDED(hr), "Failed to get surface desc, hr %#x.\n", hr); > + > + ok(!(ddsd.lPitch & (pools[i].align - 1)), "%s: Pitch %d is not %u > byte aligned.\n", + pools[i].name, ddsd.lPitch, > pools[i].align); > + if (pools[i].pitch) > + ok(ddsd.lPitch == pools[i].pitch, "%s: Expected pitch %d, got > %d.\n", + pools[i].name, pools[i].pitch, ddsd.lPitch); > + > + IDirectDrawSurface_Release(surface); > + } > + > + IDirectDraw_Release(ddraw); > +} > + > START_TEST(ddraw1) > { > test_coop_level_create_device_window(); > @@ -1130,4 +1206,5 @@ START_TEST(ddraw1) > test_coop_level_threaded(); > test_viewport_interfaces(); > test_zenable(); > + test_pitch_alignment(); > } > diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c > index ba8d3b6..348cbfc 100644 > --- a/dlls/ddraw/tests/ddraw2.c > +++ b/dlls/ddraw/tests/ddraw2.c > @@ -1383,6 +1383,86 @@ static void test_zenable(void) > DestroyWindow(window); > } > > +static void test_pitch_alignment(void) > +{ > + IDirectDraw2 *ddraw; > + IDirectDrawSurface *surface1; > + IDirectDrawSurface2 *surface; > + HRESULT hr; > + static const struct > + { > + DWORD caps; > + UINT align; > + LONG pitch; > + const char *name; > + } > + pools[] = > + { > + { > + DDSCAPS_OFFSCREENPLAIN | DDSCAPS_VIDEOMEMORY, > + 8, 0, "D3DPOOL_DEFAULT" > + }, > + { > + DDSCAPS_OFFSCREENPLAIN | DDSCAPS_SYSTEMMEMORY, > + 8, 16, "D3DPOOL_SYSTEMMEM" > + }, > + }; > + unsigned int i; > + DDSURFACEDESC ddsd; > + > + if (!(ddraw = create_ddraw())) > + { > + skip("Failed to create a ddraw object, skipping test.\n"); > + return; > + } > + > + hr = IDirectDraw2_SetCooperativeLevel(ddraw, NULL, DDSCL_NORMAL); > + ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr); > + > + for (i = 0; i < (sizeof(pools) / sizeof(*pools)); i++) > + { > + memset(&ddsd, 0, sizeof(ddsd)); > + ddsd.dwSize = sizeof(ddsd); > + ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT | > DDSD_PIXELFORMAT; + ddsd.dwWidth = 5; > + ddsd.dwHeight = 5; > + ddsd.ddpfPixelFormat.dwSize = sizeof(ddsd.ddpfPixelFormat); > + ddsd.ddpfPixelFormat.dwFlags = DDPF_RGB; > + U1(ddsd.ddpfPixelFormat).dwRGBBitCount = 16; > + U2(ddsd.ddpfPixelFormat).dwRBitMask = 0xF800; > + U3(ddsd.ddpfPixelFormat).dwGBitMask = 0x07E0; > + U4(ddsd.ddpfPixelFormat).dwBBitMask = 0x001F; > + ddsd.ddsCaps.dwCaps = pools[i].caps; > + > + hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface1, NULL); > + ok(SUCCEEDED(hr) || hr == DDERR_UNSUPPORTEDFORMAT || hr == > DDERR_NODIRECTDRAWHW, + "%s: Failed to create surface, hr > %#x.\n", pools[i].name, hr); + if (!surface1) > + { > + skip("%s: Failed to create surface, skipping pitch alignment > test\n", pools[i].name); + continue; > + } > + hr = IDirectDrawSurface_QueryInterface(surface1, > &IID_IDirectDrawSurface2, (void **) &surface); + ok(SUCCEEDED(hr), > "%s: Failed to get DirectDrawSurace2 interface, hr %#x.\n", pools[i].name, > hr); + IDirectDrawSurface_Release(surface1); > + > + memset(&ddsd, 0, sizeof(ddsd)); > + ddsd.dwSize = sizeof(ddsd); > + hr = IDirectDrawSurface2_GetSurfaceDesc(surface, &ddsd); > + ok(SUCCEEDED(hr), "Failed to get surface desc, hr %#x.\n", hr); > + > + ok(!(ddsd.lPitch & (pools[i].align - 1)), "%s: Pitch %d is not %u > byte aligned.\n", + pools[i].name, ddsd.lPitch, > pools[i].align); > + if (pools[i].pitch) > + ok(ddsd.lPitch == pools[i].pitch, "%s: Expected pitch %d, got > %d.\n", + pools[i].name, pools[i].pitch, ddsd.lPitch); > + > + IDirectDrawSurface2_Release(surface); > + } > + > + IDirectDraw2_Release(ddraw); > +} > + > START_TEST(ddraw2) > { > test_coop_level_create_device_window(); > @@ -1394,4 +1474,5 @@ START_TEST(ddraw2) > test_texture_load_ckey(); > test_viewport_interfaces(); > test_zenable(); > + test_pitch_alignment(); > } > diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c > index d9ed90d..c19ba3a 100644 > --- a/dlls/ddraw/tests/ddraw4.c > +++ b/dlls/ddraw/tests/ddraw4.c > @@ -1490,6 +1490,87 @@ static void test_zenable(void) > DestroyWindow(window); > } > > +static void test_pitch_alignment(void) > +{ > + IDirectDraw4 *ddraw; > + IDirectDrawSurface4 *surface; > + HRESULT hr; > + static const struct > + { > + DWORD caps, caps2; > + UINT align; > + LONG pitch; > + const char *name; > + } > + pools[] = > + { > + { > + DDSCAPS_OFFSCREENPLAIN | DDSCAPS_VIDEOMEMORY, 0, > + 8, 0, "D3DPOOL_DEFAULT" > + }, > + { > + DDSCAPS_OFFSCREENPLAIN | DDSCAPS_SYSTEMMEMORY, 0, > + 8, 16, "D3DPOOL_SYSTEMMEM" > + }, > + { > + DDSCAPS_TEXTURE, DDSCAPS2_TEXTUREMANAGE, > + 8, 16, "D3DPOOL_MANAGED" > + } > + }; > + unsigned int i; > + DDSURFACEDESC2 ddsd; > + > + if (!(ddraw = create_ddraw())) > + { > + skip("Failed to create a ddraw object, skipping test.\n"); > + return; > + } > + > + hr = IDirectDraw4_SetCooperativeLevel(ddraw, NULL, DDSCL_NORMAL); > + ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr); > + > + for (i = 0; i < (sizeof(pools) / sizeof(*pools)); i++) > + { > + memset(&ddsd, 0, sizeof(ddsd)); > + ddsd.dwSize = sizeof(ddsd); > + ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT | > DDSD_PIXELFORMAT; + ddsd.dwWidth = 5; > + ddsd.dwHeight = 5; > + U4(ddsd).ddpfPixelFormat.dwSize = sizeof(U4(ddsd).ddpfPixelFormat); > + U4(ddsd).ddpfPixelFormat.dwFlags = DDPF_RGB; > + U1(U4(ddsd).ddpfPixelFormat).dwRGBBitCount = 16; > + U2(U4(ddsd).ddpfPixelFormat).dwRBitMask = 0xF800; > + U3(U4(ddsd).ddpfPixelFormat).dwGBitMask = 0x07E0; > + U4(U4(ddsd).ddpfPixelFormat).dwBBitMask = 0x001F; > + ddsd.ddsCaps.dwCaps = pools[i].caps; > + ddsd.ddsCaps.dwCaps2 = pools[i].caps2; > + > + hr = IDirectDraw4_CreateSurface(ddraw, &ddsd, &surface, NULL); > + ok(SUCCEEDED(hr) || hr == DDERR_UNSUPPORTEDFORMAT || hr == > DDERR_NODIRECTDRAWHW, + "%s: Failed to create surface, hr > %#x.\n", pools[i].name, hr); + if (!surface) > + { > + skip("%s: Failed to create surface, skipping pitch alignment > test\n", pools[i].name); + continue; > + } > + > + memset(&ddsd, 0, sizeof(ddsd)); > + ddsd.dwSize = sizeof(ddsd); > + hr = IDirectDrawSurface4_GetSurfaceDesc(surface, &ddsd); > + ok(SUCCEEDED(hr), "Failed to get surface desc, hr %#x.\n", hr); > + > + ok(!(ddsd.lPitch & (pools[i].align - 1)), "%s: Pitch %d is not %u > byte aligned.\n", + pools[i].name, ddsd.lPitch, > pools[i].align); > + if (pools[i].pitch) > + ok(ddsd.lPitch == pools[i].pitch, "%s: Expected pitch %d, got > %d.\n", + pools[i].name, pools[i].pitch, ddsd.lPitch); > + > + IDirectDrawSurface4_Release(surface); > + } > + > + IDirectDraw4_Release(ddraw); > +} > + > START_TEST(ddraw4) > { > test_process_vertices(); > @@ -1502,4 +1583,5 @@ START_TEST(ddraw4) > test_texture_load_ckey(); > test_viewport_interfaces(); > test_zenable(); > + test_pitch_alignment(); > } > diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c > index 2ea77fe..4425ad4 100644 > --- a/dlls/ddraw/tests/ddraw7.c > +++ b/dlls/ddraw/tests/ddraw7.c > @@ -1277,6 +1277,87 @@ static void test_zenable(void) > DestroyWindow(window); > } > > +static void test_pitch_alignment(void) > +{ > + IDirectDraw7 *ddraw; > + IDirectDrawSurface7 *surface; > + HRESULT hr; > + static const struct > + { > + DWORD caps, caps2; > + UINT align; > + LONG pitch; > + const char *name; > + } > + pools[] = > + { > + { > + DDSCAPS_OFFSCREENPLAIN | DDSCAPS_VIDEOMEMORY, 0, > + 8, 0, "D3DPOOL_DEFAULT" > + }, > + { > + DDSCAPS_OFFSCREENPLAIN | DDSCAPS_SYSTEMMEMORY, 0, > + 8, 16, "D3DPOOL_SYSTEMMEM" > + }, > + { > + DDSCAPS_TEXTURE, DDSCAPS2_TEXTUREMANAGE, > + 8, 16, "D3DPOOL_MANAGED" > + } > + }; > + unsigned int i; > + DDSURFACEDESC2 ddsd; > + > + if (!(ddraw = create_ddraw())) > + { > + skip("Failed to create a ddraw object, skipping test.\n"); > + return; > + } > + > + hr = IDirectDraw7_SetCooperativeLevel(ddraw, NULL, DDSCL_NORMAL); > + ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr); > + > + for (i = 0; i < (sizeof(pools) / sizeof(*pools)); i++) > + { > + memset(&ddsd, 0, sizeof(ddsd)); > + ddsd.dwSize = sizeof(ddsd); > + ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT | > DDSD_PIXELFORMAT; + ddsd.dwWidth = 5; > + ddsd.dwHeight = 5; > + U4(ddsd).ddpfPixelFormat.dwSize = sizeof(U4(ddsd).ddpfPixelFormat); > + U4(ddsd).ddpfPixelFormat.dwFlags = DDPF_RGB; > + U1(U4(ddsd).ddpfPixelFormat).dwRGBBitCount = 16; > + U2(U4(ddsd).ddpfPixelFormat).dwRBitMask = 0xF800; > + U3(U4(ddsd).ddpfPixelFormat).dwGBitMask = 0x07E0; > + U4(U4(ddsd).ddpfPixelFormat).dwBBitMask = 0x001F; > + ddsd.ddsCaps.dwCaps = pools[i].caps; > + ddsd.ddsCaps.dwCaps2 = pools[i].caps2; > + > + hr = IDirectDraw7_CreateSurface(ddraw, &ddsd, &surface, NULL); > + ok(SUCCEEDED(hr) || hr == DDERR_UNSUPPORTEDFORMAT || hr == > DDERR_NODIRECTDRAWHW, + "%s: Failed to create surface, hr > %#x.\n", pools[i].name, hr); + if (!surface) > + { > + skip("%s: Failed to create surface, skipping pitch alignment > test\n", pools[i].name); + continue; > + } > + > + memset(&ddsd, 0, sizeof(ddsd)); > + ddsd.dwSize = sizeof(ddsd); > + hr = IDirectDrawSurface7_GetSurfaceDesc(surface, &ddsd); > + ok(SUCCEEDED(hr), "Failed to get surface desc, hr %#x.\n", hr); > + > + ok(!(ddsd.lPitch & (pools[i].align - 1)), "%s: Pitch %d is not %u > byte aligned.\n", + pools[i].name, ddsd.lPitch, > pools[i].align); > + if (pools[i].pitch) > + ok(ddsd.lPitch == pools[i].pitch, "%s: Expected pitch %d, got > %d.\n", + pools[i].name, pools[i].pitch, ddsd.lPitch); > + > + IDirectDrawSurface7_Release(surface); > + } > + > + IDirectDraw7_Release(ddraw); > +} > + > START_TEST(ddraw7) > { > HMODULE module = GetModuleHandleA("ddraw.dll"); > @@ -1296,4 +1377,5 @@ START_TEST(ddraw7) > test_depth_blit(); > test_texture_load_ckey(); > test_zenable(); > + test_pitch_alignment(); > }

1 0

Re: [PATCH 2/2] ddraw/tests: Add pitch alignment tests (try 2)
by Marvin Feb. 27, 2012

Feb. 27, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17115 Your paranoid android. === W7PROX64 (64 bit ddraw2) === ddraw2.c:1454: Test failed: D3DPOOL_SYSTEMMEM: Pitch 12 is not 8 byte aligned. ddraw2.c:1457: Test failed: D3DPOOL_SYSTEMMEM: Expected pitch 16, got 12. === TEST64_W7SP1 (64 bit ddraw2) === ddraw2.c:1454: Test failed: D3DPOOL_SYSTEMMEM: Pitch 12 is not 8 byte aligned. ddraw2.c:1457: Test failed: D3DPOOL_SYSTEMMEM: Expected pitch 16, got 12. === W7PROX64 (64 bit ddraw1) === ddraw1.c:1188: Test failed: D3DPOOL_SYSTEMMEM: Pitch 12 is not 8 byte aligned. ddraw1.c:1191: Test failed: D3DPOOL_SYSTEMMEM: Expected pitch 16, got 12. === TEST64_W7SP1 (64 bit ddraw1) === ddraw1.c:1188: Test failed: D3DPOOL_SYSTEMMEM: Pitch 12 is not 8 byte aligned. ddraw1.c:1191: Test failed: D3DPOOL_SYSTEMMEM: Expected pitch 16, got 12. === W7PROX64 (64 bit ddraw7) === ddraw7.c:1349: Test failed: D3DPOOL_SYSTEMMEM: Pitch 12 is not 8 byte aligned. ddraw7.c:1352: Test failed: D3DPOOL_SYSTEMMEM: Expected pitch 16, got 12. ddraw7.c:1336: Test failed: D3DPOOL_MANAGED: Failed to create surface, hr 0x80004002. ddraw7.c:1349: Test failed: D3DPOOL_MANAGED: Pitch 12 is not 8 byte aligned. ddraw7.c:1352: Test failed: D3DPOOL_MANAGED: Expected pitch 16, got 12. === TEST64_W7SP1 (64 bit ddraw7) === ddraw7.c:1349: Test failed: D3DPOOL_SYSTEMMEM: Pitch 12 is not 8 byte aligned. ddraw7.c:1352: Test failed: D3DPOOL_SYSTEMMEM: Expected pitch 16, got 12. ddraw7.c:1336: Test failed: D3DPOOL_MANAGED: Failed to create surface, hr 0x80004002. ddraw7.c:1349: Test failed: D3DPOOL_MANAGED: Pitch 12 is not 8 byte aligned. ddraw7.c:1352: Test failed: D3DPOOL_MANAGED: Expected pitch 16, got 12. === W7PROX64 (64 bit ddraw4) === ddraw4.c:1562: Test failed: D3DPOOL_SYSTEMMEM: Pitch 12 is not 8 byte aligned. ddraw4.c:1565: Test failed: D3DPOOL_SYSTEMMEM: Expected pitch 16, got 12. ddraw4.c:1562: Test failed: D3DPOOL_MANAGED: Pitch 12 is not 8 byte aligned. ddraw4.c:1565: Test failed: D3DPOOL_MANAGED: Expected pitch 16, got 12. === TEST64_W7SP1 (64 bit ddraw4) === ddraw4.c:1562: Test failed: D3DPOOL_SYSTEMMEM: Pitch 12 is not 8 byte aligned. ddraw4.c:1565: Test failed: D3DPOOL_SYSTEMMEM: Expected pitch 16, got 12. ddraw4.c:1562: Test failed: D3DPOOL_MANAGED: Pitch 12 is not 8 byte aligned. ddraw4.c:1565: Test failed: D3DPOOL_MANAGED: Expected pitch 16, got 12.

1 0

Re: [PATCH] po: Update Swedish translation. (try 2)
by Lauri Kenttä Feb. 27, 2012

Feb. 27, 2012

Please ignore this one, I missed a few bugs. -- Lauri Kenttä

1 0

Fw: Re: po: zh_TW translation updates
by Hin-Tak Leung Feb. 27, 2012

Feb. 27, 2012

Strange bounces... --- On Mon, 27/2/12, Hin-Tak Leung <hintak_leung(a)yahoo.co.uk> wrote: > --- On Mon, 27/2/12, Francois Gouget > <fgouget(a)free.fr> > wrote: > > > Patches are posted to wine-patches(a)winehq.org: > > http://www.winehq.org/pipermail/wine-patches/2012-February/111804.html > > A quick look at it (it is a few hundred k) - says a few of > the problems I saw and suspected: > > - some of the changes are not improvements/corrections but > just opinionated changes > > - some changes are wrong (i.e. the older version is more > correct/natural and the change makes it worse, not better). > > - some of the changes are over-eager: i.e. it "improves" on > windows and tried to be more user-friendly, but not exactly > how windows does it. > > I think there should be a notes on the translation FAQ: one > is not looking to be "better than" windows, but > bug-for-bug-compatible. Therefore translation is preferably > what regional/localized windows (whatever version) does. > > 20% of the world's population is Chinese, I am sure it is > easy enough to do a few screenshots of localized windows (be > in traditional or simplied) and show how those behave. > > There is a definitive answer (or "definition answers") to > most of these translation strings: what localized windows > (some version) does. It is not up to individual or group > opinions, really. I mean, public libraries, etc have windows > in the far east, there is no excuse to be wrong, or on the > opposite extreme, "try to improve on windows", even if one > does not want to get one's hand dirty and own a windows > box. > > > > >

1 0

Re: po: fixed remaining Slovenian true positives in the winepo error report
by Jaka Kranjc Feb. 27, 2012

Feb. 27, 2012

On Wednesday 22 of February 2012 18:16:20 Francois Gouget wrote: > On Wed, 22 Feb 2012, Jaka Kranjc wrote: > [...] > > > > You mean that all the 'not translated' strings are actually translated > > > and just happen to be the same as in English, right? I can add them. > > > > Exactly. > > Done. Great. I also swapped wine-patches with wine-devel to keep the noise down. > So in English you'd end up with something like this: > > Error; Paper jam; > or > Initialising; Default Printer; I/O Active; > > > So what you're saying is that: > * There is no systematic conversion of semicolons to commas in > Slovenian. > * In Slovenian the strings above should definitely use a comma > because it's used as a list separator. > * The English string should maybe use a comma too? This may require > some supporting arguments... So if I understand correctly, parts of this composite get choped and concatenated and then printed as a sequence. Lacking full sentences, semicolons *are* a good choice for Slovenian in this case too. Commas would be fitting for proper "etc" lists. This brings up another can of worms though; capitalisation. We don't use title case at all, so these translation have the wrong case. Well, except for the first one being printed, but that is runtime knowledge, so we can't really fix it well. Gettext has no provisions for this (or gender or ...), so all that comes to mind is autocapitalisation depending on the locale, but that is probably ugly and I doubt it would work with more exotic scripts (but not sure if any would need it). > > So no, in general we do not substitute semicolons, but it depends on the > > original msgid context. Most translators are serious grammar nazis, so > > they/we tend to ignore mistakes in the original string. > > Don't! > > At least for Wine any issue in the English string should be fixed or > reported so it can be fixed as early as possible (preferably before it > has been translated into 20 other languages). Of course I'm saying that > but being in string freeze we would not be able to fix strings right > now. But if I saw such reports on wine-devel I'd make sure they are > acted upon after the release. Oh, I know, didn't mean to suggest inaction. But in a lot of cases, it comes down to preference, style or language perception. Plus the fact that inspecting the original's validity almost always requires the ability to read code, which most translators lack and which is hard to access if they work via online translation tools. Re usage strings: is there no 80 column limit imposed? I saw even some original strings were longer. LP -- To err is humor

2 3

Re: [PATCH] po: Update Swedish translation.
by Jan-Peter Nilsson Feb. 27, 2012

Feb. 27, 2012

Hi I have a few questions/comments/suggestions on/for the change in the Swedish translation. On -28163-01--10 20:59, Lauri Kenttä wrote: > #: comdlg32.rc:292 > -#, fuzzy > msgctxt "Luminance" > msgid "&Lum:" > -msgstr "&Lum:" > +msgstr "&Val:" Can you explain 'Val' here? I don't understand it. I would assume 'Luminance' to be translated to 'Luminans', so Lum as abbreviation makes sense to me. > #: ieframe.rc:78 > -#, fuzzy > msgid "Searching for %s" > -msgstr "Egenskaper för %s" > +msgstr "Söker för %s" "Söker efter" would probably be better. > #: shell32.rc:215 > -#, fuzzy > msgid "Common Files" > -msgstr "Kopierar filer..." > +msgstr "" Perhaps 'Delade Filer'? > #: cmd.rc:331 > -#, fuzzy > msgid "Verify is %1\n" > -msgstr "Verifiera blev %s\n" > +msgstr "Verifiera blev %1\n" I would use 'är', 'blev' is more 'became' than 'is'. > #: cmd.rc:335 > -#, fuzzy > msgid "Volume label (11 characters, <Enter> for none)?" > -msgstr "Diskvolymens namn (11 karaktärer, tryck enter för inget)?" > +msgstr "Diskvolymens namn (11 karaktärer, tryck <Enter> för inget)?" 'Karaktärer' is the other kind of characters, the word here is 'tecken'. > #: explorer.rc:29 > #, fuzzy > @@ -10042,9 +9949,8 @@ msgid "Usage: hostname\n" > msgstr "" > > #: hostname.rc:28 > -#, fuzzy > msgid "Error: Invalid option '%c'.\n" > -msgstr "Fel: ogiltigt nyckelnamn\n" > +msgstr "Fel: Ogiltigt val '%c'.\n" I'm not sure about 'val' here. To me 'val' reads more like 'selection' than 'option'. > #: net.rc:41 > msgid "There are no entries in the list.\n" > @@ -10215,14 +10110,12 @@ msgstr "" > "---------------------------------------------------------------\n" > > #: net.rc:43 > -#, fuzzy > msgid "%1 %2 %3 Open resources: %4!u!\n" > -msgstr "%s %s %s Öppna resurser: %lu\n" > +msgstr "%1 %1 %1 Öppna resurser: %4!u!\n" I suppose that should be %1 %2 %3. > #: regedit.rc:88 > -#, fuzzy > msgid "Modify Binary Data..." > -msgstr "Ändra binärt data" > +msgstr "Ändra binärt data..." 'binärdata' is one word. > #: taskkill.rc:31 > -#, fuzzy > msgid "Error: Option %1 expects a command line parameter.\n" > -msgstr "Fel: Valet %s kräver en kommandoradsparameter.\n" > +msgstr "Fel: Valet %1 kräver en kommandoradsparameter.\n" > > #: taskkill.rc:32 > msgid "Error: Options /im and /pid are mutually exclusive.\n" > msgstr "Fel: Valen /im och /pid kan inte användas tillsammans.\n" > Val again. I don't really have any better suggestion, but it sounds strange to me. > #: winecfg.rc:146 > -#, fuzzy > msgid "" > "Wine can mimic different Windows versions for each application. This tab is " > "linked to the Libraries and Graphics tabs to allow you to change systemwide " > "or per-application settings in those tabs as well." > msgstr "" > -"Wine kan imitera olika Windows-versioner för varje program. Den här fliken " > +"Wine kan imitera olika Windows-versioner för varje program. Den här fliken " > "är länkad till flikarna Bibliotek och Grafik för att låta dig ändra " > "inställningar i de flikarna också, antingen systembreda eller per program." > I believe 'systemövergripande' would be better than 'systembreda'. > > #: winecfg.rc:83 > -#, fuzzy > msgid "Audio test failed!" > -msgstr "Återställning av hårddisk misslyckades\n" > +msgstr "" Maybe "Ljudtest misslyckades!" ? > > #: winecfg.rc:85 > -#, fuzzy > msgid "(System default)" > -msgstr "Systemsökväg" > +msgstr "" Maybe "(Systemstandard)" ? > #: winefile.rc:197 > msgctxt "accelerator Fullscreen" > @@ -13528,9 +13355,8 @@ msgid "Error while selecting new font." > msgstr "Ett fel uppstod när ett nytt teckensnitt valdes." > > #: winefile.rc:95 > -#, fuzzy > msgid "Wine File Manager" > -msgstr "Winefile" > +msgstr "Wine Filhanteraren" "Wine Filhanterare", unless we want definite form "The Wine File Manager". > #: wordpad.rc:188 > -#, fuzzy > msgid "OLE storage documents are not supported." > -msgstr "Utökade attribut ej stödda\n" > +msgstr "" Maybe "OLE lagringsdokument stöds ej." ? //Jan-Peter

4 4

Wrong charcter encoding in winmm-tests
by Julian Rüger Feb. 27, 2012

Feb. 27, 2012

Hello everyone, I ran the winmm-tests in wine today, with a german locale, and noticed that the umlauts are displayed incorrectly. My terminal is in UTF-8 and wine outputs ISO 8859-1. I looked into the code and found out that ie. in wave.c, wave_out_error() declares the strings as static char, and thus uses waveOutGetErrorTextA() if I am not mistaken. Should this be fixed or doesn't it matter in the tests? Best regards, Julian

2 5

Re: [PATCH 2/2] ddraw/tests: Add pitch alignment tests
by Marvin Feb. 26, 2012

Feb. 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17108 Your paranoid android. === WNT4WSSP6 (32 bit ddraw2) === ddraw2.c:1438: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 00420FAD === W2KPROSP4 (32 bit ddraw2) === ddraw2.c:1438: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw2: unhandled exception c0000005 at 00420FAD === WXPPROSP3 (32 bit ddraw2) === ddraw2.c:1438: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw2: unhandled exception c0000005 at 00420FAD === W2K3R2SESP2 (32 bit ddraw2) === ddraw2.c:1438: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw2: unhandled exception c0000005 at 00420FAD === WVISTAADM (32 bit ddraw2) === ddraw2.c:1438: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw2: unhandled exception c0000005 at 00420FAD === W2K8SE (32 bit ddraw2) === ddraw2.c:1438: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw2: unhandled exception c0000005 at 00420FAD === W7PRO (32 bit ddraw2) === ddraw2.c:1438: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 00420FAD === W7PROX64 (32 bit ddraw2) === ddraw2.c:1438: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 00420FAD === TEST64_W7SP1 (32 bit ddraw2) === ddraw2.c:1438: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 00420FAD === W7PROX64 (64 bit ddraw2) === ddraw2.c:1438: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. Timeout === TEST64_W7SP1 (64 bit ddraw2) === ddraw2.c:1438: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. Timeout === WNT4WSSP6 (32 bit ddraw1) === ddraw1.c:1175: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 0041A3A5 === W2KPROSP4 (32 bit ddraw1) === ddraw1.c:1175: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw1: unhandled exception c0000005 at 0041A3A5 === WXPPROSP3 (32 bit ddraw1) === ddraw1.c:1175: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw1: unhandled exception c0000005 at 0041A3A5 === W2K3R2SESP2 (32 bit ddraw1) === ddraw1.c:1175: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw1: unhandled exception c0000005 at 0041A3A5 === WVISTAADM (32 bit ddraw1) === ddraw1.c:1175: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw1: unhandled exception c0000005 at 0041A3A5 === W2K8SE (32 bit ddraw1) === ddraw1.c:1175: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw1: unhandled exception c0000005 at 0041A3A5 === W7PRO (32 bit ddraw1) === ddraw1.c:1175: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 0041A3A5 === W7PROX64 (32 bit ddraw1) === ddraw1.c:1175: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 0041A3A5 === TEST64_W7SP1 (32 bit ddraw1) === ddraw1.c:1175: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 0041A3A5 === W7PROX64 (64 bit ddraw1) === ddraw1.c:1175: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. Timeout === TEST64_W7SP1 (64 bit ddraw1) === ddraw1.c:1175: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. Timeout === W2KPROSP4 (32 bit ddraw7) === ddraw7.c:1336: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw7: unhandled exception c0000005 at 0042E3E1 === WXPPROSP3 (32 bit ddraw7) === ddraw7.c:1336: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw7: unhandled exception c0000005 at 0042E3E1 === W2K3R2SESP2 (32 bit ddraw7) === ddraw7.c:1336: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw7: unhandled exception c0000005 at 0042E3E1 === WVISTAADM (32 bit ddraw7) === ddraw7.c:1336: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw7: unhandled exception c0000005 at 0042E3E1 === W2K8SE (32 bit ddraw7) === ddraw7.c:1336: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw7: unhandled exception c0000005 at 0042E3E1 === W7PRO (32 bit ddraw7) === ddraw7.c:1336: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 0042E3E1 === W7PROX64 (32 bit ddraw7) === ddraw7.c:1336: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 0042E3E1 === TEST64_W7SP1 (32 bit ddraw7) === ddraw7.c:1336: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 0042E3E1 === W7PROX64 (64 bit ddraw7) === ddraw7.c:1336: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. Timeout === TEST64_W7SP1 (64 bit ddraw7) === ddraw7.c:1336: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. Timeout === W2KPROSP4 (32 bit ddraw4) === ddraw4.c:1549: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw4: unhandled exception c0000005 at 00427CC1 === WXPPROSP3 (32 bit ddraw4) === ddraw4.c:1549: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw4: unhandled exception c0000005 at 00427CC1 === W2K3R2SESP2 (32 bit ddraw4) === ddraw4.c:1549: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw4: unhandled exception c0000005 at 00427CC1 === WVISTAADM (32 bit ddraw4) === ddraw4.c:1549: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw4: unhandled exception c0000005 at 00427CC1 === W2K8SE (32 bit ddraw4) === ddraw4.c:1549: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x887601fe. ddraw4: unhandled exception c0000005 at 00427CC1 === W7PRO (32 bit ddraw4) === ddraw4.c:1549: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 00427CC1 === W7PROX64 (32 bit ddraw4) === ddraw4.c:1549: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 00427CC1 === TEST64_W7SP1 (32 bit ddraw4) === ddraw4.c:1549: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 00427CC1 === W7PROX64 (64 bit ddraw4) === ddraw4.c:1549: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. Timeout === TEST64_W7SP1 (64 bit ddraw4) === ddraw4.c:1549: Test failed: D3DPOOL_DEFAULT: Failed to create surface, hr 0x88760233. Timeout

1 0