February 2012 - Wine-Devel - list.winehq.org

Skype support status
by Artem S. Tashkinov Feb. 5, 2012

Feb. 5, 2012

Hello everyone, It's not a secret that Skype was bought by Microsoft a few months back and that there's a great chance that its native Linux version will get even fewer updates in the future because I doubt that Microsoft is even remotely endorse the existence of Linux and open source, thus Skype may easily become a "burden" they don't want to bear. Another quite important fact to consider is that the Linux version of Skype has fewer features than its Windows counterpart and that there are multiple issues regarding Skype, like the absence of a native 64bit version and a number of quite serious bugs (crashes, exclusive sound card access preventing other applications from working, 100% CPU usage after hibernation/sleep). Currently under Wine 1.4-rc2 I wasn't able to even run any version of Skype even in a simple chat mode. Very old versions of Skype cannot get online, more recent ones crash when trying to get online, or crash when you just start them, the last few releases (5.5-5.8) use MSHTML as their logon form and the way it behaves under Wine you cannot make use of it. I know that Codeweavers resources are very limited and that your priorities and the priority of other programmers hacking Wine are mostly concerned about getting proper support for core Windows applications like MS Office, Adobe products and other crucial programs, but I think it would be wise to make even basic Skype functionality work, because there are operating systems other than Windows, MacOS (iOS), and Linux (Android) and many people are left without one of the most popular messengers in the world. In short this message is a cry for getting Skype to work _at all_, because now it's totally unusable. With respect, Artem S. Tashkinov

1 0

Re: kernel32: Add LCMapStringEx implementation and test it reusing tests from LCMapStringW (try 2)
by Dmitry Timoshkov Feb. 5, 2012

Feb. 5, 2012

André Hentschel <nerv(a)dawncrow.de> wrote: > +@ stdcall LCMapStringEx(long long wstr long ptr long ptr ptr long) ... > +INT WINAPI LCMapStringEx(LPCWSTR name, DWORD flags, LPCWSTR src, INT srclen, LPWSTR dst, INT dstlen, > + LPNLSVERSIONINFO version, LPVOID reserved, LPARAM lparam) .spec file entry doesn't match the implementation. -- Dmitry.

1 0

Re: kernel32: Add LCMapStringEx implementation and test it reusing tests from LCMapStringW
by Dmitry Timoshkov Feb. 5, 2012

Feb. 5, 2012

André Hentschel <nerv(a)dawncrow.de> wrote: > +/* Locale name special values */ > +#define LOCALE_NAME_INVARIANT L"" > +#define LOCALE_NAME_MAX_LENGTH 85 > +#define LOCALE_NAME_SYSTEM_DEFAULT L"!sys-default-locale" > +#define LOCALE_NAME_USER_DEFAULT NULL Have a look how unicode constants are defined in other header files, the above version can't work in Wine. Also just duplicating LCMapString tests is not a very good idea, it would be better to find a way to share the test data. -- Dmitry.

2 2

Re: ntdll: Remove dead code
by Marcus Meissner Feb. 5, 2012

Feb. 5, 2012

On Sun, Feb 05, 2012 at 03:59:44PM +0100, André Hentschel wrote: > --- > dlls/ntdll/signal_x86_64.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c > index 0fc53c7..e9cefb8 100644 > --- a/dlls/ntdll/signal_x86_64.c > +++ b/dlls/ntdll/signal_x86_64.c > @@ -2629,10 +2629,6 @@ static BOOL is_inside_epilog( BYTE *pc ) > > for (;;) > { > - BYTE rex = 0; > - > - if ((*pc & 0xf0) == 0x40) rex = *pc++ & 0x0f; /* rex prefix */ > - This is not OK I think. The pc++ side effect is removed ... and is not handled in the switch() below. Ciao, Marcus

1 0

Re: user32: Only call SetWindowPos() in UpdateLayeredWindowIndirect() if needed. (try 3)
by Dmitry Timoshkov Feb. 4, 2012

Feb. 4, 2012

Adam Martinson <adam.r.martinson(a)gmail.com> wrote: > +static HDC (WINAPI *pGetWindowDC)(HWND hWnd); > +static int (WINAPI *pReleaseDC)(HWND hWnd,HDC hDC); There is no need to dynamically import these APIs, they are always available. > +static DWORD WINAPI test_ulw_thread(void *data) > +{ > + struct test_ulw_tdata *tdata = data; > + DWORD res; > + > + res = WaitForSingleObject( tdata->hSem, 1000 ); > + ok( !res, "wait for semaphore failed: %08x\n", res ); > + if (!res) > + { > + HDC hdc = pGetWindowDC( tdata->hwnd ); > + res = pUpdateLayeredWindow( tdata->hwnd, 0, NULL, tdata->psz, hdc, tdata->ppt, 0, NULL, ULW_OPAQUE ); > + ok( res, "UpdateLayeredWindow failed: %08x\n", GetLastError() ); > + pReleaseDC( tdata->hwnd, hdc ); > + } > + > + return res; > +} I don't see how this is supposed to test what you presumably are trying to fix. A bunch of message tests that calls UpdateLayeredWindow with various flags and parameters and compares window extents before and after the call would be more convincing IMO. -- Dmitry.

1 0

re: Wine automated testing update
by Dan Kegel Feb. 3, 2012

Feb. 3, 2012

Jeremy wrote: > the VMWare folks are not willing to provide a permanent license for VMWare to us. > > So, we've shifted gears, and are exploring whether something like qemu + > kvm would be a sufficient alternate. What's the plan for automated MacOSX testing? I hear 10.7 supports running in a VM...

3 2

Re: [2/3] msi: Use the return value of IXMLDOMNode_get_text (clang).
by Juan Lang Feb. 3, 2012

Feb. 3, 2012

Hi Hans, hr = IXMLDOMNode_get_text( node, &s ); IXMLDOMNode_Release( node ); - if (!strcmpW( s, product_code )) r = ERROR_SUCCESS; - SysFreeString(s); + if (hr == S_OK && !strcmpW( s, product_code )) r = ERROR_SUCCESS; + SysFreeString( s ); Is it really safe to free s if IXMLDOMNode_get_text failed? --Juan

1 0

Re: quartz: AMFilterData_ParseFilterData returns a pointer to a pointer to filter data
by Dmitry Timoshkov Feb. 3, 2012

Feb. 3, 2012

Aric Stewart <aric(a)codeweavers.com> wrote: > - REGFILTER2 *prf2; > + static REGFILTER2 *prf2; What's the point of this change? -- Dmitry.

3 2

Re: gdi32/tests: Add tests for default font selection.
by Marvin Feb. 3, 2012

Feb. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16799 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4145: Test failed: expected vertical face, got System === WXPPROSP3 (32 bit font) === font.c:4145: Test failed: expected vertical face, got System === W2K3R2SESP2 (32 bit font) === font.c:4145: Test failed: expected vertical face, got System

1 0

Profiing windows apps
by Ralph Little Feb. 2, 2012

Feb. 2, 2012

Hi, I'm looking at bug #9672 again in the The Sims. The app crashes early on during initialisation in DirectDraw. The problem occurs after CreateSurface returns an error, since it would appear that the DDSURFACEDESC passed into the call is foobar. This would lead me to conclude that something on the lead up to that call is precipitating that rogue call. I have a legal Windows XP and I wish to trace the calls leading up to this point with real Windows/DirectX to compare with what is happening to Wine so that I can assess what is upsetting the application, since I can't see anything in the Wine trace prior to that that looks suspicious. Does anyone have any experience with tracing apps in real Windows in the context of Wine development? Should I use a profiler or is there a simpler method? Cheers, Ralph

3 5

Re: [PATCH 1/2] ddraw/tests: Add some IDirect3DViewport interface tests (try 2)
by Henri Verbeet Feb. 2, 2012

Feb. 2, 2012

On 2 February 2012 14:57, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static ULONG get_refcount(IUnknown *test_iface) > +{ > + IUnknown_AddRef(test_iface); > + return IUnknown_Release(test_iface); > +} ... > + LONG ref; ... > + ref = get_refcount((IUnknown *)d3d); > + ok(ref == 2, "IDirect3D refcount is %d\n", ref); Well yeah, get_refcount() returns ULONG now, but you should fix the type of "ref" and the format strings as well.

2 1

Re: [PATCH 1/2] ddraw/tests: Add some IDirect3DViewport interface tests (try 2)
by Marvin Feb. 2, 2012

Feb. 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16784 Your paranoid android. === WNT4WSSP6 (32 bit ddraw2) === ddraw2.c:421: Test failed: Got unexpected count 3. ddraw2.c:430: Test failed: Got unexpected clip rect {14, 33, 646, 237}, expected {14, 33, 646, 486}.

1 0

Re: [PATCH] ddraw/tests: Add some IDirect3DViewport interface tests
by Henri Verbeet Feb. 2, 2012

Feb. 2, 2012

On 2 February 2012 12:56, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static LONG get_refcount(IUnknown *test_iface) > +{ > + IUnknown_AddRef(test_iface); > + return IUnknown_Release(test_iface); > +} Release is supposed to return a ULONG. > + hr = IDirect3DViewport_QueryInterface(viewport, &IID_IDirect3DViewport2, (void **)&viewport2); > + ok(SUCCEEDED(hr) || broken(hr == E_FAIL), "Failed to QI IDirect3DViewport2, hr %#x.\n", hr); I think this would make the test fail on old versions of ddraw that simply don't know about IDirect3DViewport2. > + hr = IDirect3DViewport3_QueryInterface(viewport2, &IID_IUnknown, (void **)&unknown); This looks like it was intended to be called on viewport3. > + /* FIXME: This test suggests that IDirect3D, IDirect3D2 and IDirect3D3 are linked > + * to IDirectDraw. However, they are linked to whatever interface is used to QI the > + * first IDirect3D? interface. If DDraw1 is replaced with DDraw4 here the tests break */ Makes sense. I'm not sure it really should be part of this patch though.

1 0

please test native behaviour with (un)pluggable audio devices
by Joerg-Cyril.Hoehle＠t-systems.com Feb. 2, 2012

Feb. 2, 2012

Hi, please run the mmdevapi render and capture testsuites while unplugging (or deactivating) audio HW. I'd like to hear how native behaves prior to implementing error handling in Wine's drivers. One way to run the testsuites is as follows: 1. Download winetest-xyz.exe from test.winehq; 2. winetest-xyz.exe /x will extract all exes into some directory; 3. set WINETEST_DEBUG=2 4. set WINETEST_INTERACTIVE=1 (not used yet, but soon) 5. mmdevapi_test.exe render 6. mmdevapi_test.exe capture Esp., I'd like to know whether ReleaseBuffer ever signals an error or if it's always the job of GetBuffer to do so. Then I'd like to know whether primitives such as GetBufferSize fail too when the device is unplugged. Note that the testsuite may crash because it doesn't expect loosing devices mid-way. Thank you, Jörg Höhle

1 0

Re: dinput: Support INFINITE as number of effect iterations (try 2)
by Vitaliy Margolen Feb. 2, 2012

Feb. 2, 2012

On 01/28/2012 05:56 PM, Marcel Hasler wrote: > According to the DirectX reference, IDirectInputEffect::Start accepts > INFINITE (aka -1) for the number of iterations. However, passing -1 to > Linux via input_event results in no effect being played at all. This > patch sets the number of iterations to the maximum signed value > allowed if INFINITE is passed. > > This fixes bug 29712. > > This patch supersedes patch 83233. It does the same thing but adds a > comment and should be easier to understand. In general looks good. Would be nice to point out that linux/input.h says that any durations should not exceed 0x7fff as a maximum value. Please don't make code "easier to read" by adding needless if / else. Your first patch was fine. Vitaliy.

2 5

Re: [PATCH] winealsa: snd_card_get_name uses strdup (Valgrind).
by Christian Costa Feb. 1, 2012

Feb. 1, 2012

In that case you don't need the if (!err) condition to free the buffer otherwise you leak the string return by strdup. Christian 2012/2/1 Lauri Kenttä <lauri.kentta(a)gmail.com> > --- > dlls/winealsa.drv/mmdevdrv.c | 10 +++++++--- > 1 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index 0bedcc5..e434038 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -363,7 +363,7 @@ static HRESULT alsa_enum_devices(EDataFlow flow, WCHAR > **ids, char **keys, > for(err = snd_card_next(&card); card != -1 && err >= 0; > err = snd_card_next(&card)){ > char cardpath[64]; > - const char *cardname; > + char *cardname; > WCHAR *cardnameW; > snd_ctl_t *ctl; > DWORD len; > @@ -376,16 +376,18 @@ static HRESULT alsa_enum_devices(EDataFlow flow, > WCHAR **ids, char **keys, > continue; > } > > - if((err = snd_card_get_name(card, (char **)&cardname)) < 0){ > + if((err = snd_card_get_name(card, &cardname)) < 0){ > WARN("Unable to get card name for ALSA device %s: %d (%s)\n", > cardpath, err, snd_strerror(err)); > /* FIXME: Should be localized */ > - cardname = "Unknown soundcard"; > + cardname = strdup("Unknown soundcard"); > } > > len = MultiByteToWideChar(CP_UNIXCP, 0, cardname, -1, NULL, 0); > cardnameW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > if(!cardnameW){ > + if(!err) > + free(cardname); > snd_ctl_close(ctl); > return E_OUTOFMEMORY; > } > @@ -394,6 +396,8 @@ static HRESULT alsa_enum_devices(EDataFlow flow, WCHAR > **ids, char **keys, > alsa_get_card_devices(stream, ids, keys, num, ctl, card, > cardnameW); > > HeapFree(GetProcessHeap(), 0, cardnameW); > + if(!err) > + free(cardname); > > snd_ctl_close(ctl); > } > -- > 1.7.9 > > > >

3 2

snd_card_get_name uses strdup (Valgrind).
by Joerg-Cyril.Hoehle＠t-systems.com Feb. 1, 2012

Feb. 1, 2012

Hi there's a small memory leak in winealsa, tentatively plugged by patches #83353, #83334 and #82900. It would be nice if somebody who feels like struggling with const warnings in gcc would get a fix accepted in git. The dilemma: a literal "foo" is a const char*, free() does not want a const and casts are the root of all evil in C. Thank you, Jörg Höhle

2 1

Re: [PATCH 2/3] winecoreaudio: Implement the lock-free callback design.
by Andrew Eikum Feb. 1, 2012

Feb. 1, 2012

On Mon, Jan 30, 2012 at 11:37:17AM +0100, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Fixes bug #29657 > While I like the idea of this patch and how you implemented it, I wonder if it's appropriate for code freeze. The main problem in that bug is that the CA driver can deadlock, or release memory out of order. When working on this patch, were you able to identify specifically where the contention is? The idea of the InTransition state was to handle the lock release in mid-call. Can we add a check for that state in the callbacks to solve this problem less intrusively? The first patch seems fine. Andrew

4 6

Updated clang-static-analyzer results (just in time for 1.4 ;))
by Austin English Feb. 1, 2012

Feb. 1, 2012

Enjoy: http://www.mediafire.com/?aiomfk1cr9bc61y Using: wine-1.4-rc1-34-g01947e0 LLVM commit 683d1e1d449e6e790ff4c0b6340a4bbf144ff919 / git-svn-id: http://llvm.org/svn/llvm-project/llvm/trunk(a)149340 91177308-0d34-0410-b5e6-96231b3b80d8 austin(a)aw21 ~ $ sha1sum scan-build-2012-01-30-1.tar.bz2 8b3b2573c3595c805431b2ab40c6958805f37497 scan-build-2012-01-30-1.tar.bz2 -- -Austin

2 2