February 2012 - Wine-Devel - list.winehq.org

Re: cryptnet/tests: Fix test failures on older NT4
by Marvin Feb. 13, 2012

Feb. 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16947 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: advapi32/tests: Fix a test failure on older NT4
by Marvin Feb. 13, 2012

Feb. 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16946 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Fwd: Google Summer of Code 2012 DEADLINE: 2012-02-27
by Jeremy White Feb. 12, 2012

Feb. 12, 2012

Hi Folks, It's that time of year again - summer of code is going to start up soon. Maarten, you've been coordinating things for us for a while now - are you still game? Would you like help? Anyone else willing to volunteer to help admin the process? Cheers, Jeremy --- Conservancy Projects, I want to draw your attention to the fact that Google's Summer of Code program for 2012 is now accepting applications. Carol Smith wrote at 11:43 (EST) on Saturday: > We're pleased to announce that Google Summer of Code will be happening > for its eighth year this year: > > [1] - http://google-opensource.blogspot.com/2012/02/google-summer-of-code-2012-is… > [2] - http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc20… > [3] - http://www.google-melange.com/gsoc/events/google/gsoc2012 In particular, take a look at [3], which has the calendar for the SoC 2012 program.

6 7

Re: [PATCH 4/7] kernel32/tests: initial tests for cdrom.c (try 2)
by Charles Davis Feb. 10, 2012

Feb. 10, 2012

On Feb 10, 2012, at 1:30 PM, Dan Kegel wrote: > +START_TEST(cdrom) > +{ [...] > + /* GENERIC_WRITE because without it, passthrough doesn't work on win7 */ But with it, you can't open the device at all on Mac. As I explained on bug 29669, the device file only has 0440 access. Chip

1 0

The audio GetPosition dilemma (long)
by Joerg-Cyril.Hoehle＠t-systems.com Feb. 10, 2012

Feb. 10, 2012

Hi, mmdevapi's GetPosition returns "the stream position of the sample that is currently playing through the speakers", says MSDN. This is exactly what apps ought to use that want to synchronize audio & video (lip synchronisation). MSDN's wording about winmm's GetPosition is not exactly the same: "the current playback position of the given waveform-audio output device." However there's no other winmm function that could be used for lip-sync. Tests in winmm/tests/wave.c tend to show that WHDR_DONE notifications are only received after a position corresponding to the written number of bytes has been reached -- IOW the buffer has been played. Now look at winmm's PlaySound and mciwave code: /* make it so that 3 buffers per second are needed */ Both then proceed to play ping pong with two 1/3 second buffers. Every time WHDR_DONE is received, one of the two is empty, refilled and resubmitted using waveOutWrite. Now consider a system such as PulseAudio that wants to buffer 2 seconds of an audio stream internally. That scheme will fail completely. - If WHDR_DONE is based on GetPosition, notifications will only be sent after 2 seconds or an underrun. Neither PlaySound nor MCIWAVE buffer 2 seconds. They continuously hit an underrun as PA signals that it drained the tiny 40ms ALSA buffer we supplied. Is that PlaySound's fault? - If WHDR_DONE is instead based on buffer usage, it could be sent following snd_pcm_write and let PA buffer as much as it wants. But then our wave tests fail if GetPosition returns something like the position currently playing through the speakers, which is 2s late. Should we have GetPosition lie? And suffer loss of lip sync? DSound's GetCurrentPosition suffers from the exact same issue. For instance, playing an audio CD-ROM with mcicda in recent Wine causes constant underruns from DSound when Pulseaudio is involved. What's the root cause of the issue? 15 years ago, the audio HW would likely receive a pointer to the winmm header data and play that. Once played, the buffer was no more needed and returned to the app. Also, there was nothing sitting behind the audio HW causing significant latency (I mean DAC -> electronic -> speaker -> acoustic had latency negligible to the human brain). Equating GetPosition with the sample seen by the DAC was and is reasonable -- ALSA does exactly this with hw:0. DSound's model is that of a circular buffer from which the DAC is fed. No different. These days with mmdevapi, w7 users report a latency of 30-40ms introduced by the native mixer. Native's winmm might account for that in its GetPosition reports. This limit is below the threshold that my mmdevapi tests would notice. It is well below the approximately 100ms that matter to human perception when correlating visible and audible events. Note that native's mixer is the last in an audio graph before the HW. What happens in Linux with Wine? ALSA's dmix is known to introduce some latency as it operates in period-size chunks. However ALSA's periods are typically very small, e.g. 21.333ms and ALSA's dmix is typically connected to hw:0, immediately playing audio to the speakers. There's hardly a difference between audible GetPosition and a buffer position derived from snd_pcm_write (and old Wine mixed the two in the past). The picture looks a lot like with native's mmdevapi mixer. PulseAudio is entirely different. With PA, the wine mixer is no more near the end of the audio graph, rather than in front of a 2 second latency introducing element. A position derived from snd_pcm_write is 2s ahead of the true speaker position. How did we react? winealsa tried: 1. Using a small ALSA buffer so as to signal PA that large latencies are not ok. PA seems to ignore that hint. It still appears to buffer a lot somewhere internally (I've no experience with PA 1.0 or 1.1, please check). Even worse, small ALSA buffers like 40ms increased the risk of underruns and resulted in a worse audio experience to all users of wineALSA, whereas old wine would typically use a 100ms buffer. Small buffers are no issue to native's mixer. It's using "Pro Audio" priority, which is the highest priority on a native system AFAIK. By contrast, Wine is running at normal user priority. 2. Rate-Limiting. We currently believe we are doing it because we write no more than 3 periods at a time. But we're not. Nothing can prevent PA or any other device from filling its 2s buffer over time. It'll eventually do it, just slowly. We can't use our own clock to limit our writes because that would introduce clock skew issues with the audio HW clock. What if it runs faster than the system's interpretation of 48000fps? We can't second-guess the audio HW clock. IOW, we can't win a rate-limiting game. If the back-end signals via snd_pcm_avail that it has space, then we must feed it. Now we know the reason of our troubles. What can we do? 0. Ignore the issue. Equate GetPosition with Released_frames - GetCurrentPadding 1. Consider lip-sync important and strive to support audio & video applications. 2. mmdevapi appears to have a reasonable separation of concerns between buffering and speaker position. Leave as is. (It may happen though that apps built upon the assumption that they are no more than 40ms apart break when latencies like PA's enter the loop. Here it would be interesting to see whether native has some similar situation, like a remote desktop & audio environment). 3. Protect DSound from a too large delta between padding and position. The maximum is given by the DSound primary buffer size, since DSound's circular GetCurrentPosition abstraction breaks down completely should they be further apart. IOW, don't rate limit DSound writes, but lie about the position if the wineXYZ device says it's too far behind. Having this right may fix some of the bugs currently in bugzilla. That way, we'll get lip-sync with back-ends that don't introduce an unbearable latency. And we won't enter an underrun because the driver or the app never wait too much for the position to increase. 3. Protect winmm from a too large delta between padding and position. As there's no buffer limit to guide us, we must introduce an arbitrary one, around 100-200ms. I don't know whether a dynamic limit based on average supplied WHDR buffers would work. Regarding WHDR_DONE, I don't know whether we should then relax the tests. That feels unsafe, because an app may well wait for WHDR_DONE before calling waveOutReset or Close. WHDR_DONE should not come too early, or we may lose trailing sounds. Perhaps we should not delay the position when playing the last buffer in the list. Our winmm/tests/wave.c tests prove nothing more than that: at the end, the position corresponds to the sum of written samples. Perhaps a similar reflection on MS' side explains why in my tests native's mmdevapi GetPosition may stay 17 samples below the sum of written samples with some USB headsets (or is it just a bug in their driver?). 4. Observe the behaviour of libraries that target mmdevapi, winmm and DSound, e.g. OpenAL, XAudio2, bink, smack, SDL, FMOD and learn. Actually, thinking about what may happen to trailing samples in a system that introduces 2s latencies still gives headaches. If we issue snd_pcm_reset prior to snd_pcm_close, sound will be killed for sure. It looks like the device should remain open for some time. This applies to all wineXYZ devices, not just ALSA with PA. Some future OSS device may too introduce unforeseen latencies. Now I'll go and fix winmm as suggested above. Thank you for reading this far, Jörg Höhle

1 0

Re: [PATCH 3/3] ieframe: Added IProvideClassInfo::GetClassInfo tests
by Marvin Feb. 10, 2012

Feb. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16906 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3189: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3189: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3189: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3189: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3304: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3281: Test failed: Could not get WebBrowserV1 instance: 80040154 webbrowser: unhandled exception c0000005 at 0040A9DE === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2539: Test failed: expected GetOverridesKeyPath webbrowser.c:2543: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2544: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2153: Test failed: put_Resizable failed: 80004001 webbrowser.c:2154: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2158: Test failed: put_Resizable failed: 80004001 webbrowser.c:2159: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2539: Test failed: expected GetOverridesKeyPath webbrowser.c:2543: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2544: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:410: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2153: Test failed: put_Resizable failed: 80004001 webbrowser.c:2154: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2158: Test failed: put_Resizable failed: 80004001 webbrowser.c:2159: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2539: Test failed: expected GetOverridesKeyPath webbrowser.c:2543: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2544: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:469: Test failed: unexpected nCmdID 29 webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:2702: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2829: Test failed: expected TranslateUrl webbrowser.c:2830: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2832: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2838: Test failed: ReadyState = 1, expected 4 webbrowser.c:2648: Test failed: ReadyState = 1, expected 4 webbrowser.c:839: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:855: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:862: Test failed: ReadyState = 1, expected 4 webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:621: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:625: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1557: Test failed: unexpected call GetOptionKeyPath webbrowser.c:359: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:839: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:839: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:839: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:839: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:469: Test failed: unexpected nCmdID 26 webbrowser.c:469: Test failed: unexpected nCmdID 29 webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:791: Test failed: ReadyState = 1, expected 4 webbrowser.c:1568: Test failed: unexpected call GetDropTarget webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:2702: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3225: Test failed: doc != doc2 webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:621: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:625: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1557: Test failed: unexpected call GetOptionKeyPath webbrowser.c:359: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:469: Test failed: unexpected nCmdID 26 webbrowser.c:469: Test failed: unexpected nCmdID 29 webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:1568: Test failed: unexpected call GetDropTarget webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:2695: Test failed: expected TranslateUrl webbrowser.c:2702: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3232: Test failed: doc != doc2 webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:621: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:625: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1557: Test failed: unexpected call GetOptionKeyPath webbrowser.c:359: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:469: Test failed: unexpected nCmdID 26 webbrowser.c:469: Test failed: unexpected nCmdID 29 webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:1568: Test failed: unexpected call GetDropTarget webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:2695: Test failed: expected TranslateUrl webbrowser.c:2702: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2829: Test failed: expected TranslateUrl webbrowser.c:2830: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2838: Test failed: ReadyState = 1, expected 4 webbrowser.c:2648: Test failed: ReadyState = 1, expected 4 webbrowser.c:855: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:862: Test failed: ReadyState = 1, expected 4 webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:621: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:625: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1557: Test failed: unexpected call GetOptionKeyPath webbrowser.c:359: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:469: Test failed: unexpected nCmdID 26 webbrowser.c:469: Test failed: unexpected nCmdID 29 webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:791: Test failed: ReadyState = 1, expected 4 webbrowser.c:1568: Test failed: unexpected call GetDropTarget webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:2702: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2648: Test failed: ReadyState = 1, expected 4 webbrowser.c:839: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:855: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:621: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:625: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1557: Test failed: unexpected call GetOptionKeyPath webbrowser.c:359: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:469: Test failed: unexpected nCmdID 26 webbrowser.c:469: Test failed: unexpected nCmdID 16 webbrowser.c:469: Test failed: unexpected nCmdID 15 webbrowser.c:469: Test failed: unexpected nCmdID 29 webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:791: Test failed: ReadyState = 1, expected 4 webbrowser.c:1568: Test failed: unexpected call GetDropTarget webbrowser.c:1007: Test failed: unexpected call GetContainer webbrowser.c:517: Test failed: unexpected call webbrowser.c:2702: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2943: Test failed: expected RequestUIActivate webbrowser.c:3035: Test failed: Got 0x80004002 webbrowser.c:3130: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040D5A2

1 0

winealsa.drv patch to enum all software devices from .asoundrc
by Нискородов Серёжа Feb. 10, 2012

Feb. 10, 2012

Hi, all. I'm not so good at programming. I just was looking for a way to make possible play sound from WINE to ALSA software device other than "default". I wrote a patch that allows you to select the ALSA software device from control panel, along with the hardware devices. Perhaps the code is not so clear and beautiful, but it works for me, and maybe someone wants to send it to the repository, or to correct and send a corrected.

2 5

[PATCH 1/6] include: new file ddk/scsi.h
by Dan Kegel Feb. 9, 2012

Feb. 9, 2012

Only adds the minimum definitions needed to use SCSIOP_READ_DVD_STRUCTURE.

1 0

winetest can't remove its temp directory
by Joerg-Cyril.Hoehle＠t-systems.com Feb. 9, 2012

Feb. 9, 2012

Hi, does anybody else see a message from winetest.exe about not being able to clean up at the end? This happened with e.g. winetest-1.4-rc2 and some earlier ones. Indeed, a temp directory with all the extracted *_test.exe is left half-full. It looks like files got deleted in alphabetical order starting with 'a'. mmdevapi_test.exe is the first one left, up to x*_test.exe Today's "[PATCH 2/4] mmdevapi/tests" adds a missing IAudioClock_Release(acl); Perhaps that prevented mmdevapi from cleaning up? How to explain such an effect? How to allow winetest to clean up and exit properly? That does not seem to be issue #12801. Thank you for your help, Jörg Höhle

2 1

Add a trailing full stop to the kernel32 error messages
by Francois Gouget Feb. 9, 2012

Feb. 9, 2012

Translators: This may concern you! See the (*) below. (hence the post to wine-devel) It was discovered that the kernel32 error messages are supposed to all end with a full stop. This is a lot of strings and impacts a lot of translations. http://www.winehq.org/pipermail/wine-devel/2012-January/093969.html So this fix is not provided as a patch but as a set of two scripts. * mcfix adds a trailing full stop if needed to the kernel32 error messages. * pofix does the matching changes to the specified PO file both on the English and translated strings (taking into account the full-width for Chinese and Japanese translations). The advantage is that this can update everything with no fuzzying and without risking conflicts when applying it to Wine(*). To update Wine, simply run: ./mcfix dlls/kernel32/winerror.mc; for i in po/*.po;do ./pofix $i;done (*) As a translator if you have a local PO file that you took before this change and you modified some kernel32 error translations you patch will conflict. But that's easy to solve, simply run: ./pofix myfile.po -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 145 = 1! + 4! + 5!

1 0