March 2012 - Wine-Devel - list.winehq.org

Re: gdi32: Add support for loading scalable font resources.
by Dmitry Timoshkov March 30, 2012

March 30, 2012

Huw Davies <huw(a)codeweavers.com> wrote: > + if (size.u.LowPart < sizeof( *dos )) goto fail; Testing LowPart only could not work for large sizes. -- Dmitry.

2 2

Re: [PATCH 2/3] dmsynth: Check the rigth CLSID to create the DirectMusicSynthSink object.
by Marvin March 29, 2012

March 29, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17568 Your paranoid android. === WNT4WSSP6 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154 === W2KPROSP4 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80004002 dmsynth.c:42: Test failed: CoCreateInstance returned: 80004002 === W2K3R2SESP2 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154 === W2K8SE (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154

1 0

Re: [PATCH 1/3] dmsynth: Add basic tests.
by Marvin March 29, 2012

March 29, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17567 Your paranoid android. === WNT4WSSP6 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154 === W2KPROSP4 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80004002 dmsynth.c:42: Test failed: CoCreateInstance returned: 80004002 === W2K3R2SESP2 (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154 === W2K8SE (32 bit dmsynth) === dmsynth.c:39: Test failed: CoCreateInstance returned: 80040154 dmsynth.c:42: Test failed: CoCreateInstance returned: 80040154

1 0

Re: [PATCH 3/3] d3drm: Implement CreateMesh method and stubbed IDirect3DRMMesh interface.
by Michael Stefaniuc March 29, 2012

March 29, 2012

Hello Christian, On 03/29/2012 11:57 PM, Christian Costa wrote: > +HRESULT Direct3DRMMesh_create(REFIID riid, IUnknown** ppObj) > +{ > + IDirect3DRMMeshImpl* object; > + > + TRACE("(%p)\n", ppObj); > + > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirect3DRMMeshImpl)); > + if (!object) > + { > + ERR("Out of memory\n"); > + return E_OUTOFMEMORY; > + } > + > + object->IDirect3DRMMesh_iface.lpVtbl = &Direct3DRMMesh_Vtbl; > + object->ref = 1; > + > + if (IsEqualGUID(riid, &IID_IDirect3DRMMesh)) > + *ppObj = (IUnknown*)&object->IDirect3DRMMesh_iface; > + else > + *ppObj = (IUnknown*)&object->IDirect3DRMMesh_iface; both if and else code path are the same. > + > + return S_OK; > +} > + bye michael

2 1

Would like to get some feedback on GSOC idea
by M C March 29, 2012

March 29, 2012

Hi everyone, My name is Marek Chmiel, I am a student a NEIU. I am studying computer science and network security related topics. This semester I had spent a fair amount of time writing crypt related functions with java, and became very interested in Cryptography. After looking over the suggested ideas on SOC official wine wiki I was pleasantly surprised to see that there was already a crypt related idea suggested. I have a great understanding of c++ and java, and though I know c I have not worked with it as much as the other languages. Implementing a DSS provider sounds like an awesome task to tackle, if someone has never written code for Linux, can they take on such a task? Are there any significant issues implementing a DSS that you guys know about? Any crypt GSOC ideas would you suggest for someone who has wrote limited amount of code for Linux? What I would also like to do, besides implementing a DSS provider, is to fix most if not all of the crypt related bugs that remain in Wine. This might seem like more than most people can chew, but viewing the Bug Tracking database it appears that there aren't that many crypt related bugs and might even be caused by a lack of a DSS provider (Hopefully this wouldn't create a entire new series of bugs). Thanks for any input I might receive, and look forward to speaking with you all. I can also be found on the irc for development with the nick "MarcoVonChmiel". Marek K Chmiel.

2 1

Implementing a DSS provider
by M C March 29, 2012

March 29, 2012

Hello everyone, I am doing some research in regards GSOC, and would like to find out if anyone besides Juan Lang is experienced enough to make suggestions in regards to bug 10506 and/or the implementation of a DSS provider.

1 0

Re: [PATCH 2/5] dmusic: Enumerate ports for midi out and midi in devices in EnumPort.
by Alexandre Julliard March 29, 2012

March 29, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > With this patch I get exactly the same output for ports caps (except guid) as native. > I kept the comment regarding dmusic32 usage altough the native version > of dmusic I used does standard winmm calls to get port informations. > --- > dlls/dmusic/Makefile.in | 2 - > dlls/dmusic/dmusic.c | 120 ++++++++++++++++++++++++++++++++--------------- > 2 files changed, 82 insertions(+), 40 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dmime.dll -T ../../.. -p dmime_test.exe.so performance.c && touch performance.ok performance.c:111: Test failed: Got unexpected portcaps struct size: 00000004 make[1]: *** [performance.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: MsiGetFileHash
by Hans Leidekker March 29, 2012

March 29, 2012

On Thu, 2012-03-29 at 18:29 +0200, Robert van Herk wrote: > + mapping = CreateFileMappingW( handle, NULL, PAGE_READONLY, 0, 0, NULL ); > + if (mapping) > + { > + p = MapViewOfFile( mapping, FILE_MAP_READ, 0, 0, length ); > + if (p) > + { > + MD5_CTX ctx; > + > + MD5Init( &ctx ); > + MD5Update( &ctx, p, length ); > + MD5Final( &ctx ); > + UnmapViewOfFile( p ); > + > + memcpy( pHash->dwData, ctx.digest, sizeof pHash->dwData ); > + r = ERROR_SUCCESS; > + } > + CloseHandle( mapping ); > + } > + } else { > + /* Empty file -> set hash to 0 */ > + memset( pHash->dwData, 0, sizeof pHash->dwData ); > + r = ERROR_SUCCESS; > } > + > CloseHandle( handle ); Please use 4 space indentation and put brackets on a new line like in the rest of that function. Same for the test. Please also provide a more descriptive subject line and prefix it with "msi: "

1 0

SoC 2012 Ideas
by Charles Davis March 29, 2012

March 29, 2012

Hi, Since I graduate this year, this may be the last time I participate--or at least, attempt to participate, since last year didn't quite work out for me :(--in Summer of Code. (I realize I was supposed to email you last week, but what's done is done.) So, without further ado, here's what I'm proposing: 1) Make Wine use App Sandbox on Mac OS X. A project that used to be listed on the SoC ideas page was to implement proper sandboxing in Wine. Apparently, you think this is unrealistic, because you took it down. (Not the page, just that suggestion.) But, I think that if I narrowed my focus a bit, it could be possible to do this. I'm proposing using the Mac OS App Sandbox API--the beginnings of which were introduced in 10.5 and which came into its own in 10.7--to improve security of Wine on Mac OS. Wine is an excellent candidate for the App Sandbox, because most of its file-system activity is limited to a single directory--namely, the Wine prefix. I'm not sure what you think of this, though, so I'm throwing this out there to get feedback. At the very least, I would like to be able to limit Wine's file-system activity to the prefix. 2) HLSL compiler. Well, my D3D bytecode backend to LLVM didn't pan out like I'd hoped. Maybe an LLVM-based compiler is too complex for Wine right now. But perhaps we don't need it right now anyway. If CodeWeavers can't afford to pay me, maybe Google can. I can add a simple parser and compiler (that performs little or no optimization) that hopefully would be sufficient for Wine's purposes. 3) Integrate pieces of DCE/RPC into Wine. As you may or may not know, in Mac OS 10.7, Apple stopped using Samba (probably because it uses the GPL3 as its license) in favor of their own implementation--which just so happens to be based on the original DCE/RPC implementation (the same one that was used as a base for MS RPC). I figured we could cannibalize pieces of it for our own use. Or is that not acceptable? What do you think? I'm not sure how useful or feasible these are, so I'm posting to the list before. Chip

2 1

Re: [PATCH 3/3] (try2) gdi32: Add support for loading scalable font resources.
by Alexandre Julliard March 29, 2012

March 29, 2012

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/gdi32/font.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 75 insertions(+), 0 deletions(-) This one doesn't build: gcc -m32 -c -I. -I. -I../../include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -Werror -I/usr/include/freetype2 -g -O2 -o font.o font.c font.c: In function ‘AddFontResourceExW’: font.c:3498:59: error: ‘count’ may be used uninitialized in this function [-Werror=uninitialized] font.c:3475:36: note: ‘count’ was declared here cc1: all warnings being treated as errors make[1]: *** [font.o] Error 1 Admittedly count would always be initialized with the files we create, but we probably shouldn't rely on that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/5] dmusic: Enumerate ports for midi out and midi in devices in EnumPort.
by Andrew Eikum March 29, 2012

March 29, 2012

On Thu, Mar 29, 2012 at 08:52:45AM +0200, Christian Costa wrote: > + midiOutGetDevCapsW(index - 1, &caps, sizeof(caps)); > ... > + CoCreateInstance(&CLSID_DirectMusicSynth, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectMusicSynth8, (void**)&synth); > + IDirectMusicSynth8_GetPortCaps(synth, port_caps); Maybe I'm pickier than most people, but I like error checking on these sorts of calls. They make it easier to find what is happening when something goes terribly and unexpectedly wrong.

2 2

Re: [PATCH 5/5] dmusic: Implement partially SetDirectSound.
by Andrew Eikum March 29, 2012

March 29, 2012

It would be nice to see some tests for this. For example, how does this IDirectSound reference relate to the one created by IDirectMusicPerformance::InitAudio()? On Thu, Mar 29, 2012 at 08:53:10AM +0200, Christian Costa wrote: > > --- > dlls/dmusic/dmusic.c | 27 +++++++++++++++++++++------ > dlls/dmusic/dmusic_private.h | 2 ++ > 2 files changed, 23 insertions(+), 6 deletions(-) > > diff --git a/dlls/dmusic/dmusic.c b/dlls/dmusic/dmusic.c > index 8f2edea..60d6b8a 100644 > --- a/dlls/dmusic/dmusic.c > +++ b/dlls/dmusic/dmusic.c > @@ -52,19 +52,22 @@ static ULONG WINAPI IDirectMusic8Impl_AddRef (LPDIRECTMUSIC8 iface) { > return refCount; > } > > -static ULONG WINAPI IDirectMusic8Impl_Release (LPDIRECTMUSIC8 iface) { > +static ULONG WINAPI IDirectMusic8Impl_Release(LPDIRECTMUSIC8 iface) > +{ > IDirectMusic8Impl *This = (IDirectMusic8Impl *)iface; > ULONG refCount = InterlockedDecrement(&This->ref); > > TRACE("(%p)->(ref before=%u)\n", This, refCount + 1); > > if (!refCount) { > + if (This->dsound) > + IDirectSound_Release(This->dsound); > HeapFree(GetProcessHeap(), 0, This->ppPorts); > HeapFree(GetProcessHeap(), 0, This); > } > > DMUSIC_UnlockModule(); > - > + > return refCount; > } > > @@ -257,10 +260,22 @@ static HRESULT WINAPI IDirectMusic8Impl_GetDefaultPort (LPDIRECTMUSIC8 iface, LP > return S_OK; > } > > -static HRESULT WINAPI IDirectMusic8Impl_SetDirectSound (LPDIRECTMUSIC8 iface, LPDIRECTSOUND pDirectSound, HWND hWnd) { > - IDirectMusic8Impl *This = (IDirectMusic8Impl *)iface; > - FIXME("(%p, %p, %p): stub\n", This, pDirectSound, hWnd); > - return S_OK; > +static HRESULT WINAPI IDirectMusic8Impl_SetDirectSound(LPDIRECTMUSIC8 iface, LPDIRECTSOUND dsound, HWND wnd) > +{ > + IDirectMusic8Impl *This = (IDirectMusic8Impl *)iface; > + > + FIXME("(%p, %p, %p): partial implementation\n", This, dsound, wnd); > + > + if (dsound) > + { > + This->dsound = dsound; > + IDirectSound_AddRef(dsound); > + } > + > + /* If no direct sound object is given, native does not create one yet */ > + This->dsound_inited = TRUE; > + > + return S_OK; > } > > static HRESULT WINAPI IDirectMusic8Impl_SetExternalMasterClock (LPDIRECTMUSIC8 iface, IReferenceClock* pClock) { > diff --git a/dlls/dmusic/dmusic_private.h b/dlls/dmusic/dmusic_private.h > index c05adf0..b0655d6 100644 > --- a/dlls/dmusic/dmusic_private.h > +++ b/dlls/dmusic/dmusic_private.h > @@ -96,6 +96,8 @@ struct IDirectMusic8Impl { > IReferenceClockImpl* pMasterClock; > IDirectMusicPort** ppPorts; > int nrofports; > + BOOL dsound_inited; > + IDirectSound* dsound; > }; > > /***************************************************************************** > > >

2 1

Re: [PATCH 3/3] dmsynth: Put port caps that match native ones.
by Andrew Eikum March 29, 2012

March 29, 2012

Just to be clear, which "native" do you mean? Does this match Windows 7's dmusic behavior, or something else? I've been trying to target Windows 7's behavior in the new audio design. Also... On Thu, Mar 29, 2012 at 08:53:52AM +0200, Christian Costa wrote: > - obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB | DMUS_EFFECT_CHORUS | DMUS_EFFECT_DELAY; > + obj->pCaps.dwEffectFlags = DMUS_EFFECT_REVERB; /* DMUS_EFFECT_CHORUS | DMUS_EFFECT_DELAY */ I'd just remove the unused flags. No need for crufty comments.

2 1

Re: po: Update German translation
by Julian Rüger March 29, 2012

March 29, 2012

Hi André, Am Dienstag, den 27.03.2012, 21:43 +0200 schrieb André Hentschel: > --- > po/de.po | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > #: jscript.rc:37 >-#, fuzzy > #| msgid "Invalid parameter.\n" > msgid "Invalid character" >-msgstr "Ungültiger Parameter.\n" >+msgstr "Ungültiges Zeichen" du solltest die alte msgid auch entfernen. (Ist ein neues Feature, wurden schon andere drauf hingewiesen ;) Viele Grüsse, Julian

2 2

Re: [PATCH 1/2] vbscript: Added Mid function implementation
by Marvin March 29, 2012

March 29, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17548 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Added Mid function implementation
by Marvin March 29, 2012

March 29, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17548 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

SoC 2012 Ideas
by Joerg-Cyril.Hoehle＠t-systems.com March 29, 2012

March 29, 2012

Charles Davis wrote: >1) Make Wine use App Sandbox on Mac OS X. >At the very least, I would like to be able to limit Wine's file-system activity to the prefix. I'm not familiar with Mac OS X' particular security features, but I wonder why limiting FS activity needs changes in wine? With AppArmor or the like on Linux, you'd define a set of rules living outside of the app. Limiting to the prefix won't work, because /dev/tty and /tmp/X11.socket etc. need be used. All my apps are installed in a directory outside any .wine prefix. There's a symlink from within C:\Programs. How would you take that into account? BTW, I once defined a set of iptable rules to prevent networking for Wine (or was it for a whole user?) based on the consideration that the apps I use have nothing to do with networking. Here too, nothing need be changed in Wine. Regards, Jörg Höhle

2 1

Re: [PATCH 2/3] dmsynth: Check the rigth CLSID to create the DirectMusicSynthSink object.
by Marvin March 29, 2012

March 29, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17544 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] dmsynth: Add basic tests.
by Marvin March 29, 2012

March 29, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17543 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] dmsynth: Add basic tests.
by Marvin March 29, 2012

March 29, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17543 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] dmusic: Add some tests for enumerating and creating ports.
by Marvin March 29, 2012

March 29, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17542 Your paranoid android. === WNT4WSSP6 (32 bit dmusic) === dmusic.c:51: Test failed: CoCreateInstance returned: 80040154 dmusic: unhandled exception c0000005 at 00401347 === W2KPROSP4 (32 bit dmusic) === dmusic.c:51: Test failed: CoCreateInstance returned: 80004002 dmusic: unhandled exception c0000005 at 00401347 === W2K3R2SESP2 (32 bit dmusic) === dmusic.c:51: Test failed: CoCreateInstance returned: 80040154 dmusic: unhandled exception c0000005 at 00401347 === WVISTAADM (32 bit dmusic) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation === W2K8SE (32 bit dmusic) === dmusic.c:51: Test failed: CoCreateInstance returned: 80040154 dmusic: unhandled exception c0000005 at 00401347

1 0

Re: winspool.drv: Update allowed driver Version
by Marvin March 28, 2012

March 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17541 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

RFC: Duplicate in/out device naming
by Andrew Eikum March 28, 2012

March 28, 2012

I'm working on Bug 14559 and have run into an interesting UI problem. In WinMM, there are three "classes" of devices: waveIn, waveOut, and mixer. Windows 7's WinMM implementation provides one mixer for each waveIn and waveOut device. The "WCHAR caps.szPname[32]" field for the matching mixer and waveIn/Out device are the same. Some applications, in this case Rosetta Stone 3, use the matching szPname fields to determine which mixer to associate with which device. The problem turns up when we have duplicate input and output device names. Consider: waveOut: 0: default 1: HDA Intel Analog 2: HDA Intel Digital waveIn: 0: default 1: HDA Intel Analog mixer: 0: default 1: HDA Intel Analog 2: HDA Intel Digital 3: default 4: HDA Intel Analog Rosetta Stone chooses waveIn[0] and starts iterating over the mixers' szPname fields, finding that mixer[0] matches. But, mixer[0] is actually associated with the waveOut default, not the waveIn default. Bad things happen. Windows 7 solves this problem implicitly by providing unique device names at the MMDevAPI level. For instance, the input device is Microphone and the output devices are Stereo and Headphones. Hacking the registry to force duplicate MMDevAPI device names actually does result in duplicate mixer names. But Wine's backends don't provide this kind of information, so we simply provide the ALSA device name as the device's name. As an attempt to solve this in Wine, I added a prefix to each MMDevice indicating its flow direction. The unique identifier must be a prefix, as WinMM's szPname field truncates at 31 characters. This gives WinMM device names like: waveOut: 0: Out: default 1: Out: HDA Intel Analog 2: Out: HDA Intel Digital This solves the Rosetta Stone issue, as you can see in the bug. But when testing this in other applications, it quickly becomes silly. Audacity 1.3 adds its own "Out: " prefix to WinMM device names, creating "Out: Out: default" in the UI. Dynamically adding prefixes only if a duplicate device is present causes issues with duplicates appearing/disappearing. Trying to remember if a duplicate has ever been present is quite "ugly" in code, requiring storing that kind of information in the registry. So I don't know what to do. Have ugly, redundant device names? Leave Rosetta Stone broken, as it is arguably an application bug? Try to guess at the device type, and insert names like "Speakers" and "Microphone" into the MMDevAPI device name, even if that might be wrong? Thoughts? Andrew

3 2

Re: [2/4] scrrun: Register Scripting interfaces (try 2)
by Alexandre Julliard March 28, 2012

March 28, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -4,4 +4,6 @@ C_SRCS = scrrun.c > > RC_SRCS = scrrun.rc > > +IDL_TLB_SCRS = scrrun.idl This can't possibly do anything. I've fixed it up, but please test your code before sending, it's not the first time you send a registration patch that doesn't register anything. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] strmbase: Display dll in which we are searching a class to instanciate.
by Alexandre Julliard March 28, 2012

March 28, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -360,14 +361,17 @@ HRESULT WINAPI STRMBASE_DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID * > break; > } > > + if (!GetModuleFileNameA(g_hInst, dllname, sizeof(dllname))) > + strcpy(dllname, "???"); You don't want to do that in the success case. -- Alexandre Julliard julliard(a)winehq.org

2 3