March 2012 - Wine-Devel - list.winehq.org

Re: [PATCH] implement MSIMODIFY_MERGE function in TABLE_modify
by Dmitry Timoshkov March 26, 2012

March 26, 2012

Andoni Morales <ylatuya(a)gmail.com> wrote: > - case MSIMODIFY_REPLACE: > case MSIMODIFY_MERGE: > + /* check for a duplicated key */ > + r = msi_table_find_row( tv, rec, &row, column ); > + if (r == ERROR_SUCCESS) { > + /* check that both are identical */ > + r = compare_record (tv, row, rec); > + if (r != ERROR_SUCCESS) > + break; > + } else { > + r = table_validate_new( tv, rec, NULL ); > + if (r != ERROR_SUCCESS) > + break; > + r = TABLE_insert_row( view, rec, -1, FALSE ); > + break; > + } > + > + case MSIMODIFY_REPLACE: > case MSIMODIFY_VALIDATE: Please get rid of redundant 'break' statements, and add one at the end of case processing. -- Dmitry.

1 0

PDB format documentation.
by Svyatoslav Kuzmich March 26, 2012

March 26, 2012

Hello dear Wine mailing list! I've found that Wine dbghelp.dll includes PDB file parser. Does anyone know where I can find documentation of PDB internal structure? Thanks, Svyatoslav Kuzmich

2 1

Re: My Idea for GSOC
by Daniel Oom March 25, 2012

March 25, 2012

I think I accidentally dropped wine-devel, I have re-added and hope it does not create any trouble. And thanks for the explanation, but I'm not sure I fully understand how the different versions of direct3d interact within wine's implementation. I will probably figure it out in time. Also I will try to come up with a better test that compares lighting-settings as this was fun and fine introduction to wine. On Wed, Mar 21, 2012 at 15:18, Stefan Dösinger <stefandoesinger(a)gmx.at>wrote: > Hi, > > Did you run the test on Windows? The purpose of the tests is not do > document > what we think should happen, but figure out how Windows behaves, and then > replicate the same behavior. > > Is suspect your test fails on Windows because you're verifying that > lighting > is on or off in the wrong way. IDirect3DDevice2_GetRenderState(device, > D3DRENDERSTATE_LIGHTING, &value) will most likely not work in this way > because > D3DRENDERSTATE_LIGHTING does not exist in IDirect3DDevice2. You have to > set up > the d3d states in a way that rendering produces a different result with > lighting on vs lighting off, then read back the rendering result(there's > already a get_pixel_color function for that) and verify that you get the > correct color. > > A basic recipie for that: With lighting off, you get the diffuse color in > the > vertex as final color(well, assuming that stuff like texturing, fog, etc. > are > off too). With lighting on it runs through the d3d lighting > calculations[1]. > If you disable all lights(d3d default), set the global ambient light to > black(in later d3d there's a renderstate for that, in d3d2 I suspect that's > part of D3DLIGHT and IDirect3DLight*), and set the emissive material > property > to a color != black, your emissive color will be the final color(since the > ambient, diffuse and specular components of the equation are zero). By > setting > the vertex color and emissive material color to different colors you can > tell > if lighting is on or off. > > Cheers, > Stefan > > PS: It's prefered to keep such discussions in public, ie with wine-devel > CCed. > I haven't CCed wine-devel yet, and I'm not sure if you dropped it or if I > dropped it accidentally. > > 1: http://msdn.microsoft.com/en- > us/library/windows/desktop/bb147178(v=vs.85).aspx > > Am Mittwoch, 21. März 2012, 09:25:40 schrieb Daniel Oom: > > I have poked around a bit with the source and managed to add tests that > > checks if lighting is disabled/enabled in device2 and device7. I also > added > > SetRenderState in IDirect3DDeviceImpl_2_DrawPrimitive. The tests works > but > > I have not checked what effect the change has in other circumstances. > > > > I attached a patch in hopefully the preferred format. > > > > On Sat, Mar 10, 2012 at 22:04, Stefan Dösinger > <stefandoesinger(a)gmx.at>wrote: > > > Am Samstag, 10. März 2012, 17:22:51 schrieb Daniel Oom: > > > > Hi, > > > > > > > > Writing tests, or implementing the command line tools seems like > > > > something I could do. I'm kinda leaning towards the command line > > > > tools, since it would offer a chance to thoroughly learn the shading > > > > languages. > > > > > > For learning purposes writing tests and fixing bugs uncovered by them > > > will be > > > better. The command line tools are mostly about parsing parameters and > > > forwarding them to d3dx9 functions(*). > > > > > > If you want to look a little bit in either proposal(we recommend that > in > > > general): > > > > > > For the test stuff, take a look at IDirect3DDeviceImpl_2_DrawPrimitive > > > in > > > dlls/ddraw/device.c. It thunks IDirect3DDevice2::DrawPrimitive to > > > IDirect3DDevice7::DrawPrimitive. The main difference is the VertexType > > > parameter. It is a D3DVERTEXTYPE in the IDirect3DDevice2 method, and a > > > DWORD > > > with D3DFVF_* flags in Device7. Our thunk simply converts between these > > > two, > > > but a deeper difference a user noticed is that D3DVT_LVERTEX in Device2 > > > disables lighting calculations, whereas the equivalent D3DFVF flag > > > collection > > > in Device3 and Device7 does not. Device3 and newer have > > > D3DRENDERSTATE_LIGHTING to enable / disable lighting, but this render > > > state does not exist in Device2. > > > > > > Fixing this is fairly straightforward, just call > > > SetRenderState(LIGHTING, > > > ...) > > > in the thunk, but it needs some tests to answer / show the following: > > > > > > * Show that D3DVT_LVERTEX indeed disables lighting, and D3DVT_VERTEX > > > enables > > > it > > > * Show that D3DFVF_LVERTEX does not influence lighting in Device2 and > > > Device7(D3DFVF_TLVERTEX disables all vertex processing in all d3d > > > versions, this is already tested and implemented) > > > * Test what happens when you call SetRenderState and GetRenderState in > > > Device2. > > > * Probably others > > > > > > There are numerous things like that that need testing and probably > > > fixes. > > > This > > > is just one example that happens to be on my todo list. ddraw tests go > > > to > > > dlls/ddraw/tests/ddraw*.c. The other files should be moved to the > > > tests/ddraw*.c files and extended to cover all ddraw versions. > > > > > > For the command line tools, download an older version of the directx > sdk > > > that > > > still has vsa.exe and psa.exe(I think 2007 ones were the last ones) and > > > compare their command line parameters to > > > d3dx9.D3DXAssembleShaderFromFile > > > and > > > friends. > > > > > > The tests are certainly the more useful task. vsa.exe and psa.exe would > > > mainly > > > serve developer convenience when writing d3d8 and d3d9 tests since we > > > wouldn't > > > need an ancient dx sdk to assemble our own test shaders. d3d tests and > > > fixes > > > fix actual games. > > > > > > Enjoy, > > > Stefan > > > > > > (*) Actually, that's not how native vsa/psa work. They seem to have > > > their > > > own > > > copy-pasted version of the compiler and assembler, or they link > > > statically. We > > > should probably do it by calling d3dx9 though, especially for tools > that > > > mainly serve developer convenience. >

2 2

re: PDB format documentation.
by Dan Kegel March 25, 2012

March 25, 2012

Svyatoslav wrote: > I've found that Wine dbghelp.dll includes PDB file parser. Does anyone > know where I can find documentation of PDB internal structure? I think you've found it :-) As you probably know, PDB is an undocumented format. I suspect the best you can find are scattered posts like http://moyix.blogspot.com/2007/08/pdb-stream-decomposition.html http://www.godevtool.com/Other/pdb.htm from people who reverse engineer bits of it. Although http://moyix.blogspot.com/2007/08/pdb-stream-decomposition.html claims http://ccimetadata.codeplex.com/ has some interesting bits from the horse's mouth, and http://code.google.com/p/pdbparse/ http://code.google.com/p/pdbparser/ http://pdbparser.codeplex.com might be interesting.

1 0

re: GSoC proposal
by Dan Kegel March 25, 2012

March 25, 2012

> submitting multiple proposals are explicitly allowed. True, but be careful, for two reasons: 1) there may have been cases where people who submit applications to two orgs fall through the cracks, with each org thinking the other was going to take him. 2) passion generally drives success, and unless you're like my friend who didn't sleep and got a triple major in four years (and now heads chip development for a major game console), splitting your passion between multiple applications could reduce the chances of either one being accepted. Going a bit further with a single application, e.g. by including [more] working patches, seems the better choice... assuming you pick a project that the organization really likes, anyway.

1 0

Wine and Window Management
by Roger Cruz March 25, 2012

March 25, 2012

Could someone tell me if Wine has a built-in Window Manager of its own or does it count on the host's window manager for such things as window hierarchy (parent-child relationships), clipping, move, resize, iconify, etc? I want to run Wine on an environment which lacks X and I have been told conflicting information on whether I need to write my own window manager. It has always been my impression that Wine does all the window management so it must have a Windows window manager built-in. I'm interested in knowing that if I remove the X11 driver from Wine, whether I will have to also provide my own window manager or whether what is in Wine is sufficient. If there is a window manager in Wine, what type of functionality does it require from whatever I chose to replace X11 with? Thanks Roger R. Cruz

2 1

Re: GSoC proposal
by Hin-Tak Leung March 25, 2012

March 25, 2012

--- On Sun, 25/3/12, Cheer Xiao <xiaqqaix(a)gmail.com> wrote: > 2012/3/25 Hin-Tak Leung <htl10(a)users.sourceforge.net>: > > --- On Sun, 25/3/12, Cheer Xiao <xiaqqaix(a)gmail.com> > wrote: > > > > <snipped> > >> So according to you and the thread Jerome > mentioned, uxtheme > >> is one of > >> the more tricky and less rewarding areas; so I will > set it > >> aside for > >> the moment and work on the IME proposal instead. > > <snipped> > > > > There is no reason why you cannot submit two proposals, > if you are interested in two areas. You do not get penalized > for doing that, other than your own time of preparing two > proposals, which is twice the preparation work. > > > > In fact it is quite common for GSoC students to apply > for more than one project under different/same > organization. > > > > From the organization's point of view, it may be a good > decision to give the project to the strongest candidate if > there are multiple students applying to the same area; or > not to take up any student for lack of interests (from > mentors); in which case you might be still be taken up and > assigned to your "2nd" choice project. > > > > (poor applications - showing no understandings of the > background technology, etc - are rejected, so in that sense > you are penalized if you cannot devote enough time to your > proposal(s), if you divide your efforts). > > > > Thanks for the clarification. On the "multiple proposals" idea, in fact it is explicitly in the GSoC application schedule that there is a final decision afternoon or something, at which some organization admins come together to decide which organization would take a student, if a student had submitted multiple strong proposals to multiple organizations, and multiple organizations had decided to accept the same student to work on two different proposals. So submitting multiple proposals are explicitly allowed. Obviously, if you submit two proposals to the *same* organization, one of your applications would certainly be dropped at some intermediate stage before reaching that final stage, because they are reviewed by the same people (and there are some communications/decisions between organizations *before* that final stage, if multiple applications are made) . This is just because a student cannot be actually working on two projects over the same summer period, so all except one proposals must be turned down/withdrawn *eventually*. I am just saying that, if you feel like you could be happy working on more than one area, and is confident you can get a good proposal in for each (for the same organization, or different ones), by all means submit more than one proposals.

1 0

RFC: A donation for Corel Draw 12 - support.
by Gerold Jens Wucherpfennig March 24, 2012

March 24, 2012

Hi, how much money do I have to donate to winehq.org to let someone fix Wine for CorelDraw 12? http://appdb.winehq.org/objectManager.php?sClass=version&iId=2390 Installation worked, but Corel is not usable and only reports: "Registry Corrupt - The UI Language registration list is invalid" I've donated a few dollars some years ago to wine and I even coded some cabinet.dll stuff some years ago... Maybe someone can help me with fixing this? Best Regards, Gerold

1 0

XTestFakeKeyEvent events postponed until wine process exits
by Ilya Basin March 24, 2012

March 24, 2012

Hi list. Currently SendInput() works only with wine windows. I need to send keypresses to all windows, so I created a winelib dll that uses XTestFakeKeyEvent. I call this function from a wine process, but all my fake key presses wait for the process to exit. What is the reason?

1 0

Re: [website] Spanish translation for release 1.5.0
by Frédéric Delanoy March 24, 2012

March 24, 2012

On Sat, Mar 24, 2012 at 12:13, Eduardo García <eduardo.garcia(a)gmx.com> wrote: > You should send diff using git (e.g. with 'git format-patch -k 1) i.e. sthg like http://source.winehq.org/patches/data/84646

1 0

Re: [PATCH] mscoree: Print the correct values in a TRACE.
by Nicolas Le Cam March 23, 2012

March 23, 2012

Le 23 mars 2012 21:41, Lauri Kenttä <lauri.kentta(a)gmail.com> a écrit : > --- > dlls/mscoree/mscoree_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/mscoree/mscoree_main.c b/dlls/mscoree/mscoree_main.c > index 1aa120f..0ebc813 100644 > --- a/dlls/mscoree/mscoree_main.c > +++ b/dlls/mscoree/mscoree_main.c > @@ -359,7 +359,7 @@ HRESULT WINAPI GetRequestedRuntimeInfo(LPCWSTR pExe, LPCWSTR pwszVersion, LPCWST > > HRESULT WINAPI GetRequestedRuntimeVersion(LPWSTR pExe, LPWSTR pVersion, DWORD cchBuffer, DWORD *dwlength) > { > - TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), debugstr_w(pExe), cchBuffer, dwlength); > + TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), pVersion, cchBuffer, dwlength); > > if(!dwlength) > return E_POINTER; > -- > 1.7.9.4 > > > Hi Lauri, Should be %s debugstr_w(pVersion) IMHO. -- Nicolas Le Cam

2 2

Re: mscoree: Print the debug string and not the pointer to it.
by Lauri Kenttä March 23, 2012

March 23, 2012

On 2012-03-22 00:36, Michael Stefaniuc wrote: > HRESULT WINAPI GetRequestedRuntimeVersion(LPWSTR pExe, LPWSTR > pVersion, DWORD cchBuffer, DWORD *dwlength) > { > - TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), debugstr_w(pExe), > cchBuffer, dwlength); > + TRACE("(%s, %s, %d, %p)\n", debugstr_w(pExe), debugstr_w(pExe), > cchBuffer, dwlength); Why is pExe printed two times? Maybe the second one should be pVersion? -- Lauri Kenttä

2 1

GSoC 2012 - Implement a few missing functions in D3DX9
by Józef Kucia March 21, 2012

March 21, 2012

Hi there, I'm writing to discuss my project proposal for upcoming Google Summer of Code. I was recently playing with Wine, looking around in the code and searching through Wine bugzilla. As a result I found out that there is still a quite number of functions missing in Wine's D3DX implementation. However, some of them are probably not used much in a real software. For example, the mostly unimplemented ID3DXSkinInfo interface seems to be not used frequently. In this email I would like to present things which I would like to implement. I hope that implementation of this functions, or at least some of them, could improve Wine compatibility with a few real applications. I would like to implement the following things: * Implement D3DXCreateRenderToSurface function and ID3DXRenderToSurface interface. * Finish the implementation of ID3DXFont, particularly ID3DXFont::DrawTextA and ID3DXFont::DrawTextW functions. * Implement D3DXCreateCubeTextureFrom* and D3DXCreateVolumeTextureFrom* functions. * Add support for DDS file format in D3DXGetImageInfoFrom* functions. I think I could also implement a few missing functions in ID3DXConstantTable interface, as a bonus task. I'm looking forward for a feedback. If you find any D3DX's function more important than functions enumerated by me, please let me know. I'm also looking for applications with heavy usage of D3DX dlls, especially applications which are using unimplemented or partially implemented functions (yes, I'm aware about http://wiki.winehq.org/DirectX-D3DX9) Cheers, Józef Kucia

4 8

Updating GSoC proposal
by Jacek Caban March 21, 2012

March 21, 2012

Hi all, GSoC is starting this year and, if we want to have good applications, we need to update our proposals. Usually the most attention is directed into adding new ones, while we keep obviously bad (or just bad IMO) proposals on the page. I'm planning to remove following project proposals: Security - implement sandboxing Theming - Implement Wine theming support NTDLL - support performance registry keys Winelib Aware Scons (or cmake) Cleanup Winemenubuilder to support generating Application Bundles on Mac OS X Wine-based application virtualization If someone knows a reason to not remove them, please reply. Cheers, Jacek

9 16

Re: Changed UrlGetPartA and UrlGetPartW to return the correct (different) values.
by Nikolay Sivov March 21, 2012

March 21, 2012

On 3/21/2012 09:24, Eric Culp wrote: > On Wed, Mar 21, 2012 at 2:59 AM, Nikolay Sivov <bunglehead(a)gmail.com > <mailto:bunglehead(a)gmail.com>> wrote: > > On 3/21/2012 08:58, Eric Culp wrote: > > The two functions have different return values on windows for > analogous inputs. > Changed to match windows behavior. > --- > dlls/shlwapi/url.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > Please add some tests for that. > > I think it's already covered by > > dlls/shlwapi/tests/url.c:672 > res = pUrlGetPartA("hi", szPart, &dwSize, URL_PART_SCHEME, 0); > ok (res==S_FALSE, "UrlGetPartA(\"hi\") returned %08X\n", res); > > and > > dlls/shlwapi/tests/url.c:685 > res = pUrlGetPartW(hiW, bufW, &dwSize, URL_PART_SCHEME, 0); > todo_wine ok(res==S_OK, "UrlGetPartW(\"hi\") returned %08X\n", res); > > Line 686 was the one that previously triggered a todo. Should the > todo_wine be removed? Yes, you should run 'make test' and get no errors after your changes. If you fixed todo it should be removed, if you break existing test you should fix your patch. > > > >

1 0

Re: Changed UrlGetPartA and UrlGetPartW to return the correct (different) values.
by Nikolay Sivov March 21, 2012

March 21, 2012

On 3/21/2012 08:58, Eric Culp wrote: > The two functions have different return values on windows for analogous inputs. > Changed to match windows behavior. > --- > dlls/shlwapi/url.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) Please add some tests for that.

1 0

re: Are we the reason Apple isn't helping us?
by Dan Kegel March 21, 2012

March 21, 2012

Vitaliy wrote: > Can you show me exactly where did I yell at him? Or where I wasn't polite enough I think it was http://bugs.winehq.org/show_bug.cgi?id=29922#c14 where you wrote "Would bugzilla admin please remove / ban this user? Jeremy, you've been told by the only person who commits stuff to Wine - Everything working fine, there is nothing to fix. Period, conversation over. If you reopen this bug it will be an indication to bad your user record." There ought to be some wiggle room granted people who work at important neighboring projects who are unable for whatever reason to follow Wine's usual conventions; at the very least, we shouldn't actively drive them away like that. - Dan

6 10

Re: usp10: properly handle invalide arguments to ScriptBreak
by Nikolay Sivov March 19, 2012

March 19, 2012

On 3/19/2012 18:56, Aric Stewart wrote: > Fix for bug 30219 > --- > dlls/usp10/usp10.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Could you add a test for that? Or there's some troubles with that, like different native usp10 versions behaviour or anything? >

1 0

Networking+wine
by prateek papriwal March 19, 2012

March 19, 2012

Networking + wine (like as running uTorrent in ubuntu) can be very dangerous. I feel there should be some sandboxing(as in Windows) to prevent frequent attacks. I would be very interested in implementing sandboxing for running Wine applications. Thank you Prateek

3 3

Re: [1/2] msvcrt: Add tmpfile_s implementation (resend)
by Alexandre Julliard March 18, 2012

March 18, 2012

André Hentschel <nerv(a)dawncrow.de> writes: > +int CDECL MSVCRT_tmpfile_s(MSVCRT_FILE** file) > +{ > + if (!file) { > + *MSVCRT__errno() = MSVCRT_EINVAL; > + return MSVCRT_EINVAL; > + } That's not the right way to check parameters in _s functions. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: po: Update Polish translation.
by Frédéric Delanoy March 17, 2012

March 17, 2012

On Sat, Mar 17, 2012 at 19:27, Łukasz Wojniłowicz <lukasz.wojnilowicz(a)gmail.com> wrote: > Dnia sobota, 17 marca 2012 15:29:25 piszesz: >> On Fri, Mar 16, 2012 at 20:15, Łukasz Wojniłowicz >> >> <lukasz.wojnilowicz(a)gmail.com> wrote: >> > --- >> > po/pl.po | 70 >> > ++++++++++++++++++++++++++++--------------------------------- 1 files >> > changed, 32 insertions(+), 38 deletions(-) >> > >> > #: cryptui.rc:296 >> > -#, fuzzy >> > #| msgid "Cryptographic Message Syntax Standard/PKCS #7 Messages >> > (.p7b)" >> >> Those #| lines must be removed as well (previous msgid) >> >> Frédéric > > I edited it through lokalize (computer aided translation application) and it > didn't remove it. Is it vital for this patch to be accepted? AJ doesn't want those, and I agree (no need for former msgid when the entry is updated: that's just noise) I guess it should appear as comment in localize (not tested), or else you can use an editor/sed to remove those. Frédéric

1 0

Re: po: Update Polish translation.
by Frédéric Delanoy March 17, 2012

March 17, 2012

On Fri, Mar 16, 2012 at 20:15, Łukasz Wojniłowicz <lukasz.wojnilowicz(a)gmail.com> wrote: > --- > po/pl.po | 70 ++++++++++++++++++++++++++++--------------------------------- > 1 files changed, 32 insertions(+), 38 deletions(-) > > #: cryptui.rc:296 > -#, fuzzy > #| msgid "Cryptographic Message Syntax Standard/PKCS #7 Messages (.p7b)" Those #| lines must be removed as well (previous msgid) Frédéric

1 0

What happened to my patch? --> msvcrt/file.c: file mode T (temporary file) (try 4)
by Robert van Herk March 17, 2012

March 17, 2012

Hi all, I never heard from my patch again. Has it fallen into a void? Kind regards, Robert From: mijnspamboxje(a)hotmail.com To: wine-patches(a)winehq.org Subject: msvcrt/file.c: file mode T (temporary file) (try 4) Date: Tue, 28 Feb 2012 20:55:07 +0100 Dear all, Hereby try 4. Tested by Marvin through my brand new Marvin-test-account... Kind regards, Robert van Herk

2 2

Regarding GSoC 2012 project Ideas
by Jaldeep Vasavada March 17, 2012

March 17, 2012

Hello, I am Jaldeep, studying Computer Science, in BITS Pilani, India. I checked some projects described on GSoC website. I am interested to work with a project in CMD-project, a parser implementation. Can you please guide in brief about the project work? Can you please explain me the procedure about application for a particular project? Thank You -- Regards Jaldeep Vasavada

1 0

Vacation
by Alexandre Julliard March 16, 2012

March 16, 2012

Folks, I'll be on vacation for a week, so there won't be any commits. Hopefully we have caused enough regressions in 1.5.0 to keep all you busy ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0