April 2012 - Wine-Devel - list.winehq.org

Re: [PATCH] wined3d: When releasing resources, don't perform any other operations on device if it has been released.
by Henri Verbeet April 2, 2012

April 2, 2012

This looks wrong. Is there a legitimate way that this can happen?

2 3

Wine test bot and win16 exe
by Christian Costa April 1, 2012

April 1, 2012

Hi, I wrote a win16 exe test file using open watcom but I cannot submit it to winebot. I fails saying "Unricognized file type". This is a little annoying. Is this a known limitation of wine test bot ? Thanks Christian

2 1

Re: d3dx9: Implement D3DXCreatePolygon
by Józef Kucia April 1, 2012

April 1, 2012

On Sun, Apr 1, 2012 at 10:43 PM, David Adam <david.adam.cnrs(a)gmail.com> wrote: > + *mesh = polygon; > + > + if (adjacency) > + { > + hr = D3DXCreateBuffer(3 * sides * sizeof(DWORD), &adjacency_tmp); > + if (FAILED(hr)) return hr; You should release the polygon mesh. Also, you probably shouldn't touch *mesh when the function fails. -- Józef Kucia

1 0

Re: shell32: Added stubs for IMarshal interface (resend)
by Jacek Caban April 1, 2012

April 1, 2012

Hi Gaurav, On 3/31/12 9:22 PM, Gaurav Jain wrote: > shell32: Added stubs for IMarshal interface (resend) > > Resending due to previous code freeze. > > ShellLink_QueryInterface() did not have a lookup for the IMarshal Interface. This resulted in an error message popping up in the Quest for Glory II (remake) installer. Providing IMarshal interface stubs avoids this error behaviour. > IMarshal is an interface that has serious impact on how the object is handled in RPC calls and the fact that you see better behavior in an app may be very well a side effect of Wine behaving badly, but in a different (more friendly for given application) way. The first question is does the object really implements custom IMarshal implementation on Windows? Cheers, Jacek

2 1

Re: [2/2] gdi32: Simplify font cache. (try 2)
by Alexandre Julliard April 1, 2012

April 1, 2012

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > @@ -1516,23 +1464,8 @@ static void add_face_to_cache(Face *face) > RegSetValueExW(hkey_face, face_full_name_value, 0, REG_SZ, (BYTE*)face->FullName, > (strlenW(face->FullName) + 1) * sizeof(WCHAR)); > > - reg_save_dword(hkey_face, face_index_value, face->face_index); > - reg_save_dword(hkey_face, face_italic_value, (face->ntmFlags & NTM_ITALIC) != 0); > - reg_save_dword(hkey_face, face_bold_value, (face->ntmFlags & NTM_BOLD) != 0); > - reg_save_dword(hkey_face, face_version_value, face->font_version); > - reg_save_dword(hkey_face, face_external_value, face->external); > - > - RegSetValueExW(hkey_face, face_font_sig_value, 0, REG_BINARY, (BYTE*)&face->fs, sizeof(face->fs)); > + RegSetValueExW(hkey_face, face_value, 0, REG_BINARY, (BYTE*)face, sizeof *face); I don't think that's a good idea. There are many things in the structure that don't make sense to have in the registry. Also this won't work on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: d3dx9_36: Implement D3DXSHDot
by Rico Schüller April 1, 2012

April 1, 2012

Am 01.04.2012 04:33, schrieb David Adam: + * Order is not limited by D3DXSH_MINORDER and D3DXSH_MAXORDER! + * All values will work, test from 0-7 [D3DXSH_MINORDER = 2, D3DXSH_MAXORDER = 6] + * Exceptions will show up when out, in1 or in2 are NULL + */ + for (k = 0; k < 8; k++) Where is the variable out? Cheers Rico

1 0