April 2012 - Wine-Devel - list.winehq.org

Re: ws2_32: Fix hostent memory allocation
by Alexandre Julliard April 16, 2012

April 16, 2012

Bruno Jesus <00cpxxx(a)gmail.com> writes: > @@ -5546,24 +5546,70 @@ INT WINAPI WSAUnhookBlockingHook(void) > * pointers (via a template of some kind). > */ > > -static int list_size(char** l, int item_size) > +/*********************************************************************** > + * list_size (INTERNAL) > + * > + * Calculate the size of data and number of items from a list based on > + * a fixed item size or strings by using strlen. The source list must be > + * NULL terminated. > + * > + * PARAMS > + * l [I] Pointer to array of source items. > + * item_size [I] Fixed item size or zero if it's a string list. > + * size_sum [O] Pointer to where the sum of item bytes will be > + * stored. May be NULL if not required by the caller. > + * item_count [O] Pointer to where the number of items bytes will be > + * stored. May be NULL if not required by the caller. > + * > + * NOTES > + * When item_size is zero the byte sum will also count the NULL > + * terminator for each string. > + */ > +static void list_size(char** l, int item_size, int *size_sum, int *item_count) > { > - int i,j = 0; > - if(l) > - { for(i=0;l[i];i++) > - j += (item_size) ? item_size : strlen(l[i]) + 1; > - j += (i + 1) * sizeof(char*); } > - return j; > + int s, c, *sum = (size_sum ? size_sum : &s), *count = (item_count ? item_count : &c); > + *sum = *count = 0; > + if(l) > + { > + for(;l[*count];(*count)++) > + *sum += (item_size) ? item_size : strlen(l[*count]) + 1; > + } That's not a good helper function, with all the optional parameters and various behaviors. Also if you need a big documentation block like this for a 5-line function it's a sign that something is wrong. -- Alexandre Julliard julliard(a)winehq.org

2 1

WASAPI ISimpleAudioVolume::SetMasterVolume appears to not work
by adam smith April 16, 2012

April 16, 2012

Hi, I've been trying to get WASAPI audio output working for our app as Directsound output was very glitchy post the new audio stack. All seems to work great with WASAPI however I need to able to set the volume level independently for individual audio sessions / streams for crossfading however I'm having problems controlling the volume levels of a shared mode audio session / stream. specifically, ISimpleAudioVolume::SetMasterVolume http://msdn.microsoft.com/en-us/library/windows/desktop/dd316537(v=vs.85).a… Doesn't seem to work under Wine i.e. HRESULT hr; hr=audioClient_->GetService(IID_ISimpleAudioVolume,(void**)&simpleAudioVolume_); if (SUCCESS(hr)) hr=simpleAudioVolume_->SetMasterVolume(0.1,NULL); returns success but does not change the volume level though interestingly HRESULT hr; hr=audioClient_->GetService(IID_ISimpleAudioVolume,(void**)&simpleAudioVolume_); if (SUCCESS(hr)) hr=simpleAudioVolume_->SetMute(TRUE,NULL); does work and mute the volume. I've also tried usingsthe IAudioStreamVolume interface to control the volume again to no avail. Does anyone have any experience of these interfaces or know equivalent interfaces to use instead working I've tested on : Ubuntu 10.04, 11.10 Wine 1.4 , 1.5 , 1.5.2 PulseAudio 0.9.21 , 1.0 , no pulse audio (and windows 7 where the code works fine) Thanks, Adam

2 1

Re: jscript: Make sure to jump out of switch before entering implicit default clausule
by Marvin April 16, 2012

April 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17883 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Testbot certificate has expired
by Morten Rønne April 16, 2012

April 16, 2012

Hi testbot.winehq.com certificate expired on 13-04-2012. So now the wininet tests in dlls/wininet/tests/http.c are failing with an error for me. I can't determine if the fault are in the test or the function called should handle the error case. The error message is: err:wininet:NETCON_secure_connect SSL_connect failed: 12037 http.c:2873: Test failed: HttpSendRequest failed: 12037 wine: Unhandled page fault on read access to 0x00000008 at address 0x68a876c5 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x68a876c5). Best Regards Morten Rønne

2 1

Re: gdi32: Add support for emulating bold faces of bitmap fonts.
by Huw Davies April 16, 2012

April 16, 2012

On Mon, Apr 16, 2012 at 04:37:39PM +0900, Dmitry Timoshkov wrote: > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 0a5d3c3..eb3f9b5 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -5669,12 +5669,27 @@ static inline BYTE get_max_level( UINT format ) > return 255; > } > > -static const BYTE masks[8] = {0x80, 0x40, 0x20, 0x10, 0x08, 0x04, 0x02, 0x01}; > +static void emulate_bold_glyph(BYTE *buf, int pitch, int height) > +{ > + int x, y; > + BYTE *p = buf; > + > + for (y = 0; y < height; y++) > + { > + for (x = pitch - 1; x >= 0; x--) > + { > + p[x] |= p[x] >> 1; > + if (x > 0) p[x] |= p[x - 1] << 7; > + } > + p += pitch; > + } > +} > Don't we need to add some bytes if glyph_width % 32 == 0 ? Huw.

2 3

Re: msvcp90: Add codecvt ctors and dtors
by Piotr Caban April 16, 2012

April 16, 2012

Hi, On 04/16/12 02:50, William Panlener wrote: > typedef struct { > + locale_facet facet; > + /* FIXME: type definition in standard but var here */ > + enum { ok, partial, error, noconv } result; > +} codecvt_base; This structure has incorrect size. It should not contain result variable. > +typedef struct { > + codecvt_base base; > + /* FIXME: incomplete struct definition */ > +} codecvt_char_char_mbstate; It's better to define whole structure. Also other structures are named differently, it would be probably better to name it codecvt_char. > +typedef struct { > + codecvt_base base; > + /* FIXME: incomplete struct definition */ > +} codecvt_short_char_mbstate; > + > +typedef struct { > + codecvt_base base; > + /* FIXME: incomplete struct definition */ > +} codecvt_wchar_char_mbstate; There's no reason to define separate structures for unsigned short and wchar_t variants of the class. Probably the only difference between this classes is typeinfo structure. > +/* FIXME: Potentially unused */ > +/* ?id@?$codecvt(a)DDH@std@@2V0locale(a)2@A */ > +locale_id codecvt_char_char_mbstate_id = {0}; I don't understand this comment. The id fields will be used by locale class. > +/* ??1codecvt_base(a)std@@UAE(a)XZ */ > +/* ??1codecvt_base(a)std@@UEAA(a)XZ */ > +DEFINE_THISCALL_WRAPPER(codecvt_base_dtor, 4) > +void __thiscall codecvt_base_dtor(codecvt_base *this) > +{ > + FIXME("(%p)\n stub!", this); > + TRACE("(%p)\n", this); > +} There's no need to use both FIXME and TRACE. > +/* ??1?$codecvt(a)DDH@std@@MAE(a)XZ */ > +/* ??1?$codecvt(a)DDH@std@@MEAA(a)XZ */ > +DEFINE_THISCALL_WRAPPER(codecvt_char_char_mbstate_dtor, 4) > +void __thiscall codecvt_char_char_mbstate_dtor(codecvt_char_char_mbstate *this) > +{ > + /*FIXME stub*/ > + codecvt_base_dtor(&this->base); > + TRACE("(%p)\n", this); > +} It's better to print a fixme message here. > +DEFINE_RTTI_DATA(codecvt_char_char_mbstate, 0, 1,&locale_facet_rtti_base_descriptor, NULL, NULL, " ?AV?$codecvt(a)DDH@std@@"); > +DEFINE_RTTI_DATA(codecvt_short_char_mbstate, 0, 1,&locale_facet_rtti_base_descriptor, NULL, NULL, " ?AV?$codecvt(a)GDH@std@@"); > +DEFINE_RTTI_DATA(codecvt_wchar_char_mbstate, 0, 1,&locale_facet_rtti_base_descriptor, NULL, NULL, ".?AV?$codecvt(a)_WDH@std@@"); The RTTI data for these structures is incorrect. > + __ASM_VTABLE(codecvt_base, ""/*FIXME*/); > + __ASM_VTABLE(codecvt_char_char_mbstate, ""/*FIXME*/); > + __ASM_VTABLE(codecvt_short_char_mbstate, ""/*FIXME*/); > + __ASM_VTABLE(codecvt_wchar_char_mbstate, ""/*FIXME*/); It's better to create correct virtual functions table. This may lead to some strange crashes.

1 0

Re: [PATCH 1/3] browseui: Add IOleWindow to IProgressDialog
by Nikolay Sivov April 15, 2012

April 15, 2012

On 4/15/2012 23:08, Detlef Riekenberg wrote: > Used by apps to adjust the dialog position > or remove the cancel button before vista > > -- > By by ... Detlef > --- > dlls/browseui/progressdlg.c | 69 ++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 68 insertions(+), 1 deletions(-) > > diff --git a/dlls/browseui/progressdlg.c b/dlls/browseui/progressdlg.c > index 9b970e2..2807622 100644 > --- a/dlls/browseui/progressdlg.c > +++ b/dlls/browseui/progressdlg.c > @@ -60,6 +60,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(browseui); > > typedef struct tagProgressDialog { > IProgressDialog IProgressDialog_iface; > + IOleWindow IOleWindow_iface; > LONG refCount; > CRITICAL_SECTION cs; > HWND hwnd; > @@ -79,6 +80,11 @@ static inline ProgressDialog *impl_from_IProgressDialog(IProgressDialog *iface) > return CONTAINING_RECORD(iface, ProgressDialog, IProgressDialog_iface); > } > > +static inline ProgressDialog *impl_from_IOleWindow(IOleWindow *iface) > +{ > + return CONTAINING_RECORD(iface, ProgressDialog, IOleWindow_iface); > +} > + > static void set_buffer(LPWSTR *buffer, LPCWSTR string) > { > static const WCHAR empty_string[] = {0}; > @@ -270,9 +276,20 @@ static HRESULT WINAPI ProgressDialog_QueryInterface(IProgressDialog *iface, REFI > ProgressDialog *This = impl_from_IProgressDialog(iface); > *ppvOut = NULL; > > - if (IsEqualIID(iid,&IID_IUnknown) || IsEqualIID(iid,&IID_IProgressDialog)) > + if (IsEqualIID(iid,&IID_IUnknown)) > { > *ppvOut = This; > + TRACE("(%p, IID_IUnknown, %p) -> %p\n", This, ppvOut, This); > + } > + else if (IsEqualIID(iid,&IID_IProgressDialog)) > + { > + *ppvOut = This; > + TRACE("(%p, IID_IProgressDialog, %p) -> %p\n", This, ppvOut, This); > + } > + else if (IsEqualIID(iid,&IID_IOleWindow)) > + { > + *ppvOut =&This->IOleWindow_iface; > + TRACE("(%p, IID_IOleWindow, %p) -> %p\n", This, ppvOut, *ppvOut); > } What's a point in different traces? A single one is enough, with printed riid of course. Also please return iface instead of This, like *ppvOut = iface;, or if you prefer instance pointer add a pointer to interface like - &This->... > > if (*ppvOut) > @@ -495,6 +512,55 @@ static const IProgressDialogVtbl ProgressDialogVtbl = > ProgressDialog_Timer > }; > > +static HRESULT WINAPI OleWindow_QueryInterface(IOleWindow *iface, REFIID iid, LPVOID *ppvOut) > +{ > + ProgressDialog *This = impl_from_IOleWindow(iface); > + > + TRACE("(%p, %s, %p)\n", iface, debugstr_guid(iid), ppvOut); > + return ProgressDialog_QueryInterface(&This->IProgressDialog_iface, iid, ppvOut); > +} > + This trace should go to ProgressDialog_QueryInterface(), no need to place it in every interface.

1 0

Re: ddraw/tests: Compare the correct surface pointers.
by Marvin April 15, 2012

April 15, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17873 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00A70028) === WXPPROSP3 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00BA0028) === W2K3R2SESP2 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00E40028) === WVISTAADM (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02210028) === W2K8SE (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02800028) === W7PRO (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(01BF0028) === W7PROX64 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02740028) === TEST64_W7SP1 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02690028) === W7PROX64 (64 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(0000000000000000) differs from the one returned by Lock(0000000002390040) === TEST64_W7SP1 (64 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(0000000000000000) differs from the one returned by Lock(0000000002360040)

2 1

Re: [PATCH 1/3] browseui: Add IOleWindow to IProgressDialog
by Michael Stefaniuc April 15, 2012

April 15, 2012

Hello Detlef, On 04/15/2012 10:08 PM, Detlef Riekenberg wrote: > Used by apps to adjust the dialog position > or remove the cancel button before vista > > -- > By by ... Detlef > --- > dlls/browseui/progressdlg.c | 69 ++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 68 insertions(+), 1 deletions(-) > > diff --git a/dlls/browseui/progressdlg.c b/dlls/browseui/progressdlg.c > index 9b970e2..2807622 100644 > --- a/dlls/browseui/progressdlg.c > +++ b/dlls/browseui/progressdlg.c > @@ -270,9 +276,20 @@ static HRESULT WINAPI ProgressDialog_QueryInterface(IProgressDialog *iface, REFI > ProgressDialog *This = impl_from_IProgressDialog(iface); > *ppvOut = NULL; > > - if (IsEqualIID(iid, &IID_IUnknown) || IsEqualIID(iid, &IID_IProgressDialog)) > + if (IsEqualIID(iid, &IID_IUnknown)) > { > *ppvOut = This; > + TRACE("(%p, IID_IUnknown, %p) -> %p\n", This, ppvOut, This); > + } > + else if (IsEqualIID(iid, &IID_IProgressDialog)) > + { > + *ppvOut = This; this is not correct as ppvOut takes an interface and not an object. While at it please fix the above one too. thanks bye michael

1 0

[GSoC] Reduce dependency on native dlls
by William Panlener April 15, 2012

April 15, 2012

My name is William Panlener, and I am currently attending the University of Mississippi as a first semester Masters student in Computer Science. This is my first time participating in GSoC. My proposal for GSoC involves choosing an application with high dependence on native dlls and implementing enough stubs so as to eliminate this dependency. I chose the game, League of Legends, and its installer, Pando Media Booster. Most stubs that require implementation are in msvcp90 and wininet. I have two concerns with this proposal: 1) Is it unusual to work towards improving a specific application rather than focusing on a specific component of wine? 2) The scope of the project is difficult to gauge in advance since the next problematic stub cannot be identified until all the previous problematic stubs are taken care of. Is this an issue for a GSoC proposal? I would be more than willing to revise my proposal (if this is allowed) if either of the above points is a problem.

2 1

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)
by Dmitry Timoshkov April 15, 2012

April 15, 2012

Daniel Jelinski <djelinski1(a)gmail.com> wrote: > Skipping tests on WinNT - older versions of comctl send a different > set of events. Then you need to figure out what is different, and make the tests pass there as well (there is 'optional' flag for that), otherwise you risk breaking applications written for NT. > + /* WM_RBUTTONDOWN does not return until it gets another mouse event. > + Make sure it gets one by posting WM_RBUTTONUP to message queue */ > + PostMessageA(hTree, WM_RBUTTONUP, 0, (LPARAM)0x10001); > + /* this sequence should NOT send WM_CONTEXTMENU */ > + SendMessageA(hTree, WM_RBUTTONDOWN, 2, (LPARAM)0x10001); > + > + /* ditch the first sequence as it processed more messages than we need. Redo */ > + flush_sequences(sequences, NUM_MSG_SEQUENCES); > + > + PostMessageA(hTree, WM_RBUTTONUP, 0, (LPARAM)0x10001); > + SendMessageA(hTree, WM_RBUTTONDOWN, 2, (LPARAM)0x10001); This can't work. If you use PostMessage you need to flush message queue before testing the sequence. Using SendMessage after PostMessage doesn't guarantee that a posted message is handled before a sent one, you may try generating hardware messages instead. > + > + if(sequences[PARENT_SEQ_INDEX]->sequence->message == 0x133) > + { > + win_skip("Comctl32 versions prior to 5.80 send different set of events"); > + return; > + } Please use symbolic names for messages instead of magic numbers. -- Dmitry.

4 5

automate winedbg IDE integration
by Ilya Basin April 15, 2012

April 15, 2012

Hi developers. There's a manual on this page: http://www.winehq.org/docs/winedev-guide/dbg-others > Start the Wine debugger with a command line like: > winedbg --gdb --no-start <name_of_exe_to_debug.exe> > Start ddd > In ddd, use the 'Open File' or 'Open Program' to point to the Wine executable (which is either wine-pthread or wine-kthread depending on your settings). > In the output of 1/, there's a line like > target remote localhost:32878 > copy that line and paste into ddd command pane (the one with the (gdb) prompt) So many steps. Is there an easier way? Or maybe everyone use plain winedbg without any IDE?

2 5

winedbg-eclipse - winedbg wrapper for Eclipse IDE
by Ilya Basin April 14, 2012

April 14, 2012

- Get Eclipse 3.7.2 CDT - Import existing code as Makefile (a wine component or a standalone - winelib program) - Check "Automate discovery" in project properties/C/C++ Build/Discovery - Create a standart C/C++ Application debug configuration - Set *.exe.so as application - Set winedbg-eclipse as GDB debugger - fix bugs faster!

1 0

Re: Wine release 1.5.2
by mike＠yurick.ca April 13, 2012

April 13, 2012

I am no longer using this e-mail. Please contact me for my new e-mail address. Thank you, Mike

1 0

Re: vbscript: Short if statement may have optional 'end if'
by Marvin April 13, 2012

April 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17842 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

gdi32/dibdrv: don't add_join if points are coincident in wide_line_segments (try 2)
by Daniel Lehman April 13, 2012

April 13, 2012

try 2 - integrate into existing tests; updated commit message I think the only points in the middle of the points array can cause the crash I was seeing. wide_pen_lines trims coincident points/empty segments from the beginning and end of the array, so the wine_line_segment calls before and after the for loop I modified will always return valid faces

1 0

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending. Resend.
by Vincent Povirk April 13, 2012

April 13, 2012

I ran some of my drawing tests with GdipSetCompositingMode(graphics, CompositingModeSourceCopy), and it looks like native in that mode does roughly what your patch does, except that pixels that would be 100% transparent are not drawn. If a printer device behaves differently then that would be very strange. If it is the same, it probably makes sense to use (and maybe set at graphics creation time if it's appropriate for the HDC) the compositing mode flag. So I guess this is an acceptable approach, and could probably be committed as is and refined later, but it'd be nice if you could look into compositing modes and drawing with 100% transparent colors, since you have a test program set up for printing and I don't.

1 0

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface. (try 2) (resend)
by Marvin April 13, 2012

April 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17840 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] d3drm: Implement IDirect3DRMFrameX_GetParent and update tests. (resend)
by Marvin April 13, 2012

April 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17839 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface. (try 2) (resend)
by Marvin April 13, 2012

April 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17835 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] d3drm: Implement IDirect3DRMFrameX_GetParent and update tests. (resend)
by Marvin April 13, 2012

April 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17832 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Regression testing
by Daniel Jeliński April 12, 2012

April 12, 2012

Hello all, I am trying to get Microsoft SQL Server Management Studio to work flawlessly under Wine. For the most part I create and triage related bug reports, but recently I also started tinkering with code, specifically with comctl library, which I am most familiar with. Back on subject. I thought I found a regression - on Wine 1.4 package downloaded from launchpad the "New query" button works fine, while on my compiled Wine it produces an error. So I did: git reset --hard wine-1.4 make and, surprisingly, I still had the problem with the compiled version. However after some combination of deleting leftover files, running make clean, make depend and make the button started working, so I started bisecting, hoping for the best. At some point I started getting bad versions, and every subsequent compile was bad - even after I ended bisecting and returned to wine-1.4, the button still did not work (and it still works under packaged Wine - I use the same install for all tests). This time make clean && make depend && make did not help. I am comparing what I did to [1], and the only difference I see is that I did not run configure before make. I'll try doing that later, but I think this shouldn't affect the outcome. Any other ideas? Also [1] suggests to set CC="ccache gcc -m32" on amd64 machines. I did that and when doing make I noticed that many lines start with: ccache gcc -m32 -m32 I guess that CC="ccache gcc" would be enough - but I didn't test that yet. Also I noticed that running parallel make (make -j) is never mentioned on [1]. Is there any reason I shouldn't use it? Daniel [1] http://wiki.winehq.org/RegressionTesting

5 6

Re: [PATCH 1/4] d3drm: Implement IDirect3DRMFrameX_AddChild. (try 2) (resend)
by Alexandre Julliard April 12, 2012

April 12, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > + children = (IDirect3DRMFrame3**)HeapAlloc(GetProcessHeap(), 0, (This->nb_children + 1) * sizeof(IDirect3DRMFrame3*)); > + if (!children) > + return E_OUTOFMEMORY; > + > + CopyMemory(children, This->children, This->nb_children * sizeof(IDirect3DRMFrame3*)); > + HeapFree(GetProcessHeap(), 0, This->children); HeapReAlloc is your friend. Also you should grow the buffer quadratically. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests: Add a test for creating named mapping after closing without unmapping.
by Dmitry Timoshkov April 12, 2012

April 12, 2012

Alexander Morozov <amorozov(a)etersoft.ru> wrote: > + ptr = MapViewOfFile(mapping, FILE_MAP_WRITE, 0, 0, 0); > + ok( ptr != NULL, "MapViewOfFile failed with error %d\n", GetLastError() ); > + CloseHandle(mapping); > + > + SetLastError(0xdeadbeef); > + mapping = CreateFileMappingA(INVALID_HANDLE_VALUE, NULL, PAGE_READWRITE, 0, MAPPING_SIZE, name); > + ok( mapping != INVALID_HANDLE_VALUE, "CreateFileMappingA failed\n" ); It would be interesting to add OpenFileMapping before and after CloseHandle and test what it returns. -- Dmitry.

1 0

Re: [PATCH] d3drm: Implement IDirect3DRMFrameX_GetTransform.
by Marvin April 12, 2012

April 12, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17814 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0