April 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 2/3] wininet/tests: Added more tests for urlcache, including a new flag in CacheEntryType.
by Piotr Caban April 7, 2012

April 7, 2012

Hi, On 04/05/12 08:50, Morten Rønne wrote: diff --git a/include/wininet.h b/include/wininet.h #define URLHISTORY_CACHE_ENTRY 0x00200000 +#define DELETED_CACHE_ENTRY 0x00400000 #define TRACK_OFFLINE_CACHE_ENTRY 0x00000010 DELETED_CACHE_ENTRY is not defined in native wininet.h header that I have. Did you find a header with it? If not, it should not be defined there. Cheers, Piotr

2 2

Re: winealsa: Fix an uninitialized variable compiler warning.
by Andrew Eikum April 7, 2012

April 7, 2012

Thanks. GCC 4.7 must be smart enough to detect the same if-conditions, and doesn't issue a warning for me. Kind of impressive, actually. Andrew On Fri, Apr 06, 2012 at 02:49:38AM +0200, Józef Kucia wrote: > --- > dlls/winealsa.drv/mmdevdrv.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index c99186b..1438f5b 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -343,7 +343,7 @@ static WCHAR *construct_device_id(EDataFlow flow, const WCHAR *chunk1, const cha > { > WCHAR *ret; > const WCHAR *prefix; > - DWORD len_wchars = 0, chunk1_len, copied = 0, prefix_len; > + DWORD len_wchars = 0, chunk1_len = 0, copied = 0, prefix_len; > > static const WCHAR dashW[] = {' ','-',' ',0}; > static const size_t dashW_len = (sizeof(dashW) / sizeof(*dashW)) - 1; > -- > 1.7.8.5 > > >

2 1

RFC: Getting CorelDraw 12 installation done - was: A donation for Corel Draw 12 - support.
by Gerold Jens Wucherpfennig April 6, 2012

April 6, 2012

Hi can someone give me some hints about fixing wine for Corel 12 support? The installation seems to succeed at first glance, but comparing the installation folder to the folder of an installation on Windows XP reveals that only 2/3 of the installation was done. I updated the APPDB: http://appdb.winehq.org/objectManager.php?sClass=version&iId=2390 On 03/26/2012 09:52 AM, Frédéric Delanoy wrote: > On Sat, Mar 24, 2012 at 19:45, Gerold Jens Wucherpfennig > <gjwucherpfennig(a)gmx.net> wrote: >> http://appdb.winehq.org/objectManager.php?sClass=version&iId=2390 >> >> Installation worked, but Corel is not usable and only reports: >> >> "Registry Corrupt - The UI Language registration list is invalid" > > That page indicates the last tested version. > > Did you try Core Draw 12 with 1.4 or 1.5 and get the same errors? > > If you did, you might want to add test data in the AppDB entry, so > other people don't spend time duplicating your test. > If you didn't, maybe will retesting with 1.4 or 1.5 reveal it works > correctly for your needs? > > Frédéric I want to make a small donation to winehq, if we can get Corel 12 running on Wine... Here is the installation log: gerold(a)gerold-AOD270:/media/6B35-950F/Corel$ wine ./setup.exe wine: created the configuration directory '/home/gerold/.wine' fixme:storage:create_storagefile Storage share mode not implemented. err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot fixme:iphlpapi:NotifyAddrChange (Handle 0xede318, overlapped 0xede2e0): stub fixme:storage:create_storagefile Storage share mode not implemented. err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot err:mscoree:LoadLibraryShim error reading registry key for installroot fixme:iphlpapi:NotifyAddrChange (Handle 0xfee8ec, overlapped 0xfee8d0): stub wine: configuration in '/home/gerold/.wine' has been updated. fixme:storage:create_storagefile Storage share mode not implemented. fixme:storage:create_storagefile Storage share mode not implemented. fixme:vbscript:parse_script parser failed on parsing L"(\"SERIALNUMBER\") = \"DR12WTX-9999998-YSP\"\r\n\tSession.Property(\"TypeB\") = \"1\"\r\nEnd If\r\n\r\n'///////////////////////////////////////////////\r\nFunction IsFeatureExists(sFeature)\r\nOn Error Resume Next\r\n\r\n\tDim objDB: Set objDB = Session.Database\r\n\r\n\tDim sQuery: sQuery = \"SELECT"... err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self fixme:vbscript:parse_script parser failed on parsing L"(\"ShowLanguagePackDialog\") = \"1\"\r\nElse\r\n\tIf (IsFeatureExists(\"EN\") = \"1\") Then\r\n\t\tSession.Property(\"ENLANG\") = \"1\"\r\n\tEnd If\r\n\tIf (IsFeatureExists(\"DE\") = \"1\") Then\r\n\t\tSession.Property(\"DELANG\") = \"1\"\r\n\tEnd If\r\n\tIf (IsFeatureExists(\"FR\") = \"1\") Then\r\n"... err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\nDim nRemoveVBAEN:nRemoveVBAEN = 0\r\nDim nRemoveVBACZ:nRemoveVBACZ = 0\r\nDim nRemoveVBANL:nRemoveVBAPL = 0\r\n\r\nOn "... fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\n\r\nOn Error Resume Next\r\n\r\nIf (IsFeatureSelected(\"FontNav\") = True) Then\r\n If ((Session.Property(\"PLLANG\""... err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\n\r\nOn Error Resume Next\r\n\r\nIf (IsFeatureSelected(\"FontNav\") = True) Then\r\n If ((Session.Property(\"PLLANG\""... err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self fixme:vbscript:parse_script parser failed on parsing L"1\r\nConst msiInstallStateAdvertise = 1\r\nConst msiInstallStateAbsent = 2\r\nConst msiInstallStateLocal = 3\r\nConst msiInstallStateSource = 4\r\nConst msiInstallStateDefault = 5\r\n\r\nOn Error Resume Next\r\n\t\r\nIf (IsFeatureExists(\"LocalInstallsOnly\")=\"1\") Then\r\n\tIf ((Session.Property(\""... err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, advertised shortcut err:ole:ClientRpcChannelBuffer_SendReceive called from wrong apartment, should have been 0x2a0000003d err:ole:xCall RpcChannelBuffer SendReceive failed, 8001010e fixme:ntdll:NtFsControlFile FSCTL_PIPE_IMPERSONATE: impersonating self gerold(a)gerold-AOD270:/media/6B35-950F/Corel$ Thanks in advance! Gerold

1 0

Re: ddraw: Improve GetScanLine stub so it's usable for timing related tasks
by Christian Costa April 6, 2012

April 6, 2012

Le 06/04/2012 12:35, Piotr Caban a écrit : > + /* Simulate a 60Hz display */ > + time = GetTickCount(); > + frame_progress = time& 15; /* time % (1000 / 60) */ > + if (!frame_progress) > + { > + *Scanline = 0; > + return DDERR_VERTICALBLANKINPROGRESS; > + } > + > + /* convert frame_progress to estimated scan line */ > + lines = mode.height / 15; > + *Scanline = (frame_progress - 1) * lines + time % lines; > return DD_OK; > } Is time % lines here is to generate a random values (sort of noise) ?

2 2

Re: [GSoC] Control panel proposal
by Magdalena Nowak April 6, 2012

April 6, 2012

On 6 April 2012 11:06, André Hentschel <nerv(a)dawncrow.de> wrote: > Am 06.04.2012 01:35, schrieb Magdalena Nowak: >> Hey André, >> >> On 5 April 2012 22:46, André Hentschel <nerv(a)dawncrow.de> wrote: >>> >>>> The second solution would be to have a separate applet for >>>> per-application settings. The screens would be stored in a DLL, for >>>> example, as to avoid duplication. >>> >>> I dislike that, that seems just like a new view of winecfg. Further i doubt that you can store Wine specific things in a Wine specific DLL. >> >> I didn't like this idea either, but I have included it for the sake of >> completeness. > > That's good :) > >>> I think this project is doable, but might be hard to get the patches accepted i guess. >> >> What makes you say that? > > One or two people already tried IIRC and failed, but most likely they missed the part with the per-app configuration that you have seen. I think it's a great feature, but very hard to implement. That's why I've had a few ideas in mind. > Further you have to keep in mind that winecfg is a historical app, you'll need a nice and clean incremental way of patching it out. That's why I want to work incrementally, (c.f. the timeline on my proposal). > For further communication please CC wine-devel. Oops! BTW, the proposal can be found on http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/magdalen…

1 0

Re: winedump: Add basic support for dumping the property store in lnk files.
by Dmitry Timoshkov April 5, 2012

April 5, 2012

Vincent Povirk <madewokherd(a)gmail.com> wrote: > +typedef struct tagLINK_PROPERTYSTORAGE_VALUE > +{ > + DWORD size; > + DWORD pid; > + BYTE unknown8; > + DWORD vt; > + DWORD unknown25; > +} LINK_PROPERTYSTORAGE_VALUE; You probably need an appropriate packing for this structure. -- Dmitry.

2 2

[GSoC] Control panel proposal
by Magdalena Nowak April 5, 2012

April 5, 2012

Hi, my name is Magdalena Nowak and I'd like to apply for this year's Summer of Code with Wine. My proposal is to merge the two control panel suggestions (Tools - Merge winecfg and control panel and Tools - Implement new control panel applets) into one project. I would start off with splitting winecfg into several applets. Roughly, each tab would become a new applet. The Applications applet would only be used to register applications with the control panel to allow the user to specify custom settings for that application. I would like to merge the Graphics tab with the Appearance section of Desktop Integration (and this applet would be the place where the 3D settings would go later) and merge the Folders section with the Drives tab into one applet. Later on, I will start implementing new applets. For example, create a Networking applet for the network-related settings, maybe a simple diagnostics tool (a read-only applet with information regarding build options and system resources), Fonts (both list of fonts available to Wine as well as hinting and DPI settings), a System applet for settings like owner name, Windows version, libraries etc. There is a problem with per-application settings. I have three possible solutions to this problem. I have made pictures to illustrate what I mean. One would be to simply add a drop-down list to each applet that contains settings that can be per-application settings. The drop-down list would contain a "global" entry, as well as entries for each application registered through the Applications applet. Upon selecting an entry, the applet would load the settings for this program. The second solution would be to have a separate applet for per-application settings. The screens would be stored in a DLL, for example, as to avoid duplication. The third, and my favourite, solution, is to create a virtual control panel for each registered application. The user would be able to select the application or global settings from some kind of list, and the applets would be passed an argument to indicate the selected application. If a specific setting was global-only, it would be highlighted appropriately. Here are the promised images: http://imgur.com/T4pUV - Showing the drop-down menu at the top of the applet window. http://imgur.com/vA1Vq - Showing the per-application settings applet. http://imgur.com/is63I - Showing the control panel with an application selected, and a Graphics applet showing a global-only setting. Of course these are only examples, I welcome any comments. I will post a proposal on Melange soon. Yours, 'Lena.

2 2

[3/3] shell32: Add test for STARTF_TITLEISAPPID flag.
by Vincent Povirk April 5, 2012

April 5, 2012

1 1

urlcache: what all are you working on?
by Juan Lang April 5, 2012

April 5, 2012

Hi Morten and Piotr, I notice both of you are working on wininet's url cache. That's great: it's largely bitrot, and has been for years. My question is, what are you planning to fix? It seems like you're both running into some of the same issues right now, and it would be nice if you could coordinate a little. Ok, I lie: it'd be nice to get code from both of you ;) If I were to guess, it looks like you're both working on eliminating corruption and deadlocks, both of which can occur right now. Fantastic. Another thing that'd be nice to see is reducing the amount of disk space used. Morten, some of the patches you sent me do some of that, by removing files once they're no longer in use. (The patches I have do that too.) Piotr, were you planning to address this too? A question that I have to ask is, would be better to eliminate the url cache altogether? Right now its only utility is to pass test cases, and conveniently fill up your disk. No requests are ever fulfilled from the cache. Either of you have any plans to tackle that? Thanks, --Juan

3 2

qemu still can't run x86 wine
by Dan Kegel April 5, 2012

April 5, 2012

http://wiki.winehq.org/ARM says commands like $ qemu-i386 /usr/local/qemu-i386/wine/bin/wine /usr/local/qemu-i386/wine/c/Program\ Files/putty.exe used to work, but doesn't anymore. I gave it a shot anyway, just trying to run x86 apps inside wine inside qemu: wget http://wiki.qemu.org/download/qemu-1.0.1.tar.gz tar -xzvf qemu-1.0.1.tar.gz cd qemu-1.0.1 ./configure --prefix=/usr/local/qemu --target-list=i386-linux-user make # Compilation fails; to work around, edit linux-user/syscall.c and # replace soundcard.h with soundcard.h.oss3 make sudo make install # Verify that qemu can run a trivial binary /usr/local/qemu/bin/qemu-i386 /bin/uname -a # Verify you can run wine a little /usr/local/qemu/bin/qemu-i386 /usr/bin/wine --version # Now run a real app /usr/local/qemu/bin/qemu-i386 /usr/bin/wine cmd /c echo hi qemu: Unsupported syscall: 240 # Huh. That didn't work. OK, try sh: /usr/local/qemu/bin/qemu-i386 /bin/sh $ ls /bin/sh: 1: Cannot fork The syscall error seems to be https://bugs.launchpad.net/ubuntu/+source/qemu-linaro/+bug/758424 "We only implement the futex syscalls if CONFIG_USE_NPTL. This isn't defined for the i386 target (the necessary support in target-i386 for pushing atomic insns up to the linux-user top level loop isn't implemented). The upshot is that running multithreaded programs in linux-user i386-target isn't supported and this is just one of the symptoms." Dunno about the fork error. So it looks like anyone hoping to run x86 wine in qemu would need to fix qemu first and/or go back to an old wine that doesn't use nptl?

1 0

Google Summer of Code Project: Implement missing D3DX libraries
by Alexander Mezin April 5, 2012

April 5, 2012

Hello. I want to participate in GSoC and work on project "Direct3D: Implement missing D3DX libraries", listed at http://wiki.winehq.org/SummerOfCode. I have experience of developing for Windows using Direct3D 9 and D3DX, so I think I'm the one who you need for this project. About two years ago I reimplemented some D3DX functionality using Direct3D for a casual game, because these D3DX_XX libraries caused problems with distribution. Sadly, all this code is lost, but there was nothing hard to implement, or, at least no such things was used in the game. Usually only D3DXSprite, D3DXFont and, maybe, effect framework are used. And also nothing really changes between D3DX versions, usually only some methods are renamed or their parameters are reordered. I want to contact possible mentor to discuss what parts of the libraries must be implemented, but I can't find his e-mail, wiki says that his page isn't created.

2 1

My GSoC proposition: Raw Input
by Eryk Wieliczko April 5, 2012

April 5, 2012

I've been thinking about joining GSoC as a student this year. As an idea I propose Raw Input, and I seek your advise. Is this topic good, what are possible catches, etc. I think that it might be possible to finally do a decent implementation, that would (besides mouse and keyboard) also support joysticks and possibly some other input devices - tablets and multiple mice and keyboards. What do you think about this topic? Links: http://msdn.microsoft.com/en-us/library/windows/desktop/ms645536(v=vs.85).a… http://appdb.winehq.org/viewbugs.php?bug_id=20395 http://bugs.winehq.org/show_bug.cgi?id=20395

3 3

Re: [PATCH 1/1] ntdll: Fix section header heap deadlock (try 2).
by Alexandre Julliard April 5, 2012

April 5, 2012

"Erich E. Hoover" <ehoover(a)mines.edu> writes: > Description: > Free the section header memory outside of the uninterrupted > section lock. Changing the order here stops the process heap from > potentially deadlocking (Bug #30356). The allocation will still be an issue. I think a better approach would be to avoid any memory allocation in there. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/5] wined3d: Enable "AlwaysOffscreen" by default.
by Alexandre Julliard April 5, 2012

April 5, 2012

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > dlls/wined3d/wined3d_main.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) It doesn't work here (GeForce 8500, driver 295.20): ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so visual.c && touch visual.ok visual.c:1385: Tests skipped: D3DFMT_P8 textures not supported visual.c:2011: Test failed: Expected color 0x000000ff at 80,60, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x000000ff at 240,60, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x0000ff00 at 400,60, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x000000ff at 80,180, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x000000ff at 240,180, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x0000ff00 at 400,180, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x0000ff00 at 80,300, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x0000ff00 at 240,300, got 0x00ff0000. visual.c:2011: Test failed: Expected color 0x0000ff00 at 400,300, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 80,60, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 240,60, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 400,60, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 560,60, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 80,180, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 240,180, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 400,180, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 560,180, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 80,300, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 240,300, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 400,300, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 560,300, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 80,420, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 240,420, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 400,420, got 0x00ff0000. visual.c:2111: Test failed: Expected color 0x0000ff00 560,420, got 0x00ff0000. visual.c:2824: Tests skipped: No RESZ support, skipping RESZ test. make: *** [visual.ok] Error 25 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: (try 2)quartz: add control.idl as a typelib resource
by Huw Davies April 5, 2012

April 5, 2012

On Thu, Apr 05, 2012 at 07:51:13AM -0500, Aric Stewart wrote: > > revised based on comments from Jacek Caban > --- > dlls/quartz/Makefile.in | 1 + > dlls/quartz/control_v2.idl | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+), 0 deletions(-) > create mode 100644 dlls/quartz/control_v2.idl Calling this control_v2.idl seems a little odd. control_tlb.idl may be better. Huw.

1 0

Re: gdi32: Constification.
by Alexandre Julliard April 5, 2012

April 5, 2012

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > @@ -6407,7 +6409,7 @@ static BOOL get_text_metrics(GdiFont *font, LPTEXTMETRICW ptm) > return TRUE; > } > > -static BOOL face_has_symbol_charmap(FT_Face ft_face) > +static BOOL face_has_symbol_charmap(const FT_Face ft_face) > { > int i; > > @@ -6729,7 +6731,7 @@ end: > static DWORD freetype_GetGlyphOutline( PHYSDEV dev, UINT glyph, UINT format, > LPGLYPHMETRICS lpgm, DWORD buflen, LPVOID buf, const MAT2 *lpmat ) > { > - struct freetype_physdev *physdev = get_freetype_dev( dev ); > + const struct freetype_physdev * const physdev = get_freetype_dev( dev ); > DWORD ret; > > if (!physdev->font) You are overdoing it. There's no reason to change per-value parameters or local variables like the physdev. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 3/3] wininet/tests: Added checks for bad return values and stop tests when it happens.
by Alexandre Julliard April 5, 2012

April 5, 2012

Morten Rønne <morten.roenne(a)tdcadsl.dk> writes: > @@ -29,6 +29,8 @@ > > #include "wine/test.h" > > +#define bail_out { ok(0, "Bailing out\n"); return; } Please avoid that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: quartz: add control.idl as a typelib resource
by Jacek Caban April 5, 2012

April 5, 2012

Hi Aric, On 04/04/12 20:38, Aric Stewart wrote: > --- a/dlls/quartz/Makefile.in > +++ b/dlls/quartz/Makefile.in > @@ -32,6 +32,7 @@ RC_SRCS = version.rc > IDL_H_SRCS = fil_data.idl > IDL_P_SRCS = quartz_strmif.idl > IDL_R_SRCS = quartz_strmif.idl > +IDL_TLB_SRCS = ../../include/control.idl This is not the right way. A simple IDL file in DLL directory that does nothing but #include will do the trick. See dlls/stdole2 for example. Jacek

1 0

About the "Implement Common Windows Scripting Classes"
by Lucas Zawacki April 4, 2012

April 4, 2012

Hello, regarding the "Implement Common Windows Scripting Classes" gsoc idea. How many of these classes would be fine for the length of the program? I'm thinking that maybe 3 classes with thorough would be cool for a proposal. Some of them like "Dictionary" seem to be pretty straight forward and small, the others I'm not sure. Looking at dlls/scrrun/scrrun.idl I see there are a lot more of classes, but according to the idea page, Dictionary and FileSystemObject block multiple applications so they're higher priority. Are there other ones that are important?

1 0

Re: [PATCH 1/2] Revert "gdi32: Load fonts from default Mac external font paths."
by Ken Thomases April 4, 2012

April 4, 2012

Forgot to note that this is a resend. On Apr 4, 2012, at 5:40 PM, Ken Thomases wrote: > > This reverts commit 85a71387dac1ca3ad47970800c8c01743681b528. > --- > dlls/gdi32/freetype.c | 17 +---------------- > 1 files changed, 1 insertions(+), 16 deletions(-) > > <0001-Revert-gdi32-Load-fonts-from-default-Mac-external-fo.patch>

1 0

Re: [PATCH] d3drm: Retreive mesh name at loading time. Implement GetName and SetName.
by Henri Verbeet April 4, 2012

April 4, 2012

You should use debugstr_a() for printing strings like that. Also, where does the 128 char limit come from?

2 1

Re: [PATCH 2/4] amstream: Add IAudioMediaStream stub implementation.
by Henri Verbeet April 4, 2012

April 4, 2012

On 4 April 2012 21:57, Christian Costa <titan.costa(a)gmail.com> wrote: > +static HRESULT WINAPI IAudioMediaStreamImpl_QueryInterface(IAudioMediaStream *iface, > + REFIID riid, void **ppv) > +{ > + IAudioMediaStreamImpl *This = impl_from_IAudioMediaStream(iface); > + > + TRACE("(%p/%p)->(%s,%p)\n", iface, This, debugstr_guid(riid), ppv); > + > + if (IsEqualGUID(riid, &IID_IUnknown) || > + IsEqualGUID(riid, &IID_IMediaStream) || > + IsEqualGUID(riid, &IID_IAudioMediaStream)) > + { > + IUnknown_AddRef(iface); > + *ppv = This; That's wrong. > + return S_OK; > + } > + > + ERR("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppv); > + return E_NOINTERFACE; > +} QueryInterface() should generally set "*ppv" to NULL on failure.

1 0

Re: [PATCH 4/4] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface. (resend)
by Marvin April 4, 2012

April 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17650 Your paranoid android. === WNT4WSSP6 (32 bit d3drm) === d3drm.c:472: Test failed: Invalid refcount. Expected 3 got 2 d3drm.c:480: Test failed: Invalid refcount. Expected 4 got 3 d3drm.c:482: Test failed: Invalid refcount. Expected 3 got 2

2 2

Re: amstream: IAMMultiMediaStreamImpl_SetState: correct ifs
by Christian Costa April 4, 2012

April 4, 2012

Le 04/04/2012 21:22, Joris Huizer a écrit : > Correcting a mistake in 27c4ad3bec1229020ab38ab5b45f0969204192ef > > Oupsssssss...... :(

1 0

Re: user32/tests: Add DlgDirList tests
by Alexandre Julliard April 4, 2012

April 4, 2012

Bruno Jesus <00cpxxx(a)gmail.com> writes: > Based on original patch from Christian Lupien from bug 8226. > > Tests required to later fix http://bugs.winehq.org/show_bug.cgi?id=8226 This should be added to the existing DlgDirList tests, making sure that these things are not already being tested. -- Alexandre Julliard julliard(a)winehq.org

1 0