April 2012 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: Web based translation tool
by Michal Čihař June 18, 2013

June 18, 2013

Hi Dne Mon, 12 Mar 2012 12:02:49 +0200 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > The Wine project is thinking about using Weblate in order to translate > Wine, you can look at the following discussion and see for yourself. That sounds great! > Looking good although a litle immature, not sure about authentication as > wel... For authentication you can basically use anything what can be used in Django. Any specific concerns on this topic? > I'll talk to Michal Cihar and ask him for a roadmap for this project. Well I don't have any real roadmap right now. I urgently needed replacement for Pootle because we got hit by too many bugs there and did not manage to understand the code there to be able to fix them myself. So far I think it is in pretty good shape for day to day work (with today's 0.5 release fixing few annoying bugs). Of course there are some features missing, you can check what I plan for 1.0 release here: https://github.com/nijel/weblate/issues?state=open&milestone=1 I currently hope to have 1.0 in a month or so, but I really don't want to commit to any specific date. PS: I'm not subscribed to mailing list so please CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

7 16

Wine automated testing update
by Jeremy White Aug. 6, 2012

Aug. 6, 2012

Hi Folks, At the last Wine conference, I volunteered to find a home for the WineTestBot that Ge's brother has been hosting, and to take over the Buildbot that Dan and Austin have been so diligently maintaining. This is an update on that project, mostly to help keep my procrastinating self moving it along. First, we have a lovely set of hardware; 4 servers, in a dedicated rack, with a dedicated static ip to the outside world. One server is the gateway, 2 are dedicated Linux test systems (with nice fast processor + gpus), and one is a beefy system capable of running many VMs. The plan was to move the existing VMWare based WineTestBot to this hardware and simply get the existing system up and running on the new hardware. Here we hit our first snag; the VMWare folks are not willing to provide a permanent license for VMWare to us. So, we've shifted gears, and are exploring whether something like qemu + kvm would be a sufficient alternate. I've done a little of this work, and Maarten is hopefully going to help me try converting the existing VMs to see if we can save any hassle by doing a conversion. In parallel, I learned a great deal about buildbot and the buildbot system that Dan has built. There are two especially valuable and useful functions provided by this buildbot: the first is essentially a patch watcher; a process that catches simple mistakes (e.g. build errors on different architectures, and so on). The second is more powerful and is encapsulated by the 'dotests.sh' shell script. The dotests.sh script does a good job of basically running make test and noticing any test failures outside of 'the usual ones'. There is an infrastructure for Buildbot is a good tool, and I invested a lot of energy into it (as have Dan and Austin). However, Alexandre has persuaded me that we should first explore integrating the dotest.sh functionality into the existing WineTestBot, as that would allow us to have a very simple clean web page, and would also allow us to integrate most cleanly with Alexandre's back end tools. Of course, WineTestBot is Perl code, and my Perl fu is low. So I have recently asked Francois to help with that effort as well. So the basic plan is as follows: 1. Test qemu/kvm with a few Windows versions to see if it'll work. 2. If so, modify WineTestBot to use qemu instead of vmware. (This is 'easy' because the WineTestBot code nicely isolates the VM functions, but 'hard', because VMWare provides some APIs that may have to be replicated). 3. Migrate WineTestBot to the new hardware stack 4. Write new code to run 'dotests.sh' as part of WineTestBot Cheers, Jeremy

9 11

Rethinking WineConf
by Jeremy White July 26, 2012

July 26, 2012

Hi All, This past Wine conference, while great fun as always, was not as well attended as Wine conferences in the past. So I would like to stir up trouble by suggesting we rethink WineConf. For those that have not attended, the Wine conference has been a mostly annual affair since 2002. It is open to all, but is advertised as being aimed at Wine developers. About 35 people attend each year. It's been in Minnesota about every 3rd year, and is otherwise 'normally' somewhere in Europe. I see the primary goal as creating human bonds between otherwise anonymous people (aka going to the pub). It's a bonus if it also spurs resolution to tricky issues, or motivates people to get more done. So I'd like to ask folks to brain storm with me. How could Wineconf be different? If you've never been, what would encourage you to come? If you've been to a technical conference recently that you thought was well done, what did they do well? Anything we could emulate? Any other ideas, or suggestions? Cheers, Jeremy

17 25

Re: mshtml: Set outgoing pass-by-address variable in an error case case within confirm_safety_load.
by Jacek Caban July 18, 2012

July 18, 2012

Hi Gerald, On 03/07/12 23:35, Gerald Pfeifer wrote: > I noticed we return in this case, without initializing this variable. > Visual inspection indicates we do not seem to access the variable in > this error case, but a) better safe than sorry, and b) GCC 4.8 currently > warns about it. > > Not sure URLPOLICY_DISALLOW is the best return value, open for better > alternatives. I generally don't think this patch makes things any better (or worse). If we return an error, the caller should not expect this value to be sane. What's the GCC 4.8 warning? Jacek

2 4

winebuild port to ARM?
by Roger Cruz July 7, 2012

July 7, 2012

Has anyone worked or is currently working on porting the x86 specific code in Winebuild to ARM? Specifically the relay.c file? Thanks Roger R. Cruz

2 9

[PATCH 0/6] Extended file stat system call
by David Howells May 10, 2012

May 10, 2012

Implement a pair of new system calls to provide extended and further extensible stat functions. The second of the associated patches is the main patch that provides these new system calls: ssize_t ret = xstat(int dfd, const char *filename, unsigned atflag, unsigned mask, struct xstat *buffer); ssize_t ret = fxstat(int fd, unsigned atflag, unsigned mask, struct xstat *buffer); which are more fully documented in the first patch's description. These new stat functions provide a number of useful features, in summary: (1) More information: creation time, inode generation number, data version number, flags/attributes. A subset of these is available through a number of filesystems (such as CIFS, NFS, AFS, Ext4 and BTRFS). (2) Lightweight stat: Ask for just those details of interest, and allow a netfs (such as NFS) to approximate anything not of interest, possibly without going to the server. (3) Heavyweight stat: Force a netfs to go to the server, even if it thinks its cached attributes are up to date. (4) Allow the filesystem to indicate what it can/cannot provide: A filesystem can now say it doesn't support a standard stat feature if that isn't available. (5) Make the fields a consistent size on all arches, and make them large. (6) Can be extended by using more request flags and appending further data after the end of the standard return data. Note that no lstat() equivalent is required as that can be implemented through xstat() with atflag == 0. ======= PATCHES ======= Patch 1 defines the xstat() and fxstat() system calls. Patches 2-6 implement extended stat facilities for Ext4, AFS, NFS and CIFS, and make eCryptFS go to the lower filesystem for such details. ============== CONSIDERATIONS ============== Should fxstat() be implemented as xstat() with a NULL filename, using dfd as fd? Should the default for a network fs be to do an unconditional (heavyweight) stat with a flag to suppress going to the server to update the locally held attributes and flushing pending writebacks? Should things like the Windows Archive, Hidden and System bits be handled through IOC flags, perhaps expanded to 64-bits? Are these things useful to userspace other than Samba and userspace NFS servers? Is it useful to pass the volume ID out? Or is statfs() sufficient for this? Should I add a sixth argument to xstat(), mark it reserved and require that must be supplied as 0 to hedge against future use? Is there anything else I can usefully add at the moment? ========== TO BE DONE ========== Autofs, ntfs, btrfs, ... I should perhaps use u8/u32/u64 rather than uint8/32/64_t. Handle remote filesystems being offline and indicate this with XSTAT_INFO_OFFLINE. ======= TESTING ======= There's a test program attached to the description for the main patch. It can be run as follows: [root(a)andromeda tmp]# ./xstat -R /mnt/foo xstat(/mnt/foo) = 0 0000: 000081a40000ffef 0000000000000001 0000020000000000 0000100000080000 0020: 0000000000000000 0000000600000008 000000004f88499a 0000000136fd9208 0040: 000000004f88499a 0000000136fd9208 000000004f8849b9 0000000106daf187 0060: 000000004f8849b9 0000000106daf187 000000000000000c 000000000000000f 0080: 0000000000000008 00000000484ebbef 0000000000000025 5949ebd4711efd82 00a0: d3250b5c15d5e380 0000000000000000 0000000000000000 0000000000000000 00c0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 00e0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 results=ffef Size: 15 Blocks: 8 IO Block: 4096 regular file Device: 08:06 Inode: 12 Links: 1 Access: (0644/-rw-r--r--) Uid: 0 Gid: 0 Access: 2012-04-13 16:43:22.922587656+0100 Modify: 2012-04-13 16:43:53.115011975+0100 Change: 2012-04-13 16:43:53.115011975+0100 Create: 2012-04-13 16:43:22.922587656+0100 Inode version: 484ebbefh Data version: 25h Inode flags: 00080000 (-------- ----e--- -------- --------) Information: 00000200 (-------- -------- ------a- --------) Volume ID: 82fd1e71d4eb4959-80e3d5155c0b25d3 David --- David Howells (6): xstat: eCryptFS: Return extended attributes xstat: CIFS: Return extended attributes xstat: NFS: Return extended attributes xstat: AFS: Return extended attributes xstat: Ext4: Return extended attributes xstat: Add a pair of system calls to make extended file stats available arch/x86/syscalls/syscall_32.tbl | 2 arch/x86/syscalls/syscall_64.tbl | 2 fs/afs/inode.c | 29 ++- fs/afs/super.c | 7 + fs/cifs/cifsfs.h | 4 fs/cifs/cifsglob.h | 16 +- fs/cifs/dir.c | 2 fs/cifs/inode.c | 120 +++++++++++-- fs/ecryptfs/inode.c | 14 +- fs/ext4/ext4.h | 2 fs/ext4/file.c | 2 fs/ext4/inode.c | 32 +++ fs/ext4/namei.c | 2 fs/ext4/super.c | 1 fs/ext4/symlink.c | 2 fs/nfs/inode.c | 49 ++++- fs/nfs/super.c | 1 fs/stat.c | 350 +++++++++++++++++++++++++++++++++++--- include/linux/fcntl.h | 1 include/linux/fs.h | 4 include/linux/stat.h | 126 +++++++++++++- include/linux/syscalls.h | 7 + 22 files changed, 694 insertions(+), 81 deletions(-)

10 65

Re: Ubuntu 12.04 (version#2, drop previous mail)
by Eric Pouech May 9, 2012

May 9, 2012

> This is because you _cannot_ install the 32-bit -dev packages onto > 12.04. It's not just symlinks that are missing, many of the header > files are different between the arches. I'm not sure this is a generic rule, and if it were, then exclusion between i386 and x86_64 should be defined on most dev packages, and it's not the case also note, that in some cases, arch specific headers are moved to arch dependent directories (e.g. jpeg, glib...), which should also parallel install of multi-arch libs in any case, the job by ubuntu folks in 12.04 done is crappy, to say the least > Just do the chroot. You will save yourself so much grief and it will > actually work. if the ubuntu folks keep this state of mind, then they'll continue to sink the best solution is then to pick up another distro A+ -- -- Eric Pouech

3 4

Request for help/advice in investigation of one interesting "huge FPS regression" bug
by Alexey Loukianov May 3, 2012

May 3, 2012

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Good day to all. Henri, Stefan, I address this message to you at the first place as to a main developers of wined3d/opengl stuff. Nevertheless, hints and help are welcome from anyone, cause ATM I'm totally confused and don't know what else to try to investigate a case. What I've got here is an app (localized version of "Perfect World" MMORPG game client from "Mail.Ru Games Corp") that seems to suffer huge FPS regression which I believe to be a bug in nVIDIA drivers rather than a regression in Wine. Details are following. When I configure an app to run in a windowed mode I've got around 40 FPS on game login screen with nVIDIA drivers 275.09.07, but switching into using more recent versions causes FPS to drop to around ~10. Configuring the game to use fullscreen more fixes the issue - I've got ~30-40 FPS at game login screen no matter the driver version I use. I've been suspecting that this issue might be related to vsync control (and a recent change in nVIDIA linux drivers for vsync to be on by default) that causes the issue, so I had exported __GL_SYNC_TO_VBLANK="0" into the environment and used nvidia-settings to set vsync to be off by default. Using a small native opengl demo program I had specifically written to test for vsync state I can prove that vsync defaults to be off on my system. Also I had modified Wine's winex11.drv opengl.c in a way that a call to wglSwapIntervalEXT always sets swap_interval to be zero, no matter what was originally requested. Nevertheless, I still got this strange FPS drop when I run the game in a windowed more with a recent nVIDIA drivers. What could be a cause for it? What I want is to track down the problem to it's roots and check if it's really a bug in nVIDIA drivers. In the end I would like to implement a small opengl demo that would trigger the bug so nVIDIA wouldn't be able to reject my bug report on a matter that "it's a Wine bug, prove us that it's not". - -- Best regards, Alexey Loukianov mailto:mooroon2(a)mail.ru System Engineer, Mob.:+7(926)218-1320 *nix Specialist -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPij76AAoJEPB9BOdTkBULjz4H/1B/Nw6qOQUlEmDb64SmabvQ LQmzIHcnH38Ftz3KyWQxlYZ5EtLDYAIOQeP4pAHfzxKhGUJ1mCumv4ByaSs4YDhI juWJ/u/88vKwZYXJ9nZLQVqJY+dkr9MbxP3q0eGNaAFLNRDIqodzJJWB5EPucMrX Yid/zMjl5uGd9QDCO3Db4gwJKYpvHCbAfzADddqBwPoak9jXdlq53H9a2mImTbCB JR1MXQq6gFakOgtxXPxzFSU2Ge0n8RBGGN7UeZEubsLiktnmvTbKAJmmgWgPG80Y mlud7LrM4wLRPtpwTwS+M1n8TuVtUZzzCTagRyj3XSRL8Pqf2d5S3H+MpxBT1JQ= =TkMD -----END PGP SIGNATURE-----

5 8

GSOC 2012 has started
by Austin English May 2, 2012

May 2, 2012

Howdy, Google Summer of Code 2012 has started, and we have 5 students this year: Józef Kucia - Implement missing functions in D3DX9, mentored by Stefan Dösinger - https://google-melange.appspot.com/gsoc/project/google/gsoc2012/jos/58002 Lucas Fialho Zawacki, mentored by Joystick configuration and testing applet Marcus Meissner - https://google-melange.appspot.com/gsoc/project/google/gsoc2012/lfzawacki/3… Magdalena Nowak - Control Panel, mentored by Owen Rudge - https://google-melange.appspot.com/gsoc/project/google/gsoc2012/magdalena/1… Marek K Chmiel - Encryption – digital signature security, mentored by Juan Lang - https://google-melange.appspot.com/gsoc/project/google/gsoc2012/mkchmiel/16… Qian Hong - GSoC project: Improve CJK font support, mentored by Aric Stewart - https://google-melange.appspot.com/gsoc/project/google/gsoc2012/fracting/11… Good luck everyone! -- -Austin

3 3

Fwd: Ubuntu 12.04 (version#2, drop previous mail)
by Eric Pouech May 1, 2012

May 1, 2012

for the devels having upgraded their boxes to ubuntu 12.04, here's a couple of stuff I had to do, especially to get 32bit wine compile This could be useful if you want to have a dual x86_64 : i386 setup this is an updated version to what I already sent to scott ritchie of course this is not a step by step installation, just hints if you want to take that road (version #3) (I'm using a multiarch x86_64/i386) now wine compiles and runs in 32bit while compiled on 64bit machine here's the summary of the pain getting it right after upgrade in response to https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/944321 I was able to compile 32bit-wine on 64bit as I always, and without a chroot or anything similar Problem #1 ---------- an old (11.10 according to the dates) directory was left over after migration, whereas it should have been removed /usr/include/i386-linux-gnu Problem #2 ---------- a ton of symlinks are missing in /usr/lib/i386-linux-gnu for example [root:/usr/lib/i386-linux-gnu]# ls -l /usr/lib/i386-linux-gnu/libfree* lrwxrwxrwx 1 root root 20 avril 3 10:54 /usr/lib/i386-linux-gnu/libfreetype.so.6 -> libfreetype.so.6.8.0 -rw-r--r-- 1 root root 624084 avril 3 10:54 /usr/lib/i386-linux-gnu/libfreetype.so.6.8.0 and it misses lrwxrwxrwx 1 root root 16 avril 28 21:30 /usr/lib/i386-linux-gnu/libfreetype.so -> libfreetype.so.6 the same applies for a lot libraries libXcursor.so libXi.so libXxf86vm.so libxrandr.so libxinerama.so libxcomposite.so libGLU.so libdbus-1.so (libdbus-1.so lies in /lib/i386-linux-gnu, not /usr/lib/i386-linux-gnu) libgnutls.so libsane.so libv4l1.so libgphoto2.so libgphoto2_port.so libgstreamer-0.10.so (***) libcapi20.so libcups.so libfontconfig.so libtiff.so libmpg123.so libopenal.so libxrender.so libGL.so (libGL.so is in mesa subdir!!!) libxml2.so libxslt.so libssl.so libcrypto.so libjpeg.so (***) libpng.so.0 (libpng12.so.0 lies in /lib/i386-linux-gnu, not /usr/lib/i386-linux-gnu) libXext.so the ones marked (***) means that the symlink is missing but it doesn't solve fully the issue from a wine perspective (see below) Problem #3 (jpeg) ----------------- Fails to open<jconfig.h>. which only lies in /usr/include/x86_64-linux-gnu/jconfig.h, and couldn't be accessed from 32bit build Creating the /usr/include/i386-linux-gnu/ directory and creating a symlink for jconfig.h to /usr/include/x86_64-linux-gnu/jconfig.h just works (I checked the contents of jconfig.h and it looks reasonable to do so) Problem #4 (gstreamer) ---------------------- it doesn't work as only /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h is installed (/usr/lib/i386-linux-gnu/glib-2.0/include/glibconfig.h doesn't exist, dpkg -S doesn't find it) and /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h defines gint64 as long, which is correct on 64bit targets one wrong on 32 bit ones... one should craft a decent /usr/lib/i386-linux-gnu/glib-2.0/include/glibconfig.h, or grab one out of pure i386 install (I haven't had time to look further into those, my main interest was to have a 32bit setup up& running) List of potentially installed i386 packages ------------------------------------------- fixed by installing i386 packages (not exhaustive, unfortunately, as I didn't note all the :i386 packages I've manually installed) libldap2.so alternatively, if I do a [eric:~]$ dpkg -l | grep i386 | grep -- -dev ii libc6-dev-i386 2.15-0ubuntu10 Embedded GNU C Library: 32-bit development libraries for AMD64 ii libldap2-dev:i386 2.4.28-1.1ubuntu4 OpenLDAP development libraries ii libpthread-stubs0-dev:i386 0.3-3 pthread stubs not provided by native libc, development files ii libx11-dev:i386 2.1.4.99.1-0ubuntu2 X11 client-side library (development headers) ii libxau-dev:i386 1:1.0.6-4 X11 authorisation library (development headers) ii libxcb1-dev:i386 1.8.1-1 X C Binding, development files ii libxdmcp-dev:i386 1:1.1.0-4 X11 authorisation library (development headers) tends to ask for libc6-dev:i386, libldap2-dev:i386, libx11-dev:i386, libxau-dev:i386, libxcb1-dev:i386, libxdmcp-dev:i386 as dedicated installations of dev:i386 packages but strangely enough, when looking at details, libx11-dev (for example) cannot be installed with libx11-dev:i386 according to manifest, but I have both installed (and both install the same files in /usr/include for example) this looks very strange indeed List of stuff that won't work ----------------------------- won't be supported (just to note them, as those are the left overs from the configure failing list) compiled without multiarch support: libhal, libgsm Warning at compilation ---------------------- when compiling, some warnings still have to be worked upon /home/eric/work/wine/dlls/winex11.drv/keyboard.c:1109:5: warning: 'XKeycodeToKeysym' is deprecated (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations] this one can be forgotten for now (it's just being marked deprecated in precise, so warning doesn't come from misconfiguration) debugging (32bit and 64bit) is broken ------------------------------------- the debugging is broken it turns out that ptrace and prctl (which had to be added in 11.10) work fine when tracing, only the first started process get correct pid out of wineserver in socket SCM_CREDENTIALS info. the later get 0 I tried to force the pid without requiring the recvmsg stuff and it works just fine I've not found yet the change that broke this more to come if get any futher on the remaining topics A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

5 7

Patches 85862 & 85862
by Christian Costa April 30, 2012

April 30, 2012

What's wrong with these patches : - http://source.winehq.org/patches/data/85862 - http://source.winehq.org/patches/data/85862 There are marked as pending but can't see anything wrong. Maybe I'm missing something. Christian

1 0

Re: [1/3] d3dx9: Define DDS structures. (try 3)
by Stefan Dösinger April 30, 2012

April 30, 2012

The patches look good to me. Am Sonntag, 29. April 2012, 21:43:08 schrieb Józef Kucia: > This patch series implements the DDS support for D3DXGetImageInfo functions. > > Try 2: Define pitch as LONG. > Try 3: Revert it back to DWORD. > --- > dlls/d3dx9_36/surface.c | 66 > ++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 65 > insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c > index 567282c..3319927 100644 > --- a/dlls/d3dx9_36/surface.c > +++ b/dlls/d3dx9_36/surface.c > @@ -28,9 +28,73 @@ WINE_DEFAULT_DEBUG_CHANNEL(d3dx); > > > /* Wine-specific WIC GUIDs */ > - > DEFINE_GUID(GUID_WineContainerFormatTga, > 0x0c44fda1,0xa5c5,0x4298,0x96,0x85,0x47,0x3f,0xc1,0x7c,0xd3,0x22); > > +/* dds_header.flags */ > +#define DDS_CAPS 0x1 > +#define DDS_HEIGHT 0x2 > +#define DDS_WIDTH 0x2 > +#define DDS_PITCH 0x8 > +#define DDS_PIXELFORMAT 0x1000 > +#define DDS_MIPMAPCOUNT 0x20000 > +#define DDS_LINEARSIZE 0x80000 > +#define DDS_DEPTH 0x800000 > + > +/* dds_header.caps */ > +#define DDS_CAPS_COMPLEX 0x8 > +#define DDS_CAPS_TEXTURE 0x1000 > +#define DDS_CAPS_MIPMAP 0x400000 > + > +/* dds_header.caps2 */ > +#define DDS_CAPS2_CUBEMAP 0x200 > +#define DDS_CAPS2_CUBEMAP_POSITIVEX 0x400 > +#define DDS_CAPS2_CUBEMAP_NEGATIVEX 0x800 > +#define DDS_CAPS2_CUBEMAP_POSITIVEY 0x1000 > +#define DDS_CAPS2_CUBEMAP_NEGATIVEY 0x2000 > +#define DDS_CAPS2_CUBEMAP_POSITIVEZ 0x4000 > +#define DDS_CAPS2_CUBEMAP_NEGATIVEZ 0x8000 > +#define DDS_CAPS2_VOLUME 0x200000 > + > +/* dds_pixel_format.flags */ > +#define DDS_PF_ALPHA 0x1 > +#define DDS_PF_ALPHA_ONLY 0x2 > +#define DDS_PF_FOURCC 0x4 > +#define DDS_PF_RGB 0x40 > +#define DDS_PF_YUV 0x200 > +#define DDS_PF_LUMINANCE 0x20000 > + > +struct dds_pixel_format > +{ > + DWORD size; > + DWORD flags; > + DWORD fourcc; > + DWORD bpp; > + DWORD rmask; > + DWORD gmask; > + DWORD bmask; > + DWORD amask; > +}; > + > +struct dds_header > +{ > + DWORD signature; > + DWORD size; > + DWORD flags; > + DWORD height; > + DWORD width; > + DWORD pitch_or_linear_size; > + DWORD depth; > + DWORD miplevels; > + DWORD reserved[11]; > + struct dds_pixel_format pixel_format; > + DWORD caps; > + DWORD caps2; > + DWORD caps3; > + DWORD caps4; > + DWORD reserved2; > +}; > + > + > /************************************************************ > * D3DXGetImageInfoFromFileInMemory > *

1 0

Re: wined3d: Fix build with MSVC (try 2).
by Stefan Dösinger April 30, 2012

April 30, 2012

Am Samstag, 28. April 2012, 10:16:13 schrieb Thomas Faber: > Apparently NAN and INFINITE are C99 as well (I should really get a > version of the old standard instead of mostly reading C99 :|). > > How about a simple const variable that will trick MSVC, while not > changing semantics. How about a function in libs/port or a macro in one of its headers? I believe the NAN/INFINITE issue is not specific to wined3d. With the const variable, msvc compiles the code, but still produces a warning.

2 2

Re: [1/2] gdi32: GetGlyphOutline should fail for a bitmap font.
by Huw Davies April 30, 2012

April 30, 2012

On Sat, Apr 28, 2012 at 05:52:13PM +0900, Dmitry Timoshkov wrote: > --- > dlls/gdi32/freetype.c | 6 ++++++ > dlls/gdi32/tests/font.c | 17 ++++++++++++----- > 2 files changed, 18 insertions(+), 5 deletions(-) This will break the display of bitmap fonts in winex11.drv . Do you have an app that depends on this? Huw.

2 1

Wine developer example sessions?
by Dan Kegel April 27, 2012

April 27, 2012

I'm bringing a new intern up to speed, and while I was showing him how to diagnose one particular wine bug, I recorded the session on a web page, http://kegel.com/wine/bug30486.html It occurred to me that recorded sessions like that might be useful to other beginners (above and beyond the more structured wine developer doc), so I created http://wiki.winehq.org/DeveloperExamples and linked to it from there. Does that seem useful, and are there other tutorials that could be linked to?

2 2

Re: user32/tests: Update DlgDirList tests
by Bruno Jesus April 27, 2012

April 27, 2012

On Sat, Apr 14, 2012 at 21:57, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Based on original patch from Christian Lupien from bug 8226. > > Tests required to later fix http://bugs.winehq.org/show_bug.cgi?id=8226 Is there anything else I could provide in helping to get this patch accepted? http://source.winehq.org/patches/data/85434 Regards, Bruno

1 0

Re: [1/3] d3dx9: Define DDS structures.
by Stefan Dösinger April 27, 2012

April 27, 2012

Am Donnerstag, 26. April 2012, 11:47:51 schrieb Józef Kucia: > + DWORD pitch_or_linear_size; Are you aware that lPitch is a (signed) LONG in the original DDSURFACEDESC structure? Honestly I have no idea why, and I have never seen an app that passes a negative pitch, but it might lead to obscure bugs if it is not checked.

3 2

Re: [3/3] d3dx9: Implement conversion from DDS pixel format to D3DFORMAT.
by Matteo Bruni April 26, 2012

April 26, 2012

Il 26 aprile 2012 11:47, Józef Kucia <joseph.kucia(a)gmail.com> ha scritto: > static D3DFORMAT dds_pixel_format_to_d3dformat(const struct dds_pixel_format *pixel_format) > { > - FIXME("Pixel format conversion not implemented.\n"); > + if (pixel_format->flags & DDS_PF_FOURCC) > + return dds_fourcc_to_d3dformat(pixel_format->fourcc); > + else if (pixel_format->flags & DDS_PF_RGB) > + return dds_rgb_to_d3dformat(pixel_format); > + else if (pixel_format->flags & DDS_PF_LUMINANCE) > + return dds_luminance_to_d3dformat(pixel_format); > + else if (pixel_format->flags & DDS_PF_ALPHA_ONLY) > + return dds_alpha_to_d3dformat(pixel_format); You don't need all those 'else's, the 'return's imply that you get there only when the 'if' condition isn't true. The same applies in other areas of this patch. I don't mind much, but since you have to resend the series anyway...

1 0

Re: [1/3] d3dx9: Define DDS structures.
by Henri Verbeet April 26, 2012

April 26, 2012

Is there no header that should define these?

2 2

Re: [2/3] d3dx9: Add partial DDS support implementation for D3DXGetImageInfo functions.
by Henri Verbeet April 26, 2012

April 26, 2012

On 26 April 2012 11:47, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > +static HRESULT get_image_info_from_dds(LPCVOID buffer, DWORD length, D3DXIMAGE_INFO *info) Please avoid types like LPCVOID.

1 0

Re: [PATCH 1/2] amstream: Add stubbed implementation of DirectDrawStreamSample. (try 4)
by Marvin April 26, 2012

April 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18050 Your paranoid android. === WVISTAADM (32 bit amstream) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: gdiplus: GdipDrawString is not supposed to use the layout rectangle for clipping. Take 2.
by Dmitry Timoshkov April 25, 2012

April 25, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > There is a dedicated clip region in the graphics object. Please ignore that patch or mark it as rejected, the real problem has been fixed by 9b5b04c1c1a7b32dd3e1e453b6d739082c4ccede. -- Dmitry.

1 0

Re: [PATCH 1/2] amstream: Add stubbed implementation of DirectDrawStreamSample. (try 3)
by Alexandre Julliard April 25, 2012

April 25, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > Try3: Put sample stuff in stream_sample.c > Try2: Fix QueryInterface. It was better without creating a new file. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/4] make_unicode: Create tables with data needed by nameprep algorithm
by Alexandre Julliard April 25, 2012

April 25, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > + dump_nameprep_range($INPUT, $nameprep_flags{"unassigned"}, \@flags_table) if (/A.1/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.1.2/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.2.2/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.3/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.4/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.5/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.6/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.7/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.8/); > + dump_nameprep_range($INPUT, $nameprep_flags{"prohibited"}, \@flags_table) if (/C.9/); > + dump_nameprep_range($INPUT, $nameprep_flags{"bidi_ral"}, \@flags_table) if (/D.1/); > + dump_nameprep_range($INPUT, $nameprep_flags{"bidi_l"}, \@flags_table) if (/D.2/); > + > + dump_nameprep_map($INPUT, \@mapping_table) if (/B.1/); > + dump_nameprep_map($INPUT, \@mapping_table) if (/B.2/); These names are confusing, the functions are loading data not dumping it. > + for (my $i = 0; $i < 65536; $i++) > + { > + next unless defined $flags_table[$i]; > + $flags_table[$i] += $i; > + } > + > + open OUTPUT,">$filename.new" or die "Cannot create $filename"; > + print "Building $filename\n"; > + print OUTPUT "/* Nameprep algorithm related data */\n"; > + print OUTPUT "/* generated from $STRINGPREP */\n"; > + print OUTPUT "/* DO NOT EDIT!! */\n\n"; > + print OUTPUT "#include \"wine/unicode.h\"\n\n"; > + DUMP_CASE_TABLE( "nameprep_char_type", @flags_table ); It doesn't make sense to use a case table for this, it's just flags. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: vbscript: 'property' may be both keyword and identifier
by Marvin April 25, 2012

April 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18045 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] server: Revise completion behavior to allow completions for cancelled sockets (try 2).
by Alexandre Julliard April 24, 2012

April 24, 2012

"Erich E. Hoover" <ehoover(a)mines.edu> writes: > Real Name: > Erich Hoover > > Description: > This patch changes how the close socket operation works so that if > an async operation is registered then closing the handle will be > deferred until the async operation has completed. I would find it very suprising if this were how it's supposed to work, particularly since multiple handles can of course be opened to the same socket. You'll need very convincing tests for this... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/5] gdi32: Introduce a list of font file/data.
by Alexandre Julliard April 24, 2012

April 24, 2012

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > @@ -962,6 +972,22 @@ static Family *find_family_from_any_name(const WCHAR *name) > return NULL; > } > > +static Font *find_font_file(const char *file) > +{ > + if (file != NULL) > + { > + Font *font; > + > + LIST_FOR_EACH_ENTRY(font, &font_list, Font, entry) > + { > + if (font->file != NULL && strcmp(font->file, file) == 0) > + return font; > + } > + } > + > + return NULL; > +} You can't compare files this way, different paths can point to the same file. > @@ -2927,7 +2988,8 @@ static BOOL get_fontdir( const char *unix_name, struct fontdir *fd ) > DWORD type; > > if (!ft_face) return FALSE; > - face = create_face( ft_face, 0, unix_name, NULL, 0, 0, FALSE ); > + font.file = (char *)unix_name; Don't do that. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: gdi32: Add support for emulating bold faces of bitmap fonts.
by Dmitry Timoshkov April 24, 2012

April 24, 2012

Hello, Any feedback on this patch? -- Dmitry.

1 0

Re: winex11.drv: Windows always generates VK_DECIMAL for Del/. on a keypad.
by Dmitry Timoshkov April 24, 2012

April 24, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Windows always generates VK_DECIMAL for Del/. on a keypad while some > X11 keyboard layouts generate XK_KP_Separator instead of XK_KP_Decimal > in order to produce a locale dependent numeric separator. > > X11 handles XK_KP_Separator same way as XK_KP_Decimal for all tested > keyboard layouts, so passing XK_KP_Separator instead of XK_KP_Decimal > to XKeysymToKeycode doesn't break things. Pressing Del/. with NumLock > turned on still correctly generates '.' or ',' depending on keyboard > layout and matches what Windows does. > > This patch fixes an application which uses VK_DECIMAL as a sign to break > the input string and insert a separator while entering a currency/price. Is there anything else I could provide in helping to get this patch accepted? -- Dmitry.

1 1

Re: [3/5] mapi32: Convert sendmail_extended_mapi to Unicode
by Alexandre Julliard April 24, 2012

April 24, 2012

Owen Rudge <orudge(a)codeweavers.com> writes: > + > +/* Macro to test for validity before freeing a pointer */ > +#define mapi_heap_free(_ptr) if (_ptr) { HeapFree(GetProcessHeap(), 0, (_ptr)); } You don't need that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Mono packaging status
by Vincent Povirk April 24, 2012

April 24, 2012

So, I've finally had some time to work on Mono packaging. I think I have a sort of "first draft" ready. The goal is to create an MSI package of Mono, similar to the one we use for Gecko, which Wine will install automatically when updating a prefix, unless native mscoree is installed. This package will include all the Mono runtime files, as well as any registry keys and files that need to be installed to the Windows system for .NET compatibility. Anything .NET that we want to replace (including XNA, WPF, and msvcm libraries) will be included. Ideally, with this package installed, any official installers for .NET components will decide they are already installed and do nothing. To install native .NET, it will be necessary to uninstall the Mono package (using "wine uninstaller --remove '{E45D8920-A758-4088-B6C6-31DBB276992E}'", which will continue to work for the foreseeable future). Before the Mono package is installed, and after it is removed, no .NET registry keys or files will be present, so in theory the installers will just work (but in practice they probably will require work-arounds for Wine bugs). There will be only one package for 32-bit and 64-bit. Most of the compiled code is architecture-independent, so it doesn't make much sense to have separate packages. The Mono package versions will be loosely tied to Wine version. On prefix creation time, Wine will attempt to install the version it "prefers". Due to limitations of MSI, this may mean that Wine will upgrade Mono automatically but never downgrade it. Because the Mono API is stable, it should be possible to use any Mono package with any Wine version back to 1.5.1, which was the first version to search for the Mono runtime dll based on architecture. I'm currently publishing the source code at https://github.com/madewokherd/wine-mono, but I'm not sure if that is a good permanent home. I do want to keep it on github so I can make and accept pull requests. I'm using submodules, so it will be necessary to clone with --recursive and update the submodules from time to time. The build process requires mingw-w64 (both 32-bit and 64-bit), Wine, and a version of the Mono C sharp compiler (gmcs or dmcs, I think), and not surprisingly is done by running build-winemono.sh. There should never be any more requirements, and I'd like to keep the version requirements on those as broad as I can. I want this to be easy to build, so other people can work on it. The 64-bit part appears to work on Windows, but it is not useful on Wine currently. I'll be working on fixing that, or at least getting Alexandre bug reports and test cases so he can work on it. I think that when it is fixed, we'll have a lot more 64-bit processes than we used to, for better or worse. For now, the only way to install the package is with msiexec. The current version is based on Mono 2.11.0, which has a serious deadlock bug on Windows. This will need to be resolved before I can do an actual release. Otherwise, I'm not expecting much difference from the official Mono 2.10 packages for Windows. The XNA, WPF, and msvcm stuff is not ready yet. So, I know it's kind of crappy right now, and I'm not asking for testing so much as comments. If you are a packager of Wine, I would like to make sure you can build it, and that the resulting build works apart from that deadlock bug. If for some reason you want to try it, the current version is at https://github.com/downloads/madewokherd/wine-mono/winemono-0.0.2.msi. I think I will need a new home for the binaries, because github only gives me enough space for about 5 of them. So, uh, don't count on that URL sticking around.

4 5

Re: [2/2] gdi32: Enumerated font size should not be too large.
by Huw Davies April 23, 2012

April 23, 2012

On 23/04/2012 15:32, Dmitry Timoshkov wrote: > This reverts commit f4625d1ae1109ee9a30faa8254b10779853f0ac2. > --- > dlls/gdi32/freetype.c | 2 +- > dlls/gdi32/tests/font.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 3875e4f..401cfd1 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -5048,7 +5048,7 @@ static void GetEnumStructs(Face *face, LPENUMLOGFONTEXW pelf, > font = alloc_font(); > > if(face->scalable) { > - height = -2048; /* 2048 is the most common em size */ > + height = 100; > width = 0; > } else { > height = face->size.y_ppem>> 6; You'll need to fix the ntmTm.ntmCellHeight and ntmTm.ntmAvgWidth values. Huw.

2 3

Re: gdiplus: Use symbolic name of the font style.
by Nikolay Sivov April 23, 2012

April 23, 2012

On 4/23/2012 17:31, Dmitry Timoshkov wrote: > --- > dlls/gdiplus/font.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/gdiplus/font.c b/dlls/gdiplus/font.c > index 169e28f..8157b0a 100644 > --- a/dlls/gdiplus/font.c > +++ b/dlls/gdiplus/font.c > @@ -767,7 +767,7 @@ GpStatus WINGDIPAPI GdipGetLineSpacing(GDIPCONST GpFontFamily *family, > static INT CALLBACK font_has_style_proc(const LOGFONTW *elf, > const TEXTMETRICW *ntm, DWORD type, LPARAM lParam) > { > - INT fontstyle=0; > + INT fontstyle = FontStyleRegular; > > if (!ntm) return 1; > Maybe it's better to make it 'enum FontStyle' after all.

2 1

Re: [PATCH 1/4] amstream: rename mediastream to ddrawmediastream. (resend)
by Alexandre Julliard April 23, 2012

April 23, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/amstream/Makefile.in | 2 > dlls/amstream/amstream.c | 6 + > dlls/amstream/amstream_private.h | 2 > dlls/amstream/ddrawmediastream.c | 256 ++++++++++++++++++++++++++++++++++++++ > dlls/amstream/mediastream.c | 251 ------------------------------------- > 5 files changed, 263 insertions(+), 254 deletions(-) > create mode 100644 dlls/amstream/ddrawmediastream.c > delete mode 100644 dlls/amstream/mediastream.c There's no reason to rename the file. Just put everything in there. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: iphlpapi: Move get_pid_map() and find_owning_pid() under #ifdef #ifdef __linux__.
by Alexandre Julliard April 23, 2012

April 23, 2012

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > ...like their sole user. > > Otherwise this warns on everything which is not __linux__. ;-) That's a feature. It needs to be implemented on other platforms. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] dmusic: Pass creation parameters to DMUSIC_CreateDirectMusicBufferImpl then allocate data buffer and set format accordingly.
by Alexandre Julliard April 23, 2012

April 23, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > +HRESULT WINAPI DMUSIC_CreateDirectMusicBufferImpl(LPDMUS_BUFFERDESC desc, LPVOID* ret_iface) > +{ > + IDirectMusicBufferImpl* dmbuffer; > + > + TRACE("(%p, %p)\n", desc, ret_iface); > + > + dmbuffer = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectMusicBufferImpl)); > + if (!dmbuffer) { > + *ret_iface = NULL; > + return E_OUTOFMEMORY; > + } > + > + dmbuffer->lpVtbl = &DirectMusicBuffer_Vtbl; > + dmbuffer->ref = 0; /* Will be inited by QueryInterface */ > + > + memcpy(&dmbuffer->format, &desc->guidBufferFormat, sizeof(GUID)); > + dmbuffer->size = (desc->cbBuffer + 3) & ~3; /* Buffer size must be multiple of 4 bytes */ > + > + dmbuffer->data = HeapAlloc(GetProcessHeap(), 0, sizeof(dmbuffer->size)); > + if (!dmbuffer->data) { > + HeapFree(GetProcessHeap(), 0, dmbuffer); > + *ret_iface = NULL; > + return E_OUTOFMEMORY; > + } > + > + return IDirectMusicBufferImpl_QueryInterface((LPDIRECTMUSICBUFFER)dmbuffer, &IID_IDirectMusicBuffer, ret_iface); While you are changing the function please also make it handle errors properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] dmsynth: Check the rigth CLSID to create the DirectMusicSynthSink object. (resend)
by Marvin April 21, 2012

April 21, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17990 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

winedbg and program stdout
by Ilya Basin April 21, 2012

April 21, 2012

When I debug a program with winedbg, it's output never goes to the same terminal. If it's compiled with -mconsole, it goes to a new console window; if compiled with -mwindows, the output is discarded. Any way to change this behavior?

2 1

Re: d3dx9_36: Add adjacency for D3DXCreateCylinder
by Rico Schüller April 20, 2012

April 20, 2012

Am 20.04.2012 16:20, schrieb David Adam: > > + if (adjacency) > > I'm not sure that this is correct, but why is adjacency not touched? What should be returned for adjacency, maybe a test will show it? I guess the temp ID3DXBuffer should be returned instead of leaked when all is successful... Cheers Rico

1 0

Re: jscript: Added regexp 'pre-parser' to support non-backslash-sequenced non-terminating '/' in characted classes
by Marvin April 20, 2012

April 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17979 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Are we missing the small folder_open icons?
by Francois Gouget April 20, 2012

April 20, 2012

In dlls/shell32/shell32.rc I see the following fixme: /* FIXME: Following three resources are not yet added */ /* @makedep: folder_open.ico */ IDI_SHELL_FOLDER_OPEN_SMALL ICON folder_open.ico /* @makedep: folder_open.ico */ IDI_SHELL_FOLDER_OPEN_LARGE ICON folder_open.ico /* @makedep: folder_open.ico */ IDI_SHELL_FOLDER_SMALL_XP ICON folder_open.ico However folder_open.ico is generated from an SVG file and we seem to be having it in multiple sizes. Also this fixme has been there forever. So is there really still something to be fixed? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U

2 1

Updating GSoC proposal
by Jacek Caban April 19, 2012

April 19, 2012

Hi all, GSoC is starting this year and, if we want to have good applications, we need to update our proposals. Usually the most attention is directed into adding new ones, while we keep obviously bad (or just bad IMO) proposals on the page. I'm planning to remove following project proposals: Security - implement sandboxing Theming - Implement Wine theming support NTDLL - support performance registry keys Winelib Aware Scons (or cmake) Cleanup Winemenubuilder to support generating Application Bundles on Mac OS X Wine-based application virtualization If someone knows a reason to not remove them, please reply. Cheers, Jacek

2 1

Re: d3dx9/tests: Add DDS pixel format tests for D3DXGetImageInfoFromFileInMemory.
by Matteo Bruni April 19, 2012

April 19, 2012

Il 19 aprile 2012 19:37, Józef Kucia <joseph.kucia(a)gmail.com> ha scritto: > --- > dlls/d3dx9_36/tests/surface.c | 65 +++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 65 insertions(+), 0 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c > index 87aa03e..51d6ebd 100644 > --- a/dlls/d3dx9_36/tests/surface.c > +++ b/dlls/d3dx9_36/tests/surface.c > @@ -22,6 +22,8 @@ > #include "wine/test.h" > #include "d3dx9tex.h" > #include "resources.h" > +#undef MAKE_DDHRESULT > +#include "ddraw.h" > I'm not sure that's a good idea. ddraw.h is not included in recent DirectX SDKs and the relevant definitions are "gone", as far as I know. So I think d3dx9 or its tests should not depend on that header. I'd just (re)declare the stuff you need privately in the test source file instead. You don't even need to use the same types/defines/variables names as those from ddraw.h, you just have to keep them compatible. On that point, I see that MSDN mentions the equivalent DDS_HEADER and DDS_PIXELFORMAT structures (http://msdn.microsoft.com/en-us/library/windows/desktop/bb943991%28v=vs.85%…) except those don't seem to be defined in the MS headers either. I guess you are free to use whatever names you like...

3 3