April 2012 - Wine-Devel - list.winehq.org

Re: [1/2] gdi32: GetGlyphOutline should fail for a bitmap font.
by Huw Davies April 30, 2012

April 30, 2012

On Sat, Apr 28, 2012 at 05:52:13PM +0900, Dmitry Timoshkov wrote: > --- > dlls/gdi32/freetype.c | 6 ++++++ > dlls/gdi32/tests/font.c | 17 ++++++++++++----- > 2 files changed, 18 insertions(+), 5 deletions(-) This will break the display of bitmap fonts in winex11.drv . Do you have an app that depends on this? Huw.

2 1

Wine developer example sessions?
by Dan Kegel April 27, 2012

April 27, 2012

I'm bringing a new intern up to speed, and while I was showing him how to diagnose one particular wine bug, I recorded the session on a web page, http://kegel.com/wine/bug30486.html It occurred to me that recorded sessions like that might be useful to other beginners (above and beyond the more structured wine developer doc), so I created http://wiki.winehq.org/DeveloperExamples and linked to it from there. Does that seem useful, and are there other tutorials that could be linked to?

2 2

Re: user32/tests: Update DlgDirList tests
by Bruno Jesus April 27, 2012

April 27, 2012

On Sat, Apr 14, 2012 at 21:57, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Based on original patch from Christian Lupien from bug 8226. > > Tests required to later fix http://bugs.winehq.org/show_bug.cgi?id=8226 Is there anything else I could provide in helping to get this patch accepted? http://source.winehq.org/patches/data/85434 Regards, Bruno

1 0

Re: [1/3] d3dx9: Define DDS structures.
by Stefan Dösinger April 27, 2012

April 27, 2012

Am Donnerstag, 26. April 2012, 11:47:51 schrieb Józef Kucia: > + DWORD pitch_or_linear_size; Are you aware that lPitch is a (signed) LONG in the original DDSURFACEDESC structure? Honestly I have no idea why, and I have never seen an app that passes a negative pitch, but it might lead to obscure bugs if it is not checked.

3 2

Re: [3/3] d3dx9: Implement conversion from DDS pixel format to D3DFORMAT.
by Matteo Bruni April 26, 2012

April 26, 2012

Il 26 aprile 2012 11:47, Józef Kucia <joseph.kucia(a)gmail.com> ha scritto: > static D3DFORMAT dds_pixel_format_to_d3dformat(const struct dds_pixel_format *pixel_format) > { > - FIXME("Pixel format conversion not implemented.\n"); > + if (pixel_format->flags & DDS_PF_FOURCC) > + return dds_fourcc_to_d3dformat(pixel_format->fourcc); > + else if (pixel_format->flags & DDS_PF_RGB) > + return dds_rgb_to_d3dformat(pixel_format); > + else if (pixel_format->flags & DDS_PF_LUMINANCE) > + return dds_luminance_to_d3dformat(pixel_format); > + else if (pixel_format->flags & DDS_PF_ALPHA_ONLY) > + return dds_alpha_to_d3dformat(pixel_format); You don't need all those 'else's, the 'return's imply that you get there only when the 'if' condition isn't true. The same applies in other areas of this patch. I don't mind much, but since you have to resend the series anyway...

1 0

Re: [1/3] d3dx9: Define DDS structures.
by Henri Verbeet April 26, 2012

April 26, 2012

Is there no header that should define these?

2 2

Re: [2/3] d3dx9: Add partial DDS support implementation for D3DXGetImageInfo functions.
by Henri Verbeet April 26, 2012

April 26, 2012

On 26 April 2012 11:47, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > +static HRESULT get_image_info_from_dds(LPCVOID buffer, DWORD length, D3DXIMAGE_INFO *info) Please avoid types like LPCVOID.

1 0

Re: [PATCH 1/2] amstream: Add stubbed implementation of DirectDrawStreamSample. (try 4)
by Marvin April 26, 2012

April 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18050 Your paranoid android. === WVISTAADM (32 bit amstream) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: gdiplus: GdipDrawString is not supposed to use the layout rectangle for clipping. Take 2.
by Dmitry Timoshkov April 25, 2012

April 25, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > There is a dedicated clip region in the graphics object. Please ignore that patch or mark it as rejected, the real problem has been fixed by 9b5b04c1c1a7b32dd3e1e453b6d739082c4ccede. -- Dmitry.

1 0

Re: [PATCH 1/2] amstream: Add stubbed implementation of DirectDrawStreamSample. (try 3)
by Alexandre Julliard April 25, 2012

April 25, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > Try3: Put sample stuff in stream_sample.c > Try2: Fix QueryInterface. It was better without creating a new file. -- Alexandre Julliard julliard(a)winehq.org

1 0