April 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 4/4] jscript: Added Number.toPrecision implementation
by Marvin April 19, 2012

April 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17957 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] jscript: Added Number.toExpontential implementation
by Marvin April 19, 2012

April 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17956 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/4] jscript: Added Number.toFixed implementation
by Marvin April 19, 2012

April 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17955 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] ws2_32: Revise AcceptEx behavior to send completions for canceled sockets (resend 3, deferred).
by Alexandre Julliard April 19, 2012

April 19, 2012

"Erich E. Hoover" <ehoover(a)mines.edu> writes: > @@ -256,10 +256,12 @@ void async_set_result( struct object *obj, unsigned int status, unsigned int tot > else > { > if (async->timeout) remove_timeout_user( async->timeout ); > + if (async->completion && async->data.cvalue && status != STATUS_ALERTED) > + add_completion( async->completion, async->comp_key, async->data.cvalue, status, total ); > + else if (async->completion && async->data.cvalue && status == STATUS_ALERTED) > + status = STATUS_SUCCESS; This looks pretty hackish, the server shouldn't have to care about the status values or patch them up for the client. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] wininet: Add a new common module information struct
by Piotr Caban April 18, 2012

April 18, 2012

On 04/16/12 22:03, Morten Rønne wrote: > Add a new common module information struct for urlcache and functions to > do initialization of the struct. This is intended to be a new way to > more easily create Ansi and Unicode version of the functions, by doing a > Ansi/Unicode preamble code that calls a common worker function that do > the real work. Is there any reason not to call Ansi function inside Unicode function? (This is the other way then it is done in most parts of wine, the reason for this is that urlcache stores ansi strings internally. Unicode urls should probably be converted using punycode encoding (IdnToAscii?)). This patch is also introducing lots of unneeded Ansi/Unicode conversions. I'm not sure if storing all url entry related information inside a structure makes anything easier/more readable. Especially when you need to make sure that a field is initialized before accessing it.

2 1

Re: [PATCH 1/2] wininet: Update structs with more information in preparation for implementation of more functionality.
by Piotr Caban April 18, 2012

April 18, 2012

On 04/16/12 22:00, Morten Rønne wrote: + DWORD AllocationTable[0xF6C]; There are defines describing allocation table size. It's better to define it as BYTE AllocationTable[ALLOCATION_TABLE_SIZE];

2 1

Patch 85420
by Christian Costa April 18, 2012

April 18, 2012

Hi, Patch http://source.winehq.org/patches/data/85420 is marked as pending. I've taken a look but I still don't understand what's wrong. Is there anything I've missed ? Thanks Christian

3 3

Re: gdiplus: Use StretchBlt instead of GdiAlphaBlend if device doesn't support alpha blending. Resend.
by Dmitry Timoshkov April 18, 2012

April 18, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > This patch makes printing of PNG and other images work from applications > which use gdiplus for that. > > Printer drivers can't support transparency or alpha blending in any way. > This patch was tested with wide range of images (some mixed with other > graphics and text), and output matches what native gdiplus does. Is there anything else I could provide in helping to get this patch accepted? -- Dmitry.

2 2

Re: mshtml: Copy filter value in HTMLElement_clone
by Marvin April 18, 2012

April 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17938 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] wininet: Add a new common module information struct
by Jacek Caban April 18, 2012

April 18, 2012

Hi Morten, On 04/16/12 22:03, Morten Rønne wrote: > typedef struct _HASH_CACHEFILE_ENTRY > { > CACHEFILE_ENTRY CacheFileEntry; > DWORD dwAddressNext; > DWORD dwHashTableNumber; > - struct _HASH_ENTRY HashTable[HASHTABLE_SIZE]; > -} HASH_CACHEFILE_ENTRY; > + HASH_ENTRY HashTable[HASHTABLE_SIZE]; > +} HASH_CACHEFILE_ENTRY, *LPHASH_CACHEFILE_ENTRY; > > typedef struct _DIRECTORY_DATA > { > @@ -187,13 +187,56 @@ typedef struct _URLCACHECONTAINER > HANDLE hMapping; /* handle of file mapping */ > DWORD file_size; /* size of file when mapping was opened */ > HANDLE hMutex; /* handle of mutex */ > -} URLCACHECONTAINER; > +} URLCACHECONTAINER, *LPURLCACHECONTAINER; Please don't use this kind of defined. LP* types make the code less readable for no good reason. Cheers, Jacek

1 0