May 2012 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: Web based translation tool
by Michal Čihař June 18, 2013

June 18, 2013

Hi Dne Mon, 12 Mar 2012 12:02:49 +0200 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > The Wine project is thinking about using Weblate in order to translate > Wine, you can look at the following discussion and see for yourself. That sounds great! > Looking good although a litle immature, not sure about authentication as > wel... For authentication you can basically use anything what can be used in Django. Any specific concerns on this topic? > I'll talk to Michal Cihar and ask him for a roadmap for this project. Well I don't have any real roadmap right now. I urgently needed replacement for Pootle because we got hit by too many bugs there and did not manage to understand the code there to be able to fix them myself. So far I think it is in pretty good shape for day to day work (with today's 0.5 release fixing few annoying bugs). Of course there are some features missing, you can check what I plan for 1.0 release here: https://github.com/nijel/weblate/issues?state=open&milestone=1 I currently hope to have 1.0 in a month or so, but I really don't want to commit to any specific date. PS: I'm not subscribed to mailing list so please CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

7 16

Wine automated testing update
by Jeremy White Aug. 6, 2012

Aug. 6, 2012

Hi Folks, At the last Wine conference, I volunteered to find a home for the WineTestBot that Ge's brother has been hosting, and to take over the Buildbot that Dan and Austin have been so diligently maintaining. This is an update on that project, mostly to help keep my procrastinating self moving it along. First, we have a lovely set of hardware; 4 servers, in a dedicated rack, with a dedicated static ip to the outside world. One server is the gateway, 2 are dedicated Linux test systems (with nice fast processor + gpus), and one is a beefy system capable of running many VMs. The plan was to move the existing VMWare based WineTestBot to this hardware and simply get the existing system up and running on the new hardware. Here we hit our first snag; the VMWare folks are not willing to provide a permanent license for VMWare to us. So, we've shifted gears, and are exploring whether something like qemu + kvm would be a sufficient alternate. I've done a little of this work, and Maarten is hopefully going to help me try converting the existing VMs to see if we can save any hassle by doing a conversion. In parallel, I learned a great deal about buildbot and the buildbot system that Dan has built. There are two especially valuable and useful functions provided by this buildbot: the first is essentially a patch watcher; a process that catches simple mistakes (e.g. build errors on different architectures, and so on). The second is more powerful and is encapsulated by the 'dotests.sh' shell script. The dotests.sh script does a good job of basically running make test and noticing any test failures outside of 'the usual ones'. There is an infrastructure for Buildbot is a good tool, and I invested a lot of energy into it (as have Dan and Austin). However, Alexandre has persuaded me that we should first explore integrating the dotest.sh functionality into the existing WineTestBot, as that would allow us to have a very simple clean web page, and would also allow us to integrate most cleanly with Alexandre's back end tools. Of course, WineTestBot is Perl code, and my Perl fu is low. So I have recently asked Francois to help with that effort as well. So the basic plan is as follows: 1. Test qemu/kvm with a few Windows versions to see if it'll work. 2. If so, modify WineTestBot to use qemu instead of vmware. (This is 'easy' because the WineTestBot code nicely isolates the VM functions, but 'hard', because VMWare provides some APIs that may have to be replicated). 3. Migrate WineTestBot to the new hardware stack 4. Write new code to run 'dotests.sh' as part of WineTestBot Cheers, Jeremy

9 11

Rethinking WineConf
by Jeremy White July 26, 2012

July 26, 2012

Hi All, This past Wine conference, while great fun as always, was not as well attended as Wine conferences in the past. So I would like to stir up trouble by suggesting we rethink WineConf. For those that have not attended, the Wine conference has been a mostly annual affair since 2002. It is open to all, but is advertised as being aimed at Wine developers. About 35 people attend each year. It's been in Minnesota about every 3rd year, and is otherwise 'normally' somewhere in Europe. I see the primary goal as creating human bonds between otherwise anonymous people (aka going to the pub). It's a bonus if it also spurs resolution to tricky issues, or motivates people to get more done. So I'd like to ask folks to brain storm with me. How could Wineconf be different? If you've never been, what would encourage you to come? If you've been to a technical conference recently that you thought was well done, what did they do well? Anything we could emulate? Any other ideas, or suggestions? Cheers, Jeremy

17 25

Re: mshtml: Set outgoing pass-by-address variable in an error case case within confirm_safety_load.
by Jacek Caban July 18, 2012

July 18, 2012

Hi Gerald, On 03/07/12 23:35, Gerald Pfeifer wrote: > I noticed we return in this case, without initializing this variable. > Visual inspection indicates we do not seem to access the variable in > this error case, but a) better safe than sorry, and b) GCC 4.8 currently > warns about it. > > Not sure URLPOLICY_DISALLOW is the best return value, open for better > alternatives. I generally don't think this patch makes things any better (or worse). If we return an error, the caller should not expect this value to be sane. What's the GCC 4.8 warning? Jacek

2 4

winebuild port to ARM?
by Roger Cruz July 7, 2012

July 7, 2012

Has anyone worked or is currently working on porting the x86 specific code in Winebuild to ARM? Specifically the relay.c file? Thanks Roger R. Cruz

2 9

1.4 has dropped off the list for AppDB submissions
by Rosanne DiMesio June 6, 2012

June 6, 2012

As of the release of 1.5.5, 1.4 has dropped off the list of Wine versions for which AppDB test reports can be submitted. Can someone please add it to the list of stable releases that are always available in the dropdown list? Until it's put back, users will not be able to submit new test reports for 1.4. We could avoid having this problem every time there's a new stable release if users were allowed to submit test reports for any version. Bugzilla lists every version, I don't see why the AppDB doesn't. -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 2

Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)
by Dmitry Timoshkov May 31, 2012

May 31, 2012

sir-lexa <sir-lexa(a)yandex.ru> wrote: > case WM_DESTROY: > - PostQuitMessage(0); > + /* PostQuitMessage(0); It lets some tests to be skipped */ > return TRUE; This is not acceptable, there is much more behind the scene. You need to figure out the real reason of skipping the tests. -- Dmitry.

2 2

Re: [PATCH 3/5] ddraw/tests: Add test_coop_level_mode_set() for older ddraw versions.
by Marvin May 31, 2012

May 31, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18687 Your paranoid android. === WNT4WSSP6 (32 bit ddraw2) === ddraw2.c:2282: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2284: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2310: Test failed: Expected surface width 640, got 800. ddraw2.c:2312: Test failed: Expected surface height 480, got 600. ddraw2.c:2327: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2338: Test failed: Expected surface width 640, got 800. ddraw2.c:2340: Test failed: Expected surface height 480, got 600. ddraw2.c:2406: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2408: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2434: Test failed: Expected surface width 640, got 800. ddraw2.c:2436: Test failed: Expected surface height 480, got 600. ddraw2.c:2451: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2462: Test failed: Expected surface width 640, got 800. ddraw2.c:2464: Test failed: Expected surface height 480, got 600. === WNT4WSSP6 (32 bit ddraw1) === ddraw1.c:2145: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2147: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2173: Test failed: Expected surface width 640, got 800. ddraw1.c:2175: Test failed: Expected surface height 480, got 600. ddraw1.c:2190: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2201: Test failed: Expected surface width 640, got 800. ddraw1.c:2203: Test failed: Expected surface height 480, got 600. ddraw1.c:2269: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2271: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2297: Test failed: Expected surface width 640, got 800. ddraw1.c:2299: Test failed: Expected surface height 480, got 600. ddraw1.c:2314: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2325: Test failed: Expected surface width 640, got 800. ddraw1.c:2327: Test failed: Expected surface height 480, got 600.

1 0

Re: [PATCH 3/3] ntdll/tests: Add tests for RtlGetProductInfo [resend]
by Alexandre Julliard May 31, 2012

May 31, 2012

Detlef Riekenberg <wine.dev(a)web.de> writes: > Clone the kernel32 tests to verify, that the NULL pointer > check is present in ntdll.dll That's not useful, it's clearly the same function, it doesn't need to be tested twice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] win16/int21: make found filename uppercase.
by Alexandre Julliard May 31, 2012

May 31, 2012

Oleksij Rempel <bug-track(a)fisher-privat.net> writes: > @@ -3961,6 +3962,8 @@ static int INT21_FindNext( CONTEXT *context ) > INT21_FindPath = dta->fullPath = NULL; > } > dta->count = n; > + p = dta->filename; > + for ( ; *p; p++) *p = toupper(*p); Using toupper is probably not a good idea on OEM codepage strings. Which app depends on this? -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [4/4] windowscodecs: Add stub IWICMetadataBlockReader to PNG decoder.
by Marvin May 30, 2012

May 30, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18675 Your paranoid android. === WXPPROSP3 (32 bit metadata) === metadata: unhandled exception c0000005 at 4CCA826D === W2K8SE (32 bit metadata) === metadata: unhandled exception c0000005 at 72C28045

1 0

Re: [3/4] windowscodecs: Add test for IWICMetadataBlockReader interface.
by Marvin May 30, 2012

May 30, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18674 Your paranoid android. === WXPPROSP3 (32 bit metadata) === metadata: unhandled exception c0000005 at 4CCA826D === W2K8SE (32 bit metadata) === metadata: unhandled exception c0000005 at 72C28045

1 0

crypt32/tests(1/6): Don't shadow a variable with a variable of a different type
by Juan Lang May 30, 2012

May 30, 2012

--Juan

1 0

Re: [2/2]kernel32/test: added test for OutputDebugStringA called with NULL pointer
by Marvin May 30, 2012

May 30, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18671 Your paranoid android. === WXPPROSP3 (32 bit debugger) === Timeout === W2K3R2SESP2 (32 bit debugger) === Timeout

1 0

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream. (try 2)
by Dmitry Timoshkov May 30, 2012

May 30, 2012

Józef Kucia <joseph.kucia(a)gmail.com> wrote: > + offset.QuadPart = 0; > + size.u.LowPart = 0xffffffff; > + size.u.HighPart = 0xffffffff; > + return IWICStream_InitializeFromIStreamRegion(iface, pIStream, offset, size); What prevents you from discovering correct stream size? -- Dmitry.

3 5

Re: [1/2] mscoree: Install Wine Mono on prefix update.
by Alexandre Julliard May 30, 2012

May 30, 2012

Vincent Povirk <madewokherd(a)gmail.com> writes: > From d271ba591f6afb4e0b2356da24841f54d5f11b9b Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Tue, 29 May 2012 10:35:36 -0500 > Subject: [PATCH 1/2] mscoree: Install Wine Mono on prefix update. > > --- > dlls/mscoree/mscoree_main.c | 120 +++++++++++++++++++++++++++++++++++++++++++ > tools/wine.inf.in | 1 + > 2 files changed, 121 insertions(+) This is breaking 64-bit prefixes, because things are not done in the correct order. It also looks like the package is not creating the 64-bit registry keys. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 4/4] jscript: Added VT_I2 tests
by Marvin May 30, 2012

May 30, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18657 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/3] jscript: Get rid of ret_nan hack
by Ruslan Kabatsayev May 30, 2012

May 30, 2012

Hello, This patch (committed as d0a719a79dae001df341db907fcae54118691d35) leads to compilation error: make[1]: Entering directory `/fastdocs/programmer/wine-git/dlls/msadp32.acm' make[1]: Nothing to be done for `all'. make[1]: Leaving directory `/fastdocs/programmer/wine-git/dlls/msadp32.acm' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -I/opt/Xorg-7.5/include -L/opt/Xorg-7.5/lib -o string.o string.c lex.c: In function ‘cc_token’: lex.c:936:71: error: ‘NAN’ undeclared (first use in this function) lex.c:936:71: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [lex.o] Error 1 I've tried doing git clean -xdf, but this still doesn't compile. Regards, Ruslan On Tue, May 29, 2012 at 2:53 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/jscript/date.c | 28 ++++++++++++++-------------- > dlls/jscript/error.c | 3 ++- > dlls/jscript/global.c | 2 +- > dlls/jscript/jscript.h | 7 ------- > dlls/jscript/jsutils.c | 6 +++--- > dlls/jscript/lex.c | 2 +- > 6 files changed, 21 insertions(+), 27 deletions(-) > > > > >

2 1

ru.po: improved an Russian translation
by Oleg Yarigin May 30, 2012

May 30, 2012

There are some improvements of a style (now it is more official) and non-translated empty lines. To avoid an character encoding interruption, I send the diff file as a packed text file attachment (ru_diff.txt.bz2, 22.3 KB).

3 2

stub for SetThreadStackGuarantee
by Daniel Jelinski May 29, 2012

May 29, 2012

Hello, SQL Server Management Studio 2005 needs SetThreadStackGuarantee to either be absent or return TRUE - otherwise it refuses to run at all. Is there a reason for this stub to return FALSE? Regards, Daniel

1 0

Re: kernel32/volume: Don't modify the last error in GetVolumeInformation
by Alexandre Julliard May 29, 2012

May 29, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -729,6 +731,8 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root, LPWSTR label, DWORD label_len, > } > else > { > + /* At this point, last error is ERROR_NOT_SUPPORTED. Restoring the previous one */ > + SetLastError(lastError); You should never need to do that sort of thing, there are no guarantees about last error on success. -- Alexandre Julliard julliard(a)winehq.org

2 1

Implementing joystick ids in DirectInput
by Lucas Zawacki May 29, 2012

May 29, 2012

Hey guys, asking for a little code review here... I was looking at the solution for this bug http://bugs.winehq.org/show_bug.cgi?id=30705 and it comes down to implementing the DIPROP_JOYSTICKSID property for joystick devices. After some research on what this is I know it's always a number between (0,n), where n is the number of joysticks connected, and is analogous to the winmm driver joystick id. The solution I came up is in the attached patch, it's a little weird but I found it hard to give a unique ID to each joystick on Linux when they can come from different drivers. This solution uses the order which dinput puts the joysticks on it's device list and will work regardless. If someone has a better way to do it I'd like to know. Cheers,

2 2

Re: [PATCH 1/3] ntdll: Implement RtlGetProductInfo and use it for GetProductInfo
by Alexandre Julliard May 29, 2012

May 29, 2012

Detlef Riekenberg <wine.dev(a)web.de> writes: > The wrapper in kernel32 is not needed. > RtlGetProductInfo and GetProductInfo have the same signature and > tests show the same results. No they don't have the same signature, look closer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] d3dx9: Implement D3DXSaveSurfaceToFileInMemory.
by Vincent Povirk May 28, 2012

May 28, 2012

> - hr = IWICImagingFactory_CreateStream(factory, &stream); > + hr = IWICImagingFactory_CreateStream(factory, &wic_stream); > IWICImagingFactory_Release(factory); > if (FAILED(hr)) goto cleanup_err; > > - hr = IWICStream_InitializeFromFilename(stream, dst_filename, GENERIC_WRITE); > + hr = CreateStreamOnHGlobal(NULL, TRUE, &stream); > if (FAILED(hr)) goto cleanup_err; > > + hr = IWICStream_InitializeFromIStream(wic_stream, stream); Why bother creating an IWICStream here? Just use your HGLOBAL stream to initialize the encoder.

1 0

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream.
by Vincent Povirk May 28, 2012

May 28, 2012

> +static HRESULT WINAPI StreamOnStream_Seek(IStream *iface, > + LARGE_INTEGER dlibMove, DWORD dwOrigin, ULARGE_INTEGER *plibNewPosition) > +{ > + StreamOnStream *This = StreamOnStream_from_IStream(iface); > + HRESULT hr=S_OK; > + TRACE("(%p)\n", This); > + > + EnterCriticalSection(&This->lock); > + hr = IStream_Seek(This->stream, dlibMove, dwOrigin, plibNewPosition); > + LeaveCriticalSection(&This->lock); > + > + return hr; > +} The IWICStream needs to have an independent position from the underlying stream. Also, why not just forward to InitializeFromIStreamRegion?

1 0

Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)
by Marvin May 28, 2012

May 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18630 Your paranoid android. === W7PROX64 (32 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible. === TEST64_W7SP1 (32 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible. === W7PROX64 (64 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible. === TEST64_W7SP1 (64 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible.

1 0

Re: d3dx9_36/tests: Add tests for D3DXCreatePolygon
by Marvin May 27, 2012

May 27, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18615 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

func or pFunc in tests ?
by GOUJON Alexandre May 27, 2012

May 27, 2012

Hi, I'm planning to add a test in the wine test suite and I noticed a difference. Some tests call directly the function by its name (i.e. GetWindowsDirectory, CreateFileA, CloseHandle...) while others declare a pointer to the function (prefixing its name by 'p' and followed by a capital letter) retrieved via GetProcAddress. I know that tests have been written by lots of different people at different times and the general rule is "follow the style of the test file to be consistent" but here, both styles exist in the same file (kernel32/tests/volume.c). Is there any rule concerning using func over pFunc ? Is it related to the module it comes from ? Thanks

2 2

[website] Logo license? Usable in a propritary App?
by André Hentschel May 25, 2012

May 25, 2012

Hey, they use the "old" WineHQ Logo in this 99 Cent App: https://play.google.com/store/apps/details?id=com.appdevandroid.framework.w… Is that ok? If not, could the creater please contact them. The Icon could be misleading. -- Best Regards, André Hentschel

1 0

Fwd: [Freerdp-devel] WinPR: Windows Portable Runtime
by Pau Garcia i Quiles May 25, 2012

May 25, 2012

FYI ---------- Forwarded message ---------- From: Marc-André Moreau <marcandre.moreau(a)gmail.com> Date: Fri, May 25, 2012 at 3:04 AM Subject: [Freerdp-devel] WinPR: Windows Portable Runtime To: freerdp-devel <freerdp-devel(a)lists.sourceforge.net> Dear FreeRDP community, I have an announcement to make regarding a new spin-off project which I've been preparing for a while. Please read as this will set the tone of future development :) You can find most current WinPR development work on the winpr branch: https://github.com/FreeRDP/FreeRDP/tree/winpr WinPR is a spin-off project of FreeRDP which aims at providing a portable implementation of important portions of the Windows API. Just like FreeRDP, WinPR is released under the Apache license. Unlike Wine, WinPR does not provide binary compatibility, and does not require applications to be built for Windows. Instead, WinPR provides API compatibility for applications targeting non-Windows environments. When on Windows, the original native API is being used instead of the equivalent WinPR implementation, without having to modify the code using it. WinPR is the result of long and thoughtful process that came up after years of FreeRDP development. RDP, as you know, is a protocol designed by Microsoft and is primarily “Windows to Windows”. In many instances, protocol messages rely heavily on Windows-specific APIs which have no direct equivalent on other operating systems. For instance, core graphical messages are based on GDI, network level authentication makes use of the Microsoft SSPI authentication modules (CredSSP, NTLM), and terminal server gateway makes use of both SSPI and MSRPC. That’s not even mentioning all the effort that went into mapping keyboard systems and time zones. Developing FreeRDP is in many ways all about implementing Windows APIs outside of Windows. Immense efforts have gone into the implementation of such features, to the point where they begin having value outside of FreeRDP itself. At this point, one of the most valuable part of WinPR is the set of SSPI modules. Various NTLM implementations exist, all with different interfaces, but the WinPR implementation is a direct replacement of the original. This is an advantage because the API is already well documented, with expected inputs and outputs. FreeRDP can also optionally build against the native SSPI modules when on Windows. Making this code easily reusable to any one means that application developers now have an easy way of porting their applications to make use of the Windows authentication architecture. WinPR is also a response to a recurrent problem in FreeRDP development: the proliferation of custom helpers and utility functions. While those are useful, they often need to be modified and updated to meet new requirements, causing frequent API changes. Breaking the API regularly obviously makes a lot of developers unhappy. By choosing to implement an existing and mature API, we can effectively get rid of the core of the problem. If a certain API has been used for years and it fits the needs of most people, you are less likely to need to break it yourself. Besides the argument of API stability, there is another huge advantage in using the Windows API over custom utility functions: the ability to easily share code with other projects that aim at implementing the same API. For instance, the SSPI modules currently developed in WinPR are of high interest to the ReactOS project. If the code was filled with custom utility functions, it would be much harder to use outside of FreeRDP, hindering such collaboration opportunities. For instance, instead of wrapping calls to MultiByteToWideChar() in a custom unicode conversion utility, we can use MultiByteToWideChar() as the utility function and provide an implementation on non-Windows systems. As a general rule in WinPR, if a utility function can be replaced by a part of the Windows API, then the Windows API will have precedence. Otherwise, a utility method can be used, keeping in mind the downsides of it. WinPR is also designed to be as modular as possible, using the MinWin architecture as a reference. MinWin is a refactoring effort of the Windows API which is more cleaner and comprehensive than the original. The API has been separated into logical sets, each with a DLL. Not a lot of documentation is available online about MinWin, but one can find its structure in the MSDN article “Windows API Sets”: http://msdn.microsoft.com/en-us/library/hh802935/ Just like MinWin, WinPR aims at being minimalistic and modular, such that one can have fine grained control over what is to be used. For projects making use of only a small amounts of WinPR, it should be possible to depend only on the minimum required. At last, why not simply use Wine or code from other projects like ReactOS or Samba? In all of these cases, there are both licensing and architectural problems which make it fairly hard for us to use in FreeRDP. For instance, Wine provides binary compatibility, and it’s not easy for a native Linux application to make use of parts of it without being built for Windows. Samba has an interesting MSRPC implementation, but it’s a fairly big dependency, without counting the fact that we can forget about portability on mobile platforms like Android and iOS. Unfortunately, none of these provide a highly portable implementation of the Windows API in the way we would like and under a license which is suitable to us, justifying the existence of WinPR. Through WinPR, investment done in FreeRDP development will take a new life and become even more valuable. We will open new doors to even higher levels of interoperability. We will foster collaboration with other projects following similar goals and reach new heights at an increasingly faster pace. Stay tuned, you will be amazed! ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Freerdp-devel mailing list Freerdp-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel -- Pau Garcia i Quiles http://www.elpauer.org (Due to my workload, I may need 10 days to answer)

1 0

Re: [5/5] propsys: Implement IPropertyStore::GetCount.
by Marvin May 24, 2012

May 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18573 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] propsys: Implement IPropertyStore::SetValue and GetValue.
by Marvin May 24, 2012

May 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18572 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: gdiplus: Reimplement GdipIsEmptyRegion.
by Dmitry Timoshkov May 24, 2012

May 24, 2012

Hello, I'm surprised that such a trivial patch wasn't accepted yet. But just in case it matters, current implementation doesn't work for paths and combined/complex regions. -- Dmitry.

2 2

Re: windowscodecs: Add a stubbed out IWICMetadataBlockReader interface.
by Vincent Povirk May 24, 2012

May 24, 2012

Please add a test showing that some builtin metadata handler implements this interface. On Thu, May 24, 2012 at 4:39 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/windowscodecs/metadatahandler.c | 69 ++++++++++++++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/dlls/windowscodecs/metadatahandler.c b/dlls/windowscodecs/metadatahandler.c > index afcff21..ffe6763 100644 > --- a/dlls/windowscodecs/metadatahandler.c > +++ b/dlls/windowscodecs/metadatahandler.c > @@ -39,6 +39,7 @@ typedef struct MetadataHandler { > IWICMetadataWriter IWICMetadataWriter_iface; > LONG ref; > IWICPersistStream IWICPersistStream_iface; > + IWICMetadataBlockReader IWICMetadataBlockReader_iface; > const MetadataHandlerVtbl *vtable; > MetadataItem *items; > DWORD item_count; > @@ -55,6 +56,11 @@ static inline MetadataHandler *impl_from_IWICPersistStream(IWICPersistStream *if > return CONTAINING_RECORD(iface, MetadataHandler, IWICPersistStream_iface); > } > > +static inline MetadataHandler *impl_from_IWICMetadataBlockReader(IWICMetadataBlockReader *iface) > +{ > + return CONTAINING_RECORD(iface, MetadataHandler, IWICMetadataBlockReader_iface); > +} > + > static void MetadataHandler_FreeItems(MetadataHandler *This) > { > int i; > @@ -92,6 +98,10 @@ static HRESULT WINAPI MetadataHandler_QueryInterface(IWICMetadataWriter *iface, > { > *ppv = &This->IWICPersistStream_iface; > } > + else if (IsEqualIID(&IID_IWICMetadataBlockReader, iid)) > + { > + *ppv = &This->IWICMetadataBlockReader_iface; > + } > else > { > *ppv = NULL; > @@ -317,6 +327,64 @@ static const IWICPersistStreamVtbl MetadataHandler_PersistStream_Vtbl = { > MetadataHandler_SaveEx > }; > > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_QueryInterface(IWICMetadataBlockReader *iface, > + REFIID iid, void **ppv) > +{ > + MetadataHandler *This = impl_from_IWICMetadataBlockReader(iface); > + return IWICMetadataWriter_QueryInterface(&This->IWICMetadataWriter_iface, iid, ppv); > +} > + > +static ULONG WINAPI MetadataHandler_MetadataBlockReader_AddRef(IWICMetadataBlockReader *iface) > +{ > + MetadataHandler *This = impl_from_IWICMetadataBlockReader(iface); > + return IWICMetadataWriter_AddRef(&This->IWICMetadataWriter_iface); > +} > + > +static ULONG WINAPI MetadataHandler_MetadataBlockReader_Release(IWICMetadataBlockReader *iface) > +{ > + MetadataHandler *This = impl_from_IWICMetadataBlockReader(iface); > + return IWICMetadataWriter_Release(&This->IWICMetadataWriter_iface); > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetContainerFormat( > + IWICMetadataBlockReader *iface, GUID *guid) > +{ > + FIXME("(%p,%p): stub\n", iface, guid); > + return E_NOTIMPL; > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetCount( > + IWICMetadataBlockReader *iface, UINT *count) > +{ > + FIXME("(%p,%p): stub\n", iface, count); > + return E_NOTIMPL; > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetReaderByIndex( > + IWICMetadataBlockReader *iface, UINT index, IWICMetadataReader **reader) > +{ > + FIXME("(%p,%u,%p): stub\n", iface, index, reader); > + return E_NOTIMPL; > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetEnumerator( > + IWICMetadataBlockReader *iface, IEnumUnknown **enum_metadata) > +{ > + FIXME("(%p,%p): stub\n", iface, enum_metadata); > + return E_NOTIMPL; > +} > + > +static const IWICMetadataBlockReaderVtbl MetadataHandler_MetadataBlockReader_Vtbl = > +{ > + MetadataHandler_MetadataBlockReader_QueryInterface, > + MetadataHandler_MetadataBlockReader_AddRef, > + MetadataHandler_MetadataBlockReader_Release, > + MetadataHandler_MetadataBlockReader_GetContainerFormat, > + MetadataHandler_MetadataBlockReader_GetCount, > + MetadataHandler_MetadataBlockReader_GetReaderByIndex, > + MetadataHandler_MetadataBlockReader_GetEnumerator > +}; > + > HRESULT MetadataReader_Create(const MetadataHandlerVtbl *vtable, IUnknown *pUnkOuter, REFIID iid, void** ppv) > { > MetadataHandler *This; > @@ -333,6 +401,7 @@ HRESULT MetadataReader_Create(const MetadataHandlerVtbl *vtable, IUnknown *pUnkO > > This->IWICMetadataWriter_iface.lpVtbl = &MetadataHandler_Vtbl; > This->IWICPersistStream_iface.lpVtbl = &MetadataHandler_PersistStream_Vtbl; > + This->IWICMetadataBlockReader_iface.lpVtbl = &MetadataHandler_MetadataBlockReader_Vtbl; > This->ref = 1; > This->vtable = vtable; > This->items = NULL; > -- > 1.7.10.1 > > >

1 0

Testing regedit
by Daniel Jelinski May 24, 2012

May 24, 2012

Hello, I just noticed that wine's regedit has a few interesting bugs that appear when running with native comctl32. Can I/should I file them in the bugzilla? Regards, Daniel

3 3

Re: [PATCH variant 1] dsound: use a low-quality FIR for games
by Andrew Eikum May 23, 2012

May 23, 2012

Thanks Alexander. Thoughts below... On Sat, May 19, 2012 at 09:09:35PM +0600, Alexander E. Patrakov wrote: > There are two ways to implement a high-performance resampler, and I > have prepared (conflicting, pick no more than one) patches for both: > > 1 (this patch): Use a shorter FIR with the existing code. This has the > advantage of higher quality (unwanted frequencies are at least > attempted to be rejected) and almost no new code. > 2 (the other patch): Write new code. E.g., linear interpolation. This > is what Windows XP does at its lowest quality setting, and it eats > less CPU than variant 1. > Do you have an opinion on which of these patches to use? The low-quality FIR has the advantage of not introducing another codepath. On the other hand, the linear resampler codepath is very simple, and even easier on the CPU. I'm leaning towards the linear resampler for its larger CPU usage benefits. > Also note that, as evicenced by the debugging patch, a Core 2 Duo > E6420 @ 2.13 GHz _can_ resample more than 32 streams simultaneously > from various weird rates to 48000 Hz. As GTA:SA reportedly creates > only 16 secondary buffers, it _should_ have more than enough CPU time > to mix them. IMHO, this makes bug #30639 look somewhat strange: on > GyB's computer, GTA:SA stutters, while Darwinia (which looks more > demanding about sound) doesn't. It may well be that in fact none of my > patches are needed, and that the real bug is that the CPU-intensive > cp_fields() function is called from a wrong thread or process. I don't > have the expertise needed to debug this. > I did some research on this. Darwinia creates up to 32 buffers, like you said. GTA:SA creates and destroys buffers as needed, and I saw it go as high as 31 in a quick test. Darwinia's buffer frequencies range in the 40-90 kHz range and resample to 22050 Hz, while GTA:SA's range around 10-20 kHz and resample to 48 kHz. So in each time step, GTA:SA requires about 1000-2000 get_current_sample() calls, but 4800 FIR convolutions per buffer. Darwinia requires 4000-9000 get_current_sample() calls, but only about 2200 convolutions per buffer. I suspect the convolutions are considerably more expensive than the get_current_sample() calls, so I would actually expect GTA:SA to be more CPU taxing. That should explain what's going on here. We could test this on Gyb's machine by setting DefaultSampleRate=22050 and hacking <dlls/dsound/primary.c:primarybuffer_SetFormat> to return S_OK without actually changing the primary buffer's format. That should give GTA:SA similar cp_fields performance to Darwinia, and I expect it would fix the lag issue. Andrew

2 2

Re: vbscript: Add support for integer values in conditional jumps.
by Marvin May 23, 2012

May 23, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18547 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

2 1

Re: [2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.
by Bruno Jesus May 22, 2012

May 22, 2012

On Mon, Apr 30, 2012 at 6:52 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/gdi32/freetype.c | 35 +++++++++++++++++++- > dlls/gdi32/tests/font.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 116 insertions(+), 2 deletions(-) I don't know if this patch was directly related to a bug or not but now we are sure it does really fix at least this bug: http://bugs.winehq.org/show_bug.cgi?id=12476 Best wishes, Bruno

1 0

Re: wineqtdecoder: Recreate audio extraction session when we run out of frames.
by Alexandre Julliard May 22, 2012

May 22, 2012

Aric Stewart <aric(a)codeweavers.com> writes: > This is instead of waiting until a movie is fully loaded before being > able to start playing. This eliminates the up to several second pause > when starting some, mostly avi, movies. > --- > dlls/wineqtdecoder/qtsplitter.c | 66 > +++++++++++++++++++++++++++++++++------ > 1 files changed, 56 insertions(+), 10 deletions(-) What about the comment that says that we can't do that? -- Alexandre Julliard julliard(a)winehq.org

2 1

winetricks & DLL overrides
by wylda＠volny.cz May 22, 2012

May 22, 2012

Hi Dan, i'm happy user of winetricks and thanks for all that work. Today i found out, that i wasn't able to reveal, that apps uses some native dll when using: winetricks settings alldlls=builtin further checking revealed, that winetricks(20120308) has several no longer available dll override compared to winecfg and some are missing, thus application uses them as native. So i add/del dlls from override_all_dlls list based on winecfg (1.5.3-164-gdec3d50) and the result is attached as a patch. Probably unusable for you, because: * no care about line length * i do not know whether removing no longer available dll's override is allowed (what's happen for users using old wine-1.0 and need dlls's override no longer available in wine-1.5.3) * shouldn’t be the dll's override in user.reg simply overwritten? As i noticed the names are there twice - 2nd one with "*" prefix making it confusing, which value will be used and the list in winecfg is twice as long. Thanks and regards, W.

2 2

Re: [1/2] ole32: Forward OleCreateLinkFromData and OleCreateStaticFromData to OleCreateFromData.
by Alexandre Julliard May 22, 2012

May 22, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > +/****************************************************************************** > + * OleCreateLinkFromData [OLE32.@] > + */ > +HRESULT WINAPI OleCreateLinkFromData(LPDATAOBJECT data, REFIID iid, > + DWORD renderopt, LPFORMATETC fmt, > + LPOLECLIENTSITE client_site, LPSTORAGE stg, > + LPVOID *obj) > +{ > + return OleCreateFromData(data, iid, renderopt, fmt, client_site, stg, obj); > +} > + > +/****************************************************************************** > + * OleCreateStaticFromData [OLE32.@] > + */ > +HRESULT WINAPI OleCreateStaticFromData(LPDATAOBJECT data, REFIID iid, > + DWORD renderopt, LPFORMATETC fmt, > + LPOLECLIENTSITE client_site, LPSTORAGE stg, > + LPVOID *obj) > +{ > + return OleCreateFromData(data, iid, renderopt, fmt, client_site, stg, obj); > +} Surely there's more to these functions than that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: quartz/tests: Fix compilation on systems that don't support nameless structs.
by Marvin May 21, 2012

May 21, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18512 Your paranoid android. === WNT4WSSP6 (32 bit filtermapper) === filtermapper.c:96: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:233: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:347: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:405: Test failed: CoCreateInstance failed with 80040154

2 1

Re: [PATCH 3/3] shell32: Move the pidl handling to the ExtractIcon_Constructor
by Nikolay Sivov May 20, 2012

May 20, 2012

On 5/20/2012 18:47, Detlef Riekenberg wrote: > } else if (IsEqualIID(riid,&IID_IExtractIconA)&&(cidl == 1)) { > - pidl = ILCombine(This->pidlRoot, apidl[0]); > - pObj = (LPUNKNOWN) IExtractIconA_Constructor(pidl); > - SHFree(pidl); > - hr = S_OK; > + return IExtractIconAW_Constructor(This->pidlRoot, apidl[0], FALSE, ppvOut); > } else if (IsEqualIID(riid,&IID_IExtractIconW)&&(cidl == 1)) { > - pidl = ILCombine(This->pidlRoot, apidl[0]); > - pObj = (LPUNKNOWN) IExtractIconW_Constructor(pidl); > - SHFree(pidl); > - hr = S_OK; > + return IExtractIconAW_Constructor(This->pidlRoot, apidl[0], TRUE, ppvOut); > } else if ((IsEqualIID(riid,&IID_IShellLinkW) || IsEqualIID(riid,&IID_IShellLinkA)) I think it's better to pass riid to constructor helper and return appropriate vtable according to that riid. That will also collapse this to a single 'if' testing for both interfaces. > +HRESULT IExtractIconAW_Constructor(LPCITEMIDLIST root, LPCITEMIDLIST item, BOOL is_unicode, void ** ppvOut) > { > - IExtractIconWImpl *ei; > + IExtractIconWImpl *ei = HeapAlloc(GetProcessHeap(), 0, sizeof(IExtractIconWImpl)); > + LPITEMIDLIST pidl = ILCombine(root, item); > > - TRACE("%p\n", pidl); > + if (!pidl || !ei) { > + SHFree(pidl); > + HeapFree(GetProcessHeap(), 0, ei); > + return E_OUTOFMEMORY; > + } > > - ei = HeapAlloc(GetProcessHeap(), 0, sizeof(*ei)); > ei->ref=1; > ei->IExtractIconW_iface.lpVtbl =&eivt; > ei->IExtractIconA_iface.lpVtbl =&eiavt; > ei->IPersistFile_iface.lpVtbl =&pfvt; > ei->pidl=ILClone(pidl); > > - pdump(pidl); Same here as in previous patch - storing combined result vs. making another clone.

1 0

Re: [PATCH 1/3] shell32: Add IQueryInfo in ShellFolder2_GetUIObjectOf [try 2]
by Nikolay Sivov May 20, 2012

May 20, 2012

On 5/20/2012 18:47, Detlef Riekenberg wrote: > +HRESULT IQueryInfo_Constructor(LPCITEMIDLIST root, LPCITEMIDLIST item, void ** ppvOut) > +{ > + IQueryInfoImpl *qi = HeapAlloc(GetProcessHeap(), 0, sizeof(IQueryInfoImpl)); > + LPITEMIDLIST pidl = ILCombine(root, item); > + > + if (!pidl || !qi) { > + SHFree(pidl); > + HeapFree(GetProcessHeap(), 0, qi); > + return E_OUTOFMEMORY; > + } > + > + qi->IQueryInfo_iface.lpVtbl =&IQueryInfo_vtbl; > + qi->ref = 1; > + qi->pidl = ILClone(pidl); > + > + SHFree(pidl); I don't see a reason to ILClone() here. You could just store ILCombine() result.

1 0

Re: dsound: Fixed compilation error caused by 942f2ce7
by Jacek Caban May 19, 2012

May 19, 2012

Hi Alexander, On 5/19/12 3:35 PM, Alexander E. Patrakov wrote: > There is no dummy union u anymore. > This doesn't seem right. They are still present, just generated by widl. Jacek

2 2

re: [appdb] Applications working flawlessly using patched wine should be rated Gold
by Dan Kegel May 18, 2012

May 18, 2012

Frédéric Delanoy wrote: -Application works flawlessly with some DLL overrides, other settings or third party software. +Application works flawlessly with some DLL overrides, some patches applied, other settings or third party software. Really? IMHO they should still be silver. Patches are very hard for the average user to deploy without a third party front end like POL, and appdb is not about POL. - Dan

7 13

Re: [1/2] comctl32/tests: Added tests for treeview right mouse click handling (try 3)
by Marvin May 18, 2012

May 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18480 Your paranoid android. === WNT4WSSP6 (32 bit treeview) === Timeout

1 0

Re: [PATCH 1/5] programs: First version of the joystick testing tool. Just lists connected joysticks.
by Alexandre Julliard May 18, 2012

May 18, 2012

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > --- > configure.ac | 1 + > programs/joystick/Makefile.in | 17 +++++++ > programs/joystick/main.c | 102 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 120 insertions(+) > create mode 100644 programs/joystick/Makefile.in > create mode 100644 programs/joystick/main.c I don't think it makes sense to add a command-line application for this. If there are really things that the user needs to configure, it should be a control panel. But ideally we should retrieve the settings from the Unix environment. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: quartz: COM cleanup for Parser_OutputPin
by Michael Stefaniuc May 18, 2012

May 18, 2012

Hello Aric, On 05/18/2012 04:27 PM, Aric Stewart wrote: > diff --git a/dlls/quartz/avisplit.c b/dlls/quartz/avisplit.c > index 5027e90..bac1b24 100644 > --- a/dlls/quartz/avisplit.c > +++ b/dlls/quartz/avisplit.c > @@ -288,7 +288,7 @@ static HRESULT AVISplitter_next_request(AVISplitterImpl *This, DWORD streamnumbe > > static HRESULT AVISplitter_Receive(AVISplitterImpl *This, IMediaSample *sample, DWORD streamnumber) > { > - Parser_OutputPin *pin = (Parser_OutputPin *)This->Parser.ppPins[1+streamnumber]; > + Parser_OutputPin *pin = impl_Parser_OutputPin_from_IPin(This->Parser.ppPins[1+streamnumber]); this isn't right. impl_from_... should be used only from methods of the respective implementation. You can either: - Make This->Parser.ppPins an array of Parser_OutputPin instead of IPin - Or if you need to support application provided IPin then you'll need an unsafe_impl_from_... > HRESULT hr; > LONGLONG start, stop, rtstart, rtstop; > StreamData *stream = &This->streams[streamnumber]; bye michael

2 1

Logging issue ?
by GOUJON Alexandre May 18, 2012

May 18, 2012

Hi, To understand why a game does not work with the disc while it does with the ISO (created from the same disc), I made a log with +tid,+relay,+volume in both cases and noticed : - some lines (call or ret) are not printed / missing - some lines are half-printed and joined with the following I know sometimes a trailing \n is missing in TRACE() so the output is uncertain. But that doesn't seem to be the case here. Maybe it's not thread safe or something like that ? I tried using taskset 1 wine .. to force using one core but no luck. Here a small part of my log (order not modified, I just remove lines from other threads): 0030:Call KERNEL32.GetVolumeInformationA(09732288 "D:",097321ec,0000007f,00000000,00000000,097321d8,00000000,00000000) ret=0057b045 0030:trace:volume:GetVolumeInformationW L"\\??\\D:\\": found fs type 50009:Call wined3d.wined3d_mutex_unlock() ret=7ed6e3a6 0030:Ret KERNEL32.CreateFileA() retval=000001f4 ret=00c8b5ab 0030:Call KERNEL32.DeviceIoControl(000001f4,00041018,00000000,00000000,09732190,00000008,097321a4,00000000) ret=00c8b64a The game calls GetVolumeInformationA .. the trace is mixed with output of another thread .. I guess the game open the device (no call line) .. and then do some ioctl. No trace of how the game opened the device.. I can do several logs and try to compare each other to have a complete puzzle but that's not very handy. Any thought ? idea ? advice ? (I'm using packaged wine on x86_64) Thanks

2 1

Fwd: Re: Logging issue ?
by GOUJON Alexandre May 18, 2012

May 18, 2012

Also replying to wine-devel -------- Original Message -------- Subject: Re: Logging issue ? Date: Fri, 18 May 2012 16:52:34 +0200 From: GOUJON Alexandre <ale.goujon(a)gmail.com> To: Nikolay Sivov <bunglehead(a)gmail.com> On 05/18/2012 05:31 PM, Nikolay Sivov wrote: > On 5/18/2012 17:23, GOUJON Alexandre wrote: >> Any thought ? idea ? advice ? > I believe there was a discussion about that in the past, It usually > helps to use a ">>" redirect that appends to log file instead of > replacing its contents. But you'll obviously need to clean a log file > before starting anything Using>> instead of> seems to work. It's weird but if it works... Thanks for the advice !

1 0

Re: [PATCH 3/4] shell32: Add IQueryInfo to more shellfolder
by Nikolay Sivov May 18, 2012

May 18, 2012

On 5/18/2012 14:06, Detlef Riekenberg wrote: > + } else if (IsEqualIID(riid,&IID_IQueryInfo)&& (cidl == 1)) { > + pidl = ILCombine (This->pidlRoot, apidl[0]); > + pObj = (IUnknown *) IQueryInfo_Constructor (pidl); > + SHFree (pidl); > + hr = S_OK; > } else { Patch doesn't have a cast here, and looks really redundant. If you really need that it's better to make IQueryInfo_Constructor look more like class factory call - with HRESULT and void** parameter. Also it looks like you always need to combine pidls and cleanup after that, I think it's better to combine them in constructor and keep result in QueryInfo impl. (instead of making a clone). So constructor could look like "HRESULT constructor(root, pidl, pObj)".

1 0

Re: [PATCH 1/4] shell32: Add IQueryInfo in ShellFolder2_GetUIObjectOf
by Nikolay Sivov May 18, 2012

May 18, 2012

On 5/18/2012 14:06, Detlef Riekenberg wrote: > + if (ppv == NULL) > + return E_POINTER; This is usually redundant. > + > + if (IsEqualGUID(&IID_IUnknown, riid) || > + IsEqualGUID(&IID_IQueryInfo, riid)) { > + *ppv =&This->IQueryInfo_iface; > + IUnknown_AddRef((IUnknown*)*ppv); > + TRACE("returning IQueryInfo: %p\n", *ppv); > + return S_OK; > + } Instead of using IUnknown for some reason a clean way could be to call IQueryInfo_AddRef(iface). Trace is not needed here - you have a trace on top of that and FIXME trace on a failure, so you'll know. > + > + *ppv = NULL; > + FIXME("(%p)->(%s %p) interface not supported\n", This, debugstr_guid(riid), ppv); > + return E_NOINTERFACE; > +} > +IQueryInfo *IQueryInfo_Constructor(LPCITEMIDLIST pidl) > +{ > + IQueryInfoImpl *qi; > + > + TRACE("(%p)\n", pidl); > + > + qi = HeapAlloc(GetProcessHeap(), 0, sizeof(IQueryInfoImpl)); > + qi->IQueryInfo_iface.lpVtbl =&IQueryInfo_vtbl; > + qi->ref=1; > + qi->pidl=ILClone(pidl); > + > + TRACE("==> %p (pidl: %p)\n", qi, qi->pidl); > + return&qi->IQueryInfo_iface; > +} This doesn't handle HeaoAlloc() or ILClone failures.

1 0

Installing 64 bit visual c++ 2010 runtime?
by Dan Kegel May 17, 2012

May 17, 2012

I'd like to try a real 64 bit app, so on a 64 bit Ubuntu 12.04, I tried sudo apt-get install wine rm -rf ~/.wine export WINEARCH=win64 wget http://download.microsoft.com/download/3/2/2/3224B87F-CFA0-4E70-BDA3-3DE650… wine vcredist_x64 and that installs fine... but only puts anything in c:\windows\syswow64, and the 64 bit app I'm trying is rather upset that it can't find mfc100.dll. The log it writes into c:\users\$LOGNAME\*.html says (if you look at the source, or click 'verbose' in a web browser) "platform not supported". This happens even if I use winecfg to set win7 mode. Happily, it looks like one can just grab the file from the .cab with something like this: mkdir foo cd foo cabextract ../vcredist_x64.exe cabextract vc_red.cab cp F_CENTRAL_mfc100_x86 ~/.wine/windows/system32 cd .. rm -rf foo That gets the app I'm trying to the point where it needs a newer builtin vcrun100, http://source.winehq.org/git/wine.git/?a=commit;h=6cb3713e26aa4d89d4dc67601… which is great. (Now I just have to get around to following up on previous posts about how to build biarch wine on ubuntu 12.04.) But I still wonder why the installer doesn't want to install the 64 bit files.

1 1

Re: comctl32: When created with TCS_VERTICAL, TCS_MULTILINE is set automatically
by Stefan Leichter May 17, 2012

May 17, 2012

Thursday 17 May 2012 Nikolay Sivov <nsivov(a)codeweavers.com> > - DWORD dwStyle; > + DWORD style; Any reason for changing the name?

2 1

Re: kernel32: check the last parameter of K32EnumProcessModules for NULL before use (with test)
by Nikolay Sivov May 17, 2012

May 17, 2012

On 5/17/2012 11:46, Stefan Leichter wrote: > SetLastError(0xdeadbeef); > + pEnumProcessModules(hpQI,&hMod, sizeof(HMODULE), NULL); > + ok(GetLastError() == ERROR_ACCESS_DENIED, "expected error=ERROR_ACCESS_DENIED but got %d\n", GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = pEnumProcessModules(hpQV,&hMod, sizeof(HMODULE), NULL); > + ok(!ret, "succeeded\n"); > + ok(GetLastError() == ERROR_NOACCESS, "expected error=ERROR_NOACCESS but got %d\n", GetLastError()); > + Why don't you check return value from the first call?

2 1

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold
by K.King May 17, 2012

May 17, 2012

<< A "runs well with patched wine" checkbox might be useful, but would be very confusing. Maybe if it forced the rating to be garbage that would be ok. >> If it was possible my preference would be to be able to see separate rating per vanilla and per non vanilla. The per vanilla should be first and more obvious. If I see a rating of Garbage infers even with patching it would not run? problem with "runs well with patched wine" is it's an on or off, whereas you could start wishing for an indication of how well it can be made to run? Keeping the steps, results, capabilities, not tested, etc for patched wine could/should maybe be kept quite separate to the quick and obvious vanilla out of box results section? K.

1 0

kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions
by Alex Henrie May 16, 2012

May 16, 2012

Hello, This patch was marked committed yesterday--thank you for accepting it!--but it still isn't showing up in Git. Maybe it was accidentally skipped? It needs to be committed before I can submit the UTF-7 implementation I wrote that builds on it. -Alex

2 1

AppDB, ratings and native vs. builtin trouble
by Alexey Loukianov May 16, 2012

May 16, 2012

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Good day to all subscribers of this list, I've got a small decision trouble I have to deal with as an AppDB maintainer. I know that years ago there had been discussion on this topic, but I want to bring this once on a surface once again so we would get a fresh modern look an thus minor problem. As we all know, Wine isn't perfect, thus applications often require native DLLs to behave properly. AppDb treats such cases as being "Gold" rating. It's easy to distinguish between "Platinum" and "Gold" case most of the time, but sometimes there are cases where native dll overrides happen automagically as a result of app installed installing third-party lib redists himself. Good example is idSoftware's Rage game which require XAudio2 to functions - which is not implemented in Wine. User would have to install and use native lib for game to function, but most of the times it would be done automatically by Steam (its "auto-install required libs" feature would try to install DirectX redist at the first time user would try to launch the game). How should we treat situations like that? From user PoV it's "Platinum" - app is working out of the box. From real side of things - it is "Gold", as native dll override is required for app to function - Wine's stubbed xaudio2 implementation is obviously not enough for game to work. With the recent release of Diablo III we're are at the same spot: game installer auto-installs vcrun2008 redist as a part of installation process, so end-user experience is like this game "works out of a box". Problem is that D3 installed isn't working unless user patches Wine's AcceptEx implementation with Erichs patchset, so for vast majority of Wine's userbase installing D3 would be something like "copy already installed D3 from other PC" - and that would bring the problem of the game requiring native VC++ 2008 runtime on the surface. How should we treat/assign ratings for these cases? P.S. Aside from that, I want to once again bring up the discussion on extending AppDB so more detailed test reports would be possible. IMO it might be reasonable to add to AppDB test report form is an ability to specify whether the version used was "vanilla" or "patched with some out-of-tree patches" one. For most reporters sane default would be "vanilla", while at some circumstances most of the test reports would come for "patched" version: good examples are SW:KOTR, WoT, D3 and many other games that require out-of-tree patches to function best under Wine. Thanks for spending your time reading this, and thanks in advance for your answers. - -- Best regards, Alexey Loukianov mailto:mooroon2(a)mail.ru System Engineer, Mob.:+7(926)218-1320 *nix Specialist -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPs34GAAoJEPB9BOdTkBUL5KMH+gOtjQv1ckZ4tZ9X+kysZ/+0 gM1uCSHvuUdHuY+aVlUs688NU76mJcUu+ORPSuMrdltm7BCn5DbAN3ITjMSf2Y7y KHvvDFbGcKkiDupCyQhdNHpEyfC3PFzWjuI7o8nG/2eZGum5zRwGdbgvDvSc2Qo1 md208/6WDAGNjN2943orolG5pqhKapDvjvpoKSavgW1ykHeKDiTvCiNKXvcRU2ox bRZomHY93DNV0RoLnExcp8HnA/DooWQdGfwF4uTp+wgmIbwbWM4iw3Zw5CuXim+6 VzetXUPU9iVr2h3xqBgmVq5a7rMri7mykDXACo7ex30ekWM9XQBqSgT0jxqIi14= =16iP -----END PGP SIGNATURE-----

3 6

Re: [1/2] wmvcore: Add stub for WMCreateSyncReader (try 2) (resend)
by Nikolay Sivov May 16, 2012

May 16, 2012

On 5/16/2012 19:46, André Hentschel wrote: > + wmsdkidl.idl \ > + wmsbuffer.idl \ This is supposed to be sorted. Also I think you need to add .gitignore changes as well.

1 0

RE: localspl: Only store the file part of the filenames in the registry
by Detlef Riekenberg May 16, 2012

May 16, 2012

Hi Huw. We have only filenames in the registry. The current code works fine with the adobe postscript driver and various other driver for PDF printers. Which native driver makes problems? Why do you add spaces before and after the the function args and change idention, bracket style and variable names everywhere in the patch? HP is using a subdirectory for some driver files, but i can't remember the driver name at the moment. -- By by ... Detlef

2 1

re: AppDB, ratings and native vs. builtin trouble
by Dan Kegel May 16, 2012

May 16, 2012

16.05.2012 17:34, Rosanne DiMesio wrote: > If the user didn't have to manually do anything, it should be rated > platinum. Agreed. appdb ratings are from the point of view of someone who simply uses their linux distro to install wine, and then tries to install a game. If no fiddling is required, and the game works perfectly, it's platinum even if under the hood the game has snuck in a native (and Microsoft-copyrighted) DLL. (DLLs not copyrighted by Microsoft are not generally a concern.) In parallel, people who care about making Wine run without any native DLLs should make sure there's a "purist" bug in wine's bugzilla describing what breaks if you force wine to use its own builtin DLL for the game. (And should then try to fix that bug. :-) - Dan

2 1

Re: [2/2] gdiplus: Implement GdipImageGetFrameCount and GdipImageSelectActiveFrame.
by Vincent Povirk May 16, 2012

May 16, 2012

Er, you removed the FIXME, but GdipImageSelectActiveFrame is still a stub? You're not changing the image data.

2 1

Re: [PATCH 2/2] ieframe: Added GetExternal tests
by Marvin May 16, 2012

May 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18421 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3402: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3377: Test failed: Could not get WebBrowserV1 instance: 80040154 webbrowser: unhandled exception c0000005 at 0040AE8E === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2594: Test failed: expected GetOverridesKeyPath webbrowser.c:2599: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2600: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3019: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402FCA

1 0

Re: mstask: Actually run a test and fix the expected behaviour.
by Marvin May 16, 2012

May 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18419 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task

2 1

Re: [1/2] comctl32/tests: Added tests for treeview right mouse click handling
by Nikolay Sivov May 16, 2012

May 16, 2012

On 5/15/2012 22:53, Daniel Jelinski wrote: > > > + PostMessageA(hTree, WM_RBUTTONUP, 0, (LPARAM)0x10001); > + /* this sequence should NOT send WM_CONTEXTMENU */ > + SendMessageA(hTree, WM_RBUTTONDOWN, 2, (LPARAM)0x10001); Please use defined names for wParam and a MAKELPARAM macro to make a coordinate dword. > + test_mouse(); Also this deserves a more descriptive name, something like test_rbutton().

1 0

Re: mstask: Actually run a test and fix the expected behaviour.
by Marvin May 16, 2012

May 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18419 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task

1 0

Re: mstask/tests: Add missing call to the tested function.
by Marvin May 16, 2012

May 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18417 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task === W2KPROSP4 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === WXPPROSP3 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W2K3R2SESP2 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === WVISTAADM (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W2K8SE (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PRO (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PROX64 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === TEST64_W7SP1 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PROX64 (64 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === TEST64_W7SP1 (64 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000

1 0

Re: [PATCH] devenum: Do not fail with a IBindCtx (with tests)
by Dmitry Timoshkov May 16, 2012

May 16, 2012

Detlef Riekenberg <wine.dev(a)web.de> wrote: > static HRESULT WINAPI DEVENUM_IMediaCatMoniker_BindToStorage(IMoniker *iface, IBindCtx *pbc, > IMoniker *pmkToLeft, REFIID riid, void **ppvObj) > { > + static IBindCtx *old_bc; > MediaCatMoniker *This = impl_from_IMoniker(iface); > > TRACE("(%p)->(%p, %p, %s, %p)\n", This, pbc, pmkToLeft, debugstr_guid(riid), ppvObj); > > *ppvObj = NULL; > > - if (pbc || pmkToLeft) > + if (pbc != old_bc) > + { > + FIXME("ignoring IBindCtx %p\n", pbc); > + old_bc = pbc; > + } This doesn't look sane. -- Dmitry.

1 0

wine/clang warnings
by Austin English May 15, 2012

May 15, 2012

Howdy, I tried Wine with LLVM/Clang from svn recently, thought others may like some of the results. I've also ran the static analyzer. For reference, this is with: wine-1.5.4-61-g8327e6f, plus the following patch: diff --git a/include/windef.h b/include/windef.h index 9cf98e7..e95388a 100644 --- a/include/windef.h +++ b/include/windef.h @@ -53,7 +53,7 @@ extern "C" { #ifndef __stdcall # ifdef __i386__ # ifdef __GNUC__ -# ifdef __APPLE__ /* Mac OS X uses a 16-byte aligned stack and not a 4-byte one */ +# if defined (__APPLE__) || defined (__clang__) /* Mac OS X uses a 16-byte aligned stack and not a 4-byte one */ # define __stdcall __attribute__((__stdcall__)) __attribute__((__force_align_arg_pointer__)) # else # define __stdcall __attribute__((__stdcall__)) see http://wiki.winehq.org/Clang for more info. Wine was compiled using: #!/bin/bash export CC="clang" export CXX="$CC" export CFLAGS="-g -O0 -std=gnu89 -Wno-conversion -Wno-invalid-source-encoding" ./configure -Wno-invalid-source-encoding, because clang does not like our encoding of strings in winex11/keyboard.c. There are 851 warnings of: clang -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/usr/include/freetype2 -g -O0 -std=gnu89 -Wno-conversion -o keyboard.o keyboard.c keyboard.c:267:17: warning: illegal character encoding in string literal [-Winvalid-source-encoding] "`","1!","2\"","3<A3>","4$","5%","6^","7&","8*","9(","0)","-_","=+", The static analyzer found 2231 bugs (--disable-tests was used). http://www.sendspace.com/file/qsbv3k austin(a)aw21 ~ $ du -h scan-build-2012-05-15-2.tar.bz2 42M scan-build-2012-05-15-2.tar.bz2 austin(a)aw21 ~ $ sha1sum scan-build-2012-05-15-2.tar.bz2 442cf6faddb45515792d116717c992282496dfbe scan-build-2012-05-15-2.tar.bz2 Cheers, Austin

1 0

Re: comctl32: Fix message sequence when right-clicking a treeview
by Nikolay Sivov May 15, 2012

May 15, 2012

On 5/15/2012 21:30, Daniel Jelinski wrote: > Patch dropped out of the pending list, resending. Please add a test for this fix.

2 2

Re: [PATCH 1/3] user32: Added GetMenuBarInfo implementation (try2)
by Alexandre Julliard May 15, 2012

May 15, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > This patch serie is based on Andrew Eikum's and Rein Klazes's work. > --- > dlls/user32/menu.c | 94 > ++++++++++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 87 insertions(+), 7 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:11511: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' msg.c:12297: Test failed: popup menu command: 17: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12297: Test failed: popup menu command: 18: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12297: Test failed: popup menu command: 19: the msg 0x0126 was expected, but got msg 0x0212 instead msg.c:12297: Test failed: popup menu command: 21: the msg 0x0101 was expected, but got msg 0x0126 instead msg.c:12297: Test failed: popup menu command: 22: the msg sequence is not complete: expected 0000 - actual 0101 msg.c:12315: Test failed: submenu of a popup menu command: 22: the msg 0x0004 was expected, but got msg 0x0125 instead msg.c:12315: Test failed: submenu of a popup menu command: 23: the msg 0x0125 was expected, but got msg 0x0004 instead msg.c:12315: Test failed: submenu of a popup menu command: 26: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12315: Test failed: submenu of a popup menu command: 27: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12315: Test failed: submenu of a popup menu command: 28: the msg 0x0126 was expected, but got msg 0x0212 instead msg.c:12315: Test failed: submenu of a popup menu command: 30: the msg 0x0101 was expected, but got msg 0x0126 instead msg.c:12315: Test failed: submenu of a popup menu command: 31: the msg sequence is not complete: expected 0000 - actual 0101 msg.c:12363: Test failed: submenu of a popup menu command: 22: the msg 0x0004 was expected, but got msg 0x0125 instead msg.c:12363: Test failed: submenu of a popup menu command: 23: the msg 0x0125 was expected, but got msg 0x0004 instead msg.c:12363: Test failed: submenu of a popup menu command: 26: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12363: Test failed: submenu of a popup menu command: 27: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12363: Test failed: submenu of a popup menu command: 28: the msg 0x0111 was expected, but got msg 0x0212 instead msg.c:12363: Test failed: submenu of a popup menu command: 30: the msg 0x0101 was expected, but got msg 0x0111 instead msg.c:12363: Test failed: submenu of a popup menu command: 31: the msg sequence is not complete: expected 0000 - actual 0101 make[1]: *** [msg.ok] Error 19 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw: Forward AddAttachedSurface to the correct equivalent
by Stefan Dösinger May 15, 2012

May 15, 2012

Am Sonntag, 13. Mai 2012, 20:39:27 schrieb David Adam: > + hr = ddraw_surface3_AddAttachedSurface(&This- >IDirectDrawSurface3_iface, > + attachment_impl ? &attachment_impl->IDirectDrawSurface3_iface : NULL); It isn't immediately clear to me why Surface3 is correct instead of Surface7. Do you have tests or bug reports to back this up?

3 3

Re: [PATCH 1/4] dsound: Remove minlen, since we always mix full chunks anyway
by Alexander E. Patrakov May 15, 2012

May 15, 2012

Andrew Eikum wrote: > - > - TRACE("Mixed at least %d from all buffers\n", minlen); > - return minlen; Hi. You have removed the message that could say "Mixed at least 0 from all buffers" (as seen, e.g., for Armored Fist 3 and sometimes even for foobar2000). What was the reason for that "0" (or, rather, 1024, 1024, 1024, 0, 2048, 1024, ... sequence) seen in some games? Was it also fixed by your patch? (this mail is a question, not an objection) -- Alexander E. Patrakov

2 1

Re: [PATCH 1/4] dsound: Change mix_buffer to float instead of INT
by Alexander E. Patrakov May 15, 2012

May 15, 2012

Andrew Eikum wrote: > +static LONG f_to_24(float value) > +{ > if(value <= -1.f) > + return 0x80000000; > + if(value >= 1.f * 0x7FFFFF / 0x800000) > + return 0x7FFFFF00; > + return lrintf(value * 0x80000000U); > } ... > +static inline LONG f_to_32(float value) > +{ > + if(value <= -1.f) > + return 0x80000000; > + if(value >= 1.f * 0x7FFFFFFF / 0x80000000U) /* this rounds to 1.f */ > + return 0x7FFFFFFF; > + return le32(lrintf(value * 0x80000000U)); > +} [sorry for a possible duplicate, the previous mail contained a typo] Minor nitpick: I'd say these functions are identical on little-endian systems if the least significant bits are discarded. Are you sure that we indeed want two functions here, and not, say, use f_to_32() in put24()? -- Alexander E. Patrakov

1 0

Wine Mono 0.0.4 Release - I'm serious now!
by Vincent Povirk May 14, 2012

May 14, 2012

I have published version 0.0.4 of Wine Mono on Sourceforge. I fully intend to make this release a part of Wine. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.4/wine-mono-0.0.… The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.4/wine-mono-0.0.… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.2: * With Wine 1.5.4 and Wine Mono 0.0.4, it's now possible to run mixed-mode assemblies. * The random hang that was introduced in Mono 2.11 is now fixed (0.0.2 contained a hacky work-around). * A replacement for XNA 4.0 based on MonoGame is now included, to be used if MS XNA 4.0 is not installed. * Updated Mono from 2.11.0 to 2.11.1, bringing in the changes listed here: http://mono.1490590.n4.nabble.com/Mono-2-11-1-is-out-td4575466.html * Changes from Hans Leidekker to make upgrading and removing the msi work better. * Added more registry keys to prevent native .NET from trying to install while Wine Mono is installed. * Various improvements to the build script. Some programs that worked with the official Mono for Windows package will fail with this one because gluezilla (Mono's web browser component) is missing. In all other respects I expect this to work as well as or better than the official Mono for Windows package, and if not I'd like to hear about it. If nothing new seems to be horribly wrong with this build other than the lack of gluezilla, I will try to make it an official part of Wine. It's not really clear where the bugs should be reported at the moment, but I think Wine bugzilla is appropriate.

1 0

XINPUT JOYSTICK PATCH
by Giovanni Ongaro May 14, 2012

May 14, 2012

I have written a modification of the xinput1_3 dll that simulates xbox joystick with a logitech rumblepad 2 joystick,also provided is a way to disable dinput joysticks through an environment variable, it seems to work well,may it be of interest to the wine project?

2 1

Re: wmvcore: Add stub for WMCreateSyncReader
by Nikolay Sivov May 14, 2012

May 14, 2012

On 5/14/2012 19:34, André Hentschel wrote: > Otherwise GTA San Andreas runs into it and crashes. This stub let's it work again. > a workaround is to disable wmvcore in winecfg... > --- > dlls/wmvcore/wmvcore.spec | 2 +- > dlls/wmvcore/wmvcore_main.c | 8 ++++++++ > 2 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/dlls/wmvcore/wmvcore.spec b/dlls/wmvcore/wmvcore.spec > index 1c6cb1f..e0fa2e9 100644 > --- a/dlls/wmvcore/wmvcore.spec > +++ b/dlls/wmvcore/wmvcore.spec > @@ -11,7 +11,7 @@ > @ stub WMCreateProfileManager > @ stub WMCreateReader > @ stub WMCreateReaderPriv > -@ stub WMCreateSyncReader > +@ stdcall WMCreateSyncReader(ptr long ptr) > @ stub WMCreateWriter > @ stub WMCreateWriterFileSink > @ stub WMCreateWriterNetworkSink > diff --git a/dlls/wmvcore/wmvcore_main.c b/dlls/wmvcore/wmvcore_main.c > index 096328b..5fce972 100644 > --- a/dlls/wmvcore/wmvcore_main.c > +++ b/dlls/wmvcore/wmvcore_main.c > @@ -22,6 +22,7 @@ > > #include "windef.h" > #include "winbase.h" > +#include "objbase.h" > #include "wine/debug.h" > > WINE_DEFAULT_DEBUG_CHANNEL(wmvcore); > @@ -43,3 +44,10 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > > return TRUE; > } > + > +HRESULT WINAPI WMCreateSyncReader(IUnknown *pcert, DWORD rights, > + IUnknown /* FIXME: IWMSyncReader */ **syncreader) > +{ > + FIXME("(%p, %x, %p): stub\n", pcert, rights, syncreader); > + return E_NOTIMPL; > +} You'll be probably requested to add a proper .idl for that with interface definition. Also it makes sense to init out parameter to 0, as a common practice for such creation methods/calls. >

1 0

Re: [1/2] gdiplus: Measure the passed in string without height clipping in order to compute correct Y offset. Take 3.
by Vincent Povirk May 14, 2012

May 14, 2012

Looks good to me.

1 0

Re: Using an IDE on Wine?
by Michael Ost May 14, 2012

May 14, 2012

On 5/13/12 10:00 AM, wine-devel-request(a)winehq.org wrote: > How many of you use an Integrated Development Environment (IDE) when > working on Wine? > > If you do, which one do you use and how, how useful is it and how hard > was it to set up? I use Qt Creator for Linux for our winelib application. Our app is a hybrid winelib + Qt/X11 app, so we get the extra Qt "goodies" with Qt Creator. But it does work for other project types too. Getting the integrated gdb debugger to work was a trick. The main thing is to set WINELOADERNOEXEC=1 in the environment and run /usr/bin/wine as the debuggee. We also built and copied in a debug version of /usr/bin/wine to keep Qt Creator from complaining when a debug session got underway. The last "gotcha" was that we had to hack out alpha channel support for cursors when running under GDB. (IIRC) the DIB engine uses segfaults in normal operation which confuses GDB. I can send along that patch if you are interested. Of course, if you are trying to debug a straight windows application then all of this is irrelevant! But if you are doing winelib, then these tricks can help. -- Michael Ost

1 0

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset. Take 2.
by Vincent Povirk May 14, 2012

May 14, 2012

If the string wraps, and you don't give the width to GdipMeasureString, won't it return a too small height? On Mon, May 14, 2012 at 9:11 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > GdipMeasureString() clips the string extents to passed rectangle width and > height, but that leads to wrong offsety calculation if the string doesn't > fit into that rectangle. > --- > dlls/gdiplus/graphics.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 38335a8..1c9780d 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -5162,14 +5162,18 @@ GpStatus WINGDIPAPI GdipDrawString(GpGraphics *graphics, GDIPCONST WCHAR *string > /* Should be no need to explicitly test for StringAlignmentNear as > * that is default behavior if no alignment is passed. */ > if(format->vertalign != StringAlignmentNear){ > + static const RectF empty_rect = { 0.0, 0.0, 0.0, 0.0 }; > RectF bounds; > - GdipMeasureString(graphics, string, length, font, rect, format, &bounds, 0, 0); > + GdipMeasureString(graphics, string, length, font, &empty_rect, format, &bounds, 0, 0); > + > + TRACE("bounds %s\n", debugstr_rectf(&bounds)); > > if(format->vertalign == StringAlignmentCenter) > offsety = (rect->Height - bounds.Height) / 2; > else if(format->vertalign == StringAlignmentFar) > offsety = (rect->Height - bounds.Height); > } > + TRACE("vertical align %d, offsety %f\n", format->vertalign, offsety); > } > > save_state = SaveDC(hdc); > -- > 1.7.10.1 > > >

2 3

Re: [PATCH 1/5] d3dcompiler: Make SlWriteBytecode return the shader size.
by Stefan Dösinger May 14, 2012

May 14, 2012

Am Montag, 14. Mai 2012, 17:24:01 schrieb Matteo Bruni: > - CopyMemory(pos, messages, strlen(messages) + 1); > + memcpy(pos, messages, strlen(messages) + 1); > ... > - if (shader == NULL) > + if (!shader) This looks unrelated. The changes are OK, but should be in another patch.

1 0

Re: [1/3] user32/tests: Add GetUserObjectInformation tests
by Alexandre Julliard May 14, 2012

May 14, 2012

Owen Rudge <orudge(a)codeweavers.com> writes: > There appears to be a bug in the GetUserObjectInformationA function on > Windows that results in an incorrect buffer length being returned when > the buffer size provided by the caller is insufficient. The 'A' > function returns the Unicode length instead of the ANSI length. These > patches modify Wine's behaviour to provide that incorrect > behaviour. They also fix an issue whereby the wrong error code is set > when the buffer is too short. Using the number of Unicode chars multiplied by 2 is a reasonable upper bound on the A string size, and it's used in a number of places. This can't really be considered a Windows bug. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.
by Vincent Povirk May 14, 2012

May 14, 2012

> - GdipMeasureString(graphics, string, length, font, rect, format, &bounds, 0, 0); > + GdipMeasureString(graphics, string, length, font, &bounds, format, &bounds, 0, 0); You probably shouldn't use the same GpRect* for both parameters there.

2 3

Re: msxml3: avoid a dangling else (LLVM/Clang)
by Michael Stefaniuc May 14, 2012

May 14, 2012

Hello Austin, On 05/14/2012 08:01 AM, Austin English wrote: > diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c > index 6805c75..14fd01b 100644 > --- a/dlls/msxml3/domdoc.c > +++ b/dlls/msxml3/domdoc.c > @@ -2277,8 +2277,10 @@ static HRESULT WINAPI domdoc_loadXML( > > /* skip leading spaces if needed */ > if (This->properties->version == MSXML_DEFAULT || This->properties->version == MSXML26) > + { > while (*ptr) > if (isspaceW(*ptr)) ptr++; else break; I do not mind terse code but that kinda overdoes it. I would put the "else" on a separate line. > + } > > xmldoc = doparse(This, (char*)ptr, strlenW(ptr)*sizeof(WCHAR), XML_CHAR_ENCODING_UTF16LE); > if ( !xmldoc ) bye michael

2 2

Re: wininet: Fixed typo in tests and accompanying implementation
by Marvin May 14, 2012

May 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18349 Your paranoid android. === W7PROX64 (64 bit http) === http.c:2853: Test failed: HttpSendRequest failed: 12002

1 0

Re: wininet/tests: fix a compiler warning on LLVM/Clang
by Jacek Caban May 14, 2012

May 14, 2012

Hi Austin, On 05/14/12 08:19, Austin English wrote: > clang -c -I. -I. -I../../../include -I../../../include > -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT > -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement > -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits > -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith > -I/usr/include/freetype2 -g -O0 -std=gnu89 -o http.o http.c > http.c:212:52: warning: use of logical '||' with constant operand > [-Wconstant-logical-operand] > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_NUMBER, &code, &size, &index); > ^ ~~~~~~~~~~~~~~~~~~~~~~ > http.c:212:52: note: use '|' for a bitwise operation > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_NUMBER, &code, &size, &index); > ^~~~~~~~~~~~~~~~~~~~~~~~ > | > http.c:218:52: warning: use of logical '||' with constant operand > [-Wconstant-logical-operand] > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_REQUEST_HEADERS, &code, &size, > NULL); > ^ > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > http.c:218:52: note: use '|' for a bitwise operation > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_REQUEST_HEADERS, &code, &size, > NULL); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Thanks for the patch. The problem found by those warnings was more serious as we were tested a wrong thing, causing the implementation to be wrong. That said, we need to fix tests and implementation as well. I've sent a patch. Thanks, Jacek

1 0

Re: wininet/tests: fix a compiler warning on LLVM/Clang
by Marvin May 14, 2012

May 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18347 Your paranoid android. === WXPPROSP3 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W2K3R2SESP2 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === WVISTAADM (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W2K8SE (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PRO (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PROX64 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === TEST64_W7SP1 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PROX64 (64 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === TEST64_W7SP1 (64 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154)

1 0

Re: [2/2] msxml3: Support iso-8859-x encodings in writer
by Marvin May 14, 2012

May 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18346 Your paranoid android. === W2KPROSP4 (32 bit saxreader) === saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-3: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-4: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-5: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-7: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-9: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-13: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> === WXPPROSP3 (32 bit saxreader) === saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-3: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?>

1 0

Re: jscript/tests: Fix the spelling of the testEmbeddedFunctions() function name.
by Marvin May 13, 2012

May 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18345 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: jscript/tests: Fix the spelling of the testEmbeddedFunctions() function name.
by Marvin May 13, 2012

May 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18345 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Using an IDE on Wine?
by Max TenEyck Woodbury May 13, 2012

May 13, 2012

How many of you use an Integrated Development Environment (IDE) when working on Wine? If you do, which one do you use and how, how useful is it and how hard was it to set up? Max

4 3

re: Using an IDE on Wine?
by Dan Kegel May 13, 2012

May 13, 2012

I suspect most people don't use IDEs with wine. Someone recently posted how to use eclipse during debugging, though: http://www.winehq.org/pipermail/wine-devel/2012-April/095162.html

1 0

Re: d3dx9_36: Equality between floats is too strict.
by Marvin May 12, 2012

May 12, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18337 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W2K3R2SESP2 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === WVISTAADM (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W2K8SE (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W7PRO (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W7PROX64 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === TEST64_W7SP1 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W7PROX64 (64 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === TEST64_W7SP1 (64 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0

1 0

Re: [2/8] d3dx9: Check the size of a DDS file in D3DXGetImageInfoFromFileInMemory.
by Stefan Dösinger May 12, 2012

May 12, 2012

Am Mittwoch, 9. Mai 2012, 23:32:05 schrieb Józef Kucia: > + *pitch = width * format_desc->bytes_per_pixel; > + *size = *pitch * height; Usually surface pitches are either 4 or 8 byte aligned(depending on the API and pool). I recommend to write some tests for this. The most likely problematic formats are D3DFMT_P8, any 16 bit format like R5G6B5 and 24 bit R8G8B8. Maybe you're supposed to honor the pitch_or_linear_size member of the DDSURFACEDESC.

3 5

Re: [PATCH 1/3] user32: Added GetMenuBarInfo implementation
by Alexandre Julliard May 12, 2012

May 12, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > + __TRY > + { > + mbi.cbSize = pmbi->cbSize; > + if (mbi.cbSize == sizeof(MENUBARINFO)) > + memcpy(pmbi, &mbi, sizeof(MENUBARINFO)); > + } > + __EXCEPT_PAGE_FAULT > + { > + SetLastError(ERROR_NOACCESS); > + return FALSE; > + } > + __ENDTRY Do you really have an app that requires an exception handler? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/5] d3dx9: Forward D3DXSaveSurfaceToFileA to D3DXSaveSurfaceToFileW.
by Józef Kucia May 11, 2012

May 11, 2012

On Wed, May 2, 2012 at 2:55 PM, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > --- > dlls/d3dx9_36/surface.c | 24 ++++++++++++++++++++---- > 1 files changed, 20 insertions(+), 4 deletions(-) > > diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c > index 44d4e06..70627fd 100644 > --- a/dlls/d3dx9_36/surface.c > +++ b/dlls/d3dx9_36/surface.c > @@ -1364,11 +1364,27 @@ HRESULT WINAPI D3DXLoadSurfaceFromSurface(LPDIRECT3DSURFACE9 pDestSurface, > } > > > -HRESULT WINAPI D3DXSaveSurfaceToFileA(LPCSTR pDestFile, D3DXIMAGE_FILEFORMAT DestFormat, > - LPDIRECT3DSURFACE9 pSrcSurface, const PALETTEENTRY* pSrcPalette, const RECT* pSrcRect) > +HRESULT WINAPI D3DXSaveSurfaceToFileA(LPCSTR dst_filename, D3DXIMAGE_FILEFORMAT file_format, > + IDirect3DSurface9 *src_surface, const PALETTEENTRY *src_palette, const RECT *src_rect) > { > - FIXME("(%p, %d, %p, %p, %p): stub\n", pDestFile, DestFormat, pSrcSurface, pSrcPalette, pSrcRect); > - return D3DERR_INVALIDCALL; > + int len; > + LPWSTR filename; > + HRESULT hr; > + > + TRACE("(%s, %d, %p, %p, %p): relay\n", > + wine_dbgstr_a(dst_filename), file_format, src_surface, src_palette, src_rect); > + > + if (!dst_filename) return D3DERR_INVALIDCALL; > + > + len = MultiByteToWideChar(CP_ACP, 0, dst_filename, -1, NULL, 0); > + filename = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(WCHAR)); > + if (!filename) return E_OUTOFMEMORY; > + MultiByteToWideChar(CP_ACP, 0, dst_filename, -1, filename, len); > + > + hr = D3DXSaveSurfaceToFileW(filename, file_format, src_surface, src_palette, src_rect); > + > + HeapFree(GetProcessHeap(), 0, filename); > + return hr; > } > > HRESULT WINAPI D3DXSaveSurfaceToFileW(LPCWSTR pDestFile, D3DXIMAGE_FILEFORMAT DestFormat, > -- > 1.7.8.6 > This mail is the lost mail from 2nd May. Please ignore it.

1 0

Re: [PATCH 1/2 resend] mshtml.idl: Added DispHTMLHistory declaration
by Jacek Caban May 11, 2012

May 11, 2012

There must have been some problem with mail servers. These mails were sent last week and should replace already committed patches. The fix from try 2 (fixing tests on old IEs) is also already committed. Cheers, Jacek

1 0

Re: [1/8] d3dx9: Add missing pixel formats.
by Matteo Bruni May 11, 2012

May 11, 2012

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > diff --git a/dlls/d3dx9_36/util.c b/dlls/d3dx9_36/util.c > index 4dbf44c..ad8a6ea 100644 > --- a/dlls/d3dx9_36/util.c > +++ b/dlls/d3dx9_36/util.c > @@ -62,6 +62,7 @@ static const PixelFormatDesc formats[] = > {D3DFMT_G16R16, {0, 16, 16, 0}, { 0, 0, 16, 0}, 4, 1, 1, 4, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_A8, {8, 0, 0, 0}, { 0, 0, 0, 0}, 1, 1, 1, 1, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_A8L8, {8, 8, 0, 0}, { 8, 0, 0, 0}, 2, 1, 1, 2, FORMAT_ARGB, la_from_rgba, la_to_rgba}, > + {D3DFMT_A4L4, {4, 4, 0, 0}, { 4, 0, 0, 0}, 1, 1, 1, 1, FORMAT_ARGB, la_from_rgba, la_to_rgba}, > {D3DFMT_DXT1, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 8, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_DXT2, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 16, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_DXT3, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 16, FORMAT_ARGB, NULL, NULL }, I guess it would make sense to add all the new pixel formats to the table, assuming it doesn't break the tests or other stuff.

3 2

Re: [PATCH 3/4] dmusic: COM cleanup of IReferenceClock.
by Nikolay Sivov May 11, 2012

May 11, 2012

On 5/11/2012 09:19, Christian Costa wrote: > > diff --git a/dlls/dmusic/dmusic_private.h b/dlls/dmusic/dmusic_private.h > index 73a05d4..96334c9 100644 > --- a/dlls/dmusic/dmusic_private.h > +++ b/dlls/dmusic/dmusic_private.h > @@ -167,13 +167,14 @@ extern HRESULT WINAPI DMUSIC_CreateDMSynthPort(REFIID riid, LPVOID *ppobj, LPUNK > * IReferenceClockImpl implementation structure > */ > struct IReferenceClockImpl { > - /* IUnknown fields */ > - const IReferenceClockVtbl *lpVtbl; > - LONG ref; > + /* IUnknown fields */ > + IReferenceClock IReferenceClock_iface; > + const IReferenceClockVtbl *lpVtbl; You forgot to remove that, right? > + LONG ref; > > >

2 1

Re: Vincent Povirk : windowscodecs: Add wrapper functions for IWICPalette methods.
by Charles Davis May 11, 2012

May 11, 2012

On May 10, 2012, at 1:17 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 2fc7cdc93f6dc8ed67498b74193423c44e5bb770 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=2fc7cdc93f6dc8ed67498b741… > > Author: Vincent Povirk <vincent(a)codeweavers.com> > Date: Tue May 8 10:49:22 2012 -0500 > > windowscodecs: Add wrapper functions for IWICPalette methods. I have to say, these patches all seem really mechanical. Correct me if I'm wrong, but I think MIDL has an option to generate the proxy wrappers automatically. Even if it doesn't, I'm sure this would be a good feature to add to widl (if we don't already have it) so we don't have to laboriously write and maintain each and every one of the proxy wrappers. Chip

2 1

Re: [PATCH 2/2 try 2] mshtml: Added IHTMLWindow2::get_history implementation
by Marvin May 10, 2012

May 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18319 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

GSoC Joystick Configuration Tools
by Lucas Zawacki May 10, 2012

May 10, 2012

Hello all, I'll use this thread to post information and ask questions regarding my GSoC project. First there's a wiki which aggregates some information and lists tasks I'm working on: http://lfzawacki.heroku.com/wine/published/HomePage Then there's a github repo: https://github.com/lfzawacki/wine-joysticks In the repository you'll find the different tools I'll be implementing. They can be easily built and tested, even before they make it into wine. At the moment there's an intial version of the command line joystick tester. This tool is useful for listing connected joysticks, testing if they work correctly in wine, testing axis remapping, watching for dinput trace messages, etc... It's also the basis for the joystick testing GUI. I'll start cleaning up, splitting this code and commiting it to wine next week. For now I'll make a similar tool to this one that tests force feedback. I'll try to make it in the style of the Linux fftest program, but using the dinput interfaces so that a user can test the differences. Cheers, Lucas

2 2

Re: [5/8] d3dx9: Add DDS support in D3DXCreateTextureFromFile functions.
by Józef Kucia May 10, 2012

May 10, 2012

On Wed, May 9, 2012 at 11:32 PM, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c > index ab56593..3d5a50f 100644 > --- a/dlls/d3dx9_36/tests/surface.c > +++ b/dlls/d3dx9_36/tests/surface.c > @@ -917,6 +917,20 @@ static void test_D3DXCreateVolumeTexture(IDirect3DDevice9 *device) > } > } > > +static void test_D3DXCreateTextureFromFileInMemory(IDirect3DDevice9 *device) > +{ > + HRESULT hr; > + IDirect3DTexture9 *texture; > + > + hr = D3DXCreateTextureFromFileInMemory(device, dds_16bit, sizeof(dds_16bit), &texture); > + ok(hr == D3D_OK, "D3DCreateTextureFromFileInMemory returned %#x, expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) IDirect3DTexture9_Release(texture); > + > + hr = D3DXCreateTextureFromFileInMemory(device, dds_24bit, sizeof(dds_24bit), &texture); > + ok(hr == D3D_OK, "D3DXCreateTextureFromFileInMemory returned %#x, expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) IDirect3DTexture9_Release(texture); > +} > + I noticed that I put more and more texture functions tests in tests/surface.c, because these tests needs the dds files which are in tests/surface.c. I wonder if it would be better to copy needed dds files to tests/texture.c and move texture function tests to their proper place. I think the dds files could be used to tests other texture functions, e.g. D3DXCreateTextureFromFileInMemoryEx doesn't seem to have any tests.

2 1

Re: [1/5] gdiplus: Retrive LOGFONT from a GpFont using GdipGetLogFontW instead of accessing it directly.
by Alexandre Julliard May 10, 2012

May 10, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -4926,12 +4925,15 @@ GpStatus WINGDIPAPI GdipMeasureCharacterRanges(GpGraphics* graphics, > TRACE("(%p %s %d %p %s %p %d %p)\n", graphics, debugstr_w(string), > length, font, debugstr_rectf(layoutRect), stringFormat, regionCount, regions); > > - if (!(graphics && string && font && layoutRect && stringFormat && regions)) > + if (!graphics || !string || !font || !layoutRect || !stringFormat || !regions) > return InvalidParameter; Please avoid mixing that sort of gratuitous change with the real changes. > + stat = GdipGetLogFontW((GpFont *)font, graphics, &lfw); > + if (stat != Ok) return stat; I'm not sure it's an improvement, since you need to add these ugly casts. You should find a way that doesn't require that. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions (try 4)
by Juan Lang May 10, 2012

May 10, 2012

Hi Alex, first, thanks for taking the time to respond to feedback. Showing responsiveness helps a great deal. Next, on your patch: I'm trying to help you get this committed, so this is meant to be constructive feedback. +static void test_WideCharToMultiByte_error(UINT page, DWORD flags, LPCWSTR src, + INT srclen, LPSTR dst, INT dstlen, + LPCSTR defchar, BOOL* used, + const char* test_description, + DWORD expected_error) +{ + SetLastError(ERROR_SUCCESS); + WideCharToMultiByte(page, flags, src, srclen, dst, dstlen, defchar, used); + ok(GetLastError() == expected_error, + "codepage %i, %s, expected error %i got error %i\n", page, + test_description, expected_error, GetLastError()); +} + +static void test_MultiByteToWideChar_error(UINT page, DWORD flags, LPCSTR src, + INT srclen, LPWSTR dst, INT dstlen, + const char* test_description, + DWORD expected_error) +{ + SetLastError(ERROR_SUCCESS); + MultiByteToWideChar(page, flags, src, srclen, dst, dstlen); + ok(GetLastError() == expected_error, + "codepage %i, %s, expected error %i got error %i\n", page, + test_description, expected_error, GetLastError()); +} These helpers don't really gain you anything here, there's really not enough code to be worth using helpers. Please just copy/paste the changes everyplace you're currently using them. Also, a common convention we use is to set last error to 0xdeadbeef prior to a test we expect to set last error on failure. Thanks, --Juan

2 1

Re: [PATCH] winmm: Don't call MMDevAPI during process exit
by Alexandre Julliard May 10, 2012

May 10, 2012

Andrew Eikum <aeikum(a)codeweavers.com> writes: > --- > This fixes bug 30631, introduced by > 31291cdc6ccc4c172ccf86f383c6a90f31a50ba1. > > In addition to safely exiting on process exit, we do much more > thorough cleanup on process detach. There shouldn't be any reason to do cleanup on process exit (and you can't really do anything reliably at that point anyway). -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [5/8] d3dx9: Add DDS support in D3DXCreateTextureFromFile functions.
by Matteo Bruni May 10, 2012

May 10, 2012

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > --- > +HRESULT load_texture_from_dds(IDirect3DTexture9 *texture, const void *src_data, UINT srd_data_size, > + const PALETTEENTRY *palette, DWORD filter, D3DCOLOR color_key, const D3DXIMAGE_INFO *src_info) DECLSPEC_HIDDEN; ... > +HRESULT load_texture_from_dds(IDirect3DTexture9 *texture, const void *src_data, UINT srd_data_size, > + const PALETTEENTRY *palette, DWORD filter, D3DCOLOR color_key, const D3DXIMAGE_INFO *src_info) I guess that was meant to be called "src_data_size". More to the point, anyway, you're not using that value right now, you should probably add a check against it or remove the parameter altogether.

2 1

Re: [4/8] d3dx9: Implement D3DXCreateCubeTextureFromFileInMemoryEx.
by Matteo Bruni May 10, 2012

May 10, 2012

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > + mip_levels = min(src_info->MipLevels, IDirect3DCubeTexture9_GetLevelCount(cube_texture)); > + for (face = D3DCUBEMAP_FACE_POSITIVE_X; face <= D3DCUBEMAP_FACE_NEGATIVE_Z; face++) > + { > + size = src_info->Width; > + for (mip_level = 0; mip_level < mip_levels; mip_level++) > + { > + hr = calculate_dds_surface_size(src_info, size, size, &src_pitch, &mip_level_size); > + if (FAILED(hr)) return hr; > + > + SetRect(&src_rect, 0, 0, size, size); > + > + IDirect3DCubeTexture9_GetCubeMapSurface(cube_texture, face, mip_level, &surface); > + hr = D3DXLoadSurfaceFromMemory(surface, palette, NULL, pixels, src_info->Format, src_pitch, > + NULL, &src_rect, filter, color_key); > + IDirect3DSurface9_Release(surface); > + if (FAILED(hr)) return hr; > + > + pixels += mip_level_size; > + size = max(1, size / 2); > + } > + > + /* if texture has fewer mip levels than DDS file, skip excessive mip levels */ > + while (mip_level < src_info->MipLevels) > + { > + calculate_dds_surface_size(src_info, size, size, &src_pitch, &mip_level_size); > + pixels += mip_level_size; > + size = max(1, size / 2); > + mip_level++; > + } > + } Really a nitpick, you could merge the "while" into the "for" loop above. > + if ((caps.Caps2 & D3DCAPS2_DYNAMICTEXTURES) && (pool != D3DPOOL_DEFAULT) && (usage != D3DUSAGE_DYNAMIC)) > + { > + hr = D3DXCreateCubeTexture(device, size, mip_levels, usage, format, pool, &tex); > + buftex = NULL; > + } > + else > + { > + hr = D3DXCreateCubeTexture(device, size, mip_levels, usage, format, D3DPOOL_SYSTEMMEM, &buftex); > + tex = buftex; > + } The "if" condition doesn't look correct to me, since e.g. you don't need a temporary texture if pool == D3DPOOL_DEFAULT and usage == D3DUSAGE_DYNAMIC.

2 1

Re: [2/8] d3dx9: Check the size of a DDS file in D3DXGetImageInfoFromFileInMemory.
by Matteo Bruni May 10, 2012

May 10, 2012

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > +static HRESULT get_image_info_from_dds(const void *buffer, UINT length, D3DXIMAGE_INFO *info) > { > + UINT i; > + UINT faces = 0; ... > + /* calculate the expected length */ > + width = info->Width; > + height = info->Height; > + for (i = 0; i < info->MipLevels; i++) > + { > + UINT pitch, size = 0; > + calculate_dds_surface_size(info, width, height, &pitch, &size); > + expected_length += size; > + width = max(1, width / 2); > + height = max(1, width / 2); > + } > + > + if (length < expected_length) > + return D3DXERR_INVALIDDATA; It looks like you're not actually using the faces variable.

2 1

Re: [PATCH] dmusic: Variable spelling fix.
by Andrew Eikum May 10, 2012

May 10, 2012

On Thu, May 10, 2012 at 07:52:58AM +0200, Christian Costa wrote: > static HRESULT read_from_stream(IStream *stream, void *data, ULONG size) > { > - ULONG readed; > + ULONG read; > HRESULT hr; > > - hr = IStream_Read(stream, data, size, &readed); > + hr = IStream_Read(stream, data, size, &read); > if(FAILED(hr)){ I called it that to prevent shadowing read(3). It probably doesn't matter since we almost never use that call in Wine, but that was the rationale. Andrew

2 1

Re: [PATCH 1/2] comctl32: LVM_SETITEMTEXT is not supported on LVS_OWNERDATA
by Nikolay Sivov May 10, 2012

May 10, 2012

On 5/10/2012 12:01, Piotr Caban wrote: > > Thanks to this patch we no longer ask about the item text inside this > notification before returning error. > --- > dlls/comctl32/listview.c | 1 + > dlls/comctl32/tests/listview.c | 8 +++++++- > 2 files changed, 8 insertions(+), 1 deletions(-) > > case LVM_SETITEMTEXTA: > case LVM_SETITEMTEXTW: > + if (infoPtr->dwStyle& LVS_OWNERDATA) return FALSE; > return LISTVIEW_SetItemTextT(infoPtr, (INT)wParam, (LPLVITEMW)lParam, > uMsg == LVM_SETITEMTEXTW); Please place this inside LISTVIEW_SetItemTextT().

1 0

[PATCH 0/6] Extended file stat system call
by David Howells May 10, 2012

May 10, 2012

Implement a pair of new system calls to provide extended and further extensible stat functions. The second of the associated patches is the main patch that provides these new system calls: ssize_t ret = xstat(int dfd, const char *filename, unsigned atflag, unsigned mask, struct xstat *buffer); ssize_t ret = fxstat(int fd, unsigned atflag, unsigned mask, struct xstat *buffer); which are more fully documented in the first patch's description. These new stat functions provide a number of useful features, in summary: (1) More information: creation time, inode generation number, data version number, flags/attributes. A subset of these is available through a number of filesystems (such as CIFS, NFS, AFS, Ext4 and BTRFS). (2) Lightweight stat: Ask for just those details of interest, and allow a netfs (such as NFS) to approximate anything not of interest, possibly without going to the server. (3) Heavyweight stat: Force a netfs to go to the server, even if it thinks its cached attributes are up to date. (4) Allow the filesystem to indicate what it can/cannot provide: A filesystem can now say it doesn't support a standard stat feature if that isn't available. (5) Make the fields a consistent size on all arches, and make them large. (6) Can be extended by using more request flags and appending further data after the end of the standard return data. Note that no lstat() equivalent is required as that can be implemented through xstat() with atflag == 0. ======= PATCHES ======= Patch 1 defines the xstat() and fxstat() system calls. Patches 2-6 implement extended stat facilities for Ext4, AFS, NFS and CIFS, and make eCryptFS go to the lower filesystem for such details. ============== CONSIDERATIONS ============== Should fxstat() be implemented as xstat() with a NULL filename, using dfd as fd? Should the default for a network fs be to do an unconditional (heavyweight) stat with a flag to suppress going to the server to update the locally held attributes and flushing pending writebacks? Should things like the Windows Archive, Hidden and System bits be handled through IOC flags, perhaps expanded to 64-bits? Are these things useful to userspace other than Samba and userspace NFS servers? Is it useful to pass the volume ID out? Or is statfs() sufficient for this? Should I add a sixth argument to xstat(), mark it reserved and require that must be supplied as 0 to hedge against future use? Is there anything else I can usefully add at the moment? ========== TO BE DONE ========== Autofs, ntfs, btrfs, ... I should perhaps use u8/u32/u64 rather than uint8/32/64_t. Handle remote filesystems being offline and indicate this with XSTAT_INFO_OFFLINE. ======= TESTING ======= There's a test program attached to the description for the main patch. It can be run as follows: [root(a)andromeda tmp]# ./xstat -R /mnt/foo xstat(/mnt/foo) = 0 0000: 000081a40000ffef 0000000000000001 0000020000000000 0000100000080000 0020: 0000000000000000 0000000600000008 000000004f88499a 0000000136fd9208 0040: 000000004f88499a 0000000136fd9208 000000004f8849b9 0000000106daf187 0060: 000000004f8849b9 0000000106daf187 000000000000000c 000000000000000f 0080: 0000000000000008 00000000484ebbef 0000000000000025 5949ebd4711efd82 00a0: d3250b5c15d5e380 0000000000000000 0000000000000000 0000000000000000 00c0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 00e0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 results=ffef Size: 15 Blocks: 8 IO Block: 4096 regular file Device: 08:06 Inode: 12 Links: 1 Access: (0644/-rw-r--r--) Uid: 0 Gid: 0 Access: 2012-04-13 16:43:22.922587656+0100 Modify: 2012-04-13 16:43:53.115011975+0100 Change: 2012-04-13 16:43:53.115011975+0100 Create: 2012-04-13 16:43:22.922587656+0100 Inode version: 484ebbefh Data version: 25h Inode flags: 00080000 (-------- ----e--- -------- --------) Information: 00000200 (-------- -------- ------a- --------) Volume ID: 82fd1e71d4eb4959-80e3d5155c0b25d3 David --- David Howells (6): xstat: eCryptFS: Return extended attributes xstat: CIFS: Return extended attributes xstat: NFS: Return extended attributes xstat: AFS: Return extended attributes xstat: Ext4: Return extended attributes xstat: Add a pair of system calls to make extended file stats available arch/x86/syscalls/syscall_32.tbl | 2 arch/x86/syscalls/syscall_64.tbl | 2 fs/afs/inode.c | 29 ++- fs/afs/super.c | 7 + fs/cifs/cifsfs.h | 4 fs/cifs/cifsglob.h | 16 +- fs/cifs/dir.c | 2 fs/cifs/inode.c | 120 +++++++++++-- fs/ecryptfs/inode.c | 14 +- fs/ext4/ext4.h | 2 fs/ext4/file.c | 2 fs/ext4/inode.c | 32 +++ fs/ext4/namei.c | 2 fs/ext4/super.c | 1 fs/ext4/symlink.c | 2 fs/nfs/inode.c | 49 ++++- fs/nfs/super.c | 1 fs/stat.c | 350 +++++++++++++++++++++++++++++++++++--- include/linux/fcntl.h | 1 include/linux/fs.h | 4 include/linux/stat.h | 126 +++++++++++++- include/linux/syscalls.h | 7 + 22 files changed, 694 insertions(+), 81 deletions(-)

10 65

Re: [7/8] d3dx9/tests: Add tests for compressed pixel formats support in D3DXLoadSurface functions.
by Stefan Dösinger May 10, 2012

May 10, 2012

Am Mittwoch, 9. Mai 2012, 23:32:10 schrieb Józef Kucia: > +#define check_pixel_3bpp(lockrect, x, y, color) \ > +ok(((BYTE*)(lockrect).pBits)[3 * (x) + (y) * (lockrect).Pitch + 0] == > ... Inline functions are generally prefered over macros where possible. I think it is possible to pass a different line number to ok() to make the messages more useful when they are called from a helper function, but I don't know how off the top of my head. If you have to use a macro, please use capital letters.

2 1

Re: kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions
by Nikolay Sivov May 10, 2012

May 10, 2012

On 5/10/2012 00:52, Alex Henrie wrote: > This patch was a lot harder to figure out than I thought it was going to be. > > The MSDN documentation of most of these behaviors can be found at > http://msdn.microsoft.com/en-us/library/windows/desktop/dd319072(v=vs.85).a… Does any application depend on that? > > --- > dlls/kernel32/locale.c | 38 ++++++++++++++--- > dlls/kernel32/tests/locale.c | 94 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 126 insertions(+), 6 deletions(-) This is a wrong file to place tests into. > > diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c > index 3216ef9..9cbb124 100644 > --- a/dlls/kernel32/tests/locale.c > +++ b/dlls/kernel32/tests/locale.c > @@ -3137,6 +3137,99 @@ static void test_IdnToUnicode(void) > } > } > > +static void test_WideCharToMultiByte_error(UINT page, DWORD flags, LPCWSTR src, > + INT srclen, LPSTR dst, INT dstlen, > + LPCSTR defchar, BOOL* used, > + const char* test_description, > + DWORD expected_error) > +{ > + SetLastError(ERROR_SUCCESS); > + WideCharToMultiByte(page, flags, src, srclen, dst, dstlen, defchar, used); > + ok(GetLastError() == expected_error, > + "codepage %i, %s, expected error %i got error %i\n", page, > + test_description, expected_error, GetLastError()); > +} > + > +static void test_MultiByteToWideChar_error(UINT page, DWORD flags, LPCSTR src, > + INT srclen, LPWSTR dst, INT dstlen, > + const char* test_description, > + DWORD expected_error) > +{ > + SetLastError(ERROR_SUCCESS); > + MultiByteToWideChar(page, flags, src, srclen, dst, dstlen); > + ok(GetLastError() == expected_error, > + "codepage %i, %s, expected error %i got error %i\n", page, > + test_description, expected_error, GetLastError()); > +} > + Looks ugly enough, it's better to place some test data in table and loop through it, if you really want to test that.

2 3

Re: [PATCH 2/3] dmsynth: Add some clock tests.
by Marvin May 10, 2012

May 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18298 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

kernel32: Add UTF-7 support
by Alex Henrie May 9, 2012

May 9, 2012

Hi all, Could I get some feedback on http://source.winehq.org/patches/data/85898 ? It was marked "Rejected" a week ago without explanation. Most of the code was authored by Katayama Hirofumi, whose patches have been accepted into Wine before. He gave permission to use his code under the LGPL at http://bugs.winehq.org/show_bug.cgi?id=27388 What more needs to be done before this patch can be accepted? -Alex

3 4

Re: d3drm/tests: Port IDirect3DRMFrame tests to IDirect3DRMFrame3
by Alexandre Julliard May 9, 2012

May 9, 2012

André Hentschel <nerv(a)dawncrow.de> writes: > --- > dlls/d3drm/tests/d3drm.c | 323 +++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 320 insertions(+), 3 deletions(-) It doesn't seem necessary to duplicate the whole thing, try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] d3drm: Retreive mesh name at loading time. Implement GetName and SetName. (try 5) (resend)
by Alexandre Julliard May 9, 2012

May 9, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > Try 5: Use a growing buffer to store name. I don't think a growing buffer makes sense for this. > + if (name) > + { > + *size = min(*size, This->name_size); > + memcpy(name, This->name, *size); > + /* Make sure we have the terminating 0 in case of truncation */ > + name[*size] = 0; Buffer overflow. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Ubuntu 12.04 (version#2, drop previous mail)
by Eric Pouech May 9, 2012

May 9, 2012

> This is because you _cannot_ install the 32-bit -dev packages onto > 12.04. It's not just symlinks that are missing, many of the header > files are different between the arches. I'm not sure this is a generic rule, and if it were, then exclusion between i386 and x86_64 should be defined on most dev packages, and it's not the case also note, that in some cases, arch specific headers are moved to arch dependent directories (e.g. jpeg, glib...), which should also parallel install of multi-arch libs in any case, the job by ubuntu folks in 12.04 done is crappy, to say the least > Just do the chroot. You will save yourself so much grief and it will > actually work. if the ubuntu folks keep this state of mind, then they'll continue to sink the best solution is then to pick up another distro A+ -- -- Eric Pouech

3 4

Re: [2/5] gdi32: Set tmDigitizedAspectX/Y to 96 instead of 300 for consistency.
by Dmitry Timoshkov May 8, 2012

May 8, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -6677,8 +6677,8 @@ static BOOL get_outline_text_metrics(GdiFont *font) > TM.tmWeight = pOS2->usWeightClass; > } > TM.tmOverhang = 0; > - TM.tmDigitizedAspectX = 300; > - TM.tmDigitizedAspectY = 300; > + TM.tmDigitizedAspectX = 96; /* FIXME */ > + TM.tmDigitizedAspectY = 96; /* FIXME */ A couple of comments to the patch: 1. the values should be set to the resolution of the target device, and 96 looks more natural since most of the time the device is a display. 2. the change is for consystency with get_bitmap_text_metrics() which sets these values to 96. 3. even if this pacth is rejected, other patches in the sequence should not be affected by it. -- Dmitry.

1 0

running 16bit code
by David Laight May 8, 2012

May 8, 2012

Does wine support running of 16bit windows apps? If so does it rely on the underlying OS having support for 'virtual 8086 emulation'? I'm thinking of removing the VM86 support from NetBSD, and wine is about the only likley user. David -- David Laight: david(a)l8s.co.uk

5 5

Re: [PATCH 4/4] dmsynth: Add stubbed IKsControl interface to DirectMusicSynthSink object.
by Alexandre Julliard May 8, 2012

May 8, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/dmsynth/dmsynth_private.h | 1 + > dlls/dmsynth/synthsink.c | 67 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 68 insertions(+), 0 deletions(-) It fails here: ../../../tools/runtest -q -P wine -M dmsynth.dll -T ../../.. -p dmsynth_test.exe.so dmsynth.c && touch dmsynth.ok dmsynth.c:56: Test succeeded inside todo block: IDirectMusicSynthSink_QueryInterface returned: 0 make: *** [dmsynth.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] d3dcompiler: Partially implement D3DCompile function.
by Henri Verbeet May 8, 2012

May 8, 2012

I realize compile_shader() is mostly a copy of assemble_shader(), but nevertheless: On 8 May 2012 16:17, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +struct bwriter_shader *parse_hlsl_shader(const char *text, enum shader_type type, DWORD version, If this isn't called outside of compiler.c it should be static. > + LPD3DBLOB buffer; "ID3DBlob *" > + CopyMemory(pos, preproc_messages, strlen(preproc_messages) + 1); memcpy() should do fine. > + hr = SlWriteBytecode(shader, 9, &res); ... > + size = HeapSize(GetProcessHeap(), 0, res); > + hr = D3DCreateBlob(size, &buffer); That's not very pretty, SlWriteBytecode() should probably just return the size as well.

2 1

Re: mscoree: Implement vtable fixups.
by Alexandre Julliard May 8, 2012

May 8, 2012

Vincent Povirk <madewokherd(a)gmail.com> writes: > + if (fixup->fixup->type & COR_VTABLE_32BIT) > + { > + DWORD *vtable = fixup->vtable; > + DWORD *tokens = fixup->tokens; > + for (i=0; i<fixup->fixup->count; i++) > + { > + TRACE("%x\n", tokens[i]); > + vtable[i] = (DWORD)host->mono->mono_marshal_get_vtfixup_ftnptr( > + image, tokens[i], fixup->fixup->type); This will cause warnings on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: kernel32: Add UTF-7 support
by Alex Henrie May 8, 2012

May 8, 2012

2012/5/7 Ben Klein <shacklein(a)gmail.com>: > Without being a regular contributor, here are a few tips from a cursory glance: > 1) Whitespace change on at least one line The only change to whitespace I made was: - if( flags) + if (flags) I don't think this is a big deal. > 2) Why the change from ERROR_INVALID_PARAMETER to ERROR_INVALID_FLAGS? To match the behavior of Windows. I verified this with both MSDN and empirical tests. If the flags parameter is not null, all versions of Windows tested report ERROR_INVALID_FLAGS with the possible exception of Windows NT4. See http://testbot.winehq.org/JobDetails.pl?Key=18148 > 3) New function defs do not match format of surrounding defs in unicode.h This was a hard one. I didn't know if I should keep Katayama's use of INT or change the functions to use int like the UTF-8 functions do. So you're saying it should all be int? Do LPCSTR and LPCWSTR need to be changed to something else as well? > 4) No new tests to confirm the behaviour is correct (or mention of > current tests succeeding) dlls/kernel32/tests/locale.c already has just as many UTF-7 tests as it has UTF-8 tests. What tests do we need for UTF-7 which are not needed for UTF-8? Thanks for your quick response, -Alex

2 1

Re: msi: Tweak msiexec's usage message.
by Julian Rüger May 7, 2012

May 7, 2012

Hi Francois and wine-devel, while we're at it, shouldn't these >"Advertise a product:\n" >"\t/j[u|m] package [/t transform] [/g languageid]\n" >"Apply a patch:\n" >"\t/p patch_package [property]\n" >"\t/p patch_package /a package [property]\n" also be put in curly brackets? Like this: \t/j[u|m] {package} [/t transform] ... \t/p {patch_package} [property]\n ... Best, Julian

3 3

Re: [Programs] Notepad: sync with ReactOS notepad (2)
by carlo.bramix＠libero.it May 7, 2012

May 7, 2012

Hello friends, >> Because you do seriously believe that ReactOS developers reversed the >> Windows notepad?! Along with Solitaire & calculator, I suppose? >> Common sense is a powerful tool, let's make use of it :-). > >It's a matter of trust. If a person is known to use illegal practices >to write ReactOS code then even adding one line of code to notepad >makes her/his contribution dangerous for the entity accepting that code. > >> For the record, ReactOS as well disallows any person who has seen the >> Microsoft Windows code to comment, contribute, commit to the project. > >That's just a blanket statement, nothing more. It's hard to believe >to it if the person(s) publicly accused in using leaked code still >commit to ReactOS without any limitation. as I already wrote, I totally agree. Please reject the patches. Sincerely, Carlo Bramini.

1 0

Re: [Programs] Notepad: sync with ReactOS notepad (2)
by carlo.bramix＠libero.it May 7, 2012

May 7, 2012

Hello friends, >The issue is whether the appropriate guidelines were followed >(http://wiki.winehq.org/CleanRoomGuidelines) One issue is that Wine >does not allow people that have ever viewed Microsoft source code to >contribute to Wine, but there are other issues. You'll have to talk >to Alexandre and see how he feels about this specific issue, but if >you've followed all of the guidelines and contribute only your own >changes then he might be ok with your contribution. I see. Perhaps it would be better to reject all these patches since I'm not the only author of all the changes. I understand that this is done to protect yourself and the project, because you do not know the people who touched the sources of the notepad, who they are and how they collected their information, so I agree with you. Sincerely, Carlo Bramini.

3 2

Re: [Programs] Notepad: sync with ReactOS notepad (2)
by carlo.bramix＠libero.it May 6, 2012

May 6, 2012

Hello friends, >thank you for working on this. I think you will improve the chances for >your patches to be accepted if you give them individually meaningful >names, like > >"notepad: Don't use reserved MSVC keyword." > >for patch #2. Actually, I followed the tip I read into the wiki of WINE in "Patch submission guidelines", so I tried to imitate the style of other patches for WINE and for this reason I used an identical title with a progressive number as subject. If something different is prefered, no problem, I will follow your suggestion and I will use a more focused title. >Also, like Jerome said, we may have a problem if different people >commited these changes to ReactOS. I'm no expert on this, but as I >understand, Wine needs the patch to be credited to the author who >actually wrote the code. Well, ReactOS notepad had been imported from WINE long time ago and various people did some changes on it and I'm included in them since, in this specific case, the status bar implementation had been almost rewritten by me. I'm not an expert too, but since it is distribuited under the same license of WINE, with same coding restrictions and all people who sent patches have agreed to the same GPL as well, my intuition would say that there is no problem on this... because the owner who can providing this code to you is the ReactOS project itself. That's just my opinion of course... I will wait for your suggestions/orders... ;-) Sincerely, Carlo Bramini.

4 3

Re: [Programs] Notepad: sync with ReactOS notepad (2)
by Julian Rüger May 6, 2012

May 6, 2012

Hi Carlo, thank you for working on this. I think you will improve the chances for your patches to be accepted if you give them individually meaningful names, like "notepad: Don't use reserved MSVC keyword." for patch #2. Also, like Jerome said, we may have a problem if different people commited these changes to ReactOS. I'm no expert on this, but as I understand, Wine needs the patch to be credited to the author who actually wrote the code. (Can someone else please comment on this, if I am mistaken?) Best regards, Julian

1 0

Re: rpcrt4/tests: Fix build with PSDK headers.
by Marvin May 5, 2012

May 5, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18238 Your paranoid android. === WNT4WSSP6 (32 bit ndr_marshall) === ndr_marshall: unhandled exception c0000005 at 004081C6

1 0

Re: [Programs] Notepad: sync with ReactOS notepad
by Jerome Leclanche May 5, 2012

May 5, 2012

On Sat, May 5, 2012 at 2:15 PM, carlo.bramix(a)libero.it < carlo.bramix(a)libero.it> wrote: > Attached patch synces the WINE's notepad with the improvements added into > ReactOS' Notepad. > > - Imported status bar implementation, it fixes Bug #18715. New menu voice > has > been introduced into the resource file. > This is the biggest part of the patch, that it caused to touch all files > modified by the patch. > Other minor fixes included here are: > > - Implemented GOTO function. Since its menu voice has been added into the > resource file when adding support the statusbar, the related dialog box > and the > source code have been introduced too. > > - Find/Replace functions have an extremely similar behavior, so the job > can be > implemented with a single function. > > - Find and Find next commands must be grayed if there is not a text to > search > into. > > - The "class" word is a reserved keyword in MSVC, so I also imported the > fix > into the creation of the class of the window: "class" has been replaced > with > "wndclass", no code change. > > Sincerely, > > Carlo Bramini > > It's not going to be accepted as one big patch. It needs to be split. Also, are you the author of all the patches or are these other contributors for this? J. Leclanche

1 0

Re: kernel32: add more tracing to GetDiskFreeSpaceW
by Dmitry Timoshkov May 5, 2012

May 5, 2012

Austin English <austinenglish(a)gmail.com> wrote: > @@ -1687,6 +1689,8 @@ BOOL WINAPI GetDiskFreeSpaceW( LPCWSTR root, LPDWORD cluster_sectors, > if (sector_bytes) *sector_bytes = info.BytesPerSector; > if (free_clusters) *free_clusters = info.AvailableAllocationUnits.u.LowPart; > if (total_clusters) *total_clusters = info.TotalAllocationUnits.u.LowPart; > + TRACE("%u, %u, %u, %u, capped=%d\n", cluster_sectors ? *cluster_sectors : 0, sector_bytes ? *sector_bytes : 0, > + free_clusters ? *free_clusters : 0, total_clusters ? *total_clusters : 0, capped); Why not print in the values directly from info structure? That way all the data are in the trace regardless of what info appication requested. I'd guess that printing valus in hex would be more readable, and once the data is printed in hex it should be obvious when the values were capped, making 'capped' flag redundant. -- Dmitry.

1 0

Re: [2/5] msvcm80: Add stub dll.
by Charles Davis May 4, 2012

May 4, 2012

On May 4, 2012, at 10:07 AM, Vincent Povirk wrote: > > <0002-msvcm80-Add-stub-dll.txt> msvcmrt? The Managed C++ Runtime DLL? I imagine you won't get far on that without a C++/CLI compiler that understands the Microsoft Visual C++ ABI--unless you're willing to write all the marshaling glue code by hand. There's only one such compiler right now, and it only runs on Windows. VC++ ABI support is on my Clang to-do list--heck, it's my GSoC project--but C++/CLI is something I won't get to for a while. Given all that, how do you intend to implement this? Chip

2 2

Re: [2/5] msvcm80: Add stub dll.
by Stefan Dösinger May 4, 2012

May 4, 2012

3 2

Re: [5/5] msvcm80: Add __setusermatherr_m stub.
by Charles Davis May 4, 2012

May 4, 2012

On May 4, 2012, at 10:10 AM, Vincent Povirk wrote: > diff --git a/dlls/msvcm80/msvcm80_main.c b/dlls/msvcm80/msvcm80_main.c > index cd38f5b..eb09898 100644 > --- a/dlls/msvcm80/msvcm80_main.c > +++ b/dlls/msvcm80/msvcm80_main.c > @@ -50,3 +50,10 @@ void __cdecl CrtImplementationDetails_RegisterModuleUninitializer(void* handler) > FIXME("%p: stub\n", handler); > } > > +/* handler is a "method" with signature int32 (*handler)(_exception*), but I'm > + * not sure what that means */ I am. Actually, it's: int (__clrcall *handler)(struct _exception *) i.e. a "pointer to a function intended to be called from managed code that takes a pointer to a struct _exception and returns an int." The definition of struct _exception is in <math.h> under Visual Studio. To write such a function, you'd need a C++/CLI compiler. Chip

1 0

Wine Gecko 1.6-beta1
by Jacek Caban May 4, 2012

May 4, 2012

Hi all, I've uploaded a beta version of another Gecko update. Other than usual Gecko changes coming from Mozilla (for upcoming Firefox 13), it contains fixes for Wine bugs 30465 and 25243. To try it, as usually, the attached patch is required as well as the build that may be found on SourceForge [1], installed in usual way [2] (or your own build, it's easy those days! See wine-gecko-1.6 branch on [3]). All help with testing is appreciated! Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.6-beta1/ [2] http://wiki.winehq.org/Gecko [3] http://wine.git.sourceforge.net/git/gitweb.cgi?p=wine/wine-gecko;a=summary

1 0

Re: [PATCH 1/2] jscript: Skip failing tests on old jscript versions
by Marvin May 4, 2012

May 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18229 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: po: English (neutral / Great Britain) spelling fixes.
by Nicolas Le Cam May 3, 2012

May 3, 2012

Le 3 mai 2012 02:45, "Francois Gouget" <fgouget(a)free.fr> a écrit : > @@ -9429,9 +9429,9 @@ msgstr "" > "start [options] document_filename\n" > "\n" > "Options:\n" > -"/M[inimized] Start the program minimized.\n" > -"/MAX[imized] Start the program maximized.\n" > -"/R[estored] Start the program normally (neither minimized nor maximized).\n" > +"/M[inimized] Start the program minimised.\n" > +"/MAX[imized] Start the program maximised.\n" > +"/R[estored] Start the program normally (neither minimised nor maximised).\n" > "/W[ait] Wait for started program to finish, then exit with its exit " > "code.\n" > "/Unix Use a Unix filename and start the file like windows explorer.\n" Hi Francois, Shouldn't the end of words between brackets be translated too ? -- Nicolas Le Cam

3 3

Re: [3/5] d3dx9: Implement D3DXSaveSurfaceToFileW.
by Henri Verbeet May 3, 2012

May 3, 2012

On 2 May 2012 23:32, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > + if(wic_pixel_formats[i].d3dformat == format) Missing whitespace. > +HRESULT WINAPI D3DXSaveSurfaceToFileW(LPCWSTR dst_filename, D3DXIMAGE_FILEFORMAT file_format, "LPCWSTR" -> "const WCHAR *" > + TRACE("(%s, %d, %p, %p, %p)\n", > + wine_dbgstr_w(dst_filename), file_format, src_surface, src_palette, src_rect); wine_dbgstr_rect(). > + memcpy(&wic_pixel_format, pixel_format_guid, sizeof(GUID)); > + hr = IWICBitmapFrameEncode_SetPixelFormat(frame, &wic_pixel_format); > + d3d_pixel_format = wic_guid_to_d3dformat(&wic_pixel_format); What is all this for? Also, how do you intend to implement D3DXSaveSurfaceToFileInMemory()?

2 2

Re: [2/5] d3dx9: Forward D3DXSaveSurfaceToFileA to D3DXSaveSurfaceToFileW.
by Henri Verbeet May 3, 2012

May 3, 2012

On 2 May 2012 23:32, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > +HRESULT WINAPI D3DXSaveSurfaceToFileA(LPCSTR dst_filename, D3DXIMAGE_FILEFORMAT file_format, > + IDirect3DSurface9 *src_surface, const PALETTEENTRY *src_palette, const RECT *src_rect) If you're changing these anyway, LPCSTR is a broken way of saying "const char *". > + TRACE("(%s, %d, %p, %p, %p): relay\n", > + wine_dbgstr_a(dst_filename), file_format, src_surface, src_palette, src_rect); I generally prefer %#x for things like file_format, but don't care particularly strongly. For src_rect you should use %s and wine_dbgstr_rect(). I don't care much for the "relay" suffix, but I suppose half the existing code has it as well. > + len = MultiByteToWideChar(CP_ACP, 0, dst_filename, -1, NULL, 0); > + filename = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(WCHAR)); The HEAP_ZERO_MEMORY flag is useless, you're immediately going to overwrite all the memory afterwards. Sadly the existing d3dx9 code isn't a very good example here either.

1 0

Request for help/advice in investigation of one interesting "huge FPS regression" bug
by Alexey Loukianov May 3, 2012

May 3, 2012

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Good day to all. Henri, Stefan, I address this message to you at the first place as to a main developers of wined3d/opengl stuff. Nevertheless, hints and help are welcome from anyone, cause ATM I'm totally confused and don't know what else to try to investigate a case. What I've got here is an app (localized version of "Perfect World" MMORPG game client from "Mail.Ru Games Corp") that seems to suffer huge FPS regression which I believe to be a bug in nVIDIA drivers rather than a regression in Wine. Details are following. When I configure an app to run in a windowed mode I've got around 40 FPS on game login screen with nVIDIA drivers 275.09.07, but switching into using more recent versions causes FPS to drop to around ~10. Configuring the game to use fullscreen more fixes the issue - I've got ~30-40 FPS at game login screen no matter the driver version I use. I've been suspecting that this issue might be related to vsync control (and a recent change in nVIDIA linux drivers for vsync to be on by default) that causes the issue, so I had exported __GL_SYNC_TO_VBLANK="0" into the environment and used nvidia-settings to set vsync to be off by default. Using a small native opengl demo program I had specifically written to test for vsync state I can prove that vsync defaults to be off on my system. Also I had modified Wine's winex11.drv opengl.c in a way that a call to wglSwapIntervalEXT always sets swap_interval to be zero, no matter what was originally requested. Nevertheless, I still got this strange FPS drop when I run the game in a windowed more with a recent nVIDIA drivers. What could be a cause for it? What I want is to track down the problem to it's roots and check if it's really a bug in nVIDIA drivers. In the end I would like to implement a small opengl demo that would trigger the bug so nVIDIA wouldn't be able to reject my bug report on a matter that "it's a Wine bug, prove us that it's not". - -- Best regards, Alexey Loukianov mailto:mooroon2(a)mail.ru System Engineer, Mob.:+7(926)218-1320 *nix Specialist -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPij76AAoJEPB9BOdTkBULjz4H/1B/Nw6qOQUlEmDb64SmabvQ LQmzIHcnH38Ftz3KyWQxlYZ5EtLDYAIOQeP4pAHfzxKhGUJ1mCumv4ByaSs4YDhI juWJ/u/88vKwZYXJ9nZLQVqJY+dkr9MbxP3q0eGNaAFLNRDIqodzJJWB5EPucMrX Yid/zMjl5uGd9QDCO3Db4gwJKYpvHCbAfzADddqBwPoak9jXdlq53H9a2mImTbCB JR1MXQq6gFakOgtxXPxzFSU2Ge0n8RBGGN7UeZEubsLiktnmvTbKAJmmgWgPG80Y mlud7LrM4wLRPtpwTwS+M1n8TuVtUZzzCTagRyj3XSRL8Pqf2d5S3H+MpxBT1JQ= =TkMD -----END PGP SIGNATURE-----

5 8

Re: [PATCH 5/9] jscript: Better handling of to_integer result in String.lastIndexOf
by Marvin May 3, 2012

May 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18203 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/9] jscript: Bettter handling of to_number result in String.indexOf
by Marvin May 3, 2012

May 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18202 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/9] jscript: Better handling of to_integer result in String.charCodeAt
by Marvin May 3, 2012

May 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18201 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/9] jscript: Better handling of to_integer result in String.charAt
by Marvin May 3, 2012

May 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18200 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/9] jscript: Better handling of to_integer result in Array.splice
by Marvin May 3, 2012

May 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18199 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] d3drm: Implement IDirect3DRMFrameX_GetChildren method and IDirect3DRMFrameArray interface. (try 2) (resend)
by Marvin May 3, 2012

May 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18196 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Building 64 & 32 bit wine on Ubuntu 12.10?
by Dan Kegel May 3, 2012

May 3, 2012

What's the standard procedure for building both 32 and 64 bit wine together on Ubuntu 12.10? Sadly, it seems you can't install both 32 and 64 bit development files at the same time. And trying to use a 32 bit chroot is awkward because wine's build system tries to use the 64 bit makedep from inside the 32 bit chroot (which fails because the 64 bit shared libraries aren't present).

2 1

GSOC 2012 has started
by Austin English May 2, 2012

May 2, 2012

Howdy, Google Summer of Code 2012 has started, and we have 5 students this year: Józef Kucia - Implement missing functions in D3DX9, mentored by Stefan Dösinger - https://google-melange.appspot.com/gsoc/project/google/gsoc2012/jos/58002 Lucas Fialho Zawacki, mentored by Joystick configuration and testing applet Marcus Meissner - https://google-melange.appspot.com/gsoc/project/google/gsoc2012/lfzawacki/3… Magdalena Nowak - Control Panel, mentored by Owen Rudge - https://google-melange.appspot.com/gsoc/project/google/gsoc2012/magdalena/1… Marek K Chmiel - Encryption – digital signature security, mentored by Juan Lang - https://google-melange.appspot.com/gsoc/project/google/gsoc2012/mkchmiel/16… Qian Hong - GSoC project: Improve CJK font support, mentored by Aric Stewart - https://google-melange.appspot.com/gsoc/project/google/gsoc2012/fracting/11… Good luck everyone! -- -Austin

3 3

Re: [PATCH] include: Add definition of IKsControl interface in dmksctrl.h.
by Alexandre Julliard May 2, 2012

May 2, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > +typedef struct { > + union { > + struct { > + GUID Set; > + ULONG Id; > + ULONG Flags; > + }; > + LONGLONG Alignment; > + }; > +} KSIDENTIFIER, *PKSIDENTIFIER; Check how anonymous unions/structs are done in other headers. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] dmusic: Midi message takes 4 bytes space but only 3 are relevant + add tests to check buffer content.
by Alexandre Julliard May 2, 2012

May 2, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > +static inline char* debugstr_longlong(LONGLONG val) > +{ > + static char string[17]; > + sprintf(string, "%08x%08x", *((DWORD*)&val + 1), *(DWORD*)&val); > + return string; Check how this is done in other places. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests: Add tests for K32GetModuleFileNameEx (try 2)
by Alexandre Julliard May 2, 2012

May 2, 2012

Bruno Jesus <00cpxxx(a)gmail.com> writes: > try2: > Based on latest git > > Tests intended as complement for the buffer overflow fix from > > http://source.winehq.org/git/wine.git/commitdiff/fd11023e4b44b18af7f9d44b21… This should be merged with the existing psapi tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] d3dx9: Implement mapping from WICPixelFormat GUIDs to D3DFORMATs.
by Stefan Dösinger May 2, 2012

May 2, 2012

It looks like patch 2 is missing

2 1

Re: [1/5] d3dx9: Implement mapping from WICPixelFormat GUIDs to D3DFORMATs.
by Stefan Dösinger May 2, 2012

May 2, 2012

Am Mittwoch, 2. Mai 2012, 14:55:35 schrieb Józef Kucia: > +static const struct > +{ > + const GUID *wic_guid; > + D3DFORMAT d3dformat; > +} wic_pixel_formats[] = { Wouldn't it make sense to include this info in PixelFormatDesc?

2 1

Re: [PATCH 2/2] mshtml: Added IHTMLWindow2::get_history implementation
by Marvin May 2, 2012

May 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18178 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:4490: Test failed: unexpected guid {FECEAAA2-8405-11CF-8BA1-00AA00476DA6} === WVISTAADM (32 bit dom) === dom.c:4490: Test failed: unexpected guid {FECEAAA2-8405-11CF-8BA1-00AA00476DA6} === W2K8SE (32 bit dom) === dom.c:4490: Test failed: unexpected guid {FECEAAA2-8405-11CF-8BA1-00AA00476DA6}

1 0

Find Wine software installer
by Shanuka Wijekoon May 1, 2012

May 1, 2012

haiiii I have a problem that i need to track the software installation.that means I need to keep the location where the files are installed. Are there any place in wine source code to get help for my problem. thank you.

2 1

Re: kernel32/tests: Add tests for K32GetModuleFileNameEx
by Bruno Jesus May 1, 2012

May 1, 2012

On Tue, May 1, 2012 at 02:34, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Add some tests required for http://bugs.winehq.org/show_bug.cgi?id=30543 Please, ignore this patch. It was based on old git. Apologies, Bruno

1 0

Re: [PATCH 4/4] amstream: Add stubbed implementation of AudioStreamSample. (try 2) (resend)
by Marvin May 1, 2012

May 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18153 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] amstream: Add stubbed implementation of DirectDrawStreamSample. (try 2) (resend)
by Marvin May 1, 2012

May 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18152 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/4] dmusic: Add tests to enumerate master clocks.
by Marvin May 1, 2012

May 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18151 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Fwd: Ubuntu 12.04 (version#2, drop previous mail)
by Eric Pouech May 1, 2012

May 1, 2012

for the devels having upgraded their boxes to ubuntu 12.04, here's a couple of stuff I had to do, especially to get 32bit wine compile This could be useful if you want to have a dual x86_64 : i386 setup this is an updated version to what I already sent to scott ritchie of course this is not a step by step installation, just hints if you want to take that road (version #3) (I'm using a multiarch x86_64/i386) now wine compiles and runs in 32bit while compiled on 64bit machine here's the summary of the pain getting it right after upgrade in response to https://bugs.launchpad.net/ubuntu/+source/wine1.4/+bug/944321 I was able to compile 32bit-wine on 64bit as I always, and without a chroot or anything similar Problem #1 ---------- an old (11.10 according to the dates) directory was left over after migration, whereas it should have been removed /usr/include/i386-linux-gnu Problem #2 ---------- a ton of symlinks are missing in /usr/lib/i386-linux-gnu for example [root:/usr/lib/i386-linux-gnu]# ls -l /usr/lib/i386-linux-gnu/libfree* lrwxrwxrwx 1 root root 20 avril 3 10:54 /usr/lib/i386-linux-gnu/libfreetype.so.6 -> libfreetype.so.6.8.0 -rw-r--r-- 1 root root 624084 avril 3 10:54 /usr/lib/i386-linux-gnu/libfreetype.so.6.8.0 and it misses lrwxrwxrwx 1 root root 16 avril 28 21:30 /usr/lib/i386-linux-gnu/libfreetype.so -> libfreetype.so.6 the same applies for a lot libraries libXcursor.so libXi.so libXxf86vm.so libxrandr.so libxinerama.so libxcomposite.so libGLU.so libdbus-1.so (libdbus-1.so lies in /lib/i386-linux-gnu, not /usr/lib/i386-linux-gnu) libgnutls.so libsane.so libv4l1.so libgphoto2.so libgphoto2_port.so libgstreamer-0.10.so (***) libcapi20.so libcups.so libfontconfig.so libtiff.so libmpg123.so libopenal.so libxrender.so libGL.so (libGL.so is in mesa subdir!!!) libxml2.so libxslt.so libssl.so libcrypto.so libjpeg.so (***) libpng.so.0 (libpng12.so.0 lies in /lib/i386-linux-gnu, not /usr/lib/i386-linux-gnu) libXext.so the ones marked (***) means that the symlink is missing but it doesn't solve fully the issue from a wine perspective (see below) Problem #3 (jpeg) ----------------- Fails to open<jconfig.h>. which only lies in /usr/include/x86_64-linux-gnu/jconfig.h, and couldn't be accessed from 32bit build Creating the /usr/include/i386-linux-gnu/ directory and creating a symlink for jconfig.h to /usr/include/x86_64-linux-gnu/jconfig.h just works (I checked the contents of jconfig.h and it looks reasonable to do so) Problem #4 (gstreamer) ---------------------- it doesn't work as only /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h is installed (/usr/lib/i386-linux-gnu/glib-2.0/include/glibconfig.h doesn't exist, dpkg -S doesn't find it) and /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h defines gint64 as long, which is correct on 64bit targets one wrong on 32 bit ones... one should craft a decent /usr/lib/i386-linux-gnu/glib-2.0/include/glibconfig.h, or grab one out of pure i386 install (I haven't had time to look further into those, my main interest was to have a 32bit setup up& running) List of potentially installed i386 packages ------------------------------------------- fixed by installing i386 packages (not exhaustive, unfortunately, as I didn't note all the :i386 packages I've manually installed) libldap2.so alternatively, if I do a [eric:~]$ dpkg -l | grep i386 | grep -- -dev ii libc6-dev-i386 2.15-0ubuntu10 Embedded GNU C Library: 32-bit development libraries for AMD64 ii libldap2-dev:i386 2.4.28-1.1ubuntu4 OpenLDAP development libraries ii libpthread-stubs0-dev:i386 0.3-3 pthread stubs not provided by native libc, development files ii libx11-dev:i386 2.1.4.99.1-0ubuntu2 X11 client-side library (development headers) ii libxau-dev:i386 1:1.0.6-4 X11 authorisation library (development headers) ii libxcb1-dev:i386 1.8.1-1 X C Binding, development files ii libxdmcp-dev:i386 1:1.1.0-4 X11 authorisation library (development headers) tends to ask for libc6-dev:i386, libldap2-dev:i386, libx11-dev:i386, libxau-dev:i386, libxcb1-dev:i386, libxdmcp-dev:i386 as dedicated installations of dev:i386 packages but strangely enough, when looking at details, libx11-dev (for example) cannot be installed with libx11-dev:i386 according to manifest, but I have both installed (and both install the same files in /usr/include for example) this looks very strange indeed List of stuff that won't work ----------------------------- won't be supported (just to note them, as those are the left overs from the configure failing list) compiled without multiarch support: libhal, libgsm Warning at compilation ---------------------- when compiling, some warnings still have to be worked upon /home/eric/work/wine/dlls/winex11.drv/keyboard.c:1109:5: warning: 'XKeycodeToKeysym' is deprecated (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations] this one can be forgotten for now (it's just being marked deprecated in precise, so warning doesn't come from misconfiguration) debugging (32bit and 64bit) is broken ------------------------------------- the debugging is broken it turns out that ptrace and prctl (which had to be added in 11.10) work fine when tracing, only the first started process get correct pid out of wineserver in socket SCM_CREDENTIALS info. the later get 0 I tried to force the pid without requiring the recvmsg stuff and it works just fine I've not found yet the change that broke this more to come if get any futher on the remaining topics A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

5 7

Re: [PATCH 4/4] ws2_32/tests: Test for IOCP behavior without AcceptEx call (resend).
by Marvin May 1, 2012

May 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18138 Your paranoid android. === W7PROX64 (64 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === TEST64_W7SP1 (64 bit sock) === sock.c:5628: Test failed: Internal status is c0000120

1 0

Re: [PATCH 3/4] ws2_32/tests: Test for AcceptEx IOCP behavior for a duplicated handle (try 2).
by Marvin May 1, 2012

May 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18137 Your paranoid android. === W7PROX64 (64 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === TEST64_W7SP1 (64 bit sock) === sock.c:5628: Test failed: Internal status is c0000120

1 0

Re: [PATCH 4/4] ws2_32/tests: Test for IOCP behavior without AcceptEx call.
by Marvin May 1, 2012

May 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18134 Your paranoid android. === WVISTAADM (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W2K8SE (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W7PRO (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W7PROX64 (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === TEST64_W7SP1 (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W7PROX64 (64 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === TEST64_W7SP1 (64 bit sock) === sock.c:5628: Test failed: Internal status is c0000120

1 0

Re: [PATCH 3/4] ws2_32/tests: Test for AcceptEx IOCP behavior for a duplicated handle.
by Marvin May 1, 2012

May 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18133 Your paranoid android. === WVISTAADM (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W2K8SE (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W7PRO (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W7PROX64 (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === TEST64_W7SP1 (32 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === W7PROX64 (64 bit sock) === sock.c:5628: Test failed: Internal status is c0000120 === TEST64_W7SP1 (64 bit sock) === sock.c:5628: Test failed: Internal status is c0000120

1 0