May 2012 - Wine-Devel - list.winehq.org

Re: [PATCH] d3drm: Retreive mesh name at loading time. Implement GetName and SetName. (try 5) (resend)
by Alexandre Julliard May 9, 2012

May 9, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > Try 5: Use a growing buffer to store name. I don't think a growing buffer makes sense for this. > + if (name) > + { > + *size = min(*size, This->name_size); > + memcpy(name, This->name, *size); > + /* Make sure we have the terminating 0 in case of truncation */ > + name[*size] = 0; Buffer overflow. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Ubuntu 12.04 (version#2, drop previous mail)
by Eric Pouech May 9, 2012

May 9, 2012

> This is because you _cannot_ install the 32-bit -dev packages onto > 12.04. It's not just symlinks that are missing, many of the header > files are different between the arches. I'm not sure this is a generic rule, and if it were, then exclusion between i386 and x86_64 should be defined on most dev packages, and it's not the case also note, that in some cases, arch specific headers are moved to arch dependent directories (e.g. jpeg, glib...), which should also parallel install of multi-arch libs in any case, the job by ubuntu folks in 12.04 done is crappy, to say the least > Just do the chroot. You will save yourself so much grief and it will > actually work. if the ubuntu folks keep this state of mind, then they'll continue to sink the best solution is then to pick up another distro A+ -- -- Eric Pouech

3 4

Re: [2/5] gdi32: Set tmDigitizedAspectX/Y to 96 instead of 300 for consistency.
by Dmitry Timoshkov May 8, 2012

May 8, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -6677,8 +6677,8 @@ static BOOL get_outline_text_metrics(GdiFont *font) > TM.tmWeight = pOS2->usWeightClass; > } > TM.tmOverhang = 0; > - TM.tmDigitizedAspectX = 300; > - TM.tmDigitizedAspectY = 300; > + TM.tmDigitizedAspectX = 96; /* FIXME */ > + TM.tmDigitizedAspectY = 96; /* FIXME */ A couple of comments to the patch: 1. the values should be set to the resolution of the target device, and 96 looks more natural since most of the time the device is a display. 2. the change is for consystency with get_bitmap_text_metrics() which sets these values to 96. 3. even if this pacth is rejected, other patches in the sequence should not be affected by it. -- Dmitry.

1 0

running 16bit code
by David Laight May 8, 2012

May 8, 2012

Does wine support running of 16bit windows apps? If so does it rely on the underlying OS having support for 'virtual 8086 emulation'? I'm thinking of removing the VM86 support from NetBSD, and wine is about the only likley user. David -- David Laight: david(a)l8s.co.uk

5 5

Re: [PATCH 4/4] dmsynth: Add stubbed IKsControl interface to DirectMusicSynthSink object.
by Alexandre Julliard May 8, 2012

May 8, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/dmsynth/dmsynth_private.h | 1 + > dlls/dmsynth/synthsink.c | 67 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 68 insertions(+), 0 deletions(-) It fails here: ../../../tools/runtest -q -P wine -M dmsynth.dll -T ../../.. -p dmsynth_test.exe.so dmsynth.c && touch dmsynth.ok dmsynth.c:56: Test succeeded inside todo block: IDirectMusicSynthSink_QueryInterface returned: 0 make: *** [dmsynth.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] d3dcompiler: Partially implement D3DCompile function.
by Henri Verbeet May 8, 2012

May 8, 2012

I realize compile_shader() is mostly a copy of assemble_shader(), but nevertheless: On 8 May 2012 16:17, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +struct bwriter_shader *parse_hlsl_shader(const char *text, enum shader_type type, DWORD version, If this isn't called outside of compiler.c it should be static. > + LPD3DBLOB buffer; "ID3DBlob *" > + CopyMemory(pos, preproc_messages, strlen(preproc_messages) + 1); memcpy() should do fine. > + hr = SlWriteBytecode(shader, 9, &res); ... > + size = HeapSize(GetProcessHeap(), 0, res); > + hr = D3DCreateBlob(size, &buffer); That's not very pretty, SlWriteBytecode() should probably just return the size as well.

2 1

Re: mscoree: Implement vtable fixups.
by Alexandre Julliard May 8, 2012

May 8, 2012

Vincent Povirk <madewokherd(a)gmail.com> writes: > + if (fixup->fixup->type & COR_VTABLE_32BIT) > + { > + DWORD *vtable = fixup->vtable; > + DWORD *tokens = fixup->tokens; > + for (i=0; i<fixup->fixup->count; i++) > + { > + TRACE("%x\n", tokens[i]); > + vtable[i] = (DWORD)host->mono->mono_marshal_get_vtfixup_ftnptr( > + image, tokens[i], fixup->fixup->type); This will cause warnings on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: kernel32: Add UTF-7 support
by Alex Henrie May 8, 2012

May 8, 2012

2012/5/7 Ben Klein <shacklein(a)gmail.com>: > Without being a regular contributor, here are a few tips from a cursory glance: > 1) Whitespace change on at least one line The only change to whitespace I made was: - if( flags) + if (flags) I don't think this is a big deal. > 2) Why the change from ERROR_INVALID_PARAMETER to ERROR_INVALID_FLAGS? To match the behavior of Windows. I verified this with both MSDN and empirical tests. If the flags parameter is not null, all versions of Windows tested report ERROR_INVALID_FLAGS with the possible exception of Windows NT4. See http://testbot.winehq.org/JobDetails.pl?Key=18148 > 3) New function defs do not match format of surrounding defs in unicode.h This was a hard one. I didn't know if I should keep Katayama's use of INT or change the functions to use int like the UTF-8 functions do. So you're saying it should all be int? Do LPCSTR and LPCWSTR need to be changed to something else as well? > 4) No new tests to confirm the behaviour is correct (or mention of > current tests succeeding) dlls/kernel32/tests/locale.c already has just as many UTF-7 tests as it has UTF-8 tests. What tests do we need for UTF-7 which are not needed for UTF-8? Thanks for your quick response, -Alex

2 1

Re: msi: Tweak msiexec's usage message.
by Julian Rüger May 7, 2012

May 7, 2012

Hi Francois and wine-devel, while we're at it, shouldn't these >"Advertise a product:\n" >"\t/j[u|m] package [/t transform] [/g languageid]\n" >"Apply a patch:\n" >"\t/p patch_package [property]\n" >"\t/p patch_package /a package [property]\n" also be put in curly brackets? Like this: \t/j[u|m] {package} [/t transform] ... \t/p {patch_package} [property]\n ... Best, Julian

3 3

Re: [Programs] Notepad: sync with ReactOS notepad (2)
by carlo.bramix＠libero.it May 7, 2012

May 7, 2012

Hello friends, >> Because you do seriously believe that ReactOS developers reversed the >> Windows notepad?! Along with Solitaire & calculator, I suppose? >> Common sense is a powerful tool, let's make use of it :-). > >It's a matter of trust. If a person is known to use illegal practices >to write ReactOS code then even adding one line of code to notepad >makes her/his contribution dangerous for the entity accepting that code. > >> For the record, ReactOS as well disallows any person who has seen the >> Microsoft Windows code to comment, contribute, commit to the project. > >That's just a blanket statement, nothing more. It's hard to believe >to it if the person(s) publicly accused in using leaked code still >commit to ReactOS without any limitation. as I already wrote, I totally agree. Please reject the patches. Sincerely, Carlo Bramini.

1 0

Re: [Programs] Notepad: sync with ReactOS notepad (2)
by carlo.bramix＠libero.it May 7, 2012

May 7, 2012

Hello friends, >The issue is whether the appropriate guidelines were followed >(http://wiki.winehq.org/CleanRoomGuidelines) One issue is that Wine >does not allow people that have ever viewed Microsoft source code to >contribute to Wine, but there are other issues. You'll have to talk >to Alexandre and see how he feels about this specific issue, but if >you've followed all of the guidelines and contribute only your own >changes then he might be ok with your contribution. I see. Perhaps it would be better to reject all these patches since I'm not the only author of all the changes. I understand that this is done to protect yourself and the project, because you do not know the people who touched the sources of the notepad, who they are and how they collected their information, so I agree with you. Sincerely, Carlo Bramini.

3 2

Re: [Programs] Notepad: sync with ReactOS notepad (2)
by carlo.bramix＠libero.it May 6, 2012

May 6, 2012

Hello friends, >thank you for working on this. I think you will improve the chances for >your patches to be accepted if you give them individually meaningful >names, like > >"notepad: Don't use reserved MSVC keyword." > >for patch #2. Actually, I followed the tip I read into the wiki of WINE in "Patch submission guidelines", so I tried to imitate the style of other patches for WINE and for this reason I used an identical title with a progressive number as subject. If something different is prefered, no problem, I will follow your suggestion and I will use a more focused title. >Also, like Jerome said, we may have a problem if different people >commited these changes to ReactOS. I'm no expert on this, but as I >understand, Wine needs the patch to be credited to the author who >actually wrote the code. Well, ReactOS notepad had been imported from WINE long time ago and various people did some changes on it and I'm included in them since, in this specific case, the status bar implementation had been almost rewritten by me. I'm not an expert too, but since it is distribuited under the same license of WINE, with same coding restrictions and all people who sent patches have agreed to the same GPL as well, my intuition would say that there is no problem on this... because the owner who can providing this code to you is the ReactOS project itself. That's just my opinion of course... I will wait for your suggestions/orders... ;-) Sincerely, Carlo Bramini.

4 3

Re: [Programs] Notepad: sync with ReactOS notepad (2)
by Julian Rüger May 6, 2012

May 6, 2012

Hi Carlo, thank you for working on this. I think you will improve the chances for your patches to be accepted if you give them individually meaningful names, like "notepad: Don't use reserved MSVC keyword." for patch #2. Also, like Jerome said, we may have a problem if different people commited these changes to ReactOS. I'm no expert on this, but as I understand, Wine needs the patch to be credited to the author who actually wrote the code. (Can someone else please comment on this, if I am mistaken?) Best regards, Julian

1 0

Re: rpcrt4/tests: Fix build with PSDK headers.
by Marvin May 5, 2012

May 5, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18238 Your paranoid android. === WNT4WSSP6 (32 bit ndr_marshall) === ndr_marshall: unhandled exception c0000005 at 004081C6

1 0

Re: [Programs] Notepad: sync with ReactOS notepad
by Jerome Leclanche May 5, 2012

May 5, 2012

On Sat, May 5, 2012 at 2:15 PM, carlo.bramix(a)libero.it < carlo.bramix(a)libero.it> wrote: > Attached patch synces the WINE's notepad with the improvements added into > ReactOS' Notepad. > > - Imported status bar implementation, it fixes Bug #18715. New menu voice > has > been introduced into the resource file. > This is the biggest part of the patch, that it caused to touch all files > modified by the patch. > Other minor fixes included here are: > > - Implemented GOTO function. Since its menu voice has been added into the > resource file when adding support the statusbar, the related dialog box > and the > source code have been introduced too. > > - Find/Replace functions have an extremely similar behavior, so the job > can be > implemented with a single function. > > - Find and Find next commands must be grayed if there is not a text to > search > into. > > - The "class" word is a reserved keyword in MSVC, so I also imported the > fix > into the creation of the class of the window: "class" has been replaced > with > "wndclass", no code change. > > Sincerely, > > Carlo Bramini > > It's not going to be accepted as one big patch. It needs to be split. Also, are you the author of all the patches or are these other contributors for this? J. Leclanche

1 0

Re: kernel32: add more tracing to GetDiskFreeSpaceW
by Dmitry Timoshkov May 5, 2012

May 5, 2012

Austin English <austinenglish(a)gmail.com> wrote: > @@ -1687,6 +1689,8 @@ BOOL WINAPI GetDiskFreeSpaceW( LPCWSTR root, LPDWORD cluster_sectors, > if (sector_bytes) *sector_bytes = info.BytesPerSector; > if (free_clusters) *free_clusters = info.AvailableAllocationUnits.u.LowPart; > if (total_clusters) *total_clusters = info.TotalAllocationUnits.u.LowPart; > + TRACE("%u, %u, %u, %u, capped=%d\n", cluster_sectors ? *cluster_sectors : 0, sector_bytes ? *sector_bytes : 0, > + free_clusters ? *free_clusters : 0, total_clusters ? *total_clusters : 0, capped); Why not print in the values directly from info structure? That way all the data are in the trace regardless of what info appication requested. I'd guess that printing valus in hex would be more readable, and once the data is printed in hex it should be obvious when the values were capped, making 'capped' flag redundant. -- Dmitry.

1 0

Re: [2/5] msvcm80: Add stub dll.
by Charles Davis May 4, 2012

May 4, 2012

On May 4, 2012, at 10:07 AM, Vincent Povirk wrote: > > <0002-msvcm80-Add-stub-dll.txt> msvcmrt? The Managed C++ Runtime DLL? I imagine you won't get far on that without a C++/CLI compiler that understands the Microsoft Visual C++ ABI--unless you're willing to write all the marshaling glue code by hand. There's only one such compiler right now, and it only runs on Windows. VC++ ABI support is on my Clang to-do list--heck, it's my GSoC project--but C++/CLI is something I won't get to for a while. Given all that, how do you intend to implement this? Chip

2 2

Re: [2/5] msvcm80: Add stub dll.
by Stefan Dösinger May 4, 2012

May 4, 2012

3 2

Re: [5/5] msvcm80: Add __setusermatherr_m stub.
by Charles Davis May 4, 2012

May 4, 2012

On May 4, 2012, at 10:10 AM, Vincent Povirk wrote: > diff --git a/dlls/msvcm80/msvcm80_main.c b/dlls/msvcm80/msvcm80_main.c > index cd38f5b..eb09898 100644 > --- a/dlls/msvcm80/msvcm80_main.c > +++ b/dlls/msvcm80/msvcm80_main.c > @@ -50,3 +50,10 @@ void __cdecl CrtImplementationDetails_RegisterModuleUninitializer(void* handler) > FIXME("%p: stub\n", handler); > } > > +/* handler is a "method" with signature int32 (*handler)(_exception*), but I'm > + * not sure what that means */ I am. Actually, it's: int (__clrcall *handler)(struct _exception *) i.e. a "pointer to a function intended to be called from managed code that takes a pointer to a struct _exception and returns an int." The definition of struct _exception is in <math.h> under Visual Studio. To write such a function, you'd need a C++/CLI compiler. Chip

1 0

Wine Gecko 1.6-beta1
by Jacek Caban May 4, 2012

May 4, 2012

Hi all, I've uploaded a beta version of another Gecko update. Other than usual Gecko changes coming from Mozilla (for upcoming Firefox 13), it contains fixes for Wine bugs 30465 and 25243. To try it, as usually, the attached patch is required as well as the build that may be found on SourceForge [1], installed in usual way [2] (or your own build, it's easy those days! See wine-gecko-1.6 branch on [3]). All help with testing is appreciated! Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.6-beta1/ [2] http://wiki.winehq.org/Gecko [3] http://wine.git.sourceforge.net/git/gitweb.cgi?p=wine/wine-gecko;a=summary

1 0

Re: [PATCH 1/2] jscript: Skip failing tests on old jscript versions
by Marvin May 4, 2012

May 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18229 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: po: English (neutral / Great Britain) spelling fixes.
by Nicolas Le Cam May 3, 2012

May 3, 2012

Le 3 mai 2012 02:45, "Francois Gouget" <fgouget(a)free.fr> a écrit : > @@ -9429,9 +9429,9 @@ msgstr "" > "start [options] document_filename\n" > "\n" > "Options:\n" > -"/M[inimized] Start the program minimized.\n" > -"/MAX[imized] Start the program maximized.\n" > -"/R[estored] Start the program normally (neither minimized nor maximized).\n" > +"/M[inimized] Start the program minimised.\n" > +"/MAX[imized] Start the program maximised.\n" > +"/R[estored] Start the program normally (neither minimised nor maximised).\n" > "/W[ait] Wait for started program to finish, then exit with its exit " > "code.\n" > "/Unix Use a Unix filename and start the file like windows explorer.\n" Hi Francois, Shouldn't the end of words between brackets be translated too ? -- Nicolas Le Cam

3 3

Re: [3/5] d3dx9: Implement D3DXSaveSurfaceToFileW.
by Henri Verbeet May 3, 2012

May 3, 2012

On 2 May 2012 23:32, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > + if(wic_pixel_formats[i].d3dformat == format) Missing whitespace. > +HRESULT WINAPI D3DXSaveSurfaceToFileW(LPCWSTR dst_filename, D3DXIMAGE_FILEFORMAT file_format, "LPCWSTR" -> "const WCHAR *" > + TRACE("(%s, %d, %p, %p, %p)\n", > + wine_dbgstr_w(dst_filename), file_format, src_surface, src_palette, src_rect); wine_dbgstr_rect(). > + memcpy(&wic_pixel_format, pixel_format_guid, sizeof(GUID)); > + hr = IWICBitmapFrameEncode_SetPixelFormat(frame, &wic_pixel_format); > + d3d_pixel_format = wic_guid_to_d3dformat(&wic_pixel_format); What is all this for? Also, how do you intend to implement D3DXSaveSurfaceToFileInMemory()?

2 2

Re: [2/5] d3dx9: Forward D3DXSaveSurfaceToFileA to D3DXSaveSurfaceToFileW.
by Henri Verbeet May 3, 2012

May 3, 2012

On 2 May 2012 23:32, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > +HRESULT WINAPI D3DXSaveSurfaceToFileA(LPCSTR dst_filename, D3DXIMAGE_FILEFORMAT file_format, > + IDirect3DSurface9 *src_surface, const PALETTEENTRY *src_palette, const RECT *src_rect) If you're changing these anyway, LPCSTR is a broken way of saying "const char *". > + TRACE("(%s, %d, %p, %p, %p): relay\n", > + wine_dbgstr_a(dst_filename), file_format, src_surface, src_palette, src_rect); I generally prefer %#x for things like file_format, but don't care particularly strongly. For src_rect you should use %s and wine_dbgstr_rect(). I don't care much for the "relay" suffix, but I suppose half the existing code has it as well. > + len = MultiByteToWideChar(CP_ACP, 0, dst_filename, -1, NULL, 0); > + filename = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(WCHAR)); The HEAP_ZERO_MEMORY flag is useless, you're immediately going to overwrite all the memory afterwards. Sadly the existing d3dx9 code isn't a very good example here either.

1 0

Request for help/advice in investigation of one interesting "huge FPS regression" bug
by Alexey Loukianov May 3, 2012

May 3, 2012

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Good day to all. Henri, Stefan, I address this message to you at the first place as to a main developers of wined3d/opengl stuff. Nevertheless, hints and help are welcome from anyone, cause ATM I'm totally confused and don't know what else to try to investigate a case. What I've got here is an app (localized version of "Perfect World" MMORPG game client from "Mail.Ru Games Corp") that seems to suffer huge FPS regression which I believe to be a bug in nVIDIA drivers rather than a regression in Wine. Details are following. When I configure an app to run in a windowed mode I've got around 40 FPS on game login screen with nVIDIA drivers 275.09.07, but switching into using more recent versions causes FPS to drop to around ~10. Configuring the game to use fullscreen more fixes the issue - I've got ~30-40 FPS at game login screen no matter the driver version I use. I've been suspecting that this issue might be related to vsync control (and a recent change in nVIDIA linux drivers for vsync to be on by default) that causes the issue, so I had exported __GL_SYNC_TO_VBLANK="0" into the environment and used nvidia-settings to set vsync to be off by default. Using a small native opengl demo program I had specifically written to test for vsync state I can prove that vsync defaults to be off on my system. Also I had modified Wine's winex11.drv opengl.c in a way that a call to wglSwapIntervalEXT always sets swap_interval to be zero, no matter what was originally requested. Nevertheless, I still got this strange FPS drop when I run the game in a windowed more with a recent nVIDIA drivers. What could be a cause for it? What I want is to track down the problem to it's roots and check if it's really a bug in nVIDIA drivers. In the end I would like to implement a small opengl demo that would trigger the bug so nVIDIA wouldn't be able to reject my bug report on a matter that "it's a Wine bug, prove us that it's not". - -- Best regards, Alexey Loukianov mailto:mooroon2(a)mail.ru System Engineer, Mob.:+7(926)218-1320 *nix Specialist -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPij76AAoJEPB9BOdTkBULjz4H/1B/Nw6qOQUlEmDb64SmabvQ LQmzIHcnH38Ftz3KyWQxlYZ5EtLDYAIOQeP4pAHfzxKhGUJ1mCumv4ByaSs4YDhI juWJ/u/88vKwZYXJ9nZLQVqJY+dkr9MbxP3q0eGNaAFLNRDIqodzJJWB5EPucMrX Yid/zMjl5uGd9QDCO3Db4gwJKYpvHCbAfzADddqBwPoak9jXdlq53H9a2mImTbCB JR1MXQq6gFakOgtxXPxzFSU2Ge0n8RBGGN7UeZEubsLiktnmvTbKAJmmgWgPG80Y mlud7LrM4wLRPtpwTwS+M1n8TuVtUZzzCTagRyj3XSRL8Pqf2d5S3H+MpxBT1JQ= =TkMD -----END PGP SIGNATURE-----

5 8