June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)
by Marvin June 19, 2012

June 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19269 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 3.
by Vincent Povirk June 19, 2012

June 19, 2012

I'm still a little worried about seeking the stream behind libtiff's back, but otherwise it looks good.

2 1

Disabling joysticks with registry keys and joy.cpl
by Lucas Zawacki June 19, 2012

June 19, 2012

Hello all, disabling an specific joystick device is an issue that is raised from time to time in this list. I'm planning on implementing it as a registry key like 'DirectInput/Disable controllername'. However I'd like the ability to disable specific joysticks on Linux, like the /dev/input/js* version, while keeping the /dev/input/event* one being enumerated. One option for doing this would be having a "Disable USB Controller" -> "driver" key with options being: "linux", "linuxinput", and "all". My only doubt is how would you guys want to have this option in joy.cpl? I think the correct thing to do would be to disable it with "all", but my use case includes a user disabling the repeated joysticks on Linux through the interface and if he's only able to disable all drivers at once that would be confusing and less useful. The bottom line is: can I add platform dependent code in joy.cpl for this purpose? If that's not an option, do you have some other way to do through joy.cpl or should it be registry only? Attached is an example patch of the approach for joystick_linuxinput.c Cheers, Lucas

2 2

Re: d3dx9_36: Reckonize A8B8G8R8 format
by Stefan Dösinger June 18, 2012

June 18, 2012

Hi, Please add the format to the dds tests in dlls/d3dx9_36/tests/surface.c > { 32, 0x0000ffff, 0xffff0000, 0x00000000, 0x00000000, D3DFMT_G16R16 }, > + { 32, 0xff, 0xff00, 0xff0000, 0xff000000, D3DFMT_A8B8G8R8 }, The other 32 bit formats in this table have their bitmasks padded to 32 bit with leading zeroes. Stefan Am Freitag, 15. Juni 2012, 18:18:46 schrieb Nozomi Kodama: This patch solves the color problem appearing in bug 30786. Nozomi

1 1

Re: comctl32: hotkey control needs to invalidate itself when painting for some apps
by Dmitry Timoshkov June 18, 2012

June 18, 2012

Dan Kegel <dank(a)kegel.com> wrote: > @@ -190,6 +190,8 @@ HOTKEY_Paint(HOTKEY_INFO *infoPtr, HDC hdc) > HOTKEY_Refresh(infoPtr, hdc); > else { > PAINTSTRUCT ps; > + /* In some apps, the hotkey doesn't draw unless we invalidate it here */ > + InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); It doesn't make sense to invalidate before painting in the paint handler. -- Dmitry.

2 1

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Chris Robinson June 18, 2012

June 18, 2012

On Friday, June 15, 2012 3:39:33 PM Andrew Eikum wrote: > One thing to note is that PulseAudio has an absurdly high default > latency (two seconds), and due to its poor API there's no (easy) way > for us to control it. The latency is likely caused by PulseAudio setting a much larger tlength (and minreq) than what you asked for. This happens all the time for me when the server has been running. The trick I've found to dealing with this in OpenAL Soft is to essentially ignore what PulseAudio sets and do your free space calculations so that only the size of the buffer you requested is used. Something like: size_t writable_size(pulse_data *data) { uint buffer_size = our requested buffer size in bytes; uint update_size = our expected period size in bytes; /* This is signed since it could come out negative */ ssize_t len; pa_threaded_mainloop_lock(data->loop); len = pa_stream_writable_size(data->stream) - data->attr.tlength + buffer_size; pa_threaded_mainloop_unlock(data->loop); if(len < 0) return 0; len -= len%update_size; return len; } The update_size is only relevant if mmdevapi updates in period-sized chunks. If it doesn't, you can just remove it and the rounding. The tlength should be kept updated using pa_stream_set_buffer_attr_callback, in case the server tries to increase it more during runtime. When creating the stream, I set minreq to the period size, and tlength to the requested buffer size. I also set the flags PA_STREAM_INTERPOLATE_TIMING, PA_STREAM_AUTO_TIMING_UPDATE, and PA_STREAM_ADJUST_LATENCY. The most important part is to not rely on PA_STREAM_EARLY_REQUESTS or the write callback to tell you when some space is free for writing, since as noted above, PulseAudio can set unreasonably large values. This doesn't completely fix the latency problem, as I'll still get better performance using ALSA's dmix, but it helps immensely.

2 4

comctl32: hotkey control needs to invalidate itself when painting for some apps
by Dan Kegel June 18, 2012

June 18, 2012

In at least one app, the hotkey control doesn't draw itself. Invalidating its own window during HOTKEY_Paint gets the control to draw properly, and makes the app happy. Fixes http://bugs.winehq.org/show_bug.cgi?id=30486 (Unlike the patch attached to that bug, this one doesn't also ask the background to be redrawn again.)

2 1

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 2.
by Vincent Povirk June 18, 2012

June 18, 2012

This looks better, but I still think you should use WICPersistOptionNoCacheStream. Some of your failure cases in create_metadata_reader will return a reference to an IWICMetadataReader, which seems wrong.

2 1

Re: windowscodecs: Create a IWICMetadataReader when loading a TIFF frame.
by Vincent Povirk June 18, 2012

June 18, 2012

> + hr = IWICPersistStream_LoadEx(persist, This->parent->stream, NULL, persist_options); > + if (FAILED(hr)) > + ERR("IWICPersistStream_LoadEx error %#x\n", hr); We can't use that stream because we provide separate seek and read/write methods to libtiff, and libtiff may rely on the stream's position to not change between operations. This illustrates a design flaw in WIC. Normally, we would just clone the stream, but IWICStream doesn't implement the Clone method. I think we are probably supposed to create a new IWICStream based on the given stream, but the resulting stream won't be thread-safe with ours. I think for now it's OK to re-use this stream as long as you seek it back to where it was when you're done, but we may have to change that later. Also, LoadEx should (but does not yet) save the stream so it can create an IWICFastMetadataEncoder. If you re-use the bitmap decoder's stream, you should also use the WICPersistOptionNoCacheStream flag when you create the metadata reader to make sure it won't do that. Your GetReaderByIndex method should check whether This->metadata_reader has been set and return an error if not. Otherwise, the patch looks good to me.

2 4

Re: atl80: prefer native, if present
by Alexandre Julliard June 18, 2012

June 18, 2012

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 7243b3594c9c0b13770ede1ab32d4dd1329b1dd4 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Sun, 17 Jun 2012 17:37:15 +0200 > Subject: atl80: prefer native, if present > > --- > dlls/atl80/atl80.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) There's no reason to do that, most of the dll is already implemented. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Darryl Slack June 18, 2012

June 18, 2012

Well after fighting with pulseaudio after all this time I have tried this patch with wine 1.5.6 with a Presonus StudioLive 24.4.2 Fire-wire controller within wine, to control software known as Virtual DJ with timecoded vinyl records. With Andrew's patch, there are stalled buffer errors, and I wasn't able to measure latency very well because the controller just kept on reporting 'stalled' I did also try martaans driver, which was added to wine, and latency was much lower, and the controller worked well within Linux, in fact the first time i've actually been able to use it with pulseaudio. I was measuring latency much lower than I expected, 2-4ms. With Andrew's Driver I was not even able to play a timecode from start to finish without 'stalled' buffers. Please Take the time to QA this driver for things just other than 'cos we have it' and consider Martaan's driver as well, because there is a massive improvement in latency over Andrews, and applications requiring fire-wire work much nicer with pulseaudio. My Wine build is 1.5.4, Gentoo 3.4.2-r1. Thanks Darryl

1 0

Re: mshtml: Implement IHTMLScriptElement_put_src
by Jacek Caban June 18, 2012

June 18, 2012

André, On 06/15/12 23:45, André Hentschel wrote: > --- > dlls/mshtml/htmlscript.c | 14 ++++++++++++-- > dlls/mshtml/tests/dom.c | 6 ++++++ > 2 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/htmlscript.c b/dlls/mshtml/htmlscript.c > index 376db7b..1714cfe 100644 > --- a/dlls/mshtml/htmlscript.c > +++ b/dlls/mshtml/htmlscript.c > @@ -101,8 +101,18 @@ static HRESULT WINAPI HTMLScriptElement_Invoke(IHTMLScriptElement *iface, DISPID > static HRESULT WINAPI HTMLScriptElement_put_src(IHTMLScriptElement *iface, BSTR v) > { > HTMLScriptElement *This = impl_from_IHTMLScriptElement(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_w(v)); > - return E_NOTIMPL; > + nsAString src_str; > + nsresult nsres; > + > + TRACE("(%p)->(%s)\n", This, debugstr_w(v)); > + > + nsAString_Init(&src_str, v); > + nsres = nsIDOMHTMLScriptElement_SetSrc(This->nsscript, &src_str); > + if (NS_FAILED(nsres)) > + ERR("SetSrc failed: %08x\n", nsres); > + nsAString_Finish (&src_str); > + > + return S_OK; > } > Unfortunately it's not so easy. That won't work this way. Jacek

1 0

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)
by Alexandre Julliard June 18, 2012

June 18, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE { > > /* From 0 to 4 */ > UCHAR LayerNumber; > -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE; > +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE; > + > +typedef struct _DVD_DESCRIPTOR_HEADER { > + USHORT Length; > + UCHAR Reserved[2]; > +#if !defined(_midl) > + UCHAR Data[0]; > +#endif > +} DVD_DESCRIPTOR_HEADER, *PDVD_DESCRIPTOR_HEADER; > +C_ASSERT(sizeof(DVD_DESCRIPTOR_HEADER) == 4); Zero-size arrays are not portable and should be avoided. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] wbemprox: Add tests for IWbemServices.
by Marvin June 18, 2012

June 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19208 Your paranoid android. === WNT4WSSP6 (32 bit services) === services.c:38: Test failed: failed to create IWbemLocator interface 80040154 services: unhandled exception c0000005 at 004019EE

1 0

Re: [2/2] comdlg32/tests: Test file name selection on init
by Marvin June 17, 2012

June 17, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19196 Your paranoid android. === WNT4WSSP6 (32 bit filedlg) === Timeout === W2KPROSP4 (32 bit filedlg) === Timeout === WXPPROSP3 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 7C809E32 === W2K3R2SESP2 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 77E63110 === WVISTAADM (32 bit filedlg) === filedlg: unhandled exception c0000005 at 76A75031 === W2K8SE (32 bit filedlg) === filedlg: unhandled exception c0000005 at 76285DBE === W7PRO (32 bit filedlg) === filedlg.c:1158: Test failed: The EM_GETSEL message returned with no selection

1 0

Re: [PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test
by Nikolay Sivov June 17, 2012

June 17, 2012

On 6/17/2012 13:11, Alexandre Goujon wrote: > > case DvdManufacturerDescriptor: > + nt_desc.manf->Header.Length = 0x0802; > + nt_desc.manf->Header.Reserved[0] = 0; > + nt_desc.manf->Header.Reserved[1] = 0; Does this length mean something? Looks a bit dirty to leave hardcoded things like that, but maybe I don't know details.

2 1

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)
by Nikolay Sivov June 17, 2012

June 17, 2012

On 6/17/2012 13:11, Alexandre Goujon wrote: > Superseeds the patch of the same name (#87003) > Definition and assert taken from Windows Driver Kit (WDK) 8 Consumer Preview > --- > include/ddk/ntddcdvd.h | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/include/ddk/ntddcdvd.h b/include/ddk/ntddcdvd.h > index 5313496..d0178c7 100644 > --- a/include/ddk/ntddcdvd.h > +++ b/include/ddk/ntddcdvd.h > @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE { > > /* From 0 to 4 */ > UCHAR LayerNumber; > -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE; > +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE; > + > +typedef struct _DVD_DESCRIPTOR_HEADER { > + USHORT Length; > + UCHAR Reserved[2]; > +#if !defined(_midl) > + UCHAR Data[0]; > +#endif > +} DVD_DESCRIPTOR_HEADER, *PDVD_DESCRIPTOR_HEADER; > +C_ASSERT(sizeof(DVD_DESCRIPTOR_HEADER) == 4); This looks wrong, correct name for it __midl, and this also needs a check for __WIDL__ probably.

2 1

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines.
by Dmitry Timoshkov June 17, 2012

June 17, 2012

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > - static const struct test_data > + const int font[] = > { > - int id, weight, height, dpi; > + ANSI_FIXED_FONT, ANSI_VAR_FONT, SYSTEM_FONT, DEVICE_DEFAULT_FONT, DEFAULT_GUI_FONT > + /* SYSTEM_FIXED_FONT, OEM_FIXED_FONT */ > + }; > + const struct test_data > + { Please add back 'static' to test_data and add it to font. -- Dmitry.

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Maarten Lankhorst June 16, 2012

June 16, 2012

What happened to the stamped capture buffers? Why is held_frames added? This doesn't look like an attempt to get my driver in, it looks like a rewrite by someone who doesn't understand why I made the design decisions I made for correctness. If you don't paste all the mmdevapi tests with the fix in my git tree, it's a regression. I don't want to see held_Frames because it's a shadow buffer. If winmm and dsound don't work without it, they're wrong, fix those. The logic I kept for timestamping audio buffers was removed which just makes timestamping less accurate on capture buffers. Was this driver even tested on low latency? There was a reason I kept track of all packets in a linked list, no need to do held_frames logic. I genuinely do want a good driver to go in, but this just isn't it. There is also no reason to have an INCREASED period size for exclusive compared to shared. I'm currently not handling exclusive because there are no good tests for it. and "hooray_cb" ? If this is going to be accepted (likely, sadly) I want to have this added to the commit: Rejected-by: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> ~Maarten PS: Still sad that you chose to reject my original driver not based on any merits.

1 0

Re: [PATCH] sfnt2fnt: Fix broken .fon files on !x86 architectures
by Alexandre Julliard June 15, 2012

June 15, 2012

Hilko Bengen <bengen(a)hilluzination.de> writes: > @@ -46,6 +46,8 @@ > > #include "pshpack1.h" > > +#include <endian.h> endian.h is not portable, you should use the endianness defines from the Wine headers instead. -- Alexandre Julliard julliard(a)winehq.org

4 9

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver
by Alexandre Julliard June 15, 2012

June 15, 2012

Andrew Eikum <aeikum(a)codeweavers.com> writes: > The configure.ac changes and parts of the driver itself were written by > Maarten Lankhorst. It doesn't work here, it's apparently using the driver even though PulseAudio is not running on this box: ../../../tools/runtest -q -P wine -M amstream.dll -T ../../.. -p amstream_test.exe.so amstream.c && touch amstream.ok err:pulse:AudioClient_Initialize PulseAudio no longer running? err:quartz:DSoundRender_create Cannot create Direct Sound object (88890010) fixme:ole:CoCreateInstance no instance created for interface {56a86895-0ad4-11ce-b03a-0020af0ba770} of class {79376820-07d0-11cf-a24d-0020afd79767}, hres is 0x88890010 amstream.c:274: Test failed: IAMMultiMediaStream_AddMediaStream returned: 88890010 -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH 1/4] DSS Test Suite: CryptAcquireContext tests for base DSS
by Alexandre Julliard June 15, 2012

June 15, 2012

Marek Chmiel <kcmark(a)gmail.com> writes: > From 748332765355ae099ab24cf1402bed86610984e7 Mon Sep 17 00:00:00 2001 > From: Marek Chmiel <kcmark(a)gmail.com> > Date: Fri, 1 Jun 2012 22:38:03 -0500 > Subject: [PATCH 1/4] Add CryptAcquireContext tests for base DSS CSP. > > --- > configure | 1 + > configure.ac | 1 + > dlls/dssenh/tests/Makefile.in | 7 +++ > dlls/dssenh/tests/dssenh.c | 119 +++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 128 insertions(+) > create mode 100644 dlls/dssenh/tests/Makefile.in > create mode 100644 dlls/dssenh/tests/dssenh.c You are adding 4 almost identical copies of that code. Try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2 resend] advapi32: Pass service name as argv[0] to ServiceMain
by Alexandre Julliard June 15, 2012

June 15, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > Resend with tests. > > --- > dlls/advapi32/service.c | 3 +-- > programs/services/tests/service.c | 4 ++++ > 2 files changed, 5 insertions(+), 2 deletions(-) You will now get the name twice for autostart services. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).
by Alexandre Julliard June 15, 2012

June 15, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > + while(min <= max) > + { > + const char *encoded_symbol; > + > + pos = (min+max)/2; > + encoded_symbol = html_encoded_symbols[pos].html_code; > + dir = strncmp(encoded_symbol, amp, len); You need to check the length, strncmp is not enough. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mmcndmgr: Implement IMMCVersionInfo (try 3)
by Marvin June 15, 2012

June 15, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19090 Your paranoid android. === WNT4WSSP6 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000 === W2KPROSP4 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000

1 0

Re: ru.po: improved an Russian translation
by Oleg Yarigin June 15, 2012

June 15, 2012

Hi, Julian! > 1. Patches should be sent to wine-patches(a)winehq.org, not wine-devel. Thank you a lot, I didn't know these address! > I don't think that's a good idea... Afaik, the general guideline is to > not change formatting and punctuation (from the English original), > unless there's a rule in the Russian language that specifically > dictates it. In Russian there is different from English punctuation. We create a tool for humans, not machines, don't we? So, we must improve a punctuation according to a language's rules. Instead, I send my improves to Nikolay, as you recommended. > A normal, UTF-8 formatted textfile as an attachment ... should suffice, > you shouldn't need to pack it. > I guess an archive could also confuse the automated scripts I packed it to decrease a size. But if it isn't good for merging, I willn't do it. > Please understand this as constructive criticism, it will help getting > your patch accepted and not cause extra work for the maintainer > (Alexandre). It looks like you invested a lot of effort, thanks for > that. No, that's OK. There isn't something bad in constructive criticism, I think. --- Best regards, Oleg. P. S. I didn't know how to post messages into pipemail, so I replied privetly. There is a copy of my answer.

1 0

Re: [05/11] windowscodecs: Add support for more types of IFD fields. Resend.
by Alexandre Julliard June 15, 2012

June 15, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -650,30 +672,43 @@ static HRESULT load_IFD_entry(IStream *input, const struct IFD_entry *entry, > SWAP_ULONG(count); > type = entry->type; > SWAP_USHORT(type); > + item->value.vt = tag_to_vt(type); > value = entry->value; > SWAP_ULONG(value); > > switch (type) > { > + case IFD_BYTE: > + case IFD_SBYTE: > + if (count == 1) > + { > + item->value.u.bVal = *(BYTE *)&value; > + break; > + } > + FIXME("loading multiple byte fields is not implemented\n"); > + break; This seems to contradict the endianness support. Are you really supposed to byte-swap arrays of bytes? -- Alexandre Julliard julliard(a)winehq.org

2 1

RFC: comdlg32: Fix null lpstrFile uses in FILEDLG95_OnOpen
by Bruno Jesus June 15, 2012

June 15, 2012

Hi, I have written a patch to fix bug 17229 and would like to request help to complete the test part. The test creates a common dialog and select a filename (file does not need to exist), it was copied from other tests in the same file (comdlg32/tests/filedlg.c). It's not possible to have a default file name because lpstrFile is used to do this and it's NULL. To fill a filename in the common dialog control that appears I have used EnumChildWindows to find the textbox and set the filename in it. The main problem is how to detect that a HWND is a textbox? Currently I'm sending SetWindowText to every control and that does work but I think the patch may be rejected by that. The patch can be downloaded at: https://testbot.winehq.org/JobDetails.pl?Key=19074 The problem is in the line 56. Thanks in advance, Bruno

1 0

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).
by Alexandre Julliard June 14, 2012

June 14, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. As of version > 3 of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and it also includes some additional cleanup. It > is important to note that HTML Help only supports characters within > the ANSI code pages, so support for multi-byte characters is not > necessary. I don't see why you'd want to use ANSI code pages for this, since they will be converted to Unicode anyway. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: msvcrt/tests: Fix portuguese locale test on NT4
by Marvin June 14, 2012

June 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19045 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: msvcrt: Fix the name of the Portuguese locale alias.
by Bruno Jesus June 14, 2012

June 14, 2012

On Wed, Jun 13, 2012 at 2:47 PM, Francois Gouget <fgouget(a)free.fr> wrote: > ... > dlls/msvcrt/locale.c | 2 +- > dlls/msvcrt/tests/locale.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > ... > - "portugese", "ptb", > + "portuguese", "ptb", Just a side note. Although I'm not sure I think portuguese is "ptg", brazilian portuguese is "ptb". So the correct may be: > + "portuguese", "ptg", A Portugal user would be able to check that, or maybe it's easier to write a testcase. If I'm wrong I ask apologies in advance, Bruno

3 2

DllMain() seems unused in ntoskrnl.exe
by Francois Gouget June 14, 2012

June 14, 2012

The DllMain() function in ntoskrnl.exe appears to be unused: making it static causes a compiler warning to that effect and removing it entirely does not cause a compilation failure. Should it be removed or is there a build issue with ntoskrnl.exe? diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index 2b84297..ffeb2f8 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -1711,30 +1711,6 @@ VOID WINAPI IoInitializeRemoveLockEx(PIO_REMOVE_LOCK lock, ULONG tag, } /***************************************************** - * DllMain - */ -BOOL WINAPI DllMain( HINSTANCE inst, DWORD reason, LPVOID reserved ) -{ - static void *handler; - LARGE_INTEGER count; - - switch(reason) - { - case DLL_PROCESS_ATTACH: - DisableThreadLibraryCalls( inst ); -#ifdef __i386__ - handler = RtlAddVectoredExceptionHandler( TRUE, vectored_handler ); -#endif - KeQueryTickCount( &count ); /* initialize the global KeTickCount */ - break; - case DLL_PROCESS_DETACH: - RtlRemoveVectoredExceptionHandler( handler ); - break; - } - return TRUE; -} - -/***************************************************** * Ke386IoSetAccessProcess (NTOSKRNL.EXE.@) */ BOOLEAN WINAPI Ke386IoSetAccessProcess(PEPROCESS *process, ULONG flag) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Be careful of reading health books, you might die of a misprint. -- Mark Twain

2 1

Re: [11/11] windowscodecs: Implement GetMetadataFormat. Resend.
by Dmitry Timoshkov June 14, 2012

June 14, 2012

Please ignore this patch, it doesn't really belong to this series, and correct implementation should use MetadataReaderInfo interface instead. -- Dmitry.

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19010 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19009 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19007 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] windowscodecs: Add stub IWICMetadataBlockReader to PNG decoder.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19006 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.
by Nikolay Sivov June 13, 2012

June 13, 2012

On 6/12/2012 11:52, Ulrik Dickow wrote: > Patch 1 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . > > > > +static void test_namespaces_change(int doc_version) > +{ > + IXMLDOMDocument *doc; > + IXMLDOMElement *elem; > + IXMLDOMNode *node; > + > + VARIANT var; > + HRESULT hr; > + BSTR str; > + > + /* create on element and try to alter namespace after that */ > + doc = (doc_version == 0 ? > + create_document(&IID_IXMLDOMDocument) : > + create_document_version(60, &IID_IXMLDOMDocument)); > + if (!doc) return; Please use something like CLSID array with every available Document CLSID, instead of only testing 2 of them. There's a lot of examples for that in saxreader.c. > + test_namespaces_change(0); > + test_namespaces_change(60); > > free_bstrs(); > } It's better to avoid nested test calls like that imho, you could just add another call in main test list. > +static void test_namespaces_change(int doc_version) > +{ > + IXMLDOMDocument *doc; > + IXMLDOMElement *elem; > + IXMLDOMNode *node; ... > + > + IXMLDOMElement_Release(elem); > + IXMLDOMDocument_Release(doc); > +} > + When this is running on all CLSIDs please add free_bstrs() here.

3 4

Re: d3dx9_36: D3DXQuaternionLn computes as if the norm of the input is 1
by Matteo Bruni June 13, 2012

June 13, 2012

2012/6/12 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > > + if ( (pq->w >= 1.0f) || (pq->w == -1.0f) ) I think the second comparison should be '<=', if you want to avoid getting NaNs.

2 2

Re: wined3d: Avoid sizeof on structs with variable length arrays.
by Henri Verbeet June 13, 2012

June 13, 2012

On 13 June 2012 10:41, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, FIELD_OFFSET(struct wined3d, adapters[1])); That's not really a VLA, just a somewhat stupid array of size 1.

2 2

Misspelt Portuguese in msvcrt
by Francois Gouget June 13, 2012

June 13, 2012

Is there a reason why Portuguese is misspelt in these two places? diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index 97b82ec..b26a9c8 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -85,7 +85,7 @@ static const char * const _country_synonyms[] = "german-swiss", "des", "italian-swiss", "its", "german-austrian", "dea", - "portugese", "ptb", + "portuguese", "ptb", "portuguese-brazil", "ptb", "spanish-mexican", "esm", "norwegian-bokmal", "nor", diff --git a/dlls/msvcrt/tests/locale.c b/dlls/msvcrt/tests/locale.c index 8d6a34f..638a3d2 100644 --- a/dlls/msvcrt/tests/locale.c +++ b/dlls/msvcrt/tests/locale.c @@ -472,7 +472,7 @@ static void test_setlocale(void) if(ret) ok(!strcmp(ret, "Polish_Poland.1250"), "ret = %s\n", ret); - ret = setlocale(LC_ALL, "portugese"); + ret = setlocale(LC_ALL, "portuguese"); ok(ret != NULL || broken (ret == NULL), "ret == NULL\n"); if(ret) ok(!strcmp(ret, "Portuguese_Brazil.1252"), "ret = %s\n", ret); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ E-Voting: Those who cast the votes decide nothing. Those who count the votes decide everything.

2 1

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 3).
by Jacek Caban June 13, 2012

June 13, 2012

Hi Erich, On 06/12/12 19:03, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and some additional cleanup. It is important to > note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. Many > apologizes to Jacek Caban for missing some of his comments in his > original reply. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. The patch looks much better. There is one remaining problem: + int pos = sizeof(html_encoded_symbols)/sizeof(html_encoded_symbols[0]); + float step = pos/2; + int dir = +1; + + do + { + const char *encoded_symbol; + + pos += -dir*ceil(step); Using float here is definitely not needed, esp. that you always use ceil() on it. You've made it more complicated than it really is. See [1] for an example. Also feel free to send linear search with FIXME comment. That's fine for the first iteration patch. Jacek [1] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/mshtml/dispex.c#l709

1 0

Re: [11/11] windowscodecs: Implement GetMetadataFormat.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18989 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd

1 0

Re: [10/11] windowscodecs: Handle IFD fields with count 0 same way as with count 1.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18988 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd

1 0

Re: [09/11] windowscodecs: Add support for IFD_UNDEFINED field type.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18987 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd

1 0

Re: [08/11] windowscodecs: Add tests for more types of IFD fields.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18986 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd

1 0

Re: po: Update Russian translation (try 3) (resend)
by Francois Gouget June 13, 2012

June 13, 2012

msgid "KeyID=" -msgstr "Код ключа=" +msgstr "Код ключа: " [...] msgid "Other Name=" -msgstr "Другое имя=" +msgstr "Альтернативное имя: " and many more like this. Why did you not fix this? Replacing the equal sign with a colon looks wrong to me but then I don't speak Russian. Still I have not seen anything to suggest that the typographic rules would be different in this regard. But Nikolay Sivov, who speaks Russian, seems to concur. Note that this was reported to you back in May: http://www.winehq.org/pipermail/wine-devel/2012-May/095672.html -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

1 0

Re: [PATCH 4/5] wined3d: Set undefined vertex attributes to 0.0.
by Stefan Dösinger June 12, 2012

June 12, 2012

Am Dienstag, 12. Juni 2012, 17:03:49 schrieb Henri Verbeet: > + if (state->vertex_shader->reg_maps.input_registers & (1 << i)) > + GL_EXTCALL(glVertexAttrib4fARB(i, 0.0f, 0.0f, 0.0f, 0.0f)); Does an application need this? Afair Windows drivers have implementation- specific behavior here that pretty much matches their GL counterparts.

1 0

re: Command line parameters
by Dan Kegel June 12, 2012

June 12, 2012

John asked > [ How do I launch Windows apps from Unix apps and pass filenames to them?] > execl (the_path_to_wine, "wine", path_to_the_windows_program, command_line_parameter_for_windows_app, NULL); Relative unix paths will often work with Windows apps, but in general, you will have to translate command_line_parameter_for_windows_app, and any paths that appear in data files, from Unix to Windows before launching the app. The winepath utility may help there, or you can translate them yourself once you know how Wine maps filenames. Also, I recall being in a situation where I had to put the commandline in a batch file and do wine cmd.exe /c foo.bat because there wasn't another other way to make the windows app happy... something about the commandline that made me need to use CreateProcess, and cmd.exe was the easiest way to use CreateProcess. - Dan

5 10

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 2).
by Jacek Caban June 12, 2012

June 12, 2012

Hi Erich, On 06/11/12 21:01, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control. It is important > to note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. You didn't address most of my comments. Feel free to ask for clarifications if something was not clear enough. Jacek

2 1

Re: configure.ac: Get the needed libs from cups-config (for OpenBSD)
by Alexandre Julliard June 12, 2012

June 12, 2012

André Hentschel <nerv(a)dawncrow.de> writes: > Inspired by Matias Colli, see bug 17896. > I made sure it doesn't hurt on other OS and send it because it doesn't seem he will do it and it's a oneliner. It doesn't work for me on Debian testing, not without manually creating symlinks for the libs that cups-config requires. It sounds like OpenBSD should fix their libcups build. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ntprint: Do not fail when the spooler service was stopped
by Alexandre Julliard June 12, 2012

June 12, 2012

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -88,22 +92,25 @@ static void test_PSetupDestroyMonitorInfo(VOID) > { > HANDLE mi; > > - > SetLastError(0xdeadbeef); > pPSetupDestroyMonitorInfo(NULL); > - /* lasterror is returned */ > - trace("returned with %u\n", GetLastError()); > + /* lasterror is untouched */ > + ok(GetLastError() == 0xdeadbeef, "returned with 0x%x\n", GetLastError()); Testing last error on success is not useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] msi/tests: Use only uppercase characters for the PID_REVNUMBER property.
by Marvin June 12, 2012

June 12, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18972 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH] loader: On Mac OS, don't use external symbols for the DOS and shared heap segments.
by Alexandre Julliard June 11, 2012

June 11, 2012

Charles Davis <cdavis(a)mymail.mines.edu> writes: > My first idea was to just add some '.globl' directives in the code. But > then I asked myself: why are we using an indirect symbol at all? Why are > we treating this like an external symbol when it clearly isn't? So now, > the arrays are declared static, and their owning section is explicitly > declared to the C compiler. While compile times have gone up, at least > the compiled loader executable actually works. This core dumps instantly when build with gcc on Mac OS 10.5, and doesn't even compile on 10.6. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] winspool: Install the ppd files into the driver directory.
by Alexandre Julliard June 11, 2012

June 11, 2012

Huw Davies <huw(a)codeweavers.com> writes: > @@ -488,18 +638,70 @@ static void *cupshandle; > DO_FUNC(cupsGetPPD); \ > DO_FUNC(cupsParseOptions); \ > DO_FUNC(cupsPrintFile); > +#define CUPS_OPT_FUNCS \ > + DO_FUNC(cupsGetPPD3); > > #define DO_FUNC(f) static typeof(f) *p##f > CUPS_FUNCS; > +CUPS_OPT_FUNCS; > #undef DO_FUNC This still requires the function to be defined: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_SPOOL32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/usr/local/include/freetype2 -I/usr/local/include -g -O2 -o info.o info.c info.c:732: error: 'cupsGetPPD3' undeclared here (not in a function) info.c:732: warning: type defaults to 'int' in declaration of 'pcupsGetPPD3' info.c: In function 'cupsGetPPD3_wrapper': info.c:741: error: called object 'pcupsGetPPD3' is not a function info.c: In function 'get_cups_ppd': info.c:771: error: 'CUPS_HTTP_DEFAULT' undeclared (first use in this function) info.c:771: error: (Each undeclared identifier is reported only once info.c:771: error: for each function it appears in.) make[1]: *** [info.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: po: Update Russian translation (try 3) (resend)
by Nikolay Sivov June 11, 2012

June 11, 2012

On 6/9/2012 07:43, Oleg Yarigin wrote: > To avoid encode breaks I send a patch as an attachment. > > I packed it into *.GZ archive, becouse (I suppose so) some > intermediate servers can block messages with big attachments. > > Please split it to several patches with changes grouped by some criteria, it's really hard to review when it's that long.

1 0

Re: po: Update Italian translation
by Matteo Bruni June 11, 2012

June 11, 2012

Hi Luca, just a couple of nitpicks: -"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a href=" -"\"http://wiki.winehq.org/Gecko\">http://wiki.winehq.org/Gecko</a> per i " -"dettagli." +"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a " +"href=\"http://wiki.winehq.org/Mono\">http://wiki.winehq.org/Mono</a> " +"per i dettagli." This sounds a bit awkward, I'd go for something like "Nota: si raccomanda di usare i pacchetti forniti dalla tua distribuzione." #: cryptui.rc:413 -#, fuzzy -#| msgid "&Personal Information Exchange/PKCS #12 (.pfx)" msgid "&Personal Information Exchange/PKCS #12 (*.pfx)" -msgstr "Scambia di Informazioni &Personali/PKCS #12 (.pfx)" +msgstr "Scambia di Informazioni &Personali/PKCS #12 (*.pfx)" "Scambio". #: joy.rc:33 msgid "Joysticks" -msgstr "" +msgstr "Joysticks" I'm quite sure foreign words are always wrote in singular form in Italian language, so this would be "Joystick".

1 0

Re: [1/4] msi: Add support for 64-bit registry components. (resend)
by Marvin June 11, 2012

June 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18942 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH 1/4] kernel32/tests: Move a cdrom test to its own file
by Alexandre Julliard June 11, 2012

June 11, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > The cdrom test file will be used to test ioctl (results, structure size...) > Each drive is tested and skipped gracefully if ioctl not supported or not a CDROM drive. I don't see a need for a new file, particularly since disk extents are not CDROM-specific. But even DVD ioctls can be tested in volume.c. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Alexandre Julliard June 11, 2012

June 11, 2012

Andrew Eikum <aeikum(a)codeweavers.com> writes: > There's a lengthy comment in ready_pulse() describing why we're using > pthreads syncro primitives instead of Win32 primitives. I was under > the impression (thanks to the CoreAudio driver, mostly) that threads > not created through CreateThread() cannot use CRITICAL_SECTION, ERR, > WARN, TRACE, and so on. However, when I was testing, I noticed that > debug printing _does_ work in callbacks from the pthread thread. You can't do that, you need to create a proper Win32 thread, and solve the loader lock issue some other way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] loader: On Mac OS, don't emit a __PAGEZERO segment.
by Alexandre Julliard June 11, 2012

June 11, 2012

Charles Davis <cdavis(a)mymail.mines.edu> writes: > This is the reason we couldn't put the WINE_DOS segment at address 0. We don't need page zero, we don't run DOS apps on the Mac. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2 resend] wininet: Added InternetGetSecurityInfoByURL tests
by Marvin June 11, 2012

June 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18940 Your paranoid android. === W2K8SE (32 bit http) === http.c:533: Test failed: req_error = 12007 http.c:544: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:557: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:558: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:559: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:560: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:569: Test failed: flags = 8, expected 0 http.c:657: Test failed: Returned zero size in response to request complete http.c:269: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:533: Test failed: req_error = 12007 http.c:557: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:558: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:559: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:560: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:562: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:569: Test failed: flags = 8, expected 0 http.c:583: Test failed: Wrong URL http://test.winehq.org/tests/redirect http.c:657: Test failed: Returned zero size in response to request complete http.c:269: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:269: Test failed: unexpected status 11 (INTERNET_STATUS_NAME_RESOLVED)

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Dmitry Timoshkov June 11, 2012

June 11, 2012

Andrew Eikum <aeikum(a)codeweavers.com> wrote: > configure.ac | 31 +- > dlls/mmdevapi/main.c | 4 +- > dlls/winepulse.drv/Makefile.in | 9 + > dlls/winepulse.drv/mmdevdrv.c | 3216 +++++++++++++++++++++++++++++++++ > dlls/winepulse.drv/winepulse.drv.spec | 5 + > 5 files changed, 3261 insertions(+), 4 deletions(-) > create mode 100644 dlls/winepulse.drv/Makefile.in > create mode 100644 dlls/winepulse.drv/mmdevdrv.c > create mode 100644 dlls/winepulse.drv/winepulse.drv.spec How does it follow the Alexandre's requirement to split the patch into smaller pieces before submitting? -- Dmitry.

1 0

Re: [PATCH] kernel32: Don't use putenv(3) on temporary strings.
by Ken Thomases June 10, 2012

June 10, 2012

The putenv() calls occur in a forked grandchild process just before an exec(). The strings are sure to survive the current process image. After that, it's the kernel's problem. Regards, Ken On Jun 10, 2012, at 11:47 AM, Charles Davis wrote: > The Darwin manpage for putenv() warns that it no longer makes a copy of > its input, but directly stores the pointer in environ. Wine was passing > stack- and heap-allocated strings to putenv(), which could have caused a > crash. We were very lucky it didn't. Instead, use setenv(3), which still > copies its inputs. > > Found while tracking down an insidious bug in Clang-built optimized > (-O2) Wine. > --- > dlls/kernel32/process.c | 24 +++++++++++------------- > 1 files changed, 11 insertions(+), 13 deletions(-) > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index 42716c2..1ec3e3d 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -1741,17 +1741,14 @@ static const char *get_alternate_loader( char **ret_env ) > int len = strlen( loader_env ); > if (!is_win64) > { > - if (!(env = HeapAlloc( GetProcessHeap(), 0, sizeof("WINELOADER=") + len + 2 ))) return NULL; > - strcpy( env, "WINELOADER=" ); > - strcat( env, loader_env ); > + if (!(env = HeapAlloc( GetProcessHeap(), 0, len + 2 ))) return NULL; > + strcpy( env, loader_env ); > strcat( env, "64" ); > } > else > { > - if (!(env = HeapAlloc( GetProcessHeap(), 0, sizeof("WINELOADER=") + len ))) return NULL; > - strcpy( env, "WINELOADER=" ); > - strcat( env, loader_env ); > - len += sizeof("WINELOADER=") - 1; > + if (!(env = HeapAlloc( GetProcessHeap(), 0, len ))) return NULL; > + strcpy( env, loader_env ); > if (!strcmp( env + len - 2, "64" )) env[len - 2] = 0; > } > if (!loader) > @@ -1860,14 +1857,14 @@ static pid_t exec_loader( LPCWSTR cmd_line, unsigned int flags, int socketfd, > /* Reset signals that we previously set to SIG_IGN */ > signal( SIGPIPE, SIG_DFL ); > > - sprintf( socket_env, "WINESERVERSOCKET=%u", socketfd ); > - sprintf( preloader_reserve, "WINEPRELOADRESERVE=%lx-%lx", > + sprintf( socket_env, "%u", socketfd ); > + sprintf( preloader_reserve, "%lx-%lx", > (unsigned long)binary_info->res_start, (unsigned long)binary_info->res_end ); > > - putenv( preloader_reserve ); > - putenv( socket_env ); > - if (winedebug) putenv( winedebug ); > - if (wineloader) putenv( wineloader ); > + setenv( "WINESERVERSOCKET", socket_env, 1 ); > + setenv( "WINEPRELOADRESERVE", preloader_reserve, 1 ); > + if (winedebug) setenv( "WINEDEBUG", winedebug, 1 ); > + if (wineloader) setenv( "WINELOADER", wineloader, 1 ); > if (unixdir) chdir(unixdir); > > if (argv) > @@ -1976,6 +1973,7 @@ static BOOL create_process( HANDLE hFile, LPCWSTR filename, LPWSTR cmd_line, LPW > static const WCHAR WINEDEBUG[] = {'W','I','N','E','D','E','B','U','G','=',0}; > if (!winedebug && !strncmpW( env_end, WINEDEBUG, sizeof(WINEDEBUG)/sizeof(WCHAR) - 1 )) > { > + env_end += sizeof(WINEDEBUG)/sizeof(WCHAR) - 1; > DWORD len = WideCharToMultiByte( CP_UNIXCP, 0, env_end, -1, NULL, 0, NULL, NULL ); > if ((winedebug = HeapAlloc( GetProcessHeap(), 0, len ))) > WideCharToMultiByte( CP_UNIXCP, 0, env_end, -1, winedebug, len, NULL, NULL ); > -- > 1.7.5.4 > > >

1 0

Re: [PATCH 4/4] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdCopyrightDescriptor) test
by Marvin June 10, 2012

June 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18927 Your paranoid android. === W2KPROSP4 (32 bit cdrom) === cdrom.c:85: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87

1 0

Re: [PATCH 3/4] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) test
by Marvin June 10, 2012

June 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18926 Your paranoid android. === W2KPROSP4 (32 bit cdrom) === cdrom.c:84: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87

1 0

Re: [PATCH 1/5] hhctrl.ocx: Add HTML to Unicode parsing capability.
by Jacek Caban June 10, 2012

June 10, 2012

Hi Erich, On 06/07/12 23:09, Erich E. Hoover wrote: > + /* Post the HTML text to the document */ > + array = SafeArrayCreateVector(VT_VARIANT, 0, 1); > + if(!array) > + goto cleanup; > + hr = SafeArrayAccessData(array, (LPVOID*)&array_param); > + if (FAILED(hr)) > + goto cleanup; > + V_VT(array_param) = VT_BSTR; > + V_BSTR(array_param) = SysAllocString(html_fragment); > + hr = SafeArrayUnaccessData(array); > + if (FAILED(hr)) > + goto cleanup; > + hr = IHTMLDocument2_write(html_parsing_doc, array); Did you test indexes like '<script>alert("really!?")</script>' ? :) Seriously, HTMLDocument is not the right tool for the job. Cheers, Jacek

2 4

Re: Patch 1/2 - [scrrun] - Add initial support for Dictionary - try 2
by Jacek Caban June 10, 2012

June 10, 2012

Hi Vijay, On 06/08/12 03:15, Vijay Kiran Kamuju wrote: > + *ppvObject = NULL; > + if ( IsEqualGUID( riid, &IID_IDictionary ) || > + IsEqualGUID( riid, &IID_IPersist ) || > + IsEqualGUID( riid, &IID_IDispatch ) || > + IsEqualGUID( riid, &IID_IUnknown ) ) > + { > + *ppvObject = This; > + } That's not the right way to cast object to interface. See http://wiki.winehq.org/COMGuideline Cheers, Jacek

2 2

joy.cpl icon
by Joel Holdsworth June 10, 2012

June 10, 2012

Hi All, I've just submitted an icon for joy.cpl to wine-patches. Unfortunatly I've uncovered a problem with the buildimage script. When I first wrote the script, I used the "rsvg" command to convert svg to png. rsvg has been depreciated in favour of rsvg-convert, which has slightly different semantics: rsvg-convert in.svg > out.png instead of rsvg in.svg out.png Moving over to rsvg-convert is trivial of course, except one question. Is it present on enough platforms? I'm using Ubunut 12.04. Is maintainer mode meant to work on Debian Squeeze? We could support both, but I'd rather not do that. Joel

2 1

re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.
by Dan Kegel June 8, 2012

June 8, 2012

-#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) +#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (defined(HAVE_STRUCT_IPSTAT_IPS_TOTAL) || defined(HAVE_STRUCT_IP_STATS_IPS_TOTAL)) Isn't this a no-op? I thought that an undefined symbol was treated as false by the preprocessor. When I compile #if defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) defined #else not defined #endif with gcc -E or cl /E, I get not defined

3 4

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests
by Alexandre Julliard June 8, 2012

June 8, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/wininet/tests/Makefile.in | 2 +- > dlls/wininet/tests/http.c | 38 > ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 39 insertions(+), 1 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:3020: Test failed: InternetGetSecurityInfoByURLA returned: 1(12028), exected 12028 http.c:3153: Test failed: InternetGetSecurityInfoByURLA returned: 1(997), exected 12028 make[1]: *** [http.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests
by Marvin June 8, 2012

June 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18903 Your paranoid android. === W7PROX64 (32 bit http) === http.c:3293: Test failed: HttpSendRequest failed: 12002

2 1

Re: msxml3: Implement IXMLParser Get/Set Flags
by Marvin June 8, 2012

June 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18891 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [PATCH 4/4] mshtml: Added IWindowForBindingUI tests
by Marvin June 8, 2012

June 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18890 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/4] windowscodecs: Add WICIfdMetadataReader registration. Resend.
by Marvin June 8, 2012

June 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18888 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Re: Patch 2/2 - [scrrun] - Add initial tests for Dictionary - resend
by Marvin June 8, 2012

June 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18875 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 1/1] shell32: Fix FindExecutable search path when a default directory is supplied.
by Marvin June 7, 2012

June 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18869 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1336: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\System32\notepad.exe] shlexec.c:1342: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\System32\notepad.exe] === W2KPROSP4 (32 bit shlexec) === shlexec.c:1336: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\system32\notepad.exe] shlexec.c:1342: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\system32\notepad.exe]

1 0

Re: [4/5] propsys: Implement IPropertyStoreCache::SetState.
by Marvin June 7, 2012

June 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18853 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/5] propsys: Implement IPropertyStoreCache::GetValueAndState.
by Marvin June 7, 2012

June 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18852 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] propsys: Implement IPropertyStoreCache::GetState.
by Marvin June 7, 2012

June 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18851 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] windowscodecs: Implement a better stub for MetadataHandler_GetCount.
by Vincent Povirk June 7, 2012

June 7, 2012

It should be trivial to implement this correctly. On Wed, Jun 6, 2012 at 11:21 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/windowscodecs/metadatahandler.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/windowscodecs/metadatahandler.c b/dlls/windowscodecs/metadatahandler.c > index 013fe04..0ea404b 100644 > --- a/dlls/windowscodecs/metadatahandler.c > +++ b/dlls/windowscodecs/metadatahandler.c > @@ -152,7 +152,8 @@ static HRESULT WINAPI MetadataHandler_GetCount(IWICMetadataWriter *iface, > if (!pcCount) return E_INVALIDARG; > > FIXME("(%p,%p): stub\n", iface, pcCount); > - return E_NOTIMPL; > + *pcCount = 0; > + return S_OK; > } > > static HRESULT WINAPI MetadataHandler_GetValueByIndex(IWICMetadataWriter *iface, > -- > 1.7.10.1 > > >

2 1

Re: [PATCH 1/7] urlmon: Use file content to verify MIME type reported by file protocol handler
by Jacek Caban June 7, 2012

June 7, 2012

On 06/07/12 15:40, Jacek Caban wrote: > --- > dlls/urlmon/file.c | 8 +++++++- > dlls/urlmon/tests/protocol.c | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletions(-) > Please skip this one. I didn't mean to send it in the series. Thanks, Jacek

1 0

Re: mscoree: Use .NET 2.0 for 1.0 assemblies
by Vincent Povirk June 7, 2012

June 7, 2012

I was planning to do something like this eventually, as I was advised on #mono this was the way to go, but I didn't expect it to be that simple. +1. On Thu, Jun 7, 2012 at 4:27 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Mono will use .NET 2.0 when a .NET 1.0/1.1 application is run. > > http://www.mono-project.com/Release_Notes_Mono_2.8 > Find: Removed .NET 1.1 Profile > > > Changelog: > mscoree: Use .NET 2.0 for 1.0 assemblies > > > Best Regards > Alistair Leslie-Hughes > > >

1 0

Re: po: Update Russian translation (try 2)
by Nikolay Sivov June 7, 2012

June 7, 2012

On 6/5/2012 11:16, Архад wrote: Please, configure your mail client to use your real name in sent mails. > > #: appwiz.rc:28 > msgid "Add/Remove Programs" > -msgstr "Установка/удаление программ" > +msgstr "Установка/Удаление программ" Looks better as it is. Only start letter of a sentence supposed to be capital, if it's not a part of some name of course, which is not in this case. > > > #: appwiz.rc:35 shell32.rc:141 shell32.rc:238 regedit.rc:122 winefile.rc:104 > msgid "Name" > -msgstr "Имя" > +msgstr "Название" I don't think so. > > > > #: appwiz.rc:39 > msgid "Programs (*.exe)" > -msgstr "Программы (*.exe)" > +msgstr "Исполняемые файлы (*.exe)" No reason for that. > > #: appwiz.rc:40 avifil32.rc:30 cryptui.rc:80 shell32.rc:196 notepad.rc:73 > #: oleview.rc:101 progman.rc:79 regedit.rc:195 winedbg.rc:39 winhlp32.rc:87 > @@ -248,7 +247,7 @@ msgid "" > "file." > msgstr "" > "Ошибка контрольной суммы загруженного файла. Установка поврежденного файла " > -"отменяется." > +"будет отменена." English string doesn't say that it 'will be aborted', it says 'aborting' which means it's already in process to abort it. > > > > #: comdlg32.rc:157 comdlg32.rc:179 > msgid "&Directories:" > -msgstr "&Каталоги:" > +msgstr "&Папки:" It's better as it is. > > #: comdlg32.rc:160 comdlg32.rc:182 > msgid "List Files of &Type:" > -msgstr "Показывать файлы &типа:" > +msgstr "&Тип файлов:" This doesn't reflect original meaning. > > > > #: comdlg32.rc:282 > msgid "&Red:" > -msgstr "Крас&н:" > +msgstr "Крас&ный:" String length matters for this dialog as I remember. > > > > #: comdlg32.rc:315 comdlg32.rc:336 > msgid "Match &Whole Word Only" > @@ -817,20 +816,18 @@ msgid "" > "File does not exist.\n" > "Do you want to create file?" > msgstr "" > -"Файла не существует.\n" > -"Хотите ли вы его создать?" > +"Файла не существует. Создать?" This supposed to match original line splitting probably. > > > #: comdlg32.rc:68 > msgid "Unknown printer driver." > -msgstr "Неизвестный драйвер принтера." > +msgstr "Неопознанный драйвер принтера." This sounds like 'unknown' from UFO now. > > #: crypt32.rc:55 > msgid "On-line Certificate Status Protocol" > @@ -1371,7 +1367,7 @@ msgstr "Имя SSL-сервера Netscape" > > #: crypt32.rc:67 > msgid "Netscape Comment" > -msgstr "Комментарий Netscape" > +msgstr "Комментарии Netscape" Original word is in singular. ... I'm skipping the rest as it's too much to comment at once, but I think you got the idea how to improve that. Also winerror strings should be left as it is, cause nobody cares much anyway. And please pay attention to actual dialog testing, cause updated strings should fit in.

1 0

Re: Command line parameters
by Hin-Tak Leung June 7, 2012

June 7, 2012

--- On Thu, 7/6/12, John Emmas <johne53(a)tiscali.co.uk> wrote: <snipped> > Is Wine clever enough to realise that the UTF8 string needs to be converted to a locale-specific string, so that the Windows app can understand it? Or does Wine simply pass whatever characters it received, without attempting any translation? Thanks. > John "Use the source, Luke!"... THe relevant code is in dlls/ntdll/file.c and dlls/ntdll/path.c which do the right thing. As a general windows programming note, in windows' land, file path related WIN32 APIs tend to have two variants, those ending with *A, and those ending with *W. The former expects ascii inputs, the latter expects WCHAR (I think it is basically UT16LE). The long answer is that wine leaves the former unchanged (except path separator translation, e.g. from unix "/" to windows "\", adding or removing drive letter prefixes, depending on the direction of translation), but will convert from utf8 to WCHAR for the latter, so that the application itself receives the right thing. It is still up to the application's author to use the right Windows APIs for reading/writing files, and whether the application itself expects ascii file paths or unicode (WCHAR) file paths. The short answer is that wine *does* translate from unix-like to windows-like file paths so that the application receives the right stuff. You have nothing to worry about.

2 1

Command line parameters
by John Emmas June 7, 2012

June 7, 2012

Originally, I was going to post this on wine-users but after I wrote it, it seemed like wine-devel might be more appropriate. Please let me know if I need to re-submit it to wine-users. I understand that Wine is mostly used for running Windows apps on Linux - i.e. in most cases, the user will be launching the Windows app manually. But what about a Linux application that needs to launch a Windows app? What does Wine do (if anything) about command-line parameters..? After using fork() to create a new process, this would be a typical program command to start Wine and the Windows app:- execl (the_path_to_wine, "wine", path_to_the_windows_program, command_line_parameter_for_windows_app, NULL); Notice that execl() passes two command-line parameters to Wine (one of which gets passed to the Windows app). Let's assume this is a file path as that's easy to visualize. In the vast majority of cases, those command-line parameters will get passed to Wine as UTF8 strings. Wine will hopefully understand this when interpreting 'path_to_the_windows_program'. However, Windows programs themselves don't understand UTF8 at all - except for a very limited set of (mostly English) characters. So if that parameter was a file path (e.g. a file that the Windows program needed to open) it would only get understood in an English speaking locale. Non-English characters (accented characters etc) would only get understood if a locale translation takes place. Is Wine clever enough to realise that the UTF8 string needs to be converted to a locale-specific string, so that the Windows app can understand it? Or does Wine simply pass whatever characters it received, without attempting any translation? Thanks. John

1 0

Re: [4/4] windowscodecs: Add WICIfdMetadataReader registration.
by Marvin June 7, 2012

June 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18837 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 2

re: comctl: allow label edit only if treeview style allows editing
by Dan Kegel June 6, 2012

June 6, 2012

> I stopped doing > make test on my machine some time ago Bad developer, no donut :-) > , when I found out that some > tests do consistently fail on my machine (clean prefix or not), and > others consistently hang, thus preventing make test -k. I had the same problem, and wrote a little script to skip the bad tests. It was written for buildbot, but can be run standalone. Try downloading http://winezeug.googlecode.com/svn/trunk/buildbot/dotests.sh and http://winezeug.googlecode.com/svn/trunk/buildbot/dotests_blacklist.txt then run sh dotests.sh goodtests That will skip all the tests known to hang or fail. (The list might be a bit out of date, but it's easy to add new tests to the blacklist.) > I don't install wine-gecko, maybe that's the reason. Run https://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh then you'll never have to install it again. (Until it's updated, anyway.) - Dan

2 1

Re: urlmon: Use file content to verify MIME type reported by file protocol handler
by Alexandre Julliard June 6, 2012

June 6, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/file.c | 8 +++++++- > dlls/urlmon/tests/protocol.c | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so protocol.c && touch protocol.ok protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

1.4 has dropped off the list for AppDB submissions
by Rosanne DiMesio June 6, 2012

June 6, 2012

As of the release of 1.5.5, 1.4 has dropped off the list of Wine versions for which AppDB test reports can be submitted. Can someone please add it to the list of stable releases that are always available in the dropdown list? Until it's put back, users will not be able to submit new test reports for 1.4. We could avoid having this problem every time there's a new stable release if users were allowed to submit test reports for any version. Bugzilla lists every version, I don't see why the AppDB doesn't. -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 2

Re: [PATCH 2/3] server: STATUS_MORE_PROCESSING_REQUIRED does not indicate that an async operation is complete (try 4).
by Alexandre Julliard June 6, 2012

June 6, 2012

"Erich E. Hoover" <compholio(a)gmail.com> writes: > @@ -285,7 +285,9 @@ void async_set_result( struct object *obj, unsigned int status, unsigned int tot > if (async->timeout) remove_timeout_user( async->timeout ); > async->timeout = NULL; > async->status = status; > - if (async->data.cvalue) > + if (status == STATUS_MORE_PROCESSING_REQUIRED) > + async->status = STATUS_PENDING; > + else if (async->data.cvalue) Why are you marking the async pending? That doesn't seem right, it's terminated at that point. -- Alexandre Julliard julliard(a)winehq.org

2 1

http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono
by Dan Kegel June 6, 2012

June 6, 2012

http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh now also installs mono. It should be probably be called wine-install-addons.sh now, maybe I'll rename it that soon. If you have a better idea for the name, let me know. (I've also deprecated the copy that was in winezeug; that one now just tells users to get it from the winetricks repo.)

11 20

Re: windowscodecs: Add a stubbed out IWICMetadataBlockReader to TIFF decoder.
by Vincent Povirk June 6, 2012

June 6, 2012

Looks good. Here are some notes in case you get around to implementing this before I do: I found it very surprising that no metadata handlers seem to implement IWICMetadataBlockReader, while many of them advertise that they can be found in other metadata formats. I'm guessing that metadata handlers return child IWICMetadataReader objects from the IWICMetadataReader interface, but I haven't tested this. It probably doesn't make sense to reimplement GetEnumerator for each decoder, and we should be able to make a common implementation based on the other methods. We should probably implement GetReaderByIndex based on CreateMetadataReaderFromContainer, which I'm guessing expects a copy of the image stream (using IWICStream because we can't use IStream::Clone) seeked to the beginning of some metadata, or a region of the image stream, maybe depending on the container format.

1 0

Re: urlmon: Use file content to verify MIME type reported by file protocol handler
by Marvin June 6, 2012

June 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18815 Your paranoid android. === WXPPROSP3 (32 bit protocol) === protocol.c:1046: Test failed: unexpected call ReportResult protocol.c:1051: Test failed: hrResult = 00000000, expected: 80004004 protocol.c:2838: Test failed: Read failed: 00000001

2 1

Re: [2/2] user32: Add a test to demonstrate the z-order problem for a top level window with a region. Take 2.
by Alexandre Julliard June 6, 2012

June 6, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This version of the test tries harder to avoid races that could cause > the test failures. It's not races, it's failing consistently here, even with your latest version. I don't think you can reliably test expose events processing from a Windows app. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] shell32: do not crash "wine control.exe nonexisting"
by Jacek Caban June 6, 2012

June 6, 2012

Hi Marcus, On 06/06/12 10:17, Marcus Meissner wrote: > Hi, > > wine control.exe joy crashed in this line, as it should be wine control.exe joy.cpl. > > The list is just not setup yet as we fail... > > Ciao, Marcus > --- > dlls/shell32/control.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/shell32/control.c b/dlls/shell32/control.c > index cb080d5..b3eddb6 100644 > --- a/dlls/shell32/control.c > +++ b/dlls/shell32/control.c > @@ -55,7 +55,7 @@ void Control_UnloadApplet(CPlApplet* applet) > } > if (applet->proc) applet->proc(applet->hWnd, CPL_EXIT, 0L, 0L); > FreeLibrary(applet->hModule); > - list_remove( &applet->entry ); > + if (applet->entry.next) list_remove( &applet->entry ); > HeapFree(GetProcessHeap(), 0, applet->cmd); > HeapFree(GetProcessHeap(), 0, applet); > } The way Wine standard list implementation works, it should not be NULL here. It seems that list_init call is missing where the CPlApplet is allocated. Cheers, Jacek

3 6

Re: [PATCH 3/5] d3drm: Handle texture associated with the materail when loading a mesh.
by Alexandre Julliard June 6, 2012

June 6, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/d3drm/meshbuilder.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M d3drm.dll -T ../../.. -p d3drm_test.exe.so d3drm.c && touch d3drm.ok d3drm.c:375: Test failed: No texture should be present wine: Unhandled page fault on write access to 0x00162708 at address 0x68353cb7 (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] msi: Add support for 64-bit registry components.
by Alexandre Julliard June 5, 2012

June 5, 2012

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/msi/action.c | 30 +++++++--- > dlls/msi/msi_main.c | 1 + > dlls/msi/msipriv.h | 1 + > dlls/msi/package.c | 2 - > dlls/msi/tests/install.c | 140 ++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 162 insertions(+), 12 deletions(-) This breaks the Gecko installer on 64-bit for me. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [1/2] user32: Add a test to demonstrate the z-order problem for a top level window with a region.
by Alexandre Julliard June 5, 2012

June 5, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/user32/tests/win.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so ../../../../wine/dlls/user32/tests/win.c && touch win.ok win.c:7111: Test succeeded inside todo block: expected next window 0x400ea, got 0x400ea win.c:7114: Test succeeded inside todo block: expected previous window 0x400f0, got 0x400f0 make[1]: *** [win.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] server: Make sure that region and rectangle have the same origin before calling rect_in_region().
by Alexandre Julliard June 5, 2012

June 5, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -2457,7 +2457,9 @@ DECL_HANDLER(update_window_zorder) > if (!(ptr->style & WS_VISIBLE)) continue; > if (ptr->ex_style & WS_EX_TRANSPARENT) continue; > if (!intersect_rect( &tmp, &ptr->visible_rect, &rect )) continue; > - if (ptr->win_region && !rect_in_region( ptr->win_region, &rect )) continue; > + tmp = rect; > + offset_rect( &tmp, -ptr->client_rect.left, -ptr->client_rect.top ); > + if (ptr->win_region && !rect_in_region( ptr->win_region, &tmp )) continue; The window region is not in client coordinates. -- Alexandre Julliard julliard(a)winehq.org

1 0