June 2012 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: Web based translation tool
by Michal Čihař June 18, 2013

June 18, 2013

Hi Dne Mon, 12 Mar 2012 12:02:49 +0200 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > The Wine project is thinking about using Weblate in order to translate > Wine, you can look at the following discussion and see for yourself. That sounds great! > Looking good although a litle immature, not sure about authentication as > wel... For authentication you can basically use anything what can be used in Django. Any specific concerns on this topic? > I'll talk to Michal Cihar and ask him for a roadmap for this project. Well I don't have any real roadmap right now. I urgently needed replacement for Pootle because we got hit by too many bugs there and did not manage to understand the code there to be able to fix them myself. So far I think it is in pretty good shape for day to day work (with today's 0.5 release fixing few annoying bugs). Of course there are some features missing, you can check what I plan for 1.0 release here: https://github.com/nijel/weblate/issues?state=open&milestone=1 I currently hope to have 1.0 in a month or so, but I really don't want to commit to any specific date. PS: I'm not subscribed to mailing list so please CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

7 16

Re: xbox 360 emulation with logitech cordless and dinput joy disable
by Stefan Dösinger Jan. 1, 2013

Jan. 1, 2013

Hi, The patch needs a few improvements before it can be accepted into Wine. I can't comment on the dinput / xinput specifics of the patch, so this is a non- exhaustive list of general suggestions. Concerning the big picture, this patch needs a few discussions about xinput.dll design. There have been some discussions about that in the past, and I hope that some dinput devs can help out. Am Dienstag, 12. Juni 2012, 23:48:53 schrieb Giovanni Ongaro: > From: root <root(a)joe.(none)> Please configure git correctly, see http://wiki.winehq.org/GitWine section 3.3. Also consider using a non-root user, but that's your personal setup, so not really my business. > + if (getenv("LINIXFORCENOJOY") != NULL) return FALSE; /*JoeFix disable joystick*/ The problem with dinput vs xinput conflicts should probably be solved in a different manner. That aside, such configurations are usually done via registry keys. Also comments like /* I changed this here */ are useless, the git history stores this information anyway. > + <...> //JoeFix DEAD ZONE This is a C++ comment and not allowed in Wine. See http://wiki.winehq.org/SubmittingPatches > + fdJoy=open("/dev/input/js0",O_RDONLY | O_NONBLOCK); Xinput.dll should not open joystick devices directy, and definitely not a hardcoded one. I don't know if there's consensus about how xinput should be implemented, but basing it on top of dinput might be a start. A good start would be to write a few tests to test how Windows announces(or doesn't announce) Xbox gamepads and other gamepads/joysticks to games. My understanding is that xinput.dll only works for Xbox gamepads. Do those show up in dinput on Windows? > +#define DEAD_ZONE 4096 > ... > + if (e.number == 4) { > + if (e.value == 1) { > + FIXME("TRIGGER LEFT PRESSED\n"); > + pState->Gamepad.bLeftTrigger=32767; > + } > + else { > + pState->Gamepad.bLeftTrigger=0; > + } > ... > +#define JOYMAX 30000 > +#define JOYMIN -30000 The hardcoded numbers look questionable. The 4 and 1 are probably specific to the joystick, the 32767 might have a symbolic name like XINPUT_MAX or something. A part of this seems to be needed due to the attempt to emulate an xbox gamepad with a different device. Personally I'm not opposed to doing that, and you might need some device specific tricks to pull this off. However, this needs a more structured approach than hardcoding the values needed for one specific Logitech device in the code. Best regards, Stefan

3 2

Wine automated testing update
by Jeremy White Aug. 6, 2012

Aug. 6, 2012

Hi Folks, At the last Wine conference, I volunteered to find a home for the WineTestBot that Ge's brother has been hosting, and to take over the Buildbot that Dan and Austin have been so diligently maintaining. This is an update on that project, mostly to help keep my procrastinating self moving it along. First, we have a lovely set of hardware; 4 servers, in a dedicated rack, with a dedicated static ip to the outside world. One server is the gateway, 2 are dedicated Linux test systems (with nice fast processor + gpus), and one is a beefy system capable of running many VMs. The plan was to move the existing VMWare based WineTestBot to this hardware and simply get the existing system up and running on the new hardware. Here we hit our first snag; the VMWare folks are not willing to provide a permanent license for VMWare to us. So, we've shifted gears, and are exploring whether something like qemu + kvm would be a sufficient alternate. I've done a little of this work, and Maarten is hopefully going to help me try converting the existing VMs to see if we can save any hassle by doing a conversion. In parallel, I learned a great deal about buildbot and the buildbot system that Dan has built. There are two especially valuable and useful functions provided by this buildbot: the first is essentially a patch watcher; a process that catches simple mistakes (e.g. build errors on different architectures, and so on). The second is more powerful and is encapsulated by the 'dotests.sh' shell script. The dotests.sh script does a good job of basically running make test and noticing any test failures outside of 'the usual ones'. There is an infrastructure for Buildbot is a good tool, and I invested a lot of energy into it (as have Dan and Austin). However, Alexandre has persuaded me that we should first explore integrating the dotest.sh functionality into the existing WineTestBot, as that would allow us to have a very simple clean web page, and would also allow us to integrate most cleanly with Alexandre's back end tools. Of course, WineTestBot is Perl code, and my Perl fu is low. So I have recently asked Francois to help with that effort as well. So the basic plan is as follows: 1. Test qemu/kvm with a few Windows versions to see if it'll work. 2. If so, modify WineTestBot to use qemu instead of vmware. (This is 'easy' because the WineTestBot code nicely isolates the VM functions, but 'hard', because VMWare provides some APIs that may have to be replicated). 3. Migrate WineTestBot to the new hardware stack 4. Write new code to run 'dotests.sh' as part of WineTestBot Cheers, Jeremy

9 11

Re: include: fix mingw64 build
by Nicolas Le Cam July 30, 2012

July 30, 2012

2012/6/29 Austin English <austinenglish(a)gmail.com>: > Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 > > -- > -Austin > > > Hi Austin, I already tried to fix it on Wine side, see [1], but Alexandre told me on IRC that the bug needs to be fixed in mingw-w64, as it shouldn't include crtdefs.h by default. BTW, won't that break mingw32 build ? [1] http://source.winehq.org/patches/data/84070 -- Nicolas Le Cam

4 13

Wine's support for reporting calling conventions
by Roger Cruz July 26, 2012

July 26, 2012

In dlls/dbghelp/dwarf.c, there is this snippet of code which appears to hard-code the calling convention to CALL_FAR_C. Does Wine not support reporting a function's calling convention correctly then? Is it a limitation of DWARF or just that it is not implemented? I can see that DWARF has a DW_AT_calling_convention field but when I examine a Wine DLL with objdump, it does not show this field in use. /* FIXME: assuming C source code */ sig_type = symt_new_function_signature(ctx->module, ret_type, CV_CALL_FAR_C); Thanks Roger

3 5

A copyright question to wine developpers
by Christophe-Marie Duquesne July 26, 2012

July 26, 2012

Hi, To my understanding, wine is a reimplementation of the MS system. As far as I understand, you take MS public headers and reimplement their functions. If that is how it works, then how do you deal with copyright? The MS headers certainly come with a copyright clause: how is it possible to redistribute these headers with wine? The reason why I ask this: I just rewrote an opensource implementation of a closed-source library. This opensource implementation is meant to be fully compatible with the closed source one: I reimplemented all the functions provided by their header, and anyone using the closed source one should be able to use my library as a replacement. My problem, though, is with the distribution of the header: Since I want to be fully compatible with the closed-source implementation, I have to, somehow, use the same header. I could probably modify it so that is *looks* different, but for the compiler, the API *needs* to be the same. Since you seem to have the same problem with wine (and you probably dealt with it succesfully), I wanted to ask you how you are solving this problem. Do you "rewrite" the headers? Do you copy them "raw"? Thank you, Christophe-Marie Duquesne

5 7

Rethinking WineConf
by Jeremy White July 26, 2012

July 26, 2012

Hi All, This past Wine conference, while great fun as always, was not as well attended as Wine conferences in the past. So I would like to stir up trouble by suggesting we rethink WineConf. For those that have not attended, the Wine conference has been a mostly annual affair since 2002. It is open to all, but is advertised as being aimed at Wine developers. About 35 people attend each year. It's been in Minnesota about every 3rd year, and is otherwise 'normally' somewhere in Europe. I see the primary goal as creating human bonds between otherwise anonymous people (aka going to the pub). It's a bonus if it also spurs resolution to tricky issues, or motivates people to get more done. So I'd like to ask folks to brain storm with me. How could Wineconf be different? If you've never been, what would encourage you to come? If you've been to a technical conference recently that you thought was well done, what did they do well? Anything we could emulate? Any other ideas, or suggestions? Cheers, Jeremy

17 25

mshtml: Always set the URL policy in the error cases?
by Francois Gouget July 26, 2012

July 26, 2012

gcc 4.7 is complaining that policy may be used uninitialized in InternetHostSecurityManager_QueryCustomPolicy() and indeed there are many error cases in confirm_safety_load() and confirm_safety() where the policy is not set. The patch belowe seems to plug all these holes but I don't know if it really makes sense. diff --git a/dlls/mshtml/secmgr.c b/dlls/mshtml/secmgr.c index ff349ac..3f64a42 100644 --- a/dlls/mshtml/secmgr.c +++ b/dlls/mshtml/secmgr.c @@ -104,10 +104,9 @@ static HRESULT confirm_safety_load(HTMLDocumentNode *This, struct CONFIRMSAFETY CATID init_catid = CATID_SafeForInitializing; hres = ICatInformation_IsClassOfCategories(This->catmgr, &cs->clsid, 1, &init_catid, 0, NULL); + *ret = hres == S_OK ? URLPOLICY_ALLOW : URLPOLICY_DISALLOW; if(FAILED(hres)) return hres; - - *ret = hres == S_OK ? URLPOLICY_ALLOW : URLPOLICY_DISALLOW; } return S_OK; @@ -157,13 +156,17 @@ static HRESULT confirm_safety(HTMLDocumentNode *This, const WCHAR *url, struct C if(!This->catmgr) { hres = CoCreateInstance(&CLSID_StdComponentCategoriesMgr, NULL, CLSCTX_INPROC_SERVER, &IID_ICatInformation, (void**)&This->catmgr); - if(FAILED(hres)) + if(FAILED(hres)) { + *ret = URLPOLICY_DISALLOW; return hres; + } } hres = ICatInformation_IsClassOfCategories(This->catmgr, &cs->clsid, 1, &scripting_catid, 0, NULL); - if(FAILED(hres)) + if(FAILED(hres)) { + *ret = URLPOLICY_DISALLOW; return hres; + } if(hres != S_OK) { *ret = URLPOLICY_DISALLOW; -- 1.7.10

2 3

Re: mshtml: Set outgoing pass-by-address variable in an error case case within confirm_safety_load.
by Jacek Caban July 18, 2012

July 18, 2012

Hi Gerald, On 03/07/12 23:35, Gerald Pfeifer wrote: > I noticed we return in this case, without initializing this variable. > Visual inspection indicates we do not seem to access the variable in > this error case, but a) better safe than sorry, and b) GCC 4.8 currently > warns about it. > > Not sure URLPOLICY_DISALLOW is the best return value, open for better > alternatives. I generally don't think this patch makes things any better (or worse). If we return an error, the caller should not expect this value to be sane. What's the GCC 4.8 warning? Jacek

2 4

Re: [2/2] msxml3: Support xmlns[:*] attribute nodes intelligently.
by Nikolay Sivov July 8, 2012

July 8, 2012

On 6/12/2012 11:55, Ulrik Dickow wrote: > Patch 2 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . > > > > + /* Emit appropriate fixme or warning in case of unsupported or invalid namespace. > + * The W3C spec would like us to exit earlier for attempts to redefine the namespace for > + * the reserved "xmlns" attribute or prefix (http://www.w3.org/TR/xml-names/#ns-decl) > + * likehttp://gdome2.cs.unibo.it/gtk-doc/gdome2-gdomeelement.html#GDOME-EL-SETATTRIBUTENS, > + * but since native msxml3 accepts anything here, it's safest to just continue with warning. > + */ The question is more like what libxml2 thinks about that. If it follows w3c here which is likely the question will be - won't it break somewhere internally in libxml2 code if we hack it that way? > + if(namespaceURI && namespaceURI[0] && node_type != NODE_ELEMENT) > + { > + if(node_type == NODE_ATTRIBUTE) > + switch((!strcmpW(name, xmlnsW) || > + !strncmpW(name, xmlnscW, sizeof(xmlnscW)/sizeof(WCHAR))) + > + !strcmpW(namespaceURI, w3xmlns)) Could you please simplify that, it's a bit hard to read. > + * Note: We would be more in line with the native msxml if we only detected a > + * redundancy/conflict for prefixes existing on the element itself (in element->ns > + * or in the linked list element->nsDef). But as long as our *_get_xml() doesn't > + * eliminate redundant namespace definitions in children, this behaviour may be > + * an advantage in some cases. As disadvantage is that we incorrectly regard the > + * redefinition in element 'b' in '<a xmlns="x"><b xmlns="y"/></a>' as a conflict. > + * Libxml2 currently doesn't have a function or option to only search for namespaces > + * on the current node; but it would be easy to make a reduced version of xmlSearchNs > + * (currently defined inhttp://git.gnome.org/browse/libxml2/tree/tree.c#n5871) > + * However, most apps probably set the ns to y on node b creation, so no conflict here. > + * I don't think it's better to potentially break one thing while fixing the other. And I guess I like a thought on making xmlSearchNs version that will do what we want from it. Just to clarify - is that right that libxml2 problem here is a lack of some checks that lead to duplication and conflicts later? (that are visible in doc dumps too) > +/* Convenient helper function for creating an attribute node in a given namespace. > + * Note: CHECK_HR() should not be here, but in caller, to give optimal line number info. > + */ You mean EXPECT_HR here I guess. > +static HRESULT create_attribute_ns( > + IXMLDOMDocument *doc, > + const char *attr_name, > + const char *nsURI, > + IXMLDOMAttribute **attr_ptr) > +{ > + HRESULT hr; > + VARIANT var; > + IXMLDOMNode *node; > + > + V_VT(&var) = VT_I1; > + V_I1(&var) = NODE_ATTRIBUTE; > + > + hr = IXMLDOMDocument_createNode(doc, var,_bstr_(attr_name),_bstr_(nsURI), &node); > + if (hr == S_OK) > + { > + IXMLDOMNode_QueryInterface(node, &IID_IXMLDOMAttribute, (void**) attr_ptr); > + IXMLDOMNode_Release(node); > + } > + return hr; > +} Please null out pointer in case of failure, or better always before createNode().

2 4

winebuild port to ARM?
by Roger Cruz July 7, 2012

July 7, 2012

Has anyone worked or is currently working on porting the x86 specific code in Winebuild to ARM? Specifically the relay.c file? Thanks Roger R. Cruz

2 9

[PATCH] winepulse.drv: Add PulseAudio driver
by Joerg-Cyril.Hoehle＠t-systems.com July 4, 2012

July 4, 2012

Hi, >If you don't paste all the mmdevapi tests with the fix in my git tree, it's a >regression. I don't want to see held_Frames because it's a shadow buffer. >If winmm and dsound don't work without it, they're wrong, fix those. I won't comment on the two individual pulseaudio drivers. Unfortunately, none of the two authors bothered to point me to a verbose log of the mmdevapi tests for my scrutiny. The tests should pass like they do on native. Regarding latency, I'm not aware of a flaw in Wine's winmm. HOWEVER, Wine's DSound needs a patch. Here the reason. To recap, latency is somehow related to the "distance" between what one hears and the PCM frames sent to the device. GetPosition is the only API call in that area in both winmm and mmdevapi. Buffer size is a completely different thing. I find it useful to have in mind a cascade of audio filters performing some buffering each. Then it's obvious that an app only sees the frontmost buffer size and knows nothing about the others. High latencies imply that there must be some large buffer space(s), somewhere. Period is an artificial entity related to how often the frontmost buffer is drained to feed the next buffer in the chain, in case that happens regularly. This is not guaranteed nor necessarily documented. You get the idea: regardless of arbitrary (front) buffer sizes and periods not worth this name, try and send a stable flow of data to play music without glitches and let explosions be heard ASAP. So far the situation, now the issue. It appears easier to write code that provides (frontmost) buffer space behaviour similar to native than one that provides similar latency. Alas, behaviour observable on MS-Windows differs from what we get with PulseAudio and some ALSA devices. Tests seem to indicate a latency of around 30-70ms from mmdevapi with MS-Windows. That good enough for games. OTOH if ALSA or PA gives us 2 seconds on Linux, that's a big cause of trouble. The authors of MS apps could never test them in an environment with such high latency. What happens with software not tested? It happens not to work. Two solutions: - Reduce actual latency or - lie about latency. Lying about latency causes apps to loose the ability to sync audio and video. However, given a choice between loss of lip sync and possible crashes or other weird behaviour because an app is executed in a environment that its developers never experienced, I consider the loss of lip sync to be less worrying. We designed the winealsa driver to accomodate an arbitrary latency and accept a large variation of periods. (Some bug report from Jack users seem to imply that it should accept even larger periods, e.g. 150ms, yet still pretend to use 10ms on the mmdevapi side). We choose to have the winealsa driver not lie about latency. That should be left to high level APIs. DirectSound is built around the "Direct" HW (lack of) abstraction: a circular buffer of samples is played by a DAC. The converted signal is immediately sent to the speaker. Hence: 1. GetPosition information in the DSound abstraction translates to a "playpos" -- well known. 2. No provision is made for additional buffering. The playpos must lie within the circular buffer. The reported free (writable) space shall never cross the playpos -- with subtle consequences. Wine's DSound needs a patch to ensure this second property. Given a 80ms primary buffer, Wine's DSound must not pretend its playpos is 2 seconds late! I think Wine should try and reduce latency but lie if that does not suffice. What's needed? 1. Have DSound always use a buffer large enough for typical situations (I believe 100-200ms). 2. Clamp the reported position such that it won't leave the (virtual) primary buffer. As a result, DSound must pretend to play even when Wine is solely pumping the huge 2s of cascading SW audio buffers. 3. Work on reducing the latency of the cascading audio filters. That device-level work is independent on the DSound one. Native's 30-70ms has the benefit that it nicely fits within typical DSound primary buffer sizes. PulseAudio's 2s does not (yet). I believe a total 80ms latency would be acceptable with games. Further areas of investigation and effort: - Maybe clamp latency in the mmdevapi drivers after all? After all, huge latencies are known to cause dead-locks in apps and we don't know what all apps or libraries built atop mmdevapi or winmm expect. (If yes, to what value? 150% buffer size?) - Try and find MS setups with huge latencies. USB headphones are said to be candidates, but I've yet to see an excellent and trustworthy report about what happens in that case. - Work on reducing the cascades of audio buffers - Work on further decoupling mmdevapi periods from UNIX audio API ones - Research the trade-off between glitch free playback and buffering in UNIX. The current settings in Wine's audio are IMHO not good enough yet. Regards, Jörg Höhle

2 1

Re: msvcp90: Fix __cdecl functions definitions that returns structures
by Alexandre Julliard July 2, 2012

July 2, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > In code produced by gcc callee removes hidden return argument. In code > produced by MS Visual Studio caller is responsible for removing the > hidden argument. That's only for structures larger than 8 bytes, which isn't the case at least for _Getcoll. Some tests would probably be a good idea. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2] qedit/tests: Add COM aggregation test for MediaDet.
by Marvin June 30, 2012

June 30, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19677 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401587 === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401587

2 1

Release schedule
by Alexandre Julliard June 30, 2012

June 30, 2012

Folks, Because of various travels and vacations (and just to keep you on your toes ;-), during the month of July I'm planning to make releases on Tuesdays instead of Fridays. So 1.5.8 will be on July 3rd, and then I'll be out for the rest of that week. Subsequent releases should happen on July 17th and 31st, and I'll also be out the first 10 days of August. And if you find this confusing, just take some vacations too ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.
by Michael Stefaniuc June 30, 2012

June 30, 2012

Dmitry, afair the fix is to disable the int truncation warnings in MSVC. For whatever reason they seem to enable those bogus warnings. bye michael On 06/28/2012 12:12 PM, Dmitry Timoshkov wrote: > --- > include/basetsd.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/basetsd.h b/include/basetsd.h > index 698dd5c..4a59897 100644 > --- a/include/basetsd.h > +++ b/include/basetsd.h > @@ -153,12 +153,12 @@ typedef unsigned int UHALF_PTR, *PUHALF_PTR; > > static inline ULONG32 HandleToULong(const void *h) > { > - return (ULONG_PTR)h; > + return (ULONG32)(ULONG_PTR)h; > } > > static inline LONG32 HandleToLong(const void *h) > { > - return (LONG_PTR)h; > + return (LONG32)(LONG_PTR)h; > } > > static inline void *ULongToHandle(ULONG32 ul) > @@ -173,32 +173,32 @@ static inline void *LongToHandle(LONG32 l) > > static inline ULONG32 PtrToUlong(const void *p) > { > - return (ULONG_PTR)p; > + return (ULONG32)(ULONG_PTR)p; > } > > static inline LONG32 PtrToLong(const void *p) > { > - return (LONG_PTR)p; > + return (LONG32)(LONG_PTR)p; > } > > static inline UINT32 PtrToUint(const void *p) > { > - return (UINT_PTR)p; > + return (UINT32)(UINT_PTR)p; > } > > static inline INT32 PtrToInt(const void *p) > { > - return (INT_PTR)p; > + return (INT32)(INT_PTR)p; > } > > static inline UINT16 PtrToUshort(const void *p) > { > - return (ULONG_PTR)p; > + return (UINT16)(ULONG_PTR)p; > } > > static inline INT16 PtrToShort(const void *p) > { > - return (LONG_PTR)p; > + return (INT16)(LONG_PTR)p; > } > > static inline void *IntToPtr(INT32 i)

3 5

Re: windowscodecs: test for TIFFSetWarningHandlerExt
by Alexandre Julliard June 29, 2012

June 29, 2012

Daniel Lehman <dlehman(a)esri.com> writes: > Fails to build on RHEL4 with libtiff 3.6.1 > > Alternative to this is a configure test for libtiff 3.8.0, which is when the function first appears I don't think this needs a configure test. Just define the prototype explicitly instead of using typeof. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] d3dx9: Implement D3DXLoadVolumeFromMemory.
by Matteo Bruni June 29, 2012

June 29, 2012

2012/6/27 Józef Kucia <joseph.kucia(a)gmail.com>: > --- Hi Józef, > +void copy_simple_data(const BYTE *src, UINT srcpitch, SIZE src_size, const PixelFormatDesc *srcformat, > + BYTE *dest, UINT destpitch, SIZE dst_size, const PixelFormatDesc *destformat, D3DCOLOR colorkey) DECLSPEC_HIDDEN; > + You are not actually using this function in the patch. > + if (dst_box->Left > dst_box->Right || dst_box->Right > desc.Width) > + return D3DERR_INVALIDCALL; > + if (dst_box->Top > dst_box->Bottom || dst_box->Bottom > desc.Height) > + return D3DERR_INVALIDCALL; > + if (dst_box->Front > dst_box->Back || dst_box->Back > desc.Depth) > + return D3DERR_INVALIDCALL; > + > + dst_width = dst_box->Right - dst_box->Left; > + dst_height = dst_box->Bottom - dst_box->Top; > + dst_depth = dst_box->Back - dst_box->Front; > + if (!dst_width || !dst_height || !dst_depth) > + return D3DERR_INVALIDCALL; You can avoid the last check by comparing e.g. (dst_box->Left >= dst_box->Right) above, instead of using ">". > + if (src_box->Left & (src_format_desc->block_width - 1) > + || src_box->Top & (src_format_desc->block_height - 1) > + || (src_box->Right & (src_format_desc->block_width - 1) > + && src_width != desc.Width) > + || (src_box->Bottom & (src_format_desc->block_height - 1) > + && src_height != desc.Height)) > + { > + WARN("Source box (%u, %u, %u, %u) is misaligned\n", > + src_box->Left, src_box->Top, src_box->Right, src_box->Bottom); > + return D3DXERR_INVALIDDATA; > + } I'm not quite sure of the right and bottom misalignment checks. If the tests confirm that, of course that's okay. > + for (slice = 0; slice < src_depth; slice++) > + { > + src_addr = src_memory; > + src_addr += slice * src_slice_pitch; Shouldn't you take into account src_box->Front?

2 1

Re: user32: Add test for ComboBox repositioning behavior (try 2).
by Marvin June 29, 2012

June 29, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19658 Your paranoid android. === W7PRO (32 bit msg) === msg.c:8219: Test failed: did not get zero count as expected (1).

2 1

Re: gdiplus: Add a test to show that GdipCloneImage is not supposed to increase refcount of the source image stream, but clone it instead.
by Vincent Povirk June 29, 2012

June 29, 2012

I think it's most likely not keeping the input stream in the new image at all. It's probably also worth testing SelectActiveFrame, GetPropertyItem, and GetImageRawFormat with clones of images. Maybe they don't work.

2 1

Re: wbemprox: Add a Win32_LogicalDisk class stub.
by Hans Leidekker June 28, 2012

June 28, 2012

On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote: > +static void fill_logicaldisk( struct table *table ) > +{ > + static const WCHAR caption[] = > + {'C',':',0}; > + static const WCHAR description[] = > + {'L','o','c','a','l',' ','F','i','x','e','d',' ','D','i','s','k',0}; > + static const WCHAR device_id[] = > + {'C',':',0}; > + struct record_logicaldisk *rec; > + FIXME("returns a fake logical disks table\n"); > + if (!(table->data = heap_alloc( sizeof(*rec) ))) > + { > + return; > + } > + rec = (struct record_logicaldisk *)(table->data); > + rec->caption = caption; > + rec->description = description; > + rec->device_id = device_id; > + table->num_rows = 1; > + TRACE("created %u row(s)\n", table->num_rows); That's better. Does NFS actually query the Caption and Description properties?

2 4

Re: user32: Add a test for ComboBox WM_WINDOWPOSCHANGED handling.
by Alexandre Julliard June 28, 2012

June 28, 2012

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -5807,6 +5830,25 @@ static void test_combobox_messages(void) > log_all_parent_messages--; > ok_sequence(WmKeyDownComboSeq, "WM_KEYDOWN/VK_DOWN on a ComboBox", FALSE); > > + wp.hwnd = combo; > + wp.hwndInsertAfter = HWND_TOP; > + wp.cx = wp.cy = wp.x = wp.y = 50; > + wp.flags = 0; > + flush_sequence(); > + SendMessage(combo, WM_WINDOWPOSCHANGED, 0, (LPARAM)&wp); It doesn't make much sense to send this message directly. What are you trying to test? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] gdiplus: Increase refcount of the source stream when loading a bitmap instead of cloning it.
by Vincent Povirk June 28, 2012

June 28, 2012

This looks good to me. (I didn't think it was necessary to comment, but this is an important fix and I was surprised it was still New.)

1 0

Unused msvcp60 functions
by Francois Gouget June 28, 2012

June 28, 2012

I get the following warnings when compiling msvcp60: main.c:108:51: warning: ‘std_BADOFF_func’ defined but not used [-Wunused-function] misc.c:66:40: warning: ‘mutex_mutex_lock’ defined but not used [-Wunused-function] misc.c:73:40: warning: ‘mutex_mutex_unlock’ defined but not used [-Wunused-function] misc.c:80:40: warning: ‘mutex_mutex_ctor’ defined but not used [-Wunused-function] misc.c:87:40: warning: ‘mutex_mutex_dtor’ defined but not used [-Wunused-function] misc.c:175:58: warning: ‘set_new_handler_reset’ defined but not used [-Wunused-function] Indeed msvcp60.spec contains no _BADOFF, _Mutex or set_new_handler function. I don't see them in my 'database' of exported Windows APIs for msvcp60 but maybe the Windows dlls I built it from where not entirely up to date. Still it looks like these were added in later revisions and thus can be removed from the above files. misc.c:127:50: warning: ‘wctype’ defined but not used [-Wunused-function] This one is actually forwarded to msvcp90 according to msvcp60.spec, thus making this implementation redundant. So it should either be removed or msvcp60.spec should be modified. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Only wimps use tape backup: _real_ men just upload their important stuff on ftp, and let the rest of the world mirror it ;)" -- Linus Torvalds

2 3

Re: windowscodecs: Make sure that stream is not reused once the decoder is initialized.
by Vincent Povirk June 28, 2012

June 28, 2012

Looks good to me.

1 0

Re: kernel32/tests: Remove an unused variable in the sync tests.
by Marvin June 28, 2012

June 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19638 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] d3dx9: Implement D3DXCreateVolumeTextureFromFileInMemoryEx.
by Matteo Bruni June 28, 2012

June 28, 2012

2012/6/27 Józef Kucia <joseph.kucia(a)gmail.com>: > --- > + for (mip_level = 0; mip_level < mip_levels; mip_level++) > + { > + hr = calculate_dds_surface_size(src_info, width, height, &src_pitch, &mip_level_size); > + if (FAILED(hr)) return hr; ... > + hr = D3DXLoadVolumeFromMemory(volume, palette, NULL, pixels, src_info->Format, > + src_pitch, mip_level_size, NULL, &box, filter, color_key); mip_level_size would be the source slice pitch, right? I'd just call it like that.

1 0

Re: [2/2] msvcp90: Sync spec files
by Owen Rudge June 28, 2012

June 28, 2012

On 28/06/2012 11:33, Owen Rudge wrote: > --- > dlls/msvcp60/msvcp60.spec | 638 > ++++++++++++++++++++++---------------------- Sorry, I ran the make_specfiles script without realising that msvcp60.spec shouldn't have been updated. I've resent the patch without these changes. -- Owen Rudge http://www.owenrudge.net/

1 0

Re: [2/2] msvcp90: Sync spec files
by Piotr Caban June 28, 2012

June 28, 2012

First patch looks correct. On 06/28/12 12:33, Owen Rudge wrote: > dlls/msvcp60/msvcp60.spec | 638 > ++++++++++++++++++++++---------------------- You can't update msvcp60.spec file this way (most of functions there should not be forwarded to msvcp90).

1 0

Re: po: add missing url tag to nl.po
by Francois Gouget June 28, 2012

June 28, 2012

On Wed, 27 Jun 2012, Austin English wrote: > http://bugs.winehq.org/show_bug.cgi?id=31038 "Noot: Het wordt aanbevolen om distributiepakketten te gebruiken. Zie <a " -"href=http://wiki.winehq.org/Gecko voor details." +"href=http://wiki.winehq.org/Gecko</a> voor details." Note that this is missing a lot more than just </a>. This should be: "Noot: Het wordt aanbevolen om distributiepakketten te gebruiken. Zie <a " "href=\"http://wiki.winehq.org/Gecko\">http://wiki.winehq.org/Gecko</a> voor details." Fortunately it looks like nl is the only such case. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A polar bear is a cartesian bear after a coordinate transform.

1 0

Re: [1/5] windowscodecs: Implement MetadataHandler_GetValue. Take 2. Resend.
by Marvin June 28, 2012

June 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19631 Your paranoid android. === WVISTAADM (32 bit metadata) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [4/5] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem. Take 2.
by Marvin June 28, 2012

June 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19625 Your paranoid android. === W7PROX64 (64 bit image) === image.c:2817: Test failed: 0: expected property size 17 or 36, got 44 image.c:2817: Test failed: 2: expected property size 144 or 0, got 152 image.c:2817: Test failed: 3: expected property size 20 or 0, got 28 === TEST64_W7SP1 (64 bit image) === image.c:2817: Test failed: 0: expected property size 17 or 36, got 44 image.c:2817: Test failed: 2: expected property size 144 or 0, got 152 image.c:2817: Test failed: 3: expected property size 20 or 0, got 28

2 1

Re: [5/5] gdiplus: Add a bunch of tests for TIFF image properties. Resend.
by Marvin June 28, 2012

June 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19626 Your paranoid android. === W7PROX64 (64 bit image) === image.c:2818: Test failed: 0: expected property size 17 or 36, got 44 image.c:2818: Test failed: 2: expected property size 144 or 0, got 152 image.c:2818: Test failed: 3: expected property size 20 or 0, got 28 === TEST64_W7SP1 (64 bit image) === image.c:2818: Test failed: 0: expected property size 17 or 36, got 44 image.c:2818: Test failed: 2: expected property size 144 or 0, got 152 image.c:2818: Test failed: 3: expected property size 20 or 0, got 28

1 0

Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.
by Marvin June 28, 2012

June 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19594 Your paranoid android. === W7PROX64 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed: 3: expected property size 20 or 0, got 28 === TEST64_W7SP1 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed: 3: expected property size 20 or 0, got 28

3 4

Re: wbemprox: Add a Win32_LogicalDisk class stub.
by Hans Leidekker June 27, 2012

June 27, 2012

On Wed, 2012-06-27 at 14:41 +0300, John Yani wrote: > +static void fill_logicaldisk( struct table *table ) > +{ > + static const WCHAR device_id[] = {'0',0}; > + struct record_logicaldisk *rec; > + FIXME("returns a fake logical disks table\n"); > + if (!(table->data = heap_alloc( sizeof(*rec) ))) > + { > + return; > + } > + rec = (struct record_logicaldisk *)(table->data); > + rec->device_id = heap_strdupW( device_id ); > + table->num_rows = 1; > + TRACE("created %u rows\n", table->num_rows); > +} There's no need to create a copy of device_id. Just assign it to rec->device_id and remove COL_FLAG_DYNAMIC from the column definition.

1 0

ODBC on 64bit system
by Daniel Jelinski June 27, 2012

June 27, 2012

Hello all, Is it possible to run a 32bit application using 64bit ODBC drivers? I already checked that standard 32bit wine compilation does not work - but will it work with WoW64? I am trying to get an application to connect to SQL Server via tdsodbc, but unfortunately tdsodbc:i386 in ubuntu 11.10 is broken... Regards, Daniel

1 0

Re: [1/5] windowscodecs: Implement IWICBitmapScaler::GetSize.
by Dmitry Timoshkov June 27, 2012

June 27, 2012

Vincent Povirk <madewokherd(a)gmail.com> wrote: > static HRESULT WINAPI BitmapScaler_GetSize(IWICBitmapScaler *iface, > UINT *puiWidth, UINT *puiHeight) > { > - FIXME("(%p,%p,%p): stub\n", iface, puiWidth, puiHeight); > + BitmapScaler *This = impl_from_IWICBitmapScaler(iface); > + TRACE("(%p,%p,%p)\n", iface, puiWidth, puiHeight); > > - return E_NOTIMPL; > + if (!This->source) > + return WINCODEC_ERR_WRONGSTATE; > + > + *puiWidth = This->width; > + *puiHeight = This->height; > + > + return S_OK; This patch and remaning patches in the sequence completely miss any parameter checking. -- Dmitry.

2 1

Re: d3dx9_36 [patch 2 of 3]: Implementation of D3DXSHScale
by Matteo Bruni June 27, 2012

June 27, 2012

2012/6/27 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > -@ stub D3DXSHScale(ptr long ptr ptr) +@ stdcall D3DXSHScale(ptr long ptr ptr) ... +FLOAT* WINAPI D3DXSHScale(FLOAT *out, UINT order, CONST FLOAT *a, CONST FLOAT scale) The last parameter doesn't match between the function prototype and the spec entry. Also, apparently MSDN agrees with your prototype, while the docs in the last DirectX SDK have a pointer there. I guess the tests demonstrate that the parameter is actually a plain float... + for (i = 0; i < 100; i++) + { + a[i] = (FLOAT)i; + b[i] = (FLOAT)i; + } No need to cast. + D3DXSHScale(b, order, a, 5.0f); Not important, but you could also verify that the returned pointer is == b. +/* D3DXSHScale does not modify the elements of the array after the order * order-th element */ Can you please indent those comments? + return; +} That's not needed at all. Also, while you're at it, you should probably merge the two for loops in the test, like Francois did in http://www.winehq.org/pipermail/wine-patches/2012-June/115464.html

1 0

Re: wbemprox: Add a Win32_LogicalDisk class stub.
by Hans Leidekker June 27, 2012

June 27, 2012

On Wed, 2012-06-27 at 11:34 +0300, John Yani wrote: > +static void fill_logicaldisk( struct table *table ) > +{ > + static const WCHAR fmtW[] = {'%','u',0}; > + WCHAR device_id[11]; > + struct record_logicaldisk *rec; > + UINT num_rows = 1; > + FIXME("returns a fake logical disks table\n"); > + if (!(table->data = heap_alloc( sizeof(*rec) * num_rows ))) > + { > + return; > + } > + rec = (struct record_networkadapter *)(table->data); This should be (struct record_logicaldisk *)(table->data); > + sprintfW( device_id, fmtW, 0 ); > + rec->device_id = heap_strdupW( device_id ); > + > + TRACE("created %u rows\n", num_rows); > + table->num_rows = num_rows; > +} You don't need the num_rows variable since it's a fixed value. You also don't need to build the device id, it can just be a static string.

1 0

Re: [4/4] gdiplus: Add a bunch of tests for TIFF image properties.
by Marvin June 27, 2012

June 27, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19595 Your paranoid android. === W7PROX64 (64 bit image) === image.c:2812: Test failed: 0: expected property size 17 or 36, got 44 image.c:2812: Test failed: 2: expected property size 144 or 0, got 152 image.c:2812: Test failed: 3: expected property size 20 or 0, got 28 === TEST64_W7SP1 (64 bit image) === image.c:2812: Test failed: 0: expected property size 17 or 36, got 44 image.c:2812: Test failed: 2: expected property size 144 or 0, got 152 image.c:2812: Test failed: 3: expected property size 20 or 0, got 28

1 0

Re: d3dx9_36 [patch 3 of 3]: Implementation of D3DXSHMultiply2
by Marvin June 27, 2012

June 27, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19586 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: d3dx9_36 [patch 2 of 3]: Implementation of D3DXSHScale
by Marvin June 27, 2012

June 27, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19585 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] qedit: Support COM aggregation for SampleGrabber.
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19578 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401639 === W2KPROSP4 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401639

2 1

Re: [PATCH 3/4] qedit/tests: Add COM aggregation test for MediaDet.
by Michael Stefaniuc June 26, 2012

June 26, 2012

Argh! Please skip this patch, it is incomplete and just skips the rest of the tests on Wine. I'll resubmit it when I implement COM aggregation for MediaDet. Patch 4/4 can be still applied as it doesn't depends on this. bye michael On 06/26/2012 11:53 PM, Michael Stefaniuc wrote: > --- > dlls/qedit/tests/mediadet.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c > index 1d9a2f1..1d75680 100644 > --- a/dlls/qedit/tests/mediadet.c > +++ b/dlls/qedit/tests/mediadet.c > @@ -132,6 +132,7 @@ static BOOL init_tests(void) > static void test_mediadet(void) > { > HRESULT hr; > + struct unk_impl unk_obj = {{&unk_vtbl}, 19, NULL}; > IMediaDet *pM = NULL; > BSTR filename = NULL; > LONG nstrms = 0; > @@ -141,6 +142,12 @@ static void test_mediadet(void) > int flags; > int i; > > + /* COM aggregation */ > + hr = CoCreateInstance(&CLSID_MediaDet, &unk_obj.IUnknown_iface, CLSCTX_INPROC_SERVER, > + &IID_IUnknown, (void**)&unk_obj.inner_unk); > + todo_wine ok(hr == S_OK, "CoCreateInstance failed: %08x\n", hr); > + if (hr != S_OK) return; > + > /* test.avi has one video stream. */ > hr = CoCreateInstance(&CLSID_MediaDet, NULL, CLSCTX_INPROC_SERVER, > &IID_IMediaDet, (LPVOID*)&pM);

1 0

Re: [PATCH 3/4] qedit/tests: Add COM aggregation test for MediaDet.
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19577 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 === W2KPROSP4 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154

1 0

Re: kernel32: Change LCMapStringW to LCMapStringEx and call it from LCMapStringW (try 2)
by Alexandre Julliard June 26, 2012

June 26, 2012

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2625,6 +2641,28 @@ INT WINAPI LCMapStringW(LCID lcid, DWORD flags, LPCWSTR src, INT srclen, > } > > /************************************************************************* > + * LCMapStringW (KERNEL32.@) > + * > + * See LCMapStringA. > + */ > +INT WINAPI LCMapStringW(LCID lcid, DWORD flags, LPCWSTR src, INT srclen, > + LPWSTR dst, INT dstlen) > +{ > + WCHAR locale[LOCALE_NAME_MAX_LENGTH]; > + > + TRACE("(0x%04x,0x%08x,%s,%d,%p,%d)\n", > + lcid, flags, debugstr_wn(src, srclen), srclen, dst, dstlen); > + > + if (!LCIDToLocaleName(lcid, locale, LOCALE_NAME_MAX_LENGTH, 0)) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return 0; > + } I don't think it makes sense to do name conversion for a parameter that isn't used. If we use it someday it will most likely be to look up a conversion table directly from the lcid. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: windowscodecs: Implement MetadataHandler_GetValue.
by Vincent Povirk June 26, 2012

June 26, 2012

> + case VT_I8: > + case VT_UI8: > + case VT_R8: > + return v1->u.uhVal.QuadPart - v2->u.uhVal.QuadPart; Won't this only compare the low part on x86?

2 1

Re: [PATCH 3/5] secur32: Handle incomplete messages in schan_InitializeSecurityContextW().
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19560 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === schannel.c:702: Test failed: Got unexpected status 0x80090308.

1 0

Re: urlmon: Do not stop binding when OnDataAvailable() returns E_PENDING
by Jacek Caban June 26, 2012

June 26, 2012

On 06/26/12 00:02, Andrew Talbot wrote: > Changelog: > urlmon: Do not stop binding when OnDataAvailable() returns E_PENDING. > > diff --git a/dlls/urlmon/binding.c b/dlls/urlmon/binding.c > index 58aed20..42eca4b 100644 > --- a/dlls/urlmon/binding.c > +++ b/dlls/urlmon/binding.c > @@ -1097,7 +1097,7 @@ static void report_data(Binding *This, DWORD bscf, ULONG progress, ULONG progres > > hres = IBindStatusCallback_OnDataAvailable(This->callback, bscf, progress, > &formatetc, &stgmed); > - if(hres != S_OK) { > + if(FAILED(hres) && hres != E_PENDING) { > if(This->download_state != END_DOWNLOAD) { > This->download_state = END_DOWNLOAD; > IBindStatusCallback_OnProgress(This->callback, progress, progress_max, Please add a test case. You may modify one of existing binding tests to use E_PENDING. Jacek

1 0

Is it safe yet for developers to upgrade to Ubuntu 12.04?
by Erich E. Hoover June 26, 2012

June 26, 2012

I know that for a while there were some packaging problems that meant that upgrading to 12.04 made compiling 32-bit Wine on a 64-bit PC extremely difficult. Is this still the case? I'd like to upgrade to the new OS version, but I'm not willing to sacrifice the ability to build Wine in order to do so. Thanks in advance! Erich Hoover ehoover(a)mines.edu

6 5

Re: [PATCH] opengl32: Disable wglGetProcAddress for core GL 1.0/1.1 functions
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19550 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

change wording of ok()-messages in winspool-tests?
by Julian Rüger June 26, 2012

June 26, 2012

Hi Francois and list, [/nitpick-mode on] I'm preparing a patch to fix typos/spelling/grammar in dlls/winspool.drv/tests/info.c, where I stumbled across repeated messages like ok( !retval, "function result wrong! False expected\n"); or ok( size == exact, "Parameter size wrong! %d expected got %d\n", exact, size); Do you think it's worth changing these? (I think "Wrong function result: 'false' expected\n", and "Wrong parameter size: expected %d, got %d\n" would be better) Do we have guidelines for strings like these? For example: start with a captial letter, no punctuation at the end... What tests have "good" style I can use as reference? Best regards, Julian PS: Am I bike shedding here? Does anyone care about stuff like this? Sorry for wasting your time ;)

3 3

Building WoW64 packages
by Hilko Bengen June 25, 2012

June 25, 2012

Hi, after the effort on the Debian wine packages has progressed to a point where it's likely that we'll release wheezy with a stable wine version that is not completely out of date, I'd like to take things a step further. I recently spent some time looking at ways how we could build Debian packages for a shared WoW64 setup similar to what is described in http://wiki.winehq.org/Wine64. We will have to use separate build environments because having 32-bit and 64-bit -dev packages installed at the same time is not possible. Installing a 64-bit package that contains the build tools into a 32-bit environment should be possible, though. >From looking at the build system, things happen in a different way when I run configure for the 32-bit components with --wine64=...: 1. Manpages are not installed (WOW64_DISABLE) 2. --disable-fonts is implied 3. --disable-server is implied, so wineserver is not built. (The 64-bit wineserver is used instead, right?) 4. --disable-tools is implied because the existing build tools are being used. Did I miss anything? Leaving parts out is easy to understand, but how do the build tools that have been built for the x86_64 architecture affect the 32-bit components that are being built with them? Are different paths encoded into libwine? Cheers, -Hilko

2 1

Re: [PATCH 2/2] opengl32: Check for valid context in wglGetProcAddress
by Chris Robinson June 25, 2012

June 25, 2012

On Sunday, June 24, 2012 10:42:11 PM Roderick Colenbrander wrote: > @@ -797,7 +797,7 @@ static void test_getprocaddress(HDC hdc) > /* Temporarily disable the context, so we can see that we can't > retrieve functions now. */ wglMakeCurrent(hdc, NULL); > func = wglGetProcAddress("glActiveTextureARB"); > - todo_wine ok(func == NULL, "Function lookup without a context passed, > expected a failure; last error %#x\n", GetLastError()); > + ok(func == NULL, "Function lookup without a context passed, expected a > failure; last error %#x\n", GetLastError()); > wglMakeCurrent(hdc, ctx); > } Does this apply to all functions, or just the ones MS's DLL doesn't implement? I could imagine wlgGetProcAddress still returning functions that are in opengl32.dll without worrying about the driver.

2 1

Re: [3/5] gdiplus: Implement GdipGetPropertyIdList.
by Nikolay Sivov June 25, 2012

June 25, 2012

On 6/25/2012 14:30, Dmitry Timoshkov wrote: > + > + return hr == S_OK ? Ok : hresult_to_status(hr); > } > No need for special case for S_OK here.

1 0

Re: [3/3] d3drm: Implement IDirect3DRMMeshBuilderX_GetClassName
by Marvin June 24, 2012

June 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19493 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] d3drm: Implement IDirect3DRMLight_GetClassName
by Marvin June 24, 2012

June 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19492 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Incompatibility in Kernel32
by robert.van.herk＠serioustoys.com June 23, 2012

June 23, 2012

Hi group, As I was trying write a fix for msi.dll, I stumbled upon an incompatibility in the kernel. If you open an existing file, FILE_SHARE_DELETE doesn't seem to work in Wine. In Windows, it does. Attached is a minimal test case. I feel hesitation towards starting to hack in kernel32 myself. Though this bug seems to be blocking me to implement msi.dll completely compatible with the MS implementation... Shall I file a bug report? Regards, Robert

4 6

MSVCP60.dll
by John Emmas June 22, 2012

June 22, 2012

Firstly, I'm not a Linux user. I'm a Windows programmer but I have a passing knowledge of Linux (and several friends who are Linux programmers). I write a Windows application which gets launched as a child process by a popular Linux DAW. My program was first written many years ago when the (then) current version of Wine was about v0.9.58. Over a hundred people are using my program with old versions of Wine and I've had no complaints so far. Recently however, two customers tried to use it with Wine v1.5.35. In both cases the program crashed - apparently because some particular function wasn't found in MSVCP60.dll (at the moment, we don't know which function). Both customers went to a web site called WineTricks from where they were able to install an alternative version of MSVCP60.dll. My app now gets past the place where it previously crashed although it now crashes further on... :-( It looks as if the MSVC6 runtime module(s) that now come with Wine aren't the same as the ones from v0.9.58. Either they're different versions of the Microsoft DLLs or maybe they're now being implemented by somebody else, perhaps as part of Wine development? Either way, they don't work with my particular app any more. I still have Visual C++6 installed on an old computer, together with both the source code and the (InstallShield) packager for my original app. So is there anything I can do to make this work? For example, do I need to link against a particular version of the MSVC6 runtime? Or do I need to configure my packager so that it specifically distributes the runtime modules that my app linked to? I never did that in the past - because whichever runtime came with Wine seemed to work. Any advice? John

4 7

Re: [1/2] windowscodecs: Implement GetPreview and GetThumbnail in the TIFF decoder.
by Vincent Povirk June 22, 2012

June 22, 2012

According to MSDN, GetPreview isn't supported on any decoder except WMPhoto, and if that's true it should probably be returning WINCODEC_ERR_UNSUPPORTEDOPERATION. And why bother with GetThumbnail if you're not going to do it properly? At least check whether a thumbnail exists in the image before returning something.

2 1

Re: d3dx9_36: Implentation of D3DXSHDot
by Alexandre Julliard June 22, 2012

June 22, 2012

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > +static void test_D3DXSHDot(void) > +{ > + unsigned int i; > + FLOAT a[64], b[64], got; > + CONST FLOAT expected[] = > + { 0.0f, 0.0f, 17.0f, 222.0f, 1300.0f, 5050.0f, 15225.0f, 38612.0f, 86352.0f, }; > + > + for (i = 0; i < 64; i++) > + { > + a[i] = (FLOAT)i; > + b[i] = (FLOAT)i + 0.5f; > + } You should start with a non-zero value to tests orders 0 and 1 properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9_36 [patch 4 of 4, try 2]: Save multiplications
by Alexandre Julliard June 22, 2012

June 22, 2012

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > @@ -1971,11 +1971,13 @@ FLOAT *WINAPI D3DXFloat16To32Array(FLOAT *pout, CONST D3DXFLOAT16 *pin, UINT n) > > FLOAT* WINAPI D3DXSHAdd(FLOAT *out, UINT order, const FLOAT *a, const FLOAT *b) > { > - UINT i; > + UINT i, sq_order; > > TRACE("out %p, order %u, a %p, b %p\n", out, order, a, b); > > - for (i = 0; i < order * order; i++) > + sq_order = order * order; > + > + for (i = 0; i < sq_order; i++) > out[i] = a[i] + b[i]; There's no reason to do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wintrust/tests: Fix build with MSVC.
by Dmitry Timoshkov June 22, 2012

June 22, 2012

Thomas Faber <thfabba(a)gmx.de> wrote: > FIELD_OFFSET isn't constant "enough". The problem is not with FIELD_OFFSET, but with applying shift and mask operations to a constant. -- Dmitry.

3 3

Re: d3dx9_36 [patch 1 of 4, try 2]: Implemetation of D3DXSHDot
by Dmitry Timoshkov June 22, 2012

June 22, 2012

Hello, Please follow http://wiki.winehq.org/SubmittingPatches instructions for naming patches when sending a patch series. Usually 'git format-patch -n' will do it for you. Otherwise testbot won't recognize the series. -- Dmitry.

1 0

Re: d3dx9_36 [patch 3 of 4, try 2]: Implemetation of D3DXSHMultiply2
by Marvin June 22, 2012

June 22, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19429 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: d3dx9_36 [patch 1 of 4, try 2]: Implemetation of D3DXSHScale
by Marvin June 22, 2012

June 22, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19428 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

re: [PATCH 2/5] ddraw: Use wined3d_get_adapter_display_mode() in CreateSurface().
by Dan Kegel June 21, 2012

June 21, 2012

Henri wrote: - hr = wined3d_device_get_display_mode(ddraw->wined3d_device, 0, &mode); - if (FAILED(hr)) + if (FAILED(hr = wined3d_get_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &mode))) Seems like a step back in readability to combine setting and testing hr. - Dan

1 0

Examples of AJ silently improving patches?
by Dan Kegel June 21, 2012

June 21, 2012

AJ sometimes kindly fixes problems in patches while committing them (I guess it's easier than rejecting the patch for small issues). I wonder if these silent improvements would be worth collecting as a sort of style-guide-by-example. Anyone remember any good examples? I've started a list at http://wiki.winehq.org/StyleExamples

4 3

Re: [PATCH 1/7] ntdll: Add support for junction point creation.
by Hans Leidekker June 21, 2012

June 21, 2012

On Wed, 2012-06-20 at 17:26 -0600, Erich E. Hoover wrote: > + TRACE("Linking %s to %s\n", unix_src.Buffer, unix_dest.Buffer); > + if (rmdir( unix_src.Buffer ) < 0) > + { > + status = FILE_GetNtStatus(); > + goto cleanup; > + } > + if (symlink( unix_dest.Buffer, unix_src.Buffer ) < 0) > + { > + status = FILE_GetNtStatus(); > + goto cleanup; > + } > + status = STATUS_SUCCESS; This is not an atomic operation since you need two Unix calls. So you would need locking or rollback to deal with possible races. Should permissions and ownership be preserved on the directory when a junction is removed?

2 2

[1/5] windowscodecs: Implement PixelFormatInfo_GetBitsPerPixel.
by Vincent Povirk June 21, 2012

June 21, 2012

1 0

Re: kernel32: Add a test for deleting an opened for reading file. Take 2.
by Eric Pouech June 21, 2012

June 21, 2012

one tricky question... could it be that on windows this test behaves differently on ntfs vs FAT filesystem ? or what would give re-opening the file after the deletefile call ? A+ 2012/6/21, Dmitry Timoshkov <dmitry(a)baikal.ru>: > Previous version had a typo in file name. > --- > dlls/kernel32/tests/file.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c > index 8768b99..0a662d9 100644 > --- a/dlls/kernel32/tests/file.c > +++ b/dlls/kernel32/tests/file.c > @@ -3236,6 +3236,31 @@ static void test_CreatFile(void) > > DeleteFile(file_name); > } > +static void test_delete_file(void) > +{ > + char temp_path[MAX_PATH], temp_file[MAX_PATH]; > + HANDLE hfile; > + int ret; > + > + GetTempPathA(MAX_PATH, temp_path); > + GetTempFileName(temp_path, "tst", 0, temp_file); > + > + SetLastError(0xdeadbeef); > + hfile = CreateFile(temp_file, GENERIC_READ, FILE_SHARE_DELETE | > FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); > + ok(hfile != INVALID_HANDLE_VALUE, "CreateFile error %d\n", > GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = DeleteFile(temp_file); > +todo_wine > + ok(ret, "DeleteFile error %d\n", GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = CloseHandle(hfile); > + ok(ret, "CloseHandle error %d\n", GetLastError()); > + ret = DeleteFile(temp_file); > +todo_wine > + ok(!ret, "DeleteFile should fail\n"); > +} > > START_TEST(file) > { > @@ -3257,6 +3282,7 @@ START_TEST(file) > test_CreateFileW(); > test_DeleteFileA(); > test_DeleteFileW(); > + test_delete_file(); > test_MoveFileA(); > test_MoveFileW(); > test_FindFirstFileA(); > -- > 1.7.11 > > > > -- -- Eric Pouech

1 0

Re: wintrust/tests: Fix build with MSVC.
by Dmitry Timoshkov June 21, 2012

June 21, 2012

Thomas Faber <thfabba(a)gmx.de> wrote: > Empty braces are no valid initializer. > FIELD_OFFSET isn't constant "enough". > + /* add 'jmp ExitProcess' instruction */ > + count = 2; > + bin.text_section[count++] = 0xFF; > + bin.text_section[count++] = 0x25; > + bin.text_section[count++] = EXIT_PROCESS&0xFF; > + bin.text_section[count++] = (EXIT_PROCESS>>8)&0xFF; > + bin.text_section[count++] = (EXIT_PROCESS>>16)&0xFF; > + bin.text_section[count++] = (EXIT_PROCESS>>24)&0xFF; This part of the patch obviously is not related to the patch description. -- Dmitry.

1 0

Re: kernel32: Add a test for deleting an opened for reading file.
by Marvin June 21, 2012

June 21, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19407 Your paranoid android. === WNT4WSSP6 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W2KPROSP4 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === WXPPROSP3 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W2K3R2SESP2 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === WVISTAADM (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W2K8SE (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W7PRO (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W7PROX64 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === TEST64_W7SP1 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W7PROX64 (64 bit file) === file.c:3255: Test failed: DeleteFile error 2 === TEST64_W7SP1 (64 bit file) === file.c:3255: Test failed: DeleteFile error 2

1 0

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 3.
by Dmitry Timoshkov June 21, 2012

June 21, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/windowscodecs/tiffformat.c | 75 +++++++++++++++++++++++++++++++++++++---- > 1 file changed, 69 insertions(+), 6 deletions(-) Just a note, that once this patch is committed plus today's IFD metadata reader improvements the infrastructure for metadata handling in TIFF files should be all done. WICExplorer is able to recognize and show complete metadata listings for every frame in a multiframe TIFF file (native riched20 is needed for nicer visualization). -- Dmitry.

1 0

Re: [PATCH] winspool/tests: Fix failures, when the spooler service is not running
by Marvin June 20, 2012

June 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19360 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: gdiplus: Implement GdipImageSelectActiveFrame. Take 2.
by Vincent Povirk June 20, 2012

June 20, 2012

Looks good to me.

1 0

RE: msi:RECORD_StreamFromFile bug, help needed
by robert.van.herk＠serioustoys.com June 20, 2012

June 20, 2012

> IStream is not exposed to the user, but an internal interface would probably end up looking a lot like IStream because we need read/write/seek operations, reference counting and the ability to create clones. So we might as well use IStream. Hmmm... Then I want exactly the same as SHCreateStreamOnFileEx, but the only difference is that the file should be opened with FILE_SHARE_DELETE. (I think). What is that policy on this? It seems overkill to copy istream.c from shlwapi, just because I want to change 1 flag. On the other hand, I don't want to expose more functions in the shlwapi header, as that would make it different from the Windows implementation... Regards, Robert

2 1

Re: mmcndmgr: Implement IMMCVersionInfo (try 5)
by Marvin June 20, 2012

June 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19325 Your paranoid android. === WNT4WSSP6 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000 === W2KPROSP4 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000

1 0

Re: shell32: Make ShellExecute use native file association databases as fallback path (try 2)
by Francois Gouget June 20, 2012

June 20, 2012

On Tue, 19 Jun 2012, Erik van Pienbroek wrote: [...] > Additionally a check is added to make sure no recursive loop is > triggered when the native file association database points back to > wine and the fallback path is triggered again This looks much better. [...] > @@ -1911,6 +1944,44 @@ static BOOL SHELL_execute( LPSHELLEXECUTEINFOW sei, SHELL_ExecuteW32 execfunc ) > strcatW(lpstrTmpFile, lpFile); > retval = (UINT_PTR)ShellExecuteW(sei_tmp.hwnd, sei_tmp.lpVerb, lpstrTmpFile, NULL, NULL, 0); > } > +#if defined(HAVE_FORK) && defined(HAVE_WAITPID) > + /* Integration with native file association database */ > + else if (!getenv("WINE_INSIDE_SHELLEXECUTE")) > + { [...] > + /* Prevent the situation where the native file association database > + * tries to run wine to execute a program and we trigger this fallback > + * path again and end up in a recursive loop */ > + setenv("WINE_INSIDE_SHELLEXECUTE", "1", 0); [...] + unsetenv("WINE_INSIDE_SHELLEXECUTE"); Setting WINE_INSIDE_SHELLEXECUTE here creates a race condition if two threads call ShellExecute() at the same time. So I think this should be set between the fork() and the exec() in SHELL_try_native_execute(). -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

msi:RECORD_StreamFromFile bug, help needed
by robert.van.herk＠serioustoys.com June 20, 2012

June 20, 2012

Hi all, I think I found a msi.dll, record.c, RECORD_StreamFromFile. This function calls GlobalAlloc, with a file size as an argument. However, I believe that this can easily fail (which it does in my case) when the file size is too large. In my case, my msi builder (WiX) calls MsiRecordSetStreamW, which calls static function RECORD_StreamFromFile. WiX calls MsiRecordSetStreamW on some file that seems to be 0x11b2acc5 bytes (296 megs) large. Trying to allocate the block of 296 megs causes the error: 036:Call msi.MsiRecordSetStreamW(00000003,00000002,0cc8078c L"C:\\users\\robert\\Temp\\3c5c43d5\\1bfe39fa\\#product.cab") ret=009a4c3a 0036:Call KERNEL32.CreateFileW(0cc8078c L"C:\\users\\robert\\Temp\\3c5c43d5\\1bfe39fa\\#product.cab",80000000,00000001,00000000,00000003,00000000,00000000) ret=202868cf 0036:Ret KERNEL32.CreateFileW() retval=00000100 ret=202868cf 0036:Call KERNEL32.GetFileSize(00000100,0033ef58) ret=202868ef 0036:Ret KERNEL32.GetFileSize() retval=11b2acc5 ret=202868ef 0036:Call KERNEL32.GlobalAlloc(00000000,11b2acc5) ret=202869fb 0036:Ret KERNEL32.GlobalAlloc() retval=00000000 ret=202869fb <--- fail I believe the call to GlobalAlloc stems from RECORD_StreamFromFile. This tries to copy the full contents of the file in memory, and then create an IStream from that memory using CreateStreamOnHGlobal: /* read the data in a file into an IStream */ static UINT RECORD_StreamFromFile(LPCWSTR szFile, IStream **pstm) { ... handle = CreateFileW(szFile, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL); ... sz = GetFileSize(handle, &szHighWord); if( sz != INVALID_FILE_SIZE && szHig sz = GetFileSize(handle, &szHighWord); if( sz != INVALID_FILE_SIZE && szHighWord == 0 ) { hGlob = GlobalAlloc(GMEM_FIXED, sz); // <-- Fails in my case, because sz == 296 megs if( hGlob ) { BOOL r = ReadFile(handle, hGlob, sz, &read, NULL); if( !r ) { GlobalFree(hGlob); hGlob = 0; } } CloseHandle(handle); if( !hGlob ) return ERROR_FUNCTION_FAILED; // <-- hence, this error is raised. hr = CreateStreamOnHGlobal(hGlob, TRUE, pstm); ... } I want to fix this. I guess that apart from that the allocation fails, I have the feeling that copying this entire 296 megs into main memory is anyway a bit heavy, just for creating a stream. So I thought a better solution would be just to create a stream from the file. My first guess would be to use the SHCreateStreamOnFile function: HRESULT SHCreateStreamOnFile( __in LPCTSTR pszFile, __in DWORD grfMode, __out IStream **ppstm ); But then I was thinking: this seems like such an obvious thing to do, that it is almost suspicious. Was there any reason for copying the file contents to main memory and then create a memory stream? For instance, was the intention to have a non-mutable copy in memory, in case the backing file would be altered later on? I guess if that's the case, I could just create a copy of the original file in a temp dir, and mark it as STGM_DELETEONRELEASE. Before I wildly attempt a fix though, I would appreciate it if someone had an idea here... Kind regards, Robert van Herk

2 8

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability.
by André Hentschel June 19, 2012

June 19, 2012

Am 18.06.2012 15:52, schrieb Erich E. Hoover: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the code for finding the appropriate symbol has > been split out into a separate function (requested by Michael > Stefaniuc) and the string comparison has been modified to use the > larger of the two lengths (the length of the symbol to check and the > length of the symbol given in the help file). > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. You're adding dead code here, you should maybe merge Patch 1 & 2 -- Best Regards, André Hentschel

2 2

Re: shell32: add some tests for the Progman DDE interface
by Alexandre Julliard June 19, 2012

June 19, 2012

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * shell32: add some tests for the Progman DDE interface Please merge that with the existing tests, assuming that what you are testing is not already covered. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll : add ThreadQuerySetWin32StartAddress in NtQueryInformationThread
by Alexandre Julliard June 19, 2012

June 19, 2012

Roman Dadkov <romand(a)etersoft.ru> writes: > @@ -63,7 +63,7 @@ struct reply_header > /* this is used to construct the generic_request union */ > struct request_max_size > { > - int pad[16]; /* the max request size is 16 ints */ > + int pad[18]; /* the max request size is 18 ints */ > }; You can't change that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mmcndmgr: Implement IMMCVersionInfo (try 4)
by Alexandre Julliard June 19, 2012

June 19, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -66,8 +179,6 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > > switch (fdwReason) > { > - case DLL_WINE_PREATTACH: > - return FALSE; /* prefer native version */ Changing this may or may not be a good idea at this point, but it definitely shouldn't be silently sneaked in as part of a different patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)
by Akihiro Sagawa June 19, 2012

June 19, 2012

On Tue, 19 Jun 2012 03:39:18 -0300, Bruno Jesus wrote: > Hi, judging by the subjects I'd say the patches were commited already, > you're trying to send them again or are they different patches? > > http://source.winehq.org/git/wine.git/commitdiff/afdc84cf0366c8e161004bf1e7… > http://source.winehq.org/git/wine.git/commitdiff/2bb416baa88c28f57bb0f65aa9… > http://source.winehq.org/git/wine.git/commitdiff/f503afd86ff9df9467eb1351cf… Hi Bruno, Please ignore these patches. They were sent over 48 hours ago. It seems there is a huge delay between Gmail and wine-patches. Actually, one of my original patches are missed `static' keyword as Dmitry spotted(*). Therefore, I added the keyword and sent series of patches again. But, during transfer (>48 hours), the original patch was updated by Alexandre, then committed. After a while, my modified version was delivered and tested although they have already been applied. * ... http://www.winehq.org/pipermail/wine-devel/2012-June/095956.html Akihiro Sagawa

2 2

Re: [website] Portuguese translation for release 1.4.1
by Lucas Zawacki June 19, 2012

June 19, 2012

Disregard this patch. I added the wrong file to the commit and will resend. On Tue, Jun 19, 2012 at 12:01 PM, Jeremy Newman <jnewman(a)codeweavers.com> wrote: > This is just english. Did you mean for that to happen? > > No need to send the english, as if the xml does not exist, the site will > always fall back to the english version already. > > -N > > > On 06/19/2012 09:49 AM, Lucas Zawacki wrote: >> >> From: Lucas Zawacki<lfzawacki(a)gmail.com> >> >> --- >> news/pt/2012061501.xml | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> create mode 100644 news/pt/2012061501.xml >> >> diff --git a/news/pt/2012061501.xml b/news/pt/2012061501.xml >> new file mode 100644 >> index 0000000..7c0ff9f >> --- /dev/null >> +++ b/news/pt/2012061501.xml >> @@ -0,0 +1,13 @@ >> +<news> >> +<date>June 15, 2012</date> >> +<title>Wine 1.4.1 Released</title> >> +<body> >> +<p> The Wine maintenance release 1.4.1 is now available.</p> >> +<p> <a href="{$root}/announce/1.4.1">What's new</a> in this release: >> +<ul> >> +<li>Translation updates.</li> >> +<li>Various bug fixes.</li> >> +</ul></p> >> +<p><p>The source is<a >> href="http://prdownloads.sourceforge.net/wine/wine-1.4.1.tar.bz2">available >> now</a>. >> +Binary packages are in the process of being built, and will appear soon >> at their respective<a href="{$root}/download">download locations</a>. >> +</p></body></news>

1 0

Re: [5/5] gdiplus: Implement GdipImageSelectActiveFrame.
by Vincent Povirk June 19, 2012

June 19, 2012

> + hr = IStream_Clone(image->stream, &stream); > + if (FAILED(hr)) That's odd. When does that happen? > + if (stat == Ok) > + { > + memcpy(&new_image->format, &codec->info.FormatID, sizeof(GUID)); > + free_image_data(image); > + if (image->type == ImageTypeBitmap) > + *(GpBitmap *)image = *(GpBitmap *)new_image; > + else if (image->type == ImageTypeMetafile) > + *(GpMetafile *)image = *(GpMetafile *)new_image; > + return Ok; > + } Why did you re-implement move_bitmap() ?

2 5

Re: d3dx9_36 [patch 1of 2]: Implementation of D3DXSHDot
by Matteo Bruni June 19, 2012

June 19, 2012

2012/6/19 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: +static void test_D3DXSHDot(void) +{ + unsigned int i; + FLOAT a[90], b[90], got; + CONST FLOAT expected[] = + { 0.0f, 0.0f, 17.0f, 222.0f, 1300.0f, 5050.0f, 15225.0f, 38612.0f, 86352.0f, 175500.0f, }; + + for (i = 0; i < 90; i++) + { + a[i] = (FLOAT)i; + b[i] = (FLOAT)i + 0.5f; + } + +/* D3DXSHDot computes by using order * order elements */ + for (i = 0; i < 9; i++) + { + got = D3DXSHDot(i, a, b); + ok(relative_error(got, expected[i]) < admitted_error, "order %d: expected %f, received %f\n", i, expected[i], got); + } + + return; +} + Making the "a" and "b" arrays 90 elements big doesn't make much sense. If your D3DXSHDot implementation is correct, for the i = 8 case you only need 8 * 8 = 64 elements. Also notice that the "expected" array has 10 elements, while you use only 9. Also please recheck formatting and whitespaces of this patch and patch 2/2.

1 0

Re: [appdb] Upgrade to xinha svn head to fix issues with xinha editors not appearing in Firefox 15
by Ricardo Filipe June 19, 2012

June 19, 2012

2012/6/18 André Hentschel <nerv(a)dawncrow.de>: > http://bugs.winehq.org/show_bug.cgi?id=30820 > --- > xinha/Xinha.css | 229 +- > xinha/XinhaCore.js |12107 ++++++++++++++------ > xinha/contrib/php-xinha.php | 29 +- > xinha/examples/Extended.html | 299 - > xinha/examples/Newbie.html | 12 +- > xinha/examples/XinhaConfig.js | 149 +- > xinha/examples/custom.css | 40 - > xinha/examples/dynamic.css | 56 - > xinha/examples/ext_example-body.html | 202 - > xinha/examples/ext_example-dest.php | 23 - > xinha/examples/ext_example-menu.php | 331 - > xinha/examples/ext_example.html | 16 - > xinha/examples/full_example.css | 48 - > xinha/examples/full_example.js | 97 - > xinha/examples/simple_example.html | 190 +- > xinha/examples/stylist.css | 31 - > xinha/examples/testbed.html | 45 +- > xinha/htmlarea.js | 44 +- > xinha/lang/b5.js | 58 +- > xinha/lang/ch.js | 112 +- > xinha/lang/cz.js | 100 +- > xinha/lang/da.js | 202 +- > xinha/lang/de.js | 338 +- > xinha/lang/ee.js | 100 +- > xinha/lang/el.js | 110 +- > xinha/lang/es.js | 207 +- > xinha/lang/eu.js | 2 +- > xinha/lang/fa.js | 6 +- > xinha/lang/fi.js | 76 +- > xinha/lang/fr.js | 338 +- > xinha/lang/gb.js | 58 +- > xinha/lang/he.js | 128 +- > xinha/lang/hu.js | 128 +- > xinha/lang/it.js | 110 +- > xinha/lang/ja.js | 6 +- > xinha/lang/lt.js | 106 +- > xinha/lang/lv.js | 84 +- > xinha/lang/nb.js | 156 +- > xinha/lang/nl.js | 128 +- > xinha/lang/pl.js | 2 +- > xinha/lang/pt_br.js | 180 +- > xinha/lang/ro.js | 126 +- > xinha/lang/ru.js | 370 +- > xinha/lang/sh.js | 2 +- > xinha/lang/si.js | 100 +- > xinha/lang/sr.js | 2 +- > xinha/lang/vn.js | 112 +- > xinha/modules/ColorPicker/ColorPicker.js | 1494 ++- > xinha/modules/CreateLink/link.js | 190 +- > xinha/modules/Dialogs/dialog.js | 159 +- > xinha/modules/Dialogs/inline-dialog.js | 204 - > xinha/modules/Dialogs/panel-dialog.js | 1 + > xinha/modules/Dialogs/popupwin.js | 291 +- > xinha/modules/FullScreen/full-screen.js | 373 +- > xinha/modules/Gecko/Gecko.js | 1225 ++- > xinha/modules/Gecko/paraHandlerBest.js | 1196 ++- > xinha/modules/Gecko/paraHandlerDirty.js | 116 - > xinha/modules/GetHtml/DOMwalk.js | 519 +- > xinha/modules/GetHtml/TransformInnerHTML.js | 368 +- > xinha/modules/InsertImage/insert_image.html | 345 +- > xinha/modules/InsertImage/insert_image.js | 214 +- > xinha/modules/InsertTable/insert_table.html | 314 +- > xinha/modules/InsertTable/insert_table.js | 153 +- > xinha/modules/InternetExplorer/InternetExplorer.js | 1150 ++- > xinha/plugins/CSS/css.js | 74 - > xinha/plugins/CharCounter/char-counter.js | 106 - > xinha/plugins/CharacterMap/CharacterMap.css | 6 +- > xinha/plugins/CharacterMap/character-map.js | 68 - > xinha/plugins/CharacterMap/lang/de.js | 22 +- > .../CharacterMap/popups/select_character.html | 184 - > xinha/plugins/ContextMenu/1.pl | 38 - > xinha/plugins/ContextMenu/context-menu.js | 383 - > xinha/plugins/ContextMenu/lang/de.js | 100 +- > xinha/plugins/ContextMenu/lang/el.js | 94 +- > xinha/plugins/ContextMenu/lang/fr.js | 98 +- > xinha/plugins/ContextMenu/lang/he.js | 94 +- > xinha/plugins/ContextMenu/lang/nl.js | 94 +- > xinha/plugins/DoubleClick/double-click.js | 66 - > xinha/plugins/DynamicCSS/dynamiccss.js | 199 - > xinha/plugins/DynamicCSS/lang/de.js | 24 +- > xinha/plugins/DynamicCSS/lang/fr.js | 12 +- > xinha/plugins/FindReplace/find-replace.js | 42 - > xinha/plugins/FindReplace/fr_engine.js | 291 +- > xinha/plugins/FindReplace/lang/pt_br.js | 60 +- > xinha/plugins/FindReplace/popups/find_replace.html | 324 +- > xinha/plugins/Forms/forms.js | 354 - > xinha/plugins/Forms/popups/fieldset.html | 15 +- > xinha/plugins/Forms/popups/form.html | 21 +- > xinha/plugins/Forms/popups/input.html | 78 +- > xinha/plugins/Forms/popups/label.html | 15 +- > xinha/plugins/Forms/popups/select.html | 217 +- > xinha/plugins/Forms/popups/textarea.html | 41 +- > xinha/plugins/FullPage/full-page.js | 200 - > xinha/plugins/FullPage/lang/de.js | 36 +- > xinha/plugins/FullPage/lang/fr.js | 32 +- > xinha/plugins/FullPage/lang/he.js | 28 +- > xinha/plugins/FullPage/lang/ro.js | 28 +- > xinha/plugins/FullPage/popups/docprop.html | 282 +- > xinha/plugins/FullScreen/full-screen.js | 203 - > xinha/plugins/FullScreen/lang/de.js | 6 - > xinha/plugins/FullScreen/lang/fr.js | 5 - > xinha/plugins/FullScreen/lang/no.js | 6 - > xinha/plugins/FullScreen/lang/pl.js | 6 - > xinha/plugins/HtmlTidy/README | 104 - > xinha/plugins/HtmlTidy/html-tidy-config.cfg | 29 - > xinha/plugins/HtmlTidy/html-tidy-logic.php | 79 - > xinha/plugins/HtmlTidy/html-tidy.js | 105 - > xinha/plugins/HtmlTidy/img/html-tidy.gif | Bin 599 -> 0 bytes > xinha/plugins/HtmlTidy/lang/de.js | 7 - > xinha/plugins/HtmlTidy/lang/fr.js | 8 - > xinha/plugins/HtmlTidy/lang/ja.js | 8 - > xinha/plugins/HtmlTidy/lang/nb.js | 7 - > xinha/plugins/HtmlTidy/lang/nl.js | 5 - > xinha/plugins/InsertAnchor/insert-anchor.css | 1 - > xinha/plugins/InsertAnchor/insert-anchor.js | 76 - > xinha/plugins/InsertPicture/InsertPicture.php | 301 - > xinha/plugins/InsertPicture/img/btn_open.gif | Bin 173 -> 0 bytes > xinha/plugins/InsertPicture/img/nopic.gif | Bin 1537 -> 0 bytes > xinha/plugins/InsertPicture/insert-picture.js | 25 - > xinha/plugins/InsertPicture/lang/de.js | 15 - > xinha/plugins/InsertPicture/lang/fr.js | 22 - > xinha/plugins/InsertPicture/lang/ja.js | 25 - > xinha/plugins/InsertPicture/lang/nb.js | 22 - > xinha/plugins/InsertPicture/lang/sv.js | 35 - > xinha/plugins/InsertPicture/viewpicture.html | 46 - > xinha/plugins/InsertWords/insert-words.js | 70 - > xinha/plugins/Linker/dTree/api.html | 502 +- > xinha/plugins/Linker/dTree/dtree.css | 8 +- > xinha/plugins/Linker/dTree/dtree.js | 1037 ++- > xinha/plugins/Linker/dTree/example01.html | 104 +- > xinha/plugins/Linker/dialog.html | 210 +- > xinha/plugins/Linker/linker.js | 385 - > xinha/plugins/Linker/scan.php | 220 +- > xinha/plugins/ListType/lang/de.js | 24 +- > xinha/plugins/ListType/list-type.js | 137 - > xinha/plugins/QuickTag/lang/pt_br.js | 26 +- > xinha/plugins/QuickTag/popups/quicktag.html | 706 +- > xinha/plugins/QuickTag/quick-tag.js | 53 - > xinha/plugins/QuickTag/tag-lib.js | 381 +- > xinha/plugins/SpellChecker/aspell_setup.php | 246 +- > xinha/plugins/SpellChecker/lang/cz.js | 52 +- > xinha/plugins/SpellChecker/lang/da.js | 52 +- > xinha/plugins/SpellChecker/lang/de.js | 52 +- > xinha/plugins/SpellChecker/lang/he.js | 54 +- > xinha/plugins/SpellChecker/lang/hu.js | 52 +- > xinha/plugins/SpellChecker/lang/nl.js | 54 +- > xinha/plugins/SpellChecker/lang/ro.js | 52 +- > xinha/plugins/SpellChecker/readme-tech.html | 228 +- > xinha/plugins/SpellChecker/spell-check-logic.cgi | 420 +- > xinha/plugins/SpellChecker/spell-check-logic.php | 340 +- > .../plugins/SpellChecker/spell-check-savedicts.php | 74 +- > xinha/plugins/SpellChecker/spell-check-ui.html | 250 +- > xinha/plugins/SpellChecker/spell-check-ui.js | 846 +- > xinha/plugins/SpellChecker/spell-checker.js | 73 - > xinha/plugins/Stylist/stylist.js | 372 - > xinha/plugins/SuperClean/dialog.html | 14 +- > xinha/plugins/SuperClean/lang/de.js | 3 +- > xinha/plugins/SuperClean/super-clean.js | 211 - > xinha/plugins/SuperClean/tidy.php | 358 +- > xinha/plugins/TableOperations/lang/cz.js | 158 +- > xinha/plugins/TableOperations/lang/da.js | 161 +- > xinha/plugins/TableOperations/lang/de.js | 162 +- > xinha/plugins/TableOperations/lang/el.js | 158 +- > xinha/plugins/TableOperations/lang/fi.js | 136 +- > xinha/plugins/TableOperations/lang/fr.js | 154 +- > xinha/plugins/TableOperations/lang/he.js | 158 +- > xinha/plugins/TableOperations/lang/it.js | 158 +- > xinha/plugins/TableOperations/lang/ja.js | 6 +- > xinha/plugins/TableOperations/lang/nb.js | 158 +- > xinha/plugins/TableOperations/lang/nl.js | 158 +- > xinha/plugins/TableOperations/lang/pl.js | 6 +- > xinha/plugins/TableOperations/lang/ro.js | 158 +- > xinha/plugins/TableOperations/lang/ru.js | 6 +- > xinha/plugins/TableOperations/lang/sv.js | 6 +- > .../TableOperations/popups/merge_cells.html | 11 +- > xinha/plugins/TableOperations/table-operations.js | 893 -- > xinha/plugins/UnFormat/popups/unformat.html | 85 - > xinha/plugins/UnFormat/un-format.js | 65 - > xinha/popups/about.html | 296 - > xinha/popups/blank.html | 3 +- > xinha/popups/editor_help.html | 122 +- > xinha/popups/popup.js | 239 +- > xinha/popups/select_color.html | 716 +- > xinha/release-notes.txt | 476 +- > xinha/skins/blue-look/skin.css | 14 +- > xinha/skins/blue-metallic/skin.css | 7 + > xinha/skins/green-look/skin.css | 10 +- > xinha/skins/inditreuse/skin.css | 10 +- > xinha/skins/titan/skin.css | 10 +- > xinha/skins/xp-blue/skin.css | 10 +- > xinha/skins/xp-green/skin.css | 10 +- > 191 files changed, 22579 insertions(+), 20386 deletions(-) > delete mode 100644 xinha/examples/Extended.html > delete mode 100644 xinha/examples/custom.css > delete mode 100644 xinha/examples/dynamic.css > delete mode 100644 xinha/examples/ext_example-body.html > delete mode 100644 xinha/examples/ext_example-dest.php > delete mode 100644 xinha/examples/ext_example-menu.php > delete mode 100644 xinha/examples/ext_example.html > delete mode 100644 xinha/examples/full_example.css > delete mode 100644 xinha/examples/full_example.js > delete mode 100644 xinha/examples/stylist.css > delete mode 100644 xinha/modules/Dialogs/inline-dialog.js > mode change 100644 => 100755 xinha/modules/FullScreen/lang/sv.js > delete mode 100644 xinha/modules/Gecko/paraHandlerDirty.js > delete mode 100644 xinha/plugins/CSS/css.js > delete mode 100644 xinha/plugins/CharCounter/char-counter.js > delete mode 100644 xinha/plugins/CharacterMap/character-map.js > mode change 100644 => 100755 xinha/plugins/CharacterMap/lang/sv.js > delete mode 100644 xinha/plugins/CharacterMap/popups/select_character.html > delete mode 100755 xinha/plugins/ContextMenu/1.pl > delete mode 100644 xinha/plugins/ContextMenu/context-menu.js > delete mode 100644 xinha/plugins/DoubleClick/double-click.js > delete mode 100644 xinha/plugins/DynamicCSS/dynamiccss.js > delete mode 100644 xinha/plugins/FindReplace/find-replace.js > mode change 100644 => 100755 xinha/plugins/FindReplace/lang/sv.js > delete mode 100644 xinha/plugins/Forms/forms.js > delete mode 100644 xinha/plugins/FullPage/full-page.js > delete mode 100644 xinha/plugins/FullScreen/full-screen.js > delete mode 100644 xinha/plugins/FullScreen/lang/de.js > delete mode 100644 xinha/plugins/FullScreen/lang/fr.js > delete mode 100644 xinha/plugins/FullScreen/lang/no.js > delete mode 100644 xinha/plugins/FullScreen/lang/pl.js > delete mode 100644 xinha/plugins/HtmlTidy/README > delete mode 100644 xinha/plugins/HtmlTidy/html-tidy-config.cfg > delete mode 100755 xinha/plugins/HtmlTidy/html-tidy-logic.php > delete mode 100644 xinha/plugins/HtmlTidy/html-tidy.js > delete mode 100644 xinha/plugins/HtmlTidy/img/html-tidy.gif > delete mode 100644 xinha/plugins/HtmlTidy/lang/de.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/fr.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/ja.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/nb.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/nl.js > delete mode 100755 xinha/plugins/InsertAnchor/insert-anchor.js > delete mode 100644 xinha/plugins/InsertPicture/InsertPicture.php > delete mode 100644 xinha/plugins/InsertPicture/img/btn_open.gif > delete mode 100644 xinha/plugins/InsertPicture/img/nopic.gif > delete mode 100644 xinha/plugins/InsertPicture/insert-picture.js > delete mode 100644 xinha/plugins/InsertPicture/lang/de.js > delete mode 100644 xinha/plugins/InsertPicture/lang/fr.js > delete mode 100644 xinha/plugins/InsertPicture/lang/ja.js > delete mode 100644 xinha/plugins/InsertPicture/lang/nb.js > delete mode 100644 xinha/plugins/InsertPicture/lang/sv.js > delete mode 100644 xinha/plugins/InsertPicture/viewpicture.html > delete mode 100755 xinha/plugins/InsertWords/insert-words.js > delete mode 100644 xinha/plugins/Linker/linker.js > mode change 100644 => 100755 xinha/plugins/ListType/lang/sv.js > delete mode 100644 xinha/plugins/ListType/list-type.js > delete mode 100644 xinha/plugins/QuickTag/quick-tag.js > delete mode 100644 xinha/plugins/SpellChecker/spell-checker.js > delete mode 100644 xinha/plugins/Stylist/stylist.js > delete mode 100644 xinha/plugins/SuperClean/super-clean.js > mode change 100644 => 100755 xinha/plugins/TableOperations/lang/sv.js > mode change 100644 => 100755 xinha/plugins/TableOperations/popups/merge_cells.html > delete mode 100644 xinha/plugins/TableOperations/table-operations.js > delete mode 100644 xinha/plugins/UnFormat/popups/unformat.html > delete mode 100644 xinha/plugins/UnFormat/un-format.js > delete mode 100644 xinha/popups/about.html > > > -- > > Best Regards, André Hentschel > > > > The xinha editor does not show up in chrome either for a long time now... could it be related to this? I even opened a bug report on chromium but it still wasn't looked at. Maybe this solves it too...

1 0

'Expensive' expressions in loop limits (was: Implementation of D3DXSHScale)
by Dan Kegel June 19, 2012

June 19, 2012

Nozomi wrote: + for (i = 0; i < order * order; i++) I might have written int n = order * order; for (i=0; i < n; i++) to avoid repeating the multiplication every time around the loop, even though multiplication is cheap nowadays, and -O1 will optimize it out anyway. Staying in the habit of avoiding 'expensive' operations in loop limits might still be a good idea, since the optimizer can't always save you. Or is that considered ugly these days? D3DXSHAdd() has the same code, which is where this came from, probably.

2 1

Re: d3dx9_36: Implementation of a test for D3DFMT_A8B8G8R8
by Józef Kucia June 19, 2012

June 19, 2012

I've also added a tests for this pixel format in the patch, which was submitted yesterday: http://www.winehq.org/pipermail/wine-patches/2012-June/115268.html

1 0

Re: [PATCH 2/3] gdi32: Fix East-Asian font parameters. (resend)
by Marvin June 19, 2012

June 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19270 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)
by Marvin June 19, 2012

June 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19269 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 3.
by Vincent Povirk June 19, 2012

June 19, 2012

I'm still a little worried about seeking the stream behind libtiff's back, but otherwise it looks good.

2 1

Disabling joysticks with registry keys and joy.cpl
by Lucas Zawacki June 19, 2012

June 19, 2012

Hello all, disabling an specific joystick device is an issue that is raised from time to time in this list. I'm planning on implementing it as a registry key like 'DirectInput/Disable controllername'. However I'd like the ability to disable specific joysticks on Linux, like the /dev/input/js* version, while keeping the /dev/input/event* one being enumerated. One option for doing this would be having a "Disable USB Controller" -> "driver" key with options being: "linux", "linuxinput", and "all". My only doubt is how would you guys want to have this option in joy.cpl? I think the correct thing to do would be to disable it with "all", but my use case includes a user disabling the repeated joysticks on Linux through the interface and if he's only able to disable all drivers at once that would be confusing and less useful. The bottom line is: can I add platform dependent code in joy.cpl for this purpose? If that's not an option, do you have some other way to do through joy.cpl or should it be registry only? Attached is an example patch of the approach for joystick_linuxinput.c Cheers, Lucas

2 2

Re: d3dx9_36: Reckonize A8B8G8R8 format
by Stefan Dösinger June 18, 2012

June 18, 2012

Hi, Please add the format to the dds tests in dlls/d3dx9_36/tests/surface.c > { 32, 0x0000ffff, 0xffff0000, 0x00000000, 0x00000000, D3DFMT_G16R16 }, > + { 32, 0xff, 0xff00, 0xff0000, 0xff000000, D3DFMT_A8B8G8R8 }, The other 32 bit formats in this table have their bitmasks padded to 32 bit with leading zeroes. Stefan Am Freitag, 15. Juni 2012, 18:18:46 schrieb Nozomi Kodama: This patch solves the color problem appearing in bug 30786. Nozomi

1 1

Re: comctl32: hotkey control needs to invalidate itself when painting for some apps
by Dmitry Timoshkov June 18, 2012

June 18, 2012

Dan Kegel <dank(a)kegel.com> wrote: > @@ -190,6 +190,8 @@ HOTKEY_Paint(HOTKEY_INFO *infoPtr, HDC hdc) > HOTKEY_Refresh(infoPtr, hdc); > else { > PAINTSTRUCT ps; > + /* In some apps, the hotkey doesn't draw unless we invalidate it here */ > + InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); It doesn't make sense to invalidate before painting in the paint handler. -- Dmitry.

2 1

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Chris Robinson June 18, 2012

June 18, 2012

On Friday, June 15, 2012 3:39:33 PM Andrew Eikum wrote: > One thing to note is that PulseAudio has an absurdly high default > latency (two seconds), and due to its poor API there's no (easy) way > for us to control it. The latency is likely caused by PulseAudio setting a much larger tlength (and minreq) than what you asked for. This happens all the time for me when the server has been running. The trick I've found to dealing with this in OpenAL Soft is to essentially ignore what PulseAudio sets and do your free space calculations so that only the size of the buffer you requested is used. Something like: size_t writable_size(pulse_data *data) { uint buffer_size = our requested buffer size in bytes; uint update_size = our expected period size in bytes; /* This is signed since it could come out negative */ ssize_t len; pa_threaded_mainloop_lock(data->loop); len = pa_stream_writable_size(data->stream) - data->attr.tlength + buffer_size; pa_threaded_mainloop_unlock(data->loop); if(len < 0) return 0; len -= len%update_size; return len; } The update_size is only relevant if mmdevapi updates in period-sized chunks. If it doesn't, you can just remove it and the rounding. The tlength should be kept updated using pa_stream_set_buffer_attr_callback, in case the server tries to increase it more during runtime. When creating the stream, I set minreq to the period size, and tlength to the requested buffer size. I also set the flags PA_STREAM_INTERPOLATE_TIMING, PA_STREAM_AUTO_TIMING_UPDATE, and PA_STREAM_ADJUST_LATENCY. The most important part is to not rely on PA_STREAM_EARLY_REQUESTS or the write callback to tell you when some space is free for writing, since as noted above, PulseAudio can set unreasonably large values. This doesn't completely fix the latency problem, as I'll still get better performance using ALSA's dmix, but it helps immensely.

2 4

comctl32: hotkey control needs to invalidate itself when painting for some apps
by Dan Kegel June 18, 2012

June 18, 2012

In at least one app, the hotkey control doesn't draw itself. Invalidating its own window during HOTKEY_Paint gets the control to draw properly, and makes the app happy. Fixes http://bugs.winehq.org/show_bug.cgi?id=30486 (Unlike the patch attached to that bug, this one doesn't also ask the background to be redrawn again.)

2 1

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 2.
by Vincent Povirk June 18, 2012

June 18, 2012

This looks better, but I still think you should use WICPersistOptionNoCacheStream. Some of your failure cases in create_metadata_reader will return a reference to an IWICMetadataReader, which seems wrong.

2 1

Re: windowscodecs: Create a IWICMetadataReader when loading a TIFF frame.
by Vincent Povirk June 18, 2012

June 18, 2012

> + hr = IWICPersistStream_LoadEx(persist, This->parent->stream, NULL, persist_options); > + if (FAILED(hr)) > + ERR("IWICPersistStream_LoadEx error %#x\n", hr); We can't use that stream because we provide separate seek and read/write methods to libtiff, and libtiff may rely on the stream's position to not change between operations. This illustrates a design flaw in WIC. Normally, we would just clone the stream, but IWICStream doesn't implement the Clone method. I think we are probably supposed to create a new IWICStream based on the given stream, but the resulting stream won't be thread-safe with ours. I think for now it's OK to re-use this stream as long as you seek it back to where it was when you're done, but we may have to change that later. Also, LoadEx should (but does not yet) save the stream so it can create an IWICFastMetadataEncoder. If you re-use the bitmap decoder's stream, you should also use the WICPersistOptionNoCacheStream flag when you create the metadata reader to make sure it won't do that. Your GetReaderByIndex method should check whether This->metadata_reader has been set and return an error if not. Otherwise, the patch looks good to me.

2 4

Re: atl80: prefer native, if present
by Alexandre Julliard June 18, 2012

June 18, 2012

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 7243b3594c9c0b13770ede1ab32d4dd1329b1dd4 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Sun, 17 Jun 2012 17:37:15 +0200 > Subject: atl80: prefer native, if present > > --- > dlls/atl80/atl80.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) There's no reason to do that, most of the dll is already implemented. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Darryl Slack June 18, 2012

June 18, 2012

Well after fighting with pulseaudio after all this time I have tried this patch with wine 1.5.6 with a Presonus StudioLive 24.4.2 Fire-wire controller within wine, to control software known as Virtual DJ with timecoded vinyl records. With Andrew's patch, there are stalled buffer errors, and I wasn't able to measure latency very well because the controller just kept on reporting 'stalled' I did also try martaans driver, which was added to wine, and latency was much lower, and the controller worked well within Linux, in fact the first time i've actually been able to use it with pulseaudio. I was measuring latency much lower than I expected, 2-4ms. With Andrew's Driver I was not even able to play a timecode from start to finish without 'stalled' buffers. Please Take the time to QA this driver for things just other than 'cos we have it' and consider Martaan's driver as well, because there is a massive improvement in latency over Andrews, and applications requiring fire-wire work much nicer with pulseaudio. My Wine build is 1.5.4, Gentoo 3.4.2-r1. Thanks Darryl

1 0

Re: mshtml: Implement IHTMLScriptElement_put_src
by Jacek Caban June 18, 2012

June 18, 2012

André, On 06/15/12 23:45, André Hentschel wrote: > --- > dlls/mshtml/htmlscript.c | 14 ++++++++++++-- > dlls/mshtml/tests/dom.c | 6 ++++++ > 2 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/htmlscript.c b/dlls/mshtml/htmlscript.c > index 376db7b..1714cfe 100644 > --- a/dlls/mshtml/htmlscript.c > +++ b/dlls/mshtml/htmlscript.c > @@ -101,8 +101,18 @@ static HRESULT WINAPI HTMLScriptElement_Invoke(IHTMLScriptElement *iface, DISPID > static HRESULT WINAPI HTMLScriptElement_put_src(IHTMLScriptElement *iface, BSTR v) > { > HTMLScriptElement *This = impl_from_IHTMLScriptElement(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_w(v)); > - return E_NOTIMPL; > + nsAString src_str; > + nsresult nsres; > + > + TRACE("(%p)->(%s)\n", This, debugstr_w(v)); > + > + nsAString_Init(&src_str, v); > + nsres = nsIDOMHTMLScriptElement_SetSrc(This->nsscript, &src_str); > + if (NS_FAILED(nsres)) > + ERR("SetSrc failed: %08x\n", nsres); > + nsAString_Finish (&src_str); > + > + return S_OK; > } > Unfortunately it's not so easy. That won't work this way. Jacek

1 0

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)
by Alexandre Julliard June 18, 2012

June 18, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE { > > /* From 0 to 4 */ > UCHAR LayerNumber; > -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE; > +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE; > + > +typedef struct _DVD_DESCRIPTOR_HEADER { > + USHORT Length; > + UCHAR Reserved[2]; > +#if !defined(_midl) > + UCHAR Data[0]; > +#endif > +} DVD_DESCRIPTOR_HEADER, *PDVD_DESCRIPTOR_HEADER; > +C_ASSERT(sizeof(DVD_DESCRIPTOR_HEADER) == 4); Zero-size arrays are not portable and should be avoided. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] wbemprox: Add tests for IWbemServices.
by Marvin June 18, 2012

June 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19208 Your paranoid android. === WNT4WSSP6 (32 bit services) === services.c:38: Test failed: failed to create IWbemLocator interface 80040154 services: unhandled exception c0000005 at 004019EE

1 0

Re: [2/2] comdlg32/tests: Test file name selection on init
by Marvin June 17, 2012

June 17, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19196 Your paranoid android. === WNT4WSSP6 (32 bit filedlg) === Timeout === W2KPROSP4 (32 bit filedlg) === Timeout === WXPPROSP3 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 7C809E32 === W2K3R2SESP2 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 77E63110 === WVISTAADM (32 bit filedlg) === filedlg: unhandled exception c0000005 at 76A75031 === W2K8SE (32 bit filedlg) === filedlg: unhandled exception c0000005 at 76285DBE === W7PRO (32 bit filedlg) === filedlg.c:1158: Test failed: The EM_GETSEL message returned with no selection

1 0

Re: [PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test
by Nikolay Sivov June 17, 2012

June 17, 2012

On 6/17/2012 13:11, Alexandre Goujon wrote: > > case DvdManufacturerDescriptor: > + nt_desc.manf->Header.Length = 0x0802; > + nt_desc.manf->Header.Reserved[0] = 0; > + nt_desc.manf->Header.Reserved[1] = 0; Does this length mean something? Looks a bit dirty to leave hardcoded things like that, but maybe I don't know details.

2 1

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)
by Nikolay Sivov June 17, 2012

June 17, 2012

On 6/17/2012 13:11, Alexandre Goujon wrote: > Superseeds the patch of the same name (#87003) > Definition and assert taken from Windows Driver Kit (WDK) 8 Consumer Preview > --- > include/ddk/ntddcdvd.h | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/include/ddk/ntddcdvd.h b/include/ddk/ntddcdvd.h > index 5313496..d0178c7 100644 > --- a/include/ddk/ntddcdvd.h > +++ b/include/ddk/ntddcdvd.h > @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE { > > /* From 0 to 4 */ > UCHAR LayerNumber; > -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE; > +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE; > + > +typedef struct _DVD_DESCRIPTOR_HEADER { > + USHORT Length; > + UCHAR Reserved[2]; > +#if !defined(_midl) > + UCHAR Data[0]; > +#endif > +} DVD_DESCRIPTOR_HEADER, *PDVD_DESCRIPTOR_HEADER; > +C_ASSERT(sizeof(DVD_DESCRIPTOR_HEADER) == 4); This looks wrong, correct name for it __midl, and this also needs a check for __WIDL__ probably.

2 1

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines.
by Dmitry Timoshkov June 17, 2012

June 17, 2012

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > - static const struct test_data > + const int font[] = > { > - int id, weight, height, dpi; > + ANSI_FIXED_FONT, ANSI_VAR_FONT, SYSTEM_FONT, DEVICE_DEFAULT_FONT, DEFAULT_GUI_FONT > + /* SYSTEM_FIXED_FONT, OEM_FIXED_FONT */ > + }; > + const struct test_data > + { Please add back 'static' to test_data and add it to font. -- Dmitry.

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Maarten Lankhorst June 16, 2012

June 16, 2012

What happened to the stamped capture buffers? Why is held_frames added? This doesn't look like an attempt to get my driver in, it looks like a rewrite by someone who doesn't understand why I made the design decisions I made for correctness. If you don't paste all the mmdevapi tests with the fix in my git tree, it's a regression. I don't want to see held_Frames because it's a shadow buffer. If winmm and dsound don't work without it, they're wrong, fix those. The logic I kept for timestamping audio buffers was removed which just makes timestamping less accurate on capture buffers. Was this driver even tested on low latency? There was a reason I kept track of all packets in a linked list, no need to do held_frames logic. I genuinely do want a good driver to go in, but this just isn't it. There is also no reason to have an INCREASED period size for exclusive compared to shared. I'm currently not handling exclusive because there are no good tests for it. and "hooray_cb" ? If this is going to be accepted (likely, sadly) I want to have this added to the commit: Rejected-by: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> ~Maarten PS: Still sad that you chose to reject my original driver not based on any merits.

1 0

Re: [PATCH] sfnt2fnt: Fix broken .fon files on !x86 architectures
by Alexandre Julliard June 15, 2012

June 15, 2012

Hilko Bengen <bengen(a)hilluzination.de> writes: > @@ -46,6 +46,8 @@ > > #include "pshpack1.h" > > +#include <endian.h> endian.h is not portable, you should use the endianness defines from the Wine headers instead. -- Alexandre Julliard julliard(a)winehq.org

4 9

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver
by Alexandre Julliard June 15, 2012

June 15, 2012

Andrew Eikum <aeikum(a)codeweavers.com> writes: > The configure.ac changes and parts of the driver itself were written by > Maarten Lankhorst. It doesn't work here, it's apparently using the driver even though PulseAudio is not running on this box: ../../../tools/runtest -q -P wine -M amstream.dll -T ../../.. -p amstream_test.exe.so amstream.c && touch amstream.ok err:pulse:AudioClient_Initialize PulseAudio no longer running? err:quartz:DSoundRender_create Cannot create Direct Sound object (88890010) fixme:ole:CoCreateInstance no instance created for interface {56a86895-0ad4-11ce-b03a-0020af0ba770} of class {79376820-07d0-11cf-a24d-0020afd79767}, hres is 0x88890010 amstream.c:274: Test failed: IAMMultiMediaStream_AddMediaStream returned: 88890010 -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH 1/4] DSS Test Suite: CryptAcquireContext tests for base DSS
by Alexandre Julliard June 15, 2012

June 15, 2012

Marek Chmiel <kcmark(a)gmail.com> writes: > From 748332765355ae099ab24cf1402bed86610984e7 Mon Sep 17 00:00:00 2001 > From: Marek Chmiel <kcmark(a)gmail.com> > Date: Fri, 1 Jun 2012 22:38:03 -0500 > Subject: [PATCH 1/4] Add CryptAcquireContext tests for base DSS CSP. > > --- > configure | 1 + > configure.ac | 1 + > dlls/dssenh/tests/Makefile.in | 7 +++ > dlls/dssenh/tests/dssenh.c | 119 +++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 128 insertions(+) > create mode 100644 dlls/dssenh/tests/Makefile.in > create mode 100644 dlls/dssenh/tests/dssenh.c You are adding 4 almost identical copies of that code. Try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2 resend] advapi32: Pass service name as argv[0] to ServiceMain
by Alexandre Julliard June 15, 2012

June 15, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > Resend with tests. > > --- > dlls/advapi32/service.c | 3 +-- > programs/services/tests/service.c | 4 ++++ > 2 files changed, 5 insertions(+), 2 deletions(-) You will now get the name twice for autostart services. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).
by Alexandre Julliard June 15, 2012

June 15, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > + while(min <= max) > + { > + const char *encoded_symbol; > + > + pos = (min+max)/2; > + encoded_symbol = html_encoded_symbols[pos].html_code; > + dir = strncmp(encoded_symbol, amp, len); You need to check the length, strncmp is not enough. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mmcndmgr: Implement IMMCVersionInfo (try 3)
by Marvin June 15, 2012

June 15, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19090 Your paranoid android. === WNT4WSSP6 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000 === W2KPROSP4 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000

1 0

Re: ru.po: improved an Russian translation
by Oleg Yarigin June 15, 2012

June 15, 2012

Hi, Julian! > 1. Patches should be sent to wine-patches(a)winehq.org, not wine-devel. Thank you a lot, I didn't know these address! > I don't think that's a good idea... Afaik, the general guideline is to > not change formatting and punctuation (from the English original), > unless there's a rule in the Russian language that specifically > dictates it. In Russian there is different from English punctuation. We create a tool for humans, not machines, don't we? So, we must improve a punctuation according to a language's rules. Instead, I send my improves to Nikolay, as you recommended. > A normal, UTF-8 formatted textfile as an attachment ... should suffice, > you shouldn't need to pack it. > I guess an archive could also confuse the automated scripts I packed it to decrease a size. But if it isn't good for merging, I willn't do it. > Please understand this as constructive criticism, it will help getting > your patch accepted and not cause extra work for the maintainer > (Alexandre). It looks like you invested a lot of effort, thanks for > that. No, that's OK. There isn't something bad in constructive criticism, I think. --- Best regards, Oleg. P. S. I didn't know how to post messages into pipemail, so I replied privetly. There is a copy of my answer.

1 0

Re: [05/11] windowscodecs: Add support for more types of IFD fields. Resend.
by Alexandre Julliard June 15, 2012

June 15, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -650,30 +672,43 @@ static HRESULT load_IFD_entry(IStream *input, const struct IFD_entry *entry, > SWAP_ULONG(count); > type = entry->type; > SWAP_USHORT(type); > + item->value.vt = tag_to_vt(type); > value = entry->value; > SWAP_ULONG(value); > > switch (type) > { > + case IFD_BYTE: > + case IFD_SBYTE: > + if (count == 1) > + { > + item->value.u.bVal = *(BYTE *)&value; > + break; > + } > + FIXME("loading multiple byte fields is not implemented\n"); > + break; This seems to contradict the endianness support. Are you really supposed to byte-swap arrays of bytes? -- Alexandre Julliard julliard(a)winehq.org

2 1

RFC: comdlg32: Fix null lpstrFile uses in FILEDLG95_OnOpen
by Bruno Jesus June 15, 2012

June 15, 2012

Hi, I have written a patch to fix bug 17229 and would like to request help to complete the test part. The test creates a common dialog and select a filename (file does not need to exist), it was copied from other tests in the same file (comdlg32/tests/filedlg.c). It's not possible to have a default file name because lpstrFile is used to do this and it's NULL. To fill a filename in the common dialog control that appears I have used EnumChildWindows to find the textbox and set the filename in it. The main problem is how to detect that a HWND is a textbox? Currently I'm sending SetWindowText to every control and that does work but I think the patch may be rejected by that. The patch can be downloaded at: https://testbot.winehq.org/JobDetails.pl?Key=19074 The problem is in the line 56. Thanks in advance, Bruno

1 0

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).
by Alexandre Julliard June 14, 2012

June 14, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. As of version > 3 of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and it also includes some additional cleanup. It > is important to note that HTML Help only supports characters within > the ANSI code pages, so support for multi-byte characters is not > necessary. I don't see why you'd want to use ANSI code pages for this, since they will be converted to Unicode anyway. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: msvcrt/tests: Fix portuguese locale test on NT4
by Marvin June 14, 2012

June 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19045 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: msvcrt: Fix the name of the Portuguese locale alias.
by Bruno Jesus June 14, 2012

June 14, 2012

On Wed, Jun 13, 2012 at 2:47 PM, Francois Gouget <fgouget(a)free.fr> wrote: > ... > dlls/msvcrt/locale.c | 2 +- > dlls/msvcrt/tests/locale.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > ... > - "portugese", "ptb", > + "portuguese", "ptb", Just a side note. Although I'm not sure I think portuguese is "ptg", brazilian portuguese is "ptb". So the correct may be: > + "portuguese", "ptg", A Portugal user would be able to check that, or maybe it's easier to write a testcase. If I'm wrong I ask apologies in advance, Bruno

3 2

DllMain() seems unused in ntoskrnl.exe
by Francois Gouget June 14, 2012

June 14, 2012

The DllMain() function in ntoskrnl.exe appears to be unused: making it static causes a compiler warning to that effect and removing it entirely does not cause a compilation failure. Should it be removed or is there a build issue with ntoskrnl.exe? diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index 2b84297..ffeb2f8 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -1711,30 +1711,6 @@ VOID WINAPI IoInitializeRemoveLockEx(PIO_REMOVE_LOCK lock, ULONG tag, } /***************************************************** - * DllMain - */ -BOOL WINAPI DllMain( HINSTANCE inst, DWORD reason, LPVOID reserved ) -{ - static void *handler; - LARGE_INTEGER count; - - switch(reason) - { - case DLL_PROCESS_ATTACH: - DisableThreadLibraryCalls( inst ); -#ifdef __i386__ - handler = RtlAddVectoredExceptionHandler( TRUE, vectored_handler ); -#endif - KeQueryTickCount( &count ); /* initialize the global KeTickCount */ - break; - case DLL_PROCESS_DETACH: - RtlRemoveVectoredExceptionHandler( handler ); - break; - } - return TRUE; -} - -/***************************************************** * Ke386IoSetAccessProcess (NTOSKRNL.EXE.@) */ BOOLEAN WINAPI Ke386IoSetAccessProcess(PEPROCESS *process, ULONG flag) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Be careful of reading health books, you might die of a misprint. -- Mark Twain

2 1

Re: [11/11] windowscodecs: Implement GetMetadataFormat. Resend.
by Dmitry Timoshkov June 14, 2012

June 14, 2012

Please ignore this patch, it doesn't really belong to this series, and correct implementation should use MetadataReaderInfo interface instead. -- Dmitry.

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19010 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19009 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19007 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] windowscodecs: Add stub IWICMetadataBlockReader to PNG decoder.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19006 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.
by Nikolay Sivov June 13, 2012

June 13, 2012

On 6/12/2012 11:52, Ulrik Dickow wrote: > Patch 1 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . > > > > +static void test_namespaces_change(int doc_version) > +{ > + IXMLDOMDocument *doc; > + IXMLDOMElement *elem; > + IXMLDOMNode *node; > + > + VARIANT var; > + HRESULT hr; > + BSTR str; > + > + /* create on element and try to alter namespace after that */ > + doc = (doc_version == 0 ? > + create_document(&IID_IXMLDOMDocument) : > + create_document_version(60, &IID_IXMLDOMDocument)); > + if (!doc) return; Please use something like CLSID array with every available Document CLSID, instead of only testing 2 of them. There's a lot of examples for that in saxreader.c. > + test_namespaces_change(0); > + test_namespaces_change(60); > > free_bstrs(); > } It's better to avoid nested test calls like that imho, you could just add another call in main test list. > +static void test_namespaces_change(int doc_version) > +{ > + IXMLDOMDocument *doc; > + IXMLDOMElement *elem; > + IXMLDOMNode *node; ... > + > + IXMLDOMElement_Release(elem); > + IXMLDOMDocument_Release(doc); > +} > + When this is running on all CLSIDs please add free_bstrs() here.

3 4

Re: d3dx9_36: D3DXQuaternionLn computes as if the norm of the input is 1
by Matteo Bruni June 13, 2012

June 13, 2012

2012/6/12 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > > + if ( (pq->w >= 1.0f) || (pq->w == -1.0f) ) I think the second comparison should be '<=', if you want to avoid getting NaNs.

2 2

Re: wined3d: Avoid sizeof on structs with variable length arrays.
by Henri Verbeet June 13, 2012

June 13, 2012

On 13 June 2012 10:41, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, FIELD_OFFSET(struct wined3d, adapters[1])); That's not really a VLA, just a somewhat stupid array of size 1.

2 2

Misspelt Portuguese in msvcrt
by Francois Gouget June 13, 2012

June 13, 2012

Is there a reason why Portuguese is misspelt in these two places? diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index 97b82ec..b26a9c8 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -85,7 +85,7 @@ static const char * const _country_synonyms[] = "german-swiss", "des", "italian-swiss", "its", "german-austrian", "dea", - "portugese", "ptb", + "portuguese", "ptb", "portuguese-brazil", "ptb", "spanish-mexican", "esm", "norwegian-bokmal", "nor", diff --git a/dlls/msvcrt/tests/locale.c b/dlls/msvcrt/tests/locale.c index 8d6a34f..638a3d2 100644 --- a/dlls/msvcrt/tests/locale.c +++ b/dlls/msvcrt/tests/locale.c @@ -472,7 +472,7 @@ static void test_setlocale(void) if(ret) ok(!strcmp(ret, "Polish_Poland.1250"), "ret = %s\n", ret); - ret = setlocale(LC_ALL, "portugese"); + ret = setlocale(LC_ALL, "portuguese"); ok(ret != NULL || broken (ret == NULL), "ret == NULL\n"); if(ret) ok(!strcmp(ret, "Portuguese_Brazil.1252"), "ret = %s\n", ret); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ E-Voting: Those who cast the votes decide nothing. Those who count the votes decide everything.

2 1

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 3).
by Jacek Caban June 13, 2012

June 13, 2012

Hi Erich, On 06/12/12 19:03, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and some additional cleanup. It is important to > note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. Many > apologizes to Jacek Caban for missing some of his comments in his > original reply. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. The patch looks much better. There is one remaining problem: + int pos = sizeof(html_encoded_symbols)/sizeof(html_encoded_symbols[0]); + float step = pos/2; + int dir = +1; + + do + { + const char *encoded_symbol; + + pos += -dir*ceil(step); Using float here is definitely not needed, esp. that you always use ceil() on it. You've made it more complicated than it really is. See [1] for an example. Also feel free to send linear search with FIXME comment. That's fine for the first iteration patch. Jacek [1] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/mshtml/dispex.c#l709

1 0

Re: [11/11] windowscodecs: Implement GetMetadataFormat.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18989 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd

1 0

Re: [10/11] windowscodecs: Handle IFD fields with count 0 same way as with count 1.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18988 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd

1 0

Re: [09/11] windowscodecs: Add support for IFD_UNDEFINED field type.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18987 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd

1 0

Re: [08/11] windowscodecs: Add tests for more types of IFD fields.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18986 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd

1 0

Re: po: Update Russian translation (try 3) (resend)
by Francois Gouget June 13, 2012

June 13, 2012

msgid "KeyID=" -msgstr "Код ключа=" +msgstr "Код ключа: " [...] msgid "Other Name=" -msgstr "Другое имя=" +msgstr "Альтернативное имя: " and many more like this. Why did you not fix this? Replacing the equal sign with a colon looks wrong to me but then I don't speak Russian. Still I have not seen anything to suggest that the typographic rules would be different in this regard. But Nikolay Sivov, who speaks Russian, seems to concur. Note that this was reported to you back in May: http://www.winehq.org/pipermail/wine-devel/2012-May/095672.html -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

1 0

Re: [PATCH 4/5] wined3d: Set undefined vertex attributes to 0.0.
by Stefan Dösinger June 12, 2012

June 12, 2012

Am Dienstag, 12. Juni 2012, 17:03:49 schrieb Henri Verbeet: > + if (state->vertex_shader->reg_maps.input_registers & (1 << i)) > + GL_EXTCALL(glVertexAttrib4fARB(i, 0.0f, 0.0f, 0.0f, 0.0f)); Does an application need this? Afair Windows drivers have implementation- specific behavior here that pretty much matches their GL counterparts.

1 0

re: Command line parameters
by Dan Kegel June 12, 2012

June 12, 2012

John asked > [ How do I launch Windows apps from Unix apps and pass filenames to them?] > execl (the_path_to_wine, "wine", path_to_the_windows_program, command_line_parameter_for_windows_app, NULL); Relative unix paths will often work with Windows apps, but in general, you will have to translate command_line_parameter_for_windows_app, and any paths that appear in data files, from Unix to Windows before launching the app. The winepath utility may help there, or you can translate them yourself once you know how Wine maps filenames. Also, I recall being in a situation where I had to put the commandline in a batch file and do wine cmd.exe /c foo.bat because there wasn't another other way to make the windows app happy... something about the commandline that made me need to use CreateProcess, and cmd.exe was the easiest way to use CreateProcess. - Dan

5 10

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 2).
by Jacek Caban June 12, 2012

June 12, 2012

Hi Erich, On 06/11/12 21:01, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control. It is important > to note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. You didn't address most of my comments. Feel free to ask for clarifications if something was not clear enough. Jacek

2 1

Re: configure.ac: Get the needed libs from cups-config (for OpenBSD)
by Alexandre Julliard June 12, 2012

June 12, 2012

André Hentschel <nerv(a)dawncrow.de> writes: > Inspired by Matias Colli, see bug 17896. > I made sure it doesn't hurt on other OS and send it because it doesn't seem he will do it and it's a oneliner. It doesn't work for me on Debian testing, not without manually creating symlinks for the libs that cups-config requires. It sounds like OpenBSD should fix their libcups build. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ntprint: Do not fail when the spooler service was stopped
by Alexandre Julliard June 12, 2012

June 12, 2012

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -88,22 +92,25 @@ static void test_PSetupDestroyMonitorInfo(VOID) > { > HANDLE mi; > > - > SetLastError(0xdeadbeef); > pPSetupDestroyMonitorInfo(NULL); > - /* lasterror is returned */ > - trace("returned with %u\n", GetLastError()); > + /* lasterror is untouched */ > + ok(GetLastError() == 0xdeadbeef, "returned with 0x%x\n", GetLastError()); Testing last error on success is not useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] msi/tests: Use only uppercase characters for the PID_REVNUMBER property.
by Marvin June 12, 2012

June 12, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18972 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH] loader: On Mac OS, don't use external symbols for the DOS and shared heap segments.
by Alexandre Julliard June 11, 2012

June 11, 2012

Charles Davis <cdavis(a)mymail.mines.edu> writes: > My first idea was to just add some '.globl' directives in the code. But > then I asked myself: why are we using an indirect symbol at all? Why are > we treating this like an external symbol when it clearly isn't? So now, > the arrays are declared static, and their owning section is explicitly > declared to the C compiler. While compile times have gone up, at least > the compiled loader executable actually works. This core dumps instantly when build with gcc on Mac OS 10.5, and doesn't even compile on 10.6. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] winspool: Install the ppd files into the driver directory.
by Alexandre Julliard June 11, 2012

June 11, 2012

Huw Davies <huw(a)codeweavers.com> writes: > @@ -488,18 +638,70 @@ static void *cupshandle; > DO_FUNC(cupsGetPPD); \ > DO_FUNC(cupsParseOptions); \ > DO_FUNC(cupsPrintFile); > +#define CUPS_OPT_FUNCS \ > + DO_FUNC(cupsGetPPD3); > > #define DO_FUNC(f) static typeof(f) *p##f > CUPS_FUNCS; > +CUPS_OPT_FUNCS; > #undef DO_FUNC This still requires the function to be defined: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_SPOOL32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/usr/local/include/freetype2 -I/usr/local/include -g -O2 -o info.o info.c info.c:732: error: 'cupsGetPPD3' undeclared here (not in a function) info.c:732: warning: type defaults to 'int' in declaration of 'pcupsGetPPD3' info.c: In function 'cupsGetPPD3_wrapper': info.c:741: error: called object 'pcupsGetPPD3' is not a function info.c: In function 'get_cups_ppd': info.c:771: error: 'CUPS_HTTP_DEFAULT' undeclared (first use in this function) info.c:771: error: (Each undeclared identifier is reported only once info.c:771: error: for each function it appears in.) make[1]: *** [info.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: po: Update Russian translation (try 3) (resend)
by Nikolay Sivov June 11, 2012

June 11, 2012

On 6/9/2012 07:43, Oleg Yarigin wrote: > To avoid encode breaks I send a patch as an attachment. > > I packed it into *.GZ archive, becouse (I suppose so) some > intermediate servers can block messages with big attachments. > > Please split it to several patches with changes grouped by some criteria, it's really hard to review when it's that long.

1 0

Re: po: Update Italian translation
by Matteo Bruni June 11, 2012

June 11, 2012

Hi Luca, just a couple of nitpicks: -"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a href=" -"\"http://wiki.winehq.org/Gecko\">http://wiki.winehq.org/Gecko</a> per i " -"dettagli." +"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a " +"href=\"http://wiki.winehq.org/Mono\">http://wiki.winehq.org/Mono</a> " +"per i dettagli." This sounds a bit awkward, I'd go for something like "Nota: si raccomanda di usare i pacchetti forniti dalla tua distribuzione." #: cryptui.rc:413 -#, fuzzy -#| msgid "&Personal Information Exchange/PKCS #12 (.pfx)" msgid "&Personal Information Exchange/PKCS #12 (*.pfx)" -msgstr "Scambia di Informazioni &Personali/PKCS #12 (.pfx)" +msgstr "Scambia di Informazioni &Personali/PKCS #12 (*.pfx)" "Scambio". #: joy.rc:33 msgid "Joysticks" -msgstr "" +msgstr "Joysticks" I'm quite sure foreign words are always wrote in singular form in Italian language, so this would be "Joystick".

1 0

Re: [1/4] msi: Add support for 64-bit registry components. (resend)
by Marvin June 11, 2012

June 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18942 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH 1/4] kernel32/tests: Move a cdrom test to its own file
by Alexandre Julliard June 11, 2012

June 11, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > The cdrom test file will be used to test ioctl (results, structure size...) > Each drive is tested and skipped gracefully if ioctl not supported or not a CDROM drive. I don't see a need for a new file, particularly since disk extents are not CDROM-specific. But even DVD ioctls can be tested in volume.c. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Alexandre Julliard June 11, 2012

June 11, 2012

Andrew Eikum <aeikum(a)codeweavers.com> writes: > There's a lengthy comment in ready_pulse() describing why we're using > pthreads syncro primitives instead of Win32 primitives. I was under > the impression (thanks to the CoreAudio driver, mostly) that threads > not created through CreateThread() cannot use CRITICAL_SECTION, ERR, > WARN, TRACE, and so on. However, when I was testing, I noticed that > debug printing _does_ work in callbacks from the pthread thread. You can't do that, you need to create a proper Win32 thread, and solve the loader lock issue some other way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] loader: On Mac OS, don't emit a __PAGEZERO segment.
by Alexandre Julliard June 11, 2012

June 11, 2012

Charles Davis <cdavis(a)mymail.mines.edu> writes: > This is the reason we couldn't put the WINE_DOS segment at address 0. We don't need page zero, we don't run DOS apps on the Mac. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2 resend] wininet: Added InternetGetSecurityInfoByURL tests
by Marvin June 11, 2012

June 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18940 Your paranoid android. === W2K8SE (32 bit http) === http.c:533: Test failed: req_error = 12007 http.c:544: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:557: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:558: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:559: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:560: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:569: Test failed: flags = 8, expected 0 http.c:657: Test failed: Returned zero size in response to request complete http.c:269: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:533: Test failed: req_error = 12007 http.c:557: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:558: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:559: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:560: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:562: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:569: Test failed: flags = 8, expected 0 http.c:583: Test failed: Wrong URL http://test.winehq.org/tests/redirect http.c:657: Test failed: Returned zero size in response to request complete http.c:269: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:269: Test failed: unexpected status 11 (INTERNET_STATUS_NAME_RESOLVED)

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Dmitry Timoshkov June 11, 2012

June 11, 2012

Andrew Eikum <aeikum(a)codeweavers.com> wrote: > configure.ac | 31 +- > dlls/mmdevapi/main.c | 4 +- > dlls/winepulse.drv/Makefile.in | 9 + > dlls/winepulse.drv/mmdevdrv.c | 3216 +++++++++++++++++++++++++++++++++ > dlls/winepulse.drv/winepulse.drv.spec | 5 + > 5 files changed, 3261 insertions(+), 4 deletions(-) > create mode 100644 dlls/winepulse.drv/Makefile.in > create mode 100644 dlls/winepulse.drv/mmdevdrv.c > create mode 100644 dlls/winepulse.drv/winepulse.drv.spec How does it follow the Alexandre's requirement to split the patch into smaller pieces before submitting? -- Dmitry.

1 0

Re: [PATCH] kernel32: Don't use putenv(3) on temporary strings.
by Ken Thomases June 10, 2012

June 10, 2012

The putenv() calls occur in a forked grandchild process just before an exec(). The strings are sure to survive the current process image. After that, it's the kernel's problem. Regards, Ken On Jun 10, 2012, at 11:47 AM, Charles Davis wrote: > The Darwin manpage for putenv() warns that it no longer makes a copy of > its input, but directly stores the pointer in environ. Wine was passing > stack- and heap-allocated strings to putenv(), which could have caused a > crash. We were very lucky it didn't. Instead, use setenv(3), which still > copies its inputs. > > Found while tracking down an insidious bug in Clang-built optimized > (-O2) Wine. > --- > dlls/kernel32/process.c | 24 +++++++++++------------- > 1 files changed, 11 insertions(+), 13 deletions(-) > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index 42716c2..1ec3e3d 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -1741,17 +1741,14 @@ static const char *get_alternate_loader( char **ret_env ) > int len = strlen( loader_env ); > if (!is_win64) > { > - if (!(env = HeapAlloc( GetProcessHeap(), 0, sizeof("WINELOADER=") + len + 2 ))) return NULL; > - strcpy( env, "WINELOADER=" ); > - strcat( env, loader_env ); > + if (!(env = HeapAlloc( GetProcessHeap(), 0, len + 2 ))) return NULL; > + strcpy( env, loader_env ); > strcat( env, "64" ); > } > else > { > - if (!(env = HeapAlloc( GetProcessHeap(), 0, sizeof("WINELOADER=") + len ))) return NULL; > - strcpy( env, "WINELOADER=" ); > - strcat( env, loader_env ); > - len += sizeof("WINELOADER=") - 1; > + if (!(env = HeapAlloc( GetProcessHeap(), 0, len ))) return NULL; > + strcpy( env, loader_env ); > if (!strcmp( env + len - 2, "64" )) env[len - 2] = 0; > } > if (!loader) > @@ -1860,14 +1857,14 @@ static pid_t exec_loader( LPCWSTR cmd_line, unsigned int flags, int socketfd, > /* Reset signals that we previously set to SIG_IGN */ > signal( SIGPIPE, SIG_DFL ); > > - sprintf( socket_env, "WINESERVERSOCKET=%u", socketfd ); > - sprintf( preloader_reserve, "WINEPRELOADRESERVE=%lx-%lx", > + sprintf( socket_env, "%u", socketfd ); > + sprintf( preloader_reserve, "%lx-%lx", > (unsigned long)binary_info->res_start, (unsigned long)binary_info->res_end ); > > - putenv( preloader_reserve ); > - putenv( socket_env ); > - if (winedebug) putenv( winedebug ); > - if (wineloader) putenv( wineloader ); > + setenv( "WINESERVERSOCKET", socket_env, 1 ); > + setenv( "WINEPRELOADRESERVE", preloader_reserve, 1 ); > + if (winedebug) setenv( "WINEDEBUG", winedebug, 1 ); > + if (wineloader) setenv( "WINELOADER", wineloader, 1 ); > if (unixdir) chdir(unixdir); > > if (argv) > @@ -1976,6 +1973,7 @@ static BOOL create_process( HANDLE hFile, LPCWSTR filename, LPWSTR cmd_line, LPW > static const WCHAR WINEDEBUG[] = {'W','I','N','E','D','E','B','U','G','=',0}; > if (!winedebug && !strncmpW( env_end, WINEDEBUG, sizeof(WINEDEBUG)/sizeof(WCHAR) - 1 )) > { > + env_end += sizeof(WINEDEBUG)/sizeof(WCHAR) - 1; > DWORD len = WideCharToMultiByte( CP_UNIXCP, 0, env_end, -1, NULL, 0, NULL, NULL ); > if ((winedebug = HeapAlloc( GetProcessHeap(), 0, len ))) > WideCharToMultiByte( CP_UNIXCP, 0, env_end, -1, winedebug, len, NULL, NULL ); > -- > 1.7.5.4 > > >

1 0

Re: [PATCH 4/4] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdCopyrightDescriptor) test
by Marvin June 10, 2012

June 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18927 Your paranoid android. === W2KPROSP4 (32 bit cdrom) === cdrom.c:85: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87

1 0

Re: [PATCH 3/4] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) test
by Marvin June 10, 2012

June 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18926 Your paranoid android. === W2KPROSP4 (32 bit cdrom) === cdrom.c:84: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87

1 0

Re: [PATCH 1/5] hhctrl.ocx: Add HTML to Unicode parsing capability.
by Jacek Caban June 10, 2012

June 10, 2012

Hi Erich, On 06/07/12 23:09, Erich E. Hoover wrote: > + /* Post the HTML text to the document */ > + array = SafeArrayCreateVector(VT_VARIANT, 0, 1); > + if(!array) > + goto cleanup; > + hr = SafeArrayAccessData(array, (LPVOID*)&array_param); > + if (FAILED(hr)) > + goto cleanup; > + V_VT(array_param) = VT_BSTR; > + V_BSTR(array_param) = SysAllocString(html_fragment); > + hr = SafeArrayUnaccessData(array); > + if (FAILED(hr)) > + goto cleanup; > + hr = IHTMLDocument2_write(html_parsing_doc, array); Did you test indexes like '<script>alert("really!?")</script>' ? :) Seriously, HTMLDocument is not the right tool for the job. Cheers, Jacek

2 4

Re: Patch 1/2 - [scrrun] - Add initial support for Dictionary - try 2
by Jacek Caban June 10, 2012

June 10, 2012

Hi Vijay, On 06/08/12 03:15, Vijay Kiran Kamuju wrote: > + *ppvObject = NULL; > + if ( IsEqualGUID( riid, &IID_IDictionary ) || > + IsEqualGUID( riid, &IID_IPersist ) || > + IsEqualGUID( riid, &IID_IDispatch ) || > + IsEqualGUID( riid, &IID_IUnknown ) ) > + { > + *ppvObject = This; > + } That's not the right way to cast object to interface. See http://wiki.winehq.org/COMGuideline Cheers, Jacek

2 2

joy.cpl icon
by Joel Holdsworth June 10, 2012

June 10, 2012

Hi All, I've just submitted an icon for joy.cpl to wine-patches. Unfortunatly I've uncovered a problem with the buildimage script. When I first wrote the script, I used the "rsvg" command to convert svg to png. rsvg has been depreciated in favour of rsvg-convert, which has slightly different semantics: rsvg-convert in.svg > out.png instead of rsvg in.svg out.png Moving over to rsvg-convert is trivial of course, except one question. Is it present on enough platforms? I'm using Ubunut 12.04. Is maintainer mode meant to work on Debian Squeeze? We could support both, but I'd rather not do that. Joel

2 1

re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.
by Dan Kegel June 8, 2012

June 8, 2012

-#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) +#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (defined(HAVE_STRUCT_IPSTAT_IPS_TOTAL) || defined(HAVE_STRUCT_IP_STATS_IPS_TOTAL)) Isn't this a no-op? I thought that an undefined symbol was treated as false by the preprocessor. When I compile #if defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) defined #else not defined #endif with gcc -E or cl /E, I get not defined

3 4

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests
by Alexandre Julliard June 8, 2012

June 8, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/wininet/tests/Makefile.in | 2 +- > dlls/wininet/tests/http.c | 38 > ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 39 insertions(+), 1 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:3020: Test failed: InternetGetSecurityInfoByURLA returned: 1(12028), exected 12028 http.c:3153: Test failed: InternetGetSecurityInfoByURLA returned: 1(997), exected 12028 make[1]: *** [http.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests
by Marvin June 8, 2012

June 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18903 Your paranoid android. === W7PROX64 (32 bit http) === http.c:3293: Test failed: HttpSendRequest failed: 12002

2 1

Re: msxml3: Implement IXMLParser Get/Set Flags
by Marvin June 8, 2012

June 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18891 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [PATCH 4/4] mshtml: Added IWindowForBindingUI tests
by Marvin June 8, 2012

June 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18890 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/4] windowscodecs: Add WICIfdMetadataReader registration. Resend.
by Marvin June 8, 2012

June 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18888 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Re: Patch 2/2 - [scrrun] - Add initial tests for Dictionary - resend
by Marvin June 8, 2012

June 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18875 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 1/1] shell32: Fix FindExecutable search path when a default directory is supplied.
by Marvin June 7, 2012

June 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18869 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1336: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\System32\notepad.exe] shlexec.c:1342: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\System32\notepad.exe] === W2KPROSP4 (32 bit shlexec) === shlexec.c:1336: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\system32\notepad.exe] shlexec.c:1342: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\system32\notepad.exe]

1 0

Re: [4/5] propsys: Implement IPropertyStoreCache::SetState.
by Marvin June 7, 2012

June 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18853 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/5] propsys: Implement IPropertyStoreCache::GetValueAndState.
by Marvin June 7, 2012

June 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18852 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] propsys: Implement IPropertyStoreCache::GetState.
by Marvin June 7, 2012

June 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18851 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] windowscodecs: Implement a better stub for MetadataHandler_GetCount.
by Vincent Povirk June 7, 2012

June 7, 2012

It should be trivial to implement this correctly. On Wed, Jun 6, 2012 at 11:21 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/windowscodecs/metadatahandler.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/windowscodecs/metadatahandler.c b/dlls/windowscodecs/metadatahandler.c > index 013fe04..0ea404b 100644 > --- a/dlls/windowscodecs/metadatahandler.c > +++ b/dlls/windowscodecs/metadatahandler.c > @@ -152,7 +152,8 @@ static HRESULT WINAPI MetadataHandler_GetCount(IWICMetadataWriter *iface, > if (!pcCount) return E_INVALIDARG; > > FIXME("(%p,%p): stub\n", iface, pcCount); > - return E_NOTIMPL; > + *pcCount = 0; > + return S_OK; > } > > static HRESULT WINAPI MetadataHandler_GetValueByIndex(IWICMetadataWriter *iface, > -- > 1.7.10.1 > > >

2 1

Re: [PATCH 1/7] urlmon: Use file content to verify MIME type reported by file protocol handler
by Jacek Caban June 7, 2012

June 7, 2012

On 06/07/12 15:40, Jacek Caban wrote: > --- > dlls/urlmon/file.c | 8 +++++++- > dlls/urlmon/tests/protocol.c | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletions(-) > Please skip this one. I didn't mean to send it in the series. Thanks, Jacek

1 0

Re: mscoree: Use .NET 2.0 for 1.0 assemblies
by Vincent Povirk June 7, 2012

June 7, 2012

I was planning to do something like this eventually, as I was advised on #mono this was the way to go, but I didn't expect it to be that simple. +1. On Thu, Jun 7, 2012 at 4:27 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Mono will use .NET 2.0 when a .NET 1.0/1.1 application is run. > > http://www.mono-project.com/Release_Notes_Mono_2.8 > Find: Removed .NET 1.1 Profile > > > Changelog: > mscoree: Use .NET 2.0 for 1.0 assemblies > > > Best Regards > Alistair Leslie-Hughes > > >

1 0

Re: po: Update Russian translation (try 2)
by Nikolay Sivov June 7, 2012

June 7, 2012

On 6/5/2012 11:16, Архад wrote: Please, configure your mail client to use your real name in sent mails. > > #: appwiz.rc:28 > msgid "Add/Remove Programs" > -msgstr "Установка/удаление программ" > +msgstr "Установка/Удаление программ" Looks better as it is. Only start letter of a sentence supposed to be capital, if it's not a part of some name of course, which is not in this case. > > > #: appwiz.rc:35 shell32.rc:141 shell32.rc:238 regedit.rc:122 winefile.rc:104 > msgid "Name" > -msgstr "Имя" > +msgstr "Название" I don't think so. > > > > #: appwiz.rc:39 > msgid "Programs (*.exe)" > -msgstr "Программы (*.exe)" > +msgstr "Исполняемые файлы (*.exe)" No reason for that. > > #: appwiz.rc:40 avifil32.rc:30 cryptui.rc:80 shell32.rc:196 notepad.rc:73 > #: oleview.rc:101 progman.rc:79 regedit.rc:195 winedbg.rc:39 winhlp32.rc:87 > @@ -248,7 +247,7 @@ msgid "" > "file." > msgstr "" > "Ошибка контрольной суммы загруженного файла. Установка поврежденного файла " > -"отменяется." > +"будет отменена." English string doesn't say that it 'will be aborted', it says 'aborting' which means it's already in process to abort it. > > > > #: comdlg32.rc:157 comdlg32.rc:179 > msgid "&Directories:" > -msgstr "&Каталоги:" > +msgstr "&Папки:" It's better as it is. > > #: comdlg32.rc:160 comdlg32.rc:182 > msgid "List Files of &Type:" > -msgstr "Показывать файлы &типа:" > +msgstr "&Тип файлов:" This doesn't reflect original meaning. > > > > #: comdlg32.rc:282 > msgid "&Red:" > -msgstr "Крас&н:" > +msgstr "Крас&ный:" String length matters for this dialog as I remember. > > > > #: comdlg32.rc:315 comdlg32.rc:336 > msgid "Match &Whole Word Only" > @@ -817,20 +816,18 @@ msgid "" > "File does not exist.\n" > "Do you want to create file?" > msgstr "" > -"Файла не существует.\n" > -"Хотите ли вы его создать?" > +"Файла не существует. Создать?" This supposed to match original line splitting probably. > > > #: comdlg32.rc:68 > msgid "Unknown printer driver." > -msgstr "Неизвестный драйвер принтера." > +msgstr "Неопознанный драйвер принтера." This sounds like 'unknown' from UFO now. > > #: crypt32.rc:55 > msgid "On-line Certificate Status Protocol" > @@ -1371,7 +1367,7 @@ msgstr "Имя SSL-сервера Netscape" > > #: crypt32.rc:67 > msgid "Netscape Comment" > -msgstr "Комментарий Netscape" > +msgstr "Комментарии Netscape" Original word is in singular. ... I'm skipping the rest as it's too much to comment at once, but I think you got the idea how to improve that. Also winerror strings should be left as it is, cause nobody cares much anyway. And please pay attention to actual dialog testing, cause updated strings should fit in.

1 0

Re: Command line parameters
by Hin-Tak Leung June 7, 2012

June 7, 2012

--- On Thu, 7/6/12, John Emmas <johne53(a)tiscali.co.uk> wrote: <snipped> > Is Wine clever enough to realise that the UTF8 string needs to be converted to a locale-specific string, so that the Windows app can understand it? Or does Wine simply pass whatever characters it received, without attempting any translation? Thanks. > John "Use the source, Luke!"... THe relevant code is in dlls/ntdll/file.c and dlls/ntdll/path.c which do the right thing. As a general windows programming note, in windows' land, file path related WIN32 APIs tend to have two variants, those ending with *A, and those ending with *W. The former expects ascii inputs, the latter expects WCHAR (I think it is basically UT16LE). The long answer is that wine leaves the former unchanged (except path separator translation, e.g. from unix "/" to windows "\", adding or removing drive letter prefixes, depending on the direction of translation), but will convert from utf8 to WCHAR for the latter, so that the application itself receives the right thing. It is still up to the application's author to use the right Windows APIs for reading/writing files, and whether the application itself expects ascii file paths or unicode (WCHAR) file paths. The short answer is that wine *does* translate from unix-like to windows-like file paths so that the application receives the right stuff. You have nothing to worry about.

2 1

Command line parameters
by John Emmas June 7, 2012

June 7, 2012

Originally, I was going to post this on wine-users but after I wrote it, it seemed like wine-devel might be more appropriate. Please let me know if I need to re-submit it to wine-users. I understand that Wine is mostly used for running Windows apps on Linux - i.e. in most cases, the user will be launching the Windows app manually. But what about a Linux application that needs to launch a Windows app? What does Wine do (if anything) about command-line parameters..? After using fork() to create a new process, this would be a typical program command to start Wine and the Windows app:- execl (the_path_to_wine, "wine", path_to_the_windows_program, command_line_parameter_for_windows_app, NULL); Notice that execl() passes two command-line parameters to Wine (one of which gets passed to the Windows app). Let's assume this is a file path as that's easy to visualize. In the vast majority of cases, those command-line parameters will get passed to Wine as UTF8 strings. Wine will hopefully understand this when interpreting 'path_to_the_windows_program'. However, Windows programs themselves don't understand UTF8 at all - except for a very limited set of (mostly English) characters. So if that parameter was a file path (e.g. a file that the Windows program needed to open) it would only get understood in an English speaking locale. Non-English characters (accented characters etc) would only get understood if a locale translation takes place. Is Wine clever enough to realise that the UTF8 string needs to be converted to a locale-specific string, so that the Windows app can understand it? Or does Wine simply pass whatever characters it received, without attempting any translation? Thanks. John

1 0

Re: [4/4] windowscodecs: Add WICIfdMetadataReader registration.
by Marvin June 7, 2012

June 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18837 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 2

re: comctl: allow label edit only if treeview style allows editing
by Dan Kegel June 6, 2012

June 6, 2012

> I stopped doing > make test on my machine some time ago Bad developer, no donut :-) > , when I found out that some > tests do consistently fail on my machine (clean prefix or not), and > others consistently hang, thus preventing make test -k. I had the same problem, and wrote a little script to skip the bad tests. It was written for buildbot, but can be run standalone. Try downloading http://winezeug.googlecode.com/svn/trunk/buildbot/dotests.sh and http://winezeug.googlecode.com/svn/trunk/buildbot/dotests_blacklist.txt then run sh dotests.sh goodtests That will skip all the tests known to hang or fail. (The list might be a bit out of date, but it's easy to add new tests to the blacklist.) > I don't install wine-gecko, maybe that's the reason. Run https://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh then you'll never have to install it again. (Until it's updated, anyway.) - Dan

2 1

Re: urlmon: Use file content to verify MIME type reported by file protocol handler
by Alexandre Julliard June 6, 2012

June 6, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/file.c | 8 +++++++- > dlls/urlmon/tests/protocol.c | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so protocol.c && touch protocol.ok protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

1.4 has dropped off the list for AppDB submissions
by Rosanne DiMesio June 6, 2012

June 6, 2012

As of the release of 1.5.5, 1.4 has dropped off the list of Wine versions for which AppDB test reports can be submitted. Can someone please add it to the list of stable releases that are always available in the dropdown list? Until it's put back, users will not be able to submit new test reports for 1.4. We could avoid having this problem every time there's a new stable release if users were allowed to submit test reports for any version. Bugzilla lists every version, I don't see why the AppDB doesn't. -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 2

Re: [PATCH 2/3] server: STATUS_MORE_PROCESSING_REQUIRED does not indicate that an async operation is complete (try 4).
by Alexandre Julliard June 6, 2012

June 6, 2012

"Erich E. Hoover" <compholio(a)gmail.com> writes: > @@ -285,7 +285,9 @@ void async_set_result( struct object *obj, unsigned int status, unsigned int tot > if (async->timeout) remove_timeout_user( async->timeout ); > async->timeout = NULL; > async->status = status; > - if (async->data.cvalue) > + if (status == STATUS_MORE_PROCESSING_REQUIRED) > + async->status = STATUS_PENDING; > + else if (async->data.cvalue) Why are you marking the async pending? That doesn't seem right, it's terminated at that point. -- Alexandre Julliard julliard(a)winehq.org

2 1

http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono
by Dan Kegel June 6, 2012

June 6, 2012

http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh now also installs mono. It should be probably be called wine-install-addons.sh now, maybe I'll rename it that soon. If you have a better idea for the name, let me know. (I've also deprecated the copy that was in winezeug; that one now just tells users to get it from the winetricks repo.)

11 20

Re: windowscodecs: Add a stubbed out IWICMetadataBlockReader to TIFF decoder.
by Vincent Povirk June 6, 2012

June 6, 2012

Looks good. Here are some notes in case you get around to implementing this before I do: I found it very surprising that no metadata handlers seem to implement IWICMetadataBlockReader, while many of them advertise that they can be found in other metadata formats. I'm guessing that metadata handlers return child IWICMetadataReader objects from the IWICMetadataReader interface, but I haven't tested this. It probably doesn't make sense to reimplement GetEnumerator for each decoder, and we should be able to make a common implementation based on the other methods. We should probably implement GetReaderByIndex based on CreateMetadataReaderFromContainer, which I'm guessing expects a copy of the image stream (using IWICStream because we can't use IStream::Clone) seeked to the beginning of some metadata, or a region of the image stream, maybe depending on the container format.

1 0

Re: urlmon: Use file content to verify MIME type reported by file protocol handler
by Marvin June 6, 2012

June 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18815 Your paranoid android. === WXPPROSP3 (32 bit protocol) === protocol.c:1046: Test failed: unexpected call ReportResult protocol.c:1051: Test failed: hrResult = 00000000, expected: 80004004 protocol.c:2838: Test failed: Read failed: 00000001

2 1

Re: [2/2] user32: Add a test to demonstrate the z-order problem for a top level window with a region. Take 2.
by Alexandre Julliard June 6, 2012

June 6, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This version of the test tries harder to avoid races that could cause > the test failures. It's not races, it's failing consistently here, even with your latest version. I don't think you can reliably test expose events processing from a Windows app. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] shell32: do not crash "wine control.exe nonexisting"
by Jacek Caban June 6, 2012

June 6, 2012

Hi Marcus, On 06/06/12 10:17, Marcus Meissner wrote: > Hi, > > wine control.exe joy crashed in this line, as it should be wine control.exe joy.cpl. > > The list is just not setup yet as we fail... > > Ciao, Marcus > --- > dlls/shell32/control.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/shell32/control.c b/dlls/shell32/control.c > index cb080d5..b3eddb6 100644 > --- a/dlls/shell32/control.c > +++ b/dlls/shell32/control.c > @@ -55,7 +55,7 @@ void Control_UnloadApplet(CPlApplet* applet) > } > if (applet->proc) applet->proc(applet->hWnd, CPL_EXIT, 0L, 0L); > FreeLibrary(applet->hModule); > - list_remove( &applet->entry ); > + if (applet->entry.next) list_remove( &applet->entry ); > HeapFree(GetProcessHeap(), 0, applet->cmd); > HeapFree(GetProcessHeap(), 0, applet); > } The way Wine standard list implementation works, it should not be NULL here. It seems that list_init call is missing where the CPlApplet is allocated. Cheers, Jacek

3 6

Re: [PATCH 3/5] d3drm: Handle texture associated with the materail when loading a mesh.
by Alexandre Julliard June 6, 2012

June 6, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/d3drm/meshbuilder.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M d3drm.dll -T ../../.. -p d3drm_test.exe.so d3drm.c && touch d3drm.ok d3drm.c:375: Test failed: No texture should be present wine: Unhandled page fault on write access to 0x00162708 at address 0x68353cb7 (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] msi: Add support for 64-bit registry components.
by Alexandre Julliard June 5, 2012

June 5, 2012

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/msi/action.c | 30 +++++++--- > dlls/msi/msi_main.c | 1 + > dlls/msi/msipriv.h | 1 + > dlls/msi/package.c | 2 - > dlls/msi/tests/install.c | 140 ++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 162 insertions(+), 12 deletions(-) This breaks the Gecko installer on 64-bit for me. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [1/2] user32: Add a test to demonstrate the z-order problem for a top level window with a region.
by Alexandre Julliard June 5, 2012

June 5, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/user32/tests/win.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so ../../../../wine/dlls/user32/tests/win.c && touch win.ok win.c:7111: Test succeeded inside todo block: expected next window 0x400ea, got 0x400ea win.c:7114: Test succeeded inside todo block: expected previous window 0x400f0, got 0x400f0 make[1]: *** [win.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] server: Make sure that region and rectangle have the same origin before calling rect_in_region().
by Alexandre Julliard June 5, 2012

June 5, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -2457,7 +2457,9 @@ DECL_HANDLER(update_window_zorder) > if (!(ptr->style & WS_VISIBLE)) continue; > if (ptr->ex_style & WS_EX_TRANSPARENT) continue; > if (!intersect_rect( &tmp, &ptr->visible_rect, &rect )) continue; > - if (ptr->win_region && !rect_in_region( ptr->win_region, &rect )) continue; > + tmp = rect; > + offset_rect( &tmp, -ptr->client_rect.left, -ptr->client_rect.top ); > + if (ptr->win_region && !rect_in_region( ptr->win_region, &tmp )) continue; The window region is not in client coordinates. -- Alexandre Julliard julliard(a)winehq.org

1 0