June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 4/4] qedit: Support COM aggregation for SampleGrabber.
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19578 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401639 === W2KPROSP4 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401639

2 1

Re: [PATCH 3/4] qedit/tests: Add COM aggregation test for MediaDet.
by Michael Stefaniuc June 26, 2012

June 26, 2012

Argh! Please skip this patch, it is incomplete and just skips the rest of the tests on Wine. I'll resubmit it when I implement COM aggregation for MediaDet. Patch 4/4 can be still applied as it doesn't depends on this. bye michael On 06/26/2012 11:53 PM, Michael Stefaniuc wrote: > --- > dlls/qedit/tests/mediadet.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c > index 1d9a2f1..1d75680 100644 > --- a/dlls/qedit/tests/mediadet.c > +++ b/dlls/qedit/tests/mediadet.c > @@ -132,6 +132,7 @@ static BOOL init_tests(void) > static void test_mediadet(void) > { > HRESULT hr; > + struct unk_impl unk_obj = {{&unk_vtbl}, 19, NULL}; > IMediaDet *pM = NULL; > BSTR filename = NULL; > LONG nstrms = 0; > @@ -141,6 +142,12 @@ static void test_mediadet(void) > int flags; > int i; > > + /* COM aggregation */ > + hr = CoCreateInstance(&CLSID_MediaDet, &unk_obj.IUnknown_iface, CLSCTX_INPROC_SERVER, > + &IID_IUnknown, (void**)&unk_obj.inner_unk); > + todo_wine ok(hr == S_OK, "CoCreateInstance failed: %08x\n", hr); > + if (hr != S_OK) return; > + > /* test.avi has one video stream. */ > hr = CoCreateInstance(&CLSID_MediaDet, NULL, CLSCTX_INPROC_SERVER, > &IID_IMediaDet, (LPVOID*)&pM);

1 0

Re: [PATCH 3/4] qedit/tests: Add COM aggregation test for MediaDet.
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19577 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 === W2KPROSP4 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154

1 0

Re: kernel32: Change LCMapStringW to LCMapStringEx and call it from LCMapStringW (try 2)
by Alexandre Julliard June 26, 2012

June 26, 2012

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2625,6 +2641,28 @@ INT WINAPI LCMapStringW(LCID lcid, DWORD flags, LPCWSTR src, INT srclen, > } > > /************************************************************************* > + * LCMapStringW (KERNEL32.@) > + * > + * See LCMapStringA. > + */ > +INT WINAPI LCMapStringW(LCID lcid, DWORD flags, LPCWSTR src, INT srclen, > + LPWSTR dst, INT dstlen) > +{ > + WCHAR locale[LOCALE_NAME_MAX_LENGTH]; > + > + TRACE("(0x%04x,0x%08x,%s,%d,%p,%d)\n", > + lcid, flags, debugstr_wn(src, srclen), srclen, dst, dstlen); > + > + if (!LCIDToLocaleName(lcid, locale, LOCALE_NAME_MAX_LENGTH, 0)) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return 0; > + } I don't think it makes sense to do name conversion for a parameter that isn't used. If we use it someday it will most likely be to look up a conversion table directly from the lcid. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: windowscodecs: Implement MetadataHandler_GetValue.
by Vincent Povirk June 26, 2012

June 26, 2012

> + case VT_I8: > + case VT_UI8: > + case VT_R8: > + return v1->u.uhVal.QuadPart - v2->u.uhVal.QuadPart; Won't this only compare the low part on x86?

2 1

Re: [PATCH 3/5] secur32: Handle incomplete messages in schan_InitializeSecurityContextW().
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19560 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === schannel.c:702: Test failed: Got unexpected status 0x80090308.

1 0

Re: urlmon: Do not stop binding when OnDataAvailable() returns E_PENDING
by Jacek Caban June 26, 2012

June 26, 2012

On 06/26/12 00:02, Andrew Talbot wrote: > Changelog: > urlmon: Do not stop binding when OnDataAvailable() returns E_PENDING. > > diff --git a/dlls/urlmon/binding.c b/dlls/urlmon/binding.c > index 58aed20..42eca4b 100644 > --- a/dlls/urlmon/binding.c > +++ b/dlls/urlmon/binding.c > @@ -1097,7 +1097,7 @@ static void report_data(Binding *This, DWORD bscf, ULONG progress, ULONG progres > > hres = IBindStatusCallback_OnDataAvailable(This->callback, bscf, progress, > &formatetc, &stgmed); > - if(hres != S_OK) { > + if(FAILED(hres) && hres != E_PENDING) { > if(This->download_state != END_DOWNLOAD) { > This->download_state = END_DOWNLOAD; > IBindStatusCallback_OnProgress(This->callback, progress, progress_max, Please add a test case. You may modify one of existing binding tests to use E_PENDING. Jacek

1 0

Is it safe yet for developers to upgrade to Ubuntu 12.04?
by Erich E. Hoover June 26, 2012

June 26, 2012

I know that for a while there were some packaging problems that meant that upgrading to 12.04 made compiling 32-bit Wine on a 64-bit PC extremely difficult. Is this still the case? I'd like to upgrade to the new OS version, but I'm not willing to sacrifice the ability to build Wine in order to do so. Thanks in advance! Erich Hoover ehoover(a)mines.edu

6 5

Re: [PATCH] opengl32: Disable wglGetProcAddress for core GL 1.0/1.1 functions
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19550 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

change wording of ok()-messages in winspool-tests?
by Julian Rüger June 26, 2012

June 26, 2012

Hi Francois and list, [/nitpick-mode on] I'm preparing a patch to fix typos/spelling/grammar in dlls/winspool.drv/tests/info.c, where I stumbled across repeated messages like ok( !retval, "function result wrong! False expected\n"); or ok( size == exact, "Parameter size wrong! %d expected got %d\n", exact, size); Do you think it's worth changing these? (I think "Wrong function result: 'false' expected\n", and "Wrong parameter size: expected %d, got %d\n" would be better) Do we have guidelines for strings like these? For example: start with a captial letter, no punctuation at the end... What tests have "good" style I can use as reference? Best regards, Julian PS: Am I bike shedding here? Does anyone care about stuff like this? Sorry for wasting your time ;)

3 3

Building WoW64 packages
by Hilko Bengen June 25, 2012

June 25, 2012

Hi, after the effort on the Debian wine packages has progressed to a point where it's likely that we'll release wheezy with a stable wine version that is not completely out of date, I'd like to take things a step further. I recently spent some time looking at ways how we could build Debian packages for a shared WoW64 setup similar to what is described in http://wiki.winehq.org/Wine64. We will have to use separate build environments because having 32-bit and 64-bit -dev packages installed at the same time is not possible. Installing a 64-bit package that contains the build tools into a 32-bit environment should be possible, though. >From looking at the build system, things happen in a different way when I run configure for the 32-bit components with --wine64=...: 1. Manpages are not installed (WOW64_DISABLE) 2. --disable-fonts is implied 3. --disable-server is implied, so wineserver is not built. (The 64-bit wineserver is used instead, right?) 4. --disable-tools is implied because the existing build tools are being used. Did I miss anything? Leaving parts out is easy to understand, but how do the build tools that have been built for the x86_64 architecture affect the 32-bit components that are being built with them? Are different paths encoded into libwine? Cheers, -Hilko

2 1

Re: [PATCH 2/2] opengl32: Check for valid context in wglGetProcAddress
by Chris Robinson June 25, 2012

June 25, 2012

On Sunday, June 24, 2012 10:42:11 PM Roderick Colenbrander wrote: > @@ -797,7 +797,7 @@ static void test_getprocaddress(HDC hdc) > /* Temporarily disable the context, so we can see that we can't > retrieve functions now. */ wglMakeCurrent(hdc, NULL); > func = wglGetProcAddress("glActiveTextureARB"); > - todo_wine ok(func == NULL, "Function lookup without a context passed, > expected a failure; last error %#x\n", GetLastError()); > + ok(func == NULL, "Function lookup without a context passed, expected a > failure; last error %#x\n", GetLastError()); > wglMakeCurrent(hdc, ctx); > } Does this apply to all functions, or just the ones MS's DLL doesn't implement? I could imagine wlgGetProcAddress still returning functions that are in opengl32.dll without worrying about the driver.

2 1

Re: [3/5] gdiplus: Implement GdipGetPropertyIdList.
by Nikolay Sivov June 25, 2012

June 25, 2012

On 6/25/2012 14:30, Dmitry Timoshkov wrote: > + > + return hr == S_OK ? Ok : hresult_to_status(hr); > } > No need for special case for S_OK here.

1 0

Re: [3/3] d3drm: Implement IDirect3DRMMeshBuilderX_GetClassName
by Marvin June 24, 2012

June 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19493 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] d3drm: Implement IDirect3DRMLight_GetClassName
by Marvin June 24, 2012

June 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19492 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Incompatibility in Kernel32
by robert.van.herk＠serioustoys.com June 23, 2012

June 23, 2012

Hi group, As I was trying write a fix for msi.dll, I stumbled upon an incompatibility in the kernel. If you open an existing file, FILE_SHARE_DELETE doesn't seem to work in Wine. In Windows, it does. Attached is a minimal test case. I feel hesitation towards starting to hack in kernel32 myself. Though this bug seems to be blocking me to implement msi.dll completely compatible with the MS implementation... Shall I file a bug report? Regards, Robert

4 6

MSVCP60.dll
by John Emmas June 22, 2012

June 22, 2012

Firstly, I'm not a Linux user. I'm a Windows programmer but I have a passing knowledge of Linux (and several friends who are Linux programmers). I write a Windows application which gets launched as a child process by a popular Linux DAW. My program was first written many years ago when the (then) current version of Wine was about v0.9.58. Over a hundred people are using my program with old versions of Wine and I've had no complaints so far. Recently however, two customers tried to use it with Wine v1.5.35. In both cases the program crashed - apparently because some particular function wasn't found in MSVCP60.dll (at the moment, we don't know which function). Both customers went to a web site called WineTricks from where they were able to install an alternative version of MSVCP60.dll. My app now gets past the place where it previously crashed although it now crashes further on... :-( It looks as if the MSVC6 runtime module(s) that now come with Wine aren't the same as the ones from v0.9.58. Either they're different versions of the Microsoft DLLs or maybe they're now being implemented by somebody else, perhaps as part of Wine development? Either way, they don't work with my particular app any more. I still have Visual C++6 installed on an old computer, together with both the source code and the (InstallShield) packager for my original app. So is there anything I can do to make this work? For example, do I need to link against a particular version of the MSVC6 runtime? Or do I need to configure my packager so that it specifically distributes the runtime modules that my app linked to? I never did that in the past - because whichever runtime came with Wine seemed to work. Any advice? John

4 7

Re: [1/2] windowscodecs: Implement GetPreview and GetThumbnail in the TIFF decoder.
by Vincent Povirk June 22, 2012

June 22, 2012

According to MSDN, GetPreview isn't supported on any decoder except WMPhoto, and if that's true it should probably be returning WINCODEC_ERR_UNSUPPORTEDOPERATION. And why bother with GetThumbnail if you're not going to do it properly? At least check whether a thumbnail exists in the image before returning something.

2 1

Re: d3dx9_36: Implentation of D3DXSHDot
by Alexandre Julliard June 22, 2012

June 22, 2012

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > +static void test_D3DXSHDot(void) > +{ > + unsigned int i; > + FLOAT a[64], b[64], got; > + CONST FLOAT expected[] = > + { 0.0f, 0.0f, 17.0f, 222.0f, 1300.0f, 5050.0f, 15225.0f, 38612.0f, 86352.0f, }; > + > + for (i = 0; i < 64; i++) > + { > + a[i] = (FLOAT)i; > + b[i] = (FLOAT)i + 0.5f; > + } You should start with a non-zero value to tests orders 0 and 1 properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9_36 [patch 4 of 4, try 2]: Save multiplications
by Alexandre Julliard June 22, 2012

June 22, 2012

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > @@ -1971,11 +1971,13 @@ FLOAT *WINAPI D3DXFloat16To32Array(FLOAT *pout, CONST D3DXFLOAT16 *pin, UINT n) > > FLOAT* WINAPI D3DXSHAdd(FLOAT *out, UINT order, const FLOAT *a, const FLOAT *b) > { > - UINT i; > + UINT i, sq_order; > > TRACE("out %p, order %u, a %p, b %p\n", out, order, a, b); > > - for (i = 0; i < order * order; i++) > + sq_order = order * order; > + > + for (i = 0; i < sq_order; i++) > out[i] = a[i] + b[i]; There's no reason to do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wintrust/tests: Fix build with MSVC.
by Dmitry Timoshkov June 22, 2012

June 22, 2012

Thomas Faber <thfabba(a)gmx.de> wrote: > FIELD_OFFSET isn't constant "enough". The problem is not with FIELD_OFFSET, but with applying shift and mask operations to a constant. -- Dmitry.

3 3

Re: d3dx9_36 [patch 1 of 4, try 2]: Implemetation of D3DXSHDot
by Dmitry Timoshkov June 22, 2012

June 22, 2012

Hello, Please follow http://wiki.winehq.org/SubmittingPatches instructions for naming patches when sending a patch series. Usually 'git format-patch -n' will do it for you. Otherwise testbot won't recognize the series. -- Dmitry.

1 0

Re: d3dx9_36 [patch 3 of 4, try 2]: Implemetation of D3DXSHMultiply2
by Marvin June 22, 2012

June 22, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19429 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: d3dx9_36 [patch 1 of 4, try 2]: Implemetation of D3DXSHScale
by Marvin June 22, 2012

June 22, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19428 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

re: [PATCH 2/5] ddraw: Use wined3d_get_adapter_display_mode() in CreateSurface().
by Dan Kegel June 21, 2012

June 21, 2012

Henri wrote: - hr = wined3d_device_get_display_mode(ddraw->wined3d_device, 0, &mode); - if (FAILED(hr)) + if (FAILED(hr = wined3d_get_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &mode))) Seems like a step back in readability to combine setting and testing hr. - Dan

1 0