June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 1/5] wined3d: Use NAN.
by Ruslan Kabatsayev June 5, 2012

June 5, 2012

Hello, This patch stops wine from building on my system with following errors: In file included from arb_program_shader.c:35:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from device.c:32:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from ati_fragment_shader.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from context.c:27:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from directx.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from gl_compat.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) make[1]: *** [ati_fragment_shader.o] Error 1 Regards, Ruslan On Wed, May 30, 2012 at 6:14 PM, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > --- > dlls/wined3d/drawprim.c | 2 ++ > dlls/wined3d/utils.c | 2 ++ > dlls/wined3d/wined3d_private.h | 4 ++-- > 3 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c > index 2e30175..c8944e5 100644 > --- a/dlls/wined3d/drawprim.c > +++ b/dlls/wined3d/drawprim.c > @@ -25,6 +25,8 @@ > */ > > #include "config.h" > +#include "wine/port.h" > + > #include "wined3d_private.h" > > WINE_DEFAULT_DEBUG_CHANNEL(d3d_draw); > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index dc63d8b..f8f301a 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -25,6 +25,8 @@ > */ > > #include "config.h" > +#include "wine/port.h" > + > #include "wined3d_private.h" > > WINE_DEFAULT_DEBUG_CHANNEL(d3d); > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 096fe60..6632f6e 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -200,7 +200,7 @@ static inline float float_16_to_32(const unsigned short *in) { > return sgn * powf(2, (float)e - 15.0f) * (1.0f + ((float)m / 1024.0f)); > } else { > if(m == 0) return sgn / 0.0f; /* +INF / -INF */ > - else return 0.0f / 0.0f; /* NAN */ > + else return NAN; > } > } > > @@ -222,7 +222,7 @@ static inline float float_24_to_32(DWORD in) > else > { > if (m == 0) return sgn / 0.0f; /* +INF / -INF */ > - else return 0.0f / 0.0f; /* NAN */ > + else return NAN; > } > } > > -- > 1.7.3.4 > > >

2 2

Re: [PATCH 5/5] d3dcompiler: Parse variable declarations.
by Stefan Dösinger June 5, 2012

June 5, 2012

Am Montag, 4. Juni 2012, 17:58:24 schrieb Matteo Bruni: > +struct hlsl_type > +{ > ... > + unsigned int dimx; > + unsigned int dimy; > ... > +}; One thing I noticed when I wrote my compiler was that a float1x1 is not the same as a float1 or float. I did not implement this difference nor do I know if any games depend on it. (That's no reason to hold up this patch, just something to keep in mind for further work)

3 4

Re: [4/5] msi/tests: Use only uppercase characters for the PID_REVNUMBER property.
by Marvin June 5, 2012

June 5, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18792 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [1/5] msi: Add support for 64-bit registry components.
by Marvin June 5, 2012

June 5, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18791 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: oleaut32: Add a test for BSTR cache. Take 3.
by Alexandre Julliard June 5, 2012

June 5, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > + for (i = 0; i < sizeof(bstr)/sizeof(bstr[0]); i++) > + { > + INTERNAL_BSTR *data = Get(bstr[i]); > + > + for (j = 0; j < i; j++) str[j] = '0' + i % 10; > + > + if (data->dwLen == i * sizeof(WCHAR)) > + good_length_entries++; > + if (!memcmp(data->szString, str, i * sizeof(WCHAR))) > + good_string_entries++; > + } > + > + trace("good_length_entries %d, good_string_entries %d\n", good_length_entries, good_string_entries); > + ok(good_length_entries >= 95, "good_length_entries %d out of 256\n", good_length_entries); > +todo_wine > + ok(good_string_entries >= 190, "good_string_entries %d out of 256\n", good_string_entries); That doesn't seem very useful. What use case would there be for an app to rely on some random 75% of its strings to remain valid? -- Alexandre Julliard julliard(a)winehq.org

3 6

Wine in Humble Indie Bundle
by Dan Kegel June 4, 2012

June 4, 2012

I see the Humble Indie Bundle includes a game ported via wine, http://zcint.co.uk/article/limbo-on-linux-incites-humble-bundle-petition That's pretty cool, but not everyone agrees, and somebody has started circulating an anti-wine petition. So I put together a pro-wine petition: http://www.ipetitions.com/petition/use-wine-as-needed-in-future-humble-indi… How's that look? If you agree with it, please sign and forward to your friends. Thanks, Dan

5 5

Re: [PATCH 1/2] joystick.cpl: First version of the joystick configuration applet
by Alexandre Julliard June 4, 2012

June 4, 2012

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > This adds a control panel applet to configure the joysticks. It is > a property sheet and has 3 pages: > > * Joystick listing > * Axes and Button Testing > * Force Feedback testing > > All the function are stubs at the moment, the panel has no icon too. > > --- > configure.ac | 1 + > dlls/joystick.cpl/Makefile.in | 14 +++ > dlls/joystick.cpl/forcefeedback.c | 60 +++++++++++ > dlls/joystick.cpl/joystick.cpl.spec | 3 + > dlls/joystick.cpl/joystick.h | 63 ++++++++++++ > dlls/joystick.cpl/joystick.rc | 55 ++++++++++ > dlls/joystick.cpl/list.c | 57 +++++++++++ > dlls/joystick.cpl/main.c | 191 +++++++++++++++++++++++++++++++++++ > dlls/joystick.cpl/test.c | 60 +++++++++++ > 9 files changed, 504 insertions(+) > create mode 100644 dlls/joystick.cpl/Makefile.in > create mode 100644 dlls/joystick.cpl/forcefeedback.c > create mode 100644 dlls/joystick.cpl/joystick.cpl.spec > create mode 100644 dlls/joystick.cpl/joystick.h > create mode 100644 dlls/joystick.cpl/joystick.rc > create mode 100644 dlls/joystick.cpl/list.c > create mode 100644 dlls/joystick.cpl/main.c > create mode 100644 dlls/joystick.cpl/test.c It's called joy.cpl on Windows. Please also use compatible exports, and avoid creating a lot of empty source files. I'd expect that a single source file is sufficient for this. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/4] server: Move completion from async object to async queue.
by Alexandre Julliard June 4, 2012

June 4, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > Real Name: > Erich Hoover > > Description: > It seems that the completion information should be associated with > the async queue, rather than the async object, since the completion > information for a file handle can be updated after an async IO has > been queued. So, the attached patch moves the completion information > from the async object into the async queue so that we can properly > handle associating a completion with a file descriptor after an async > IO is queued (part 2). Does it even need to be stored in the queue then? Why not retrieve it from the fd when needed? -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [website] Publish a sign button for the Wine in Humble Indie Bundle petition
by Jeremy Newman June 4, 2012

June 4, 2012

I'm not sure this belongs in the news section on WineHQ. I need some further convincing. -Newman On 06/04/2012 01:11 PM, André Hentschel wrote: > http://www.winehq.org/pipermail/wine-devel/2012-June/095722.html needs more cow bell > > --- > news/en/2012060401.xml | 23 +++++++++++++++++++++++ > 1 files changed, 23 insertions(+), 0 deletions(-) > create mode 100644 news/en/2012060401.xml > > diff --git a/news/en/2012060401.xml b/news/en/2012060401.xml > new file mode 100644 > index 0000000..1bcd3d5 > --- /dev/null > +++ b/news/en/2012060401.xml > @@ -0,0 +1,23 @@ > +<news> > +<date>June 4, 2012</date> > +<title>Wine in Humble Indie Bundle</title> > +<body> > +<div style="float: left; margin: 0 20px 20px 0; display:block; clear:both; text-align: left; background: #000 url(http://www.ipetitions.com/assets/images/widgets/black.png) no-repeat top left; width: 200px;"> > +<iframe src="http://www.ipetitions.com/widget/view/black/437775" marginheight="0" marginwidth="0" style="width: 200px; height:150px; border:0;" scrolling="no"></iframe> > +<div style="text-align:center; font-family:Arial;font-size: 9px; width: 196px; margin-top: -3px; padding: 1px 2px 2px; color: #8a8a8a; font-style: italic;"> > +<a style="color: #8a8a8a; text-decoration:none;" href="http://www.ipetitions.com/">Petitions</a> by<a style="color: #8a8a8a; text-decoration:none;" href="http://www.ipetitions.com">iPetitions.com</a> > +</div> > +</div> > +<p> > + The Humble Indie Bundle includes a game (Limbo) > +<a href="http://zcint.co.uk/article/limbo-on-linux-incites-humble-bundle-petition">ported via wine</a>. > +</p> > +<p> > + That's pretty cool, but not everyone agrees, and somebody has started circulating an anti-wine petition. > +</p> > +<p> > + So Dan Kegel put together a pro-wine petition: > +<a href="http://www.ipetitions.com/petition/use-wine-as-needed-in-future-humble-indi…">Use Wine as needed in future Humble Indie Bundles</a> > +</p> > +</body> > +</news> > > > >

1 0

Re: wininet: Added support for undocumented InternetQueryOption(98)
by Marvin June 4, 2012

June 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18739 Your paranoid android. === W7PROX64 (32 bit http) === http.c:3203: Test failed: HttpSendRequest failed: 12007 http.c:3208: Test failed: expected secure flag to be set http.c:3220: Test failed: expected a non-empty subject name http.c:3223: Test failed: expected a non-empty issuer name http.c:3232: Test failed: expected a non-zero key size http.c:3252: Test failed: expected a non-empty subject name http.c:3255: Test failed: expected a non-empty issuer name http.c:3264: Test failed: expected a non-zero key size

1 0

Re: Fix the FIXME message to reflect the real problem.
by Piotr Caban June 4, 2012

June 4, 2012

On 06/02/12 13:35, max(a)mtew.isa-geek.net wrote: > @@ -2735,7 +2735,7 @@ static BOOL CommitUrlCacheEntryInternal( > goto cleanup; > } > > - FIXME("entry already in cache - don't know what to do!\n"); > + FIXME("collision handler needed - the entry is already in use!\n"); This message is not about entry being used. I think the old message is quite accurate. The "don't know what to do" part is quite strange but I don't see reason to change it.

2 1

Re: comctl: allow label edit only if treeview style allows editing
by Alexandre Julliard June 4, 2012

June 4, 2012

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 21d26b76560f0c15a3d302883efa2d41d940a093 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Sat, 2 Jun 2012 07:23:32 +0200 > Subject: comctl: allow label edit only if treeview style allows editing > > Native comctl behaves this way - noticed when debugging regedit It breaks the tests: ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so brsfolder.c && touch brsfolder.ok brsfolder.c:225: Test failed: The new folder did not get the name foo brsfolder.c:232: Test failed: SHBrowseForFolder did not return the pidl for the new folder. Expected 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\foo' got 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\New Folder' make: *** [brsfolder.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [scrrun] Add initial support for Dictionary patch - 1/3
by Alistair Leslie-Hughes June 4, 2012

June 4, 2012

Hi Vijay, On 4/06/2012 8:06 PM, Vijay Kiran Kamuju wrote: > Sending patch series for initial support for Scripting.Dictionary in scrrun.dll > > +static HRESULT WINAPI dictionary_put_Item(IDictionary *iface, VARIANT *key, VARIANT *item) > +{ > + FIXME("%p %p\n", iface, key); Please include all parameters in FIXME, they all seem to be missing the last one. Best Regards Alistair Leslie-Hughes

1 0

Re: [scrrun] Add initial support for Dictionary patch - 1/3
by Jacek Caban June 4, 2012

June 4, 2012

Hi Vijay On 06/04/12 12:06, Vijay Kiran Kamuju wrote: > Sending patch series for initial support for Scripting.Dictionary in scrrun.dll > > The first patch will add dictionary.c > The second will add the necessary changes to Makefile and the scrrun.c > (mistake done will doing git commit - hence two patches) This split doesn't make sense. Please merge those patches. +static ULONG WINAPI dictionary_AddRef(IDictionary *iface) +{ + TRACE("%p\n", iface); + + return 2; +} + +static ULONG WINAPI dictionary_Release(IDictionary *iface) +{ + TRACE("%p\n", iface); + + return 1; +} Dictionary object should be heap-based. That requires proper reference counting and object structure. Cheers, Jacek

1 0

Re: [scrrun] - Add initial support for Dictionary - tests - patch 3/3
by Marvin June 4, 2012

June 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18733 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: oleaut32: Add a test for BSTR cache.
by Marvin June 4, 2012

June 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18731 Your paranoid android. === W2KPROSP4 (32 bit vartype) === vartype.c:6166: Test failed: good_length_entries 98 out of 256 === WXPPROSP3 (32 bit vartype) === vartype.c:6166: Test failed: good_length_entries 99 out of 256

1 0

Re: [3/3] iphlpapi: Check for the right TCP statistics structure name (for DragonFly BSD)
by Juan Lang June 3, 2012

June 3, 2012

Hi André, +#if HAVE_STRUCT_TCPSTAT_TCPS_CONNATTEMPT + struct tcpstat tcp_stat; +#elif HAVE_STRUCT_TCP_STATS_TCPS_CONNATTEMPT + struct tcp_stats tcp_stat; +#endif struct tcpstat tcp_stat; I think you meant to remove the declaration outside of the #if. --Juan

2 1

Re: [1/4] user32/tests: remove WM_DESTROY processing in test (it is of no use and causes tests skipping) (try 2)
by Marvin June 3, 2012

June 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18723 Your paranoid android. === W7PROX64 (32 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === TEST64_W7SP1 (32 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === W7PROX64 (64 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === TEST64_W7SP1 (64 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible.

1 0

Mono?!?
by Max TenEyck Woodbury June 3, 2012

June 3, 2012

When did WINE start requiring MONO? I have a VERY strong DISLIKE for MONO and do NOT want it on my machines. Seems to be a recent addition. Is it possible to NOT use it? PLEASE!

6 15

Re: shell32: fix compilation error with strcpy_chk: buffer overflow detected
by Nikolay Sivov June 2, 2012

June 2, 2012

A static string constant would be better here. On Sat, Jun 2, 2012 at 12:42 PM, Vitaly Lipatov <lav(a)etersoft.ru> wrote: > --- > dlls/shell32/pidl.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dlls/shell32/pidl.c b/dlls/shell32/pidl.c > index c394e5b..5906a4f 100644 > --- a/dlls/shell32/pidl.c > +++ b/dlls/shell32/pidl.c > @@ -1752,16 +1752,17 @@ LPITEMIDLIST _ILCreateDrive(LPCWSTR lpszNew) > LPITEMIDLIST _ILCreateEntireNetwork(void) > { > LPITEMIDLIST pidlOut; > + DWORD alen = sizeof("Entire Network"); > > TRACE("\n"); > > - pidlOut = _ILAlloc(PT_NETWORK, FIELD_OFFSET(PIDLDATA, > u.network.szNames[sizeof("Entire Network")])); > + pidlOut = _ILAlloc(PT_NETWORK, FIELD_OFFSET(PIDLDATA, > u.network.szNames[alen])); > if (pidlOut) > { > LPPIDLDATA pData = _ILGetDataPointer(pidlOut); > > pData->u.network.dummy = 0; > - strcpy(pData->u.network.szNames, "Entire Network"); > + memcpy(pData->u.network.szNames, "Entire Network", alen + 1); > } > return pidlOut; > } > -- > 1.7.9.7 > > -- > С уважением, > Виталий Липатов, > Etersoft > >

1 0

Re: shell32: Make ShellExecute use native file association databases as fallback path
by Francois Gouget June 2, 2012

June 2, 2012

On Thu, 31 May 2012, Erik van Pienbroek wrote: [...] > Tested successfully on a Fedora 17 environment using the start.exe > command and Outlook 2007 by trying to open a .pdf file (where there > is no file association registered inside the wine prefix) There are two issues with this patch: * In some cases xdg-open returns 0 whether or not there is a native file association. This is the case in KDE for instance. That would cause ShellExecute() to be unable to return anything but success. * There is a risk of infinite loops if the native association calls Wine. One such scenario is if you create the native association using Wine but later wipe out the Wine prefix so that there is no handler on the Wine side anymore. However I believe it can also happen simply because Windows' associations are based on extensions and Unix's on MIME types so that neither thinks they handle that case. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.
by Alexandre Julliard June 1, 2012

June 1, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Any chance for at least a comment? You did get a comment from Huw that you need to allocate extra bytes, you still haven't done that AFAICS. -- Alexandre Julliard julliard(a)winehq.org

2 5

size of wine packages
by Marcus Meissner June 1, 2012

June 1, 2012

Hi, As we have crossed the 100MB installed size (stripped) for the Wine RPM packages (stripped), this makes a Wow64 capable installation taking around 200MB these days. Can we reduce this size? eg. kernel32.dll.so has 1.6MB of static data inside itself, which is puzzling me a bit. (winerror.res is 1.3MB, winerror.mc is 0.068 MB ... Huh? Translations blowing this up?) Out of 100MB /usr/lib/wine/, e.g. I have here 67 MB of .text (73MB on x86_64) 11 MB of .data (static data) Ciao, Marcus

1 0

Judge rules: APIs can not be copyrighted.
by Detlef Riekenberg May 31, 2012

May 31, 2012

1 0