June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 4/4] qedit: Support COM aggregation for SampleGrabber.
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19578 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401639 === W2KPROSP4 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401639

2 1

Re: [PATCH 3/4] qedit/tests: Add COM aggregation test for MediaDet.
by Michael Stefaniuc June 26, 2012

June 26, 2012

Argh! Please skip this patch, it is incomplete and just skips the rest of the tests on Wine. I'll resubmit it when I implement COM aggregation for MediaDet. Patch 4/4 can be still applied as it doesn't depends on this. bye michael On 06/26/2012 11:53 PM, Michael Stefaniuc wrote: > --- > dlls/qedit/tests/mediadet.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c > index 1d9a2f1..1d75680 100644 > --- a/dlls/qedit/tests/mediadet.c > +++ b/dlls/qedit/tests/mediadet.c > @@ -132,6 +132,7 @@ static BOOL init_tests(void) > static void test_mediadet(void) > { > HRESULT hr; > + struct unk_impl unk_obj = {{&unk_vtbl}, 19, NULL}; > IMediaDet *pM = NULL; > BSTR filename = NULL; > LONG nstrms = 0; > @@ -141,6 +142,12 @@ static void test_mediadet(void) > int flags; > int i; > > + /* COM aggregation */ > + hr = CoCreateInstance(&CLSID_MediaDet, &unk_obj.IUnknown_iface, CLSCTX_INPROC_SERVER, > + &IID_IUnknown, (void**)&unk_obj.inner_unk); > + todo_wine ok(hr == S_OK, "CoCreateInstance failed: %08x\n", hr); > + if (hr != S_OK) return; > + > /* test.avi has one video stream. */ > hr = CoCreateInstance(&CLSID_MediaDet, NULL, CLSCTX_INPROC_SERVER, > &IID_IMediaDet, (LPVOID*)&pM);

1 0

Re: [PATCH 3/4] qedit/tests: Add COM aggregation test for MediaDet.
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19577 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 === W2KPROSP4 (32 bit mediadet) === mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 mediadet.c:356: Test failed: CoCreateInstance failed: 80040154

1 0

Re: kernel32: Change LCMapStringW to LCMapStringEx and call it from LCMapStringW (try 2)
by Alexandre Julliard June 26, 2012

June 26, 2012

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2625,6 +2641,28 @@ INT WINAPI LCMapStringW(LCID lcid, DWORD flags, LPCWSTR src, INT srclen, > } > > /************************************************************************* > + * LCMapStringW (KERNEL32.@) > + * > + * See LCMapStringA. > + */ > +INT WINAPI LCMapStringW(LCID lcid, DWORD flags, LPCWSTR src, INT srclen, > + LPWSTR dst, INT dstlen) > +{ > + WCHAR locale[LOCALE_NAME_MAX_LENGTH]; > + > + TRACE("(0x%04x,0x%08x,%s,%d,%p,%d)\n", > + lcid, flags, debugstr_wn(src, srclen), srclen, dst, dstlen); > + > + if (!LCIDToLocaleName(lcid, locale, LOCALE_NAME_MAX_LENGTH, 0)) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return 0; > + } I don't think it makes sense to do name conversion for a parameter that isn't used. If we use it someday it will most likely be to look up a conversion table directly from the lcid. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: windowscodecs: Implement MetadataHandler_GetValue.
by Vincent Povirk June 26, 2012

June 26, 2012

> + case VT_I8: > + case VT_UI8: > + case VT_R8: > + return v1->u.uhVal.QuadPart - v2->u.uhVal.QuadPart; Won't this only compare the low part on x86?

2 1

Re: [PATCH 3/5] secur32: Handle incomplete messages in schan_InitializeSecurityContextW().
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19560 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === schannel.c:702: Test failed: Got unexpected status 0x80090308.

1 0

Re: urlmon: Do not stop binding when OnDataAvailable() returns E_PENDING
by Jacek Caban June 26, 2012

June 26, 2012

On 06/26/12 00:02, Andrew Talbot wrote: > Changelog: > urlmon: Do not stop binding when OnDataAvailable() returns E_PENDING. > > diff --git a/dlls/urlmon/binding.c b/dlls/urlmon/binding.c > index 58aed20..42eca4b 100644 > --- a/dlls/urlmon/binding.c > +++ b/dlls/urlmon/binding.c > @@ -1097,7 +1097,7 @@ static void report_data(Binding *This, DWORD bscf, ULONG progress, ULONG progres > > hres = IBindStatusCallback_OnDataAvailable(This->callback, bscf, progress, > &formatetc, &stgmed); > - if(hres != S_OK) { > + if(FAILED(hres) && hres != E_PENDING) { > if(This->download_state != END_DOWNLOAD) { > This->download_state = END_DOWNLOAD; > IBindStatusCallback_OnProgress(This->callback, progress, progress_max, Please add a test case. You may modify one of existing binding tests to use E_PENDING. Jacek

1 0

Is it safe yet for developers to upgrade to Ubuntu 12.04?
by Erich E. Hoover June 26, 2012

June 26, 2012

I know that for a while there were some packaging problems that meant that upgrading to 12.04 made compiling 32-bit Wine on a 64-bit PC extremely difficult. Is this still the case? I'd like to upgrade to the new OS version, but I'm not willing to sacrifice the ability to build Wine in order to do so. Thanks in advance! Erich Hoover ehoover(a)mines.edu

6 5

Re: [PATCH] opengl32: Disable wglGetProcAddress for core GL 1.0/1.1 functions
by Marvin June 26, 2012

June 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19550 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

change wording of ok()-messages in winspool-tests?
by Julian Rüger June 25, 2012

June 25, 2012

Hi Francois and list, [/nitpick-mode on] I'm preparing a patch to fix typos/spelling/grammar in dlls/winspool.drv/tests/info.c, where I stumbled across repeated messages like ok( !retval, "function result wrong! False expected\n"); or ok( size == exact, "Parameter size wrong! %d expected got %d\n", exact, size); Do you think it's worth changing these? (I think "Wrong function result: 'false' expected\n", and "Wrong parameter size: expected %d, got %d\n" would be better) Do we have guidelines for strings like these? For example: start with a captial letter, no punctuation at the end... What tests have "good" style I can use as reference? Best regards, Julian PS: Am I bike shedding here? Does anyone care about stuff like this? Sorry for wasting your time ;)

3 3

Building WoW64 packages
by Hilko Bengen June 25, 2012

June 25, 2012

Hi, after the effort on the Debian wine packages has progressed to a point where it's likely that we'll release wheezy with a stable wine version that is not completely out of date, I'd like to take things a step further. I recently spent some time looking at ways how we could build Debian packages for a shared WoW64 setup similar to what is described in http://wiki.winehq.org/Wine64. We will have to use separate build environments because having 32-bit and 64-bit -dev packages installed at the same time is not possible. Installing a 64-bit package that contains the build tools into a 32-bit environment should be possible, though. >From looking at the build system, things happen in a different way when I run configure for the 32-bit components with --wine64=...: 1. Manpages are not installed (WOW64_DISABLE) 2. --disable-fonts is implied 3. --disable-server is implied, so wineserver is not built. (The 64-bit wineserver is used instead, right?) 4. --disable-tools is implied because the existing build tools are being used. Did I miss anything? Leaving parts out is easy to understand, but how do the build tools that have been built for the x86_64 architecture affect the 32-bit components that are being built with them? Are different paths encoded into libwine? Cheers, -Hilko

2 1

Re: [PATCH 2/2] opengl32: Check for valid context in wglGetProcAddress
by Chris Robinson June 25, 2012

June 25, 2012

On Sunday, June 24, 2012 10:42:11 PM Roderick Colenbrander wrote: > @@ -797,7 +797,7 @@ static void test_getprocaddress(HDC hdc) > /* Temporarily disable the context, so we can see that we can't > retrieve functions now. */ wglMakeCurrent(hdc, NULL); > func = wglGetProcAddress("glActiveTextureARB"); > - todo_wine ok(func == NULL, "Function lookup without a context passed, > expected a failure; last error %#x\n", GetLastError()); > + ok(func == NULL, "Function lookup without a context passed, expected a > failure; last error %#x\n", GetLastError()); > wglMakeCurrent(hdc, ctx); > } Does this apply to all functions, or just the ones MS's DLL doesn't implement? I could imagine wlgGetProcAddress still returning functions that are in opengl32.dll without worrying about the driver.

2 1

Re: [3/5] gdiplus: Implement GdipGetPropertyIdList.
by Nikolay Sivov June 25, 2012

June 25, 2012

On 6/25/2012 14:30, Dmitry Timoshkov wrote: > + > + return hr == S_OK ? Ok : hresult_to_status(hr); > } > No need for special case for S_OK here.

1 0

Re: [3/3] d3drm: Implement IDirect3DRMMeshBuilderX_GetClassName
by Marvin June 24, 2012

June 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19493 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] d3drm: Implement IDirect3DRMLight_GetClassName
by Marvin June 24, 2012

June 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19492 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Incompatibility in Kernel32
by robert.van.herk＠serioustoys.com June 23, 2012

June 23, 2012

Hi group, As I was trying write a fix for msi.dll, I stumbled upon an incompatibility in the kernel. If you open an existing file, FILE_SHARE_DELETE doesn't seem to work in Wine. In Windows, it does. Attached is a minimal test case. I feel hesitation towards starting to hack in kernel32 myself. Though this bug seems to be blocking me to implement msi.dll completely compatible with the MS implementation... Shall I file a bug report? Regards, Robert

4 6

MSVCP60.dll
by John Emmas June 22, 2012

June 22, 2012

Firstly, I'm not a Linux user. I'm a Windows programmer but I have a passing knowledge of Linux (and several friends who are Linux programmers). I write a Windows application which gets launched as a child process by a popular Linux DAW. My program was first written many years ago when the (then) current version of Wine was about v0.9.58. Over a hundred people are using my program with old versions of Wine and I've had no complaints so far. Recently however, two customers tried to use it with Wine v1.5.35. In both cases the program crashed - apparently because some particular function wasn't found in MSVCP60.dll (at the moment, we don't know which function). Both customers went to a web site called WineTricks from where they were able to install an alternative version of MSVCP60.dll. My app now gets past the place where it previously crashed although it now crashes further on... :-( It looks as if the MSVC6 runtime module(s) that now come with Wine aren't the same as the ones from v0.9.58. Either they're different versions of the Microsoft DLLs or maybe they're now being implemented by somebody else, perhaps as part of Wine development? Either way, they don't work with my particular app any more. I still have Visual C++6 installed on an old computer, together with both the source code and the (InstallShield) packager for my original app. So is there anything I can do to make this work? For example, do I need to link against a particular version of the MSVC6 runtime? Or do I need to configure my packager so that it specifically distributes the runtime modules that my app linked to? I never did that in the past - because whichever runtime came with Wine seemed to work. Any advice? John

4 7

Re: [1/2] windowscodecs: Implement GetPreview and GetThumbnail in the TIFF decoder.
by Vincent Povirk June 22, 2012

June 22, 2012

According to MSDN, GetPreview isn't supported on any decoder except WMPhoto, and if that's true it should probably be returning WINCODEC_ERR_UNSUPPORTEDOPERATION. And why bother with GetThumbnail if you're not going to do it properly? At least check whether a thumbnail exists in the image before returning something.

2 1

Re: d3dx9_36: Implentation of D3DXSHDot
by Alexandre Julliard June 22, 2012

June 22, 2012

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > +static void test_D3DXSHDot(void) > +{ > + unsigned int i; > + FLOAT a[64], b[64], got; > + CONST FLOAT expected[] = > + { 0.0f, 0.0f, 17.0f, 222.0f, 1300.0f, 5050.0f, 15225.0f, 38612.0f, 86352.0f, }; > + > + for (i = 0; i < 64; i++) > + { > + a[i] = (FLOAT)i; > + b[i] = (FLOAT)i + 0.5f; > + } You should start with a non-zero value to tests orders 0 and 1 properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9_36 [patch 4 of 4, try 2]: Save multiplications
by Alexandre Julliard June 22, 2012

June 22, 2012

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > @@ -1971,11 +1971,13 @@ FLOAT *WINAPI D3DXFloat16To32Array(FLOAT *pout, CONST D3DXFLOAT16 *pin, UINT n) > > FLOAT* WINAPI D3DXSHAdd(FLOAT *out, UINT order, const FLOAT *a, const FLOAT *b) > { > - UINT i; > + UINT i, sq_order; > > TRACE("out %p, order %u, a %p, b %p\n", out, order, a, b); > > - for (i = 0; i < order * order; i++) > + sq_order = order * order; > + > + for (i = 0; i < sq_order; i++) > out[i] = a[i] + b[i]; There's no reason to do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wintrust/tests: Fix build with MSVC.
by Dmitry Timoshkov June 22, 2012

June 22, 2012

Thomas Faber <thfabba(a)gmx.de> wrote: > FIELD_OFFSET isn't constant "enough". The problem is not with FIELD_OFFSET, but with applying shift and mask operations to a constant. -- Dmitry.

3 3

Re: d3dx9_36 [patch 1 of 4, try 2]: Implemetation of D3DXSHDot
by Dmitry Timoshkov June 22, 2012

June 22, 2012

Hello, Please follow http://wiki.winehq.org/SubmittingPatches instructions for naming patches when sending a patch series. Usually 'git format-patch -n' will do it for you. Otherwise testbot won't recognize the series. -- Dmitry.

1 0

Re: d3dx9_36 [patch 3 of 4, try 2]: Implemetation of D3DXSHMultiply2
by Marvin June 22, 2012

June 22, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19429 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: d3dx9_36 [patch 1 of 4, try 2]: Implemetation of D3DXSHScale
by Marvin June 22, 2012

June 22, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19428 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

re: [PATCH 2/5] ddraw: Use wined3d_get_adapter_display_mode() in CreateSurface().
by Dan Kegel June 21, 2012

June 21, 2012

Henri wrote: - hr = wined3d_device_get_display_mode(ddraw->wined3d_device, 0, &mode); - if (FAILED(hr)) + if (FAILED(hr = wined3d_get_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &mode))) Seems like a step back in readability to combine setting and testing hr. - Dan

1 0

Examples of AJ silently improving patches?
by Dan Kegel June 21, 2012

June 21, 2012

AJ sometimes kindly fixes problems in patches while committing them (I guess it's easier than rejecting the patch for small issues). I wonder if these silent improvements would be worth collecting as a sort of style-guide-by-example. Anyone remember any good examples? I've started a list at http://wiki.winehq.org/StyleExamples

4 3

Re: [PATCH 1/7] ntdll: Add support for junction point creation.
by Hans Leidekker June 21, 2012

June 21, 2012

On Wed, 2012-06-20 at 17:26 -0600, Erich E. Hoover wrote: > + TRACE("Linking %s to %s\n", unix_src.Buffer, unix_dest.Buffer); > + if (rmdir( unix_src.Buffer ) < 0) > + { > + status = FILE_GetNtStatus(); > + goto cleanup; > + } > + if (symlink( unix_dest.Buffer, unix_src.Buffer ) < 0) > + { > + status = FILE_GetNtStatus(); > + goto cleanup; > + } > + status = STATUS_SUCCESS; This is not an atomic operation since you need two Unix calls. So you would need locking or rollback to deal with possible races. Should permissions and ownership be preserved on the directory when a junction is removed?

2 2

[1/5] windowscodecs: Implement PixelFormatInfo_GetBitsPerPixel.
by Vincent Povirk June 21, 2012

June 21, 2012

1 0

Re: kernel32: Add a test for deleting an opened for reading file. Take 2.
by Eric Pouech June 21, 2012

June 21, 2012

one tricky question... could it be that on windows this test behaves differently on ntfs vs FAT filesystem ? or what would give re-opening the file after the deletefile call ? A+ 2012/6/21, Dmitry Timoshkov <dmitry(a)baikal.ru>: > Previous version had a typo in file name. > --- > dlls/kernel32/tests/file.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c > index 8768b99..0a662d9 100644 > --- a/dlls/kernel32/tests/file.c > +++ b/dlls/kernel32/tests/file.c > @@ -3236,6 +3236,31 @@ static void test_CreatFile(void) > > DeleteFile(file_name); > } > +static void test_delete_file(void) > +{ > + char temp_path[MAX_PATH], temp_file[MAX_PATH]; > + HANDLE hfile; > + int ret; > + > + GetTempPathA(MAX_PATH, temp_path); > + GetTempFileName(temp_path, "tst", 0, temp_file); > + > + SetLastError(0xdeadbeef); > + hfile = CreateFile(temp_file, GENERIC_READ, FILE_SHARE_DELETE | > FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); > + ok(hfile != INVALID_HANDLE_VALUE, "CreateFile error %d\n", > GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = DeleteFile(temp_file); > +todo_wine > + ok(ret, "DeleteFile error %d\n", GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = CloseHandle(hfile); > + ok(ret, "CloseHandle error %d\n", GetLastError()); > + ret = DeleteFile(temp_file); > +todo_wine > + ok(!ret, "DeleteFile should fail\n"); > +} > > START_TEST(file) > { > @@ -3257,6 +3282,7 @@ START_TEST(file) > test_CreateFileW(); > test_DeleteFileA(); > test_DeleteFileW(); > + test_delete_file(); > test_MoveFileA(); > test_MoveFileW(); > test_FindFirstFileA(); > -- > 1.7.11 > > > > -- -- Eric Pouech

1 0

Re: wintrust/tests: Fix build with MSVC.
by Dmitry Timoshkov June 21, 2012

June 21, 2012

Thomas Faber <thfabba(a)gmx.de> wrote: > Empty braces are no valid initializer. > FIELD_OFFSET isn't constant "enough". > + /* add 'jmp ExitProcess' instruction */ > + count = 2; > + bin.text_section[count++] = 0xFF; > + bin.text_section[count++] = 0x25; > + bin.text_section[count++] = EXIT_PROCESS&0xFF; > + bin.text_section[count++] = (EXIT_PROCESS>>8)&0xFF; > + bin.text_section[count++] = (EXIT_PROCESS>>16)&0xFF; > + bin.text_section[count++] = (EXIT_PROCESS>>24)&0xFF; This part of the patch obviously is not related to the patch description. -- Dmitry.

1 0

Re: kernel32: Add a test for deleting an opened for reading file.
by Marvin June 21, 2012

June 21, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19407 Your paranoid android. === WNT4WSSP6 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W2KPROSP4 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === WXPPROSP3 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W2K3R2SESP2 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === WVISTAADM (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W2K8SE (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W7PRO (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W7PROX64 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === TEST64_W7SP1 (32 bit file) === file.c:3255: Test failed: DeleteFile error 2 === W7PROX64 (64 bit file) === file.c:3255: Test failed: DeleteFile error 2 === TEST64_W7SP1 (64 bit file) === file.c:3255: Test failed: DeleteFile error 2

1 0

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 3.
by Dmitry Timoshkov June 20, 2012

June 20, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/windowscodecs/tiffformat.c | 75 +++++++++++++++++++++++++++++++++++++---- > 1 file changed, 69 insertions(+), 6 deletions(-) Just a note, that once this patch is committed plus today's IFD metadata reader improvements the infrastructure for metadata handling in TIFF files should be all done. WICExplorer is able to recognize and show complete metadata listings for every frame in a multiframe TIFF file (native riched20 is needed for nicer visualization). -- Dmitry.

1 0

Re: [PATCH] winspool/tests: Fix failures, when the spooler service is not running
by Marvin June 20, 2012

June 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19360 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: gdiplus: Implement GdipImageSelectActiveFrame. Take 2.
by Vincent Povirk June 20, 2012

June 20, 2012

Looks good to me.

1 0

RE: msi:RECORD_StreamFromFile bug, help needed
by robert.van.herk＠serioustoys.com June 20, 2012

June 20, 2012

> IStream is not exposed to the user, but an internal interface would probably end up looking a lot like IStream because we need read/write/seek operations, reference counting and the ability to create clones. So we might as well use IStream. Hmmm... Then I want exactly the same as SHCreateStreamOnFileEx, but the only difference is that the file should be opened with FILE_SHARE_DELETE. (I think). What is that policy on this? It seems overkill to copy istream.c from shlwapi, just because I want to change 1 flag. On the other hand, I don't want to expose more functions in the shlwapi header, as that would make it different from the Windows implementation... Regards, Robert

2 1

Re: mmcndmgr: Implement IMMCVersionInfo (try 5)
by Marvin June 20, 2012

June 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19325 Your paranoid android. === WNT4WSSP6 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000 === W2KPROSP4 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000

1 0

Re: shell32: Make ShellExecute use native file association databases as fallback path (try 2)
by Francois Gouget June 20, 2012

June 20, 2012

On Tue, 19 Jun 2012, Erik van Pienbroek wrote: [...] > Additionally a check is added to make sure no recursive loop is > triggered when the native file association database points back to > wine and the fallback path is triggered again This looks much better. [...] > @@ -1911,6 +1944,44 @@ static BOOL SHELL_execute( LPSHELLEXECUTEINFOW sei, SHELL_ExecuteW32 execfunc ) > strcatW(lpstrTmpFile, lpFile); > retval = (UINT_PTR)ShellExecuteW(sei_tmp.hwnd, sei_tmp.lpVerb, lpstrTmpFile, NULL, NULL, 0); > } > +#if defined(HAVE_FORK) && defined(HAVE_WAITPID) > + /* Integration with native file association database */ > + else if (!getenv("WINE_INSIDE_SHELLEXECUTE")) > + { [...] > + /* Prevent the situation where the native file association database > + * tries to run wine to execute a program and we trigger this fallback > + * path again and end up in a recursive loop */ > + setenv("WINE_INSIDE_SHELLEXECUTE", "1", 0); [...] + unsetenv("WINE_INSIDE_SHELLEXECUTE"); Setting WINE_INSIDE_SHELLEXECUTE here creates a race condition if two threads call ShellExecute() at the same time. So I think this should be set between the fork() and the exec() in SHELL_try_native_execute(). -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

msi:RECORD_StreamFromFile bug, help needed
by robert.van.herk＠serioustoys.com June 20, 2012

June 20, 2012

Hi all, I think I found a msi.dll, record.c, RECORD_StreamFromFile. This function calls GlobalAlloc, with a file size as an argument. However, I believe that this can easily fail (which it does in my case) when the file size is too large. In my case, my msi builder (WiX) calls MsiRecordSetStreamW, which calls static function RECORD_StreamFromFile. WiX calls MsiRecordSetStreamW on some file that seems to be 0x11b2acc5 bytes (296 megs) large. Trying to allocate the block of 296 megs causes the error: 036:Call msi.MsiRecordSetStreamW(00000003,00000002,0cc8078c L"C:\\users\\robert\\Temp\\3c5c43d5\\1bfe39fa\\#product.cab") ret=009a4c3a 0036:Call KERNEL32.CreateFileW(0cc8078c L"C:\\users\\robert\\Temp\\3c5c43d5\\1bfe39fa\\#product.cab",80000000,00000001,00000000,00000003,00000000,00000000) ret=202868cf 0036:Ret KERNEL32.CreateFileW() retval=00000100 ret=202868cf 0036:Call KERNEL32.GetFileSize(00000100,0033ef58) ret=202868ef 0036:Ret KERNEL32.GetFileSize() retval=11b2acc5 ret=202868ef 0036:Call KERNEL32.GlobalAlloc(00000000,11b2acc5) ret=202869fb 0036:Ret KERNEL32.GlobalAlloc() retval=00000000 ret=202869fb <--- fail I believe the call to GlobalAlloc stems from RECORD_StreamFromFile. This tries to copy the full contents of the file in memory, and then create an IStream from that memory using CreateStreamOnHGlobal: /* read the data in a file into an IStream */ static UINT RECORD_StreamFromFile(LPCWSTR szFile, IStream **pstm) { ... handle = CreateFileW(szFile, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL); ... sz = GetFileSize(handle, &szHighWord); if( sz != INVALID_FILE_SIZE && szHig sz = GetFileSize(handle, &szHighWord); if( sz != INVALID_FILE_SIZE && szHighWord == 0 ) { hGlob = GlobalAlloc(GMEM_FIXED, sz); // <-- Fails in my case, because sz == 296 megs if( hGlob ) { BOOL r = ReadFile(handle, hGlob, sz, &read, NULL); if( !r ) { GlobalFree(hGlob); hGlob = 0; } } CloseHandle(handle); if( !hGlob ) return ERROR_FUNCTION_FAILED; // <-- hence, this error is raised. hr = CreateStreamOnHGlobal(hGlob, TRUE, pstm); ... } I want to fix this. I guess that apart from that the allocation fails, I have the feeling that copying this entire 296 megs into main memory is anyway a bit heavy, just for creating a stream. So I thought a better solution would be just to create a stream from the file. My first guess would be to use the SHCreateStreamOnFile function: HRESULT SHCreateStreamOnFile( __in LPCTSTR pszFile, __in DWORD grfMode, __out IStream **ppstm ); But then I was thinking: this seems like such an obvious thing to do, that it is almost suspicious. Was there any reason for copying the file contents to main memory and then create a memory stream? For instance, was the intention to have a non-mutable copy in memory, in case the backing file would be altered later on? I guess if that's the case, I could just create a copy of the original file in a temp dir, and mark it as STGM_DELETEONRELEASE. Before I wildly attempt a fix though, I would appreciate it if someone had an idea here... Kind regards, Robert van Herk

2 8

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability.
by André Hentschel June 19, 2012

June 19, 2012

Am 18.06.2012 15:52, schrieb Erich E. Hoover: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the code for finding the appropriate symbol has > been split out into a separate function (requested by Michael > Stefaniuc) and the string comparison has been modified to use the > larger of the two lengths (the length of the symbol to check and the > length of the symbol given in the help file). > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. You're adding dead code here, you should maybe merge Patch 1 & 2 -- Best Regards, André Hentschel

2 2

Re: shell32: add some tests for the Progman DDE interface
by Alexandre Julliard June 19, 2012

June 19, 2012

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * shell32: add some tests for the Progman DDE interface Please merge that with the existing tests, assuming that what you are testing is not already covered. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll : add ThreadQuerySetWin32StartAddress in NtQueryInformationThread
by Alexandre Julliard June 19, 2012

June 19, 2012

Roman Dadkov <romand(a)etersoft.ru> writes: > @@ -63,7 +63,7 @@ struct reply_header > /* this is used to construct the generic_request union */ > struct request_max_size > { > - int pad[16]; /* the max request size is 16 ints */ > + int pad[18]; /* the max request size is 18 ints */ > }; You can't change that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mmcndmgr: Implement IMMCVersionInfo (try 4)
by Alexandre Julliard June 19, 2012

June 19, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -66,8 +179,6 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > > switch (fdwReason) > { > - case DLL_WINE_PREATTACH: > - return FALSE; /* prefer native version */ Changing this may or may not be a good idea at this point, but it definitely shouldn't be silently sneaked in as part of a different patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)
by Akihiro Sagawa June 19, 2012

June 19, 2012

On Tue, 19 Jun 2012 03:39:18 -0300, Bruno Jesus wrote: > Hi, judging by the subjects I'd say the patches were commited already, > you're trying to send them again or are they different patches? > > http://source.winehq.org/git/wine.git/commitdiff/afdc84cf0366c8e161004bf1e7… > http://source.winehq.org/git/wine.git/commitdiff/2bb416baa88c28f57bb0f65aa9… > http://source.winehq.org/git/wine.git/commitdiff/f503afd86ff9df9467eb1351cf… Hi Bruno, Please ignore these patches. They were sent over 48 hours ago. It seems there is a huge delay between Gmail and wine-patches. Actually, one of my original patches are missed `static' keyword as Dmitry spotted(*). Therefore, I added the keyword and sent series of patches again. But, during transfer (>48 hours), the original patch was updated by Alexandre, then committed. After a while, my modified version was delivered and tested although they have already been applied. * ... http://www.winehq.org/pipermail/wine-devel/2012-June/095956.html Akihiro Sagawa

2 2

Re: [website] Portuguese translation for release 1.4.1
by Lucas Zawacki June 19, 2012

June 19, 2012

Disregard this patch. I added the wrong file to the commit and will resend. On Tue, Jun 19, 2012 at 12:01 PM, Jeremy Newman <jnewman(a)codeweavers.com> wrote: > This is just english. Did you mean for that to happen? > > No need to send the english, as if the xml does not exist, the site will > always fall back to the english version already. > > -N > > > On 06/19/2012 09:49 AM, Lucas Zawacki wrote: >> >> From: Lucas Zawacki<lfzawacki(a)gmail.com> >> >> --- >> news/pt/2012061501.xml | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> create mode 100644 news/pt/2012061501.xml >> >> diff --git a/news/pt/2012061501.xml b/news/pt/2012061501.xml >> new file mode 100644 >> index 0000000..7c0ff9f >> --- /dev/null >> +++ b/news/pt/2012061501.xml >> @@ -0,0 +1,13 @@ >> +<news> >> +<date>June 15, 2012</date> >> +<title>Wine 1.4.1 Released</title> >> +<body> >> + The Wine maintenance release 1.4.1 is now available. >> + <a href="{$root}/announce/1.4.1">What's new</a> in this release: >> +<ul> >> +<li>Translation updates.</li> >> +<li>Various bug fixes.</li> >> +</ul> >> +The source is<a >> href="http://prdownloads.sourceforge.net/wine/wine-1.4.1.tar.bz2">available >> now</a>. >> +Binary packages are in the process of being built, and will appear soon >> at their respective<a href="{$root}/download">download locations</a>. >> +</body></news>

1 0

Re: [5/5] gdiplus: Implement GdipImageSelectActiveFrame.
by Vincent Povirk June 19, 2012

June 19, 2012

> + hr = IStream_Clone(image->stream, &stream); > + if (FAILED(hr)) That's odd. When does that happen? > + if (stat == Ok) > + { > + memcpy(&new_image->format, &codec->info.FormatID, sizeof(GUID)); > + free_image_data(image); > + if (image->type == ImageTypeBitmap) > + *(GpBitmap *)image = *(GpBitmap *)new_image; > + else if (image->type == ImageTypeMetafile) > + *(GpMetafile *)image = *(GpMetafile *)new_image; > + return Ok; > + } Why did you re-implement move_bitmap() ?

2 5

Re: d3dx9_36 [patch 1of 2]: Implementation of D3DXSHDot
by Matteo Bruni June 19, 2012

June 19, 2012

2012/6/19 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: +static void test_D3DXSHDot(void) +{ + unsigned int i; + FLOAT a[90], b[90], got; + CONST FLOAT expected[] = + { 0.0f, 0.0f, 17.0f, 222.0f, 1300.0f, 5050.0f, 15225.0f, 38612.0f, 86352.0f, 175500.0f, }; + + for (i = 0; i < 90; i++) + { + a[i] = (FLOAT)i; + b[i] = (FLOAT)i + 0.5f; + } + +/* D3DXSHDot computes by using order * order elements */ + for (i = 0; i < 9; i++) + { + got = D3DXSHDot(i, a, b); + ok(relative_error(got, expected[i]) < admitted_error, "order %d: expected %f, received %f\n", i, expected[i], got); + } + + return; +} + Making the "a" and "b" arrays 90 elements big doesn't make much sense. If your D3DXSHDot implementation is correct, for the i = 8 case you only need 8 * 8 = 64 elements. Also notice that the "expected" array has 10 elements, while you use only 9. Also please recheck formatting and whitespaces of this patch and patch 2/2.

1 0

Re: [appdb] Upgrade to xinha svn head to fix issues with xinha editors not appearing in Firefox 15
by Ricardo Filipe June 19, 2012

June 19, 2012

2012/6/18 André Hentschel <nerv(a)dawncrow.de>: > http://bugs.winehq.org/show_bug.cgi?id=30820 > --- > xinha/Xinha.css | 229 +- > xinha/XinhaCore.js |12107 ++++++++++++++------ > xinha/contrib/php-xinha.php | 29 +- > xinha/examples/Extended.html | 299 - > xinha/examples/Newbie.html | 12 +- > xinha/examples/XinhaConfig.js | 149 +- > xinha/examples/custom.css | 40 - > xinha/examples/dynamic.css | 56 - > xinha/examples/ext_example-body.html | 202 - > xinha/examples/ext_example-dest.php | 23 - > xinha/examples/ext_example-menu.php | 331 - > xinha/examples/ext_example.html | 16 - > xinha/examples/full_example.css | 48 - > xinha/examples/full_example.js | 97 - > xinha/examples/simple_example.html | 190 +- > xinha/examples/stylist.css | 31 - > xinha/examples/testbed.html | 45 +- > xinha/htmlarea.js | 44 +- > xinha/lang/b5.js | 58 +- > xinha/lang/ch.js | 112 +- > xinha/lang/cz.js | 100 +- > xinha/lang/da.js | 202 +- > xinha/lang/de.js | 338 +- > xinha/lang/ee.js | 100 +- > xinha/lang/el.js | 110 +- > xinha/lang/es.js | 207 +- > xinha/lang/eu.js | 2 +- > xinha/lang/fa.js | 6 +- > xinha/lang/fi.js | 76 +- > xinha/lang/fr.js | 338 +- > xinha/lang/gb.js | 58 +- > xinha/lang/he.js | 128 +- > xinha/lang/hu.js | 128 +- > xinha/lang/it.js | 110 +- > xinha/lang/ja.js | 6 +- > xinha/lang/lt.js | 106 +- > xinha/lang/lv.js | 84 +- > xinha/lang/nb.js | 156 +- > xinha/lang/nl.js | 128 +- > xinha/lang/pl.js | 2 +- > xinha/lang/pt_br.js | 180 +- > xinha/lang/ro.js | 126 +- > xinha/lang/ru.js | 370 +- > xinha/lang/sh.js | 2 +- > xinha/lang/si.js | 100 +- > xinha/lang/sr.js | 2 +- > xinha/lang/vn.js | 112 +- > xinha/modules/ColorPicker/ColorPicker.js | 1494 ++- > xinha/modules/CreateLink/link.js | 190 +- > xinha/modules/Dialogs/dialog.js | 159 +- > xinha/modules/Dialogs/inline-dialog.js | 204 - > xinha/modules/Dialogs/panel-dialog.js | 1 + > xinha/modules/Dialogs/popupwin.js | 291 +- > xinha/modules/FullScreen/full-screen.js | 373 +- > xinha/modules/Gecko/Gecko.js | 1225 ++- > xinha/modules/Gecko/paraHandlerBest.js | 1196 ++- > xinha/modules/Gecko/paraHandlerDirty.js | 116 - > xinha/modules/GetHtml/DOMwalk.js | 519 +- > xinha/modules/GetHtml/TransformInnerHTML.js | 368 +- > xinha/modules/InsertImage/insert_image.html | 345 +- > xinha/modules/InsertImage/insert_image.js | 214 +- > xinha/modules/InsertTable/insert_table.html | 314 +- > xinha/modules/InsertTable/insert_table.js | 153 +- > xinha/modules/InternetExplorer/InternetExplorer.js | 1150 ++- > xinha/plugins/CSS/css.js | 74 - > xinha/plugins/CharCounter/char-counter.js | 106 - > xinha/plugins/CharacterMap/CharacterMap.css | 6 +- > xinha/plugins/CharacterMap/character-map.js | 68 - > xinha/plugins/CharacterMap/lang/de.js | 22 +- > .../CharacterMap/popups/select_character.html | 184 - > xinha/plugins/ContextMenu/1.pl | 38 - > xinha/plugins/ContextMenu/context-menu.js | 383 - > xinha/plugins/ContextMenu/lang/de.js | 100 +- > xinha/plugins/ContextMenu/lang/el.js | 94 +- > xinha/plugins/ContextMenu/lang/fr.js | 98 +- > xinha/plugins/ContextMenu/lang/he.js | 94 +- > xinha/plugins/ContextMenu/lang/nl.js | 94 +- > xinha/plugins/DoubleClick/double-click.js | 66 - > xinha/plugins/DynamicCSS/dynamiccss.js | 199 - > xinha/plugins/DynamicCSS/lang/de.js | 24 +- > xinha/plugins/DynamicCSS/lang/fr.js | 12 +- > xinha/plugins/FindReplace/find-replace.js | 42 - > xinha/plugins/FindReplace/fr_engine.js | 291 +- > xinha/plugins/FindReplace/lang/pt_br.js | 60 +- > xinha/plugins/FindReplace/popups/find_replace.html | 324 +- > xinha/plugins/Forms/forms.js | 354 - > xinha/plugins/Forms/popups/fieldset.html | 15 +- > xinha/plugins/Forms/popups/form.html | 21 +- > xinha/plugins/Forms/popups/input.html | 78 +- > xinha/plugins/Forms/popups/label.html | 15 +- > xinha/plugins/Forms/popups/select.html | 217 +- > xinha/plugins/Forms/popups/textarea.html | 41 +- > xinha/plugins/FullPage/full-page.js | 200 - > xinha/plugins/FullPage/lang/de.js | 36 +- > xinha/plugins/FullPage/lang/fr.js | 32 +- > xinha/plugins/FullPage/lang/he.js | 28 +- > xinha/plugins/FullPage/lang/ro.js | 28 +- > xinha/plugins/FullPage/popups/docprop.html | 282 +- > xinha/plugins/FullScreen/full-screen.js | 203 - > xinha/plugins/FullScreen/lang/de.js | 6 - > xinha/plugins/FullScreen/lang/fr.js | 5 - > xinha/plugins/FullScreen/lang/no.js | 6 - > xinha/plugins/FullScreen/lang/pl.js | 6 - > xinha/plugins/HtmlTidy/README | 104 - > xinha/plugins/HtmlTidy/html-tidy-config.cfg | 29 - > xinha/plugins/HtmlTidy/html-tidy-logic.php | 79 - > xinha/plugins/HtmlTidy/html-tidy.js | 105 - > xinha/plugins/HtmlTidy/img/html-tidy.gif | Bin 599 -> 0 bytes > xinha/plugins/HtmlTidy/lang/de.js | 7 - > xinha/plugins/HtmlTidy/lang/fr.js | 8 - > xinha/plugins/HtmlTidy/lang/ja.js | 8 - > xinha/plugins/HtmlTidy/lang/nb.js | 7 - > xinha/plugins/HtmlTidy/lang/nl.js | 5 - > xinha/plugins/InsertAnchor/insert-anchor.css | 1 - > xinha/plugins/InsertAnchor/insert-anchor.js | 76 - > xinha/plugins/InsertPicture/InsertPicture.php | 301 - > xinha/plugins/InsertPicture/img/btn_open.gif | Bin 173 -> 0 bytes > xinha/plugins/InsertPicture/img/nopic.gif | Bin 1537 -> 0 bytes > xinha/plugins/InsertPicture/insert-picture.js | 25 - > xinha/plugins/InsertPicture/lang/de.js | 15 - > xinha/plugins/InsertPicture/lang/fr.js | 22 - > xinha/plugins/InsertPicture/lang/ja.js | 25 - > xinha/plugins/InsertPicture/lang/nb.js | 22 - > xinha/plugins/InsertPicture/lang/sv.js | 35 - > xinha/plugins/InsertPicture/viewpicture.html | 46 - > xinha/plugins/InsertWords/insert-words.js | 70 - > xinha/plugins/Linker/dTree/api.html | 502 +- > xinha/plugins/Linker/dTree/dtree.css | 8 +- > xinha/plugins/Linker/dTree/dtree.js | 1037 ++- > xinha/plugins/Linker/dTree/example01.html | 104 +- > xinha/plugins/Linker/dialog.html | 210 +- > xinha/plugins/Linker/linker.js | 385 - > xinha/plugins/Linker/scan.php | 220 +- > xinha/plugins/ListType/lang/de.js | 24 +- > xinha/plugins/ListType/list-type.js | 137 - > xinha/plugins/QuickTag/lang/pt_br.js | 26 +- > xinha/plugins/QuickTag/popups/quicktag.html | 706 +- > xinha/plugins/QuickTag/quick-tag.js | 53 - > xinha/plugins/QuickTag/tag-lib.js | 381 +- > xinha/plugins/SpellChecker/aspell_setup.php | 246 +- > xinha/plugins/SpellChecker/lang/cz.js | 52 +- > xinha/plugins/SpellChecker/lang/da.js | 52 +- > xinha/plugins/SpellChecker/lang/de.js | 52 +- > xinha/plugins/SpellChecker/lang/he.js | 54 +- > xinha/plugins/SpellChecker/lang/hu.js | 52 +- > xinha/plugins/SpellChecker/lang/nl.js | 54 +- > xinha/plugins/SpellChecker/lang/ro.js | 52 +- > xinha/plugins/SpellChecker/readme-tech.html | 228 +- > xinha/plugins/SpellChecker/spell-check-logic.cgi | 420 +- > xinha/plugins/SpellChecker/spell-check-logic.php | 340 +- > .../plugins/SpellChecker/spell-check-savedicts.php | 74 +- > xinha/plugins/SpellChecker/spell-check-ui.html | 250 +- > xinha/plugins/SpellChecker/spell-check-ui.js | 846 +- > xinha/plugins/SpellChecker/spell-checker.js | 73 - > xinha/plugins/Stylist/stylist.js | 372 - > xinha/plugins/SuperClean/dialog.html | 14 +- > xinha/plugins/SuperClean/lang/de.js | 3 +- > xinha/plugins/SuperClean/super-clean.js | 211 - > xinha/plugins/SuperClean/tidy.php | 358 +- > xinha/plugins/TableOperations/lang/cz.js | 158 +- > xinha/plugins/TableOperations/lang/da.js | 161 +- > xinha/plugins/TableOperations/lang/de.js | 162 +- > xinha/plugins/TableOperations/lang/el.js | 158 +- > xinha/plugins/TableOperations/lang/fi.js | 136 +- > xinha/plugins/TableOperations/lang/fr.js | 154 +- > xinha/plugins/TableOperations/lang/he.js | 158 +- > xinha/plugins/TableOperations/lang/it.js | 158 +- > xinha/plugins/TableOperations/lang/ja.js | 6 +- > xinha/plugins/TableOperations/lang/nb.js | 158 +- > xinha/plugins/TableOperations/lang/nl.js | 158 +- > xinha/plugins/TableOperations/lang/pl.js | 6 +- > xinha/plugins/TableOperations/lang/ro.js | 158 +- > xinha/plugins/TableOperations/lang/ru.js | 6 +- > xinha/plugins/TableOperations/lang/sv.js | 6 +- > .../TableOperations/popups/merge_cells.html | 11 +- > xinha/plugins/TableOperations/table-operations.js | 893 -- > xinha/plugins/UnFormat/popups/unformat.html | 85 - > xinha/plugins/UnFormat/un-format.js | 65 - > xinha/popups/about.html | 296 - > xinha/popups/blank.html | 3 +- > xinha/popups/editor_help.html | 122 +- > xinha/popups/popup.js | 239 +- > xinha/popups/select_color.html | 716 +- > xinha/release-notes.txt | 476 +- > xinha/skins/blue-look/skin.css | 14 +- > xinha/skins/blue-metallic/skin.css | 7 + > xinha/skins/green-look/skin.css | 10 +- > xinha/skins/inditreuse/skin.css | 10 +- > xinha/skins/titan/skin.css | 10 +- > xinha/skins/xp-blue/skin.css | 10 +- > xinha/skins/xp-green/skin.css | 10 +- > 191 files changed, 22579 insertions(+), 20386 deletions(-) > delete mode 100644 xinha/examples/Extended.html > delete mode 100644 xinha/examples/custom.css > delete mode 100644 xinha/examples/dynamic.css > delete mode 100644 xinha/examples/ext_example-body.html > delete mode 100644 xinha/examples/ext_example-dest.php > delete mode 100644 xinha/examples/ext_example-menu.php > delete mode 100644 xinha/examples/ext_example.html > delete mode 100644 xinha/examples/full_example.css > delete mode 100644 xinha/examples/full_example.js > delete mode 100644 xinha/examples/stylist.css > delete mode 100644 xinha/modules/Dialogs/inline-dialog.js > mode change 100644 => 100755 xinha/modules/FullScreen/lang/sv.js > delete mode 100644 xinha/modules/Gecko/paraHandlerDirty.js > delete mode 100644 xinha/plugins/CSS/css.js > delete mode 100644 xinha/plugins/CharCounter/char-counter.js > delete mode 100644 xinha/plugins/CharacterMap/character-map.js > mode change 100644 => 100755 xinha/plugins/CharacterMap/lang/sv.js > delete mode 100644 xinha/plugins/CharacterMap/popups/select_character.html > delete mode 100755 xinha/plugins/ContextMenu/1.pl > delete mode 100644 xinha/plugins/ContextMenu/context-menu.js > delete mode 100644 xinha/plugins/DoubleClick/double-click.js > delete mode 100644 xinha/plugins/DynamicCSS/dynamiccss.js > delete mode 100644 xinha/plugins/FindReplace/find-replace.js > mode change 100644 => 100755 xinha/plugins/FindReplace/lang/sv.js > delete mode 100644 xinha/plugins/Forms/forms.js > delete mode 100644 xinha/plugins/FullPage/full-page.js > delete mode 100644 xinha/plugins/FullScreen/full-screen.js > delete mode 100644 xinha/plugins/FullScreen/lang/de.js > delete mode 100644 xinha/plugins/FullScreen/lang/fr.js > delete mode 100644 xinha/plugins/FullScreen/lang/no.js > delete mode 100644 xinha/plugins/FullScreen/lang/pl.js > delete mode 100644 xinha/plugins/HtmlTidy/README > delete mode 100644 xinha/plugins/HtmlTidy/html-tidy-config.cfg > delete mode 100755 xinha/plugins/HtmlTidy/html-tidy-logic.php > delete mode 100644 xinha/plugins/HtmlTidy/html-tidy.js > delete mode 100644 xinha/plugins/HtmlTidy/img/html-tidy.gif > delete mode 100644 xinha/plugins/HtmlTidy/lang/de.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/fr.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/ja.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/nb.js > delete mode 100644 xinha/plugins/HtmlTidy/lang/nl.js > delete mode 100755 xinha/plugins/InsertAnchor/insert-anchor.js > delete mode 100644 xinha/plugins/InsertPicture/InsertPicture.php > delete mode 100644 xinha/plugins/InsertPicture/img/btn_open.gif > delete mode 100644 xinha/plugins/InsertPicture/img/nopic.gif > delete mode 100644 xinha/plugins/InsertPicture/insert-picture.js > delete mode 100644 xinha/plugins/InsertPicture/lang/de.js > delete mode 100644 xinha/plugins/InsertPicture/lang/fr.js > delete mode 100644 xinha/plugins/InsertPicture/lang/ja.js > delete mode 100644 xinha/plugins/InsertPicture/lang/nb.js > delete mode 100644 xinha/plugins/InsertPicture/lang/sv.js > delete mode 100644 xinha/plugins/InsertPicture/viewpicture.html > delete mode 100755 xinha/plugins/InsertWords/insert-words.js > delete mode 100644 xinha/plugins/Linker/linker.js > mode change 100644 => 100755 xinha/plugins/ListType/lang/sv.js > delete mode 100644 xinha/plugins/ListType/list-type.js > delete mode 100644 xinha/plugins/QuickTag/quick-tag.js > delete mode 100644 xinha/plugins/SpellChecker/spell-checker.js > delete mode 100644 xinha/plugins/Stylist/stylist.js > delete mode 100644 xinha/plugins/SuperClean/super-clean.js > mode change 100644 => 100755 xinha/plugins/TableOperations/lang/sv.js > mode change 100644 => 100755 xinha/plugins/TableOperations/popups/merge_cells.html > delete mode 100644 xinha/plugins/TableOperations/table-operations.js > delete mode 100644 xinha/plugins/UnFormat/popups/unformat.html > delete mode 100644 xinha/plugins/UnFormat/un-format.js > delete mode 100644 xinha/popups/about.html > > > -- > > Best Regards, André Hentschel > > > > The xinha editor does not show up in chrome either for a long time now... could it be related to this? I even opened a bug report on chromium but it still wasn't looked at. Maybe this solves it too...

1 0

'Expensive' expressions in loop limits (was: Implementation of D3DXSHScale)
by Dan Kegel June 19, 2012

June 19, 2012

Nozomi wrote: + for (i = 0; i < order * order; i++) I might have written int n = order * order; for (i=0; i < n; i++) to avoid repeating the multiplication every time around the loop, even though multiplication is cheap nowadays, and -O1 will optimize it out anyway. Staying in the habit of avoiding 'expensive' operations in loop limits might still be a good idea, since the optimizer can't always save you. Or is that considered ugly these days? D3DXSHAdd() has the same code, which is where this came from, probably.

2 1

Re: d3dx9_36: Implementation of a test for D3DFMT_A8B8G8R8
by Józef Kucia June 19, 2012

June 19, 2012

I've also added a tests for this pixel format in the patch, which was submitted yesterday: http://www.winehq.org/pipermail/wine-patches/2012-June/115268.html

1 0

Re: [PATCH 2/3] gdi32: Fix East-Asian font parameters. (resend)
by Marvin June 19, 2012

June 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19270 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0