June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)
by Marvin June 19, 2012

June 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19269 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 3.
by Vincent Povirk June 19, 2012

June 19, 2012

I'm still a little worried about seeking the stream behind libtiff's back, but otherwise it looks good.

2 1

Disabling joysticks with registry keys and joy.cpl
by Lucas Zawacki June 19, 2012

June 19, 2012

Hello all, disabling an specific joystick device is an issue that is raised from time to time in this list. I'm planning on implementing it as a registry key like 'DirectInput/Disable controllername'. However I'd like the ability to disable specific joysticks on Linux, like the /dev/input/js* version, while keeping the /dev/input/event* one being enumerated. One option for doing this would be having a "Disable USB Controller" -> "driver" key with options being: "linux", "linuxinput", and "all". My only doubt is how would you guys want to have this option in joy.cpl? I think the correct thing to do would be to disable it with "all", but my use case includes a user disabling the repeated joysticks on Linux through the interface and if he's only able to disable all drivers at once that would be confusing and less useful. The bottom line is: can I add platform dependent code in joy.cpl for this purpose? If that's not an option, do you have some other way to do through joy.cpl or should it be registry only? Attached is an example patch of the approach for joystick_linuxinput.c Cheers, Lucas

2 2

Re: d3dx9_36: Reckonize A8B8G8R8 format
by Stefan Dösinger June 18, 2012

June 18, 2012

Hi, Please add the format to the dds tests in dlls/d3dx9_36/tests/surface.c > { 32, 0x0000ffff, 0xffff0000, 0x00000000, 0x00000000, D3DFMT_G16R16 }, > + { 32, 0xff, 0xff00, 0xff0000, 0xff000000, D3DFMT_A8B8G8R8 }, The other 32 bit formats in this table have their bitmasks padded to 32 bit with leading zeroes. Stefan Am Freitag, 15. Juni 2012, 18:18:46 schrieb Nozomi Kodama: This patch solves the color problem appearing in bug 30786. Nozomi

1 1

Re: comctl32: hotkey control needs to invalidate itself when painting for some apps
by Dmitry Timoshkov June 18, 2012

June 18, 2012

Dan Kegel <dank(a)kegel.com> wrote: > @@ -190,6 +190,8 @@ HOTKEY_Paint(HOTKEY_INFO *infoPtr, HDC hdc) > HOTKEY_Refresh(infoPtr, hdc); > else { > PAINTSTRUCT ps; > + /* In some apps, the hotkey doesn't draw unless we invalidate it here */ > + InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); It doesn't make sense to invalidate before painting in the paint handler. -- Dmitry.

2 1

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Chris Robinson June 18, 2012

June 18, 2012

On Friday, June 15, 2012 3:39:33 PM Andrew Eikum wrote: > One thing to note is that PulseAudio has an absurdly high default > latency (two seconds), and due to its poor API there's no (easy) way > for us to control it. The latency is likely caused by PulseAudio setting a much larger tlength (and minreq) than what you asked for. This happens all the time for me when the server has been running. The trick I've found to dealing with this in OpenAL Soft is to essentially ignore what PulseAudio sets and do your free space calculations so that only the size of the buffer you requested is used. Something like: size_t writable_size(pulse_data *data) { uint buffer_size = our requested buffer size in bytes; uint update_size = our expected period size in bytes; /* This is signed since it could come out negative */ ssize_t len; pa_threaded_mainloop_lock(data->loop); len = pa_stream_writable_size(data->stream) - data->attr.tlength + buffer_size; pa_threaded_mainloop_unlock(data->loop); if(len < 0) return 0; len -= len%update_size; return len; } The update_size is only relevant if mmdevapi updates in period-sized chunks. If it doesn't, you can just remove it and the rounding. The tlength should be kept updated using pa_stream_set_buffer_attr_callback, in case the server tries to increase it more during runtime. When creating the stream, I set minreq to the period size, and tlength to the requested buffer size. I also set the flags PA_STREAM_INTERPOLATE_TIMING, PA_STREAM_AUTO_TIMING_UPDATE, and PA_STREAM_ADJUST_LATENCY. The most important part is to not rely on PA_STREAM_EARLY_REQUESTS or the write callback to tell you when some space is free for writing, since as noted above, PulseAudio can set unreasonably large values. This doesn't completely fix the latency problem, as I'll still get better performance using ALSA's dmix, but it helps immensely.

2 4

comctl32: hotkey control needs to invalidate itself when painting for some apps
by Dan Kegel June 18, 2012

June 18, 2012

In at least one app, the hotkey control doesn't draw itself. Invalidating its own window during HOTKEY_Paint gets the control to draw properly, and makes the app happy. Fixes http://bugs.winehq.org/show_bug.cgi?id=30486 (Unlike the patch attached to that bug, this one doesn't also ask the background to be redrawn again.)

2 1

Re: windowscodecs: Create a IWICMetadataReader for a TIFF frame. Take 2.
by Vincent Povirk June 18, 2012

June 18, 2012

This looks better, but I still think you should use WICPersistOptionNoCacheStream. Some of your failure cases in create_metadata_reader will return a reference to an IWICMetadataReader, which seems wrong.

2 1

Re: windowscodecs: Create a IWICMetadataReader when loading a TIFF frame.
by Vincent Povirk June 18, 2012

June 18, 2012

> + hr = IWICPersistStream_LoadEx(persist, This->parent->stream, NULL, persist_options); > + if (FAILED(hr)) > + ERR("IWICPersistStream_LoadEx error %#x\n", hr); We can't use that stream because we provide separate seek and read/write methods to libtiff, and libtiff may rely on the stream's position to not change between operations. This illustrates a design flaw in WIC. Normally, we would just clone the stream, but IWICStream doesn't implement the Clone method. I think we are probably supposed to create a new IWICStream based on the given stream, but the resulting stream won't be thread-safe with ours. I think for now it's OK to re-use this stream as long as you seek it back to where it was when you're done, but we may have to change that later. Also, LoadEx should (but does not yet) save the stream so it can create an IWICFastMetadataEncoder. If you re-use the bitmap decoder's stream, you should also use the WICPersistOptionNoCacheStream flag when you create the metadata reader to make sure it won't do that. Your GetReaderByIndex method should check whether This->metadata_reader has been set and return an error if not. Otherwise, the patch looks good to me.

2 4

Re: atl80: prefer native, if present
by Alexandre Julliard June 18, 2012

June 18, 2012

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 7243b3594c9c0b13770ede1ab32d4dd1329b1dd4 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Sun, 17 Jun 2012 17:37:15 +0200 > Subject: atl80: prefer native, if present > > --- > dlls/atl80/atl80.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) There's no reason to do that, most of the dll is already implemented. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Darryl Slack June 18, 2012

June 18, 2012

Well after fighting with pulseaudio after all this time I have tried this patch with wine 1.5.6 with a Presonus StudioLive 24.4.2 Fire-wire controller within wine, to control software known as Virtual DJ with timecoded vinyl records. With Andrew's patch, there are stalled buffer errors, and I wasn't able to measure latency very well because the controller just kept on reporting 'stalled' I did also try martaans driver, which was added to wine, and latency was much lower, and the controller worked well within Linux, in fact the first time i've actually been able to use it with pulseaudio. I was measuring latency much lower than I expected, 2-4ms. With Andrew's Driver I was not even able to play a timecode from start to finish without 'stalled' buffers. Please Take the time to QA this driver for things just other than 'cos we have it' and consider Martaan's driver as well, because there is a massive improvement in latency over Andrews, and applications requiring fire-wire work much nicer with pulseaudio. My Wine build is 1.5.4, Gentoo 3.4.2-r1. Thanks Darryl

1 0

Re: mshtml: Implement IHTMLScriptElement_put_src
by Jacek Caban June 18, 2012

June 18, 2012

André, On 06/15/12 23:45, André Hentschel wrote: > --- > dlls/mshtml/htmlscript.c | 14 ++++++++++++-- > dlls/mshtml/tests/dom.c | 6 ++++++ > 2 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/htmlscript.c b/dlls/mshtml/htmlscript.c > index 376db7b..1714cfe 100644 > --- a/dlls/mshtml/htmlscript.c > +++ b/dlls/mshtml/htmlscript.c > @@ -101,8 +101,18 @@ static HRESULT WINAPI HTMLScriptElement_Invoke(IHTMLScriptElement *iface, DISPID > static HRESULT WINAPI HTMLScriptElement_put_src(IHTMLScriptElement *iface, BSTR v) > { > HTMLScriptElement *This = impl_from_IHTMLScriptElement(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_w(v)); > - return E_NOTIMPL; > + nsAString src_str; > + nsresult nsres; > + > + TRACE("(%p)->(%s)\n", This, debugstr_w(v)); > + > + nsAString_Init(&src_str, v); > + nsres = nsIDOMHTMLScriptElement_SetSrc(This->nsscript, &src_str); > + if (NS_FAILED(nsres)) > + ERR("SetSrc failed: %08x\n", nsres); > + nsAString_Finish (&src_str); > + > + return S_OK; > } > Unfortunately it's not so easy. That won't work this way. Jacek

1 0

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)
by Alexandre Julliard June 18, 2012

June 18, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE { > > /* From 0 to 4 */ > UCHAR LayerNumber; > -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE; > +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE; > + > +typedef struct _DVD_DESCRIPTOR_HEADER { > + USHORT Length; > + UCHAR Reserved[2]; > +#if !defined(_midl) > + UCHAR Data[0]; > +#endif > +} DVD_DESCRIPTOR_HEADER, *PDVD_DESCRIPTOR_HEADER; > +C_ASSERT(sizeof(DVD_DESCRIPTOR_HEADER) == 4); Zero-size arrays are not portable and should be avoided. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] wbemprox: Add tests for IWbemServices.
by Marvin June 18, 2012

June 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19208 Your paranoid android. === WNT4WSSP6 (32 bit services) === services.c:38: Test failed: failed to create IWbemLocator interface 80040154 services: unhandled exception c0000005 at 004019EE

1 0

Re: [2/2] comdlg32/tests: Test file name selection on init
by Marvin June 17, 2012

June 17, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19196 Your paranoid android. === WNT4WSSP6 (32 bit filedlg) === Timeout === W2KPROSP4 (32 bit filedlg) === Timeout === WXPPROSP3 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 7C809E32 === W2K3R2SESP2 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 77E63110 === WVISTAADM (32 bit filedlg) === filedlg: unhandled exception c0000005 at 76A75031 === W2K8SE (32 bit filedlg) === filedlg: unhandled exception c0000005 at 76285DBE === W7PRO (32 bit filedlg) === filedlg.c:1158: Test failed: The EM_GETSEL message returned with no selection

1 0

Re: [PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test
by Nikolay Sivov June 17, 2012

June 17, 2012

On 6/17/2012 13:11, Alexandre Goujon wrote: > > case DvdManufacturerDescriptor: > + nt_desc.manf->Header.Length = 0x0802; > + nt_desc.manf->Header.Reserved[0] = 0; > + nt_desc.manf->Header.Reserved[1] = 0; Does this length mean something? Looks a bit dirty to leave hardcoded things like that, but maybe I don't know details.

2 1

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)
by Nikolay Sivov June 17, 2012

June 17, 2012

On 6/17/2012 13:11, Alexandre Goujon wrote: > Superseeds the patch of the same name (#87003) > Definition and assert taken from Windows Driver Kit (WDK) 8 Consumer Preview > --- > include/ddk/ntddcdvd.h | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/include/ddk/ntddcdvd.h b/include/ddk/ntddcdvd.h > index 5313496..d0178c7 100644 > --- a/include/ddk/ntddcdvd.h > +++ b/include/ddk/ntddcdvd.h > @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE { > > /* From 0 to 4 */ > UCHAR LayerNumber; > -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE; > +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE; > + > +typedef struct _DVD_DESCRIPTOR_HEADER { > + USHORT Length; > + UCHAR Reserved[2]; > +#if !defined(_midl) > + UCHAR Data[0]; > +#endif > +} DVD_DESCRIPTOR_HEADER, *PDVD_DESCRIPTOR_HEADER; > +C_ASSERT(sizeof(DVD_DESCRIPTOR_HEADER) == 4); This looks wrong, correct name for it __midl, and this also needs a check for __WIDL__ probably.

2 1

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines.
by Dmitry Timoshkov June 17, 2012

June 17, 2012

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > - static const struct test_data > + const int font[] = > { > - int id, weight, height, dpi; > + ANSI_FIXED_FONT, ANSI_VAR_FONT, SYSTEM_FONT, DEVICE_DEFAULT_FONT, DEFAULT_GUI_FONT > + /* SYSTEM_FIXED_FONT, OEM_FIXED_FONT */ > + }; > + const struct test_data > + { Please add back 'static' to test_data and add it to font. -- Dmitry.

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Maarten Lankhorst June 16, 2012

June 16, 2012

What happened to the stamped capture buffers? Why is held_frames added? This doesn't look like an attempt to get my driver in, it looks like a rewrite by someone who doesn't understand why I made the design decisions I made for correctness. If you don't paste all the mmdevapi tests with the fix in my git tree, it's a regression. I don't want to see held_Frames because it's a shadow buffer. If winmm and dsound don't work without it, they're wrong, fix those. The logic I kept for timestamping audio buffers was removed which just makes timestamping less accurate on capture buffers. Was this driver even tested on low latency? There was a reason I kept track of all packets in a linked list, no need to do held_frames logic. I genuinely do want a good driver to go in, but this just isn't it. There is also no reason to have an INCREASED period size for exclusive compared to shared. I'm currently not handling exclusive because there are no good tests for it. and "hooray_cb" ? If this is going to be accepted (likely, sadly) I want to have this added to the commit: Rejected-by: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> ~Maarten PS: Still sad that you chose to reject my original driver not based on any merits.

1 0

Re: [PATCH] sfnt2fnt: Fix broken .fon files on !x86 architectures
by Alexandre Julliard June 15, 2012

June 15, 2012

Hilko Bengen <bengen(a)hilluzination.de> writes: > @@ -46,6 +46,8 @@ > > #include "pshpack1.h" > > +#include <endian.h> endian.h is not portable, you should use the endianness defines from the Wine headers instead. -- Alexandre Julliard julliard(a)winehq.org

4 9

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver
by Alexandre Julliard June 15, 2012

June 15, 2012

Andrew Eikum <aeikum(a)codeweavers.com> writes: > The configure.ac changes and parts of the driver itself were written by > Maarten Lankhorst. It doesn't work here, it's apparently using the driver even though PulseAudio is not running on this box: ../../../tools/runtest -q -P wine -M amstream.dll -T ../../.. -p amstream_test.exe.so amstream.c && touch amstream.ok err:pulse:AudioClient_Initialize PulseAudio no longer running? err:quartz:DSoundRender_create Cannot create Direct Sound object (88890010) fixme:ole:CoCreateInstance no instance created for interface {56a86895-0ad4-11ce-b03a-0020af0ba770} of class {79376820-07d0-11cf-a24d-0020afd79767}, hres is 0x88890010 amstream.c:274: Test failed: IAMMultiMediaStream_AddMediaStream returned: 88890010 -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH 1/4] DSS Test Suite: CryptAcquireContext tests for base DSS
by Alexandre Julliard June 15, 2012

June 15, 2012

Marek Chmiel <kcmark(a)gmail.com> writes: > From 748332765355ae099ab24cf1402bed86610984e7 Mon Sep 17 00:00:00 2001 > From: Marek Chmiel <kcmark(a)gmail.com> > Date: Fri, 1 Jun 2012 22:38:03 -0500 > Subject: [PATCH 1/4] Add CryptAcquireContext tests for base DSS CSP. > > --- > configure | 1 + > configure.ac | 1 + > dlls/dssenh/tests/Makefile.in | 7 +++ > dlls/dssenh/tests/dssenh.c | 119 +++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 128 insertions(+) > create mode 100644 dlls/dssenh/tests/Makefile.in > create mode 100644 dlls/dssenh/tests/dssenh.c You are adding 4 almost identical copies of that code. Try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2 resend] advapi32: Pass service name as argv[0] to ServiceMain
by Alexandre Julliard June 15, 2012

June 15, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > Resend with tests. > > --- > dlls/advapi32/service.c | 3 +-- > programs/services/tests/service.c | 4 ++++ > 2 files changed, 5 insertions(+), 2 deletions(-) You will now get the name twice for autostart services. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).
by Alexandre Julliard June 15, 2012

June 15, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > + while(min <= max) > + { > + const char *encoded_symbol; > + > + pos = (min+max)/2; > + encoded_symbol = html_encoded_symbols[pos].html_code; > + dir = strncmp(encoded_symbol, amp, len); You need to check the length, strncmp is not enough. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mmcndmgr: Implement IMMCVersionInfo (try 3)
by Marvin June 15, 2012

June 15, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19090 Your paranoid android. === WNT4WSSP6 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000 === W2KPROSP4 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000

1 0

Re: ru.po: improved an Russian translation
by Oleg Yarigin June 15, 2012

June 15, 2012

Hi, Julian! > 1. Patches should be sent to wine-patches(a)winehq.org, not wine-devel. Thank you a lot, I didn't know these address! > I don't think that's a good idea... Afaik, the general guideline is to > not change formatting and punctuation (from the English original), > unless there's a rule in the Russian language that specifically > dictates it. In Russian there is different from English punctuation. We create a tool for humans, not machines, don't we? So, we must improve a punctuation according to a language's rules. Instead, I send my improves to Nikolay, as you recommended. > A normal, UTF-8 formatted textfile as an attachment ... should suffice, > you shouldn't need to pack it. > I guess an archive could also confuse the automated scripts I packed it to decrease a size. But if it isn't good for merging, I willn't do it. > Please understand this as constructive criticism, it will help getting > your patch accepted and not cause extra work for the maintainer > (Alexandre). It looks like you invested a lot of effort, thanks for > that. No, that's OK. There isn't something bad in constructive criticism, I think. --- Best regards, Oleg. P. S. I didn't know how to post messages into pipemail, so I replied privetly. There is a copy of my answer.

1 0

Re: [05/11] windowscodecs: Add support for more types of IFD fields. Resend.
by Alexandre Julliard June 15, 2012

June 15, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -650,30 +672,43 @@ static HRESULT load_IFD_entry(IStream *input, const struct IFD_entry *entry, > SWAP_ULONG(count); > type = entry->type; > SWAP_USHORT(type); > + item->value.vt = tag_to_vt(type); > value = entry->value; > SWAP_ULONG(value); > > switch (type) > { > + case IFD_BYTE: > + case IFD_SBYTE: > + if (count == 1) > + { > + item->value.u.bVal = *(BYTE *)&value; > + break; > + } > + FIXME("loading multiple byte fields is not implemented\n"); > + break; This seems to contradict the endianness support. Are you really supposed to byte-swap arrays of bytes? -- Alexandre Julliard julliard(a)winehq.org

2 1

RFC: comdlg32: Fix null lpstrFile uses in FILEDLG95_OnOpen
by Bruno Jesus June 15, 2012

June 15, 2012

Hi, I have written a patch to fix bug 17229 and would like to request help to complete the test part. The test creates a common dialog and select a filename (file does not need to exist), it was copied from other tests in the same file (comdlg32/tests/filedlg.c). It's not possible to have a default file name because lpstrFile is used to do this and it's NULL. To fill a filename in the common dialog control that appears I have used EnumChildWindows to find the textbox and set the filename in it. The main problem is how to detect that a HWND is a textbox? Currently I'm sending SetWindowText to every control and that does work but I think the patch may be rejected by that. The patch can be downloaded at: https://testbot.winehq.org/JobDetails.pl?Key=19074 The problem is in the line 56. Thanks in advance, Bruno

1 0

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).
by Alexandre Julliard June 14, 2012

June 14, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. As of version > 3 of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and it also includes some additional cleanup. It > is important to note that HTML Help only supports characters within > the ANSI code pages, so support for multi-byte characters is not > necessary. I don't see why you'd want to use ANSI code pages for this, since they will be converted to Unicode anyway. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: msvcrt/tests: Fix portuguese locale test on NT4
by Marvin June 14, 2012

June 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19045 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: msvcrt: Fix the name of the Portuguese locale alias.
by Bruno Jesus June 14, 2012

June 14, 2012

On Wed, Jun 13, 2012 at 2:47 PM, Francois Gouget <fgouget(a)free.fr> wrote: > ... > dlls/msvcrt/locale.c | 2 +- > dlls/msvcrt/tests/locale.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > ... > - "portugese", "ptb", > + "portuguese", "ptb", Just a side note. Although I'm not sure I think portuguese is "ptg", brazilian portuguese is "ptb". So the correct may be: > + "portuguese", "ptg", A Portugal user would be able to check that, or maybe it's easier to write a testcase. If I'm wrong I ask apologies in advance, Bruno

3 2

DllMain() seems unused in ntoskrnl.exe
by Francois Gouget June 14, 2012

June 14, 2012

The DllMain() function in ntoskrnl.exe appears to be unused: making it static causes a compiler warning to that effect and removing it entirely does not cause a compilation failure. Should it be removed or is there a build issue with ntoskrnl.exe? diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index 2b84297..ffeb2f8 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -1711,30 +1711,6 @@ VOID WINAPI IoInitializeRemoveLockEx(PIO_REMOVE_LOCK lock, ULONG tag, } /***************************************************** - * DllMain - */ -BOOL WINAPI DllMain( HINSTANCE inst, DWORD reason, LPVOID reserved ) -{ - static void *handler; - LARGE_INTEGER count; - - switch(reason) - { - case DLL_PROCESS_ATTACH: - DisableThreadLibraryCalls( inst ); -#ifdef __i386__ - handler = RtlAddVectoredExceptionHandler( TRUE, vectored_handler ); -#endif - KeQueryTickCount( &count ); /* initialize the global KeTickCount */ - break; - case DLL_PROCESS_DETACH: - RtlRemoveVectoredExceptionHandler( handler ); - break; - } - return TRUE; -} - -/***************************************************** * Ke386IoSetAccessProcess (NTOSKRNL.EXE.@) */ BOOLEAN WINAPI Ke386IoSetAccessProcess(PEPROCESS *process, ULONG flag) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Be careful of reading health books, you might die of a misprint. -- Mark Twain

2 1

Re: [11/11] windowscodecs: Implement GetMetadataFormat. Resend.
by Dmitry Timoshkov June 14, 2012

June 14, 2012

Please ignore this patch, it doesn't really belong to this series, and correct implementation should use MetadataReaderInfo interface instead. -- Dmitry.

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19010 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19009 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19007 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] windowscodecs: Add stub IWICMetadataBlockReader to PNG decoder.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19006 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.
by Nikolay Sivov June 13, 2012

June 13, 2012

On 6/12/2012 11:52, Ulrik Dickow wrote: > Patch 1 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . > > > > +static void test_namespaces_change(int doc_version) > +{ > + IXMLDOMDocument *doc; > + IXMLDOMElement *elem; > + IXMLDOMNode *node; > + > + VARIANT var; > + HRESULT hr; > + BSTR str; > + > + /* create on element and try to alter namespace after that */ > + doc = (doc_version == 0 ? > + create_document(&IID_IXMLDOMDocument) : > + create_document_version(60, &IID_IXMLDOMDocument)); > + if (!doc) return; Please use something like CLSID array with every available Document CLSID, instead of only testing 2 of them. There's a lot of examples for that in saxreader.c. > + test_namespaces_change(0); > + test_namespaces_change(60); > > free_bstrs(); > } It's better to avoid nested test calls like that imho, you could just add another call in main test list. > +static void test_namespaces_change(int doc_version) > +{ > + IXMLDOMDocument *doc; > + IXMLDOMElement *elem; > + IXMLDOMNode *node; ... > + > + IXMLDOMElement_Release(elem); > + IXMLDOMDocument_Release(doc); > +} > + When this is running on all CLSIDs please add free_bstrs() here.

3 4

Re: d3dx9_36: D3DXQuaternionLn computes as if the norm of the input is 1
by Matteo Bruni June 13, 2012

June 13, 2012

2012/6/12 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > > + if ( (pq->w >= 1.0f) || (pq->w == -1.0f) ) I think the second comparison should be '<=', if you want to avoid getting NaNs.

2 2

Re: wined3d: Avoid sizeof on structs with variable length arrays.
by Henri Verbeet June 13, 2012

June 13, 2012

On 13 June 2012 10:41, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, FIELD_OFFSET(struct wined3d, adapters[1])); That's not really a VLA, just a somewhat stupid array of size 1.

2 2

Misspelt Portuguese in msvcrt
by Francois Gouget June 13, 2012

June 13, 2012

Is there a reason why Portuguese is misspelt in these two places? diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index 97b82ec..b26a9c8 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -85,7 +85,7 @@ static const char * const _country_synonyms[] = "german-swiss", "des", "italian-swiss", "its", "german-austrian", "dea", - "portugese", "ptb", + "portuguese", "ptb", "portuguese-brazil", "ptb", "spanish-mexican", "esm", "norwegian-bokmal", "nor", diff --git a/dlls/msvcrt/tests/locale.c b/dlls/msvcrt/tests/locale.c index 8d6a34f..638a3d2 100644 --- a/dlls/msvcrt/tests/locale.c +++ b/dlls/msvcrt/tests/locale.c @@ -472,7 +472,7 @@ static void test_setlocale(void) if(ret) ok(!strcmp(ret, "Polish_Poland.1250"), "ret = %s\n", ret); - ret = setlocale(LC_ALL, "portugese"); + ret = setlocale(LC_ALL, "portuguese"); ok(ret != NULL || broken (ret == NULL), "ret == NULL\n"); if(ret) ok(!strcmp(ret, "Portuguese_Brazil.1252"), "ret = %s\n", ret); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ E-Voting: Those who cast the votes decide nothing. Those who count the votes decide everything.

2 1

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 3).
by Jacek Caban June 13, 2012

June 13, 2012

Hi Erich, On 06/12/12 19:03, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and some additional cleanup. It is important to > note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. Many > apologizes to Jacek Caban for missing some of his comments in his > original reply. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. The patch looks much better. There is one remaining problem: + int pos = sizeof(html_encoded_symbols)/sizeof(html_encoded_symbols[0]); + float step = pos/2; + int dir = +1; + + do + { + const char *encoded_symbol; + + pos += -dir*ceil(step); Using float here is definitely not needed, esp. that you always use ceil() on it. You've made it more complicated than it really is. See [1] for an example. Also feel free to send linear search with FIXME comment. That's fine for the first iteration patch. Jacek [1] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/mshtml/dispex.c#l709

1 0

Re: [11/11] windowscodecs: Implement GetMetadataFormat.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18989 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd

1 0

Re: [10/11] windowscodecs: Handle IFD fields with count 0 same way as with count 1.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18988 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd

1 0

Re: [09/11] windowscodecs: Add support for IFD_UNDEFINED field type.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18987 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd

1 0

Re: [08/11] windowscodecs: Add tests for more types of IFD fields.
by Marvin June 13, 2012

June 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18986 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd

1 0

Re: po: Update Russian translation (try 3) (resend)
by Francois Gouget June 13, 2012

June 13, 2012

msgid "KeyID=" -msgstr "Код ключа=" +msgstr "Код ключа: " [...] msgid "Other Name=" -msgstr "Другое имя=" +msgstr "Альтернативное имя: " and many more like this. Why did you not fix this? Replacing the equal sign with a colon looks wrong to me but then I don't speak Russian. Still I have not seen anything to suggest that the typographic rules would be different in this regard. But Nikolay Sivov, who speaks Russian, seems to concur. Note that this was reported to you back in May: http://www.winehq.org/pipermail/wine-devel/2012-May/095672.html -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

1 0

Re: [PATCH 4/5] wined3d: Set undefined vertex attributes to 0.0.
by Stefan Dösinger June 12, 2012

June 12, 2012

Am Dienstag, 12. Juni 2012, 17:03:49 schrieb Henri Verbeet: > + if (state->vertex_shader->reg_maps.input_registers & (1 << i)) > + GL_EXTCALL(glVertexAttrib4fARB(i, 0.0f, 0.0f, 0.0f, 0.0f)); Does an application need this? Afair Windows drivers have implementation- specific behavior here that pretty much matches their GL counterparts.

1 0

re: Command line parameters
by Dan Kegel June 12, 2012

June 12, 2012

John asked > [ How do I launch Windows apps from Unix apps and pass filenames to them?] > execl (the_path_to_wine, "wine", path_to_the_windows_program, command_line_parameter_for_windows_app, NULL); Relative unix paths will often work with Windows apps, but in general, you will have to translate command_line_parameter_for_windows_app, and any paths that appear in data files, from Unix to Windows before launching the app. The winepath utility may help there, or you can translate them yourself once you know how Wine maps filenames. Also, I recall being in a situation where I had to put the commandline in a batch file and do wine cmd.exe /c foo.bat because there wasn't another other way to make the windows app happy... something about the commandline that made me need to use CreateProcess, and cmd.exe was the easiest way to use CreateProcess. - Dan

5 10

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 2).
by Jacek Caban June 12, 2012

June 12, 2012

Hi Erich, On 06/11/12 21:01, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control. It is important > to note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. You didn't address most of my comments. Feel free to ask for clarifications if something was not clear enough. Jacek

2 1