June 2012 - Wine-Devel - list.winehq.org

Re: Fix the FIXME message to reflect the real problem.
by Piotr Caban June 4, 2012

June 4, 2012

On 06/02/12 13:35, max(a)mtew.isa-geek.net wrote: > @@ -2735,7 +2735,7 @@ static BOOL CommitUrlCacheEntryInternal( > goto cleanup; > } > > - FIXME("entry already in cache - don't know what to do!\n"); > + FIXME("collision handler needed - the entry is already in use!\n"); This message is not about entry being used. I think the old message is quite accurate. The "don't know what to do" part is quite strange but I don't see reason to change it.

2 1

Re: comctl: allow label edit only if treeview style allows editing
by Alexandre Julliard June 4, 2012

June 4, 2012

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 21d26b76560f0c15a3d302883efa2d41d940a093 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Sat, 2 Jun 2012 07:23:32 +0200 > Subject: comctl: allow label edit only if treeview style allows editing > > Native comctl behaves this way - noticed when debugging regedit It breaks the tests: ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so brsfolder.c && touch brsfolder.ok brsfolder.c:225: Test failed: The new folder did not get the name foo brsfolder.c:232: Test failed: SHBrowseForFolder did not return the pidl for the new folder. Expected 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\foo' got 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\New Folder' make: *** [brsfolder.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [scrrun] Add initial support for Dictionary patch - 1/3
by Alistair Leslie-Hughes June 4, 2012

June 4, 2012

Hi Vijay, On 4/06/2012 8:06 PM, Vijay Kiran Kamuju wrote: > Sending patch series for initial support for Scripting.Dictionary in scrrun.dll > > +static HRESULT WINAPI dictionary_put_Item(IDictionary *iface, VARIANT *key, VARIANT *item) > +{ > + FIXME("%p %p\n", iface, key); Please include all parameters in FIXME, they all seem to be missing the last one. Best Regards Alistair Leslie-Hughes

1 0

Re: [scrrun] Add initial support for Dictionary patch - 1/3
by Jacek Caban June 4, 2012

June 4, 2012

Hi Vijay On 06/04/12 12:06, Vijay Kiran Kamuju wrote: > Sending patch series for initial support for Scripting.Dictionary in scrrun.dll > > The first patch will add dictionary.c > The second will add the necessary changes to Makefile and the scrrun.c > (mistake done will doing git commit - hence two patches) This split doesn't make sense. Please merge those patches. +static ULONG WINAPI dictionary_AddRef(IDictionary *iface) +{ + TRACE("%p\n", iface); + + return 2; +} + +static ULONG WINAPI dictionary_Release(IDictionary *iface) +{ + TRACE("%p\n", iface); + + return 1; +} Dictionary object should be heap-based. That requires proper reference counting and object structure. Cheers, Jacek

1 0

Re: [scrrun] - Add initial support for Dictionary - tests - patch 3/3
by Marvin June 4, 2012

June 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18733 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: oleaut32: Add a test for BSTR cache.
by Marvin June 4, 2012

June 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18731 Your paranoid android. === W2KPROSP4 (32 bit vartype) === vartype.c:6166: Test failed: good_length_entries 98 out of 256 === WXPPROSP3 (32 bit vartype) === vartype.c:6166: Test failed: good_length_entries 99 out of 256

1 0

Re: [3/3] iphlpapi: Check for the right TCP statistics structure name (for DragonFly BSD)
by Juan Lang June 3, 2012

June 3, 2012

Hi André, +#if HAVE_STRUCT_TCPSTAT_TCPS_CONNATTEMPT + struct tcpstat tcp_stat; +#elif HAVE_STRUCT_TCP_STATS_TCPS_CONNATTEMPT + struct tcp_stats tcp_stat; +#endif struct tcpstat tcp_stat; I think you meant to remove the declaration outside of the #if. --Juan

2 1

Re: [1/4] user32/tests: remove WM_DESTROY processing in test (it is of no use and causes tests skipping) (try 2)
by Marvin June 3, 2012

June 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18723 Your paranoid android. === W7PROX64 (32 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === TEST64_W7SP1 (32 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === W7PROX64 (64 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === TEST64_W7SP1 (64 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible.

1 0

Mono?!?
by Max TenEyck Woodbury June 3, 2012

June 3, 2012

When did WINE start requiring MONO? I have a VERY strong DISLIKE for MONO and do NOT want it on my machines. Seems to be a recent addition. Is it possible to NOT use it? PLEASE!

6 15

Re: shell32: fix compilation error with strcpy_chk: buffer overflow detected
by Nikolay Sivov June 2, 2012

June 2, 2012

A static string constant would be better here. On Sat, Jun 2, 2012 at 12:42 PM, Vitaly Lipatov <lav(a)etersoft.ru> wrote: > --- > dlls/shell32/pidl.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dlls/shell32/pidl.c b/dlls/shell32/pidl.c > index c394e5b..5906a4f 100644 > --- a/dlls/shell32/pidl.c > +++ b/dlls/shell32/pidl.c > @@ -1752,16 +1752,17 @@ LPITEMIDLIST _ILCreateDrive(LPCWSTR lpszNew) > LPITEMIDLIST _ILCreateEntireNetwork(void) > { > LPITEMIDLIST pidlOut; > + DWORD alen = sizeof("Entire Network"); > > TRACE("\n"); > > - pidlOut = _ILAlloc(PT_NETWORK, FIELD_OFFSET(PIDLDATA, > u.network.szNames[sizeof("Entire Network")])); > + pidlOut = _ILAlloc(PT_NETWORK, FIELD_OFFSET(PIDLDATA, > u.network.szNames[alen])); > if (pidlOut) > { > LPPIDLDATA pData = _ILGetDataPointer(pidlOut); > > pData->u.network.dummy = 0; > - strcpy(pData->u.network.szNames, "Entire Network"); > + memcpy(pData->u.network.szNames, "Entire Network", alen + 1); > } > return pidlOut; > } > -- > 1.7.9.7 > > -- > С уважением, > Виталий Липатов, > Etersoft > >

1 0