June 2012 - Wine-Devel - list.winehq.org

Re: wintrust/tests: Fix build with MSVC.
by Dmitry Timoshkov June 22, 2012

June 22, 2012

Thomas Faber <thfabba(a)gmx.de> wrote: > FIELD_OFFSET isn't constant "enough". The problem is not with FIELD_OFFSET, but with applying shift and mask operations to a constant. -- Dmitry.

3 3

Re: d3dx9_36 [patch 1 of 4, try 2]: Implemetation of D3DXSHDot
by Dmitry Timoshkov June 22, 2012

June 22, 2012

Hello, Please follow http://wiki.winehq.org/SubmittingPatches instructions for naming patches when sending a patch series. Usually 'git format-patch -n' will do it for you. Otherwise testbot won't recognize the series. -- Dmitry.

1 0

Re: d3dx9_36 [patch 3 of 4, try 2]: Implemetation of D3DXSHMultiply2
by Marvin June 22, 2012

June 22, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19429 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: d3dx9_36 [patch 1 of 4, try 2]: Implemetation of D3DXSHScale
by Marvin June 22, 2012

June 22, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19428 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

re: [PATCH 2/5] ddraw: Use wined3d_get_adapter_display_mode() in CreateSurface().
by Dan Kegel June 21, 2012

June 21, 2012

Henri wrote: - hr = wined3d_device_get_display_mode(ddraw->wined3d_device, 0, &mode); - if (FAILED(hr)) + if (FAILED(hr = wined3d_get_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &mode))) Seems like a step back in readability to combine setting and testing hr. - Dan

1 0

Examples of AJ silently improving patches?
by Dan Kegel June 21, 2012

June 21, 2012

AJ sometimes kindly fixes problems in patches while committing them (I guess it's easier than rejecting the patch for small issues). I wonder if these silent improvements would be worth collecting as a sort of style-guide-by-example. Anyone remember any good examples? I've started a list at http://wiki.winehq.org/StyleExamples

4 3

Re: [PATCH 1/7] ntdll: Add support for junction point creation.
by Hans Leidekker June 21, 2012

June 21, 2012

On Wed, 2012-06-20 at 17:26 -0600, Erich E. Hoover wrote: > + TRACE("Linking %s to %s\n", unix_src.Buffer, unix_dest.Buffer); > + if (rmdir( unix_src.Buffer ) < 0) > + { > + status = FILE_GetNtStatus(); > + goto cleanup; > + } > + if (symlink( unix_dest.Buffer, unix_src.Buffer ) < 0) > + { > + status = FILE_GetNtStatus(); > + goto cleanup; > + } > + status = STATUS_SUCCESS; This is not an atomic operation since you need two Unix calls. So you would need locking or rollback to deal with possible races. Should permissions and ownership be preserved on the directory when a junction is removed?

2 2

[1/5] windowscodecs: Implement PixelFormatInfo_GetBitsPerPixel.
by Vincent Povirk June 21, 2012

June 21, 2012

1 0

Re: kernel32: Add a test for deleting an opened for reading file. Take 2.
by Eric Pouech June 21, 2012

June 21, 2012

one tricky question... could it be that on windows this test behaves differently on ntfs vs FAT filesystem ? or what would give re-opening the file after the deletefile call ? A+ 2012/6/21, Dmitry Timoshkov <dmitry(a)baikal.ru>: > Previous version had a typo in file name. > --- > dlls/kernel32/tests/file.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c > index 8768b99..0a662d9 100644 > --- a/dlls/kernel32/tests/file.c > +++ b/dlls/kernel32/tests/file.c > @@ -3236,6 +3236,31 @@ static void test_CreatFile(void) > > DeleteFile(file_name); > } > +static void test_delete_file(void) > +{ > + char temp_path[MAX_PATH], temp_file[MAX_PATH]; > + HANDLE hfile; > + int ret; > + > + GetTempPathA(MAX_PATH, temp_path); > + GetTempFileName(temp_path, "tst", 0, temp_file); > + > + SetLastError(0xdeadbeef); > + hfile = CreateFile(temp_file, GENERIC_READ, FILE_SHARE_DELETE | > FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); > + ok(hfile != INVALID_HANDLE_VALUE, "CreateFile error %d\n", > GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = DeleteFile(temp_file); > +todo_wine > + ok(ret, "DeleteFile error %d\n", GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = CloseHandle(hfile); > + ok(ret, "CloseHandle error %d\n", GetLastError()); > + ret = DeleteFile(temp_file); > +todo_wine > + ok(!ret, "DeleteFile should fail\n"); > +} > > START_TEST(file) > { > @@ -3257,6 +3282,7 @@ START_TEST(file) > test_CreateFileW(); > test_DeleteFileA(); > test_DeleteFileW(); > + test_delete_file(); > test_MoveFileA(); > test_MoveFileW(); > test_FindFirstFileA(); > -- > 1.7.11 > > > > -- -- Eric Pouech

1 0

Re: wintrust/tests: Fix build with MSVC.
by Dmitry Timoshkov June 21, 2012

June 21, 2012

Thomas Faber <thfabba(a)gmx.de> wrote: > Empty braces are no valid initializer. > FIELD_OFFSET isn't constant "enough". > + /* add 'jmp ExitProcess' instruction */ > + count = 2; > + bin.text_section[count++] = 0xFF; > + bin.text_section[count++] = 0x25; > + bin.text_section[count++] = EXIT_PROCESS&0xFF; > + bin.text_section[count++] = (EXIT_PROCESS>>8)&0xFF; > + bin.text_section[count++] = (EXIT_PROCESS>>16)&0xFF; > + bin.text_section[count++] = (EXIT_PROCESS>>24)&0xFF; This part of the patch obviously is not related to the patch description. -- Dmitry.

1 0