July 2012 - Wine-Devel - list.winehq.org

Re: oleaut32: Add support for boolean strings in VarNot.
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=87 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: windowscodecs: Implement MetadataHandler_GetValue.
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=86 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH] opengl32: Disable wglGetProcAddress for core GL 1.0/1.1 functions
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=85 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: kernel32: Change LCMapStringW to LCMapStringEx and call it from LCMapStringW (try 2)
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=84 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] jscript: Added more apply and call tests
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=83 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [4/5] gdiplus: Add some tests for image properties.
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=82 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [4/5] gdiplus: Add some tests for image properties.
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=81 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [4/5] gdiplus: Add some tests for image properties.
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=80 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [2/2] wbemprox: Parse the resource string in IWbemLocator::ConnectServer.
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=79 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [4/5] gdiplus: Add some tests for image properties.
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=78 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [4/5] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem. Take 2.
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=77 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: msxml3: Basic refcount test for IMXNamespacePrefixes
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=76 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [5/5] msxml3: Implement internalEntityDecl() for writer
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=75 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [4/5] msxml3: Initial implementation of attributeDecl() in writer
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=74 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [3/5] msxml3: Fix closing of open element
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=73 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [2/5] msxml3: Properly handle -1 as length of element qualified name in startElement()
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=72 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [1/5] msxml3: Return stream reference from get_output() if stream is set
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=71 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] opengl32: Check for valid context in wglGetProcAddress
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=70 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: gdiplus: Store device resolution in the graphics object.
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=56 Your paranoid android. === windowsxp (32 bit image) === image.c:2736: Test failed: GdipLoadImageFromStream error 2 image.c:2739: Test failed: GdipGetImageType error 2 image.c:2749: Test failed: GdipCloneImage error 2 image: unhandled exception c0000005 at 4EBB42CD

3 3

Re: windowscodecs: Do not assume that vtable is the first element of the object, avoid not necessary casts. Resend.
by Vincent Povirk July 25, 2012

July 25, 2012

> The patch is marked as 'build failure', but it builds just fine here. > What kind of build failure is that? Did you try building it on a Mac?

3 2

Re: kernel32/tests: Explicitly cast to signed char
by Dmitry Timoshkov July 25, 2012

July 25, 2012

André Hentschel <nerv(a)dawncrow.de> wrote: > - ok(mbc == -28, "mbc is %d\n", mbc); > + ok((signed char)mbc == -28, "mbc is %d\n", mbc); > if(bUsedDefaultChar) ok(*bUsedDefaultChar == FALSE, "bUsedDefaultChar is %d\n", *bUsedDefaultChar); > ok(GetLastError() == 0xdeadbeef, "GetLastError() is %u\n", GetLastError()); > > @@ -301,7 +301,7 @@ static void test_string_conversion(LPBOOL bUsedDefaultChar) > SetLastError(0xdeadbeef); > ret = WideCharToMultiByte(1251, 0, &wc2, 1, &mbc, 1, NULL, bUsedDefaultChar); > ok(ret == 1, "ret is %d\n", ret); > - ok(mbc == -16, "mbc is %d\n", mbc); > + ok((signed char)mbc == -16, "mbc is %d\n", mbc); In these cases comparison with hex would work better IMO, and printing the result of conversion in hex would be more readable as well. -- Dmitry.

1 0

Re: [PATCH 5/5] d3d10: Implement d3d10_effect_sampler_variable_GetBackingStore().
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=67 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3d10: Implement d3d10_effect_blend_variable_GetBackingStore().
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=66 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH 6/6] jscript: Use prototype for buitin String properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=64 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH 5/6] jscript: Use prototype for buitin RegExp properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=63 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH 4/6] jscript: Use prototype for buitin Number properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=62 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH 3/6] jscript: Use prototype for buitin Date properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=61 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH 2/6] jscript: Use prototype for buitin Boolean properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=60 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH 1/6] jscript: Use prototype for buitin Array properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=59 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [2/2] kernel32: Implement InitOnceExecuteOnce() for Linux platform (resend)
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=58 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [1/2] kernel32: Some tests for blocking initialization with InitOnceBeginInitialize() (try2)
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=57 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [2/2] kernel32: Implement InitOnceExecuteOnce() for Linux platform
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=55 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [1/2] kernel32: Some tests for blocking initialization with InitOnceBeginInitialize()
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=54 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

What's the right way to implement _wtoi_l?
by Alex Henrie July 24, 2012

July 24, 2012

Dear Wine developers, Bug 24389 documents an application crash due to the unimplemented function msvcr90._wtoi_l. I have been looking into how to resolve this problem. I see three workable options: 1. Implement msvcr90._wtoi_l by copying the code from ntdll._wtoi to msvcrt, ignoring the locale parameter for now. 2. Forward msvcr90._wtoi_l to ntdll._wtoi via msvcr90.spec, ignoring the locale parameter for now. 3. Implement msvcr90._wtoi_l as a stub function in msvcrt that always returns 0. Any of these options would fix bug 24389. Which one should I work on? -Alex

3 3

Re: msvcp90: Explicitly cast to signed char
by André Hentschel July 24, 2012

July 24, 2012

Am 24.07.2012 21:30, schrieb André Hentschel: > --- > dlls/msvcp90/ios.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) This has been obsoleted due to Piotrs changes, thx. -- Best Regards, André Hentschel

1 0

Re: [4/5] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem. Take 2.
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=44 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [1/5] windowscodecs: Implement MetadataHandler_GetValue. Take 2.
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=43 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0

Re: [PATCH 2/3] mshtml: Added IHTMLDOMAttribute::get_specified implementation
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=41 Your paranoid android. === windowsxp (32 bit dom) === Can't copy TestLauncher to VM: :7094

1 0

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.
by Vincent Povirk July 24, 2012

July 24, 2012

I disagree with many of the choices in this series (for example, I think casting an interface pointer to an inherited interface is fine, and replacing that with QueryInterface just adds unnecessary additional logic), but I don't think any semantics have been changed and overall it's a good cleanup.

3 4

Re: gdiplus: Store device resolution in the graphics object.
by Vincent Povirk July 24, 2012

July 24, 2012

Looks good, thanks.

1 0

Re: windowscodecs: Implement MetadataHandler_Load.
by Vincent Povirk July 24, 2012

July 24, 2012

Looks good, thanks.

1 0

Re: [PATCH 6/6] jscript: Use prototype for buitin String properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20282 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/6] jscript: Use prototype for buitin RegExp properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20281 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/6] jscript: Use prototype for buitin Number properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20280 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [2/2] kernel32: Implement InitOnceExecuteOnce() for Linux platform (resend)
by Alexandre Julliard July 24, 2012

July 24, 2012

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > +DWORD NTAPI RtlRunOnceExecuteOnce(PRTL_RUN_ONCE initonce, PRTL_RUN_ONCE_INIT_FN callback, void *parameter, void **ctxt) > +{ > +#ifdef __linux__ > + if (!use_futexes()) return FALSE; > + > + for (;;) > + { > + DWORD_PTR val = (DWORD_PTR)interlocked_cmpxchg_ptr( &initonce->Ptr, (void*)1, NULL ); > + switch (val & 0x3) > + { > + case 0: > + { > + DWORD ret = callback(initonce, parameter, ctxt); > + if (ret) > + { > + DWORD_PTR context = ctxt ? (DWORD_PTR)*ctxt : 0; > + context = (context & ~0x3) | 0x2; > + interlocked_cmpxchg_ptr( &initonce->Ptr, (void*)context, (void*)1 ); > + } > + else > + interlocked_cmpxchg_ptr( &initonce->Ptr, NULL, (void*)1 ); > + futex_wake( (int *)&initonce->Ptr, 1 ); > + return ret; > + } > + case 1: > + /* blocked by another thread */ > + futex_wait( (int *)&initonce->Ptr, 1, NULL ); > + break; > + case 2: > + /* already initialized */ > + return TRUE; > + } > + } It's supposed to return an NTSTATUS, not a boolean. Also you have to always return the context, and you should try to do a generic implementation first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/6] jscript: Use prototype for buitin Date properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20279 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/3] apphelp/tests: Add tests for ApphelpCheckShellObject
by Alexandre Julliard July 24, 2012

July 24, 2012

Detlef Riekenberg <wine.dev(a)web.de> writes: > + flags = 0xdeadbeeffeedfaceULL; Don't use long long constants. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/6] jscript: Use prototype for buitin Boolean properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20278 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] jscript: Use prototype for buitin Array properties
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20277 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.
by Michael Stefaniuc July 24, 2012

July 24, 2012

Hello Dmitry, On 07/24/2012 08:01 AM, Dmitry Timoshkov wrote: > The patches in this series do not depend on each other, numeration is just > for a convenience. Patches do basically the same job for different objects, > so I decided to not invent a new subject for every separate kind of object. > --- > dlls/windowscodecs/bmpdecode.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/dlls/windowscodecs/bmpdecode.c b/dlls/windowscodecs/bmpdecode.c > index 6da6a3c..1a1ee0a 100644 > --- a/dlls/windowscodecs/bmpdecode.c > +++ b/dlls/windowscodecs/bmpdecode.c > @@ -94,6 +94,8 @@ static inline BmpDecoder *impl_from_IWICBitmapFrameDecode(IWICBitmapFrameDecode > static HRESULT WINAPI BmpFrameDecode_QueryInterface(IWICBitmapFrameDecode *iface, REFIID iid, > void **ppv) > { > + BmpDecoder *This = impl_from_IWICBitmapFrameDecode(iface); > + > TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); > > if (!ppv) return E_INVALIDARG; > @@ -102,7 +104,7 @@ static HRESULT WINAPI BmpFrameDecode_QueryInterface(IWICBitmapFrameDecode *iface > IsEqualIID(&IID_IWICBitmapSource, iid) || > IsEqualIID(&IID_IWICBitmapFrameDecode, iid)) > { > - *ppv = iface; > + *ppv = &This->IWICBitmapFrameDecode_iface; > } > else > { this part of the change is gratuitous. As long as there is only one interface implementation in the object there is no need for impl_from_Foo(). bye michael

2 1