July 2012 - Wine-Devel - list.winehq.org

Re: [12/18] windowscodecs: Do not assume that vtable is the first element of the object, avoid not necessary casts.
by Michael Stefaniuc July 24, 2012

July 24, 2012

Hello Dmitry, On 07/24/2012 08:12 AM, Dmitry Timoshkov wrote: > --- > dlls/windowscodecs/jpegformat.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c > index 53d7ec4..2c77d4f 100644 > --- a/dlls/windowscodecs/jpegformat.c > +++ b/dlls/windowscodecs/jpegformat.c > @@ -469,6 +470,8 @@ static const IWICBitmapDecoderVtbl JpegDecoder_Vtbl = { > static HRESULT WINAPI JpegDecoder_Frame_QueryInterface(IWICBitmapFrameDecode *iface, REFIID iid, > void **ppv) > { > + JpegDecoder *This = impl_from_IWICBitmapFrameDecode(iface); > + > TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); > > if (!ppv) return E_INVALIDARG; > @@ -477,7 +480,7 @@ static HRESULT WINAPI JpegDecoder_Frame_QueryInterface(IWICBitmapFrameDecode *if > IsEqualIID(&IID_IWICBitmapSource, iid) || > IsEqualIID(&IID_IWICBitmapFrameDecode, iid)) > { > - *ppv = iface; > + *ppv = &This->IWICBitmapFrameDecode_iface; > } > else > { same here: not needed. bye michael

1 0

Re: [2/2] kernel32: Implement InitOnceExecuteOnce() for Linux platform
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20269 Your paranoid android. === WVISTAADM (32 bit sync) === sync.c:1231: Test failed: got 0 === W7PRO (32 bit sync) === sync.c:1231: Test failed: got 0 === W7PROX64 (32 bit sync) === sync.c:1231: Test failed: got 0 === TEST64_W7SP1 (32 bit sync) === sync.c:1231: Test failed: got 0 === W7PROX64 (64 bit sync) === sync.c:1231: Test failed: got 0 === TEST64_W7SP1 (64 bit sync) === sync.c:1231: Test failed: got 0

1 0

Re: [1/2] kernel32: Some tests for blocking initialization with InitOnceBeginInitialize()
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20268 Your paranoid android. === WVISTAADM (32 bit sync) === sync.c:1225: Test failed: got 0 === W7PRO (32 bit sync) === sync.c:1225: Test failed: got 0 === W7PROX64 (32 bit sync) === sync.c:1225: Test failed: got 0 === TEST64_W7SP1 (32 bit sync) === sync.c:1225: Test failed: got 0 === W7PROX64 (64 bit sync) === sync.c:1225: Test failed: got 0 === TEST64_W7SP1 (64 bit sync) === sync.c:1225: Test failed: got 0

1 0

re: Have there been any problems with Wine on GCC 4.7?
by Dan Kegel July 24, 2012

July 24, 2012

Groveling around, I found a few possibilities: backtraces broken on gcc 4.7 http://bugs.winehq.org/show_bug.cgi?id=26791 ICE when compiling: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641056 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640864 https://bugs.launchpad.net/ubuntu/+source/gcc-4.6/+bug/842012 needs-new-prelink-to-avoid-crash-with -g option: http://bugs.winehq.org/show_bug.cgi?id=30862 steam overlays: http://bugs.winehq.org/show_bug.cgi?id=22053 enabling -fomit-frame-pointer by default breaks Wine: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46468 gcc shouldn't assume that the stack is aligned: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40838 wine's conformance test kernel32/thread.ok always fails/crashes on ubuntu 11.10: https://bugs.launchpad.net/ubuntu/+source/wine1.3/+bug/872063 http://wiki.winehq.org/GccVersions might be a place to record this kind of stuff, but it's outdated. There are some known fixes, possibly related to the above problems, e.g. http://bugs.winehq.org/show_bug.cgi?id=27692 http://bugs.winehq.org/show_bug.cgi?id=28753 http://bugs.winehq.org/show_bug.cgi?id=23137 And then there's debian's "wine uses an old gcc" bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=654742

1 0

Re: kernel32: Reimplement GetLogicalDrives using the mountmgr
by Alexandre Julliard July 23, 2012

July 23, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > Previous approach was patch #88280 > --- > dlls/kernel32/volume.c | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) > > diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c > index 8377e41..57453bb 100644 > --- a/dlls/kernel32/volume.c > +++ b/dlls/kernel32/volume.c > @@ -1435,27 +1435,15 @@ DWORD WINAPI QueryDosDeviceA( LPCSTR devname, LPSTR target, DWORD bufsize ) > */ > DWORD WINAPI GetLogicalDrives(void) > { > - const char *config_dir = wine_get_config_dir(); > - struct stat st; > - char *buffer, *dev; > DWORD ret = 0; > + WCHAR drive; > int i; > > - if (!(buffer = HeapAlloc( GetProcessHeap(), 0, strlen(config_dir) + sizeof("/dosdevices/a:") ))) > - { > - SetLastError( ERROR_NOT_ENOUGH_MEMORY ); > - return 0; > - } > - strcpy( buffer, config_dir ); > - strcat( buffer, "/dosdevices/a:" ); > - dev = buffer + strlen(buffer) - 2; > - > for (i = 0; i < 26; i++) > { > - *dev = 'a' + i; > - if (!stat( buffer, &st )) ret |= (1 << i); > + drive = 'A'+i; > + if (get_mountmgr_drive_type(&drive) != DRIVE_UNKNOWN) ret |= (1 << i); > } That's very inefficient. There are better way of enumerating drives, check for instance QueryDosDevice. -- Alexandre Julliard julliard(a)winehq.org

2 4

Query MediaType of SD-Cards using IOCTL_GET_DISK_DRIVE_GEOMETRY
by Eduard Hasenleithner July 23, 2012

July 23, 2012

Hi I'm trying to use the TANITA Bodyvision software (http://www.tanita.co.uk/index.php?id=158) under wine. The software is supposed to read its data from an SD-Card. But under wine it cannot find the SD card. I managed to find out what it takes so that the software finds the SD card. Please see the attached small sample to see how the software iterates the drive letters, and how it determines a eligibile media using (data.MediaType == RemovableMedia). The reasons why this does not work are manyfold. Here are some events which happen when inserting the card. * The drive is reported using udisks. This creates a symlink in dosdevices to the raw block device /dev/sdf * The partition /dev/sdf1 is mounted automatically in /media/XXXX-YYYY * /dev/sdf and /dev/sdf1 are not user read/writable. * wine creates a drive letter symlink for /dev/sdf * no symlink is created for /media/XXXX-YYYY * When you open wine explorer, the drive does not show up in the drive list This means that the drive letter assigned for the sd card will not be returned in GetLogicalDrives(). When the symlink to the mountpoint is added manually, following output is produced: DbgPrint says: Drive f fixme:ntdll:server_ioctl_file Unsupported ioctl 70000 (device=7 access=0 func=0 method=0) DbgPrint says: DeviceIoControl failed When get_dos_device is made to unconditionally return STATUS_BAD_DEVICE_TYPE, the ioctl is properly delivered to harddisk_ioctl DeviceIoControl succeeds: DbgPrint says: Drive f DbgPrint says: Removable: 0 But still, the device is reported as non-removable. The reason for this is probably that udisks reports /dev/sdf as removable, but not its partition /dev/sdf1. Is it worth for working on patches for these issues, or is this completely impossible with the current architecture? Eduard

3 7

Re: [1/2] msvcrt: added wmemcpy_s and wmemmove_s
by Alexandre Julliard July 23, 2012

July 23, 2012

Dan Kegel <dank(a)kegel.com> writes: > Next patch will expose them for msvcr100. > > From 357c45971e1315e8f6cd1f9feac65cf96a006a41 Mon Sep 17 00:00:00 2001 > From: Dan Kegel <dank(a)kegel.com> > Date: Fri, 20 Jul 2012 10:39:32 -0700 > Subject: [PATCH 1/2] msvcrt: add wmemcpy_s and wmemmove_s > > --- > dlls/msvcrt/heap.c | 29 ++++++++++++++++++++++++ > dlls/msvcrt/msvcrt.spec | 2 + > dlls/msvcrt/tests/misc.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 85 insertions(+), 0 deletions(-) You shouldn't need to put that in msvcrt. Also please check the parameters correctly like every other _s function does. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: Dmitry Timoshkov : gdiplus: GdipMeasureString operates internally in pixels but in/ out rectangles are in device units.
by Vincent Povirk July 23, 2012

July 23, 2012

> gdiplus: GdipMeasureString operates internally in pixels but in/out rectangles are in device units. I still don't understand this patch. Your subject implies that device units and pixels are not the same thing, but my understanding is that except for metafile HDCs (which we don't handle correctly anyway, and I suspect native doesn't either), they are. You're scaling sizes based on graphics->unit. Yet the conversion in get_graphics_transform (which we were already using in GdipMeasureString to convert between world and device units, indirectly through GdipTransformPoints) already takes graphics->unit into account. So I'm concerned that the original conversion apparently wasn't sufficient, and that you've added more code instead of fixing it. And I'm still concerned about whether the sizes returned by GdipMeasureString will match the size of the strings rendered by GdipDrawString with this patch applied.

2 6

Re: [1/6] windowscodecs: Add support for generating WICBitmapPaletteTypeFixedHalftone27 palette.
by Vincent Povirk July 23, 2012

July 23, 2012

Series looks good to me.

1 0

Re: [PATCH 4/4] mshtml: Added IHTMLFrameBase::frameBorder implementation
by Marvin July 23, 2012

July 23, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20256 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] vbscript: Added select case statement tests
by Marvin July 23, 2012

July 23, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20253 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: atl80: Implement AtlGetVersion - try2
by Dmitry Timoshkov July 23, 2012

July 23, 2012

Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote: > +WINAPI DWORD AtlGetVersion(void* pReserved) That's a somewhat strange choice for the placement of a calling convention specifier. Also it shouldn't be too hard to avoid a hungarian style named variable, and placing '*' properly. -- Dmitry.

2 2

Re: configure.ac: Always treat char as signed char on ARM
by Alexandre Julliard July 23, 2012

July 23, 2012

André Hentschel <nerv(a)dawncrow.de> writes: > Problem: > On ARM the default "char" is "unsigned char" for performance reasons, > Wine uses "char" expecting the x86 default (signed char). In general there's no such expectation in Wine. If there are places that expect char to be signed, they are bugs that should be fixed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Noticed openwatcom.org's afxapi
by Dan Kegel July 22, 2012

July 22, 2012

"Initial checkin of afxapi, a class library aiming to provide source-level compatibility with MFC." http://www.openwatcom.org:4000/@md=d&cd=//depot/openwatcom/bld/afxapi/inclu… Wonder how that's going.

1 0

Error When Using winedbg on 64-bit Ubuntu 12.04
by John Edmonds July 22, 2012

July 22, 2012

I'm using 64-bit Ubuntu 12.04. I built and installed wine using the instructions from http://wiki.winehq.org/WineOn64bit. Whenever I try to debug an application using winedbg I get the following error message: > /var/chroot/usr/local/bin/winedbg ~/.wine/drive_c/windows/system32/notepad.exe err:module:LdrInitializeThunk Main exe initialization for L"C:\\windows\\system32\\notepad.exe" failed, status c0000022 WineDbg starting on pid 0023 couldn't load main module (2) Process of pid=0023 has terminated This is the output when the same command is run with WINEDEBUG=warn+all: http://pastebin.com/RjErdbt8. My source tree is synced to git commit 020a68e1350eaf7293718732c1c9203e460709c6. Has anyone had success debugging Windows applications on 64-bit Linux? Thanks, John Edmonds

3 2

Re: [PATCH 3/5] wined3d: Don't use GL_EXTCALL for WGL extension functions.
by Henri Verbeet July 22, 2012

July 22, 2012

Actually, ignore this one, it shouldn't be needed anymore.

1 0

Re: mpr/tests: Сheck the return values of the WNetGetUniversalNameA. (try 2)
by Nikolay Sivov July 20, 2012

July 20, 2012

On 7/20/2012 16:02, Roman Dadkov wrote: > This patch adds additional check for the returned results in the test > for the function WNetGetUniversalNameA. > The following cases are checked: > 1 transmission of an incorrect buffer size > 2 transmission of an incorrect buffer pointer > 3 transmission path to the file > Similar checks are carried out to call a function with parameter > REMOTE_NAME_INFO_LEVEL. > > + fail_size = sizeof(driveA) / sizeof(char) - 1; // buffer size is less than the path I don't know if this will be accepted as is, but anyway don't use cpp style comments in future. > + if(drive_type == DRIVE_REMOTE) > + todo_wine ok(ret == WN_NO_ERROR, "WNetGetUniversalNameW failed: %08x\n", ret); > + else > + todo_wine ok(ret == ERROR_NOT_CONNECTED, "WNetGetUniversalNameW gave wrong error: %08x\n", ret); > This is mostly matter of taste but in such cases you can use todo_wine {} and place all test call inside.

1 0

Re: mpr/tests: Сheck the return values of the WNetGetUniversalNameA. (try 2)
by Marvin July 20, 2012

July 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20185 Your paranoid android. === W2KPROSP4 (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === WXPPROSP3 (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === W2K3R2SESP2 (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === WVISTAADM (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === W7PRO (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === W7PROX64 (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === TEST64_W7SP1 (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === W7PROX64 (64 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === TEST64_W7SP1 (64 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca

1 0

Re: gdiplus: Set actual resolution of a being encoded image.
by Vincent Povirk July 20, 2012

July 20, 2012

Looks good, thanks.

1 0

Re: mpr/tests: Сheck the return values of the WNetGetUniversalNameA.
by Marvin July 19, 2012

July 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20174 Your paranoid android. === WNT4WSSP6 (32 bit mpr) === mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7 mpr.c:124: Test failed: WNetGetUniversalNameA gave wrong error: 000001e7

1 0

Re: fusion: Don't assume a specific compiler behaviour
by Ruslan Kabatsayev July 19, 2012

July 19, 2012

Hello, > Most likely it's rotated on x86 and hardly shifted on ARM, damn compilers. No, it's not compilers, it's intel's "shr" instruction behavior: it masks bit count lower 5 bits, thus making 33 effectively 1. Corresponding ARM instruction most likely does true 33 bit shift giving you zero result. Regards, Ruslan PS I didn't look at types your patch works on, but be careful to not mess up 64 bit types this way. On Thu, Jul 19, 2012 at 11:49 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > maybe it's some braindamage by me, but when i is greater or equal to 32 a shift of HighPart by e.g. 33 doesn't make much sense. For some reason this works on x86 but not on ARM. Most likely it's rotated on x86 and hardly shifted on ARM, damn compilers. > If i'm right i don't want to know how much places there are in Wine with assumptions like this, i'll most likely find them with the testsuite on ARM, but i's quite hard to get to the point where you see them... > --- > dlls/fusion/assembly.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/fusion/assembly.c b/dlls/fusion/assembly.c > index d04ba73..8e6bfcb 100644 > --- a/dlls/fusion/assembly.c > +++ b/dlls/fusion/assembly.c > @@ -506,7 +506,7 @@ static HRESULT parse_clr_tables(ASSEMBLY *assembly, ULONG offset) > for (i = 0; i < MAX_CLR_TABLES; i++) > { > if ((i < 32 && (assembly->tableshdr->MaskValid.u.LowPart >> i) & 1) || > - (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> i) & 1)) > + (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> (i-32)) & 1)) > { > assembly->numtables++; > } > @@ -522,7 +522,7 @@ static HRESULT parse_clr_tables(ASSEMBLY *assembly, ULONG offset) > for (i = 0; i < MAX_CLR_TABLES; i++) > { > if ((i < 32 && (assembly->tableshdr->MaskValid.u.LowPart >> i) & 1) || > - (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> i) & 1)) > + (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> (i-32)) & 1)) > { > assembly->tables[i].rows = assembly->numrows[offidx]; > offidx++; > @@ -534,7 +534,7 @@ static HRESULT parse_clr_tables(ASSEMBLY *assembly, ULONG offset) > for (i = 1; i < MAX_CLR_TABLES; i++) > { > if ((i < 32 && (assembly->tableshdr->MaskValid.u.LowPart >> i) & 1) || > - (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> i) & 1)) > + (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> (i-32)) & 1)) > { > currofs += get_table_size(assembly, previ) * assembly->numrows[offidx - 1]; > assembly->tables[i].offset = currofs; > -- > 1.7.4.1 > > > -- > > Best Regards, André Hentschel > > >

2 1

Re: wininet: Support ICU_ENCODE_PERCENT, ICU_ENCODE_SPACES_ONLY, and ICU_NO_META.
by Austin English July 19, 2012

July 19, 2012

On Wed, Jul 18, 2012 at 6:33 PM, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Without this patch, Internet Explorer 6 produces a lot of messages like > "fixme:wininet:InternetCanonicalizeUrlW Unhandled flags 0x04000000" > > Wine's wininet.h was missing ICU_ENCODE_PERCENT, which is present in > the wininet.h from the Windows 7 SDK. > > Wine previously treated ICU_ESCAPE like ICU_DECODE. This is incorrect, > MSDN and empirical tests agree that ICU_ESCAPE should be ignored: > http://msdn.microsoft.com/en-us/library/windows/desktop/aa384342(v=vs.85).a… > https://testbot.winehq.org/JobDetails.pl?Key=20155 Why didn't you include the tests in the patch? -- -Austin

2 2

Re: [1/2]usp10: cache OUTLINETEXTMETRICW instead of just TEXTMETRICW
by Dmitry Timoshkov July 19, 2012

July 19, 2012

Aric Stewart <aric(a)codeweavers.com> wrote: > + sc->tm = heap_alloc(size); > + GetOutlineTextMetricsW(hdc, size, sc->tm); otmSize exists for a reason, if GetOutlineTextMetrics currently doesn't check it this doesn't mean it won't at some point in future. -- Dmitry.

1 0

Re: [PATCH 4/4] ieframe: Avoid useless QI(IID_IWebBrowser2) calls in tests by passing IWebBrowser2 interface where possible
by Marvin July 19, 2012

July 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20160 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: include/winhttp.h: Make strings in WINHTTP_PROXY_INFO non-const
by Hans Leidekker July 19, 2012

July 19, 2012

On Thu, 2012-07-19 at 07:27 +0000, Heiko Hund wrote: > The strings shouldn't be const according to the docs at [1] and > declaring them as LPWSTR removes some false warnings when > compiling code GlobalFree()ing them with mingw. Please also remove unnecessary casts from Wine.

1 0

Re: [PATCH 01/10] dsound/tests: Add IDirectSound refcount and COM aggregation tests.
by Marvin July 18, 2012

July 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20152 Your paranoid android. === WNT4WSSP6 (32 bit dsound) === dsound.c:194: Test failed: DirectMusicPerformance create failed: 80070057, expected CLASS_E_NOAGGREGATION dsound.c:196: Test failed: dso = DEADBEEF

1 0

Re: ole32: Forward BSTR functions to oleaut32
by Alexandre Julliard July 18, 2012

July 18, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -1244,6 +1244,9 @@ static void COMPOBJ_InitProcess( void ) > static void COMPOBJ_UninitProcess( void ) > { > UnregisterClassW(wszAptWinClass, hProxyDll); > + > + if(oleaut32_instance) > + FreeLibrary(oleaut32_instance); Since oleaut32 imports ole32 you'll never get here. Using a delayed import would probably be easier. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: mshtml: Set outgoing pass-by-address variable in an error case case within confirm_safety_load.
by Jacek Caban July 18, 2012

July 18, 2012

Hi Gerald, On 03/07/12 23:35, Gerald Pfeifer wrote: > I noticed we return in this case, without initializing this variable. > Visual inspection indicates we do not seem to access the variable in > this error case, but a) better safe than sorry, and b) GCC 4.8 currently > warns about it. > > Not sure URLPOLICY_DISALLOW is the best return value, open for better > alternatives. I generally don't think this patch makes things any better (or worse). If we return an error, the caller should not expect this value to be sane. What's the GCC 4.8 warning? Jacek

2 4

Re: d3dx9_36: Implementation of D3DXSHRotateZ
by Matteo Bruni July 18, 2012

July 18, 2012

2012/7/18 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > Minor nitpicks, but nevertheless: > -@ stub D3DXSHRotateZ(ptr long long ptr) > +@ stdcall D3DXSHRotateZ(ptr long long ptr) ... > +FLOAT* WINAPI D3DXSHRotateZ(FLOAT *out, UINT order, FLOAT angle, CONST FLOAT *in) I guess using "float" in the spec file for the third parameter would be more appropriate (yes, it was already wrong but that's not an excuse ;) + if ( i >= order * order || ( (order > D3DXSH_MAXORDER) && ( i >= D3DXSH_MAXORDER * D3DXSH_MAXORDER ) ) ) + expected = ( i + 1.0f ) * ( i + 1.0f ); Bad indentation. In general the inner for loop in the tests feels awkward, try to rewrite it to avoid the duplicated stuff. + } + } + } You're adding a tab character here, please use only whitespaces for indentation. That said, thanks for your work on d3dx9!

1 0

Re: [PATCH 2/2] vbscript: Added LCase implementation
by Marvin July 18, 2012

July 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20130 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/2] gdiplus: Add 8bpp to the list of supported formats.
by Vincent Povirk July 18, 2012

July 18, 2012

> + &GUID_WICPixelFormat8bppGray, This will give you a halftone palette instead of a grayscale palette, unless you add special handling for that format.

2 2

Re: [PATCH 5/5] d3dcompiler: Implement basic expressions parsing.
by Stefan Dösinger July 17, 2012

July 17, 2012

Am Montag, 16. Juli 2012, 20:39:23 schrieb Matteo Bruni: > + HLSL_IR_BINOP_MUL, > ... > + HLSL_IR_BINOP_DOT, HLSL has 3 somewhat related multiplication operations: "*", "mul" and "dot". Dot is fairly straightforward, but "*" and "mul" have subtle differences. I recommend to write tests to find out the exact details, but as far as I remember "float4 * float4" gives you a float4 with a component-wise multiplication, whereas mul(float, float) returns a scalar like the dot product. "float4x4 * float4" is an error, but mul(float4x4, float4) performs a matrix-vector multiplication and returns a float4. > +static struct hlsl_type *expr_common_type(struct hlsl_type *t1, struct > hlsl_type *t2, > + struct source_location *loc) This type inference system might be a bit too limited, you have to take the operation into account. e.g. a dot(float3, float4) returns a scalar and crs(float4, float4) returns a float3.

2 1

Re: riched20: Avoid uninitialized field in STGMEDIUM structure (LLVM/Clang).
by Alexandre Julliard July 17, 2012

July 17, 2012

Nicolas Le Cam <niko.lecam(a)gmail.com> writes: > @@ -1098,6 +1098,8 @@ static BOOL ME_RTFInsertOleObject(RTF_Info *info, HENHMETAFILE hemf, HBITMAP hbm > BOOL ret = FALSE; > DWORD conn; > > + memset(&stgm, 0, sizeof(stgm)); > + Please fix the bugs (if any) instead of silencing the warnings by memsetting everything to 0. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: msvcp90: handle npos as a len in basic_string<>::replace
by Dan Kegel July 16, 2012

July 16, 2012

Daniel Lehman wrote: @@ -1949,7 +1949,7 @@ basic_string_char* __thiscall basic_string_char_replace_cstr_len(basic_string_ch - if(off+len > this->size) + if(off+len < off || off+len > this->size) len = this->size-off; Wouldn't this be more elegant: if(num > this->size-pos) num = this->size-pos; ? Also, you may have missed the similar case in basic_string_char_compare_substr_cstr_len (which uses 'pos' and 'num' rather than 'off' and 'len'). See http://bugs.winehq.org/show_bug.cgi?id=31085#c5

2 1

Build failure of "[PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test (try 4)" ?
by GOUJON Alexandre July 16, 2012

July 16, 2012

Hi, My patch (http://source.winehq.org/patches/data/88072) is marked as "Build failure". I tried with the latest (today) HEAD and I successfully applied it. Compilation also works for me at least on my x86 and x86_64 computers. Moreover, the Wine Test Bot tested it without any issue, see https://testbot.winehq.org/JobDetails.pl?Key=19936. I know your machine is a bit "mystic". Can you show me your output to help me diagnosing your build failure ? Thanks

2 2

Re: msi/tests: Mark some test results as broken.
by Marvin July 16, 2012

July 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20071 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: kernel32: Also report empty drives as available in GetLogicalDrives
by Alexandre Julliard July 16, 2012

July 16, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > --- > dlls/kernel32/volume.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c > index 8377e41..67e2eb1 100644 > --- a/dlls/kernel32/volume.c > +++ b/dlls/kernel32/volume.c > @@ -1441,19 +1441,26 @@ DWORD WINAPI GetLogicalDrives(void) > DWORD ret = 0; > int i; > > - if (!(buffer = HeapAlloc( GetProcessHeap(), 0, strlen(config_dir) + sizeof("/dosdevices/a:") ))) > + if (!(buffer = HeapAlloc( GetProcessHeap(), 0, strlen(config_dir) + sizeof("/dosdevices/a::") ))) > { > SetLastError( ERROR_NOT_ENOUGH_MEMORY ); > return 0; > } > strcpy( buffer, config_dir ); > - strcat( buffer, "/dosdevices/a:" ); > - dev = buffer + strlen(buffer) - 2; > + strcat( buffer, "/dosdevices/a::" ); > + dev = buffer + strlen(buffer) - 3; > > for (i = 0; i < 26; i++) > { > *dev = 'a' + i; > + dev[2] = 0; > if (!stat( buffer, &st )) ret |= (1 << i); > + /* Windows also report empty drives as available */ > + else > + { > + dev[2] = ':'; > + if (!stat( buffer, &st )) ret |= (1 << i); > + } You can't do that, the device symlinks don't reflect the availability of the drive. It would have to go through the mountmgr. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/9] hhctrl.ocx: Centralize merging HH_WINTYPE data (resend).
by Alexandre Julliard July 16, 2012

July 16, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > @@ -28,6 +28,13 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(htmlhelp); > > +#define HHWIN_PARAM_MASK (HHWIN_PARAM_PROPERTIES|HHWIN_PARAM_STYLES|HHWIN_PARAM_EXSTYLES|HHWIN_PARAM_RECT\ > + |HHWIN_PARAM_NAV_WIDTH|HHWIN_PARAM_SHOWSTATE|HHWIN_PARAM_INFOTYPES\ > + |HHWIN_PARAM_TB_FLAGS|HHWIN_PARAM_EXPANSION|HHWIN_PARAM_TABPOS\ > + |HHWIN_PARAM_TABORDER|HHWIN_PARAM_HISTORY_COUNT|HHWIN_PARAM_CUR_TAB) > +#define MERGE_PARAM(s,d,o,p) ((s->fsValidMembers & p) && (!(d->fsValidMembers & p) || o)) > +#define MERGE_PROP(s,d,o,p) (s->p != 0 && (d->p == 0 || o)) These macros are fairly ugly, you should be able to do without that. > @@ -1752,16 +1752,16 @@ void ReleaseHelpViewer(HHInfo *info) > list_remove(&info->entry); > > /* Free allocated strings */ > - heap_free(info->pszType); > - heap_free(info->pszCaption); > - heap_free(info->pszToc); > - heap_free(info->pszIndex); > - heap_free(info->pszFile); > - heap_free(info->pszHome); > - heap_free(info->pszJump1); > - heap_free(info->pszJump2); > - heap_free(info->pszUrlJump1); > - heap_free(info->pszUrlJump2); > + heap_free((LPVOID)info->WinType.pszType); > + heap_free((LPVOID)info->WinType.pszCaption); > + heap_free((LPVOID)info->WinType.pszToc); > + heap_free((LPVOID)info->WinType.pszIndex); > + heap_free((LPVOID)info->WinType.pszFile); > + heap_free((LPVOID)info->WinType.pszHome); > + heap_free((LPVOID)info->WinType.pszJump1); > + heap_free((LPVOID)info->WinType.pszJump2); > + heap_free((LPVOID)info->WinType.pszUrlJump1); > + heap_free((LPVOID)info->WinType.pszUrlJump2); Don't do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 6/6] jscript: Don't set constructor property to each object instance, it belongs to their prototypes
by Marvin July 16, 2012

July 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20070 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/6] jscript: Expose RegExpError constructor in global object
by Marvin July 16, 2012

July 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20069 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/6] jscript: Properly set Error object's constructor property
by Marvin July 16, 2012

July 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20068 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/6] jscript: Properly set Function constructor's constructor property
by Marvin July 16, 2012

July 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20067 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/6] jscript: Properly handle constructor property for most builtin constructors
by Marvin July 16, 2012

July 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20066 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] jscript: Properly set Number.prototyp.constructor
by Marvin July 16, 2012

July 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20065 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [4/4] gdiplus: GdipMeasureString operates internally in pixels but in/out rectangles are in device units. Resend.
by Vincent Povirk July 16, 2012

July 16, 2012

Values returned from Measure[String|CharacterRanges] have to match what DrawString will draw. If they don't currently match, you need to explain why that is. If they do, you need to bring DrawString into line as well.

1 0

re: Query MediaType of SD-Cards using IOCTL_GET_DISK_DRIVE_GEOMETRY
by Dan Kegel July 15, 2012

July 15, 2012

> Is it worth for working on patches for these issues, or is this > completely impossible with the current architecture? Do you know yet why no symlink is made in dosdevices for /media/XXXX-YYYY? I haven't heard any rumblings about the current architecture being hopelessly broken.

2 1

Re: dsound: Add detection of output format and allow a maximum of 8 channels
by Andrew Eikum July 14, 2012

July 14, 2012

Thanks, Donny. Nice work overall. Some comments below. On Fri, Jul 13, 2012 at 05:57:48PM +1000, Donny Yang wrote: > This patch makes dsound automatically get the output format when a > output device is initialised and also allows up to 8 output channels > to be used for ALSA and PulseAudio. Using ALSA with over 2 channels > outputs the channels in the wrong speakers with my testing but I don't > know why so I can't fix that. You probably already discovered that ALSA's multi-channel support is primitive at best. You have to test each channel and hand-craft an asoundrc to match your hardware. See some more information here: <http://drona.csa.iisc.ernet.in/~uday/alsamch.shtml> > @@ -1492,6 +1493,24 @@ HRESULT DirectSoundDevice_Initialize(DirectSoundDevice ** ppDevice, LPCGUID lpcG > } else > WARN("DSOUND_PrimaryCreate failed: %08x\n", hr); > > + hr = IAudioClient_GetMixFormat(device->client, &pwfx); > + if(FAILED(hr)){ > + WARN("IAudioClient_GetMixFormat failed: %08x; Falling back to default output format\n", hr); > + }else{ > + DWORD oldPriolevel = device->priolevel; > + device->priolevel = DSSCL_WRITEPRIMARY; > + hr = primarybuffer_SetFormat(device, pwfx); > + device->priolevel = oldPriolevel; This looks like a hack. I think it fits better in DirectSoundDevice_Create, where the default values are copied in. Is there a reason it couldn't be done there? > -void put_mono2stereo(const IDirectSoundBufferImpl *dsb, DWORD pos, DWORD channel, float value) > +void put_mono(const IDirectSoundBufferImpl *dsb, DWORD pos, DWORD channel, float value) > { > - dsb->put_aux(dsb, pos, 0, value); > - dsb->put_aux(dsb, pos, 1, value); > + /* XXX: Is this how Windows does this? */ > + DWORD c; > + for (c = 0; c < dsb->device->pwfx->nChannels; ++c) > + dsb->put_aux(dsb, pos, c, value); > } > I think this is fine. I wonder if we should skip the LOWFREQ channel, though we'd have to be careful not to affect performance too much, as this runs in a really tight loop. > void mixieee32(float *src, float *dst, unsigned samples) > diff --git a/dlls/dsound/dsound_main.c b/dlls/dsound/dsound_main.c > index 072b25a..538534d 100644 > --- a/dlls/dsound/dsound_main.c > +++ b/dlls/dsound/dsound_main.c > @@ -642,7 +642,7 @@ DirectSoundCaptureEnumerateW( > */ > > typedef HRESULT (*FnCreateInstance)(REFIID riid, LPVOID *ppobj); > - > + > typedef struct { > IClassFactory IClassFactory_iface; > REFCLSID rclsid; > @@ -702,7 +702,7 @@ static HRESULT WINAPI DSCF_CreateInstance( > *ppobj = NULL; > return This->pfnCreateInstance(riid, ppobj); > } > - > + > static HRESULT WINAPI DSCF_LockServer(LPCLASSFACTORY iface, BOOL dolock) > { > IClassFactoryImpl *This = impl_from_IClassFactory(iface); The only changes to this file are whitespace changes. I'd exclude these changes when you resend. > diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound/dsound_private.h > index 1cf6daa..68f6242 100644 > --- a/dlls/dsound/dsound_private.h > +++ b/dlls/dsound/dsound_private.h > @@ -202,7 +202,7 @@ struct IDirectSoundBufferImpl > }; > > float get_mono(const IDirectSoundBufferImpl *dsb, DWORD pos, DWORD channel) DECLSPEC_HIDDEN; > -void put_mono2stereo(const IDirectSoundBufferImpl *dsb, DWORD pos, DWORD channel, float value) DECLSPEC_HIDDEN; > +void put_mono(const IDirectSoundBufferImpl *dsb, DWORD pos, DWORD channel, float value) DECLSPEC_HIDDEN; > > HRESULT IDirectSoundBufferImpl_Create( > DirectSoundDevice *device, > @@ -288,7 +288,7 @@ HRESULT primarybuffer_SetFormat(DirectSoundDevice *device, LPCWAVEFORMATEX wfex) > LONG capped_refcount_dec(LONG *ref) DECLSPEC_HIDDEN; > > /* duplex.c */ > - > + > HRESULT DSOUND_FullDuplexCreate(REFIID riid, LPDIRECTSOUNDFULLDUPLEX* ppDSFD) DECLSPEC_HIDDEN; > > /* mixer.c */ > @@ -305,7 +305,7 @@ DWORD CALLBACK DSOUND_mixthread(void *ptr) DECLSPEC_HIDDEN; > void DSOUND_Calc3DBuffer(IDirectSoundBufferImpl *dsb) DECLSPEC_HIDDEN; > > /* capture.c */ > - > + > HRESULT DSOUND_CaptureCreate(REFIID riid, LPDIRECTSOUNDCAPTURE *ppDSC) DECLSPEC_HIDDEN; > HRESULT DSOUND_CaptureCreate8(REFIID riid, LPDIRECTSOUNDCAPTURE8 *ppDSC8) DECLSPEC_HIDDEN; > Likewise, more unneeded whitespace changes. > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index 93e2b8d..fa6b05a 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -1544,7 +1544,7 @@ static HRESULT WINAPI AudioClient_IsFormatSupported(IAudioClient *iface, > goto exit; > } > if(max > 8) > - max = 2; > + max = 8; > if(fmt->nChannels > max){ > hr = S_FALSE; > closest->nChannels = max; > @@ -1649,8 +1649,8 @@ static HRESULT WINAPI AudioClient_GetMixFormat(IAudioClient *iface, > goto exit; > } > > - if(max_channels > 2) > - fmt->Format.nChannels = 2; > + if(max_channels > 8) > + fmt->Format.nChannels = 8; > else > fmt->Format.nChannels = max_channels; > This needs to be a separate patch. Also, winealsa's multi-channel handling needs a closer examination. My current thinking is GetMixFormat should just return some sane, supported default (2ch, 48kHz, 16bps, or less as supported). It seems impossible to detect what the ALSA device actually supports, so we probably shouldn't even try like we do now. > diff --git a/dlls/winepulse.drv/mmdevdrv.c b/dlls/winepulse.drv/mmdevdrv.c > index b374b53..e86ed08 100644 > --- a/dlls/winepulse.drv/mmdevdrv.c > +++ b/dlls/winepulse.drv/mmdevdrv.c > @@ -1050,13 +1050,13 @@ static HRESULT pulse_spec_from_waveformat(ACImpl *This, const WAVEFORMATEX *fmt) > This->ss.format = PA_SAMPLE_INVALID; > switch(fmt->wFormatTag) { > case WAVE_FORMAT_IEEE_FLOAT: > - if (!fmt->nChannels || fmt->nChannels > 2 || fmt->wBitsPerSample != 32) > + if (!fmt->nChannels || fmt->nChannels > 8 || fmt->wBitsPerSample != 32) > break; > This->ss.format = PA_SAMPLE_FLOAT32LE; > pa_channel_map_init_auto(&This->map, fmt->nChannels, PA_CHANNEL_MAP_ALSA); > break; > case WAVE_FORMAT_PCM: > - if (!fmt->nChannels || fmt->nChannels > 2) > + if (!fmt->nChannels || fmt->nChannels > 8) > break; > if (fmt->wBitsPerSample == 8) > This->ss.format = PA_SAMPLE_U8; Wine doesn't have a PulseAudio driver yet, so this chunk won't apply. Andrew

2 2

GetDriveType and empty CD/DVD-ROM drives
by GOUJON Alexandre July 14, 2012

July 14, 2012

Hi, I'm currently working on bug #17037. The root cause is that GetDriveType("D:\") (if D is mapped to /dev/cdrom) returns DRIVE_NO_ROOT_DIR while on Windows it returns DRIVE_CDROM when there is no disc in the D drive. GetDriveType tries to open D:\ which is converted into \\??\\D:\\ then ~/.wine/dosdevices/d:/ The fact is that there is a dosdevices/d:: file (symlinked to /dev/cdrom) but no dosdevices/d: except if a CD or DVD is in and mounted somewhere. The conversion \\??\\D:\\ -> ~/.wine/dosdevices/d:/ is done in wine_nt_to_unix_file_name (ntdll/directory.c, line 2897). I'm asking here because I wonder if modifying wine_nt_to_unix_file_name is the right thing to do and sane: it's called at several locations and I don't want to cause trouble and regressions, well, if possible. Thanks for any advice

1 0

Suppressing My Computer in File Open dialog box?
by Dan Kegel July 14, 2012

July 14, 2012

I'm creating a page of tips at http://wiki.winehq.org/DisplayingUnixFilenames for vendors shipping Windows apps on Linux with Wine who want their apps to use Windows paths throughout internally, but display Linux paths in the GUI This is something I've been meaning to do ever since I helped port Picasa. Picasa was an easy case, since it didn't use any standard widgets. So now I'm wondering how to coax standard widgets into not leaking Windows paths or naming conventions visually. Does anyone know how to keep the Save File dialog box from listing My Computer in the LookIn pulldown? (I know how to keep it from showing /, but I'd like to do the opposite, and *only* show / and maybe the user's home directory, if possible.)

2 2

Re: dsound: Add support for adjusting volume of more than 2 channels
by Andrew Eikum July 13, 2012

July 13, 2012

On Fri, Jul 13, 2012 at 05:59:03PM +1000, Donny Yang wrote: > - if (channels != 1 && channels != 2) > - { > - FIXME("There is no support for %u channels\n", channels); > + if (dsb->device->pwfx->wFormatTag == WAVE_FORMAT_EXTENSIBLE) > + channelMask = ((WAVEFORMATEXTENSIBLE*)dsb->device->pwfx)->dwChannelMask; > + else if (channels == 1) > + channelMask = SPEAKER_FRONT_CENTER; > + else if (channels == 2) > + channelMask = SPEAKER_FRONT_LEFT | SPEAKER_FRONT_RIGHT; > + else { > + FIXME("There is no support for %u channels without an extensible wave format\n", channels); > return; > } Before you resend, please consider testing how Windows behaves in this condition. Does it actually refuse to apply any volume at all? Andrew

1 0