July 2012 - Wine-Devel - list.winehq.org

A copyright question to wine developpers
by Christophe-Marie Duquesne July 26, 2012

July 26, 2012

Hi, To my understanding, wine is a reimplementation of the MS system. As far as I understand, you take MS public headers and reimplement their functions. If that is how it works, then how do you deal with copyright? The MS headers certainly come with a copyright clause: how is it possible to redistribute these headers with wine? The reason why I ask this: I just rewrote an opensource implementation of a closed-source library. This opensource implementation is meant to be fully compatible with the closed source one: I reimplemented all the functions provided by their header, and anyone using the closed source one should be able to use my library as a replacement. My problem, though, is with the distribution of the header: Since I want to be fully compatible with the closed-source implementation, I have to, somehow, use the same header. I could probably modify it so that is *looks* different, but for the compiler, the API *needs* to be the same. Since you seem to have the same problem with wine (and you probably dealt with it succesfully), I wanted to ask you how you are solving this problem. Do you "rewrite" the headers? Do you copy them "raw"? Thank you, Christophe-Marie Duquesne

5 7

Rethinking WineConf
by Jeremy White July 26, 2012

July 26, 2012

Hi All, This past Wine conference, while great fun as always, was not as well attended as Wine conferences in the past. So I would like to stir up trouble by suggesting we rethink WineConf. For those that have not attended, the Wine conference has been a mostly annual affair since 2002. It is open to all, but is advertised as being aimed at Wine developers. About 35 people attend each year. It's been in Minnesota about every 3rd year, and is otherwise 'normally' somewhere in Europe. I see the primary goal as creating human bonds between otherwise anonymous people (aka going to the pub). It's a bonus if it also spurs resolution to tricky issues, or motivates people to get more done. So I'd like to ask folks to brain storm with me. How could Wineconf be different? If you've never been, what would encourage you to come? If you've been to a technical conference recently that you thought was well done, what did they do well? Anything we could emulate? Any other ideas, or suggestions? Cheers, Jeremy

17 25

Re: user32: Rearrange ComboBox repositioning code (Resolves one "todo") (Resend).
by Dmitry Timoshkov July 26, 2012

July 26, 2012

Sergey Guralnik <serhio(a)etersoft.ru> wrote: > user32: Rearrange ComboBox repositioning code. For what it's worth this patch seems reasonable to me. -- Dmitry.

1 0

Re: kernel32: Add UTF-7 support
by Alexandre Julliard July 26, 2012

July 26, 2012

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Fixes bug 27388. > > This patch has been in the queue since May 21. I'm open to feedback. It should all be in kernel32, not in libwine. Also you must do it without memory allocations. You'd also want more tests for the overflow cases, in particular for partial sequences. -- Alexandre Julliard julliard(a)winehq.org

1 0

mshtml: Always set the URL policy in the error cases?
by Francois Gouget July 26, 2012

July 26, 2012

gcc 4.7 is complaining that policy may be used uninitialized in InternetHostSecurityManager_QueryCustomPolicy() and indeed there are many error cases in confirm_safety_load() and confirm_safety() where the policy is not set. The patch belowe seems to plug all these holes but I don't know if it really makes sense. diff --git a/dlls/mshtml/secmgr.c b/dlls/mshtml/secmgr.c index ff349ac..3f64a42 100644 --- a/dlls/mshtml/secmgr.c +++ b/dlls/mshtml/secmgr.c @@ -104,10 +104,9 @@ static HRESULT confirm_safety_load(HTMLDocumentNode *This, struct CONFIRMSAFETY CATID init_catid = CATID_SafeForInitializing; hres = ICatInformation_IsClassOfCategories(This->catmgr, &cs->clsid, 1, &init_catid, 0, NULL); + *ret = hres == S_OK ? URLPOLICY_ALLOW : URLPOLICY_DISALLOW; if(FAILED(hres)) return hres; - - *ret = hres == S_OK ? URLPOLICY_ALLOW : URLPOLICY_DISALLOW; } return S_OK; @@ -157,13 +156,17 @@ static HRESULT confirm_safety(HTMLDocumentNode *This, const WCHAR *url, struct C if(!This->catmgr) { hres = CoCreateInstance(&CLSID_StdComponentCategoriesMgr, NULL, CLSCTX_INPROC_SERVER, &IID_ICatInformation, (void**)&This->catmgr); - if(FAILED(hres)) + if(FAILED(hres)) { + *ret = URLPOLICY_DISALLOW; return hres; + } } hres = ICatInformation_IsClassOfCategories(This->catmgr, &cs->clsid, 1, &scripting_catid, 0, NULL); - if(FAILED(hres)) + if(FAILED(hres)) { + *ret = URLPOLICY_DISALLOW; return hres; + } if(hres != S_OK) { *ret = URLPOLICY_DISALLOW; -- 1.7.10

2 3

Re: [1/9] gdiplus: Make sure that GdipBitmapLockBits stores valid lockmode.
by Vincent Povirk July 26, 2012

July 26, 2012

I think this is a correct change, even though it looks wrong. If you use some invalid flag and/or add a comment, that may help explain what you're doing.

1 0

Re: [1/2] gdiplus: Make sure that 1bpp bitmap images get loaded in native format.
by Vincent Povirk July 26, 2012

July 26, 2012

Uh, this is going to cause regressions if you don't give the image a palette.

2 2

Re: gdiplus: Store device resolution in the graphics object.
by Dmitry Timoshkov July 26, 2012

July 26, 2012

Hello, this patch is marked as pending, is there a reason why? Thanks. -- Dmitry.

1 0

[rfc msvcp100] add Container_base::_Orphan_all
by Dan Kegel July 25, 2012

July 25, 2012

Piotr, can you review this, please? I've only tested this with two apps on 32 bits, I have not tested at all on 64 bits, and am only guessing on the calling convention stuff. Seems to fix http://bugs.winehq.org/show_bug.cgi?id=27698 for Harvest and one other app (I can't reproduce the problem with Origin, and I haven't tried cl.exe).

2 2

Re: [PATCH 7/7] msvcp90/tests: Added destructor tests for class with virtual inheritance
by Marvin July 25, 2012

July 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=161 Your paranoid android. === debiantesting (build) === Patch failed to apply

1 0