August 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template
by Dmitry Timoshkov Aug. 13, 2012

Aug. 13, 2012

Eric Pouech <eric.pouech(a)orange.fr> wrote: > MMRESULT WINAPI acmFormatChooseW(PACMFORMATCHOOSEW pafmtc) > { > - return DialogBoxParamW(MSACM_hInstance32, MAKEINTRESOURCEW(DLG_ACMFORMATCHOOSE_ID), > - pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + MMRESULT ret; > + > + if (pafmtc->fdwStyle & ACMFORMATCHOOSE_STYLEF_ENABLETEMPLATEHANDLE) > + ret = DialogBoxIndirectParamW(MSACM_hInstance32, (LPCDLGTEMPLATEW)pafmtc->hInstance, > + pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + else if (pafmtc->fdwStyle & ACMFORMATCHOOSE_STYLEF_ENABLETEMPLATE) > + ret = DialogBoxParamW(pafmtc->hInstance, pafmtc->pszTemplateName, > + pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + else > + ret = DialogBoxParamW(MSACM_hInstance32, MAKEINTRESOURCEW(DLG_ACMFORMATCHOOSE_ID), > + pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + return ret; > } It would look much better without all those 'ret' + 'else' things. -- Dmitry.

2 3

Re: [PATCH 2/4] wined3d: Fix pixel format alpha/red masks.
by Henri Verbeet Aug. 13, 2012

Aug. 13, 2012

On 13 August 2012 20:20, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + * Pixel formats with more than 4 bpp do not have correct masks, because the > + * high masks do not fit into the 32 bit values needed for ddraw. The masks > + * are only used for ddraw mostly, and to figure out if the format has an alpha > + * component (the POSTPIXELSHADER_BLENDING test also uses those masks to know > + * if there is more than 1 alpha bit and a red component), so that doesn't > + * matter. The 64 and 128 bit formats are not supported by ddraw anyway. > */ We'll probably want these as offset + mask, or perhaps offset + size.

1 0

Re: joy.cpl: Corrected misplaced elements when using high DPIs
by Alexandre Julliard Aug. 13, 2012

Aug. 13, 2012

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Zawacki <lfzawacki(a)gmail.com> > > Fixes bug #31316 > > joy.cpl uses CreateWindow and SetWindowPos to draw some elements > and the hardcoded coordinates where wrong when the dpi was set to anything > bigger than 96px in winecfg. My approach to solve is normalize the > coordinates based on the dialog window size. You probably want to use MapDialogRect instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

_vcomp_fork stack frame puzzle
by Dan Kegel Aug. 12, 2012

Aug. 12, 2012

Having fun trying to figure out what's in the black box of _vcomp_fork(), the helper function that spawns threads in Visual C's OpenMP support library. The C source code #include <stdio.h> #include <omp.h> int main(int argc, char **argv) { double d; double e; int i; printf("&d is %p, &e is %p\n", &d, &e); #pragma omp parallel for for (i=0; i<3; i++) { printf("&d is %p\n", &d); } #pragma omp parallel for for (i=0; i<3; i++) { printf("&d is %p, &e is %p\n", &d, &e); } return 0; } when compiled with cl /MD /openmp /FAs odd.c generates an .exe and a mixed assembly / source .asm listing. The compiler puts the loop into a helper function, and invokes the helper using _vcomp_fork(), which is called with a flag saying whether to parallelize, a pointer to the helper function, a count, and then a pointer to each variable referenced by the loop from the outer scope. The code in the helper function knows to get the addresses of the variables from the stack. When run with native vcomp.dll, this prints out the right addresses inside the loop. When run with my slightly less stubby builtin vcomp patch attached to http://bugs.winehq.org/show_bug.cgi?id=26688 (based on Andre's earlier patch), it prints out garbage. It seems like Andre's varargs code should be right, but something's not connecting. I even tried beer, and it still didn't work. I guess I should fire up a debugger and see what's going on, but I don't want to accidentally see too much about what native's doing. Suggestions, anyone? - Dan

2 5

Wiki is down
by Austin English Aug. 10, 2012

Aug. 10, 2012

Mind taking a look? :) Have a great weekend! -- -Austin

2 1

Re: user32: Menu should not be activated by menu key while mouse buttons are down.
by Jan Boon Aug. 10, 2012

Aug. 10, 2012

Okay, will write a test case later today or tomorrow. When trying to fix the issue I had, I noticed that in the function where it currently handles the logic for the menu key, it only received messages WM_MOUSEACTIVATE on pressing and WM_CAPTURECHANGED on release (in the tested application), but no mouse down or up messages, which caused the mouse down not to set the iMenuSysKey to 0 if the mouse button was pressed after holding alt (and additionally it also needs to not select the menu either when hitting alt while the mouse button is already down). (Also, when trying this manually on linux, gnome desktop wm mouse-button-modifier should be changed from Alt to something else, because it intercepts the alt-mouse combos before wine sees them it seems.) So, since the function is not receiving all the messages here, which I assume are not all forwarded to the default handler by 3ds Max, would it be better to hook into the messages or mouse status at an earlier point in the code (to handle the first case where the mouse is pressed after alt)? And is there a saner way that can be used here to check if the mouse is down (when alt is pressed after mouse down)? On Fri, Aug 10, 2012 at 8:14 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Jan Boon <jan.boon(a)kaetemi.be> wrote: > > > Fix for bug #31434. > > 1. this kind of change requires a test case, some of the changes look wrong > 2. formatting is broken due to not standard tab size > 3. patch introduces compile-time warnings, that's not accepatable > > -- > Dmitry. >

1 0

Re: [01/17] gdiplus: Add more tests for GdipMeasureString using device with custom resolution. Take 4.
by Vincent Povirk Aug. 9, 2012

Aug. 9, 2012

Other than patch 15 the series looks good to me, and I've seen or thought about most of this before, but do you really have to send a series of 17 patches at once?

2 1

Re: [15/17] gdiplus: Delete GDI objects once they are not needed anymore.
by Vincent Povirk Aug. 9, 2012

Aug. 9, 2012

This will break text rendering. We need the correct font to be selected on the hdc during the call to gdip_format_string.

2 3

Re: [1/4] gdiplus: Add a test for GdipDrawImage scaling.
by Vincent Povirk Aug. 8, 2012

Aug. 8, 2012

This series looks good to me.

1 0

__wine_uuidof causing a wall of "warning: returning reference to temporary" on g++
by Ilya Konstantinov Aug. 8, 2012

Aug. 8, 2012

Hi, I've just started porting my C++ application to Linux with Winelib. Upon first attempts to compile, I've received a wall of "warning: returning reference to temporary" on Wine's headers from g++. All of those seem to stem from guidgen.h definition of __wine_uuidof / __CRT_UUID_DECL for C++. All in all, g++ seems to be right -- we are indeed returning a reference to a IID struct that's allocated on the stack. If I remove the '&' in this definition (in guidgen.h): template<typename T> const GUID &__wine_uuidof(); the warnings stop, but then I wonder, did the original author have some good reasoning for returning a reference in the first place? Thanks.

2 4

Re: [3/4] gdiplus: Destination points passed to GdipDrawImagePointsRect should be in device units.
by Dmitry Timoshkov Aug. 7, 2012

Aug. 7, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > + scale_x = units_scale(srcUnit, graphics->unit, graphics->xres); > + scale_y = units_scale(srcUnit, graphics->unit, graphics->yres); This depends on a not yet sent series which introduces units_scale(), please ignore for now, I'll resend it a bit later. -- Dmitry.

1 0

Cannot run wineinstall
by Carlos Tiba Aug. 7, 2012

Aug. 7, 2012

It displays the message: " You are running wineinstall as root, this is not advisable. Please rerun as a user. Aborting. " However it is not possible to install anything on Ubuntu Linux if you-re not root. The command: $ sudo ./wineinstall does not run after passwd enter because of the message above. How is it possible? Thanks Carlos Tiba

2 1

Wine automated testing update
by Jeremy White Aug. 6, 2012

Aug. 6, 2012

Hi Folks, At the last Wine conference, I volunteered to find a home for the WineTestBot that Ge's brother has been hosting, and to take over the Buildbot that Dan and Austin have been so diligently maintaining. This is an update on that project, mostly to help keep my procrastinating self moving it along. First, we have a lovely set of hardware; 4 servers, in a dedicated rack, with a dedicated static ip to the outside world. One server is the gateway, 2 are dedicated Linux test systems (with nice fast processor + gpus), and one is a beefy system capable of running many VMs. The plan was to move the existing VMWare based WineTestBot to this hardware and simply get the existing system up and running on the new hardware. Here we hit our first snag; the VMWare folks are not willing to provide a permanent license for VMWare to us. So, we've shifted gears, and are exploring whether something like qemu + kvm would be a sufficient alternate. I've done a little of this work, and Maarten is hopefully going to help me try converting the existing VMs to see if we can save any hassle by doing a conversion. In parallel, I learned a great deal about buildbot and the buildbot system that Dan has built. There are two especially valuable and useful functions provided by this buildbot: the first is essentially a patch watcher; a process that catches simple mistakes (e.g. build errors on different architectures, and so on). The second is more powerful and is encapsulated by the 'dotests.sh' shell script. The dotests.sh script does a good job of basically running make test and noticing any test failures outside of 'the usual ones'. There is an infrastructure for Buildbot is a good tool, and I invested a lot of energy into it (as have Dan and Austin). However, Alexandre has persuaded me that we should first explore integrating the dotest.sh functionality into the existing WineTestBot, as that would allow us to have a very simple clean web page, and would also allow us to integrate most cleanly with Alexandre's back end tools. Of course, WineTestBot is Perl code, and my Perl fu is low. So I have recently asked Francois to help with that effort as well. So the basic plan is as follows: 1. Test qemu/kvm with a few Windows versions to see if it'll work. 2. If so, modify WineTestBot to use qemu instead of vmware. (This is 'easy' because the WineTestBot code nicely isolates the VM functions, but 'hard', because VMWare provides some APIs that may have to be replicated). 3. Migrate WineTestBot to the new hardware stack 4. Write new code to run 'dotests.sh' as part of WineTestBot Cheers, Jeremy

9 11

Fwd: [GSoC Mentors] [Announce] GSoC 2012 Mentors/Org Admins: "Pencils Down" and Final Evaluation Dates Approaching
by Austin English Aug. 6, 2012

Aug. 6, 2012

---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Aug 6, 2012 at 12:33 PM Subject: [GSoC Mentors] [Announce] GSoC 2012 Mentors/Org Admins: "Pencils Down" and Final Evaluation Dates Approaching To: Google Summer of Code Mentors List <google-summer-of-code-mentors-list(a)googlegroups.com> Hi there, This is a friendly reminder that Monday, 13 August is our soft "pencils down" date. We suggest that students have completed their projects by this date and spend a week writing documentation and wrapping up their projects. We require that students stop all coding on 20 August. Monday, 20 August at 19:00 UTC is also when final evaluations open. Please consider this your reminder to submit your final evaluation by 24 August at 19:00 UTC so that you don't delay your students' final payments or possibly jeopardize your organization's attendance at the mentor summit. I have updated the code submission guidelines [0] and posted it on Melange for your reference. Code submission begins once students have received a passing grade on their final evaluations (after 24 August). The deadline is 14 September. One question students ask a lot is what portion of their code to submit if they made changes to an existing code base or their code interacts a lot with a system they didn't write. The answer is: use your best discretion. Have them submit the code that makes the most sense from a user's perspective. If students need help with code submission they should contact the Melange team at melange-soc-dev(a)googlegroups.com. I have posted the questions for the final evaluations below as well for your reference. [0] - http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc20… Cheers, Carol ---------------- How would you rate the student’s performance on his/her project since the midterm evaluations? It has improved since the midterm It has stayed the same since the midterm It has gotten worse since the midterm Considering your student’s original project proposal, how closely does the project produced reflect the project proposed? It’s almost exactly the same - there have been very few changes to the project It’s similar - there have been some changes over the course of the summer It’s different - we changed the goals or scope of the project It’s different - the student diverged from the project plan How much time have you spent on Google Summer of Code since the midterm evaluations (again, take into consideration both time mentoring the student and working on the program as a whole)? 10-15 hours per week 15-20 hours per week 20-25 hours per week 25-30 hours per week 30-35 hours per week 35-40 hours per week 40+ hours per week How does this amount of time spent on the program compare to before the midterms? It’s less than before the midterms It’s about the same It’s more than before the midterms How would you rate your student’s performance overall? Excellent - amongst the best performers I’ve ever worked with Strong, solid performance Okay Poor How would you rate your experience with the program overall? Excellent - one of the best programs I’ve ever participated in Very good Okay Poor Did you have a co-mentor in the program this year? If so, would you consider this a help or a hindrance? Why? What one thing would you tell mentors for your organization to do in the future to help the students’ experience with the program? What was the most rewarding and/or difficult part of the program for you this year? Anything else you’d like to tell us? -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Mentors List" group. To post to this group, send email to google-summer-of-code-mentors-list(a)googlegroups.com. To unsubscribe from this group, send email to google-summer-of-code-mentors-list+unsubscribe(a)googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-summer-of-code-mentors-list?hl=en. -- -Austin

1 0

GSoC mentor summit 2012
by Owen Rudge Aug. 6, 2012

Aug. 6, 2012

It looks like the GSoC mentor summit for 2012 has been announced. Are any of the mentors this year interested in attending? It's happening on the 20th/21st October in Mountain View. Details are on the GSoC mentor wiki: http://gsoc-wiki.osuosl.org/index.php/2012 Cheers, -- Owen Rudge http://www.owenrudge.net/

6 10

Re: [1/4] dwrite: Added IDWriteFont stub
by Dmitry Timoshkov Aug. 5, 2012

Aug. 5, 2012

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static IDWriteFontVtbl dwritefontvtbl = { > + dwritefont_QueryInterface, > + dwritefont_AddRef, > + dwritefont_Release, Vtables should be 'const' (here and in other places). -- Dmitry.

1 0

Re: winex11.drv: xrandr1.2 don't assume CRTC 0 is active
by Henri Verbeet Aug. 1, 2012

Aug. 1, 2012

On 30 July 2012 22:05, <siro(a)das-labor.org> wrote: > As far as I understood CRTC 0 is disabled, because it is only capable of > generating analog video signals. I'm using a HDMI monitor, which is > controlled by CRTC 1. To use multihead (not clone), you have to connect a > analog (VGA) and digital monitor (in my case). Each monitor will use one > CRTC and each CRTC will show a different part of the same screen. With this > in mind every active CRTC should be listed as "native Windows monitor". Mostly for reference, what driver are you using? Have you explicitly configured a primary display at all (either through the xorg.conf "Primary" option for the monitor, or with the xrandr utility), or is it just picking up the first display connector and incorrectly assuming it's connected?

2 2

Wiki seems to be down.
by Scott Ritchie July 31, 2012

July 31, 2012

Thank you :)

1 0