August 2012 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: Web based translation tool
by Michal Čihař June 17, 2013

June 17, 2013

Hi Dne Mon, 12 Mar 2012 12:02:49 +0200 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > The Wine project is thinking about using Weblate in order to translate > Wine, you can look at the following discussion and see for yourself. That sounds great! > Looking good although a litle immature, not sure about authentication as > wel... For authentication you can basically use anything what can be used in Django. Any specific concerns on this topic? > I'll talk to Michal Cihar and ask him for a roadmap for this project. Well I don't have any real roadmap right now. I urgently needed replacement for Pootle because we got hit by too many bugs there and did not manage to understand the code there to be able to fix them myself. So far I think it is in pretty good shape for day to day work (with today's 0.5 release fixing few annoying bugs). Of course there are some features missing, you can check what I plan for 1.0 release here: https://github.com/nijel/weblate/issues?state=open&milestone=1 I currently hope to have 1.0 in a month or so, but I really don't want to commit to any specific date. PS: I'm not subscribed to mailing list so please CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

7 16

Re: xbox 360 emulation with logitech cordless and dinput joy disable
by Stefan Dösinger Jan. 1, 2013

Jan. 1, 2013

Hi, The patch needs a few improvements before it can be accepted into Wine. I can't comment on the dinput / xinput specifics of the patch, so this is a non- exhaustive list of general suggestions. Concerning the big picture, this patch needs a few discussions about xinput.dll design. There have been some discussions about that in the past, and I hope that some dinput devs can help out. Am Dienstag, 12. Juni 2012, 23:48:53 schrieb Giovanni Ongaro: > From: root <root(a)joe.(none)> Please configure git correctly, see http://wiki.winehq.org/GitWine section 3.3. Also consider using a non-root user, but that's your personal setup, so not really my business. > + if (getenv("LINIXFORCENOJOY") != NULL) return FALSE; /*JoeFix disable joystick*/ The problem with dinput vs xinput conflicts should probably be solved in a different manner. That aside, such configurations are usually done via registry keys. Also comments like /* I changed this here */ are useless, the git history stores this information anyway. > + <...> //JoeFix DEAD ZONE This is a C++ comment and not allowed in Wine. See http://wiki.winehq.org/SubmittingPatches > + fdJoy=open("/dev/input/js0",O_RDONLY | O_NONBLOCK); Xinput.dll should not open joystick devices directy, and definitely not a hardcoded one. I don't know if there's consensus about how xinput should be implemented, but basing it on top of dinput might be a start. A good start would be to write a few tests to test how Windows announces(or doesn't announce) Xbox gamepads and other gamepads/joysticks to games. My understanding is that xinput.dll only works for Xbox gamepads. Do those show up in dinput on Windows? > +#define DEAD_ZONE 4096 > ... > + if (e.number == 4) { > + if (e.value == 1) { > + FIXME("TRIGGER LEFT PRESSED\n"); > + pState->Gamepad.bLeftTrigger=32767; > + } > + else { > + pState->Gamepad.bLeftTrigger=0; > + } > ... > +#define JOYMAX 30000 > +#define JOYMIN -30000 The hardcoded numbers look questionable. The 4 and 1 are probably specific to the joystick, the 32767 might have a symbolic name like XINPUT_MAX or something. A part of this seems to be needed due to the attempt to emulate an xbox gamepad with a different device. Personally I'm not opposed to doing that, and you might need some device specific tricks to pull this off. However, this needs a more structured approach than hardcoding the values needed for one specific Logitech device in the code. Best regards, Stefan

3 2

Wine Gecko 1.8-beta1
by Jacek Caban Sept. 4, 2012

Sept. 4, 2012

Hi all, It's time for another Gecko update. I've uploaded to SourceForge [1] new Gecko builds. These are based on Firefox 16 beta. Other than tons of changes inherited from Firefox and usual fixes to keep it working well for us, it brings a few visible fixes: - Proper <noscript> tag handling - Synchronous ActiveX loading - Possibility to properly call APIs requiring JSContext - Possibility to implement HTMLStyleElement::styleSheet property As usually, to test it you need the attached patch and Gecko build placed in the right place [2]. Any help with testing is appreciated! On related note, I seriously consider dropping debug builds and replace them by unstripped release build or even just a separated package containing only debug symbols for the release build. Here are my thoughts about reasoning (in random order): - People use debug build mostly to retrieve better backtraces. Unstripped builds also give that ability. - If someone really needs debug build, it's easy enough to build it himself (and that's usually a good idea anyway) - Debug builds are seriously different than release build, so it occasionally exposes different set of problems, leading to invalid assumptions. This is really something for developers rather than users. - It costs my time spent builds and tests. And I consider it a serious matter. Amount of work needed to keep Gecko relevant is constantly growing. I try to mitigate it by doing long-term improvements upstream, automating the process and improving my hardware, but that has its limits. And the time spent on Gecko maintenance (as in pure maintenance, not real improvements) costs Wine in terms of improvements I could make in this time. If someone has a reason to keep debug builds, let me know. Any comments are welcomed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.8-beta1/ [2] http://wiki.winehq.org/Gecko

3 3

vcomp.dll, vcomp90.dll missing on testbot?
by Dan Kegel Sept. 3, 2012

Sept. 3, 2012

I'm trying to test a better set of stubs for vcomp.dll and its ilk, but those dlls don't seem to be installed on testbot. Is vcomp{,90,100}.dll not installed by default on Windows? If not, should we install it on a few of the VMs?

3 9

Re: [1/16] po: Update Russian translation
by Nikolay Sivov Aug. 31, 2012

Aug. 31, 2012

On 8/24/2012 10:13, Oleg Yarigin wrote: > > > "To install a new program from a floppy disk, CD-ROM drive, or your hard " > "drive, click Install." > msgstr "" > -"Чтобы установить программу с CD-ROM, дискеты или жёсткого диска, нажмите " > -"Установить." > +"Для установки программы с компакт- или жёсткого диска нажмите «Установить»." You only need to fix quotation marks in original string, the variant you proposed doesn't say what English string is saying. > #: appwiz.rc:62 > -msgid "" > -"The following software can be automatically removed. To remove a program or " > -"to modify its installed components, select it from the list and click Modify/" > -"Remove." > -msgstr "" > -"Перечисленные программы можно автоматически удалить. Чтобы удалить программу " > -"или изменить состав установленных компонентов, выберите её в списке и " > +msgid "The following software can be automatically removed. To remove a " > +"program or to modify its installed components, select it from the list and " > +"click Modify/Remove." > +msgstr "Перечисленные программы могут быть удалены. Для удаления " > +"или изменения состава установленных компонентов, выберите их в списке и " > "нажмите кнопку Изменить/Удалить." Again, don't alter original meaning, no reason to remove 'automatically' here. > #: appwiz.rc:76 > msgid "The following information can be used to get technical support for %s:" > -msgstr "" > -"Указанная информация может быть использована для получения технической " > +msgstr "Указанная информация может быть использована для получения технической " > "поддержки приложения %s:" Nothing changed here. > #: appwiz.rc:35 shell32.rc:141 shell32.rc:238 regedit.rc:122 winefile.rc:104 > msgid "Name" > -msgstr "Имя" > +msgstr "Название" That's questionable. If you really want to change that it will need to depend on context I guess. > #: avifil32.rc:33 > msgid "Wine AVI-default-filehandler" > -msgstr "Обработчик по умолчанию avi-файлов в Wine" > +msgstr "Обработчик avi-файлов по умолчанию в Wine" This alters a meaning a bit, now what you did means that there're some default avi-files in Wine.

3 5

Re: kernel32: Return correct drive type for empty drives
by Alexandre Julliard Aug. 31, 2012

Aug. 31, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > Should fix bug #17037 > I followed your advice and now, I only ask the mountmgr when needed. > --- > dlls/kernel32/volume.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) This is failing here when the drive is empty: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so volume.c && touch volume.ok volume.c:132: Tests skipped: can't test removing fake drive volume.c:785: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87 make: *** [volume.ok] Error 1 If I put a DVD in I get: volume.c:813: Test failed: IOCTL_DVD_READ_STRUCTURE should have failed Probably the tests need some fixing. -- Alexandre Julliard julliard(a)winehq.org

4 3

Wine Gecko 1.8-beta1
by Jacek Caban Aug. 31, 2012

Aug. 31, 2012

Hi all, It's time for another Gecko update. I've uploaded to SourceForge [1] new Gecko builds. These are based on Firefox 16 beta. Other than tons of changes inherited from Firefox and usual fixes to keep it working well for us, it brings a few visible fixes: - Proper <noscript> tag handling - Synchronous ActiveX loading - Possibility to properly call APIs requiring JSContext - Possibility to implement HTMLStyleElement::styleSheet property As usually, to test it you need the attached patch and Gecko build placed in the right place [2]. Any help with testing is appreciated! On related note, I seriously consider dropping debug builds and replace them by unstripped release build or even just a separated package containing only debug symbols for the release build. Here are my thoughts about reasoning (in random order): - People use debug build mostly to retrieve better backtraces. Unstripped builds also give that ability. - If someone really needs debug build, it's easy enough to build it himself (and that's usually a good idea anyway) - Debug builds are seriously different than release build, so it occasionally exposes different set of problems, leading to invalid assumptions. This is really something for developers rather than users. - It costs my time spent builds and tests. And I consider it a serious matter. Amount of work needed to keep Gecko relevant is constantly growing. I try to mitigate it by doing long-term improvements upstream, automating the process and improving my hardware, but that has its limits. And the time spent on Gecko maintenance (as in pure maintenance, not real improvements) costs Wine in terms of improvements I could make in this time. If someone has a reason to keep debug builds, let me know. Any comments are welcomed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.8-beta1/ [2] http://wiki.winehq.org/Gecko

1 0

Re: kernel32: Add UTF-7 support. (try 5)
by Alexandre Julliard Aug. 31, 2012

Aug. 31, 2012

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Try 5 adds two tests for the case where srclen < -1 and passes them both. You are still overflowing the source. You need to spend more time on this. You also need to split the patch, and write some sort of table-driven tests so you can test a lot more cases, the ones you have are clearly not sufficient. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Moving pages to/from wiki
by Kyle Auble Aug. 31, 2012

Aug. 31, 2012

Wed, Aug 29, 2012 16:09, André Hentschel wrote: > get the website source and do "grep -Ri cvs *" > then ignore wwn/ and news/ ... > all that should somehow bring you to http://www.winehq.org/cvs or be deleted grep -r "...." * is rapidly becoming a very good friend of mine ;) I just checked http://cvs.winehq.org and sure enough, there is still a very outdated CVS repository there, but I can't find a template or a PHP applet for it, just the same links you found (most in WWN issues). I've CCed Jeremy Newman because I'm guessing the site admin would have to remove it. As for redirecting to http://www.winehq.org/cvs, since that was designed as a notice page for people trying to browse the source code, I was picturing just redirecting the links to http://source.winehq.org/git and deleting http://www.winehq.org/cvs as only WWN issues and news would still have dangling links. I don't want to remove it if there's another reason for keeping it though. - Kyle

5 6

Re: [PATCH 2/5] hhctrl.ocx: Implement HH_SET_WIN_TYPE (try 7).
by Alexandre Julliard Aug. 30, 2012

Aug. 30, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > @@ -1784,11 +1785,25 @@ void ReleaseHelpViewer(HHInfo *info) > OleUninitialize(); > } > > -HHInfo *CreateHelpViewer(LPCWSTR filename, HWND caller) > +static BOOL info_in_list(HHInfo *info) > +{ > + HHInfo *i; > + > + LIST_FOR_EACH_ENTRY(i, &window_list, HHInfo, entry) > + { > + if(i == info) > + return TRUE; > + } > + return FALSE; > +} You should never need that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: Add UTF-7 support. (try 4)
by Alexandre Julliard Aug. 30, 2012

Aug. 30, 2012

Alex Henrie <alexhenrie24(a)gmail.com> writes: > + do > + { > + if (src[source_index] == 0 && srclen == -1) > + { > + if (dry_run) dest_index++; else if (write_to_w_string(dst, dstlen, &dest_index, 0)) return -1; > + /* when srclen=-1, terminate at the first null character found */ > + break; > + } > + else if (src[source_index] == '+') > + { > + WCHAR byte_pair = 0; > + short offset = 0; > + > + source_index++; /* skip the + sign */ > + > + if (src[source_index] == '-') > + { > + /* just a plus sign escaped as +- */ > + if (dry_run) dest_index++; else if (write_to_w_string(dst, dstlen, &dest_index, '+')) return -1; > + source_index++; > + continue; > + } You are not checking properly for the source string length. Also please add tests for such cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Moving pages to/from wiki
by Kyle Auble Aug. 29, 2012

Aug. 29, 2012

I'm starting to work on moving static pages to and from the wiki, but I wanted to ask for opinions on a few changes first: 1. Move all static IRC pages to the wiki or add info from the wiki to the static templates? The static pages only mention #winehq and don't describe guidelines, but IRC details shouldn't change much right? 2. For the static About page, some languages also have wiki versions. Do we want to keep the sparser versions currently in use, or add the more detailed information from the wiki version? Both versions seem well-written, and exist for English, Hebrew, & Spanish (I deleted the Polish wiki version; it was a duplicate). 3. Do we still need the static "cvs" page, or should I just redirect any links to it, then delete? On a related note, the WineHQ ToDo on the wiki still claims that a browser for the old CVS source tree is lurking on the site somewhere. Is that true, or do I need to cut that line from the ToDo list? 4. Since licensing tends to be really static could we just redirect the WikiLicense page to the static license page, or should they be kept separate? While I'd think it wouldn't be too hard to reword the static page's intro to include other projects, I'm leery of editing any legal-ese without asking first. By the way, the WikiLicense page says it's LGPL v2.1 in the intro text, but the included license actually looks like v2.0 of the GPL with a modification for libraries. If the wiki version of the page should stay, I'll put in a copy of v2.1 - Kyle

2 1

Re: [Tools] testbot: Add LICENSE and COPYING.LIB files.
by Henri Verbeet Aug. 29, 2012

Aug. 29, 2012

On 29 August 2012 16:35, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > I think this made total sense when th WineTestBot was in its own > repository. Now maybe the COPYING.LIB and LICENSE files can be > considered to apply to all of the Wine tools and should go to the > top-level directory? > Not all of the code in tools.git is under LGPL 2.1. (And personally I'd argue that GPL 3 is probably more appropriate for most of the things in there anyway.)

2 1

Wine bot results
by Alistair Leslie-Hughes Aug. 29, 2012

Aug. 29, 2012

Hi, I have a patch that when run on on the testbot, it fails on all but two machines. However when I build the exe myself and run it, it pass on all but two machines. http://testbot.winehq.org/JobDetails.pl?Key=21257 http://testbot.winehq.org/JobDetails.pl?Key=21256 Ubuntu 12.04. Any Ideas on the different results? Best Regards Alistair Leslie-Hughes

5 7

Re: d3dx9: ID3DXConstantTable
by Józef Kucia Aug. 29, 2012

Aug. 29, 2012

On Tue, Aug 21, 2012 at 10:52 PM, gurketsky <gurketsky(a)googlemail.com>wrote: > I just like to present the state of the ID3DXConstantTable implementation, > so that possibly no work is done twice. This goes specifically to Józef. > I'm not sure what's the plan on this. There are two problems which arise > and I did not had time to sort those out, yet. > Thanks for notifying me. I was about to write some tests for structures in constant tables. I see that you've already written such tests. Cheers, Józef Kucia

4 8

Re: gdiplus: Make GdipMeasureCharacterRanges/GdipMeasureString/GdipDrawString add extra space around the text. Take 2.
by Vincent Povirk Aug. 28, 2012

Aug. 28, 2012

This looks correct to me. Lack of shared logic and GenericTypographic still makes me sad, but not too sad because the added logic is simple.

1 0

Re: About WineHQ Wiki
by Kyle Auble Aug. 28, 2012

Aug. 28, 2012

Sat, 25 Aug 2012 14:44, Oleg Yarigin wrote: > When I edited pages in the WineHQ Wiki, I notised, its markup lankuage > isn`t so good as MediaWiki`s one. How do you think about moving the Wiki > into MediaWiki engine? Besides, moving each language section of the Wiki > into separated subdomain (like in Wikipedia) would be a good idea too. I've been working a lot on the wiki recently, and I actually brought up something similar in this thread: http://www.winehq.org/pipermail/wine-devel/2012-July/096198.html While I'm busy with other things right now, I wanted to discuss this in more detail in the near future, particularly how it ties into possibly migrating the entire site over to a CMS. The Moinmoin syntax was new to me too, but after using it a little, I don't mind it too much. There are definitely a few missing features and rough edges compared to MediaWiki. However, and this is just my impression, I think MediaWiki has really evolved to fit Wikipedia's needs. I'm not sure how well it integrates (style-wise at least) if you don't run your entire site off of it, and while I haven't actually looked at MediaWiki's code, I've heard that it can be really tricky to setup, maintain, and reprogram. There are some pluggable parsers for Moinmoin, and there may be one that allows MediaWiki syntax. After going through and checking, categorizing, and editing so many pages, I definitely agree with your suggestion that each language be given a domain, instead of one flat namespace. Then maybe just add a single common "translation" menu to the side toolbar? I've come to the opinion that we should probably stick with Moinmoin, and migrate to a new engine other than MediaWiki only if there are strong reasons. What might be best is if we actually got in touch with some of the Moinmoin developers and put in some feature requests. Helping with the wiki's engine is on my list so I'd like to hear some more opinions. -Kyle

5 8

Re: [PATCH 1/5] d3dx9: Add some traces to D3DXLoadSurfaceFromMemory().
by Henri Verbeet Aug. 28, 2012

Aug. 28, 2012

2012/8/28 Rico Schüller <kgbricola(a)web.de>: > + FIXME("Format conversation missing %#x -> %#x\n", src_format, surfdesc.Format); I don't think that's really what we want it to say.

1 0

Re: shell32: Make ShellExecute use native file association databases as fallback path (resend)
by Alexandre Julliard Aug. 28, 2012

Aug. 28, 2012

Erik van Pienbroek <erik(a)vanpienbroek.nl> writes: > +#if defined(HAVE_FORK) && defined(HAVE_WAITPID) > +static UINT_PTR SHELL_try_native_execute ( const char *openCmd, const char *unixName ) > +{ > + UINT_PTR retval = SE_ERR_NOASSOC; > + pid_t cpid; > + struct stat st; > + > + if (stat(openCmd, &st) == -1) > + { > + TRACE("stat() %s failed: %s\n", openCmd, strerror(errno)); > + return retval; > + } > + > + cpid = fork(); > + if (!cpid) > + { > + /* Prevent the situation where the native file association database > + * tries to run wine to execute a program and we trigger this fallback > + * path again and end up in a recursive loop */ > + if (getenv("WINE_INSIDE_SHELLEXECUTE")) > + { > + TRACE("recursive loop detected, not continuing with ShellExecute call\n"); > + exit(EXIT_SUCCESS); > + } > + setenv("WINE_INSIDE_SHELLEXECUTE", "1", 0); > + > + TRACE("running %s %s\n", openCmd, unixName); > + execlp(openCmd, openCmd, unixName, (char*) NULL); > + /* execlp replaces the current process image with a new process image, > + * so no code below here should get executed by the forked child */ > + } else { > + int status; > + waitpid(cpid, &status, 0); > + TRACE("status %x\n", status); > + if(!WEXITSTATUS(status)) > + retval = 33; > + } > + > + return retval; > +} You want spawnvp(), but that sort of thing should probably go in winebrowser or something like that, and be configurable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: Try to get the drive type from the mountmgr first [resend]
by Alexandre Julliard Aug. 28, 2012

Aug. 28, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > Should fix bug #17037 > Now that my patch disappeared from source.winehq.org/patches, I'm resending it. > Before commenting, please read the e-mail I sent in July (winehq.org/pipermail/wine-devel/2012-July/096587.html) The goal here is to avoid a mountmgr round-trip for the common case, calling mountmgr first defeats this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 6/6] Always define WIDL_C_INLINE_WRAPPERS
by Marvin Aug. 28, 2012

Aug. 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21287 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/6] Always define WIDL_C_INLINE_WRAPPERS
by Marvin Aug. 28, 2012

Aug. 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21286 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/6] Always define WIDL_C_INLINE_WRAPPERS
by Marvin Aug. 28, 2012

Aug. 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21285 Your paranoid android. === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: gdiplus: When copying an image do not round pixel positions up.
by Vincent Povirk Aug. 28, 2012

Aug. 28, 2012

I know this looks wrong, but it's there for a reason, and it matches the behavior of the other interpolations. In my tests, the center of a bitmap pixel is at an integral value, meaning that the pixel at (0,0) is a rectangle extending from (-0.5, -0.5) to (0.5, 0.5), and if you enlarge an image you do get out-of-bounds bits on the lower right. I'm pretty sure I also tested GdipDrawImageRect separately and got the same result.

2 7

re: xmllite: Store DTD processing mode in reader
by Dan Kegel Aug. 28, 2012

Aug. 28, 2012

Alexandre Julliard wrote: > Explicit ok() calls are better than hiding them inside a macro. Uh-oh. Want me to get rid of this macro +#define CHECK_RET_ERRNO(ret, ex) \ + do { \ + ok(ret == ex, "ret is %d, expected %d\n", ret, ex); \ + ok(errno == ex, "errno is %d, expected %d\n", errno, ex); \ + } while (0) in http://source.winehq.org/patches/data/89349 ?

2 1

Re: [3/3] gdiplus: Make GdipMeasureCharacterRanges/GdipMeasureString/GdipDrawString add extra space around the text.
by Vincent Povirk Aug. 28, 2012

Aug. 28, 2012

> These APIs use different logic for adding extra space, so at the moment > I don't see how gdip_format_string() can be used to do this in one place, > but if somebody has an idea how to do that - patches are welcome. That is highly unlikely, particularly given that MeasureCharacterRanges is the accepted practice for highlighting parts of a string. You should make sure you do your tests so the size in pixels is the em size of the font, or at least at a consistent size between them, as native may cut into the padding if hinting makes the characters proportionally larger (this is the point of having the padding, but for the record I think it is behavior that we shouldn't try to duplicate). Do you have a visual test program for this? I'd like to see something that draws a string overlayed with the measurements, to confirm that the functions are not consistent on Windows (or, if they are, confirm that they are consistent with your patch). If not, I'll write one and send you the source code. + /* FIXME: GenericTypographic format prevents extra margins */ Since no margins is the current behavior, won't that cause a regression? It should be fairly easy to include that exception. Then again, I think I've heard reports that GenericTypographic doesn't work.

2 10

Re: gdiplus: Use outside color from image attributes for an out of bounds pixel.
by Vincent Povirk Aug. 27, 2012

Aug. 27, 2012

> if (src_pointf.X >= srcx && src_pointf.X < srcx + srcwidth && src_pointf.Y >= srcy && src_pointf.Y < srcy+srcheight) > *dst_color = resample_bitmap_pixel(&src_area, src_data, bitmap->width, bitmap->height, &src_pointf, imageAttributes, interpolation); > else > - *dst_color = 0; > + *dst_color = imageAttributes->outside_color; It's like this for a reason. This isn't out of the bounds of the source image, which is when imageAttributes would apply. This is out of the bounds of the parallelogram we're drawing, and we should be leaving that pixel alone.

1 0

Re: [PATCH 1/2] msvcrt: Detect UTF-8 mode
by Alexandre Julliard Aug. 27, 2012

Aug. 27, 2012

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -1286,6 +1288,17 @@ static int msvcrt_get_flags(const MSVCRT_wchar_t* mode, int *open_flags, int* st > case '+': > case ' ': > break; > + case ',': > + if (!memcmp(mode, encoding_utf8, sizeof(encoding_utf8)) ) > + { > + *open_flags |= MSVCRT__O_U8TEXT; > + *open_flags &= ~(MSVCRT__O_TEXT | MSVCRT__O_BINARY | MSVCRT__O_WTEXT | MSVCRT__O_U16TEXT); > + mode += (sizeof(encoding_utf8)/sizeof(MSVCRT_wchar_t)); > + } > + else > + FIXME("mode %s not supported\n", debugstr_w(mode -1)); Your string parsing needs more work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: xmllite: Store DTD processing mode in reader
by Alexandre Julliard Aug. 27, 2012

Aug. 27, 2012

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -350,34 +353,47 @@ static void test_reader_create(void) > HRESULT hr; > IXmlReader *reader; > IUnknown *input; > + DtdProcessing dtd; > > /* crashes native */ > if (0) > { > pCreateXmlReader(&IID_IXmlReader, NULL, NULL); > - pCreateXmlReader(NULL, (LPVOID*)&reader, NULL); > + pCreateXmlReader(NULL, (void**)&reader, NULL); > } > > - hr = pCreateXmlReader(&IID_IXmlReader, (LPVOID*)&reader, NULL); > - ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); > + hr = pCreateXmlReader(&IID_IXmlReader, (void**)&reader, NULL); > + EXPECT_HR(hr, S_OK); > > test_read_state(reader, XmlReadState_Closed, -1, FALSE); > > + dtd = 2; > + hr = IXmlReader_GetProperty(reader, XmlReaderProperty_DtdProcessing, (LONG_PTR*)&dtd); > + EXPECT_HR(hr, S_OK); > + ok(dtd == DtdProcessing_Prohibit, "got %d\n", dtd); > + > + dtd = 2; > + hr = IXmlReader_SetProperty(reader, XmlReaderProperty_DtdProcessing, dtd); > + EXPECT_HR(hr, E_INVALIDARG); > + > + hr = IXmlReader_SetProperty(reader, XmlReaderProperty_DtdProcessing, -1); > + EXPECT_HR(hr, E_INVALIDARG); > + > /* Null input pointer, releases previous input */ > hr = IXmlReader_SetInput(reader, NULL); > - ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); > + EXPECT_HR(hr, S_OK); Explicit ok() calls are better than hiding them inside a macro. -- Alexandre Julliard julliard(a)winehq.org

1 0

Unused msvcp100 functions?
by Francois Gouget Aug. 27, 2012

Aug. 27, 2012

There are a lot of msvcp100 functions that look like they are unused: * In string.c all of the MSVCP__String_base_*(), MSVCP_basic_string_*(), MSVCP_basic_string_wchar_*() and MSVCP_char_traits_*() functions, basic_string_w?char_replace_helper(). * In locale.c _Locinfo__Locinfo_ctor_bstr(), codecvt_{short,wchar}__Id_func(), collate_{char,short}__Getcat(), various ctype_*() functions, etc. * In ios.c, the basic_istream_*() and basic_ostream_*() functions, ios_base_Index_func() and ios_base_Sync_func(). * In math.c a lot of std_Ctraits_{double,float,long}_*() functions. Is it just that the spec file needs to catch up or that they will be used soon? I attached a more precise list of the suspects. I did not actually verify that all of them are unused but based on the ones I looked at it seems to be the case. If they are indeed unused and will remain so I can submit a patch to remove them. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

2 1

Re: kernel32: Handle neutral locale names better in GetLocaleInfoEx
by Dmitry Timoshkov Aug. 27, 2012

Aug. 27, 2012

Hi, Are you sure that GetLocaleInfo can't handle these cases on its own? -- Dmitry.

2 1

Re: [3/3] gdiplus: get_log_fontW helper requires a valid graphics object.
by Vincent Povirk Aug. 26, 2012

Aug. 26, 2012

> + GdipFree(backup); I think you want GdipDeletePath. This seems very convoluted. Couldn't we just skip the size conversion in get_log_fontW when graphics is NULL? Any cases where the scaling would produce a size other than the em size need to be fixed in GdipAddPathString anyway.

2 2

Re: msxml3: Implement xmldecl-version property for a reader
by Marvin Aug. 26, 2012

Aug. 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21252 Your paranoid android. === W2KPROSP4 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === WXPPROSP3 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W2K3R2SESP2 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === WVISTAADM (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W2K8SE (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PRO (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PROX64 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === TEST64_W7SP1 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PROX64 (64 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 Timeout === TEST64_W7SP1 (64 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 Timeout

1 0

re: msvcr100: Add wmemmove_s and wmemcpy_s
by Dan Kegel Aug. 26, 2012

Aug. 26, 2012

I asked Alexandre what http://source.winehq.org/patches/data/88732 needed before it could be reviewed. He said it needed to adapt to the recent parameter checking changes. I see that when he took my patch http://www.winehq.org/pipermail/wine-patches/attachments/20120728/bea2581d/… and committed it as http://source.winehq.org/git/wine.git/patch/49560458426cf25b6a36bbf9bad35aa… he could remove a few assignments to *MSVCRT__errno() because MSVCRT_CHECK_PMT now does that for you. But msvcr100's wmemmove_s/wmemcpy_s are different; they do not change errno. Tests in my patch confirm this. So changing msvcr100's CHECK_PMT macro to assign to errno doesn't seem appropriate. So, is there still anything that needs changing?

2 2

Re: About WineHQ Wiki
by Kyle Auble Aug. 26, 2012

Aug. 26, 2012

Sorry if my replies come in large batches, I'm subscribed to the mailing list digest. Sun, 26 Aug 2012 10:08, Cheer Xiao wrote: > Hi all, > I'm a MoinMoin contributor, one of MoinMoin's participating students > in this year's Summer of Code. > 2012/8/26 Kyle Auble <randomidman48(a)yahoo.com>: >> Sat, 25 Aug 2012 14:44, Oleg Yarigin wrote: >>> When I edited pages in the WineHQ Wiki, I notised, its markup lankuage >>> isn`t so good as MediaWiki`s one. How do you think about moving the Wiki >>> into MediaWiki engine? Besides, moving each language section of the Wiki >>> into separated subdomain (like in Wikipedia) would be a good idea too. >> There are some pluggable parsers for Moinmoin, and there may be one >> that allows MediaWiki syntax. After going through and checking, >> categorizing, and editing so many pages, I definitely agree with your >> suggestion that each language be given a domain, instead of one flat >> namespace. Then maybe just add a single common "translation" menu to >> the side toolbar? > Indeed there is a MediaWiki parser[1]. > Also, take a look at MoinMoin 2.0[2]. It has multiple markups support > out of the box (including mediawiki of course). You can even mix them > in a single wiki instance - this is not necessarily a good idea, but > it helps when you have to migrate some content from another wiki by > hand. ... > Feature requests are welcome, but be noted that MoinMoin 2.0 is the > current development version (it's not a development "branch" since the > codebase is almost a total rewrite) and quite likely the feature you > want is already there (or a TODO). :) Hello, I'm glad to hear there's already a line of communication. Allowing people to use MediaWiki syntax will probably be a big plus. There have been performance problems, but I noticed both the Ubuntu and Moinmoin wikis are pretty snappy so I'm thinking it's due to a strained server and using an old version of Moinmoin (although the SystemInfo macro seems to be disabled, I ran across version info somewhere, and I think Wine Wiki is running Moinmoin 1.5 or 1.6). I'm not sure if other problems I've noticed have been fixed in v1.8 or 1.9 so I would have to try out those versions before checking against v2.0. One thing I have done is written up some python code to help convert HTML tables to Moinmoin ones. I checked in Moinmoin's script market, but could only find full-blown page converters, and their output was kind of messy. I probably got carried away, but I'll attach it to http://wiki.winehq.org/WineStatus because I'm using it to move WineHQ's static status pages to the wiki. I guess that would make it LGPL so if you want to salvage a few parts from it or have me submit it to your utility marketplace, just let me know. Sun, 26 Aug 2012 16:07, Andre Hentschel wrote: > Further it seems a bit more complicated with Wine, the moinmoin wiki is sponsored by http://lattica.com/ (whatever > sponsored means, didn't find further information) and the code > is not accessable via a wine git repo (maybe it should be in tools.git, website.git or its own). This also leads to the > fact that we still have no new wiki theme years after the > theme change on the website. > Now that we upgraded the Forum engine we (we as in laxdragon xD) could maybe do something about the wiki, it > needs love. > It seems Kyle is doing a good job at the content, but the content is not everything. Thank you for the compliment. I am actually planning on doing more coding soon, but besides ramping up, I though cleaning up the wiki some first would let me see where the different parts of the project are. Applying the theme from the rest of the WineHQ is on both the WikiToDo and my own list (no guarantees about how long I would take though). Sun, 26 Aug 2012 22:46, Cheer Xiao wrote: > And yes, as I noted in a previous post moin2 is *not* production-ready > yet and I don't suggest you jump ship now. :) > What I do strongly suggest, however, is that you upgrade to moin1.9 > first, since 1) there has been many security fixes[1] which are not > backported to old versions, and 2) upgrade to moin2 will only be > supported from moin1.9. Helping to upgrade the wiki is on my list somewhere between finishing a first round of polishing content and trying a couple of patches to Wine itself. Although the maintainer would actually have to deploy it, I could test and work some of the kinks out of the upgrade using a local install. Dimi Paun put a lot of work into setting up the wiki in the first place and is the maintainer at lattica. From the git logs and mail list, it seems like he has been really busy with other things for a while. At times, Jeremy Newman has raised the possibility of moving the wiki to WineHQ: http://www.winehq.org/pipermail/wine-devel/2006-June/048712.html I remember stumbling across another email too, but I can't find it right now. If it's still a possibilty, I think the first step would be somehow setting up datadumps so we could start on the upgrade. If there is already a feature for admins to do that, maybe Dimi could start putting a daily/weekly tarball on WineHQ's FTP site. If it requires a custom patch though, I could look into doing that too. -Kyle

1 0

Re: po: Update German translation
by Julian Rüger Aug. 26, 2012

Aug. 26, 2012

Hi André, war ich zu langsam? ;) Das Komma ist an der Stelle grammatikalisch falsch, glaube ich. "Die verbundenen Controller" sollten auch Plural bleiben. Mein Vorschlag wäre irgendwie so etwas: "Nach dem De-/Aktivieren eines Gerätes wird die Liste der verbundenen Controller bis zum Neustart dieses Applets nicht [mehr] aktualisiert." Viele Grüsse, Julian Am Samstag, den 25.08.2012, 13:40 +0200 schrieb André Hentschel: > "After disabling or enabling a device, the connected joysticks won't be " > "updated here until you restart this applet." >-msgstr "" >+msgstr "Nach dem deaktivieren oder aktivieren eines Gerätes, wird der " >+"verbundene Controller hier bis zum Neustart des Applets nicht mehr " >+"aktualisiert."

1 1

Re: winhttp: disable TLSv1.1/1.2 by default
by Marcus Meissner Aug. 26, 2012

Aug. 26, 2012

On Sun, Aug 26, 2012 at 11:50:15AM +0900, Hiroshi Miura wrote: > > Windows 7 disables TLSv1.1/1.2 by default. > This patch intend to behave same as Windows. Please do not... The newer TLSv1.x fix some shortcomings of the older TLS versions. Is there a specific problem you see? Otherwise, I object. Ciao, MArcus > Signed-off-by: Hiroshi Miura <miurahr(a)linux.com> > --- > dlls/winhttp/net.c | 74 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > > > > diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c > index 5ec4e1a..03cf9b7 100644 > --- a/dlls/winhttp/net.c > +++ b/dlls/winhttp/net.c > @@ -52,6 +52,7 @@ > #include "winbase.h" > #include "winhttp.h" > #include "wincrypt.h" > +#include "winreg.h" > > #include "winhttp_private.h" > > @@ -109,8 +110,10 @@ MAKE_FUNCPTR( SSL_load_error_strings ); > MAKE_FUNCPTR( SSLv23_method ); > MAKE_FUNCPTR( SSL_CTX_free ); > MAKE_FUNCPTR( SSL_CTX_new ); > +MAKE_FUNCPTR( SSL_CTX_ctrl ); > MAKE_FUNCPTR( SSL_new ); > MAKE_FUNCPTR( SSL_free ); > +MAKE_FUNCPTR( SSL_ctrl ); > MAKE_FUNCPTR( SSL_set_fd ); > MAKE_FUNCPTR( SSL_connect ); > MAKE_FUNCPTR( SSL_shutdown ); > @@ -408,12 +411,66 @@ static int netconn_secure_verify( int preverify_ok, X509_STORE_CTX *ctx ) > } > return ret; > } > + > +static long get_tls_option(void) { > + long tls_option; > + DWORD type, val, size; > + HKEY hkey,tls12_client,tls11_client; > + LONG res; > + const WCHAR Schannel_Prot[] = { /* SYSTEM\\CurrentControlSet\\Control\\SecurityProviders\\SCANNEL\\Protocols */ > + 'S','Y','S','T','E','M','\\', > + 'C','u','r','r','e','n','t','C','o','n','t','r','o','l','S','e','t','\\', > + 'C','o','n','t','r','o','l','\\', > + 'S','e','c','u','r','i','t','y','P','r','o','v','i','d','e','r','s','\\', > + 'S','C','H','A','N','N','E','L','\\', > + 'P','r','o','t','o','c','o','l','s',0 }; > + const WCHAR TLS12_Client[] = {'T','L','S',' ','1','.','2','\\','C','l','i','e','n','t',0}; > + const WCHAR TLS11_Client[] = {'T','L','S',' ','1','.','1','\\','C','l','i','e','n','t',0}; > + const WCHAR DisabledByDefault[] = {'D','i','s','a','b','l','e','d','B','y','D','e','f','a','u','l','t',0}; > + > + tls_option = SSL_OP_NO_SSLv2; /* disable SSLv2 for security reason, and secur32/Schannel(GnuTLS) don't support it */ > + res = RegOpenKeyExW(HKEY_LOCAL_MACHINE, > + Schannel_Prot, > + 0, KEY_READ, &hkey); > + if (res != ERROR_SUCCESS) { > + tls_option |= SSL_OP_NO_TLSv1_2; > + tls_option |= SSL_OP_NO_TLSv1_1; > + goto end; > + } > + if (RegOpenKeyExW(hkey, TLS12_Client, 0, KEY_READ, &tls12_client) == ERROR_SUCCESS) { > + size = sizeof(DWORD); > + if (RegQueryValueExW(tls12_client, DisabledByDefault, NULL, &type, (LPBYTE) &val, &size) || type != REG_DWORD) { > + tls_option |= SSL_OP_NO_TLSv1_2; > + } else { > + tls_option |= val?SSL_OP_NO_TLSv1_2:0; > + } > + RegCloseKey(tls12_client); > + } else { > + tls_option |= SSL_OP_NO_TLSv1_2; > + } > + if (RegOpenKeyExW(hkey, TLS11_Client, 0, KEY_READ, &tls11_client) == ERROR_SUCCESS) { > + size = sizeof(DWORD); > + if (RegQueryValueExW(tls11_client, DisabledByDefault, NULL, &type, (LPBYTE) &val, &size) || type != REG_DWORD) { > + tls_option |= SSL_OP_NO_TLSv1_1; > + } else { > + tls_option |= val?SSL_OP_NO_TLSv1_1:0; > + } > + RegCloseKey(tls11_client); > + } else { > + tls_option |= SSL_OP_NO_TLSv1_1; > + } > + RegCloseKey(hkey); > + > +end: > + return tls_option; > +} > #endif > > BOOL netconn_init( netconn_t *conn, BOOL secure ) > { > #if defined(SONAME_LIBSSL) && defined(SONAME_LIBCRYPTO) > int i; > + long tls_option; > #endif > > conn->socket = -1; > @@ -453,8 +510,10 @@ BOOL netconn_init( netconn_t *conn, BOOL secure ) > LOAD_FUNCPTR( SSLv23_method ); > LOAD_FUNCPTR( SSL_CTX_free ); > LOAD_FUNCPTR( SSL_CTX_new ); > + LOAD_FUNCPTR (SSL_CTX_ctrl); > LOAD_FUNCPTR( SSL_new ); > LOAD_FUNCPTR( SSL_free ); > + LOAD_FUNCPTR( SSL_ctrl ); > LOAD_FUNCPTR( SSL_set_fd ); > LOAD_FUNCPTR( SSL_connect ); > LOAD_FUNCPTR( SSL_shutdown ); > @@ -494,11 +553,20 @@ BOOL netconn_init( netconn_t *conn, BOOL secure ) > LOAD_FUNCPTR( sk_num ); > #undef LOAD_FUNCPTR > > +#define pSSL_CTX_set_options(ctx,op) \ > + pSSL_CTX_ctrl((ctx),SSL_CTRL_OPTIONS,(op),NULL) > +#define pSSL_set_options(ssl,op) \ > + pSSL_ctrl((ssl),SSL_CTRL_OPTIONS,(op),NULL) > + > pSSL_library_init(); > pSSL_load_error_strings(); > > method = pSSLv23_method(); > ctx = pSSL_CTX_new( method ); > + > + tls_option = get_tls_option(); > + pSSL_CTX_set_options(ctx, tls_option); > + > if (!pSSL_CTX_set_default_verify_paths( ctx )) > { > ERR("SSL_CTX_set_default_verify_paths failed: %s\n", pERR_error_string( pERR_get_error(), 0 )); > @@ -676,12 +744,18 @@ BOOL netconn_connect( netconn_t *conn, const struct sockaddr *sockaddr, unsigned > BOOL netconn_secure_connect( netconn_t *conn, WCHAR *hostname ) > { > #ifdef SONAME_LIBSSL > + long tls_option; > + > if (!(conn->ssl_conn = pSSL_new( ctx ))) > { > ERR("SSL_new failed: %s\n", pERR_error_string( pERR_get_error(), 0 )); > set_last_error( ERROR_OUTOFMEMORY ); > goto fail; > } > + > + tls_option = get_tls_option(); > + pSSL_set_options(conn->ssl_conn, tls_option); > + > if (!pSSL_set_ex_data( conn->ssl_conn, hostname_idx, hostname )) > { > ERR("SSL_set_ex_data failed: %s\n", pERR_error_string( pERR_get_error(), 0 )); > > >

1 0

Question about some Linux integration
by Oleg Yarigin Aug. 25, 2012

Aug. 25, 2012

Hi! I have an idea to move some Wine parts into Linux subsystems. For instance, Wine apps windows and window content can be drawn with Desktop Manager via USER32.DLL opposite of using Wine Server. Similar thing can be with clipboard. I understand, it`s a big work, what is must to be started with an EXE loader. So I have a few questions before I can start: 1. Does Wine loader have any mechanism for loading .so files. 2. May I move all loader stuff from NTDLL to the loader. Is it rational? I asked, becouse there are a lot of stuff, that can be unloaded after program loading. And an off-top question: where is wine_server_call realisation defined? --- Oleg

2 2

About WineHQ Wiki
by Oleg Yarigin Aug. 25, 2012

Aug. 25, 2012

Hi to all! When I edited pages in the WineHQ Wiki, I notised, its markup lankuage isn`t so good as MediaWiki`s one. How do you think about moving the Wiki into MediaWiki engine? Besides, moving each language section of the Wiki into separated subdomain (like in Wikipedia) would be a good idea too. --- Oleg

1 0

Re: [1/16] po: Update Russian translation
by Dmitry Timoshkov Aug. 24, 2012

Aug. 24, 2012

These new translations look at least questionable to say the least. -- Dmitry.

2 1

Re: advapi32/tests: Skip a couple of registry tests on NT4 to avoid crashing it.
by Alexandre Julliard Aug. 24, 2012

Aug. 24, 2012

Francois Gouget <fgouget(a)free.fr> writes: > I know it's bad form to test for the Windows version but I'm not sure > what other check would be relevant here. I think we can safely ignore such old versions at this point. -- Alexandre Julliard julliard(a)winehq.org

1 0

configure --with-osmesa fails to link
by Peter Urbanec Aug. 24, 2012

Aug. 24, 2012

I just turned on --with-osmesa and configure fails for me: > checking for -lOSMesa... not found > configure: error: libOSMesa development files not found (or too old), > OpenGL rendering in bitmaps won't be supported. > This is an error since --with-osmesa was requested config.log output would suggest that perhaps the test is being treated as C code, but libOSMesa needs to link with C++ libs. > configure:9067: checking for -lOSMesa > configure:9092: gcc -o conftest -g3 -feliminate-unused-debug-symbols > -O0 -mtune=core2 conftest.c -lOSMesa -lSM -lICE -lXext -lX11 > -lm >&5 > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator delete[](void*)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator new(unsigned long)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_get_proc_address' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator delete(void*)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_get_dispatch_table_size' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator new[](unsigned long)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `__cxa_pure_virtual' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `__gxx_personality_v0' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_get_context' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `vtable for __cxxabiv1::__vmi_class_type_info' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `vtable for __cxxabiv1::__class_type_info' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_add_dispatch' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_check_multithread' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_tls_Context' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_set_context' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `vtable for __cxxabiv1::__si_class_type_info' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_set_dispatch' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_tls_Dispatch' > collect2: ld returned 1 exit status This is on Gentoo x64 with: media-libs/mesa-8.1_rc1_pre20120814 (classic egl g3dvl gallium llvm nptl osmesa shared-glapi vdpau xvmc -bindist -d3d -debug -gbm -gles1 -gles2 -kernel_FreeBSD -openvg -pax_kernel -pic -r600-llvm-compiler -selinux -video_cards_i915 -video_cards_i965 -video_cards_intel -video_cards_nouveau -video_cards_r100 -video_cards_r200 -video_cards_r300 -video_cards_r600 -video_cards_radeon -video_cards_radeonsi -video_cards_vmware -wayland -xa -xorg) sys-devel/gcc-4.6.3 (cxx fortran graphite mudflap multilib nls nptl openmp -altivec -bootstrap -build -doc -fixed-point -gcj -go -gtk -hardened -libssp -multislot -nocxx -nopie -nossp -objc -objc++ -objc-gc -test -vanilla) Any suggestions as to how this could be fixed? My autoconf skills are no match for this problem :-( Thanks.

3 3

Re: quartz/tests: Use proper method macros
by Marvin Aug. 24, 2012

Aug. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21196 Your paranoid android. === WNT4WSSP6 (32 bit memallocator) === memallocator.c:34: Test failed: Unable to create memory allocator 80040154

1 0

Re: wshom.ocx/tests: Use proper method macro
by Marvin Aug. 24, 2012

Aug. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21198 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [2/16] po: Update Russian translation
by Nikolay Sivov Aug. 24, 2012

Aug. 24, 2012

On 8/24/2012 10:14, Oleg Yarigin wrote: > #: comctl32.rc:88 > msgid "&Add ->" > -msgstr "&Добавить ->" > +msgstr "&Добавить →" > #: comctl32.rc:89 > msgid "<- &Remove" > -msgstr "<- &Удалить" > +msgstr "← &Удалить" I don't think so. > #: comdlg32.rc:157 comdlg32.rc:179 > msgid "&Directories:" > -msgstr "&Каталоги:" > +msgstr "&Папки:" New translation is traditionally used for 'folders' mostly. I agree there's a mess in directory/folder/catalogue here though. > #: comdlg32.rc:223 > msgid "[none]" > -msgstr "[нет]" > +msgstr "(нет)" Why? > #: comdlg32.rc:282 > msgid "&Red:" > -msgstr "Крас&н:" > +msgstr "Крас&ный:" The reason was it doesn't fit a dialog template otherwise, did you check that? > #: comdlg32.rc:52 > msgid "Unreadable Entry" > -msgstr "Нечитаемый элемент" > +msgstr "Нераспознаваемый элемент" You translated 'unrecognised' instead of 'unreadable'. > #: comdlg32.rc:65 > msgid "Cannot find the printer." > -msgstr "Не удалось найти принтер." > +msgstr "Принтер не найден." However I like this kind of changes, it's a good example of keeping it short while it means the same. > #: comdlg32.rc:91 > msgid "Output tray is full; " > -msgstr "Лоток переполнен бумагой; " > +msgstr "Лоток для бумаги переполнен; " Could be "Лоток полон;" ... I can't comment on the rest of this series but there's a lot to fix already.

1 0

Re: oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY
by Marvin Aug. 24, 2012

Aug. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21195 Your paranoid android. === WNT4WSSP6 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === WXPPROSP3 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === WVISTAADM (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W2K8SE (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PRO (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PROX64 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === TEST64_W7SP1 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PROX64 (64 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === TEST64_W7SP1 (64 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v

1 0

Re: oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY
by Dmitry Timoshkov Aug. 24, 2012

Aug. 24, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Changelog: > oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY Please resend the test separately, your fix conflicts with the patch sent by Roman Dadkov. -- Dmitry.

1 0

Re: dssenh/tests: Added key exchange tests for the DSSENH cryptographic service provider
by Marvin Aug. 23, 2012

Aug. 23, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21186 Your paranoid android. === TEST64_W7SP1 (32 bit dssenh) === dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008 dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008 dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008

1 0

Have there been any problems with Wine on GCC 4.7?
by Scott Ritchie Aug. 23, 2012

Aug. 23, 2012

Wine is the last remaining package still depending on GCC 4.5 in the current Ubuntu alpha, it would be nice to drop GCC 4.5 and forward port Wine, however 4.6 is known to not work too well. But now we have 4.7 -- have there been any bugs attributed to its usage? Thanks, Scott Ritchie

4 15

Re: hhctrl.ocx: Make MergeChmProperties() static.
by Erich E. Hoover Aug. 23, 2012

Aug. 23, 2012

I'm going to need MergeChmProperties() for HH_SET_WIN_TYPE. I've just been really busy lately and have not had a chance to cleanup my patches yet (from discussions with Jacek it looks like we need to redo storing HH_WINTYPE data a little bit). Erich

1 0

Re: [PATCH 1/3] dinput: Disable linuxinput or linux joysticks based on registry key (try 2)
by Alexandre Julliard Aug. 23, 2012

Aug. 23, 2012

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > In the form of "controllername(drivername)"="disabled" key > > Examples: > Disable the linux js driver for "Usb Controller" device > "Usb Controller(js)"="disabled" > > Disable the linux js and event drivers for "Other Controller" device > "OtherController(event)"="disabled" > "OtherController(js)"="disabled" That's better, thanks. You probably want to put them under a subkey though, to avoid mixing up the joystick names with the other configuration values. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/3] joy.cpl: Using joystick name suffixed with driver when in Linux (try 2)
by Alexandre Julliard Aug. 23, 2012

Aug. 23, 2012

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > @@ -57,6 +57,34 @@ BOOL WINAPI DllMain(HINSTANCE hdll, DWORD reason, LPVOID reserved) > return TRUE; > } > > +static void get_joystick_name(struct Joystick *joy) > +{ > + /* Base product guids as Wine defines them in DirectInput */ > + /* 9e573ed9-7734-11d2-8d4a-23903fb6bdf7 */ > + static const GUID linux_guid = { 0x9e573ed9, 0x7734, 0x11d2, {0x8d, 0x4a, 0x23, 0x90, 0x3f, 0xb6, 0xbd, 0xf7} }; > + /* 9e573eda-7734-11d2-8d4a-23903fb6bdf7 */ > + static const GUID linuxinput_guid = { 0x9e573eda, 0x7734, 0x11d2, {0x8d, 0x4a, 0x23, 0x90, 0x3f, 0xb6, 0xbd, 0xf7} }; > + static REFGUID wine_guids[] = { &linux_guid, &linuxinput_guid }; > + static const WCHAR wine_device_names[2][9] = { {'(','j','s',')','\0'}, {'(','e','v','e','n','t',')','\0'} }; I think dinput should be appending that to the returned name, joy.cpl shouldn't have to know about the specific naming scheme of the driver. -- Alexandre Julliard julliard(a)winehq.org

2 1

Testing Gdi+
by Stepa Nick Aug. 23, 2012

Aug. 23, 2012

Hi! I`m new in WINE development. I have some tests cases, that works incorrect in current version of WINE and I want to fix this mistakes. So, I`m interesting are there some testing systems that compares bitmap(for example)? I look thru WINE tests, http://www.winehq.org/docs/winedev-guide/testing and had found only tests, that compare some variables to constant. I think, that WINE needs graphics test. Thanks.

2 1

Re: wine/server: removed obsolete one-iteration loop from request forming macro (try 2)
by Marcus Meissner Aug. 23, 2012

Aug. 23, 2012

On Thu, Aug 23, 2012 at 11:14:23AM +0400, Oleg Yarigin wrote: > An original message was sent with wrong author`s name by mistake, so > I resend this patch with hope it was the only reason to reject it. It was not the only reason. A single loop is a common pattern in C to allow safe encapsulation and handling of blocks, or doing "break;"/"continue;" style things. One thing that it allows here in Wine is that the variable definitions are at the begin of a { } block and not in the middle of the code to allow old C standard builds to work still. There is no "break;" usage, although I spotted 1 "goto done;" which could be just a break; ;) The compiler will optimize everything of those loops away, so this change also brings no performance improvement. Ciao, Marcus > --- > include/wine/server.h | 22 +++++++++------------- > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/include/wine/server.h b/include/wine/server.h > index d573d1f..dcbc7fa 100644 > --- a/include/wine/server.h > +++ b/include/wine/server.h > @@ -124,19 +124,15 @@ static inline void *wine_server_get_ptr( client_ptr_t ptr ) > /* macros for server requests */ > > #define SERVER_START_REQ(type) \ > - do { \ > - struct __server_request_info __req; \ > - struct type##_request * const req = &__req.u.req.type##_request; \ > - const struct type##_reply * const reply = &__req.u.reply.type##_reply; \ > - memset( &__req.u.req, 0, sizeof(__req.u.req) ); \ > - __req.u.req.request_header.req = REQ_##type; \ > - __req.data_count = 0; \ > - (void)reply; \ > - do > - > -#define SERVER_END_REQ \ > - while(0); \ > - } while(0) > + struct __server_request_info __req; \ > + struct type##_request * const req = &__req.u.req.type##_request; \ > + const struct type##_reply * const reply = &__req.u.reply.type##_reply; \ > + memset( &__req.u.req, 0, sizeof(__req.u.req) ); \ > + __req.u.req.request_header.req = REQ_##type; \ > + __req.data_count = 0; \ > + (void)reply; > + > +#define SERVER_END_REQ > > > #endif /* __WINE_WINE_SERVER_H */ > -- 1.7.9.5 > > -- Open Linux Security Engineer Position at SUSE: http://bit.ly/Li4RbS

1 0

Re: configure.ac: provide a --disable-dwarf2 configure option
by Alexandre Julliard Aug. 22, 2012

Aug. 22, 2012

Austin English <austinenglish(a)gmail.com> writes: > This should address the concerns from > http://bugs.winehq.org/show_bug.cgi?id=31501 I don't think that justifies adding a configure option, people shouldn't have to worry about that kind of detail. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wine/server: removed obsolete one-iteration loop from request forming macro
by Sergey Guralnik Aug. 22, 2012

Aug. 22, 2012

On 2012-08-22 6:26, Архад wrote: > #define SERVER_START_REQ(type) \ > - do { \ > - struct __server_request_info __req; \ ... > - (void)reply; \ > - do > - > -#define SERVER_END_REQ \ > - while(0); \ > - } while(0) > + struct __server_request_info __req; \ ... > + (void)reply; > + > +#define SERVER_END_REQ Are you try at least to rebuild project with it? -- Sergey

1 0

Re: opengl32/test: do not pass NULL attrib list to wglCreatePBufferARB
by Marvin Aug. 22, 2012

Aug. 22, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21127 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/3] gdiplus: GdipMeasureCharacterRanges should respect device units and transformations.
by Vincent Povirk Aug. 22, 2012

Aug. 22, 2012

> GetTextExtentExPointW(hdc, string + index, range_start - index, > INT_MAX, NULL, NULL, &range_size); > - range_rect.X = bounds->X + range_size.cx; > + range_rect.X = bounds->X / args->rel_width + range_size.cx; > > GetTextExtentExPointW(hdc, string + index, range_end - index, > INT_MAX, NULL, NULL, &range_size); > - range_rect.Width = (bounds->X + range_size.cx) - range_rect.X; > + range_rect.Width = (bounds->X / args->rel_width + range_size.cx) - range_rect.X; Shouldn't you be scaling range_size.cx as well?

2 3

Re: user32: Don't limit time needed for WM_DDE_INITIATE processing.
by Alexandre Julliard Aug. 21, 2012

Aug. 21, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > Current timeout is too small for Microsoft Office 2010 in some cases. > I've checked that DdeConnect succeeds on windows when it needs to wait > for 10 minutes. Are you sure that you want to remove the SMTO_ABORTIFHUNG flag? Does a hung process really prevent all DDE connections? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] dinput: Disable linuxinput or linux joysticks based on registry key
by Alexandre Julliard Aug. 21, 2012

Aug. 21, 2012

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > In the form of "Disable Controllername"="driver" > > Examples: > Disable "Usb Controller"="js" disable linux js driver > Disable "OtherController"="event,js" disable linux js and event drivers That's a fairly complicated way to disable a given joystick. What you probably want is to give them a unique name and have a enable/disable value for each name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mountmgr.sys: For loop-mounted devices, use the backing file
by Alexandre Julliard Aug. 21, 2012

Aug. 21, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > As part of their copy protection, some games use some ioctl's to check some physical attributes. > Unfortunately, when using the loop device, some ioctl fail (like IOCTL_SCSI_GET_ADDRESS). > A simple fix is to use /path/to/the/file.ISO instead of /dev/loopX. Several places depend on this being a device. Besides, failing to get the SCSI address of a loop mount seems like correct behavior to me. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH] kernel32: add basic conditional variables support (try 2)
by Alexandre Julliard Aug. 21, 2012

Aug. 21, 2012

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > Started with patch from Austin, brought up to a point > where Adobe Lightroom 4.1 starts up. > > The synchronisation is probably not 100% correct and > not sufficiently atomic. Synchronization routines have to be 100% correct, half stubs are worse than no implementation at all. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] wined3d: Improve post-pixelshader blending test. (Try 2)
by Lucas Zawacki Aug. 20, 2012

Aug. 20, 2012

Hello, this patch caused a regression with Rayman 2, all the text in the menus is rendered wrong now. Should I open a bug or is this email enough? A demo of the game can be downloaded here ftp://ftp.ubisoft.com/Rayman2/rayman2high.zip Screenshot: http://dl.dropbox.com/u/2701879/images/rayman2.png Regression test: a488e574497d674631b4036d4b179ce349ddb764 is the first bad commit commit a488e574497d674631b4036d4b179ce349ddb764 Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Wed Aug 15 00:38:26 2012 +0200 wined3d: Improve post-pixelshader blending test. :040000 040000 1a61c91a146de3e7a5206ccde1cc239fa0771e40 a9759ba603b3b52f2feccc716daff3d875a90b74 M dlls

2 1

Re: [6/7] d3dx9: Implement ID3DXConstantTable::SetMatrixPointerArray.
by Rico Schüller Aug. 20, 2012

Aug. 20, 2012

On 20.08.2012 17:10, Józef Kucia wrote: > + if (desc.Class == D3DXPC_MATRIX_ROWS || desc.Class == D3DXPC_MATRIX_COLUMNS) > + { ... > + } > + else if (desc.Class == D3DXPC_SCALAR) Could you also set D3DXPC_VECTOR variables with this call? It should be easy to add a test for a scalar and a vector. But that may also be a separate patch. In general I think it would be fine to try to set all variable class and see which work / fail. That way you would also verify, that the non common way works too, which has no test, yet, but a implementation. This holds true for all the Set(Matrix/Vector/...) functions. That way you'd ensure that the setting is correct for the specific class. ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "c2x3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "r2x3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "vec3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "scalar", matrix_pointer, 1); Cheers Rico

1 0

Re: [3/7] d3dx9: ID3DXConstantTable::SetFloat shouldn't change the value of matrix and vector constants.
by Rico Schüller Aug. 20, 2012

Aug. 20, 2012

On 20.08.2012 17:10, Józef Kucia wrote: > @@ -665,6 +666,31 @@ static void test_setting_basic_table(IDirect3DDevice9 *device) > out[8], out[9], out[10], out[11], > out[12], out[13], out[14], out[15]); > > + ID3DXConstantTable_SetFloat(ctable, device, "mvp", f); > + ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable mvp: 0x%08x\n", res); You probably may save res (= ID3DXConstantTable_SetFloat) before checking it. Otherwise you are checking the same res value multiple times. > + ID3DXConstantTable_SetFloat(ctable, device, "f4", f); > + ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable f4: 0x%08x\n", res); Cheers Rico

1 0

Re: [PATCH 1/2] oleaut32: Ensure that the right interface is passed to the callee in ITypeInfo::Invoke
by Alexandre Julliard Aug. 20, 2012

Aug. 20, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -6509,6 +6510,38 @@ static HRESULT WINAPI ITypeInfo_fnInvoke( > { > prgpvarg[i] = src_arg; > } > + > + if((tdesc->vt == VT_USERDEFINED || (tdesc->vt == VT_PTR && tdesc->u.lptdesc->vt == VT_USERDEFINED)) > + && (V_VT(prgpvarg[i]) == VT_DISPATCH || V_VT(prgpvarg[i]) == VT_UNKNOWN)) { > + const TYPEDESC *userdefined_tdesc = tdesc; > + IUnknown *userdefined_iface; > + ITypeInfo *tinfo2; > + TYPEATTR *tattr; > + > + if(tdesc->vt == VT_PTR) > + userdefined_tdesc = tdesc->u.lptdesc; typelib.c: In function ‘ITypeInfo_fnInvoke’: typelib.c:6516:41: error: variable ‘userdefined_tdesc’ set but not used [-Werror=unused-but-set-variable] make[1]: *** [typelib.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Microsecond unit
by Francois Gouget Aug. 20, 2012

Aug. 20, 2012

The microsecond unit is 'µs' and yet, in dlls/sane.ds/sane.rc, we define it as 'us' and then rely on the British and American English PO files to convert it to 'µs'. Why not put the right unit directly in the RC file? It's UTF-8 anyway... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

2 1

Re: kernel32: Add UTF-7 support. (try 4)
by Alex Henrie Aug. 20, 2012

Aug. 20, 2012

Correction: I meant to write that try 4 exits the loop slightly faster when ending a base64 sequence, it has nothing to do with escaped plus signs which are handled a few lines earlier. -Alex

1 0

Re: [6/7] gdiplus: Add a test for extra space added by GdipMeasureString. Resend.
by Marvin Aug. 19, 2012

Aug. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21046 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msctf: Call interface methods properly
by Marvin Aug. 19, 2012

Aug. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21043 Your paranoid android. === TEST64_W7SP1 (32 bit inputprocessor) === inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink

1 0

How to convert msvcp names to legible names?
by Bruno Jesus Aug. 19, 2012

Aug. 19, 2012

Which is the roseta stone used to read all msvcp function names like "msvcp80.dll.??0?$basic_stringstream(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QAE(a)H@Z, aborting" as the real function name in source code? Thanks in advance, Bruno

3 2

Re: winedbg: Use standard fixed pitch UI font for the crash dialog.
by Dmitry Timoshkov Aug. 17, 2012

Aug. 17, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > static void set_fixed_font( HWND dlg, UINT id ) > { > - HFONT hfont = (HFONT)SendDlgItemMessageW( dlg, id, WM_GETFONT, 0, 0); > - LOGFONTW font; > + HFONT hfont; > > - GetObjectW(hfont, sizeof(LOGFONTW), &font); > - font.lfPitchAndFamily = FIXED_PITCH; > - font.lfFaceName[0] = 0; > - hfont = CreateFontIndirectW(&font); > + hfont = GetStockObject( ANSI_FIXED_FONT ); > SendDlgItemMessageW( dlg, id, WM_SETFONT, (WPARAM)hfont, TRUE ); > } To clarify things a bit: current code uses empty font face name, and GDI uses "System" font in that case (regardless of requested FIXED_PITCH), which is absolutely not readable. ANSI_FIXED_FONT should use built-in "Courier", which is actually a FIXED_PITCH font and much more readable. -- Dmitry.

2 3

Re: [10/10] gdiplus: Filter tabs out until they are properly supported using stringformat.
by Vincent Povirk Aug. 17, 2012

Aug. 17, 2012

This should probably be handled somehow by gdip_format_string. DrawDriverString doesn't have access to the StringFormat, and there's a good change that the native implementation really does draw tabs as squares. Also, MeasureCharacterRanges and MeasureString will have to account for tabstops. gdip_format_string already has logic to ignore certain characters, but it needs more thought as to how we can do that and keep the offsets passed to the callback accurate, and how to eventually pass information about tabs to the callback. If this does turn out to be a correct change for DrawDriverString (I predict that it is not), then MeasureDriverString should be updated as well.

2 1

Re: [08/10] gdiplus: GdipMeasureString/GdipDrawString should add extra space around the text.
by Vincent Povirk Aug. 17, 2012

Aug. 17, 2012

Why can't this logic go in gdip_format_string?

2 6

Re: Re: DSSENH/tests: Added block cipher mode tests for the DSSENH cryptographic service provider (try2)
by Marvin Aug. 17, 2012

Aug. 17, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20983 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [02/10] gdiplus: If source and destination rectangles differ it's not a reason to fallback to software blitting.
by Vincent Povirk Aug. 17, 2012

Aug. 17, 2012

> Both StretchBlt and GdiAlphaBlend handle that case just fine. Only if the graphics interpolation mode happens to be nearest neighbor, which isn't the default.

2 3

Re: DSSENH/tests: Added block cipher mode tests for the DSSENH cryptographic service provider
by Marvin Aug. 16, 2012

Aug. 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20977 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/3] riched20: Added support for UTF8 BOM stream. (Try 2)
by Alexandre Julliard Aug. 16, 2012

Aug. 16, 2012

Qian Hong <fracting(a)gmail.com> writes: > @@ -304,8 +307,19 @@ static LRESULT ME_StreamInText(ME_TextEditor *editor, DWORD dwFormat, ME_InStrea > > if (!(dwFormat & SF_UNICODE)) > { > - /* FIXME? this is doomed to fail on true MBCS like UTF-8, luckily they're unlikely to be used as CP_ACP */ > - nWideChars = MultiByteToWideChar(CP_ACP, 0, stream->buffer, stream->dwSize, wszText, STREAMIN_BUFFER_SIZE); > + if (!is_read) > + { > + is_read = TRUE; > + if (stream->dwSize >= 3 && !memcmp(stream->buffer, bom_utf8, 3)) > + { > + cp = CP_UTF8; > + stream->dwSize -= 3; > + memmove(stream->buffer, stream->buffer + 3, stream->dwSize); There's no reason to move the data. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/2] comctl32: Correct values passed in MCN_SELECT/MCN_SELCHANGE notifications.
by Nikolay Sivov Aug. 16, 2012

Aug. 16, 2012

On Thu, Aug 16, 2012 at 5:20 PM, Sergey Guralnik <serhio(a)etersoft.ru> wrote: > > -- > Sergey > > > You can use simple assignment with st_null instead of that: + memset(&nmsc.stSelEnd, 0, sizeof nmsc.stSelEnd);

1 0

Re: [PATCH 2/2] comctl32: Correct values passed in MCN_SELECT/MCN_SELCHANGE notifications.
by Marvin Aug. 16, 2012

Aug. 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20934 Your paranoid android. === WNT4WSSP6 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2KPROSP4 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WXPPROSP3 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K3R2SESP2 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WVISTAADM (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K8SE (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PRO (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead

1 0

Re: [PATCH 2/2] comctl32: Correct values passed in MCN_SELECT/MCN_SELCHANGE notifications.
by Marvin Aug. 16, 2012

Aug. 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20934 Your paranoid android. === WNT4WSSP6 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2KPROSP4 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WXPPROSP3 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K3R2SESP2 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WVISTAADM (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K8SE (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PRO (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead

1 0

Re: [PATCH 1/2] comctl32/tests: Add test for MCN_SELECT/MCN_SELCHANGE notifications.
by Marvin Aug. 16, 2012

Aug. 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20933 Your paranoid android. === WNT4WSSP6 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2KPROSP4 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WXPPROSP3 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K3R2SESP2 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WVISTAADM (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K8SE (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PRO (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (64 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (64 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead

2 1

Re: comdlg32: Use proper helpers for iface calls
by Marvin Aug. 16, 2012

Aug. 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20929 Your paranoid android. === TEST64_W7SP1 (32 bit itemdlg) === itemdlg: unhandled exception c0000005 at 75AF1AC3

1 0

Re: [PATCH 1/4] include/wine/test.h: Added wine_dbgstr_a[n] to test framwork.
by Qian Hong Aug. 16, 2012

Aug. 16, 2012

On Thu, Aug 16, 2012 at 4:55 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > > This shouldn't be necessary, you can use a simple printf. Functions > should only be added to test.h if there's a clear need across a wide > range of tests. Thanks for review! Will provide an updated patch set soon. -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

1 0

Re: [PATCH] kernel32: add support for CAL_ICALINTVALUE
by Alexandre Julliard Aug. 16, 2012

Aug. 16, 2012

Michael Blumenkrantz <michael.blumenkrantz(a)gmail.com> writes: > @@ -656,8 +656,8 @@ int WINAPI GetCalendarInfoW(LCID Locale, CALID Calendar, CALTYPE CalType, > * for the CALTYPES not requiring GetLocaleInfoA */ > switch (CalType & ~(CAL_NOUSEROVERRIDE|CAL_RETURN_NUMBER|CAL_USE_CP_ACP)) { > case CAL_ICALINTVALUE: > - FIXME("Unimplemented caltype %d\n", CalType & 0xffff); > - return 0; > + return GetLocaleInfoW(Locale, LOCALE_RETURN_NUMBER|LOCALE_ICALENDARTYPE, > + (LPWSTR)lpValue, sizeof(CALID)/sizeof(WCHAR)); I doubt that you want to hardcode LOCALE_RETURN_NUMBER here. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: windowscodecs: Implement Palette_InitializeFromBitmap.
by Vincent Povirk Aug. 14, 2012

Aug. 14, 2012

This does not agree with MSDN's description of the function. According to MSDN, InitializeFromBitmap should compute a palette based on the contents of the (presumably) non-paletted bitmap data.

2 2

Re: Use WM_PAINT to redraw button instead of directly calling unthemed paint routine
by Dmitry Timoshkov Aug. 14, 2012

Aug. 14, 2012

Ruslan Kabatsayev <b7.10110111(a)gmail.com> wrote: > This patch makes buttons render correctly themed in various cases when > e.g. they are pressed and released, made active etc. Without this > patch they look win95-like in such cases even if desktop integration > is used. Let me guess, you didn't run 'make test' with these changes? -- Dmitry.

2 1

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin Aug. 14, 2012

Aug. 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20875 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin Aug. 14, 2012

Aug. 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20871 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [05/17] gdiplus: GdipMeasureString should apply its internal scaling factors to layout rectangle.
by Alexandre Julliard Aug. 14, 2012

Aug. 14, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/gdiplus/graphics.c | 10 ++++++++-- > dlls/gdiplus/tests/graphics.c | 29 ----------------------------- > 2 files changed, 8 insertions(+), 31 deletions(-) This fails here on 64-bit: ../../../../wine/tools/runtest -q -P wine -M gdiplus.dll -T ../../.. -p gdiplus_test.exe.so ../../../../wine/dlls/gdiplus/tests/graphics.c && touch graphics.ok graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 make: *** [graphics.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 4/4] ole32: Added ISynchronizeHandle tests
by Marvin Aug. 14, 2012

Aug. 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20841 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: user32: search more aggressively for a window under a tooltip
by Dmitry Timoshkov Aug. 14, 2012

Aug. 14, 2012

Daniel Jelinski <djelinski1(a)gmail.com> wrote: > Fixes bug 9512 and bug 8914, tested with Delphi and DVD Profiler. > Still not perfect - according to MSDN the function should never return > a window belonging to another thread. This kind of change requires a test case, and I suspect it's plain wrong. -- Dmitry.

3 9

Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template
by Dmitry Timoshkov Aug. 13, 2012

Aug. 13, 2012

Eric Pouech <eric.pouech(a)orange.fr> wrote: > MMRESULT WINAPI acmFormatChooseW(PACMFORMATCHOOSEW pafmtc) > { > - return DialogBoxParamW(MSACM_hInstance32, MAKEINTRESOURCEW(DLG_ACMFORMATCHOOSE_ID), > - pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + MMRESULT ret; > + > + if (pafmtc->fdwStyle & ACMFORMATCHOOSE_STYLEF_ENABLETEMPLATEHANDLE) > + ret = DialogBoxIndirectParamW(MSACM_hInstance32, (LPCDLGTEMPLATEW)pafmtc->hInstance, > + pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + else if (pafmtc->fdwStyle & ACMFORMATCHOOSE_STYLEF_ENABLETEMPLATE) > + ret = DialogBoxParamW(pafmtc->hInstance, pafmtc->pszTemplateName, > + pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + else > + ret = DialogBoxParamW(MSACM_hInstance32, MAKEINTRESOURCEW(DLG_ACMFORMATCHOOSE_ID), > + pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + return ret; > } It would look much better without all those 'ret' + 'else' things. -- Dmitry.

2 3

Re: [PATCH 2/4] wined3d: Fix pixel format alpha/red masks.
by Henri Verbeet Aug. 13, 2012

Aug. 13, 2012

On 13 August 2012 20:20, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + * Pixel formats with more than 4 bpp do not have correct masks, because the > + * high masks do not fit into the 32 bit values needed for ddraw. The masks > + * are only used for ddraw mostly, and to figure out if the format has an alpha > + * component (the POSTPIXELSHADER_BLENDING test also uses those masks to know > + * if there is more than 1 alpha bit and a red component), so that doesn't > + * matter. The 64 and 128 bit formats are not supported by ddraw anyway. > */ We'll probably want these as offset + mask, or perhaps offset + size.

1 0

Re: joy.cpl: Corrected misplaced elements when using high DPIs
by Alexandre Julliard Aug. 13, 2012

Aug. 13, 2012

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Zawacki <lfzawacki(a)gmail.com> > > Fixes bug #31316 > > joy.cpl uses CreateWindow and SetWindowPos to draw some elements > and the hardcoded coordinates where wrong when the dpi was set to anything > bigger than 96px in winecfg. My approach to solve is normalize the > coordinates based on the dialog window size. You probably want to use MapDialogRect instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

_vcomp_fork stack frame puzzle
by Dan Kegel Aug. 12, 2012

Aug. 12, 2012

Having fun trying to figure out what's in the black box of _vcomp_fork(), the helper function that spawns threads in Visual C's OpenMP support library. The C source code #include <stdio.h> #include <omp.h> int main(int argc, char **argv) { double d; double e; int i; printf("&d is %p, &e is %p\n", &d, &e); #pragma omp parallel for for (i=0; i<3; i++) { printf("&d is %p\n", &d); } #pragma omp parallel for for (i=0; i<3; i++) { printf("&d is %p, &e is %p\n", &d, &e); } return 0; } when compiled with cl /MD /openmp /FAs odd.c generates an .exe and a mixed assembly / source .asm listing. The compiler puts the loop into a helper function, and invokes the helper using _vcomp_fork(), which is called with a flag saying whether to parallelize, a pointer to the helper function, a count, and then a pointer to each variable referenced by the loop from the outer scope. The code in the helper function knows to get the addresses of the variables from the stack. When run with native vcomp.dll, this prints out the right addresses inside the loop. When run with my slightly less stubby builtin vcomp patch attached to http://bugs.winehq.org/show_bug.cgi?id=26688 (based on Andre's earlier patch), it prints out garbage. It seems like Andre's varargs code should be right, but something's not connecting. I even tried beer, and it still didn't work. I guess I should fire up a debugger and see what's going on, but I don't want to accidentally see too much about what native's doing. Suggestions, anyone? - Dan

2 5

Wiki is down
by Austin English Aug. 10, 2012

Aug. 10, 2012

Mind taking a look? :) Have a great weekend! -- -Austin

2 1

Re: user32: Menu should not be activated by menu key while mouse buttons are down.
by Jan Boon Aug. 10, 2012

Aug. 10, 2012

Okay, will write a test case later today or tomorrow. When trying to fix the issue I had, I noticed that in the function where it currently handles the logic for the menu key, it only received messages WM_MOUSEACTIVATE on pressing and WM_CAPTURECHANGED on release (in the tested application), but no mouse down or up messages, which caused the mouse down not to set the iMenuSysKey to 0 if the mouse button was pressed after holding alt (and additionally it also needs to not select the menu either when hitting alt while the mouse button is already down). (Also, when trying this manually on linux, gnome desktop wm mouse-button-modifier should be changed from Alt to something else, because it intercepts the alt-mouse combos before wine sees them it seems.) So, since the function is not receiving all the messages here, which I assume are not all forwarded to the default handler by 3ds Max, would it be better to hook into the messages or mouse status at an earlier point in the code (to handle the first case where the mouse is pressed after alt)? And is there a saner way that can be used here to check if the mouse is down (when alt is pressed after mouse down)? On Fri, Aug 10, 2012 at 8:14 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Jan Boon <jan.boon(a)kaetemi.be> wrote: > > > Fix for bug #31434. > > 1. this kind of change requires a test case, some of the changes look wrong > 2. formatting is broken due to not standard tab size > 3. patch introduces compile-time warnings, that's not accepatable > > -- > Dmitry. >

1 0

Re: [01/17] gdiplus: Add more tests for GdipMeasureString using device with custom resolution. Take 4.
by Vincent Povirk Aug. 9, 2012

Aug. 9, 2012

Other than patch 15 the series looks good to me, and I've seen or thought about most of this before, but do you really have to send a series of 17 patches at once?

2 1

Re: [15/17] gdiplus: Delete GDI objects once they are not needed anymore.
by Vincent Povirk Aug. 9, 2012

Aug. 9, 2012

This will break text rendering. We need the correct font to be selected on the hdc during the call to gdip_format_string.

2 3

Re: [1/4] gdiplus: Add a test for GdipDrawImage scaling.
by Vincent Povirk Aug. 8, 2012

Aug. 8, 2012

This series looks good to me.

1 0

__wine_uuidof causing a wall of "warning: returning reference to temporary" on g++
by Ilya Konstantinov Aug. 8, 2012

Aug. 8, 2012

Hi, I've just started porting my C++ application to Linux with Winelib. Upon first attempts to compile, I've received a wall of "warning: returning reference to temporary" on Wine's headers from g++. All of those seem to stem from guidgen.h definition of __wine_uuidof / __CRT_UUID_DECL for C++. All in all, g++ seems to be right -- we are indeed returning a reference to a IID struct that's allocated on the stack. If I remove the '&' in this definition (in guidgen.h): template<typename T> const GUID &__wine_uuidof(); the warnings stop, but then I wonder, did the original author have some good reasoning for returning a reference in the first place? Thanks.

2 4

Re: [3/4] gdiplus: Destination points passed to GdipDrawImagePointsRect should be in device units.
by Dmitry Timoshkov Aug. 7, 2012

Aug. 7, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > + scale_x = units_scale(srcUnit, graphics->unit, graphics->xres); > + scale_y = units_scale(srcUnit, graphics->unit, graphics->yres); This depends on a not yet sent series which introduces units_scale(), please ignore for now, I'll resend it a bit later. -- Dmitry.

1 0

Cannot run wineinstall
by Carlos Tiba Aug. 7, 2012

Aug. 7, 2012

It displays the message: " You are running wineinstall as root, this is not advisable. Please rerun as a user. Aborting. " However it is not possible to install anything on Ubuntu Linux if you-re not root. The command: $ sudo ./wineinstall does not run after passwd enter because of the message above. How is it possible? Thanks Carlos Tiba

2 1

Wine automated testing update
by Jeremy White Aug. 6, 2012

Aug. 6, 2012

Hi Folks, At the last Wine conference, I volunteered to find a home for the WineTestBot that Ge's brother has been hosting, and to take over the Buildbot that Dan and Austin have been so diligently maintaining. This is an update on that project, mostly to help keep my procrastinating self moving it along. First, we have a lovely set of hardware; 4 servers, in a dedicated rack, with a dedicated static ip to the outside world. One server is the gateway, 2 are dedicated Linux test systems (with nice fast processor + gpus), and one is a beefy system capable of running many VMs. The plan was to move the existing VMWare based WineTestBot to this hardware and simply get the existing system up and running on the new hardware. Here we hit our first snag; the VMWare folks are not willing to provide a permanent license for VMWare to us. So, we've shifted gears, and are exploring whether something like qemu + kvm would be a sufficient alternate. I've done a little of this work, and Maarten is hopefully going to help me try converting the existing VMs to see if we can save any hassle by doing a conversion. In parallel, I learned a great deal about buildbot and the buildbot system that Dan has built. There are two especially valuable and useful functions provided by this buildbot: the first is essentially a patch watcher; a process that catches simple mistakes (e.g. build errors on different architectures, and so on). The second is more powerful and is encapsulated by the 'dotests.sh' shell script. The dotests.sh script does a good job of basically running make test and noticing any test failures outside of 'the usual ones'. There is an infrastructure for Buildbot is a good tool, and I invested a lot of energy into it (as have Dan and Austin). However, Alexandre has persuaded me that we should first explore integrating the dotest.sh functionality into the existing WineTestBot, as that would allow us to have a very simple clean web page, and would also allow us to integrate most cleanly with Alexandre's back end tools. Of course, WineTestBot is Perl code, and my Perl fu is low. So I have recently asked Francois to help with that effort as well. So the basic plan is as follows: 1. Test qemu/kvm with a few Windows versions to see if it'll work. 2. If so, modify WineTestBot to use qemu instead of vmware. (This is 'easy' because the WineTestBot code nicely isolates the VM functions, but 'hard', because VMWare provides some APIs that may have to be replicated). 3. Migrate WineTestBot to the new hardware stack 4. Write new code to run 'dotests.sh' as part of WineTestBot Cheers, Jeremy

9 11

Fwd: [GSoC Mentors] [Announce] GSoC 2012 Mentors/Org Admins: "Pencils Down" and Final Evaluation Dates Approaching
by Austin English Aug. 6, 2012

Aug. 6, 2012

---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Aug 6, 2012 at 12:33 PM Subject: [GSoC Mentors] [Announce] GSoC 2012 Mentors/Org Admins: "Pencils Down" and Final Evaluation Dates Approaching To: Google Summer of Code Mentors List <google-summer-of-code-mentors-list(a)googlegroups.com> Hi there, This is a friendly reminder that Monday, 13 August is our soft "pencils down" date. We suggest that students have completed their projects by this date and spend a week writing documentation and wrapping up their projects. We require that students stop all coding on 20 August. Monday, 20 August at 19:00 UTC is also when final evaluations open. Please consider this your reminder to submit your final evaluation by 24 August at 19:00 UTC so that you don't delay your students' final payments or possibly jeopardize your organization's attendance at the mentor summit. I have updated the code submission guidelines [0] and posted it on Melange for your reference. Code submission begins once students have received a passing grade on their final evaluations (after 24 August). The deadline is 14 September. One question students ask a lot is what portion of their code to submit if they made changes to an existing code base or their code interacts a lot with a system they didn't write. The answer is: use your best discretion. Have them submit the code that makes the most sense from a user's perspective. If students need help with code submission they should contact the Melange team at melange-soc-dev(a)googlegroups.com. I have posted the questions for the final evaluations below as well for your reference. [0] - http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc20… Cheers, Carol ---------------- How would you rate the student’s performance on his/her project since the midterm evaluations? It has improved since the midterm It has stayed the same since the midterm It has gotten worse since the midterm Considering your student’s original project proposal, how closely does the project produced reflect the project proposed? It’s almost exactly the same - there have been very few changes to the project It’s similar - there have been some changes over the course of the summer It’s different - we changed the goals or scope of the project It’s different - the student diverged from the project plan How much time have you spent on Google Summer of Code since the midterm evaluations (again, take into consideration both time mentoring the student and working on the program as a whole)? 10-15 hours per week 15-20 hours per week 20-25 hours per week 25-30 hours per week 30-35 hours per week 35-40 hours per week 40+ hours per week How does this amount of time spent on the program compare to before the midterms? It’s less than before the midterms It’s about the same It’s more than before the midterms How would you rate your student’s performance overall? Excellent - amongst the best performers I’ve ever worked with Strong, solid performance Okay Poor How would you rate your experience with the program overall? Excellent - one of the best programs I’ve ever participated in Very good Okay Poor Did you have a co-mentor in the program this year? If so, would you consider this a help or a hindrance? Why? What one thing would you tell mentors for your organization to do in the future to help the students’ experience with the program? What was the most rewarding and/or difficult part of the program for you this year? Anything else you’d like to tell us? -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Mentors List" group. To post to this group, send email to google-summer-of-code-mentors-list(a)googlegroups.com. To unsubscribe from this group, send email to google-summer-of-code-mentors-list+unsubscribe(a)googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-summer-of-code-mentors-list?hl=en. -- -Austin

1 0

GSoC mentor summit 2012
by Owen Rudge Aug. 6, 2012

Aug. 6, 2012

It looks like the GSoC mentor summit for 2012 has been announced. Are any of the mentors this year interested in attending? It's happening on the 20th/21st October in Mountain View. Details are on the GSoC mentor wiki: http://gsoc-wiki.osuosl.org/index.php/2012 Cheers, -- Owen Rudge http://www.owenrudge.net/

6 10

Re: [1/4] dwrite: Added IDWriteFont stub
by Dmitry Timoshkov Aug. 5, 2012

Aug. 5, 2012

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static IDWriteFontVtbl dwritefontvtbl = { > + dwritefont_QueryInterface, > + dwritefont_AddRef, > + dwritefont_Release, Vtables should be 'const' (here and in other places). -- Dmitry.

1 0

Re: winex11.drv: xrandr1.2 don't assume CRTC 0 is active
by Henri Verbeet Aug. 1, 2012

Aug. 1, 2012

On 30 July 2012 22:05, <siro(a)das-labor.org> wrote: > As far as I understood CRTC 0 is disabled, because it is only capable of > generating analog video signals. I'm using a HDMI monitor, which is > controlled by CRTC 1. To use multihead (not clone), you have to connect a > analog (VGA) and digital monitor (in my case). Each monitor will use one > CRTC and each CRTC will show a different part of the same screen. With this > in mind every active CRTC should be listed as "native Windows monitor". Mostly for reference, what driver are you using? Have you explicitly configured a primary display at all (either through the xorg.conf "Primary" option for the monitor, or with the xrandr utility), or is it just picking up the first display connector and incorrectly assuming it's connected?

2 2

Wiki seems to be down.
by Scott Ritchie July 31, 2012

July 31, 2012

Thank you :)

1 0