August 2012 - Wine-Devel - list.winehq.org

Re: quartz/tests: Use proper method macros
by Marvin Aug. 24, 2012

Aug. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21196 Your paranoid android. === WNT4WSSP6 (32 bit memallocator) === memallocator.c:34: Test failed: Unable to create memory allocator 80040154

1 0

Re: wshom.ocx/tests: Use proper method macro
by Marvin Aug. 24, 2012

Aug. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21198 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [2/16] po: Update Russian translation
by Nikolay Sivov Aug. 24, 2012

Aug. 24, 2012

On 8/24/2012 10:14, Oleg Yarigin wrote: > #: comctl32.rc:88 > msgid "&Add ->" > -msgstr "&Добавить ->" > +msgstr "&Добавить →" > #: comctl32.rc:89 > msgid "<- &Remove" > -msgstr "<- &Удалить" > +msgstr "← &Удалить" I don't think so. > #: comdlg32.rc:157 comdlg32.rc:179 > msgid "&Directories:" > -msgstr "&Каталоги:" > +msgstr "&Папки:" New translation is traditionally used for 'folders' mostly. I agree there's a mess in directory/folder/catalogue here though. > #: comdlg32.rc:223 > msgid "[none]" > -msgstr "[нет]" > +msgstr "(нет)" Why? > #: comdlg32.rc:282 > msgid "&Red:" > -msgstr "Крас&н:" > +msgstr "Крас&ный:" The reason was it doesn't fit a dialog template otherwise, did you check that? > #: comdlg32.rc:52 > msgid "Unreadable Entry" > -msgstr "Нечитаемый элемент" > +msgstr "Нераспознаваемый элемент" You translated 'unrecognised' instead of 'unreadable'. > #: comdlg32.rc:65 > msgid "Cannot find the printer." > -msgstr "Не удалось найти принтер." > +msgstr "Принтер не найден." However I like this kind of changes, it's a good example of keeping it short while it means the same. > #: comdlg32.rc:91 > msgid "Output tray is full; " > -msgstr "Лоток переполнен бумагой; " > +msgstr "Лоток для бумаги переполнен; " Could be "Лоток полон;" ... I can't comment on the rest of this series but there's a lot to fix already.

1 0

Re: oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY
by Marvin Aug. 24, 2012

Aug. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21195 Your paranoid android. === WNT4WSSP6 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === WXPPROSP3 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === WVISTAADM (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W2K8SE (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PRO (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PROX64 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === TEST64_W7SP1 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PROX64 (64 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === TEST64_W7SP1 (64 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v

1 0

Re: oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY
by Dmitry Timoshkov Aug. 24, 2012

Aug. 24, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Changelog: > oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY Please resend the test separately, your fix conflicts with the patch sent by Roman Dadkov. -- Dmitry.

1 0

Re: dssenh/tests: Added key exchange tests for the DSSENH cryptographic service provider
by Marvin Aug. 23, 2012

Aug. 23, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21186 Your paranoid android. === TEST64_W7SP1 (32 bit dssenh) === dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008 dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008 dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008

1 0

Have there been any problems with Wine on GCC 4.7?
by Scott Ritchie Aug. 23, 2012

Aug. 23, 2012

Wine is the last remaining package still depending on GCC 4.5 in the current Ubuntu alpha, it would be nice to drop GCC 4.5 and forward port Wine, however 4.6 is known to not work too well. But now we have 4.7 -- have there been any bugs attributed to its usage? Thanks, Scott Ritchie

4 15

Re: hhctrl.ocx: Make MergeChmProperties() static.
by Erich E. Hoover Aug. 23, 2012

Aug. 23, 2012

I'm going to need MergeChmProperties() for HH_SET_WIN_TYPE. I've just been really busy lately and have not had a chance to cleanup my patches yet (from discussions with Jacek it looks like we need to redo storing HH_WINTYPE data a little bit). Erich

1 0

Re: [PATCH 1/3] dinput: Disable linuxinput or linux joysticks based on registry key (try 2)
by Alexandre Julliard Aug. 23, 2012

Aug. 23, 2012

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > In the form of "controllername(drivername)"="disabled" key > > Examples: > Disable the linux js driver for "Usb Controller" device > "Usb Controller(js)"="disabled" > > Disable the linux js and event drivers for "Other Controller" device > "OtherController(event)"="disabled" > "OtherController(js)"="disabled" That's better, thanks. You probably want to put them under a subkey though, to avoid mixing up the joystick names with the other configuration values. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/3] joy.cpl: Using joystick name suffixed with driver when in Linux (try 2)
by Alexandre Julliard Aug. 23, 2012

Aug. 23, 2012

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > @@ -57,6 +57,34 @@ BOOL WINAPI DllMain(HINSTANCE hdll, DWORD reason, LPVOID reserved) > return TRUE; > } > > +static void get_joystick_name(struct Joystick *joy) > +{ > + /* Base product guids as Wine defines them in DirectInput */ > + /* 9e573ed9-7734-11d2-8d4a-23903fb6bdf7 */ > + static const GUID linux_guid = { 0x9e573ed9, 0x7734, 0x11d2, {0x8d, 0x4a, 0x23, 0x90, 0x3f, 0xb6, 0xbd, 0xf7} }; > + /* 9e573eda-7734-11d2-8d4a-23903fb6bdf7 */ > + static const GUID linuxinput_guid = { 0x9e573eda, 0x7734, 0x11d2, {0x8d, 0x4a, 0x23, 0x90, 0x3f, 0xb6, 0xbd, 0xf7} }; > + static REFGUID wine_guids[] = { &linux_guid, &linuxinput_guid }; > + static const WCHAR wine_device_names[2][9] = { {'(','j','s',')','\0'}, {'(','e','v','e','n','t',')','\0'} }; I think dinput should be appending that to the returned name, joy.cpl shouldn't have to know about the specific naming scheme of the driver. -- Alexandre Julliard julliard(a)winehq.org

2 1

Testing Gdi+
by Stepa Nick Aug. 23, 2012

Aug. 23, 2012

Hi! I`m new in WINE development. I have some tests cases, that works incorrect in current version of WINE and I want to fix this mistakes. So, I`m interesting are there some testing systems that compares bitmap(for example)? I look thru WINE tests, http://www.winehq.org/docs/winedev-guide/testing and had found only tests, that compare some variables to constant. I think, that WINE needs graphics test. Thanks.

2 1

Re: wine/server: removed obsolete one-iteration loop from request forming macro (try 2)
by Marcus Meissner Aug. 23, 2012

Aug. 23, 2012

On Thu, Aug 23, 2012 at 11:14:23AM +0400, Oleg Yarigin wrote: > An original message was sent with wrong author`s name by mistake, so > I resend this patch with hope it was the only reason to reject it. It was not the only reason. A single loop is a common pattern in C to allow safe encapsulation and handling of blocks, or doing "break;"/"continue;" style things. One thing that it allows here in Wine is that the variable definitions are at the begin of a { } block and not in the middle of the code to allow old C standard builds to work still. There is no "break;" usage, although I spotted 1 "goto done;" which could be just a break; ;) The compiler will optimize everything of those loops away, so this change also brings no performance improvement. Ciao, Marcus > --- > include/wine/server.h | 22 +++++++++------------- > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/include/wine/server.h b/include/wine/server.h > index d573d1f..dcbc7fa 100644 > --- a/include/wine/server.h > +++ b/include/wine/server.h > @@ -124,19 +124,15 @@ static inline void *wine_server_get_ptr( client_ptr_t ptr ) > /* macros for server requests */ > > #define SERVER_START_REQ(type) \ > - do { \ > - struct __server_request_info __req; \ > - struct type##_request * const req = &__req.u.req.type##_request; \ > - const struct type##_reply * const reply = &__req.u.reply.type##_reply; \ > - memset( &__req.u.req, 0, sizeof(__req.u.req) ); \ > - __req.u.req.request_header.req = REQ_##type; \ > - __req.data_count = 0; \ > - (void)reply; \ > - do > - > -#define SERVER_END_REQ \ > - while(0); \ > - } while(0) > + struct __server_request_info __req; \ > + struct type##_request * const req = &__req.u.req.type##_request; \ > + const struct type##_reply * const reply = &__req.u.reply.type##_reply; \ > + memset( &__req.u.req, 0, sizeof(__req.u.req) ); \ > + __req.u.req.request_header.req = REQ_##type; \ > + __req.data_count = 0; \ > + (void)reply; > + > +#define SERVER_END_REQ > > > #endif /* __WINE_WINE_SERVER_H */ > -- 1.7.9.5 > > -- Open Linux Security Engineer Position at SUSE: http://bit.ly/Li4RbS

1 0

Re: configure.ac: provide a --disable-dwarf2 configure option
by Alexandre Julliard Aug. 22, 2012

Aug. 22, 2012

Austin English <austinenglish(a)gmail.com> writes: > This should address the concerns from > http://bugs.winehq.org/show_bug.cgi?id=31501 I don't think that justifies adding a configure option, people shouldn't have to worry about that kind of detail. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wine/server: removed obsolete one-iteration loop from request forming macro
by Sergey Guralnik Aug. 22, 2012

Aug. 22, 2012

On 2012-08-22 6:26, Архад wrote: > #define SERVER_START_REQ(type) \ > - do { \ > - struct __server_request_info __req; \ ... > - (void)reply; \ > - do > - > -#define SERVER_END_REQ \ > - while(0); \ > - } while(0) > + struct __server_request_info __req; \ ... > + (void)reply; > + > +#define SERVER_END_REQ Are you try at least to rebuild project with it? -- Sergey

1 0

Re: opengl32/test: do not pass NULL attrib list to wglCreatePBufferARB
by Marvin Aug. 22, 2012

Aug. 22, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21127 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/3] gdiplus: GdipMeasureCharacterRanges should respect device units and transformations.
by Vincent Povirk Aug. 22, 2012

Aug. 22, 2012

> GetTextExtentExPointW(hdc, string + index, range_start - index, > INT_MAX, NULL, NULL, &range_size); > - range_rect.X = bounds->X + range_size.cx; > + range_rect.X = bounds->X / args->rel_width + range_size.cx; > > GetTextExtentExPointW(hdc, string + index, range_end - index, > INT_MAX, NULL, NULL, &range_size); > - range_rect.Width = (bounds->X + range_size.cx) - range_rect.X; > + range_rect.Width = (bounds->X / args->rel_width + range_size.cx) - range_rect.X; Shouldn't you be scaling range_size.cx as well?

2 3

Re: user32: Don't limit time needed for WM_DDE_INITIATE processing.
by Alexandre Julliard Aug. 21, 2012

Aug. 21, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > Current timeout is too small for Microsoft Office 2010 in some cases. > I've checked that DdeConnect succeeds on windows when it needs to wait > for 10 minutes. Are you sure that you want to remove the SMTO_ABORTIFHUNG flag? Does a hung process really prevent all DDE connections? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] dinput: Disable linuxinput or linux joysticks based on registry key
by Alexandre Julliard Aug. 21, 2012

Aug. 21, 2012

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > In the form of "Disable Controllername"="driver" > > Examples: > Disable "Usb Controller"="js" disable linux js driver > Disable "OtherController"="event,js" disable linux js and event drivers That's a fairly complicated way to disable a given joystick. What you probably want is to give them a unique name and have a enable/disable value for each name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mountmgr.sys: For loop-mounted devices, use the backing file
by Alexandre Julliard Aug. 21, 2012

Aug. 21, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > As part of their copy protection, some games use some ioctl's to check some physical attributes. > Unfortunately, when using the loop device, some ioctl fail (like IOCTL_SCSI_GET_ADDRESS). > A simple fix is to use /path/to/the/file.ISO instead of /dev/loopX. Several places depend on this being a device. Besides, failing to get the SCSI address of a loop mount seems like correct behavior to me. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH] kernel32: add basic conditional variables support (try 2)
by Alexandre Julliard Aug. 21, 2012

Aug. 21, 2012

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > Started with patch from Austin, brought up to a point > where Adobe Lightroom 4.1 starts up. > > The synchronisation is probably not 100% correct and > not sufficiently atomic. Synchronization routines have to be 100% correct, half stubs are worse than no implementation at all. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] wined3d: Improve post-pixelshader blending test. (Try 2)
by Lucas Zawacki Aug. 20, 2012

Aug. 20, 2012

Hello, this patch caused a regression with Rayman 2, all the text in the menus is rendered wrong now. Should I open a bug or is this email enough? A demo of the game can be downloaded here ftp://ftp.ubisoft.com/Rayman2/rayman2high.zip Screenshot: http://dl.dropbox.com/u/2701879/images/rayman2.png Regression test: a488e574497d674631b4036d4b179ce349ddb764 is the first bad commit commit a488e574497d674631b4036d4b179ce349ddb764 Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Wed Aug 15 00:38:26 2012 +0200 wined3d: Improve post-pixelshader blending test. :040000 040000 1a61c91a146de3e7a5206ccde1cc239fa0771e40 a9759ba603b3b52f2feccc716daff3d875a90b74 M dlls

2 1

Re: [6/7] d3dx9: Implement ID3DXConstantTable::SetMatrixPointerArray.
by Rico Schüller Aug. 20, 2012

Aug. 20, 2012

On 20.08.2012 17:10, Józef Kucia wrote: > + if (desc.Class == D3DXPC_MATRIX_ROWS || desc.Class == D3DXPC_MATRIX_COLUMNS) > + { ... > + } > + else if (desc.Class == D3DXPC_SCALAR) Could you also set D3DXPC_VECTOR variables with this call? It should be easy to add a test for a scalar and a vector. But that may also be a separate patch. In general I think it would be fine to try to set all variable class and see which work / fail. That way you would also verify, that the non common way works too, which has no test, yet, but a implementation. This holds true for all the Set(Matrix/Vector/...) functions. That way you'd ensure that the setting is correct for the specific class. ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "c2x3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "r2x3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "vec3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "scalar", matrix_pointer, 1); Cheers Rico

1 0

Re: [3/7] d3dx9: ID3DXConstantTable::SetFloat shouldn't change the value of matrix and vector constants.
by Rico Schüller Aug. 20, 2012

Aug. 20, 2012

On 20.08.2012 17:10, Józef Kucia wrote: > @@ -665,6 +666,31 @@ static void test_setting_basic_table(IDirect3DDevice9 *device) > out[8], out[9], out[10], out[11], > out[12], out[13], out[14], out[15]); > > + ID3DXConstantTable_SetFloat(ctable, device, "mvp", f); > + ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable mvp: 0x%08x\n", res); You probably may save res (= ID3DXConstantTable_SetFloat) before checking it. Otherwise you are checking the same res value multiple times. > + ID3DXConstantTable_SetFloat(ctable, device, "f4", f); > + ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable f4: 0x%08x\n", res); Cheers Rico

1 0

Re: [PATCH 1/2] oleaut32: Ensure that the right interface is passed to the callee in ITypeInfo::Invoke
by Alexandre Julliard Aug. 20, 2012

Aug. 20, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -6509,6 +6510,38 @@ static HRESULT WINAPI ITypeInfo_fnInvoke( > { > prgpvarg[i] = src_arg; > } > + > + if((tdesc->vt == VT_USERDEFINED || (tdesc->vt == VT_PTR && tdesc->u.lptdesc->vt == VT_USERDEFINED)) > + && (V_VT(prgpvarg[i]) == VT_DISPATCH || V_VT(prgpvarg[i]) == VT_UNKNOWN)) { > + const TYPEDESC *userdefined_tdesc = tdesc; > + IUnknown *userdefined_iface; > + ITypeInfo *tinfo2; > + TYPEATTR *tattr; > + > + if(tdesc->vt == VT_PTR) > + userdefined_tdesc = tdesc->u.lptdesc; typelib.c: In function ‘ITypeInfo_fnInvoke’: typelib.c:6516:41: error: variable ‘userdefined_tdesc’ set but not used [-Werror=unused-but-set-variable] make[1]: *** [typelib.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Microsecond unit
by Francois Gouget Aug. 20, 2012

Aug. 20, 2012

The microsecond unit is 'µs' and yet, in dlls/sane.ds/sane.rc, we define it as 'us' and then rely on the British and American English PO files to convert it to 'µs'. Why not put the right unit directly in the RC file? It's UTF-8 anyway... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

2 1