September 2012 - Wine-Devel

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: Web based translation tool
by Michal Čihař June 18, 2013

June 18, 2013

Hi Dne Mon, 12 Mar 2012 12:02:49 +0200 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > The Wine project is thinking about using Weblate in order to translate > Wine, you can look at the following discussion and see for yourself. That sounds great! > Looking good although a litle immature, not sure about authentication as > wel... For authentication you can basically use anything what can be used in Django. Any specific concerns on this topic? > I'll talk to Michal Cihar and ask him for a roadmap for this project. Well I don't have any real roadmap right now. I urgently needed replacement for Pootle because we got hit by too many bugs there and did not manage to understand the code there to be able to fix them myself. So far I think it is in pretty good shape for day to day work (with today's 0.5 release fixing few annoying bugs). Of course there are some features missing, you can check what I plan for 1.0 release here: https://github.com/nijel/weblate/issues?state=open&milestone=1 I currently hope to have 1.0 in a month or so, but I really don't want to commit to any specific date. PS: I'm not subscribed to mailing list so please CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

7 16

Re: xbox 360 emulation with logitech cordless and dinput joy disable
by Stefan Dösinger Jan. 1, 2013

Jan. 1, 2013

Hi, The patch needs a few improvements before it can be accepted into Wine. I can't comment on the dinput / xinput specifics of the patch, so this is a non- exhaustive list of general suggestions. Concerning the big picture, this patch needs a few discussions about xinput.dll design. There have been some discussions about that in the past, and I hope that some dinput devs can help out. Am Dienstag, 12. Juni 2012, 23:48:53 schrieb Giovanni Ongaro: > From: root <root(a)joe.(none)> Please configure git correctly, see http://wiki.winehq.org/GitWine section 3.3. Also consider using a non-root user, but that's your personal setup, so not really my business. > + if (getenv("LINIXFORCENOJOY") != NULL) return FALSE; /*JoeFix disable joystick*/ The problem with dinput vs xinput conflicts should probably be solved in a different manner. That aside, such configurations are usually done via registry keys. Also comments like /* I changed this here */ are useless, the git history stores this information anyway. > + <...> //JoeFix DEAD ZONE This is a C++ comment and not allowed in Wine. See http://wiki.winehq.org/SubmittingPatches > + fdJoy=open("/dev/input/js0",O_RDONLY | O_NONBLOCK); Xinput.dll should not open joystick devices directy, and definitely not a hardcoded one. I don't know if there's consensus about how xinput should be implemented, but basing it on top of dinput might be a start. A good start would be to write a few tests to test how Windows announces(or doesn't announce) Xbox gamepads and other gamepads/joysticks to games. My understanding is that xinput.dll only works for Xbox gamepads. Do those show up in dinput on Windows? > +#define DEAD_ZONE 4096 > ... > + if (e.number == 4) { > + if (e.value == 1) { > + FIXME("TRIGGER LEFT PRESSED\n"); > + pState->Gamepad.bLeftTrigger=32767; > + } > + else { > + pState->Gamepad.bLeftTrigger=0; > + } > ... > +#define JOYMAX 30000 > +#define JOYMIN -30000 The hardcoded numbers look questionable. The 4 and 1 are probably specific to the joystick, the 32767 might have a symbolic name like XINPUT_MAX or something. A part of this seems to be needed due to the attempt to emulate an xbox gamepad with a different device. Personally I'm not opposed to doing that, and you might need some device specific tricks to pull this off. However, this needs a more structured approach than hardcoding the values needed for one specific Logitech device in the code. Best regards, Stefan

3 2

Re: wined3d: Use backup swapchain DC for devices created with desktop window. (try 2)
by Stefan Dösinger Nov. 14, 2012

Nov. 14, 2012

Am Montag, 3. September 2012, 04:06:01 schrieb Adam Jakubek: > Previous version failed on test bots. > Added test case skipping when no device can be created with normal > (non-desktop) window. I skimmed bug #18490, and I'm wondering about two things: Does the app create a D3DDEVTYPE_REF or D3DDEVTYPE_NULLREF device? Once the device is created, what does it to with it? A +d3d log would provide some answers. This is some guesswork: I don't think the game creates a _REF device because REF devices require the user to install the reference rasterizer dll, as Matteo already mentioned. If it's a NULLREF device I wonder what the game is able to do with it. The bug report has a link which promises some clues, but the link is dead. Stefan

3 2

d3d9 implementation
by Luchezar Belev Oct. 15, 2012

Oct. 15, 2012

hello i have been writing some d3d9/d3d8 implementation on top of opengl as a pet project i mainly work on it under windows, but also made it run under wine. i thought you guys might find it interesting to try it out. It works fine with all the games i got - there are no major problems. they are guild wars (1), wow, league of legends, tomb raider underworld, titan quest, skyrim. it requires opengl 3.3 or higher. attached is zip archive with binaries (2 files) and a readme. (i'm not sure i want to give away the sources yet.)

2 1

Overriding the check for ownership of a prefix
by Scott Ritchie Oct. 3, 2012

Oct. 3, 2012

So, I believe I have a legitimate use case for ignoring this, and want to know what sort of patch would go forward. Imagine a distro package containing a Windows game in the form of a read-only copy of an installed prefix (into, say, /opt). When the user launches the app (via desktop file) this in turn launches a script that does the following: 1) Makes a temporary folder 2) Sets up a unionfs-fuse copy-on-write mount between ~/.appname and the read-only packaged prefix in /opt, mounted in the temporary folder 3) Runs the app with WINEPREFIX= the temp folder 4) When the app is finished, unmounts the temp folder This all works quite fine: new (or modified) files within the prefix get stored in ~/.appname, to be restored the next time the user runs the app. Distinct users can run the app simultaneously, as they each have their own prefix. Excess file-copying is avoided, as only the user-modified files need to be stored in the home folders. There is one major snag, however: unionfs displays the owner as root until the user has modified/copied it. This means Wine refuses to launch as the user with the "root-owned" prefix. Simply commenting out this part of the code makes Wine work fine, however I'd like to be able to have a proper solution. Would something like a command-line switch or environment variable be acceptable here? Thanks, Scott Ritchie * Note that there is a problem with this setup if the app modifies the registry and we then need to update the prefix-default registry, but that's a different feature request

2 3

ImmIsUIMessageA/W
by Aric Stewart Oct. 3, 2012

Oct. 3, 2012

Hi Andre, I have a quick question for you. I am looking into why IME unaware applications are no longer showing their composition window and found it was because of: commit 7673d67c1e1cfdcdf7560beea9162c3699329aa5 Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Jun 25 16:13:41 2011 +0200 imm32: Test and fix ImmIsUIMessageA/W. in that patch I see that you eliminate the part where we check if there is a default IME window and if not then create one. if (!IMM_GetThreadData()->hwndDefault) ImmGetDefaultIMEWnd(NULL); also you eliminate the part where if the incoming hWndIME is NULL we send the message to the thread's default IME window. These changes cause the IME to stop working for IME unaware applications. Where the changed intentional and if so based on what documentation? thanks! -aric

3 9

Re: dmusic: Fix a copy and paste error
by Christian Costa Sept. 29, 2012

Sept. 29, 2012

Le 29/09/2012 17:11, Sven Baars a écrit : > This should fix http://bugs.winehq.org/show_bug.cgi?id=31805 > > Good catch !

1 0

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.
by Hans Leidekker Sept. 29, 2012

Sept. 29, 2012

On Thu, 2012-09-27 at 09:59 +0200, Christian Costa wrote: > diff --git a/dlls/msi/media.c b/dlls/msi/media.c > index 612624d..8a39fcd 100644 > --- a/dlls/msi/media.c > +++ b/dlls/msi/media.c > @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE fdint, > > if (strcmpiW( mi->cabinet, cab )) > { > - ERR("Continuous cabinet does not match the next cabinet in the Media table\n"); > - goto done; > + LPSTR next_cab; > + > + WARN("Continuous cabinet %s does not match the next cabinet %s in the media table\n", debugstr_w(cab), debugstr_w(mi->cabinet)); > + > + /* Use cabinet name from the media table */ > + next_cab = strdupWtoA(mi->cabinet); > + /* Modify path to cabinet file with full filename (psz3 points to a 256 bytes buffer that can be modified contrary to psz1 and psz2) */ > + strcat(pfdin->psz3, "\\"); > + strcat(pfdin->psz3, next_cab); > + /* Path psz3 and cabinet psz1 are concatenated by FDI so just reset psz1 */ > + *pfdin->psz1 = 0; > + msi_free(next_cab); > } > > if (!(cabinet_file = get_cabinet_filename(mi))) The requirement that the continuous cabinet name matches the next cabinet in the media table might simply be too strict. Perhaps we need to try them one by one and let FDI decide based on the setID and iCabinet fields. Can you please add some tests?

2 3

Re: [PATCH] wined3d: move texture reference decrement to end of usage (Coverity)
by Henri Verbeet Sept. 29, 2012

Sept. 29, 2012

On 29 September 2012 11:14, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > I do not fully understand all this, but it seem the decref needs to > be behind the last usage of prev. > Sort of. It's probably better to do it like this, but a non-zero bind_count implies a non-zero reference count as well, so in practice there's no danger of using prev after it's free'd.

1 0

Fwd: CIA going down: KGB wants your commits!
by Austin English Sept. 29, 2012

Sept. 29, 2012

-- -Austin ---------- Forwarded message ---------- From: Martín Ferrari <martin.ferrari(a)gmail.com> Date: Thu, Sep 27, 2012 at 3:52 PM Subject: CIA going down: KGB wants your commits! To: debian-project(a)lists.debian.org, Debian Developers <debian-devel(a)lists.debian.org> Hi there! Not to "to knock 'em when they're down", but since it seems that the CIA.vc service has officially closed recently (cannot find exactly when did that happen), I think it's worthwhile offering this little project we (dam@, gregoa@, and me) have since a few years ago, called KGB (ha-ha). It's a very simple and dumb client-server architecture: IRC bots running in our personal servers listen for SOAP messages sent by kgb-clients called from post-commit hooks in repos out there. The bot just relays and formats a message, nothing fancier than that. So, if you're looking for a simple IRC notification of your commits, this might be of help. You can either run your own bot (debian package kgb-bot), or use ours. As for the client, alioth does not have it installed, but you can run it off /home/groups/kgb. There's a sample configuration there too. In /home/groups/pkg-perl/meta/pkg-perl-post-receive you can see how to use it from a post-commit hook. If you rather use our bots, we'll need you to provide: a project/repository name, an IRC channel, and a password (used to avoid spam, not really secure). -- Martín Ferrari -- To UNSUBSCRIBE, email to debian-devel-REQUEST(a)lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmaster(a)lists.debian.org Archive: http://lists.debian.org/CAL60Pd_7zoPk4w4rta49-jymxzKOU+K7DdqZUiqsP32KZ9bQBA…

3 2

Re: comctl32: use GetWindowLong to check for scrollbar (try 2)
by Nikolay Sivov Sept. 28, 2012

Sept. 28, 2012

On 9/28/2012 20:43, Daniel Jelinski wrote: > Corrected from first try: > - uses GetWindowLong instead of GetWindowLongPtr > - does not touch dwStyle Sorry, was busy to reply earlier. I think this fix is ok if it really helps, thanks for working on this.

1 0

Re: [PATCH] configure: use -Wp, -D_FORTIFY_SOURCE=0 instead of -D_FORTIFY_SOURCE=0
by Alexandre Julliard Sept. 28, 2012

Sept. 28, 2012

Anssi Hannula <anssi.hannula(a)iki.fi> writes: > Some Linux distributions (at least Mageia) build packages with > -Wp,-D_FORTIFY_SOURCE=2 by default. There is a check in configure which > checks for enabled fortify and adds "-U_FORTIFY_SOURCE > -D_FORTIFY_SOURCE=0". Unfortunately, -Wp,-Dfoo are applied after -Dfoo, > so the added flags fail to override the fortify in the CFLAGS. I would say that's a distro bug. Defaulting to Fortify is already broken enough, but making it even harder to disable is stupid. I don't think we want to get into that kind of arms race. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdiplus: Reuse an existing image stream in GdipImageSelectActiveFrame. Take 2.
by Vincent Povirk Sept. 28, 2012

Sept. 28, 2012

Looks good, thanks.

1 0

Re: [PATCH 2/2] vbscript: Added MonthName implementation
by Marvin Sept. 28, 2012

Sept. 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21880 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: gdi32: Fixed freetype working function
by Alexandre Julliard Sept. 28, 2012

Sept. 28, 2012

Сергей Мосин <svmosin(a)gmail.com> writes: > The function WineEngAddFontMemResourceEx in gdi32/fretype.c contained > strange XOR operation with some random number 0x87654321, instead of > returning the real font handle. Do you have an app that depends on this? What does it do with the handle? -- Alexandre Julliard julliard(a)winehq.org

1 0

is CreateThread(CREATE_SUSPENDED) fully functional?
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 27, 2012

Sept. 27, 2012

Hi, Recently I thought I found a use-case for CreateThread(CREATE_SUSPENDED). The idiom is to get the thread handle before the thread starts a life on its own. I looked at the kernel tests, http://source.winehq.org/source/dlls/kernel32/tests/thread.c#L460 However, both invocations with CREATE_SUSPENDED actually test the pair CreateThread + SuspendThread. The tests do not prove that CREATE_SUSPENDED works! They only prove that the suspend counter and perhaps SuspendThread work. a) Does Wine not support CREATE_SUSPENDED, so that the tests do the best they can? In such a case, a WARN("ignoring SUSPENDED flag, beware of race conditions\n") would be appropriate. or b) CREATE_SUSPENDED is fully supported on all platforms. Then the tests need some refinement. Thank you, Jörg Höhle

3 2

Re: [1/3] gdiplus: Move font substitution test into a separate body.
by Vincent Povirk Sept. 27, 2012

Sept. 27, 2012

The series looks good to me. Very cool to have a fix for this.

1 0

Re: gdiplus: Reuse an existing image stream in GdipImageSelectActiveFrame.
by Vincent Povirk Sept. 27, 2012

Sept. 27, 2012

> @@ -3898,7 +3894,7 @@ GpStatus WINGDIPAPI GdipImageSelectActiveFrame(GpImage *image, GDIPCONST GUID *d > return Ok; > } > > - IStream_Release(stream); > + IStream_Release(image->stream); > return stat; > } I don't think it's necessary to AddRef/Release the stream anymore in GdipImageSelectActiveFrame. Creating the new image and freeing the old one will update the refcount as necessary. And it's a bit confusing since technically the current image->stream is released by free_image_data then overwritten (with the same value, fortunately) by copying new_image to image. Looks good otherwise.

1 0

'sort' implementation (Bug 27933) - any easy way?
by Ann and Jason Edmeades Sept. 27, 2012

Sept. 27, 2012

Hello, While working on more of the 'for' processing in the command shell, I've come across a stumbling block that wildcard expansion 'ordering' is not guaranteed (findfirst/findnext) meaning I cannot automate tests for some of the key bits - this is frustrating as we really need tests for the things I'm looking at as the code is getting complex. Looking in the cmd testsuite, there's already some commented out tests as well, saying we really need a 'sort' implementation, and that would also resolve the problem I have at the moment. Therefore, I'd like to know if there's any simple way to implement a command line sort program which we can call from the command shell. This has subsequently been raised as bug 27933. My first thought was to avoid reinventing the wheel and to have a windows program called sort which parses its parameters and then runs the Unix 'sort' command with an equivalent command line. I think most of the windows command line parameters have Unix equivalents, and for the majority of cases it would be a case of transposing a windows path to a Unix path, and just running the Unix sort. However, I then started to get concerned about stdin / stdout... Is there any way to take the windows stdin and 'connect it' to the unix program you spawn, and vica-versa for the stdout. Whilst I dont accurately need this for the testsuite, without it the wine implementation would not match the windows one. So I think my specific questions are... 1. Is wrappering an existing (Linux) 'sort' program an option for this, or do we really need a whole unique implementation of sort (which I would have no idea how to write!)? If it is an option, the two key questions I have are: 2. How do I handle stdin / stdout, so sort can work in pipes / redirects 3. Is it ok to use wine_get_unix_file_name to convert files and directories to the unix equivalents when building the unix equivalent command line? (as per winepath) Thanks. Jason

1 0

Re: d3dx9_36 [patch 6/6]: Implement D3DXSHEvalHemisphereLight
by Rico Schüller Sept. 27, 2012

Sept. 27, 2012

Well I think, if you rework a series, please add something like try xyz or so ... Also try to avoid to add / remove some patches, at least if they actually don't have anything todo with the rest of the patch set (if they could be submitted on their own). On 27.09.2012 10:00, Nozomi Kodama wrote: > + TRACE("%u, %p, %p, %p, %p, %p, %p\n", order, dir, &top, &bottom, rout, gout, bout); Sure, that's an other form of the trace. I think we hadn't one with such a version... other traces in the file look like (the one marked with * is my preferred version): TRACE("out %p, order %u, a %p, b %p\n", out, order, a, b); * TRACE("(%p, %p, %u)\n", pout, pin, n); I don't think it makes much sense to print the address for &top. It doesn't gather some useful information, does it? Instead you may print the actual content for r,g,b if you like. > + if ( gout ) Also here, I prefer "if (gout)" ... I know there are several occurrences for the other style ... I should have mentioned that earlier ... it's not something which is critical... git grep "if (" dlls/d3dx9_36/* | wc -l reveals ~2000 while git grep "if ( " dlls/d3dx9_36/* | wc -l does ~100 > + ok(relative_error(expected, blue_out[j]) < admitted_error, > + "Blue: case %u, order %u: expected[%u] = %f, received %f \n", l, order, j, expected, blue_out[j]); Please indent 8 instead of 2 spaces when a new line is used ... Cheers Rico

1 0

dsound: Don't bother shrinking the secondary buffer list.
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 27, 2012

Sept. 27, 2012

Michael, >+#include <assert.h> your patch is already committed, yet I believe that the least that dsound needs is new asserts. Asserts in dsound have been a PITA in Wine for the last decade. It's ok for the kernel to crash in an assert. IMHO it is not ok for an optional thing like sound. The assert's backtrace will not help anybody, because the logical error will have happened much earlier. Instead, a plain ERR would have been just as telling. Let's quote http://www.winehq.org/docs/winedev-guide/debugging#DBG-CLASSES "ERR: Messages in this class indicate serious errors in Wine, such as as conditions that should never happen by design." I recommend: - assert(device->buffers[0] == pDSB); + if (pdevice->buffers[0] != pDSB) + ERR("broken device buffer %p\n", device->buffers[0]); HeapFree(GetProcessHeap(), 0, device->buffers); device->buffers = NULL; The ERR is IMHO revealing enough in a user's log. If a sound component detects a bogus state, I'd very much prefer that it disables sound -- without crashing. Regards, Jörg Höhle

2 1

Re: d3dx9_36 [patch 1/6]: Implement D3DXSHMultiply4
by Rico Schüller Sept. 27, 2012

Sept. 27, 2012

On 27.09.2012 09:56, Nozomi Kodama wrote: > +FLOAT* WINAPI D3DXSHMultiply4(FLOAT *out, CONST FLOAT *a, CONST FLOAT *b) FLOAT * WINAPI D3DXSHMultiply4(FLOAT *out, const FLOAT *a, const FLOAT *b) A minor nitpick, anyone against something like? I think that was what Matteo meant in http://www.winehq.org/pipermail/wine-devel/2012-September/096924.html with "Fix the FLOAT*"? > + TRACE("(%p, %p, %p)\n", out, a, b); I would probably prefer: TRACE("out %p, a %p, b %p\n", out, a, b); I know the other Multiply functions and so on use your trace format... > + out[0] = 0.28209479f * a[0] * b[0]; There are still double spaces ... Hint: it's not the only occurrence. Cheers Rico

1 0

Re: d3dx9_36 [patch 2/6]: Speed-up some tests
by Rico Schüller Sept. 27, 2012

Sept. 27, 2012

On 27.09.2012 09:57, Nozomi Kodama wrote: > - FLOAT a[64], b[64], got; > + FLOAT a[49], b[49], got; > CONST FLOAT expected[] = > { 0.5f, 0.5f, 25.0f, 262.5f, 1428.0f, 5362.0f, 15873.0f, 39812.0f, 88400.0f, }; > > - for (i = 0; i < 64; i++) > + for (i = 0; i < 49; i++) > > - for (i = 0; i < 9; i++) > + for (i = 0; i <= D3DXSH_MAXORDER + 1; i++) Again: You may correct the (array) size for the expected value ... If we run til element 7 instead of 8, I think the last element could be thrown away? Cheers Rico

1 0

Re : d3dx9 [patch 1/5]: Implement D3DXSHMultiply4
by Nozomi Kodama Sept. 26, 2012

Sept. 26, 2012

>On 26.09.2012 12:17, Nozomi Kodama wrote: >> + ta =0.28209479f * a[0]+ 0.14567312f * a[8]+ 0.12615663f * a[6]; >> + tb =0.28209479f * b[0]+ 0.14567312f * b[8]+ 0.12615663f * b[6]; >> + out[13] += ta * b[13] + tb * a[13]; <> + t = a[13] * b[13]; >> + out[0] +=0.28209479f *t; >Please use spaces with care. >The preferred way is "x = 123 * a[0] + 456 * b[234]; Mostly one space is enough, only use two or more if >you like to indent something, that's mostly not the case when calculating a value. Even then, please be >consistent across your patch. oops!!! I will take care of this one. >> + D3DXSHMultiply4(c, a, b); >>What happens if you use something like D3DXSHMultiply4(c, c, c). Is that allowed? Tests in native show that D3DXSHMultiply gives what I implemented. We can not reuse a input variable as output (we don't obtain what we expect logically). >Also is there a reason why it uses slightly different values than e.g. D3DXSHMultiply3? Why don't we >use defines? A problem might be to find good names... Maybe the Multiply functions could share the >same base? To me it looks like they do share a lot of calculations, And if the order doesn't matter (see >comment above) then it may be possible to rearrange the calculation. > >ta = 0.28209479f * a[0] - 0.12615663f * a[6] - 0.21850969f * a[8]; >vs >ta = 0.28209479f * a[0] - 0.12615662f * a[6] - 0.21850968f * a[8]; I do the computations with a formal computation software. Unfortunately I did not use the same for D3DXSHMultiply4 and D3DXSHMultiply3 ..... (Xcas vs Maple). And obtain the exact values look beyond the capacities of these softwares. And even the worst, since the integrated functions oscillate, the internal algorithm of the software are not robust to compute the integrals. For a given number of significative digits, that's why we obtain slightly different values for the both softwares. Addind defines will add tons on variables for no gain. But I can simplify slightly the function by calling D3DXSHMultiply3. I will give it a try. I worry about efficiency. Best regards Nozomi >Cheers >Rico

2 1

Re: oledb32: Add support for IDBInitialize interface in IDataInitialize
by Alexandre Julliard Sept. 26, 2012

Sept. 26, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Changelog: > oledb32: Add support for IDBInitialize interface in IDataInitialize It doesn't work here: ../../../tools/runtest -q -P wine -M oledb32.dll -T ../../.. -p oledb32_test.exe.so database.c && touch database.ok database.c:43: Test failed: Unable to load oledb library make[1]: *** [database.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (try 3) imm32: there is only 1 default Hwnd per thread
by Alexandre Julliard Sept. 26, 2012

Sept. 26, 2012

Aric Stewart <aric(a)codeweavers.com> writes: > - if (data->imeWnd == NULL) > + if (defWnd == NULL) > { > /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + defWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + SetWindowLongPtrW(defWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = defWnd; So now, shouldn't you be resetting IMMGWL_IMC at some point? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: (resend) imm32: there is only 1 default Hwnd per thread
by Alexandre Julliard Sept. 26, 2012

Sept. 26, 2012

Aric Stewart <aric(a)codeweavers.com> writes: > This corrects issues with applications that create and manage multiple IMCs > try 2: > avoid premature destruction of the window > --- > dlls/imm32/imm.c | 22 ++++++++++++---------- > dlls/imm32/tests/imm32.c | 28 ++++++++++++++++++++++++++++ > 2 files changed, 40 insertions(+), 10 deletions(-) > > > > diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c > index 7394101..a18aa26 100644 > --- a/dlls/imm32/imm.c > +++ b/dlls/imm32/imm.c > @@ -678,10 +678,6 @@ static BOOL IMM_DestroyContext(HIMC hIMC) > data->immKbd->pImeSelect(hIMC, FALSE); > SendMessageW(data->IMC.hWnd, WM_IME_SELECT, FALSE, (LPARAM)GetKeyboardLayout(0)); > > - if (IMM_GetThreadData()->hwndDefault == data->imeWnd) > - IMM_GetThreadData()->hwndDefault = NULL; > - DestroyWindow(data->imeWnd); > - > ImmDestroyIMCC(data->IMC.hCompStr); > ImmDestroyIMCC(data->IMC.hCandInfo); > ImmDestroyIMCC(data->IMC.hGuideLine); > @@ -2323,12 +2319,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > > if (data->imeWnd == NULL) > { > - /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > - data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > - 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + HWND def = IMM_GetThreadData()->hwndDefault; > + if (def == NULL) > + { > + /* create the ime window */ > + data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > + 0, data->immKbd->hIME, 0); > + SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = data->imeWnd; > + } > + else > + data->imeWnd = def; So why is there a window in the IMC at all, if it's not used for anything? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/8] vbscript: Added VT_R8 support to to_int
by Marvin Sept. 26, 2012

Sept. 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21824 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/8] vbscript: Added Round implementation
by Marvin Sept. 26, 2012

Sept. 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21823 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: d3dx9 [patch 1/5]: Implement D3DXSHMultiply4
by Rico Schüller Sept. 26, 2012

Sept. 26, 2012

On 26.09.2012 12:17, Nozomi Kodama wrote: > + ta =0.28209479f * a[0]+ 0.14567312f * a[8]+ 0.12615663f * a[6]; > + tb =0.28209479f * b[0]+ 0.14567312f * b[8]+ 0.12615663f * b[6]; > + out[13] += ta * b[13] + tb * a[13]; > + t = a[13] * b[13]; > + out[0] +=0.28209479f *t; Please use spaces with care. The preferred way is "x = 123 * a[0] + 456 * b[234]; Mostly one space is enough, only use two or more if you like to indent something, that's mostly not the case when calculating a value. Even then, please be consistent across your patch. > + D3DXSHMultiply4(c, a, b); What happens if you use something like D3DXSHMultiply4(c, c, c). Is that allowed? Also is there a reason why it uses slightly different values than e.g. D3DXSHMultiply3? Why don't we use defines? A problem might be to find good names... Maybe the Multiply functions could share the same base? To me it looks like they do share a lot of calculations, And if the order doesn't matter (see comment above) then it may be possible to rearrange the calculation. ta = 0.28209479f * a[0] - 0.12615663f * a[6] - 0.21850969f * a[8]; vs ta = 0.28209479f * a[0] - 0.12615662f * a[6] - 0.21850968f * a[8]; Cheers Rico

1 0

Re: winspool/tests: Don't crash when AddJob/GetJob fails (win8)
by Marvin Sept. 25, 2012

Sept. 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21799 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Wine Mono 0.0.6 Release - Because hey, why not?
by Vincent Povirk Sept. 25, 2012

Sept. 25, 2012

I have published version 0.0.6 of Wine Mono on Sourceforge, because it's probably not good to let it get too stale. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.6/wine-mono-0.0.… The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.6/wine-mono-0.0.… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.4: * Updated the visual basic class libraries from upstream. * Updated mono from 2.11.1 to 2.11.4. Unfortunately, there wasn't a nice changelog like 2.11.1 had. Here are some highlights: * Beginnings of support for hosting ActiveX controls inside winforms. (Alistair Leslie-Hughes) * Various HttpClient-related fixes. (Martin Baulig) * "Intermediate" state check boxes now rendered in winforms. (Steven Boswell II) * ACL support on Windows. (James Bellinger) * One can now specify WINE_MONO_TRACE=wrapper to log all transitions between native and managed code, which is sort of the Mono equivalent of a relay log. * RVA fields can now be accessed properly via the ldsfld[a] instruction. This should help with Managed C++ support. * Fix for winehq bug 30947 - Mono would cause a hang when a dll is loaded after Mono is loaded but before it is used to run any .NET code. * Because of a problem with the build system, MonoPosixHelper.dll was not present, and this prevented some builtin methods in Mono from working correctly. This has been resolved. * Added hashes for all included files in the msi package, which is needed for msi to replace the files on upgrade. * Added 64-bit registry entries to the msi package.

1 1

Re: imm32: there is only 1 default Hwnd per thread
by Alexandre Julliard Sept. 25, 2012

Sept. 25, 2012

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -2323,12 +2323,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > > if (data->imeWnd == NULL) > { > - /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > - data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > - 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + HWND def = IMM_GetThreadData()->hwndDefault; > + if (def == NULL) > + { > + /* create the ime window */ > + data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > + 0, data->immKbd->hIME, 0); > + SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = data->imeWnd; > + } > + else > + data->imeWnd = def; So what happens to the window if the first IMC is destroyed? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] iphlpapi: Set DhcpEnabled to TRUE for all interfaces.
by Juan Lang Sept. 25, 2012

Sept. 25, 2012

Hi Qian, > There is a winpcap based network authentication client which check for the DhcpEnabled value, this patch make the app happy and then the app works with André's pcap wrapper [1]. > > Please let me know if this is acceptable, or we have to correctly implement DhcpEnabled status? I think this is fine, but you'd want to remove/fix some outdated comments I wrote at the same time: * NOTES * Since GetAdaptersInfo never returns adapters that have DHCP enabled, * this function does nothing. * * FIXME * Stub, returns ERROR_NOT_SUPPORTED. */ DWORD WINAPI IpReleaseAddress(PIP_ADAPTER_INDEX_MAP AdapterInfo) { TRACE("AdapterInfo %p\n", AdapterInfo); /* not a stub, never going to support this (and I never mark an adapter as DHCP enabled, see GetAdaptersInfo, so this should never get called) */ The same comments are in IpRenewAddress. Historical reason: when I wrote iphlpapi's first implementation, I had recently been working on a Windows app that released and renewed IP addresses on DHCP-enabled interfaces, because Windows at the time was pretty poor at doing so in response to changes to wireless connection state. I figured I wouldn't be the only one to have had to work around this issue, so I didn't want to have to implement IpReleaseAddress and IpRenewAddress in Wine. That was almost 10 years ago now, so these reasons no longer apply. I'm pretty sure the app I wrote isn't in use any longer, and even if it is, it isn't in use on Wine (I also wrote a Linux version.) Thanks, --Juan

3 2

Re: vbscript: Added Space() implementation
by Marvin Sept. 25, 2012

Sept. 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21787 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] mshtml: Added DISPATCH_PROPERTYGET|DISPATCH_METHOD flags support for elements exposed as window properties
by Marvin Sept. 25, 2012

Sept. 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21785 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: shlwapi: PathCreateFromUrlA() should not crash when given NULL buffers.
by Alexandre Julliard Sept. 25, 2012

Sept. 25, 2012

Francois Gouget <fgouget(a)codeweavers.com> writes: > Add NULL and insufficient buffer tests for PathCreateFromUrl(). > --- > dlls/shlwapi/path.c | 3 +++ > dlls/shlwapi/tests/path.c | 49 +++++++++++++++++++++++++++++---------------- > 2 files changed, 35 insertions(+), 17 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M shlwapi.dll -T ../../.. -p shlwapi_test.exe.so path.c && touch path.ok path.c:322: Test succeeded inside todo block: got len = 22 expected 22 from url file:///localhost/c:/foo/bar path.c:322: Test succeeded inside todo block: got len = 19 expected 19 from url file://host//c:/foo/bar make: *** [path.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oledb32: Add support for IDBInitialize interface in IDataInitialize
by Marvin Sept. 25, 2012

Sept. 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21782 Your paranoid android. === WNT4WSSP6 (32 bit marshal) === marshal.c:66: Test failed: CoMarshalInterface failed with error 0x80040155 marshal.c:239: Test failed: "CoUnmarshalInterface" failed with error 0x8003001e marshal: unhandled exception c0000005 at 004165D0

2 1

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)
by Per Johansson Sept. 25, 2012

Sept. 25, 2012

Hi, I should probably add a note that when I wrote this I had some doubts it it belongs in start.exe, and I still somewhat do. The alternative would be to write a new program. The advantage to that is: 1. start.exe is left more similar to it's windows counterpart. 2. This other program could handle multiple files sent in the same AppleEvent, which is possible. 3. The same program could also act as a proxy for a dock icon, handling clicks and activating windows (this is a later project). I'd imagine it'd be called winehostproxy or somesuch and handle several types of interaction with the host (is that what we call it btw?). If you think that's more appropriate I can work on that instead of adding this to start. Regards, -- Per Johansson 2012/9/23 Per Johansson <pelle(a)morth.org> >

2 2

Re: [5/5] dxgi/tests: Test some reference counts.
by Alexandre Julliard Sept. 25, 2012

Sept. 25, 2012

Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> writes: > --- > dlls/dxgi/tests/device.c | 69 > ++++++++++++++++++++++++++++++++++------------ > 1 file changed, 51 insertions(+), 18 deletions(-) In general testing reference count values is not useful, unless you have an app that depends on it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Spam applications for testbot accounts
by Scott Ritchie Sept. 25, 2012

Sept. 25, 2012

Never underestimate the overeagerness of bots, I suppose... We're getting a lot of spam applications for testbot accounts now, maybe 2-3 per day. Some are easy to discard because they put stuff like penis pills into the info field, but others look like just names. Suggestions are welcome. In the meantime it would be nice if anyone requesting a legit account put some sort of non-spammy text in there like "Hey I'm a human I read wine-devel"

2 1

Overriding the check for ownership of a prefix
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 25, 2012

Sept. 25, 2012

Scott, I don't think you need to override this check, esp. given that there's a good reason for it being there: >Note that there is a problem with this setup if the app modifies the >registry and we then need to update the prefix-default registry I've excellent experience with symbolic links. In fact, none of the apps (games) I use are installed directly within any .wine prefix. Drive_c/Program Files/Games is a symbolic link to a large partition. >Imagine a distro package containing a Windows game in the form of a >read-only copy of an installed prefix (into, say, /opt). So I recommend the following setup: - Have the game's main directory be something like /opt/games/XYZ in UNIX, but tell it to install to C:\games/XYZ - During installation, write down all registry keys that the app creates and every file that it stores outside of its local directory. Beware: the name of the directory C:\Program.. depends upon every user's locale at .wine creation time! Use C:\Games\ instead to avoid that pitfall. For every user: - After .wine is created normally, add a symlink from Drive_c/Games to /opt/games - Add registry keys or dlls needed by the app. wineprefixcreate ln -s /opt/games/XYZ $HOME/.wine/drive_c/games cp -p whatever.dll $HOME/.wine/drive_c/windows/system32/ wine regedit xyz.reg Trivial, isn't it? Typically, you don't need to recreate the content of user-local APPDATA directories. The app will create them upon each run, since they ought to run with different users on one machine. Caveat: Although my .wine and games directories are distinct, I've no experience with write-protecting the games partition. Obviously, this only has a chance to work with modern apps, written after MS started recommending separating the app's dir from its per-local configuration files to be since stored in ~/LOCALAPPDATA or the like. Thus w9x/w2k-era games are ruled out. Still, I don't know where those apps attempt to store e.g. crash logs. I've seen apps write high-scores or savegames to their central directory when w2k was set in winecfg, and use HKCU/LOCALAPPDATA (what's the exact name?) when running in xp mode. I've made excellent experience with plenty of apps sharing a single .wine-games prefix with such a setup. I.e. you don't need one prefix per app. Like on a real box, the apps ought to be able to coexist. Drawback: when I was initially attracted to Wine 5 years ago, every .wine was a tiny 3-4MB. Nowadays it's more than 10 times that size, and I'm not happy with that. Using a single onion-union-fs to share drive_c/xyz may be interesting -- for as long as one single version of Wine is in use. Regards, Jörg Höhle

2 1

d3dx9: Implement D3DXSHEvalDirectionalLight
by Nozomi Kodama Sept. 24, 2012

Sept. 24, 2012

Hello, do it remain problems with this patch? Nozomi

1 0

Re: [PATCH] dmusic: Add master clock tests.
by Andrew Eikum Sept. 24, 2012

Sept. 24, 2012

On Sun, Sep 23, 2012 at 08:44:59PM +0200, Christian Costa wrote: > @@ -66,6 +68,11 @@ static void test_dmusic(void) > return; > } > > + hr = IDirectMusic_GetMasterClock(dmusic, &guid_clock, &clock); > + ok(hr == S_OK, "IDirectMusic_GetMasterClock returned: %x\n", hr); > + ok(clock != NULL, "No clock returned\n"); > + trace(" guidPort = %s\n", debugstr_guid(&guid_clock)); > + Minor nit-pick: you never release the clock.

1 0

Re: [PATCH 2/2] mshtml: Added function overriding tests
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21757 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] jscript: Added support for limit argument in String.split
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21756 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: Assorted spelling fixes.
by Julian Rüger Sept. 24, 2012

Sept. 24, 2012

Hi Francois, > - /* if we set the bufferpointer to NULL here UrlUnescape fails and string gets not converted */ > + /* if we set the buffer pointer to NULL here UrlUnescape fails and the string is not converted */ for consistency with the other buffer pointer comments and better readability, I suggest you add a comma here: + /* if we set the buffer pointer to NULL here, UrlUnescape fails and the string is not converted */ Best regards, Julian

1 0

Re: [PATCH 4/4] mshtml: Added IHTMLElement::contains implementation
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21753 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] mshtml: Added function overriding tests
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21751 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

RFC: Locale-independent case-insensitive string comparison
by Francois Gouget Sept. 24, 2012

Sept. 24, 2012

diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 28f82a3..f465ad7 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -640,7 +640,7 @@ static void HTTP_FixURL(http_request_t *request) } } - if(CSTR_EQUAL != CompareStringW( LOCALE_SYSTEM_DEFAULT, NORM_IGNORECASE, + if(CSTR_EQUAL != CompareStringW( LOCALE_INVARIANT, NORM_IGNORECASE, request->path, strlenW(request->path), szHttp, strlenW(szHttp) ) && request->path[0] != '/') /* not an absolute path ?? --> fix it !! */ { In this code snippet it feels wrong to have this string comparison depend on the system locale, which in Wine's case would come from the user's Unix locale. Isn't this a case where LOCALE_INVARIANT would be better? However I have not found a case where this makes a difference anyway, either with 'http:' or with 'file:'. That is, 'file:' always matches 'FILE:', even in Turkish, as long as I don't use NORM_LINGUISTIC_CASING. Conversely, 'fîle:' is different from 'FILE:' no matter what. Once I have a CompareString() test-case I can make some for UrlIs(), PathCreateFormURL(), possibly ShellExecute(), etc. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [PATCH] d3dx9_36: Cube texture can be loaded as a simple texture. The first face texture is taken in that case.
by Józef Kucia Sept. 24, 2012

Sept. 24, 2012

Hi, On Sun, Sep 23, 2012 at 8:44 PM, Christian Costa <titan.costa(a)gmail.com>wrote: > + hr = IDirect3DTexture9_LockRect(texture, 0, &lock_rect, NULL, > D3DLOCK_READONLY); > + ok(hr == D3D_OK, "IDirect3DTexture9_LockTexture returned %#x, > expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) > + for (i = 0; i < 16; i++) > + ok(((BYTE*)lock_rect.pBits)[i] == dds_cube_map[128+i], > "Byte at index %u is 0x%02x, expected 0x%02x\n", i, > ((BYTE*)lock_rect.pBits)[i], dds_cube_map[144+i]); > + IDirect3DTexture9_Release(texture); > You should call IDirect3DTexture9_UnlockRect before IDirect3DTexture9_Release.

2 1

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.
by Henri Verbeet Sept. 24, 2012

Sept. 24, 2012

On 23 September 2012 22:40, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > > +struct refresh_rates { Formatting. > +struct refresh_rates refresh_list[] = This should be static const. > + ok(hr == E_INVALIDARG, "GetDesc unexpectedly returend %#x.\n", hr); "returned". > + for (i = 0; i < sizeof(refresh_list)/sizeof(struct refresh_rates); i++) I generally prefer "sizeof(*refresh_list)", or perhaps "sizeof(refresh_list[0])" over "sizeof(struct refresh_rates)" in this kind of situation. > + "Numerator %d is %d.\n", i, result_desc.BufferDesc.RefreshRate.Numerator); These are unsigned variables.

1 0

Re: [3/4] dxgi: Avoid division by zero. Based on patch by Eduard - Gabriel Munteanu.
by Henri Verbeet Sept. 24, 2012

Sept. 24, 2012

On 23 September 2012 22:40, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > +static UINT dxgi_rational_to_uint(DXGI_RATIONAL *rational) "rational" should be const.

1 0

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.
by Józef Kucia Sept. 24, 2012

Sept. 24, 2012

On Sun, Sep 23, 2012 at 10:40 PM, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > +struct refresh_rates refresh_list[] = > +{ > + {60, 60, FALSE, FALSE}, > + {60, 0, TRUE, FALSE}, > + {60, 1, TRUE, TRUE}, > + { 0, 60, TRUE, FALSE}, > + { 0, 0, TRUE, FALSE}, > +}; It's probably better to declare it inside test_createswapchain(). It could also be static const. > + hr = IDXGISwapChain_Release(swapchain); > + ok(hr == 0, "Release failed, hr %d.\n", hr); It should be assigned to refcount. > + hr = IDXGIFactory_Release(factory); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); > + > + hr = IDXGIAdapter_Release(adapter); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); > + > + hr = IUnknown_Release(obj); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); Release doesn't return HRESULT and the value returned by Release shouldn't be tested with SUCCEEDED. refcount = IDXGIFactory_Release(factory); ok(!refcount, "ID3DXGIFactory has %u references left\n", refcount);

1 0

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.
by Alexandre Julliard Sept. 24, 2012

Sept. 24, 2012

Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> writes: > --- > dlls/dxgi/tests/Makefile.in | 2 +- > dlls/dxgi/tests/device.c | 147 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 148 insertions(+), 1 deletion(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dxgi.dll -T ../../.. -p dxgi_test.exe.so device.c && touch device.ok device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. make: *** [device.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Assorted spelling fixes.
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21742 Your paranoid android. === W2K3R2SESP2 (32 bit sync) === sync.c:972: Test failed: DeleteTimerQueueTimer

1 0

Re: [7/8] windowscodecs: Calculate transparent color index for global GIF palette.
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21729 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/8] windowscodecs: Add some tests for GIF palette.
by Vincent Povirk Sept. 24, 2012

Sept. 24, 2012

Series looks good to me.

1 0

WineHQ on CMS/Framework
by Kyle Auble Sept. 23, 2012

Sept. 23, 2012

After working on the wiki for a while, I finally wanted to ask about possibly moving WineHQ to a CMS or web framework. First off, while there are a couple of mentions on the wiki and mailing lists, is there still much interest in doing this? If there is, I think the second question is which kind of system do we want to use? While http://wiki.winehq.org/WinehqDesign mentions Drupal, which has a lot of plugins and features for easy editing, I've read that a CMS can become a hassle if your website needs to do more complex things than serving regular chunks of content. WineHQ provides a bug-tracker, a forum, a wiki, mailing lists, source-code browsers, and other tools besides static content, with lots of interconnections between them. If we did go with a web framework, we could still probably run a CMS on top of it for the AppDB and static pages. Finally, for the frameworks, it seems that one of the main differences is simply which language we want to deal with. Is there a strong preference for using a specific language? Right now the various parts outside of Wine proper use a mix of Perl, PHP, and Python. This also raises the question of whether there's any desire to (over the very long term) try consolidating all the code outside Wine around one or two languages. I'm guessing it wouldn't be worth the trouble (different tools for different jobs), but if there is a strong reason to, it would probably be good to pick a framework in the language we want to emphasize. - Kyle

2 2

re: Question from new developer
by Dan Kegel Sept. 23, 2012

Sept. 23, 2012

Chris wrote: > 1. I discovered later that I don't think this is the root of my > original bug - and in fact doesn't seem to affect behavior of my > program. Is it still worth submitting? Generally, fixes are more likely to get committed when they don't break anything (did you run all the conformance tests?), their tests cases pass on all versions of windows (did you send your patch to testbot?), improve the behavior of a real program (I don't think you have demonstrated this yet), and are written from a position of relatively deep understanding. So you might want to find a more solid fix for your first submission. Welcome, and good luck! - Dan

1 0

Re: comctl32/listview: update dwStyle before checking for scrollbar
by Nikolay Sivov Sept. 23, 2012

Sept. 23, 2012

On 9/21/2012 23:07, Daniel Jelinski wrote: > dwStyle is updated only in WM_STYLECHANGED, which is not sent > when displaying and hiding scrollbars. > Fixes the issue where there was a large margin between items > and horizontal scrollbar (e.g. in file open dialog). Are you sure it's really not supposed to be sent when WS_HSCROLL/WS_VSCROLL bits are changed? A quick test with ControlSpy shows style changing messages when I set/reset these. So it's possible there's a bug outside of comctl32.

2 4

Question from new developer
by Chris Teague Sept. 23, 2012

Sept. 23, 2012

I submitted bug 31753 for an application that I use, and started making an attempt to fix it. I started with the last few messages from the log: fixme:win:LockWindowUpdate (0x501c4), partial stub! fixme:win:LockWindowUpdate ((nil)), partial stub! wine: Unhandled page fault on read access to 0x00000023 at address 0x78680087 (thread 0009), starting debugger... Looking at LockWindowUpdate(), I discovered that it had no conformance tests. I wrote a few covering all the possible scenarios I could think of (only 4 of them), and ran them on wine as well as cross compiling them and running on XP. To my surprise, one of the tests fails on wine, but passes on WinXP! This was great news, so I dug a little further. Specifically the problem was attempting to do a "unlock" operation by passing NULL, when the the function was already unlocked. Windows treats this as an error and returns 0, while wine returns 1. So I fixed it, patch is attached (also at: https://dl.dropbox.com/u/477050/0001-Fixed-LockWindowUpdate.txt) I have two big questions: 1. I discovered later that I don't think this is the root of my original bug - and in fact doesn't seem to affect behavior of my program. Is it still worth submitting? I do believe it alleviates the need for the "fixme" in the LockWindowUpdate function. 2. If it is worth submitting, could someone take a look at it and point out all the dumb things I've done? I'm happy with the logic of the code, but I'm sure I've done something horribly wrong in terms of doing it the preferred way. Thanks, Chris Teague

2 1

Re: [3/3] gdiplus: Add an ability to cache bitmap properties and use distinct metadata loaders for different image formats. Take 2.
by Vincent Povirk Sept. 21, 2012

Sept. 21, 2012

This looks good to me.

1 0

Re: scrrun: Correct Invoke parameter
by Jacek Caban Sept. 21, 2012

Sept. 21, 2012

Hi Alistair, On 09/21/12 14:12, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > scrrun: Correct Invoke parameter > --- a/dlls/scrrun/dictionary.c +++ b/dlls/scrrun/dictionary.c @@ -153,7 +153,7 @@ static HRESULT WINAPI dictionary_Invoke(IDictionary *iface, DISPID dispIdMember, hr = get_typeinfo(IDictionary_tid, &typeinfo); if(SUCCEEDED(hr)) { - hr = ITypeInfo_Invoke(typeinfo, &iface, dispIdMember, wFlags, + hr = ITypeInfo_Invoke(typeinfo, This, dispIdMember, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr); This really should be an interface, not an object. &This->IDistionary_iface or simply iface would be the right thing to do. Jacek

1 0

Re: [3/3] gdiplus: Add an ability to cache bitmap properties and use distinct metadata loaders for different image formats.
by Vincent Povirk Sept. 20, 2012

Sept. 20, 2012

> @@ -2123,6 +2125,8 @@ static void move_bitmap(GpBitmap *dst, GpBitmap *src, BOOL clobber_palette) > if (dst->metadata_reader) > IWICMetadataReader_Release(dst->metadata_reader); > dst->metadata_reader = src->metadata_reader; > + dst->prop_count = src->prop_count; > + dst->prop_item = src->prop_item; > if (dst->image.stream) > IStream_Release(dst->image.stream); > dst->image.stream = src->image.stream; I think you should be freeing dst->prop_item here. > @@ -2850,6 +2923,12 @@ GpStatus WINGDIPAPI GdipGetAllPropertyItems(GpImage *image, UINT size, > > if (prop_count != count || prop_size != size) return InvalidParameter; > > + if (((GpBitmap *)image)->prop_item) > + { > + memcpy(buf, ((GpBitmap *)image)->prop_item, prop_size); > + return Ok; > + } > + > reader = ((GpBitmap *)image)->metadata_reader; > if (!reader) return PropertyNotFound; I think you have to change the values here so they point into the user buffer. > +typedef GpStatus (*metadata_reader_func)(GpBitmap *bitmap, IWICBitmapDecoder *decoder, UINT frame); ... > + if (metadata_reader) > + metadata_reader(bitmap, decoder, active_frame); > + else if (IWICBitmapFrameDecode_QueryInterface(frame, &IID_IWICMetadataBlockReader, (void Either your metadata reader function should return void, or you should check the returned status. Otherwise, this looks good to me.

1 0

Re: jscript: Added support for RegExp.$* properties
by Marvin Sept. 20, 2012

Sept. 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21683 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin Sept. 20, 2012

Sept. 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [8/8] winemenubuilder: Implement OS X application bundles. (try 2)
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21663 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [7/8] winemenubuilder: Use a dispatch table to access XDG specific parts, extracted to different file.
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21662 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: shell32: Add tests for ShellExecute()'s handling of file URLs. (try2)
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21655 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === Timeout === W2KPROSP4 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 === WVISTAADM (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W2K8SE (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PRO (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PROX64 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === TEST64_W7SP1 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PROX64 (64 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === TEST64_W7SP1 (64 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.
by Juan Lang Sept. 19, 2012

Sept. 19, 2012

Hi Francois, pretty sure you didn't mean to leave this hunk in: @@ -2296,9 +2406,13 @@ START_TEST(shlexec) init_test(); +#if 0 test_argify(); test_lpFile_parsed(); test_filename(); +#endif + test_fileurl(); +#if 0 test_find_executable(); test_lnks(); test_exes(); @@ -2308,6 +2422,7 @@ START_TEST(shlexec) test_commandline(); test_directory(); test_trojans(); +#endif --Juan

1 0

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21649 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] scrrun: Moved creating filesystem object to its own function
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -194,13 +245,33 @@ HRESULT WINAPI DllUnregisterServer(void) > > HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID* ppv) > { > + scrruncf *This; > + HRESULT hr = CLASS_E_CLASSNOTAVAILABLE; > + > + TRACE("(%s, %s, %p): stub\n", debugstr_guid(rclsid), debugstr_guid(riid), ppv); > + > + if(!ppv) > + return E_INVALIDARG; > + > + This = HeapAlloc(GetProcessHeap(), 0, sizeof(scrruncf)); > + > + This->IClassFactory_iface.lpVtbl = &scrruncf_vtbl; > + This->pfnCreateInstance = NULL; > + This->ref = 1; > + > if(IsEqualGUID(&CLSID_FileSystemObject, rclsid)) { > - TRACE("(CLSID_WshShell %s %p)\n", debugstr_guid(riid), ppv); > - return IClassFactory_QueryInterface(&FileSystemFactory, riid, ppv); > + TRACE("(CLSID_FileSystemObject %s %p)\n", debugstr_guid(riid), ppv); > + This->pfnCreateInstance = &create_filesystem; > + This->clsid = IID_IFileSystem3; > + } You could just as well continue using static instances of the class factory, and using the IID as a clsid doesn't make much sense. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] user32/tests: Add tests for class small icons (try 3).
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Sergey Guralnik <serhio(a)etersoft.ru> writes: > +todo_wine > + ok( hsmicon != NULL, "GetClassLong should return non-zero handle\n"); > + for(i = 0; i < 100; i++) > + if(hsmicon != (HICON)GetClassLongPtrW(hwnd, GCLP_HICONSM)) > + { > + ok(FALSE, "Always should return the same icon handle\n"); > + break; > + } This doesn't make sense, it's not going to return the same thing 99 times and then suddenly something different. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ole32: Add CoGetDefaultContext stub
by Michael Stefaniuc Sept. 19, 2012

Sept. 19, 2012

Hallo Alistair, > --- > dlls/ole32/compobj.c | 9 +++++++++ > dlls/ole32/ole32.spec | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c > index 0055d15..2ea1dc9 100644 > --- a/dlls/ole32/compobj.c > +++ b/dlls/ole32/compobj.c > @@ -4279,6 +4279,15 @@ HRESULT WINAPI CoGetContextToken( ULONG_PTR *token ) > return S_OK; > } > > +/*********************************************************************** > + * CoGetContextToken [OLE32.@] copy and paste error ^^^ > + */ > +HRESULT CoGetDefaultContext(APTTYPE type, REFIID riid, LPVOID *ppv) bye michael

2 1

user32/tests: Add tests for class small icons (try 3).
by Sergey Guralnik Sept. 19, 2012

Sept. 19, 2012

There are two patches that stay at queue more than weeek, and have no comments yet: From 5c723835fb9b8b56ccaf2a22256524c84b358fe9 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Tue, 11 Sep 2012 10:24:56 +0400 Subject: [PATCH 1/2] user32/tests: Add tests for class small icons (try 3). From 49d6118117ccfb4efecbb9839b279cc286b19392 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Tue, 11 Sep 2012 13:40:54 +0400 Subject: [PATCH 2/2] user32: Add internal class small icons functionality (try 3). Is something wrong with them? -- Sergey

1 0

user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik Sept. 19, 2012

Sept. 19, 2012

Alexandre Julliard writes: > Not really. If you want to test purely the Wine behavior, then you > shouldn't be waiting for window manager events. If the window manager > is > involved then you can't guarantee that a given window will always get > focus. > If your app breaks because the window manager doesn't give it focus > at a > certain point, then pretty much the only solution is to change the wm > policy, or use a different wm. Thanks for explanations. -- Sergey

1 0

Re: [PATCH 3/3] jscript: Added support for no new line between return and expression rule
by Marvin Sept. 18, 2012

Sept. 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21637 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386
by Jacek Caban Sept. 18, 2012

Sept. 18, 2012

Please ignore this last patch. It has one more dependency that I didn't send yet. On 09/17/12 15:21, Jacek Caban wrote: > --- > dlls/jscript/jsutils.c | 4 +- > dlls/jscript/jsval.h | 143 > +++++++++++++++++++++++++++++++++++++---------- > 2 files changed, 114 insertions(+), 33 deletions(-) >

2 2

Re: [PATCH 3/6] vbscript: Added support for do..loop statement without an expression
by Marvin Sept. 18, 2012

Sept. 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21628 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/6] vbscript: Added Len implementation
by Marvin Sept. 18, 2012

Sept. 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21627 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] vbscript: Fixed parsing if statements with empty body
by Marvin Sept. 18, 2012

Sept. 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21626 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] jscript: Added support for host objects being part of scope chain
by Marvin Sept. 18, 2012

Sept. 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21625 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] oleaut32/tests: Don't take the size of a pointer (Clang).
by Michael Stefaniuc Sept. 18, 2012

Sept. 18, 2012

Hello Charles, On 09/18/2012 07:51 AM, Charles Davis wrote: > From: Charles Davis <cdavis(a)mymail.mines.edu> > > Contrary to what a novice C programmer might expect, when you declare an > array parameter to a function, what you actually get is a pointer. > Therefore, using sizeof() on the parameter will return the size of a > pointer, and not 8*sizeof(UINT) as was intended here. Since the array was please fix it in a way to not confuse a novice C programmer; e.g. passing it a pointer to a MYSTRUCT. That way you can avoid the magic constant 8 too. > explicitly declared as being 8 elements long, just use the number 8 in > the for loop instead. > --- > dlls/oleaut32/tests/tmarshal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/oleaut32/tests/tmarshal.c b/dlls/oleaut32/tests/tmarshal.c > index be8ef94..ad56123 100644 > --- a/dlls/oleaut32/tests/tmarshal.c > +++ b/dlls/oleaut32/tests/tmarshal.c > @@ -596,10 +596,10 @@ static HRESULT WINAPI Widget_VarArg( > } > > > -static BOOL mystruct_uint_ordered(UINT uarr[8]) > +static BOOL mystruct_uint_ordered(UINT uarr[]) > { > int i; > - for (i = 0; i < sizeof(uarr) / sizeof(uarr[0]); i++) > + for (i = 0; i < 8; i++) > if (uarr[i] != i) > return 0; > thanks bye michael

1 0

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 3.
by Dmitry Timoshkov Sept. 17, 2012

Sept. 17, 2012

Hi, Can I please get a feedback on this gdiplus series along with another one "gdiplus: Add some tests for GIF properties." ? -- Dmitry.

2 1

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik Sept. 17, 2012

Sept. 17, 2012

Alexandre Julliard wrote: > Sergey Guralnik <serhio at etersoft.ru> writes: > >> I've sent next patch more than month ago, and have no comments about >> it. >> >> From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 >> 2001 >> From: Sergey Guralnik <serhio at etersoft.ru> >> Date: Thu, 9 Aug 2012 17:12:56 +0400 >> Subject: user32/tests: Add test for SetFocus() (with few todo)(Try >> 2). >> >> Is anything wrong with this one? > > That's mostly testing the window manager focus policy, I don't think > that makes sense. What are you trying to demonstrate with this? I try to show that some applications rely on finishing all side focus switching, which are result of call to some window management function, before this function returns. For example my app hopes that result of call to SetFocus() will not be distorted in message loop due call to DestroyWindow(), that made before call to SetFocus(). Is my explanation clear enough? -- Sergey

2 1

Re: d3dx9 [patch 1/2]: Implement D3DXSHEvalDirectionalLight
by Rico Schüller Sept. 17, 2012

Sept. 17, 2012

On 17.09.2012 00:33, Nozomi Kodama wrote: > + { { rout, gout, bout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, ... > + { rout, bout, gout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, > + { bout, rout, gout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, I think it doesn't make much sense to test this, they are doing basically all three the same. The name of the variable doesn't matter. Besides we test for (rout, rout, rout), these might be good to test: (rout, gout, gout), (rout, rout, bout), (rout, gout, rout). Maybe the naming of the variables is a bit confusing... I used the starting name for the name, hence you could also use the expected value name or rename the variables to out1, out2, out3 to not make confusion with the expected / started color. Though I'm fine with all cases... > + } > + > + startindex += order * order; > + } I would indent the startindex... Some style comments (I have no strong opinion about that, just like to mention it): The brackets "()" in &(table[90]) could be left out. You may also break the longer lines into two. Though, I don't know the actual recommended line length, but 200 seems a bit long... I only found this http://www.winehq.org/pipermail/wine-devel/2010-September/086996.html . Cheers Rico

2 1

Wine Mono update
by Alistair Leslie-Hughes Sept. 16, 2012

Sept. 16, 2012

Hi, Mono 2.11.4 has been released which contains a few patches which removes most of the exceptions from the AxHost class. This class has been the cause of a few applications from starting (DDO and LOTRO launchers to name a few) I purpose a new wine-mono to be built. What sort of milestones should we look for to trigger a new wine-mono release? Best Regards Alistair Leslie-Hughes

1 0

very slow updating of client area
by Andrew Makhorin Sept. 16, 2012

Sept. 16, 2012

Hello, Please see below a function that processes WM_PAINT message. Being run under Wine this function updates the client area (50x120 chars) about 50 times slower than under Windows XP. Could anyone please explain me what might be wrong and suggest how to fix that? Thank you, Andrew Makhorin /*********************************************************************** * update_panel_area - update client area of panel window * * This routine updates the client area of the window associated with * the specified panel. (It is called when the panel window procedure * receives the message WM_PAINT.) */ void update_panel_area(PANELX *px) { PAINTSTRUCT ps; HFONT old_hfont; HPEN old_hpen, hpen; int row, col, row1, row2, col1, col2; xassert(px != NULL); /* if the update region is empty, do nothing */ if (!GetUpdateRect(px->window, NULL, FALSE)) goto done; /* start updating */ BeginPaint(px->window, &ps); old_hfont = SelectObject(ps.hdc, px->hfont); hpen = CreatePen(PS_SOLID, 0, 0x000000); old_hpen = SelectObject(ps.hdc, hpen); /* given the update region, determine which rows and columns of the display area should be updated (note that the update region reported by BeginPaint does not include right-most and bottom-most pixels, so we subtract 1 in order not to update an extra row and column out of the update region) */ row1 = 1 + ps.rcPaint.top / px->fy; row2 = 1 + (ps.rcPaint.bottom - 1) / px->fy; col1 = 1 + ps.rcPaint.left / px->fx; col2 = 1 + (ps.rcPaint.right - 1) / px->fx; /* updating is performed according to information in the buffer array of the panel display area (see rpsed.h) */ for (row = row1; row <= row2; row++) { for (col = col1; col <= col2; col++) { FMTCHAR c; int x, y; char buf[1]; /* get formatted character at position (row,col) */ if (1 <= row && row <= px->p->nrows+1 && 1 <= col && col <= px->p->ncols+1) c = px->p->c[row][col]; else c = px->p->std_char[FMT_SPACE]; /* paint this character */ x = (col - 1) * px->fx; y = (row - 1) * px->fy; SetTextColor(ps.hdc, palette->value[c.f]); SetBkColor(ps.hdc, palette->value[c.b]); SetBkMode(ps.hdc, OPAQUE); buf[0] = c.c; TextOut(ps.hdc, x, y, buf, 1); /* paint the underline, if specified */ if (c.a & FMT_UNDERLINE) { SetBkMode(ps.hdc, TRANSPARENT); TextOut(ps.hdc, x, y, "_", 1); } /* paint the vertical bar, if specified */ if (c.a & FMT_MARGIN) { MoveToEx(ps.hdc, x, y, NULL); LineTo(ps.hdc, x, y + px->fy); } } } /* finish updating */ SelectObject(ps.hdc, old_hfont); SelectObject(ps.hdc, old_hpen); DeleteObject(hpen); EndPaint(px->window, &ps); done: return; }

1 0

Re: d3dx9_36 [patch 1/2]: Implement D3DXSHEvalDirectionalLight
by Rico Schüller Sept. 14, 2012

Sept. 14, 2012

On 14.09.2012 11:07, Nozomi Kodama wrote: > Hello > > one remark about this patch. > > Test in real windows shows that D3DXSHEvalDirectionalLight accepts order > > D3DXSH_MAXORDER or order < D3DXSH_MINORDER. > But in these cases, the colour outputs are unpredictable. For the same > calling arguments, D3DSXHEvalDirectionalLight returns different colours. > > That explains the simplicity of the implementation of this function. > > Nozomi. > + FLOAT s, temp[max( 1, order * order )]; Is this allowed in c and does it really work the way one would expect? + for (order = D3DXSH_MINORDER; order <= D3DXSH_MAXORDER; order++) ... + if ( ( order == 0 ) || ( j >= order * order ) ) Why would you check for order == 0? That's imho never the case that this is true. At least if you only test from D3DXSH_MINORDER onward. + unsigned int j, order, start[] = {0, 4, 13, 29, 54}; Using the start[] looks a bit ugly ... why don't you calculate the index? + expected = table[start[order - 2] + j]; ! You've again trailing white spaces. What happens in the following test case? Which result is returned? D3DXSHEvalDirectionalLight(order, &dir, 1.7f, 2.6f, 3.5f, rout, rout, rout); Well the implementation seems to be correct, but it may be nice to test for this as well. Maybe in another patch. Cheers Rico

2 1

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik Sept. 14, 2012

Sept. 14, 2012

I've sent next patch more than month ago, and have no comments about it. From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Thu, 9 Aug 2012 17:12:56 +0400 Subject: user32/tests: Add test for SetFocus() (with few todo)(Try 2). Is anything wrong with this one? -- Sergey

2 1

Re: [PATCH] advapi32: Eliminate dead stores (Clang).
by Alexandre Julliard Sept. 14, 2012

Sept. 14, 2012

Charles Davis <cdavis5x(a)gmail.com> writes: > @@ -615,9 +613,9 @@ static DWORD mac_write_credential(const CREDENTIALW *credential, BOOL preserve_b > attr_list.count = 0; > attr_list.attr = NULL; > } > - status = SecKeychainItemModifyAttributesAndData(keychain_item, &attr_list, > - preserve_blob ? 0 : strlen(password), > - preserve_blob ? NULL : password); > + SecKeychainItemModifyAttributesAndData(keychain_item, &attr_list, > + preserve_blob ? 0 : strlen(password), > + preserve_blob ? NULL : password); I expect you'd want to handle that error instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] windowscodecs: Implement Graphic Control Extension metadata reader.
by Marvin Sept. 14, 2012

Sept. 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21585 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/4] windowscodecs: Implement Image Descriptor metadata reader.
by Marvin Sept. 14, 2012

Sept. 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21584 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: vcomp: better stub for _vcomp_fork
by Alexandre Julliard Sept. 13, 2012

Sept. 13, 2012

Dan Kegel <dank(a)kegel.com> writes: > @@ -41,6 +42,80 @@ double CDECL omp_get_wtime(void) > return GetTickCount() / 1000.0; > } > > +/* Call helper with the ncount args after ncount */ > +extern void WINAPIV _vcomp_fork(DWORD parallel, int ncount, void *helper, ...); > +#ifdef __i386__ > +__ASM_GLOBAL_FUNC( _vcomp_fork, > + "push %ebp\n\t" > + "movl %esp,%ebp\n\t" > + > + /* Push varargs */ > + "movl 12(%ebp),%ecx\n\t" /* if (nargs > 0) */ > + "test %ecx,%ecx\n\t" > + "jz copyend\n\t" > + "leal 20(%ebp),%edx\n\t" /* dx -> first vararg */ > + "leal (%edx,%ecx,4),%edx\n\t" /* dx += nargs * sizeof arg */ > + "copyloop:\n\t" /* while (nargs-- > 0) */ > + "sub $4,%edx\n\t" > + "pushl (%edx)\n\t" /* push next vararg */ > + "dec %ecx\n\t" > + "jnz copyloop\n\t" > + "copyend:\n\t" > + > + /* Call helper and return */ > + "call *16(%ebp)\n\t" > + "movl %ebp,%esp\n\t" > + "pop %ebp\n\t" > + "ret\n\t" > + ) > +#endif There are several places that already implement that sort of thing the right way, you should copy one of them instead of reinventing the wheel. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9_36 [patch 1/2: try 2]: Implement D3DXSHEvalDirectionalLight
by Alexandre Julliard Sept. 13, 2012

Sept. 13, 2012

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > @@ -2231,6 +2231,40 @@ FLOAT* WINAPI D3DXSHEvalDirection(FLOAT *out, UINT order, CONST D3DXVECTOR3 *dir > return out; > } > > +HRESULT WINAPI D3DXSHEvalDirectionalLight(UINT order, CONST D3DXVECTOR3 *dir, FLOAT Rintensity, FLOAT Gintensity, FLOAT Bintensity, FLOAT *Rout, FLOAT *Gout, FLOAT *Bout) > +{ > + FLOAT s, temp[36]; > + UINT j; > + > + TRACE("Order %u, Vector %p, Red %f, Green %f, Blue %f, Rout %p, Gout %p, Bout %p\n", order, dir, Rintensity, Gintensity, Bintensity, Rout, Gout, Bout); > + > + if ( order > D3DXSH_MAXORDER ) > + { > + FIXME("This case is not implemented yet. Anyway, following to MSDN, this case should not happen\n"); > + > + return D3D_OK; > + } You should test the expected results for that case too, the implementation should be easy either way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] ntdll: Add more complete implementation of NtPowerInformation
by Alexandre Julliard Sept. 13, 2012

Sept. 13, 2012

James Eder <jimportal(a)gmail.com> writes: > @@ -2261,7 +2242,19 @@ NTSTATUS WINAPI NtInitiatePowerAction( > SystemAction,MinSystemState,Flags,Asynchronous); > return STATUS_NOT_IMPLEMENTED; > } > - > + > +#ifdef linux > +static int have_cpufreq(void) > +{ > + FILE* f = fopen("/sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq", "r"); > + if(f) > + { > + fclose(f); > + return 1; > + } > + return 0; > +} > +#endif You don't want to open a file just to see if you will be able to open it for real later on. You'll need to check the subsequent open anyway, so you can do the fallback at that point. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] jscript: Don't leave current scope in return statement before evaluating the expression
by Marvin Sept. 13, 2012

Sept. 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21565 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/6] mshtml: Added IHTMLDocument4::fireEvent implementation
by Marvin Sept. 13, 2012

Sept. 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21559 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Translations of the About Pages
by Kyle Auble Sept. 13, 2012

Sept. 13, 2012

I just submitted a draft rewrite of WineHQ's About page in English that integrates some things from the wiki page, but there are still Hebrew and Spanish about pages on the wiki. I started working on translating the Spanish one, but realized someone else should probably do it after one paragraph, and my Hebrew is even weaker. I think the goal is still to move all central pages to WineHQ so I'd like to remove those versions from the wiki soon too. If any Hebrew or Spanish-speaking contributors would prefer to work from the wiki content though, I can leave it up for a while. If you would rather translate from the new English version to keep the different translations in sync though, I'll go ahead and clean up the wiki some more. - Kyle

1 0

Re: [2/2] windowscodecs: Create Graphic Control Extension metadata block for a GIF frame.
by Marvin Sept. 13, 2012

Sept. 13, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21552 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] windowscodecs: Create Image Descriptor metadata block for a GIF frame.
by Vincent Povirk Sept. 13, 2012

Sept. 13, 2012

> + stream = create_stream(&IMD_data, sizeof(IMD_data)); Er, where is create_stream defined? I don't see it in git or a previous patch.

2 1

dssenh: implementing the dssenh cryptographic service provider
by Marek Chmiel Sept. 12, 2012

Sept. 12, 2012

Hello all, over the summer I had a chance to complete the regression test suite for the DSSENH cryptographic provider; thank you to those that helped along the way. I am currently researching how to implement the actual provider, and any suggestions would be greatly appreciated. A question I have is: RSAENH AND DSSENH both use the same encryption algorithms (I am not 100% sure about that yet), so for example could I use one that was written for RSAENH or shall I write those functions on my own using Libtomcrypt? Thank you. --Marek

2 1

Re: ddraw: Don't print a fixme for the flags in DirectDrawEnumerateExA; they don't change the outcome
by Michael Stefaniuc Sept. 12, 2012

Sept. 12, 2012

After talking to Henri on irc, please ignore this patch. There are patches out there to enumerate more devices than the primary one and then the flags do play a role. On 09/12/2012 11:08 PM, Michael Stefaniuc wrote: > --- > dlls/ddraw/main.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/dlls/ddraw/main.c b/dlls/ddraw/main.c > index 61e8ec9..b79b12e 100644 > --- a/dlls/ddraw/main.c > +++ b/dlls/ddraw/main.c > @@ -377,12 +377,9 @@ HRESULT WINAPI DirectDrawEnumerateExA(LPDDENUMCALLBACKEXA Callback, void *Contex > DDENUM_NONDISPLAYDEVICES)) > return DDERR_INVALIDPARAMS; > > - if (Flags) > - FIXME("flags 0x%08x not handled\n", Flags); > - > TRACE("Enumerating default DirectDraw HAL interface\n"); > > - /* We only have one driver by now */ > + /* We have only one driver (primary) which is always enumerated regardless of the flags */ > __TRY > { > static CHAR driver_desc[] = "DirectDraw HAL", > bye michael

1 0

Re: [PATCH 4/4] ntdll: Add more complete implementation of NtPowerInformation
by Ken Thomases Sept. 12, 2012

Sept. 12, 2012

On Sep 12, 2012, at 2:17 PM, James Eder wrote: > - valSize = sizeof(longVal); > - if (!sysctlbyname("hw.cpufrequency", &longVal, &valSize, NULL, 0)) > - cpuHz = longVal; I haven't tried building, but this would still leave the warning about longVal being declared but never used, right? I don't see you removing that declaration. Regards, Ken

1 0

Re: [2/2] windowscodecs: Add a bunch of GIF metadata tests.
by Marvin Sept. 12, 2012

Sept. 12, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21528 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msls31: Add stub dll.
by Austin English Sept. 11, 2012

Sept. 11, 2012

On Tue, Sep 11, 2012 at 9:32 AM, Josh DuBois <duboisj(a)codeweavers.com> wrote: > Presence of a stub of msls31.dll allows Visio 2003 to open .svg files, which > it fails to do without the stub. > Visio 2003 does complain that some values in the files are missing or of the > incorrect data type when opening these files, but it will nonetheless open > them and can edit them successfully when the stubbed .dll is present. @@ -0,0 +1,79 @@ +70 stub LssbFDoneDisplay +65 stub LsCompressSubline +1 stub LsCreateContext +3 stub LsCreateLine ..etc. Does it really need them by ordinal? The spec files are typically sorted alphabetically by function name, e.g.,: +@ stub LsCompressSubline +@ stub LsCreateContext +@ stub LsCreateLine +@ stub LssbFDoneDisplay ..etc. Some other minor things: A) you don't need to include the changes to configure, just configure.ac. B) Your comments are formatted a bit strange /* --------------------------------------------------------------- ** msls31.dll ** Copyright CodeWeavers, Inc. ** Created: 9/10/2012 by Josh DuBois for CodeWeavers. most files have: /* * msls31.dll * * Copyright 2012 Josh DuBois for CodeWeavers, Inc. * */ similar for your comment about preferring the native version. Welcome to Wine! -- -Austin

2 1

Re: [PATCH 5/5] ntdll: Add more complete implementation of NtPowerInformation
by James Eder Sept. 11, 2012

Sept. 11, 2012

I've sent a patch set that I need some help testing. The first four in the series should be fine as they don't change anything specific to a particular platform. The last one however makes some changes which are platform specific (affects Linux, Apple, and various BSDs). I've tested the Linux code but I do not have an Apple, for example, to test that code. While the code looks good to me and is is largely based off of code removed from fill_cpu_info(), it is still worth some concern that it hasn't seen any real testing. If you have a Mac or BSD, I would be grateful if you could try the patches out to make sure things are working as expected. You'll find a few more details in the commit message http://source.winehq.org/patches/data/89698 . Also of concern is that the testbot seems to have only one processor. This results in most of the tests added in http://source.winehq.org/patches/data/89697 being skipped. So testbot doesn't seem that helpful for this test. As for the implementation of the test itself, would it be better to use broken() and just test Wine for the Win7 behavior? From my testing, the test as is works for XP, Win7, and Wine with my patch set. If we can write the test to work everywhere, don't use broken()? There are more details in the patch itself so please have a look and let me know what you think. -- Jim

2 2

Re: wininet: disable TLSv1.1/1.2 by default
by Hiroshi Miura Sept. 11, 2012

Sept. 11, 2012

Hi, Are there any comment for it? It is a motivation that Evernote windows client cannot connect its server on Wine/OpenSSL 1.0.1. it is caused by server is only support TLS1.0/SSL3.0 , apache2/openssl 0.9.8 thing, but client ask TLS1.1/1.2 and then server returns that session is fails. I know wininet(in Microsoft implementation) has a behavior to re-try by TLS1.0 after TLS1.2 fails. It is discussed in IETF TLS maillist http://www.ietf.org/mail-archive/web/tls/current/msg08218.html How do you think whether we should implement similar way or not? If we adopt similar fall back mechanism, compatibility may become well, but is it good behavior? Hiroshi On 2012.08.26 11:51, Hiroshi Miura wrote: > > OpenSSL 1.0.x now support TLSv1.1 and TLSv1.2 > but Windows7 is disabled by default. > > Schannel registry indicate TLSv1.1/1.2 config. > > It fixes the error of Evernote client connection. > http://bugs.winehq.org/show_bug.cgi?id=30598 > > Signed-off-by: Hiroshi Miura <miurahr(a)linux.com> > --- > dlls/wininet/netconnection.c | 68 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > > > > >

2 1

Re: [PATCH] secur32/schannel: diabled TLS1.1/1.2 by Default
by Marcus Meissner Sept. 10, 2012

Sept. 10, 2012

On Mon, Sep 10, 2012 at 12:14:51AM +0900, Hiroshi Miura wrote: > -Set TLS1.1/1.2 disabled by Default that is > same as Windows 7 default. > > See registry entry for schannel and control > enable/disable tls versions. > > It also see grbitEnabledProtocols defined in > credentials that take precedence over registry. I think the regression issue with TLS 1.1/1.2 is the "empty fragments" sending, right? Perhaps we can just disable that and not all of TLS 1.1/1.2? Ciao, Marcus

2 1

Re: [PATCH 3/5] gdi32: Fixed localized font style name.
by Qian Hong Sept. 10, 2012

Sept. 10, 2012

Hello, On Tue, Sep 11, 2012 at 1:05 AM, Qian Hong <fracting(a)gmail.com> wrote: > and the symbol font bug (with todo_wine because it need to be fixed in [PATCH 4/5].) Sorry for a typo, should be: with todo_wine because it need to be fixed in [PATCH 5/5]. Thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

1 0

Re: [PATCH 2/3] jscript: Added support for no new line between continue and identifier rule
by Marvin Sept. 10, 2012

Sept. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21489 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] jscript: Added support for no new line between break and identifier rule
by Marvin Sept. 10, 2012

Sept. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21488 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: mshtml: Added support for navigating to anchors with IDs containing '#'
by Alexandre Julliard Sept. 10, 2012

Sept. 10, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/navigate.c | 42 +++++++++++++++++++++++++++++++++++++++--- > dlls/mshtml/nsiface.idl | 11 +++++++++++ > 2 files changed, 50 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmldoc.c && touch htmldoc.ok htmldoc.c:4650: Test failed: unexpected riid {5C8B21BC-EF6E-4599-A26F-FACC05B4ADBE} make: *** [htmldoc.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 5/5] vbscript: Added support for VT_NULL in stack_pop_bool
by Marvin Sept. 10, 2012

Sept. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21486 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/5] vbscript: Added support for comparing to null
by Marvin Sept. 10, 2012

Sept. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21485 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/5] mshtml: Check if value is function only when it needs to be in invoke_builtin_prop
by Marvin Sept. 10, 2012

Sept. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21484 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/5] mshtml: Use first script host's GUID as default script guid
by Marvin Sept. 10, 2012

Sept. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21483 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/9] mshtml: Use first script host's GUID as default script guid
by Alexandre Julliard Sept. 10, 2012

Sept. 10, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > dlls/mshtml/htmlwindow.c | 1 - > dlls/mshtml/mshtml_private.h | 1 - > dlls/mshtml/script.c | 18 ++++++++++-------- > dlls/mshtml/tests/vbtest.html | 15 +++++++++++++-- > 4 files changed, 23 insertions(+), 12 deletions(-) It doesn't work here on 64-bit: ../../../../wine/tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so ../../../../wine/dlls/mshtml/tests/script.c && touch script.ok script.c:620: Test failed: L"got an exception" script.c:620: Test failed: L"counter = 3" make: *** [script.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] secur32/schannel: diabled TLS1.1/1.2 by Default
by Henri Verbeet Sept. 9, 2012

Sept. 9, 2012

On 2 September 2012 10:58, Hiroshi Miura <miurahr(a)linux.com> wrote: > > -Set TLS1.1/1.2 disabled by Default that is > same as Windows 7 default. > Aside from whether disabling TLS1.1+ is appropriate or not, or if this is the right implementation, this patch also add %COMPAT to the priority string, which wasn't there before.

2 1

Wine, fullscreen applications, and RandR 1.2
by Andy Ritger Sept. 8, 2012

Sept. 8, 2012

Hello wine developers, I work on NVIDIA's Linux graphics driver team, and have a few questions about how Wine should interact with X driver mode lists. Sorry if this isn't the correct forum for these questions. Starting in release 302.xx, we finally added RandR 1.2 support to NVIDIA's X driver. At the same time, we reworked some things about how modetimings are validated and configured by the NVIDIA X driver. For the following, the important part is that we eliminated implicit flat panel scaling, and instead made it explicitly configurability through NVIDIA's MetaMode syntax and through RandR 1.2. The user-visible change is that only modes reported by a digital flat panel's EDID are in the mode list for an RandR output. A little background: modern GPUs (at least NVIDIA, and I expect other vendors) have a flexible display scaling pipeline that consists of: * A "RasterSize": this is the resolution of pixels that will be sent to the monitor; this is what people normally think of as the size of the "mode". * A "ViewPortIn": this is the resolution of pixels that the display engine will fetch from the X screen. * A "ViewPortOut": this is the region _within_ the RasterSize to which the pixels of ViewPortIn should be sent. The pixels fetched in ViewPortIn can be scaled up or down by specifying different sizes for ViewPortIn and ViewPortOut. Also, letterboxing and overscan compensation can be configured by making ViewPortOut smaller than RasterSize. For example, if your monitor accepts a mode of 1920x1200, and you want a desktop resolution of 1280x720 aspect-scaled to fill 1920x1200 (i.e., 1280x720 scaled to 1920x1080, with 60 blank scanlines above and below it in a 1920x1200 mode), then in NVIDIA MetaMode syntax you could do: "1920x1200 { ViewPortIn = 1280x720, ViewPortOut = 1920x1080+0+60 }" While the MetaMode syntax is NVIDIA-specific, the same can be configured through RandR: * The RandR transformation matrix can be used to describe the scaling between ViewPortOut and ViewPortIn. * The RandR "Border" output property can be used, when available, to describe a ViewPortOut that is smaller than the RasterSize. Note: most RandR X drivers, including NVIDIA, don't yet provide this property, though I'm in the process of adding it for NVIDIA. In practice this means that most resolutions (i.e., not just a fixed modelist), from the perspective of desktop size, are achievable with RandR. Questions: * Looking at dlls/winex11.drv/xrandr.c, the first RandR CRTC/output's modelist is used to populate Wine's list of available modes. Is the data flow between Wine and Windows applications always such that you need to advertise a list of (width, height, refreshRate)s? Or would an application ever tell Wine what resolution it wants? * Would you be open to patches to make dlls/winex11.drv/xrandr.c generate a larger set of (width, height, refreshRate)s, and then have xrandr12_set_current_mode() use RandR transformation matrix and Border property to satisfy those? I was envisioning something where we take the "preferred" mode for the RandR output, and create all of the following resolutions using ViewPort{In,Out}: 1920 x 1200 1920 x 1080 1600 x 1200 1280 x 1024 1280 x 720 1024 x 768 800 x 600 640 x 480 * The current xrandr.c code picks the first CRTC/output, which may not be currently active. At the least, it should scan for an active CRTC+output. I imagine it would be even better if the user could configure which RandR output they want. Would that be reasonable? What mechanisms are available in Wine for users to provide runtime configuration? * From the current code, it does not look like Wine's RandR support tries to do anything with multiple simultaneous RandR outputs. Ironically: this actually works better with RandR 1.1 + NVIDIA: users can configure their MetaModes to describe what mode (plus viewport configuration) they want on each monitor, and then RandR 1.1 chooses the MetaMode. Would it make sense for the user to be able to specify to Wine the RandR configuration (spanning all of the RandR outputs on the X screen)? I guess that depends on what runtime configuration mechanisms are possible. I'm curious what you guys think, before I code up any patches to propose. Thanks, - Andy Ritger

2 8

Re: [PATCH 1/2] gdi32/tests: Added tests for symbol fonts.
by Marvin Sept. 8, 2012

Sept. 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21461 Your paranoid android. === W7PROX64 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === W7PROX64 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular

2 1

Re: [PATCH 2/2] gdi32: Fixed get_name_table_entry for symbol fonts.
by Marvin Sept. 8, 2012

Sept. 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21462 Your paranoid android. === W7PROX64 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === W7PROX64 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular

1 0

Re: [2/5] vcomp: add better stub for _vcomp_fork (resend)
by Marvin Sept. 7, 2012

Sept. 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21417 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

2 2

Re: [PATCH 2/2] user32: Correct class small icons behavior (try 2).
by Sergey Guralnik Sept. 7, 2012

Sept. 7, 2012

On 2012-09-07 15:24, Sergey Guralnik wrote: > This patch based on MSDN's description of WNDCLASSEX structure: ... hIconSm: Handle to a small icon that is associated with the window class. If this member is NULL, the system searches the icon resource specified by the hIcon member for an icon of the appropriate size to use as the small icon. ... -- Sergey

1 0

Re: [PATCH 9/9] vbscript: Added support for VT_NULL in stack_pop_bool
by Marvin Sept. 7, 2012

Sept. 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21447 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 8/9] vbscript: Added support for comparing to null
by Marvin Sept. 7, 2012

Sept. 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21446 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 7/9] mshtml: Check if value is function only when it needs to be in invoke_builtin_prop
by Marvin Sept. 7, 2012

Sept. 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21445 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/9] mshtml: Use first script host's GUID as default script guid
by Marvin Sept. 7, 2012

Sept. 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21444 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] user32: Correct class small icons behavior.
by Marvin Sept. 7, 2012

Sept. 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21433 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 1/2] user32/tests: Added test for class icons handling.
by Marvin Sept. 7, 2012

Sept. 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21432 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 4/5] gdi32: Added font name tests on non English locale.
by Alexandre Julliard Sept. 7, 2012

Sept. 7, 2012

Qian Hong <fracting(a)gmail.com> writes: > @@ -4110,7 +4120,9 @@ static void test_fullname2_helper(const char *Family) > > bufW[0] = 0; > bufA[0] = 0; > - ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size), "FAMILY (family name) could not be read\n"); > + ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, GetSystemDefaultLangID()) || > + get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, TT_MS_LANGID_ENGLISH_UNITED_STATES), You should avoid that sort of thing, it will be hard to debug, particularly since get_ttf_nametable_entry itself has ok() calls. Store the result in a variable instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/3] user32: Implement RegisterRawInputDevices().
by Alexandre Julliard Sept. 7, 2012

Sept. 7, 2012

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > @@ -2931,3 +2965,14 @@ DECL_HANDLER(set_cursor) > reply->new_clip = input->desktop->cursor.clip; > reply->last_change = input->desktop->cursor.last_change; > } > + > +DECL_HANDLER(update_rawinput_devices) > +{ > + const struct rawinput_device *devices = get_req_data(); > + unsigned int i; > + > + for (i = 0; i < req->device_count; ++i) > + { > + update_rawinput_device(&devices[i]); > + } > +} device_count is redundant (and unsafe), this should use the data size instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/5] vcomp: better stubs for _vcomp_for_static_simple_init, _vcomp_for_static_end
by Marvin Sept. 7, 2012

Sept. 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21419 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [3/5] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next
by Marvin Sept. 7, 2012

Sept. 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21418 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 2.
by Dmitry Timoshkov Sept. 7, 2012

Sept. 7, 2012

I hope that I've addressed Vincent's concern about todo_wine blanket coverage, is there anything else that prevents these 2 patches from being accepted? -- Dmitry.

1 0

Re: [PATCH 4/6] msvcp60: Fixed RTTI structure on 64-bit systems (try2)
by Alexandre Julliard Sept. 6, 2012

Sept. 6, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > try2: > - fixed base pointer offset calculation (patches 4,5,6) You should pass the module handle from DllMain instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] kernel32: Return correct drive type for empty drives (try2)
by Alexandre Julliard Sept. 6, 2012

Sept. 6, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -2544,7 +2544,8 @@ static NTSTATUS DVD_ReadStructure(int dev, const DVD_READ_STRUCTURE *structure, > } > > if (ioctl(dev, DVD_READ_STRUCT, &s) < 0) > - return STATUS_INVALID_PARAMETER; > + /* Will be converted into ERROR_INVALID_FUNCTION */ > + return (errno == ENOMEDIUM) ? STATUS_INVALID_DEVICE_REQUEST : STATUS_INVALID_PARAMETER; That doesn't make much sense, you probably want to use FILE_GetNtStatus. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] [cmd] move issues when overwriting files
by Alexandre Julliard Sept. 6, 2012

Sept. 6, 2012

Ann and Jason Edmeades <jason(a)edmeades.me.uk> writes: > @@ -1709,8 +1709,13 @@ void WCMD_move (void) > WINE_TRACE("Source '%s'\n", wine_dbgstr_w(src)); > WINE_TRACE("Dest '%s'\n", wine_dbgstr_w(dest)); > > - /* If destination exists, prompt unless /Y supplied */ > - if (GetFileAttributesW(dest) != INVALID_FILE_ATTRIBUTES) { > + /* If we have src == dest, skip moving this one */ > + if (strcmpW(src,dest)==0) ok = FALSE; You can't detect identical files by comparing file names. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 6/6] msvcrt: Fixed RTTI structure on 64-bit systems
by Alexandre Julliard Sept. 6, 2012

Sept. 6, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcrt/cpp.c | 129 > ++++++++++++++++++---------------------------------- > dlls/msvcrt/cxx.h | 114 +++++++++++++++++++++++++++++++++++++++++++++-- > 2 files changed, 155 insertions(+), 88 deletions(-) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M msvcrt.dll -T ../../.. -p msvcrt_test.exe.so ../../../../wine/dlls/msvcrt/tests/cpp.c && touch cpp.ok cpp.c:405: Test failed: bad rtti for e wine: Unhandled exception 0xe06d7363 at address 0x7b84a70a (thread 0025), starting debugger... Unhandled exception: C++ exception(object = 0x0022f870, type = 0x2b780f15a760) in 64-bit code (0x000000007b84a70a). Register dump: rip:000000007b84a70a rsp:000000000022f680 rbp:00002b780f1635f0 eflags:00000202 ( - -- I - - - ) rax:000000000022f6c0 rbx:000000000022f6a0 rcx:000000000022f6a0 rdx:0000000000000000 rsi:000000000022f838 rdi:000000000022f6d8 r8:00002b780f15a760 r9:000000000022f820 r10:2161746164204954 r11:00002b780d5712b0 r12:000000000022fa90 r13:0000000000013198 r14:000000007b8739b0 r15:00007fffffbe8000 Stack dump: 0x000000000022f680: 000000000022f6a0 ff000000ffffff00 0x000000000022f690: 0000000000000000 0000000000000000 0x000000000022f6a0: 00000001e06d7363 0000000000000000 0x000000000022f6b0: 000000007b84a70a 0000000000000003 0x000000000022f6c0: 0000000019930520 000000000022f870 0x000000000022f6d0: 00002b780f15a760 000000000022f870 0x000000000022f6e0: 000000000022f858 00002b780ef3c000 0x000000000022f6f0: 000000000022f858 0000000000000021 0x000000000022f700: 0000000000013198 000000007b8739b0 0x000000000022f710: 00007fffffbe8000 00002b780eefafdc 0x000000000022f720: 00000002c0000005 0000000000000000 0x000000000022f730: 00002b780d54eb28 00002b780d3224e0 Backtrace: =>0 0x000000007b84a70a RaiseException+0xba(code=<is not available>, flags=<is not available>, nbargs=<is not available>, args=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/except.c:85] in kernel32 (0x00002b780f1635f0) 1 0x00002b780eee29c1 _CxxThrowException+0x30(object=<is not available>, type=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/../../../wine/dlls/msvcrt/cpp.c:1109] in msvcrt (0x00002b780f1635f0) 2 0x00002b780eee3242 MSVCRT___RTtypeid+0x171(cppobj=0x2b780f1635f0) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/../../../wine/dlls/msvcrt/cpp.c:901] in msvcrt (0x00002b780f1635f0) 3 0x00002b780ec60326 func_cpp+0x20c5() [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/tests/../../../../wine/dlls/msvcrt/tests/cpp.c:411] in msvcrt_test (0x00002b780f1635f0) 4 0x00002b780ec5c82c main+0x28b(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/tests/../../../../wine/include/wine/test.h:557] in msvcrt_test (0x0000000000000003) 5 0x00002b780ec8dc42 __wine_spec_exe_entry+0xa1(peb=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/winecrt0/../../../wine/dlls/winecrt0/exe_entry.c:36] in msvcrt_test (0x00002b780d2f38f0) 6 0x000000007b873a61 start_process+0xb0(peb=0x7fffffbef000) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1052] in kernel32 (0x00002b780ec8dba0) 7 0x00002b780db5982e call_thread_func+0x6d(entry=0x7b8739b0, arg=0x7fffffbef000, frame=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/signal_x86_64.c:3230] in ntdll (0x00007fff5630f450) 8 0x00002b780db52f1a call_thread_entry_point+0x29() in ntdll (0x00007fff5630f450) 9 0x00002b780db24a56 start_process+0x15(kernel_start=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2653] in ntdll (0x00007fff5630f450) 10 0x00002b780cfcd283 wine_call_on_stack+0x12() in libwine.so.1 (0x00007fff5630f450) 11 0x00002b780cfcd2d9 wine_switch_to_stack+0x8(func=<is not available>, arg=<is not available>, stack=<is not available>) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/port.c:59] in libwine.so.1 (0x00007fffffbef000) 12 0x00002b780db2a500 LdrInitializeThunk+0x45f(kernel_start=0x7b8739b0, unknown2=<is not available>, unknown3=<is not available>, unknown4=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2709] in ntdll (0x00007fffffbef000) 13 0x000000007b879ebd __wine_kernel_init+0x91c() [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1255] in kernel32 (0x00002b780ddbb800) 14 0x00002b780db2ad74 __wine_process_init+0x143() [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2918] in ntdll (0x00007fff56310700) 15 0x00002b780cfcb488 wine_init+0x297(argc=0x3, argv=0x7fff56310bf8, error="", error_size=0x400) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/loader.c:831] in libwine.so.1 (0x00007fff56310700) 16 0x000000007bf00da2 main+0x71(argc=0x3, argv=0x7fff56310bf8) [/home/julliard/wine/build/obj-elf64/loader/../../wine/loader/main.c:230] in <wine-loader> (0x00007fff56310bf8) 17 0x00002b780d55dead __libc_start_main+0xfc(main=<is not available>, argc=<is not available>, ubp_av=<is not available>, init=<is not available>, fini=<is not available>, rtld_fini=<is not available>, stack_end=0x7fff56310be8) [/home/aurel32/eglibc-sid/eglibc-2.13/csu/libc-start.c:228] in libc.so.6 (0x0000000000000000) 18 0x000000007bf00e9d _start+0x28() in <wine-loader> (0x0000000000000000) 0x000000007b84a70a RaiseException+0xba [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/except.c:85] in kernel32: 85 } -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Add AMD Radeon HD 7700 series and HD 7800 series graphics cards
by Henri Verbeet Sept. 6, 2012

Sept. 6, 2012

On 6 September 2012 15:27, Jiang Yike <futureway(a)asia.com> wrote: > This patch adds the recognition of AMD Radeon HD 7700 series and HD 7800 > series graphics cards. > This patch has whitespace errors.

1 0

Re: [PATCH 5/5] mshtml: Added VBScript as event attribute tests
by Marvin Sept. 6, 2012

Sept. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21412 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

2 1

Re: [3/3] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next (resend)
by Marvin Sept. 6, 2012

Sept. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21408 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [2/3] vcomp: better stub for _vcomp_fork (resend)
by Marvin Sept. 6, 2012

Sept. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21407 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [3/3] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next
by Marvin Sept. 6, 2012

Sept. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21405 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] vcomp: better stub for _vcomp_fork
by Marvin Sept. 6, 2012

Sept. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21404 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] hhctrl.ocx: Resize the window when HH_SET_WIN_TYPE is called (try 3, resend 2).
by Alexandre Julliard Sept. 5, 2012

Sept. 5, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > @@ -266,7 +266,7 @@ void MergeChmProperties(HH_WINTYPEW *src, HHInfo *info) > if (merge & HHWIN_PARAM_PROPERTIES) dst->fsWinProperties = src->fsWinProperties; > if (merge & HHWIN_PARAM_STYLES) dst->dwStyles = src->dwStyles; > if (merge & HHWIN_PARAM_EXSTYLES) dst->dwExStyles = src->dwExStyles; > - if (merge & HHWIN_PARAM_RECT) dst->rcWindowPos = src->rcWindowPos; > + if (merge & HHWIN_PARAM_RECT || override) dst->rcWindowPos = src->rcWindowPos; > if (merge & HHWIN_PARAM_NAV_WIDTH) dst->iNavWidth = src->iNavWidth; > if (merge & HHWIN_PARAM_SHOWSTATE) dst->nShowState = src->nShowState; > if (merge & HHWIN_PARAM_INFOTYPES) dst->paInfoTypes = src->paInfoTypes; You still need to check the source flags. -- Alexandre Julliard julliard(a)winehq.org

1 0

Building winetest-latest.exe?
by Dan Kegel Sept. 5, 2012

Sept. 5, 2012

Hi folks, how does one build the native version of winetest.exe? I looked around a bit, and didn't see any obvious instructions. http://www.winehq.org/pipermail/wine-devel/2011-July/091144.html touches on it, but doesn't say much. I ask because I'm interested in tracking down why testbot doesn't think vcomp.dll is installed. ( cf. http://www.winehq.org/pipermail/wine-devel/2012-August/096642.html ) - Dan

5 7

Re: d3dx9_36 [try 4 ]: Implement D3DXSHRotate
by Rico Schüller Sept. 5, 2012

Sept. 5, 2012

On 05.09.2012 08:02, Nozomi Kodama wrote: + out[15] = -0.9682458639f * in[13] + 0.25f * in[15]; ! You didn't find all trailing white spaces. I made a !, so it could be seen. You could easily get around that by changing your editors preference. Most editors are able to remove that automatically (see e.g. for vim http://vim.wikia.com/wiki/Remove_unwanted_spaces) You may also have a look at http://wiki.winehq.org/GitWine#head-b20b05157175835751686365f9818ae978ceca23 . Both are really easy to use. Be warned, that's not the only occurrence, so please look carefully if you remove them by hand. What you get from a comment to a patch are only hints. But you may check for all mentioned hints to the specific patch (even to previous tries), if you have fulfilled them or you may add a comment why you think the hint is bad. If you don't understand a hint, please ask - before sending another try, sometimes the hints could be wrong and sometimes they are worth to think about it. That's all I have to say, there won't be any more comments from my side to this patch. I need my time to get my own screwed up patches into wine. :-) Cheers Rico

1 0

Re: [PATCH 1/3] [cmd] "PATH=value" fails whereas "PATH value" works
by Marvin Sept. 4, 2012

Sept. 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21386 Your paranoid android. === WVISTAADM (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

2 1

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes.
by Vincent Povirk Sept. 4, 2012

Sept. 4, 2012

> match = memcmp(dst_8x1, td[i].image, sizeof(dst_8x1)) == 0; > + if (!match) > + todo_wine ok(match, "%d: data should match\n", i); > + else > ok(match, "%d: data should match\n", i); This sort of thing makes me nervous. Couldn't you do this in such a way that we'll notice if the existing tests break, like adding a todo field to the structure?

1 0

Re: d3dx9_36 [try 3]: Implement D3DXSHRotate
by Rico Schüller Sept. 4, 2012

Sept. 4, 2012

On 04.09.2012 13:19, Nozomi Kodama wrote: + FLOAT expected, in[100], out[100], ... + for (i = 0; i < 49; i++) + in[i] = i + 1.01f; I guess this belongs together. I'd like to make some suggestions, please don't take it personally. When you got a comment on a patch, read it carefully. Think about it, if it makes sens to do the change (just adding what I've said is not always the best, it just gives you a hint, that you may improve some things, the list is not always complete and different people may have different suggestions) and try to improve your patch. After you are done, read your patch. Well mistakes happen, especially when you try to get something done really fast. (1) Take you some time and read it again and see if you've done that as best as possible and if you are happy with the code you've done, then submit it. If you've found a bug don't submit, fix it and go to #1. The earlier a bug is found the cheaper is it to solve it. I hope this helps a bit and it hopefully saves you some time to get a patch in the feature accepted. Thought I'd like to thank you for your patience and hopefully I haven't annoyed you and we'll see some good quality patches in the feature from you. :-) Cheers Rico

3 4

Re: wininet: Set last error for invalid URL argument
by Marvin Sept. 4, 2012

Sept. 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21380 Your paranoid android. === W2KPROSP4 (32 bit internet) === Timeout

1 0

Re: [2/2] gdiplus: Add preliminary support for pixel offset modes.
by Vincent Povirk Sept. 4, 2012

Sept. 4, 2012

> return sample_bitmap_pixel(src_rect, bits, width, height, > - gdip_round(point->X), gdip_round(point->Y), attributes); > + point->X + pixel_offset, point->Y + pixel_offset, attributes); > + } This is going to break tiling. By removing gdip_round you're implicitly truncating the number instead of flooring, which will give you the wrong result when X or Y is negative. I suggest explicitly adding a floorf.

1 0

Re: jscript: Fixed empty cases in the end of switch statement
by Marvin Sept. 4, 2012

Sept. 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21379 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/4] mshtml: Properly expose frame and iframe element's windows to scripts
by Marvin Sept. 4, 2012

Sept. 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21376 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Wine Gecko 1.8-beta1
by Jacek Caban Sept. 4, 2012

Sept. 4, 2012

Hi all, It's time for another Gecko update. I've uploaded to SourceForge [1] new Gecko builds. These are based on Firefox 16 beta. Other than tons of changes inherited from Firefox and usual fixes to keep it working well for us, it brings a few visible fixes: - Proper <noscript> tag handling - Synchronous ActiveX loading - Possibility to properly call APIs requiring JSContext - Possibility to implement HTMLStyleElement::styleSheet property As usually, to test it you need the attached patch and Gecko build placed in the right place [2]. Any help with testing is appreciated! On related note, I seriously consider dropping debug builds and replace them by unstripped release build or even just a separated package containing only debug symbols for the release build. Here are my thoughts about reasoning (in random order): - People use debug build mostly to retrieve better backtraces. Unstripped builds also give that ability. - If someone really needs debug build, it's easy enough to build it himself (and that's usually a good idea anyway) - Debug builds are seriously different than release build, so it occasionally exposes different set of problems, leading to invalid assumptions. This is really something for developers rather than users. - It costs my time spent builds and tests. And I consider it a serious matter. Amount of work needed to keep Gecko relevant is constantly growing. I try to mitigate it by doing long-term improvements upstream, automating the process and improving my hardware, but that has its limits. And the time spent on Gecko maintenance (as in pure maintenance, not real improvements) costs Wine in terms of improvements I could make in this time. If someone has a reason to keep debug builds, let me know. Any comments are welcomed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.8-beta1/ [2] http://wiki.winehq.org/Gecko

3 3

Re: d3dx9_36 [try 2]: Implement D3DXSHRotate
by Rico Schüller Sept. 4, 2012

Sept. 4, 2012

On 03.09.2012 20:59, Nozomi Kodama wrote: > Thanks Rico and Henri for your help. > > Nozomi > > > The patch looks much better now. But I have some minor things which I didn't mention last time... + ok(received_ptr == out, "order %u, Expected %p, received %p\n", order, out, received_ptr); We may write the variables all starting with upper or lower char, maybe the first word will start with a upper char and the rest with a lower char. The mixture as is looks a bit ugly, doesn't it? Please have a look at the surrounding code, but not at test_D3DXSHRotateZ. ;-) And of course only going til 7 we won't need the in/out array till 100. 49 should fit, shouldn't it? That would be reducing the time spend in the for loops, even if it's only the test... Cheers Rico

1 0

vcomp.dll, vcomp90.dll missing on testbot?
by Dan Kegel Sept. 3, 2012

Sept. 3, 2012

I'm trying to test a better set of stubs for vcomp.dll and its ilk, but those dlls don't seem to be installed on testbot. Is vcomp{,90,100}.dll not installed by default on Windows? If not, should we install it on a few of the VMs?

3 9

Re: [PATCH 1/6] mshtml: Moved getting frame by name to separated function
by Alexandre Julliard Sept. 3, 2012

Sept. 3, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/htmlwindow.c | 127 > ++++++++++++++++++++++++++-------------------- > 1 files changed, 72 insertions(+), 55 deletions(-) gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -Werror -I/usr/include/freetype2 -g -O2 -o htmlwindow.o htmlwindow.c htmlwindow.c: In function ‘HTMLWindow2_item’: htmlwindow.c:416:13: error: variable ‘hres’ set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors make: *** [htmlwindow.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.
by Alexandre Julliard Sept. 3, 2012

Sept. 3, 2012

Alex Henrie <alexhenrie24(a)gmail.com> writes: > I was asked to split this patch up, so I did. The complaint about the > last version was "You are still overflowing the source." I have not > been able to find any test case that my implementation handled > incorrectly, however, I did find that (*src == 0 && srclen < 0) will > never evaluate to true, so I removed this if statement from the code. I > also changed example #2 in the tests to be slightly more stringent, but > the last patch would also have passed. > > If this patch series is rejected, please show me a test case that > demonstrates what I am doing wrong. You don't have a single test with an explicit source length, so obviously you are not going to find problems in that area. Like I said, you need a lot more tests. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] msctf: also free the sink in the non-source branch (Coverity)
by Marvin Sept. 3, 2012

Sept. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21357 Your paranoid android. === TEST64_W7SP1 (32 bit inputprocessor) === inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink

1 0

Re: wined3d: Use backup swapchain DC for devices created with desktop window.
by Henri Verbeet Sept. 3, 2012

Sept. 3, 2012

On 3 September 2012 00:51, Adam Jakubek <ajakubek(a)gmail.com> wrote: > Hi, > > This patch causes wined3d to use backup swapchain DC when > IDirect3DDevice9 is created using the desktop window. > Windows allows to create such device as long its type is > D3DDEVTYPE_REF or D3DDEVTYPE_NULLREF. > > Unpatched Wine will fail in IDirect3D9_CreateDevice method, since it > incorrectly uses the X root window. > > Relevant d3d test case is included. > Patch closes bug #18490. > How is actual rendering to the desktop window supposed to work?

2 1

Re: [PATCH 6/6] mshtml: Added IHTMLIFrameElement3 stub implementation
by Marvin Sept. 3, 2012

Sept. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21355 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:5225: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:5262: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === WVISTAADM (32 bit dom) === dom.c:5225: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:5262: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002

1 0

Re: d3dx9_36: Implement D3DXSHRotate
by Rico Schüller Sept. 3, 2012

Sept. 3, 2012

I had another look and like to give some suggestion. On 02.09.2012 22:28, Nozomi Kodama wrote: + sinb = sqrt( 1.0f - matrix->u.m[2][2] * matrix->u.m[2][2] ); I'd prefer to declare the variables as locally as possible. + D3DXSHRotateZ(temp5, order, alpha, temp4); + memcpy(out, temp5, sizeof(float) * order * order); + + return out; You probably may avoid the memcpy. What do you think about something like: return D3DXSHRotateZ(out, order, alpha, temp4); + FLOAT alpha, beta, gamma, sinb, temp1[36], temp2[36], temp3[36], temp4[36], temp5[36]; Do we really need that much temps? I think one is enough, but definitively 2 (I think you are able to use out as one "temp"). If you don't like the usage of out, you may use temp2 instead, but I think it could be avoided. D3DXSHRotateZ(out, order, gamma, in); RotateX(temp, order, 1, out); D3DXSHRotateZ(out, order, beta, temp); RotateX(temp, order, 0, out); D3DXSHRotateZ(out, order, alpha, temp); +static FLOAT* RotateX(FLOAT *out, UINT order, UINT pm, FLOAT *in) The return value is never used. Probably you may return void or you'd like to stack the function calls above a bit and reuse the returned pointer. You also may use "BOOL pm" since it uses only 0 and 1 or you may pass the "FLOAT a" directly to the function. Whatever pm stands for... Cheers Rico

2 1

Re: [PATCH] kernel32: add condition variables prototypes and tests (2nd try)
by Dmitry Timoshkov Sept. 3, 2012

Sept. 3, 2012

Marcus Meissner <meissner(a)suse.de> wrote: > + if (!pInitializeConditionVariable) { > + skip("no condition variable support.\n"); > + return; > + } Probably this should be a win_slip(). > + /* fprintf(stderr,"produced %d, c1 %d, c2 %d\n", totalproduced, cnt1, cnt2); */ > + > + /* The sleeps of the producer or consumer should not go above 10000, otherwise > + * the implementation does not sleep correctly. */ > + > + /* fprintf(stderr,"producer sleep %d, consumer sleep %d\n", condvar_producer_sleepcnt, condvar_consumer_sleepcnt); */ There is trace() for debug output, it's shorter and more convenient IMHO. -- Dmitry.

4 3

Re: d3dx9_36: Implement D3DXSHRotate
by Rico Schüller Sept. 3, 2012

Sept. 3, 2012

On 02.09.2012 23:46, Nozomi Kodama wrote: > For instance, D3DXSHAdd and D3DXSHDot accept order>D3DXSH_MAXORDER. So > we must check whether it is acceptable for other D3DXSH functions to > give such an order. If it is not acceptable, then we must know what the > function returns. Yes, they do and I agree with you. But why do you chose to try from 0 to 9 (<10) instead of 0-7 (<8) - which I think is enough and nothing more changes? (It includes the first round of not touched values.) Asking the other way around, why don't you try lets say till 1000? I guess the easy answer is, because the output values won't be touched for orders >6. The test results show the same for the tests 7-9 (and would til 1000) and thus testing for 7 is enough, testing 8 and 9 brings no new information, beside you would miss to test from 10 to open end. > > For the out of bound problem, I agree that we reach an out of bound. But > it is not a problem, since for such an index, expected is defined by an > other value. > If there is a complaining compiler about this, I can modify the tests > though. I'm not sure if the compiler is complaining, but I think it's much better to set it in the else case. You may get an unhandled exception and this is not what the software should do in the first place, it should run and not produce exceptions! :-) The same is done in test_D3DXSHRotateZ, which I'm not happy about it. Cheers Rico

1 0

Re: wined3d: Use backup swapchain DC for devices created with desktop window.
by Marvin Sept. 2, 2012

Sept. 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21350 Your paranoid android. === WXPPROSP3 (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === W2K3R2SESP2 (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === WVISTAADM (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === W2K8SE (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === W7PRO (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === W7PROX64 (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === TEST64_W7SP1 (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === W7PROX64 (64 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === TEST64_W7SP1 (64 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a.

1 0

Re : d3dx9_36: Implement D3DXSHRotate
by Nozomi Kodama Sept. 2, 2012

Sept. 2, 2012

For instance, D3DXSHAdd and D3DXSHDot accept order>D3DXSH_MAXORDER. So we must check whether it is acceptable for other D3DXSH functions to give such an order. If it is not acceptable, then we must know what the function returns. For the out of bound problem, I agree that we reach an out of bound. But it is not a problem, since for such an index, expected is defined by an other value. If there is a complaining compiler about this, I can modify the tests though. Nozomi

1 0

Re: d3dx9_36: Implement D3DXSHRotate
by Rico Schüller Sept. 2, 2012

Sept. 2, 2012

On 02.09.2012 22:28, Nozomi Kodama wrote: > > + for (order = 0; order < 10; order++) > Is there a reason why we'd want to test til 9? D3DXSH_MAXORDER is 6, so 7 Should be enough? I know the other test do this, but technically I see no reason for that. Specifically the if (.. order > D3DXSH_MAXORDER) says exactly that, so no need to further than 7, since the parameters or did I miss something? I guess you'd also out of bounds? table[36 * j + i]; (for j=3 and i=99 => 207) since the table only has 4*36 => 144 elements. Cheers Rico

1 0

Re: winhttp: disable TLSv1.1/1.2 by default
by Henri Verbeet Sept. 2, 2012

Sept. 2, 2012

On 26 August 2012 18:56, André Hentschel <nerv(a)dawncrow.de> wrote: > It's for http://bugs.winehq.org/show_bug.cgi?id=30598 > So it has its reason > So assuming I don't feel like reading through various bug trackers to figure this out, what is the specific issue this patch is supposed to address?

1 0

Re: [PATCH 3/3] hhctrl.ocx: Resize the window when HH_SET_WIN_TYPE is called (try 3, resend 2).
by Charles Davis Sept. 2, 2012

Sept. 2, 2012

On Sep 2, 2012, at 11:23 AM, Erich E. Hoover wrote: > This patch adds the final feature to make the embedded help work > properly, allowing Elster to resize the HTML Help window whenever the > application window is resized. Without this feature the HTML Help > window would always remain at the same size as when the window was > first created. Er, uh, what patch? Chip

2 1

Re: [PATCH] kernel32: add condition variables prototypes and tests
by Marvin Sept. 2, 2012

Sept. 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21332 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH] kernel32: add condition variables prototypes and tests
by Marvin Sept. 2, 2012

Sept. 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21331 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: netapi32: Add stub for NetScheduleJobAdd
by Jacek Caban Sept. 1, 2012

Sept. 1, 2012

Hi Jong, On 09/01/12 17:13, Jong Bin, Chae wrote: > --- > dlls/netapi32/netapi32.c | 6 ++++++ > dlls/netapi32/netapi32.spec | 2 +- > 2 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/dlls/netapi32/netapi32.c b/dlls/netapi32/netapi32.c > index 470adf0..f6c6d20 100644 > --- a/dlls/netapi32/netapi32.c > +++ b/dlls/netapi32/netapi32.c > @@ -238,6 +238,12 @@ NET_API_STATUS WINAPI NetUseEnum(LMSTR server, > DWORD level, LPBYTE* bufptr, DWOR > return ERROR_NOT_SUPPORTED; > } > > +NET_API_STATUS WINAPI NetScheduleJobAdd(LPCWSTR server, LPBYTE > bufptr, LPDWORD jobid) > +{ > + FIXME("stub (%s, %p, %p)\n", debugstr_w(server), bufptr, jobid); It looks like your mail client wraps lines. Please send patches as attachments or reconfigure your mail client. Cheers, Jacek

1 0

Wine Gecko 1.8-beta1
by Jacek Caban Sept. 1, 2012

Sept. 1, 2012

Hi all, It's time for another Gecko update. I've uploaded to SourceForge [1] new Gecko builds. These are based on Firefox 16 beta. Other than tons of changes inherited from Firefox and usual fixes to keep it working well for us, it brings a few visible fixes: - Proper <noscript> tag handling - Synchronous ActiveX loading - Possibility to properly call APIs requiring JSContext - Possibility to implement HTMLStyleElement::styleSheet property As usually, to test it you need the attached patch and Gecko build placed in the right place [2]. Any help with testing is appreciated! On related note, I seriously consider dropping debug builds and replace them by unstripped release build or even just a separated package containing only debug symbols for the release build. Here are my thoughts about reasoning (in random order): - People use debug build mostly to retrieve better backtraces. Unstripped builds also give that ability. - If someone really needs debug build, it's easy enough to build it himself (and that's usually a good idea anyway) - Debug builds are seriously different than release build, so it occasionally exposes different set of problems, leading to invalid assumptions. This is really something for developers rather than users. - It costs my time spent builds and tests. And I consider it a serious matter. Amount of work needed to keep Gecko relevant is constantly growing. I try to mitigate it by doing long-term improvements upstream, automating the process and improving my hardware, but that has its limits. And the time spent on Gecko maintenance (as in pure maintenance, not real improvements) costs Wine in terms of improvements I could make in this time. If someone has a reason to keep debug builds, let me know. Any comments are welcomed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.8-beta1/ [2] http://wiki.winehq.org/Gecko PS: This is a second resend. For some reason this mail didn't make to wine-devel yesterday.

1 0

Re: winhttp: disable TLSv1.1/1.2 by default
by Hiroshi Miura Sept. 1, 2012

Sept. 1, 2012

Hi, Thanks André to point the discussion On 2012年08月27日 01:56, André Hentschel wrote: > Am 26.08.2012 17:46, schrieb Marcus Meissner: >> On Sun, Aug 26, 2012 at 11:50:15AM +0900, Hiroshi Miura wrote: >>> >>> Windows 7 disables TLSv1.1/1.2 by default. >>> This patch intend to behave same as Windows. >> >> >> Please do not... The newer TLSv1.x fix some shortcomings >> of the older TLS versions. >> >> Is there a specific problem you see? >> >> Otherwise, I object. >> > > It's for http://bugs.winehq.org/show_bug.cgi?id=30598 > So it has its reason > Yes it has a reason to disable TLS 1.1 1.2 by DEFAULT. It also provide interface to enable it through registry entry, which is same as windows does. I also prefer to use TLS 1.1/1.2 than before SSL3.0/TLS1.0. but here is a interoperability issue with SSL3.0/TLS 1.0 only site and TLS1.1/1.2 enabled Wine program. In evernote case, client program use wininet dll instead of winhttp. Even such a case, it should be a same behavior for registry values in secur32/schannel, wininet, and winhttp dlls. I understand that wininet/winhttp has a issue to re-implement it using schannel instead of openssl. It means if we support a behavior disabling/enabling TLS1.1/1.2 with registry entry for Schannel, wininet/winhttp should also have a same behavior. We need to add function that enable/disable TLS1.1/1.2 in secur32/schannel according to this registry, but I've not implemented it yet. registry entry is like; ---- Windows Registry Editor Version 5.00 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.1\Client] "DisabledByDefault"=dword:00000000 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.1\Server] "DisabledByDefault"=dword:00000000 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Client] "DisabledByDefault"=dword:00000000 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Server] "DisabledByDefault"=dword:00000000 ----- see http://netsekure.org/2009/10/tls-1-2-in-windiows-7/ Hiroshi

1 0