September 2012 - Wine-Devel

Re: [PATCH 6/6] msvcrt: Fixed RTTI structure on 64-bit systems
by Alexandre Julliard Sept. 6, 2012

Sept. 6, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcrt/cpp.c | 129 > ++++++++++++++++++---------------------------------- > dlls/msvcrt/cxx.h | 114 +++++++++++++++++++++++++++++++++++++++++++++-- > 2 files changed, 155 insertions(+), 88 deletions(-) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M msvcrt.dll -T ../../.. -p msvcrt_test.exe.so ../../../../wine/dlls/msvcrt/tests/cpp.c && touch cpp.ok cpp.c:405: Test failed: bad rtti for e wine: Unhandled exception 0xe06d7363 at address 0x7b84a70a (thread 0025), starting debugger... Unhandled exception: C++ exception(object = 0x0022f870, type = 0x2b780f15a760) in 64-bit code (0x000000007b84a70a). Register dump: rip:000000007b84a70a rsp:000000000022f680 rbp:00002b780f1635f0 eflags:00000202 ( - -- I - - - ) rax:000000000022f6c0 rbx:000000000022f6a0 rcx:000000000022f6a0 rdx:0000000000000000 rsi:000000000022f838 rdi:000000000022f6d8 r8:00002b780f15a760 r9:000000000022f820 r10:2161746164204954 r11:00002b780d5712b0 r12:000000000022fa90 r13:0000000000013198 r14:000000007b8739b0 r15:00007fffffbe8000 Stack dump: 0x000000000022f680: 000000000022f6a0 ff000000ffffff00 0x000000000022f690: 0000000000000000 0000000000000000 0x000000000022f6a0: 00000001e06d7363 0000000000000000 0x000000000022f6b0: 000000007b84a70a 0000000000000003 0x000000000022f6c0: 0000000019930520 000000000022f870 0x000000000022f6d0: 00002b780f15a760 000000000022f870 0x000000000022f6e0: 000000000022f858 00002b780ef3c000 0x000000000022f6f0: 000000000022f858 0000000000000021 0x000000000022f700: 0000000000013198 000000007b8739b0 0x000000000022f710: 00007fffffbe8000 00002b780eefafdc 0x000000000022f720: 00000002c0000005 0000000000000000 0x000000000022f730: 00002b780d54eb28 00002b780d3224e0 Backtrace: =>0 0x000000007b84a70a RaiseException+0xba(code=<is not available>, flags=<is not available>, nbargs=<is not available>, args=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/except.c:85] in kernel32 (0x00002b780f1635f0) 1 0x00002b780eee29c1 _CxxThrowException+0x30(object=<is not available>, type=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/../../../wine/dlls/msvcrt/cpp.c:1109] in msvcrt (0x00002b780f1635f0) 2 0x00002b780eee3242 MSVCRT___RTtypeid+0x171(cppobj=0x2b780f1635f0) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/../../../wine/dlls/msvcrt/cpp.c:901] in msvcrt (0x00002b780f1635f0) 3 0x00002b780ec60326 func_cpp+0x20c5() [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/tests/../../../../wine/dlls/msvcrt/tests/cpp.c:411] in msvcrt_test (0x00002b780f1635f0) 4 0x00002b780ec5c82c main+0x28b(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/tests/../../../../wine/include/wine/test.h:557] in msvcrt_test (0x0000000000000003) 5 0x00002b780ec8dc42 __wine_spec_exe_entry+0xa1(peb=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/winecrt0/../../../wine/dlls/winecrt0/exe_entry.c:36] in msvcrt_test (0x00002b780d2f38f0) 6 0x000000007b873a61 start_process+0xb0(peb=0x7fffffbef000) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1052] in kernel32 (0x00002b780ec8dba0) 7 0x00002b780db5982e call_thread_func+0x6d(entry=0x7b8739b0, arg=0x7fffffbef000, frame=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/signal_x86_64.c:3230] in ntdll (0x00007fff5630f450) 8 0x00002b780db52f1a call_thread_entry_point+0x29() in ntdll (0x00007fff5630f450) 9 0x00002b780db24a56 start_process+0x15(kernel_start=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2653] in ntdll (0x00007fff5630f450) 10 0x00002b780cfcd283 wine_call_on_stack+0x12() in libwine.so.1 (0x00007fff5630f450) 11 0x00002b780cfcd2d9 wine_switch_to_stack+0x8(func=<is not available>, arg=<is not available>, stack=<is not available>) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/port.c:59] in libwine.so.1 (0x00007fffffbef000) 12 0x00002b780db2a500 LdrInitializeThunk+0x45f(kernel_start=0x7b8739b0, unknown2=<is not available>, unknown3=<is not available>, unknown4=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2709] in ntdll (0x00007fffffbef000) 13 0x000000007b879ebd __wine_kernel_init+0x91c() [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1255] in kernel32 (0x00002b780ddbb800) 14 0x00002b780db2ad74 __wine_process_init+0x143() [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2918] in ntdll (0x00007fff56310700) 15 0x00002b780cfcb488 wine_init+0x297(argc=0x3, argv=0x7fff56310bf8, error="", error_size=0x400) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/loader.c:831] in libwine.so.1 (0x00007fff56310700) 16 0x000000007bf00da2 main+0x71(argc=0x3, argv=0x7fff56310bf8) [/home/julliard/wine/build/obj-elf64/loader/../../wine/loader/main.c:230] in <wine-loader> (0x00007fff56310bf8) 17 0x00002b780d55dead __libc_start_main+0xfc(main=<is not available>, argc=<is not available>, ubp_av=<is not available>, init=<is not available>, fini=<is not available>, rtld_fini=<is not available>, stack_end=0x7fff56310be8) [/home/aurel32/eglibc-sid/eglibc-2.13/csu/libc-start.c:228] in libc.so.6 (0x0000000000000000) 18 0x000000007bf00e9d _start+0x28() in <wine-loader> (0x0000000000000000) 0x000000007b84a70a RaiseException+0xba [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/except.c:85] in kernel32: 85 } -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Add AMD Radeon HD 7700 series and HD 7800 series graphics cards
by Henri Verbeet Sept. 6, 2012

Sept. 6, 2012

On 6 September 2012 15:27, Jiang Yike <futureway(a)asia.com> wrote: > This patch adds the recognition of AMD Radeon HD 7700 series and HD 7800 > series graphics cards. > This patch has whitespace errors.

1 0

Re: [PATCH 5/5] mshtml: Added VBScript as event attribute tests
by Marvin Sept. 6, 2012

Sept. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21412 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

2 1

Re: [3/3] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next (resend)
by Marvin Sept. 5, 2012

Sept. 5, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21408 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [2/3] vcomp: better stub for _vcomp_fork (resend)
by Marvin Sept. 5, 2012

Sept. 5, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21407 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [3/3] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next
by Marvin Sept. 5, 2012

Sept. 5, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21405 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] vcomp: better stub for _vcomp_fork
by Marvin Sept. 5, 2012

Sept. 5, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21404 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] hhctrl.ocx: Resize the window when HH_SET_WIN_TYPE is called (try 3, resend 2).
by Alexandre Julliard Sept. 5, 2012

Sept. 5, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > @@ -266,7 +266,7 @@ void MergeChmProperties(HH_WINTYPEW *src, HHInfo *info) > if (merge & HHWIN_PARAM_PROPERTIES) dst->fsWinProperties = src->fsWinProperties; > if (merge & HHWIN_PARAM_STYLES) dst->dwStyles = src->dwStyles; > if (merge & HHWIN_PARAM_EXSTYLES) dst->dwExStyles = src->dwExStyles; > - if (merge & HHWIN_PARAM_RECT) dst->rcWindowPos = src->rcWindowPos; > + if (merge & HHWIN_PARAM_RECT || override) dst->rcWindowPos = src->rcWindowPos; > if (merge & HHWIN_PARAM_NAV_WIDTH) dst->iNavWidth = src->iNavWidth; > if (merge & HHWIN_PARAM_SHOWSTATE) dst->nShowState = src->nShowState; > if (merge & HHWIN_PARAM_INFOTYPES) dst->paInfoTypes = src->paInfoTypes; You still need to check the source flags. -- Alexandre Julliard julliard(a)winehq.org

1 0

Building winetest-latest.exe?
by Dan Kegel Sept. 5, 2012

Sept. 5, 2012

Hi folks, how does one build the native version of winetest.exe? I looked around a bit, and didn't see any obvious instructions. http://www.winehq.org/pipermail/wine-devel/2011-July/091144.html touches on it, but doesn't say much. I ask because I'm interested in tracking down why testbot doesn't think vcomp.dll is installed. ( cf. http://www.winehq.org/pipermail/wine-devel/2012-August/096642.html ) - Dan

5 7

Re: d3dx9_36 [try 4 ]: Implement D3DXSHRotate
by Rico Schüller Sept. 5, 2012

Sept. 5, 2012

On 05.09.2012 08:02, Nozomi Kodama wrote: + out[15] = -0.9682458639f * in[13] + 0.25f * in[15]; ! You didn't find all trailing white spaces. I made a !, so it could be seen. You could easily get around that by changing your editors preference. Most editors are able to remove that automatically (see e.g. for vim http://vim.wikia.com/wiki/Remove_unwanted_spaces) You may also have a look at http://wiki.winehq.org/GitWine#head-b20b05157175835751686365f9818ae978ceca23 . Both are really easy to use. Be warned, that's not the only occurrence, so please look carefully if you remove them by hand. What you get from a comment to a patch are only hints. But you may check for all mentioned hints to the specific patch (even to previous tries), if you have fulfilled them or you may add a comment why you think the hint is bad. If you don't understand a hint, please ask - before sending another try, sometimes the hints could be wrong and sometimes they are worth to think about it. That's all I have to say, there won't be any more comments from my side to this patch. I need my time to get my own screwed up patches into wine. :-) Cheers Rico

1 0

Re: [PATCH 1/3] [cmd] "PATH=value" fails whereas "PATH value" works
by Marvin Sept. 4, 2012

Sept. 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21386 Your paranoid android. === WVISTAADM (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

2 1

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes.
by Vincent Povirk Sept. 4, 2012

Sept. 4, 2012

> match = memcmp(dst_8x1, td[i].image, sizeof(dst_8x1)) == 0; > + if (!match) > + todo_wine ok(match, "%d: data should match\n", i); > + else > ok(match, "%d: data should match\n", i); This sort of thing makes me nervous. Couldn't you do this in such a way that we'll notice if the existing tests break, like adding a todo field to the structure?

1 0

Re: d3dx9_36 [try 3]: Implement D3DXSHRotate
by Rico Schüller Sept. 4, 2012

Sept. 4, 2012

On 04.09.2012 13:19, Nozomi Kodama wrote: + FLOAT expected, in[100], out[100], ... + for (i = 0; i < 49; i++) + in[i] = i + 1.01f; I guess this belongs together. I'd like to make some suggestions, please don't take it personally. When you got a comment on a patch, read it carefully. Think about it, if it makes sens to do the change (just adding what I've said is not always the best, it just gives you a hint, that you may improve some things, the list is not always complete and different people may have different suggestions) and try to improve your patch. After you are done, read your patch. Well mistakes happen, especially when you try to get something done really fast. (1) Take you some time and read it again and see if you've done that as best as possible and if you are happy with the code you've done, then submit it. If you've found a bug don't submit, fix it and go to #1. The earlier a bug is found the cheaper is it to solve it. I hope this helps a bit and it hopefully saves you some time to get a patch in the feature accepted. Thought I'd like to thank you for your patience and hopefully I haven't annoyed you and we'll see some good quality patches in the feature from you. :-) Cheers Rico

3 4

Re: wininet: Set last error for invalid URL argument
by Marvin Sept. 4, 2012

Sept. 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21380 Your paranoid android. === W2KPROSP4 (32 bit internet) === Timeout

1 0

Re: [2/2] gdiplus: Add preliminary support for pixel offset modes.
by Vincent Povirk Sept. 4, 2012

Sept. 4, 2012

> return sample_bitmap_pixel(src_rect, bits, width, height, > - gdip_round(point->X), gdip_round(point->Y), attributes); > + point->X + pixel_offset, point->Y + pixel_offset, attributes); > + } This is going to break tiling. By removing gdip_round you're implicitly truncating the number instead of flooring, which will give you the wrong result when X or Y is negative. I suggest explicitly adding a floorf.

1 0

Re: jscript: Fixed empty cases in the end of switch statement
by Marvin Sept. 4, 2012

Sept. 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21379 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/4] mshtml: Properly expose frame and iframe element's windows to scripts
by Marvin Sept. 4, 2012

Sept. 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21376 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Wine Gecko 1.8-beta1
by Jacek Caban Sept. 4, 2012

Sept. 4, 2012

Hi all, It's time for another Gecko update. I've uploaded to SourceForge [1] new Gecko builds. These are based on Firefox 16 beta. Other than tons of changes inherited from Firefox and usual fixes to keep it working well for us, it brings a few visible fixes: - Proper <noscript> tag handling - Synchronous ActiveX loading - Possibility to properly call APIs requiring JSContext - Possibility to implement HTMLStyleElement::styleSheet property As usually, to test it you need the attached patch and Gecko build placed in the right place [2]. Any help with testing is appreciated! On related note, I seriously consider dropping debug builds and replace them by unstripped release build or even just a separated package containing only debug symbols for the release build. Here are my thoughts about reasoning (in random order): - People use debug build mostly to retrieve better backtraces. Unstripped builds also give that ability. - If someone really needs debug build, it's easy enough to build it himself (and that's usually a good idea anyway) - Debug builds are seriously different than release build, so it occasionally exposes different set of problems, leading to invalid assumptions. This is really something for developers rather than users. - It costs my time spent builds and tests. And I consider it a serious matter. Amount of work needed to keep Gecko relevant is constantly growing. I try to mitigate it by doing long-term improvements upstream, automating the process and improving my hardware, but that has its limits. And the time spent on Gecko maintenance (as in pure maintenance, not real improvements) costs Wine in terms of improvements I could make in this time. If someone has a reason to keep debug builds, let me know. Any comments are welcomed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.8-beta1/ [2] http://wiki.winehq.org/Gecko

3 3

Re: d3dx9_36 [try 2]: Implement D3DXSHRotate
by Rico Schüller Sept. 4, 2012

Sept. 4, 2012

On 03.09.2012 20:59, Nozomi Kodama wrote: > Thanks Rico and Henri for your help. > > Nozomi > > > The patch looks much better now. But I have some minor things which I didn't mention last time... + ok(received_ptr == out, "order %u, Expected %p, received %p\n", order, out, received_ptr); We may write the variables all starting with upper or lower char, maybe the first word will start with a upper char and the rest with a lower char. The mixture as is looks a bit ugly, doesn't it? Please have a look at the surrounding code, but not at test_D3DXSHRotateZ. ;-) And of course only going til 7 we won't need the in/out array till 100. 49 should fit, shouldn't it? That would be reducing the time spend in the for loops, even if it's only the test... Cheers Rico

1 0

vcomp.dll, vcomp90.dll missing on testbot?
by Dan Kegel Sept. 3, 2012

Sept. 3, 2012

I'm trying to test a better set of stubs for vcomp.dll and its ilk, but those dlls don't seem to be installed on testbot. Is vcomp{,90,100}.dll not installed by default on Windows? If not, should we install it on a few of the VMs?

3 9

Re: [PATCH 1/6] mshtml: Moved getting frame by name to separated function
by Alexandre Julliard Sept. 3, 2012

Sept. 3, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/htmlwindow.c | 127 > ++++++++++++++++++++++++++-------------------- > 1 files changed, 72 insertions(+), 55 deletions(-) gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -Werror -I/usr/include/freetype2 -g -O2 -o htmlwindow.o htmlwindow.c htmlwindow.c: In function ‘HTMLWindow2_item’: htmlwindow.c:416:13: error: variable ‘hres’ set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors make: *** [htmlwindow.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.
by Alexandre Julliard Sept. 3, 2012

Sept. 3, 2012

Alex Henrie <alexhenrie24(a)gmail.com> writes: > I was asked to split this patch up, so I did. The complaint about the > last version was "You are still overflowing the source." I have not > been able to find any test case that my implementation handled > incorrectly, however, I did find that (*src == 0 && srclen < 0) will > never evaluate to true, so I removed this if statement from the code. I > also changed example #2 in the tests to be slightly more stringent, but > the last patch would also have passed. > > If this patch series is rejected, please show me a test case that > demonstrates what I am doing wrong. You don't have a single test with an explicit source length, so obviously you are not going to find problems in that area. Like I said, you need a lot more tests. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] msctf: also free the sink in the non-source branch (Coverity)
by Marvin Sept. 3, 2012

Sept. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21357 Your paranoid android. === TEST64_W7SP1 (32 bit inputprocessor) === inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink

1 0

Re: wined3d: Use backup swapchain DC for devices created with desktop window.
by Henri Verbeet Sept. 3, 2012

Sept. 3, 2012

On 3 September 2012 00:51, Adam Jakubek <ajakubek(a)gmail.com> wrote: > Hi, > > This patch causes wined3d to use backup swapchain DC when > IDirect3DDevice9 is created using the desktop window. > Windows allows to create such device as long its type is > D3DDEVTYPE_REF or D3DDEVTYPE_NULLREF. > > Unpatched Wine will fail in IDirect3D9_CreateDevice method, since it > incorrectly uses the X root window. > > Relevant d3d test case is included. > Patch closes bug #18490. > How is actual rendering to the desktop window supposed to work?

2 1

Re: [PATCH 6/6] mshtml: Added IHTMLIFrameElement3 stub implementation
by Marvin Sept. 3, 2012

Sept. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21355 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:5225: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:5262: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === WVISTAADM (32 bit dom) === dom.c:5225: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:5262: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002

1 0