September 2012 - Wine-Devel

d3dx9: Implement D3DXSHEvalDirectionalLight
by Nozomi Kodama Sept. 25, 2012

Sept. 25, 2012

Hello, do it remain problems with this patch? Nozomi

1 0

Re: [PATCH] dmusic: Add master clock tests.
by Andrew Eikum Sept. 24, 2012

Sept. 24, 2012

On Sun, Sep 23, 2012 at 08:44:59PM +0200, Christian Costa wrote: > @@ -66,6 +68,11 @@ static void test_dmusic(void) > return; > } > > + hr = IDirectMusic_GetMasterClock(dmusic, &guid_clock, &clock); > + ok(hr == S_OK, "IDirectMusic_GetMasterClock returned: %x\n", hr); > + ok(clock != NULL, "No clock returned\n"); > + trace(" guidPort = %s\n", debugstr_guid(&guid_clock)); > + Minor nit-pick: you never release the clock.

1 0

Re: [PATCH 2/2] mshtml: Added function overriding tests
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21757 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] jscript: Added support for limit argument in String.split
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21756 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: Assorted spelling fixes.
by Julian Rüger Sept. 24, 2012

Sept. 24, 2012

Hi Francois, > - /* if we set the bufferpointer to NULL here UrlUnescape fails and string gets not converted */ > + /* if we set the buffer pointer to NULL here UrlUnescape fails and the string is not converted */ for consistency with the other buffer pointer comments and better readability, I suggest you add a comma here: + /* if we set the buffer pointer to NULL here, UrlUnescape fails and the string is not converted */ Best regards, Julian

1 0

Re: [PATCH 4/4] mshtml: Added IHTMLElement::contains implementation
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21753 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] mshtml: Added function overriding tests
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21751 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

RFC: Locale-independent case-insensitive string comparison
by Francois Gouget Sept. 24, 2012

Sept. 24, 2012

diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 28f82a3..f465ad7 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -640,7 +640,7 @@ static void HTTP_FixURL(http_request_t *request) } } - if(CSTR_EQUAL != CompareStringW( LOCALE_SYSTEM_DEFAULT, NORM_IGNORECASE, + if(CSTR_EQUAL != CompareStringW( LOCALE_INVARIANT, NORM_IGNORECASE, request->path, strlenW(request->path), szHttp, strlenW(szHttp) ) && request->path[0] != '/') /* not an absolute path ?? --> fix it !! */ { In this code snippet it feels wrong to have this string comparison depend on the system locale, which in Wine's case would come from the user's Unix locale. Isn't this a case where LOCALE_INVARIANT would be better? However I have not found a case where this makes a difference anyway, either with 'http:' or with 'file:'. That is, 'file:' always matches 'FILE:', even in Turkish, as long as I don't use NORM_LINGUISTIC_CASING. Conversely, 'fîle:' is different from 'FILE:' no matter what. Once I have a CompareString() test-case I can make some for UrlIs(), PathCreateFormURL(), possibly ShellExecute(), etc. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [PATCH] d3dx9_36: Cube texture can be loaded as a simple texture. The first face texture is taken in that case.
by Józef Kucia Sept. 24, 2012

Sept. 24, 2012

Hi, On Sun, Sep 23, 2012 at 8:44 PM, Christian Costa <titan.costa(a)gmail.com>wrote: > + hr = IDirect3DTexture9_LockRect(texture, 0, &lock_rect, NULL, > D3DLOCK_READONLY); > + ok(hr == D3D_OK, "IDirect3DTexture9_LockTexture returned %#x, > expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) > + for (i = 0; i < 16; i++) > + ok(((BYTE*)lock_rect.pBits)[i] == dds_cube_map[128+i], > "Byte at index %u is 0x%02x, expected 0x%02x\n", i, > ((BYTE*)lock_rect.pBits)[i], dds_cube_map[144+i]); > + IDirect3DTexture9_Release(texture); > You should call IDirect3DTexture9_UnlockRect before IDirect3DTexture9_Release.

2 1

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.
by Henri Verbeet Sept. 24, 2012

Sept. 24, 2012

On 23 September 2012 22:40, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > > +struct refresh_rates { Formatting. > +struct refresh_rates refresh_list[] = This should be static const. > + ok(hr == E_INVALIDARG, "GetDesc unexpectedly returend %#x.\n", hr); "returned". > + for (i = 0; i < sizeof(refresh_list)/sizeof(struct refresh_rates); i++) I generally prefer "sizeof(*refresh_list)", or perhaps "sizeof(refresh_list[0])" over "sizeof(struct refresh_rates)" in this kind of situation. > + "Numerator %d is %d.\n", i, result_desc.BufferDesc.RefreshRate.Numerator); These are unsigned variables.

1 0

Re: [3/4] dxgi: Avoid division by zero. Based on patch by Eduard - Gabriel Munteanu.
by Henri Verbeet Sept. 24, 2012

Sept. 24, 2012

On 23 September 2012 22:40, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > +static UINT dxgi_rational_to_uint(DXGI_RATIONAL *rational) "rational" should be const.

1 0

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.
by Józef Kucia Sept. 24, 2012

Sept. 24, 2012

On Sun, Sep 23, 2012 at 10:40 PM, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > +struct refresh_rates refresh_list[] = > +{ > + {60, 60, FALSE, FALSE}, > + {60, 0, TRUE, FALSE}, > + {60, 1, TRUE, TRUE}, > + { 0, 60, TRUE, FALSE}, > + { 0, 0, TRUE, FALSE}, > +}; It's probably better to declare it inside test_createswapchain(). It could also be static const. > + hr = IDXGISwapChain_Release(swapchain); > + ok(hr == 0, "Release failed, hr %d.\n", hr); It should be assigned to refcount. > + hr = IDXGIFactory_Release(factory); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); > + > + hr = IDXGIAdapter_Release(adapter); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); > + > + hr = IUnknown_Release(obj); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); Release doesn't return HRESULT and the value returned by Release shouldn't be tested with SUCCEEDED. refcount = IDXGIFactory_Release(factory); ok(!refcount, "ID3DXGIFactory has %u references left\n", refcount);

1 0

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.
by Alexandre Julliard Sept. 24, 2012

Sept. 24, 2012

Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> writes: > --- > dlls/dxgi/tests/Makefile.in | 2 +- > dlls/dxgi/tests/device.c | 147 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 148 insertions(+), 1 deletion(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dxgi.dll -T ../../.. -p dxgi_test.exe.so device.c && touch device.ok device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. make: *** [device.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Assorted spelling fixes.
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21742 Your paranoid android. === W2K3R2SESP2 (32 bit sync) === sync.c:972: Test failed: DeleteTimerQueueTimer

1 0

Re: [7/8] windowscodecs: Calculate transparent color index for global GIF palette.
by Marvin Sept. 24, 2012

Sept. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21729 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/8] windowscodecs: Add some tests for GIF palette.
by Vincent Povirk Sept. 24, 2012

Sept. 24, 2012

Series looks good to me.

1 0

WineHQ on CMS/Framework
by Kyle Auble Sept. 23, 2012

Sept. 23, 2012

After working on the wiki for a while, I finally wanted to ask about possibly moving WineHQ to a CMS or web framework. First off, while there are a couple of mentions on the wiki and mailing lists, is there still much interest in doing this? If there is, I think the second question is which kind of system do we want to use? While http://wiki.winehq.org/WinehqDesign mentions Drupal, which has a lot of plugins and features for easy editing, I've read that a CMS can become a hassle if your website needs to do more complex things than serving regular chunks of content. WineHQ provides a bug-tracker, a forum, a wiki, mailing lists, source-code browsers, and other tools besides static content, with lots of interconnections between them. If we did go with a web framework, we could still probably run a CMS on top of it for the AppDB and static pages. Finally, for the frameworks, it seems that one of the main differences is simply which language we want to deal with. Is there a strong preference for using a specific language? Right now the various parts outside of Wine proper use a mix of Perl, PHP, and Python. This also raises the question of whether there's any desire to (over the very long term) try consolidating all the code outside Wine around one or two languages. I'm guessing it wouldn't be worth the trouble (different tools for different jobs), but if there is a strong reason to, it would probably be good to pick a framework in the language we want to emphasize. - Kyle

2 2

re: Question from new developer
by Dan Kegel Sept. 23, 2012

Sept. 23, 2012

Chris wrote: > 1. I discovered later that I don't think this is the root of my > original bug - and in fact doesn't seem to affect behavior of my > program. Is it still worth submitting? Generally, fixes are more likely to get committed when they don't break anything (did you run all the conformance tests?), their tests cases pass on all versions of windows (did you send your patch to testbot?), improve the behavior of a real program (I don't think you have demonstrated this yet), and are written from a position of relatively deep understanding. So you might want to find a more solid fix for your first submission. Welcome, and good luck! - Dan

1 0

Re: comctl32/listview: update dwStyle before checking for scrollbar
by Nikolay Sivov Sept. 23, 2012

Sept. 23, 2012

On 9/21/2012 23:07, Daniel Jelinski wrote: > dwStyle is updated only in WM_STYLECHANGED, which is not sent > when displaying and hiding scrollbars. > Fixes the issue where there was a large margin between items > and horizontal scrollbar (e.g. in file open dialog). Are you sure it's really not supposed to be sent when WS_HSCROLL/WS_VSCROLL bits are changed? A quick test with ControlSpy shows style changing messages when I set/reset these. So it's possible there's a bug outside of comctl32.

2 4

Question from new developer
by Chris Teague Sept. 23, 2012

Sept. 23, 2012

I submitted bug 31753 for an application that I use, and started making an attempt to fix it. I started with the last few messages from the log: fixme:win:LockWindowUpdate (0x501c4), partial stub! fixme:win:LockWindowUpdate ((nil)), partial stub! wine: Unhandled page fault on read access to 0x00000023 at address 0x78680087 (thread 0009), starting debugger... Looking at LockWindowUpdate(), I discovered that it had no conformance tests. I wrote a few covering all the possible scenarios I could think of (only 4 of them), and ran them on wine as well as cross compiling them and running on XP. To my surprise, one of the tests fails on wine, but passes on WinXP! This was great news, so I dug a little further. Specifically the problem was attempting to do a "unlock" operation by passing NULL, when the the function was already unlocked. Windows treats this as an error and returns 0, while wine returns 1. So I fixed it, patch is attached (also at: https://dl.dropbox.com/u/477050/0001-Fixed-LockWindowUpdate.txt) I have two big questions: 1. I discovered later that I don't think this is the root of my original bug - and in fact doesn't seem to affect behavior of my program. Is it still worth submitting? I do believe it alleviates the need for the "fixme" in the LockWindowUpdate function. 2. If it is worth submitting, could someone take a look at it and point out all the dumb things I've done? I'm happy with the logic of the code, but I'm sure I've done something horribly wrong in terms of doing it the preferred way. Thanks, Chris Teague

2 1

Re: [3/3] gdiplus: Add an ability to cache bitmap properties and use distinct metadata loaders for different image formats. Take 2.
by Vincent Povirk Sept. 21, 2012

Sept. 21, 2012

This looks good to me.

1 0

Re: scrrun: Correct Invoke parameter
by Jacek Caban Sept. 21, 2012

Sept. 21, 2012

Hi Alistair, On 09/21/12 14:12, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > scrrun: Correct Invoke parameter > --- a/dlls/scrrun/dictionary.c +++ b/dlls/scrrun/dictionary.c @@ -153,7 +153,7 @@ static HRESULT WINAPI dictionary_Invoke(IDictionary *iface, DISPID dispIdMember, hr = get_typeinfo(IDictionary_tid, &typeinfo); if(SUCCEEDED(hr)) { - hr = ITypeInfo_Invoke(typeinfo, &iface, dispIdMember, wFlags, + hr = ITypeInfo_Invoke(typeinfo, This, dispIdMember, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr); This really should be an interface, not an object. &This->IDistionary_iface or simply iface would be the right thing to do. Jacek

1 0

Re: [3/3] gdiplus: Add an ability to cache bitmap properties and use distinct metadata loaders for different image formats.
by Vincent Povirk Sept. 20, 2012

Sept. 20, 2012

> @@ -2123,6 +2125,8 @@ static void move_bitmap(GpBitmap *dst, GpBitmap *src, BOOL clobber_palette) > if (dst->metadata_reader) > IWICMetadataReader_Release(dst->metadata_reader); > dst->metadata_reader = src->metadata_reader; > + dst->prop_count = src->prop_count; > + dst->prop_item = src->prop_item; > if (dst->image.stream) > IStream_Release(dst->image.stream); > dst->image.stream = src->image.stream; I think you should be freeing dst->prop_item here. > @@ -2850,6 +2923,12 @@ GpStatus WINGDIPAPI GdipGetAllPropertyItems(GpImage *image, UINT size, > > if (prop_count != count || prop_size != size) return InvalidParameter; > > + if (((GpBitmap *)image)->prop_item) > + { > + memcpy(buf, ((GpBitmap *)image)->prop_item, prop_size); > + return Ok; > + } > + > reader = ((GpBitmap *)image)->metadata_reader; > if (!reader) return PropertyNotFound; I think you have to change the values here so they point into the user buffer. > +typedef GpStatus (*metadata_reader_func)(GpBitmap *bitmap, IWICBitmapDecoder *decoder, UINT frame); ... > + if (metadata_reader) > + metadata_reader(bitmap, decoder, active_frame); > + else if (IWICBitmapFrameDecode_QueryInterface(frame, &IID_IWICMetadataBlockReader, (void Either your metadata reader function should return void, or you should check the returned status. Otherwise, this looks good to me.

1 0

Re: jscript: Added support for RegExp.$* properties
by Marvin Sept. 20, 2012

Sept. 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21683 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin Sept. 20, 2012

Sept. 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [8/8] winemenubuilder: Implement OS X application bundles. (try 2)
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21663 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [7/8] winemenubuilder: Use a dispatch table to access XDG specific parts, extracted to different file.
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21662 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: shell32: Add tests for ShellExecute()'s handling of file URLs. (try2)
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21655 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === Timeout === W2KPROSP4 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 === WVISTAADM (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W2K8SE (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PRO (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PROX64 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === TEST64_W7SP1 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PROX64 (64 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === TEST64_W7SP1 (64 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.
by Juan Lang Sept. 19, 2012

Sept. 19, 2012

Hi Francois, pretty sure you didn't mean to leave this hunk in: @@ -2296,9 +2406,13 @@ START_TEST(shlexec) init_test(); +#if 0 test_argify(); test_lpFile_parsed(); test_filename(); +#endif + test_fileurl(); +#if 0 test_find_executable(); test_lnks(); test_exes(); @@ -2308,6 +2422,7 @@ START_TEST(shlexec) test_commandline(); test_directory(); test_trojans(); +#endif --Juan

1 0

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21649 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] scrrun: Moved creating filesystem object to its own function
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -194,13 +245,33 @@ HRESULT WINAPI DllUnregisterServer(void) > > HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID* ppv) > { > + scrruncf *This; > + HRESULT hr = CLASS_E_CLASSNOTAVAILABLE; > + > + TRACE("(%s, %s, %p): stub\n", debugstr_guid(rclsid), debugstr_guid(riid), ppv); > + > + if(!ppv) > + return E_INVALIDARG; > + > + This = HeapAlloc(GetProcessHeap(), 0, sizeof(scrruncf)); > + > + This->IClassFactory_iface.lpVtbl = &scrruncf_vtbl; > + This->pfnCreateInstance = NULL; > + This->ref = 1; > + > if(IsEqualGUID(&CLSID_FileSystemObject, rclsid)) { > - TRACE("(CLSID_WshShell %s %p)\n", debugstr_guid(riid), ppv); > - return IClassFactory_QueryInterface(&FileSystemFactory, riid, ppv); > + TRACE("(CLSID_FileSystemObject %s %p)\n", debugstr_guid(riid), ppv); > + This->pfnCreateInstance = &create_filesystem; > + This->clsid = IID_IFileSystem3; > + } You could just as well continue using static instances of the class factory, and using the IID as a clsid doesn't make much sense. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] user32/tests: Add tests for class small icons (try 3).
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Sergey Guralnik <serhio(a)etersoft.ru> writes: > +todo_wine > + ok( hsmicon != NULL, "GetClassLong should return non-zero handle\n"); > + for(i = 0; i < 100; i++) > + if(hsmicon != (HICON)GetClassLongPtrW(hwnd, GCLP_HICONSM)) > + { > + ok(FALSE, "Always should return the same icon handle\n"); > + break; > + } This doesn't make sense, it's not going to return the same thing 99 times and then suddenly something different. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ole32: Add CoGetDefaultContext stub
by Michael Stefaniuc Sept. 19, 2012

Sept. 19, 2012

Hallo Alistair, > --- > dlls/ole32/compobj.c | 9 +++++++++ > dlls/ole32/ole32.spec | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c > index 0055d15..2ea1dc9 100644 > --- a/dlls/ole32/compobj.c > +++ b/dlls/ole32/compobj.c > @@ -4279,6 +4279,15 @@ HRESULT WINAPI CoGetContextToken( ULONG_PTR *token ) > return S_OK; > } > > +/*********************************************************************** > + * CoGetContextToken [OLE32.@] copy and paste error ^^^ > + */ > +HRESULT CoGetDefaultContext(APTTYPE type, REFIID riid, LPVOID *ppv) bye michael

2 1

user32/tests: Add tests for class small icons (try 3).
by Sergey Guralnik Sept. 19, 2012

Sept. 19, 2012

There are two patches that stay at queue more than weeek, and have no comments yet: From 5c723835fb9b8b56ccaf2a22256524c84b358fe9 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Tue, 11 Sep 2012 10:24:56 +0400 Subject: [PATCH 1/2] user32/tests: Add tests for class small icons (try 3). From 49d6118117ccfb4efecbb9839b279cc286b19392 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Tue, 11 Sep 2012 13:40:54 +0400 Subject: [PATCH 2/2] user32: Add internal class small icons functionality (try 3). Is something wrong with them? -- Sergey

1 0

user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik Sept. 19, 2012

Sept. 19, 2012

Alexandre Julliard writes: > Not really. If you want to test purely the Wine behavior, then you > shouldn't be waiting for window manager events. If the window manager > is > involved then you can't guarantee that a given window will always get > focus. > If your app breaks because the window manager doesn't give it focus > at a > certain point, then pretty much the only solution is to change the wm > policy, or use a different wm. Thanks for explanations. -- Sergey

1 0

Re: [PATCH 3/3] jscript: Added support for no new line between return and expression rule
by Marvin Sept. 18, 2012

Sept. 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21637 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386
by Jacek Caban Sept. 18, 2012

Sept. 18, 2012

Please ignore this last patch. It has one more dependency that I didn't send yet. On 09/17/12 15:21, Jacek Caban wrote: > --- > dlls/jscript/jsutils.c | 4 +- > dlls/jscript/jsval.h | 143 > +++++++++++++++++++++++++++++++++++++---------- > 2 files changed, 114 insertions(+), 33 deletions(-) >

2 2

Re: [PATCH 3/6] vbscript: Added support for do..loop statement without an expression
by Marvin Sept. 18, 2012

Sept. 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21628 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/6] vbscript: Added Len implementation
by Marvin Sept. 18, 2012

Sept. 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21627 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] vbscript: Fixed parsing if statements with empty body
by Marvin Sept. 18, 2012

Sept. 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21626 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] jscript: Added support for host objects being part of scope chain
by Marvin Sept. 18, 2012

Sept. 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21625 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] oleaut32/tests: Don't take the size of a pointer (Clang).
by Michael Stefaniuc Sept. 18, 2012

Sept. 18, 2012

Hello Charles, On 09/18/2012 07:51 AM, Charles Davis wrote: > From: Charles Davis <cdavis(a)mymail.mines.edu> > > Contrary to what a novice C programmer might expect, when you declare an > array parameter to a function, what you actually get is a pointer. > Therefore, using sizeof() on the parameter will return the size of a > pointer, and not 8*sizeof(UINT) as was intended here. Since the array was please fix it in a way to not confuse a novice C programmer; e.g. passing it a pointer to a MYSTRUCT. That way you can avoid the magic constant 8 too. > explicitly declared as being 8 elements long, just use the number 8 in > the for loop instead. > --- > dlls/oleaut32/tests/tmarshal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/oleaut32/tests/tmarshal.c b/dlls/oleaut32/tests/tmarshal.c > index be8ef94..ad56123 100644 > --- a/dlls/oleaut32/tests/tmarshal.c > +++ b/dlls/oleaut32/tests/tmarshal.c > @@ -596,10 +596,10 @@ static HRESULT WINAPI Widget_VarArg( > } > > > -static BOOL mystruct_uint_ordered(UINT uarr[8]) > +static BOOL mystruct_uint_ordered(UINT uarr[]) > { > int i; > - for (i = 0; i < sizeof(uarr) / sizeof(uarr[0]); i++) > + for (i = 0; i < 8; i++) > if (uarr[i] != i) > return 0; > thanks bye michael

1 0

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 3.
by Dmitry Timoshkov Sept. 17, 2012

Sept. 17, 2012

Hi, Can I please get a feedback on this gdiplus series along with another one "gdiplus: Add some tests for GIF properties." ? -- Dmitry.

2 1

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik Sept. 17, 2012

Sept. 17, 2012

Alexandre Julliard wrote: > Sergey Guralnik <serhio at etersoft.ru> writes: > >> I've sent next patch more than month ago, and have no comments about >> it. >> >> From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 >> 2001 >> From: Sergey Guralnik <serhio at etersoft.ru> >> Date: Thu, 9 Aug 2012 17:12:56 +0400 >> Subject: user32/tests: Add test for SetFocus() (with few todo)(Try >> 2). >> >> Is anything wrong with this one? > > That's mostly testing the window manager focus policy, I don't think > that makes sense. What are you trying to demonstrate with this? I try to show that some applications rely on finishing all side focus switching, which are result of call to some window management function, before this function returns. For example my app hopes that result of call to SetFocus() will not be distorted in message loop due call to DestroyWindow(), that made before call to SetFocus(). Is my explanation clear enough? -- Sergey

2 1

Re: d3dx9 [patch 1/2]: Implement D3DXSHEvalDirectionalLight
by Rico Schüller Sept. 17, 2012

Sept. 17, 2012

On 17.09.2012 00:33, Nozomi Kodama wrote: > + { { rout, gout, bout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, ... > + { rout, bout, gout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, > + { bout, rout, gout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, I think it doesn't make much sense to test this, they are doing basically all three the same. The name of the variable doesn't matter. Besides we test for (rout, rout, rout), these might be good to test: (rout, gout, gout), (rout, rout, bout), (rout, gout, rout). Maybe the naming of the variables is a bit confusing... I used the starting name for the name, hence you could also use the expected value name or rename the variables to out1, out2, out3 to not make confusion with the expected / started color. Though I'm fine with all cases... > + } > + > + startindex += order * order; > + } I would indent the startindex... Some style comments (I have no strong opinion about that, just like to mention it): The brackets "()" in &(table[90]) could be left out. You may also break the longer lines into two. Though, I don't know the actual recommended line length, but 200 seems a bit long... I only found this http://www.winehq.org/pipermail/wine-devel/2010-September/086996.html . Cheers Rico

2 1

Wine Mono update
by Alistair Leslie-Hughes Sept. 16, 2012

Sept. 16, 2012

Hi, Mono 2.11.4 has been released which contains a few patches which removes most of the exceptions from the AxHost class. This class has been the cause of a few applications from starting (DDO and LOTRO launchers to name a few) I purpose a new wine-mono to be built. What sort of milestones should we look for to trigger a new wine-mono release? Best Regards Alistair Leslie-Hughes

1 0

very slow updating of client area
by Andrew Makhorin Sept. 16, 2012

Sept. 16, 2012

Hello, Please see below a function that processes WM_PAINT message. Being run under Wine this function updates the client area (50x120 chars) about 50 times slower than under Windows XP. Could anyone please explain me what might be wrong and suggest how to fix that? Thank you, Andrew Makhorin /*********************************************************************** * update_panel_area - update client area of panel window * * This routine updates the client area of the window associated with * the specified panel. (It is called when the panel window procedure * receives the message WM_PAINT.) */ void update_panel_area(PANELX *px) { PAINTSTRUCT ps; HFONT old_hfont; HPEN old_hpen, hpen; int row, col, row1, row2, col1, col2; xassert(px != NULL); /* if the update region is empty, do nothing */ if (!GetUpdateRect(px->window, NULL, FALSE)) goto done; /* start updating */ BeginPaint(px->window, &ps); old_hfont = SelectObject(ps.hdc, px->hfont); hpen = CreatePen(PS_SOLID, 0, 0x000000); old_hpen = SelectObject(ps.hdc, hpen); /* given the update region, determine which rows and columns of the display area should be updated (note that the update region reported by BeginPaint does not include right-most and bottom-most pixels, so we subtract 1 in order not to update an extra row and column out of the update region) */ row1 = 1 + ps.rcPaint.top / px->fy; row2 = 1 + (ps.rcPaint.bottom - 1) / px->fy; col1 = 1 + ps.rcPaint.left / px->fx; col2 = 1 + (ps.rcPaint.right - 1) / px->fx; /* updating is performed according to information in the buffer array of the panel display area (see rpsed.h) */ for (row = row1; row <= row2; row++) { for (col = col1; col <= col2; col++) { FMTCHAR c; int x, y; char buf[1]; /* get formatted character at position (row,col) */ if (1 <= row && row <= px->p->nrows+1 && 1 <= col && col <= px->p->ncols+1) c = px->p->c[row][col]; else c = px->p->std_char[FMT_SPACE]; /* paint this character */ x = (col - 1) * px->fx; y = (row - 1) * px->fy; SetTextColor(ps.hdc, palette->value[c.f]); SetBkColor(ps.hdc, palette->value[c.b]); SetBkMode(ps.hdc, OPAQUE); buf[0] = c.c; TextOut(ps.hdc, x, y, buf, 1); /* paint the underline, if specified */ if (c.a & FMT_UNDERLINE) { SetBkMode(ps.hdc, TRANSPARENT); TextOut(ps.hdc, x, y, "_", 1); } /* paint the vertical bar, if specified */ if (c.a & FMT_MARGIN) { MoveToEx(ps.hdc, x, y, NULL); LineTo(ps.hdc, x, y + px->fy); } } } /* finish updating */ SelectObject(ps.hdc, old_hfont); SelectObject(ps.hdc, old_hpen); DeleteObject(hpen); EndPaint(px->window, &ps); done: return; }

1 0