September 2012 - Wine-Devel

Re: [PATCH 2/2] user32: Correct class small icons behavior.
by Marvin Sept. 7, 2012

Sept. 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21433 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 1/2] user32/tests: Added test for class icons handling.
by Marvin Sept. 7, 2012

Sept. 7, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21432 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 4/5] gdi32: Added font name tests on non English locale.
by Alexandre Julliard Sept. 7, 2012

Sept. 7, 2012

Qian Hong <fracting(a)gmail.com> writes: > @@ -4110,7 +4120,9 @@ static void test_fullname2_helper(const char *Family) > > bufW[0] = 0; > bufA[0] = 0; > - ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size), "FAMILY (family name) could not be read\n"); > + ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, GetSystemDefaultLangID()) || > + get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, TT_MS_LANGID_ENGLISH_UNITED_STATES), You should avoid that sort of thing, it will be hard to debug, particularly since get_ttf_nametable_entry itself has ok() calls. Store the result in a variable instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/3] user32: Implement RegisterRawInputDevices().
by Alexandre Julliard Sept. 7, 2012

Sept. 7, 2012

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > @@ -2931,3 +2965,14 @@ DECL_HANDLER(set_cursor) > reply->new_clip = input->desktop->cursor.clip; > reply->last_change = input->desktop->cursor.last_change; > } > + > +DECL_HANDLER(update_rawinput_devices) > +{ > + const struct rawinput_device *devices = get_req_data(); > + unsigned int i; > + > + for (i = 0; i < req->device_count; ++i) > + { > + update_rawinput_device(&devices[i]); > + } > +} device_count is redundant (and unsafe), this should use the data size instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/5] vcomp: better stubs for _vcomp_for_static_simple_init, _vcomp_for_static_end
by Marvin Sept. 6, 2012

Sept. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21419 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [3/5] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next
by Marvin Sept. 6, 2012

Sept. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21418 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 2.
by Dmitry Timoshkov Sept. 6, 2012

Sept. 6, 2012

I hope that I've addressed Vincent's concern about todo_wine blanket coverage, is there anything else that prevents these 2 patches from being accepted? -- Dmitry.

1 0

Re: [PATCH 4/6] msvcp60: Fixed RTTI structure on 64-bit systems (try2)
by Alexandre Julliard Sept. 6, 2012

Sept. 6, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > try2: > - fixed base pointer offset calculation (patches 4,5,6) You should pass the module handle from DllMain instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] kernel32: Return correct drive type for empty drives (try2)
by Alexandre Julliard Sept. 6, 2012

Sept. 6, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -2544,7 +2544,8 @@ static NTSTATUS DVD_ReadStructure(int dev, const DVD_READ_STRUCTURE *structure, > } > > if (ioctl(dev, DVD_READ_STRUCT, &s) < 0) > - return STATUS_INVALID_PARAMETER; > + /* Will be converted into ERROR_INVALID_FUNCTION */ > + return (errno == ENOMEDIUM) ? STATUS_INVALID_DEVICE_REQUEST : STATUS_INVALID_PARAMETER; That doesn't make much sense, you probably want to use FILE_GetNtStatus. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] [cmd] move issues when overwriting files
by Alexandre Julliard Sept. 6, 2012

Sept. 6, 2012

Ann and Jason Edmeades <jason(a)edmeades.me.uk> writes: > @@ -1709,8 +1709,13 @@ void WCMD_move (void) > WINE_TRACE("Source '%s'\n", wine_dbgstr_w(src)); > WINE_TRACE("Dest '%s'\n", wine_dbgstr_w(dest)); > > - /* If destination exists, prompt unless /Y supplied */ > - if (GetFileAttributesW(dest) != INVALID_FILE_ATTRIBUTES) { > + /* If we have src == dest, skip moving this one */ > + if (strcmpW(src,dest)==0) ok = FALSE; You can't detect identical files by comparing file names. -- Alexandre Julliard julliard(a)winehq.org

1 0