September 2012 - Wine-Devel

Re: d3dx9_36 [patch 2/6]: Speed-up some tests
by Rico Schüller Sept. 27, 2012

Sept. 27, 2012

On 27.09.2012 09:57, Nozomi Kodama wrote: > - FLOAT a[64], b[64], got; > + FLOAT a[49], b[49], got; > CONST FLOAT expected[] = > { 0.5f, 0.5f, 25.0f, 262.5f, 1428.0f, 5362.0f, 15873.0f, 39812.0f, 88400.0f, }; > > - for (i = 0; i < 64; i++) > + for (i = 0; i < 49; i++) > > - for (i = 0; i < 9; i++) > + for (i = 0; i <= D3DXSH_MAXORDER + 1; i++) Again: You may correct the (array) size for the expected value ... If we run til element 7 instead of 8, I think the last element could be thrown away? Cheers Rico

1 0

Re : d3dx9 [patch 1/5]: Implement D3DXSHMultiply4
by Nozomi Kodama Sept. 26, 2012

Sept. 26, 2012

>On 26.09.2012 12:17, Nozomi Kodama wrote: >> + ta =0.28209479f * a[0]+ 0.14567312f * a[8]+ 0.12615663f * a[6]; >> + tb =0.28209479f * b[0]+ 0.14567312f * b[8]+ 0.12615663f * b[6]; >> + out[13] += ta * b[13] + tb * a[13]; <> + t = a[13] * b[13]; >> + out[0] +=0.28209479f *t; >Please use spaces with care. >The preferred way is "x = 123 * a[0] + 456 * b[234]; Mostly one space is enough, only use two or more if >you like to indent something, that's mostly not the case when calculating a value. Even then, please be >consistent across your patch. oops!!! I will take care of this one. >> + D3DXSHMultiply4(c, a, b); >>What happens if you use something like D3DXSHMultiply4(c, c, c). Is that allowed? Tests in native show that D3DXSHMultiply gives what I implemented. We can not reuse a input variable as output (we don't obtain what we expect logically). >Also is there a reason why it uses slightly different values than e.g. D3DXSHMultiply3? Why don't we >use defines? A problem might be to find good names... Maybe the Multiply functions could share the >same base? To me it looks like they do share a lot of calculations, And if the order doesn't matter (see >comment above) then it may be possible to rearrange the calculation. > >ta = 0.28209479f * a[0] - 0.12615663f * a[6] - 0.21850969f * a[8]; >vs >ta = 0.28209479f * a[0] - 0.12615662f * a[6] - 0.21850968f * a[8]; I do the computations with a formal computation software. Unfortunately I did not use the same for D3DXSHMultiply4 and D3DXSHMultiply3 ..... (Xcas vs Maple). And obtain the exact values look beyond the capacities of these softwares. And even the worst, since the integrated functions oscillate, the internal algorithm of the software are not robust to compute the integrals. For a given number of significative digits, that's why we obtain slightly different values for the both softwares. Addind defines will add tons on variables for no gain. But I can simplify slightly the function by calling D3DXSHMultiply3. I will give it a try. I worry about efficiency. Best regards Nozomi >Cheers >Rico

2 1

Re: oledb32: Add support for IDBInitialize interface in IDataInitialize
by Alexandre Julliard Sept. 26, 2012

Sept. 26, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Changelog: > oledb32: Add support for IDBInitialize interface in IDataInitialize It doesn't work here: ../../../tools/runtest -q -P wine -M oledb32.dll -T ../../.. -p oledb32_test.exe.so database.c && touch database.ok database.c:43: Test failed: Unable to load oledb library make[1]: *** [database.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (try 3) imm32: there is only 1 default Hwnd per thread
by Alexandre Julliard Sept. 26, 2012

Sept. 26, 2012

Aric Stewart <aric(a)codeweavers.com> writes: > - if (data->imeWnd == NULL) > + if (defWnd == NULL) > { > /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + defWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + SetWindowLongPtrW(defWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = defWnd; So now, shouldn't you be resetting IMMGWL_IMC at some point? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: (resend) imm32: there is only 1 default Hwnd per thread
by Alexandre Julliard Sept. 26, 2012

Sept. 26, 2012

Aric Stewart <aric(a)codeweavers.com> writes: > This corrects issues with applications that create and manage multiple IMCs > try 2: > avoid premature destruction of the window > --- > dlls/imm32/imm.c | 22 ++++++++++++---------- > dlls/imm32/tests/imm32.c | 28 ++++++++++++++++++++++++++++ > 2 files changed, 40 insertions(+), 10 deletions(-) > > > > diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c > index 7394101..a18aa26 100644 > --- a/dlls/imm32/imm.c > +++ b/dlls/imm32/imm.c > @@ -678,10 +678,6 @@ static BOOL IMM_DestroyContext(HIMC hIMC) > data->immKbd->pImeSelect(hIMC, FALSE); > SendMessageW(data->IMC.hWnd, WM_IME_SELECT, FALSE, (LPARAM)GetKeyboardLayout(0)); > > - if (IMM_GetThreadData()->hwndDefault == data->imeWnd) > - IMM_GetThreadData()->hwndDefault = NULL; > - DestroyWindow(data->imeWnd); > - > ImmDestroyIMCC(data->IMC.hCompStr); > ImmDestroyIMCC(data->IMC.hCandInfo); > ImmDestroyIMCC(data->IMC.hGuideLine); > @@ -2323,12 +2319,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > > if (data->imeWnd == NULL) > { > - /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > - data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > - 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + HWND def = IMM_GetThreadData()->hwndDefault; > + if (def == NULL) > + { > + /* create the ime window */ > + data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > + 0, data->immKbd->hIME, 0); > + SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = data->imeWnd; > + } > + else > + data->imeWnd = def; So why is there a window in the IMC at all, if it's not used for anything? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/8] vbscript: Added VT_R8 support to to_int
by Marvin Sept. 26, 2012

Sept. 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21824 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/8] vbscript: Added Round implementation
by Marvin Sept. 26, 2012

Sept. 26, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21823 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: d3dx9 [patch 1/5]: Implement D3DXSHMultiply4
by Rico Schüller Sept. 26, 2012

Sept. 26, 2012

On 26.09.2012 12:17, Nozomi Kodama wrote: > + ta =0.28209479f * a[0]+ 0.14567312f * a[8]+ 0.12615663f * a[6]; > + tb =0.28209479f * b[0]+ 0.14567312f * b[8]+ 0.12615663f * b[6]; > + out[13] += ta * b[13] + tb * a[13]; > + t = a[13] * b[13]; > + out[0] +=0.28209479f *t; Please use spaces with care. The preferred way is "x = 123 * a[0] + 456 * b[234]; Mostly one space is enough, only use two or more if you like to indent something, that's mostly not the case when calculating a value. Even then, please be consistent across your patch. > + D3DXSHMultiply4(c, a, b); What happens if you use something like D3DXSHMultiply4(c, c, c). Is that allowed? Also is there a reason why it uses slightly different values than e.g. D3DXSHMultiply3? Why don't we use defines? A problem might be to find good names... Maybe the Multiply functions could share the same base? To me it looks like they do share a lot of calculations, And if the order doesn't matter (see comment above) then it may be possible to rearrange the calculation. ta = 0.28209479f * a[0] - 0.12615663f * a[6] - 0.21850969f * a[8]; vs ta = 0.28209479f * a[0] - 0.12615662f * a[6] - 0.21850968f * a[8]; Cheers Rico

1 0

Re: winspool/tests: Don't crash when AddJob/GetJob fails (win8)
by Marvin Sept. 25, 2012

Sept. 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21799 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Wine Mono 0.0.6 Release - Because hey, why not?
by Vincent Povirk Sept. 25, 2012

Sept. 25, 2012

I have published version 0.0.6 of Wine Mono on Sourceforge, because it's probably not good to let it get too stale. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.6/wine-mono-0.0.… The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.6/wine-mono-0.0.… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.4: * Updated the visual basic class libraries from upstream. * Updated mono from 2.11.1 to 2.11.4. Unfortunately, there wasn't a nice changelog like 2.11.1 had. Here are some highlights: * Beginnings of support for hosting ActiveX controls inside winforms. (Alistair Leslie-Hughes) * Various HttpClient-related fixes. (Martin Baulig) * "Intermediate" state check boxes now rendered in winforms. (Steven Boswell II) * ACL support on Windows. (James Bellinger) * One can now specify WINE_MONO_TRACE=wrapper to log all transitions between native and managed code, which is sort of the Mono equivalent of a relay log. * RVA fields can now be accessed properly via the ldsfld[a] instruction. This should help with Managed C++ support. * Fix for winehq bug 30947 - Mono would cause a hang when a dll is loaded after Mono is loaded but before it is used to run any .NET code. * Because of a problem with the build system, MonoPosixHelper.dll was not present, and this prevented some builtin methods in Mono from working correctly. This has been resolved. * Added hashes for all included files in the msi package, which is needed for msi to replace the files on upgrade. * Added 64-bit registry entries to the msi package.

1 1