September 2012 - Wine-Devel

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.
by Juan Lang Sept. 19, 2012

Sept. 19, 2012

Hi Francois, pretty sure you didn't mean to leave this hunk in: @@ -2296,9 +2406,13 @@ START_TEST(shlexec) init_test(); +#if 0 test_argify(); test_lpFile_parsed(); test_filename(); +#endif + test_fileurl(); +#if 0 test_find_executable(); test_lnks(); test_exes(); @@ -2308,6 +2422,7 @@ START_TEST(shlexec) test_commandline(); test_directory(); test_trojans(); +#endif --Juan

1 0

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.
by Marvin Sept. 19, 2012

Sept. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21649 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] scrrun: Moved creating filesystem object to its own function
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -194,13 +245,33 @@ HRESULT WINAPI DllUnregisterServer(void) > > HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID* ppv) > { > + scrruncf *This; > + HRESULT hr = CLASS_E_CLASSNOTAVAILABLE; > + > + TRACE("(%s, %s, %p): stub\n", debugstr_guid(rclsid), debugstr_guid(riid), ppv); > + > + if(!ppv) > + return E_INVALIDARG; > + > + This = HeapAlloc(GetProcessHeap(), 0, sizeof(scrruncf)); > + > + This->IClassFactory_iface.lpVtbl = &scrruncf_vtbl; > + This->pfnCreateInstance = NULL; > + This->ref = 1; > + > if(IsEqualGUID(&CLSID_FileSystemObject, rclsid)) { > - TRACE("(CLSID_WshShell %s %p)\n", debugstr_guid(riid), ppv); > - return IClassFactory_QueryInterface(&FileSystemFactory, riid, ppv); > + TRACE("(CLSID_FileSystemObject %s %p)\n", debugstr_guid(riid), ppv); > + This->pfnCreateInstance = &create_filesystem; > + This->clsid = IID_IFileSystem3; > + } You could just as well continue using static instances of the class factory, and using the IID as a clsid doesn't make much sense. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] user32/tests: Add tests for class small icons (try 3).
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Sergey Guralnik <serhio(a)etersoft.ru> writes: > +todo_wine > + ok( hsmicon != NULL, "GetClassLong should return non-zero handle\n"); > + for(i = 0; i < 100; i++) > + if(hsmicon != (HICON)GetClassLongPtrW(hwnd, GCLP_HICONSM)) > + { > + ok(FALSE, "Always should return the same icon handle\n"); > + break; > + } This doesn't make sense, it's not going to return the same thing 99 times and then suddenly something different. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ole32: Add CoGetDefaultContext stub
by Michael Stefaniuc Sept. 19, 2012

Sept. 19, 2012

Hallo Alistair, > --- > dlls/ole32/compobj.c | 9 +++++++++ > dlls/ole32/ole32.spec | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c > index 0055d15..2ea1dc9 100644 > --- a/dlls/ole32/compobj.c > +++ b/dlls/ole32/compobj.c > @@ -4279,6 +4279,15 @@ HRESULT WINAPI CoGetContextToken( ULONG_PTR *token ) > return S_OK; > } > > +/*********************************************************************** > + * CoGetContextToken [OLE32.@] copy and paste error ^^^ > + */ > +HRESULT CoGetDefaultContext(APTTYPE type, REFIID riid, LPVOID *ppv) bye michael

2 1

user32/tests: Add tests for class small icons (try 3).
by Sergey Guralnik Sept. 19, 2012

Sept. 19, 2012

There are two patches that stay at queue more than weeek, and have no comments yet: From 5c723835fb9b8b56ccaf2a22256524c84b358fe9 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Tue, 11 Sep 2012 10:24:56 +0400 Subject: [PATCH 1/2] user32/tests: Add tests for class small icons (try 3). From 49d6118117ccfb4efecbb9839b279cc286b19392 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Tue, 11 Sep 2012 13:40:54 +0400 Subject: [PATCH 2/2] user32: Add internal class small icons functionality (try 3). Is something wrong with them? -- Sergey

1 0

user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik Sept. 19, 2012

Sept. 19, 2012

Alexandre Julliard writes: > Not really. If you want to test purely the Wine behavior, then you > shouldn't be waiting for window manager events. If the window manager > is > involved then you can't guarantee that a given window will always get > focus. > If your app breaks because the window manager doesn't give it focus > at a > certain point, then pretty much the only solution is to change the wm > policy, or use a different wm. Thanks for explanations. -- Sergey

1 0

Re: [PATCH 3/3] jscript: Added support for no new line between return and expression rule
by Marvin Sept. 18, 2012

Sept. 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21637 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386
by Jacek Caban Sept. 18, 2012

Sept. 18, 2012

Please ignore this last patch. It has one more dependency that I didn't send yet. On 09/17/12 15:21, Jacek Caban wrote: > --- > dlls/jscript/jsutils.c | 4 +- > dlls/jscript/jsval.h | 143 > +++++++++++++++++++++++++++++++++++++---------- > 2 files changed, 114 insertions(+), 33 deletions(-) >

2 2