January 2013 - Wine-Devel - list.winehq.org

Re: [PATCH] [2/2] kernel32/tests: Add test with a large string for CompareStringA.
by Nikolay Sivov Jan. 8, 2013

Jan. 8, 2013

On 1/8/2013 16:34, Tatyana Fokina wrote: > + > + memset(a, 'a', sizeof(a)); > + SetLastError(NO_ERROR); > + ret = CompareStringA(lcid, 0, a, sizeof(a), a, sizeof(a)); > + error = GetLastError(); > + ok(!error && ret == CSTR_EQUAL, "ret %d (expected %d), error %d\n", ret, CSTR_EQUAL, error); It's better to set it to some value you don't expect to be ever used as error code, like 0xdeadbeef or 0xb19b00b5.

2 1

[PATCH] winspool.drv: Ignore pDevModeInput if fMode not equal DM_IN_BUFFER
by Tatyana Fokina Jan. 8, 2013

Jan. 8, 2013

1 0

Re: [PATCH] [2/2] kernel32/tests: Add test with a large string for CompareStringA.
by Marvin Jan. 8, 2013

Jan. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23793 Your paranoid android. === W2K8SE (32 bit locale) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [2/3] xmllite: Report value for PI nodes
by Marvin Jan. 8, 2013

Jan. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23792 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/3] xmllite: Report node value for comment nodes
by Marvin Jan. 8, 2013

Jan. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23791 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d8/tests: Merge d3d8_main.c into device.c.
by Marvin Jan. 8, 2013

Jan. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23788 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] dplayx: check return of CoCreateInstance (Coverity)
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23787 Your paranoid android. === W2K8SE (32 bit dplayx) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] dplayx: check return of CoCreateInstance (Coverity)
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23787 Your paranoid android. === W2K8SE (32 bit dplayx) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] ddraw: Don't discard buffers that haven't been used in draws (try 2)
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23786 Your paranoid android. === W2K8SE (32 bit ddraw7) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation === W2K8SE (32 bit ddraw4) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] advapi32: close scm_handle on error exit (Coverity)
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23785 Your paranoid android. === W2KPROSP4 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0 === WXPPROSP3 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0 === W2K3R2SESP2 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0 === W2K8SE (32 bit service) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 7/7] d3dcompiler43/tests: Don't use IUnknown_Release(). (resend)
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23784 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/7] d3dx9: Handle invalid byte code in D3DXGetShaderConstantTableEx(). (resend)
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23783 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/7] d3dx9: Always set the table = NULL in D3DXGetShaderConstantTableEx(). (resend)
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23782 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Don't copy extra data from the end of a row.
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23777 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/6] loader: On Mac, embed Info.plist in (__TEXT, __info_plist) section. [try 2]
by Alexandre Julliard Jan. 7, 2013

Jan. 7, 2013

Ken Thomases <ken(a)codeweavers.com> writes: > @@ -731,11 +731,13 @@ case $host_os in > AC_SUBST(IOKITLIB,"-framework IOKit -framework CoreFoundation") > AC_SUBST(APPLICATIONSERVICESLIB,"-framework ApplicationServices") > AC_SUBST(CORESERVICESLIB,"-framework CoreServices") > + AC_SUBST(WINE_INFO_PLIST,"wine_info.plist") > + AC_CONFIG_FILES(loader/$WINE_INFO_PLIST) This should be generated from the Makefile. The convention is that configure generates makefiles, and makefiles generate the rest. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/6] loader: On Mac, embed Info.plist in (__TEXT, __info_plist) section.
by Charles Davis Jan. 7, 2013

Jan. 7, 2013

On Jan 6, 2013, at 6:54 PM, Ken Thomases wrote: > diff --git a/loader/wine_info.plist.in b/loader/wine_info.plist.in > new file mode 100644 > index 0000000..c332649 > --- /dev/null > +++ b/loader/wine_info.plist.in > @@ -0,0 +1,28 @@ > +<?xml version="1.0" encoding="UTF-8"?> > +<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> > +<plist version="1.0"> > +<dict> > + <key>CFBundleDevelopmentRegion</key> > + <string>English</string> > + <key>CFBundleExecutable</key> > + <string>wine</string> > + <key>CFBundleIdentifier</key> > + <string>org.winehq.wine</string> > + <key>CFBundleInfoDictionaryVersion</key> > + <string>6.0</string> > + <key>CFBundleName</key> > + <string>Wine</string> > + <key>CFBundlePackageType</key> > + <string>APPL</string> > + <key>CFBundleShortVersionString</key> > + <string>@PACKAGE_VERSION@</string> > + <key>CFBundleSignature</key> > + <string>????</string> > + <key>CFBundleVersion</key> > + <string>@PACKAGE_VERSION@</string> > + <key>LSMinimumSystemVersion</key> > + <string>10.6</string> With this, you won't be able to launch Wine from the Finder or with open(1) prior to 10.6. Chip > + <key>NSPrincipalClass</key> > + <string>WineApplication</string> > +</dict> > +</plist> >

4 4

Re: wininet: Fixed handling NULL buffer in INTERNET_OPTION_PROXY queries
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23776 Your paranoid android. === W2K8SE (32 bit internet) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/5] dsound: rework ugly mixer logic
by Andrew Eikum Jan. 7, 2013

Jan. 7, 2013

This patch breaks the sound on Zaxxon[1] on both CoreAudio and ALSA without PulseAudio. I didn't test OSS. It skips around on the ship's shooting noises. I've attached good and bad logs on ALSA here. [1] http://www.classic-retro-games.com/Zaxxon_70.html Andrew On Wed, Jan 02, 2013 at 02:46:43PM +0100, Maarten Lankhorst wrote: > --- > dlls/dsound/dsound.c | 1 - > dlls/dsound/dsound_main.c | 6 - > dlls/dsound/dsound_private.h | 6 +- > dlls/dsound/mixer.c | 253 +++++++++++-------------------------------- > dlls/dsound/primary.c | 95 ++++++---------- > 5 files changed, 99 insertions(+), 262 deletions(-)

1 0

Re: [PATCH 2/3] mshtml: Added IHTMLStyle::put_pixelLeft implementation
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23774 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] mshtml: Added IHTMLStyle::get_pixelLeft implementation
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23773 Your paranoid android. === W2K8SE (32 bit style) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [3/3] xmllite: Support name reporting for comments and PIs
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23772 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] xmllite: Support streams starting with comments, simplify tests
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23771 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/3] xmllite: Implement PI parsing
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23770 Your paranoid android. === W2K8SE (32 bit reader) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

2 1

Re: [PATCH] kernel32: implement condition variables
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23769 Your paranoid android. === W2K8SE (32 bit sync) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] kernel32: improve condition variable testcase
by Marvin Jan. 7, 2013

Jan. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23768 Your paranoid android. === W2K8SE (32 bit sync) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0