January 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 07/17] msvcrt: Added write tests on unicode files
by Marvin Jan. 10, 2013

Jan. 10, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23835 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 05/17] msvcrt: Added fopen_s test with ccs option
by Marvin Jan. 10, 2013

Jan. 10, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23834 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 0/7] Series short description
by Alexandre Julliard Jan. 9, 2013

Jan. 9, 2013

Eric Pouech <eric.pouech(a)orange.fr> writes: > The following series implements a new scheme for managing 'bare' consoles. > We now force every program started without a wine parent to be run under > wineconsole (transparently for the user). > This is done using a new backend in wineconsole called 'line'. This backend > only takes care of input; output is kept as a client side operation. > All terminal related code is moved from dlls/kernel32 to programs/wineconsole. > > This basically ensures that: > - Only wineconsole reads from standard input (and writes into input queue). > This fixes bug reported by Jason when $CONIN is opened with read access only. > - It also enforces that wineconsole always has control of the unix terminal, > hence ensuring that we properly reset the terminal settings upon exit. Running make test with this series hangs in the hlink.c test, there seems to be a wineconsole process that never terminates. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] crypt32: free the encoded msg (Coverity)
by Juan Lang Jan. 9, 2013

Jan. 9, 2013

In case this was awaiting an ACK from me, this looks good. Thanks. --Juan

1 0

Re: usp10: Implement GPOS MarkToLigature Attachment Positioning Subtable
by Huw Davies Jan. 9, 2013

Jan. 9, 2013

On Wed, Jan 09, 2013 at 11:36:51AM -0600, Aric Stewart wrote: > +typedef struct { > + WORD LigatureAnchor[1]; > +} GPOS_ComponentRecord; > + > +typedef struct { > + WORD ComponentCount; > + GPOS_ComponentRecord ComponentRecord[1]; > +} GPOS_LigatureAttach; > + > + for (i = 0; i < component_count && !offset; i++) > + { > + int k; > + for (k = 0; k < class_count && !offset; k++) > + offset = GET_BE_WORD(lt->ComponentRecord[i].LigatureAnchor[k]); > + } Hi Aric, This can't work as ComponentRecord is a variable-sized struct. Huw.

2 1

Re: [PATCH (try3)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks
by Marvin Jan. 9, 2013

Jan. 9, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23822 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] d3d8/tests: Merge surface.c into device.c.
by Marvin Jan. 9, 2013

Jan. 9, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23820 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: aclocal: Use -Werror when checking compiler flags (try 2)
by Alexandre Julliard Jan. 9, 2013

Jan. 9, 2013

Per Johansson <per(a)morth.org> writes: > ...if supported by compiler. > This makes clang exit with error on unsupported warnings. > --- > aclocal.m4 | 2 +- > configure.ac | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/aclocal.m4 b/aclocal.m4 > index 14cf916..a6d9f12 100644 > --- a/aclocal.m4 > +++ b/aclocal.m4 > @@ -74,7 +74,7 @@ AC_DEFUN([WINE_TRY_CFLAGS], > [AS_VAR_PUSHDEF([ac_var], ac_cv_cflags_[[$1]])dnl > AC_CACHE_CHECK([whether the compiler supports $1], ac_var, > [ac_wine_try_cflags_saved=$CFLAGS > -CFLAGS="$CFLAGS $1" > +CFLAGS="$CFLAGS $ac_wine_try_cflags_werror $1" > AC_LINK_IFELSE([AC_LANG_SOURCE([[int main(int argc, char **argv) { return 0; }]])], > [AS_VAR_SET(ac_var,yes)], [AS_VAR_SET(ac_var,no)]) aclocal macros should be stand-alone, they shouldn't depend on things done by the main configure. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] windowscodecs: Add a test for loading a .bmp file with BITMAPINFOHEADER.
by Vincent Povirk Jan. 9, 2013

Jan. 9, 2013

Series looks fine to me. And yes, testbot has been broken for a while now..

1 0

Re: [PATCH 5/5] d3d8/tests: Merge surface.c into device.c.
by Alexandre Julliard Jan. 9, 2013

Jan. 9, 2013

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > dlls/d3d8/tests/Makefile.in | 1 - > dlls/d3d8/tests/device.c | 704 ++++++++++++++++++++++++++++++++++++++++++- > dlls/d3d8/tests/surface.c | 653 --------------------------------------- > 3 files changed, 702 insertions(+), 656 deletions(-) > delete mode 100644 dlls/d3d8/tests/surface.c It doesn't work here: ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so device.c && touch device.ok device.c:4088: Test failed: Got unexpected hr 0x88760867. device.c:4091: Test failed: Got unexpected refcount 3, expected 4. device.c:4092: Test failed: Got unexpected ptr 0x15, expected 0x21fdb8. wine: Unhandled page fault on read access to 0x00000015 at address 0x684e3686 (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

2 1