October 2013 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.
by Alexandre Julliard April 23, 2015

April 23, 2015

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 57 > ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html -- Alexandre Julliard julliard(a)winehq.org

3 8

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

FOSDEM '14 Call for Papers
by Jeremy White Dec. 2, 2013

Dec. 2, 2013

Folks, There will a Wine devroom at FOSDEM '14 on Sunday, February 2, 2014. Last year we had a great time, and I think it was valuable for us to connect with the broader Free software community. I'd like to now invite you to submit proposals for talks. I'd really like to encourage everyone to think of something fun to share with the 5,000 geeks that will be swarming Brussels. If you have an topic you'd like to discuss, or an idea you want to present, please submit it to: https://penta.fosdem.org/submission You will create an account (if you don't have one from a previous year), and select the "Wine devroom" as the track. Please either submit for lengths of 30 or 60 minutes. The deadline for submissions is December 1st. I think it would be great if we branched out a bit, and submitting a crazy off the wall proposal will just burn churn a few electrons. So submit it! For further discussion, please follow up to wineconf(a)winehq.org. Cheers, Jeremy

1 1

WineTestBot status update
by Francois Gouget Nov. 14, 2013

Nov. 14, 2013

We switched to the new WineTestBot near the start of September. Early on it ran into a problem when it was flooded with tests due to the __WINESRC__ tests work and it failed to keep up. The reason is that as time went on the time it takes to get the VMs back to a clean state ready to run the tests (the revert time) kept increasing as can be seen on this graph: http://fgouget.free.fr/wtb/vm1-revtimes.png There one can see the increased activity in september that what was caused by the surge in test patches. But the most remarkable feature is the Windows XP revert times which increase linearly, reaching over 30 minutes. The revert times for the other VMs are much more random but still seem to increase somewhat (1). The reason for the increase is still unknown. The revert time fell down a few times and now I suspect this corresponds to times when the VM was restored from backup. So at the start of October I upgraded to QEMU 1.6.0 and restored all the VMs from backup, hoping this would solve the problem. The revert times did get much better and the WineTestBot now manages to keep up: http://fgouget.free.fr/wtb/vm1-revtimes-new.png The upgrade happened around the 2nd of october and the revert times fell at that point. But looking at more recent data it's clear that the Windows XP revert times are increasing again, while those of the other VMs remain stable (see vm1-revtimes.xls for the raw data). That XP VM is one of the first ones I created, so it probably was created with a pretty old QEMU version. Futhermore it was only an out of the box SP2 and did not have any of the later updates. So I decided to recreate it from scratch, using QEMU 1.6.0, and to add all the other updates as I was at it. And I'm hoping that this time things will be better. That's why this VM is currently in 'maintenance' mode. I also took down the 32-bit Windows 8 VM for maintenance. It too is missing proper updates and the plan is to upgrade it to Windows 8.1. Another issue has been that the tests are running a bit slow, a particular point of pain was msi:action and msi:install which were regularly timing out. See: http://fgouget.free.fr/wtb/runtimes.htm So while rebuilding the Windows XP VM I did some performance tests. That paid off. I found that switching the emulated disk cache mode from writeback to default roughly halves the msi run times: http://fgouget.free.fr/wtb/runtimes2.htm msi:action and msi:install went from an average of 99 and 90 seconds down to 48 and 39 seconds and they are not timing out anymore. The remaining troublesome tests are now ddraw:ddraw{2,4,7}, shell32:shlexec, and winspool.drv:info. I also uncovered two other potential performance issues: * Some VMs have Windows Defender and apparently it was starting a full disk scan as soon as the VM was ready to run the tests. That's clearly not good so I disabled Windows Defender in all VMs. * Most VMs were still using 20% of the CPU when idle. That's fine if only one VM is running but could impact performance (through increased interrupt rates) if many are running at once (like on the WineTestBot). Apparently the culprit is the USB Tablet device that's added by default. So I removed it from all VMs too (and now the mouse is even more laggy than before when I work on the VMs :-( But that does not impact the tests). So there is still a lot of work to do on the WineTestBot, and that's not even counting fixing all the failing tests. (1) It's almost as if the increasing Windows XP revert times were pulling up the other VM revert times. Yet there's only one revert at a given time, so I don't see how this would be possible. (2) Setting the cache mode to writeback was improving the performance quite a bit with the pre-upgrade QEMU version. But obviously it's not true anymore. Another interesting point is that the Virtio mode improves performance by a factor of 10 (down from 450 seconds to 45 in msi:action). Yet Windows 8 posts the fastest times yet in the basic IDE mode (~23 seconds). I couldn't get Windows 8 working with the Virtio disk yet and I have not verified that it's really doing the same set of tests. So that remains to be confirmed. Here is some performance data taken from the Windows XP VM while the TestBot was idle. From it cache=default looks like it's a completely separate mode! msi:action | msi:install | msi:msi 448 460 520| 487 439 | 238 229 VGA, qcow2 ide disk, cache:default 44 45 42 | 47 49 46 | 24 23 21 VGA, qcow2 virtio disk, cache:default 48 45 50 | 47 48 48 | 23 23 24 VMVGA/VGA, qcow2 virtio disk, cache:default 47 46 | 48 46 | 23 22 22 VMVGA, qcow2 virtio disk, cache:default 47 47 | 49 48 | 24 23 VMVGA, raw virtio disk, cache:default 62 67 67 | 64 60 63 | 29 27 27 VMVGA, raw virtio disk, cache:none 111 92 72 113 | 101 101 | 37 37 40 VMVGA, raw virtio disk, cache:writethrough 61 64 53 | 70 59 58 | 36 28 29 VMVGA, raw virtio disk, cache:writeback 46 44 | | VMVGA, raw virtio disk, cache:default 71 55 68 | | VMVGA, raw virtio disk, cache:writeback 65 71 72 69| | VMVGA, raw virtio disk, cache:none 76 118 111 | | VMVGA, raw virtio disk, cache:writethrough 50 48 47 | | VMVGA, raw virtio disk, cache:default And the preliminary Windows 8 performance. I hope it holds up. msi:action | msi:install | msi:msi 23 22 22 | 16 15 16 | 13 13 15 VGA, qcow2 ide disk, cache:default -- Francois Gouget <fgouget(a)codeweavers.com>

6 12

Re: winex11.drv: Add TIMESTAMP to X clipboard TARGETS
by Alexandre Julliard Nov. 1, 2013

Nov. 1, 2013

Andrey Vostrikov <andrey.vostrikov(a)cogentembedded.com> writes: > + else if(event->target == x11drv_atom(TIMESTAMP)) /* Return event timestamp */ > + { > + /* TIMESTAMP selection request */ > + XChangeProperty(display, request, rprop, event->target, > + 32, PropModeReplace, (unsigned char*)&event->time, 1); That's not the correct timestamp. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH] quartz/tests: Enable compilation with -D__WINESRC__
by Marvin Nov. 1, 2013

Nov. 1, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3099 Your paranoid android. === w864 (32 bit filtergraph) === filtergraph: unhandled exception c0000005 at 00404347 === w864 (64 bit filtergraph) === filtergraph: unhandled exception c0000005 at 0000000000403DF2

3 2

Re: [PATCH 3/3] opengl32: Use opengl xml registry files.
by Alexandre Julliard Oct. 31, 2013

Oct. 31, 2013

Rico Schüller <kgbricola(a)web.de> writes: > --- > dlls/opengl32/make_opengl | 316 > +++++++++++++++++++--------------------------- > dlls/winemac.drv/opengl.c | 8 +- > dlls/winex11.drv/opengl.c | 8 +- > 3 Dateien geändert, 136 Zeilen hinzugefügt(+), 196 Zeilen entfernt(-) It's not generating quite the same thing as the previous version, and some of the differences look wrong, for instance: -static void WINAPI glBindAttribLocation( GLuint program, GLuint index, const GLchar* name ) { +static void WINAPI glBindAttribLocation( GLhandleARB programObj, GLuint index, const GLcharARB* name ) { -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: [PATCH 3/5] ddraw/tests: Use explicit A calls.
by Marvin Oct. 31, 2013

Oct. 31, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3136 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:3055: Test failed: SetDisplayMode failed, hr 0x80004001. === wvista (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w2008s64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7pro64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w8 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w864 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w864 (32 bit visual) === visual.c:2616: Test failed: unexpected colortable on offscreen surface

1 0

Re: [PATCH 1/5] d3d9/tests: Use color_match() in more places.
by Marvin Oct. 31, 2013

Oct. 31, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3134 Your paranoid android. === w8 (32 bit visual) === visual.c:6533: Test failed: Test blendindices returned color 0x00333333, expected 0x00000000. === w864 (32 bit visual) === visual.c:6533: Test failed: Test blendindices returned color 0x00333333, expected 0x00000000. === w864 (64 bit visual) === visual.c:6533: Test failed: Test blendindices returned color 0x00333333, expected 0x00000000.

1 0

Re: server: Make it possible for WaitCommEvent to detect recursive requests.
by Marvin Oct. 31, 2013

Oct. 31, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3133 Your paranoid android. === w7pro64 (32 bit comm) === comm.c:859: Test failed: WaitCommEvent failed with a timeout comm.c:870: recovering after WAIT_TIMEOUT... comm.c:880: Test failed: WaitCommEvent error 0 comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1500) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting comm.c:1550: test_AbortWaitCts timeout 500 handle 000000F8 comm.c:1517: Changing CommMask on the fly for handle 000000F8 after timeout 500

1 0

Re: shell32: Check number of bytes returned by ReadFile.
by Dmitry Timoshkov Oct. 31, 2013

Oct. 31, 2013

What is the reason for setting state of this patch as 'pending'? -- Dmitry.

2 1

Re: [PATCH 2/3] winmm/tests: Use the explicit mciSendCommandA() version.
by Marvin Oct. 30, 2013

Oct. 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3126 Your paranoid android. === w7pro64 (32 bit mci) === mci.c:988: Test failed: 394ms is not in the expected 400-600ms range mci.c:995: Test failed: 394ms is not even in the expected 400-1000ms range

1 0

Re: [PATCH 1/3] winmm/tests: Avoid duplicating the tested call in the ok() message.
by Marvin Oct. 30, 2013

Oct. 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3125 Your paranoid android. === wvista (32 bit mci) === mci.c:987: Test failed: 398ms is not in the expected 400-600ms range mci.c:994: Test failed: 398ms is not even in the expected 400-1000ms range === w864 (32 bit mci) === mci.c:987: Test failed: 398ms is not in the expected 400-600ms range mci.c:994: Test failed: 398ms is not even in the expected 400-1000ms range === w7pro64 (64 bit mci) === mci.c:856: Test failed: mci status mode: playing after play from 0 to 0

1 0

Re: shlwapi: Test and fix the behaviour of the CopyTo method for file sizes not multiple of the internal buffer size, on SHC
by Marvin Oct. 30, 2013

Oct. 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3116 Your paranoid android. === wvista (32 bit istream) === istream.c:669: Test failed: SHCreateStreamOnFileEx failed with ret=0x8007007b === w2008s64 (64 bit istream) === istream.c:669: Test failed: SHCreateStreamOnFileEx failed with ret=0x8007007b

1 0

Re: shlwapi: Test and fix the behaviour of the CopyTo method for file sizes not multiple of the internal buffer size, on SHCreateStreamOnFileEx-returned IStreams. (try 4)
by Alexandre Julliard Oct. 30, 2013

Oct. 30, 2013

"David Quintana (gigaherz)" <gigaherz(a)gmail.com> writes: > +{ > + HRESULT ret; > + IStream* src; > + IStream* dst; > + ULARGE_INTEGER count, read, written; > + > + CHAR srcPathA[MAX_PATH]; > + CHAR dstPathA[MAX_PATH]; > + > + WCHAR srcPath[MAX_PATH]; > + WCHAR dstPath[MAX_PATH]; > + > + const CHAR *srcFileName = "SHCreateStreamOnFileEx-src.dat"; > + const CHAR *dstFileName = "SHCreateStreamOnFileEx-dst.dat"; > + > + GetTempPathA(MAX_PATH, srcPathA); > + lstrcatA(srcPathA, srcFileName); > + MultiByteToWideChar(CP_ACP, 0, srcPathA, -1, srcPath, MAX_PATH); > + > + GetTempPathA(MAX_PATH, dstPathA); > + lstrcatA(dstPathA, dstFileName); > + MultiByteToWideChar(CP_ACP, 0, dstPathA, -1, dstPath, MAX_PATH); There's no reason to use such specific file names, just use GetTempFileName or something like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/5] d3d9/tests: Use explicit A calls.
by Marvin Oct. 30, 2013

Oct. 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3115 Your paranoid android. === w864 (32 bit device) === device: unhandled exception c0000005 at 74C714C8 === w864 (64 bit device) === device: unhandled exception c0000005 at 000007F9366B90EB

1 0

Re: [PATCH 2/5] d3d9/tests: Avoid windowsx.h.
by Marvin Oct. 30, 2013

Oct. 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3114 Your paranoid android. === w864 (32 bit device) === device: unhandled exception c0000005 at 74C714C8 === w864 (64 bit device) === device: unhandled exception c0000005 at 000007F9366B90EB

1 0

Re: crypt32: Check number of bytes returned by ReadFile and avoid a memory leak on error path.
by Dmitry Timoshkov Oct. 29, 2013

Oct. 29, 2013

This patch is marked as superseded in the tracker but it is not. -- Dmitry.

1 0

Re: [PATCH 3/5] d3d8/tests: Use explicit A calls.
by Marvin Oct. 29, 2013

Oct. 29, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3095 Your paranoid android. === w864 (32 bit device) === device.c:2494: Test failed: Expected foreground window 0004017A, got 0001007A. device.c:3190: Test failed: Expected wndproc 0x40ff80, got 0x40ff80.

1 0

Re: [PATCH 2/5] d3d8/tests: Avoid windowsx.h.
by Marvin Oct. 29, 2013

Oct. 29, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3094 Your paranoid android. === w7pro64 (32 bit device) === device.c:2465: Test failed: Expected foreground window 00030170, got 00060144. === w864 (32 bit device) === device.c:2483: Test failed: Expected foreground window 0004017A, got 0001007A. device.c:3176: Test failed: Expected wndproc 0x40ff80, got 0x40ff80.

1 0

Re: [PATCH 2/5] ddraw/tests: Allow some flags to fail surface creation in test_rt_caps (try 2).
by Marvin Oct. 28, 2013

Oct. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3085 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:3915: Test failed: Test 16: Got unexpected caps 0x22800, expected 0x10026000. ddraw2.c:3915: Test failed: Test 17: Got unexpected caps 0x20800, expected 0x10024000. === w864 (32 bit ddraw1) === ddraw1.c:3289: Test failed: Test 16: Got unexpected caps 0x22800, expected 0x10026000. ddraw1.c:3289: Test failed: Test 17: Got unexpected caps 0x20800, expected 0x10024000.

1 0

Wine Mono 4.5.0 Release
by Vincent Povirk Oct. 28, 2013

Oct. 28, 2013

I have published version 4.5.0 of Wine Mono on sourceforge. It's been a little over a year since the last release, and I'm sorry I waited so long to do it. I have also changed the versioning scheme. The major and minor version numbers will now indicate the highest supported .NET runtime version. The source tarball is at https://sourceforge.net/projects/wine/files/Wine%20Mono/4.5.0/wine-mono-4.5… The binary is at https://sourceforge.net/projects/wine/files/Wine%20Mono/4.5.0/wine-mono-4.5… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.8: * Fixed build on machines using bash as their sh implementation. * .NET Framework directories now include mscorlib.dll (fixes wine bug #31888). * Fixed build on machines running Mac OS X. (Josh DuBois) * Added a security.config file to the .NET 2.0 directory. (Alistair Leslie-Hughes) * Microsoft's Managed C++ compiler sometimes generates broken IL code ending in an unreachable ret statement. This code would be accepted by the .NET runtime but rejected by Mono. Mono is correctly following the spec in this case, but since our goal is compatibility we now accept code that does this. * Building with the -t switch will now build runtime tests. Previously, it only built class library tests. * Added registry keys to indicate the presence of .NET 4.5. * Added user-agent strings to the registry, which allow javascript embedded in web pages to detect .NET. * Updated Mono from 2.11.4 to 3.2.3 plus some additional commits. I'm no longer using Mono's release tags, because they don't seem to help me find revisions that are stable or even buildable. Anyway, here are some highlights of the changes brought in from Mono: * The new 'sgen' garbage collector has been greatly improved and is now the default instead of the old 'boehm' gc, which in our case means it's the only one shipped. It is an improvement over boehm in many ways and should be generally more efficient. * Mono now has support for Portable Class Libraries. * Beginnings of support for System.Windows.Forms.AxHost. (Alistair Leslie-Hughes) * Added support for P/Invoke methods with the thiscall calling convention, which are used by Managed C++ assemblies. * Improved IDispatch interface on managed objects. (Alistair Leslie-Hughes)

3 2

Re: [PATCH 1/5] ddraw/tests: Accept nvidia return values in test_rt_caps (try 2).
by Marvin Oct. 28, 2013

Oct. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3084 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00420E6B

1 0

Re: [Patch]try 2: Bug 33164 - row-resize / col-resize cursor is wrong (Listview)‏
by Vincent Povirk Oct. 28, 2013

Oct. 28, 2013

Your patch is being mangled somehow, even in the attachment. The blank line should contain a space. Also, please use your name transliterated to Latin characters when sending patches.

1 0

Re: shlwapi: Test and fix the behaviour of the CopyTo method for file sizes not multiple of the internal buffer size, on SHCreateStreamOnFileEx-returned IStreams.
by David Quintana (gigaherz) Oct. 28, 2013

Oct. 28, 2013

Hello people, I fixed Vincent's comment, and submitted the new version of the patch. It has been quite a few days already so I'd like to know if there is anything else left to do before the patch is looked at, or if there's just too much going on at the moment, in which case I can re-submit the patch in a few days/weeks, so that it can be looked at properly when there's more time. Vincent Povirk wrote: > We should probably still exit the loop if fewer bytes were read than > requested, rather than do another read at the end of the file.

2 1

Re: [3/8] crypt32: Remove unused variable and avoid a memory leak on error path.
by Alexandre Julliard Oct. 28, 2013

Oct. 28, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/crypt32/filestore.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/dlls/crypt32/filestore.c b/dlls/crypt32/filestore.c > index 44b9bbb..6084395 100644 > --- a/dlls/crypt32/filestore.c > +++ b/dlls/crypt32/filestore.c > @@ -117,9 +117,8 @@ static BOOL CRYPT_ReadBlobFromFile(HANDLE file, PCERT_BLOB blob) > blob->pbData = CryptMemAlloc(blob->cbData); > if (blob->pbData) > { > - DWORD read; > - > - ret = ReadFile(file, blob->pbData, blob->cbData, &read, NULL); > + ret = ReadFile(file, blob->pbData, blob->cbData, NULL, NULL); > + if (!ret) CryptMemFree(blob->pbData); In general if the read size is not checked that's a bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

[3/8] crypt32: Remove unused variable and avoid a memory leak on error path.
by Thomas Faber Oct. 28, 2013

Oct. 28, 2013

Hi, On 2013-10-28 09:28, Dmitry Timoshkov wrote: > - ret = ReadFile(file, blob->pbData, blob->cbData, &read, NULL); > + ret = ReadFile(file, blob->pbData, blob->cbData, NULL, NULL); the lpNumberOfBytesRead parameter is not optional on Windows for synchronous I/O, so could you keep it please? I've had to add it back in elsewhere to prevent Wine functions from crashing on Win. Thanks! Best, Thomas

1 0

Re: [01/02] d3d9: update locked_rect only if wined3d_surface_map succeeds
by Marvin Oct. 28, 2013

Oct. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2909 Your paranoid android. === w864 (32 bit device) === device: unhandled exception c0000005 at 740D14C8 === w864 (64 bit device) === device: unhandled exception c0000005 at 000007F84EDD90EB

3 3

Re: d3d9: update locked_rect only if wined3d_surface_map succeeds (try 2)
by Marvin Oct. 28, 2013

Oct. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3077 Your paranoid android. === w864 (32 bit device) === device: unhandled exception c0000005 at 74C714C8 === w864 (64 bit device) === device: unhandled exception c0000005 at 000007F9366B90EB

1 0

Re: msvcrt: add support for _chsize_s (try #3)
by Piotr Caban Oct. 28, 2013

Oct. 28, 2013

Hi, On 10/26/13 04:58, Mike Koss wrote: > This patch adds the _chsize_s() to the mscvrt and corresponding mscvr*s. > Incorporates previous feedback and now includes an updated test file. > > --- > dlls/msvcr100/msvcr100.spec | 2 +- > dlls/msvcr110/msvcr110.spec | 2 +- > dlls/msvcr80/msvcr80.spec | 2 +- > dlls/msvcr90/msvcr90.spec | 2 +- > dlls/msvcrt/file.c | 63 > +++++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/tests/file.c | 37 ++++++++++++++++++++++++++ > 7 files changed, 105 insertions(+), 5 deletions(-) There're few more issues with this patch: - _chsize_s is not defined in headers (please make sure that your code compiles without warnings) - _chsize_s is not available in some versions of msvcrt.dll, you should load it using GetProcAddress like in other *_s functions tests - the tests are failing on windows, it's probably also caused by lack of _chsize_s header Thanks, Piotr

1 0

Re: [PATCH] wined3d: Use GL_ARB_texture_mirror_clamp_to_edge when available.
by Henri Verbeet Oct. 28, 2013

Oct. 28, 2013

On 21 October 2013 21:20, Rico Schüller <kgbricola(a)web.de> wrote: > As wgl.h is a bit out of date, it still uses the > GL_MIRROR_CLAMP_TO_EDGE_ATI instead of GL_MIRROR_CLAMP_TO_EDGE (which is > only available in headers for OpenGL 4.4). > The wine/wgl.h header is generated from the GL .spec files by dlls/opengl32/make_opengl, so in principle all you'd have to do would be to run that script to get the new constant. Unfortunately Khronos seems to have decided to no longer update the .spec files, since there are shiny new XML files now.

2 2

Re: [PATCH 1/4] comctl32: Set updown control value to min or max in out of range case
by Piotr Caban Oct. 28, 2013

Oct. 28, 2013

On 10/28/13 09:35, Alistair Leslie-Hughes wrote: > On 17/10/2013 1:34 AM, Piotr Caban wrote: >> --- >> dlls/comctl32/updown.c | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> - } else return FALSE; >> + } if ((infoPtr->MaxVal > infoPtr->MinVal && >> infoPtr->CurVal+delta > infoPtr->MaxVal) > ^^^ >> + || (infoPtr->MaxVal < infoPtr->MinVal && >> infoPtr->CurVal+delta < infoPtr->MaxVal)) { >> + delta = infoPtr->MaxVal - infoPtr->CurVal; > > Should the "if" be one its own line or was the else missed? The 'else' was missed. I've sent a fix for it. Thanks, Piotr

1 0

Re: kernel32/tests: Update trace message to report actually used timeout value.
by Marvin Oct. 28, 2013

Oct. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3074 Your paranoid android. === w2008s64 (32 bit comm) === comm.c:859: Test failed: WaitCommEvent failed with a timeout comm.c:870: recovering after WAIT_TIMEOUT... comm.c:880: Test failed: WaitCommEvent error 0 comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1500) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting comm.c:1551: test_AbortWaitCts timeout 500 handle 000000C4 comm.c:1518: Changing CommMask on the fly for handle 000000C4 after timeout 500

1 0

Re: winspool.drv/tests: Fix the OpenPrinter() tests error reporting.
by Marvin Oct. 27, 2013

Oct. 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3070 Your paranoid android. === w864 (32 bit info) === info.c:2923: Test failed: AddJobA() failed le=50 info.c:2929: Test failed: GetJobA() failed le=87 info: unhandled exception c0000005 at 0040B24A === w864 (64 bit info) === info.c:2923: Test failed: AddJobA() failed le=50 info.c:2929: Test failed: GetJobA() failed le=87 info.c:2972: Test failed: AddJobA() failed le=50 info.c:2978: Test failed: GetJobA() failed le=87 info: unhandled exception c0000005 at 00000000004099E0

1 0

Re: Raise the minimum version of FreeBSD to 8.0.
by Frédéric Delanoy Oct. 26, 2013

Oct. 26, 2013

On Sun, Mar 3, 2013 at 12:22 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > We've had this as a requirement in the FreeBSD ports for quite a > while (and the Wiki describes some background). > > Gerald > --- > - FreeBSD 7.0 or later > + FreeBSD 8.0 or later > ... > FreeBSD info: > - Wine will generally not work properly on versions before FreeBSD 7.0. > + Wine will generally not work properly on versions before FreeBSD 8.0. You should also change the version in the various README.xx translations (in 'documentation' directory). Frédéric

3 2

Re: ddraw/tests: Fix compilation on systems that don't support nameless unions.
by Marvin Oct. 26, 2013

Oct. 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3061 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00420E52 === w864 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 at 0041212F

1 0

Re: shell32/tests: Fix compilation with -D__WINESRC__
by Marvin Oct. 26, 2013

Oct. 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3060 Your paranoid android. === w2008s64 (32 bit shlexec) === shlexec.c:1539: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt453.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test file.shlexec' shlexec.c:2607: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt453.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test2.exe' shlexec.c:2620: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt453.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test2.exe' shlexec.c:2632: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt453.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test2.exe' === w864 (32 bit shlexec) === shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\wt47C9.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\wt47C9.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2060: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\wt47C9.tmp" Exec") succeeded: rc=42 === w2008s64 (64 bit shlexec) === shlexec.c:1539: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt2FC.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test file.shlexec' shlexec.c:2607: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt2FC.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test2.exe' shlexec.c:2620: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt2FC.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test2.exe' shlexec.c:2632: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt2FC.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test2.exe' === w864 (64 bit shlexec) === shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\wt4598.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\wt4598.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2060: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\wt4598.tmp" Exec") succeeded: rc=42 === w864 (64 bit shlfolder) === shlfolder: unhandled exception c0000005 at 000007F93936ABDC

1 0

Re: msvcrt: add support for _chsize_s (try #3)
by Marvin Oct. 25, 2013

Oct. 25, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3053 Your paranoid android. === wvista (32 bit file) === Failure running script in VM: timed out waiting for the child process === w2008s64 (32 bit file) === Failure running script in VM: timed out waiting for the child process === w7pro64 (32 bit file) === file.c:1574: Test failed: Wrong file size Timeout === w864 (32 bit file) === Failure running script in VM: timed out waiting for the child process

1 0

Re: [PATCH 1/2] advapi32: HKCR merge: foundation
by Alexandre Julliard Oct. 25, 2013

Oct. 25, 2013

George Stephanos <gaf.stephanos(a)gmail.com> writes: > @@ -224,13 +248,138 @@ static NTSTATUS open_key( HKEY *retkey, ACCESS_MASK access, OBJECT_ATTRIBUTES *a > > } > > +static LSTATUS create_hkcr_struct( HKEY *hkey, opened_hkcr_t **hkcr ) > +{ > + UINT_PTR handle = nb_hkcr_handles, i; > + LSTATUS ret = ERROR_SUCCESS; > + > + EnterCriticalSection( &hkcr_handles_cs ); > + > + for (i = 0; i < nb_hkcr_handles; i++) > + { > + if (!hkcr_handles[i]) > + { > + handle = i; > + break; > + } > + } You need some sort of free list instead of a linear search. Also you can probably avoid one level of pointers and store objects directly. Returning a pointer to the object outside of the critical section is not a good idea. > +static HKEY resolve_hkcr( HKEY hkey ) > +{ > + HKEY ret; > + UINT_PTR idx = (UINT_PTR)hkey >> 2; > + opened_hkcr_t *hkcr; > + if (idx <= nb_hkcr_handles) > + { > + EnterCriticalSection( &hkcr_handles_cs ); The count needs to be protected by the critical section too. Also please write a better subject line for the commit. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 1/5] ddraw/tests: Accept nvidia return values in test_rt_caps.
by Henri Verbeet Oct. 25, 2013

Oct. 25, 2013

On 25 October 2013 00:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > --- > dlls/ddraw/tests/ddraw2.c | 26 ++++++++++++++++++++++++-- > dlls/ddraw/tests/ddraw7.c | 27 ++++++++++++++++++++++++--- > 2 files changed, 48 insertions(+), 5 deletions(-) > > diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c > index f4702f1..801135d 100644 > --- a/dlls/ddraw/tests/ddraw2.c > +++ b/dlls/ddraw/tests/ddraw2.c > @@ -3663,6 +3663,7 @@ static void test_rt_caps(void) > DWORD caps_out; > HRESULT create_device_hr; > HRESULT set_rt_hr; > + HRESULT alternative_set_rt_hr; > } > test_data[] = > { This kind of construction doesn't generally make me very happy, but on the other hand I'm not sure I can come up with something that's much better either. I do think we should mark the alternative results as broken. Some of the Evergreen results in later patches in this series are a bit surprising to me. I wrote the test on Windows 7 / AMD Cayman, which should be very close to Evergreen hardware.

2 2

Re: [PATCH 2/5] ddraw/tests: Allow some flags to fail surface creation in test_rt_caps.
by Marvin Oct. 25, 2013

Oct. 25, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3031 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:3915: Test failed: Test 16: Got unexpected caps 0x22800, expected 0x10026000. ddraw2.c:3915: Test failed: Test 17: Got unexpected caps 0x20800, expected 0x10024000. === w864 (32 bit ddraw1) === ddraw1.c:3289: Test failed: Test 16: Got unexpected caps 0x22800, expected 0x10026000. ddraw1.c:3289: Test failed: Test 17: Got unexpected caps 0x20800, expected 0x10024000.

2 1

Re: [3/4] kernel32/tests: WaitCommEvent may sometimes return immediately on a busy system when write operation to a COM-port
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3039 Your paranoid android. === w2008s64 (64 bit comm) === comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting === w7pro64 (64 bit comm) === comm.c:859: Test failed: WaitCommEvent failed with a timeout comm.c:870: recovering after WAIT_TIMEOUT... comm.c:880: Test failed: WaitCommEvent error 0 comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting comm.c:1552: test_AbortWaitCts timeout 500 handle 0000000000000068 comm.c:1519: Changing CommMask on the fly for handle 0000000000000068 after timeout 500

1 0

Re: [2/4] kernel32/tests: Increase the timeout for completion of write to a COM-port.
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3038 Your paranoid android. === w2008s64 (64 bit comm) === comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting === w7pro64 (64 bit comm) === comm.c:859: Test failed: WaitCommEvent failed with a timeout comm.c:870: recovering after WAIT_TIMEOUT... comm.c:880: Test failed: WaitCommEvent error 0 comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting comm.c:1552: test_AbortWaitCts timeout 500 handle 0000000000000068 comm.c:1519: Changing CommMask on the fly for handle 0000000000000068 after timeout 500

1 0

Re: [PATCH 5/5] d3d8/tests: Port z_range_test to d3d8.
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3034 Your paranoid android. === w864 (32 bit visual) === visual.c:1619: Test failed: Failed to create vertex shader, hr 0x8876086c. visual.c:1649: Test failed: Failed to delete vertex shader, hr 0x8876086c. visual.c:1657: Test failed: Z range failed: Got color 0x00ffffff, expected 0x00ff0000. visual.c:1664: Test failed: Z range failed: Got color 0x00ffffff, expected 0x000000ff. visual.c:1666: Test failed: Z range failed: Got color 0x00ffffff, expected 0x000000ff.

1 0

Re: [PATCH 3/5] ddraw/tests: Make caps checking in test_rt_caps() less strict.
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3032 Your paranoid android. === w864 (32 bit ddraw7) === The test timed out === w864 (32 bit ddraw4) === The test timed out

1 0

Re: [PATCH 1/5] ddraw/tests: Accept nvidia return values in test_rt_caps.
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3030 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00420E61 === w864 (32 bit ddraw7) === No test summary line found Failure running script in VM: network read timed out

1 0

Re: winspool.drv/tests: Fix tests compilation with __WINESRC__ defined (try 2)
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3019 Your paranoid android. === w864 (32 bit info) === info: unhandled exception c0000005 at 0040B246 === w864 (64 bit info) === info.c:2932: Test failed: got NULL DEVMODEA info: unhandled exception c0000005 at 00000000004099CD

1 0

Re: [PATCH 6/6] ole32: If an object exposes IExternalConnection then don't take down the stub manager if we have remaining w
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3010 Your paranoid android. === w864 (32 bit marshal) === marshal.c:3318: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3319: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3335: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3336: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3373: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3374: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3391: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3392: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3355: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3356: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3318: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3319: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3335: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3336: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3373: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3374: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3391: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3392: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3355: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3356: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3318: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3319: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3335: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3336: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3373: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3374: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3391: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3392: Test failed: info->dwServerPid was 0x874 instead of 0x904 marshal.c:3355: Test failed: info->cbSize was -737179689 instead of 48 marshal.c:3356: Test failed: info->dwServerPid was 0x874 instead of 0x904 === w864 (64 bit marshal) === marshal.c:3318: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3319: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3335: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3336: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3373: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3374: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3391: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3392: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3355: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3356: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3318: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3319: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3335: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3336: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3373: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3374: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3391: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3392: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3355: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3356: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3318: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3319: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3335: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3336: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3373: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3374: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3391: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3392: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48 marshal.c:3355: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3356: Test failed: info->dwServerPid was 0xaa4 instead of 0xa48

1 0

Re: [PATCH 5/6] ole32: Call IExternalConnection_ReleaseConnection with the correct final parameter.
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3009 Your paranoid android. === w864 (32 bit marshal) === marshal.c:3321: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3322: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3338: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3339: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3376: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3377: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3394: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3395: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3358: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3359: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3321: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3322: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3338: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3339: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3376: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3377: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3394: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3395: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3358: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3359: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3321: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3322: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3338: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3339: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3376: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3377: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3394: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3395: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 marshal.c:3358: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3359: Test failed: info->dwServerPid was 0xb60 instead of 0xa48 === w864 (64 bit marshal) === marshal.c:3321: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3322: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3338: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3339: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3376: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3377: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3394: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3395: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3358: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3359: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3321: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3322: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3338: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3339: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3376: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3377: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3394: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3395: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3358: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3359: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3321: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3322: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3338: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3339: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3376: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3377: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3394: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3395: Test failed: info->dwServerPid was 0x86c instead of 0xbb0 marshal.c:3358: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3359: Test failed: info->dwServerPid was 0x86c instead of 0xbb0

1 0

Re: [PATCH 4/6] ole32: When releasing marshal data of a normal ref ignore any remaining weak refs.
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3008 Your paranoid android. === w864 (32 bit marshal) === marshal.c:3326: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3327: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3343: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3344: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3381: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3382: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3399: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3400: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3363: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3364: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3326: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3327: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3343: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3344: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3381: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3382: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3399: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3400: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3363: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3364: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3326: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3327: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3343: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3344: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3381: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3382: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3399: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3400: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 marshal.c:3363: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3364: Test failed: info->dwServerPid was 0x5bc instead of 0xac8 === w864 (64 bit marshal) === marshal.c:3326: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3327: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3343: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3344: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3381: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3382: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3399: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3400: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3363: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3364: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3326: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3327: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3343: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3344: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3381: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3382: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3399: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3400: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3363: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3364: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3326: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3327: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3343: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3344: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3381: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3382: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3399: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3400: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74 marshal.c:3363: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3364: Test failed: info->dwServerPid was 0x8e4 instead of 0xb74

1 0

Re: [PATCH 3/6] ole32/tests: Add some tests for CoReleaseMarshalData with a combination of normal and weak marshals.
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3007 Your paranoid android. === w864 (32 bit marshal) === marshal.c:3326: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3327: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3343: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3344: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3381: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3382: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3399: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3400: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3363: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3364: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3326: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3327: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3343: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3344: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3381: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3382: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3399: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3400: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3363: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3364: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3326: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3327: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3343: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3344: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3381: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3382: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3399: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3400: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 marshal.c:3363: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3364: Test failed: info->dwServerPid was 0xaa4 instead of 0xb54 === w864 (64 bit marshal) === marshal.c:3326: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3327: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3343: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3344: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3381: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3382: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3399: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3400: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3363: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3364: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3326: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3327: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3343: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3344: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3381: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3382: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3399: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3400: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3363: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3364: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3326: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3327: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3343: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3344: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3381: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3382: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3399: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3400: Test failed: info->dwServerPid was 0x118 instead of 0xba4 marshal.c:3363: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3364: Test failed: info->dwServerPid was 0x118 instead of 0xba4

1 0

Re: [PATCH 2/6] ole32/tests: Make the two reference marshalling thread more generic.
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3006 Your paranoid android. === w864 (32 bit marshal) === marshal.c:3230: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3231: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3247: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3248: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3285: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3286: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3303: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3304: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3267: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3268: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3230: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3231: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3247: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3248: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3285: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3286: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3303: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3304: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3267: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3268: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3230: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3231: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3247: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3248: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3285: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3286: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3303: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3304: Test failed: info->dwServerPid was 0x370 instead of 0xa48 marshal.c:3267: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3268: Test failed: info->dwServerPid was 0x370 instead of 0xa48 === w864 (64 bit marshal) === marshal.c:3230: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3231: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3247: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3248: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3285: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3286: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3303: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3304: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3267: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3268: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3230: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3231: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3247: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3248: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3285: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3286: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3303: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3304: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3267: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3268: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3230: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3231: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3247: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3248: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3285: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3286: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3303: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3304: Test failed: info->dwServerPid was 0x738 instead of 0xbb8 marshal.c:3267: Test failed: info->cbSize was -1047396882 instead of 56 marshal.c:3268: Test failed: info->dwServerPid was 0x738 instead of 0xbb8

1 0

Re: [PATCH 1/6] ole32/tests: Extend the lifecycle tests to objects which expose IExternalConnection.
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3005 Your paranoid android. === w864 (32 bit marshal) === marshal.c:3226: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3227: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3243: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3244: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3281: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3282: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3299: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3300: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3263: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3264: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3226: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3227: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3243: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3244: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3281: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3282: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3299: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3300: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3263: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3264: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3226: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3227: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3243: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3244: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3281: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3282: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3299: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3300: Test failed: info->dwServerPid was 0x870 instead of 0xbac marshal.c:3263: Test failed: info->cbSize was -1846173327 instead of 48 marshal.c:3264: Test failed: info->dwServerPid was 0x870 instead of 0xbac === w864 (64 bit marshal) === marshal.c:3226: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3227: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3243: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3244: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3281: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3282: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3299: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3300: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3263: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3264: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3226: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3227: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3243: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3244: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3281: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3282: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3299: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3300: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3263: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3264: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3226: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3227: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3243: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3244: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3281: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3282: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3299: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3300: Test failed: info->dwServerPid was 0x18c instead of 0xa48 marshal.c:3263: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3264: Test failed: info->dwServerPid was 0x18c instead of 0xa48

1 0

Re: server: Add support for pending write flag to the serial device. Take 2.
by Alexandre Julliard Oct. 24, 2013

Oct. 24, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This patch makes WaitCommEvent(EV_TXEMPTY) work when a serial device > reports that the out queue is empty even after a successful write() > which is the case for real COM ports and as well as for serial-USB > adapters. > > Take 2 removes special handling of FlushFileBuffers for a serial sevice, > the tests show that it really should not reset the pending write state. > > I'd like to see some feedback for this patch. It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p kernel32_test.exe.so comm.c && touch comm.ok comm.c:860: Test failed: WaitCommEvent failed with a timeout comm.c:881: Test failed: WaitCommEvent error 997 comm.c:882: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:887: Test failed: WaitCommEvent used 1003 ms for waiting comm.c:2226: Tests skipped: interactive tests (set WINETEST_INTERACTIVE=1) make: *** [comm.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

3 10

Re: [5/7] oleaut32/tests: Fix typelib tests compilation with __WINESRC__ defined
by Dmitry Timoshkov Oct. 23, 2013

Oct. 23, 2013

André Hentschel <nerv(a)dawncrow.de> wrote: > - ok(lstrcmp(value, buf) == 0, #expr " expected \"%s\" got \"%s\"\n", value, buf); \ > + ok(lstrcmpA(value, buf) == 0, #expr " expected \"%s\" got \"%s\"\n", value, buf); \ Using simple strcmp() should be preferrable, leaving lstr* versions only for cases when an exception handler is really needed. P.S. Fixing compilation with __WINESRC__ defined gives an opportunity for reviewing the code, this should not be a simple search and replace job. -- Dmitry.

1 0

Re: winspool.drv/tests: Fix tests compilation with __WINESRC__ defined
by Dmitry Timoshkov Oct. 23, 2013

Oct. 23, 2013

André Hentschel <nerv(a)dawncrow.de> wrote: > @@ -3018,28 +3018,28 @@ START_TEST(info) > test_ConfigurePort(); > test_DeleteMonitor(); > test_DeletePort(); > - test_DeviceCapabilities(); > - test_DocumentProperties(); > + test_DeviceCapabilitiesA(); > + test_DocumentPropertiesA(); > test_EnumForms(NULL); > if (default_printer) test_EnumForms(default_printer); > test_EnumMonitors(); > - test_EnumPorts(); > + test_EnumPortsA(); > test_EnumPrinterDrivers(); > test_EnumPrinters(); > test_EnumPrintProcessors(); > test_GetDefaultPrinter(); > test_GetPrinterDriverDirectory(); > test_GetPrintProcessorDirectory(); > - test_OpenPrinter(); > - test_GetPrinter(); > + test_OpenPrinterA(); > + test_GetPrinterA(); > test_GetPrinterData(); > test_GetPrinterDataEx(); > - test_GetPrinterDriver(); > + test_GetPrinterDriverA(); > test_SetDefaultPrinter(); > test_XcvDataW_MonitorUI(); > test_XcvDataW_PortIsValid(); > test_IsValidDevmodeW(); > - test_OpenPrinter_defaults(); > + test_OpenPRINTER_DEFAULTSA(); Please leave the test names intact, that assumes that adding tests for W version of an API doesn't need a separate body. -- Dmitry.

1 0

Re: winspool.drv/tests: Fix tests compilation with __WINESRC__ defined
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2988 Your paranoid android. === w864 (32 bit info) === info.c:2925: Test failed: got 0 info.c:2931: Test failed: got 0 info: unhandled exception c0000005 at 0040B246 === w864 (64 bit info) === info.c:2934: Test failed: got NULL DEVMODEA info: unhandled exception c0000005 at 00000000004099CD

1 0

Re: winemac: Add registry settings to make Option keys send Alt rather than accessing additional characters from the keyboard layout.
by Phil Krylov Oct. 23, 2013

Oct. 23, 2013

Thanks! Do you consider adding an option to stop interpreting Command as Alt? On Thu, Oct 10, 2013 at 1:30 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/cocoa_window.m | 22 ++++++++++++++++++++-- > dlls/winemac.drv/macdrv_cocoa.h | 2 ++ > dlls/winemac.drv/macdrv_main.c | 7 +++++++ > 3 files changed, 29 insertions(+), 2 deletions(-) > > > > -- С уважением, Филипп Крылов.

2 5

Re: [PATCH 2/6] user32: Implement OpenInputDesktop.
by Alexandre Julliard Oct. 23, 2013

Oct. 23, 2013

Qian Hong <qhong(a)codeweavers.com> writes: > Hello, > > This patch superseded patch 99498. > Thanks Vincent Povirk for the previous comment, now I try to implement > OpenInputDesktop in user32 and server. I don't think that makes sense, under Wine every desktop is potentially an input desktop, there's no way to decide which one is the "real" one. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 2/2] user32: Implement OpenInputDesktop.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2978 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ole32: Support activation context in CLSIDFromProgID()
by Alexandre Julliard Oct. 23, 2013

Oct. 23, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Support activation context in CLSIDFromProgID() It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M msi.dll -p msi_test.exe.so msi.c && touch msi.ok msi.c:1974: Test failed: expected 0xdeadbeef, got 14007 msi.c:1981: Test failed: expected 0xdeadbeef, got 14007 msi.c:1988: Test failed: expected 0xdeadbeef, got 14007 msi.c:2003: Test failed: expected 0xdeadbeef, got 14007 msi.c:2506: Test failed: expected 0xdeadbeef, got 14007 msi.c:2515: Test failed: expected 0xdeadbeef, got 14007 make: *** [msi.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] ddraw/tests: Test DDSCAPS2_D3DTEXTUREMANAGE.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2973 Your paranoid android. === w864 (32 bit ddraw7) === No test summary line found Failure running script in VM: network read timed out === w864 (64 bit ddraw7) === ddraw7.c:3695: Test failed: Got unexpected, hr 0x80004002, case 4. ddraw7.c:3695: Test failed: Got unexpected, hr 0x80004002, case 5. ddraw7.c:3695: Test failed: Got unexpected, hr 0x80004002, case 6. ddraw7.c:3695: Test failed: Got unexpected, hr 0x80004002, case 7. === w864 (32 bit ddraw4) === The test timed out

1 0

Re: [PATCH 1/3] ddraw/tests: Add surface lockability tests.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2972 Your paranoid android. === w864 (32 bit ddraw2) === The test timed out === w864 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 at 0041212F === w864 (32 bit ddraw7) === Timeout Failure running script in VM: network read timed out === w864 (64 bit ddraw7) === ddraw7.c:3683: Test failed: Got unexpected, hr 0x80004002, case 2. ddraw7.c:3683: Test failed: Got unexpected, hr 0x80004002, case 3. ddraw7.c:3683: Test failed: Got unexpected, hr 0x80004002, case 4. === w864 (32 bit ddraw4) === Failure running script in VM: network read timed out

2 1

Re: [23/23] user32/tests: Enable user32 tests compilation with __WINESRC__ defined.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2971 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: [02/02] d3d8: update locked_rect only if wined3d_surface_map succeeds
by Henri Verbeet Oct. 23, 2013

Oct. 23, 2013

On 21 October 2013 10:47, Lasse Rasinen <lrasinen(a)iki.fi> wrote: > diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c > index 7932a7f..52cf27a 100644 > --- a/dlls/d3d8/tests/device.c > +++ b/dlls/d3d8/tests/device.c > @@ -4022,8 +4022,12 @@ static void test_lockrect_invalid(void) > > hr = IDirect3DSurface8_LockRect(surface, &locked_rect, NULL, 0); > ok(SUCCEEDED(hr), "Failed to lock surface with rect NULL, hr %#x.\n", hr); > + locked_rect.pBits = 0xdeadbeef; > + locked_rect.Pitch = 1; > hr = IDirect3DSurface8_LockRect(surface, &locked_rect, NULL, 0); > ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x.\n", hr); > + ok(locked_rect.pBits == 0xdeadbeef, "pBits changed on double lock.\n"); > + ok(locked_rect.Pitch == 1, "Pitch changed on double lock.\n"); > hr = IDirect3DSurface8_UnlockRect(surface); > ok(SUCCEEDED(hr), "Failed to unlock surface, hr %#x.\n", hr); > This test fails for me on Windows 7: device.c:4029: Test failed: pBits changed on double lock. device.c:4030: Test failed: Pitch changed on double lock. As an aside, if you had written the messages as "Got unexpected pBits %p.\n" and "Got unexpected Pitch %d.\n", you would have gotten the following output instead: device.c:4029: Test failed: Got unexpected pBits 00000000. device.c:4030: Test failed: Got unexpected Pitch 0.

3 6

Re: [20/23] user32/tests: Fix window tests compilation with __WINESRC__ defined.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2968 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000700E2 fg 00030040 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000701F6 fg 00010046 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000500F4 fg 0001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00090138 fg 00010066 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w864 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000601BA fg 00010084 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000500F4 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000090138 fg 0000000000010066 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000

1 0

Re: [18/23] user32/tests: Fix system parameters tests compilation with __WINESRC__ defined.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2966 Your paranoid android. === w864 (32 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 sysparams.c:2490: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2503: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (64 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 Timeout

1 0

Re: [10/23] user32/tests: Fix input tests compilation with __WINESRC__ defined.
by Saulius Krasuckas Oct. 23, 2013

Oct. 23, 2013

* On Wed, 23 Oct 2013, Dmitry Timoshkov wrote: > --- a/dlls/user32/tests/input.c > +++ b/dlls/user32/tests/input.c > @@ -929,7 +929,7 @@ static void test_Input_blackbox(void) > * key state set by SendInput(). */ > empty_message_queue(); > > - prevWndProc = SetWindowLongPtr(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > + prevWndProc = SetWindowLongPtrA(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > ok(prevWndProc != 0 || (prevWndProc == 0 && GetLastError() == 0), > "error: %d\n", (int) GetLastError()); > * On Fri, 8 Jun 2007, Saulius Krasuckas wrote: > --- a/dlls/user32/tests/input.c > +++ b/dlls/user32/tests/input.c > @@ -496,7 +496,7 @@ static void test_Input_blackbox(void) > * key state set by SendInput(). */ > empty_message_queue(); > > - prevWndProc = SetWindowLongPtr(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > + prevWndProc = SetWindowLongPtrA(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > ok(prevWndProc != 0 || (prevWndProc == 0 && GetLastError() == 0), > "error: %d\n", (int) GetLastError()); > It's nice to see the change is being offered by it's previous opponent six years later. Since Dmitry was strongly against it, questions go to him: * On Sat, 9 Jun 2007, Dmitry Timoshkov wrote: > "Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote: > > > Hello. I see some tests call [GS]etWindowLongPtr(..., GWLP_WNDPROC, > > ...). I think this is somewhat confusing. API offers both A- an W- > > versions of this function, while at my first glance I cannot firmly > > decide, what used name does refer to. > > > > Shouldn't occurences be renamed to ...WindowLongPtrA() here (or even > > all occurrences {by not requiring second parameter == GWLP_WNDPROC}) ? > > > > Same question stands for [GS]etWindowLong(). > > The code is correct as it is now, there is no need to change anything. Dmitry, what has changed since? (now that every test subdir is being migrated to compile with __WINESRC__) > > Did that restrict us from using single naming scheme? > > Personally I don't see any point in that. The tests are not forced to > use A/W API suffixes, that's done on purpose. Is the purpose gone now? S.

2 1

Re: [07/23] user32/tests: Fix DDE tests compilation with __WINESRC__ defined.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2955 Your paranoid android. === w864 (64 bit dde) === Timeout

1 0

Re: [02/23] user32/tests: Fix class tests compilation with __WINESRC__ defined.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2950 Your paranoid android. === w864 (32 bit class) === class.c:692: Test failed: Windows should be Unicode

1 0

Re: [01/23] user32/tests: Fix broadcast tests compilation with __WINESRC__ defined.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2949 Your paranoid android. === w864 (64 bit broadcast) === The test timed out

1 0

Re: comdlg32/tests: Use BOOL type where appropriate
by Marvin Oct. 22, 2013

Oct. 22, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2943 Your paranoid android. === w2008s64 (64 bit filedlg) === No test summary line found

1 0

Re: [PATCH 5/6] user32/tests: Test SetUserObjectInformation for invisible winstation.
by Marvin Oct. 22, 2013

Oct. 22, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2941 Your paranoid android. === w2008s64 (32 bit winstation) === winstation.c:927: Test failed: unexpected foreground window 0001004E

1 0

Mono Update
by Alistair Leslie-Hughes Oct. 22, 2013

Oct. 22, 2013

Hi, wine-mono hasn't been updated in nearly a year. Should it be time to consider a new release? Thoughts. Best Regards Alistair Leslie-Hughes

2 2

Re: comctl32/tests: Preparation for switching __WINESRC__ on
by Marvin Oct. 22, 2013

Oct. 22, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2934 Your paranoid android. === wvista (32 bit listview) === listview.c:5043: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5048: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w2008s64 (32 bit listview) === listview.c:5043: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5048: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w7pro64 (32 bit listview) === listview.c:5043: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5048: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w864 (32 bit listview) === listview.c:5043: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5048: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w2008s64 (64 bit listview) === listview.c:5043: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5048: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w7pro64 (64 bit listview) === listview.c:5043: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5048: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

1 0

Re: [PATCH 3/3] msvcrt: Don't output __ptr64 when UNDNAME_NO_MS_KEYWORDS is used
by Marvin Oct. 22, 2013

Oct. 22, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2929 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/3] msvcrt: Output ptr64 when UNDNAME_NO_LEADING_UNDERSCORES flag is used
by Marvin Oct. 22, 2013

Oct. 22, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2928 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] msvcrt: Add support for UNDNAME_NO_THISTYPE flag in __unDName
by Marvin Oct. 22, 2013

Oct. 22, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2927 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: oleaut32: Added a preliminary test, for scale overflow, in VarDecCmp. (try 2) (resend)
by Marvin Oct. 22, 2013

Oct. 22, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2926 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: oleaut32: Added a preliminary test, for scale overflow, in VarDecCmp. (resend)
by Dmitry Timoshkov Oct. 21, 2013

Oct. 21, 2013

Christopher Cope <ccope3(a)utk.edu> wrote: > --- a/dlls/oleaut32/vartype.c > +++ b/dlls/oleaut32/vartype.c > @@ -5836,7 +5836,9 @@ HRESULT WINAPI VarDecRound(const DECIMAL* pDecIn, int cDecimals, DECIMAL* pDecOu > HRESULT WINAPI VarDecCmp(const DECIMAL* pDecLeft, const DECIMAL* pDecRight) > { > HRESULT hRet; > - DECIMAL result; > + static DECIMAL scaleFactor; Is there a reason to make this variable static? -- Dmitry.

1 0

Re: shlwapi: Test and fix the behaviour of the CopyTo method for file sizes not multiple of the internal buffer size, on SHCreateStreamOnFileEx-returned IStreams.
by Vincent Povirk Oct. 21, 2013

Oct. 21, 2013

We should probably still exit the loop if fewer bytes were read than requested, rather than do another read at the end of the file.

1 0

Re: msvcrt: Make first call to fwrite bufferred
by Piotr Caban Oct. 21, 2013

Oct. 21, 2013

Please ignore this patch, it slows down fwrite on unbuffered FILE's. On 10/21/13 15:43, Piotr Caban wrote: > Without this patch fwrite allocates the buffer on first call and doesn't > use it. > --- > dlls/msvcrt/file.c | 125 > +++++++++++++++++++++++------------------------------ > 1 file changed, 54 insertions(+), 71 deletions(-) > > > > >

1 0

Re: [02/02] d3d8: update locked_rect only if wined3d_surface_map succeeds
by Marvin Oct. 21, 2013

Oct. 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2910 Your paranoid android. === w864 (32 bit device) === device.c:2481: Test failed: Expected foreground window 000401A4, got 00010084. device.c:3174: Test failed: Expected wndproc 0x4107a0, got 0x4107a0. device.c:4029: Test failed: pBits changed on double lock. device.c:4030: Test failed: Pitch changed on double lock.

1 0

Re: [23/23] kernel32/tests: Enable kernel32 tests compilation with __WINESRC__ defined.
by Marvin Oct. 21, 2013

Oct. 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2908 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: [01/02] d3d9: update locked_rect only if wined3d_surface_map succeeds
by Henri Verbeet Oct. 21, 2013

Oct. 21, 2013

On 21 October 2013 10:46, Lasse Rasinen <lrasinen(a)iki.fi> wrote: > diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c > index 02b4174..51835c8 100644 > --- a/dlls/d3d9/tests/device.c > +++ b/dlls/d3d9/tests/device.c > @@ -5402,8 +5402,12 @@ static void test_lockrect_invalid(void) > > hr = IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, 0); > ok(SUCCEEDED(hr), "Failed to lock surface with rect NULL, hr %#x.\n", hr); > + locked_rect.pBits = 0xdeadbeef; > + locked_rect.Pitch = 1; > hr = IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, 0); > ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x.\n", hr); > + ok(locked_rect.pBits == 0xdeadbeef, "pBits changed on double lock.\n"); > + ok(locked_rect.Pitch == 1, "Pitch changed on double lock.\n"); > hr = IDirect3DSurface9_UnlockRect(surface); > ok(SUCCEEDED(hr), "Failed to unlock surface, hr %#x.\n", hr); > This introduces warnings: device.c: In function ‘test_lockrect_invalid’: device.c:5405:23: warning: assignment makes pointer from integer without a cast [enabled by default] device.c:5409:26: warning: comparison between pointer and integer [enabled by default] Also applies to the d3d8 test.

1 0

Re: [03/23] kernel32/tests: Fix console tests compilation with __WINESRC__ defined.
by Marvin Oct. 21, 2013

Oct. 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2889 Your paranoid android. === w864 (32 bit console) === console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 18, got 00000138 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 20, got 0000013C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 21, got 0000014C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 22, got 00000148 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 23, got 00000144 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 24, got 00000150 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 25, got 00000154 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 26, got 00000158 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 28, got 0000015C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 29, got 00000160 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 30, got 00000164 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 31, got 00000168 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 32, got 0000016C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 33, got 00000170 console.c:1421: Test failed: [13] Expected output count to be 0, got 1987557047 console.c:1421: Test failed: [15] Expected output count to be 0, got 1987557047 console.c:1421: Test failed: [18] Expected output count to be 3735928559, got 1987557047 console.c:1664: Test failed: [13] Expected output count to be 0, got 1987557047 console.c:1664: Test failed: [15] Expected output count to be 0, got 1987557047 console.c:1664: Test failed: [18] Expected output count to be 3735928559, got 1987557047 === w864 (64 bit console) === console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 18, got 0000000000000054 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 20, got 0000000000000058 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 23, got 0000000000000060

1 0

Re: server: Implement job objects (try 3)
by Alexandre Julliard Oct. 21, 2013

Oct. 21, 2013

Andrew Cook <ariscop(a)gmail.com> writes: > It's been another 3 weeks with zero response. You keep sending more and more versions of the same patches, so it seems clear that this stuff is not ready yet. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [02/23] kernel32/tests: Fix file change notification tests compilation with __WINESRC__ defined.
by Marvin Oct. 21, 2013

Oct. 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2888 Your paranoid android. === wvista (32 bit change) === change.c:81: Test failed: Missed notification

1 0

Clang Static analysis
by C.W. Betts Oct. 21, 2013

Oct. 21, 2013

I have been doing a Clang static analysis of Wine on OS X using the one provided at http://clang-analyzer.llvm.org and storing the results on my PogoPlug drive. If someone wants to see the results, please tell me and I'll set up your e-mail. You will need a free PogoPlug account to view them. While the contents are zipped, they expand to about 1.2 GB. They are displayed as basic HTML pages, so you don't need anything special other than a web browser to see the results. Or you could click on this link for the analysis of 1.7.4: http://ppl.ug/ND-7PZ3cSzM/

2 1

Re: shell32: Avoid leaks and add parameter checks in SHCreateShellFolderView[Ex]. (try 2)
by Marvin Oct. 20, 2013

Oct. 20, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2885 Your paranoid android. === w864 (64 bit shlfolder) === shlfolder: unhandled exception c0000005 at 000007F851EBABDC

2 1

Re: shell32: Avoid leaks and add parameter checks in SHCreateShellFolderView[Ex].
by Marvin Oct. 20, 2013

Oct. 20, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2880 Your paranoid android. === w864 (64 bit shlfolder) === shlfolder: unhandled exception c0000005 at 000007F851EBABDC

1 0

Re: shell32: Avoid leaks and add parameter checks in SHCreateShellFolderView[Ex].
by Nikolay Sivov Oct. 20, 2013

Oct. 20, 2013

On 10/20/2013 21:01, Thomas Faber wrote: > + if (0) > + { > + // crash on win7 > + pSHCreateShellFolderViewEx(NULL, NULL); > + pSHCreateShellFolderViewEx(NULL, &psv); > + pSHCreateShellFolderViewEx(&csfv, NULL); > + } Please no cpp comments. > + MAKEFUNC_ORD(SHCreateShellFolderViewEx, 174); > + MAKEFUNC_ORD(SHCreateShellFolderView, 256); These call are exported by name at least on XP, probably 2000 too, so it makes no sense to use ordinals here. > + if (!pSHCreateShellFolderView || !pSHCreateShellFolderViewEx) > + { > + win_skip("SHCreateShellFolderView or SHCreateShellFolderViewEx missing.\n"); > + return; > + } I don't think it's really possible to have *Ex version without non-Ex one. > + hr = SHGetDesktopFolder(&desktop); > + ok(hr == S_OK, "got (0x%08x)\n", hr); > + if (FAILED(hr)) > + { > + skip("No desktop folder\n"); > + return; > + } It's not going to fail, so a ok() test is enough. > + memset(&sfvc, 0, sizeof(sfvc)); > + sfvc.cbSize = sizeof(sfvc); > + sfvc.pshf = desktop; > + psv = (void *)0xdeadbeef; > + hr = pSHCreateShellFolderView(&sfvc, &psv); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + ok(psv != NULL, "psv = %p\n", psv); > + if (psv && psv != (void *)0xdeadbeef) > + { > + refCount = IShellView_Release(psv); > + ok(refCount == 0, "refCount = %u\n", refCount); > + } It's simpler than that. Set 'psv' to NULL and test for it being set after a call. > + test_SHCreateShellFolderView(); You're testing two calls here, so they probably deserve two separate test functions.

1 0

Re: shell32/tests: Use BOOL type where appropriate
by Marvin Oct. 19, 2013

Oct. 19, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2879 Your paranoid android. === wxppro (32 bit shlexec) === shlexec.c:1197: Test failed: expected 1 args, got 4 shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec.', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\%nasty% $file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\%NASTY~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:/DOCUME~1/winetest/LOCALS~1/Temp/wt1.tmp/test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.noassoc.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~2.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\masked file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\MASKED~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\masked file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\MASKED~1.SHL' shlexec.c:1631: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1939: Test failed: argvA4 expected 'C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1947: Test failed: argvA4 expected 'C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:2250: Test failed: argvA3 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.sde', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SDE' shlexec.c:2250: Test failed: argvA3 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.sde', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SDE' shlexec.c:2240: Test failed: argcA expected 5, but got 4 === wvista (32 bit shlexec) === shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC34E.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC34E.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1530: Test failed: argvA3 expected 'Open', but key not found or empty shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtC34E.tmp\test file.noassoc', but key not found or empty === w2008s64 (32 bit shlexec) === shlexec.c:1538: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt9F4A.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test file.shlexec' shlexec.c:2606: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt9F4A.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test2.exe' shlexec.c:2619: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt9F4A.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test2.exe' shlexec.c:2631: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt9F4A.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test2.exe' === w864 (32 bit shlexec) === shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\wt4E20.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\wt4E20.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2059: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\wt4E20.tmp" Exec") succeeded: rc=42 === w2008s64 (64 bit shlexec) === shlexec.c:1538: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wtDF85.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test file.shlexec' shlexec.c:2606: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wtDF85.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test2.exe' shlexec.c:2619: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wtDF85.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test2.exe' shlexec.c:2631: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wtDF85.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test2.exe' === w864 (64 bit shlexec) === shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\wt9DA6.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\wt9DA6.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2059: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\wt9DA6.tmp" Exec") succeeded: rc=42 === w864 (64 bit shlfolder) === shlfolder: unhandled exception c0000005 at 000007F851EBABDC

1 0

Re: server: Implement job objects (try 2)
by Andrew Cook Oct. 18, 2013

Oct. 18, 2013

On 17/10/13 15:11, Andrew Cook wrote: > --- > dlls/kernel32/tests/process.c | 172 ++++++++++++++++++++++- > dlls/ntdll/sync.c | 127 +++++++++++++++-- > server/process.c | 313 > ++++++++++++++++++++++++++++++++++++++++++ > server/process.h | 3 + > server/protocol.def | 33 +++++ > 5 files changed, 636 insertions(+), 12 deletions(-) > > Is there something wrong with this patch?

1 0

Re: [1/2] gdiplus: Reimplement GdipCloneBitmapArea without using GdipBitmapLockBits.
by Vincent Povirk Oct. 18, 2013

Oct. 18, 2013

This series looks good to me.

1 0

Re: [PATCH 2/2] ole32: Pass last_unlock_releases to IExternalConnection_ReleaseConnection().
by Alexandre Julliard Oct. 18, 2013

Oct. 18, 2013

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/ole32/stubmanager.c | 2 +- > dlls/ole32/tests/marshal.c | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M oleaut32.dll -p oleaut32_test.exe.so tmarshal.c && touch tmarshal.ok tmarshal.c:191: Test failed: fLastReleaseCloses = 0, expected 1 tmarshal.c:191: Test failed: fLastReleaseCloses = 0, expected 1 make: *** [tmarshal.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] ole32/tests: Add tests to show that CoLockObjectExternal() calls ReleaseConnection() with the appropriate va
by Marvin Oct. 18, 2013

Oct. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2863 Your paranoid android. === wxppro (32 bit marshal) === marshal.c:2805: Test failed: wait timed out marshal.c:2809: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 00419C8C === w864 (32 bit marshal) === marshal.c:3066: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3067: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3083: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3084: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3121: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3122: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3139: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3140: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3103: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3104: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3066: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3067: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3083: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3084: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3121: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3122: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3139: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3140: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3103: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3104: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3066: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3067: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3083: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3084: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3121: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3122: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3139: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3140: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3103: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3104: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 === w864 (64 bit marshal) === marshal.c:3066: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3067: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3083: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3084: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3121: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3122: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3139: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3140: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3103: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3104: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3066: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3067: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3083: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3084: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3121: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3122: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3139: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3140: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3103: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3104: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3066: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3067: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3083: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3084: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3121: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3122: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3139: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3140: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3103: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3104: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac

2 1

Re: [PATCH 2/2] ole32: Pass last_unlock_releases to IExternalConnection_ReleaseConnection().
by Marvin Oct. 18, 2013

Oct. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2864 Your paranoid android. === wxppro (32 bit marshal) === marshal.c:2803: Test failed: wait timed out marshal.c:2807: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 00419C4C === w864 (32 bit marshal) === marshal.c:3064: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3065: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3081: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3082: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3119: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3120: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3137: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3138: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3101: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3102: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3064: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3065: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3081: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3082: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3119: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3120: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3137: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3138: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3101: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3102: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3064: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3065: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3081: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3082: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3119: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3120: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3137: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3138: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3101: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3102: Test failed: info->dwServerPid was 0x674 instead of 0xba8 === w864 (64 bit marshal) === marshal.c:3064: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3065: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3081: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3082: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3119: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3120: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3137: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3138: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3101: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3102: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3064: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3065: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3081: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3082: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3119: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3120: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3137: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3138: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3101: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3102: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3064: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3065: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3081: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3082: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3119: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3120: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3137: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3138: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3101: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3102: Test failed: info->dwServerPid was 0x900 instead of 0xad0

1 0

Re: wined3d: Initialize map_desc in wined3d_surface_map
by Marvin Oct. 18, 2013

Oct. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2785 Your paranoid android. === w864 (32 bit device) === device.c:5409: Test failed: pBits not cleared on double lock. device.c:5410: Test failed: Pitch not cleared on double lock. device: unhandled exception c0000005 at 742814C8 === w864 (64 bit device) === device.c:5409: Test failed: pBits not cleared on double lock. device.c:5410: Test failed: Pitch not cleared on double lock. device: unhandled exception c0000005 at 000007F84EDD90EB

3 3

Re: [PATCH 7/9] secur32: Cache certificate context instead of store in schannel handle.
by Marvin Oct. 18, 2013

Oct. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2860 Your paranoid android. === w864 (32 bit schannel) === schannel.c:803: Test failed: cert != cert2

1 0

Re: wintrust/tests: Compile with -D__WINESRC__
by Marvin Oct. 17, 2013

Oct. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2850 Your paranoid android. === w864 (32 bit crypt) === crypt.c:289: Test failed: Expected success, got FALSE with 87 crypt.c:293: Test failed: Expected success, got FALSE with 87

1 0

re: visual studio 2012 pdb support
by Dan Kegel Oct. 17, 2013

Oct. 17, 2013

Hi Roman, it might help if you were to show tiny example programs that wine's pdb support doesn't handle, like I did at http://kegel.com/wine/valgrind/pdbdemo/ Ideally you'd file a new bug report at bugs.winehq.org for this. - Dan

1 0

Re: winemac: Restore the window title when the window style is changed.
by Ken Thomases Oct. 17, 2013

Oct. 17, 2013

On Oct 17, 2013, at 3:54 AM, Kevin Eaves wrote: > <cocoa_window.patch> Looks good to me. Thanks. Note that this fixes <http://bugs.winehq.org/show_bug.cgi?id=34472>. -Ken

1 0

Re: [2/3] gdi32: Adjust fake bold outline font metrics.
by Marvin Oct. 17, 2013

Oct. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2842 Your paranoid android. === wvista (32 bit font) === The test timed out

1 0

Re: [1/3] gdi32/tests: Add tests for fake bold outline fonts.
by Marvin Oct. 17, 2013

Oct. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2841 Your paranoid android. === wvista (32 bit font) === No test summary line found Failure running script in VM: network read timed out === w2008s64 (32 bit font) === Failure running script in VM: network read timed out

1 0

Re: [2/2] msxml3: Set referrer header to container url
by Marvin Oct. 17, 2013

Oct. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2837 Your paranoid android. === wxppro (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === wvista (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w2008s64 (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w7pro64 (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w864 (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {af0ff408-129d-4b20-91f0-02bd23d88352}, riid {af0ff408-129d-4b20-91f0-02bd23d88352} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9c1-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9c1-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9d5-bafa-11ce-8c82-00aa004ba90b}, riid {79eac9d5-bafa-11ce-8c82-00aa004ba90b} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w2008s64 (64 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w7pro64 (64 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w864 (64 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {af0ff408-129d-4b20-91f0-02bd23d88352}, riid {af0ff408-129d-4b20-91f0-02bd23d88352} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9c1-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9c1-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9d5-bafa-11ce-8c82-00aa004ba90b}, riid {79eac9d5-bafa-11ce-8c82-00aa004ba90b} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/"

1 0

Re: [4/6] kernel32/tests: Fix communication port tests compilation with __WINESRC__ defined.
by Marvin Oct. 16, 2013

Oct. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2833 Your paranoid android. === w2008s64 (32 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:883: Test failed: WaitCommEvent error 0 comm.c:885: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:889: WaitCommEvent for EV_TXEMPTY took 1014 ms (timeout 1000) comm.c:891: Test failed: WaitCommEvent used 1014 ms for waiting comm.c:1558: test_AbortWaitCts timeout 500 handle 000000C4 comm.c:1525: Changing CommMask on the fly for handle 000000C4 after timeout 500

1 0

Re: [2/2] gdi32/tests: Enable gdi32 tests compilation with __WINESRC__ defined. Resend.
by Marvin Oct. 16, 2013

Oct. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2828 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: msctf/tests: Compile with -D__WINESRC__
by Marvin Oct. 16, 2013

Oct. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2822 Your paranoid android. === w864 (64 bit inputprocessor) === inputprocessor.c:791: Test failed: Deactivation came unexpectedly

1 0

Re: [PATCH] user32/tests: Skip desktop tests on NT4.
by Alexandre Julliard Oct. 16, 2013

Oct. 16, 2013

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so winstation.c && touch winstation.ok winstation.c:546: Test succeeded inside todo block: unexpected last error deadbeef winstation.c:549: Test failed: Skip tests on NT4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 02/11] crypt32: Don't use links to certs in memory store.
by Alexandre Julliard Oct. 16, 2013

Oct. 16, 2013

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/crypt32/cert.c | 159 > ++++++++++++++++++++++++----------------- > dlls/crypt32/collectionstore.c | 12 ++-- > dlls/crypt32/context.c | 4 +- > dlls/crypt32/crl.c | 7 +- > dlls/crypt32/crypt32_private.h | 22 +++--- > dlls/crypt32/ctl.c | 9 ++- > dlls/crypt32/provstore.c | 18 ++--- > dlls/crypt32/store.c | 17 +++-- > 8 files changed, 140 insertions(+), 108 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M cryptui.dll -p cryptui_test.exe.so cryptui.c && touch cryptui.ok wine: Unhandled page fault on read access to 0xfffffff0 at address 0x6865c543 (thread 005d), starting debugger... Unhandled exception: page fault on read access to 0xfffffff0 in 32-bit code (0x6865c543). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:6865c543 ESP:0032fab0 EBP:0032fac8 EFLAGS:00010297( R- -- I S -A-P-C) EAX:ffffffe8 EBX:686bb2fc ECX:00000000 EDX:0013ed38 ESI:0013ed70 EDI:00000001 Stack dump: 0x0032fab0: 00000005 0013eea0 0032fb68 686bb2fc 0x0032fac0: 686bb2fc 00000001 0032fb68 6864f122 0x0032fad0: 0013d6a8 00000000 00000000 0032fb2c 0x0032fae0: 00000000 00000000 0032fb38 6869a1af 0x0032faf0: 00000000 00020000 00000000 6865b7e0 0x0032fb00: 0032fb3c 0013ed50 0032fb38 6869a618 Backtrace: =>0 0x6865c543 Context_CopyProperties+0x43(to=0x13d6a8, from=0x0(nil)) [/home/julliard/wine/wine/dlls/crypt32/context.c:99] in crypt32 (0x0032fac8) 1 0x6864f122 add_cert_to_store+0x3e1(store=<couldn't compute location>, cert=<couldn't compute location>, add_disposition=<couldn't compute location>, use_link=<couldn't compute location>, ret_context=<couldn't compute location>) [/home/julliard/wine/wine/dlls/crypt32/cert.c:270] in crypt32 (0x0032fb68) 2 0x6864f37d CertAddCertificateContextToStore+0x9c(hCertStore=<couldn't compute location>, pCertContext=<couldn't compute location>, dwAddDisposition=<couldn't compute location>, ppStoreContext=<couldn't compute location>) [/home/julliard/wine/wine/dlls/crypt32/cert.c:288] in crypt32 (0x0032fbc8) 3 0x5557563b import_cert+0x14a() in cryptui (0x0032fc38) 4 0x555793ad CryptUIWizImport+0x10c() in cryptui (0x0032fc78) 5 0x6862a5e7 func_cryptui+0x4f6() [/home/julliard/wine/wine/dlls/cryptui/tests/cryptui.c:397] in cryptui_test (0x0032fcf8) 6 0x6862b675 run_test+0x144(name=<is not available>) [/home/julliard/wine/wine/dlls/cryptui/tests/../../../include/wine/test.h:570] in cryptui_test (0x0032fd48) 7 0x68629c23 main+0x152(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/cryptui/tests/../../../include/wine/test.h:640] in cryptui_test (0x0032fe08) 8 0x6862c0c0 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in cryptui_test (0x0032fe58) 9 0x7b85f38c call_process_entry+0xb() in kernel32 (0x0032fe78) 10 0x7b86056b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1085] in kernel32 (0x0032feb8) 11 0x7bc7fea0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 12 0x7bc82dad call_thread_func+0x7c(entry=0x7b860500, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2602] in ntdll (0x0032ffa8) 13 0x7bc7fe7e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 14 0x7bc54a2e start_process+0x1d(kernel_start=0x7b860500) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2697] in ntdll (0x0032ffe8) 15 0x6803128d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 16 0x6803134b wine_switch_to_stack+0x2a(func=0x7bc54a10, arg=0x7b860500, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xffb103b8) 17 0x7bc5a587 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2753] in ntdll (0xffb10428) 18 0x7b866ae0 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1257] in kernel32 (0xffb11338) 19 0x7bc5ac53 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2962] in ntdll (0xffb113c8) 20 0x6802eeda wine_init+0x2b9(argc=0x3, argv=0xffb11904, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:952] in libwine.so.1 (0xffb11428) 21 0x7bf00d3b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xffb11868) 22 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x6865c543 Context_CopyProperties+0x43 [/home/julliard/wine/wine/dlls/crypt32/context.c:99] in crypt32: movl 0xfffffff0(%ecx),%edx 99 while (ptr && ptr->linked) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/6] atl: Avoid duplicate debugging trace for same exported function names from different dlls.
by Alexandre Julliard Oct. 16, 2013

Oct. 16, 2013

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/atl/atl.spec | 6 +++--- > dlls/atl/atl_main.c | 9 +++++---- > 2 files changed, 8 insertions(+), 7 deletions(-) I'd suggest to simply print the version in the trace, instead of renaming all the functions. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH try3] atl110: Added new DLL.
by Qian Hong Oct. 16, 2013

Oct. 16, 2013

> +WINE_DEFAULT_DEBUG_CHANNEL(atl); Hi Jacek, we already have a debug channel atl100 for atl100.dll, but we currently use atl for both atl.dll and atl80.dll, do you think it is better to use atl for all, or one debug channel per each dll?

2 5

visual studio 2012 pdb support
by Роман Остриков Oct. 16, 2013

Oct. 16, 2013

Hello, dear developes Some times ago I have started porting some system to wine and was disappointed that application hangs. So I have began use dbghelp. I have faced with problem in supporting dpb files in wine which was generated by Visual Studio 2012. I have found an article: http://bugs.winehq.org/show_bug.cgi?id=835 where Dan Kegel public a series of fixes. But support was for VS2008 and post was dated by 2009-11-01. So may be this fix already included in Wine1.6 and debug symbols cant recognized by dbghelp due of another problem? Can anybody explain this? Best Reagrds

1 0

Video Mixing Renderer 7
by Michael Müller Oct. 16, 2013

Oct. 16, 2013

Hi, I am wondering what would be the best way to handle programs which rely on the Video Mixing Renderer 7 (quartz.dll) as it's supposed to be available on XP and later, but Wine contains only an implementation of version 9. The program I am speaking of is Silverlight which uses the VMR 7 Interface to create a filter graph and then queries for the IAMCertifiedOutputProtection interface. I am currently using a hack fix to get around this by returning a VMR9 instance when a VMR7 is requested and implementing the missing subinterfaces (which are only part of VMR7). This solution is clearly not perfect and I am searching for a better way to get around this issue. The most similar way to Windows would be to completely rewrite the current implementation of the VMR9 as VMR7 using DirectDraw, which would take a lot of time and most probably end up in having a lot of duplicate code. I am wondering whether using d3d9 for VMR7 would also be an acceptable solution. We could move all the d3d9 related stuff to a separate file so that VMR7.c and VMR9.c only offer the version specific interfaces and use the same code internally. This shouldn't be a big problem since the differences between the VMR7 and VMR9 interfaces are often only very small. Though it would not completely fit the behavior of windows. I am open for other ideas on how to solve the problem, but as Silverlight does not even use the VMR7 object for playing the video but only to check for the graphic driver certificate I don't think it would justify to rewrite everything using Direct Draw if there are no other programs needing this interface. Best Regards, Michael Müller

5 4

Re: notepad: Use BOOL type where appropriate (try 2)
by Alexandre Julliard Oct. 16, 2013

Oct. 16, 2013

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > try 2: Avoid changing SendMessage calls Dialog procedures return booleans too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: notepad: Use BOOL type where appropriate
by Alexandre Julliard Oct. 16, 2013

Oct. 16, 2013

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -298,7 +298,7 @@ static SAVE_STATUS DoSaveFile(LPCWSTR szFileName, ENCODING enc) > CloseHandle(hFile); > HeapFree(GetProcessHeap(), 0, pBytes); > > - SendMessageW(Globals.hEdit, EM_SETMODIFY, FALSE, 0); > + SendMessageW(Globals.hEdit, EM_SETMODIFY, 0, 0); Many messages use booleans, even if the actual type is a WPARAM. Please don't change them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dispex/tests: Compile with -D__WINESRC__
by Dmitry Timoshkov Oct. 16, 2013

Oct. 16, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + PeekMessageA(&msg, NULL, WM_USER, WM_USER, PM_NOREMOVE); IMHO it would be much better to use W version of APIs while doing this cleanup. Same applies to all other your patches that prepare switching compilation to using -D__WINESRC__. -- Dmitry.

2 1

Re: [10/10] gdi32/tests: Enable gdi32 tests compilation with __WINESRC__ defined.
by Marvin Oct. 16, 2013

Oct. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2808 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: [06/10] gdi32/tests: Fix font tests compilation with __WINESRC__ defined.
by Marvin Oct. 16, 2013

Oct. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2804 Your paranoid android. === wxppro (32 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 === wvista (32 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 No test summary line found Failure running script in VM: network read timed out === w2008s64 (32 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 Timeout Failure running script in VM: network read timed out === w7pro64 (32 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 === w864 (32 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 === w2008s64 (64 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 === w7pro64 (64 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080 === w864 (64 bit font) === font.c:1545: Test failed: GetGlyphIndicesW should have returned a 20ac not 0080

1 0

Re: mmdevapi/tests: Compile with -D__WINESRC__.
by Marvin Oct. 15, 2013

Oct. 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2797 Your paranoid android. === w7pro64 (32 bit render) === render.c:662: Test failed: Wait(event) after Stop gave 102

1 0

Re: winmm/tests: Use the explicit mciSendStringA() form.
by Marvin Oct. 15, 2013

Oct. 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2796 Your paranoid android. === w864 (32 bit midi) === midi.c:518: Test failed: midiOutPrepare old size rc=MMSYSERR_INVALPARAM midi.c:519: Test failed: MHDR.dwFlags when prepared 0 midi.c:523: Test failed: midiStreamOut old size rc=MIDIERR_UNPREPARED midi.c:547: Test failed: MHDR.dwFlags 0 no ISSTRM when out of queue midi.c:553: Test failed: MHDR.dwFlags 0 not DONE when out of queue midi.c:554: Test failed: Wait failed: 0102 -559038737 midi.c:554: Test failed: Expect message 3ca from midiStream callback midi.c:555: Test failed: Wait failed: 0102 -559038737 midi.c:555: Test failed: Expect message 3c9 from midiStreamOut midi.c:558: Test failed: play left MIDIHDR.dwOffset at 1234567890 midi.c:561: Test failed: midiOutUnprepare rc=MMSYSERR_INVALPARAM midi.c:563: Test failed: midiOutUnprepare #2 rc=MMSYSERR_INVALPARAM midi.c:566: Test failed: MHDR.dwFlags when done 0 midi.c:580: Test failed: stream set tempo 500000 midi.c:588: Test failed: midiOutPrepare used flags 8 rc=MMSYSERR_INVALPARAM midi.c:590: Test failed: midiOutUnprepare used flags 8 rc=MMSYSERR_INVALPARAM midi.c:518: Test failed: midiOutPrepare old size rc=MMSYSERR_INVALPARAM midi.c:519: Test failed: MHDR.dwFlags when prepared 0 midi.c:523: Test failed: midiStreamOut old size rc=MIDIERR_UNPREPARED midi.c:547: Test failed: MHDR.dwFlags 0 no ISSTRM when out of queue midi.c:553: Test failed: MHDR.dwFlags 0 not DONE when out of queue midi.c:554: Test failed: Wait failed: 0102 -559038737 midi.c:554: Test failed: Expect message 3ca from midiStream callback midi.c:555: Test failed: Wait failed: 0102 -559038737 midi.c:555: Test failed: Expect message 3c9 from midiStreamOut midi.c:558: Test failed: play left MIDIHDR.dwOffset at 1234567890 midi.c:561: Test failed: midiOutUnprepare rc=MMSYSERR_INVALPARAM midi.c:563: Test failed: midiOutUnprepare #2 rc=MMSYSERR_INVALPARAM midi.c:566: Test failed: MHDR.dwFlags when done 0 midi.c:580: Test failed: stream set tempo 500000 midi.c:588: Test failed: midiOutPrepare used flags 8 rc=MMSYSERR_INVALPARAM midi.c:590: Test failed: midiOutUnprepare used flags 8 rc=MMSYSERR_INVALPARAM === wxppro (32 bit mci) === mci.c:1209: Test failed: mci status "C:\Documents and Settings\winetest\My Documents\tempfile.wav" mode returned MCIERR_INVALID_DEVICE_NAME mci.c:1274: Test failed: mci re-auto-open status mode returned MCIERR_INVALID_DEVICE_NAME mci.c:1290: Test failed: mci auto-open pause returned MCIERR_INVALID_DEVICE_NAME === wvista (32 bit mci) === mci.c:986: Test failed: 397ms is not in the expected 400-600ms range mci.c:993: Test failed: 397ms is not even in the expected 400-1000ms range === w7pro64 (64 bit mci) === mci.c:1120: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close)

1 0

Re: cmd/tests: Compile with -D__WINESRC__
by Marvin Oct. 15, 2013

Oct. 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2794 Your paranoid android. === wxppro (32 bit batch) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 686 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 687 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 688 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 690 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 691 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 692 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 694 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 696 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 697 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 700 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 701 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 705 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 713 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 714 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 720 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 726 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 728 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 729 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 735 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 739 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 742 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 752 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 753 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 754 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 764 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 771 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 772 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 773 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 777 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1361 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1362 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1363 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1364 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1365 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1366 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1367 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1368 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1370 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1373 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1374 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1375 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1376 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1377 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar')

1 0

Re: ole32/tests: Compile with -D__WINESRC__
by Marvin Oct. 15, 2013

Oct. 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2791 Your paranoid android. === wxppro (32 bit marshal) === marshal.c:2746: Test failed: wait timed out marshal.c:2750: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 00419A9C === w864 (32 bit marshal) === marshal.c:3007: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3008: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3024: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3025: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3062: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3063: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3080: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3081: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3044: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3045: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3007: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3008: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3024: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3025: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3062: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3063: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3080: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3081: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3044: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3045: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3007: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3008: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3024: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3025: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3062: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3063: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3080: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3081: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 marshal.c:3044: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3045: Test failed: info->dwServerPid was 0x5bc instead of 0xbb8 === w864 (64 bit marshal) === marshal.c:3007: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3008: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3024: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3025: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3062: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3063: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3080: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3081: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3044: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3045: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3007: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3008: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3024: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3025: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3062: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3063: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3080: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3081: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3044: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3045: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3007: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3008: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3024: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3025: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3062: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3063: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3080: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3081: Test failed: info->dwServerPid was 0x8ac instead of 0xb44 marshal.c:3044: Test failed: info->cbSize was -432292180 instead of 56 marshal.c:3045: Test failed: info->dwServerPid was 0x8ac instead of 0xb44

1 0

Request for a possible inclusion of the Wineasio driver?
by Joakim Hernberg Oct. 15, 2013

Oct. 15, 2013

I am the maintainer of a driver for Wine on Linux called Wineasio. I'd like to find a home for the code and am hoping to convince you of adding it to the Wine codebase. ASIO is an API developed by Steinberg for supporting low latency audio hardware under Windows. Each hardware manufacturer uses Steinberg's SDK to create a driver supporting their own hardware. Software using the API is normally audio related such as Digital Audio Workstations, virtual instruments and other music production software. On Linux, Wineasio interfaces directly with the Jack audio API, and runs on all hardware supported by Jack, which nowdays is the vast majority on audio hardware supported in linux. On OS/X a derrived driver called Coreasio has been created, and is in use by Image-line's FLS port. Jack runs on Linux, Solaris, FreeBSD, OS/X, iOS and Windows, so in theory it ought to be possible to support Wineasio on all platforms supported by Wine. I don't know the details on how Coreasio works, but in the case of Wineasio, the driver links directly to the Jack server's client libs, so there is no need to alter any existing parts of Wine's audiostack nor to reimplement and maintain a Jack driver for Wine itself. The only change needed is to include the driver in the source tree. The driver implements all the core functionality of the API, only some optional and obscure parts of the API are missing. It has been in use for years on 32 bit Wine and does not appear to have any showstopping bugs, if any at all. I've personally used it for over a year on 64 bit Wine, and I know of some other people who use it without problems on 64 bit too. The API is stable and hasn't been changed nor expanded by Steinberg for many years. It has been tested with audio production software like Reaper and FLS, with virtual instruments, amp simulations and other FX software from companies like Native Instruments, Ik Multimedia, Toontracks, Celemony and many others. The biggest problem is that the ASIO API is defined in the asio.h header file distributed by Steinberg in their ASIO SDK, and that the license explicitly forbids the distribution of any component by a third party. I imagine that this situation is not new to the Wine project and similar to other SDKs needed. I have a header file which I have created by compiling the driver without including asio.h, and then typing in the needed defines and structures while consulting asio.h. The header makes the driver work in both 32 and 64 bit wine. I propose to undertake the following: 1. Fix up the Wineasio code to confirm to Wine conventions and coding practices. 2. Merge it into Wine for conditional compilation on linux with Jack as a dependency. 3. Work together with the Wine project to merge in coreasio support for use on OS X. The latest sourcecode of the project is available at: git://git.code.sf.net/p/wineasio/code wineasio-git or as a tarball from: http://sourceforge.net/projects/wineasio/ Is this something that has any chance of getting accepted into Wine? -- Joakim

2 1

We're in at FOSDEM!
by Jeremy White Oct. 15, 2013

Oct. 15, 2013

Hey folks, I thought I'd let everyone know that I applied for and we have been granted a room at FOSDEM again this year. I'm going to send a 'Call for Papers' separately. Cheers, Jeremy

1 0

Video Mixing Renderer 7
by Michael Müller Oct. 15, 2013

Oct. 15, 2013

Hi, I am wondering what would be the best way to handle programs which rely on the Video Mixing Renderer 7 (quartz.dll) as it's supposed to be available on XP and later, but Wine contains only an implementation of version 9. The program I am speaking of is Silverlight which uses the VMR 7 Interface to create a filter graph and then queries for the IAMCertifiedOutputProtection interface. I am currently using a hack fix to get around this by returning a VMR9 instance when a VMR7 is requested and implementing the missing subinterfaces (which are only part of VMR7). This solution is clearly not perfect and I am searching for a better way to get around this issue. The most similar way to Windows would be to completely rewrite the current implementation of the VMR9 as VMR7 using DirectDraw, which would take a lot of time and most probably end up in having a lot of duplicate code. I am wondering whether using d3d9 for VMR7 would also be an acceptable solution. We could move all the d3d9 related stuff to a separate file so that VMR7.c and VMR9.c only offer the version specific interfaces and use the same code internally. This shouldn't be a big problem since the differences between the VMR7 and VMR9 interfaces are often only very small. Though it would not completely fit the behavior of windows. I am open for other ideas on how to solve the problem, but as Silverlight does not even use the VMR7 object for playing the video but only to check for the graphic driver certificate I don't think it would justify to rewrite everything using Direct Draw if there are no other programs needing this interface. Best Regards, Michael Müller

1 0

Re: wined3d: Initialize map_desc in wined3d_surface_map
by Marvin Oct. 15, 2013

Oct. 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2784 Your paranoid android. === w864 (32 bit device) === device.c:2481: Test failed: Expected foreground window 000401A6, got 00010084. device.c:3174: Test failed: Expected wndproc 0x4107a0, got 0x4107a0. device: unhandled exception c0000005 at 742F14C8

1 0

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded (try 3)
by Nikolay Sivov Oct. 15, 2013

Oct. 15, 2013

On 10/15/2013 18:57, Lasse Rasinen wrote: > According to debugging output, Artemis Spaceship Bridge Simulator 2.0 > calls LockRect twice on the same texture (for whatever reason) and crashes. > > http://bugs.winehq.org/show_bug.cgi?id=34271 > > The return values are cleared explicitly --- game is playable. > > Now with appropriate assignments and test output. > --- > dlls/d3d9/surface.c | 9 +++++++-- > dlls/d3d9/tests/device.c | 4 ++++ > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/dlls/d3d9/surface.c b/dlls/d3d9/surface.c > index 99f0b0f..20ccc68 100644 > --- a/dlls/d3d9/surface.c > +++ b/dlls/d3d9/surface.c > @@ -293,8 +293,13 @@ static HRESULT WINAPI d3d9_surface_LockRect(IDirect3DSurface9 *iface, > hr = wined3d_surface_map(surface->wined3d_surface, &map_desc, rect, flags); > wined3d_mutex_unlock(); > > - locked_rect->Pitch = map_desc.row_pitch; > - locked_rect->pBits = map_desc.data; > + if (SUCCEEDED(hr)) { > + locked_rect->Pitch = map_desc.row_pitch; > + locked_rect->pBits = map_desc.data; > + } else { > + locked_rect->Pitch = 0; > + locked_rect->pBits = NULL; > + } > > return hr; > } > diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c > index 02b4174..90d5c38 100644 > --- a/dlls/d3d9/tests/device.c > +++ b/dlls/d3d9/tests/device.c > @@ -5404,6 +5404,10 @@ static void test_lockrect_invalid(void) > ok(SUCCEEDED(hr), "Failed to lock surface with rect NULL, hr %#x.\n", hr); > hr = IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, 0); > ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x.\n", hr); > + locked_rect.pBits = (BYTE *)0xdeadbeef; > + hr = IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, 0); > + ok(!SUCCEEDED(hr) && locked_rect.pBits == NULL, "Failed to clear pBits (%p)\n", > + locked_rect.pBits); > hr = IDirect3DSurface9_UnlockRect(surface); > ok(SUCCEEDED(hr), "Failed to unlock surface, hr %#x.\n", hr); > It looks like you could use existing LockRect() call that's already tested as failing. Also I think FAILED() is a preferred way to test HRESULT value for failure, but as existing code does - you could also test for exact failure code.

2 1

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded (try 3)
by Marvin Oct. 15, 2013

Oct. 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2783 Your paranoid android. === w864 (32 bit device) === device.c:5409: Test failed: Failed to clear pBits (DEADBEEF) device: unhandled exception c0000005 at 742814C8 === w864 (64 bit device) === device.c:5409: Test failed: Failed to clear pBits (00000000DEADBEEF) device: unhandled exception c0000005 at 000007F84EDD90EB

2 1

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded (try 3)
by Stefan Dösinger Oct. 15, 2013

Oct. 15, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-10-15 16:57, schrieb Lasse Rasinen: > - locked_rect->Pitch = map_desc.row_pitch; - > locked_rect->pBits = map_desc.data; + if (SUCCEEDED(hr)) { + > locked_rect->Pitch = map_desc.row_pitch; + > locked_rect->pBits = map_desc.data; + } else { + > locked_rect->Pitch = 0; + locked_rect->pBits = NULL; + } You can handle this in wined3d/surface.c, wined3d_surface_map. Also, please follow the code style of the existing code. Curly brackets go in their own line. > + locked_rect.pBits = (BYTE *)0xdeadbeef; + hr = > IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, 0); + > ok(!SUCCEEDED(hr) && locked_rect.pBits == NULL, "Failed to clear > pBits (%p)\n", + locked_rect.pBits); For the sake of completeness, please also test locked_rect.Pitch and port the test to d3d8. Ddraw already has a test in dsurface.c. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSXVwzAAoJEN0/YqbEcdMw1CQP/2Lk2v78Ws8BGh1x4MvaXj/x YhJQ1d44bqP9B8+H7E3NKWuwZ6ywNmxvH+Mq59nbNKdfBrxvTezIA2PDLEsNwWJa hl/Q4St61K1XkExmu+48tyxtT3BS8P2g60Z50V8VIfrUh/3qqquXq79tki9XqYSr vtuFLuJyHECzYq7hQ+BZqbudwSSf42ZQfX0wNpa4wuZ2uX/PzA4ku0R/zvHzaMTh HoOrlIxX9hvCF/y5y7v0SAeYT83nMCkUBOZ8EMoDqv81btLDCqdFedtlFz2gTO0P O2vaGzSH0NPU+umIU9rEXUwq3H2gJdFcTG4FujQNsoVSaliXz24OzVTCEc1PvuWz eo+zMhxfG05xNSsb6Yh+fATnOPP6YDWYukS42kmalZ+V5WGlwxxKd4jgfONjCqzH JsIcqbmlxkWN9bPB9k3mIMMDHZ1PClI3GFm1XVMnc4Vas2/FF/IAAK/yPpIV2O/R fJkz4PKcha8P9V/yNlGJrmHYq/Dy7mW9xANmQ4gKv9wm0iqHoUGrDorX7OptskHL ua0pOFmWIXHRtzFysctZ/w6QkKX/e9Vwh/hRWIBhN2JOliu5AZuqQESbqe/rCwZR Flje6p9RaxlqgIzxxK1GQawpQ05NP3y8oS1MIe+mGr4c6sk8KO5d6aUgNVo4jcdY 4OAnKqN3lNbqDZgNEg91 =32E8 -----END PGP SIGNATURE-----

1 0

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded (try 2)
by Marvin Oct. 15, 2013

Oct. 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2776 Your paranoid android. === w864 (32 bit device) === device.c:5409: Test failed: Failed to clear pBits (DEADBEEF)device.c:5588: Tests skipped: Failed to create surface for format D3DFMT_R8G8B8 (hr 0x8876086c), skipping tests. device: unhandled exception c0000005 at 740D14C8 === w864 (64 bit device) === device.c:5409: Test failed: Failed to clear pBits (00000000DEADBEEF)device.c:5588: Tests skipped: Failed to create surface for format D3DFMT_R8G8B8 (hr 0x8876086c), skipping tests. device: unhandled exception c0000005 at 000007F84EDD90EB

1 0

Re: [00/11] msi/tests: Prepare action.c for the switch to -D__WINESRC__.
by Marvin Oct. 15, 2013

Oct. 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2775 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [10/11] msi/tests: Prepare msi.c for the switch to -D__WINESRC__.
by Marvin Oct. 15, 2013

Oct. 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2769 Your paranoid android. === wvista (32 bit msi) === The test timed out === w2008s64 (32 bit msi) === The test timed out === w7pro64 (32 bit msi) === Timeout === w2008s64 (64 bit msi) === Timeout === w7pro64 (64 bit msi) === Timeout

1 0

Re: [11/11] msi/tests: Compile with -D__WINESRC__.
by Marvin Oct. 15, 2013

Oct. 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2770 Your paranoid android. === build (build) === Make failed

1 0

Re: [04/11] msi/tests: Prepare install.c for the switch to -D__WINESRC__.
by Marvin Oct. 15, 2013

Oct. 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2763 Your paranoid android. === wxppro (32 bit install) === No test summary line found Failure running script in VM: network read timed out === wvista (32 bit install) === Timeout === w2008s64 (32 bit install) === Failure running script in VM: network read timed out === w7pro64 (32 bit install) === Timeout Failure running script in VM: timed out waiting for the child process === w864 (32 bit install) === install.c:2439: Test failed: Directory not created === w2008s64 (64 bit install) === Timeout

1 0

Re: dlls/explorerframe: build tests with -D__WINESRC__
by Marvin Oct. 14, 2013

Oct. 14, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2750 Your paranoid android. === wvista (32 bit nstc) === nstc.c:1934: Test failed: Got event 7, count 0 nstc.c:1936: Test failed: Got event 4, count 0 nstc.c:1949: Test failed: Got event 4, count 0

1 0

Re: wsock32: Add a fallback for inet_network.
by Alexandre Julliard Oct. 14, 2013

Oct. 14, 2013

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/wsock32/protocol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This doesn't build on MingW: protocol.o: In function `WSOCK32_inet_network(a)4': /home/julliard/wine/build/obj-pe32/dlls/wsock32/../../../wine/dlls/wsock32/protocol.c:55: undefined reference to `_inet_addr' /home/julliard/wine/build/obj-pe32/dlls/wsock32/../../../wine/dlls/wsock32/protocol.c:55: undefined reference to `_ntohl' collect2: ld returned 1 exit status winegcc: i686-w64-mingw32-gcc failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Help / Mentoring
by Hugh McMaster Oct. 14, 2013

Oct. 14, 2013

Hi everyone, I just wanted to know if anyone would mind helping/mentoring me with a few small patches. I am working primarily on wineconsole's screen buffer problems (to which I believe I have the solution), but am also looking at implementing some stub Win32 console functions found in dlls/kernel32. Obviously, my aim is to have these patches committed, as the changes will benefit the entire Wine community. I had initially thought of Eric Poeuch, a significant wineconsole developer, however he appears to be extremely busy. So I'm not sure who else to contact. If time is a consideration, please note that I won't be constantly contacting you to review patches or answer questions. Thank you, Hugh

2 3

Re: [PATCH] d3drm: added some freeing of memory in error paths (Coverity)
by Henri Verbeet Oct. 14, 2013

Oct. 14, 2013

On 13 October 2013 11:13, Marcus Meissner <marcus(a)jet.franken.de> wrote: > 1104553 Resource leak > Fixing the memory leak is fine of course, but I think it would be better to handle the array initialization in d3drm_visual_array_create() etc. instead, so that those functions actually return an object that's properly initialized.

1 0

Re: [2/4] dnsapi/tests: Compile with -D__WINESRC__.
by Marvin Oct. 14, 2013

Oct. 14, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2733 Your paranoid android. === wxppro (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === wvista (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w2008s64 (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w7pro64 (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w864 (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w2008s64 (64 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w7pro64 (64 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w864 (64 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly

1 0

Re: ntdll: Support pinning module refcount with LdrAddRefDll()
by Dmitry Timoshkov Oct. 13, 2013

Oct. 13, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + FreeLibrary(mod); Please add the tests for FreeLibrary return value. -- Dmitry.

2 1

MSYS touch.exe timestamp resolution issue on Wine-1.6
by Alan W. Irwin Oct. 13, 2013

Oct. 13, 2013

Under MSYS bash.exe if I use the touch command I only get 1-second resolution when reading the results. bash.exe-3.1$ touch touch1.test touch2.test bash.exe-3.1$ ls --full-time touch*.test -rw-r--r-- 1 wine 544 0 2013-10-12 13:57:58.000000000 -0700 touch1.test -rw-r--r-- 1 wine 544 0 2013-10-12 13:57:58.000000000 -0700 touch2.test Would somebody be willing to make the above test for MSYS on the Microsoft version of Windows (which I don't have access to) to see if time stamps are being read with 1-second resolution as above. That test should help distinguish whether this is a Wine issue or else an MSYS issue. I have also done some tests with the MSYS find.exe and make.exe commands, and in all cases touch2.test is not newer than touch1.text. This can be an important issue for the make command where one-second time resolution can potentially screw up file dependencies. If I use the equivalent Linux ls (and find and make) commands to read the time stamps on the above files, then touch2.test is newer than touch1.text, e.g., wine(a)raven> ls --full-time touch*.test -rw-r--r-- 1 wine wine 0 2013-10-12 13:57:58.391000000 -0700 touch1.test -rw-r--r-- 1 wine wine 0 2013-10-12 13:57:58.408000000 -0700 touch2.test So I think this implies the MSYS touch.exe command is writing high-resolution (i.e., millisecond) time stamps, and it is only reading that high-resolution time stamp that seems to be an issue for MSYS on Wine. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

3 2

d3d11 patch
by Max . Oct. 13, 2013

Oct. 13, 2013

Hi, I would like to know when the first patchs for d3d11 will be introduce into wine ? Beginning of 2014 ? middle 2014 ? End 2014 ? Thanks,

2 2

Re: mscoree: Add support for ICLRMetaHostPolicy interface
by Dmitry Timoshkov Oct. 12, 2013

Oct. 12, 2013

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > +static HRESULT WINAPI metahostpolicy_QueryInterface(ICLRMetaHostPolicy *iface, REFIID riid, void **ppvObject) > +{ > + TRACE("%s %p\n", debugstr_guid(riid), ppvObject); > + > + if ( IsEqualGUID( riid, &IID_ICLRMetaHostPolicy ) || > + IsEqualGUID( riid, &IID_IUnknown ) ) > + { > + *ppvObject = iface; > + } > + else > + { > + FIXME("Unsupported interface %s\n", debugstr_guid(riid)); > + return E_NOINTERFACE; > + } > + > + ICLRMetaHostPolicy_AddRef( iface ); > + > + return S_OK; > +} I think that a common COM convention is to set the object pointer to NULL in case of an unsupported interface. Also you're doing pretty good job in avoiding hungarian notation except for ppvObject. Another nitpick is the choice for if/else construct (although I understand that other places also use this sub-optimal one). A more elegant way of implementing QueryInterface would be IMHO: static HRESULT WINAPI xxx_QueryInterface(IFace *iface, REFIID riid, void **object) { if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IAnotherSupported) { xxx_AddRef(iface); *object = iface; return S_OK; } *object = NULL; return E_NOINTERFACE; } -- Dmitry.

1 0

Re: winmm/tests: Use BOOL type where appropriate
by Marvin Oct. 11, 2013

Oct. 11, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2721 Your paranoid android. === wxppro (32 bit wave) === wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13211 bytes, should be 13230 wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13229 bytes, should be 13230 wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13075 bytes, should be 13230 wave.c:509: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13091 samples (13091 bytes), should be 13230 (13230 bytes) wave.c:522: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 594 ms, (13108 bytes), should be 600 (13230 bytes) wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13220 bytes, should be 13230 wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 17621 bytes, should be 17640 wave.c:509: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 17634 samples (17634 bytes), should be 17640 (17640 bytes) wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 22016 bytes, should be 22050 wave.c:509: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 22027 samples (22027 bytes), should be 22050 (22050 bytes) wave.c:522: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 999 ms, (22044 bytes), should be 1000 (22050 bytes)

1 0

Re: wined3d: Use BOOL type where appropriate
by Henri Verbeet Oct. 11, 2013

Oct. 11, 2013

On 11 October 2013 22:51, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > - DWORD onesided_enable = FALSE; > - DWORD twosided_enable = FALSE; > + DWORD onesided_enable = 0; > + DWORD twosided_enable = 0; Actually, all of those initializations are redundant.

1 0

Fwd: Re: kernel32/tests: Add tests for job objects (try 7)
by Andrew Cook Oct. 11, 2013

Oct. 11, 2013

(no idea why my client sent this to wine-patches) On 10/10/13 15:23, Andrew Cook wrote: > --- > dlls/kernel32/tests/process.c | 159 > +++++++++++++++++++++++++++++++++++++++++- > include/winbase.h | 1 + > include/winnt.h | 90 ++++++++++++++++++++++++ > 3 files changed, 249 insertions(+), 1 deletion(-) > > there appears to be a window between the all processes leaving a job and the job actually being considered empty, and no apparent way to wait for this. I can't reproduce this locally either. Is there an accepted way to wait for some inaccessible kernel-side event? reordering some calls would likely hide the issue but i'd rather avoid that. https://newtestbot.winehq.org/JobDetails.pl?Key=2687 failure on w8 https://newtestbot.winehq.org/JobDetails.pl?Key=2709 failure on w864 https://newtestbot.winehq.org/JobDetails.pl?Key=2685 same patch, success on w864

1 0

Re: xmllite: Use BOOL type where appropriate
by Nikolay Sivov Oct. 10, 2013

Oct. 10, 2013

On 10/10/2013 00:36, Frédéric Delanoy wrote: > --- > dlls/xmllite/reader.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c > index 0a4423c..a216951 100644 > --- a/dlls/xmllite/reader.c > +++ b/dlls/xmllite/reader.c > @@ -726,7 +726,7 @@ static void readerinput_grow(xmlreaderinput *readerinput, int length) > } > } > > -static inline int readerinput_is_utf8(xmlreaderinput *readerinput) > +static inline BOOL readerinput_is_utf8(xmlreaderinput *readerinput) > { > static char startA[] = {'<','?'}; > static char commentA[] = {'<','!'}; > @@ -953,7 +953,7 @@ static void reader_skipn(xmlreader *reader, int n) > } > } > > -static inline int is_wchar_space(WCHAR ch) > +static inline BOOL is_wchar_space(WCHAR ch) > { > return ch == ' ' || ch == '\t' || ch == '\r' || ch == '\n'; > } > @@ -1055,7 +1055,7 @@ static HRESULT reader_parse_versioninfo(xmlreader *reader) > } > > /* ([A-Za-z0-9._] | '-') */ > -static inline int is_wchar_encname(WCHAR ch) > +static inline BOOL is_wchar_encname(WCHAR ch) > { > return ((ch >= 'A' && ch <= 'Z') || > (ch >= 'a' && ch <= 'z') || > @@ -1269,7 +1269,7 @@ static HRESULT reader_parse_comment(xmlreader *reader) > } > > /* [2] Char ::= #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x10000-#x10FFFF] */ > -static inline int is_char(WCHAR ch) > +static inline BOOL is_char(WCHAR ch) > { > return (ch == '\t') || (ch == '\r') || (ch == '\n') || > (ch >= 0x20 && ch <= 0xd7ff) || > @@ -1279,7 +1279,7 @@ static inline int is_char(WCHAR ch) > } > > /* [13] PubidChar ::= #x20 | #xD | #xA | [a-zA-Z0-9] | [-'()+,./:=?;!*#@$_%] */ > -static inline int is_pubchar(WCHAR ch) > +static inline BOOL is_pubchar(WCHAR ch) > { > return (ch == ' ') || > (ch >= 'a' && ch <= 'z') || > @@ -1292,7 +1292,7 @@ static inline int is_pubchar(WCHAR ch) > (ch == '_') || (ch == '\r') || (ch == '\n'); > } > > -static inline int is_namestartchar(WCHAR ch) > +static inline BOOL is_namestartchar(WCHAR ch) > { > return (ch == ':') || (ch >= 'A' && ch <= 'Z') || > (ch == '_') || (ch >= 'a' && ch <= 'z') || > @@ -1312,7 +1312,7 @@ static inline int is_namestartchar(WCHAR ch) > } > > /* [4 NS] NCName ::= Name - (Char* ':' Char*) */ > -static inline int is_ncnamechar(WCHAR ch) > +static inline BOOL is_ncnamechar(WCHAR ch) > { > return (ch >= 'A' && ch <= 'Z') || > (ch == '_') || (ch >= 'a' && ch <= 'z') || > @@ -1336,7 +1336,7 @@ static inline int is_ncnamechar(WCHAR ch) > (ch >= 0xfdf0 && ch <= 0xfffd); > } > > -static inline int is_namechar(WCHAR ch) > +static inline BOOL is_namechar(WCHAR ch) > { > return (ch == ':') || is_ncnamechar(ch); > } I don't actually see what this will achieve, but I see such patches are accepted. Is it a new style rule?

3 2

Re: mshtml: Compile tests with __WINESRC__ define.
by Marvin Oct. 10, 2013

Oct. 10, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2689 Your paranoid android. === w864 (64 bit activex) === activex.c:1346: Test failed: unexpected call SetObjectRects === wxppro (32 bit htmldoc) === htmldoc.c:2898: Test failed: mon(0026BFD0) != exmon(00269670) htmldoc.c:7601: Test failed: mon(0026BFD0) != exmon(00269670) htmldoc.c:5978: Test failed: mon(0026BFD0) != exmon(00269670) htmldoc.c:2898: Test failed: mon(0029CA28) != exmon(00286FF8) htmldoc.c:7601: Test failed: mon(0029CA28) != exmon(00286FF8) htmldoc.c:5978: Test failed: mon(0029CA28) != exmon(00286FF8) === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found

1 0

Re: ieframe: Compile tests with __WINESRC__ define.
by Marvin Oct. 10, 2013

Oct. 10, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2688 Your paranoid android. === wxppro (32 bit webbrowser) === webbrowser.c:792: Test failed: ReadyState = 1, expected 4

1 0

Re: wmvcore: Stub implementation of IWMMetadataEditor interface
by Nikolay Sivov Oct. 10, 2013

Oct. 10, 2013

On 10/10/2013 14:58, Jeff Latimer wrote: > --- > dlls/wmvcore/Makefile.in | 2 +- > dlls/wmvcore/wmvcore_main.c | 100 > +++++++++++++++++++++++++++++++++++++++++++- > include/wmsdkidl.idl | 11 ++--- > 3 files changed, 105 insertions(+), 8 deletions(-) > +typedef struct MetadataEditorImpl { > + IWMMetadataEditor MetadataEditor_iface; > + LONG ref; > +} MetadataEditorImpl; > +static inline MetadataEditorImpl *impl_from_MetadataEditor(IWMMetadataEditor *iface) Please follow naming convetions for interfaces. > +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} > +HRESULT WINAPI WMCreateEditor_flush(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} This looks totally wrong. Also please keep implementation functions order and interface methods order the same.

1 0

Re: [PATCH 5/5] user32: Implement better stub of OpenInputDesktop.
by Qian Hong Oct. 10, 2013

Oct. 10, 2013

Hello, this patch is in pending status, is there any way I can improve it? IMO there is no way to 'correctly' implement OpenInputDesktop before implementing SwitchDesktop, as far as SwitchDesktop is a stub, it is safe to assume that OpenInputDesktop will always return either NULL or Winsta0/Default, that is what the patch does and what the tests in [PATCH 3/5] shows.. It is not trivial to implement SwitchDesktop, also I don't know any real world app needing SwitchDesktop except some virtual desktop manager, so I'm not sure it is worth to spend time on implementing SwitchDesktop. However, OpenInputDesktop is needed by multiple apps (TeamViewer, QQ International, Inspect tool from Windows Platform SDK as bug 12067), is it acceptable to submit such a 'better stub' to Wine and leaving SwitchDesktop as a stub? Any comment is great appreciated! On Tue, Oct 8, 2013 at 11:41 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > Fixed http://bugs.winehq.org/show_bug.cgi?id=12067 , let QQ users happy :) > > --- > dlls/user32/tests/winstation.c | 22 ---------------------- > dlls/user32/winstation.c | 22 +++++++++++++++++++--- > 2 files changed, 19 insertions(+), 25 deletions(-) > > -- Regards, Qian Hong - http://www.codeweavers.com

2 2

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().
by Alexandre Julliard Oct. 10, 2013

Oct. 10, 2013

Ralf Habacker <ralf.habacker(a)freenet.de> writes: > With other patches i have been told to implement such stuff in the dib > driver. Unfortunally this do not works in this case, because in the top > level function it looks like having driver specific stuff using display > coordinates. It would still most likely have to be in the driver, though maybe the driver would not be calling that exact entry point. In any case, you can't change the DC transform like this. and you'll need test cases. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: kernel32/tests: Add tests for job objects (try 7)
by Marvin Oct. 9, 2013

Oct. 9, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2683 Your paranoid android. === w864 (64 bit process) === process.c:2092: Test failed: Unexpected completion event: 6, 0000000000000158, 00000000000002F0

1 0

Re: ddraw/tests: Use BOOL type where appropriate
by Marvin Oct. 9, 2013

Oct. 9, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2682 Your paranoid android. === wxppro (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wvista (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w2008s64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7pro64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag

1 0

Re: [PATCH] d3dx9: Move object initialization into a separate function.
by Matteo Bruni Oct. 9, 2013

Oct. 9, 2013

Hi Rico, 2013/10/8 Rico Schüller <kgbricola(a)web.de>: > Hi, > > this moves the object initialization into a separate function, so it could > be used for strings and resources. It also removes the STATE_TYPE as we > could distinguish the types at the object level. > > 1. When an object has a destination, it points to another shader variable. > This was state ST_PARAMETER. > > 2. If a variable has something in data, it is fxlc, shader (preshader) or a > string. This was state ST_CONSTANT and ST_FXLC. > > 3. If it has both (destination and data), it points to an array of shader > variables. The name is in the destination, the index could be calculated > with the data. This will be added in a later patch. > There's still the issue of distinguishing between ST_CONSTANT and ST_FXLC, checking object_id and type might cover that though. > Also saving the destination parameter in the object gains some speed when we > need to access the variable as we don't need to run get_parameter_by_name() > each time we need the variable ... > I'm not sure storing additional info into the objects is the right thing to do. Take a look at the D3DXFX_NOT_CLONEABLE flag from http://msdn.microsoft.com/en-us/library/windows/desktop/bb172855%28v=vs.85%…. Notice that GetPassDesc() doesn't return the shader data if the object was created with the flag. What I've been thinking is that it simply can't because the original shader data, stored in an object, were freed after parsing. While nothing forces us to do the same (except probably avoiding to use more memory than strictly necessary) I think it's better not to put additional stuff into the objects or generally assume that the objects are still available after parsing. That means creating the shaders and the strings at parse time or right after that and storing any additional required information (e.g. preshader) in the parameter. So, directly storing the referenced parameter is a good idea but I'd prefer that pointer to be in d3dx_parameter. > Cheers > Rico > > --- > dlls/d3dx9_36/effect.c | 98 > ++++++++++++++++++-------------------------------- > 1 Datei geändert, 34 Zeilen hinzugefügt(+), 64 Zeilen entfernt(-) > Cheers, Matteo

2 2

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: [PATCH 4/5] d3drm: Compare with the correct IID in IDirect3DRMVisualArrayImpl_QueryInterface().
by Dmitry Timoshkov Oct. 9, 2013

Oct. 9, 2013

Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > +static HRESULT WINAPI IDirect3DRMVisualArrayImpl_QueryInterface(IDirect3DRMVisualArray *iface, REFIID riid, void **out) > { > - TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), ret_iface); > + TRACE("iface %p, riid %s, out %p.\n", iface, debugstr_guid(riid), out); > > - if (IsEqualGUID(riid, &IID_IUnknown) || > - IsEqualGUID(riid, &IID_IDirect3DRMFrameArray)) > + if (IsEqualGUID(riid, &IID_IDirect3DRMVisualArray) > + || IsEqualGUID(riid, &IID_IUnknown)) > { > - *ret_iface = iface; > IDirect3DRMVisualArray_AddRef(iface); > + *out = iface; > return S_OK; > } Although this is existing code the assignment '*out = iface' is wrong, especially since next patch introduces impl_from_IDirect3DRMVisualArray() helper. Looks like that file needs a bit of COM clean up. -- Dmitry.

2 1

Re: ws2_32/tests: Use BOOL type where appropriate
by Marvin Oct. 8, 2013

Oct. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2674 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (bc): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB8D62 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (2c8): unexpectedly at the OOB mark: 0 === w7pro64 (32 bit sock) === sock.c:509: Test failed: oob_server (8a4): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (8a4): unexpectedly at the OOB mark: 0 === w864 (32 bit sock) === sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (118): unexpectedly at the OOB mark: 0

1 0

Wrong status of gdi32
by Akira Nakagawa Oct. 8, 2013

Oct. 8, 2013

I found this page <http://www.nirsoft.net/dll_information/windows8/gdi32_dll.html> shows that gdi32 dll has more than 800 functions,but the spec file has only 500 .

3 2

RE: binfmt support
by xantares 09 Oct. 8, 2013

Oct. 8, 2013

From: xantares09(a)hotmail.com To: hverbeet(a)gmail.com Subject: RE: binfmt support Date: Mon, 7 Oct 2013 11:47:05 +0000 > Date: Mon, 7 Oct 2013 12:23:30 +0200 > Subject: Re: binfmt support > From: hverbeet(a)gmail.com > To: xantares09(a)hotmail.com > CC: wine-devel(a)winehq.org > > On 7 October 2013 12:06, xantares 09 <xantares09(a)hotmail.com> wrote: > > ... I don't see a reason why to not include it at the wine level instead of > > every linux distros, see: > > https://github.com/xantares/wine/commit/76ebd5d29effaf4b6b39ceecb689f7008bf… > > > > What do you think ? > > > Ignoring the discussion if we want this or not for the moment, I'd > guess this would break as soon as you pass something other than /usr > for --prefix to configure. Yes, It'll only work when prefix=/usr, which is always what happens when building packaging. This is what we want ; we still want to honor the prefix var. x.

1 0

Re: gdi32/tests: Skip linked font like SimSun-ExtB in fixed-pitch font selection.
by Marvin Oct. 8, 2013

Oct. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2669 Your paranoid android. === wvista (32 bit font) === The test timed out === w2008s64 (32 bit font) === Timeout Failure running script in VM: network read timed out

1 0

Re: (try 6)[3/5] imm32: use thread data from target HWND
by Alexandre Julliard Oct. 8, 2013

Oct. 8, 2013

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -1597,7 +1612,9 @@ BOOL WINAPI ImmGetConversionStatus( > HWND WINAPI ImmGetDefaultIMEWnd(HWND hWnd) > { > HWND ret; > - IMMThreadData* thread_data = IMM_GetThreadData(0); > + IMMThreadData* thread_data = IMM_GetThreadDataForWindow(hWnd); > + if (!thread_data) > + return NULL; > if (thread_data->hwndDefault == NULL) > thread_data->hwndDefault = CreateWindowExW( WS_EX_TOOLWINDOW, > szwIME, NULL, WS_POPUP, 0, 0, 1, 1, 0, 0, 0, 0); It doesn't seem right to create the default window from a different thread. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/5] wined3d: Handle sRGB_decode when reading the sampler state.
by Henri Verbeet Oct. 8, 2013

Oct. 8, 2013

On 8 October 2013 00:27, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 52eac16..eb8ca7e 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -5608,8 +5608,6 @@ HRESULT surface_load_location(struct wined3d_surface *surface, DWORD location, c > } > } > > - if (location == SFLAG_INSRGBTEX && gl_info->supported[EXT_TEXTURE_SRGB_DECODE]) > - location = SFLAG_INTEXTURE; > > if (surface->flags & location) > { > @@ -5671,12 +5669,6 @@ HRESULT surface_load_location(struct wined3d_surface *surface, DWORD location, c > surface_evict_sysmem(surface); > } > > - if (surface->flags & (SFLAG_INTEXTURE | SFLAG_INSRGBTEX) > - && gl_info->supported[EXT_TEXTURE_SRGB_DECODE]) > - { > - surface->flags |= (SFLAG_INTEXTURE | SFLAG_INSRGBTEX); > - } > - > return WINED3D_OK; > } > This change seems good on its own, as far as I can tell all callers already handle this correctly. I'm less sure about the other changes, the texture code seems like the right place to handle EXT_texture_sRGB_decode.

2 2

Re: [1/3] xmllite: Use buffer offset instead of pointers
by Nikolay Sivov Oct. 8, 2013

Oct. 8, 2013

On 10/6/2013 19:06, Nikolay Sivov wrote: > It's normal to grow destination buffer, in this case all stored > pointers will be trashed. This patch uses offsets from start of a > buffer instead. > Hi, Alexandre. Patches list shows a build failure for this one, and I don't see any failures on testbot for it so assuming something it fails on your machine. So what's the exact failure you get?

2 2

Re: riched20: Set control content in WM_CREATE message
by Akihiro Sagawa Oct. 8, 2013

Oct. 8, 2013

On Sat, 05 Oct 2013 14:54:07 +0200, Piotr Caban wrote: > + if (!(editor->styleFlags & ES_MULTILINE)) > + { > + len = 0; > + while(textW[len] != '0' && textW[len] != '\r' && textW[len] != '\n') > + len++; > + } Although this patch has been committed as e660bf676c111ce20d9e868280094f1c5bb81c79, I doubt that it works properly. Did you mean '\0' or 0? Regards, Akihiro Sagawa

2 1

winemac.drv: add fullscreen mode support for Mac OS X 10.7+
by Kevin Eaves Oct. 8, 2013

Oct. 8, 2013

Attached patch is a proof-of-concept for the fullscreen APIs provided in OS X 10.7+, which allows applications to enter fullscreen in a separate desktop space. The fullscreen button appears if a main window is resizable. Basically this feature is the zoom button on crack. It doesn't actually go fullscreen 'natively' but simply resizes the window fullscreen, and automatically moves it to its own space. As far as Wine is concerned the window resized — just like clicking the zoom button and manually assigning the window to its own space. I doubled the MaxTrackSize in user32/winpos.c, but it only needs +15 for the height.

2 2

Re: msi/tests: Use BOOL type where appropriate (resend)
by Marvin Oct. 8, 2013

Oct. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2667 Your paranoid android. === wvista (32 bit msi) === Timeout === w2008s64 (32 bit msi) === Timeout Failure running script in VM: network read timed out === w2008s64 (64 bit msi) === Timeout

1 0

Re: msi/tests: Use BOOL type where appropriate
by Marvin Oct. 7, 2013

Oct. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2660 Your paranoid android. === wvista (32 bit msi) === The test timed out === w2008s64 (32 bit msi) === The test timed out === w7pro64 (32 bit msi) === No test summary line found Failure running script in VM: network read timed out === w2008s64 (64 bit msi) === Timeout === w7pro64 (64 bit msi) === Timeout

1 0

Re: mscoree: Partial implement ICLRMetaHost RequestRuntimeLoadedNotification (try 2)
by Vincent Povirk Oct. 7, 2013

Oct. 7, 2013

HRESULT CLRMetaHost_CreateInstance(REFIID riid, void **ppobj) { + GlobalCLRMetaHost.callback = NULL; return ICLRMetaHost_QueryInterface(&GlobalCLRMetaHost.ICLRMetaHost_iface, riid, ppobj); } I don't think we should be changing global state every time someone creates an instance of this object. We can't assume it only happens once.

1 0

Re: riched20: Set control content in WM_CREATE message
by Alexandre Julliard Oct. 7, 2013

Oct. 7, 2013

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/riched20/editor.c | 21 +++++++++++++++++++++ > dlls/riched20/tests/editor.c | 38 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 59 insertions(+) It doesn't work: ../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p riched20_test.exe.so txtsrv.c && touch txtsrv.ok wine: Unhandled page fault on read access to 0x00000024 at address 0x7ac23e94 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000024 in 32-bit code (0x7ac23e94). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7ac23e94 ESP:0032f290 EBP:0032fb98 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:7ac58c00 ECX:0032fc80 EDX:003338e8 ESI:003338e8 EDI:00000001 Stack dump: 0x0032f290: 0032fc80 00000000 00000000 00000000 0x0032f2a0: 00000001 00000000 00000000 00333428 0x0032f2b0: 4d430002 00000008 00000004 7bc3c8e3 0x0032f2c0: 00333558 00333550 00000000 7bc3c8e3 0x0032f2d0: 00000780 000004b0 0032f300 6890a34c 0x0032f2e0: 00000000 0000001f 0032f318 688bd210 Backtrace: =>0 0x7ac23e94 ME_HandleMessage+0x32d4(editor=0x3338e8, msg=0x1, wParam=0, lParam=0, unicode=0x1, phresult=0x32fbdc) [/home/julliard/wine/wine/dlls/riched20/editor.c:4029] in riched20 (0x0032fb98) 1 0x7ac3d3ab CreateTextServices+0x11a(pUnkOuter=<couldn't compute location>, pITextHost=<couldn't compute location>, ppUnk=<couldn't compute location>) [/home/julliard/wine/wine/dlls/riched20/txtsrv.c:417] in riched20 (0x0032fbf8) 2 0x686569cb func_txtsrv+0x2fa() [/home/julliard/wine/wine/dlls/riched20/tests/txtsrv.c:864] in riched20_test (0x0032fd38) 3 0x6862a5a7 main+0x386(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/riched20/tests/../../../include/wine/test.h:570] in riched20_test (0x0032fe08) 4 0x68657e30 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in riched20_test (0x0032fe58) 5 0x7b85f36c call_process_entry+0xb() in kernel32 (0x0032fe78) 6 0x7b86054b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1085] in kernel32 (0x0032feb8) 7 0x7bc7fe70 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 8 0x7bc82d7d call_thread_func+0x7c(entry=0x7b8604e0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2602] in ntdll (0x0032ffa8) 9 0x7bc7fe4e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 10 0x7bc54a1e start_process+0x1d(kernel_start=0x7b8604e0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2694] in ntdll (0x0032ffe8) 11 0x6803128d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 12 0x6803134b wine_switch_to_stack+0x2a(func=0x7bc54a00, arg=0x7b8604e0, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xff8b7288) 13 0x7bc5a557 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2750] in ntdll (0xff8b72f8) 14 0x7b866ac0 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1257] in kernel32 (0xff8b8208) 15 0x7bc5ac23 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2959] in ntdll (0xff8b8298) 16 0x6802eeda wine_init+0x2b9(argc=0x3, argv=0xff8b87d4, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:952] in libwine.so.1 (0xff8b82f8) 17 0x7bf00d3b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xff8b8738) 18 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x7ac23e94 ME_HandleMessage+0x32d4 [/home/julliard/wine/wine/dlls/riched20/editor.c:4029] in riched20: movl 0x24(%eax),%eax 4029 : (void*)((CREATESTRUCTA*)lParam)->lpszName); -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] msvcrt: Add support for vcall thunks demangling (try2)
by Marvin Oct. 7, 2013

Oct. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2651 Your paranoid android. === wxppro (32 bit cpp) === cpp.c:1329: Test failed: 125: Got name "?_dispatch(a)_impl_Engine@SalomeApp@@$R4CE(a)BA@PPPPPPPM(a)7AE_NAAVomniCallHandle@@@Z" cpp.c:1332: Test failed: 125: Expected "[thunk]:public: virtual bool __thiscall SalomeApp::_impl_Engine::_dispatch`vtordispex{36,16,4294967292,8}' (class omniCallHandle &)"

1 0

Re: [PATCH 3/3] msvcrt: Add support for vtordispex demangling
by Marvin Oct. 7, 2013

Oct. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2650 Your paranoid android. === wxppro (32 bit cpp) === cpp.c:1328: Test failed: 124: Got name "[thunk]: __thiscall CView::`vcall'{392,{flat}}' " cpp.c:1331: Test failed: 124: Expected "[thunk]: __thiscall CView::`vcall'{392,{flat}}' }'" cpp.c:1328: Test failed: 125: Got name "?_dispatch(a)_impl_Engine@SalomeApp@@$R4CE(a)BA@PPPPPPPM(a)7AE_NAAVomniCallHandle@@@Z" cpp.c:1331: Test failed: 125: Expected "[thunk]:public: virtual bool __thiscall SalomeApp::_impl_Engine::_dispatch`vtordispex{36,16,4294967292,8}' (class omniCallHandle &)"

1 0

Re: [PATCH 2/3] msvcrt: Add support for vcall thunks demangling
by Marvin Oct. 7, 2013

Oct. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2649 Your paranoid android. === wxppro (32 bit cpp) === cpp.c:1326: Test failed: 124: Got name "[thunk]: __thiscall CView::`vcall'{392,{flat}}' " cpp.c:1329: Test failed: 124: Expected "[thunk]: __thiscall CView::`vcall'{392,{flat}}' }'"

1 0

Re: msvcrt: add support for _chsize_s (try #2)
by Piotr Caban Oct. 7, 2013

Oct. 7, 2013

Hi, On 10/06/13 00:45, morphiend wrote: > + * _chsize_s (MSVCRT.@) > + */ > +int CDECL MSVCRT__chsize_s(int fd, __int64 size) > +{ > + LARGE_INTEGER cur, pos; > + LARGE_INTEGER temp = { 0 }; This causes compilation warnings. There's also a trailing space in this line. > + TRACE("(fd=%d, size=%lld)\n", fd, size); You can't print 64-bit numbers this way, it's not portable. You can use wine_dbgstr_longlong function. > + handle = msvcrt_fdtoh(fd); > + if (!MSVCRT_CHECK_PMT_ERR(handle == INVALID_HANDLE_VALUE, MSVCRT_EBADF) || > + !MSVCRT_CHECK_PMT_ERR(size < 0, MSVCRT_EINVAL)) You're validating parameters incorrectly. Did you test this patch? > + { > + ret = SetEndOfFile(handle); > + if (!ret) > + { > + msvcrt_set_errno(GetLastError()); > + ret = *MSVCRT__errno(); > + } This causes the _chsize_s function to return TRUE in case of success. > + /* restore the file pointer */ > + MSVCRT__lseek(fd, cur.QuadPart, SEEK_SET); MSVCRT__lseek takes LONG as second argument. Cheers, Piotr

1 0

binfmt support
by xantares 09 Oct. 7, 2013

Oct. 7, 2013

Hello, I made a patch to add a configuration file to be picked up by binfmt to allow to associate windows executables to wine. As binfmt is now a part of systemd in most linux disttributions: http://www.freedesktop.org/software/systemd/man/systemd-binfmt.service.html ... I don't see a reason why to not include it at the wine level instead of every linux distros, see: https://github.com/xantares/wine/commit/76ebd5d29effaf4b6b39ceecb689f7008bf… What do you think ? x.

2 1

Re: msvcrt: add support for _chsize_s (try #2)
by Frédéric Delanoy Oct. 6, 2013

Oct. 6, 2013

On Sun, Oct 6, 2013 at 12:45 AM, morphiend <morphiend(a)gmail.com> wrote: > This patch adds the _chsize_s() to the mscvrt and corresponding mscvr*s. > This was tested on Ubuntu 12.10 using IDA 6.4 as a test application. Without > the implementation of _chsize_s(), certain binaries caused an internal crash > of IDA. This patch fixed that crash. > You need to use your real name when sending patches. -- Frédéric Delanoy

2 1

Re: mshtml/tests: Fix compilation on systems that don't support nameless unions.
by Marvin Oct. 5, 2013

Oct. 5, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2637 Your paranoid android. === wxppro (32 bit htmldoc) === htmldoc.c:2898: Test failed: mon(0026BF78) != exmon(00269670) htmldoc.c:7601: Test failed: mon(0026BF78) != exmon(00269670) htmldoc.c:5978: Test failed: mon(0026BF78) != exmon(00269670) htmldoc.c:2898: Test failed: mon(002ADFE8) != exmon(00265FE8) htmldoc.c:7601: Test failed: mon(002ADFE8) != exmon(00265FE8) htmldoc.c:5978: Test failed: mon(002ADFE8) != exmon(00265FE8) === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found

1 0

Re: kernel32/tests: Fix compilation on systems that don't support nameless unions.
by Marvin Oct. 5, 2013

Oct. 5, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2634 Your paranoid android. === w7pro64 (64 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:883: Test failed: WaitCommEvent error 0 comm.c:885: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:889: WaitCommEvent for EV_TXEMPTY took 1014 ms (timeout 1000) comm.c:891: Test failed: WaitCommEvent used 1014 ms for waiting

1 0

BiDi, Unicode 6.3 and Wine.
by Aric Stewart Oct. 4, 2013

Oct. 4, 2013

Hello, So Unicode 6.3 was just recently released. One of the things it features is an updated BIDI (Bidirectional) algorithm. This is revision 29 to the algorithm. (http://www.unicode.org/reports/tr9/tr9-29.html#Modifications) Looking at the code I moved from gdi32 to usp10, it looks like the existing code is based off of revision 17. This implementation was originally by Shachar and Maarten. I simply integrated it into uniscribe. I am tempted to update our code to match the revision 29 version of the algorithm. But this raises a question. Right now our code mostly correctly mimics Windows. It may be that I am not testing the correct edge cases that would reveal if windows is coded to a later version of the algorithm or not. But if we update to revision 29 then we will almost assuredly be using a later version of the algorithm. What is more important to us in this regard? Do we want to have the latest algorithm based on the unicode standard, or do we want to try to match the algorithm that Windows makes use of? Thanks! -aric

3 2

Re: [3/3] ntdll: Add support for FILE_APPEND_DATA to NtWriteFile. Take 2.
by Alexandre Julliard Oct. 4, 2013

Oct. 4, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -979,6 +986,12 @@ NTSTATUS WINAPI NtWriteFile(HANDLE hFile, HANDLE hEvent, > goto done; > } > > + if (append_write) > + { > + offset_eof.QuadPart = (LONGLONG)-1; /* FILE_WRITE_TO_END_OF_FILE */ > + offset = &offset_eof; > + } > + Please add a test for the file position after the write, to show that this is the correct behavior. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] wined3d: Don't bother about client storage in wined3d_surface_set_mem.
by Henri Verbeet Oct. 4, 2013

Oct. 4, 2013

On 4 October 2013 15:02, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > Client storage only applies to GL textures, which won't be created for sysmem surfaces. > I don't think that's necessarily true at the moment. In particular, ddraw blits can in principle cause a texture to be created for sysmem surfaces. There might be restrictions in the ddraw API that prevent this from happening in practice, but even if there are, we certainly don't enforce them.

2 4

Re: [PATCH 5/5] wininet: Added InternetLockRequestFile tests.
by Marvin Oct. 4, 2013

Oct. 4, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2625 Your paranoid android. === w2008s64 (64 bit http) === http.c:3521: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3521: Test failed: HttpQueryInfo failed 0

1 0

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded
by Henri Verbeet Oct. 4, 2013

Oct. 4, 2013

On 3 October 2013 21:16, Lasse Rasinen <lrasinen(a)iki.fi> wrote: > According to debugging output, Artemis Spaceship Bridge Simulator 2.0 > calls LockRect twice on the same texture (for whatever reason) and crashes. > > http://bugs.winehq.org/show_bug.cgi?id=34271 > > This change prevents the locked_rect being overwritten with garbage in > that case, and the game no longer crashes. > I think this patch makes sense, but could you please add a test case as well? Ideally we'd also have similar tests for other resources (i.e., textures, volumes, vertex buffers, index buffers) and D3D versions (ddraw, d3d8), but that's not a strict requirement. > + if (hr == WINED3D_OK) { > + locked_rect->Pitch = map_desc.row_pitch; > + locked_rect->pBits = map_desc.data; > + } > Minor style issue, this should be: if (SUCCEEDED(hr)) { ... }

3 2

Re: [PATCH 2/2] advapi32: Don't cache HKCR if WOW64 redirection flags are set
by Marvin Oct. 4, 2013

Oct. 4, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2624 Your paranoid android. === wxppro (32 bit registry) === Timeout

1 0

Re: [PATCH 1/5] wined3d: Don't bother about client storage in wined3d_surface_set_mem.
by Henri Verbeet Oct. 4, 2013

Oct. 4, 2013

On 4 October 2013 00:03, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -2883,10 +2886,6 @@ HRESULT CDECL wined3d_surface_set_mem(struct wined3d_surface *surface, void *mem > /* Now the surface memory is most up do date. Invalidate drawable and texture. */ > surface_validate_location(surface, SFLAG_INSYSMEM); > surface_invalidate_location(surface, ~SFLAG_INSYSMEM); > - > - /* For client textures OpenGL has to be notified. */ > - if (surface->flags & SFLAG_CLIENT) > - surface_release_client_storage(surface); > } > else if (surface->flags & SFLAG_USERPTR) > { > @@ -2899,9 +2898,6 @@ HRESULT CDECL wined3d_surface_set_mem(struct wined3d_surface *surface, void *mem > surface->resource.allocatedMemory = NULL; > surface->flags &= ~(SFLAG_USERPTR | SFLAG_INSYSMEM); > > - if (surface->flags & SFLAG_CLIENT) > - surface_release_client_storage(surface); > - > surface_prepare_system_memory(surface); > } > What makes this safe, and why is it needed?

1 0

Re: [PATCH 3/3] winemac: Tell Wine when Cocoa has brought a window to the front.
by Ken Thomases Oct. 4, 2013

Oct. 4, 2013

On Oct 4, 2013, at 12:17 AM, Ken Thomases wrote: > --- > dlls/winemac.drv/cocoa_app.m | 8 ++++++-- > dlls/winemac.drv/cocoa_window.h | 1 + > dlls/winemac.drv/cocoa_window.m | 16 +++++++++++++--- > dlls/winemac.drv/event.c | 5 +++++ > dlls/winemac.drv/macdrv.h | 1 + > dlls/winemac.drv/macdrv_cocoa.h | 1 + > dlls/winemac.drv/window.c | 12 ++++++++++++ > 7 files changed, 39 insertions(+), 5 deletions(-) > > <0003-winemac-Tell-Wine-when-Cocoa-has-brought-a-window-to.patch> Don't commit this one. It has caused some strange behavior on Mavericks. The other two in the series are OK and useful independently of this one. -Ken

1 0

Re: [PATCH 1/5] wined3d: Store valid locations in the resource.
by Henri Verbeet Oct. 3, 2013

Oct. 3, 2013

On 3 October 2013 13:08, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > --- > dlls/wined3d/volume.c | 46 +++++++++++++++++++++--------------------- > dlls/wined3d/wined3d_private.h | 6 ++++-- > 2 files changed, 27 insertions(+), 25 deletions(-) > What about surfaces and buffers?

2 5

Re: kernel32: Add tests for job objects (try 4)
by Alexandre Julliard Oct. 3, 2013

Oct. 3, 2013

Andrew Cook <ariscop(a)gmail.com> writes: > + sprintf(buffer, "\"%s\" tests/process.c ignored \"%s\"", selfname, "wait"); > + > + IOPort = CreateIoCompletionPort(INVALID_HANDLE_VALUE, NULL, 0, 1); > + ok(IOPort != INVALID_HANDLE_VALUE, "CreateIoCompletionPort (%d)", GetLastError()); > + > + JobObject = pCreateJobObjectW(NULL, NULL); > + ok(JobObject != INVALID_HANDLE_VALUE, "CreateJobObject (%d)\n", GetLastError()); These functions don't return INVALID_HANDLE_VALUE. -- Alexandre Julliard julliard(a)winehq.org

1 0

Looking for an icon for the Mac driver: generic program running under Wine
by Ken Thomases Oct. 3, 2013

Oct. 3, 2013

Hi, I have a need for a new icon in Wine and I'm hoping somebody with some graphics-design skills might be able to create it. The Mac driver attempts to extract an icon from the executable to use for the Dock icon of its process. This is also the icon that appears in the Command-Tab application switcher. This often works, but not always. When it doesn't, the Dock just uses the generic "Unix executable" icon from Mac OS X. You can see that here: <http://i.imgur.com/b1JrMDJ.png>. It's not very nice. I would prefer to have a Wine-specific generic program icon. Any graphic designer care to take on the task of creating such an icon? I'm told Wine has been using the Tango icons as the template for its. Tango provides application-x-executable.svg at <http://cgit.freedesktop.org/tango/tango-icon-theme/tree/svg> that might be suitable. That could be badged with the Wine glass logo to produce an icon for a program running under Wine. On the other hand, if this icon were to be used only by the Mac driver, it might be more appropriate to use a Mac-themed icon. Some time back, Jeremiah posted an archive of icons. <http://www.winehq.org/pipermail/wine-devel/2013-February/098783.html> That included one which had a miniature Mac window badged with the Wine glass logo. I'm not sure of the copyright/licensing situation with that icon. It's bitmap-only, not vector, but that might be fine for a Mac-only icon. It does have some issues with rough edges around the window, rather than a smooth alpha-blended edge. Although Mac app icons can go up to 1024x1024 pixels (512x512 "points" at 2x resolution for Retina displays), this icon would only appear in the Dock and the application switcher. So, it needn't be larger than 256x256 pixels (128x128(a)2x). Thanks, Ken

2 1

Re: rpcss: Convert to a service
by Andrew Cook Oct. 3, 2013

Oct. 3, 2013

Ignore this, for some reason this randomly forks a huge number of rpcss instances, and decided to not do so while i was testing it On 03/10/13 14:00, Andrew Cook wrote: > --- > dlls/rpcrt4/rpc_epmap.c | 40 ++++++++----------- > programs/rpcss/Makefile.in | 2 +- > programs/rpcss/rpcss_main.c | 97 > +++++++++++++++++++++++++++++++++++---------- > tools/wine.inf.in | 11 +++++ > 4 files changed, 104 insertions(+), 46 deletions(-) > >

1 0

Re: server: Set the unix file write mode bit also for FILE_APPEND_DATA access.
by Dmitry Timoshkov Oct. 2, 2013

Oct. 2, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > diff --git a/server/file.c b/server/file.c > index 2ecf97c..94d3060 100644 > --- a/server/file.c > +++ b/server/file.c > @@ -459,7 +459,7 @@ static mode_t file_access_to_mode( unsigned int access ) > > access = generic_file_map_access( access ); > if (access & FILE_READ_DATA) mode |= 4; > - if (access & FILE_WRITE_DATA) mode |= 2; > + if (access & (FILE_WRITE_DATA|FILE_APPEND_DATA)) mode |= 2; > if (access & FILE_EXECUTE) mode |= 1; > return mode; > } I don't think that this patch should be in 'superseded' state. -- Dmitry.

1 0

Re: [5/5] ws2_32: Always return the source address from WSAAccept.
by Marvin Oct. 2, 2013

Oct. 2, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2610 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (618): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 74AA9799 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (600): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 0000000000000000

1 0