October 2013 - Wine-Devel - list.winehq.org

Re: [3/3] ws2_32: Always return the source address from WSAAccept.
by Bruno Jesus Oct. 1, 2013

Oct. 1, 2013

On Tue, Oct 1, 2013 at 6:37 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > --- > dlls/ws2_32/socket.c | 9 +-------- > dlls/ws2_32/tests/sock.c | 6 +++--- > 2 files changed, 4 insertions(+), 11 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index c34de4b..6855298 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -6546,12 +6546,8 @@ SOCKET WINAPI WSAAccept( SOCKET s, struct WS_sockaddr *addr, LPINT addrlen, > TRACE("Socket %04lx, sockaddr %p, addrlen %p, fnCondition %p, dwCallbackData %ld\n", > s, addr, addrlen, lpfnCondition, dwCallbackData); > > - > - size = sizeof(src_addr); > - cs = WS_accept(s, &src_addr, &size); > - > + cs = WS_accept(s, addr, addrlen); The parameter addr may be NULL in WSAAccept, I can't check the source code right now but what will WS_accept do in this case? Best wishes, Bruno

2 1

Re: [1/3] ws2_32: Always clear res on error in getaddrinfo/GetAddrInfoW.
by Marvin Oct. 1, 2013

Oct. 1, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2419 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (2a4): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (774): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (884): unexpectedly at the OOB mark: 0 === w7pro64 (64 bit sock) === sock.c:509: Test failed: oob_server (af8): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (af8): unexpectedly at the OOB mark: 0 sock.c:288: Test failed: do_synchronous_recv (af8): error 10054: sock.c:534: Test failed: oob_server (af8): not at the OOB mark: 1

1 0

Re: [PATCH 2/5] wined3d: Move location management into the resource.
by Henri Verbeet Oct. 1, 2013

Oct. 1, 2013

Please split this.

1 0

Re: [PATCH 2/5] wined3d: Move location management into the resource.
by Stefan Dösinger Oct. 1, 2013

Oct. 1, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, To illustrate the goal of these patches I've attached an archive of all surface cleanup patches to this mail. The goal is to merge GL buffer object handling of buffers, surfaces and volumes. The main motivation for this is to handle WINED3D_MAP_DISCARD in one central place once dynamic resource handling is implemented in the command stream. The 4 patches in this series move location and buffer handling code from volume.c to resource.c. The next patches remove broken(overlay, partial rectangle handling) and half-broken(direct DIB maps, buffers) surface features. The next step is migrating surfaces to the resource location and loading code in resource.c. After that WINED3D_LOCATION_DISCARDED handling is improved and previously removed surface features re-added. Due to the removal of some surface features, performance regressions are possible. I think it's unlikely because the existing surface PBO code doesn't really do what it is supposed to do. Functional regressions should not happen. This patchset does not deal with d3d buffers. The central aspect of merging buffer handling is removing color and rhw conversion support. (or, alternatively, adding a separate location WINED3D_LOCATION_CONVBUFFER if we really want to keep the conversion code.) There are some problems later in the patchset that need fixing: Patch 24 is too big, patches 48 and 52 need to be moved. Non-GL ddraw rendering is broken at the moment (black screen). My patches don't make this any worse, but I'd like to fix it to make sure non-GL operation works as intended. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSSqzhAAoJEN0/YqbEcdMww1wP/jYYo0B/igDHd0QwOkwk8DIz ip4PKHxRgqaSYzswcBGZge+iBrJrvXSHh3cScG9KJ1a/VeaRlPyhDsFDzPce1VDK 0IX7iF/gKpZazPVy21lSIPQMlErSVy58fkIsd/PqKV/zyU8zNyZDkYU3n80itYrq Y3hPhaKbJIDN8QbhIOZu0egaiHObcwomBgZCfrUv+hr+xf+gMERYbqN9gj2JWFwJ dx4EzdeTFw1CZkFExbAJKt5zWA2KeFyitVU887WOSJpa3UbqemGpOID8vnYZlABZ mmqrS22XWjXlo2+0s0NufxeQJHvzpkcludLkg8a12r4FDs+ORYYnGbUeUy2o2Rud uV2quoeucA1TEAyF20JCrVNuCvDz5nvQq19rzR51k7FF/IsKGiI823ZGA54F4Dkn DZkyDcE0rnI2Re+br1aM31ZUt/maTxQMpk10BAAjwz1jbXQ4plZ9dtO9/DObdw8r nfPDJz+DsuBv19Th7MPjTxvXRjxVFTzlfuXNk/cOfAhgNdpEFSOGCAexGi6moSq1 6slQeLb8PqmO/83JQBuz4OI86dSoGSC6O9c/TtWXdW1PgCDyHgFvNb3jmQHsf7ya U1o2TkkNhLvfYz5Eo85Ep8oyVIF09CDrqQzUo10q33K5Y2E3RM8Xbxc+crGtjgxA TGwCwR8SRvAW+DfeP7bq =MEk/ -----END PGP SIGNATURE-----

1 0

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.
by Alexandre Julliard Oct. 1, 2013

Oct. 1, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/ntdll/file.c | 3 ++- > dlls/ntdll/tests/file.c | 5 +++-- > 2 files changed, 5 insertions(+), 3 deletions(-) I don't see the point. Do you actually have an app that depends on this? -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: ntdll: Fix the version reported for 64-bit Windows XP.
by Alexandre Julliard Oct. 1, 2013

Oct. 1, 2013

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -129,11 +129,19 @@ static const RTL_OSVERSIONINFOEXW VersionData[NB_WINDOWS_VERSIONS] = > 4, 0, 0, VER_NT_WORKSTATION, 30 /* FIXME: Great, a reserved field with a value! */ > }, > /* WINXP */ > +#ifdef _WIN64 > + { > + sizeof(RTL_OSVERSIONINFOEXW), 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, > + {'S','e','r','v','i','c','e',' ','P','a','c','k',' ','1',0}, > + 1, 0, VER_SUITE_SINGLEUSERTS, VER_NT_WORKSTATION, 0 > + }, > +#else > { > sizeof(RTL_OSVERSIONINFOEXW), 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, > {'S','e','r','v','i','c','e',' ','P','a','c','k',' ','3',0}, > 3, 0, VER_SUITE_SINGLEUSERTS, VER_NT_WORKSTATION, 30 /* FIXME: Great, a reserved field with a value! */ > }, > +#endif This would mean that the 32-bit side sees a different version. I don't think that's correct. -- Alexandre Julliard julliard(a)winehq.org

1 0

mscoree: Implement CreateInterface
by Alistair Leslie-Hughes Oct. 1, 2013

Oct. 1, 2013

Hi, Changelog: mscoree: Implement CreateInterface Best Regards Alistair Leslie-Hughes

1 0

oledb32: Implement IDataSourceLocator get/put hWnd (try 4)
by Alistair Leslie-Hughes Oct. 1, 2013

Oct. 1, 2013

Hi, Corrected warnings. Changelog: Implement IDataSourceLocator get/put hWnd Best Regards Alistair Leslie-Hughes

1 0

Re: ws2_32: Implement WSASendMsg() (try 3)
by Marvin Oct. 1, 2013

Oct. 1, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2414 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (210): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB8D62 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (5a0): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (6b0): unexpectedly at the OOB mark: 0

1 0

Increasing max_req_size and subsequent errors
by Hugh McMaster Sept. 30, 2013

Sept. 30, 2013

I need to increase the $max_req_size in tools/make_requests. A new request structure for GetConsoleScreenBufferInfoEx is 80 bytes and primarily made up of 16 unsigned long integers. This is fine, but raises the error: wineserver: request.c:755: open_master_socket: Assertion `sizeof(union generic_reply) == sizeof(struct request_max_size)' failed. It looks like this error is connected to struct request_max_size { int pad[16]; }; in include/wine/server_protocol.h. But other than increasing the size of the array, I'm not sure how to fix this appropriately. Any advice will be appreciated.

1 1

Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)
by Bruno Jesus Sept. 30, 2013

Sept. 30, 2013

On Fri, Sep 27, 2013 at 8:16 AM, Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > > Fixes bug 18440, 20847. > > Try 3: > - Rebase to recent source. > - Separate ABC metrics change. > - Use conditional operator. > --- > dlls/gdi32/freetype.c | 4 ++-- > dlls/gdi32/tests/font.c | 24 ++++++++---------------- > 2 files changed, 10 insertions(+), 18 deletions(-) > + ok(gm.gmBlackBoxY == 1, "%2d:expected 1, got %u\n", fmt[i], gm.gmBlackBoxX); There seems to be a copy&paste issue in all lines related to gmBlackBoxY reporting the error as gmBlackBoxX. Regards, Bruno

1 0