October 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] d3d8/tests: Avoid windowsx.h.
by Marvin Oct. 29, 2013

Oct. 29, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3094 Your paranoid android. === w7pro64 (32 bit device) === device.c:2465: Test failed: Expected foreground window 00030170, got 00060144. === w864 (32 bit device) === device.c:2483: Test failed: Expected foreground window 0004017A, got 0001007A. device.c:3176: Test failed: Expected wndproc 0x40ff80, got 0x40ff80.

1 0

Re: [PATCH 2/5] ddraw/tests: Allow some flags to fail surface creation in test_rt_caps (try 2).
by Marvin Oct. 28, 2013

Oct. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3085 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:3915: Test failed: Test 16: Got unexpected caps 0x22800, expected 0x10026000. ddraw2.c:3915: Test failed: Test 17: Got unexpected caps 0x20800, expected 0x10024000. === w864 (32 bit ddraw1) === ddraw1.c:3289: Test failed: Test 16: Got unexpected caps 0x22800, expected 0x10026000. ddraw1.c:3289: Test failed: Test 17: Got unexpected caps 0x20800, expected 0x10024000.

1 0

Wine Mono 4.5.0 Release
by Vincent Povirk Oct. 28, 2013

Oct. 28, 2013

I have published version 4.5.0 of Wine Mono on sourceforge. It's been a little over a year since the last release, and I'm sorry I waited so long to do it. I have also changed the versioning scheme. The major and minor version numbers will now indicate the highest supported .NET runtime version. The source tarball is at https://sourceforge.net/projects/wine/files/Wine%20Mono/4.5.0/wine-mono-4.5… The binary is at https://sourceforge.net/projects/wine/files/Wine%20Mono/4.5.0/wine-mono-4.5… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.8: * Fixed build on machines using bash as their sh implementation. * .NET Framework directories now include mscorlib.dll (fixes wine bug #31888). * Fixed build on machines running Mac OS X. (Josh DuBois) * Added a security.config file to the .NET 2.0 directory. (Alistair Leslie-Hughes) * Microsoft's Managed C++ compiler sometimes generates broken IL code ending in an unreachable ret statement. This code would be accepted by the .NET runtime but rejected by Mono. Mono is correctly following the spec in this case, but since our goal is compatibility we now accept code that does this. * Building with the -t switch will now build runtime tests. Previously, it only built class library tests. * Added registry keys to indicate the presence of .NET 4.5. * Added user-agent strings to the registry, which allow javascript embedded in web pages to detect .NET. * Updated Mono from 2.11.4 to 3.2.3 plus some additional commits. I'm no longer using Mono's release tags, because they don't seem to help me find revisions that are stable or even buildable. Anyway, here are some highlights of the changes brought in from Mono: * The new 'sgen' garbage collector has been greatly improved and is now the default instead of the old 'boehm' gc, which in our case means it's the only one shipped. It is an improvement over boehm in many ways and should be generally more efficient. * Mono now has support for Portable Class Libraries. * Beginnings of support for System.Windows.Forms.AxHost. (Alistair Leslie-Hughes) * Added support for P/Invoke methods with the thiscall calling convention, which are used by Managed C++ assemblies. * Improved IDispatch interface on managed objects. (Alistair Leslie-Hughes)

3 2

Re: [PATCH 1/5] ddraw/tests: Accept nvidia return values in test_rt_caps (try 2).
by Marvin Oct. 28, 2013

Oct. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3084 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00420E6B

1 0

Re: [Patch]try 2: Bug 33164 - row-resize / col-resize cursor is wrong (Listview)‏
by Vincent Povirk Oct. 28, 2013

Oct. 28, 2013

Your patch is being mangled somehow, even in the attachment. The blank line should contain a space. Also, please use your name transliterated to Latin characters when sending patches.

1 0

Re: shlwapi: Test and fix the behaviour of the CopyTo method for file sizes not multiple of the internal buffer size, on SHCreateStreamOnFileEx-returned IStreams.
by David Quintana (gigaherz) Oct. 28, 2013

Oct. 28, 2013

Hello people, I fixed Vincent's comment, and submitted the new version of the patch. It has been quite a few days already so I'd like to know if there is anything else left to do before the patch is looked at, or if there's just too much going on at the moment, in which case I can re-submit the patch in a few days/weeks, so that it can be looked at properly when there's more time. Vincent Povirk wrote: > We should probably still exit the loop if fewer bytes were read than > requested, rather than do another read at the end of the file.

2 1

Re: [3/8] crypt32: Remove unused variable and avoid a memory leak on error path.
by Alexandre Julliard Oct. 28, 2013

Oct. 28, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/crypt32/filestore.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/dlls/crypt32/filestore.c b/dlls/crypt32/filestore.c > index 44b9bbb..6084395 100644 > --- a/dlls/crypt32/filestore.c > +++ b/dlls/crypt32/filestore.c > @@ -117,9 +117,8 @@ static BOOL CRYPT_ReadBlobFromFile(HANDLE file, PCERT_BLOB blob) > blob->pbData = CryptMemAlloc(blob->cbData); > if (blob->pbData) > { > - DWORD read; > - > - ret = ReadFile(file, blob->pbData, blob->cbData, &read, NULL); > + ret = ReadFile(file, blob->pbData, blob->cbData, NULL, NULL); > + if (!ret) CryptMemFree(blob->pbData); In general if the read size is not checked that's a bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

[3/8] crypt32: Remove unused variable and avoid a memory leak on error path.
by Thomas Faber Oct. 28, 2013

Oct. 28, 2013

Hi, On 2013-10-28 09:28, Dmitry Timoshkov wrote: > - ret = ReadFile(file, blob->pbData, blob->cbData, &read, NULL); > + ret = ReadFile(file, blob->pbData, blob->cbData, NULL, NULL); the lpNumberOfBytesRead parameter is not optional on Windows for synchronous I/O, so could you keep it please? I've had to add it back in elsewhere to prevent Wine functions from crashing on Win. Thanks! Best, Thomas

1 0

Re: [01/02] d3d9: update locked_rect only if wined3d_surface_map succeeds
by Marvin Oct. 28, 2013

Oct. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2909 Your paranoid android. === w864 (32 bit device) === device: unhandled exception c0000005 at 740D14C8 === w864 (64 bit device) === device: unhandled exception c0000005 at 000007F84EDD90EB

3 3

Re: d3d9: update locked_rect only if wined3d_surface_map succeeds (try 2)
by Marvin Oct. 28, 2013

Oct. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3077 Your paranoid android. === w864 (32 bit device) === device: unhandled exception c0000005 at 74C714C8 === w864 (64 bit device) === device: unhandled exception c0000005 at 000007F9366B90EB

1 0

Re: msvcrt: add support for _chsize_s (try #3)
by Piotr Caban Oct. 28, 2013

Oct. 28, 2013

Hi, On 10/26/13 04:58, Mike Koss wrote: > This patch adds the _chsize_s() to the mscvrt and corresponding mscvr*s. > Incorporates previous feedback and now includes an updated test file. > > --- > dlls/msvcr100/msvcr100.spec | 2 +- > dlls/msvcr110/msvcr110.spec | 2 +- > dlls/msvcr80/msvcr80.spec | 2 +- > dlls/msvcr90/msvcr90.spec | 2 +- > dlls/msvcrt/file.c | 63 > +++++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/tests/file.c | 37 ++++++++++++++++++++++++++ > 7 files changed, 105 insertions(+), 5 deletions(-) There're few more issues with this patch: - _chsize_s is not defined in headers (please make sure that your code compiles without warnings) - _chsize_s is not available in some versions of msvcrt.dll, you should load it using GetProcAddress like in other *_s functions tests - the tests are failing on windows, it's probably also caused by lack of _chsize_s header Thanks, Piotr

1 0

Re: [PATCH] wined3d: Use GL_ARB_texture_mirror_clamp_to_edge when available.
by Henri Verbeet Oct. 28, 2013

Oct. 28, 2013

On 21 October 2013 21:20, Rico Schüller <kgbricola(a)web.de> wrote: > As wgl.h is a bit out of date, it still uses the > GL_MIRROR_CLAMP_TO_EDGE_ATI instead of GL_MIRROR_CLAMP_TO_EDGE (which is > only available in headers for OpenGL 4.4). > The wine/wgl.h header is generated from the GL .spec files by dlls/opengl32/make_opengl, so in principle all you'd have to do would be to run that script to get the new constant. Unfortunately Khronos seems to have decided to no longer update the .spec files, since there are shiny new XML files now.

2 2

Re: [PATCH 1/4] comctl32: Set updown control value to min or max in out of range case
by Piotr Caban Oct. 28, 2013

Oct. 28, 2013

On 10/28/13 09:35, Alistair Leslie-Hughes wrote: > On 17/10/2013 1:34 AM, Piotr Caban wrote: >> --- >> dlls/comctl32/updown.c | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> - } else return FALSE; >> + } if ((infoPtr->MaxVal > infoPtr->MinVal && >> infoPtr->CurVal+delta > infoPtr->MaxVal) > ^^^ >> + || (infoPtr->MaxVal < infoPtr->MinVal && >> infoPtr->CurVal+delta < infoPtr->MaxVal)) { >> + delta = infoPtr->MaxVal - infoPtr->CurVal; > > Should the "if" be one its own line or was the else missed? The 'else' was missed. I've sent a fix for it. Thanks, Piotr

1 0

Re: kernel32/tests: Update trace message to report actually used timeout value.
by Marvin Oct. 28, 2013

Oct. 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3074 Your paranoid android. === w2008s64 (32 bit comm) === comm.c:859: Test failed: WaitCommEvent failed with a timeout comm.c:870: recovering after WAIT_TIMEOUT... comm.c:880: Test failed: WaitCommEvent error 0 comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1500) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting comm.c:1551: test_AbortWaitCts timeout 500 handle 000000C4 comm.c:1518: Changing CommMask on the fly for handle 000000C4 after timeout 500

1 0

Re: winspool.drv/tests: Fix the OpenPrinter() tests error reporting.
by Marvin Oct. 27, 2013

Oct. 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3070 Your paranoid android. === w864 (32 bit info) === info.c:2923: Test failed: AddJobA() failed le=50 info.c:2929: Test failed: GetJobA() failed le=87 info: unhandled exception c0000005 at 0040B24A === w864 (64 bit info) === info.c:2923: Test failed: AddJobA() failed le=50 info.c:2929: Test failed: GetJobA() failed le=87 info.c:2972: Test failed: AddJobA() failed le=50 info.c:2978: Test failed: GetJobA() failed le=87 info: unhandled exception c0000005 at 00000000004099E0

1 0

Re: Raise the minimum version of FreeBSD to 8.0.
by Frédéric Delanoy Oct. 26, 2013

Oct. 26, 2013

On Sun, Mar 3, 2013 at 12:22 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > We've had this as a requirement in the FreeBSD ports for quite a > while (and the Wiki describes some background). > > Gerald > --- > - FreeBSD 7.0 or later > + FreeBSD 8.0 or later > ... > FreeBSD info: > - Wine will generally not work properly on versions before FreeBSD 7.0. > + Wine will generally not work properly on versions before FreeBSD 8.0. You should also change the version in the various README.xx translations (in 'documentation' directory). Frédéric

3 2

Re: ddraw/tests: Fix compilation on systems that don't support nameless unions.
by Marvin Oct. 26, 2013

Oct. 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3061 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00420E52 === w864 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 at 0041212F

1 0

Re: shell32/tests: Fix compilation with -D__WINESRC__
by Marvin Oct. 26, 2013

Oct. 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3060 Your paranoid android. === w2008s64 (32 bit shlexec) === shlexec.c:1539: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt453.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test file.shlexec' shlexec.c:2607: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt453.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test2.exe' shlexec.c:2620: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt453.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test2.exe' shlexec.c:2632: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt453.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt453.tmp\test2.exe' === w864 (32 bit shlexec) === shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\wt47C9.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\wt47C9.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2060: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt47C8.tmp\wt47C9.tmp" Exec") succeeded: rc=42 === w2008s64 (64 bit shlexec) === shlexec.c:1539: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt2FC.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test file.shlexec' shlexec.c:2607: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt2FC.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test2.exe' shlexec.c:2620: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt2FC.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test2.exe' shlexec.c:2632: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt2FC.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt2FC.tmp\test2.exe' === w864 (64 bit shlexec) === shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1507: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1539: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:138: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\wt4598.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:138: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\wt4598.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2060: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4597.tmp\wt4598.tmp" Exec") succeeded: rc=42 === w864 (64 bit shlfolder) === shlfolder: unhandled exception c0000005 at 000007F93936ABDC

1 0

Re: msvcrt: add support for _chsize_s (try #3)
by Marvin Oct. 25, 2013

Oct. 25, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3053 Your paranoid android. === wvista (32 bit file) === Failure running script in VM: timed out waiting for the child process === w2008s64 (32 bit file) === Failure running script in VM: timed out waiting for the child process === w7pro64 (32 bit file) === file.c:1574: Test failed: Wrong file size Timeout === w864 (32 bit file) === Failure running script in VM: timed out waiting for the child process

1 0

Re: [PATCH 1/2] advapi32: HKCR merge: foundation
by Alexandre Julliard Oct. 25, 2013

Oct. 25, 2013

George Stephanos <gaf.stephanos(a)gmail.com> writes: > @@ -224,13 +248,138 @@ static NTSTATUS open_key( HKEY *retkey, ACCESS_MASK access, OBJECT_ATTRIBUTES *a > > } > > +static LSTATUS create_hkcr_struct( HKEY *hkey, opened_hkcr_t **hkcr ) > +{ > + UINT_PTR handle = nb_hkcr_handles, i; > + LSTATUS ret = ERROR_SUCCESS; > + > + EnterCriticalSection( &hkcr_handles_cs ); > + > + for (i = 0; i < nb_hkcr_handles; i++) > + { > + if (!hkcr_handles[i]) > + { > + handle = i; > + break; > + } > + } You need some sort of free list instead of a linear search. Also you can probably avoid one level of pointers and store objects directly. Returning a pointer to the object outside of the critical section is not a good idea. > +static HKEY resolve_hkcr( HKEY hkey ) > +{ > + HKEY ret; > + UINT_PTR idx = (UINT_PTR)hkey >> 2; > + opened_hkcr_t *hkcr; > + if (idx <= nb_hkcr_handles) > + { > + EnterCriticalSection( &hkcr_handles_cs ); The count needs to be protected by the critical section too. Also please write a better subject line for the commit. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 1/5] ddraw/tests: Accept nvidia return values in test_rt_caps.
by Henri Verbeet Oct. 25, 2013

Oct. 25, 2013

On 25 October 2013 00:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > --- > dlls/ddraw/tests/ddraw2.c | 26 ++++++++++++++++++++++++-- > dlls/ddraw/tests/ddraw7.c | 27 ++++++++++++++++++++++++--- > 2 files changed, 48 insertions(+), 5 deletions(-) > > diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c > index f4702f1..801135d 100644 > --- a/dlls/ddraw/tests/ddraw2.c > +++ b/dlls/ddraw/tests/ddraw2.c > @@ -3663,6 +3663,7 @@ static void test_rt_caps(void) > DWORD caps_out; > HRESULT create_device_hr; > HRESULT set_rt_hr; > + HRESULT alternative_set_rt_hr; > } > test_data[] = > { This kind of construction doesn't generally make me very happy, but on the other hand I'm not sure I can come up with something that's much better either. I do think we should mark the alternative results as broken. Some of the Evergreen results in later patches in this series are a bit surprising to me. I wrote the test on Windows 7 / AMD Cayman, which should be very close to Evergreen hardware.

2 2

Re: [PATCH 2/5] ddraw/tests: Allow some flags to fail surface creation in test_rt_caps.
by Marvin Oct. 25, 2013

Oct. 25, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3031 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:3915: Test failed: Test 16: Got unexpected caps 0x22800, expected 0x10026000. ddraw2.c:3915: Test failed: Test 17: Got unexpected caps 0x20800, expected 0x10024000. === w864 (32 bit ddraw1) === ddraw1.c:3289: Test failed: Test 16: Got unexpected caps 0x22800, expected 0x10026000. ddraw1.c:3289: Test failed: Test 17: Got unexpected caps 0x20800, expected 0x10024000.

2 1

Re: [3/4] kernel32/tests: WaitCommEvent may sometimes return immediately on a busy system when write operation to a COM-port
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3039 Your paranoid android. === w2008s64 (64 bit comm) === comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting === w7pro64 (64 bit comm) === comm.c:859: Test failed: WaitCommEvent failed with a timeout comm.c:870: recovering after WAIT_TIMEOUT... comm.c:880: Test failed: WaitCommEvent error 0 comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting comm.c:1552: test_AbortWaitCts timeout 500 handle 0000000000000068 comm.c:1519: Changing CommMask on the fly for handle 0000000000000068 after timeout 500

1 0

Re: [2/4] kernel32/tests: Increase the timeout for completion of write to a COM-port.
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3038 Your paranoid android. === w2008s64 (64 bit comm) === comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting === w7pro64 (64 bit comm) === comm.c:859: Test failed: WaitCommEvent failed with a timeout comm.c:870: recovering after WAIT_TIMEOUT... comm.c:880: Test failed: WaitCommEvent error 0 comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:885: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1000) comm.c:886: Test failed: WaitCommEvent used 1513 ms for waiting comm.c:1552: test_AbortWaitCts timeout 500 handle 0000000000000068 comm.c:1519: Changing CommMask on the fly for handle 0000000000000068 after timeout 500

1 0

Re: [PATCH 5/5] d3d8/tests: Port z_range_test to d3d8.
by Marvin Oct. 24, 2013

Oct. 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3034 Your paranoid android. === w864 (32 bit visual) === visual.c:1619: Test failed: Failed to create vertex shader, hr 0x8876086c. visual.c:1649: Test failed: Failed to delete vertex shader, hr 0x8876086c. visual.c:1657: Test failed: Z range failed: Got color 0x00ffffff, expected 0x00ff0000. visual.c:1664: Test failed: Z range failed: Got color 0x00ffffff, expected 0x000000ff. visual.c:1666: Test failed: Z range failed: Got color 0x00ffffff, expected 0x000000ff.

1 0