October 2013 - Wine-Devel - list.winehq.org

Re: [1/2] gdiplus: Reimplement GdipCloneBitmapArea without using GdipBitmapLockBits.
by Vincent Povirk Oct. 18, 2013

Oct. 18, 2013

This series looks good to me.

1 0

Re: [PATCH 2/2] ole32: Pass last_unlock_releases to IExternalConnection_ReleaseConnection().
by Alexandre Julliard Oct. 18, 2013

Oct. 18, 2013

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/ole32/stubmanager.c | 2 +- > dlls/ole32/tests/marshal.c | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M oleaut32.dll -p oleaut32_test.exe.so tmarshal.c && touch tmarshal.ok tmarshal.c:191: Test failed: fLastReleaseCloses = 0, expected 1 tmarshal.c:191: Test failed: fLastReleaseCloses = 0, expected 1 make: *** [tmarshal.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] ole32/tests: Add tests to show that CoLockObjectExternal() calls ReleaseConnection() with the appropriate va
by Marvin Oct. 18, 2013

Oct. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2863 Your paranoid android. === wxppro (32 bit marshal) === marshal.c:2805: Test failed: wait timed out marshal.c:2809: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 00419C8C === w864 (32 bit marshal) === marshal.c:3066: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3067: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3083: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3084: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3121: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3122: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3139: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3140: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3103: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3104: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3066: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3067: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3083: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3084: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3121: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3122: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3139: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3140: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3103: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3104: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3066: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3067: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3083: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3084: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3121: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3122: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3139: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3140: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 marshal.c:3103: Test failed: info->cbSize was 1527466381 instead of 48 marshal.c:3104: Test failed: info->dwServerPid was 0xb68 instead of 0xa48 === w864 (64 bit marshal) === marshal.c:3066: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3067: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3083: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3084: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3121: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3122: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3139: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3140: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3103: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3104: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3066: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3067: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3083: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3084: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3121: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3122: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3139: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3140: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3103: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3104: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3066: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3067: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3083: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3084: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3121: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3122: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3139: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3140: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac marshal.c:3103: Test failed: info->cbSize was -2120541113 instead of 56 marshal.c:3104: Test failed: info->dwServerPid was 0x9cc instead of 0x9ac

2 1

Re: [PATCH 2/2] ole32: Pass last_unlock_releases to IExternalConnection_ReleaseConnection().
by Marvin Oct. 18, 2013

Oct. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2864 Your paranoid android. === wxppro (32 bit marshal) === marshal.c:2803: Test failed: wait timed out marshal.c:2807: Test failed: CoCreateInstance failed with error 0x80040154 marshal: unhandled exception c0000005 at 00419C4C === w864 (32 bit marshal) === marshal.c:3064: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3065: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3081: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3082: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3119: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3120: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3137: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3138: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3101: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3102: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3064: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3065: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3081: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3082: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3119: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3120: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3137: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3138: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3101: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3102: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3064: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3065: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3081: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3082: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3119: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3120: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3137: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3138: Test failed: info->dwServerPid was 0x674 instead of 0xba8 marshal.c:3101: Test failed: info->cbSize was -1799139958 instead of 48 marshal.c:3102: Test failed: info->dwServerPid was 0x674 instead of 0xba8 === w864 (64 bit marshal) === marshal.c:3064: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3065: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3081: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3082: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3119: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3120: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3137: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3138: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3101: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3102: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3064: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3065: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3081: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3082: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3119: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3120: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3137: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3138: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3101: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3102: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3064: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3065: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3081: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3082: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3119: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3120: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3137: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3138: Test failed: info->dwServerPid was 0x900 instead of 0xad0 marshal.c:3101: Test failed: info->cbSize was -588349091 instead of 56 marshal.c:3102: Test failed: info->dwServerPid was 0x900 instead of 0xad0

1 0

Re: wined3d: Initialize map_desc in wined3d_surface_map
by Marvin Oct. 18, 2013

Oct. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2785 Your paranoid android. === w864 (32 bit device) === device.c:5409: Test failed: pBits not cleared on double lock. device.c:5410: Test failed: Pitch not cleared on double lock. device: unhandled exception c0000005 at 742814C8 === w864 (64 bit device) === device.c:5409: Test failed: pBits not cleared on double lock. device.c:5410: Test failed: Pitch not cleared on double lock. device: unhandled exception c0000005 at 000007F84EDD90EB

3 3

Re: [PATCH 7/9] secur32: Cache certificate context instead of store in schannel handle.
by Marvin Oct. 18, 2013

Oct. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2860 Your paranoid android. === w864 (32 bit schannel) === schannel.c:803: Test failed: cert != cert2

1 0

Re: wintrust/tests: Compile with -D__WINESRC__
by Marvin Oct. 17, 2013

Oct. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2850 Your paranoid android. === w864 (32 bit crypt) === crypt.c:289: Test failed: Expected success, got FALSE with 87 crypt.c:293: Test failed: Expected success, got FALSE with 87

1 0

re: visual studio 2012 pdb support
by Dan Kegel Oct. 17, 2013

Oct. 17, 2013

Hi Roman, it might help if you were to show tiny example programs that wine's pdb support doesn't handle, like I did at http://kegel.com/wine/valgrind/pdbdemo/ Ideally you'd file a new bug report at bugs.winehq.org for this. - Dan

1 0

Re: winemac: Restore the window title when the window style is changed.
by Ken Thomases Oct. 17, 2013

Oct. 17, 2013

On Oct 17, 2013, at 3:54 AM, Kevin Eaves wrote: > <cocoa_window.patch> Looks good to me. Thanks. Note that this fixes <http://bugs.winehq.org/show_bug.cgi?id=34472>. -Ken

1 0

Re: [2/3] gdi32: Adjust fake bold outline font metrics.
by Marvin Oct. 17, 2013

Oct. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2842 Your paranoid android. === wvista (32 bit font) === The test timed out

1 0

Re: [1/3] gdi32/tests: Add tests for fake bold outline fonts.
by Marvin Oct. 17, 2013

Oct. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2841 Your paranoid android. === wvista (32 bit font) === No test summary line found Failure running script in VM: network read timed out === w2008s64 (32 bit font) === Failure running script in VM: network read timed out

1 0

Re: [2/2] msxml3: Set referrer header to container url
by Marvin Oct. 17, 2013

Oct. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2837 Your paranoid android. === wxppro (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === wvista (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w2008s64 (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w7pro64 (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w864 (32 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {af0ff408-129d-4b20-91f0-02bd23d88352}, riid {af0ff408-129d-4b20-91f0-02bd23d88352} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9c1-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9c1-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9d5-bafa-11ce-8c82-00aa004ba90b}, riid {79eac9d5-bafa-11ce-8c82-00aa004ba90b} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w2008s64 (64 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w7pro64 (64 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1121: Test failed: unexpected call sp_queryservice_SID_SBindHost httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:305: Test failed: unexpected call htmldoc2_get_all httpreq.c:210: Test failed: unexpected call collection_get_length httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1174: Test failed: unexpected call site_qi_IXMLDOMDocument httpreq.c:1177: Test failed: unexpected call site_qi_IOleClientSite httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1138: Test failed: unexpected call sp_queryservice_SID_secmgr_xmldomdoc httpreq.c:1126: Test failed: unexpected call sp_queryservice_SID_SContainerDispatch_htmldoc2 httpreq.c:1131: Test failed: unexpected call sp_queryservice_SID_secmgr_htmldoc2 httpreq.c:498: Test failed: unexpected call htmldoc2_get_url httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/" === w864 (64 bit httpreq) === httpreq.c:1700: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n" httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9e4-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9e4-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {af0ff408-129d-4b20-91f0-02bd23d88352}, riid {af0ff408-129d-4b20-91f0-02bd23d88352} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9c1-baf9-11ce-8c82-00aa004ba90b}, riid {79eac9c1-baf9-11ce-8c82-00aa004ba90b} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4}, riid {4f9f9fcb-e0f4-48eb-b7ab-fa2ea9365cb4} httpreq.c:1171: Test failed: unexpected call site_qi_IServiceProvider httpreq.c:1151: Test failed: unexpected request: sid {79eac9d5-bafa-11ce-8c82-00aa004ba90b}, riid {79eac9d5-bafa-11ce-8c82-00aa004ba90b} httpreq.c:1725: Test failed: got response text L"<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>404 Not Found</title>\n</head><body>\n<h1>Not Found</h1>\n<p>The requested URL /tests/referer.php was not found on this server.</p>\n</body></html>\n", expected L"http://test.winehq.org/"

1 0

Re: [4/6] kernel32/tests: Fix communication port tests compilation with __WINESRC__ defined.
by Marvin Oct. 16, 2013

Oct. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2833 Your paranoid android. === w2008s64 (32 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:883: Test failed: WaitCommEvent error 0 comm.c:885: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:889: WaitCommEvent for EV_TXEMPTY took 1014 ms (timeout 1000) comm.c:891: Test failed: WaitCommEvent used 1014 ms for waiting comm.c:1558: test_AbortWaitCts timeout 500 handle 000000C4 comm.c:1525: Changing CommMask on the fly for handle 000000C4 after timeout 500

1 0

Re: [2/2] gdi32/tests: Enable gdi32 tests compilation with __WINESRC__ defined. Resend.
by Marvin Oct. 16, 2013

Oct. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2828 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: msctf/tests: Compile with -D__WINESRC__
by Marvin Oct. 16, 2013

Oct. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2822 Your paranoid android. === w864 (64 bit inputprocessor) === inputprocessor.c:791: Test failed: Deactivation came unexpectedly

1 0

Re: [PATCH] user32/tests: Skip desktop tests on NT4.
by Alexandre Julliard Oct. 16, 2013

Oct. 16, 2013

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so winstation.c && touch winstation.ok winstation.c:546: Test succeeded inside todo block: unexpected last error deadbeef winstation.c:549: Test failed: Skip tests on NT4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 02/11] crypt32: Don't use links to certs in memory store.
by Alexandre Julliard Oct. 16, 2013

Oct. 16, 2013

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/crypt32/cert.c | 159 > ++++++++++++++++++++++++----------------- > dlls/crypt32/collectionstore.c | 12 ++-- > dlls/crypt32/context.c | 4 +- > dlls/crypt32/crl.c | 7 +- > dlls/crypt32/crypt32_private.h | 22 +++--- > dlls/crypt32/ctl.c | 9 ++- > dlls/crypt32/provstore.c | 18 ++--- > dlls/crypt32/store.c | 17 +++-- > 8 files changed, 140 insertions(+), 108 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M cryptui.dll -p cryptui_test.exe.so cryptui.c && touch cryptui.ok wine: Unhandled page fault on read access to 0xfffffff0 at address 0x6865c543 (thread 005d), starting debugger... Unhandled exception: page fault on read access to 0xfffffff0 in 32-bit code (0x6865c543). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:6865c543 ESP:0032fab0 EBP:0032fac8 EFLAGS:00010297( R- -- I S -A-P-C) EAX:ffffffe8 EBX:686bb2fc ECX:00000000 EDX:0013ed38 ESI:0013ed70 EDI:00000001 Stack dump: 0x0032fab0: 00000005 0013eea0 0032fb68 686bb2fc 0x0032fac0: 686bb2fc 00000001 0032fb68 6864f122 0x0032fad0: 0013d6a8 00000000 00000000 0032fb2c 0x0032fae0: 00000000 00000000 0032fb38 6869a1af 0x0032faf0: 00000000 00020000 00000000 6865b7e0 0x0032fb00: 0032fb3c 0013ed50 0032fb38 6869a618 Backtrace: =>0 0x6865c543 Context_CopyProperties+0x43(to=0x13d6a8, from=0x0(nil)) [/home/julliard/wine/wine/dlls/crypt32/context.c:99] in crypt32 (0x0032fac8) 1 0x6864f122 add_cert_to_store+0x3e1(store=<couldn't compute location>, cert=<couldn't compute location>, add_disposition=<couldn't compute location>, use_link=<couldn't compute location>, ret_context=<couldn't compute location>) [/home/julliard/wine/wine/dlls/crypt32/cert.c:270] in crypt32 (0x0032fb68) 2 0x6864f37d CertAddCertificateContextToStore+0x9c(hCertStore=<couldn't compute location>, pCertContext=<couldn't compute location>, dwAddDisposition=<couldn't compute location>, ppStoreContext=<couldn't compute location>) [/home/julliard/wine/wine/dlls/crypt32/cert.c:288] in crypt32 (0x0032fbc8) 3 0x5557563b import_cert+0x14a() in cryptui (0x0032fc38) 4 0x555793ad CryptUIWizImport+0x10c() in cryptui (0x0032fc78) 5 0x6862a5e7 func_cryptui+0x4f6() [/home/julliard/wine/wine/dlls/cryptui/tests/cryptui.c:397] in cryptui_test (0x0032fcf8) 6 0x6862b675 run_test+0x144(name=<is not available>) [/home/julliard/wine/wine/dlls/cryptui/tests/../../../include/wine/test.h:570] in cryptui_test (0x0032fd48) 7 0x68629c23 main+0x152(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/cryptui/tests/../../../include/wine/test.h:640] in cryptui_test (0x0032fe08) 8 0x6862c0c0 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in cryptui_test (0x0032fe58) 9 0x7b85f38c call_process_entry+0xb() in kernel32 (0x0032fe78) 10 0x7b86056b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1085] in kernel32 (0x0032feb8) 11 0x7bc7fea0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 12 0x7bc82dad call_thread_func+0x7c(entry=0x7b860500, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2602] in ntdll (0x0032ffa8) 13 0x7bc7fe7e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 14 0x7bc54a2e start_process+0x1d(kernel_start=0x7b860500) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2697] in ntdll (0x0032ffe8) 15 0x6803128d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 16 0x6803134b wine_switch_to_stack+0x2a(func=0x7bc54a10, arg=0x7b860500, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xffb103b8) 17 0x7bc5a587 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2753] in ntdll (0xffb10428) 18 0x7b866ae0 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1257] in kernel32 (0xffb11338) 19 0x7bc5ac53 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2962] in ntdll (0xffb113c8) 20 0x6802eeda wine_init+0x2b9(argc=0x3, argv=0xffb11904, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:952] in libwine.so.1 (0xffb11428) 21 0x7bf00d3b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xffb11868) 22 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x6865c543 Context_CopyProperties+0x43 [/home/julliard/wine/wine/dlls/crypt32/context.c:99] in crypt32: movl 0xfffffff0(%ecx),%edx 99 while (ptr && ptr->linked) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/6] atl: Avoid duplicate debugging trace for same exported function names from different dlls.
by Alexandre Julliard Oct. 16, 2013

Oct. 16, 2013

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/atl/atl.spec | 6 +++--- > dlls/atl/atl_main.c | 9 +++++---- > 2 files changed, 8 insertions(+), 7 deletions(-) I'd suggest to simply print the version in the trace, instead of renaming all the functions. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH try3] atl110: Added new DLL.
by Qian Hong Oct. 16, 2013

Oct. 16, 2013

> +WINE_DEFAULT_DEBUG_CHANNEL(atl); Hi Jacek, we already have a debug channel atl100 for atl100.dll, but we currently use atl for both atl.dll and atl80.dll, do you think it is better to use atl for all, or one debug channel per each dll?

2 5

visual studio 2012 pdb support
by Роман Остриков Oct. 16, 2013

Oct. 16, 2013

Hello, dear developes Some times ago I have started porting some system to wine and was disappointed that application hangs. So I have began use dbghelp. I have faced with problem in supporting dpb files in wine which was generated by Visual Studio 2012. I have found an article: http://bugs.winehq.org/show_bug.cgi?id=835 where Dan Kegel public a series of fixes. But support was for VS2008 and post was dated by 2009-11-01. So may be this fix already included in Wine1.6 and debug symbols cant recognized by dbghelp due of another problem? Can anybody explain this? Best Reagrds

1 0

Video Mixing Renderer 7
by Michael Müller Oct. 16, 2013

Oct. 16, 2013

Hi, I am wondering what would be the best way to handle programs which rely on the Video Mixing Renderer 7 (quartz.dll) as it's supposed to be available on XP and later, but Wine contains only an implementation of version 9. The program I am speaking of is Silverlight which uses the VMR 7 Interface to create a filter graph and then queries for the IAMCertifiedOutputProtection interface. I am currently using a hack fix to get around this by returning a VMR9 instance when a VMR7 is requested and implementing the missing subinterfaces (which are only part of VMR7). This solution is clearly not perfect and I am searching for a better way to get around this issue. The most similar way to Windows would be to completely rewrite the current implementation of the VMR9 as VMR7 using DirectDraw, which would take a lot of time and most probably end up in having a lot of duplicate code. I am wondering whether using d3d9 for VMR7 would also be an acceptable solution. We could move all the d3d9 related stuff to a separate file so that VMR7.c and VMR9.c only offer the version specific interfaces and use the same code internally. This shouldn't be a big problem since the differences between the VMR7 and VMR9 interfaces are often only very small. Though it would not completely fit the behavior of windows. I am open for other ideas on how to solve the problem, but as Silverlight does not even use the VMR7 object for playing the video but only to check for the graphic driver certificate I don't think it would justify to rewrite everything using Direct Draw if there are no other programs needing this interface. Best Regards, Michael Müller

5 4

Re: notepad: Use BOOL type where appropriate (try 2)
by Alexandre Julliard Oct. 16, 2013

Oct. 16, 2013

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > try 2: Avoid changing SendMessage calls Dialog procedures return booleans too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: notepad: Use BOOL type where appropriate
by Alexandre Julliard Oct. 16, 2013

Oct. 16, 2013

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -298,7 +298,7 @@ static SAVE_STATUS DoSaveFile(LPCWSTR szFileName, ENCODING enc) > CloseHandle(hFile); > HeapFree(GetProcessHeap(), 0, pBytes); > > - SendMessageW(Globals.hEdit, EM_SETMODIFY, FALSE, 0); > + SendMessageW(Globals.hEdit, EM_SETMODIFY, 0, 0); Many messages use booleans, even if the actual type is a WPARAM. Please don't change them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dispex/tests: Compile with -D__WINESRC__
by Dmitry Timoshkov Oct. 16, 2013

Oct. 16, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + PeekMessageA(&msg, NULL, WM_USER, WM_USER, PM_NOREMOVE); IMHO it would be much better to use W version of APIs while doing this cleanup. Same applies to all other your patches that prepare switching compilation to using -D__WINESRC__. -- Dmitry.

2 1

Re: [10/10] gdi32/tests: Enable gdi32 tests compilation with __WINESRC__ defined.
by Marvin Oct. 16, 2013

Oct. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2808 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0