October 2013 - Wine-Devel - list.winehq.org

Re: [02/02] d3d8: update locked_rect only if wined3d_surface_map succeeds
by Henri Verbeet Oct. 23, 2013

Oct. 23, 2013

On 21 October 2013 10:47, Lasse Rasinen <lrasinen(a)iki.fi> wrote: > diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c > index 7932a7f..52cf27a 100644 > --- a/dlls/d3d8/tests/device.c > +++ b/dlls/d3d8/tests/device.c > @@ -4022,8 +4022,12 @@ static void test_lockrect_invalid(void) > > hr = IDirect3DSurface8_LockRect(surface, &locked_rect, NULL, 0); > ok(SUCCEEDED(hr), "Failed to lock surface with rect NULL, hr %#x.\n", hr); > + locked_rect.pBits = 0xdeadbeef; > + locked_rect.Pitch = 1; > hr = IDirect3DSurface8_LockRect(surface, &locked_rect, NULL, 0); > ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x.\n", hr); > + ok(locked_rect.pBits == 0xdeadbeef, "pBits changed on double lock.\n"); > + ok(locked_rect.Pitch == 1, "Pitch changed on double lock.\n"); > hr = IDirect3DSurface8_UnlockRect(surface); > ok(SUCCEEDED(hr), "Failed to unlock surface, hr %#x.\n", hr); > This test fails for me on Windows 7: device.c:4029: Test failed: pBits changed on double lock. device.c:4030: Test failed: Pitch changed on double lock. As an aside, if you had written the messages as "Got unexpected pBits %p.\n" and "Got unexpected Pitch %d.\n", you would have gotten the following output instead: device.c:4029: Test failed: Got unexpected pBits 00000000. device.c:4030: Test failed: Got unexpected Pitch 0.

3 6

Re: [20/23] user32/tests: Fix window tests compilation with __WINESRC__ defined.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2968 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000700E2 fg 00030040 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000701F6 fg 00010046 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000500F4 fg 0001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00090138 fg 00010066 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w864 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000601BA fg 00010084 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000500F4 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000090138 fg 0000000000010066 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000

1 0

Re: [18/23] user32/tests: Fix system parameters tests compilation with __WINESRC__ defined.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2966 Your paranoid android. === w864 (32 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 sysparams.c:2490: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2503: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (64 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 Timeout

1 0

Re: [10/23] user32/tests: Fix input tests compilation with __WINESRC__ defined.
by Saulius Krasuckas Oct. 23, 2013

Oct. 23, 2013

* On Wed, 23 Oct 2013, Dmitry Timoshkov wrote: > --- a/dlls/user32/tests/input.c > +++ b/dlls/user32/tests/input.c > @@ -929,7 +929,7 @@ static void test_Input_blackbox(void) > * key state set by SendInput(). */ > empty_message_queue(); > > - prevWndProc = SetWindowLongPtr(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > + prevWndProc = SetWindowLongPtrA(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > ok(prevWndProc != 0 || (prevWndProc == 0 && GetLastError() == 0), > "error: %d\n", (int) GetLastError()); > * On Fri, 8 Jun 2007, Saulius Krasuckas wrote: > --- a/dlls/user32/tests/input.c > +++ b/dlls/user32/tests/input.c > @@ -496,7 +496,7 @@ static void test_Input_blackbox(void) > * key state set by SendInput(). */ > empty_message_queue(); > > - prevWndProc = SetWindowLongPtr(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > + prevWndProc = SetWindowLongPtrA(window, GWLP_WNDPROC, (LONG_PTR) WndProc2); > ok(prevWndProc != 0 || (prevWndProc == 0 && GetLastError() == 0), > "error: %d\n", (int) GetLastError()); > It's nice to see the change is being offered by it's previous opponent six years later. Since Dmitry was strongly against it, questions go to him: * On Sat, 9 Jun 2007, Dmitry Timoshkov wrote: > "Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote: > > > Hello. I see some tests call [GS]etWindowLongPtr(..., GWLP_WNDPROC, > > ...). I think this is somewhat confusing. API offers both A- an W- > > versions of this function, while at my first glance I cannot firmly > > decide, what used name does refer to. > > > > Shouldn't occurences be renamed to ...WindowLongPtrA() here (or even > > all occurrences {by not requiring second parameter == GWLP_WNDPROC}) ? > > > > Same question stands for [GS]etWindowLong(). > > The code is correct as it is now, there is no need to change anything. Dmitry, what has changed since? (now that every test subdir is being migrated to compile with __WINESRC__) > > Did that restrict us from using single naming scheme? > > Personally I don't see any point in that. The tests are not forced to > use A/W API suffixes, that's done on purpose. Is the purpose gone now? S.

2 1

Re: [07/23] user32/tests: Fix DDE tests compilation with __WINESRC__ defined.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2955 Your paranoid android. === w864 (64 bit dde) === Timeout

1 0

Re: [02/23] user32/tests: Fix class tests compilation with __WINESRC__ defined.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2950 Your paranoid android. === w864 (32 bit class) === class.c:692: Test failed: Windows should be Unicode

1 0

Re: [01/23] user32/tests: Fix broadcast tests compilation with __WINESRC__ defined.
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2949 Your paranoid android. === w864 (64 bit broadcast) === The test timed out

1 0

Re: comdlg32/tests: Use BOOL type where appropriate
by Marvin Oct. 23, 2013

Oct. 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2943 Your paranoid android. === w2008s64 (64 bit filedlg) === No test summary line found

1 0

Re: [PATCH 5/6] user32/tests: Test SetUserObjectInformation for invisible winstation.
by Marvin Oct. 22, 2013

Oct. 22, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2941 Your paranoid android. === w2008s64 (32 bit winstation) === winstation.c:927: Test failed: unexpected foreground window 0001004E

1 0

Mono Update
by Alistair Leslie-Hughes Oct. 22, 2013

Oct. 22, 2013

Hi, wine-mono hasn't been updated in nearly a year. Should it be time to consider a new release? Thoughts. Best Regards Alistair Leslie-Hughes

2 2