November 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] advapi32: HKCR merge: foundation
by George Stephanos Nov. 8, 2013

Nov. 8, 2013

I've done what you asked. I avoided the extra level of pointers and there's a new array now that contains indexes of free slots in the handle table. Creating and closing handles is now done in constant complexity (and reallocation on the other hand is linear). Commit line changed as per Andre's suggestion and critical sections are tighter. Patch attached.

1 0

Re: How to undo authors list generated automatically.
by Tae Wong Nov. 8, 2013

Nov. 8, 2013

You want to revert commit 5da31c8817293ff98b4defceb962f7d0fbc25829. It restores the authors list to the one in rough alphabetical order by last name. This is the command you'll want to use: “git revert 5da31c8817293ff98b4defceb962f7d0fbc25829” Here's a good reason for reverting the commit: “Revert commit 5da31c8817293ff98b4defceb962f7d0fbc25829.” You (seotaewong40) are banned in Mozilla Bugzilla bug tracking system for repeatedly making inaccurate statements. See Bug 594788, Comment 44 for more details. How do you remove your ban to Mozilla Bugzilla bug tracking system?

1 2

Re: rpcrt4: Compile tests with -D__WINESRC__.
by Marvin Nov. 8, 2013

Nov. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3281 Your paranoid android. === w864 (64 bit cstub) === cstub: unhandled exception c0000005 at 000007F93B0B9B2F === w8 (32 bit server) === server.c:953: Test failed: get_ranged_enum() returned 3145731 instead of RE3 === w864 (32 bit server) === server.c:953: Test failed: get_ranged_enum() returned 1970077699 instead of RE3 server.c:953: Test failed: get_ranged_enum() returned 9175043 instead of RE3 server.c:953: Test failed: get_ranged_enum() returned 5701635 instead of RE3 === w864 (64 bit server) === server.c:953: Test failed: get_ranged_enum() returned 6291459 instead of RE3 server.c:953: Test failed: get_ranged_enum() returned 6488067 instead of RE3 server.c:953: Test failed: get_ranged_enum() returned 6029315 instead of RE3

1 0

Re: shell32/tests: Add tests for SHFileOperationA
by Alexandre Julliard Nov. 8, 2013

Nov. 8, 2013

Zhenbo Li <litimetal(a)gmail.com> writes: > --- > dlls/shell32/tests/shlfileop.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M shell32.dll -p shell32_test.exe.so shlfileop.c && touch shlfileop.ok shlfileop.c:640: Test failed: Expected test1.txt to exist make: *** [shlfileop.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] kernel32: use ANSI code page if current thread locale is (try 5)
by Marvin Nov. 8, 2013

Nov. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3270 Your paranoid android. === w2008s64 (64 bit codepage) === codepage.c:550: Test failed: GetLastError() is 87 for lcid 0439

1 0

Re: ws2_32/tests: Enable compilation with -D__WINESRC__ (try 2)
by Marvin Nov. 8, 2013

Nov. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3269 Your paranoid android. === wxppro (32 bit sock) === sock.c:520: Test failed: oob_server (6a4): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:520: Test failed: oob_server (7a4): unexpectedly at the OOB mark: 0 === w864 (32 bit sock) === sock.c:1741: Test failed: sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1741: Test failed: getservbyname could not retrieve information for telnet: 11004 === w2008s64 (64 bit sock) === sock.c:520: Test failed: oob_server (744): unexpectedly at the OOB mark: 0

1 0

Re: ws2_32/tests: Enable compilation with -D__WINESRC__
by Marvin Nov. 8, 2013

Nov. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3268 Your paranoid android. === wxppro (32 bit sock) === sock.c:520: Test failed: oob_server (6d4): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:520: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 757C9799 === w2008s64 (64 bit sock) === sock.c:520: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 No test summary line found

1 0

Re: [PATCH 7/7] comctl32/tests: Make propsheet.c compile with -D__WINESRC__.
by Marvin Nov. 7, 2013

Nov. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3261 Your paranoid android. === wvista (32 bit propsheet) === propsheet.c:548: Test failed: The Add button has not been pressed! propsheet.c:749: Test failed: property sheet with custom window proc: the msg 0x001c was expected, but got msg 0x0047 instead === w2008s64 (32 bit propsheet) === propsheet.c:548: Test failed: The Add button has not been pressed! === w7pro64 (32 bit propsheet) === propsheet.c:548: Test failed: The Add button has not been pressed! propsheet.c:749: Test failed: property sheet with custom window proc: the msg 0x001c was expected, but got msg 0x0047 instead === w864 (32 bit propsheet) === propsheet.c:548: Test failed: The Add button has not been pressed! propsheet.c:749: Test failed: property sheet with custom window proc: the msg 0x001c was expected, but got msg 0x0047 instead === w2008s64 (64 bit propsheet) === propsheet.c:548: Test failed: The Add button has not been pressed! === w7pro64 (64 bit propsheet) === propsheet.c:548: Test failed: The Add button has not been pressed! propsheet.c:749: Test failed: property sheet with custom window proc: the msg 0x001c was expected, but got msg 0x0047 instead === w864 (64 bit propsheet) === propsheet.c:548: Test failed: The Add button has not been pressed! propsheet.c:749: Test failed: property sheet with custom window proc: the msg 0x001c was expected, but got msg 0x0047 instead

1 0

Re: [PATCH 5/7] comctl32/tests: Make tooltips.c compile with -D__WINESRC__.
by Marvin Nov. 7, 2013

Nov. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3259 Your paranoid android. === wxppro (32 bit tooltips) === tooltips.c:423: Test failed: Adding the tool to the tooltip failed === wvista (32 bit tooltips) === tooltips.c:423: Test failed: Adding the tool to the tooltip failed === w2008s64 (32 bit tooltips) === tooltips.c:423: Test failed: Adding the tool to the tooltip failed === w7pro64 (32 bit tooltips) === tooltips.c:423: Test failed: Adding the tool to the tooltip failed === w8 (32 bit tooltips) === tooltips.c:423: Test failed: Adding the tool to the tooltip failed === w864 (32 bit tooltips) === tooltips.c:423: Test failed: Adding the tool to the tooltip failed === w2008s64 (64 bit tooltips) === tooltips.c:423: Test failed: Adding the tool to the tooltip failed === w7pro64 (64 bit tooltips) === tooltips.c:423: Test failed: Adding the tool to the tooltip failed === w864 (64 bit tooltips) === tooltips.c:423: Test failed: Adding the tool to the tooltip failed

1 0

Re: Assorted spelling fixes
by Marvin Nov. 7, 2013

Nov. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3253 Your paranoid android. === w2008s64 (32 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:882: Test failed: WaitCommEvent error 0 comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:887: WaitCommEvent for EV_TXEMPTY took 1513 ms (timeout 1500) comm.c:888: Test failed: WaitCommEvent used 1513 ms for waiting comm.c:1553: test_AbortWaitCts timeout 500 handle 000000C4 comm.c:1520: Changing CommMask on the fly for handle 000000C4 after timeout 500

1 0

Re: kernel32: use ANSI code page if current thread locale has no code page (try 4)
by Alexandre Julliard Nov. 7, 2013

Nov. 7, 2013

Daniel Lehman <dlehman(a)esri.com> writes: > + for (i = 0; i < sizeof(lcids)/sizeof(lcids[0]); i++) > + { > + SetThreadLocale(lcids[i].lcid); > + > + GetLocaleInfoA(lcids[i].lcid, LOCALE_IDEFAULTANSICODEPAGE|LOCALE_RETURN_NUMBER, (LPSTR)&cp, sizeof(cp)); > + ok(cp == lcids[i].defacp, "wrong codepage %i for lcid %04x, should be %04x\n", cp, lcids[i].defacp, cp); > + > + /* GetCPInfoEx/GetCPInfo - CP_ACP */ > + memset(&cpi, 0, sizeof(cpi)); > + GetCPInfoExA(CP_ACP, 0, &cpi); > + ok(cpi.CodePage == 1252 /* ANSI Latin 1 */, "wrong codepage %i for lcid %04x, should be 1252\n", > + cpi.CodePage, lcids[i].lcid); This should be checked against the current locale, there's no reason that it would always be 1252. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet: Check if connection is alive before sending request.
by Marvin Nov. 6, 2013

Nov. 6, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3250 Your paranoid android. === w2008s64 (64 bit http) === http.c:3520: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3520: Test failed: HttpQueryInfo failed 0

1 0

Re: [1/2] msctf/tests: Always set focus again explicitly for Win7+
by Marvin Nov. 6, 2013

Nov. 6, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3245 Your paranoid android. === w864 (64 bit inputprocessor) === inputprocessor.c:791: Test failed: Deactivation came unexpectedly

1 0

Re: [PATCH 3/3] ws2_32: Add an interactive test for interface change notifications.
by Marvin Nov. 6, 2013

Nov. 6, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3242 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (764): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (7a4): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 757C9799 === w7pro64 (32 bit sock) === sock.c:528: Test failed: oob_server (968): not at the OOB mark: 1 === w864 (32 bit sock) === sock.c:1740: Test failed: sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (744): unexpectedly at the OOB mark: 0 No test summary line found === w7pro64 (64 bit sock) === sock.c:528: Test failed: oob_server (968): not at the OOB mark: 1 === w864 (64 bit sock) === sock.c:1740: Test failed: sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004

1 0

Re: [PATCH 2/2] jscript: Improved error handling in numeric literal parser.
by Marvin Nov. 6, 2013

Nov. 6, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3231 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] jscript: Added support for octal literals.
by Marvin Nov. 6, 2013

Nov. 6, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3230 Your paranoid android. === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Re: [2/2] user32/tests: Use BOOL type where appropriate
by Marvin Nov. 6, 2013

Nov. 6, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3223 Your paranoid android. === w8 (32 bit msg) === msg.c:8363: Test failed: did not get expected count for minimum timeout (54 != ~64). === w8 (32 bit sysparams) === sysparams.c:2790: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2792: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 sysparams.c:2488: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2501: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:2790: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2792: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 sysparams.c:2488: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2501: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (64 bit sysparams) === sysparams.c:2790: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2792: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784

1 0

Re: [1/2] user32/tests: Check return code from call to SystemParametersInfo
by Marvin Nov. 6, 2013

Nov. 6, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3222 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 sysparams.c:2490: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2503: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784 sysparams.c:2490: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2503: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (64 bit sysparams) === sysparams.c:2792: Test failed: GetSystemMetrics(SM_CXMAXTRACK): expected 1044 or 1036 actual 1040 sysparams.c:2794: Test failed: GetSystemMetrics(SM_CYMAXTRACK): expected 788 or 780 actual 784

1 0

Re: [2/2] ntdll: Enable compilation with -D__WINESRC__
by Marvin Nov. 6, 2013

Nov. 6, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3218 Your paranoid android. === w2008s64 (64 bit port) === port.c:186: Test failed: Expected STATUS_SUCCESS, got c0000005 Timeout === w7pro64 (64 bit port) === port.c:186: Test failed: Expected STATUS_SUCCESS, got c0000005 Timeout

1 0

Re: [PATCH] user32: fixed sizeof() to MultiByteToWideChar
by Marvin Nov. 5, 2013

Nov. 5, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3217 Your paranoid android. === w864 (32 bit class) === class.c:690: Test failed: Windows should be Unicode

1 0

Re: kernel32: use ANSI code page if current thread locale has no code page (try 3)
by Alexandre Julliard Nov. 5, 2013

Nov. 5, 2013

Daniel Lehman <dlehman(a)esri.com> writes: > +static void test_threadcp(void) > +{ > + CPINFOEXA cpi; > + int i, ret; > + UINT cp; > + LCID last; > + struct test > + { > + LCID lcid; > + UINT defacp; > + UINT threadcp; > + } lcids[] = > + { > + { 0x0409 /* 1033 - English - United States */, 1252, 1252 /* ANSI Latin 1 */}, > + { 0x0439 /* 1081 - Hindi - India */, 0 /* None */, 1252 /* ANSI Latin 1 */}, > + { 0x0419 /* 1049 - Russian - Russia */, 1251, 1251 /* ANSI Cyrillic */}, > + { 0x0411 /* 1041 - Japanese - Japan */, 932, 932 /* Shift-JIS */} > + }; > + > + last = GetThreadLocale(); > + > + for (i = 0; i < sizeof(lcids)/sizeof(lcids[0]); i++) > + { > + SetThreadLocale(lcids[i].lcid); > + > + GetLocaleInfoA(lcids[i].lcid, LOCALE_IDEFAULTANSICODEPAGE|LOCALE_RETURN_NUMBER, (LPSTR)&cp, sizeof(cp)); > + ok(cp == lcids[i].defacp, "wrong codepage %i for lcid %04x, should be %04x\n", cp, lcids[i].defacp, cp); > + > + memset(&cpi, 0, sizeof(cpi)); > + GetCPInfoExA(CP_ACP, 0, &cpi); > + ok(cpi.CodePage == 1252 /* ANSI Latin 1 */, "wrong codepage %i for lcid %04x, should be 1252\n", > + cpi.CodePage, lcids[i].lcid); > + > + SetLastError(0xdeadbeef); > + ret = WideCharToMultiByte(CP_ACP, 0, foobarW, -1, NULL, 0, NULL, NULL); > + ok(ret == 7, "ret is %d (%04x)\n", ret, lcids[i].lcid); > + ok(GetLastError() == 0xdeadbeef, "GetLastError() is %u (%04x)\n", GetLastError(), lcids[i].lcid); > + > + GetCPInfoExA(CP_THREAD_ACP, 0, &cpi); > + ok(cpi.CodePage == lcids[i].threadcp, "wrong codepage %i for lcid %04x, should be %i\n", > + cpi.CodePage, lcids[i].lcid, lcids[i].threadcp); > + > + SetLastError(0xdeadbeef); > + ret = WideCharToMultiByte(CP_THREAD_ACP, 0, foobarW, -1, NULL, 0, NULL, NULL); > + ok(ret == 7, "ret is %d (%04x)\n", ret, lcids[i].lcid); > + ok(GetLastError() == 0xdeadbeef, "GetLastError() is %u (%04x)\n", GetLastError(), lcids[i].lcid); > + } > + > + SetThreadLocale(last); That's better, but you should use appropriate constants for the locale ids, and test the other functions that use get_codepage_table to make sure the behavior is common to all of them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt/tests: Enable compilation with -D__WINESRC__
by Marvin Nov. 5, 2013

Nov. 5, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3213 Your paranoid android. === wxppro (32 bit file) === file.c:1417: Test failed: bad position 0 expecting 8 file.c:1419: Test failed: Couldn't read back the data file.c:1987: Test failed: i 0, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '' file.c:1987: Test failed: i 1, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '' file.c:1987: Test failed: i 2, got 0 file.c:1990: Test failed: expected to read 'Hello world', got '' file.c:2024: Test failed: fread() returned 0: ferror=0 file.c:2027: Test failed: got '' expected 'Hello worldHello worldHello world'

1 0

How to undo authors list generated automatically.
by Tae Wong Nov. 4, 2013

Nov. 4, 2013

How to undo the commit: 5da31c8817293ff98b4defceb962f7d0fbc25829: AUTHORS: Regenerate the authors list from git using a .mailmap file.? It's generated automatically causing word spaces and diacritics to be ignored.

1 0

Re: kernel32: use ANSI code page if current thread locale has no code page (try 2)
by Alexandre Julliard Nov. 4, 2013

Nov. 4, 2013

Daniel Lehman <dlehman(a)esri.com> writes: > @@ -394,10 +398,48 @@ static void test_undefined_byte_char(void) > } > } > > +static void test_unicode_only(void) > +{ > + LCID last; > + BOOL ret; > + > + if (!pSetThreadLocale || !pGetThreadLocale) > + { > + win_skip("SetThreadLocale and/or GetThreadLocale not found\n"); > + return; > + } > + > + if (!IsValidCodePage(1081)) /* Hindi_India */ > + { > + skip("Codepage 1081 not available\n"); > + return; > + } > + > + last = pGetThreadLocale(); > + > + pSetThreadLocale(1252); > + SetLastError(0xdeadbeef); > + ret = WideCharToMultiByte(1081, 0, foobarW, -1, NULL, 0, NULL, NULL); > + ok(ret == 7, "ret is %d\n", ret); > + ok(GetLastError() == 0xdeadbeef, "GetLastError() is %u\n", GetLastError()); This doesn't make any sense. 1081 is not a codepage, and 1252 is not a locale. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Fwd: msvcr: Implemented _chsize_s
by Alexandre Julliard Nov. 4, 2013

Nov. 4, 2013

Andrey Zhezherun <zhezherun(a)yandex.ru> writes: > On 1 November 2013 09:37, Piotr Caban <piotr.caban(a)gmail.com> wrote: >> On 11/01/13 00:40, Andrey Zhezherun wrote: >>> +__int64 __cdecl _chsize_s(int,__int64); >> There should be int (or errno_t) instead of __int64. > Fixed, revised patch is attached. > > Regards, > Andrey > > --- wine-1.7.5.orig/dlls/crtdll/crtdll.spec 2013-10-25 18:45:30.000000000 +0100 > +++ wine-1.7.5/dlls/crtdll/crtdll.spec 2013-10-30 11:09:56.000000000 +0000 > @@ -58,6 +58,7 @@ > @ cdecl _chgsign(double) msvcrt._chgsign > @ cdecl _chmod(str long) msvcrt._chmod > @ cdecl _chsize(long long) msvcrt._chsize > +@ cdecl _chsize_s(long int64) msvcrt._chsize_s > @ cdecl _clearfp() msvcrt._clearfp > @ cdecl _close(long) msvcrt._close > @ cdecl _commit(long) msvcrt._commit It's not exported in old dlls, you shouldn't be adding it. -- Alexandre Julliard julliard(a)winehq.org

1 0

using mono dll components on wine(C#)
by 中川祥 Nov. 4, 2013

Nov. 4, 2013

I do not know how to use COM classes on wine lib,for example , System.dll wine dlls should be written by C,but I found many .Net methods equivalent to Win32 APIs. Isn't it good idea?

2 1

Re: [PATCH 3/3] winmm/tests: Compile with -D__WINESRC__
by Marvin Nov. 3, 2013

Nov. 3, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3187 Your paranoid android. === wxppro (32 bit mci) === mci.c:1212: Test failed: mci status "C:\Documents and Settings\winetest\My Documents\tempfile.wav" mode returned MCIERR_INVALID_DEVICE_NAME mci.c:1277: Test failed: mci re-auto-open status mode returned MCIERR_INVALID_DEVICE_NAME mci.c:1293: Test failed: mci auto-open pause returned MCIERR_INVALID_DEVICE_NAME === wvista (32 bit mci) === mci.c:989: Test failed: 395ms is not in the expected 400-600ms range mci.c:996: Test failed: 395ms is not even in the expected 400-1000ms range === w8 (32 bit mci) === mci.c:1123: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close) === w7pro64 (64 bit mci) === mci.c:989: Test failed: 389ms is not in the expected 400-600ms range mci.c:996: Test failed: 389ms is not even in the expected 400-1000ms range

1 0

Re: msvcr: Implemented _chsize_s
by Piotr Caban Nov. 3, 2013

Nov. 3, 2013

On 11/01/13 00:40, Andrey Zhezherun wrote: > --- wine-1.7.5.orig/include/msvcrt/io.h 2013-10-25 18:45:30.000000000 +0100 > +++ wine-1.7.5/include/msvcrt/io.h 2013-10-30 11:34:59.000000000 +0000 > @@ -87,6 +87,7 @@ > int __cdecl _access(const char*,int); > int __cdecl _chmod(const char*,int); > int __cdecl _chsize(int,__msvcrt_ulong); > +__int64 __cdecl _chsize_s(int,__int64); > int __cdecl _close(int); > int __cdecl _commit(int); > int __cdecl _creat(const char*,int); There should be int (or errno_t) instead of __int64.

2 2

Re: msvcp: fixed complex division
by Andrey Zhezherun Nov. 3, 2013

Nov. 3, 2013

On 1 November 2013 10:40, Piotr Caban <piotr.caban(a)gmail.com> wrote: > How about making it more numerically safe? Makes sense, although I checked what libstdc++ does and it has the vanilla version, similar to what I had before. Not sure what the native msvcp does though. A revised patch is attached. Regards, Andrey

1 0

Re: msvcr: Added _crt_debugger_hook function
by Piotr Caban Nov. 3, 2013

Nov. 3, 2013

On 11/01/13 00:41, Andrey Zhezherun wrote: > +/********************************************************************* > + * _crt_debugger_hook (MSVCRT.@) > + */ > +void CDECL MSVCRT__crt_debugger_hook(int reserved) > +{ > + TRACE(""); > +} The trace needs to end with '\n' character. Probably it's better to use ERR or FIXME here. Why do you need this function? In all cases I've seen the function was called only when the application was working incorrectly. Cheers, Piotr

2 1

Re: d3d9/tests: add check for D3DFMT_V8U8 support to avoid possible test crash.
by Stefan Dösinger Nov. 3, 2013

Nov. 3, 2013

On which GPU does that occur? Pixel Shader 1.x mandates V8U8 support afaik, so I am surprised this happens. I’m not opposed to this change conceptually though. > + IDirect3D9_Release(d3d9); > + if(FAILED(hr)) { > + skip("D3DFMT_V8U8 not supported\n"); > + return; > + } Please watch the formatting. Add a space between if and (, and put the { on the next line. Yeah, I know, the existing code isn’t quite consistent :-( . Am 02.11.2013 um 07:23 schrieb Alexander Dorofeyev <alexd4(a)inbox.lv>: > --- > dlls/d3d9/tests/visual.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > > <0002-d3d9-tests-add-check-for-D3DFMT_V8U8-support-to-avoid-.txt>

2 1

Wineconf videos
by Stefan Dösinger Nov. 2, 2013

Nov. 2, 2013

Hi, A few months ago I prepared some video recordings from Wineconf. They are on Youtube, but were never announced properly. So I’m sending a mail to the list, better late than never. Here are the links: Keynote: https://www.youtube.com/watch?v=ZsG2xhtGIUI Vincent’s Mono Talk: https://www.youtube.com/watch?v=ZBO1B7E3B64 My 3D performance talk: https://www.youtube.com/watch?v=T4ACXvm2gbc The sound and video quality is not too great. Most of this was filmed with my compact camera or my laptop’s webcam, and sound was recorded with my phone lying on the presentation table. But I believe it is good enough to understand the contents of the talk and it didn’t interrupt the conference flow. Librin from #winehackers is preparing videos of the other talks: André and Vincent’s ARM talk, Rosanne’s wine for users talk and I believe the last one was Francois about the testbot. Cheers, Stefan

1 0

Re: [PATCH] vbscript/tests: Use a defined name for error code
by Marvin Nov. 2, 2013

Nov. 2, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3179 Your paranoid android. === w864 (64 bit createobj) === createobj.c:1011: Test failed: hres = 800a0046

1 0

Re: winex11.drv: Add TIMESTAMP to X clipboard TARGETS
by Alexandre Julliard Nov. 1, 2013

Nov. 1, 2013

Andrey Vostrikov <andrey.vostrikov(a)cogentembedded.com> writes: > + else if(event->target == x11drv_atom(TIMESTAMP)) /* Return event timestamp */ > + { > + /* TIMESTAMP selection request */ > + XChangeProperty(display, request, rprop, event->target, > + 32, PropModeReplace, (unsigned char*)&event->time, 1); That's not the correct timestamp. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH] mmdevapi/tests: Update some error values for Windows 8.1
by Marvin Nov. 1, 2013

Nov. 1, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3171 Your paranoid android. === wvista (32 bit render) === render.c:1205: Test failed: GetPosition failed: 00000001

1 0

Fwd: attention all projects: Google is discontinuing Google Checkout
by Jeremy White Nov. 1, 2013

Nov. 1, 2013

Anyone want to patch the web site to take down the Google checkout button? Cheers, Jeremy -------- Original Message -------- Subject: attention all projects: Google is discontinuing Google Checkout Resent-Date: Fri, 01 Nov 2013 10:19:59 -0400 Resent-From: bkuhn(a)ebb.org (Bradley M. Kuhn) Resent-To: project-reps(a)sfconservancy.org Date: Thu, 31 Oct 2013 15:01:52 -0400 From: Tony Sebro <tony(a)sfconservancy.org> To: project-reps(a)sfconservancy.org Hi, all: If you haven't heard, Google has announced that they will discontinue their Google Checkout payment service on November 20, 2013[1]. All Member Projects must remove any Google Checkout donation details (e.g., links, applets, etc.) from their website by November 13. You should also publish an announcement or blog post letting your respective communities know about the pending change. Once Google Checkout is discontinued, PayPal will be the only online payment service that Conservancy supports - at least, until we can find another suitable replacement. We're currently investigating other solutions for additional credit card donation processing, but each solution brings their own set of problems and flaws. If and when we're able to find another service, we'll make another announcement and send around the information necessary to collect donations via your Projects' respective websites. On a separate note: Conservancy has created [members-discuss], a new discussion list for cross-project issues, like this one. You can register here: https://lists.sfconservancy.org/mailman/listinfo/members-discuss Conservancy will still use the [project-reps] mailing list to send out org-wide announcements to all of our Projects. But, if you'd like to participate in discussions with your sister Projects, feel free to join and post to the [members-discuss] list. Thanks! Best, -Tony [1] http://support.google.com/checkout/sell/answer/3080449 -- Tony Sebro, General Counsel, Software Freedom Conservancy +1-212-461-3245 x11 tony(a)sfconservancy.org www.sfconservancy.org

2 1

Re: mscoree: Implement CreateInterface (try 2)
by Chris Wulff Nov. 1, 2013

Nov. 1, 2013

On Oct 1, 2013, at 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Reuse CLRCreateInterface for the time being. > > Changelog: > mscoree: Implement CreateInterface > > > Best Regards > Alistair Leslie-Hughes > <0001-Implement-CreateInterface.patch> >

1 0

Re: [PATCH] winex11: support GLX_MESA_swap_control for WGL_EXT_swap_control This patch allows disabling of vsync on MESA based drivers. Without this patch, we would use the broken GLX_SGI_swap_control extension, which doesn't support disabling vsync without GLX_EXT_swap_control.
by Chris Wulff Nov. 1, 2013

Nov. 1, 2013

On Sep 17, 2013, at 12:55 PM, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > --- > dlls/winex11.drv/opengl.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c > index 5ec33c8..e28302e 100644 > --- a/dlls/winex11.drv/opengl.c > +++ b/dlls/winex11.drv/opengl.c > @@ -258,7 +258,8 @@ enum glx_swap_control_method > { > GLX_SWAP_CONTROL_NONE, > GLX_SWAP_CONTROL_EXT, > - GLX_SWAP_CONTROL_SGI > + GLX_SWAP_CONTROL_SGI, > + GLX_SWAP_CONTROL_MESA > }; > > /* X context to associate a struct gl_drawable to an hwnd */ > @@ -404,6 +405,7 @@ static void (*pglXFreeMemoryNV)(GLvoid *pointer); > > /* MESA GLX Extensions */ > static void (*pglXCopySubBufferMESA)(Display *dpy, GLXDrawable drawable, int x, int y, int width, int height); > +static int (*pglXSwapIntervalMESA)(unsigned int interval); > > /* Standard OpenGL */ > static void (*pglFinish)(void); > @@ -650,6 +652,8 @@ static BOOL has_opengl(void) > LOAD_FUNCPTR(glXCreateContextAttribsARB); > /* EXT GLX Extension */ > LOAD_FUNCPTR(glXSwapIntervalEXT); > + /* MESA GLX Extension */ > + LOAD_FUNCPTR(glXSwapIntervalMESA); > /* SGI GLX Extension */ > LOAD_FUNCPTR(glXSwapIntervalSGI); > /* NV GLX Extension */ > @@ -2963,6 +2967,10 @@ static BOOL X11DRV_wglSwapIntervalEXT(int interval) > ret = !X11DRV_check_error(); > break; > > + case GLX_SWAP_CONTROL_MESA: > + ret = !pglXSwapIntervalMESA(interval); > + break; > + > case GLX_SWAP_CONTROL_SGI: > /* wglSwapIntervalEXT considers an interval value of zero to mean that > * vsync should be disabled, but glXSwapIntervalSGI considers such a > @@ -3146,6 +3154,10 @@ static void X11DRV_WineGL_LoadExtensions(void) > has_swap_control_tear = TRUE; > } > } > + else if (has_extension( WineGLInfo.glxExtensions, "GLX_MESA_swap_control")) > + { > + swap_control_method = GLX_SWAP_CONTROL_MESA; > + } > else if (has_extension( WineGLInfo.glxExtensions, "GLX_SGI_swap_control")) > { > swap_control_method = GLX_SWAP_CONTROL_SGI; > -- > 1.8.3.1 > > >

1 0

Re: msvcp: fixed complex division
by Piotr Caban Nov. 1, 2013

Nov. 1, 2013

On 11/01/13 00:44, Andrey Zhezherun wrote: > This patch implements complex division correctly. The existing > implementation did something else which is not division. How about making it more numerically safe? Something like this should do the job: if(|c|>=|d|) (a+ib)/(c+id) = ((a+b(d/c))+i(b-a(d/c)))/(c+d(d/c)) else (a+ib)/(c+id) = ((a(c/d)+b)+i(b(c/d)-a))/(c(c/d)+d) Thanks, Piotr

1 0

Re: mscoree: Implement CreateInterface (try 2)
by Chris Wulff Nov. 1, 2013

Nov. 1, 2013

On Oct 1, 2013, at 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Reuse CLRCreateInterface for the time being. > > Changelog: > mscoree: Implement CreateInterface > > > Best Regards > Alistair Leslie-Hughes > <0001-Implement-CreateInterface.patch> >

1 0

Re: mscoree: Implement CreateInterface (try 2)
by Chris Wulff Nov. 1, 2013

Nov. 1, 2013

On Oct 1, 2013, at 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Reuse CLRCreateInterface for the time being. > > Changelog: > mscoree: Implement CreateInterface > > > Best Regards > Alistair Leslie-Hughes > <0001-Implement-CreateInterface.patch> >

1 0

Re: mscoree: Implement CreateInterface (try 2)
by Chris Wulff Nov. 1, 2013

Nov. 1, 2013

On Oct 1, 2013, at 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Reuse CLRCreateInterface for the time being. > > Changelog: > mscoree: Implement CreateInterface > > > Best Regards > Alistair Leslie-Hughes > <0001-Implement-CreateInterface.patch> >

1 0

Re: mscoree: Implement CreateInterface (try 2)
by Chris Wulff Nov. 1, 2013

Nov. 1, 2013

On Oct 1, 2013, at 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Reuse CLRCreateInterface for the time being. > > Changelog: > mscoree: Implement CreateInterface > > > Best Regards > Alistair Leslie-Hughes > <0001-Implement-CreateInterface.patch> >

1 0

Re: include: Add interfaces ICLRMetaHostPolicy,ICLRDebugging
by Chris Wulff Nov. 1, 2013

Nov. 1, 2013

On Oct 1, 2013, at 10:51 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > include: Add interfaces ICLRMetaHostPolicy,ICLRDebugging > > > Best Regards > Alistair Leslie-Hughes > <0002-Add-interfaces-ICLRMetaHostPolicy-ICLRDebugging.patch> >

1 0

Re: include: Add interfaces ICLRMetaHostPolicy,ICLRDebugging
by Chris Wulff Nov. 1, 2013

Nov. 1, 2013

On Oct 1, 2013, at 10:51 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > include: Add interfaces ICLRMetaHostPolicy,ICLRDebugging > > > Best Regards > Alistair Leslie-Hughes > <0002-Add-interfaces-ICLRMetaHostPolicy-ICLRDebugging.patch> >

1 0

Re: mscoree: Implement CreateInterface (try 2)
by Chris Wulff Nov. 1, 2013

Nov. 1, 2013

On Oct 1, 2013, at 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Reuse CLRCreateInterface for the time being. > > Changelog: > mscoree: Implement CreateInterface > > > Best Regards > Alistair Leslie-Hughes > <0001-Implement-CreateInterface.patch> >

1 0

Re: mscoree: Implement CreateInterface (try 2)
by Chris Wulff Nov. 1, 2013

Nov. 1, 2013

On Oct 1, 2013, at 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Reuse CLRCreateInterface for the time being. > > Changelog: > mscoree: Implement CreateInterface > > > Best Regards > Alistair Leslie-Hughes > <0001-Implement-CreateInterface.patch> >

1 0

Re: winhttp/tests: Fix the test failure messages.
by Marvin Nov. 1, 2013

Nov. 1, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3165 Your paranoid android. === w8 (32 bit url) === url.c:465: Test failed: unexpected path: L"?" url.c:467: Test failed: unexpected extra info: L"?" url.c:468: Test failed: unexpected extra info length: 1

1 0

Re: kernel32/tests: Remove a couple of incorrect CreateFile() console tests.
by Marvin Nov. 1, 2013

Nov. 1, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3163 Your paranoid android. === w8 (32 bit console) === console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 18, got 00000144 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 20, got 00000154 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 21, got 00000150 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 22, got 0000014C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 23, got 00000158 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 24, got 0000015C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 25, got 00000160 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 26, got 00000164 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 28, got 00000168 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 29, got 0000016C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 30, got 00000170 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 31, got 00000174 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 32, got 00000178 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 33, got 0000017C console.c:1420: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1420: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1420: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1663: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1663: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1663: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 18, got 00000138 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 20, got 0000013C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 21, got 0000014C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 22, got 00000148 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 23, got 00000144 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 24, got 00000150 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 25, got 00000154 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 26, got 00000158 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 28, got 0000015C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 29, got 00000160 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 30, got 00000164 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 31, got 00000168 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 32, got 0000016C console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 33, got 00000170 console.c:1420: Test failed: [13] Expected output count to be 0, got 2003875511 console.c:1420: Test failed: [15] Expected output count to be 0, got 2003875511 console.c:1420: Test failed: [18] Expected output count to be 3735928559, got 2003875511 console.c:1663: Test failed: [13] Expected output count to be 0, got 2003875511 console.c:1663: Test failed: [15] Expected output count to be 0, got 2003875511 console.c:1663: Test failed: [18] Expected output count to be 3735928559, got 2003875511 === w864 (64 bit console) === console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 18, got 0000000000000054 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 20, got 0000000000000058 console.c:1113: Test failed: Expected OpenConsoleW to return INVALID_HANDLE_VALUE for index 23, got 0000000000000060

1 0

Re: winhttp: netconn_query_data_available() is not used anymore so remove it.
by Jacek Caban Nov. 1, 2013

Nov. 1, 2013

Hi Francois, On 11/01/13 10:34, Francois Gouget wrote: > --- > dlls/winhttp/net.c | 20 -------------------- > dlls/winhttp/winhttp_private.h | 1 - > 2 files changed, 21 deletions(-) > > diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c > index 6d9b82a..ac8ae56 100644 > --- a/dlls/winhttp/net.c > +++ b/dlls/winhttp/net.c > @@ -712,26 +712,6 @@ BOOL netconn_recv( netconn_t *conn, void *buf, size_t len, int flags, int *recvd > return TRUE; > } > > -BOOL netconn_query_data_available( netconn_t *conn, DWORD *available ) > -{ > -#ifdef FIONREAD > - int ret; > - ULONG unread; > -#endif > - *available = 0; > - if (!netconn_connected( conn )) return FALSE; > - > - if (conn->secure) > - { > - *available = conn->peek_len; > - return TRUE; > - } > -#ifdef FIONREAD > - if (!(ret = ioctlsocket( conn->socket, FIONREAD, &unread ))) *available = unread; > -#endif > - return TRUE; > -} > - I think we should use this function instead. I will send a patch. Jacek

1 0