March 2013 - Wine-Devel - list.winehq.org

Re: gdi32: Copy gamma ramp validation from winex11 to make it driver independent
by Dmitry Timoshkov March 21, 2013

March 21, 2013

André Hentschel <nerv(a)dawncrow.de> wrote: > - this was done for the mac driver > - i tried to follow the file-style, except of the original variable naming The ERRs should be downgraded to WARNs or even TRACEs, there is no point to loudly complain on application input. -- Dmitry.

1 0

[GSoC] My proposal for GSoC 2013
by Gediminas Jakutis March 21, 2013

March 21, 2013

Hello! My name is Gediminas Jakutis. I study Informatics Engineering [bachelor / undergraduate] at Kaunas University of Technology, second year. I wish to try out GSoC for the first time by helping to improve Wine. My primary programming language is C. I am self-taught in C, but I believe my knowledge is good enough. I am quite familiar with Wine - I use it and experiment with it for many years now. I am subscribed to and read wine-devel for more than a year. I browse through Wine's source code once in a while out of curiosity. Thus, I have some knowledge of its structure. Sadly, I have not written any patches for Wine yet. Mostly due to lack of confidence. For GSoC, I am suggesting my own idea. In case this idea is not good, I am open to changing it, thinking of a new one, or adopting one. My idea: I have noticed that Wine's virtual desktop feature is very limited - if the first program on a prefix starts without a virtual desktop, all programs launched during the same session also start without a VD, disregarding any VD settings and/or requests with environment variables. And vice versa - if the first program starts inside a VD, all other programs in that sessions start in the VD. Often, this can be worked around by using separate Wine prefixes. Yet sometimes, this workaround is not possible. A good example: steam and games that only run properly in a VD. This forces the user to start steam in a VD and makes steam itself unusable while a game is running, especially if the game does not support the steam overlay. I would like to fix this limitation and make it possible to properly choose to run different programs on one prefix with or without a VD regardless what was chosen to programs already running in that prefix. I can already see this requiring changes in the winecfg utility, by the way. In case this turns out to be too easy of a project, I could implement some way to perform "alt-tabbing" between programs in a VD and/or an optional (enable-able in winecfg) rudimentary taskbar for changing/checking focus. I am very excited about participating in GSoC. And even more excited about starting to contribute to Wine by writing patches! Regardless if I get accepted or not, I wish to make Wine better. Thus, expect me to start submitting patches in the future even if I do not get accepted. ;] Sincerely, Gediminas Jakutis ---- LDK Varčiai www.varciai.lt

3 3

Re: winemac: Implement GetDeviceGammaRamp() and SetDeviceGammaRamp().
by André Hentschel March 20, 2013

March 20, 2013

Am 18.03.2013 04:41, schrieb Ken Thomases: > --- > dlls/winemac.drv/display.c | 131 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/winemac.drv/gdi.c | 4 +- > dlls/winemac.drv/macdrv.h | 2 + > 3 files changed, 135 insertions(+), 2 deletions(-) Hi, wrt macdrv_SetDeviceGammaRamp, the X11 driver has some validation in xvidmode.c->ComputeGammaFromRamp() because windows doesn't allow every ramp. It might happen that apps try bad ramps and the screen simply gets dark without validation. I'll see if i can copy/move the validation to gdi32 where the driver function normally get's called so that the validation is driver independent. -- Best Regards, André Hentschel

2 1

Re: [PATCH 2/2] msvcrt: Fixed fgetwc behavior on multibyte characters and unicode files
by Akihiro Sagawa March 20, 2013

March 20, 2013

On Mon, 18 Mar 2013 17:11:04 +0100, Piotr Caban wrote: > + char mbs[2]; This should be a constant, like MSVCRT_MB_LEN_MAX. > + int len = 0; > + ch = MSVCRT_fgetc(file); > + if(ch != MSVCRT_EOF) { > + mbs[0] = (char)ch; > + if(MSVCRT_isleadbyte(mbs[0])) { This doesn't work correctly if char is signed. Because _isleadbyte() expects the value of unsigned char or EOF as well as other is- functions. I wrote some fgetwc() tests. Please refer following page: https://testbot.winehq.org/JobDetails.pl?Key=24806 Akihiro Sagawa

2 1

Re: [7/10] winemenubuilder: Create a basic Info.plist.
by Ken Thomases March 20, 2013

March 20, 2013

On Mar 17, 2013, at 12:18 PM, Per Johansson wrote: > + namestr = CFStringCreateWithCString(NULL, link_name, CFStringGetSystemEncoding()); You should use CFStringCreateWithFileSystemRepresentation() to create CFStrings from POSIX path strings. > + pathstr = CFStringCreateWithCString(NULL, path, CFStringGetSystemEncoding()); Same thing here. > + data = CFPropertyListCreateData(NULL, propertyList, format, 0, &err); Since you don't use "err", just pass NULL. -Ken

2 1

Re: [10/10] winemenubuilder: Put appbundle icon inside the bundle.
by Ken Thomases March 19, 2013

March 19, 2013

On Mar 17, 2013, at 12:18 PM, Per Johansson wrote: > + CFStringRef iconstr = CFStringCreateWithCString(NULL, icon, CFStringGetSystemEncoding()); Another place to use CFStringCreateWithFileSystemRepresentation(). -Ken

1 0

Re: msvcr110: add a stub for __crtGetShowWindowMode
by Dmitry Timoshkov March 18, 2013

March 18, 2013

Austin English <austinenglish(a)gmail.com> wrote: > +int CDECL __crtGetShowWindowMode(void) > +{ > + FIXME(": stub!\n"); > + return 0; > +} Isn't it supposed to return SW_SHOW and other SW_xxx commands, specified at process creation time (SW_SHOWDEFAULT)? In that case returning 0 (SW_HIDE) is not a very good choice. -- Dmitry.

1 0

Re: [0/10] Launcher app bundles on OS X
by C.W. Betts March 18, 2013

March 18, 2013

A quick glance at the source revealed that you removed static from some functions. Why? If a function isn't being called outside a source file, it's better to have it be static. This includes functions referenced in structs (but not the structs themselves). A more seasoned developer is welcome to correct me if I'm wrong. On Mar 17, 2013, at 11:18 AM, Per Johansson <per(a)morth.org> wrote: > I'm resending this now after testing it with the Mac driver. > They work well together, the launcher bundle will first briefly > appear in the dock, then exit, and the mac driver icon appears. > > It's split it up into parts for easier review. I've also tried > to make sure that even if e.g. part 6 fails review, part 1 - 5 > can still be applied. > > File type associations are not included because I plan to move > that code into the mac driver but haven't gotten around to it yet. > > Regards, > -- > Per Johansson > > >

2 1

Re: [website] Portuguese translation for release 1.5.25
by Bruno Jesus March 18, 2013

March 18, 2013

2013/3/18 Lucas Zawacki <lfzawacki(a)gmail.com>: > From: Lucas Zawacki <lfzawacki(a)gmail.com> > > --- > news/pt/2013030101.xml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 news/pt/2013030101.xml > > diff --git a/news/pt/2013030101.xml b/news/pt/2013030101.xml > new file mode 100644 > index 0000000..ae13cfd > --- /dev/null > +++ b/news/pt/2013030101.xml > @@ -0,0 +1,14 @@ > +<news> > +<date>1 de Março de 2013</date> > +<title>Wine 1.5.25 lançado</title> > +<body> > + A versão de desenvolvimento 1.5.25 já está disponível agora. > + <a href="{$root}/announce/1.5.25">Novidades</a> desta versão: > +<ul> > + <li>Suporte adequado ao cursor no driver de Mac.</li> > + <li>Correções no suporte a escrita direita-para-esquerda no RichEdit.</li> > + <li>Versão inicial da uma fonte Wingdings.</li> Should be: Versão inicial de uma fonte Wingdings. Or: Versão inicial da fonte Wingdings. > + <li>Várias correções de bugs.</li> > +O código fonte está <a href="http://prdownloads.sourceforge.net/wine/wine-1.5.25.tar.bz2">disponível agora</a>. > +Pacotes binários estão em processo de construção e irão aparecer em breve em suas respectivas <a href="{$root}/download">sessões da área de downloads</a>. > +</body></news> > -- > 1.7.9.5 > > > Best wishes, Bruno

2 1

Re: usp10: Support GPOS extension lookup subtables
by Aric Stewart March 18, 2013

March 18, 2013

Hi Phil, Thank you for being patient I am back from vacation and reviewing your patch. The logic looks great and just fine. Do you happen to have a font that uses lookup type 9 that I can run my usp test suite on to make sure it functions as expected? thanks! -aric On 3/8/13 10:47 AM, Phil Krylov wrote: > > > >

1 0

WineD3D performance
by Graham Knap March 18, 2013

March 18, 2013

Hi everyone I would like to try to help with improving the performance of StarCraft II on Wine. I'm working with a friend. Over the past couple of weeks, we have tried to read whatever documentation we could find. We have tried a couple of different approaches to profiling, without much success. My friend got WineD3D running on Windows. We built Wine from current source code, tested this on two different configurations, and got similar results. - my Core 2 E8500 + GeForce 9600GT + Windows XP x86 - his i5-2500 + GeForce 660 + Windows 7 x64 It looks like WineD3D is the cause of most of the performance difference. Windows with its own D3D gave us at least twice the frame rate of Windows + WineD3D. There is some difference between the numbers for Windows + WineD3D and Linux + Wine, but it's much smaller, i.e. something like 25%. Can anyone offer some hints on how to find the most significant causes of the performance difference? Any tips for effective profiling or tracing? Thanks. -- graham

2 2

Re: wined3d: add NVidia GeForce 315M
by Stefan Dösinger March 18, 2013

March 18, 2013

Am 17.03.2013 um 17:08 schrieb Daniel Jeliński <djelinski1(a)gmail.com>: > why can't we get these values from X? They are definitely present in > my Xorg.log. Propose a patch. A few notes though: *) The upcoming GLX_MESA_query_renderer extension will provide a good way to query this info. If this extension will be adopted by the binary drivers is an open question. *) The X.org log would be an extremely ugly way to read this info. The log is at an unknown place, might be readable only by root or might not exist at all. There format of the log messages might change. *) There are vendor specific X11, GLX and GL extensions to query some GPU info *) Wined3d should not deal with GLX_MESA_query_renderer or any other X11 specific things. This should be handled by winex11.drv. > {"GT 320M", CARD_NVIDIA_GEFORCE_GT320M}, /* Geforce 300 - midend mobile */ > + {"315M", CARD_NVIDIA_GEFORCE_315M}, /* Geforce 300 - midend mobile */ > {"320M", CARD_NVIDIA_GEFORCE_320M}, /* Geforce 300 - midend mobile */ Afaics this table is sorted in descending order, for consistency you should swap the 315M and 320M

2 1

Re: msxml3: Embed user/password to uri used to create a moniker (try2)
by Nikolay Sivov March 18, 2013

March 18, 2013

On 3/15/2013 21:43, Nikolay Sivov wrote: > try2: fixed builder leak > Please ignore this one, it removes too much, I have a better version.

1 0

Updating WineWiki Theme?
by Kyle Auble March 16, 2013

March 16, 2013

Hi everybody, Although my hiatus was longer than expected, I've been making progress with updating the wiki code over the past few days (spring break is a very good thing). My workflow is a bit non-linear so I want to sort my changes into patches first, but fingers-crossed, I'll be pushing them to my Bitbucket account by the weekend. I did want to ask for input on a few things: 1. Should we just keep Moinmoin's search, replace it with the custom Google search, or offer both? 2. How about the icon? I can get the standard WineHQ one to display fine, but I'm not sure about which approach to take. Essentially, do what's simplest for us, or should I make it play well with other themes too? 3. Finally, the credits are currently just text links. In the future though, if Dimi wanted to, we could have a "sponsored by Lattica" banner like the Codeweavers ones on the other pages. After I get the theme together & test it some more on different browsers, I can look into migrating the data to the newest Moinmoin version. -Kyle

3 4

Vacation
by Alexandre Julliard March 15, 2013

March 15, 2013

Folks, There won't be any commits next week, as I'll be out skiing... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] Make mac driver the default on OS X (try 2)
by Alexandre Julliard March 15, 2013

March 15, 2013

Josh DuBois <duboisj(a)codeweavers.com> writes: > Ken also noted that the error reporting could be simpler if it were in > gdi instead of user32. My impression, after having poked at it a > while with Ken, is that it is in theory possible that an application > which never tried to create a window would print less noise with the > errors being reported as they are here than it would if the errors > were reported directly from gdi, so that this may be superior because > it is quieter. However, I'm not an expert and if the rigamarole is > not worth the extra lines, I'm sure Alexandre will indicate so by not > applying this. It needs to be printed on window creation because of command line apps, but that's not a reason for doing something as ugly and complicated as this... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] atl100/tests: Added class name test for AtlAxWinInit.
by Alexandre Julliard March 15, 2013

March 15, 2013

Qian Hong <qhong(a)codeweavers.com> writes: > @@ -562,6 +562,34 @@ static void test_source_iface(void) > ok(maj_ver == 4 && min_ver == 0, "ver = %d.%d\n", maj_ver, min_ver); > } > > +static void test_ax_win(void) > +{ > + BOOL ret; > + WNDCLASSEXW wcex; > + static const WCHAR AtlAxWin100[] = {'A','t','l','A','x','W','i','n','1','0','0',0}; > + static const WCHAR AtlAxWinLic100[] = {'A','t','l','A','x','W','i','n','L','i','c','1','0','0',0}; > + static HMODULE huser32 = 0, hinstance = 0; > + static BOOL (WINAPI *pGetClassInfoExW)(HINSTANCE, LPCWSTR, WNDCLASSEXW *); > + > + huser32 = GetModuleHandleA("user32.dll"); > + pGetClassInfoExW= (void *)GetProcAddress(huser32, "GetClassInfoExW"); It's not useful to load this dynamically if you are not going to check that it was found. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: winmm: Fix notification when recording using MSACM.
by Alexandre Julliard March 15, 2013

March 15, 2013

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > To achieve this, we eliminate the tail call and turn it into a loop, > which allows us to preserve the local state in the variable "last". Please do this as a proper loop, not with a goto. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: mmdevapi: Prevent 64 bit overflow within a few days of audio device use. (try 3)
by Alexandre Julliard March 15, 2013

March 15, 2013

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > The only comments about v2 were Michael Stefaniuc > suggesting a refactoring and me explaining why > in this particular case, that would not be a good idea. > http://www.winehq.org/pipermail/wine-devel/2013-March/099068.html It's still a good idea, even if the function is ultimately used only in one place. > For v3, I've renamed MulDiv64 to UMulDiv64. Unlike QueryPerformanceCounter, > mmdevapi GetPosition operates on unsigned values. That's a bad name. Don't make internal functions look like Win32 APIs. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Aric Stewart : usp10: Update diacritical script handling for non OpenType Itemization.
by Phil Krylov March 14, 2013

March 14, 2013

Hello Aric, On Tue, Feb 5, 2013 at 11:25 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: ef4b7c5948e43d4ceeed98ba4ddbf6c222259d36 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=ef4b7c5948e43d4ceeed98ba4… > > Author: Aric Stewart <aric(a)codeweavers.com> > Date: Tue Feb 5 08:57:44 2013 -0600 > > usp10: Update diacritical script handling for non OpenType Itemization. (snip) > + for (j = i-1; j >= 0 && scripts[j] == first_script && pwcInChars[j] != Numeric_space; j--) > + { > + WORD original = scripts[j]; > + if (original == Script_Ideograph || original == Script_Kana || original == Script_Yi || original == Script_CJK_Han || original == Script_Bopomofo) > + { > + asian = TRUE; > + break; > + } > + if (original != Script_MathAlpha && scriptInformation[scripts[j]].props.fComplex) > + break; > + scripts[j] = scripts[i]; > + if (original == Script_Punctuation2) > + break; > + } > + if (scriptInformation[scripts[j]].props.fComplex || asian) > + scripts[i] = scripts[j]; I am not sure about the logic of this, so I can't commit a good patch, but in the last statement you definitely access scripts[-1] when j reaches the value of 0. Which may cause a crash here or (in my case) later. -- Ph.

2 2

RE: d3dx9 [patch 1/2]: Implement D3DXSHEvalSphericalLight
by Nozomi Kodama March 14, 2013

March 14, 2013

Hello Any problem with the patch http://source.winehq.org/patches/data/94777 and http://source.winehq.org/patches/data/94776 ? Nozomi.

2 2

Re: winegcc: Add support for -Ttext-segment linker flag to set image base of a dll. (try 2)
by André Hentschel March 14, 2013

March 14, 2013

Am 03.03.2013 16:58, schrieb Tijl Coosemans: > --- > README | 3 +++ > tools/winegcc/utils.h | 3 ++- > tools/winegcc/winegcc.c | 11 ++++++++++- > 3 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/README b/README > index 783e798..75aff5a 100644 > --- a/README > +++ b/README > @@ -40,6 +40,9 @@ support kernel threads may be supported in the future. > > FreeBSD info: > Wine will generally not work properly on versions before FreeBSD 7.0. > + You need GCC with GNU Binutils 2.20 or higher and run configure with > + environment variables like CC, CFLAGS, CXX, CXXFLAGS, CPP, CPPFLAGS, > + LD and LDFLAGS set correctly to use this compiler and linker. > See http://wiki.freebsd.org/Wine for more information. > Do you really need that? is there no script on freebsd to set the compiler toolchain or something? > > enum target_platform > { > - PLATFORM_UNSPECIFIED, PLATFORM_APPLE, PLATFORM_SOLARIS, PLATFORM_WINDOWS, PLATFORM_CYGWIN > + PLATFORM_UNSPECIFIED, PLATFORM_APPLE, PLATFORM_SOLARIS, PLATFORM_ELF, > + PLATFORM_WINDOWS, PLATFORM_CYGWIN > }; > You would rather call it PLATFORM_FREEBSD > + if (opts->image_base && !opts->target && opts->target_platform == PLATFORM_UNSPECIFIED) I'm in doubt here -- Best Regards, André Hentschel

3 5

Re: [PATCH 2/2] ole32: Don't pass CLSCTX_INPROC_SERVER and CLSCTX_INPROC_HANDLER flags to CoCreateInstance in DefaultHandler
by Marvin March 13, 2013

March 13, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24750 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: gdiplus: Ignore gdiplus page and world transformations when creating a gdi32 clipping region.
by Vincent Povirk March 13, 2013

March 13, 2013

I guess this makes sense, because having the clipping region change with transforms would be weird when drawing recursively and changing the transform. I had assumed clipping regions were in world coordinates because most things are, but I didn't really have any information either way.

1 0

Re: [PATCH 1/2] wined3d: Put local constants into the shader code again
by Henri Verbeet March 13, 2013

March 13, 2013

On 13 March 2013 02:19, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This provides a small GPU-side performance boost on dx10+ capable Nvidia > cards - about 5% in World of Tanks on my Geforce 9600, and more in a > dedicated test program. > > This is essentially a revert of cd7825c89374fb9dd4c20aef2dbfd258713efe6a, > with proper precision. > This is probably ok, although one concern is applications setting constants to e.g. NaN or infinity. It may be worth using ARB_shader_bit_encoding when available, or perhaps even only doing this when that extension is available.

2 1