March 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] wined3d: Put local constants into the shader code again
by Stefan Dösinger March 12, 2013

March 12, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-03-12 18:19, schrieb Stefan Dösinger: > The test program is available at > https://84.112.174.163/~git/perftest file const_gl/const_gl.cpp. My server is currently turned off (and I should move this to github or somewhere at some point), so I've attached the test program here for reference. Resolution and constant mode are hardcoded into it. Tab/space mixup thanks to Visual Studio. Compile the Linux version with g++ const_gl.cpp -o const_gl -lGL -lglut -lGLEW . A d3d version is attached as well. It does not load the same values when using the global constants, but this doesn't seem to affect performance. I haven't tested ARB shaders, but from the WoT results before and after patch 2, their behavior seems to be the same as GLSL and native d3d. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRP9WcAAoJEN0/YqbEcdMwdmoP/2LvEFpPpmTiZDzxqhp38WfU DKs2S8m1kP86fL55GwLtth289WC9MsQyOosOVOqt8r3YWZyckeisZyhdP2ez2KRV 9kgxMnEXwzcZBtmm/+nrl0FwJghy86AnZ0YJ9PpnCpY0k4VTQYjaWQALlyqtF+qm Uup4UE+m4yR4DoNL/u/161Zxh+OLOA8PXEhWWfDozNL/8yMlRfPs6gzLMN/oKTIL UMA90gesZWPt7/J2Bp0+OeZvMWqNa54A2akxsLvtxVP/rB8baym4iYLn5Y2IPXa2 lBqALc+POMcVk45FCgkzjUw5b/7ck9V5n0PKOw/9Jwrm8/ChHE4i0ZwGEmHzh3So y1d/KydwesYtyCadmlklgJy1J+CxyCd/fNVUmsNtpzDEo6OF7oEagvwBUlTnCdR9 W9B9lmpsDCuBIxEnAy7C3HEZ18o70HdoUsKe5hX8fVn5lnwFPWdp7hBA0nVbO0y0 Fybps006cQmc0Rm9nHJjeJ9JoGzl/iuSX0AnQ5fiJS6fS5RrrGAnFBEb1g2O879X pNSIgBdKUSSfGBoUZKKIy+GZzC+VhDm4UqhtSaYudlUB9pcoMDFYRGQ3Rk48kRuD tJ8Ah2VBYeFUvI+x4Xty9AtOwwFWYejNG+6cNNF3EOALz2JvhFKDEJCI0p7bdmgR XCfPxQyYN7+JGFw8JiO5 =RgiG -----END PGP SIGNATURE-----

1 0

Re: [PATCH] activeds: Exclude unused headers.
by Alexandre Julliard March 12, 2013

March 12, 2013

Amine Khaldi <amine.khaldi(a)reactos.org> writes: > @@ -28,13 +28,10 @@ > > #include "windef.h" > #include "winbase.h" > -#include "winuser.h" > > #include "objbase.h" > #include "iads.h" > -#include "adshlp.h" > > -#include "wine/unicode.h" > #include "wine/debug.h" It's not worth the trouble, particularly since the file ends up including windows.h anyway. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: ntdll: Make msync() asynchronous in NtFlushVirtualMemory (resubmit with real name)
by Alexandre Julliard March 11, 2013

March 11, 2013

Mathis Beer <default_357-line(a)yahoo.de> writes: > diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c > index a99bca4..e4f2bb6 100644 > --- a/dlls/ntdll/virtual.c > +++ b/dlls/ntdll/virtual.c > @@ -62,6 +62,10 @@ WINE_DECLARE_DEBUG_CHANNEL(module); > #define MS_SYNC 0 > #endif > > +#ifndef MS_ASYNC > +#define MS_ASYNC 1 > +#endif That's questionable, there's no reason the value would be 1. We defined MS_SYNC to 0 on the theory that it's better to pass 0 than making up values, but probably not calling the function at all would be preferable. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: msvcp60: Avoid signed-unsigned integer comparisons
by larmbr zhan March 11, 2013

March 11, 2013

On Sun, Mar 10, 2013 at 5:48 AM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > msvcp60: Avoid signed-unsigned integer comparisons. Hi, Andrew Talbot. I find that you are working on these "Avoid signed-unsigned integer comparisons" things recently. I DO agree on that using _ unsigned int _ instead of _ int _(which implies _ signed int _). But I think using size_t maybe more standard-compliant, more efficient, and less bug-prone, . To hold this, I think something has to be clarified... * The overflow behavior is instrinsic because the finite range that a object of INT type can hold. But It behaves different when it is signed or not. According to C Standard, - For the signed case, once it overflows, resulting in representing a negative value . - For the unsigned case, once it overflows, resulting in representing a value reduced modulo the largest value that object could hold. So see this example: --- snip --- size_t num = get_max_object_num(); // which may give a large number. unsigned int i; for ( i = 0; i < num; i++) something_important[i] = vital_evaluate_for(i); --- snip --- For this case, though we use unsinged int ,it still may issue problem if num >= UINT_MAX, which will cause i to wrap to 0, then something_important maybe assigned a invalid value, as like. This problem may occur if using in a 64-bit enviroment, where size_t is typeof 'ed unsigned 64bit while unsigned int is still 32-t wide. Some may argue that in Wine this problem will NEVER happen. I don't doubt it. But * since we have a cleared and more standard-compliant way (which means less bug-prone), and * predictably Wine will support more platforms, portable way shall be taken it account. So I think we should use size_t in this case. -- Cheers, Zhan JIanyu

4 3

Re: ntdll: make NtDelayExecution a bit more efficient
by Alexandre Julliard March 11, 2013

March 11, 2013

Graham <graham.knap(a)gmail.com> writes: > This patch is vaguely related to bug 24558. It eliminates a few > syscalls in NtDelayExecution: > > 1. If the caller requests a zero-wait yield, then do just that, and > nothing more. That's what the existing code already does. > 2. If you're about to block on select(), then I don't see any point in > preceding that with a call to sched_yield(). This was added for a reason; most likely you'll have to write tests. -- Alexandre Julliard julliard(a)winehq.org

7 7

Re: [2/2] wmvcore: Stub implementation of IWMMetadataEditor interface (try2)
by Nikolay Sivov March 11, 2013

March 11, 2013

On 3/11/2013 16:36, Jeff Latimer wrote: > + if (!ppv) return E_INVALIDARG; You don't need this most likely. > + IUnknown_AddRef((IUnknown*)*ppv); A cleaner way is to AddRef original iface, but that's a matter of taste. > +static ULONG WINAPI WMCreateEditor_AddRef(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + return 2; > +} > + > +static ULONG WINAPI WMCreateEditor_Release(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return 1; > +} What's this supposed to mean? > +HRESULT WINAPI WMCreateEditor_flush(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} > + > +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} I don't think so. > HRESULT WINAPI WMCreateEditor(IWMMetadataEditor **editor) > { > + IWMMetadataEditor *This; > FIXME("(%p): stub\n", editor); > > - *editor = NULL; > + This = HeapAlloc(GetProcessHeap(), 0, sizeof(IWMMetadataEditor)); > + if (!This) return E_OUTOFMEMORY; > > - return E_NOTIMPL; > + This->lpVtbl = &Editor_vtable; > + *editor = This; > + > + return S_OK; > } That's not how it's done, there's plenty of examples already. > -}; > +} That change is ok I think.

1 0

Re: [1/2] include: Implement part of nserror.h
by Nikolay Sivov March 11, 2013

March 11, 2013

On 3/11/2013 10:27, Jeff Latimer wrote: > --- > include/nserror.h | 226 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 226 insertions(+) > create mode 100644 include/nserror.h > +#ifndef _NSERROR_H > +#define _NSERROR_H This doesn't look right. > +#define NS_S_CALLPENDING_HRESULT_TYPEDEF_(0x000D0000L) This is usually done with a suffix. > + > +#endif Please add a comment here.

2 2

Re: wininet: Skip test_open_url_async on IEs older than 7.
by Marvin March 9, 2013

March 9, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24685 Your paranoid android. === WVISTAADM (32 bit http) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: dpnet/tests: Allow buffersize used by Win8
by Marvin March 9, 2013

March 9, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24682 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF

1 0

Crash confuses me
by Graham March 9, 2013

March 9, 2013

I use a LD_PRELOAD before running wine so that i can debug my application. The library which is preloaded is able to replace system dlsym and from that, other consequence library call. There is no problem until, i put some Detour code(hot patching) into the kernel32.dll.so address space. But the very funny things is this ** THE PROGRAM CRASHES BEFORE MY HOTPATCH IS APPLIED ** so it seems somehow the order of cause and effect is extremely weird and frightening to me. How can a piece of code which is not excecuted be teh cause for errors PRIOR/BEFORE to its execution. And this is surely happening because when i uncomment the Hotpatch/detour lines the problem goes away. here are some lines from the crashs ... err:module:attach_process_dlls "user32.dll" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"C:\\windows\\system32\\winemenubuilder.exe" failed, status c0000005 wine: Unhandled page fault on execute access to 0x7c9e4cd7 at address 0x7c9e4cd7 (thread 000b), starting debugger... err:module:DelayLoadFailureHook failed to delay load user32.dll.BroadcastSystemMessageW wine: Call from 0x7b83ba92 to unimplemented function user32.dll.BroadcastSystemMessageW, aborting wine: Unimplemented function user32.dll.BroadcastSystemMessageW called at address 0x7b83ba92 (thread 001d), starting debugger... Another thing to notice is that this was tested using wine1.4.1 However it DOES work with wine1.5.10 ... to get something to work for me is not the challenge, its to understand the logic behind why something does not. THanks a lot and I am grateful for any who contributes his knowledge to this problem i am a real NOVICE

5 8

Re: comctl32/listview: fix overwriting of item values
by Nikolay Sivov March 9, 2013

March 9, 2013

On 3/9/2013 10:03, Daniel Jelinski wrote: Makes sense, thanks. I briefly searched for such cases and LISTVIEW_FindItemW() seems to be broken the same way.

1 0

spec file and -arch
by Stefan Leichter March 8, 2013

March 8, 2013

Hi, when i look into msvcr100.spec file i find lots of different parameters for the switch (?) -arch . So fare i have seen: arm, i386, win32, win64 and x86_64 . To me it is not clear what is the difference between win64 and x86_64. The same for i386 and win32. What are is the criteria to choose the first or the second? If it makes a difference do i have to distinguish between arm and ... ? Does -i386 and -arch=i386 mean the same? Thank you for enlightening me Stefan

2 1

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 3).
by Alexandre Julliard March 8, 2013

March 8, 2013

Sergey Guralnik <serhio(a)etersoft.ru> writes: > This patch demonstrates the most interest case from previous versions. > When SetWindowPos() moves child window, that has some invalid > area, it also invalidates children of this window according to its > update region, even if moved window has WS_CLIPCHILDREN style. > > Wine doesn't perform this invalidation. > One pretty large application depends on this feature, and now, > runned under Wine, it has broken output. > > Hope this variant is more clear than all previous. It's better, but testing the message sequence doesn't seem very useful, particularly since you don't differentiate parent and child messages. Also you should test the region before the move to show that it's the move that's changing it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcr110: Add VS2012 C/C++ runtime
by Alexandre Julliard March 8, 2013

March 8, 2013

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -0,0 +1,2260 @@ > +# MS VC++2012 runtime library > + > +@ stub -arch=arm ??0?$_SpinWait@$00(a)details@Concurrency@@QAA(a)P6AXXZ@Z > +@ stub -arch=win32 ??0?$_SpinWait@$00(a)details@Concurrency@@QAE(a)P6AXXZ@Z > +@ stub -arch=win64 ??0?$_SpinWait@$00(a)details@Concurrency@@QEAA(a)P6AXXZ@Z > +@ stub -arch=arm ??0?$_SpinWait@$0A@@details(a)Concurrency@@QAA(a)P6AXXZ@Z > +@ stub -arch=win32 ??0?$_SpinWait@$0A@@details(a)Concurrency@@QAE(a)P6AXXZ@Z > +@ stub -arch=win64 ??0?$_SpinWait@$0A@@details(a)Concurrency@@QEAA(a)P6AXXZ@Z > +@ stub -arch=arm,win32 ??0SchedulerPolicy(a)Concurrency@@QAA(a)IZZ That doesn't make much sense, arm is win32 too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winhttp: Implement WINHTTP_OPTION_CONNECTION_INFO. (try 2)
by Alexandre Julliard March 8, 2013

March 8, 2013

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/winhttp/session.c | 71 ++++++++++++++++++++++++++++++++++++++++++ > dlls/winhttp/tests/winhttp.c | 62 ++++++++++++++++++++++++++++++++++++ > include/winhttp.h | 16 ++++++++++ > 3 files changed, 149 insertions(+) Now it breaks the Android build... i686-linux-android-gcc -c -I../../../../wine/dlls/winhttp -I. -I../../../../wine/include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -o session.o ../../../../wine/dlls/winhttp/session.c ../../../../wine/dlls/winhttp/session.c: In function 'convert_sockaddr': ../../../../wine/dlls/winhttp/session.c:609:25: error: 'struct WS_sockaddr_in' has no member named '__pad' make[1]: *** [session.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemac: fix compilation on Lion and later
by Ken Thomases March 7, 2013

March 7, 2013

On Mar 7, 2013, at 4:15 PM, C.W. Betts wrote: > This patch defines __gltypes_h_ so that the Mac header doesn't get included. Thanks! -Ken

1 0

Re: [PATCH 1/7] winemac: Implement OpenGL support.
by C.W. Betts March 7, 2013

March 7, 2013

It seems like there's conflicting types for GLhandleARB, one defined by Wine, the other by OS X, on Mountain Lion. I assume that the #define __gl_h_ is a try to work around the issue, but OS X's gltypes.h still gets included. On Mar 6, 2013, at 3:59 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/Makefile.in | 4 +- > dlls/winemac.drv/cocoa_opengl.h | 32 + > dlls/winemac.drv/cocoa_opengl.m | 154 ++++ > dlls/winemac.drv/cocoa_window.m | 187 ++++ > dlls/winemac.drv/gdi.c | 2 +- > dlls/winemac.drv/macdrv.h | 10 + > dlls/winemac.drv/macdrv_cocoa.h | 15 + > dlls/winemac.drv/opengl.c | 1912 +++++++++++++++++++++++++++++++++++++++ > dlls/winemac.drv/window.c | 11 +- > 9 files changed, 2322 insertions(+), 5 deletions(-) > create mode 100644 dlls/winemac.drv/cocoa_opengl.h > create mode 100644 dlls/winemac.drv/cocoa_opengl.m > create mode 100644 dlls/winemac.drv/opengl.c > > <0001-winemac-Implement-OpenGL-support.patch>

2 3

Re: [2/2] winhttp: Implement WINHTTP_OPTION_CONNECTION_INFO.
by Alexandre Julliard March 7, 2013

March 7, 2013

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -25,6 +25,9 @@ > > #include "windef.h" > #include "winbase.h" > +#define USE_WS_PREFIX > +#include "winsock2.h" > +#include "ws2ipdef.h" > #include "winhttp.h" > #include "wincrypt.h" > #include "winreg.h" This breaks the Mingw build here: In file included from ../../../wine/dlls/winhttp/session.c:39:0: ../../../wine/dlls/winhttp/winhttp_private.h:124:29: error: field ‘sockaddr’ has incomplete type ../../../wine/dlls/winhttp/winhttp_private.h:230:49: warning: ‘struct sockaddr’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/winhttp_private.h:230:49: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] ../../../wine/dlls/winhttp/winhttp_private.h:238:66: error: unknown type name ‘socklen_t’ ../../../wine/dlls/winhttp/session.c:594:44: warning: ‘struct sockaddr’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘convert_sockaddr’: ../../../wine/dlls/winhttp/session.c:596:21: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:598:10: error: ‘AF_INET’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:598:10: note: each undeclared identifier is reported only once for each function it appears in ../../../wine/dlls/winhttp/session.c:604:39: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:605:48: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:609:10: error: ‘AF_INET6’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:615:40: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:616:44: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:617:49: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:627:283: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c: In function ‘request_query_option’: ../../../wine/dlls/winhttp/session.c:731:25: error: storage size of ‘local’ isn’t known ../../../wine/dlls/winhttp/session.c:732:9: error: unknown type name ‘socklen_t’ ../../../wine/dlls/winhttp/session.c:746:9: warning: implicit declaration of function ‘getsockname’ [-Wimplicit-function-declaration] ../../../wine/dlls/winhttp/session.c:748:9: warning: passing argument 1 of ‘convert_sockaddr’ from incompatible pointer type [enabled by default] ../../../wine/dlls/winhttp/session.c:594:13: note: expected ‘const struct sockaddr *’ but argument is of type ‘const struct sockaddr *’ ../../../wine/dlls/winhttp/session.c:731:25: warning: unused variable ‘local’ [-Wunused-variable] ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1230:63: warning: ‘struct sockaddr_in’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘printf_addr’: ../../../wine/dlls/winhttp/session.c:1233:15: warning: implicit declaration of function ‘ntohl’ [-Wimplicit-function-declaration] ../../../wine/dlls/winhttp/session.c:1233:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1234:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1235:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1236:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1239:41: warning: ‘struct addrinfo’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c:1248:66: warning: ‘struct addrinfo’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘build_wpad_url’: ../../../wine/dlls/winhttp/session.c:1252:15: error: ‘NI_MAXHOST’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:20: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1256:35: error: ‘AF_INET’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:48: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1256:63: error: ‘AF_INET6’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:80: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1259:5: warning: passing argument 1 of ‘reverse_lookup’ from incompatible pointer type [enabled by default] ../../../wine/dlls/winhttp/session.c:1239:12: note: expected ‘const struct addrinfo *’ but argument is of type ‘const struct addrinfo *’ ../../../wine/dlls/winhttp/session.c:1252:10: warning: unused variable ‘name’ [-Wunused-variable] ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1205:14: warning: ‘get_computer_name’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1221:13: warning: ‘is_domain_suffix’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1230:13: warning: ‘printf_addr’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1248:15: warning: ‘build_wpad_url’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c: In function ‘convert_sockaddr’: ../../../wine/dlls/winhttp/session.c:630:1: warning: control reaches end of non-void function [-Wreturn-type] make[1]: *** [session.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9 [patch 1/2, try 3]: Implement D3DXSHEvalConeLight
by Nozomi Kodama March 7, 2013

March 7, 2013

hello Still problems with this patch? Nozomi.

2 1

wiki.winehq.org is down
by Michael Stefaniuc March 7, 2013

March 7, 2013

Hey Dimi, the wiki is down: <puk> is the wiki down? <puk> it pings <puk> but with high latency <puk> and while port 80 connects a GET / doesn't returns thanks bye michael

1 0

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 3).
by Sergey Guralnik March 7, 2013

March 7, 2013

On 2013-03-04 10:39, Sergey Guralnik wrote: > This patch demonstrates the most interest case from previous > versions. > When SetWindowPos() moves child window, that has some invalid > area, it also invalidates children of this window according to its > update region, even if moved window has WS_CLIPCHILDREN style. > > Wine doesn't perform this invalidation. > One pretty large application depends on this feature, and now, > runned under Wine, it has broken output. > > Hope this variant is more clear than all previous. It stays queued since Monday without any reply. Is something wrong with it? -- Sergey

1 0

Re: Use accented letters in their names.
by Frédéric Delanoy March 6, 2013

March 6, 2013

> On 3/4/13, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: >> On Fri, Mar 1, 2013 at 5:01 PM, Tae Wong <seotaewong40(a)gmail.com> wrote: >>> The authors file is outdated and you want this updated with the >>> missing authors. Andrej Znidarsic should have Slovenian accented >>> letters for his last name. >>> >>> On 2/4/13, Tae Wong <seotaewong40(a)gmail.com> wrote: >>>> You will want to use accented letters in their authors names. >>>> >>>> Caolan McNamara >>>> Ferenc Wagner >>>> Marko Nikolic >>>> >>>> Every once and a while the GNOME Live website is down with an error on >>>> Netscape called “The operation timed out when attempting to contact .” >>>> - This paragraph should have a website name. You want to be unbanned >>>> in Amaterasu Translations and the DOS ain’t dead forums. >> >> Feel free to send a patch to wine-patches fixing those issues. >> On Wed, Mar 6, 2013 at 3:02 PM, Tae Wong <seotaewong40(a)gmail.com> wrote: > You’ve sent a patch to wine-patches but never got them fixed! I didn't send a patch, but you did (well, sort of, this wasn't really a patch, but a mere email) See http://wiki.winehq.org/SubmittingPatches for instructions (http://source.winehq.org/patches/ helps you see what is the status of your patch, in this case 94687) Note however that this authors list is likely autogenerated from git.("John Doo <email address>") email addresses, so it's up to the patch submitter to correctly spell his/her own name to begin with. Rewriting the history to fix this seems overkill to me. Hence, if you fix the AUTHORS file, your changes might be overwritten the next time the file is generated. Frédéric

1 0

ntdll: make NtDelayExecution a bit more efficient
by Joerg-Cyril.Hoehle＠t-systems.com March 6, 2013

March 6, 2013

You may try and find that MSDN or blog page where people explain the subtle differences of Sleep(0) and Sleep(1) on multi-core machines. Regards, Jörg Höhle

1 0

Re: [1/3] Make mac driver the default on OS X
by Ken Thomases March 6, 2013

March 6, 2013

On Mar 5, 2013, at 6:32 PM, Josh DuBois wrote: > --- > dlls/gdi32/driver.c | 102 +++++++++++++++++++++++++++++++++++++++++++-- > dlls/gdi32/gdi32.spec | 1 + > dlls/gdi32/gdi_private.h | 2 + > dlls/user32/driver.c | 27 ++++++------ > include/wine/gdi_driver.h | 11 +++++ > 5 files changed, 125 insertions(+), 18 deletions(-) > > <0001-Track-and-report-multiple-errors-loading-display-drive.txt> As I believe you're aware, I think that the Mac driver should not be made the default until OpenGL and clipboard support are in. So, maybe this was just submitted in preparation for that time, but there should probably have been a note to that effect. Also, this patch seems exceedingly complex for a relatively simple problem. Just because it has historically been user32 that reported failure to load the driver doesn't mean it must remain so, at least to my way of thinking. Why not just print out the diagnostics directly in gdi32 as each attempt to load a driver fails? In user32, there can be a secondary, driver-agnostic message about failure to create a window. > + case ERROR_DLL_INIT_FAILED: > + load_err->err_msg = "Make sure you have permission to create \na window or check for errors with Console.app. \n(The Mac driver cannot do remote display: try X11 if you need that.)"; > + break; "Make sure you have permission to create a window" doesn't mean anything to me. Checking Console.app isn't very useful either. If the user sees this message, then they're already looking at wherever the process's output is going. Running Wine from a shell won't write anything to the console logs. As of Mountain Lion, running it from a GUI app won't either; Apple changed things so that stdout and stderr of GUI apps go to /dev/null rather than console logs. (Only things like NSLog() or asl_log() go to the console log.) Probably it's just best to say that the Mac driver is running in a non-GUI session such as a remote login. -Ken

2 1

Re: qcap: Fix compilation on systems that have v4l1 but not VIDIOCMCAPTURE & co.
by Alexandre Julliard March 6, 2013

March 6, 2013

Francois Gouget <fgouget(a)free.fr> writes: > In particular this fixes compilation on FreeBSD 8.1. > > configure | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++ > configure.ac | 18 +++++++++++++ > dlls/qcap/v4l.c | 4 +-- > include/config.h.in | 3 +++ > 4 files changed, 97 insertions(+), 2 deletions(-) It's not very useful to add a configure check for a #define, you can check for it directly. -- Alexandre Julliard julliard(a)winehq.org

1 0