March 2013 - Wine-Devel - list.winehq.org

Re: gdi32: Copy gamma ramp validation from winex11 to make it driver independent
by Dmitry Timoshkov March 22, 2013

March 22, 2013

André Hentschel <nerv(a)dawncrow.de> wrote: > - this was done for the mac driver > - i tried to follow the file-style, except of the original variable naming The ERRs should be downgraded to WARNs or even TRACEs, there is no point to loudly complain on application input. -- Dmitry.

1 0

[GSoC] My proposal for GSoC 2013
by Gediminas Jakutis March 21, 2013

March 21, 2013

Hello! My name is Gediminas Jakutis. I study Informatics Engineering [bachelor / undergraduate] at Kaunas University of Technology, second year. I wish to try out GSoC for the first time by helping to improve Wine. My primary programming language is C. I am self-taught in C, but I believe my knowledge is good enough. I am quite familiar with Wine - I use it and experiment with it for many years now. I am subscribed to and read wine-devel for more than a year. I browse through Wine's source code once in a while out of curiosity. Thus, I have some knowledge of its structure. Sadly, I have not written any patches for Wine yet. Mostly due to lack of confidence. For GSoC, I am suggesting my own idea. In case this idea is not good, I am open to changing it, thinking of a new one, or adopting one. My idea: I have noticed that Wine's virtual desktop feature is very limited - if the first program on a prefix starts without a virtual desktop, all programs launched during the same session also start without a VD, disregarding any VD settings and/or requests with environment variables. And vice versa - if the first program starts inside a VD, all other programs in that sessions start in the VD. Often, this can be worked around by using separate Wine prefixes. Yet sometimes, this workaround is not possible. A good example: steam and games that only run properly in a VD. This forces the user to start steam in a VD and makes steam itself unusable while a game is running, especially if the game does not support the steam overlay. I would like to fix this limitation and make it possible to properly choose to run different programs on one prefix with or without a VD regardless what was chosen to programs already running in that prefix. I can already see this requiring changes in the winecfg utility, by the way. In case this turns out to be too easy of a project, I could implement some way to perform "alt-tabbing" between programs in a VD and/or an optional (enable-able in winecfg) rudimentary taskbar for changing/checking focus. I am very excited about participating in GSoC. And even more excited about starting to contribute to Wine by writing patches! Regardless if I get accepted or not, I wish to make Wine better. Thus, expect me to start submitting patches in the future even if I do not get accepted. ;] Sincerely, Gediminas Jakutis ---- LDK Varčiai www.varciai.lt

3 3

Re: winemac: Implement GetDeviceGammaRamp() and SetDeviceGammaRamp().
by André Hentschel March 20, 2013

March 20, 2013

Am 18.03.2013 04:41, schrieb Ken Thomases: > --- > dlls/winemac.drv/display.c | 131 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/winemac.drv/gdi.c | 4 +- > dlls/winemac.drv/macdrv.h | 2 + > 3 files changed, 135 insertions(+), 2 deletions(-) Hi, wrt macdrv_SetDeviceGammaRamp, the X11 driver has some validation in xvidmode.c->ComputeGammaFromRamp() because windows doesn't allow every ramp. It might happen that apps try bad ramps and the screen simply gets dark without validation. I'll see if i can copy/move the validation to gdi32 where the driver function normally get's called so that the validation is driver independent. -- Best Regards, André Hentschel

2 1

Re: [PATCH 2/2] msvcrt: Fixed fgetwc behavior on multibyte characters and unicode files
by Akihiro Sagawa March 20, 2013

March 20, 2013

On Mon, 18 Mar 2013 17:11:04 +0100, Piotr Caban wrote: > + char mbs[2]; This should be a constant, like MSVCRT_MB_LEN_MAX. > + int len = 0; > + ch = MSVCRT_fgetc(file); > + if(ch != MSVCRT_EOF) { > + mbs[0] = (char)ch; > + if(MSVCRT_isleadbyte(mbs[0])) { This doesn't work correctly if char is signed. Because _isleadbyte() expects the value of unsigned char or EOF as well as other is- functions. I wrote some fgetwc() tests. Please refer following page: https://testbot.winehq.org/JobDetails.pl?Key=24806 Akihiro Sagawa

2 1

Re: [7/10] winemenubuilder: Create a basic Info.plist.
by Ken Thomases March 20, 2013

March 20, 2013

On Mar 17, 2013, at 12:18 PM, Per Johansson wrote: > + namestr = CFStringCreateWithCString(NULL, link_name, CFStringGetSystemEncoding()); You should use CFStringCreateWithFileSystemRepresentation() to create CFStrings from POSIX path strings. > + pathstr = CFStringCreateWithCString(NULL, path, CFStringGetSystemEncoding()); Same thing here. > + data = CFPropertyListCreateData(NULL, propertyList, format, 0, &err); Since you don't use "err", just pass NULL. -Ken

2 1

Re: [10/10] winemenubuilder: Put appbundle icon inside the bundle.
by Ken Thomases March 19, 2013

March 19, 2013

On Mar 17, 2013, at 12:18 PM, Per Johansson wrote: > + CFStringRef iconstr = CFStringCreateWithCString(NULL, icon, CFStringGetSystemEncoding()); Another place to use CFStringCreateWithFileSystemRepresentation(). -Ken

1 0

Re: msvcr110: add a stub for __crtGetShowWindowMode
by Dmitry Timoshkov March 18, 2013

March 18, 2013

Austin English <austinenglish(a)gmail.com> wrote: > +int CDECL __crtGetShowWindowMode(void) > +{ > + FIXME(": stub!\n"); > + return 0; > +} Isn't it supposed to return SW_SHOW and other SW_xxx commands, specified at process creation time (SW_SHOWDEFAULT)? In that case returning 0 (SW_HIDE) is not a very good choice. -- Dmitry.

1 0

Re: [0/10] Launcher app bundles on OS X
by C.W. Betts March 18, 2013

March 18, 2013

A quick glance at the source revealed that you removed static from some functions. Why? If a function isn't being called outside a source file, it's better to have it be static. This includes functions referenced in structs (but not the structs themselves). A more seasoned developer is welcome to correct me if I'm wrong. On Mar 17, 2013, at 11:18 AM, Per Johansson <per(a)morth.org> wrote: > I'm resending this now after testing it with the Mac driver. > They work well together, the launcher bundle will first briefly > appear in the dock, then exit, and the mac driver icon appears. > > It's split it up into parts for easier review. I've also tried > to make sure that even if e.g. part 6 fails review, part 1 - 5 > can still be applied. > > File type associations are not included because I plan to move > that code into the mac driver but haven't gotten around to it yet. > > Regards, > -- > Per Johansson > > >

2 1

Re: [website] Portuguese translation for release 1.5.25
by Bruno Jesus March 18, 2013

March 18, 2013

2013/3/18 Lucas Zawacki <lfzawacki(a)gmail.com>: > From: Lucas Zawacki <lfzawacki(a)gmail.com> > > --- > news/pt/2013030101.xml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 news/pt/2013030101.xml > > diff --git a/news/pt/2013030101.xml b/news/pt/2013030101.xml > new file mode 100644 > index 0000000..ae13cfd > --- /dev/null > +++ b/news/pt/2013030101.xml > @@ -0,0 +1,14 @@ > +<news> > +<date>1 de Março de 2013</date> > +<title>Wine 1.5.25 lançado</title> > +<body> > + A versão de desenvolvimento 1.5.25 já está disponível agora. > + <a href="{$root}/announce/1.5.25">Novidades</a> desta versão: > +<ul> > + <li>Suporte adequado ao cursor no driver de Mac.</li> > + <li>Correções no suporte a escrita direita-para-esquerda no RichEdit.</li> > + <li>Versão inicial da uma fonte Wingdings.</li> Should be: Versão inicial de uma fonte Wingdings. Or: Versão inicial da fonte Wingdings. > + <li>Várias correções de bugs.</li> > +O código fonte está <a href="http://prdownloads.sourceforge.net/wine/wine-1.5.25.tar.bz2">disponível agora</a>. > +Pacotes binários estão em processo de construção e irão aparecer em breve em suas respectivas <a href="{$root}/download">sessões da área de downloads</a>. > +</body></news> > -- > 1.7.9.5 > > > Best wishes, Bruno

2 1

Re: usp10: Support GPOS extension lookup subtables
by Aric Stewart March 18, 2013

March 18, 2013

Hi Phil, Thank you for being patient I am back from vacation and reviewing your patch. The logic looks great and just fine. Do you happen to have a font that uses lookup type 9 that I can run my usp test suite on to make sure it functions as expected? thanks! -aric On 3/8/13 10:47 AM, Phil Krylov wrote: > > > >

1 0

WineD3D performance
by Graham Knap March 18, 2013

March 18, 2013

Hi everyone I would like to try to help with improving the performance of StarCraft II on Wine. I'm working with a friend. Over the past couple of weeks, we have tried to read whatever documentation we could find. We have tried a couple of different approaches to profiling, without much success. My friend got WineD3D running on Windows. We built Wine from current source code, tested this on two different configurations, and got similar results. - my Core 2 E8500 + GeForce 9600GT + Windows XP x86 - his i5-2500 + GeForce 660 + Windows 7 x64 It looks like WineD3D is the cause of most of the performance difference. Windows with its own D3D gave us at least twice the frame rate of Windows + WineD3D. There is some difference between the numbers for Windows + WineD3D and Linux + Wine, but it's much smaller, i.e. something like 25%. Can anyone offer some hints on how to find the most significant causes of the performance difference? Any tips for effective profiling or tracing? Thanks. -- graham

2 2

Re: wined3d: add NVidia GeForce 315M
by Stefan Dösinger March 18, 2013

March 18, 2013

Am 17.03.2013 um 17:08 schrieb Daniel Jeliński <djelinski1(a)gmail.com>: > why can't we get these values from X? They are definitely present in > my Xorg.log. Propose a patch. A few notes though: *) The upcoming GLX_MESA_query_renderer extension will provide a good way to query this info. If this extension will be adopted by the binary drivers is an open question. *) The X.org log would be an extremely ugly way to read this info. The log is at an unknown place, might be readable only by root or might not exist at all. There format of the log messages might change. *) There are vendor specific X11, GLX and GL extensions to query some GPU info *) Wined3d should not deal with GLX_MESA_query_renderer or any other X11 specific things. This should be handled by winex11.drv. > {"GT 320M", CARD_NVIDIA_GEFORCE_GT320M}, /* Geforce 300 - midend mobile */ > + {"315M", CARD_NVIDIA_GEFORCE_315M}, /* Geforce 300 - midend mobile */ > {"320M", CARD_NVIDIA_GEFORCE_320M}, /* Geforce 300 - midend mobile */ Afaics this table is sorted in descending order, for consistency you should swap the 315M and 320M

2 1

Re: msxml3: Embed user/password to uri used to create a moniker (try2)
by Nikolay Sivov March 18, 2013

March 18, 2013

On 3/15/2013 21:43, Nikolay Sivov wrote: > try2: fixed builder leak > Please ignore this one, it removes too much, I have a better version.

1 0

Updating WineWiki Theme?
by Kyle Auble March 16, 2013

March 16, 2013

Hi everybody, Although my hiatus was longer than expected, I've been making progress with updating the wiki code over the past few days (spring break is a very good thing). My workflow is a bit non-linear so I want to sort my changes into patches first, but fingers-crossed, I'll be pushing them to my Bitbucket account by the weekend. I did want to ask for input on a few things: 1. Should we just keep Moinmoin's search, replace it with the custom Google search, or offer both? 2. How about the icon? I can get the standard WineHQ one to display fine, but I'm not sure about which approach to take. Essentially, do what's simplest for us, or should I make it play well with other themes too? 3. Finally, the credits are currently just text links. In the future though, if Dimi wanted to, we could have a "sponsored by Lattica" banner like the Codeweavers ones on the other pages. After I get the theme together & test it some more on different browsers, I can look into migrating the data to the newest Moinmoin version. -Kyle

3 4

Vacation
by Alexandre Julliard March 15, 2013

March 15, 2013

Folks, There won't be any commits next week, as I'll be out skiing... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] Make mac driver the default on OS X (try 2)
by Alexandre Julliard March 15, 2013

March 15, 2013

Josh DuBois <duboisj(a)codeweavers.com> writes: > Ken also noted that the error reporting could be simpler if it were in > gdi instead of user32. My impression, after having poked at it a > while with Ken, is that it is in theory possible that an application > which never tried to create a window would print less noise with the > errors being reported as they are here than it would if the errors > were reported directly from gdi, so that this may be superior because > it is quieter. However, I'm not an expert and if the rigamarole is > not worth the extra lines, I'm sure Alexandre will indicate so by not > applying this. It needs to be printed on window creation because of command line apps, but that's not a reason for doing something as ugly and complicated as this... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] atl100/tests: Added class name test for AtlAxWinInit.
by Alexandre Julliard March 15, 2013

March 15, 2013

Qian Hong <qhong(a)codeweavers.com> writes: > @@ -562,6 +562,34 @@ static void test_source_iface(void) > ok(maj_ver == 4 && min_ver == 0, "ver = %d.%d\n", maj_ver, min_ver); > } > > +static void test_ax_win(void) > +{ > + BOOL ret; > + WNDCLASSEXW wcex; > + static const WCHAR AtlAxWin100[] = {'A','t','l','A','x','W','i','n','1','0','0',0}; > + static const WCHAR AtlAxWinLic100[] = {'A','t','l','A','x','W','i','n','L','i','c','1','0','0',0}; > + static HMODULE huser32 = 0, hinstance = 0; > + static BOOL (WINAPI *pGetClassInfoExW)(HINSTANCE, LPCWSTR, WNDCLASSEXW *); > + > + huser32 = GetModuleHandleA("user32.dll"); > + pGetClassInfoExW= (void *)GetProcAddress(huser32, "GetClassInfoExW"); It's not useful to load this dynamically if you are not going to check that it was found. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: winmm: Fix notification when recording using MSACM.
by Alexandre Julliard March 15, 2013

March 15, 2013

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > To achieve this, we eliminate the tail call and turn it into a loop, > which allows us to preserve the local state in the variable "last". Please do this as a proper loop, not with a goto. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: mmdevapi: Prevent 64 bit overflow within a few days of audio device use. (try 3)
by Alexandre Julliard March 15, 2013

March 15, 2013

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > The only comments about v2 were Michael Stefaniuc > suggesting a refactoring and me explaining why > in this particular case, that would not be a good idea. > http://www.winehq.org/pipermail/wine-devel/2013-March/099068.html It's still a good idea, even if the function is ultimately used only in one place. > For v3, I've renamed MulDiv64 to UMulDiv64. Unlike QueryPerformanceCounter, > mmdevapi GetPosition operates on unsigned values. That's a bad name. Don't make internal functions look like Win32 APIs. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Aric Stewart : usp10: Update diacritical script handling for non OpenType Itemization.
by Phil Krylov March 14, 2013

March 14, 2013

Hello Aric, On Tue, Feb 5, 2013 at 11:25 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: ef4b7c5948e43d4ceeed98ba4ddbf6c222259d36 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=ef4b7c5948e43d4ceeed98ba4… > > Author: Aric Stewart <aric(a)codeweavers.com> > Date: Tue Feb 5 08:57:44 2013 -0600 > > usp10: Update diacritical script handling for non OpenType Itemization. (snip) > + for (j = i-1; j >= 0 && scripts[j] == first_script && pwcInChars[j] != Numeric_space; j--) > + { > + WORD original = scripts[j]; > + if (original == Script_Ideograph || original == Script_Kana || original == Script_Yi || original == Script_CJK_Han || original == Script_Bopomofo) > + { > + asian = TRUE; > + break; > + } > + if (original != Script_MathAlpha && scriptInformation[scripts[j]].props.fComplex) > + break; > + scripts[j] = scripts[i]; > + if (original == Script_Punctuation2) > + break; > + } > + if (scriptInformation[scripts[j]].props.fComplex || asian) > + scripts[i] = scripts[j]; I am not sure about the logic of this, so I can't commit a good patch, but in the last statement you definitely access scripts[-1] when j reaches the value of 0. Which may cause a crash here or (in my case) later. -- Ph.

2 2

RE: d3dx9 [patch 1/2]: Implement D3DXSHEvalSphericalLight
by Nozomi Kodama March 14, 2013

March 14, 2013

Hello Any problem with the patch http://source.winehq.org/patches/data/94777 and http://source.winehq.org/patches/data/94776 ? Nozomi.

2 2

Re: winegcc: Add support for -Ttext-segment linker flag to set image base of a dll. (try 2)
by André Hentschel March 14, 2013

March 14, 2013

Am 03.03.2013 16:58, schrieb Tijl Coosemans: > --- > README | 3 +++ > tools/winegcc/utils.h | 3 ++- > tools/winegcc/winegcc.c | 11 ++++++++++- > 3 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/README b/README > index 783e798..75aff5a 100644 > --- a/README > +++ b/README > @@ -40,6 +40,9 @@ support kernel threads may be supported in the future. > > FreeBSD info: > Wine will generally not work properly on versions before FreeBSD 7.0. > + You need GCC with GNU Binutils 2.20 or higher and run configure with > + environment variables like CC, CFLAGS, CXX, CXXFLAGS, CPP, CPPFLAGS, > + LD and LDFLAGS set correctly to use this compiler and linker. > See http://wiki.freebsd.org/Wine for more information. > Do you really need that? is there no script on freebsd to set the compiler toolchain or something? > > enum target_platform > { > - PLATFORM_UNSPECIFIED, PLATFORM_APPLE, PLATFORM_SOLARIS, PLATFORM_WINDOWS, PLATFORM_CYGWIN > + PLATFORM_UNSPECIFIED, PLATFORM_APPLE, PLATFORM_SOLARIS, PLATFORM_ELF, > + PLATFORM_WINDOWS, PLATFORM_CYGWIN > }; > You would rather call it PLATFORM_FREEBSD > + if (opts->image_base && !opts->target && opts->target_platform == PLATFORM_UNSPECIFIED) I'm in doubt here -- Best Regards, André Hentschel

3 5

Re: [PATCH 2/2] ole32: Don't pass CLSCTX_INPROC_SERVER and CLSCTX_INPROC_HANDLER flags to CoCreateInstance in DefaultHandler
by Marvin March 13, 2013

March 13, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24750 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: gdiplus: Ignore gdiplus page and world transformations when creating a gdi32 clipping region.
by Vincent Povirk March 13, 2013

March 13, 2013

I guess this makes sense, because having the clipping region change with transforms would be weird when drawing recursively and changing the transform. I had assumed clipping regions were in world coordinates because most things are, but I didn't really have any information either way.

1 0

Re: [PATCH 1/2] wined3d: Put local constants into the shader code again
by Henri Verbeet March 13, 2013

March 13, 2013

On 13 March 2013 02:19, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This provides a small GPU-side performance boost on dx10+ capable Nvidia > cards - about 5% in World of Tanks on my Geforce 9600, and more in a > dedicated test program. > > This is essentially a revert of cd7825c89374fb9dd4c20aef2dbfd258713efe6a, > with proper precision. > This is probably ok, although one concern is applications setting constants to e.g. NaN or infinity. It may be worth using ARB_shader_bit_encoding when available, or perhaps even only doing this when that extension is available.

2 1

Re: [PATCH 1/2] wined3d: Put local constants into the shader code again
by Stefan Dösinger March 13, 2013

March 13, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-03-12 18:19, schrieb Stefan Dösinger: > The test program is available at > https://84.112.174.163/~git/perftest file const_gl/const_gl.cpp. My server is currently turned off (and I should move this to github or somewhere at some point), so I've attached the test program here for reference. Resolution and constant mode are hardcoded into it. Tab/space mixup thanks to Visual Studio. Compile the Linux version with g++ const_gl.cpp -o const_gl -lGL -lglut -lGLEW . A d3d version is attached as well. It does not load the same values when using the global constants, but this doesn't seem to affect performance. I haven't tested ARB shaders, but from the WoT results before and after patch 2, their behavior seems to be the same as GLSL and native d3d. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRP9WcAAoJEN0/YqbEcdMwdmoP/2LvEFpPpmTiZDzxqhp38WfU DKs2S8m1kP86fL55GwLtth289WC9MsQyOosOVOqt8r3YWZyckeisZyhdP2ez2KRV 9kgxMnEXwzcZBtmm/+nrl0FwJghy86AnZ0YJ9PpnCpY0k4VTQYjaWQALlyqtF+qm Uup4UE+m4yR4DoNL/u/161Zxh+OLOA8PXEhWWfDozNL/8yMlRfPs6gzLMN/oKTIL UMA90gesZWPt7/J2Bp0+OeZvMWqNa54A2akxsLvtxVP/rB8baym4iYLn5Y2IPXa2 lBqALc+POMcVk45FCgkzjUw5b/7ck9V5n0PKOw/9Jwrm8/ChHE4i0ZwGEmHzh3So y1d/KydwesYtyCadmlklgJy1J+CxyCd/fNVUmsNtpzDEo6OF7oEagvwBUlTnCdR9 W9B9lmpsDCuBIxEnAy7C3HEZ18o70HdoUsKe5hX8fVn5lnwFPWdp7hBA0nVbO0y0 Fybps006cQmc0Rm9nHJjeJ9JoGzl/iuSX0AnQ5fiJS6fS5RrrGAnFBEb1g2O879X pNSIgBdKUSSfGBoUZKKIy+GZzC+VhDm4UqhtSaYudlUB9pcoMDFYRGQ3Rk48kRuD tJ8Ah2VBYeFUvI+x4Xty9AtOwwFWYejNG+6cNNF3EOALz2JvhFKDEJCI0p7bdmgR XCfPxQyYN7+JGFw8JiO5 =RgiG -----END PGP SIGNATURE-----

1 0

Re: [PATCH] activeds: Exclude unused headers.
by Alexandre Julliard March 12, 2013

March 12, 2013

Amine Khaldi <amine.khaldi(a)reactos.org> writes: > @@ -28,13 +28,10 @@ > > #include "windef.h" > #include "winbase.h" > -#include "winuser.h" > > #include "objbase.h" > #include "iads.h" > -#include "adshlp.h" > > -#include "wine/unicode.h" > #include "wine/debug.h" It's not worth the trouble, particularly since the file ends up including windows.h anyway. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: ntdll: Make msync() asynchronous in NtFlushVirtualMemory (resubmit with real name)
by Alexandre Julliard March 12, 2013

March 12, 2013

Mathis Beer <default_357-line(a)yahoo.de> writes: > diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c > index a99bca4..e4f2bb6 100644 > --- a/dlls/ntdll/virtual.c > +++ b/dlls/ntdll/virtual.c > @@ -62,6 +62,10 @@ WINE_DECLARE_DEBUG_CHANNEL(module); > #define MS_SYNC 0 > #endif > > +#ifndef MS_ASYNC > +#define MS_ASYNC 1 > +#endif That's questionable, there's no reason the value would be 1. We defined MS_SYNC to 0 on the theory that it's better to pass 0 than making up values, but probably not calling the function at all would be preferable. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: msvcp60: Avoid signed-unsigned integer comparisons
by larmbr zhan March 11, 2013

March 11, 2013

On Sun, Mar 10, 2013 at 5:48 AM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > msvcp60: Avoid signed-unsigned integer comparisons. Hi, Andrew Talbot. I find that you are working on these "Avoid signed-unsigned integer comparisons" things recently. I DO agree on that using _ unsigned int _ instead of _ int _(which implies _ signed int _). But I think using size_t maybe more standard-compliant, more efficient, and less bug-prone, . To hold this, I think something has to be clarified... * The overflow behavior is instrinsic because the finite range that a object of INT type can hold. But It behaves different when it is signed or not. According to C Standard, - For the signed case, once it overflows, resulting in representing a negative value . - For the unsigned case, once it overflows, resulting in representing a value reduced modulo the largest value that object could hold. So see this example: --- snip --- size_t num = get_max_object_num(); // which may give a large number. unsigned int i; for ( i = 0; i < num; i++) something_important[i] = vital_evaluate_for(i); --- snip --- For this case, though we use unsinged int ,it still may issue problem if num >= UINT_MAX, which will cause i to wrap to 0, then something_important maybe assigned a invalid value, as like. This problem may occur if using in a 64-bit enviroment, where size_t is typeof 'ed unsigned 64bit while unsigned int is still 32-t wide. Some may argue that in Wine this problem will NEVER happen. I don't doubt it. But * since we have a cleared and more standard-compliant way (which means less bug-prone), and * predictably Wine will support more platforms, portable way shall be taken it account. So I think we should use size_t in this case. -- Cheers, Zhan JIanyu

4 3

Re: ntdll: make NtDelayExecution a bit more efficient
by Alexandre Julliard March 11, 2013

March 11, 2013

Graham <graham.knap(a)gmail.com> writes: > This patch is vaguely related to bug 24558. It eliminates a few > syscalls in NtDelayExecution: > > 1. If the caller requests a zero-wait yield, then do just that, and > nothing more. That's what the existing code already does. > 2. If you're about to block on select(), then I don't see any point in > preceding that with a call to sched_yield(). This was added for a reason; most likely you'll have to write tests. -- Alexandre Julliard julliard(a)winehq.org

7 7

Re: [2/2] wmvcore: Stub implementation of IWMMetadataEditor interface (try2)
by Nikolay Sivov March 11, 2013

March 11, 2013

On 3/11/2013 16:36, Jeff Latimer wrote: > + if (!ppv) return E_INVALIDARG; You don't need this most likely. > + IUnknown_AddRef((IUnknown*)*ppv); A cleaner way is to AddRef original iface, but that's a matter of taste. > +static ULONG WINAPI WMCreateEditor_AddRef(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + return 2; > +} > + > +static ULONG WINAPI WMCreateEditor_Release(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return 1; > +} What's this supposed to mean? > +HRESULT WINAPI WMCreateEditor_flush(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} > + > +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} I don't think so. > HRESULT WINAPI WMCreateEditor(IWMMetadataEditor **editor) > { > + IWMMetadataEditor *This; > FIXME("(%p): stub\n", editor); > > - *editor = NULL; > + This = HeapAlloc(GetProcessHeap(), 0, sizeof(IWMMetadataEditor)); > + if (!This) return E_OUTOFMEMORY; > > - return E_NOTIMPL; > + This->lpVtbl = &Editor_vtable; > + *editor = This; > + > + return S_OK; > } That's not how it's done, there's plenty of examples already. > -}; > +} That change is ok I think.

1 0

Re: [1/2] include: Implement part of nserror.h
by Nikolay Sivov March 11, 2013

March 11, 2013

On 3/11/2013 10:27, Jeff Latimer wrote: > --- > include/nserror.h | 226 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 226 insertions(+) > create mode 100644 include/nserror.h > +#ifndef _NSERROR_H > +#define _NSERROR_H This doesn't look right. > +#define NS_S_CALLPENDING_HRESULT_TYPEDEF_(0x000D0000L) This is usually done with a suffix. > + > +#endif Please add a comment here.

2 2

Re: wininet: Skip test_open_url_async on IEs older than 7.
by Marvin March 9, 2013

March 9, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24685 Your paranoid android. === WVISTAADM (32 bit http) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: dpnet/tests: Allow buffersize used by Win8
by Marvin March 9, 2013

March 9, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24682 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF

1 0

Crash confuses me
by Graham March 9, 2013

March 9, 2013

I use a LD_PRELOAD before running wine so that i can debug my application. The library which is preloaded is able to replace system dlsym and from that, other consequence library call. There is no problem until, i put some Detour code(hot patching) into the kernel32.dll.so address space. But the very funny things is this ** THE PROGRAM CRASHES BEFORE MY HOTPATCH IS APPLIED ** so it seems somehow the order of cause and effect is extremely weird and frightening to me. How can a piece of code which is not excecuted be teh cause for errors PRIOR/BEFORE to its execution. And this is surely happening because when i uncomment the Hotpatch/detour lines the problem goes away. here are some lines from the crashs ... err:module:attach_process_dlls "user32.dll" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"C:\\windows\\system32\\winemenubuilder.exe" failed, status c0000005 wine: Unhandled page fault on execute access to 0x7c9e4cd7 at address 0x7c9e4cd7 (thread 000b), starting debugger... err:module:DelayLoadFailureHook failed to delay load user32.dll.BroadcastSystemMessageW wine: Call from 0x7b83ba92 to unimplemented function user32.dll.BroadcastSystemMessageW, aborting wine: Unimplemented function user32.dll.BroadcastSystemMessageW called at address 0x7b83ba92 (thread 001d), starting debugger... Another thing to notice is that this was tested using wine1.4.1 However it DOES work with wine1.5.10 ... to get something to work for me is not the challenge, its to understand the logic behind why something does not. THanks a lot and I am grateful for any who contributes his knowledge to this problem i am a real NOVICE

5 8

Re: comctl32/listview: fix overwriting of item values
by Nikolay Sivov March 9, 2013

March 9, 2013

On 3/9/2013 10:03, Daniel Jelinski wrote: Makes sense, thanks. I briefly searched for such cases and LISTVIEW_FindItemW() seems to be broken the same way.

1 0

spec file and -arch
by Stefan Leichter March 8, 2013

March 8, 2013

Hi, when i look into msvcr100.spec file i find lots of different parameters for the switch (?) -arch . So fare i have seen: arm, i386, win32, win64 and x86_64 . To me it is not clear what is the difference between win64 and x86_64. The same for i386 and win32. What are is the criteria to choose the first or the second? If it makes a difference do i have to distinguish between arm and ... ? Does -i386 and -arch=i386 mean the same? Thank you for enlightening me Stefan

2 1

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 3).
by Alexandre Julliard March 8, 2013

March 8, 2013

Sergey Guralnik <serhio(a)etersoft.ru> writes: > This patch demonstrates the most interest case from previous versions. > When SetWindowPos() moves child window, that has some invalid > area, it also invalidates children of this window according to its > update region, even if moved window has WS_CLIPCHILDREN style. > > Wine doesn't perform this invalidation. > One pretty large application depends on this feature, and now, > runned under Wine, it has broken output. > > Hope this variant is more clear than all previous. It's better, but testing the message sequence doesn't seem very useful, particularly since you don't differentiate parent and child messages. Also you should test the region before the move to show that it's the move that's changing it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcr110: Add VS2012 C/C++ runtime
by Alexandre Julliard March 8, 2013

March 8, 2013

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -0,0 +1,2260 @@ > +# MS VC++2012 runtime library > + > +@ stub -arch=arm ??0?$_SpinWait@$00(a)details@Concurrency@@QAA(a)P6AXXZ@Z > +@ stub -arch=win32 ??0?$_SpinWait@$00(a)details@Concurrency@@QAE(a)P6AXXZ@Z > +@ stub -arch=win64 ??0?$_SpinWait@$00(a)details@Concurrency@@QEAA(a)P6AXXZ@Z > +@ stub -arch=arm ??0?$_SpinWait@$0A@@details(a)Concurrency@@QAA(a)P6AXXZ@Z > +@ stub -arch=win32 ??0?$_SpinWait@$0A@@details(a)Concurrency@@QAE(a)P6AXXZ@Z > +@ stub -arch=win64 ??0?$_SpinWait@$0A@@details(a)Concurrency@@QEAA(a)P6AXXZ@Z > +@ stub -arch=arm,win32 ??0SchedulerPolicy(a)Concurrency@@QAA(a)IZZ That doesn't make much sense, arm is win32 too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winhttp: Implement WINHTTP_OPTION_CONNECTION_INFO. (try 2)
by Alexandre Julliard March 8, 2013

March 8, 2013

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/winhttp/session.c | 71 ++++++++++++++++++++++++++++++++++++++++++ > dlls/winhttp/tests/winhttp.c | 62 ++++++++++++++++++++++++++++++++++++ > include/winhttp.h | 16 ++++++++++ > 3 files changed, 149 insertions(+) Now it breaks the Android build... i686-linux-android-gcc -c -I../../../../wine/dlls/winhttp -I. -I../../../../wine/include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -o session.o ../../../../wine/dlls/winhttp/session.c ../../../../wine/dlls/winhttp/session.c: In function 'convert_sockaddr': ../../../../wine/dlls/winhttp/session.c:609:25: error: 'struct WS_sockaddr_in' has no member named '__pad' make[1]: *** [session.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemac: fix compilation on Lion and later
by Ken Thomases March 8, 2013

March 8, 2013

On Mar 7, 2013, at 4:15 PM, C.W. Betts wrote: > This patch defines __gltypes_h_ so that the Mac header doesn't get included. Thanks! -Ken

1 0

Re: [PATCH 1/7] winemac: Implement OpenGL support.
by C.W. Betts March 7, 2013

March 7, 2013

It seems like there's conflicting types for GLhandleARB, one defined by Wine, the other by OS X, on Mountain Lion. I assume that the #define __gl_h_ is a try to work around the issue, but OS X's gltypes.h still gets included. On Mar 6, 2013, at 3:59 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/Makefile.in | 4 +- > dlls/winemac.drv/cocoa_opengl.h | 32 + > dlls/winemac.drv/cocoa_opengl.m | 154 ++++ > dlls/winemac.drv/cocoa_window.m | 187 ++++ > dlls/winemac.drv/gdi.c | 2 +- > dlls/winemac.drv/macdrv.h | 10 + > dlls/winemac.drv/macdrv_cocoa.h | 15 + > dlls/winemac.drv/opengl.c | 1912 +++++++++++++++++++++++++++++++++++++++ > dlls/winemac.drv/window.c | 11 +- > 9 files changed, 2322 insertions(+), 5 deletions(-) > create mode 100644 dlls/winemac.drv/cocoa_opengl.h > create mode 100644 dlls/winemac.drv/cocoa_opengl.m > create mode 100644 dlls/winemac.drv/opengl.c > > <0001-winemac-Implement-OpenGL-support.patch>

2 3

Re: [2/2] winhttp: Implement WINHTTP_OPTION_CONNECTION_INFO.
by Alexandre Julliard March 7, 2013

March 7, 2013

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -25,6 +25,9 @@ > > #include "windef.h" > #include "winbase.h" > +#define USE_WS_PREFIX > +#include "winsock2.h" > +#include "ws2ipdef.h" > #include "winhttp.h" > #include "wincrypt.h" > #include "winreg.h" This breaks the Mingw build here: In file included from ../../../wine/dlls/winhttp/session.c:39:0: ../../../wine/dlls/winhttp/winhttp_private.h:124:29: error: field ‘sockaddr’ has incomplete type ../../../wine/dlls/winhttp/winhttp_private.h:230:49: warning: ‘struct sockaddr’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/winhttp_private.h:230:49: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] ../../../wine/dlls/winhttp/winhttp_private.h:238:66: error: unknown type name ‘socklen_t’ ../../../wine/dlls/winhttp/session.c:594:44: warning: ‘struct sockaddr’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘convert_sockaddr’: ../../../wine/dlls/winhttp/session.c:596:21: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:598:10: error: ‘AF_INET’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:598:10: note: each undeclared identifier is reported only once for each function it appears in ../../../wine/dlls/winhttp/session.c:604:39: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:605:48: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:609:10: error: ‘AF_INET6’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:615:40: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:616:44: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:617:49: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:627:283: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c: In function ‘request_query_option’: ../../../wine/dlls/winhttp/session.c:731:25: error: storage size of ‘local’ isn’t known ../../../wine/dlls/winhttp/session.c:732:9: error: unknown type name ‘socklen_t’ ../../../wine/dlls/winhttp/session.c:746:9: warning: implicit declaration of function ‘getsockname’ [-Wimplicit-function-declaration] ../../../wine/dlls/winhttp/session.c:748:9: warning: passing argument 1 of ‘convert_sockaddr’ from incompatible pointer type [enabled by default] ../../../wine/dlls/winhttp/session.c:594:13: note: expected ‘const struct sockaddr *’ but argument is of type ‘const struct sockaddr *’ ../../../wine/dlls/winhttp/session.c:731:25: warning: unused variable ‘local’ [-Wunused-variable] ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1230:63: warning: ‘struct sockaddr_in’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘printf_addr’: ../../../wine/dlls/winhttp/session.c:1233:15: warning: implicit declaration of function ‘ntohl’ [-Wimplicit-function-declaration] ../../../wine/dlls/winhttp/session.c:1233:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1234:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1235:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1236:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1239:41: warning: ‘struct addrinfo’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c:1248:66: warning: ‘struct addrinfo’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘build_wpad_url’: ../../../wine/dlls/winhttp/session.c:1252:15: error: ‘NI_MAXHOST’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:20: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1256:35: error: ‘AF_INET’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:48: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1256:63: error: ‘AF_INET6’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:80: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1259:5: warning: passing argument 1 of ‘reverse_lookup’ from incompatible pointer type [enabled by default] ../../../wine/dlls/winhttp/session.c:1239:12: note: expected ‘const struct addrinfo *’ but argument is of type ‘const struct addrinfo *’ ../../../wine/dlls/winhttp/session.c:1252:10: warning: unused variable ‘name’ [-Wunused-variable] ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1205:14: warning: ‘get_computer_name’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1221:13: warning: ‘is_domain_suffix’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1230:13: warning: ‘printf_addr’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1248:15: warning: ‘build_wpad_url’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c: In function ‘convert_sockaddr’: ../../../wine/dlls/winhttp/session.c:630:1: warning: control reaches end of non-void function [-Wreturn-type] make[1]: *** [session.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9 [patch 1/2, try 3]: Implement D3DXSHEvalConeLight
by Nozomi Kodama March 7, 2013

March 7, 2013

hello Still problems with this patch? Nozomi.

2 1

wiki.winehq.org is down
by Michael Stefaniuc March 7, 2013

March 7, 2013

Hey Dimi, the wiki is down: <puk> is the wiki down? <puk> it pings <puk> but with high latency <puk> and while port 80 connects a GET / doesn't returns thanks bye michael

1 0

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 3).
by Sergey Guralnik March 7, 2013

March 7, 2013

On 2013-03-04 10:39, Sergey Guralnik wrote: > This patch demonstrates the most interest case from previous > versions. > When SetWindowPos() moves child window, that has some invalid > area, it also invalidates children of this window according to its > update region, even if moved window has WS_CLIPCHILDREN style. > > Wine doesn't perform this invalidation. > One pretty large application depends on this feature, and now, > runned under Wine, it has broken output. > > Hope this variant is more clear than all previous. It stays queued since Monday without any reply. Is something wrong with it? -- Sergey

1 0

Re: Use accented letters in their names.
by Frédéric Delanoy March 6, 2013

March 6, 2013

> On 3/4/13, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: >> On Fri, Mar 1, 2013 at 5:01 PM, Tae Wong <seotaewong40(a)gmail.com> wrote: >>> The authors file is outdated and you want this updated with the >>> missing authors. Andrej Znidarsic should have Slovenian accented >>> letters for his last name. >>> >>> On 2/4/13, Tae Wong <seotaewong40(a)gmail.com> wrote: >>>> You will want to use accented letters in their authors names. >>>> >>>> Caolan McNamara >>>> Ferenc Wagner >>>> Marko Nikolic >>>> >>>> Every once and a while the GNOME Live website is down with an error on >>>> Netscape called “The operation timed out when attempting to contact .” >>>> - This paragraph should have a website name. You want to be unbanned >>>> in Amaterasu Translations and the DOS ain’t dead forums. >> >> Feel free to send a patch to wine-patches fixing those issues. >> On Wed, Mar 6, 2013 at 3:02 PM, Tae Wong <seotaewong40(a)gmail.com> wrote: > You’ve sent a patch to wine-patches but never got them fixed! I didn't send a patch, but you did (well, sort of, this wasn't really a patch, but a mere email) See http://wiki.winehq.org/SubmittingPatches for instructions (http://source.winehq.org/patches/ helps you see what is the status of your patch, in this case 94687) Note however that this authors list is likely autogenerated from git.("John Doo <email address>") email addresses, so it's up to the patch submitter to correctly spell his/her own name to begin with. Rewriting the history to fix this seems overkill to me. Hence, if you fix the AUTHORS file, your changes might be overwritten the next time the file is generated. Frédéric

1 0

ntdll: make NtDelayExecution a bit more efficient
by Joerg-Cyril.Hoehle＠t-systems.com March 6, 2013

March 6, 2013

You may try and find that MSDN or blog page where people explain the subtle differences of Sleep(0) and Sleep(1) on multi-core machines. Regards, Jörg Höhle

1 0

Re: [1/3] Make mac driver the default on OS X
by Ken Thomases March 6, 2013

March 6, 2013

On Mar 5, 2013, at 6:32 PM, Josh DuBois wrote: > --- > dlls/gdi32/driver.c | 102 +++++++++++++++++++++++++++++++++++++++++++-- > dlls/gdi32/gdi32.spec | 1 + > dlls/gdi32/gdi_private.h | 2 + > dlls/user32/driver.c | 27 ++++++------ > include/wine/gdi_driver.h | 11 +++++ > 5 files changed, 125 insertions(+), 18 deletions(-) > > <0001-Track-and-report-multiple-errors-loading-display-drive.txt> As I believe you're aware, I think that the Mac driver should not be made the default until OpenGL and clipboard support are in. So, maybe this was just submitted in preparation for that time, but there should probably have been a note to that effect. Also, this patch seems exceedingly complex for a relatively simple problem. Just because it has historically been user32 that reported failure to load the driver doesn't mean it must remain so, at least to my way of thinking. Why not just print out the diagnostics directly in gdi32 as each attempt to load a driver fails? In user32, there can be a secondary, driver-agnostic message about failure to create a window. > + case ERROR_DLL_INIT_FAILED: > + load_err->err_msg = "Make sure you have permission to create \na window or check for errors with Console.app. \n(The Mac driver cannot do remote display: try X11 if you need that.)"; > + break; "Make sure you have permission to create a window" doesn't mean anything to me. Checking Console.app isn't very useful either. If the user sees this message, then they're already looking at wherever the process's output is going. Running Wine from a shell won't write anything to the console logs. As of Mountain Lion, running it from a GUI app won't either; Apple changed things so that stdout and stderr of GUI apps go to /dev/null rather than console logs. (Only things like NSLog() or asl_log() go to the console log.) Probably it's just best to say that the Mac driver is running in a non-GUI session such as a remote login. -Ken

2 1

Re: qcap: Fix compilation on systems that have v4l1 but not VIDIOCMCAPTURE & co.
by Alexandre Julliard March 6, 2013

March 6, 2013

Francois Gouget <fgouget(a)free.fr> writes: > In particular this fixes compilation on FreeBSD 8.1. > > configure | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++ > configure.ac | 18 +++++++++++++ > dlls/qcap/v4l.c | 4 +-- > include/config.h.in | 3 +++ > 4 files changed, 97 insertions(+), 2 deletions(-) It's not very useful to add a configure check for a #define, you can check for it directly. -- Alexandre Julliard julliard(a)winehq.org

1 0