March 2013 - Wine-Devel - list.winehq.org

Re: gdi32: Copy gamma ramp validation from winex11 to make it driver independent
by Dmitry Timoshkov March 22, 2013

March 22, 2013

André Hentschel <nerv(a)dawncrow.de> wrote: > - this was done for the mac driver > - i tried to follow the file-style, except of the original variable naming The ERRs should be downgraded to WARNs or even TRACEs, there is no point to loudly complain on application input. -- Dmitry.

1 0

[GSoC] My proposal for GSoC 2013
by Gediminas Jakutis March 21, 2013

March 21, 2013

Hello! My name is Gediminas Jakutis. I study Informatics Engineering [bachelor / undergraduate] at Kaunas University of Technology, second year. I wish to try out GSoC for the first time by helping to improve Wine. My primary programming language is C. I am self-taught in C, but I believe my knowledge is good enough. I am quite familiar with Wine - I use it and experiment with it for many years now. I am subscribed to and read wine-devel for more than a year. I browse through Wine's source code once in a while out of curiosity. Thus, I have some knowledge of its structure. Sadly, I have not written any patches for Wine yet. Mostly due to lack of confidence. For GSoC, I am suggesting my own idea. In case this idea is not good, I am open to changing it, thinking of a new one, or adopting one. My idea: I have noticed that Wine's virtual desktop feature is very limited - if the first program on a prefix starts without a virtual desktop, all programs launched during the same session also start without a VD, disregarding any VD settings and/or requests with environment variables. And vice versa - if the first program starts inside a VD, all other programs in that sessions start in the VD. Often, this can be worked around by using separate Wine prefixes. Yet sometimes, this workaround is not possible. A good example: steam and games that only run properly in a VD. This forces the user to start steam in a VD and makes steam itself unusable while a game is running, especially if the game does not support the steam overlay. I would like to fix this limitation and make it possible to properly choose to run different programs on one prefix with or without a VD regardless what was chosen to programs already running in that prefix. I can already see this requiring changes in the winecfg utility, by the way. In case this turns out to be too easy of a project, I could implement some way to perform "alt-tabbing" between programs in a VD and/or an optional (enable-able in winecfg) rudimentary taskbar for changing/checking focus. I am very excited about participating in GSoC. And even more excited about starting to contribute to Wine by writing patches! Regardless if I get accepted or not, I wish to make Wine better. Thus, expect me to start submitting patches in the future even if I do not get accepted. ;] Sincerely, Gediminas Jakutis ---- LDK Varčiai www.varciai.lt

3 3

Re: winemac: Implement GetDeviceGammaRamp() and SetDeviceGammaRamp().
by André Hentschel March 20, 2013

March 20, 2013

Am 18.03.2013 04:41, schrieb Ken Thomases: > --- > dlls/winemac.drv/display.c | 131 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/winemac.drv/gdi.c | 4 +- > dlls/winemac.drv/macdrv.h | 2 + > 3 files changed, 135 insertions(+), 2 deletions(-) Hi, wrt macdrv_SetDeviceGammaRamp, the X11 driver has some validation in xvidmode.c->ComputeGammaFromRamp() because windows doesn't allow every ramp. It might happen that apps try bad ramps and the screen simply gets dark without validation. I'll see if i can copy/move the validation to gdi32 where the driver function normally get's called so that the validation is driver independent. -- Best Regards, André Hentschel

2 1

Re: [PATCH 2/2] msvcrt: Fixed fgetwc behavior on multibyte characters and unicode files
by Akihiro Sagawa March 20, 2013

March 20, 2013

On Mon, 18 Mar 2013 17:11:04 +0100, Piotr Caban wrote: > + char mbs[2]; This should be a constant, like MSVCRT_MB_LEN_MAX. > + int len = 0; > + ch = MSVCRT_fgetc(file); > + if(ch != MSVCRT_EOF) { > + mbs[0] = (char)ch; > + if(MSVCRT_isleadbyte(mbs[0])) { This doesn't work correctly if char is signed. Because _isleadbyte() expects the value of unsigned char or EOF as well as other is- functions. I wrote some fgetwc() tests. Please refer following page: https://testbot.winehq.org/JobDetails.pl?Key=24806 Akihiro Sagawa

2 1

Re: [7/10] winemenubuilder: Create a basic Info.plist.
by Ken Thomases March 20, 2013

March 20, 2013

On Mar 17, 2013, at 12:18 PM, Per Johansson wrote: > + namestr = CFStringCreateWithCString(NULL, link_name, CFStringGetSystemEncoding()); You should use CFStringCreateWithFileSystemRepresentation() to create CFStrings from POSIX path strings. > + pathstr = CFStringCreateWithCString(NULL, path, CFStringGetSystemEncoding()); Same thing here. > + data = CFPropertyListCreateData(NULL, propertyList, format, 0, &err); Since you don't use "err", just pass NULL. -Ken

2 1

Re: [10/10] winemenubuilder: Put appbundle icon inside the bundle.
by Ken Thomases March 19, 2013

March 19, 2013

On Mar 17, 2013, at 12:18 PM, Per Johansson wrote: > + CFStringRef iconstr = CFStringCreateWithCString(NULL, icon, CFStringGetSystemEncoding()); Another place to use CFStringCreateWithFileSystemRepresentation(). -Ken

1 0

Re: msvcr110: add a stub for __crtGetShowWindowMode
by Dmitry Timoshkov March 18, 2013

March 18, 2013

Austin English <austinenglish(a)gmail.com> wrote: > +int CDECL __crtGetShowWindowMode(void) > +{ > + FIXME(": stub!\n"); > + return 0; > +} Isn't it supposed to return SW_SHOW and other SW_xxx commands, specified at process creation time (SW_SHOWDEFAULT)? In that case returning 0 (SW_HIDE) is not a very good choice. -- Dmitry.

1 0

Re: [0/10] Launcher app bundles on OS X
by C.W. Betts March 18, 2013

March 18, 2013

A quick glance at the source revealed that you removed static from some functions. Why? If a function isn't being called outside a source file, it's better to have it be static. This includes functions referenced in structs (but not the structs themselves). A more seasoned developer is welcome to correct me if I'm wrong. On Mar 17, 2013, at 11:18 AM, Per Johansson <per(a)morth.org> wrote: > I'm resending this now after testing it with the Mac driver. > They work well together, the launcher bundle will first briefly > appear in the dock, then exit, and the mac driver icon appears. > > It's split it up into parts for easier review. I've also tried > to make sure that even if e.g. part 6 fails review, part 1 - 5 > can still be applied. > > File type associations are not included because I plan to move > that code into the mac driver but haven't gotten around to it yet. > > Regards, > -- > Per Johansson > > >

2 1

Re: [website] Portuguese translation for release 1.5.25
by Bruno Jesus March 18, 2013

March 18, 2013

2013/3/18 Lucas Zawacki <lfzawacki(a)gmail.com>: > From: Lucas Zawacki <lfzawacki(a)gmail.com> > > --- > news/pt/2013030101.xml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 news/pt/2013030101.xml > > diff --git a/news/pt/2013030101.xml b/news/pt/2013030101.xml > new file mode 100644 > index 0000000..ae13cfd > --- /dev/null > +++ b/news/pt/2013030101.xml > @@ -0,0 +1,14 @@ > +<news> > +<date>1 de Março de 2013</date> > +<title>Wine 1.5.25 lançado</title> > +<body> > + A versão de desenvolvimento 1.5.25 já está disponível agora. > + <a href="{$root}/announce/1.5.25">Novidades</a> desta versão: > +<ul> > + <li>Suporte adequado ao cursor no driver de Mac.</li> > + <li>Correções no suporte a escrita direita-para-esquerda no RichEdit.</li> > + <li>Versão inicial da uma fonte Wingdings.</li> Should be: Versão inicial de uma fonte Wingdings. Or: Versão inicial da fonte Wingdings. > + <li>Várias correções de bugs.</li> > +O código fonte está <a href="http://prdownloads.sourceforge.net/wine/wine-1.5.25.tar.bz2">disponível agora</a>. > +Pacotes binários estão em processo de construção e irão aparecer em breve em suas respectivas <a href="{$root}/download">sessões da área de downloads</a>. > +</body></news> > -- > 1.7.9.5 > > > Best wishes, Bruno

2 1

Re: usp10: Support GPOS extension lookup subtables
by Aric Stewart March 18, 2013

March 18, 2013

Hi Phil, Thank you for being patient I am back from vacation and reviewing your patch. The logic looks great and just fine. Do you happen to have a font that uses lookup type 9 that I can run my usp test suite on to make sure it functions as expected? thanks! -aric On 3/8/13 10:47 AM, Phil Krylov wrote: > > > >

1 0