April 2013 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

Re: Raise the minimum version of FreeBSD to 8.0.
by Frédéric Delanoy Oct. 27, 2013

Oct. 27, 2013

On Sun, Mar 3, 2013 at 12:22 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > We've had this as a requirement in the FreeBSD ports for quite a > while (and the Wiki describes some background). > > Gerald > --- > - FreeBSD 7.0 or later > + FreeBSD 8.0 or later > ... > FreeBSD info: > - Wine will generally not work properly on versions before FreeBSD 7.0. > + Wine will generally not work properly on versions before FreeBSD 8.0. You should also change the version in the various README.xx translations (in 'documentation' directory). Frédéric

3 2

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: Web based translation tool
by Michal Čihař June 18, 2013

June 18, 2013

Hi Dne Mon, 12 Mar 2012 12:02:49 +0200 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > The Wine project is thinking about using Weblate in order to translate > Wine, you can look at the following discussion and see for yourself. That sounds great! > Looking good although a litle immature, not sure about authentication as > wel... For authentication you can basically use anything what can be used in Django. Any specific concerns on this topic? > I'll talk to Michal Cihar and ask him for a roadmap for this project. Well I don't have any real roadmap right now. I urgently needed replacement for Pootle because we got hit by too many bugs there and did not manage to understand the code there to be able to fix them myself. So far I think it is in pretty good shape for day to day work (with today's 0.5 release fixing few annoying bugs). Of course there are some features missing, you can check what I plan for 1.0 release here: https://github.com/nijel/weblate/issues?state=open&milestone=1 I currently hope to have 1.0 in a month or so, but I really don't want to commit to any specific date. PS: I'm not subscribed to mailing list so please CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

7 16

[PATCH v6 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky June 11, 2013

June 11, 2013

Main changes from v5: 1) O_DENYDELETE is now supported by VFS. 2) ESHAREDENIED erro code is introduced to be returned on sharelock conflicts. 3) forcemand dependancy is removed. CIFS module detects if it should use NTCreateAndX command according to existence of O_DENY flags. 4) Term 'deny lock' is replaced by 'sharelock' (function names, code comments, patch descriptions). Main changes from v4: 1) deny_lock_file uses FS_DOES_SHARELOCK flag from fs_flags to determine whether to use VFS locks or not. 2) Make nfs code return -EBUSY for share conflicts (was -EACCESS). Main changes from v3 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), The patchset avoid data races problem on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a sharelock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This lets us not mix one share reservation approach with another. The #1 patch adds flags to fcntl and implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -ESHAREDENIED in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ESHAREDENIED untill this open is closed. Now this flag is processed by VFS and CIFS filesystem. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND 3) !O_DENYDELETE -> LOCK_DELETE | LOCK_MAND ----- Pavel Shilovsky (7): VFS: Introduce new O_DENY* open flags VFS: Add O_DENYDELETE support for VFS CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts fs/cifs/cifsacl.c | 8 +- fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 ++++- fs/cifs/cifsproto.h | 8 +- fs/cifs/cifssmb.c | 50 +++++++------ fs/cifs/dir.c | 16 ++-- fs/cifs/file.c | 25 +++++-- fs/cifs/inode.c | 21 +++--- fs/cifs/link.c | 25 ++----- fs/cifs/netmisc.c | 2 +- fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 ++-- fs/cifs/smb2file.c | 10 +-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 10 ++- fs/cifs/smb2pdu.c | 6 +- fs/cifs/smb2proto.h | 14 ++-- fs/fcntl.c | 5 +- fs/locks.c | 158 ++++++++++++++++++++++++++++++++++++--- fs/namei.c | 48 +++++++++++- fs/nfs/dir.c | 4 + fs/nfs/internal.h | 3 +- fs/nfs/nfs4file.c | 4 + fs/nfs/nfs4proc.c | 4 +- fs/nfs/nfs4super.c | 9 ++- fs/nfs/nfs4xdr.c | 21 +++++- fs/nfs/super.c | 7 +- fs/nfsd/nfs4state.c | 46 +++++++++++- fs/nfsd/nfsproc.c | 1 + fs/proc_namespace.c | 1 + include/linux/fs.h | 14 ++++ include/uapi/asm-generic/errno.h | 2 + include/uapi/asm-generic/fcntl.h | 12 +++ include/uapi/linux/fs.h | 1 + 35 files changed, 443 insertions(+), 139 deletions(-) -- 1.8.1.5

4 13

Re: [AppDB] version: Only display comments section in case version has maintainers
by Christopher Cope May 2, 2013

May 2, 2013

I understand the premise, but I disagree. A lot of apps that I use don't have maintainers. However, the comments are typically helpful. I believe this should be approached differently. "André Hentschel" <nerv(a)dawncrow.de> wrote: >Am 28.04.2013 18:57, schrieb Rosanne DiMesio: >> Forced moderation of comments could work for apps with maintainers >who are doing their job, but most of the spam I recently deleted was in >unmaintained apps. My suggestion would be to block comments altogether >on unmaintained apps, not just because of spam, but because of other >inappropriate things that are not being monitored, such as posting >links to illegal downloads. As for the maintainers who clearly aren't >doing their jobs (about 20-25% of the spam I found was in entries with >maintainers), admins already have the capability of removing them. > > >--- > include/version.php | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/include/version.php b/include/version.php >index 8f02b24..bf1d7ab 100644 >--- a/include/version.php >+++ b/include/version.php >@@ -1180,9 +1180,12 @@ class version { > > echo note::displayNotesForEntry($this->iVersionId); > >- // Comments Section >- if($this->iVersionId) >- Comment::view_app_comments($this->iVersionId); >+ if(sizeof($aMaintainers)>0) >+ { >+ // Display comments section in case version has >maintainers >+ if($this->iVersionId) >+ Comment::view_app_comments($this->iVersionId); >+ } > } > > public static function lookup_name($versionId) >-- >1.7.10.4

3 4

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics. (try 3)
by Alexandre Julliard May 1, 2013

May 1, 2013

Sam Edwards <cfsworks(a)gmail.com> writes: > Content-wise, this is the same as try 2. However, there are two differences: > > 1. I merged the tests down into the same patch. > 2. This won't crash anymore: see patch 1 in this series. It still crashes: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff550f680 in get_glyph_outline (incoming_font=<optimized out>, glyph=<optimized out>, format=24, lpgm=0x20, abc=0x22c7d0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:6389 6389 ((unsigned int)src[hmul * x + rgb_interval * 2] << 0) | (gdb) bt #0 0x00007ffff550f680 in get_glyph_outline (incoming_font=<optimized out>, glyph=<optimized out>, format=24, lpgm=0x20, abc=0x22c7d0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:6389 #1 0x00007ffff550fd1e in freetype_GetGlyphOutline (dev=0x40df0, glyph=<optimized out>, format=<optimized out>, lpgm=0x22c9f0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:7133 #2 0x00007ffff54fcd84 in GetGlyphOutlineW (hdc=<optimized out>, uChar=103, fuFormat=17, lpgm=0x22c9f0, cbBuffer=288, lpBuffer=0x538c4, lpmat2=0x7ffff5535140) at ../../../wine/dlls/gdi32/font.c:2813 #3 0x00007ffff54c97b5 in render_string (hdc=0x490031, dib=<optimized out>, font=0x43cb0, x=95, y=11, flags=12288, str=0x51b70, count=13, dx=0x53470, clipped_rects=0x22cbb0, bounds=0x22cba0) at ../../../wine/dlls/gdi32/dibdrv/graphics.c:707 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 4/4] d3dx9_36: Remove todo in tests as it works now with last d3dxof fixes.
by Matteo Bruni May 1, 2013

May 1, 2013

2013/4/29 Christian Costa <titan.costa(a)gmail.com>: > > --- > dlls/d3dx9_36/tests/xfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/d3dx9_36/tests/xfile.c b/dlls/d3dx9_36/tests/xfile.c > index 1238bcd..e514a5f 100644 > --- a/dlls/d3dx9_36/tests/xfile.c > +++ b/dlls/d3dx9_36/tests/xfile.c > @@ -77,7 +77,7 @@ static void test_templates(void) > ok(ret == D3DXFERR_BADFILEFLOATSIZE, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_BADFILEFLOATSIZE); > > ret = d3dxfile->lpVtbl->RegisterTemplates(d3dxfile, templates_parse_error, sizeof(templates_parse_error) - 1); > - todo_wine ok(ret == D3DXFERR_PARSEERROR, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_PARSEERROR); > + ok(ret == D3DXFERR_PARSEERROR, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_PARSEERROR); > > ret = d3dxfile->lpVtbl->RegisterTemplates(d3dxfile, templates, sizeof(templates) - 1); > ok(ret == S_OK, "RegisterTemplates failed with %#x\n", ret); Hi Christian, good catch for that todo_wine. However, this should be merged with the patch actually fixing the test (I guess it's patch 2).

2 1

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)
by Alexandre Julliard April 30, 2013

April 30, 2013

Sam Edwards <cfsworks(a)gmail.com> writes: > From a2905abf287ff1ac44c93119d76b14b6fc3992c3 Mon Sep 17 00:00:00 2001 > From: Sam Edwards <CFSworks(a)gmail.com> > Date: Sat, 20 Apr 2013 05:48:07 -0600 > Subject: gdi32: Clip font glyphs to fit within text metrics. It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so ../../../../wine/dlls/comctl32/tests/listview.c && touch listview.ok wine: Unhandled page fault on write access to 0x400053b34 at address 0x2b4c3d69e6b7 (thread 0398), starting debugger... winedbg: Internal crash at 0x2b53f78066b7 make: *** [listview.ok] Error 84 -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: [2/2] include: Make KNONVOLATILE_CONTEXT_POINTERS match PSDK definition.
by Dmitry Timoshkov April 30, 2013

April 30, 2013

Hi, This patch has status "Build failure", but it compiles without errors here with 32 and 64-builds. What kind of a failure is that? -- Dmitry.

2 1

Re: kernel32: Add some tests for PEB and loader locks.
by Marvin April 30, 2013

April 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25367 Your paranoid android. === TEST64_W7SP1 (32 bit loader) === loader.c:1952: Test failed: WaitForSingleObject failed: 102 loader.c:1954: Test failed: expected exit code 199, got 259 loader.c:1963: Test failed: WaitForSingleObject failed: 102 loader.c:1968: Test failed: expected 198, got 259 loader.c:1972: Test failed: expected STATUS_PROCESS_IS_TERMINATING, got 0 loader.c:2018: Test failed: expected ERROR_ACCESS_DENIED, got 487 loader.c:2028: Test failed: VirtualFreeEx should fail loader.c:2029: Test failed: expected ERROR_ACCESS_DENIED, got -559038737 loader.c:2032: Test failed: VirtualAllocEx should fail loader.c:2033: Test failed: expected ERROR_ACCESS_DENIED, got -559038737 loader.c:2042: Test failed: expected STATUS_PROCESS_IS_TERMINATING, got 0

1 0

Re: riched20: Fix richtext copy/paste to OOffice.
by Nikolay Sivov April 30, 2013

April 30, 2013

On 4/30/2013 10:20, Sergey Guralnik wrote: > When copying cyrillic text from wordpad (or any richedit) > to Open Office document I get unreadable text. It seems > like some another codepage was used to display text. > This path solves this problem. > --- > dlls/riched20/writer.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > Is it really supposed to do that? Does native module help?

2 1

Re: server: Map update region to children even if window just moved.
by Sergey Guralnik April 30, 2013

April 30, 2013

On 2013-04-25 16:06, Sergey Guralnik wrote: > --- > dlls/user32/tests/win.c | 1 - > server/window.c | 5 +++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Is something wrong with this one? -- Sergey

1 0

[GSOC2013] [Tools - Winetest Graphical User Interface]
by Nouri Hamza April 30, 2013

April 30, 2013

Hi, My name is Hamza Nouri,23 years old. I'm in my second year of computer science engineering at Esprit,Tunis,Tunisia. I'm also Candidate for “Informatique et mathématiques Appliqués à la finance et aux assurances” (I.M.A.F.A) – a one year specialized postgraduate degree in computer science and mathematics applied to finance and insurances. I've took a look at Wine and found the project very promising. and i'm excited to partipate in coding for Wine and giving a help to Wine Users around the world. Regarding my technical skills, i have an experience in c/c++, java ,php,mysql and HTML5. i've done some projects using these languages that you can find in my personnal blog (http://tunisiansimpson.blogspot.com/) Here an example of Kakuro game made with language C that i've made last year : http://tunisiansimpson.blogspot.com/2012/12/kakuro.html I'm interested in the project "Tools - Winetest Graphical User Interface". I've already installed Wine and i'm starting using it. I have no prior experience in Open Source development, and i found this a good opportunity to begin coding for the good wealth of the international community. About my availability at the summer, i'll be free starting from the 9th June. I'll be pleased if you can provide me more details about the "Tools - Winetest Graphical User Interface" project and advice me with the better ways to succed my proposal. Hamza nouri best regards. Email address : hamza.nouri(a)esprit.tn CV : docs.google.com/a/esprit.tn/file/d/0B9vfb3FMh7gDU2JrRUQ2aF9PZGM/edit CV : twitter.com/tunisiansimpson Blog : tunisiansimpson.blogspot.com/ Facebook : www.facebook.com/nourihamza89

1 0

[GSOC 2013] Tools - Implement new control panel applets
by Kaiyi Zhang April 30, 2013

April 30, 2013

I'm Kaiyi Zhang,A Computer Science and Engineering student from Civil Aviation University of China.I hear the GSOC and I'm very Interested in this,I look through many projects until i see the "Tools - Implement new control panel applets". I have used wine for a long time,it's very useful and i love it,it is the first time i apply for the GSOC. when i see the wine is also in the list,i decide to contribute to the wine ,i have learned the c program language which required to this project, but i know the more things i need to learn..I have confidence in doing this well,one of my best technologies is using the internet ,search the information i want.. I send for this email to see if i'm on the right track. Look forward to you reply,Thanks for reading..

2 2

Re: [PATCH] kernel32: Fixed string comparision for non-canonical locale identifiers such as zh_CN VS zh-Hans on OS X.
by Ken Thomases April 29, 2013

April 29, 2013

On Apr 29, 2013, at 3:41 PM, Qian Hong wrote: > Thanks Ken for many helps! You're welcome and, regarding the patch: looks good to me. -Ken

1 0

Re: [AppDB]: Only display comments section in case version has maintainers
by Joerg Schiermeier April 29, 2013

April 29, 2013

Hi list, > Forced moderation of comments could work for apps with maintainers > who are doing their job, but most of the spam I recently deleted was > in unmaintained apps. This will be the first step towards a better maintained AppDB! > My suggestion would be to block comments > altogether on unmaintained apps, not just because of spam, but > because of other inappropriate things that are not being monitored, > such as posting links to illegal downloads. For me it seems to be a got idea to get the maintainers more in charge also to everything around their maintained applications. I general I would like to have this submitted patch in the actual AppDB. And if it is so bad for some maintainers, they might start a new discussion here.. Thanks to all who did some work when creating an patch and wrote some issues here! -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: opengl32: add a test for WGL_EXT_swap_control [try 2]
by Ken Thomases April 29, 2013

April 29, 2013

On Apr 29, 2013, at 10:42 AM, Roderick Colenbrander wrote: > Updated version of the patch which marks the failing test as todo_wine. The > final goal is to make the swap interval in the winex11 driver not global > anymore (and store it with the drawable) and add some new functionality. > <0001-opengl32-add-a-test-for-WGL_EXT_swap_control.patch> For what it's worth, the Mac driver does it (apparently) wrong but in the other way. In the Mac driver, the swap interval is currently part of the context state, so not part of the drawable. But it's definitely not global. -Ken

1 0

Re: opengl32: add a test for WGL_EXT_swap_control
by Alexandre Julliard April 29, 2013

April 29, 2013

Roderick Colenbrander <thunderbird2k(a)gmail.com> writes: > From 1a9ce7c13bef6e600bc9893f93da8770c8fc7767 Mon Sep 17 00:00:00 2001 > From: Roderick Colenbrander <thunderbird2k(a)gmail.com> > Date: Sun, 28 Apr 2013 16:39:28 -0700 > Subject: [PATCH] opengl32: add a test for WGL_EXT_swap_control > > --- > dlls/opengl32/tests/opengl.c | 123 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 123 insertions(+) It doesn't work here: ../../../tools/runtest -q -P wine -M opengl32.dll -T ../../.. -p opengl32_test.exe.so opengl.c && touch opengl.ok opengl.c:1584: Test failed: Expected swap interval 1, got 0 make[1]: *** [opengl.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [AppDB] version: Only display comments section in case version has maintainers
by Rosanne DiMesio April 29, 2013

April 29, 2013

> > So volunteer to be a maintainer. > > > > > That is all good and well, but most of the time I check the wine page > before I buy a game. If there are no maintainers and this is active, > there will be no comments, I will be unsure about the likelihood of it > working. Reports would still be helpful, but most of the time, the > majority of the information ends up in the comments section. > All the more reason to disable comments. The information belongs in test reports. Comments get deleted periodically, test reports don't. -- Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

[AppDB]: Recent UCE/Spam waves in AppDBs comments
by Joerg Schiermeier April 28, 2013

April 28, 2013

Hi list, hello Rosanne, I just saw again a lot of spam posted into the AppDB. Thanks to Rosanne who deleted this senseless and useless mails rapidly. But isn't there a real solution for this problem? OK, to kill this guys maybe the best way, but than I will get seriously problems. :-) So please, isn't there a way to set up a filter - for user names or, with more effect, for IPs of this bad guys ISPs? I know, this will cause 'collateral damage' but if it helps to prevent the next wave of spam - I think it's OK. This maybe a task for AppDBs administrator, isn't it? -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1

Re: winex11.drv: Fixed XInput2 errors with mislabeled mice axis.
by Dmitry Timoshkov April 28, 2013

April 28, 2013

"Cope, Christopher Edward" <ccope3(a)utk.edu> wrote: > @@ -1638,16 +1636,14 @@ static void X11DRV_RawMotion( XGenericEventCookie *xev ) > if (XIMaskIsSet( event->valuators.mask, class->number )) > { > double val = *values++; > - if (class->label == x11drv_atom( Rel_X ) || > - (!class->label && class->number == 0 && class->mode == XIModeRelative)) > + if (class->label == x11drv_atom( Rel_X ) || class->mode == XIModeRelative) > { > input.u.mi.dx = dx = val; > if (class->min < class->max) > input.u.mi.dx = val * (virtual_screen_rect.right - virtual_screen_rect.left) > / (class->max - class->min); > } > - else if (class->label == x11drv_atom( Rel_Y ) || > - (!class->label && class->number == 1 && class->mode == XIModeRelative)) > + else if (class->label == x11drv_atom( Rel_Y ) || class->mode == XIModeRelative) > { > input.u.mi.dy = dy = val; > if (class->min < class->max) How is this supposed to distinguish motion in X and Y direction? -- Dmitry.

1 0

Re: qedit/tests: Improve test messages
by Marvin April 27, 2013

April 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25328 Your paranoid android. === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588 === W2K8SE (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588

1 0

Re: qedit/tests: Improve test messages
by Marvin April 27, 2013

April 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25328 Your paranoid android. === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588 === W2K8SE (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588

1 0

[AppDB]: Recent UCE/Spam waves in AppDBs comments
by Joerg Schiermeier April 27, 2013

April 27, 2013

Hi list, hello Rosanne, I just saw again a lot of spam posted into the AppDB. Thanks to Rosanne who deleted this senseless and useless mails rapidly. But isn't there a real solution for this problem? OK, to kill this guys maybe the best way, but than I will get seriously problems. :-) So please, isn't there a way to set up a filter - for user names or, with more effect, for IPs of this bad guys ISPs? I know, this will cause 'collateral damage' but if it helps to prevent the next wave of spam - I think it's OK. This maybe a task for AppDBs administrator, isn't it? -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: netapi32: Add stub for NetGetAnyDCName
by Christian Costa April 27, 2013

April 27, 2013

Hi, + FIXME("(%s, %s, %p) stub!\n", debugstr_w(servername), + debugstr_w(domainname), bufptr); + return ERROR_NO_SUCH_DOMAIN; +} Please use 4 spaces indentation as the rest of the file. Christian Le 27/04/2013 14:05, Ruslan Kabatsayev a écrit : > Hello, > > This patch adds a stub for netapi32!NetGetAnyDCName(), which is needed > for e.g. KDE's dolphin to launch first time. I've done it similarly to > already present NetGetDCName() stub, but with another error code > return, which is among valid ones listed in MSDN. > > Regards, > Ruslan > >

2 1

Re: user32: SetTimer should respect the minimum and maximum timeout limits (try 2).
by Alexandre Julliard April 26, 2013

April 26, 2013

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > So, this particular patch fixes the minimum and maximum timeout limits > for SetTimer, which has a significant impact on any application using > SetTimer to render video (Bug #32489). The old minimum timeout (55 > ms) is nowhere near short enough to render video at 24 FPS, causing > "choppy" video behavior in a variety of Silverlight apps. Even though > MSDN indicates that the minimum timeout should be 10 ms, I'm using the > value established from the included tests instead (15 ms). That doesn't mean you can change the constant. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt.h: Use inline function to forward hypot to _hypot.
by Alexandre Julliard April 26, 2013

April 26, 2013

Jacek Caban <jacek(a)codeweavers.com> writes: > This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version. > Previous versions had a separated library that contained forwards from > underscored functions to non-underscored, which I believe made using > hypot work. Those were currently moved directly to msvcr* import libs, > which we don't use in favour of our our own ones. Don't you need to do that for the other functions too? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)
by Jacek Caban April 26, 2013

April 26, 2013

Hi Zhan, It's better, thanks, but still needs more work. On 04/25/13 23:37, Zhan Jianyu wrote: > } > > + > + While we're at this, please put more attention into whitespace changes, esp. useless ones. > static HRESULT to_double(VARIANT *v, double *ret) > { > switch(V_VT(v)) { > @@ -217,6 +221,27 @@ static HRESULT to_string(VARIANT *v, BSTR *ret) > return S_OK; > } > > + > +static HRESULT banker_rounding(double dbval, int *result_val) > +{ > + double frac_part; > + double int_part; > + > + *result_val = round(dbval); This has two problems: - you don't handle values that are out of int range by assigning double value to int - round is not portable. As I mentioned you before, Wine needs to be C89 compatible. If we need some features that are not part of C89, we need to be careful about that and it often requires things like configure checks. In case of round, replacing it with floor(x+0.5) does the trick pretty well. Cheers, Jacek

2 3

Names with particles on South Africa and Namibia should be in the particle on the AUTHORS file.
by Tae Wong April 26, 2013

April 26, 2013

You have posted a message to show how surnames with particles of South Africa and Namibia show in the credits, like van Schayck listed in S and not under V: For example, van Schayck is under S and not in V. Note that the name of the file is in all capitals. Here is a correction of the va section, with van Schyack placed on the letter by letter system. The file name is AUTHORS. It is a file in all capitals and the file content contains just the heading and some names of the developers. Note that the file is out of date. Vainer, Moshe Valoska, Hleb Valtonen, Hannu Vance, Carroll Vanek, Tomas van Schaik, Carl Vaughn, Charles

1 0

Re: [PATCH 1/2] wined3d: Set GL_NONE for glReadBuffer / glDrawBuffer on FBO initialization.
by Henri Verbeet April 26, 2013

April 26, 2013

Seems ok, though a small comment explaining the issue this patch fixes probably wouldn't hurt. On 25 April 2013 20:43, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + if (target == GL_READ_FRAMEBUFFER) > + context_bind_fbo(context, GL_DRAW_FRAMEBUFFER, draw_binding ? &draw_binding : 0); > + else > + context_bind_fbo(context, GL_READ_FRAMEBUFFER, read_binding ? &read_binding : 0); > I don't think using 0 here is strictly wrong, but a proper NULL would probably be clearer. As a followup, I think we can actually get rid of the glGenFramebuffers() in context_bind_fbo() these days and just pass a GLuint instead of a pointer. The only place left that actually creates FBOs should be context_apply_fbo_entry().

2 2

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool(try 3)
by Marvin April 25, 2013

April 25, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25302 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)
by Marvin April 25, 2013

April 25, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25301 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] wined3d: Add a new structure for for d3d limits and other info
by Stefan Dösinger April 25, 2013

April 25, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Please ignore this patch. I figured that my series might collide with Henri's, so I canceled the send process. And indeed there are conflicts, so I'll resend my patches rebased on top of Henri's. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJReSS/AAoJEN0/YqbEcdMwElkP/AiDEqVSaMxTW+sOaQava97g a0cOBpHTU+lInUuUXIS2WVe65D+IhkdYJHnMIrSUVdquvT1x+pLVgr+2J4jczFX7 /9Ay0gAjMVbKsKIYO4tvOQgSru/RdAljTg6uaIw+qTDrHZvQLW/sJu3JcbAp0GW7 9pGEzPvRr6hNsOyXE+DQlTEsT3vkbEUTRr01j4+znF50laYV2s3e5saZHyXULyY8 ObEf3n2ppQgcO4keQg7wAPLydw+xiNcYOw9724fh/xyezj8MXoT1CDHeio7yPfhg xp76kNWzNERQcWaDT7QXwuWLRXy5H3VodWm4PEMXvqXyxkJJycm2jECvTOTjrrke iswKGqh9n0gTWQjse2eUY/fKxpjhh/ySxDcJq093swHHbvrCngL8Q5dYu/Ch3cFu JbLu4pHla3iAmJKftVTT/iRq6vwsLB7tzloCoA7e8T+GFmsA39RPFI6zttCIoA60 kui5a4Ofd6/sGMFaqg2VBK+2crGJzVzN6VRvglg63A0hNr0UGbkFC/6iQK8FzxyA A+uPGr5Xrd/vGpKZksMMH68JiK5kYXm+fsiVI1F1rcAcfdh6STQBoThcig1N/HXu fA8daluv4+PgQ9RhgzlioBsVFGxkZ1FbM8XjKlcnKQb0ZK3DXLHLEzspvmBnr3Pi MK94F9BvqMDa6Wi57sgT =Wh/i -----END PGP SIGNATURE-----

1 0

Re: [0/4] Improve wineconsole and kernel32
by Frédéric Delanoy April 25, 2013

April 25, 2013

On Wed, Apr 24, 2013 at 9:15 AM, Hugh McMaster < hugh.mcmaster(a)masterindexing.com> wrote: > This series of four patches will improve various three functions in > kernel32: > > * GetConsoleFontSize > * GetCurrentConsoleFont > * GetLargestConsoleWindowSize > > This is achieved by moving logical calculations to wineconsole itself. > kernel32.dll only receives the final values. > > The first and second patches should be applied to source before compiling > Wine. If this is not done, the compiler will exit with errors. (The first > is a patch for server/protocol.def and requires tools/make_requests to be > run). > After each patch, Wine should be able to compile correctly (e.g. for regression testing) If not, you should split your patches differently IMO. Frédéric

2 1

Wine Gecko 2.21-beta1
by Jacek Caban April 25, 2013

April 25, 2013

Hi all, As some of you might have noticed, the final Wine Gecko 2.20 was never been released, although it was scheduled for about three weeks ago. This is mostly due to my lack of time, combined with the fact that part of that time I was busy with some Gecko work that would be nice to have in Wine. Being 3 weeks late means that we also have 3 weeks until the next Firefox release, so we may just wait a bit longer and do another release based on newer upstream code base. This way I may use the new beta to include some of the changes that I did lately, which would be too risky to go straight to release. Those new improvements contain, among others, a fix for Adobe CS4 products installers. In this beta, the testing is easier than ever. Our auto installer knows about the beta which, combined with the fact that we cache downloaded packages now, means that the attached Wine patch is all you need to comfortably test the new package. Just apply the patch you the Wine tree and everything should work. All tests are appreciated. Thanks, Jacek

1 0

Re: [PATCH 2/5] wined3d: Introduce a wined3d_vertex_pipe_ops structure.
by Rico Schüller April 25, 2013

April 25, 2013

On 25.04.2013 09:59, Henri Verbeet wrote: > -static HRESULT shader_arb_alloc(struct wined3d_device *device, const struct fragment_pipeline *fragment_pipe) > +static HRESULT shader_arb_alloc(struct wined3d_device *device, const struct wined3d_vertex_pipe_ops *vertex_pipe, > + const struct fragment_pipeline *fragment_pipe) > { > struct shader_arb_priv *priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*priv)); > struct fragment_caps fragment_caps; > - void *fragment_priv; > + void *vertex_priv, *fragment_priv; > + > + if (!(vertex_priv = vertex_pipe->vp_alloc(&arb_program_shader_backend, priv))) > + { > + ERR("Failed to initialize vertex pipe.\n"); > + HeapFree(GetProcessHeap(), 0, priv); > + return E_FAIL; > + } > > if (!(fragment_priv = fragment_pipe->alloc_private(&arb_program_shader_backend, priv))) > { > ERR("Failed to initialize fragment pipe.\n"); > + fragment_pipe->free_private(device); Shouldn't that vertex_pipe->vp_free(device)? > HeapFree(GetProcessHeap(), 0, priv); > return E_FAIL; > }

2 1

Clang static analyzer results / wine-1.5.28-66-g6899279
by Austin English April 25, 2013

April 25, 2013

With wine-1.5.20 and clang 3.2, the test suite is in the same state on my Fedora 18 machine as gcc-4.7.2 llvm version: git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk(a)17976891177308-0d34-0410-b5e… clang version: git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk(a)17977191177308-0d34-0410-b5e6… ./configure --disable-tests was used to reduce noise [austin(a)localhost ~]$ sha1sum scan-build-2013-04-18-2.tar.bz2 51e28c96a04ebe9ef937678149f9e7e3ed4cb20f scan-build-2013-04-18-2.tar.bz2 [austin(a)localhost ~]$ du -h scan-build-2013-04-18-2.tar.bz2 35M scan-build-2013-04-18-2.tar.bz2 http://www.mediafire.com/?xwb05d6er0aclfe -- -Austin

5 7

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)
by Sam Edwards April 24, 2013

April 24, 2013

This series has been waiting in the queue for a few days now. Does this need further discussion, or can it be committed? Thanks, Sam On 04/20/2013 08:08 AM, Sam Edwards wrote: >

1 0

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo (try 2)
by Christian Costa April 24, 2013

April 24, 2013

2013/4/24 James Eder <jimportal(a)gmail.com> > This version should either pass or skip on W2KPROSP4. > --- > dlls/kernel32/cpu.c | 23 ++++++++++++++++++----- > dlls/psapi/tests/psapi_main.c | 36 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+), 5 deletions(-) > > diff --git a/dlls/kernel32/cpu.c b/dlls/kernel32/cpu.c > index 0ebf8f3..124e5c0 100644 > --- a/dlls/kernel32/cpu.c > +++ b/dlls/kernel32/cpu.c > @@ -216,16 +216,29 @@ BOOL WINAPI IsProcessorFeaturePresent ( > */ > BOOL WINAPI K32GetPerformanceInfo(PPERFORMANCE_INFORMATION info, DWORD > size) > { > - NTSTATUS status; > + MEMORYSTATUSEX mem_status; > > TRACE( "(%p, %d)\n", info, size ); > > - status = NtQuerySystemInformation( SystemPerformanceInformation, > info, size, NULL ); > - > - if (status) > + if(size < sizeof(PERFORMANCE_INFORMATION)) > { > - SetLastError( RtlNtStatusToDosError( status ) ); > + SetLastError(ERROR_BAD_LENGTH); > return FALSE; > } > + > + mem_status.dwLength = sizeof(mem_status); > + if (!GlobalMemoryStatusEx( &mem_status )) > + return FALSE; > + > + memset(info, 0, sizeof(PERFORMANCE_INFORMATION)); > + > + info->cb = sizeof(PERFORMANCE_INFORMATION); > + info->CommitLimit = min((mem_status.ullTotalPageFile / > system_info.PageSize), MAXDWORD); > + info->PhysicalTotal = min((mem_status.ullTotalPhys / > system_info.PageSize), MAXDWORD); > + info->PhysicalAvailable = min((mem_status.ullAvailPhys / > system_info.PageSize), MAXDWORD); > + info->PageSize = system_info.PageSize; > + > + FIXME("stub\n"); > + > Hi James, That would be better to change the trace at the beginning by FIXME( "(%p, %d): semi-stub\n", info, size ); or FIXME( "(%p, %d): partial stub\n", info, size ); instead of adding another fixme (which is not really correct since it's not a stub). Christian

2 3

Re: msvcr110.dll: add a stub for crtGetShowWindowMode (try 2)
by Alexandre Julliard April 24, 2013

April 24, 2013

Austin English <austinenglish(a)gmail.com> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=33195 > > try 2: return SW_SHOWWINDOW instead of SW_HIDE It's not much harder to return the correct value. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] shell32: Add a semi-stub for SHGetStockIconInfo
by Nikolay Sivov April 24, 2013

April 24, 2013

On Wed, Apr 24, 2013 at 6:38 PM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > -- > By by ... Detlef > --- > dlls/shell32/iconcache.c | 42 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/shell32/shell32.spec | 1 + > 2 files changed, 43 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/iconcache.c b/dlls/shell32/iconcache.c > index 637dbca..df6675d 100644 > --- a/dlls/shell32/iconcache.c > +++ b/dlls/shell32/iconcache.c > @@ -46,6 +46,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(shell); > > +static const WCHAR shell32dll[] = > {'\\','s','h','e','l','l','3','2','.','d','l','l',0}; > + > Please put this in function that needs it.

1 0

Re: [PATCH 4/5] d3d9/tests: Don't test for equality in d3d9's depth_blit_test
by Henri Verbeet April 24, 2013

April 24, 2013

On 24 April 2013 11:29, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This makes the test pass on nv40 GPUs on Linux. I'm not sure if testing > equality was intentional or an accident, if it was intentional please > ignore this patch. > I don't quite remember, but probably not. Arguably the nicer way to fix it is to change the z-value for quad1 to 0.33f though.

1 0

Re: oledb32: Implement DataConvert DBTYPE_BOOL->VARIANT
by Jacek Caban April 24, 2013

April 24, 2013

On 04/24/13 10:41, Alistair Leslie-Hughes wrote: > + case DBTYPE_BOOL: > + V_VT(v) = VT_BOOL; > + V_BOOL(v) = *(BOOL*)src; You're mixing BOOL and VARIANT_BOOL here. This can't work, they even have a different size. From your test I guess that you meant to cast src to VARIANT_BOOL*. Cheers, Jacek

1 0

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo
by Marvin April 24, 2013

April 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25251 Your paranoid android. === W2KPROSP4 (32 bit psapi_main) === psapi_main.c:76: Test failed: GetProcAddress(GetPerformanceInfo) failed

1 0

Application for GSoC 2013 - improve Richedit
by Jactry Zeng April 23, 2013

April 23, 2013

Hi folks, I am Jactry Zeng, a sophomore majoring in Electronic Science from China. My nickname in #winehackers is Jactry. I would like to apply for this year's GSoC to work for wine. I have reported some bugs[1] of wine and submitted a few easy patches[2] for wine. And I feel quite good to study in wine community. I am so interested in Richedit module[3]. Because a lot of software I tested was blocked by bugs of Richedit, such as wordpad, GTalk, QQ, Weibo Desktop and AliWangwang etc. I would like to work for this module during GSoC. I've reported a few bugs regarding Richedit[4]. And for bug 33191[5], I have written a simple testcase to reproduce this bug. And I found ITextDocument is just a stub now, I want to implement some function of it, such as ITextDocument::New, ITextDocument::Open, ITextDocument::Save, ITextDocument::Range, ITextDocument ::GetName and ITextDocument::GetDefaultTabStop etc. These functions are documented in MSDN[6], what's better, thanks to kind people on codeproject[7], there are some sample applications for study, which will give me a lot of help on re-implementing ITextDocument. I think if I can finish this work, there are a lot of software will benefit from it[8]. I appreciate for any comment. Thank you. :-) [1] http://bugs.winehq.org/buglist.cgi?email1=jactry92%40gmail.com&emailtype1=e… [2]http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=Jactry [3] http://bugs.winehq.org/buglist.cgi?cmdtype=runnamed&namedcmd=richedit&list_… [4]bug of Richedit I reported: http://bugs.winehq.org/buglist.cgi?emailreporter1=1&emailtype1=exact&query_… [5]bug 33191: http://bugs.winehq.org/show_bug.cgi?id=33191 [6]http://social.msdn.microsoft.com/Search/en-US?query=ITextDocument&ac=4 [7]http://www.codeproject.com/search.aspx?q=ITextDocument&x=0&y=0&sbo=kw [8]bug of ITextDocument: http://bugs.winehq.org/buglist.cgi?quicksearch=ITextDocument&list_id=104255 -- Regards, Jactry Zeng

2 2

Re: [PATCH 3/3] mshtml: Support IObjectIdentity interface in HTMLWindow object
by Marvin April 23, 2013

April 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25244 Your paranoid android. === WXPPROSP2 (32 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 dom: unhandled exception c0000005 at 00421C52 === WXPX64 (32 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 dom: unhandled exception c0000005 at 00421C52 === WXPX64 (64 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 Timeout

1 0

Re: [PATCH 2/3] mshtml: Added IOmHistory::get_length test
by Marvin April 23, 2013

April 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25243 Your paranoid android. === WXPX64 (32 bit htmldoc) === htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call

1 0

Re: oledb32: Implement GetConversionSize DBTYPE_STR->DBTYPE_WSTR
by Marvin April 23, 2013

April 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25234 Your paranoid android. === W2KPROSP4 (32 bit convert) === convert.c:2537: Test failed: 12

1 0

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.
by Ken Thomases April 23, 2013

April 23, 2013

On Apr 22, 2013, at 6:40 PM, Sam Edwards wrote: > On 04/19/2013 10:32 AM, Max TenEyck Woodbury wrote: >> As I understand it, some fonts deliberately have glyphs larger than >> their metrics bounding boxes. Clipping them is almost certainly not a >> good idea. > > Forgive my disbelief, but can you provide an example? It seems like Windows has the same clipping behavior (see my test http://source.winehq.org/patches/data/95792) > > From my understanding, the intent of the ascent metric is that it indicates the maximum ascender on any glyph in the font (and likewise for descent), so the only real reason for the ascent/descent metrics to be wrong is if the font designer made a mistake. (And some tools, like FontForge, will automatically set the ascent/descent metrics correctly for you on export.) > > I can't think of any reason why a font author would want to create a font with an invalid ascent/descent metric. I can't speak to how Windows would render it, but one such font is Zapfino. It's an "exuberant" calligraphic font with lots of flourishes, some of which have strokes extending into the line above or below. http://en.wikipedia.org/wiki/Zapfino https://www.google.com/images?q=zapfino -Ken

2 3

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory. (try 2)
by Rico Schüller April 23, 2013

April 23, 2013

On 22.04.2013 23:08, Christian Costa wrote: > +typedef struct { > + DWORD bc2Size; > + DWORD bc2Width; > + DWORD bc2Height; > + WORD bc2Planes; > + WORD bc2BitCount; > + DWORD bc2Compression; > + DWORD bc2SizeImage; > + DWORD bc2XRes; > + DWORD bc2YRes; > + DWORD bc2ClrUsed; > + DWORD bc2ClrImportant; > + /* same as BITMAPINFOHEADER until this point */ > + WORD bc2ResUnit; > + WORD bc2Reserved; > + WORD bc2Orientation; > + WORD bc2Halftoning; > + DWORD bc2HalftoneSize1; > + DWORD bc2HalftoneSize2; > + DWORD bc2ColorSpace; > + DWORD bc2AppData; > +} BITMAPCOREHEADER2; Do we really need a typedef here? For only locally used structs, I think we shouldn't use a typedef. Also the struct is only used to determine the size and for nothing else? There may be a better way to do that... Maybe something like in dlls/windowscodecs/icoformat.c ? I think you got inspired by dlls/windowscodecs/bmpdecode.c, there is the same issue. Why do we need a typedef, if we only use it in one file to calculate the size? > > + BITMAPFILEHEADER *header; > > + if ((header_size == sizeof(BITMAPINFOHEADER)) || > + (header_size == sizeof(BITMAPV4HEADER)) || > + (header_size == sizeof(BITMAPV5HEADER)) || > + (header_size == sizeof(BITMAPCOREHEADER2))) > + { > + /* All structures have the same memory layout as BITMAPINFOHEADER */ > + BITMAPINFOHEADER*header = (BITMAPINFOHEADER*)*data; > + ULONG count = header->biClrUsed; > > + else if (header_size == sizeof(BITMAPCOREHEADER)) > + { > + BITMAPCOREHEADER*header = (BITMAPCOREHEADER*)*data; I don't think it's a good idea to use variable names multiple times. While this works fine it may be a bit confusing... Cheers Rico

2 1

d3dx9: Implement D3DXSHMultilpy5
by Nozomi Kodama April 23, 2013

April 23, 2013

Is there a problem with this patch? http://source.winehq.org/patches/data/95555 Nozomi

4 8

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.
by Dmitry Timoshkov April 23, 2013

April 23, 2013

Sam Edwards <cfsworks(a)gmail.com> wrote: > This change only affects malformed fonts that have glyphs with splines > that go above the maximum ascent as specified in the font's hhea/os2 > table. For that reason, any tests for this change would have to include > a malformed font, so I did not write tests. If we want in-tree tests, > we'll need to figure out how to include a malformed font to test against. Please add a test case, Wine test suite already includes custom fonts, you can either use an existing font, or add a new one. -- Dmitry.

3 2

kernel32/path: Potential off-by-one error, help needed!
by Kirill Smirnov April 23, 2013

April 23, 2013

Hi! While debugging bug #33307 (http://bugs.winehq.org/show_bug.cgi?id=33307) I found a suspicious piece of code, looking like off-by-one error. Unfortunately, I'm not familiar with this part of wine and I don't know how to write corresponding test case. If you familiar with this module, please, take a look at this wanna-be-a-bug and the proposed patch. -- Kirill

2 1

Re: user32: add assembly wrapper for calling hook procedures.
by James Eder April 23, 2013

April 23, 2013

Dan, the patch doesn't build for 64-bit Wine. On the #else side you have an unwanted semicolon. -- Jim

2 1

Wine History
by André Hentschel April 22, 2013

April 22, 2013

Hi, meanwhile everyone should know that Wine turns 20 this year. AJ said in this years Keynote we'll need to find a way to celebrate this in June. So i did some research on this and found "Wine History" mails by Dan Kegel from 2002 and much earlier Bob Amstadt talking about late May or early June 1993. The date listed on Wikipedia is July the 4th, but i was still curious about that late May. I think i finally found this late May (30th) discussion and want to share it: https://groups.google.com/d/msg/comp.os.linux/7TFhxP6IUVQ/gVHAeP_ZBVUJ It's of course hard to tell when a project was really born, but as far as i understand, this discussion inspired Bob to write an initial loader. I was just 5 at this time, so maybe someone can tell some more about it? :) Some more Links: http://en.wikipedia.org/wiki/Wine_%28software%29 http://www.winehq.org/pipermail/wine-devel/2002-November/010567.html http://www.winehq.org/pipermail/wine-devel/2002-November/010603.html https://groups.google.com/d/msg/comp.os.linux/RKpNL1M8vSE/Z-rgUyrSFlYJ https://groups.google.com/d/msg/comp.os.linux/mb1BwP7LckY/IV44zjGkO98J http://www.linuxjournal.com/article/2757 and of course http://wiki.winehq.org/WineHistory Ok, i somehow lost the mentioning of "late may", but it's already quite late here, sry.

2 1

Re: [user32] Add DECLSPEC_NOINLINE, use it on call_hook_proc()
by Qian Hong April 22, 2013

April 22, 2013

Hi Dan, Thanks for working on it! It is really an annoying bug, however, is adding DECLSPEC_NOINLINE a workaround or a real fix? If it is only a workaround, would that hide some real bug behind it? Or is that possible that there is a gcc bug here that we want to report to gcc? Thanks for your time!

4 7

Re: [PATCH 1/2] wined3d: Remove leftover texture accesses in GLSL shader generation
by Henri Verbeet April 22, 2013

April 22, 2013

On 21 April 2013 16:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - if (texture && texture->target == GL_TEXTURE_RECTANGLE_ARB) > - sample_flags |= WINED3D_GLSL_SAMPLE_RECT; > + if (priv->cur_ps_args->np2_fixup & (1 << sampler_idx)) > + { > + sample_flags |= WINED3D_GLSL_SAMPLE_NPOT; > + } I don't think the added braces are an improvement, but otherwise this looks ok.

2 3

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory.
by Alexandre Julliard April 22, 2013

April 22, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > + if (header_size == sizeof(BITMAPINFOHEADER)) > + { > + BITMAPINFOHEADER *header = (BITMAPINFOHEADER*)*data; > + ULONG count = header->biClrUsed; > + > + if (!count && header->biBitCount <= 8) > + count = 1 << header->biBitCount; > + > + offset = sizeof(BITMAPFILEHEADER) + header_size + sizeof(RGBQUAD) * count; This isn't correct for all DIB types. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] extrac32: Add /D switch support.
by Alexandre Julliard April 22, 2013

April 22, 2013

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -202,6 +228,9 @@ int PASCAL wWinMain(HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int sho > WCHAR path[MAX_PATH]; > LPCWSTR cabfile = NULL; > > + extr_printf = (void*)GetProcAddress(LoadLibraryA("msvcrt"), "printf"); > + if(!extr_printf) > + return 1; Mixing C runtimes is not a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)
by Vincent Povirk April 22, 2013

April 22, 2013

Dealing with the bits of a floating point number directly is a bit odd, and it makes it hard to review the code. Is there a reason you don't want to use things like modf, floor, and ceil?

2 3

re: Google Summer of Code 2013
by Dan Kegel April 20, 2013

April 20, 2013

Hi Anulesh, improving wine's support of cygwin is a toughie. ( I gave http://bugs.winehq.org/show_bug.cgi?id=15679 the old college try, but failed. ) You should probably be more specific about what you have in mind. - Dan

1 0

re: Willing to work on CMD - implement more robust parser
by Dan Kegel April 20, 2013

April 20, 2013

Hi Gaurab! Glad to hear you're interested in wine, and in cmd. You might start by reading previous discussion on the topic, e.g. the full thread following http://www.winehq.org/pipermail/wine-devel/2009-December/080643.html and http://kegel.com/wine/sweng/2010/ Two tips that might help smooth your way: There is a lot of bison in wine already, so using bison might be the path of least resistance. Switching just one command to bison, while leaving the rest using the existing code, would likely be much easier to get committed than a big patch that changed lots of things. Good luck! - Dan

1 0

Willing to work on CMD - implement more robust parser
by Gaurab Patra April 20, 2013

April 20, 2013

Respected sir/madam, Through this mail I'd like to inform you that I am a Computer Science student at Bengal Engineering and Science University, Shibpur (India) in my 3rd year of undergraduate studies. I have gone through the project CMD - implement more robust parser and would like to work on this project this summer. As it is mentioned in the required skill set I am quite proficient in C, CMD commands, datastructure and algorithm etc. I'm attaching my resume with this mail. If you want to give me the opportunity to work on this please reply with some necessary resources and guide me with more information on this. Thank you GaurabPatraResume(1).pdf<https://docs.google.com/file/d/0B99XscJv40waenczeWh3ZVNkVlk/edit?usp=drive_…> Gaurab Patra 3rd yr Computer Science BESU, Shibpur

1 0

Re: oledb32: Implement GetConversionSize DBTYPE_WSTR->DBTYPE_WSTR
by Nikolay Sivov April 20, 2013

April 20, 2013

On 4/20/2013 13:43, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > oledb32: Implement GetConversionSize DBTYPE_WSTR->DBTYPE_WSTR > > > Best Regards > Alistair Leslie-Hughes Please add a test when caller supplies source length, at least one case is interesting - supplied length is less than lstrlenW result. Another case would be embedded nulls and source length larger than null terminated length.

1 0

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool(try 2)
by Marvin April 20, 2013

April 20, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25206 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)
by Marvin April 20, 2013

April 20, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25204 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/7] wined3d: Use ARB_internalformat_query2 to check for texture format rendering and blending support, where available.
by Henri Verbeet April 19, 2013

April 19, 2013

On 18 April 2013 21:19, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + if (!format->glInternal) continue; > + > + gl_info->gl_ops.ext.p_glGetInternalformativ(GL_TEXTURE_2D, format->glInternal, > + GL_FRAMEBUFFER_RENDERABLE, 1, &value); > + if (value == GL_FULL_SUPPORT) > + { > + TRACE("Format %s is supported as FBO color attachment.\n", debug_d3dformat(format->id)); > + format->flags |= WINED3DFMT_FLAG_RENDERTARGET | WINED3DFMT_FLAG_FBO_ATTACHABLE; > + format->rtInternal = format->glInternal; > + > + if (!(format->flags & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) > + query_format_flag(gl_info, format, format->glInternal, GL_FRAMEBUFFER_BLEND, > + WINED3DFMT_FLAG_POSTPIXELSHADER_BLENDING, "post-pixelshader blending"); > + } This may be a bit dangerous, since you're now potentially adding WINED3DFMT_FLAG_RENDERTARGET for formats like e.g. WINED3DFMT_R8G8B8A8_SNORM that didn't previously had it, and where it's a bit questionable if it's really going to work as intended. Also, the depth/stencil check that follows is either redundant, or we're now also potentially setting WINED3DFMT_FLAG_RENDERTARGET for depth/stencil formats. At least initially we'll probably want to stick with formats that already have WINED3DFMT_FLAG_RENDERTARGET set, and only clear it if unsupported. At a later point we may want to do something more centered around the information we get from internalformat_query2, but I suspect it will be a bit harder than just checking if there's no fixup, no conversion function, etc.

2 1

Re: [PATCH 2/7] wined3d: Store vs_clipping in the adapter
by Henri Verbeet April 19, 2013

April 19, 2013

On 19 April 2013 11:20, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Potential alternatives include keeping the status quo or introducing a > separate structure that holds these derived limits that is owned by the > device and linked in the contexts. We could also put it into gl_info, > but I dislike this idea because these limits are not GL limits, but > limits of our shader and fixed function pipeline implementations. I think we'll want a separate structure for this. Note that you essentially have two different kinds of data you're concerned with here though. One is derived state like e.g. the texture unit map, the stream info, or the view_indent from patch 1/7. We don't really want that in wined3d_state, because there's no reason for e.g. every stateblock to have a copy of that. Having the derived state structure be owned by the device is probably ok, although there may also be something to be said for making it part of the context instead. The other type of data is immutable data like derived caps and limits, as in this patch and following ones. In principle the adapter is the right place for that, but I do think we want a separate structure for that, and probably a pointer to it in the context, for similar reasons as having one to gl_info. Arguably things like the state table, format info and the shader backend would belong in the same structure. I.e., essentially we'd have a setup like wined3d_gl_info, but for more wined3d specific / derived info.

2 2

Re: [PATCH 3/7] wined3d: Use ARB_internalformat_query2 for the other texture format caps too.
by Henri Verbeet April 19, 2013

April 19, 2013

On 18 April 2013 21:20, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + /* FIXME: We can't handle "partial" sRGB decode support right now, we could > + * introduce a new format flag and check for that. */ As mentioned on IRC, I don't think this is really an issue. The patch looks otherwise ok.

1 0

Re: [PATCH 1/3] msvcrt: Added _mbsncoll and _mbsncoll_l implementation.
by Akihiro Sagawa April 19, 2013

April 19, 2013

On Fri, 19 Apr 2013 14:42:50 +0800, Jactry Zeng wrote: > +/********************************************************************* > + * _mbsncoll_l(MSVCRT.@) > + */ > +int CDECL _mbsncoll_l(const unsigned char *str1, const unsigned char *str2, MSVCRT_size_t count, > + MSVCRT__locale_t locale) > +{ > + return _mbsnbcoll_l(str1, str2, count, locale); > +} According to MSDN, _mbsncoll_l receives a number of characters, but _mbsnbcoll_l receives a number of bytes. This is a big difference in multibyte code page. So you should properly handle this situation, or add FIXME message based on multibyte code page if your application just needs this function. Regards, Akihiro Sagawa

2 1

Google Summer of Code 2013
by Anulesh Tiwari April 19, 2013

April 19, 2013

Sir, I will be applying for GSoC 2013 under your mentoring team. Sorry for contacting very late with you as I was not aware of this program. I came to know yesterday that Gsoc is going to start. As a CS student and I have a well understanding of C C++ and Java and Data structures I am always very keenly interested in programming and coding. I devote my daily 8 hrs to it. As a potential linux user I have chosen Ideas from your list Cygwin Improvement I wish to apply on this topic and devote my each and every day of this summer to help my friends and colleagues to run Wine without bugs. Well one more thing to say Sir please give more Information and details what I have to do to assure my project to be done. Regards Anulesh Tiwari Bachelor of Science Department of Computer Science BHU INDIA

1 0

Fun with GCC 4.8
by James Eder April 18, 2013

April 18, 2013

As many of you no doubt know, GCC recently released 4.8.0. This new version introduces a new optimization level enabled by -Og with the following description (from the man page): "Optimize debugging experience. -Og enables optimizations that do not interfere with debugging. It should be the optimization level of choice for the standard edit-compile-debug cycle, offering a reasonable level of optimization while maintaining fast compilation and a good debugging experience." Of course I had to try it out. I found that building Wine lead to GCC dieing with ... dlls/kernel32/console.c:1691:1: internal compiler error: Segmentation fault I also found ... dlls/kernel32/computername.c:701:1: internal compiler error: Segmentation fault I eventually stumbled my way into the enclosed patch which lets GCC build Wine with -Og. I'm not sure if this change (or something similar) makes sense for Wine. I'm fairly certain some changes make sense for GCC (I suspect that GCC should not segfault). I haven't submitted a bug for GCC because I suspect they'll want me to provide something simpler to compile than the Wine source tree. I certainly won't be upset if someone beats me too it. I'm not sure how much time in the near future I'll spend on it. "Eventually" is probably the word that fits. At any rate, I wanted to at least share my experiences in case anyone is interested in heading down the same path. -- Jim

3 3

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications
by Alexandre Julliard April 18, 2013

April 18, 2013

Simon Lipp <sloonz(a)gmail.com> writes: > @@ -389,6 +389,10 @@ static int process_events( Display *display, Bool (*filter)(Display*, XEvent*,XP > count++; > if (XFilterEvent( &event, None )) > { > + KeySym keysym = 0; > + XLookupString(&event.xkey, NULL, 0, &keysym, NULL); > + BOOL is_dead = (keysym >= XK_dead_grave && keysym <=XK_dead_semivoiced_sound); You can't assume that you have a key event here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32/tests: Use if(0) instead of #if 0 to make sure the code still compiles.
by Marvin April 18, 2013

April 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25164 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

testbot: Default set of VMs to run the tests
by Dmitry Timoshkov April 18, 2013

April 18, 2013

Hi all, recently the set of VMs suggested to run the tests on by default has changed. It no more includes NT4, XP and Vista (although it does include win2000), 32-bit VMs for NT4, XP and Vista don't even exist in the list of available VMs (64-bit XP and Vista do exist, but for some reason are not used). Is there a reason for that? -- Dmitry.

2 5

Re: GetKeyboardState problems in Age of Empires II
by Dmitry Timoshkov April 18, 2013

April 18, 2013

[please don't omit wine-devel when replying] Stevie Trujillo <stevie.trujillo(a)gmail.com> wrote: > > Stevie Trujillo <stevie.trujillo(a)gmail.com> wrote: > > > Another (minor) problem raised in the bugzilla entry is that, if a > > > key is pressed when changing window, and released before returning, > > > GetKeyboardState() will claim the key is still pressed (0x80). But > > > this is easy to workaround, just hit the key again inside the game > > > and it will stop scrolling. > > > > dlls/winex11.drv/keyboard.c,X11DRV_KeymapNotify() should take care of > > that, if it doesn't - please debug why (probably a bug in your WM). > > I think this function only applies to "modifier keys". It was tested > with arrow keys. It should work for all keys. > Anyway I don't think it's a big issue, since it doesn't cause > any big problem, and it doesn't happen very often. It was just a > situation where Windows and Wine exhibited slightly different behavior. > > The first bug is much more annoying since one has to completely exit > the game each time. My comment was targeting both problems that you mentioned. -- Dmitry.

2 2

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool
by Jacek Caban April 18, 2013

April 18, 2013

On 04/17/13 18:18, larmbr zhan wrote: > + double tmp; > + WCHAR trueW[] = {'T','r','u','e','\0'}; > + WCHAR falseW[] = {'F','a','l','s','e','\0'}; > + > + TRACE("%s\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + switch(V_VT(arg)) { > + case VT_I2: > + tmp = V_I2(arg); > + break; > + case VT_I4: > + tmp = V_I4(arg); > + break; I don't think converting to double is a good idea here. Why don't you do conversions directly to BOOL for all cases? > + case VT_R4: > + tmp = V_R4(arg); > + break; > + case VT_R8: > + tmp = V_R8(arg); > + break; > + default: > + ERR("Not a numeric vaule: %s\n", debugstr_variant(arg)); > + return E_FAIL; > + } > + > + if (tmp < 0.0 || tmp > 0.0) > + str = SysAllocString(trueW); > + else > + str = SysAllocString(falseW); > + > + > + return return_bstr(res, str); Are you sure you want to return string type here? I'd expect a bool value (of type VT_BOOL) here... > } > > static HRESULT Global_CByte(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > diff --git a/dlls/vbscript/tests/api.vbs b/dlls/vbscript/tests/api.vbs > index 6bd4065..9b25e87 100644 > --- a/dlls/vbscript/tests/api.vbs > +++ b/dlls/vbscript/tests/api.vbs > @@ -442,4 +442,9 @@ Call ok(CInt(36.50) = 36, "CInt(36.50) = " & CInt(36.50)) > Call ok(CInt(36.75) = 37, "CInt(36.75) = " & CInt(36.75)) > Call ok(CInt(300) = 300, "CInt(300) = " & CInt(300)) > Call ok(CInt(-300) = -300, "CInt(-300) = " & CInt(-300)) > + > +Call ok(CBool(5) = "True", "CBool(5) = " & CBool(5)) > +Call ok(CBool(0) = "False", "CBool(0) = " & CBool(0)) > +Call ok(CBool(-5) = "True", "CBool(-5) = " & CBool(-5)) ...and that's why getVT(...) test would be nice here. Thanks, Jacek

2 1

Application for GSoC 2013
by larmbr zhan April 18, 2013

April 18, 2013

Hi all, I'm a junior student from a non-famous college, I apply to parcitipate in GSoC , to help do some vbscript module implementation. I've just submitted a patchset on this. Thanks. -- Regards, Zhan Jianyu

3 4

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Jacek Caban April 18, 2013

April 18, 2013

On 04/17/13 18:17, larmbr zhan wrote: > +static HRESULT to_int_banker_rounding(VARIANT *v, int *ret) > +{ I wonder if this conversion is used in any other place as well. I think this does not need a helper function until we find other use cases as well, esp. since you could simplify that to: if(V_VT(v) == VT_R8) { //... your conversion }else { hres = to_int(v); } + case VT_R8: { + double n = rint(V_R8(v)); rint is not portable. Please avoid using it. @@ -424,4 +424,22 @@ Call ok(getVT(vbYes) = "VT_I2", "getVT(vbYes) = " & getVT(vbYes)) Call ok(vbNo = 7, "vbNo = " & vbNo) Call ok(getVT(vbNo) = "VT_I2", "getVT(vbNo) = " & getVT(vbNo)) +Call ok(CInt(-36.75) = -37, "CInt(-36.75) = " & CInt(-36.75)) +Call ok(CInt(-36.50) = -36, "CInt(-36.50) = " & CInt(-36.50)) +Call ok(CInt(-36.25) = -36, "CInt(-36.25) = " & CInt(-36.25)) Please add some tests using getVT to verify underlying types. Thanks, Jacek

1 0

Re: [2/3] mountmgr.sys: Remove an artificial limitation for removable drive letters.
by Alexandre Julliard April 18, 2013

April 18, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Under Windows removable drives (USB sticks) can have drive letters such > as J: or K:. They are not considered floppy devices though. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] kernel32: Count precise amount of child process failures.
by Marvin April 18, 2013

April 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25160 Your paranoid android. === W2K8SE (32 bit loader) === lloader.c:1686: Test failed: expected exit code 0, got 196

2 1

Re: msvcr110: forward __crtSetUnhandledExceptionFilter to kernel32.SetUnhandledExceptionFilter (try 3)
by Dmitry Timoshkov April 18, 2013

April 18, 2013

Austin English <austinenglish(a)gmail.com> wrote: > +LPTOP_LEVEL_EXCEPTION_FILTER MSVCR110__crtSetUnhandledExceptionFilter(LPTOP_LEVEL_EXCEPTION_FILTER filter) > +{ > + return SetUnhandledExceptionFilter(filter); > +} msvcrt APIs need an explicit calling convention specifier. -- Dmitry.

2 1

GetKeyboardState problems in Age of Empires II
by Stevie Trujillo April 18, 2013

April 18, 2013

"Age of Empires II scrolling gets stuck after Alt-Tab away and back" ( http://bugs.winehq.org/show_bug.cgi?id=30814 ) has been debugged now. The problem is that GetKeyboardState starts returning 0x40 after changing window. Documentation seems to only define LSB and MSB ( http://msdn.microsoft.com/en-us/library/windows/desktop/ms646299(v=vs.85).a… ). This leads Age of Empires II to believe that all keys are pressed after changing window, making it scroll unstoppably. Should this be fixed by removing extra bits in GetKeyboardState like in the bugzilla entry, or should it be fixed in wineserver? Also does the similar functions GetAsyncKeyboardState() and GetKeyState() need fixing? Another (minor) problem raised in the bugzilla entry is that, if a key is pressed when changing window, and released before returning, GetKeyboardState() will claim the key is still pressed (0x80). But this is easy to workaround, just hit the key again inside the game and it will stop scrolling.

2 1

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Dmitry Timoshkov April 18, 2013

April 18, 2013

larmbr zhan <nasa4836(a)gmail.com> wrote: > + case VT_BOOL: > + *ret = V_BOOL(v) ? -1 : 0; > + break; Shouldn't this be VARIANT_TRUE/VARIANT_FALSE instead of -1/0? -- Dmitry.

1 0

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool
by Marvin April 17, 2013

April 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25139 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Marvin April 17, 2013

April 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25138 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/5] wined3d: Enable GL_ARB_texture_rectangle in GLSL ffp fragment shaders
by Henri Verbeet April 16, 2013

April 16, 2013

On 16 April 2013 14:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (gl_info->supported[ARB_TEXTURE_RECTANGLE]) > + shader_addline(buffer, "#extension GL_ARB_texture_rectangle : enable\n"); > + This may be a good idea anyway, but is this strictly required? IIRC ARB_texture_rectangle is the one special extension that's always implicitly enabled in GLSL if it's supported.

2 2

Re: [PATCH 2/5] d3d9/tests: Test NPOT texture creation
by Henri Verbeet April 16, 2013

April 16, 2013

On 16 April 2013 14:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - * Copyright (C) 2006 Chris Robinson > + * Copyright (C) 2006 Chris Robinsontes This looks unintentional. > + UINT refcount; Technically refcounts are ULONGs, although I suppose it doesn't matter a whole lot.

1 0

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications
by Dmitry Timoshkov April 16, 2013

April 16, 2013

Simon Lipp <sloonz(a)gmail.com> wrote: > + * Moreover, let dead chars be processed or we will never have > + * WM_DEADCHAR events That's how it's supposed to work. Wine should never generate WM_DEADCHAR message, it relies in the driver to handle dead keys and generate final events. X11 even has an ability to support user defined key sequences which are handled by XFilterEvent and which will be broken by your patch. -- Dmitry.

3 4

Re: kernel32: Add a test to check event and mutex states during process termination.
by Alexandre Julliard April 16, 2013

April 16, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/kernel32/tests/loader.c | 40 +++++++++++++++++++++++++++++++++------- > 1 file changed, 33 insertions(+), 7 deletions(-) That's not a very meaningful test if nobody holds the mutex. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ieframe: Added DISPID_WINDOWCLOSING tests.
by Marvin April 16, 2013

April 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25096 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Re: [PATCH 6/6] ieframe: Added DISPID_WINDOWCLOSING tests.
by Marvin April 16, 2013

April 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25086 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21 === WVISTAX64 (64 bit webbrowser) === webbrowser.c:978: Test failed: unexpected dispIdMember 271 webbrowser.c:1604: Test failed: unexpected call TranslateUrl webbrowser.c:454: Test failed: unexpected nCmdID 14 Timeout

2 1

Re: [PATCH 5/6] ieframe: Return document as IHTMLDocument2 iface from get_document.
by Marvin April 15, 2013

April 15, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25085 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2615: Test failed: expected GetOverridesKeyPath webbrowser.c:2620: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2621: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3060: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0