April 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 1/1] d3d8: Don't assert on invalid IDirect3DBaseTexture8 interfaces.
by Stefan Dösinger April 15, 2013

April 15, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-04-14 16:53, schrieb Rico Schüller: > + if (iface->lpVtbl != (const IDirect3DBaseTexture8Vtbl > *)&Direct3DTexture8_Vtbl + && iface->lpVtbl != (const > IDirect3DBaseTexture8Vtbl *)&Direct3DCubeTexture8_Vtbl + > && iface->lpVtbl != (const IDirect3DBaseTexture8Vtbl > *)&Direct3DVolumeTexture8_Vtbl) + { + WARN("%p is not a > valid IDirect3DBaseTexture8 interface.\n", iface); + return > NULL; + } A test would be a good idea. Are you sure that the assert is the actual problem, and not some memory corruption that changes the vtable poiner? What does e.g. GetTexture do after a bogous SetTexture call? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRa7lTAAoJEN0/YqbEcdMwNjEP/RLeLk3+009+Cp2n5sWOUprn Z5ED8iL3RXRjsCJNU5Fi2JIkCcVRmdkkn2RTBN9Q9KEkUL0qjg6B7Admy5sWtMIk LDtYpjS6BeDIJm8e0D0HwGItv2ekxW37ggg9fsArcXUO/lKf2GrJmUiyAjQfzmT9 IDlewcLSzUiAdbzZ4WUZzkqIa9lQgDpZBAvOgvgqhY2suf+YpJi6oTMfgwzpiSyB L2mlXx4cb0/hYaPAdWZUbc9uHvsCQ5ZwE4EhIxWpMlZM8FENMN3Gc0vrpzWAXoBo XRifoh3n0VKaYyZ+Wi+zGRaFX40P4ouBUKuFcBdjEPq6Fhz46GEGY8KFf1MVZKwM 7pzkhv6yc8/GTr2q5wthhmnZxDLHIZNyVEoMU0AFB1M0V/k0sJQfXpCCA/6vql+g dgUtyPggMSefwT0lc/7S/UwQdvuRYyIcdVd47alDJyRfU5NOMx091IiqkKXm9nby nqGAfdO3GDQoOIXJpWD5E1UMPHt6AGXGsfypkuVTtTljvOx+U7S9ngBeFkjuor8+ VFwStSFGboPxAjfKqzubdFcPcp4t8E5/qqkXR+Nc2UBJV5XeC3Pg5GOZxBsDZvbz zU4btX6kgC1Si1vIkf+D8CyZgaoPSwiVgGfVkTaqYSqnO39JZ0SpjYlv7e4yuhfa jkXNYd+XevrLq435YYir =TVml -----END PGP SIGNATURE-----

2 3

GSoC '13 - Hello!
by Eric Zheng April 15, 2013

April 15, 2013

Hello everyone, My name is Eric Zheng, I'm a junior in Computer Engineering at the University of Illinois Urbana-Champaign. I just wanted to introduce myself and state my interest in the "Xinput / Xbox 360 controller compatibility" project. I hope to be able to jump on IRC later in the week to speak with you all. Best, Eric Zheng

2 1

Re: zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung April 15, 2013

April 15, 2013

--- On Sun, 14/4/13, Vincent Povirk <madewokherd(a)gmail.com> wrote: > Well, here's a simple thing you can > check: Does your zlib dll link to > _lseek or _lseeki64? The first one uses a 32-bit offset. > Wine's > implementation (http://source.winehq.org/source/dlls/msvcrt/file.c#L1090) > expands that to 64-bit and later truncates the file offset > to 32-bit. > For a file larger than 2 GB, that could account for the > large negative > value you're seeing. > > And since this would only matter in cases where zlib uses > lseek (the > first time through I guess it wouldn't, as it has to read > the whole > everything up to the offset you give at least once) and is > at least 2 > GB into the file, that might also explain why it doesn't > fail > initially. > > But without really digging into the zlib code, all I can do > it speculate. > > I should probably also check coapp's build of zlib > sometime. It is not a dll - as you suggested and I already wrote, due to past experience of other's packaging of slightly outdated, it is being built against a private *source* copy of the latest zlib. Also the bogus offset is not large negative but large (larger than 2^32) positive. Here is an example of the debug output under wine: --------------- set_filepos failed at 34307 returning 134127533721091 Re-opening to re-try Retry successful set_filepos failed at 96919 returning 146686018157207 Re-opening to re-try Retry successful set_filepos failed at 128254 returning 12103217968382 Re-opening to re-try Retry successful ... --------------- This is generated by this code snipplet which is called inside a loop, all wrapped in the c++ class: --------------- off_t offset = gzseek(gzvcf_in, filepos, SEEK_SET); if (offset != filepos) { //implicitly converted to off_t by template streamoff() LOG.printLOG("set_filepos failed at " + LOG.streampos2str(filepos) + " returning " + LOG.off_t2str(offset) + "\n"); LOG.printLOG("Re-opening to re-try\n"); close(); open(); off_t offset1 = gzseek(gzvcf_in, filepos, SEEK_SET); if (offset1 == filepos) LOG.printLOG("Retry successful\n"); else LOG.error("Retry failed\n"); // this also aborts } ------------------- This code runs silently on linux i.e. the "if (offset != filepos)" condition is not triggered.

2 2

request.h: size of unnamed array is negative
by Hugh McMaster April 15, 2013

April 15, 2013

I've been adding a new handler to Wine's server. Unfortunately, I've run into a problem with C_ASSERT that I can't seem to resolve. In server/request.h, I've added the following code: C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_request, spi_workarea) == 16 ); C_ASSERT( sizeof(struct get_desktop_workarea_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_reply, screen_x) == 4 ); C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_reply, screen_y) == 4 ); C_ASSERT( sizeof(struct get_desktop_workarea_reply) == 8 ); But the compiler ends with output errors, as in the following: In file included from request.c:69:0: request.h:1527:1: error: size of unnamed array is negative request.h:1528:1: error: size of unnamed array is negative request.h:1529:1: error: size of unnamed array is negative request.h:1530:1: error: size of unnamed array is negative request.h:1531:1: error: size of unnamed array is negative Each error represents the C_ASSERT code listed above. I'm probably missing something obvious here. Can someone please offer any advice on resolving these errors? Thank you.

3 8

Re: zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung April 14, 2013

April 14, 2013

------------------------------ On Sun, Apr 14, 2013 22:34 BST Vincent Povirk wrote: >> considering how old zlib is and the vast number of windows application which uses zlib > >Given how many people duplicate the effort to package zlib, the fact >that they're rarely updated, and the sort of problems gnulib exists to >work around, it would not surprise me if your particular zlib binary >is broken somehow. got nobody else to blame - because of exactly the issue you outlined encountered in the past, i am building the application with a private copy of the source of zlib 1.2.7.

2 1

zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung April 14, 2013

April 14, 2013

I am porting an application which uses zlib's gzseek quite extensively to do pseudo- random access of the content of large gz'ed files, in the same manner of some's use of posix's lseek. On small test data, it works correctly on wine. (identical result as linux). On production data - a large 9GB file - it gives gabbage. I thought it is 32-bit file access problem, until I check the return value of gzseek explicitly. It is supposed to return the same value as input on success, -1 on error. On wine, it does neither, *occasionally*! I found that a first gzseek works correctly, then a 2nd fails. It does not fails with a -1, but fails with a large bogus value. Currently I am working around this strange behavior by closing the file and re-opening until it gets a correct offset. The large bogus value increases gradually and wrap around about 8-10 such repeated set of gzseek calls. Anybody has any suggestion why gzseek would behave badly *intermittently* in wine? I assume it works correctly in windows - hardly to think that it doesn't work, considering how old zlib is and the vast number of windows application which uses zlib. On a separate note, the application seems extraordinary slow in wine (again I haven't tried in windows..) - even when it works correctly without the work-around, it is hundreds of times slower in wine than in linux.

2 1

Re: [PATCH 1/4] wined3d: 1x1 texures have a power of two size
by Henri Verbeet April 14, 2013

April 14, 2013

On 13 April 2013 16:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -965,8 +965,6 @@ static HRESULT texture_init(struct wined3d_texture *texture, UINT width, UINT he > && !(format->id == WINED3DFMT_P8_UINT && gl_info->supported[EXT_PALETTED_TEXTURE] > && wined3d_settings.rendertargetlock_mode == RTL_READTEX)) > { > - if (width != 1 || height != 1) > - texture->flags &= ~WINED3D_TEXTURE_POW2_MAT_IDENT; > > texture->pow2_matrix[0] = (float)width; > texture->pow2_matrix[5] = (float)height; I think we'll want the empty line here gone as well, but otherwise the series looks ok.

1 0

Google Summer of Code
by Liu Tuo April 13, 2013

April 13, 2013

Hi, How much knowledge should I have before applying for the wine project of implementing missing D3DX9 apis? Currently I have learnt opengl; I am familiar with the opengl and glut functions and the concepts behind these functions. Thanks for your help, Liu Tuo

1 0

Re: gdiplus: fix a clipping problem
by Vincent Povirk April 13, 2013

April 13, 2013

This looks wrong. scaled_rect is an internally calculated value, not something supplied by the user, and comparing it to 0.5 doesn't make sense, especially since by this point the width was altered to add padding.

1 0

GSoC 2013 proposal: Implement XPath from scratch
by John Chadwick April 12, 2013

April 12, 2013

Hello, I am a student of computer science interested in entering Wine development via GSoC 2013. Upon looking at the various suggested proposals, the project of reimplementing XPath without libxml2 looked particularly interesting. I am familiar with the C language, W3C DOM and XPath, and I believe this is something I could do. I have a few questions I'd be interested in seeing answered: * One of the 'important things to keep in mind' is that "changes should be incremental, with a fallback to libxml2 until new processor is fully functional." Does this mean at compile time, or at runtime, when the evaluator recognizes unimplemented features in an expression, or something else entirely? * Is only MSXML 3.0 supported? It appears to be the only version implemented in the Wine source tree. * What should I aim at doing first? Because what I'd be working on is a library, I would probably need some application to test features with (test cases aside.) Should I be using an existing program, or writing a new one? Thanks, John Chadwick

3 2

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 5).
by Sergey Guralnik April 12, 2013

April 12, 2013

On 2013-04-10 14:28, Sergey Guralnik wrote: >> >> It's better, but testing the message sequence doesn't seem very >> useful, >> particularly since you don't differentiate parent and child >> messages. >> Also you should test the region before the move to show that it's >> the >> move that's changing it. > > Changes since last version: > - message sequence testing removed at all > - added update region testing for all windows > before and after moving. > > --- > dlls/user32/tests/win.c | 68 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 68 insertions(+), 0 deletions(-) Is something wrong with this version? -- Sergey

1 0

Re: [PATCH 1/2] wined3d: Use the np2_fixup to find out if a RECT texture is used
by Henri Verbeet April 12, 2013

April 12, 2013

On 11 April 2013 11:32, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -1069,17 +1069,17 @@ static void shader_generate_glsl_declarations(const struct wined3d_context *cont > shader_addline(buffer, "uniform sampler1D %s_sampler%u;\n", prefix, i); > break; > case WINED3DSTT_2D: > - texture = state->textures[i]; > + tex_rect = version->type == WINED3D_SHADER_TYPE_PIXEL && (ps_args->np2_fixup & (1 << i)); The basic idea is ok, but the conditions for when np2_fixup is set are a bit more complicated than that. Specifically, look at how the WINED3D_TEXTURE_POW2_MAT_IDENT texture flag is set / cleared in texture_init().

2 4

Re: [3/3] server: Add support for NtTerminateProcess(0). Resend.
by Alexandre Julliard April 12, 2013

April 12, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This patch fixes the problem reported in the bug 33331. Before you can start killing threads, you'll need to fix the various synchronization primitives (with appropriate tests of course) to take process shutdown into account, otherwise it will deadlock all over the place. Other things like protecting the loader data structures will also need more thought. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fresh WineWiki Theme, Straight from the Farm
by Kyle Auble April 11, 2013

April 11, 2013

So as usual, my estimate of how long it would take was way off, but I'm finally done adapting the WineHQ theme to Moinmoin. It's not perfect, but I feel it's ready to submit for switching over. I've tested it in Firefox, Chromium, Midori, and Opera (briefly in IE8 & IE9 too). I did do everything through Moinmoin's stand-alone server, but while I know there always seem to be ghosts in the machine, I'm guessing that Apache shouldn't interfere with layout issues. I mostly followed the WineHQ & current WineWiki theme for large things, just tweaking the CSS to make it fit what Moinmoin spits out. I did make more design choices of my own on the smaller stuff though. After wrestling with Moinmoin's theme system, I was surprised how many things are still hard-coded (at least as of v1.5). For example, Moinmoin wraps some things in divs without providing a CSS class for the div, just the child element. The fortune cookie on the RecentChanges page & the edit page are two cases of that. The dummy content in the search bar is another tricky one. It's set in the javascript for the search bar (don't remember where it was in the source tree) so I left that one alone. One other tricky issue was handling overflows & RTL support. They both seem to work ok in isolation, but go crazy when you mix them. I haven't checked RTL in IE, but if you force an RTL page to overflow in Webkit, it positions things based on what's actually in the window (so the sidebar winds up floating in the middle of the page). Firefox simply doesn't try to apply any of the overflow rules in RTL (which I guess is nice in a Hippocratic sense). Opera alone handled things exactly like I hoped. As for the tables, I think they should display ok now, although I don't know if everyone wants my exact values for paddings & such. The old theme had some table-based layout that may have had conflicting CSS rules, but I've div-vied everything up so the only table tags now should be when Moinmoin itself chooses them over a div and well... tables. I've pushed all of the changes to my Bitbucket repo at: https://bitbucket.org/kauble/wine-wiki-migration The "refined" branch is the one you want although I expect that once the code is hosted at WineHQ's git repo, it would become the new master branch. At that point, I can just reset my repo to point to the WineHQ one as the origin. - Kyle

3 4

Re: user32: SetTimer should respect the minimum and maximum timeout limits.
by Marvin April 11, 2013

April 11, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25036 Your paranoid android. === TEST64_W7SP1 (64 bit msg) === msg.c:8247: Test failed: did not get expected count for minimum timeout (57 != ~64).

1 0

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.
by Ken Thomases April 11, 2013

April 11, 2013

On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote: > --- a/dlls/secur32/schannel_macosx.c > +++ b/dlls/secur32/schannel_macosx.c > @@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef transport, const void *buff, > return ret; > } > > +DWORD schan_imp_enabled_protocols(void) > +{ > + /* NOTE: No support for TLS 1.1 and TLS 1.2 */ > + return SP_PROT_SSL2_CLIENT | SP_PROT_SSL3_CLIENT | SP_PROT_TLS1_0_CLIENT; > +} Mac OS X 10.8 introduced support for TLS 1.1 and 1.2. You can test at build time with: #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1080 ... #else ... #endif If we want to support building on 10.8 for deployment to earlier versions, we'd do something like: #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1080 SSLProtocol maxProtocol; if (SSLGetProtocolVersionMax != NULL && SSLGetProtocolVersionMax(context, &maxProtocol) == noErr) { ... compare maxProtocol against kTLSProtocol11 and kTLSProtocol12 ... } ... #else ... #endif The idea is that SSLGetProtocolVersionMax() would be weak linked, so we'd check if it was actually available before calling it. Of course, the other complication is that that function requires a context parameter, but we can create one just for the query if we're interested in the framework capabilities (as opposed to what's been configured for a particular context). -Ken

3 10

Re: [2/5] include/wine/test.h: Report child process failures using shared memory.
by Alexandre Julliard April 11, 2013

April 11, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Alexandre Julliard <julliard(a)winehq.org> wrote: > >> > As far as I can see ExitProcess returns 'failures' as the child process exit >> > code, but variable 'failures' is not visible from the tests. Do you have a >> > suggestion how to fix that? >> >> You need to report the status a different way. For instance you could >> store it in a file. > > How does this one look like? (In theory this approach could be used > to transfer other child process information to the parent). Something like this would work, but it should be done in the test that needs it, not in the generic code. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 2/2] wined3d: Store ps 1.4 texture types in ps_compile_args
by Henri Verbeet April 11, 2013

April 11, 2013

On 11 April 2013 11:40, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + for (i = 0; i < 6; ++i) > + { This could probably do with an appropriate constant. > +enum shader_tex_types > +{ > + shader_tex_2d = 0, > + shader_tex_3d = 1, > + shader_tex_cube = 2, > +}; Please use uppercase for enum elements. Some "wined3d" prefixes probably wouldn't hurt either, although I guess it doesn't matter so much for things that are only used internally.

1 0

Google Summer of Code
by Liu Tuo April 10, 2013

April 10, 2013

Hi, I am Liu Tuo from National University of Singapore. I am interested in implementing missing D3DX9 APIs, how can I know more about this project and how can I apply for it? Is there anyone who can help me with this? Regards, Liu Tuo

2 1

We're in GSoC 2013
by Austin English April 10, 2013

April 10, 2013

If you're interested in mentoring, please apply at: https://www.google-melange.com/gsoc/org/google/gsoc2013/wine In either case, please take a look at http://wiki.winehq.org/SummerOfCodeand update/remove/any projects you're familiar with. If you have any questions, feel free to contact me. Thanks for your help everyone! -- -Austin

2 2

Re: [PATCH 8/8] wined3d: Skip non-textureable formats in check_fbo_compat().
by Henri Verbeet April 10, 2013

April 10, 2013

On 10 April 2013 01:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > --- > dlls/wined3d/utils.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index da8fc7b..5010676 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -1038,6 +1038,9 @@ static void check_fbo_compat(const struct wined3d_gl_info *gl_info, struct wined > GLenum status; > GLuint tex; > > + if (!(format->flags & WINED3DFMT_FLAG_TEXTURE)) > + return; > + I'm not sure about this one, what exactly should this achieve? In either case, this probably belongs in init_format_fbo_compat_info(), together with the other similar checks.

2 3

[PATCH v5 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky April 10, 2013

April 10, 2013

Main changes fom v4: 1) deny_lock_file uses FS_DOES_SHARELOCK flag from fs_flags to determine whether to use VFS locks or not. 2) Make nfs code return -EBUSY for share conflicts (was -EACCESS). Main changes from v3 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), The patchset avoid data races problem on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a deny lock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This let us not mix one share reservation approach with another. The #1 patch adds flags to fcntl and implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -EBUSY in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -EBUSY untill this open is closed. Now this flag is processed by CIFS filesystems only. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND ----- Pavel Shilovsky (7): fcntl: Introduce new O_DENY* open flags CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support CIFS: Use NT_CREATE_ANDX command for forcemand mounts NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts fs/cifs/cifsacl.c | 8 +-- fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 ++++++- fs/cifs/cifsproto.h | 8 +-- fs/cifs/cifssmb.c | 50 ++++++++++--------- fs/cifs/dir.c | 16 +++--- fs/cifs/file.c | 20 +++++--- fs/cifs/inode.c | 16 +++--- fs/cifs/link.c | 25 +++------- fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 +++--- fs/cifs/smb2file.c | 10 ++-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2ops.c | 10 ++-- fs/cifs/smb2pdu.c | 6 +-- fs/cifs/smb2proto.h | 14 +++--- fs/fcntl.c | 5 +- fs/locks.c | 105 ++++++++++++++++++++++++++++++++++++--- fs/namei.c | 45 +++++++++++++++-- fs/nfs/internal.h | 3 +- fs/nfs/nfs4proc.c | 4 +- fs/nfs/nfs4super.c | 9 ++-- fs/nfs/nfs4xdr.c | 21 ++++++-- fs/nfs/super.c | 7 ++- fs/nfsd/nfs4state.c | 46 ++++++++++++++++- fs/proc_namespace.c | 1 + include/linux/fs.h | 8 +++ include/uapi/asm-generic/fcntl.h | 11 ++++ include/uapi/linux/fs.h | 1 + 29 files changed, 364 insertions(+), 130 deletions(-) -- 1.8.1.5

4 14

Re: [PATCH 1/2] wined3d: Handle texture types via ps/vs_compile_args
by Henri Verbeet April 10, 2013

April 10, 2013

On 10 April 2013 13:39, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This patch only changes the way the texture types are fed into the > shader generation code. Generating the proper shader code (hardcoded > values instead of relying on the dummy textures) is a task I've left for > Matteo, who worked on this problem before. > > This patch originates from my work-in-progress command stream work. It > is one of the few that I think makes sense on its own. > --- Why do you need the sampler type for anything other than SM1 pixel shaders? Also, while in principle I'm all for not accessing wined3d_state from the shader backend, I don't think there should be anything in the command stream patches that would prevent that.

4 4

Re: [PATCH 1/8] wined3d: Remove useless glClearxxx calls.
by Henri Verbeet April 10, 2013

April 10, 2013

On 10 April 2013 01:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > - /* Clear the screen */ > - gl_info->gl_ops.gl.p_glClearColor(1.0f, 0.0f, 0.0f, 0.0f); > - checkGLcall("glClearColor"); > - gl_info->gl_ops.gl.p_glClearIndex(0); > - gl_info->gl_ops.gl.p_glClearDepth(1); > - gl_info->gl_ops.gl.p_glClearStencil(0xffff); > - > - checkGLcall("glClear"); > And actually potentially harmful, if the new context is created after an existing one already did drawing on the same drawable. (Although that's fairly unlikely, especially with "AlwaysOffscreen" enabled.)

2 1

Re: tools: add ProductId to the Windows NT Current Version block
by Alexandre Julliard April 10, 2013

April 10, 2013

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -3019,6 +3019,7 @@ HKLM,%CurrentVersionNT%,"CSDVersion",2,"Service Pack 3" > HKLM,%CurrentVersionNT%,"CurrentBuildNumber",2,"2600" > HKLM,%CurrentVersionNT%,"CurrentType",2,"Uniprocessor Free" > HKLM,%CurrentVersionNT%,"ProductName",2,"Microsoft Windows XP" > +HKLM,%CurrentVersionNT%,"ProductId",,"12345-oem-0000001-54321" I'm not sure it's a good idea to hardcode this. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: kernel32: Add a test for threads state when a process is being terminated. Take 2.
by Alexandre Julliard April 10, 2013

April 10, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This test demonstrates the problem reported in the bug 33331. > > This version of the patch moves the ExitProcess test into a child process. It still won't report failures properly though. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [3/13] wineconsole and kernel32: set GetLargestConsoleWindowSize based on screen resolution
by Nikolay Sivov April 10, 2013

April 10, 2013

On Mon, Apr 8, 2013 at 3:53 PM, Hugh McMaster < hugh.mcmaster(a)masterindexing.com> wrote: > This file recreates most, if not all, of the source found in > dlls/advapi32/registry.c in dlls/kernel32. It provides registry > functionality. > > Tested on Linux Mint 14 and Mac OS X 10.8 (Mountain Lion). > > --- > dlls/kernel32/advapi32_registry.c | 2928 > +++++++++++++++++++++++++++++++++++++ > 1 file changed, 2928 insertions(+) > create mode 100644 dlls/kernel32/advapi32_registry.c > > > Why do you need this? (not to mention that you can't just duplicate it like that)

3 8

Google Summer of code
by Liu Tuo April 10, 2013

April 10, 2013

Hi, I am Liu Tuo from National University of Singapore, a second year student in computer science. I am interested in joining this year's google summer of code in wine project. Have a nice day, Liu Tuo

1 0

Google summer of code
by Tabibel Sami April 9, 2013

April 9, 2013

Hi, I am sami, i am student at limoges university in france am doing a master degree: Cryptology and information security and am interesting to work on wine project this summer I like C programming. Regards

1 0

[AppDB] -more spam-
by Joerg Schiermeier April 9, 2013

April 9, 2013

Hi list, again a spammer used the AppDB for his nasty activities: 1.) > Comment for 'Adobe Photoshop CS3 (10.0)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=6584#Comment-8… 2.) > Comment for 'ElsterFormular 12.0 (2010 + 2011)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=22570#Comment-… No. #2 is maintained by me, so I deleted the comment just some minutes ago. Is it possible, to mail to all maintainers to inform them about the actual mail food and to have an eye on their applications? If so please do it. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1

Re: [1/3] include: Add COM interface definitions needed for PrintDlgEx implementation.
by Nikolay Sivov April 9, 2013

April 9, 2013

Why not use DECLARE_INTERFACE_ here? And why bother checking UNICODE? On Mon, Apr 8, 2013 at 12:10 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/uuid/uuid.c | 1 + > include/commdlg.h | 80 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 81 insertions(+) > > diff --git a/dlls/uuid/uuid.c b/dlls/uuid/uuid.c > index fd96fe3..fb06f2d 100644 > --- a/dlls/uuid/uuid.c > +++ b/dlls/uuid/uuid.c > @@ -83,6 +83,7 @@ DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); > #include "sensevts.h" > #include "ocmm.h" > #include "commoncontrols.h" > +#include "commdlg.h" > #include "tlogstg.h" > #include "msdasc.h" > > diff --git a/include/commdlg.h b/include/commdlg.h > index 1a6e1d9..6eeb615 100644 > --- a/include/commdlg.h > +++ b/include/commdlg.h > @@ -762,6 +762,86 @@ typedef struct tagPDEXW > DECL_WINELIB_TYPE_AW(PRINTDLGEX) > DECL_WINELIB_TYPE_AW(LPPRINTDLGEX) > > +#ifdef STDMETHOD > +DEFINE_GUID(IID_IPrintDialogCallback, > 0x5852a2c3,0x6530,0x11d1,0xb6,0xa3,0x00,0x00,0xf8,0x75,0x7b,0xf9); > +typedef interface IPrintDialogCallback IPrintDialogCallback; > + > +#if defined(__cplusplus) && !defined(CINTERFACE) > +MIDL_INTERFACE("5852a2c3-6530-11d1-b6a3-0000f8757bf9") > +IPrintDialogCallback : public IUnknown > +{ > + virtual HRESULT STDMETHODCALLTYPE InitDone() = 0; > + virtual HRESULT STDMETHODCALLTYPE SelectionChange() = 0; > + virtual HRESULT STDMETHODCALLTYPE > HandleMessage(HWND,UINT,WPARAM,LPARAM,LRESULT *) = 0; > +}; > +#else > +typedef struct IPrintDialogCallbackVtbl > +{ > + BEGIN_INTERFACE > + > + /*** IUnknown methods ***/ > + HRESULT (STDMETHODCALLTYPE *QueryInterface)(IPrintDialogCallback > *This,REFIID riid,void **ppvObject); > + ULONG (STDMETHODCALLTYPE *AddRef)(IPrintDialogCallback *This); > + ULONG (STDMETHODCALLTYPE *Release)(IPrintDialogCallback *This); > + /*** IPrintDialogCallback methods ***/ > + HRESULT (STDMETHODCALLTYPE *InitDone)(IPrintDialogCallback *This); > + HRESULT (STDMETHODCALLTYPE *SelectionChange)(IPrintDialogCallback > *This); > + HRESULT (STDMETHODCALLTYPE *HandleMessage)(IPrintDialogCallback > *,HWND,UINT,WPARAM,LPARAM,LRESULT *); > + > + END_INTERFACE > +} IPrintDialogCallbackVtbl; > +interface IPrintDialogCallback > +{ > + CONST_VTBL IPrintDialogCallbackVtbl *lpVtbl; > +}; > +#endif /* CINTERFACE */ > + > +DEFINE_GUID(IID_IPrintDialogServices, > 0x509aaeda,0x5639,0x11d1,0xb6,0xa1,0x00,0x00,0xf8,0x75,0x7b,0xf9); > +typedef interface IPrintDialogServices IPrintDialogServices; > + > +#if defined(__cplusplus) && !defined(CINTERFACE) > +MIDL_INTERFACE("509aaeda-5639-11d1-b6a1-0000f8757bf9") > +IPrintDialogServices : public IUnknown > +{ > +#ifdef UNICODE > + virtual HRESULT STDMETHODCALLTYPE GetCurrentDevMode(LPDEVMODEW,UINT > *) = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPrinterName(LPWSTR,UINT > *) = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPortName(LPWSTR,UINT *) = > 0; > +#else > + virtual HRESULT STDMETHODCALLTYPE GetCurrentDevMode(LPDEVMODEA,UINT > *) = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPrinterName(LPSTR,UINT *) > = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPortName(LPSTR,UINT *) = > 0; > +#endif > +}; > +#else > +typedef struct IPrintDialogServicesVtbl > +{ > + BEGIN_INTERFACE > + > + /*** IUnknown methods ***/ > + HRESULT (STDMETHODCALLTYPE *QueryInterface)(IPrintDialogServices > *This,REFIID riid,void **ppvObject); > + ULONG (STDMETHODCALLTYPE *AddRef)(IPrintDialogServices *This); > + ULONG (STDMETHODCALLTYPE *Release)(IPrintDialogServices *This); > + /*** IPrintDialogServices methods ***/ > +#ifdef UNICODE > + HRESULT (STDMETHODCALLTYPE *GetCurrentDevMode)(IPrintDialogServices > *,LPDEVMODEW *,UINT *); > + HRESULT (STDMETHODCALLTYPE > *GetCurrentPrinterName)(IPrintDialogServices *,LPWSTR,UINT *); > + HRESULT (STDMETHODCALLTYPE *GetCurrentPortName)(IPrintDialogServices > *,LPWSTR,UINT *); > +#else > + HRESULT (STDMETHODCALLTYPE *GetCurrentDevMode)(IPrintDialogServices > *,LPDEVMODEA *,UINT *); > + HRESULT (STDMETHODCALLTYPE > *GetCurrentPrinterName)(IPrintDialogServices *,LPSTR,UINT *); > + HRESULT (STDMETHODCALLTYPE *GetCurrentPortName)(IPrintDialogServices > *,LPSTR,UINT *); > +#endif > + > + END_INTERFACE > +} IPrintDialogServicesVtbl; > +interface IPrintDialogServices > +{ > + CONST_VTBL IPrintDialogServicesVtbl *lpVtbl; > +}; > +#endif /* CINTERFACE */ > +#endif /* STDMETHOD */ > + > BOOL WINAPI ChooseColorA(LPCHOOSECOLORA lpChCol); > BOOL WINAPI ChooseColorW(LPCHOOSECOLORW lpChCol); > #define ChooseColor WINELIB_NAME_AW(ChooseColor) > -- > 1.8.2 > > > >

3 3

[AppDB] -more spam-
by Joerg Schiermeier April 9, 2013

April 9, 2013

Hi list, again a spammer used the AppDB for his nasty activities: 1.) > Comment for 'Adobe Photoshop CS3 (10.0)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=6584#Comment-8… 2.) > Comment for 'ElsterFormular 12.0 (2010 + 2011)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=22570#Comment-… No. #2 is maintained by me, so I deleted the comment just some minutes ago. Is it possible, to mail to all maintainers to inform them about the actual mail food and to have an eye on their applications? If so please do it. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

[GSoC] My (new) proposal for GSoC 2013
by Gediminas Jakutis April 9, 2013

April 9, 2013

Hello! My previous application[1] turned out to be a total failure, hence making a completely different one. My proposal this time goes as follows: Write various D3D tests, mostly focusing on ones that can be later re-used for dxdiag in one way or another. Along with writing a tool that would allow users to easily test if d3d and wgl / opengl work & are set up properly. Info about me (copied over from [1]): >My name is Gediminas Jakutis. I study Informatics Engineering >[bachelor / undergraduate] at Kaunas University of Technology, second >year. >I wish to try out GSoC for the first time by helping to improve Wine. >My primary programming language is C. I am self-taught in C, but I >believe my knowledge is good enough. >I am quite familiar with Wine - I use it and experiment with it for >many years now. I am subscribed to and read wine-devel for more than a >year. >I browse through Wine's source code once in a while out of curiosity. >Thus, I have some knowledge of its structure. >Sadly, I have not written any patches for Wine yet. Mostly due to lack of confidence. [1] http://www.winehq.org/pipermail/wine-devel/2013-March/099213.html Thank You for Your time Gediminas Jakutis -- LDK Varčiai www.varciai.lt

2 4

Re: kernel32: Add a test for threads state when a process is being terminated.
by Marvin April 9, 2013

April 9, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24997 Your paranoid android. === W2KPROSP4 (32 bit loader) === No test summary line found === W2K3R2SESP2 (32 bit loader) === No test summary line found === W2K8SE (32 bit loader) === No test summary line found === W7PROX64 (32 bit loader) === No test summary line found === TEST64_W7SP1 (32 bit loader) === No test summary line found

1 0

[AppDB] Comment for 'Microsoft Outlook 2007' added by bayu
by Joerg Schiermeier April 9, 2013

April 9, 2013

On Monday, April 8, 2013 at 07:49:47 an anonymous spammer wrote into the AppDB: > Comment for 'Microsoft Outlook 2007' added by bayu > http://appdb.winehq.org/objectManager.php?sClass=version&iId=7533#Comment-8… (...garbage killed...) Could someone of AppDBs admin please kill this comment and the user 'bayu'. Thanks lot! -- Kindly regards Joerg Schiermeier Bielefeld/Germany

4 3

Re: [1/13] wineconsole and kernel32: set GetLargestConsoleWindowSize based on screen resolution
by Frédéric Delanoy April 9, 2013

April 9, 2013

On Mon, Apr 8, 2013 at 2:53 PM, Hugh McMaster < hugh.mcmaster(a)masterindexing.com> wrote: > This patch creates winecon_private.h in 'include/wineconsole'. The header > is now a shared header. Note that the source code is the same as that in > programs/wineconsole/winecon_private.h. (This latter file will be removed > later.) > > Tested on Linux Mint 14 and Mac OS X 10.8 (Mountain Lion). > > --- > include/wineconsole/winecon_private.h | 103 > +++++++++++++++++++++++++++++++++ > 1 file changed, 103 insertions(+) > create mode 100644 include/wineconsole/winecon_private.h > Please don't send 13 patches with the same name. Also, for long patch series, you should describe the whole purpose of the series in the first patch [1/N] (or even better in a [0/N] patch) Finally,even if "one change per patch" is the rule, don't overdo it... Frédéric

2 1

Dosbox integration
by Fabian Ebner April 9, 2013

April 9, 2013

Hello, I'm Fabian Ebner and work with wine as a hobby. I found that GetShortNameA converts the example path C:\123456789\dn\DN.COM to C:\1234~Q4C\dn\DN.COM which causes problems with dosbox integration. Dosbox would need the path as C:\123456~1\dn\DN.COM Is there another function that converts the path in the way, dosbox needs it, should it be implemented or should dosbox be able to handle the first form of the path too? Also wine often tries to mount his z: drive, which isn't possible, because dosbox already mounts an own Z: drive http://www.dosbox.com/wiki/ZDrive Maybe wine should mount his Z: as Y:? Thanks in advance ~Fabian

2 1

Re: [3/3] comdlg32: Add an interactive PrintDlgEx test. Resend.
by Marvin April 9, 2013

April 9, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24996 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: extrac32: Preprocess command line before passing to CommandLineToArgvW().
by Alexandre Julliard April 8, 2013

April 8, 2013

Sergey Guralnik <serhio(a)etersoft.ru> writes: > There are two ways to solve this promlem: > - write own parser for extrac32, > - perform some translation for command line before > passing to CommandLineToArgvW(). > > I think that second variant is more appropriate. The first one would be cleaner. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Properly handle backbuffer_width/_height=0 in wined3d_device_reset. (try 3)
by Alexandre Julliard April 8, 2013

April 8, 2013

Sam Edwards <cfsworks(a)gmail.com> writes: > This patch differs from try 2 in formatting alone. > > From ac2134cfce1139cb35c4ea5c3943a870183fc2f4 Mon Sep 17 00:00:00 2001 > From: Sam Edwards <CFSworks(a)gmail.com> > Date: Sat, 6 Apr 2013 18:03:34 -0600 > Subject: wined3d: Properly handle backbuffer_width/_height=0 in > wined3d_device_reset. It fails here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so d3d9ex.c && touch d3d9ex.ok d3d9ex.c:693: Test succeeded inside todo block: Got unexpected scissor rect {0, 0, 200, 150}. d3d9ex.c:701: Test succeeded inside todo block: Got unexpected vp.Width 200. d3d9ex.c:702: Test succeeded inside todo block: Got unexpected vp.Height 150. d3d9ex.c:710: Test succeeded inside todo block: Got unexpected backbuffer width 200. d3d9ex.c:711: Test succeeded inside todo block: Got unexpected backbuffer height 150. make[1]: *** [d3d9ex.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9 [patch 1/2, resend]: Floatify fabs into fabs
by Matteo Bruni April 8, 2013

April 8, 2013

2013/4/7 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > Both patches are fine for me (note that the email subject is missing an "f" but the actual patch has the correct title).

1 0

[PATCH v4 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky April 8, 2013

April 8, 2013

Main changes from the previous one: 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), The patchset avoid data races problem on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a deny lock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This let us not mix one share reservation approach with another. The #1 patch adds flags to fcntl and implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -EBUSY in following cases: 1) if O_DENYREAD flag is specified and there is another open with O_DENYMAND flag and READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with O_DENYMAND flag and WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYMAND and O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYMAND and O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -EBUSY untill this open is closed. Now this flag is processed by CIFS filesystems only. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND ----- Pavel Shilovsky (7): fcntl: Introduce new O_DENY* open flags CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support CIFS: Use NT_CREATE_ANDX command for forcemand mounts NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts fs/cifs/cifsacl.c | 8 +-- fs/cifs/cifsglob.h | 18 ++++++- fs/cifs/cifsproto.h | 8 +-- fs/cifs/cifssmb.c | 50 +++++++++--------- fs/cifs/dir.c | 16 +++--- fs/cifs/file.c | 20 +++++--- fs/cifs/inode.c | 16 +++--- fs/cifs/link.c | 25 +++------ fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 +++--- fs/cifs/smb2file.c | 10 ++-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2ops.c | 10 ++-- fs/cifs/smb2pdu.c | 6 +-- fs/cifs/smb2proto.h | 14 ++--- fs/fcntl.c | 5 +- fs/locks.c | 108 ++++++++++++++++++++++++++++++++++++--- fs/namei.c | 45 ++++++++++++++-- fs/nfs/internal.h | 3 +- fs/nfs/nfs4proc.c | 2 + fs/nfs/nfs4xdr.c | 21 ++++++-- fs/nfs/super.c | 3 +- fs/nfsd/nfs4state.c | 46 ++++++++++++++++- fs/proc_namespace.c | 1 + include/linux/fs.h | 7 +++ include/uapi/asm-generic/fcntl.h | 11 ++++ include/uapi/linux/fs.h | 1 + 27 files changed, 355 insertions(+), 124 deletions(-) -- 1.8.1.5

2 10

Re: [3/3] comdlg32: Add an interactive PrintDlgEx test.
by Marvin April 8, 2013

April 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24985 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: extrac32: Preprocess command line before passing to CommandLineToArgvW().
by Sergey Guralnik April 8, 2013

April 8, 2013

On 2013-04-04 15:19, Sergey Guralnik wrote: > Playing with one application, that uses extrac32.exe, > I've found that Wine's extrac32 can't process some > command lines, that cause no problem with native one. > ... Is this patch or explanation not clear enough? (Still marked as "New") -- Sergey

1 0

Re: wbemprox: Implement some properties of Win32_ComputerSystem and Win32_DiskPartition.
by Hans Leidekker April 8, 2013

April 8, 2013

On Mon, 2013-04-08 at 01:56 +0900, Kim Jung Eon (김중언) wrote: > @@ -241,18 +243,21 @@ static const struct column col_compsys[] = > { prop_modelW, CIM_STRING }, > { prop_numlogicalprocessorsW, CIM_UINT32, VT_I4 }, > { prop_numprocessorsW, CIM_UINT32, VT_I4 }, > - { prop_totalphysicalmemoryW, CIM_UINT64 } > + { prop_totalphysicalmemoryW, CIM_UINT64 }, > + { prop_nameW, CIM_STRING|COL_FLAG_DYNAMIC } Please keep properties sorted.

1 0

Re: d3dx9 [patch 1/3]: Avoid two useless computations
by Rico Schüller April 7, 2013

April 7, 2013

On 05.04.2013 09:13, Nozomi Kodama wrote: > s = 0.75f; > - if ( order > 2 ) > - s += 5.0f / 16.0f; > - if ( order > 4 ) > - s -= 3.0f / 32.0f; > + if (order > 2) > + s = 1.0625f; > + if (order > 4) > + s = 0.96875f; > s /= D3DX_PI; Doesn't the compiler do that already? If not something like this would probably better: s = 0.23873...f; /* 0.75f / D3DX_PI */ if (order > 2) s = 1.0625f / D3DX_PI; if (order > 4) s = 0.96875f / D3DX_PI; Cheers Rico

2 1

Re: wbemprox: Implement some properties of Win32_ComputerSystem and Win32_DiskPartition.
by Nikolay Sivov April 7, 2013

April 7, 2013

Please use your real name. On Sun, Apr 7, 2013 at 7:46 PM, mog422 <admin(a)mog422.net> wrote: > > > > >

1 0

64bit winelib test app fails on AMD CPU, but works on Intel - need help to identify possible problem, please :)
by jordan April 7, 2013

April 7, 2013

Hey List, A few days ago, i posted to the list about possibly porting a winelib app to support x86_64. (currently supports x86). the original post is here (for those interested, but not entirely relevant to this post): http://wine.1045685.n5.nabble.com/exploring-possibly-porting-winelib-app-to… moving on. So we have a simple test app, that successfully loads 64bit DLLs on my friend's Intel based machines, while on my AMD Phenom II 965 X4 - the code fails. -> Successful on Intel: xj(a)xj:~/Muzyka/fsthost/trunk$ ./test64.exe ../../VST/ColourEQ_64.dll Load plugin ../../VST/ColourEQ_64.dll fixme:heap:HeapSetInformation 0x3c4000 0 0x22f610 4 Main entry: 0x1800077d0 Revive plugin V: 66048 U: 1131365713 NI: 2 NO: 2 NPr: 10 NPa: 42 Open Close So intel computers tested (2 that i know of) work just fine. -> Failure on AMD: http://pastebin.com/x64pig3s and a little snippet: ./test64.exe '/home/ninez/Desktop/ColourEQ_64.dll' fixme:heap:HeapSetInformation 0x2c4000 0 0x23fce0 4 Load plugin /home/ninez/Desktop/ColourEQ_64.dll fixme:heap:HeapSetInformation 0x3d4000 0 0x23f5f0 4 Main entry: 0x1800077d0 Revive plugin wine: Unhandled page fault on read access to 0xffffffff at address 0xffffffff (thread 002a), starting debugger... fixme:dbghelp:elf_search_auxv can't find symbol in module <snip> fixme:dbghelp:elf_search_auxv can't find symbol in module Unhandled exception: page fault on read access to 0xffffffff in 64-bit code (0x00000000ffffffff). fixme:dbghelp:elf_search_auxv can't find symbol in module Register dump: rip:00000000ffffffff rsp:000000000023fa78 rbp:000000000023fbd0 eflags:00010246 ( R- -- I Z- -P- ) rax:00000000003d8de0 rbx:0000000000000000 rcx:0000000000000000 rdx:0000000000000001 rsi:00000000ffffffff rdi:00007f1205f559d0 r8:0000000000000000 r9:0000000000000000 r10:0000000000000001 r11:0000000000000000 r12:0000000000000000 r13:00007f1205f50040 r14:000000007b86f920 r15:00007fffffbe8000 Stack dump: 0x000000000023fa78: 0000000180007756 00000000003d8de0 0x000000000023fa88: 00007f1206ff14d3 0000000000010ac1 0x000000000023fa98: 000000000000000d 0000000000000000 0x000000000023faa8: 00007f1200000000 fffffffffffffffe 0x000000000023fab8: 000000000023fbd0 00007f1205f559d0 0x000000000023fac8: 00007f1205f55b09 2020202020202020 0x000000000023fad8: 0000000000010ac1 00007f1207324323 0x000000000023fae8: 0000000000002000 ffff00ffffffffff 0x000000000023faf8: ffff00ffffffffff 0000000000202020 0x000000000023fb08: 00000001800077d0 0000000180000000 0x000000000023fb18: 0000000000010ac1 5b5b5b5b5b5b5b5b 0x000000000023fb28: 5b5b5b5b5b5b5b5b 2020202020202020 It's odd that it is working on Intel H/W, but not my AMD system. ~ what could be a possible reason for this? We've made s simple test app that doesn't require jackd, or FSThost functions, to simplify things. The source code can be found here: https://sourceforge.net/p/fsthost/code/171/tree/ SVN code required: svn checkout svn://svn.code.sf.net/p/fsthost/code/trunk fsthost-code the test app source code is called 'test64-most-simple.c' The test app can be compiled with; $ make -f Makefile64-most-simple then $ ./test64.exe /path/to/64bitVST a tester can be found here: http://www.ddmf.eu/freeware.php grab 'ColourEQ' (contains both 32bit and 64bit versions... and obviously use the 64bit version to try/test.) anyway, i am not sure what the problem is, maybe someone here has an idea or two? ... i've been wondering if there is some sort of misalignment/compiler issue, that is causing the problem...but i want to rule out Wine64 being an issue, first - if possible. any help is appreciated. Thanks Jordan

5 12

Build and override a simple winelib DLL
by Maxime Sednaoui April 6, 2013

April 6, 2013

Hi, First, I already asked for the same thing at the forum where I've been told to post here for my question Link here : http://forum.winehq.org/viewtopic.php?f=8&t=18675 I have a Windows executable that load a really simple DLL (it is a test) and I want to create a Winelib DLL that will override the Windows DLL. Basically, I created mylib_main.c and mylib.spec to build the Winelib DLL with the command: winegcc -mwindows -o mylib.dll.so mylib_main.c -I${WINE_ROOT}/include -shared mylib.spec winebuild -w --def -o libmylib.def --export mylib.spec Now I have mylib.dll.so and I want to override mylib.dll What should I do ? I removed the Windows library but then I got a Page Fault when the function is called. I also tried to configure the override with winecfg or set environment variables like WINEDLLPATH or add a DllMain in my library. I don't understand how to proceed. Is this because of the way I build my library ? Or maybe I forget a step to link it properly ? In attachment, a tar with the sources and binaries myapp.exe : the Windows executable mylib.dll : the Windows library mylib_main.c , mylib.spec : the sources to build the Winelib library

3 3

Portability - Port Wine to Wayland
by André Hentschel April 5, 2013

April 5, 2013

Hi Dan, i just removed your gsoc idea and i want to let you know why. There was a quite short discussion on IRC: Andre_H_laptop: austin_laptop: Dan added a quite controversal gsoc idea... afaik ken needed 1 year for the mac driver and dan further suggests to have a look at xwayland first to see if a new driver is needed. So the time needed for that job is some days to 1 year. what do you think? julliard: Andre_H_laptop: writing a graphics driver is definitely not suitable for gsoc

2 1

Re: [PATCH 2/2] winspool.drv: Check the value of pDeviceName.(try 3)
by Marvin April 5, 2013

April 5, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24967 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Trying Battle for Wesnoth in Wine.
by Tae Wong April 5, 2013

April 5, 2013

You haven’t tried Battle for Wesnoth latest version in Wine on Ubuntu so you have uploaded the about.cfg file to MediaFire which contains over 1000 lines and some un-terminated quoted strings in many names. Check it here (http://www.mediafire.com/?mbw9y2i834z2k7r) Swear at error message (Quoted string not terminated) whilst you fix the un-terminated quoted strings.

2 1

Trying Battle for Wesnoth in Wine.
by Tae Wong April 5, 2013

April 5, 2013

You haven’t tried Battle for Wesnoth latest version in Wine on Ubuntu so you have uploaded the about.cfg file which contains over 1000 lines and some un-terminated quoted strings in many names.

1 0

[PATCH v3 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky April 4, 2013

April 4, 2013

This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why one extra flag O_DENYMAND is added. It indicates to underlying layer that an application want to use O_DENY* flags semantic. It allows us not affect native Linux applications (that don't use O_DENYMAND flag) - so, these flags (and the semantic of open syscall that they bring) are used only for those applications that really want it proccessed that way. So, we have four new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), O_DENYMAND - to switch on/off three flags above. Also, this version of the patchset fixes the problem of data races on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a deny lock by another task. The #1 patch adds flags to fcntl, the #2 patch implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYMAND - used to inforce a mandatory share reservation scheme of the file access. If this flag is passed, the open fails with -ETXTBSY in following cases: 1) if O_DENYREAD flag is specified and there is another open with O_DENYMAND flag and READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with O_DENYMAND flag and WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYMAND and O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYMAND and O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ETXTBSY untill this open is closed. Now this flag is processed by CIFS filesystems only. This mechanism is done through flocks. If O_DENYMAND is specified and flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) O_DENYMAND -> LOCK_MAND 2) !O_DENYREAD -> LOCK_READ 3) !O_DENYWRITE -> LOCK_WRITE ----- Pavel Shilovsky (7): fcntl: Introduce new O_DENY* open flags vfs: Add O_DENYREAD/WRITE flags support for open syscall CIFS: Add O_DENY* open flags support CIFS: Use NT_CREATE_ANDX command for forcemand mounts CIFS: Translate SHARING_VIOLATION to -ETXTBSY error code for SMB2 NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS fs/cifs/cifsacl.c | 6 +- fs/cifs/cifsglob.h | 12 +++- fs/cifs/cifsproto.h | 9 +-- fs/cifs/cifssmb.c | 47 ++++++++-------- fs/cifs/dir.c | 14 +++-- fs/cifs/file.c | 18 ++++-- fs/cifs/inode.c | 11 ++-- fs/cifs/link.c | 10 ++-- fs/cifs/readdir.c | 2 +- fs/cifs/smb1ops.c | 15 ++--- fs/cifs/smb2file.c | 10 ++-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 10 ++-- fs/cifs/smb2pdu.c | 6 +- fs/cifs/smb2proto.h | 14 +++-- fs/fcntl.c | 5 +- fs/locks.c | 117 +++++++++++++++++++++++++++++++++++---- fs/namei.c | 44 ++++++++++++++- fs/nfs/nfs4xdr.c | 24 ++++++-- fs/nfsd/nfs4state.c | 46 ++++++++++++++- include/linux/fs.h | 6 ++ include/uapi/asm-generic/fcntl.h | 14 +++++ 23 files changed, 345 insertions(+), 101 deletions(-) -- 1.8.1.2

8 36

Re: wined3d: Properly handle backbuffer_width/_height=0 in wined3d_device_reset.
by Henri Verbeet April 4, 2013

April 4, 2013

Is this really the correct behaviour when windowed is FALSE and the backbuffer width / height is 0? That may just not be allowed at all, but it seems weird to use the window's dimensions in that case, instead of e.g. the current display mode. > if (!swapchain_desc->backbuffer_width || !swapchain_desc->backbuffer_height > || swapchain_desc->backbuffer_width != swapchain->desc.backbuffer_width > || swapchain_desc->backbuffer_height != swapchain->desc.backbuffer_height) Double indent for line continuations, please. > window = swapchain_desc->device_window ? > swapchain_desc->device_window : device->create_parms.focus_window; This is really just the same as "window = swapchain->device_window;". > if(swapchain_desc->backbuffer_width) Space between control statements and '('.

1 0

Re: extrac32: Preprocess command line before passing to CommandLineToArgvW().
by Sergey Guralnik April 4, 2013

April 4, 2013

On 2013-04-04 15:19, Sergey Guralnik wrote: > Playing with one application, that uses extrac32.exe, > I've found that Wine's extrac32 can't process some > command lines, that cause no problem with native one. > ... > There are two ways to solve this promlem: > - write own parser for extrac32, > - perform some translation for command line before > passing to CommandLineToArgvW(). P.S. Replacing wWinMain() with wmain() doesn't solve this problem. -- Sergey

1 0

Wine Gecko 2.20-beta1
by Jacek Caban April 4, 2013

April 4, 2013

Hi all, I've uploaded a new Gecko builds to SourceForge [1]. This one is based on Firefox 20 beta and, other than usual update of Gecko, it should fix some crashes like bug b*ug 32753* <http://bugs.winehq.org/show_bug.cgi?id=32753>. To test them, you need recent Wine Git version with the attached patch. As usually, grab the build from SourceForge, put it in the right place [2] and run patched Wine. All help with testing is appreciated! Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/2.20-beta1/ [2] http://wiki.winehq.org/Gecko

1 1

Re: cmd: Remove a pointless linefeed in an error message.
by Julian Rüger April 4, 2013

April 4, 2013

Sorry for nagging ;) Wasn't the convention to assume an 80-character wide terminal? This line would wrap, then. So the linefeed is not totally pointless here. Please correct me, if I'm mistaken. Best regards, Julian Am Mittwoch, den 03.04.2013, 16:07 +0200 schrieb Francois Gouget: > --- > programs/cmd/cmd.rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/programs/cmd/cmd.rc b/programs/cmd/cmd.rc > index c3cdb52..d464cab 100644 > --- a/programs/cmd/cmd.rc > +++ b/programs/cmd/cmd.rc > @@ -360,5 +360,5 @@ Enter HELP <command> for further information on any of the above commands.\n" > WCMD_NOOPERAND, "Expected an operand.\n" > WCMD_NOOPERATOR, "Expected an operator.\n" > WCMD_BADPAREN, "Mismatch in parentheses.\n" > - WCMD_BADHEXOCT, "Badly formed number - must be one of decimal (12),\n hexadecimal (0x34) or octal (056).\n" > + WCMD_BADHEXOCT, "Badly formed number - must be one of decimal (12), hexadecimal (0x34) or octal (056).\n" > }

2 1

Re: msvcr110: forward __crtSetUnhandledExceptionFilter to kernel32.SetUnhandledExceptionFilter (try 2)
by Dmitry Timoshkov April 4, 2013

April 4, 2013

Austin English <austinenglish(a)gmail.com> wrote: > Try 2: use cdecl calling convention > -@ stub __crtSetUnhandledExceptionFilter > +@ cdecl __crtSetUnhandledExceptionFilter(ptr) kernel32.SetUnhandledExceptionFilter It's not acceptable to mix calling conventions when forwarding an API with number of arguments != 0. -- Dmitry.

1 0

Re: [PATCH 2/2] winspool.drv: Check the value of pDeviceName.(try 2, resend)
by Marvin April 3, 2013

April 3, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24942 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [PATCH 1/2] winspool.drv/tests: Add DocumentProperties test with empty pDeviceName.
by Marvin April 3, 2013

April 3, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24941 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [PATCH 8/8] configure: Get rid of no longer needed OpenSSL checks.
by Marcus Meissner April 3, 2013

April 3, 2013

Hi, I have one concern ... Licensing. GNUTLS is (L)GPLv3+ these days. Wine will now turn into a LPGLv3+ licensed binary (not the sources, just the binaries will turn into it implicitly by linking against gnutls 3). Ciao, Marcus On Wed, Apr 03, 2013 at 02:06:09PM +0200, Jacek Caban wrote: > --- > configure.ac | 13 ------------- > 1 file changed, 13 deletions(-) > > > diff --git a/configure.ac b/configure.ac > index d8f2e8d..080e961 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -66,8 +66,6 @@ AC_ARG_WITH(openal, AS_HELP_STRING([--without-openal],[do not use OpenAL]), > AC_ARG_WITH(opencl, AS_HELP_STRING([--without-opencl],[do not use OpenCL]), > [if test "x$withval" = "xno"; then ac_cv_header_CL_cl_h=no; ac_cv_header_OpenCL_opencl_h=no; fi]) > AC_ARG_WITH(opengl, AS_HELP_STRING([--without-opengl],[do not use OpenGL])) > -AC_ARG_WITH(openssl, AS_HELP_STRING([--without-openssl],[do not use OpenSSL]), > - [if test "x$withval" = "xno"; then ac_cv_header_openssl_err_h=no; ac_cv_header_openssl_ssl_h=no; fi]) > AC_ARG_WITH(osmesa, AS_HELP_STRING([--without-osmesa],[do not use the OSMesa library])) > AC_ARG_WITH(oss, AS_HELP_STRING([--without-oss],[do not use the OSS sound support])) > AC_ARG_WITH(png, AS_HELP_STRING([--without-png],[do not use PNG]), > @@ -469,8 +467,6 @@ AC_CHECK_HEADERS(\ > netinet/in_systm.h \ > netinet/tcp.h \ > netinet/tcp_fsm.h \ > - openssl/err.h \ > - openssl/ssl.h \ > png.h \ > poll.h \ > port.h \ > @@ -1604,15 +1600,6 @@ fi > WINE_NOTICE_WITH(fontconfig,[test "x$ac_cv_lib_soname_fontconfig" = "x"], > [fontconfig ${notice_platform}development files not found, fontconfig won't be supported.]) > > -dnl **** Check for SSL **** > -if test "$ac_cv_header_openssl_err_h" = "yes" -a "$ac_cv_header_openssl_ssl_h" = "yes" > -then > - WINE_CHECK_SONAME(ssl,SSL_library_init) > - WINE_CHECK_SONAME(crypto,BIO_new_socket) > -fi > -WINE_WARNING_WITH(openssl,[test "x$ac_cv_lib_soname_ssl" = "x" -o "x$ac_cv_lib_soname_crypto" = "x"], > - [OpenSSL ${notice_platform}development files not found, SSL won't be supported.]) > - > dnl **** Check for gsm codec **** > if test "$ac_cv_header_gsm_h" = "yes" -o "$ac_cv_header_gsm_gsm_h" = "yes" > then > >

1 1

Re: [PATCH] winspool.drv: Check the value of pDeviceName.(try 2)
by Nikolay Sivov April 3, 2013

April 3, 2013

On Wed, Apr 3, 2013 at 1:31 PM, Tatyana Fokina <tatyana(a)etersoft.ru> wrote: > Function DocumentPropertiesA calling GDI_CallExtDeviceMode16: If value > pDeviceName is "", from GDI_CallExtDeviceMode16 return -1. > > Is it possible to add a test for that?

2 1

Re: ieframe: Added GoForward tests.
by Marvin April 3, 2013

April 3, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24939 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2615: Test failed: expected GetOverridesKeyPath webbrowser.c:2620: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2621: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3065: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Hi Res Icons
by Joel Holdsworth April 3, 2013

April 3, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Alexandre (+ Others), I notice you've been working on hi-res icons. I just have a couple of comments to chip in. So 2 years ago when I was doing the wine icon refresh, I decided not to try and tackle the problem of hi-res icons. Just getting the normal sized icons merged had proved to be a gargantuan task that took me over a year to complete - I didn't have the stomach to embark on another round of artwork. We also didn't support PNG icons in those days. As you can see in these hi-res icon patches, scaling icons is never as simple as people think. http://source.winehq.org/git/wine.git/blob/HEAD:/programs/iexplore/iexplore… As you can see here, scaling the iexplore icons really shows the limits of this artwork. The line caps are wrong in several places. The worst being in the highlight of the yellow swoosh at the bottom - you see the highlight doesn't line up with the border. A lot of things don't quite line up correctly. Moreover what were sharp single pixel lines in the 48x48 image have become fat strokes, which look rather play-schoolish to my eye. The solution is to have dedicated artwork specifically for these large sizes. This has been done in the Mango icon project: http://jimmac.musichall.cz/i.php?i=MIME2 http://jimmac.musichall.cz/i.php?i=git3 http://jimmac.musichall.cz/i.php?i=Tango-NG This is the work of Jakub Steiner and Lapo Calamandrei. They did a workshop on how to do this artwork here: https://www.youtube.com/watch?v=2T7833s2MJI Notice the fine detailing and beautiful shading. In the network filter they even used a paper texture for the card of the folder! These guys have done a fantastic job. So I wanted to sound out how much desire there is for this for Wine. I'm probably not going to be able to contribute this myself, due to time constraints. I wondered if there were any other developers cum artists interested in having a go. 2 years ago I asked Jakub if he would be interested in doing this, but he said he was quite busy. It might be worth reaching out to him or Lapo again, to see if they'd like to contribute. Also, I don't know how much this work is being driven by CodeWeavers Mac product, but another approach would be to for CodeWeavers to solicit contract work or a bounty for this. Jakub or Lapo might be more able to make time on those terms - but of course I don't know if that's a deal they or CodeWeavers would be interested in making. Another source of volunteers might be the tango-artists ML, but I don't know how many there are there. Finally, I've rebased my patch for the joy.cpl icon. It doesn't have a 256px icon though. Is this wanted? Best Regards Joel Holdsworth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRW/TtAAoJEIsWlGmq62IgaEcIAJYY9q/B3fA2AZQnR5M41qWn Q84e/5jrc1u2w1skmWAkCNdHNHu/R6AURklQ0Hysbnzxp+5GfftPHTKkRzA59cgs jVmkTSiqdVGGeGDRW2YWAcaFiH25xEOqSb9APzMLT4IRVypLbTwWYWhAsaZCa6+0 1USLRakqs5SF7+lCt5VcSHqiko/HPZZsTtNZYDy7cE4DPoNGbajPR9/0fEUfOEj+ b6xyu62tzPHfUcH4hj7YLa7ukJhq2Hh2ELA6gXnjr6yk+pZfx2uMTtfPZ4joWZzw 1DVcyoTkmeCOnasKJU2Obj7vdWgZxWG+WG4KTneH9a+rkSLo6T6Jojae+BXU4O8= =tNa1 -----END PGP SIGNATURE-----

2 1

Re: [PATCH 1/5] wined3d: Make fullscreen windows use HWND_TOPMOST instead of HWND_TOP. (try 3)
by Henri Verbeet April 3, 2013

April 3, 2013

I think this series looks good.

1 0

Fwd: GSoC 2013 Ideas Page
by Austin English April 2, 2013

April 2, 2013

I cleaned this up a couple months ago and removed completed/obsolete projects, but it needs further improvements (mostly new ideas). Please contribute any ideas that you have. Thanks! -Austin ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Tue, Apr 2, 2013 at 1:41 PM Subject: GSoC 2013 Ideas Page To: Carol Smith <carols(a)google.com> Hi there, You're receiving this email because we've reviewed your application for GSoC 2013. We're currently disappointed with the quality of your Ideas Page and would like to give you an opportunity to improve it and your chances of getting into GSoC this year. Please review the FAQs on Ideas Pages<http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc20…> as well as the Mentor Manual section about creating an ideaspage<http://en.flossmanuals.net/GSoCMentoring/making-your-ideas-page/> . You have 24 hours from now to improve your ideas page.We will review it again tomorrow. Please let me know if you have any questions. Cheers, Carol -- -Austin

1 1

Re: d3dx9 [patch1/3, try 2]: Do not use relative error for small numbers
by Matteo Bruni April 2, 2013

April 2, 2013

2013/4/1 Nozomi Kodama <nozomi.kodama(a)yahoo.com> > > Since there are only at most 7 significant digits for a float, we must not be too picky about the expected difference for small numbers > > -#define relative_error(exp, out) ((exp == 0.0f) ? fabs(exp - out) : (fabs(1.0f - (out) / (exp)))) > +#define relative_error(exp, out) (fabs(exp) < 0.01f ? fabs(exp - out) : fabs(1.0f - (out) / (exp))) This doesn't make much sense. Being floating point numbers, they have the same relative precision regardless of the magnitude of the value (as long as you are inside the range of representable values and excluding special values and denormals, but that should be irrelevant to our case here). If using a larger tolerance for the test in patch 2 makes it pass, then I think that's all you have to change. Otherwise you need to figure out why the test result differs so much from the expected value. Slightly unrelated, I think we should use fabsf() instead of fabs() there. We are already using fabsf() in a bunch of places, including d3dx9 tests, so there shouldn't be problems with that.

1 0

Re: uxtheme/tests: Don't test for themed app
by Alexandre Julliard April 2, 2013

April 2, 2013

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -84,18 +84,14 @@ static void test_IsThemed(void) > SetLastError(0xdeadbeef); > bThemeActive = pIsThemeActive(); > trace("Theming is %s\n", (bThemeActive) ? "active" : "inactive"); > + ok( GetLastError() == ERROR_SUCCESS || > + broken(GetLastError() == ERROR_FILE_NOT_FOUND /* Win2k8 */), > + "Expected ERROR_SUCCESS, got 0x%08x\n", > + GetLastError()); Testing last error when there's no failure is not useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

exploring/possibly porting winelib app to support 64bit.
by jordan April 1, 2013

April 1, 2013

Hi list. A friend of mine and myself, have been exploring expanding a (currently, 32bit only) winelib app to support 64bit plugins in wine (64). The app is called FSThost, which is used to host win32 VST instruments and effects (.dll) as a standalone app in Gnu/linux. Webpage: http://sourceforge.net/projects/fsthost/ We currently have a example/test app in the source code, which compile as test64.exe / test.exe.so ... you then use the exeutable 'foo'. ~ in this case 'foo' could be /path/to/your/64bitVSTplugin. Currently, the code fails to load the 64bit dll. We are not sure exactly why it is failing, but suspect a couple of reasons. this is where we at at; 1) LoadLibrary - OK 2) GetProcAddress (get address of VSTPluginMain function from DLL library) - OK 3) Initialize plugin - i.e. call VSTPluginMain function from library - FAIL. Potential reasons: - Vestige mismatch - Wine GetProcAddress on 64 bit platform My friend thought someone more familiar with Wine / WinAPI could take a look on this 64bit DLL and at least confirm that address returned by GetProcAddress is correct. (or give us good tips and/or adive). Since, i am already subbed (to wine-devel), i thought i would see if any one was interested in having a look and/or giving us some pointers, tips, etc. Here's an example (with WINEDEBUG="+relay'), full ouput: http://pastebin.com/5b5srr2a A little snippet: 0042:Call ntdll.RtlEncodePointer(002c4620) ret=18002d9aa 0042:Ret ntdll.RtlEncodePointer() retval=c90b263e5a54eb02 ret=18002d9aa 0042:Ret PE DLL (proc=0x18002f27c,module=0x180000000 L"Automaton.dll",reason=PROCESS_ATTACH,res=(nil)) retval=1 0042:Ret KERNEL32.LoadLibraryA() retval=180000000 ret=7f77bb394167 0042:Call KERNEL32.GetProcAddress(180000000,7f77bb3950b0 "VSTPluginMain") ret=7f77bb394182 0042:Ret KERNEL32.GetProcAddress() retval=180012900 ret=7f77bb394182 Revive plugin: Automaton 0042:Call KERNEL32.UnhandledExceptionFilter(0023e7f0) ret=7f77bbf1fc1a wine: Unhandled page fault on read access to 0x0000022f at address 0x22f (thread 0042), starting debugger... fixme:dbghelp:elf_search_auxv can't find symbol in module fixme:dbghelp:elf_search_auxv can't find symbol in module fixme:dbghelp:elf_search_auxv can't find symbol in module (goto pastebin for the rest / just scroll to bottom of page) If you want to take a look and/or test the code yourself (you need latest code): svn checkout svn://svn.code.sf.net/p/fsthost/code/trunk fsthost-code the source tree is small (like 2 seconds to download). Makefile64 is used to compile the test app (test.c). (just use 'make -f makefile64' from /src dir). alternatively, on sourceforge you can view the test64 app / source code online / here; http://sourceforge.net/p/fsthost/code/154/ (there are several commits following this one, but i believe this one is the most relevant. then to run it (from source dircetory); './test64.exe /path/to/64bitVSTplugin You can get a 'tester' 64bit VST (.dll) to load into test64.exe from here: http://kunz.corrupt.ch/products/tal-elek7ro anyway, any of your insights, help, tips, comments, etc would be both appreciated and helpful. thanks. Jordan

4 8

Re: includes: avoid confusing the preproccesor
by Alexandre Julliard April 1, 2013

April 1, 2013

Austin English <austinenglish(a)gmail.com> writes: > See http://savannah.nongnu.org/bugs/?38557 > > ==== > > In fact, after some investigation, I found out that it's the correct > behavior as '0xfe+1' is considered as a number token by the > preprocessor. I've learned something today :) This has nothing to do with the preprocessor. It's a compiler bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winehtml5.drv: Added new HTML5 driver.
by Ken Thomases April 1, 2013

April 1, 2013

On Apr 1, 2013, at 6:41 AM, Jacek Caban wrote: > There are still some missing features. Most notably, it lacks support > for system tray baloons. I know; that's, like, the hardest thing to do! Great work, though! Actually, since HTML is available everywhere, there's little reason for me to continue with the Mac driver. -Ken

4 3

Re: [PATCH 3/4] d3d9/tests: Verify window style after exiting fullscreen mode. (try 2)
by Henri Verbeet April 1, 2013

April 1, 2013

On 1 April 2013 02:40, Sam Edwards <cfsworks(a)gmail.com> wrote: > I opted not to write ddraw tests. The existing ddraw window style tests > suggest that DirectDraw doesn't even set WS_VISIBLE when initializing a > (non-visible) window, which is very odd, so any new tests would have been > todo_wine anyway. Nonetheless, my changes to wined3d are minimal and > shouldn't affect ddraw's behavior. > I think it's ok for the tests to be todo_wine, but we do want ddraw coverage for this in the tests. > + ZeroMemory( &d3dpp, sizeof(d3dpp) ); > + d3dpp.SwapEffect = D3DSWAPEFFECT_DISCARD; > + d3dpp.Windowed = TRUE; > + d3dpp.BackBufferWidth = screen_width / 2; > + d3dpp.BackBufferHeight = screen_height / 2; > + hr = IDirect3DDevice9_Reset(device, &d3dpp); > + ok(hr == D3D_OK, "IDirect3DDevice9_Reset failed with %08x\n", hr); I think you'll want to use reset_device() here. (Although I also just notice 766e732fb changed that to use screen_width x screen_height instead of 640x480, which is perhaps a bit of an unfortunate choice. It's fine to change reset_device() to use screen_width / 2 x screen_height / 2, if needed.)

2 2

Re: [1/4] windowscodecs: Basic tests for tiff encoder options (try3)
by Ludger Sprenker April 1, 2013

April 1, 2013

Is there anything wrong with my patches? The first one is marked as "Pending". Am Dienstag, 26. März 2013, 18:46:23 schrieb Ludger Sprenker: > Try3: > - Removed last named value initialization > - Do not check initial value of properties, if the > precondition/initial-type is not matching > (both pointed out by Vincent) > > Note: This was priviously a set of 5 patches, but the original part one has > already been committed. > > --- > dlls/windowscodecs/tests/converter.c | 145 > ++++++++++++++++++++++++++++++++++ > 1 file changed, 145 insertions(+)

2 1

Re: dpnet: Increase reported buffer size
by Marvin April 1, 2013

April 1, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24918 Your paranoid android. === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF

1 0

Problem about declarations of strcoll functions
by Jactry Zeng April 1, 2013

April 1, 2013

Hi folks, I tried to implement a lot of strcoll function these days, and I meet some trouble when I added the declaration into include/msvcrt/*.h. With "grep coll *.spec" in dlls/msvcrt/ we can find there was a lot of strcoll function. Some of them was implemented and some of them not: @ cdecl ___lc_collate_cp_func() @ stub __lc_collate @ extern __lc_collate_cp MSVCRT___lc_collate_cp @ cdecl _mbscoll(str str) @ cdecl _mbscoll_l(str str ptr) @ cdecl _mbsicoll(str str) @ cdecl _mbsicoll_l(str str ptr) @ cdecl _mbsnbcoll(str str long) @ cdecl _mbsnbcoll_l(str str long ptr) @ cdecl _mbsnbicoll(str str long) @ cdecl _mbsnbicoll_l(str str long ptr) @ stub _mbsncoll(str str long) # stub _mbsncoll_l(str str long ptr) @ stub _mbsnicoll(str str long) # stub _mbsnicoll_l(str str long ptr) @ cdecl _strcoll_l(str str ptr) MSVCRT_strcoll_l @ cdecl _stricoll(str str) MSVCRT__stricoll @ cdecl _stricoll_l(str str ptr) MSVCRT__stricoll_l @ cdecl _strncoll(str str long) MSVCRT_strncoll_l @ cdecl _strncoll_l(str str long ptr) MSVCRT_strncoll @ cdecl _strnicoll(str str long) MSVCRT__strnicoll @ cdecl _strnicoll_l(str str long ptr) MSVCRT__strnicoll_l # stub _wcscoll_l(wstr wstr ptr) @ cdecl _wcsicoll(wstr wstr) MSVCRT__wcsicoll # stub _wcsicoll_l(wstr wstr ptr) @ cdecl _wcsncoll(wstr wstr long) MSVCRT__wcsncoll @ cdecl _wcsncoll_l(wstr wstr long ptr) MSVCRT__wcsncoll_l @ cdecl _wcsnicoll(wstr wstr long) MSVCRT__wcsnicoll # stub _wcsnicoll_l(wstr wstr long ptr) @ cdecl strcoll(str str) MSVCRT_strcoll @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll With "grep coll *.h" in include/msvcrt/ we can find some declarations of some strcoll function: crtdefs.h: unsigned int lc_collate_cp; mbstring.h:int __cdecl _mbscoll(const unsigned char*,const unsigned char*); mbstring.h:int __cdecl _mbsicoll(const unsigned char*,const unsigned char*); mbstring.h:int __cdecl _mbsnbcoll(const unsigned char*,const unsigned char*,size_t); mbstring.h:int __cdecl _mbsnbicoll(const unsigned char*,const unsigned char*,size_t); mbstring.h:int __cdecl _mbsncoll(const unsigned char*,const unsigned char*,size_t); mbstring.h:int __cdecl _mbsnicoll(const unsigned char*,const unsigned char*,size_t); string.h:int __cdecl _stricoll(const char*,const char*); string.h:int __cdecl strcoll(const char*,const char*); string.h:int __cdecl _wcsicoll(const wchar_t*,const wchar_t*); string.h:int __cdecl _wcsnicoll(const wchar_t*,const wchar_t*,size_t); string.h:int __cdecl wcscoll(const wchar_t*,const wchar_t*); string.h:static inline int stricoll(const char* s1, const char* s2) { return _stricoll(s1, s2); } string.h:static inline int wcsicoll(const wchar_t* str1, const wchar_t* str2) { return _wcsicoll(str1, str2); } wchar.h:int __cdecl _wcsicoll(const wchar_t*,const wchar_t*); wchar.h:int __cdecl _wcsnicoll(const wchar_t*,const wchar_t*,size_t); wchar.h:int __cdecl wcscoll(const wchar_t*,const wchar_t*); As we can see, _strcoll_l and _mbsnbcoll_l were implemented but they were not declared. Should we declare all of them? And whether the sequence was important? Thank you. -- Regards, Jactry Zeng

2 2

Re: mshtml: Fixed builtin getter call with arguments.
by Marvin April 1, 2013

April 1, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24910 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH] wined3d: Add a registry key to configure buffer object placement
by Henri Verbeet April 1, 2013

April 1, 2013

On 1 April 2013 10:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (wined3d_settings.placebo == PLACEBO_VIDMEM) > + { > + TRACE("Placing buffer %p in video memory\n", This); > + glHint(This->buffer_type_hint, GL_FASTEST); > + } > + I'm going to go out on a limb and call April fools on this. The state of GL drivers being what it is though, there's a slight chance such a thing actually exists, in which case please link to the documentation instead. Somewhat related, I do actually have a patch to change the usage hint for static vertex buffers to GL_STATIC_DRAW_ARB in my tree, which should actually make the driver more likely to initially place those in VRAM instead of GTT. (It mostly just helps with initial fps after a VB is just created, most drivers eventually figure out the optimal placement anyway and migrate the buffer to vram.)

1 0