April 2013 - Wine-Devel - list.winehq.org

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo
by Marvin April 24, 2013

April 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25251 Your paranoid android. === W2KPROSP4 (32 bit psapi_main) === psapi_main.c:76: Test failed: GetProcAddress(GetPerformanceInfo) failed

1 0

Application for GSoC 2013 - improve Richedit
by Jactry Zeng April 23, 2013

April 23, 2013

Hi folks, I am Jactry Zeng, a sophomore majoring in Electronic Science from China. My nickname in #winehackers is Jactry. I would like to apply for this year's GSoC to work for wine. I have reported some bugs[1] of wine and submitted a few easy patches[2] for wine. And I feel quite good to study in wine community. I am so interested in Richedit module[3]. Because a lot of software I tested was blocked by bugs of Richedit, such as wordpad, GTalk, QQ, Weibo Desktop and AliWangwang etc. I would like to work for this module during GSoC. I've reported a few bugs regarding Richedit[4]. And for bug 33191[5], I have written a simple testcase to reproduce this bug. And I found ITextDocument is just a stub now, I want to implement some function of it, such as ITextDocument::New, ITextDocument::Open, ITextDocument::Save, ITextDocument::Range, ITextDocument ::GetName and ITextDocument::GetDefaultTabStop etc. These functions are documented in MSDN[6], what's better, thanks to kind people on codeproject[7], there are some sample applications for study, which will give me a lot of help on re-implementing ITextDocument. I think if I can finish this work, there are a lot of software will benefit from it[8]. I appreciate for any comment. Thank you. :-) [1] http://bugs.winehq.org/buglist.cgi?email1=jactry92%40gmail.com&emailtype1=e… [2]http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=Jactry [3] http://bugs.winehq.org/buglist.cgi?cmdtype=runnamed&namedcmd=richedit&list_… [4]bug of Richedit I reported: http://bugs.winehq.org/buglist.cgi?emailreporter1=1&emailtype1=exact&query_… [5]bug 33191: http://bugs.winehq.org/show_bug.cgi?id=33191 [6]http://social.msdn.microsoft.com/Search/en-US?query=ITextDocument&ac=4 [7]http://www.codeproject.com/search.aspx?q=ITextDocument&x=0&y=0&sbo=kw [8]bug of ITextDocument: http://bugs.winehq.org/buglist.cgi?quicksearch=ITextDocument&list_id=104255 -- Regards, Jactry Zeng

2 2

Re: [PATCH 3/3] mshtml: Support IObjectIdentity interface in HTMLWindow object
by Marvin April 23, 2013

April 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25244 Your paranoid android. === WXPPROSP2 (32 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 dom: unhandled exception c0000005 at 00421C52 === WXPX64 (32 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 dom: unhandled exception c0000005 at 00421C52 === WXPX64 (64 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 Timeout

1 0

Re: [PATCH 2/3] mshtml: Added IOmHistory::get_length test
by Marvin April 23, 2013

April 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25243 Your paranoid android. === WXPX64 (32 bit htmldoc) === htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call

1 0

Re: oledb32: Implement GetConversionSize DBTYPE_STR->DBTYPE_WSTR
by Marvin April 23, 2013

April 23, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25234 Your paranoid android. === W2KPROSP4 (32 bit convert) === convert.c:2537: Test failed: 12

1 0

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.
by Ken Thomases April 23, 2013

April 23, 2013

On Apr 22, 2013, at 6:40 PM, Sam Edwards wrote: > On 04/19/2013 10:32 AM, Max TenEyck Woodbury wrote: >> As I understand it, some fonts deliberately have glyphs larger than >> their metrics bounding boxes. Clipping them is almost certainly not a >> good idea. > > Forgive my disbelief, but can you provide an example? It seems like Windows has the same clipping behavior (see my test http://source.winehq.org/patches/data/95792) > > From my understanding, the intent of the ascent metric is that it indicates the maximum ascender on any glyph in the font (and likewise for descent), so the only real reason for the ascent/descent metrics to be wrong is if the font designer made a mistake. (And some tools, like FontForge, will automatically set the ascent/descent metrics correctly for you on export.) > > I can't think of any reason why a font author would want to create a font with an invalid ascent/descent metric. I can't speak to how Windows would render it, but one such font is Zapfino. It's an "exuberant" calligraphic font with lots of flourishes, some of which have strokes extending into the line above or below. http://en.wikipedia.org/wiki/Zapfino https://www.google.com/images?q=zapfino -Ken

2 3

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory. (try 2)
by Rico Schüller April 23, 2013

April 23, 2013

On 22.04.2013 23:08, Christian Costa wrote: > +typedef struct { > + DWORD bc2Size; > + DWORD bc2Width; > + DWORD bc2Height; > + WORD bc2Planes; > + WORD bc2BitCount; > + DWORD bc2Compression; > + DWORD bc2SizeImage; > + DWORD bc2XRes; > + DWORD bc2YRes; > + DWORD bc2ClrUsed; > + DWORD bc2ClrImportant; > + /* same as BITMAPINFOHEADER until this point */ > + WORD bc2ResUnit; > + WORD bc2Reserved; > + WORD bc2Orientation; > + WORD bc2Halftoning; > + DWORD bc2HalftoneSize1; > + DWORD bc2HalftoneSize2; > + DWORD bc2ColorSpace; > + DWORD bc2AppData; > +} BITMAPCOREHEADER2; Do we really need a typedef here? For only locally used structs, I think we shouldn't use a typedef. Also the struct is only used to determine the size and for nothing else? There may be a better way to do that... Maybe something like in dlls/windowscodecs/icoformat.c ? I think you got inspired by dlls/windowscodecs/bmpdecode.c, there is the same issue. Why do we need a typedef, if we only use it in one file to calculate the size? > > + BITMAPFILEHEADER *header; > > + if ((header_size == sizeof(BITMAPINFOHEADER)) || > + (header_size == sizeof(BITMAPV4HEADER)) || > + (header_size == sizeof(BITMAPV5HEADER)) || > + (header_size == sizeof(BITMAPCOREHEADER2))) > + { > + /* All structures have the same memory layout as BITMAPINFOHEADER */ > + BITMAPINFOHEADER*header = (BITMAPINFOHEADER*)*data; > + ULONG count = header->biClrUsed; > > + else if (header_size == sizeof(BITMAPCOREHEADER)) > + { > + BITMAPCOREHEADER*header = (BITMAPCOREHEADER*)*data; I don't think it's a good idea to use variable names multiple times. While this works fine it may be a bit confusing... Cheers Rico

2 1

d3dx9: Implement D3DXSHMultilpy5
by Nozomi Kodama April 23, 2013

April 23, 2013

Is there a problem with this patch? http://source.winehq.org/patches/data/95555 Nozomi

4 8

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.
by Dmitry Timoshkov April 23, 2013

April 23, 2013

Sam Edwards <cfsworks(a)gmail.com> wrote: > This change only affects malformed fonts that have glyphs with splines > that go above the maximum ascent as specified in the font's hhea/os2 > table. For that reason, any tests for this change would have to include > a malformed font, so I did not write tests. If we want in-tree tests, > we'll need to figure out how to include a malformed font to test against. Please add a test case, Wine test suite already includes custom fonts, you can either use an existing font, or add a new one. -- Dmitry.

3 2

kernel32/path: Potential off-by-one error, help needed!
by Kirill Smirnov April 23, 2013

April 23, 2013

Hi! While debugging bug #33307 (http://bugs.winehq.org/show_bug.cgi?id=33307) I found a suspicious piece of code, looking like off-by-one error. Unfortunately, I'm not familiar with this part of wine and I don't know how to write corresponding test case. If you familiar with this module, please, take a look at this wanna-be-a-bug and the proposed patch. -- Kirill

2 1