May 2013 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

Re: Raise the minimum version of FreeBSD to 8.0.
by Frédéric Delanoy Oct. 27, 2013

Oct. 27, 2013

On Sun, Mar 3, 2013 at 12:22 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > We've had this as a requirement in the FreeBSD ports for quite a > while (and the Wiki describes some background). > > Gerald > --- > - FreeBSD 7.0 or later > + FreeBSD 8.0 or later > ... > FreeBSD info: > - Wine will generally not work properly on versions before FreeBSD 7.0. > + Wine will generally not work properly on versions before FreeBSD 8.0. You should also change the version in the various README.xx translations (in 'documentation' directory). Frédéric

3 2

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

winemac.drv: add fullscreen mode support for Mac OS X 10.7+
by Kevin Eaves Oct. 8, 2013

Oct. 8, 2013

Attached patch is a proof-of-concept for the fullscreen APIs provided in OS X 10.7+, which allows applications to enter fullscreen in a separate desktop space. The fullscreen button appears if a main window is resizable. Basically this feature is the zoom button on crack. It doesn't actually go fullscreen 'natively' but simply resizes the window fullscreen, and automatically moves it to its own space. As far as Wine is concerned the window resized — just like clicking the zoom button and manually assigning the window to its own space. I doubled the MaxTrackSize in user32/winpos.c, but it only needs +15 for the height.

2 2

Re: Web based translation tool
by Michal Čihař June 18, 2013

June 18, 2013

Hi Dne Mon, 12 Mar 2012 12:02:49 +0200 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > The Wine project is thinking about using Weblate in order to translate > Wine, you can look at the following discussion and see for yourself. That sounds great! > Looking good although a litle immature, not sure about authentication as > wel... For authentication you can basically use anything what can be used in Django. Any specific concerns on this topic? > I'll talk to Michal Cihar and ask him for a roadmap for this project. Well I don't have any real roadmap right now. I urgently needed replacement for Pootle because we got hit by too many bugs there and did not manage to understand the code there to be able to fix them myself. So far I think it is in pretty good shape for day to day work (with today's 0.5 release fixing few annoying bugs). Of course there are some features missing, you can check what I plan for 1.0 release here: https://github.com/nijel/weblate/issues?state=open&milestone=1 I currently hope to have 1.0 in a month or so, but I really don't want to commit to any specific date. PS: I'm not subscribed to mailing list so please CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

7 16

[PATCH v6 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky June 11, 2013

June 11, 2013

Main changes from v5: 1) O_DENYDELETE is now supported by VFS. 2) ESHAREDENIED erro code is introduced to be returned on sharelock conflicts. 3) forcemand dependancy is removed. CIFS module detects if it should use NTCreateAndX command according to existence of O_DENY flags. 4) Term 'deny lock' is replaced by 'sharelock' (function names, code comments, patch descriptions). Main changes from v4: 1) deny_lock_file uses FS_DOES_SHARELOCK flag from fs_flags to determine whether to use VFS locks or not. 2) Make nfs code return -EBUSY for share conflicts (was -EACCESS). Main changes from v3 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), The patchset avoid data races problem on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a sharelock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This lets us not mix one share reservation approach with another. The #1 patch adds flags to fcntl and implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -ESHAREDENIED in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ESHAREDENIED untill this open is closed. Now this flag is processed by VFS and CIFS filesystem. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND 3) !O_DENYDELETE -> LOCK_DELETE | LOCK_MAND ----- Pavel Shilovsky (7): VFS: Introduce new O_DENY* open flags VFS: Add O_DENYDELETE support for VFS CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts fs/cifs/cifsacl.c | 8 +- fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 ++++- fs/cifs/cifsproto.h | 8 +- fs/cifs/cifssmb.c | 50 +++++++------ fs/cifs/dir.c | 16 ++-- fs/cifs/file.c | 25 +++++-- fs/cifs/inode.c | 21 +++--- fs/cifs/link.c | 25 ++----- fs/cifs/netmisc.c | 2 +- fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 ++-- fs/cifs/smb2file.c | 10 +-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 10 ++- fs/cifs/smb2pdu.c | 6 +- fs/cifs/smb2proto.h | 14 ++-- fs/fcntl.c | 5 +- fs/locks.c | 158 ++++++++++++++++++++++++++++++++++++--- fs/namei.c | 48 +++++++++++- fs/nfs/dir.c | 4 + fs/nfs/internal.h | 3 +- fs/nfs/nfs4file.c | 4 + fs/nfs/nfs4proc.c | 4 +- fs/nfs/nfs4super.c | 9 ++- fs/nfs/nfs4xdr.c | 21 +++++- fs/nfs/super.c | 7 +- fs/nfsd/nfs4state.c | 46 +++++++++++- fs/nfsd/nfsproc.c | 1 + fs/proc_namespace.c | 1 + include/linux/fs.h | 14 ++++ include/uapi/asm-generic/errno.h | 2 + include/uapi/asm-generic/fcntl.h | 12 +++ include/uapi/linux/fs.h | 1 + 35 files changed, 443 insertions(+), 139 deletions(-) -- 1.8.1.5

4 13

Re: ole32: Add a basic OLE client/server test suite. Take 2.
by Dmitry Timoshkov June 5, 2013

June 5, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > With minor clean ups and with increased timeout to wait for server termination > to please some really slow VMs (that allowed to remove broken() statements). It would be helpful to provide some feedback and explain the 'pending' state of the patch which adds a test. -- Dmitry.

2 7

Re: [1/2] DWrite: Implemented functions regarding text alignment. (try 3)
by Nikolay Sivov May 31, 2013

May 31, 2013

On Fri, May 31, 2013 at 9:07 PM, Fabian Müntefering <Cookiezzz97(a)gmx.de>wrote: > Implemented functions of text format and text layout regarding text > alignment. > > Try 3: Used proper enum value to set the enum variables. > > > > > + if(alignment!=DWRITE_TEXT_ALIGNMENT_CENTER && alignment!=DWRITE_TEXT_ALIGNMENT_LEADING && + alignment!=DWRITE_TEXT_ALIGNMENT_JUSTIFIED && alignment!=DWRITE_TEXT_ALIGNMENT_TRAILING) + return E_INVALIDARG; + This->format.text_align = alignment; This doesn't look great, you'll need a test that shows it really rejects meaningless values, and if it does it would be simpler to compare with greatest enum value.

1 0

Re: [PATCH] slc: Fix return type
by Christian Costa May 31, 2013

May 31, 2013

Le 29/05/2013 12:06, Detlef Riekenberg a écrit : > -- > By by ... Detlef > --- > dlls/slc/slc.c | 31 +++++++++++++++++++++++-------- > include/slpublic.h | 2 +- > 2 files changed, 24 insertions(+), 9 deletions(-) > > diff --git a/dlls/slc/slc.c b/dlls/slc/slc.c > index e7416f1..7fc9b93 100644 > --- a/dlls/slc/slc.c > +++ b/dlls/slc/slc.c > @@ -1,6 +1,7 @@ > /* > * > * Copyright 2008 Alistair Leslie-Hughes > + * Copyright 2010 Detlef Riekenberg > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -28,15 +29,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(slc); > > -DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue) > -{ > - FIXME("(%s) stub\n", debugstr_w(lpszValueName) ); > - > - return SL_E_RIGHT_NOT_GRANTED; > -} > - > /*********************************************************************** > - * DllMain (CLUSAPI.@) > + * DllMain (slc.@) > * > */ > BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > @@ -51,3 +45,24 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > } > return TRUE; > } > + > +/*********************************************************************** > + * SLGetWindowsInformationDWORD (slc.@) > + * > + * check the license and return the value for the given name > + * > + * PARAMS > + * name [i] application related value name to check > + * pvalue [o] ptr, where the value for the given name should be saved > + * > + * RETURNS > + * Success: S_OK > + * Failure: A HRESULT error code > + * > + */ > +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD *pvalue) > +{ > + FIXME("(%s, %p) stub\n", debugstr_w(name), pvalue); > + > + return SL_E_RIGHT_NOT_GRANTED; > +} > diff --git a/include/slpublic.h b/include/slpublic.h > index a2c6d42..5553787 100644 > --- a/include/slpublic.h > +++ b/include/slpublic.h > @@ -29,7 +29,7 @@ extern "C" { > #define SLCAPI DECLSPEC_IMPORT > #endif > > -SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue); > +SLCAPI HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR, DWORD *); > > > #ifdef __cplusplus I think s/PCWSTR/const WCHAR */ and s/pvalue/value/ would be better. :)

2 2

Re: [PATCH] winmm/tests: Fix test that fails on NT4
by Marvin May 31, 2013

May 31, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25788 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [1/2] explorer: Initial implementation of desktop launchers.
by Qian Hong May 31, 2013

May 31, 2013

Hello Hans, On Tue, May 28, 2013 at 6:42 PM, Hans Leidekker <hans(a)codeweavers.com> wrote: > + hr = SHGetKnownFolderPath( &FOLDERID_Desktop, 0, NULL, &desktop_folder ); > + if (FAILED( hr )) > + { > + WINE_ERR("Could not get user desktop folder\n"); > + return; > + } > + hr = SHGetKnownFolderPath( &FOLDERID_PublicDesktop, 0, NULL, &desktop_folder_public ); > + if (FAILED( hr )) > + { > + WINE_ERR("Could not get public desktop folder\n"); > + CoTaskMemFree( desktop_folder ); > + return; > + } Does KF_FLAG_CREATE look better here? Other wise every time a new wineprefix created there is an err output. Maybe I'm missing something here, thanks for your work. -- Regards, Qian Hong - http://www.winehq.org

2 1

Re: [PATCH 2/4] d3dxof: Move list type and list nb elements into the parse context.
by Alexandre Julliard May 30, 2013

May 30, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/d3dxof/d3dxof_private.h | 2 ++ > dlls/d3dxof/parsing.c | 23 ++++++++++------------- > 2 files changed, 12 insertions(+), 13 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so mesh.c && touch mesh.ok mesh.c:2291: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2299: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2323: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2347: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2399: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2403: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2407: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2408: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2409: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2495: Tests skipped: D3DXCreateBox failed make: *** [mesh.ok] Error 9 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] advpack: Handle quoted arguments to rundll exports.
by Alexandre Julliard May 30, 2013

May 30, 2013

Vincent Povirk <madewokherd(a)gmail.com> writes: > @@ -205,13 +205,24 @@ static HRESULT run_setup_commands_callback(HINF hinf, PCWSTR field, const void * > > /* sequentially returns pointers to parameters in a parameter list > * returns NULL if the parameter is empty, e.g. one,,three */ > -LPWSTR get_parameter(LPWSTR *params, WCHAR separator) > +LPWSTR get_parameter(LPWSTR *params, WCHAR separator, int quoted) Using proper boolean type and constants would be preferable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] DWrite: Implemented functions regarding text alignment. (try 2)
by Alexandre Julliard May 30, 2013

May 30, 2013

Fabian Müntefering <Cookiezzz97(a)gmx.de> writes: > @@ -1023,6 +1034,9 @@ HRESULT create_textformat(const WCHAR *family_name, IDWriteFontCollection *colle > This->format.size = size; > This->format.stretch = stretch; > > + /*Default values.*/ > + This->format.text_align = 0; Please use proper enum values when setting enum variables. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [4/4] kernel32: Don't move fixed memory area in GlobalReAlloc. (try 3)
by Marvin May 30, 2013

May 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25774 Your paranoid android. === WVISTAX64 (64 bit heap) === No test summary line found === W7PROX64 (64 bit heap) === No test summary line found === TEST64_W7SP1 (64 bit heap) === No test summary line found

1 0

Re: [1/4] kernel32: Add more GlobalReAlloc/LocalReAlloc tests.
by Marvin May 30, 2013

May 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25773 Your paranoid android. === WVISTAX64 (64 bit heap) === No test summary line found === W7PROX64 (64 bit heap) === No test summary line found === TEST64_W7SP1 (64 bit heap) === No test summary line found

1 0

Re: msvcrt: remove hack
by Henri Verbeet May 30, 2013

May 30, 2013

On 30 May 2013 07:23, Austin English <austinenglish(a)gmail.com> wrote: > and no modern gcc/other compiler that I can find cares. > It does if you add -Wunused-parameter, but then you'll get a lot of other warnings as well. IMO the "action = action;" line is pretty pointless and best just removed, though if people are just looking for a different workaround, "(void)action;" is more or less the standard way to do it.

1 0

Re: msvcrt: remove hack
by Marcus Meissner May 30, 2013

May 30, 2013

On Wed, May 29, 2013 at 10:23:29PM -0700, Austin English wrote: > This was added 12 years ago in 1db20bfd33f9c1486a1a662c2f78f45d00caf24b > > but clang doesn't like it: > clang -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ > -D_MT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing > -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers > -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith > -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O2 -o process.o > process.c > process.c:363:10: warning: explicitly assigning a variable of type > 'int' to itself [-Wself-assign] > action = action; /* Remove warning */ > ~~~~~~ ^ ~~~~~~ > 1 warning generated. > > and no modern gcc/other compiler that I can find cares. It was probably added because of a tool that warned of the unused parameter ... So it all goes in circles. ;) Ciao, Marcus

4 6

Re: dinput: Update existing joystick values after setting the range property
by Austin English May 30, 2013

May 30, 2013

On Sun, Apr 14, 2013 at 2:25 PM, Bassi, Gurmail <Gurmail.Bassi(a)mottmac.com> wrote: > ePSXe polls the joystick immediately after setting the axis range property, and uses the returned values as its 'centered' calibrated values - therefore the existing joystick state values must be remapped to the new range (or else the joystick may not have the full range of motion) > > > This patch has been tested on Ubuntu 12.04.1 LTS x86-64, and the behaviour confirmed to match Microsoft's DirectInput implementation on Windows XP 32-bit (Microsoft's DirectInput seems to update the existing joystick values to the new range prior to polling even if the joystick hasn't been moved) > > > --- > dlls/dinput/joystick.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) Hi Gurmail, This appears to have caused a regression, see http://bugs.winehq.org/show_bug.cgi?id=33496 (normally I'd cc you on the bug, but you don't seem to have a bugzilla account). -- -Austin

1 0

Re: (try 2)macdrv: rework the way we handle cursor position and composition text
by Ken Thomases May 29, 2013

May 29, 2013

On May 29, 2013, at 1:11 PM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 +---- > dlls/winemac.drv/event.c | 5 --- > dlls/winemac.drv/ime.c | 85 +++++++++++++---------------------------- > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h | 6 +-- > 5 files changed, 29 insertions(+), 77 deletions(-) > > > <0014-macdrv-rework-the-way-we-handle-cursor-position-and-co.txt> Looks good to me. -Ken

1 0

Re: macdrv: rework the way we handle cursor position and composition text
by Ken Thomases May 29, 2013

May 29, 2013

On May 29, 2013, at 10:37 AM, Aric Stewart wrote: > --- > dlls/winemac.drv/cocoa_window.m | 9 +---- > dlls/winemac.drv/event.c | 3 -- > dlls/winemac.drv/ime.c | 85 +++++++++++++---------------------------- > dlls/winemac.drv/macdrv.h | 1 - > dlls/winemac.drv/macdrv_cocoa.h | 5 +-- > 5 files changed, 29 insertions(+), 74 deletions(-) I know I reviewed this several times, but I failed to notice until now: you didn't remove the definition of IM_SET_CURSOR_POS in the enum and the entry in the table in dbgstr_event(). -Ken

2 1

GSoC 2013 has begun!
by Austin English May 29, 2013

May 29, 2013

Howdy, Wine has accepted 4 student proposals for Google Summer of Code 2013: George Stephanos, "Registry - implement merging between HKCR and HKCU\Software\Classes" mentored by Detlef Riekenberg Jactry Zeng, "Implement ITextDocument in Richedit" mentored by Huw Davies John Chadwick, "MSXML - Implement XPATH without libxml2" mentored by Nikolay Sivov Zhan Jianyu, "Improve and add missing feature of vbscript component" mentored by Jacek Caban Welcome to Wine and good luck on your projects! As a reminder, here are the next few big dates: May 27th - June 17: community bonding period. Students/mentors should use this time to iron out details of the project, learn the code base and get to know others on the project. June 17: coding officially begins July 29th - Aug 2nd: mid-term reviews are submitted. Mentors/students, please feel free to contact me or André Hentschel if you have any GSoC administrative/procedural questions. Otherwise use wine-devel or ask your mentor for help with learning the Wine development process/codebase/etc. -- -Austin

1 1

Re: [1/3] DWrite: Added missing JUSTIFIED text alignment mode.
by Nikolay Sivov May 29, 2013

May 29, 2013

Hi, Fabian. You forgot to attach patches 2 and 3.

1 0

re: [PATCH (try 2)] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode
by Maarten Lankhorst May 29, 2013

May 29, 2013

NAK. + HeapFree(GetProcessHeap(), 0, device->primary_pwfx); + device->primary_pwfx = DSOUND_CopyFormat(passed_fmt); Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning primary_pwfx to NULL? ~Maarten

2 1

Re: Christian Costa : d3dx9_36: Implement skin mesh loading.
by gurketsky May 29, 2013

May 29, 2013

Hi, just saw that a bit late. Is there a reason for the rewrite of hr? Could any call return anything other than D3D_OK and succeed (maybe S_FALSE)? It may be possible to drop "if (FAILED(hr)) goto end;" (for both cases) and "hr = D3D_OK"... Also the function (parse_mesh) seems to overwrite the result anyway to D3D_OK on success, so I see no reason to change the hr to D3D_OK in parse_skin_mesh_info. Cheers Rico On 28.05.2013 22:16, Alexandre Julliard wrote: > + if (SUCCEEDED(hr)) > + hr = mesh_data->skin_info->lpVtbl->SetBoneOffsetMatrix(mesh_data->skin_info, index, > + (const D3DMATRIX*)(data + nb_influences * (sizeof(DWORD) + sizeof(FLOAT)))); > + if (FAILED(hr)) > + goto end; > + } > + > + hr = D3D_OK;

2 1

Re: Increment, Decrement, and Assignment Operators
by Alexandre Julliard May 29, 2013

May 29, 2013

Stephen Leibowitz <librestephen(a)gmail.com> writes: > Hello: > > This is my first patch. The changes are minor. If it works out, I may > attempt something more substantial. Doing cosmetic changes like this across the code base is not a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] gdi32: Ask for a newer FreeType version
by Alexandre Julliard May 29, 2013

May 29, 2013

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -3686,7 +3686,8 @@ static BOOL init_freetype(void) > WINE_MESSAGE( > "Wine cannot find the FreeType font library. To enable Wine to\n" > "use TrueType fonts please install a version of FreeType greater than\n" > - "or equal to 2.0.5.\n" > + "or equal to 2.1.4.\n" > + "(Fonts with vertical metrics need at least version 2.4 of FreeType)\n" > "http://www.freetype.org\n"); > return FALSE; > } > @@ -3749,6 +3750,7 @@ sym_not_found: > "Wine cannot find certain functions that it needs inside the FreeType\n" > "font library. To enable Wine to use TrueType fonts please upgrade\n" > "FreeType to at least version 2.1.4.\n" > + "(Fonts with vertical metrics need at least version 2.4 of FreeType)\n" That's not useful. There are probably very few users who still have such an old Freetype, and even if they do, telling them about vertical metrics will only confuse them. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Increment, Decrement, and Assignment Operators
by Dan Kegel May 29, 2013

May 29, 2013

Watch http://source.winehq.org/patches/ for your patch's status (see legend at bottom). It might be rejected since it doesn't actually fix any behavioral problem in Wine. IIRC trivial cleanups in code are frowned upon, especially if they cross many modules. Better to pick some small real problem and fix it. How about http://bugs.winehq.org/show_bug.cgi?id=32922 ?

1 0

Re: gdi32/tests: Do not try to test OS/2 win metrics on non-windows fonts
by Dmitry Timoshkov May 29, 2013

May 29, 2013

Aric Stewart <aric(a)codeweavers.com> wrote: > + ascent = GET_BE_WORD(tt_os2.usWinAscent); > + descent = GET_BE_WORD(tt_os2.usWinDescent); > + cell_height = ascent + descent; > + ok(ntm->ntmCellHeight == cell_height, "%s: ntmCellHeight %u != %u, os2.usWinAscent/os2.usWinDescent %u/%u\n", > + font_name, ntm->ntmCellHeight, cell_height, ascent, descent); > + > + SetLastError(0xdeadbeef); The SetLastError() call should be left at its previous position. -- Dmitry.

1 0

Re: [PATCH] winhttp: initialize schemes (Coverity) (resubmit)
by Hans Leidekker May 28, 2013

May 28, 2013

On Tue, 2013-05-28 at 22:46 +0200, Marcus Meissner wrote: > 1020943 Uninitialized scalar variable > > schemes is |= in the called function, but not > initialized before. > > Was submitted 2 weeks ago already, I think it is good. It's good but query_auth_schemes is called from more places, so it would be better to fix it in that helper, without touching the parameter on error.

1 0

Re: [PATCH] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode
by Marvin May 28, 2013

May 28, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25741 Your paranoid android. === WXPPROSP2 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === WXPX64 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === W2K3R2SESP2 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === WXPX64 (64 bit dsound) === dsound.c:1433: Test failed: validbits: 0

1 0

Re: [5/5] kernel32: Don't move fixed memory area in GlobalReAlloc. (try 2)
by Alexandre Julliard May 28, 2013

May 28, 2013

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > This closes bug 14819. > > try 2: > * tests/heap.c was updated to avoid dependency on heap reallocation > strategies. > * Use HeapAlloc instead of LocalAlloc in some places. In those cases, > they want large memory blocks, not pinned memory addresses. They are using LMEM_MOVEABLE though. A few more tests for this flag would probably be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

dxgi, directx 11 and code duplication
by John Yani May 28, 2013

May 28, 2013

Hi. I'm trying to set up a minimal implementation that will allow to run Assasin's Creed III. It uses these 2 functions: dxgi.dll.CreateDXGIFactory1 d3d11.dll.D3D11CreateDevice See http://bugs.winehq.org/show_bug.cgi?id=24517 I need an advice on how to implement CreateDXGIFactory1 without duplicating a lot of code. There are problems with a straight-forward implementation: interface IWineDXGIFactory : IDXGIFactory { struct wined3d *get_wined3d(); } interface IWineDXGIFactory1 : IDXGIFactory1 { struct wined3d *get_wined3d(); } The problem is how to reuse functions where IWineDXGIFactory is used. Obviously we can't pass IWineDXGIFactory1 object where IWineDXGIFactory is required. Because the next time we call get_wined3d, a crash will occur (a different function will be called). Is there a more elegant solution than duplicating code and replacing all occurencdes of IWineDXGIFactory by IWineDXGIFactory1? Btw, D3D11CreateDevice accepts both IDXGIFactory and IDXGIFactory1: http://msdn.microsoft.com/en-us/library/windows/desktop/ff476082(v=vs.85).a…

2 1

dxgi, directx 11 and code duplication
by John Yani May 27, 2013

May 27, 2013

Hi. I'm trying to set up a minimal implementation that will allow to run Assasin's Creed III. It uses these 2 functions: dxgi.dll.CreateDXGIFactory1 d3d11.dll.D3D11CreateDevice See http://bugs.winehq.org/show_bug.cgi?id=24517 I need an advice on how to implement CreateDXGIFactory1 without duplicating a lot of code. There are problems with a straight-forward implementation: interface IWineDXGIFactory : IDXGIFactory { struct wined3d *get_wined3d(); } interface IWineDXGIFactory1 : IDXGIFactory1 { struct wined3d *get_wined3d(); } The problem is how to reuse functions where IWineDXGIFactory is used. Obviously we can't pass IWineDXGIFactory1 object where IWineDXGIFactory is required. Because the next time we call get_wined3d, a crash will occur (a different function will be called). Is there a more elegant solution than duplicating code and replacing all occurencdes of IWineDXGIFactory by IWineDXGIFactory1? Btw, D3D11CreateDevice accepts both IDXGIFactory and IDXGIFactory1: http://msdn.microsoft.com/en-us/library/windows/desktop/ff476082(v=vs.85).a…

1 0

Release plans
by Alexandre Julliard May 27, 2013

May 27, 2013

Folks, Now that the Mac driver is fully merged and all the bugs fixed (right?), it's time to think about the next stable release. I would like to start the code freeze after the next release cycle, so two weeks from now. Hopefully, like last time we can keep the freeze period relatively short, so that it won't impact the Summer of Code projects too much. Note that in general, new test cases can be accepted during code freeze, and it's always a good idea to start a GSoC project by writing tests. On a related note, the test results on test.winehq.org haven't been looking very good lately; in particular, we need to make the full test suite succeed on the new testbot VMs, since the old ones are being phased out. Fixes to make tests succeed on Windows can go in during code freeze, since by definition they don't impact the Wine code, so this would be a good opportunity to try to improve the situation. OTOH the regression status is looking good, I'm very pleased with how we've kept the regression count under control during the 1.5 series. Hopefully we can even fix a few more during code freeze and set a lower baseline for the next development series. Thanks all for your help, and let's make this another great release! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winmm: load winealsa if winepulse is found
by cfsworks＠gmail.com May 27, 2013

May 27, 2013

Wouldn't this cause applications which use winmm for waveout to be diverted to ALSA as well? Maybe both drivers should be loaded side by side, with winepulse handling everything but MIDI.

1 0

Re: [PATCH v23] winepulse: add pulseaudio driver
by Marvin May 27, 2013

May 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25724 Your paranoid android. === WVISTAX64 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 00000000 === W2K8SE (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 00000000 === W7PROX64 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 00000000 === TEST64_W7SP1 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 00000000 === WVISTAX64 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 0000000000000000 === W7PROX64 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 0000000000000000 === TEST64_W7SP1 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 0000000000000000

1 0

Making SetThreadPriorityBoost claim success
by Dan Kegel May 27, 2013

May 27, 2013

http://bugs.winehq.org/show_bug.cgi?id=22280 just got another dup. How awful would it be to make SetThreadPriorityBoost just return success, as in the patch attached to http://bugs.winehq.org/show_bug.cgi?id=22280#c1 http://bugs.winehq.org/attachment.cgi?id=27224&action=diff&context=patch&co… ? We'd have to mark one more test TODO_WINE. Related if catty discussion: http://www.codinghorror.com/blog/2006/08/thread-priorities-are-evil.html

2 1

Re: [PATCH 4/5] d3drm: Avoid LPDIRECT3DRMTEXTURE.
by Christian Costa May 27, 2013

May 27, 2013

Le 27/05/2013 09:22, Henri Verbeet a écrit : > --- > dlls/d3drm/d3drm.c | 20 ++++++++------------ > dlls/d3drm/frame.c | 22 +++++++--------------- > dlls/d3drm/meshbuilder.c | 14 +++++++------- > dlls/d3drm/tests/d3drm.c | 16 ++++++++-------- > include/d3drm.h | 4 ++-- > include/d3drmobj.h | 26 +++++++++++++------------- > 6 files changed, 45 insertions(+), 57 deletions(-) > > diff --git a/dlls/d3drm/d3drm.c b/dlls/d3drm/d3drm.c > index 8dfa4bb..fe728a8 100644 > --- a/dlls/d3drm/d3drm.c > +++ b/dlls/d3drm/d3drm.c > @@ -317,24 +317,20 @@ static HRESULT WINAPI IDirect3DRMImpl_CreateUserVisual(IDirect3DRM* iface, D3DRM > return E_NOTIMPL; > } > > -static HRESULT WINAPI IDirect3DRMImpl_LoadTexture(IDirect3DRM* iface, const char* filename, > - LPDIRECT3DRMTEXTURE* Texture) > +static HRESULT WINAPI IDirect3DRMImpl_LoadTexture(IDirect3DRM *iface, > + const char *filename, IDirect3DRMTexture **texture) > { > - IDirect3DRMImpl *This = impl_from_IDirect3DRM(iface); > - > - FIXME("(%p/%p)->(%s,%p): stub\n", iface, This, filename, Texture); > + FIXME("iface %p, filename %s, texture %p stub!\n", iface, debugstr_a(filename), texture); > > Do you really need to change the way traces are displayed?

2 6

Re: jscript: Added RegExp.toString() implementation.
by Marvin May 27, 2013

May 27, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25722 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: riched20: Added tests for ITextDocument::Open
by Alexandre Julliard May 27, 2013

May 27, 2013

Jactry Zeng <jactry92(a)gmail.com> writes: > diff --git a/dlls/riched20/tests/test.txt b/dlls/riched20/tests/test.txt > new file mode 100644 > index 0000000..e69de29 If you need an external file you have to create a temp file in the test. You can't rely on running from inside the source tree. -- Alexandre Julliard julliard(a)winehq.org

2 1

Spam again ...
by Joerg Schiermeier May 27, 2013

May 27, 2013

Hi maintainer, ---<cite>--- Message: 1 Date: Sun, 26 May 2013 01:07:06 +0000 (UTC) From: xerox_xerox2000(a)yahoo.co.uk To: <wine-devel(a)winehq.org>, <vidar268(a)yahoo.com>, <vladdy(a)utchat.com> Subject: RE: Message-ID: <823277.37895.bm(a)smtp104.mail.ir2.yahoo.com> Moussoiddik%20Aboudou588 http://fonio-bio.org/w/87Elsie%20Mills045 Mon, 27 May 2013 5:04:06 ---</cite>--- UCE/Spam again in this list ...! Please remove this user. Thanks a lot. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1

d3dx9: Avoid useless computations in D3DXMatrixTransformation2D
by Nozomi Kodama May 26, 2013

May 26, 2013

Hello What happens for this patch? Nozomi

1 1

Re: [PATCH] wininet: do avoid overwriting the buffer (Coverity)
by Marvin May 26, 2013

May 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25714 Your paranoid android. === WXPX64 (32 bit http) === http.c:4291: Test failed: 4462: expected status 100 got 10 http.c:4291: Test failed: 4506: expected status 100 got 40 http.c:4264: Test failed: ar->dwResult = 0, expected 1 http.c:4291: Test failed: 4515: expected status 70 got 100 http: unhandled exception c0000005 at 7722EDEA === WXPX64 (64 bit http) === http.c:4291: Test failed: 4462: expected status 100 got 10 http.c:4291: Test failed: 4506: expected status 100 got 40 http.c:4264: Test failed: ar->dwResult = 0, expected 1 http.c:4291: Test failed: 4515: expected status 70 got 100 http: unhandled exception c0000005 at 0000000000495D94

1 0

RE:
by xerox_xerox2000＠yahoo.co.uk May 26, 2013

May 26, 2013

Moussoiddik%20Aboudou588 http://fonio-bio.org/w/87Elsie%20Mills045 Mon, 27 May 2013 5:04:06

1 0

Re: [PATCH] kernel32: Don't move fixed memory area in GlobalReAlloc().
by Marvin May 25, 2013

May 25, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25705 Your paranoid android. === W7PROX64 (32 bit heap) === heap.c:234: Test failed: got 00000000 heap.c:400: Test failed: got 00000000 === TEST64_W7SP1 (32 bit heap) === heap.c:234: Test failed: got 00000000 heap.c:400: Test failed: got 00000000

1 0

Re: [2/2] server: A being destroyed object may need to access other objects using a handle.
by Alexandre Julliard May 24, 2013

May 24, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- a/server/handle.c > +++ b/server/handle.c > @@ -165,7 +165,6 @@ static void handle_table_destroy( struct object *obj ) > for (i = 0, entry = table->entries; i <= table->last; i++, entry++) > { > struct object *obj = entry->ptr; > - entry->ptr = NULL; > if (obj) release_object( obj ); You can't do that, the object can't be accessed after being released. -- Alexandre Julliard julliard(a)winehq.org

2 5

Adding names to the authors file.
by Tae Wong May 24, 2013

May 24, 2013

The only Croatian person is Marko Nikolić, but with no accented letter. Could you also add Joško Nikolić (the Croatian translator) and Volkan Gezer (the Turkish translator) to the authors file as well? The file name (in all capitals) is AUTHORS. It is very great so that you have to accentuate Marko's name at the message. But you use "straight quotes" or “smart quotes”. And Van Schaik's name is credited under the surname (and not on the particle). Here is the sort that you want for the section: va. South African and Namibian names in Dutch should have been sorted on the prefix (particle), but not in the surname. Vainer, Moshe Valoska, Hleb Valtonen, Hannu Vance, Carroll Vanek, Tomas van Schaik, Carl (Note that this is on a letter by letter sort.) Vaughn, Charles

1 0

Re: po: Added Croatian translation.
by Frédéric Delanoy May 24, 2013

May 24, 2013

On Thu, May 23, 2013 at 3:45 PM, Joško Nikolić <josko.nikolic1(a)gmail.com> wrote: > > --- > configure | 1 + > po/LINGUAS | 1 + > po/hr.po | 13923 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 13925 insertions(+) > create mode 100644 po/hr.po As mentioned on IRC, you should remove the #| msgid "foo" lines, and modify 'configure.ac' instead of 'configure', which is autogenerated. Frédéric

1 0

Re: [5/5] oledb32: GetConversionSize only returns a valid size of BSTR
by Marvin May 24, 2013

May 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25680 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] oledb32: DataConvert only variant length types can have a null dst
by Marvin May 24, 2013

May 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25679 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] oledb32: DataConvert Support NULL variant
by Marvin May 24, 2013

May 24, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25677 Your paranoid android. === WVISTAX64 (64 bit convert) === No test summary line found === W7PROX64 (64 bit convert) === No test summary line found === TEST64_W7SP1 (64 bit convert) === No test summary line found

1 0

Re: [5/5] oledb32: GetConversionSize only returns a valid size of BSTR
by Nikolay Sivov May 23, 2013

May 23, 2013

On Thu, May 23, 2013 at 11:48 AM, Alistair Leslie-Hughes < leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > oledb32: GetConversionSize only returns a valid size of BSTR > + if(V_VT((VARIANT*)src) != VT_BSTR) + *dst_len = 110; else - return hr; + *dst_len = (SysStringLen(V_BSTR((VARIANT*)src)) + 1) * sizeof(WCHAR); + + return S_OK; So it returns previous result if type is invalid, meaning it's not VT_BSTR? You can't just return a random constant that appears in tests just because of previously made call (which is my guess). If you really want to implement this broken behaviour it will need more tests, at least one more that shows it returns a result from last successful call. > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

Re: advapi32/tests: Fix copy&paste typo
by Guo Jian May 23, 2013

May 23, 2013

Hi Andre, According to my test plan of the registry merging project, I will add new tests for HKCR. At first I tried to add them to the old code but I find it become too long and hard-reading. I had to rewrite them to a series of strict and neat tests, classified as read/write operations, including keys & values enumerating and deleting. I used many pre-definitions which make the test look fluent, but I'm not sure if the code is acceptable. http://newtestbot.winehq.org/JobDetails.pl?Key=942 static void test_classesroot(void) { DWORD res, len, i; HKEY hkey; char name[32]; #define CREATE_KEY(key, path) \ { \ HKEY tmp; \ if ((res = RegCreateKeyExA( key, path, 0, NULL, 0, \ KEY_ENUMERATE_SUB_KEYS|KEY_SET_VALUE|KEY_QUERY_VALUE|KEY_CREATE_SUB_KEY, \ NULL, &tmp, NULL )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegCreateKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ RegCloseKey(tmp); \ } \ } #define DELETE_KEY(key, path) \ { \ DWORD res; \ if ((res = RegDeleteKey(key, path)) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegDeleteKey %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ } #define SET_VALUE(key, path, name, value) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_SET_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ if ((res = RegSetValueEx( tmp, name, 0, REG_SZ, \ (CONST BYTE*)value, strlen(value) )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegSetValueEx %p\\%s failed with %08X\n", tmp, name, res); \ return; \ } \ RegCloseKey(tmp); \ } \ } #define CHECK_EXIST_KEY(key, path) \ ok(exist_key(key, path), "key %p\\%s should exist\n", key, path); #define CHECK_NOT_EXIST_KEY(key, path) \ ok(!exist_key(key, path), "key %p\\%s should exist\n", key, path); #define CHECK_VALUE(key, path, name, value) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_QUERY_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ char buf[32]; \ DWORD type = REG_SZ, size = sizeof(buf); \ if ((res = RegQueryValueEx( tmp, name, 0, &type, \ (BYTE*)buf, &size )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegQueryValueEx %p\\%s failed with %08X\n", tmp, name, res); \ return; \ } \ ok(!strcmp(value, buf), "%s expected '%s' but got '%s' in %p\\%s\n", name, value, buf, key, path); \ RegCloseKey(tmp); \ } \ } #define CHECK_NON_VALUE(key, path, name) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_QUERY_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ char buf[32]; \ DWORD type = REG_SZ, size = sizeof(buf); \ if ((res = RegQueryValueEx( tmp, name, 0, &type, \ (BYTE*)buf, &size )) == ERROR_SUCCESS) \ { \ ok(FALSE, "%s should not exist in %p\\%s\n", name, key, path); \ } \ else if (res != ERROR_FILE_NOT_FOUND) \ { \ ok(FALSE, "RegQueryValueEx %p\\%s failed with %08X\n", tmp, name, res); \ return; \ } \ RegCloseKey(tmp); \ } \ } #define DELETE_VALUE(key, path, name) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_SET_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ if ((res = RegDeleteValueA(tmp, name)) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegDeleteValue %s in %p\\%s failed with %08X\n", name, key, path, res); \ return; \ } \ RegCloseKey(tmp); \ } \ } #define CHECK_KEY_INFO(key, path, c1, c2) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_QUERY_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ DWORD n1, n2; \ if (ERROR_SUCCESS != (res = RegQueryInfoKeyA( tmp, NULL, NULL, NULL, \ &n1, NULL, NULL, &n2, NULL, NULL, NULL, NULL ))) \ { \ ok(FALSE, "RegQueryInfoKeyA failed with %08X\n\n", res); \ return; \ } \ ok(n1 == c1, "subkey count expected %d but got %d in %p\\%s\n", c1, n1, key, path); \ ok(n2 == c2, "value count expected %d but got %d in %p\\%s\n", c2, n2, key, path); \ RegCloseKey(tmp); \ } \ } /* test create_key priority */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); if ((res = RegOpenKeyExA( HKEY_CLASSES_ROOT, "WineTestCls", 0, STANDARD_RIGHTS_READ, &hkey )) != ERROR_SUCCESS) { skip("classes merging not supported\n"); cleanup_classes(); return; } /* test create_key priority */ /* create from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hklm then hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hkcu then hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); /* further test based on the below */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); if ((res = RegOpenKeyExA( HKEY_CLASSES_ROOT, "WineTestCls", 0, KEY_CREATE_SUB_KEY, &hkey )) != ERROR_SUCCESS) { ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", hkey, "WineTestCls", res); return; } /* create subkey under the handle opened from the key that exists only in hkcu but not hklm */ CREATE_KEY(hkey, "subkey1"); RegCloseKey(hkey); /* check that subkey is created in hklm, proving that the handle from hkcr is not same as opened in hkcu, even when it does not conflict with hklm */ CHECK_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey1"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); /* test delete_key priority */ /* create from hkcu and delete from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hklm and delete from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hkcu and hklm and delete twice from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* delete again */ DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* test set_value priority */ /* set new value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_NON_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1"); /* set value from hkcu and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_NON_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1"); /* set value from hklm and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); /* set value from hkcu and hklm and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); /* set value from hklm in a key not conflict with hkcu and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hkcr"); /* test delete_value priority, no need to test when not conflict */ /* set value from hkcu and hklm then delete twice from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); DELETE_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1"); CHECK_NON_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); /* delete again */ DELETE_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1"); CHECK_NON_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1"); /* test query_value priority, noneed to test when not conflict */ /* set value to hkcu and create the key in hklm then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcu"); /* set value to hklm and create the key in hkcu then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hklm"); /* set conflict value both to hkcu and hklm then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcu"); /* set non conflict value both to hkcu and hklm then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val2", "hklm"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcu"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val2", "hklm"); /* test query_info_key priority, no need to test when queried key does not conflict */ /* check subkey and value count for conflict subkeys from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey1"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CHECK_KEY_INFO(HKEY_CLASSES_ROOT, "WineTestCls", 1, 1); /* check subkey and value count for non conflict subkeys from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey2"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val2", "hkcu"); CHECK_KEY_INFO(HKEY_CLASSES_ROOT, "WineTestCls", 2, 2); /* test enum_key priority, no need to test when enumerated key does not conflict */ /* create subkeys and values in hkcu and hklm */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey3"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val3", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey3"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey2"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val3", "hkcu"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val2", "hkcu"); /* check the count */ CHECK_KEY_INFO(HKEY_CLASSES_ROOT, "WineTestCls", 3, 3); if ((res = RegOpenKeyExA( HKEY_CLASSES_ROOT, "WineTestCls", 0, KEY_ENUMERATE_SUB_KEYS|KEY_QUERY_VALUE, &hkey )) != ERROR_SUCCESS) { ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", hkey, "WineTestCls", res); return; } /* check the names and order of subkeys when enumerating */ i = 0; len = sizeof(name); while (ERROR_SUCCESS == (res = RegEnumKeyExA(hkey, i, name, &len, NULL, NULL, NULL, NULL))) { ++ i; if (i > 3) { ok(FALSE, "got extra subkey name %s\n", name); } else if (strncmp(name, "subkey", 6) || name[6] != (i + '0') || name[7]) { ok(FALSE, "got unexpected subkey name or order %s at index %d\n", name, i); } len = sizeof(name); } if (res != ERROR_NO_MORE_ITEMS) { ok(FALSE, "RegEnumKeyExA failed with %08X\n", res); return; } if (i < 3) { ok(FALSE, "expected 3 subkeys but got only %d\n", i); } /* check the names and order of values when enumerating */ i = 0; len = sizeof(name); while (ERROR_SUCCESS == (res = RegEnumValueA(hkey, i, name, &len, NULL, NULL, NULL, NULL))) { ++ i; if (i > 3) { ok(FALSE, "got extra value name %s\n", name); } else if (strncmp(name, "val", 3) || name[3] != (i + '0') || name[4]) { ok(FALSE, "got unexpected value name or order %s at index %d\n", name, i); } len = sizeof(name); } if (res != ERROR_NO_MORE_ITEMS) { ok(FALSE, "RegEnumValueA failed with %08X\n", res); return; } if (i < 3) { ok(FALSE, "expected 3 value but got only %d\n", i); } RegCloseKey(hkey); cleanup_classes(); } -- Regards, Guo Jian

1 0

Regression for bash.exe redirection of ctest.exe for wine-1.5.30 compared to wine-1.5.19
by Alan W. Irwin May 22, 2013

May 22, 2013

Generally I have found in still fairly limited testing that MSYS bash.exe redirection is fine on wine-1.5.30 (which I have now been able to build in 32-bit mode on Debian wheezy x86_64 thanks to the 32-bit library symlink trick discussed in my previous recent thread). However, I have just discovered a puzzling case where MSYS bash.exe redirection now fails for ctest.exe compared to wine-1.5.19. To reproduce this regression download the Windows binary version of cmake-1.8.10.2 (which includes cmake.exe and ctest.exe) and install it. Also download and install MinGW/MSYS. In the past, I have found results depend very much on how you get into the MSYS bash.exe environment. In my case I execute wineconsole --backend=curses MinGW_4.7.0/msys/1.0/bin/bash.exe to do that, and then from that interactive environment execute the commands below. Here is how I try the --version option for cmake and ctest with redirection under bash.exe. bash.exe-3.1$ cmake --version >& cmake_version.out bash.exe-3.1$ ctest --version >& ctest_version.out For Wine-1.5.19 bash.exe-3.1$ head *.out ==> cmake_version.out <== cmake version 2.8.10.2 ==> ctest_version.out <== ctest version 2.8.10.2 For Wine-1.5.30 bash.exe-3.1$ head *.out ==> cmake_version.out <== cmake version 2.8.10.2 ==> ctest_version.out <== N.B. note the incorrect empty ctest_version.out file for Wine-1.5.30. For both Wine-1.5.19 and Wine-1.5.30 if I don't redirect the output I simply get the following results bash.exe-3.1$ cmake --version cmake version 2.8.10.2 bash.exe-3.1$ ctest --version ctest version 2.8.10.2 So somehow bash.exe redirection for ctest (but not cmake and a small number of other commands I have tried) generates an incorrect empty file for Wine-1.5.30. I never have had trouble with bash.exe redirection for any command (including ctest) on either Linux bash or MSYS bash.exe on Wine-1.5.19. So it is likely there is some minor (but probably standard) variation in how ctest handles its stdout that is triggering this Wine-1.5.30 regression compared to Wine-1.5.19. So there might be other commands as well where bash.exe redirection doesn't work for Wine-1.5.30. If it is already known that MSYS bash.exe redirection is sometimes problematic with Wine-1.5.30 compared to earlier versions, is there some patch I could try to see if it fixes this specific issue? My primary motivation is developing my own free software. Therefore, I only have limited time to help figure out wine bugs although I am willing to report the ones I discover here (and on the bug tracker once discussed here to reduce bug tracker noise). That said, it does appear that git-bisect would be an ideal way to find which commit between Wine-1.5.19 and Wine-1.5.30 caused the bash.exe redirection issue with ctest.exe. Unfortunately, I have zero experience with git-bisect. However, if somebody could give me some step-by-step instructions I could follow by rote that would be great. Ideally, those instructions would be a simple template bash script I could run unattended overnight from Linux that used git-bisect to detect the first commit between Wine-1.5.19 and Wine-1.5.30 where ctest --version >& ctest_version.out produces an empty file under MSYS bash.exe. I can fill in the parts of that template script concerning the wine build for each git commit that is being tested since I have such builds (including necessary *.so links for later wine versions) largely automated now. But I am not sure about how you get into MSYS bash.exe directly (my normal method using wineconsole as above appears to be interactive rather than something you could run unattended) from a Linux bash script so I would need advice about that. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

2 3

Patches 96314 & 96328
by Christian Costa May 22, 2013

May 22, 2013

Hi, Is there any problem with these patches? http://source.winehq.org/patches/data/96314 http://source.winehq.org/patches/data/96328 Christian

1 0

Re: [PATCH 2/5] dinput: Support SendForceFeedbackCommand for OSX joysticks
by Charles Davis May 22, 2013

May 22, 2013

On May 21, 2013, at 1:34 PM, Andrew Eikum wrote: > --- > dlls/dinput/joystick_osx.c | 34 ++++++++++++++++++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/dlls/dinput/joystick_osx.c b/dlls/dinput/joystick_osx.c > index 94398e7..8fb675d 100644 > --- a/dlls/dinput/joystick_osx.c > +++ b/dlls/dinput/joystick_osx.c > @@ -1135,6 +1135,36 @@ static HRESULT WINAPI JoystickAImpl_CreateEffect(IDirectInputDevice8A *iface, > type, params, out, outer); > } > > +static HRESULT WINAPI JoystickWImpl_SendForceFeedbackCommand(IDirectInputDevice8W *iface, > + DWORD flags) > +{ > + JoystickImpl *This = impl_from_IDirectInputDevice8W(iface); > + HRESULT hr; > + > + TRACE("%p 0x%x\n", This, flags); > + > + if(!This->ff) > + return DI_NOEFFECT; > + > + hr = FFDeviceSendForceFeedbackCommand(This->ff, flags); > + if(FAILED(hr)){ > + WARN("FFDeviceSendForceFeedbackCommand failed: %08x\n", hr); > + return hr; You can't return the straight HRESULT from ForceFeedback here. That's because the codes in the FACILITY_NULL range on Mac get their values from the 16-bit COM runtime (cf. <CoreFoundation/CFPlugInCOM.h>). You must turn them into their corresponding Win32 codes. Chip

2 1

wine-osX developer for winmm joystick project?
by DavidL May 22, 2013

May 22, 2013

To anybody interested, I think I've found a solution to an old problem of implementing winmm joystick support in WINE for Mac, but lack the necessary skills and experience to code it up myself. WINE-Linux has had it implemented for awhile, but it was never coded up for OS X. winmm is an older interface used for a lot of different peripherals, included joysticks in quite a few classic games. As there were also some problems with dinput for WINE-OSX, originally it was thought the problems with winmm were also a bug. However, the problems with dinput have been solved and it seems the necessary code for winmm joystick support, rather than being buggy, was never actually written for WINE for the Mac. Thus it is an issue in need of development rather than a bug report. So I thought I'd ask if anyone was interested in developing the code to get winmm working in in the Mac-WINE environment? I have an idea about what needs to be written but I lack the experience in Mac-system level programming to be of much use. I did take a look but found the API very arcane. That's why I am asking for someone with more experience. From what I can tell, the code should not be difficult to write for someone who knew what they were doing with regards to Mac system programming. There aren't many functions that need to be written and what ones there are seem simple enough. I have an outline about what functions need to written and modified to get winmm functionality working for the Mac-WINE environment. The requisite changes are here: ( http://bugs.winehq.org/show_bug.cgi?id=18424#c75) It is written in a bug report because originally it was part of the same conversation as the dinput bug. I look forward to hearing back from anyone interested in taking this (I think) short development project up. I'd be happy to learn and help test the code with some classic games that require winmm. Cheers, David

1 0

Re: [PATCH 2/4] ddraw/tests: Add EXCLUSIVE->NORMAL coop level switching tests
by Henri Verbeet May 22, 2013

May 22, 2013

On 21 May 2013 13:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static void test_coop_level_versions(void) It may make more sense to move that to ddraw2.c and ddraw4.c instead. (IIRC you can't QI a ddraw1 interface from ddraw7.)

2 2

Re: [PATCH 1/4] ddraw: Restore resolution on EXCLUSIVE->NORMAL switch
by Henri Verbeet May 22, 2013

May 22, 2013

On 21 May 2013 13:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > The new code does not deliver the resolution change messages to the > correct window, see the todo_wine markers in the next patch. Getting > this right isn't simply a matter of passing the correct window to > wined3d_device_restore_fullscreen_window because the delivery of the > correct messages in the new window == old window case is mostly a lucky > side effect of the window style hacks. Those hacks fail if we pass a > different window, because the style of the new window is different from > what wined3d expects, so it doesn't send any messages. Well, wined3d_device_restore_fullscreen_window() isn't really supposed to generate messages at all, the resize on mode changes happens in device_parent_mode_changed(). The implication seems to be that restoring the display mode is supposed to happen after the new swapchain is created, but before "ddraw->cooperative_level" is updated. > /***************************************************************************** > + * IDirectDraw7::RestoreDisplayMode > + * > + * Restores the display mode to what it was at creation time. Basically. > + * > + * Returns > + * DD_OK on success > + * DDERR_NOEXCLUSIVE mode if the device isn't in fullscreen mode > + * > + *****************************************************************************/ I don't think that really adds anything. > -static HRESULT WINAPI ddraw7_SetCooperativeLevel(IDirectDraw7 *iface, HWND window, DWORD cooplevel) > +static HRESULT WINAPI ddraw_set_cooperative_level(struct ddraw *ddraw, HWND window, > + DWORD cooplevel, BOOL restore_mode) Shadowing the global "restore_mode" is a bit unfortunate. > - TRACE("iface %p, window %p, flags %#x.\n", iface, window, cooplevel); > + TRACE("ddraw %p, window %p, flags %#x, restore_mode %s.\n", ddraw, window, cooplevel, > + restore_mode ? "true" : "false"); I think %#x is generally clear enough for BOOLs. > if(cooplevel & DDSCL_ALLOWREBOOT) > - WARN("(%p) Unhandled flag DDSCL_ALLOWREBOOT, harmless\n", This); > + WARN("(%p) Unhandled flag DDSCL_ALLOWREBOOT, harmless\n", ddraw); > if(cooplevel & DDSCL_ALLOWMODEX) > - WARN("(%p) Unhandled flag DDSCL_ALLOWMODEX, harmless\n", This); > + WARN("(%p) Unhandled flag DDSCL_ALLOWMODEX, harmless\n", ddraw); > if(cooplevel & DDSCL_FPUSETUP) > - WARN("(%p) Unhandled flag DDSCL_FPUSETUP, harmless\n", This); > + WARN("(%p) Unhandled flag DDSCL_FPUSETUP, harmless\n", ddraw); The "(%p)" there is pretty pointless, I usually remove them if I'm editing the line anyway. > @@ -86,6 +86,7 @@ struct ddraw > > /* DirectDraw things, which are not handled by WineD3D */ > DWORD cooperative_level; > + BOOL setcooplevel_ddraw1; > We should probably consolidate the various BOOLs in struct ddraw into a flags field.

2 2

Question about legal requirement on gsoc page
by Christian Costa May 22, 2013

May 22, 2013

*Hi, * *I read on the GSoC page this: * *"You are not allowed to analyze Windows files with the trace functions of Wine" * *What does that mean? * *Thanks * *Christian *

2 2

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called (try 2).
by Alexandre Julliard May 22, 2013

May 22, 2013

Qian Hong <qhong(a)codeweavers.com> writes: > @@ -5383,7 +5383,11 @@ int WINAPI WSAEventSelect(SOCKET s, WSAEVENT hEvent, LONG lEvent) > ret = wine_server_call( req ); > } > SERVER_END_REQ; > - if (!ret) return 0; > + if (!ret) > + { > + _enable_event(SOCKET2HANDLE(s), 0, FD_WINE_NONBLOCKING, 0); > + return 0; > + } You shouldn't need 2 server calls for this. > @@ -3578,6 +3584,12 @@ static void test_events(int useMessages) > goto end; > } > > + if (set_blocking(src2, TRUE)) > + { > + ok(0, "set_blocking failed, error %d\n", WSAGetLastError()); > + goto end; > + } There's no reason to abort on every failure. -- Alexandre Julliard julliard(a)winehq.org

2 1

Troubles configuring and building wine-1.5.30 on Debian wheezy
by Alan W. Irwin May 22, 2013

May 22, 2013

My use case is building and testing software packages on Wine. My 32-bit build of wine-1.5.19 on x86_64 hardware was fine for this purpose for MinGW/MSYS builds so I stuck with it until today when I attempted to expand my building and testing of software to the Cygwin on Wine platform. I immediately ran into some issues with the Cygwin setup.exe installer so my first instinct was to try the latest experimental wine release, wine-1.5.30, but it's build has changed quite a bit since when I built wine-1.5.19, and I need some help figuring out what to do. The first issue was the configure script complained that the 32-bit version of the X libraries was missing and errored out. I then decided to try the 64-bit version of wine instead (since my Debian system has mostly 64-bit libraries). I got that 64-bit-only build and install to work perfectly, but I could not run anything with it. For example: wine(a)raven> wine64 wine64: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory I then looked at http://wiki.winehq.org/Wine64 which recommended a WoW64 configuration, where you build both 64-bit and 32-bit versions of Wine and install both. So following those directions, the 64-bit version again built and installed without issues (in fact I just renamed what I did before) but the 32-bit version again errored out on lack of a 32-bit X library. Now Debian wheezy has multiarch implemented properly for some (but not all) packages so I was able to install libx11-dev:i386 which coexisted fine with the installed libx11-dev:amd64 and also solved the 32-bit X issue. But then the 32-bit wine-1.5.30 configure continued further and ran into a similar issue with missing 32-bit freetype6. The error message was configure: error: FreeType 32-bit development files not found. Fonts will not be built. Use the --without-freetype option if you really want this. Accordingly I attempted to install libfreetype6-dev:i386 but on Debian wheezy that conflicts with libfreetype6-dev:amd64, and it appears the only way around this packaging issue for now (until the libfreetype6-dev:i386 and libfreetype6-dev:amd64 packages are taught to coexist) is to create a pure 32-bit Debian wheezy system (which I don't want to do). So here are my questions and further comments: 1. Is there a way to stick with a pure 64-bit Wine system, or is that normally pretty useless because downloaded applications such as the Cygwin installer which apparently is 32-bit, i.e., wine(a)raven> file setup.exe setup.exe: PE32 executable (GUI) Intel 80386 (stripped to external PDB), for MS Windows, UPX compressed wont run on it? 2. If the WoW64 configuration is really the best solution, what are the consequences of dropping libfreetype from the 32-bit configuration (but obviously including it in the 64-bit configuration). IOW, if I just say --without-freetype for the 32-bit configuration (suggested as a possibility above by that error message) will the fonts be built and installed by the 64-bit configuration that includes libfreetype? 3. I would have liked to continue with pure 32-bit wine since that was what I have been used to all these years, but it appears wine-1.5.30 32-bit dependencies are really fearsome compared to the relative modest 32-bit dependencies for wine-1.5.19 so this effectively makes it impossible to build a standalone 32-bit wine system on Debian Wheezy (because no fonts will be built if --without-freetype is used) and might also compromise WoW64 builds (see question 2 above). It obviously doesn't affect pure 64-bit Wine builds, but I couldn't get that to work at all at run time (missing libwine.so.1 (see above)), but if there are workarounds for that issue, then it still might be useless (see question 1 above). Any help/comments on the correct way to build wine-1.5.30 would be much appreciated for the case (as on Debian wheezy) where 32-bit and 64-bit libfreetype packages cannot be installed simultaneously. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

5 8

Re: server: Always redraw children when parent's pos/size changed in any way (Try 2).
by Sergey Guralnik May 21, 2013

May 21, 2013

On 2013-05-06 13:24, Sergey Guralnik wrote: > Alexandre Julliard writes: >> ... >> It doesn't make sense to have all these complicated tests if we are >> going to always repaint anyway, which is essentially what your patch >> does. There has to be more to it than that. > > This version uses the same logic as used before, but also it > removes all redundant checks. > > --- > dlls/user32/tests/win.c | 1 - > server/window.c | 32 ++++++-------------------------- > 2 files changed, 6 insertions(+), 27 deletions(-) Is there some problem with this patch? -- Sergey

2 1

[PATCH] Tests that prove ntdll has no notion of HKCR.
by George Stephanos May 21, 2013

May 21, 2013

As instructed, I added a few lines to the already written tests that confirm my claim. Part of the research of the registry merging project was to determine where the implementation is going to be written: advapi32, ntdll or the server itself. The server choice was dismissed since HKCR isn't stored and rather fetched live. These tests prove that advapi32 calls that reference HKCR are either pointed there to \REGISTRY\MACHINE or \REGISTRY\USER and hence, that the merge is to be done in advapi32. http://newtestbot.winehq.org/JobDetails.pl?Key=976 --- dlls/advapi32/tests/registry.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index b2483a7..8437e4d 100644 --- a/dlls/advapi32/tests/registry.c +++ b/dlls/advapi32/tests/registry.c @@ -43,6 +43,7 @@ static DWORD (WINAPI *pRegDeleteTreeA)(HKEY,LPCSTR); static DWORD (WINAPI *pRegDeleteKeyExA)(HKEY,LPCSTR,REGSAM,DWORD); static BOOL (WINAPI *pIsWow64Process)(HANDLE,PBOOL); static NTSTATUS (WINAPI * pNtDeleteKey)(HANDLE); +static NTSTATUS (WINAPI * pNtQueryKey)(HANDLE,int,PVOID,ULONG,PULONG); static NTSTATUS (WINAPI * pRtlFormatCurrentUserKeyPath)(UNICODE_STRING*); static NTSTATUS (WINAPI * pRtlFreeUnicodeString)(PUNICODE_STRING); @@ -136,6 +137,7 @@ static void InitFunctionPtrs(void) pRtlFormatCurrentUserKeyPath = (void *)GetProcAddress( hntdll, "RtlFormatCurrentUserKeyPath" ); pRtlFreeUnicodeString = (void *)GetProcAddress(hntdll, "RtlFreeUnicodeString"); pNtDeleteKey = (void *)GetProcAddress( hntdll, "NtDeleteKey" ); + pNtQueryKey = (void *)GetProcAddress( hntdll, "NtQueryKey" ); } /* delete key and all its subkeys */ @@ -2104,6 +2106,7 @@ static void test_classesroot(void) DWORD type = REG_SZ; static CHAR buffer[8]; LONG res; + void *buf = malloc(300*sizeof(wchar_t)); /* create a key in the user's classes */ if (!RegOpenKeyA( HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", &hkey )) @@ -2132,6 +2135,9 @@ static void test_classesroot(void) RegCloseKey( hkey ); return; } + pNtQueryKey( hkcr, 3 /*KeyNameInformation*/, buf, 500*sizeof(wchar_t), (ULONG*)&res ); + ok( wcsncmp((wchar_t*)buf+2, L"\\REGISTRY\\USER", 14) == 0, + "key not from \\REGISTRY\\USER\n"); /* set a value in user's classes */ res = RegSetValueExA(hkey, "val1", 0, REG_SZ, (const BYTE *)"user", sizeof("user")); @@ -2200,6 +2206,9 @@ static void test_classesroot(void) RegCloseKey( hklm ); return; } + pNtQueryKey( hkcr, 3 /*KeyNameInformation*/, buf, 500*sizeof(wchar_t), (ULONG*)&res ); + ok( wcsncmp( (wchar_t*)buf+2, L"\\REGISTRY\\USER", 14) == 0, + "key not from \\REGISTRY\\USER\n"); /* set a value in hklm classes */ res = RegSetValueExA(hklm, "val2", 0, REG_SZ, (const BYTE *)"hklm", sizeof("hklm")); @@ -2227,6 +2236,9 @@ static void test_classesroot(void) KEY_QUERY_VALUE|KEY_SET_VALUE, &hkcr ); ok(res == ERROR_SUCCESS, "test key not found in hkcr: %d\n", res); + pNtQueryKey( hkcr, 3 /*KeyNameInformation*/, buf, 500*sizeof(wchar_t), (ULONG*)&res ); + ok( wcsncmp( (wchar_t*)buf+2, L"\\REGISTRY\\USER", 14) == 0, + "key not from \\REGISTRY\\USER\n"); /* set a value in user's classes */ res = RegSetValueExA(hkey, "val2", 0, REG_SZ, (const BYTE *)"user", sizeof("user")); @@ -2267,6 +2279,9 @@ static void test_classesroot(void) /* try to open that subkey in hkcr */ res = RegOpenKeyExA( hkcr, "subkey1", 0, KEY_QUERY_VALUE|KEY_SET_VALUE, &hkcrsub1 ); ok(res == ERROR_SUCCESS, "test key not found in hkcr: %d\n", res); + pNtQueryKey( hkcrsub1, 3 /*KeyNameInformation*/, buf, 500*sizeof(wchar_t), (ULONG*)&res ); + ok( wcsncmp( (wchar_t*)buf+2, L"\\REGISTRY\\MACHINE", 17) == 0, + "key created in hkcr not found in \\REGISTRY\\MACHINE\n"); /* set a value in hklm classes */ res = RegSetValueExA(hklmsub1, "subval1", 0, REG_SZ, (const BYTE *)"hklm", sizeof("hklm")); @@ -2326,6 +2341,9 @@ static void test_classesroot(void) /* new subkey in hkcr */ if (RegCreateKeyExA( hkcr, "subkey2", 0, NULL, 0, KEY_QUERY_VALUE|KEY_SET_VALUE, NULL, &hkcrsub2, NULL )) return; + pNtQueryKey( hkcrsub2, 3 /*KeyNameInformation*/, buf, 256*sizeof(wchar_t), (ULONG*)&res ); + ok( wcsncmp( (wchar_t*)buf+2, L"\\REGISTRY\\MACHINE", 17) == 0, + "key not found in \\REGISTRY\\MACHINE"); res = RegSetValueExA(hkcrsub2, "subval1", 0, REG_SZ, (const BYTE *)"hkcr", sizeof("hkcr")); ok(res == ERROR_SUCCESS, "RegSetValueExA failed: %d, GLE=%x\n", res, GetLastError()); -- 1.8.1.msysgit.1

3 11

Re: dbghelp: Add stub SymGetLineNextW64
by Alexandre Julliard May 21, 2013

May 21, 2013

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -1717,6 +1717,17 @@ BOOL WINAPI SymGetLineNext64(HANDLE hProcess, PIMAGEHLP_LINE64 Line) > } > > /****************************************************************** > + * SymGetLineNextW64 (DBGHELP.@) > + * > + */ > +BOOL WINAPI SymGetLineNextW64(HANDLE hProcess, PIMAGEHLP_LINEW64 Line) > +{ > + FIXME("(%p %p) stub \n", hProcess, Line); > + > + return FALSE; > +} It wouldn't be much harder to implement this properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: riched20: Added tests for ITextDocument::Open
by Nikolay Sivov May 21, 2013

May 21, 2013

On Tue, May 21, 2013 at 3:45 PM, Jactry Zeng <jactry92(a)gmail.com> wrote: > > > > > If the whole purpose of storing flags names is to output readable debug info I think it's better to have a single separate function that takes flags combination and returns static buffer pointer with a name. This way it will need just to append after bitwise 'and' check. + /* tests for ITextDocument::Open */ + for(; tomNunSingle >= 0; tomNunSingle--) Do you really need to go from the tail here?

1 0

Re: Alexandre Julliard : msvcrt: Don't bother to clean up at process exit.
by Dmitry Timoshkov May 21, 2013

May 21, 2013

Alexandre Julliard <julliard(a)winehq.org> wrote: > case DLL_PROCESS_DETACH: > - msvcrt_free_popen_data(); > msvcrt_free_io(); > + if (lpvReserved) break; > + msvcrt_free_popen_data(); > msvcrt_free_mt_locks(); > msvcrt_free_console(); > msvcrt_free_args(); Shouldn't msvcrt_free_io() be also protected by this guard? -- Dmitry.

3 6

Re: [PATCH] d3dxof: Cleanup separators handling and allow multi-semicolons + single comma separator.
by Alexandre Julliard May 21, 2013

May 21, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > There is one test becoming todo. This will be fixed in another patch. > This patch also should fix bug 30897. > --- > dlls/d3dxof/parsing.c | 35 ++++++++++------------------------- > dlls/d3dxof/tests/d3dxof.c | 22 +++++++++++----------- > 2 files changed, 21 insertions(+), 36 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M d3drm.dll -T ../../.. -p d3drm_test.exe.so d3drm.c && touch d3drm.ok d3drm.c:275: Test failed: Cannot load mesh data (hr = 88760311) d3drm.c:280: Test failed: Retrieved name '' instead of 'Object' d3drm.c:283: Test failed: IDirect3DRMMeshBuilder_GetName returned hr = 0 d3drm.c:298: Test failed: Wrong number of vertices 0 (must be 4) d3drm.c:301: Test failed: Wrong number of faces 0 (must be 3) d3drm.c:305: Test failed: Wrong number of vertices 0 (must be 4) d3drm.c:306: Test failed: Wrong number of normals 0 (must be 4) d3drm.c:307: Test failed: Wrong number of face data bytes 0 (must be 22) d3drm.c:315: Test failed: Wrong component n[1].x = 0.000000 (expected -0.229416) d3drm.c:318: Test failed: Wrong component n[2].x = 0.000000 (expected -0.229416) d3drm.c:319: Test failed: Wrong component n[2].y = 4021199976020422122536960.000000 (expected 0.688247) d3drm.c:320: Test failed: Wrong component n[2].z = 9973638011820690691325952.000000 (expected 0.688247) d3drm.c:321: Test failed: Wrong component n[3].x = 0.000000 (expected -0.577350) d3drm.c:323: Test failed: Wrong component n[3].z = 1387759860774554023173815085733773312.000000 (expected 0.577350) d3drm.c:329: Test failed: Cannot get texture coordinates (hr = 88760316) d3drm.c:330: Test failed: Wrong coordinate 1.230000 (must be 0.0) etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool
by Marvin May 21, 2013

May 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25647 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Marvin May 21, 2013

May 21, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25646 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Jacek Caban May 21, 2013

May 21, 2013

Hi Zhan, On 05/17/13 16:53, Zhan Jianyu wrote: > This patch is built based on Jaceks's newly-submitted patch: > > commit 48a862306288d69d3623d5ecdc0f5a5a40addafe > ( vbscript: Round half to even in to_int) > > Thanks, Jacek. :-) > > With his patch, CInt could be implementd in a clean way, without > any introduced helper function. > > This patch also add tests for any corner cases, and it has passed testbot's > testing. > > --- > dlls/vbscript/global.c | 14 ++++++++++++-- > dlls/vbscript/tests/api.vbs | 23 +++++++++++++++++++++++ > 2 files changed, 35 insertions(+), 2 deletions(-) As you may check here: http://source.winehq.org/patches/ your patch is marked as 'Apply failure'. Did you prepare the patch against recent Wine Git? Please rebase and resend the patch. Cheers, Jacek

1 0

Re: Troubles configuring and building wine-1.5.30 on Debian wheezy
by Hugh McMaster May 21, 2013

May 21, 2013

On Monday May 20 at 22:24:58, Alan W. Irwin wrote: >wine at raven> wine64 >wine64: error while loading shared libraries: libwine.so.1: cannot >open shared object file: No such file or directory Hi Alan, This error is caused by a regression in Wine 1.5.30. It is not present in version 1.5.29. The general source for Wine 1.5.30 on WineHQ does contain a patch to resolve the issue. The patch is available from http://source.winehq.org/git/wine.git/patch/ce4b6451aabbe83809c7483c748cfa0…. To apply it, you will need to save the patch with either the extension .patch or .txt in the Wine source directory. You will then need to run the patch command from the source directory: patch -p1 < name.patch Alternatively, you can use Git to obtain the latest source: git clone git://source.winehq.org/git/wine.git ~/wine-git This option will come with the patch already applied and a lot of other changes. --- Hugh

1 0

Re: [1/4] server: Add support for console font size, maximum window size, etc.
by Dmitry Timoshkov May 21, 2013

May 21, 2013

Hugh McMaster <hugh.mcmaster(a)masterindexing.com> wrote: > This patch modifies server/protocol.def and server/console.c to add support > for console font size detection and console window size rendering. It also > tidies up a few inconsistencies in the repeated usage of aspects of the > screen buffer struct. Your patches are full of formatting and white space changes, please don't do that. -- Dmitry.

2 1

Re: windowscodecs: Add support for IMILBitmapSource interface.
by Charles Davis May 20, 2013

May 20, 2013

On May 19, 2013, at 9:14 PM, Dmitry Timoshkov wrote: > diff --git a/dlls/windowscodecs/bitmap.c b/dlls/windowscodecs/bitmap.c > index f8904df..646f3a7 100644 > --- a/dlls/windowscodecs/bitmap.c > +++ b/dlls/windowscodecs/bitmap.c > @@ -446,6 +471,226 @@ static const IWICBitmapVtbl BitmapImpl_Vtbl = { > BitmapImpl_SetResolution > }; > > +static HRESULT WINAPI IMILBitmapImpl_QueryInterface(IMILBitmapSource *iface, REFIID iid, > + void **ppv) > +{ > + BitmapImpl *This = impl_from_IMILBitmapSource(iface); > + TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); > + > + if (!ppv) return E_INVALIDARG; > + > + if (IsEqualIID(&IID_IUnknown, iid) || > + IsEqualIID(&IID_IMILBitmapSource, iid)) > + { > + *ppv = &This->IMILBitmapSource_iface; > + IUnknown_AddRef((IUnknown*)*ppv); > + return S_OK; > + } You're violating COM rules here: when you QI an object for an interface pointer, the QI must always return the same result no matter what. Here, however, you're returning this interface pointer in response to a query for IUnknown, when the already-existing QueryInterface method on the IWICBitmap interface returns *itself* for IUnknown! Now when you QI for IUnknown on both of these interfaces, they won't compare equal. (I suspect you're not convinced. After all, native might violate COM rules here, too. I doubt that (see below), but it might. So, write a test that QI's for IUnknown from both interfaces, and checks if they're equal or not. Then we'll see who's right.) > diff --git a/dlls/windowscodecs/wincodecs_private.h b/dlls/windowscodecs/wincodecs_private.h > index dddb327..29f7726 100644 > --- a/dlls/windowscodecs/wincodecs_private.h > +++ b/dlls/windowscodecs/wincodecs_private.h > @@ -27,6 +27,46 @@ DEFINE_GUID(GUID_WineContainerFormatTga, 0x0c44fda1,0xa5c5,0x4298,0x96,0x85,0x47 > > DEFINE_GUID(GUID_VendorWine, 0xddf46da1,0x7dc1,0x404e,0x98,0xf2,0xef,0xa4,0x8d,0xfc,0x95,0x0a); > > +DEFINE_GUID(IID_IMILBitmapSource,0x7543696a,0xbc8d,0x46b0,0x5f,0x81,0x8d,0x95,0x72,0x89,0x72,0xbe); > +#define INTERFACE IMILBitmapSource > +DECLARE_INTERFACE_(IMILBitmapSource,IUnknown) > +{ > + /*** IUnknown methods ***/ > + STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID,void **) PURE; You know you can just use the STDMETHOD() macro (no trailing underscore), e.g.: STDMETHOD(QueryInterface)(THIS_ REFIID,void **) PURE; for methods that return an HRESULT, right? Or do you prefer explicitly declaring the return type like that, even if it is more typing? > + STDMETHOD_(ULONG,AddRef)(THIS) PURE; > + STDMETHOD_(ULONG,Release)(THIS) PURE; > + /*** IMILBitmapSource methods ***/ > + STDMETHOD_(HRESULT,GetSize)(THIS_ UINT *,UINT *); > + STDMETHOD_(HRESULT,GetPixelFormat)(THIS_ int *); > + STDMETHOD_(HRESULT,GetResolution)(THIS_ double *,double *); > + STDMETHOD_(HRESULT,CopyPalette)(THIS_ IWICPalette *); > + STDMETHOD_(HRESULT,CopyPixels)(THIS_ const WICRect *,UINT,UINT,BYTE *); > + STDMETHOD_(HRESULT,UnknownMethod1)(THIS_ void **); > +}; > +#undef INTERFACE > + > +#define INTERFACE IMILUnknown1 > +DECLARE_INTERFACE_(IMILUnknown1,IUnknown) > +{ > + /*** IUnknown methods ***/ > + STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID,void **) PURE; > + STDMETHOD_(ULONG,AddRef)(THIS) PURE; > + STDMETHOD_(ULONG,Release)(THIS) PURE; > +}; > +#undef INTERFACE Wouldn't that just make this interface a plain old IUnknown? Or does it have its own IID? (Or does that not even matter, given that it's returned from that "UnknownMethod1" above?) If it is nothing more than a plain IUnknown, why did you even add this, since it doesn't really extend the IUnknown interface with any new methods? It's telling that its v-table is the very first v-table in the object. This probably indicates that this really is the canonical IUnknown (i.e. the one that gets returned when you QI for IUnknown), and the other interfaces' IUnknown methods just delegate to this one. If I haven't missed my guess about this object's QI implementation, then this is the IUnknown that should get returned from a QI for IUnknown. This might actually be an object that supports aggregation; you may want to test for that, too ;). Chip

2 1

Re: [PATCH 6/6] d3d9/tests: d3d9ex video memory accounting tests
by Henri Verbeet May 20, 2013

May 20, 2013

On 14 May 2013 23:46, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > These tests have the potential to break on Windows when other > applications create or release a large number of video memory resources > while the test is running. > Yeah, maybe we don't really need this to be in the tree, although it's good to see for reference.

4 3

Re: msvcm80: Remove pre-attach handler for a dll with manifest.
by Alexandre Julliard May 20, 2013

May 20, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Manifest prevents loading of a native dll anyway. Not if it's installed globally. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called.
by Dmitry Timoshkov May 20, 2013

May 20, 2013

Qian Hong <qhong(a)codeweavers.com> wrote: > Fixed http://bugs.winehq.org/show_bug.cgi?id=33076 > > Reference: > http://msdn.microsoft.com/en-us/library/windows/desktop/ms741621%28v=vs.85%… > > See also comment in WSAIoctl: > /* AsyncSelect()'ed sockets are always nonblocking */ This change requires a test case, MSDN is often wrong, so its claims at least need to be very carefully checked. -- Dmitry.

2 5

Re: oledb32: Support DBSTATUS_S_ISNULL when converting to VARIANT
by Marvin May 20, 2013

May 20, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25629 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Add support for IMILBitmapSource interface.
by Marvin May 20, 2013

May 20, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25624 Your paranoid android. === WVISTAX64 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77370897 === W2K8SE (32 bit bitmap) === bitmap: unhandled exception c0000005 at 778A81CB === W7PROX64 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77E035F2 === TEST64_W7SP1 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77593772 === W7PROX64 (64 bit bitmap) === No test summary line found === TEST64_W7SP1 (64 bit bitmap) === Timeout

1 0

Duplicate relocations in DLL
by Alessandro Pignotti May 19, 2013

May 19, 2013

Hi everyone, Packaged with a game, I found a peculiar DLL which has duplicate blocks in the relocation table. I mean that the same pages are relocated twice and this of course breaks the DLL. I'm not sure about what could be a right way to support such (broken) DLLs. A possibility would be to keep track of already relocated pages and skip them if needed. Suggestions are welcome. Regards, Alessandro Pignotti

3 7

wineconsole screen scenarios
by Hugh McMaster May 19, 2013

May 19, 2013

In my effort to improve wineconsole and its calculations of the largest possible window size, three scenarios come into play. 1. wineconsole with --backend=user (or more simply, 'wineconsole app.exe, in which case 'user' is the default). 2. wineconsole with --backend=curses. 3. wineconsole with --backend=curses, but no X server running. Detecting the screen resolution is a simple task with (1) and (2). SystemParametersInfo for (1) and wine's own XRandR for (2) can be used. My concern is with scenario (3). Wine is designed to be used with an X server, but wineconsole can be used in non-X-based environment. While this is possible, it would seem unlikely. Nonetheless, the issue has come up on the wine-devel list before. The question is, should I worry about supporting such a scenario?

5 6

Re: [PATCH] ieframe: Add a IServiceProvider stub to IBindStatusCallback
by Alistair Leslie-Hughes May 19, 2013

May 19, 2013

On 18/05/2013 11:11 PM, Detlef Riekenberg wrote: > -- > By by ... Detlef > > --- > dlls/ieframe/navigate.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 51 insertions(+), 0 deletions(-) Tests to prove the interface exists. Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow (resend)
by Marvin May 18, 2013

May 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25614 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: GSoC proposal
by George Stephanos May 17, 2013

May 17, 2013

As we know already from [1], the merge is going to happen according to certain rules. The list at the end of the page signifies which subkeys are going to be *merged* from HKLM\Software\Classes\subkey and HKCU\Software\Classes\subkey and not simply linked to. Now there's a comment on the article that says that list is stored in a key. That lead me into thinking that the list is dynamic and should be determined at runtime using that key. However that key doesn't exist on my Win8 box or the web even. Should I just assume the list is static and build my tests/code according to it? Is there something I'm missing? [1] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724498(v=vs.85).a… On Wed, May 8, 2013 at 1:26 AM, George Stephanos <gaf.stephanos(a)gmail.com>wrote: > I'm done. Sorry for the font massacre. They're not changing :| > > > On Tue, May 7, 2013 at 6:45 PM, Juan Lang <juan.lang(a)gmail.com> wrote: > >> I'll leave it open till tomorrow (my time.) Thanks, >> --Juan >> >> >> On Tue, May 7, 2013 at 9:44 AM, Juan Lang <juan.lang(a)gmail.com> wrote: >> >>> Oh, hang on, I just flipped it so you can modify it. >>> >>> >>> On Tue, May 7, 2013 at 9:43 AM, Juan Lang <juan.lang(a)gmail.com> wrote: >>> >>>> I think you can add more of a timeline in a response. Will that work? >>>> --Juan >>>> >>>> >>>> On Tue, May 7, 2013 at 9:40 AM, George Stephanos < >>>> gaf.stephanos(a)gmail.com> wrote: >>>> >>>>> I had responded already but yes I'm a little bit shallow on the >>>>> timeline details. Alright. >>>>> Could you give me permission to modify the proposal? >>>>> >>>> >>>> >>> >> >

2 2

Re: [PATCH 4/6] gdi32: Use the default character when the glyph is missing.
by Alexandre Julliard May 17, 2013

May 17, 2013

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > This change is useful for a bitmap font. Because its glyph index 0 isn't the > default glyph in some cases. This doesn't seem to match what GetGlyphIndices does, and we probably don't want to do that in two different places. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool
by Marvin May 17, 2013

May 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25605 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Marvin May 17, 2013

May 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25604 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] wined3d: Only display a fixme when software processing is requested in wined3d_device_set_software_vertex_processing.
by Austin English May 17, 2013

May 17, 2013

On Thu, May 16, 2013 at 2:26 PM, Christian Costa <titan.costa(a)gmail.com> wrote: > Also remove fixme in wined3d_device_get_software_vertex_processing since it does what it is supposed to do. > --- > dlls/wined3d/device.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index 47da78b..89fc525 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -4281,9 +4281,9 @@ void CDECL wined3d_device_set_software_vertex_processing(struct wined3d_device * > > TRACE("device %p, software %#x.\n", device, software); > > - if (!warned) > + if (software && !warned) > { > - FIXME("device %p, software %#x stub!\n", device, software); > + FIXME("Software vertex processing not supported. Fake it and use harware one."); > warned = TRUE; Typo, should be hardware. -- -Austin

2 1

Re: msvcp90: Prefer native version.
by Piotr Caban May 17, 2013

May 17, 2013

On 05/17/13 08:01, Dmitry Timoshkov wrote: > Just like msvcp60,msvcp70,msvcp71,msvcp80,msvcp100,msvcp110 do. > --- > dlls/msvcp90/msvcp90_main.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/dlls/msvcp90/msvcp90_main.c b/dlls/msvcp90/msvcp90_main.c > index 7a7aafe..ce56c14 100644 > --- a/dlls/msvcp90/msvcp90_main.c > +++ b/dlls/msvcp90/msvcp90_main.c > @@ -80,10 +80,13 @@ static void init_cxx_funcs(void) > > BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > { > - TRACE("(0x%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); > + TRACE("(%p,%u,%p)\n", hinstDLL, fdwReason, lpvReserved); > > switch (fdwReason) > { > + case DLL_WINE_PREATTACH: > + return FALSE; /* prefer native version */ > + > case DLL_PROCESS_ATTACH: > init_cxx_funcs(); > init_lockit(); > msvcp90 has some wine specific exports. This patch breaks other msvcpXX dlls when native msvcp90 is installed.

3 5

GSoC 2013 - Registry Merging Project
by orzhvs May 17, 2013

May 17, 2013

Hi. I'm applying for the Google Summer of Code 2013, this is my proposal for the registry merging project. I'll work on improving Wine's registry in its stability and simulation to solve frequently seen non user-friendly problems, which usually caused by that application or system settings are not stored and fetched correctly. Project & My Understand: I'm most interested in the project "Registry - implement merging between HKEY_CLASSES_ROOT and HKEY_CURRENT_USER\Software\Classes". Its core task is to implement RegOpenUserClassesRoot, which returns a key token of merging view of HKCU & HKLM classes rather than present returning HKCR Classes. The difficulity is that as a view of two independent registry trees, how to treat conflicts and make changes to two seperated entrys when using HKCR as root, and how to achieve the function with no or least effect on other part of registry operation such as RegOpenKeyExX. I have some seed ideas that maybe not mature but I like solving problems initially from a burst port : Scheme 1. Registry operations based on hKey ( handle ) under HKEY_CLASSES_ROOT will be degeneration to full path in text, like "HKEY_CLASSES_ROOT\Subdir1", and try the operation after "HKEY_CLASSES_ROOT" replaced with "HKEY_CURRENT_USER\Software\Classes" and "HKEY_LOCAL_MACHINE\Software\Classes" in order, only the first success operation will be applied. This may satisfy the demand, both for query and modify. For details like the correct order, I'll make it out once get working on it. In this way, the HKCR key subtree does not exist in fact but only exists as a name. Scheme 2. After the base registry is initialized, build the HKCR's subkey trees with a new pulled in object type (say it 'symbol link') that directly point to the correct keys from HKLM or HKCU. Thus operation in HKCR tree are redirected to corresponding branch internally. When operating the HKCR itself, like creating new subkeys direct under HKCR, the operation is redirected to HKCU classes. This scheme seems more fluent but needs some tricks in the server part. What I'll Do : First of all I'll do a lot of tests on pure winows registry to definite my questions and guesses, write one or more test reports on different version of windows, some of which is already being done now. Followed by I will design the algorithms and data structures and make a complete development planation. Then enjoying coding and debuging Wine. I love the procedure, during the longest part of this project, keep writing daily report. Got the plan finished, I will applying improvement. Finally strict tests will be done to show if I achieved the final goal and a conclude paper will be carefully submitted. I'd like not only settle down the main project, but also several ideas to make Wine better, which are found in my daily use of Wine, such as add support for the shell context menu in Wine explorer for many convenient shotcuts of some software like the famous 7zip. I'll do this once time allows. Why Me : I myself is a faithful user of Wine. I know the thought of Wine and know not only basic usage but also a little implement of it. I understand Windows registry both Windows API pretty well from nearly 8 years coding. Have done much test and hooks in windows including RegXXX in advapi32.dll or lower level NtOpenKey in ntdll.dll. Further more, I used to do some kernel debug tests and hacks on registry, like hiding, protecting a subkey from regedit, resolving values from hive file rather than using API. These things are done under interests. I've been learning Windows API and OS theories from books and network like msdn for long. Ofcourse there will be no problem in registry knowledge. It's usual for me to write codes more than 1000 lines a day, for self use or for the competation ACM. I believe that I'm a careful man in codes and other things, I like discovering, guessing and proving. To prove I've developed a not too bad coding style, please refer to my submisions on codeforces http://codeforces.com/submissions/adnim (to view code click numbers under column "#"). And this may be a little evidence denoting that at least I've used git before, https://code.google.com/p/eryapass/ I know what should I do and what should not. I'm sure aware of the legal requirements. All of my tests will be done only in the black-box ways. No reverse work on Windows files is allowed and needed in Wine project, though I'm good at that. All codes will be written creatively and nothing will be copied from existing ones like WRK, RcactOS or something else. I love open source. I benefited much from the open source world and I'd be really happy to contribute to it one day. The last but most important, I'm much willing and I'm looking forward to throwing myself among the crowd of codes this entire summer, making maxium effort to improve Wine. I'd like schedule my personal activities to avoid conflicts with the development, meaning it won't be too busy in my schoolwork. Wine & Me : In my childhood, I've been coding in F-Basic on Subor (a kind of TV-based computer made in China) when friends are playing football in yard, at about 8 years old. When I was 12 years old, i was building some little games to happy classmates, and have learned c and c++ 2 years latter, then x86 asm 2 more years latter. And have done some graduation-designs for college brothers before I got to university. Also I've developed some projects for local companies. I first installed Ubuntu in 2010 and gradually I'm interested in open source projects. I'm 21 years old now, studying software engineering in Shandong University of Science and Technology in China. I'm a really enthusiastic user of Wine, who has been using it from version 1.2 to 1.4, on ubuntu, debian and gentoo. Since the first day I apt-got it I could not help trying all applications I used in Windows to it and making them running stably, during which I have learned much about configuring Wine. Another day I began to emerging that and I was once deep interested in building my customed Wine and Wine based tests. I heard about GSoC last year but missed the time. This year, I decided that I will try my best to contribute, transform my ideas to powerful codes that people will run with satisfaction. Please do not hesitate to contact me. Thanks. Guo Jian

3 9

gdi32: GetGlyphIndices doesn't substitute glyph incorrect
by Aric Stewart May 17, 2013

May 17, 2013

Hi there, I know I am a year late to the party here but I am digging deep into tategaki for a few Japanese programs that are having serious rendering issues and I believe that this patch is incorrect. I am attaching the test patch that proves it to me. Kusanagi-san, we should try to make sure that this does not break what it was that you where trying to fix with your original patch. -aric

2 4

Re: [PATCH 5/5] mshtml: Added whitespace parser tests.
by Marvin May 17, 2013

May 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25599 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] mshtml: Added parsing custom tag name tests.
by Marvin May 17, 2013

May 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25598 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0